blob: 2926e268190e3e00dfd23ce5949b94ff5ad3b8b7 [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements the visitICmp and visitFCmp functions.
11//
12//===----------------------------------------------------------------------===//
13
Chandler Carrutha9174582015-01-22 05:25:13 +000014#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000015#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000016#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000017#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000018#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000019#include "llvm/Analysis/InstructionSimplify.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000020#include "llvm/Analysis/TargetLibraryInfo.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000021#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000022#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000023#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000024#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000025#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000026#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000027#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000028
Chris Lattner2188e402010-01-04 07:37:31 +000029using namespace llvm;
30using namespace PatternMatch;
31
Chandler Carruth964daaa2014-04-22 02:55:47 +000032#define DEBUG_TYPE "instcombine"
33
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000034// How many times is a select replaced by one of its operands?
35STATISTIC(NumSel, "Number of select opts");
36
Chris Lattner98457102011-02-10 05:23:05 +000037
Sanjay Patel5f0217f2016-06-05 16:46:18 +000038/// Compute Result = In1+In2, returning true if the result overflowed for this
39/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000040static bool addWithOverflow(APInt &Result, const APInt &In1,
41 const APInt &In2, bool IsSigned = false) {
42 bool Overflow;
43 if (IsSigned)
44 Result = In1.sadd_ov(In2, Overflow);
45 else
46 Result = In1.uadd_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000047
Craig Topper6e025a32017-10-01 23:53:54 +000048 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000049}
50
Sanjay Patel5f0217f2016-06-05 16:46:18 +000051/// Compute Result = In1-In2, returning true if the result overflowed for this
52/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000053static bool subWithOverflow(APInt &Result, const APInt &In1,
54 const APInt &In2, bool IsSigned = false) {
55 bool Overflow;
56 if (IsSigned)
57 Result = In1.ssub_ov(In2, Overflow);
58 else
59 Result = In1.usub_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000060
Craig Topper6e025a32017-10-01 23:53:54 +000061 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000062}
63
Balaram Makam569eaec2016-05-04 21:32:14 +000064/// Given an icmp instruction, return true if any use of this comparison is a
65/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +000066static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +000067 for (auto *U : I.users())
68 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +000069 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +000070 return false;
71}
72
Sanjay Patel5f0217f2016-06-05 16:46:18 +000073/// Given an exploded icmp instruction, return true if the comparison only
74/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
75/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +000076static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +000077 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +000078 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +000079 case ICmpInst::ICMP_SLT: // True if LHS s< 0
80 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +000081 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +000082 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
83 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000084 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000085 case ICmpInst::ICMP_SGT: // True if LHS s> -1
86 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +000087 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000088 case ICmpInst::ICMP_UGT:
89 // True if LHS u> RHS and RHS == high-bit-mask - 1
90 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000091 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +000092 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +000093 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
94 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +000095 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +000096 default:
97 return false;
98 }
99}
100
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000101/// Returns true if the exploded icmp can be expressed as a signed comparison
102/// to zero and updates the predicate accordingly.
103/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000104/// TODO: Refactor with decomposeBitTestICmp()?
105static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000106 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000107 return false;
108
Craig Topper73ba1c82017-06-07 07:40:37 +0000109 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000110 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000111
Craig Topper73ba1c82017-06-07 07:40:37 +0000112 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000113 if (Pred == ICmpInst::ICMP_SLT) {
114 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000115 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000116 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000117 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000118 if (Pred == ICmpInst::ICMP_SGT) {
119 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000120 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000121 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000122 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000123
124 return false;
125}
126
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000127/// Given a signed integer type and a set of known zero and one bits, compute
128/// the maximum and minimum values that could have the specified known zero and
129/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000130/// TODO: Move to method on KnownBits struct?
131static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000132 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000133 assert(Known.getBitWidth() == Min.getBitWidth() &&
134 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000135 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000136 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000137
138 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
139 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000140 Min = Known.One;
141 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000142
Chris Lattner2188e402010-01-04 07:37:31 +0000143 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000144 Min.setSignBit();
145 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000146 }
147}
148
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000149/// Given an unsigned integer type and a set of known zero and one bits, compute
150/// the maximum and minimum values that could have the specified known zero and
151/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000152/// TODO: Move to method on KnownBits struct?
153static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000154 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000155 assert(Known.getBitWidth() == Min.getBitWidth() &&
156 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000157 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000158 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000159
Chris Lattner2188e402010-01-04 07:37:31 +0000160 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000161 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000162 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000163 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000164}
165
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000166/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000167/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000168/// where GV is a global variable with a constant initializer. Try to simplify
169/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000170/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
171///
172/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000173/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000174Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
175 GlobalVariable *GV,
176 CmpInst &ICI,
177 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000178 Constant *Init = GV->getInitializer();
179 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000180 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000181
Chris Lattnerfe741762012-01-31 02:55:06 +0000182 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000183 // Don't blow up on huge arrays.
184 if (ArrayElementCount > MaxArraySizeForCombine)
185 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000186
Chris Lattner2188e402010-01-04 07:37:31 +0000187 // There are many forms of this optimization we can handle, for now, just do
188 // the simple index into a single-dimensional array.
189 //
190 // Require: GEP GV, 0, i {{, constant indices}}
191 if (GEP->getNumOperands() < 3 ||
192 !isa<ConstantInt>(GEP->getOperand(1)) ||
193 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
194 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000195 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000196
197 // Check that indices after the variable are constants and in-range for the
198 // type they index. Collect the indices. This is typically for arrays of
199 // structs.
200 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000201
Chris Lattnerfe741762012-01-31 02:55:06 +0000202 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000203 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
204 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000205 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000206
Chris Lattner2188e402010-01-04 07:37:31 +0000207 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000208 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000209
Chris Lattner229907c2011-07-18 04:54:35 +0000210 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000211 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000212 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000213 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000214 EltTy = ATy->getElementType();
215 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000216 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000217 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000218
Chris Lattner2188e402010-01-04 07:37:31 +0000219 LaterIndices.push_back(IdxVal);
220 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000221
Chris Lattner2188e402010-01-04 07:37:31 +0000222 enum { Overdefined = -3, Undefined = -2 };
223
224 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000225
Chris Lattner2188e402010-01-04 07:37:31 +0000226 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
227 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
228 // and 87 is the second (and last) index. FirstTrueElement is -2 when
229 // undefined, otherwise set to the first true element. SecondTrueElement is
230 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
231 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
232
233 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
234 // form "i != 47 & i != 87". Same state transitions as for true elements.
235 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000236
Chris Lattner2188e402010-01-04 07:37:31 +0000237 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
238 /// define a state machine that triggers for ranges of values that the index
239 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
240 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
241 /// index in the range (inclusive). We use -2 for undefined here because we
242 /// use relative comparisons and don't want 0-1 to match -1.
243 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000244
Chris Lattner2188e402010-01-04 07:37:31 +0000245 // MagicBitvector - This is a magic bitvector where we set a bit if the
246 // comparison is true for element 'i'. If there are 64 elements or less in
247 // the array, this will fully represent all the comparison results.
248 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000249
Chris Lattner2188e402010-01-04 07:37:31 +0000250 // Scan the array and see if one of our patterns matches.
251 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000252 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
253 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000254 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000255
Chris Lattner2188e402010-01-04 07:37:31 +0000256 // If this is indexing an array of structures, get the structure element.
257 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000258 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000259
Chris Lattner2188e402010-01-04 07:37:31 +0000260 // If the element is masked, handle it.
261 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000262
Chris Lattner2188e402010-01-04 07:37:31 +0000263 // Find out if the comparison would be true or false for the i'th element.
264 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000265 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000266 // If the result is undef for this element, ignore it.
267 if (isa<UndefValue>(C)) {
268 // Extend range state machines to cover this element in case there is an
269 // undef in the middle of the range.
270 if (TrueRangeEnd == (int)i-1)
271 TrueRangeEnd = i;
272 if (FalseRangeEnd == (int)i-1)
273 FalseRangeEnd = i;
274 continue;
275 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000276
Chris Lattner2188e402010-01-04 07:37:31 +0000277 // If we can't compute the result for any of the elements, we have to give
278 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000279 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000280
Chris Lattner2188e402010-01-04 07:37:31 +0000281 // Otherwise, we know if the comparison is true or false for this element,
282 // update our state machines.
283 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000284
Chris Lattner2188e402010-01-04 07:37:31 +0000285 // State machine for single/double/range index comparison.
286 if (IsTrueForElt) {
287 // Update the TrueElement state machine.
288 if (FirstTrueElement == Undefined)
289 FirstTrueElement = TrueRangeEnd = i; // First true element.
290 else {
291 // Update double-compare state machine.
292 if (SecondTrueElement == Undefined)
293 SecondTrueElement = i;
294 else
295 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000296
Chris Lattner2188e402010-01-04 07:37:31 +0000297 // Update range state machine.
298 if (TrueRangeEnd == (int)i-1)
299 TrueRangeEnd = i;
300 else
301 TrueRangeEnd = Overdefined;
302 }
303 } else {
304 // Update the FalseElement state machine.
305 if (FirstFalseElement == Undefined)
306 FirstFalseElement = FalseRangeEnd = i; // First false element.
307 else {
308 // Update double-compare state machine.
309 if (SecondFalseElement == Undefined)
310 SecondFalseElement = i;
311 else
312 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000313
Chris Lattner2188e402010-01-04 07:37:31 +0000314 // Update range state machine.
315 if (FalseRangeEnd == (int)i-1)
316 FalseRangeEnd = i;
317 else
318 FalseRangeEnd = Overdefined;
319 }
320 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000321
Chris Lattner2188e402010-01-04 07:37:31 +0000322 // If this element is in range, update our magic bitvector.
323 if (i < 64 && IsTrueForElt)
324 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000325
Chris Lattner2188e402010-01-04 07:37:31 +0000326 // If all of our states become overdefined, bail out early. Since the
327 // predicate is expensive, only check it every 8 elements. This is only
328 // really useful for really huge arrays.
329 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
330 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
331 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000332 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000333 }
334
335 // Now that we've scanned the entire array, emit our new comparison(s). We
336 // order the state machines in complexity of the generated code.
337 Value *Idx = GEP->getOperand(2);
338
Matt Arsenault5aeae182013-08-19 21:40:31 +0000339 // If the index is larger than the pointer size of the target, truncate the
340 // index down like the GEP would do implicitly. We don't have to do this for
341 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000342 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000343 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000344 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
345 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000346 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000347 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000348
Chris Lattner2188e402010-01-04 07:37:31 +0000349 // If the comparison is only true for one or two elements, emit direct
350 // comparisons.
351 if (SecondTrueElement != Overdefined) {
352 // None true -> false.
353 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000354 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000355
Chris Lattner2188e402010-01-04 07:37:31 +0000356 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000357
Chris Lattner2188e402010-01-04 07:37:31 +0000358 // True for one element -> 'i == 47'.
359 if (SecondTrueElement == Undefined)
360 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000361
Chris Lattner2188e402010-01-04 07:37:31 +0000362 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000363 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000364 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000365 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000366 return BinaryOperator::CreateOr(C1, C2);
367 }
368
369 // If the comparison is only false for one or two elements, emit direct
370 // comparisons.
371 if (SecondFalseElement != Overdefined) {
372 // None false -> true.
373 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000374 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000375
Chris Lattner2188e402010-01-04 07:37:31 +0000376 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
377
378 // False for one element -> 'i != 47'.
379 if (SecondFalseElement == Undefined)
380 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000381
Chris Lattner2188e402010-01-04 07:37:31 +0000382 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000383 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000384 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000385 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000386 return BinaryOperator::CreateAnd(C1, C2);
387 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000388
Chris Lattner2188e402010-01-04 07:37:31 +0000389 // If the comparison can be replaced with a range comparison for the elements
390 // where it is true, emit the range check.
391 if (TrueRangeEnd != Overdefined) {
392 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000393
Chris Lattner2188e402010-01-04 07:37:31 +0000394 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
395 if (FirstTrueElement) {
396 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000397 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000398 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000399
Chris Lattner2188e402010-01-04 07:37:31 +0000400 Value *End = ConstantInt::get(Idx->getType(),
401 TrueRangeEnd-FirstTrueElement+1);
402 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
403 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000404
Chris Lattner2188e402010-01-04 07:37:31 +0000405 // False range check.
406 if (FalseRangeEnd != Overdefined) {
407 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
408 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
409 if (FirstFalseElement) {
410 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000411 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000412 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000413
Chris Lattner2188e402010-01-04 07:37:31 +0000414 Value *End = ConstantInt::get(Idx->getType(),
415 FalseRangeEnd-FirstFalseElement);
416 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
417 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000418
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000419 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000420 // of this load, replace it with computation that does:
421 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000422 {
Craig Topperf40110f2014-04-25 05:29:35 +0000423 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000424
425 // Look for an appropriate type:
426 // - The type of Idx if the magic fits
Craig Topper386fc252017-11-07 17:37:32 +0000427 // - The smallest fitting legal type
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000428 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
429 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000430 else
431 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000432
Craig Topperf40110f2014-04-25 05:29:35 +0000433 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000434 Value *V = Builder.CreateIntCast(Idx, Ty, false);
435 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
436 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000437 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
438 }
Chris Lattner2188e402010-01-04 07:37:31 +0000439 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000440
Craig Topperf40110f2014-04-25 05:29:35 +0000441 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000442}
443
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000444/// Return a value that can be used to compare the *offset* implied by a GEP to
445/// zero. For example, if we have &A[i], we want to return 'i' for
446/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
447/// are involved. The above expression would also be legal to codegen as
448/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
449/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000450/// to generate the first by knowing that pointer arithmetic doesn't overflow.
451///
452/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000453///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000454static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000455 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000456 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000457
Chris Lattner2188e402010-01-04 07:37:31 +0000458 // Check to see if this gep only has a single variable index. If so, and if
459 // any constant indices are a multiple of its scale, then we can compute this
460 // in terms of the scale of the variable index. For example, if the GEP
461 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
462 // because the expression will cross zero at the same point.
463 unsigned i, e = GEP->getNumOperands();
464 int64_t Offset = 0;
465 for (i = 1; i != e; ++i, ++GTI) {
466 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
467 // Compute the aggregate offset of constant indices.
468 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000469
Chris Lattner2188e402010-01-04 07:37:31 +0000470 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000471 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000472 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000473 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000474 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000475 Offset += Size*CI->getSExtValue();
476 }
477 } else {
478 // Found our variable index.
479 break;
480 }
481 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000482
Chris Lattner2188e402010-01-04 07:37:31 +0000483 // If there are no variable indices, we must have a constant offset, just
484 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000485 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000486
Chris Lattner2188e402010-01-04 07:37:31 +0000487 Value *VariableIdx = GEP->getOperand(i);
488 // Determine the scale factor of the variable element. For example, this is
489 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000490 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000491
Chris Lattner2188e402010-01-04 07:37:31 +0000492 // Verify that there are no other variable indices. If so, emit the hard way.
493 for (++i, ++GTI; i != e; ++i, ++GTI) {
494 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000495 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000496
Chris Lattner2188e402010-01-04 07:37:31 +0000497 // Compute the aggregate offset of constant indices.
498 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000499
Chris Lattner2188e402010-01-04 07:37:31 +0000500 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000501 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000502 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000503 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000504 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000505 Offset += Size*CI->getSExtValue();
506 }
507 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000508
Chris Lattner2188e402010-01-04 07:37:31 +0000509 // Okay, we know we have a single variable index, which must be a
510 // pointer/array/vector index. If there is no offset, life is simple, return
511 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000512 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000513 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000514 if (Offset == 0) {
515 // Cast to intptrty in case a truncation occurs. If an extension is needed,
516 // we don't need to bother extending: the extension won't affect where the
517 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000518 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000519 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000520 }
Chris Lattner2188e402010-01-04 07:37:31 +0000521 return VariableIdx;
522 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000523
Chris Lattner2188e402010-01-04 07:37:31 +0000524 // Otherwise, there is an index. The computation we will do will be modulo
525 // the pointer size, so get it.
526 uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000527
Chris Lattner2188e402010-01-04 07:37:31 +0000528 Offset &= PtrSizeMask;
529 VariableScale &= PtrSizeMask;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000530
Chris Lattner2188e402010-01-04 07:37:31 +0000531 // To do this transformation, any constant index must be a multiple of the
532 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
533 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
534 // multiple of the variable scale.
535 int64_t NewOffs = Offset / (int64_t)VariableScale;
536 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000537 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000538
Chris Lattner2188e402010-01-04 07:37:31 +0000539 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000540 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000541 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000542 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000543 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000544 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000545}
546
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000547/// Returns true if we can rewrite Start as a GEP with pointer Base
548/// and some integer offset. The nodes that need to be re-written
549/// for this transformation will be added to Explored.
550static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
551 const DataLayout &DL,
552 SetVector<Value *> &Explored) {
553 SmallVector<Value *, 16> WorkList(1, Start);
554 Explored.insert(Base);
555
556 // The following traversal gives us an order which can be used
557 // when doing the final transformation. Since in the final
558 // transformation we create the PHI replacement instructions first,
559 // we don't have to get them in any particular order.
560 //
561 // However, for other instructions we will have to traverse the
562 // operands of an instruction first, which means that we have to
563 // do a post-order traversal.
564 while (!WorkList.empty()) {
565 SetVector<PHINode *> PHIs;
566
567 while (!WorkList.empty()) {
568 if (Explored.size() >= 100)
569 return false;
570
571 Value *V = WorkList.back();
572
573 if (Explored.count(V) != 0) {
574 WorkList.pop_back();
575 continue;
576 }
577
578 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000579 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000580 // We've found some value that we can't explore which is different from
581 // the base. Therefore we can't do this transformation.
582 return false;
583
584 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
585 auto *CI = dyn_cast<CastInst>(V);
586 if (!CI->isNoopCast(DL))
587 return false;
588
589 if (Explored.count(CI->getOperand(0)) == 0)
590 WorkList.push_back(CI->getOperand(0));
591 }
592
593 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
594 // We're limiting the GEP to having one index. This will preserve
595 // the original pointer type. We could handle more cases in the
596 // future.
597 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
598 GEP->getType() != Start->getType())
599 return false;
600
601 if (Explored.count(GEP->getOperand(0)) == 0)
602 WorkList.push_back(GEP->getOperand(0));
603 }
604
605 if (WorkList.back() == V) {
606 WorkList.pop_back();
607 // We've finished visiting this node, mark it as such.
608 Explored.insert(V);
609 }
610
611 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000612 // We cannot transform PHIs on unsplittable basic blocks.
613 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
614 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000615 Explored.insert(PN);
616 PHIs.insert(PN);
617 }
618 }
619
620 // Explore the PHI nodes further.
621 for (auto *PN : PHIs)
622 for (Value *Op : PN->incoming_values())
623 if (Explored.count(Op) == 0)
624 WorkList.push_back(Op);
625 }
626
627 // Make sure that we can do this. Since we can't insert GEPs in a basic
628 // block before a PHI node, we can't easily do this transformation if
629 // we have PHI node users of transformed instructions.
630 for (Value *Val : Explored) {
631 for (Value *Use : Val->uses()) {
632
633 auto *PHI = dyn_cast<PHINode>(Use);
634 auto *Inst = dyn_cast<Instruction>(Val);
635
636 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
637 Explored.count(PHI) == 0)
638 continue;
639
640 if (PHI->getParent() == Inst->getParent())
641 return false;
642 }
643 }
644 return true;
645}
646
647// Sets the appropriate insert point on Builder where we can add
648// a replacement Instruction for V (if that is possible).
649static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
650 bool Before = true) {
651 if (auto *PHI = dyn_cast<PHINode>(V)) {
652 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
653 return;
654 }
655 if (auto *I = dyn_cast<Instruction>(V)) {
656 if (!Before)
657 I = &*std::next(I->getIterator());
658 Builder.SetInsertPoint(I);
659 return;
660 }
661 if (auto *A = dyn_cast<Argument>(V)) {
662 // Set the insertion point in the entry block.
663 BasicBlock &Entry = A->getParent()->getEntryBlock();
664 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
665 return;
666 }
667 // Otherwise, this is a constant and we don't need to set a new
668 // insertion point.
669 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
670}
671
672/// Returns a re-written value of Start as an indexed GEP using Base as a
673/// pointer.
674static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
675 const DataLayout &DL,
676 SetVector<Value *> &Explored) {
677 // Perform all the substitutions. This is a bit tricky because we can
678 // have cycles in our use-def chains.
679 // 1. Create the PHI nodes without any incoming values.
680 // 2. Create all the other values.
681 // 3. Add the edges for the PHI nodes.
682 // 4. Emit GEPs to get the original pointers.
683 // 5. Remove the original instructions.
684 Type *IndexType = IntegerType::get(
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000685 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000686
687 DenseMap<Value *, Value *> NewInsts;
688 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
689
690 // Create the new PHI nodes, without adding any incoming values.
691 for (Value *Val : Explored) {
692 if (Val == Base)
693 continue;
694 // Create empty phi nodes. This avoids cyclic dependencies when creating
695 // the remaining instructions.
696 if (auto *PHI = dyn_cast<PHINode>(Val))
697 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
698 PHI->getName() + ".idx", PHI);
699 }
700 IRBuilder<> Builder(Base->getContext());
701
702 // Create all the other instructions.
703 for (Value *Val : Explored) {
704
705 if (NewInsts.find(Val) != NewInsts.end())
706 continue;
707
708 if (auto *CI = dyn_cast<CastInst>(Val)) {
709 NewInsts[CI] = NewInsts[CI->getOperand(0)];
710 continue;
711 }
712 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
713 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
714 : GEP->getOperand(1);
715 setInsertionPoint(Builder, GEP);
716 // Indices might need to be sign extended. GEPs will magically do
717 // this, but we need to do it ourselves here.
718 if (Index->getType()->getScalarSizeInBits() !=
719 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
720 Index = Builder.CreateSExtOrTrunc(
721 Index, NewInsts[GEP->getOperand(0)]->getType(),
722 GEP->getOperand(0)->getName() + ".sext");
723 }
724
725 auto *Op = NewInsts[GEP->getOperand(0)];
Craig Topper781aa182018-05-05 01:57:00 +0000726 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero())
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000727 NewInsts[GEP] = Index;
728 else
729 NewInsts[GEP] = Builder.CreateNSWAdd(
730 Op, Index, GEP->getOperand(0)->getName() + ".add");
731 continue;
732 }
733 if (isa<PHINode>(Val))
734 continue;
735
736 llvm_unreachable("Unexpected instruction type");
737 }
738
739 // Add the incoming values to the PHI nodes.
740 for (Value *Val : Explored) {
741 if (Val == Base)
742 continue;
743 // All the instructions have been created, we can now add edges to the
744 // phi nodes.
745 if (auto *PHI = dyn_cast<PHINode>(Val)) {
746 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
747 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
748 Value *NewIncoming = PHI->getIncomingValue(I);
749
750 if (NewInsts.find(NewIncoming) != NewInsts.end())
751 NewIncoming = NewInsts[NewIncoming];
752
753 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
754 }
755 }
756 }
757
758 for (Value *Val : Explored) {
759 if (Val == Base)
760 continue;
761
762 // Depending on the type, for external users we have to emit
763 // a GEP or a GEP + ptrtoint.
764 setInsertionPoint(Builder, Val, false);
765
766 // If required, create an inttoptr instruction for Base.
767 Value *NewBase = Base;
768 if (!Base->getType()->isPointerTy())
769 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
770 Start->getName() + "to.ptr");
771
772 Value *GEP = Builder.CreateInBoundsGEP(
773 Start->getType()->getPointerElementType(), NewBase,
774 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
775
776 if (!Val->getType()->isPointerTy()) {
777 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
778 Val->getName() + ".conv");
779 GEP = Cast;
780 }
781 Val->replaceAllUsesWith(GEP);
782 }
783
784 return NewInsts[Start];
785}
786
787/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
788/// the input Value as a constant indexed GEP. Returns a pair containing
789/// the GEPs Pointer and Index.
790static std::pair<Value *, Value *>
791getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
792 Type *IndexType = IntegerType::get(V->getContext(),
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000793 DL.getIndexTypeSizeInBits(V->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000794
795 Constant *Index = ConstantInt::getNullValue(IndexType);
796 while (true) {
797 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
798 // We accept only inbouds GEPs here to exclude the possibility of
799 // overflow.
800 if (!GEP->isInBounds())
801 break;
802 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
803 GEP->getType() == V->getType()) {
804 V = GEP->getOperand(0);
805 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
806 Index = ConstantExpr::getAdd(
807 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
808 continue;
809 }
810 break;
811 }
812 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
813 if (!CI->isNoopCast(DL))
814 break;
815 V = CI->getOperand(0);
816 continue;
817 }
818 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
819 if (!CI->isNoopCast(DL))
820 break;
821 V = CI->getOperand(0);
822 continue;
823 }
824 break;
825 }
826 return {V, Index};
827}
828
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000829/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
830/// We can look through PHIs, GEPs and casts in order to determine a common base
831/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000832static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
833 ICmpInst::Predicate Cond,
834 const DataLayout &DL) {
835 if (!GEPLHS->hasAllConstantIndices())
836 return nullptr;
837
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000838 // Make sure the pointers have the same type.
839 if (GEPLHS->getType() != RHS->getType())
840 return nullptr;
841
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000842 Value *PtrBase, *Index;
843 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
844
845 // The set of nodes that will take part in this transformation.
846 SetVector<Value *> Nodes;
847
848 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
849 return nullptr;
850
851 // We know we can re-write this as
852 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
853 // Since we've only looked through inbouds GEPs we know that we
854 // can't have overflow on either side. We can therefore re-write
855 // this as:
856 // OFFSET1 cmp OFFSET2
857 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
858
859 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
860 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
861 // offset. Since Index is the offset of LHS to the base pointer, we will now
862 // compare the offsets instead of comparing the pointers.
863 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
864}
865
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000866/// Fold comparisons between a GEP instruction and something else. At this point
867/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000868Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000869 ICmpInst::Predicate Cond,
870 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000871 // Don't transform signed compares of GEPs into index compares. Even if the
872 // GEP is inbounds, the final add of the base pointer can have signed overflow
873 // and would change the result of the icmp.
874 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000875 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000876 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000877 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000878
Matt Arsenault44f60d02014-06-09 19:20:29 +0000879 // Look through bitcasts and addrspacecasts. We do not however want to remove
880 // 0 GEPs.
881 if (!isa<GetElementPtrInst>(RHS))
882 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000883
884 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000885 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000886 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
887 // This transformation (ignoring the base and scales) is valid because we
888 // know pointers can't overflow since the gep is inbounds. See if we can
889 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000890 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000891
Chris Lattner2188e402010-01-04 07:37:31 +0000892 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000893 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000894 Offset = EmitGEPOffset(GEPLHS);
895 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
896 Constant::getNullValue(Offset->getType()));
897 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
898 // If the base pointers are different, but the indices are the same, just
899 // compare the base pointer.
900 if (PtrBase != GEPRHS->getOperand(0)) {
901 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
902 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
903 GEPRHS->getOperand(0)->getType();
904 if (IndicesTheSame)
905 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
906 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
907 IndicesTheSame = false;
908 break;
909 }
910
911 // If all indices are the same, just compare the base pointers.
912 if (IndicesTheSame)
David Majnemer5953d372013-06-29 10:28:04 +0000913 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000914
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000915 // If we're comparing GEPs with two base pointers that only differ in type
916 // and both GEPs have only constant indices or just one use, then fold
917 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000918 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000919 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
920 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
921 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000922 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000923 Value *LOffset = EmitGEPOffset(GEPLHS);
924 Value *ROffset = EmitGEPOffset(GEPRHS);
925
926 // If we looked through an addrspacecast between different sized address
927 // spaces, the LHS and RHS pointers are different sized
928 // integers. Truncate to the smaller one.
929 Type *LHSIndexTy = LOffset->getType();
930 Type *RHSIndexTy = ROffset->getType();
931 if (LHSIndexTy != RHSIndexTy) {
932 if (LHSIndexTy->getPrimitiveSizeInBits() <
933 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000934 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000935 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000936 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000937 }
938
Craig Topperbb4069e2017-07-07 23:16:26 +0000939 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
940 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000941 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000942 }
943
Chris Lattner2188e402010-01-04 07:37:31 +0000944 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000945 // different. Try convert this to an indexed compare by looking through
946 // PHIs/casts.
947 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000948 }
949
950 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000951 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000952 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +0000953 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +0000954
955 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000956 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000957 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +0000958
Stuart Hastings66a82b92011-05-14 05:55:10 +0000959 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +0000960 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
961 // If the GEPs only differ by one index, compare it.
962 unsigned NumDifferences = 0; // Keep track of # differences.
963 unsigned DiffOperand = 0; // The operand that differs.
964 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
965 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
966 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
967 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
968 // Irreconcilable differences.
969 NumDifferences = 2;
970 break;
971 } else {
972 if (NumDifferences++) break;
973 DiffOperand = i;
974 }
975 }
976
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +0000977 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +0000978 return replaceInstUsesWith(I, // No comparison is needed here.
Craig Topperbb4069e2017-07-07 23:16:26 +0000979 Builder.getInt1(ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +0000980
Stuart Hastings66a82b92011-05-14 05:55:10 +0000981 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +0000982 Value *LHSV = GEPLHS->getOperand(DiffOperand);
983 Value *RHSV = GEPRHS->getOperand(DiffOperand);
984 // Make sure we do a signed comparison here.
985 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
986 }
987 }
988
989 // Only lower this if the icmp is the only user of the GEP or if we expect
990 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000991 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +0000992 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
993 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
994 Value *L = EmitGEPOffset(GEPLHS);
995 Value *R = EmitGEPOffset(GEPRHS);
996 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
997 }
998 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000999
1000 // Try convert this to an indexed compare by looking through PHIs/casts as a
1001 // last resort.
1002 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001003}
1004
Pete Cooper980a9352016-08-12 17:13:28 +00001005Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1006 const AllocaInst *Alloca,
1007 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001008 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1009
1010 // It would be tempting to fold away comparisons between allocas and any
1011 // pointer not based on that alloca (e.g. an argument). However, even
1012 // though such pointers cannot alias, they can still compare equal.
1013 //
1014 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1015 // doesn't escape we can argue that it's impossible to guess its value, and we
1016 // can therefore act as if any such guesses are wrong.
1017 //
1018 // The code below checks that the alloca doesn't escape, and that it's only
1019 // used in a comparison once (the current instruction). The
1020 // single-comparison-use condition ensures that we're trivially folding all
1021 // comparisons against the alloca consistently, and avoids the risk of
1022 // erroneously folding a comparison of the pointer with itself.
1023
1024 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1025
Pete Cooper980a9352016-08-12 17:13:28 +00001026 SmallVector<const Use *, 32> Worklist;
1027 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001028 if (Worklist.size() >= MaxIter)
1029 return nullptr;
1030 Worklist.push_back(&U);
1031 }
1032
1033 unsigned NumCmps = 0;
1034 while (!Worklist.empty()) {
1035 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001036 const Use *U = Worklist.pop_back_val();
1037 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001038 --MaxIter;
1039
1040 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1041 isa<SelectInst>(V)) {
1042 // Track the uses.
1043 } else if (isa<LoadInst>(V)) {
1044 // Loading from the pointer doesn't escape it.
1045 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001046 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001047 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1048 if (SI->getValueOperand() == U->get())
1049 return nullptr;
1050 continue;
1051 } else if (isa<ICmpInst>(V)) {
1052 if (NumCmps++)
1053 return nullptr; // Found more than one cmp.
1054 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001055 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001056 switch (Intrin->getIntrinsicID()) {
1057 // These intrinsics don't escape or compare the pointer. Memset is safe
1058 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1059 // we don't allow stores, so src cannot point to V.
1060 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001061 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1062 continue;
1063 default:
1064 return nullptr;
1065 }
1066 } else {
1067 return nullptr;
1068 }
Pete Cooper980a9352016-08-12 17:13:28 +00001069 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001070 if (Worklist.size() >= MaxIter)
1071 return nullptr;
1072 Worklist.push_back(&U);
1073 }
1074 }
1075
1076 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001077 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001078 ICI,
1079 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1080}
1081
Craig Topperbee74792018-08-20 23:04:25 +00001082/// Fold "icmp pred (X+C), X".
1083Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C,
Sanjay Patel43395062016-07-21 18:07:40 +00001084 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001085 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001086 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001087 // operators.
Craig Topperbee74792018-08-20 23:04:25 +00001088 assert(!!C && "C should not be zero!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00001089
Chris Lattner8c92b572010-01-08 17:48:19 +00001090 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001091 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1092 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1093 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Craig Topperbee74792018-08-20 23:04:25 +00001094 Constant *R = ConstantInt::get(X->getType(),
1095 APInt::getMaxValue(C.getBitWidth()) - C);
Chris Lattner2188e402010-01-04 07:37:31 +00001096 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1097 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001098
Chris Lattner2188e402010-01-04 07:37:31 +00001099 // (X+1) >u X --> X <u (0-1) --> X != 255
1100 // (X+2) >u X --> X <u (0-2) --> X <u 254
1101 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001102 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Craig Topperbee74792018-08-20 23:04:25 +00001103 return new ICmpInst(ICmpInst::ICMP_ULT, X,
1104 ConstantInt::get(X->getType(), -C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001105
Craig Topperbee74792018-08-20 23:04:25 +00001106 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth());
Chris Lattner2188e402010-01-04 07:37:31 +00001107
1108 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1109 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1110 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1111 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1112 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1113 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001114 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Craig Topperbee74792018-08-20 23:04:25 +00001115 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1116 ConstantInt::get(X->getType(), SMax - C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001117
Chris Lattner2188e402010-01-04 07:37:31 +00001118 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1119 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1120 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1121 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1122 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1123 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001124
Chris Lattner2188e402010-01-04 07:37:31 +00001125 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbee74792018-08-20 23:04:25 +00001126 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1127 ConstantInt::get(X->getType(), SMax - (C - 1)));
Chris Lattner2188e402010-01-04 07:37:31 +00001128}
1129
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001130/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1131/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1132/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1133Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1134 const APInt &AP1,
1135 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001136 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1137
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001138 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1139 if (I.getPredicate() == I.ICMP_NE)
1140 Pred = CmpInst::getInversePredicate(Pred);
1141 return new ICmpInst(Pred, LHS, RHS);
1142 };
1143
David Majnemer2abb8182014-10-25 07:13:13 +00001144 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001145 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001146 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001147
1148 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001149 if (IsAShr) {
1150 if (AP2.isAllOnesValue())
1151 return nullptr;
1152 if (AP2.isNegative() != AP1.isNegative())
1153 return nullptr;
1154 if (AP2.sgt(AP1))
1155 return nullptr;
1156 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001157
David Majnemerd2056022014-10-21 19:51:55 +00001158 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001159 // 'A' must be large enough to shift out the highest set bit.
1160 return getICmp(I.ICMP_UGT, A,
1161 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001162
David Majnemerd2056022014-10-21 19:51:55 +00001163 if (AP1 == AP2)
1164 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001165
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001166 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001167 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001168 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001169 else
David Majnemere5977eb2015-09-19 00:48:26 +00001170 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001171
David Majnemerd2056022014-10-21 19:51:55 +00001172 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001173 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1174 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001175 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001176 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1177 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001178 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001179 } else if (AP1 == AP2.lshr(Shift)) {
1180 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1181 }
David Majnemerd2056022014-10-21 19:51:55 +00001182 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001183
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001184 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001185 // FIXME: This should always be handled by InstSimplify?
1186 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1187 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001188}
Chris Lattner2188e402010-01-04 07:37:31 +00001189
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001190/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1191/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1192Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1193 const APInt &AP1,
1194 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001195 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1196
David Majnemer59939ac2014-10-19 08:23:08 +00001197 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1198 if (I.getPredicate() == I.ICMP_NE)
1199 Pred = CmpInst::getInversePredicate(Pred);
1200 return new ICmpInst(Pred, LHS, RHS);
1201 };
1202
David Majnemer2abb8182014-10-25 07:13:13 +00001203 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001204 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001205 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001206
1207 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1208
1209 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001210 return getICmp(
1211 I.ICMP_UGE, A,
1212 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001213
1214 if (AP1 == AP2)
1215 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1216
1217 // Get the distance between the lowest bits that are set.
1218 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1219
1220 if (Shift > 0 && AP2.shl(Shift) == AP1)
1221 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1222
1223 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001224 // FIXME: This should always be handled by InstSimplify?
1225 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1226 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001227}
1228
Sanjay Patel06b127a2016-09-15 14:37:50 +00001229/// The caller has matched a pattern of the form:
1230/// I = icmp ugt (add (add A, B), CI2), CI1
1231/// If this is of the form:
1232/// sum = a + b
1233/// if (sum+128 >u 255)
1234/// Then replace it with llvm.sadd.with.overflow.i8.
1235///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001236static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001237 ConstantInt *CI2, ConstantInt *CI1,
1238 InstCombiner &IC) {
1239 // The transformation we're trying to do here is to transform this into an
1240 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1241 // with a narrower add, and discard the add-with-constant that is part of the
1242 // range check (if we can't eliminate it, this isn't profitable).
1243
1244 // In order to eliminate the add-with-constant, the compare can be its only
1245 // use.
1246 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1247 if (!AddWithCst->hasOneUse())
1248 return nullptr;
1249
1250 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1251 if (!CI2->getValue().isPowerOf2())
1252 return nullptr;
1253 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1254 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1255 return nullptr;
1256
1257 // The width of the new add formed is 1 more than the bias.
1258 ++NewWidth;
1259
1260 // Check to see that CI1 is an all-ones value with NewWidth bits.
1261 if (CI1->getBitWidth() == NewWidth ||
1262 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1263 return nullptr;
1264
1265 // This is only really a signed overflow check if the inputs have been
1266 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1267 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1268 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1269 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1270 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1271 return nullptr;
1272
1273 // In order to replace the original add with a narrower
1274 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1275 // and truncates that discard the high bits of the add. Verify that this is
1276 // the case.
1277 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1278 for (User *U : OrigAdd->users()) {
1279 if (U == AddWithCst)
1280 continue;
1281
1282 // Only accept truncates for now. We would really like a nice recursive
1283 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1284 // chain to see which bits of a value are actually demanded. If the
1285 // original add had another add which was then immediately truncated, we
1286 // could still do the transformation.
1287 TruncInst *TI = dyn_cast<TruncInst>(U);
1288 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1289 return nullptr;
1290 }
1291
1292 // If the pattern matches, truncate the inputs to the narrower type and
1293 // use the sadd_with_overflow intrinsic to efficiently compute both the
1294 // result and the overflow bit.
1295 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
1296 Value *F = Intrinsic::getDeclaration(I.getModule(),
1297 Intrinsic::sadd_with_overflow, NewType);
1298
Craig Topperbb4069e2017-07-07 23:16:26 +00001299 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001300
1301 // Put the new code above the original add, in case there are any uses of the
1302 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001303 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001304
Craig Topperbb4069e2017-07-07 23:16:26 +00001305 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1306 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1307 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1308 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1309 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001310
1311 // The inner add was the result of the narrow add, zero extended to the
1312 // wider type. Replace it with the result computed by the intrinsic.
1313 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1314
1315 // The original icmp gets replaced with the overflow value.
1316 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1317}
1318
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001319// Handle (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
1320Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) {
1321 CmpInst::Predicate Pred = Cmp.getPredicate();
1322 Value *X = Cmp.getOperand(0);
1323
1324 if (match(Cmp.getOperand(1), m_Zero()) && Pred == ICmpInst::ICMP_SGT) {
1325 Value *A, *B;
1326 SelectPatternResult SPR = matchSelectPattern(X, A, B);
1327 if (SPR.Flavor == SPF_SMIN) {
1328 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
1329 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1330 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
1331 return new ICmpInst(Pred, A, Cmp.getOperand(1));
1332 }
1333 }
1334 return nullptr;
1335}
1336
Sanjay Patel06b127a2016-09-15 14:37:50 +00001337// Fold icmp Pred X, C.
Sanjay Patel97459832016-09-15 15:11:12 +00001338Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
1339 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001340 Value *X = Cmp.getOperand(0);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001341
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001342 const APInt *C;
1343 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel97459832016-09-15 15:11:12 +00001344 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001345
Sanjay Patel97459832016-09-15 15:11:12 +00001346 Value *A = nullptr, *B = nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001347
Sanjay Patel97459832016-09-15 15:11:12 +00001348 // Match the following pattern, which is a common idiom when writing
1349 // overflow-safe integer arithmetic functions. The source performs an addition
1350 // in wider type and explicitly checks for overflow using comparisons against
1351 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1352 //
1353 // TODO: This could probably be generalized to handle other overflow-safe
1354 // operations if we worked out the formulas to compute the appropriate magic
1355 // constants.
1356 //
1357 // sum = a + b
1358 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
1359 {
1360 ConstantInt *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1361 if (Pred == ICmpInst::ICMP_UGT &&
1362 match(X, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001363 if (Instruction *Res = processUGT_ADDCST_ADD(
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001364 Cmp, A, B, CI2, cast<ConstantInt>(Cmp.getOperand(1)), *this))
Sanjay Patel97459832016-09-15 15:11:12 +00001365 return Res;
1366 }
Sanjay Patel06b127a2016-09-15 14:37:50 +00001367
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001368 // FIXME: Use m_APInt to allow folds for splat constants.
1369 ConstantInt *CI = dyn_cast<ConstantInt>(Cmp.getOperand(1));
1370 if (!CI)
1371 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001372
Sanjay Patel97459832016-09-15 15:11:12 +00001373 // Canonicalize icmp instructions based on dominating conditions.
1374 BasicBlock *Parent = Cmp.getParent();
1375 BasicBlock *Dom = Parent->getSinglePredecessor();
1376 auto *BI = Dom ? dyn_cast<BranchInst>(Dom->getTerminator()) : nullptr;
1377 ICmpInst::Predicate Pred2;
1378 BasicBlock *TrueBB, *FalseBB;
1379 ConstantInt *CI2;
1380 if (BI && match(BI, m_Br(m_ICmp(Pred2, m_Specific(X), m_ConstantInt(CI2)),
1381 TrueBB, FalseBB)) &&
1382 TrueBB != FalseBB) {
1383 ConstantRange CR =
1384 ConstantRange::makeAllowedICmpRegion(Pred, CI->getValue());
1385 ConstantRange DominatingCR =
1386 (Parent == TrueBB)
1387 ? ConstantRange::makeExactICmpRegion(Pred2, CI2->getValue())
1388 : ConstantRange::makeExactICmpRegion(
1389 CmpInst::getInversePredicate(Pred2), CI2->getValue());
1390 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1391 ConstantRange Difference = DominatingCR.difference(CR);
1392 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001393 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001394 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001395 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001396
Sanjay Patel97459832016-09-15 15:11:12 +00001397 // If this is a normal comparison, it demands all bits. If it is a sign
1398 // bit comparison, it only demands the sign bit.
1399 bool UnusedBit;
1400 bool IsSignBit = isSignBitCheck(Pred, CI->getValue(), UnusedBit);
1401
1402 // Canonicalizing a sign bit comparison that gets used in a branch,
1403 // pessimizes codegen by generating branch on zero instruction instead
1404 // of a test and branch. So we avoid canonicalizing in such situations
1405 // because test and branch instruction has better branch displacement
1406 // than compare and branch instruction.
Eric Christophera95aac32017-06-30 01:57:48 +00001407 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1408 return nullptr;
1409
1410 if (auto *AI = Intersection.getSingleElement())
Craig Topperbb4069e2017-07-07 23:16:26 +00001411 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*AI));
Eric Christophera95aac32017-06-30 01:57:48 +00001412 if (auto *AD = Difference.getSingleElement())
Craig Topperbb4069e2017-07-07 23:16:26 +00001413 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*AD));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001414 }
1415
1416 return nullptr;
1417}
1418
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001419/// Fold icmp (trunc X, Y), C.
1420Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001421 TruncInst *Trunc,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001422 const APInt &C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001423 ICmpInst::Predicate Pred = Cmp.getPredicate();
1424 Value *X = Trunc->getOperand(0);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001425 if (C.isOneValue() && C.getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001426 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1427 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001428 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001429 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1430 ConstantInt::get(V->getType(), 1));
1431 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001432
1433 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001434 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1435 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001436 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1437 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001438 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001439
1440 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001441 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001442 // Pull in the high bits from known-ones set.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001443 APInt NewRHS = C.zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001444 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001445 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001446 }
1447 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001448
Sanjay Patela3f4f082016-08-16 17:54:36 +00001449 return nullptr;
1450}
1451
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001452/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001453Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1454 BinaryOperator *Xor,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001455 const APInt &C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001456 Value *X = Xor->getOperand(0);
1457 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001458 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001459 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001460 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001461
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001462 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1463 // fold the xor.
1464 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topperdf63b962017-10-03 19:14:23 +00001465 bool TrueIfSigned = false;
1466 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001467
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001468 // If the sign bit of the XorCst is not set, there is no change to
1469 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001470 if (!XorC->isNegative()) {
1471 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001472 Worklist.Add(Xor);
1473 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001474 }
1475
Craig Topperdf63b962017-10-03 19:14:23 +00001476 // Emit the opposite comparison.
1477 if (TrueIfSigned)
1478 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1479 ConstantInt::getAllOnesValue(X->getType()));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001480 else
Craig Topperdf63b962017-10-03 19:14:23 +00001481 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1482 ConstantInt::getNullValue(X->getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001483 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001484
1485 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001486 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1487 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001488 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1489 : Cmp.getSignedPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001490 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001491 }
1492
Craig Topperbcfd2d12017-04-20 16:56:25 +00001493 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001494 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1495 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1496 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001497 Pred = Cmp.getSwappedPredicate(Pred);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001498 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001499 }
1500 }
1501
1502 // (icmp ugt (xor X, C), ~C) -> (icmp ult X, C)
1503 // iff -C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001504 if (Pred == ICmpInst::ICMP_UGT && *XorC == ~C && (C + 1).isPowerOf2())
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001505 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001506
1507 // (icmp ult (xor X, C), -C) -> (icmp uge X, C)
1508 // iff -C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001509 if (Pred == ICmpInst::ICMP_ULT && *XorC == -C && C.isPowerOf2())
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001510 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001511
Sanjay Patela3f4f082016-08-16 17:54:36 +00001512 return nullptr;
1513}
1514
Sanjay Patel14e0e182016-08-26 18:28:46 +00001515/// Fold icmp (and (sh X, Y), C2), C1.
1516Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001517 const APInt &C1, const APInt &C2) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001518 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1519 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001520 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001521
Sanjay Patelda9c5622016-08-26 17:15:22 +00001522 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1523 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1524 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001525 // This seemingly simple opportunity to fold away a shift turns out to be
1526 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001527 unsigned ShiftOpcode = Shift->getOpcode();
1528 bool IsShl = ShiftOpcode == Instruction::Shl;
1529 const APInt *C3;
1530 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001531 bool CanFold = false;
Craig Topper7a930922017-10-04 23:06:13 +00001532 if (ShiftOpcode == Instruction::Shl) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001533 // For a left shift, we can fold if the comparison is not signed. We can
1534 // also fold a signed comparison if the mask value and comparison value
1535 // are not negative. These constraints may not be obvious, but we can
1536 // prove that they are correct using an SMT solver.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001537 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001538 CanFold = true;
Craig Topper7a930922017-10-04 23:06:13 +00001539 } else {
1540 bool IsAshr = ShiftOpcode == Instruction::AShr;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001541 // For a logical right shift, we can fold if the comparison is not signed.
1542 // We can also fold a signed comparison if the shifted mask value and the
1543 // shifted comparison value are not negative. These constraints may not be
1544 // obvious, but we can prove that they are correct using an SMT solver.
Craig Topper7a930922017-10-04 23:06:13 +00001545 // For an arithmetic shift right we can do the same, if we ensure
1546 // the And doesn't use any bits being shifted in. Normally these would
1547 // be turned into lshr by SimplifyDemandedBits, but not if there is an
1548 // additional user.
1549 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) {
1550 if (!Cmp.isSigned() ||
1551 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative()))
1552 CanFold = true;
1553 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001554 }
1555
Sanjay Patelda9c5622016-08-26 17:15:22 +00001556 if (CanFold) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001557 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001558 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001559 // Check to see if we are shifting out any of the bits being compared.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001560 if (SameAsC1 != C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001561 // If we shifted bits out, the fold is not going to work out. As a
1562 // special case, check to see if this means that the result is always
1563 // true or false now.
1564 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001565 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001566 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001567 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001568 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001569 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
Craig Topper8ed1aa92017-10-03 05:31:07 +00001570 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001571 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001572 And->setOperand(0, Shift->getOperand(0));
1573 Worklist.Add(Shift); // Shift is dead.
1574 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001575 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001576 }
1577 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001578
Sanjay Patelda9c5622016-08-26 17:15:22 +00001579 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1580 // preferable because it allows the C2 << Y expression to be hoisted out of a
1581 // loop if Y is invariant and X is not.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001582 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001583 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1584 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001585 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001586 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1587 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001588
Sanjay Patelda9c5622016-08-26 17:15:22 +00001589 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001590 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001591 Cmp.setOperand(0, NewAnd);
1592 return &Cmp;
1593 }
1594
Sanjay Patel14e0e182016-08-26 18:28:46 +00001595 return nullptr;
1596}
1597
1598/// Fold icmp (and X, C2), C1.
1599Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1600 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001601 const APInt &C1) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001602 const APInt *C2;
1603 if (!match(And->getOperand(1), m_APInt(C2)))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001604 return nullptr;
1605
Craig Topper8bf62212017-09-26 18:47:25 +00001606 if (!And->hasOneUse())
Sanjay Patel14e0e182016-08-26 18:28:46 +00001607 return nullptr;
1608
Sanjay Patel6b490972016-09-04 14:32:15 +00001609 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1610 // the input width without changing the value produced, eliminate the cast:
1611 //
1612 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1613 //
1614 // We can do this transformation if the constants do not have their sign bits
1615 // set or if it is an equality comparison. Extending a relational comparison
1616 // when we're checking the sign bit would not work.
1617 Value *W;
Craig Topper8bf62212017-09-26 18:47:25 +00001618 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001619 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001620 // TODO: Is this a good transform for vectors? Wider types may reduce
1621 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001622 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001623 if (!Cmp.getType()->isVectorTy()) {
1624 Type *WideType = W->getType();
1625 unsigned WideScalarBits = WideType->getScalarSizeInBits();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001626 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits));
Sanjay Patel6b490972016-09-04 14:32:15 +00001627 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001628 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001629 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001630 }
1631 }
1632
Craig Topper8ed1aa92017-10-03 05:31:07 +00001633 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001634 return I;
1635
Sanjay Patelda9c5622016-08-26 17:15:22 +00001636 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001637 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001638 //
1639 // iff pred isn't signed
Craig Topper8ed1aa92017-10-03 05:31:07 +00001640 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() &&
Craig Topper73ba1c82017-06-07 07:40:37 +00001641 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001642 Constant *One = cast<Constant>(And->getOperand(1));
1643 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001644 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001645 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1646 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1647 unsigned UsesRemoved = 0;
1648 if (And->hasOneUse())
1649 ++UsesRemoved;
1650 if (Or->hasOneUse())
1651 ++UsesRemoved;
1652 if (LShr->hasOneUse())
1653 ++UsesRemoved;
1654
1655 // Compute A & ((1 << B) | 1)
1656 Value *NewOr = nullptr;
1657 if (auto *C = dyn_cast<Constant>(B)) {
1658 if (UsesRemoved >= 1)
1659 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1660 } else {
1661 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001662 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1663 /*HasNUW=*/true),
1664 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001665 }
1666 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001667 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001668 Cmp.setOperand(0, NewAnd);
1669 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001670 }
1671 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001672 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001673
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001674 return nullptr;
1675}
1676
1677/// Fold icmp (and X, Y), C.
1678Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1679 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001680 const APInt &C) {
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001681 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1682 return I;
1683
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001684 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001685
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001686 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1687 Value *X = And->getOperand(0);
1688 Value *Y = And->getOperand(1);
1689 if (auto *LI = dyn_cast<LoadInst>(X))
1690 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1691 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001692 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001693 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1694 ConstantInt *C2 = cast<ConstantInt>(Y);
1695 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001696 return Res;
1697 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001698
1699 if (!Cmp.isEquality())
1700 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001701
1702 // X & -C == -C -> X > u ~C
1703 // X & -C != -C -> X <= u ~C
1704 // iff C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001705 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001706 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1707 : CmpInst::ICMP_ULE;
1708 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1709 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001710
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001711 // (X & C2) == 0 -> (trunc X) >= 0
1712 // (X & C2) != 0 -> (trunc X) < 0
1713 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1714 const APInt *C2;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001715 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001716 int32_t ExactLogBase2 = C2->exactLogBase2();
1717 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1718 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1719 if (And->getType()->isVectorTy())
1720 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001721 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001722 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1723 : CmpInst::ICMP_SLT;
1724 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001725 }
1726 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001727
Sanjay Patela3f4f082016-08-16 17:54:36 +00001728 return nullptr;
1729}
1730
Sanjay Patel943e92e2016-08-17 16:30:43 +00001731/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001732Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001733 const APInt &C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001734 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001735 if (C.isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001736 // icmp slt signum(V) 1 --> icmp slt V, 1
1737 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001738 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001739 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1740 ConstantInt::get(V->getType(), 1));
1741 }
1742
Sanjay Patel50c82c42017-04-05 17:57:05 +00001743 // X | C == C --> X <=u C
1744 // X | C != C --> X >u C
1745 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1746 if (Cmp.isEquality() && Cmp.getOperand(1) == Or->getOperand(1) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001747 (C + 1).isPowerOf2()) {
Sanjay Patel50c82c42017-04-05 17:57:05 +00001748 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1749 return new ICmpInst(Pred, Or->getOperand(0), Or->getOperand(1));
1750 }
1751
Craig Topper8ed1aa92017-10-03 05:31:07 +00001752 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001753 return nullptr;
1754
1755 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001756 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001757 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1758 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001759 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001760 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001761 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001762 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001763 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1764 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1765 }
1766
1767 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1768 // a shorter form that has more potential to be folded even further.
1769 Value *X1, *X2, *X3, *X4;
1770 if (match(Or->getOperand(0), m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1771 match(Or->getOperand(1), m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
1772 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1773 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1774 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1775 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1776 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1777 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001778 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001779
Sanjay Patela3f4f082016-08-16 17:54:36 +00001780 return nullptr;
1781}
1782
Sanjay Patel63478072016-08-18 15:44:44 +00001783/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001784Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1785 BinaryOperator *Mul,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001786 const APInt &C) {
Sanjay Patel63478072016-08-18 15:44:44 +00001787 const APInt *MulC;
1788 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001789 return nullptr;
1790
Sanjay Patel63478072016-08-18 15:44:44 +00001791 // If this is a test of the sign bit and the multiply is sign-preserving with
1792 // a constant operand, use the multiply LHS operand instead.
1793 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001794 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001795 if (MulC->isNegative())
1796 Pred = ICmpInst::getSwappedPredicate(Pred);
1797 return new ICmpInst(Pred, Mul->getOperand(0),
1798 Constant::getNullValue(Mul->getType()));
1799 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001800
1801 return nullptr;
1802}
1803
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001804/// Fold icmp (shl 1, Y), C.
1805static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001806 const APInt &C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001807 Value *Y;
1808 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1809 return nullptr;
1810
1811 Type *ShiftType = Shl->getType();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001812 unsigned TypeBits = C.getBitWidth();
1813 bool CIsPowerOf2 = C.isPowerOf2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001814 ICmpInst::Predicate Pred = Cmp.getPredicate();
1815 if (Cmp.isUnsigned()) {
1816 // (1 << Y) pred C -> Y pred Log2(C)
1817 if (!CIsPowerOf2) {
1818 // (1 << Y) < 30 -> Y <= 4
1819 // (1 << Y) <= 30 -> Y <= 4
1820 // (1 << Y) >= 30 -> Y > 4
1821 // (1 << Y) > 30 -> Y > 4
1822 if (Pred == ICmpInst::ICMP_ULT)
1823 Pred = ICmpInst::ICMP_ULE;
1824 else if (Pred == ICmpInst::ICMP_UGE)
1825 Pred = ICmpInst::ICMP_UGT;
1826 }
1827
1828 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1829 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
Craig Topper8ed1aa92017-10-03 05:31:07 +00001830 unsigned CLog2 = C.logBase2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001831 if (CLog2 == TypeBits - 1) {
1832 if (Pred == ICmpInst::ICMP_UGE)
1833 Pred = ICmpInst::ICMP_EQ;
1834 else if (Pred == ICmpInst::ICMP_ULT)
1835 Pred = ICmpInst::ICMP_NE;
1836 }
1837 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1838 } else if (Cmp.isSigned()) {
1839 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001840 if (C.isAllOnesValue()) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001841 // (1 << Y) <= -1 -> Y == 31
1842 if (Pred == ICmpInst::ICMP_SLE)
1843 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1844
1845 // (1 << Y) > -1 -> Y != 31
1846 if (Pred == ICmpInst::ICMP_SGT)
1847 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001848 } else if (!C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001849 // (1 << Y) < 0 -> Y == 31
1850 // (1 << Y) <= 0 -> Y == 31
1851 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1852 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1853
1854 // (1 << Y) >= 0 -> Y != 31
1855 // (1 << Y) > 0 -> Y != 31
1856 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1857 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1858 }
1859 } else if (Cmp.isEquality() && CIsPowerOf2) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001860 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2()));
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001861 }
1862
1863 return nullptr;
1864}
1865
Sanjay Patel38b75062016-08-19 17:20:37 +00001866/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001867Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1868 BinaryOperator *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001869 const APInt &C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001870 const APInt *ShiftVal;
1871 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00001872 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001873
Sanjay Patelfa7de602016-08-19 22:33:26 +00001874 const APInt *ShiftAmt;
1875 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00001876 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00001877
Sanjay Patel38b75062016-08-19 17:20:37 +00001878 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00001879 // shifts. When the shift is visited, it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001880 unsigned TypeBits = C.getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00001881 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001882 return nullptr;
1883
Sanjay Patele38e79c2016-08-19 17:34:05 +00001884 ICmpInst::Predicate Pred = Cmp.getPredicate();
1885 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00001886 Type *ShType = Shl->getType();
1887
Sanjay Patel291c3d82017-01-19 16:12:10 +00001888 // NSW guarantees that we are only shifting out sign bits from the high bits,
1889 // so we can ASHR the compare constant without needing a mask and eliminate
1890 // the shift.
1891 if (Shl->hasNoSignedWrap()) {
1892 if (Pred == ICmpInst::ICMP_SGT) {
1893 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001894 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001895 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1896 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00001897 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
1898 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001899 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001900 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1901 }
1902 if (Pred == ICmpInst::ICMP_SLT) {
1903 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
1904 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
1905 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
1906 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
Craig Topper8ed1aa92017-10-03 05:31:07 +00001907 assert(!C.isMinSignedValue() && "Unexpected icmp slt");
1908 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1;
Sanjay Patel291c3d82017-01-19 16:12:10 +00001909 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1910 }
1911 // If this is a signed comparison to 0 and the shift is sign preserving,
1912 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
1913 // do that if we're sure to not continue on in this function.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001914 if (isSignTest(Pred, C))
Sanjay Patel291c3d82017-01-19 16:12:10 +00001915 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
1916 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001917
Sanjay Patel291c3d82017-01-19 16:12:10 +00001918 // NUW guarantees that we are only shifting out zero bits from the high bits,
1919 // so we can LSHR the compare constant without needing a mask and eliminate
1920 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00001921 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00001922 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00001923 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001924 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patel14715b32017-01-17 21:25:16 +00001925 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1926 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00001927 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
1928 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001929 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patelae23d652017-01-18 21:16:12 +00001930 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1931 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001932 if (Pred == ICmpInst::ICMP_ULT) {
1933 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
1934 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
1935 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
1936 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
Craig Topper8ed1aa92017-10-03 05:31:07 +00001937 assert(C.ugt(0) && "ult 0 should have been eliminated");
1938 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1;
Sanjay Patel14715b32017-01-17 21:25:16 +00001939 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1940 }
1941 }
1942
Sanjay Patel291c3d82017-01-19 16:12:10 +00001943 if (Cmp.isEquality() && Shl->hasOneUse()) {
1944 // Strength-reduce the shift into an 'and'.
1945 Constant *Mask = ConstantInt::get(
1946 ShType,
1947 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00001948 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Craig Topper8ed1aa92017-10-03 05:31:07 +00001949 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00001950 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001951 }
1952
Sanjay Patela3f4f082016-08-16 17:54:36 +00001953 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
1954 bool TrueIfSigned = false;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001955 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00001956 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00001957 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00001958 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00001959 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00001960 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00001961 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00001962 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00001963 }
1964
Sanjay Patel643d21a2016-08-21 17:10:07 +00001965 // Transform (icmp pred iM (shl iM %v, N), C)
1966 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
1967 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00001968 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00001969 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00001970 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00001971 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001972 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt &&
Sanjay Patelf3dda132016-10-25 20:11:47 +00001973 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00001974 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00001975 if (ShType->isVectorTy())
1976 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00001977 Constant *NewC =
Craig Topper8ed1aa92017-10-03 05:31:07 +00001978 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00001979 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001980 }
1981
1982 return nullptr;
1983}
1984
Sanjay Patela3920492016-08-22 20:45:06 +00001985/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001986Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
1987 BinaryOperator *Shr,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001988 const APInt &C) {
Sanjay Patela3920492016-08-22 20:45:06 +00001989 // An exact shr only shifts out zero bits, so:
1990 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00001991 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00001992 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00001993 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001994 C.isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00001995 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00001996
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001997 const APInt *ShiftVal;
1998 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00001999 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002000
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002001 const APInt *ShiftAmt;
2002 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002003 return nullptr;
2004
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002005 // Check that the shift amount is in range. If not, don't perform undefined
2006 // shifts. When the shift is visited it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002007 unsigned TypeBits = C.getBitWidth();
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002008 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002009 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2010 return nullptr;
2011
Sanjay Pateld64e9882016-08-23 22:05:55 +00002012 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002013 bool IsExact = Shr->isExact();
2014 Type *ShrTy = Shr->getType();
2015 // TODO: If we could guarantee that InstSimplify would handle all of the
2016 // constant-value-based preconditions in the folds below, then we could assert
2017 // those conditions rather than checking them. This is difficult because of
2018 // undef/poison (PR34838).
2019 if (IsAShr) {
2020 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) {
2021 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC)
2022 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC)
2023 APInt ShiftedC = C.shl(ShAmtVal);
2024 if (ShiftedC.ashr(ShAmtVal) == C)
2025 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2026 }
2027 if (Pred == CmpInst::ICMP_SGT) {
2028 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1
2029 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2030 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() &&
2031 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1))
2032 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2033 }
2034 } else {
2035 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) {
2036 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC)
2037 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC)
2038 APInt ShiftedC = C.shl(ShAmtVal);
2039 if (ShiftedC.lshr(ShAmtVal) == C)
2040 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2041 }
2042 if (Pred == CmpInst::ICMP_UGT) {
2043 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1
2044 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2045 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1))
2046 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2047 }
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002048 }
2049
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002050 if (!Cmp.isEquality())
2051 return nullptr;
2052
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002053 // Handle equality comparisons of shift-by-constant.
2054
Sanjay Patel8e297742016-08-24 13:55:55 +00002055 // If the comparison constant changes with the shift, the comparison cannot
2056 // succeed (bits of the comparison constant cannot match the shifted value).
2057 // This should be known by InstSimplify and already be folded to true/false.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002058 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) ||
2059 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) &&
Sanjay Patel8e297742016-08-24 13:55:55 +00002060 "Expected icmp+shr simplify did not occur.");
2061
Sanjay Patel934738a2017-10-15 15:39:15 +00002062 // If the bits shifted out are known zero, compare the unshifted value:
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002063 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Patel934738a2017-10-15 15:39:15 +00002064 if (Shr->isExact())
Sanjay Patel42135be2017-10-16 14:47:24 +00002065 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Patelf11b5b42017-10-05 14:26:15 +00002066
Sanjay Patel934738a2017-10-15 15:39:15 +00002067 if (Shr->hasOneUse()) {
2068 // Canonicalize the shift into an 'and':
2069 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt)
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002070 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002071 Constant *Mask = ConstantInt::get(ShrTy, Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002072 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Patel42135be2017-10-16 14:47:24 +00002073 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002074 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002075
2076 return nullptr;
2077}
2078
Sanjay Patel12a41052016-08-18 17:37:26 +00002079/// Fold icmp (udiv X, Y), C.
2080Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002081 BinaryOperator *UDiv,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002082 const APInt &C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002083 const APInt *C2;
2084 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2085 return nullptr;
2086
Craig Topper29c282e2017-06-07 07:40:29 +00002087 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002088
2089 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2090 Value *Y = UDiv->getOperand(1);
2091 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002092 assert(!C.isMaxValue() &&
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002093 "icmp ugt X, UINT_MAX should have been simplified already.");
2094 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002095 ConstantInt::get(Y->getType(), C2->udiv(C + 1)));
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002096 }
2097
2098 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2099 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002100 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002101 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002102 ConstantInt::get(Y->getType(), C2->udiv(C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002103 }
2104
2105 return nullptr;
2106}
2107
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002108/// Fold icmp ({su}div X, Y), C.
2109Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2110 BinaryOperator *Div,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002111 const APInt &C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002112 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002113 // Fold this div into the comparison, producing a range check.
2114 // Determine, based on the divide type, what the range is being
2115 // checked. If there is an overflow on the low or high side, remember
2116 // it, otherwise compute the range [low, hi) bounding the new value.
2117 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002118 const APInt *C2;
2119 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002120 return nullptr;
2121
Sanjay Patel16554142016-08-24 23:03:36 +00002122 // FIXME: If the operand types don't match the type of the divide
2123 // then don't attempt this transform. The code below doesn't have the
2124 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002125 // vice versa). This is because (x /s C2) <s C produces different
2126 // results than (x /s C2) <u C or (x /u C2) <s C or even
2127 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002128 // work. :( The if statement below tests that condition and bails
2129 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002130 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2131 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002132 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002133
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002134 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2135 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2136 // division-by-constant cases should be present, we can not assert that they
2137 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002138 if (C2->isNullValue() || C2->isOneValue() ||
2139 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002140 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002141
Craig Topper6e025a32017-10-01 23:53:54 +00002142 // Compute Prod = C * C2. We are essentially solving an equation of
2143 // form X / C2 = C. We solve for X by multiplying C2 and C.
Sanjay Patel541aef42016-08-31 21:57:21 +00002144 // By solving for X, we can turn this into a range check instead of computing
2145 // a divide.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002146 APInt Prod = C * *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002147
Sanjay Patel541aef42016-08-31 21:57:21 +00002148 // Determine if the product overflows by seeing if the product is not equal to
2149 // the divide. Make sure we do the same kind of divide as in the LHS
2150 // instruction that we're folding.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002151 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C;
Sanjay Patel16554142016-08-24 23:03:36 +00002152
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002153 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002154
2155 // If the division is known to be exact, then there is no remainder from the
2156 // divide, so the covered range size is unit, otherwise it is the divisor.
Craig Topper6e025a32017-10-01 23:53:54 +00002157 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002158
2159 // Figure out the interval that is being checked. For example, a comparison
2160 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2161 // Compute this interval based on the constants involved and the signedness of
2162 // the compare/divide. This computes a half-open interval, keeping track of
2163 // whether either value in the interval overflows. After analysis each
2164 // overflow variable is set to 0 if it's corresponding bound variable is valid
2165 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2166 int LoOverflow = 0, HiOverflow = 0;
Craig Topper6e025a32017-10-01 23:53:54 +00002167 APInt LoBound, HiBound;
Sanjay Patel16554142016-08-24 23:03:36 +00002168
2169 if (!DivIsSigned) { // udiv
2170 // e.g. X/5 op 3 --> [15, 20)
2171 LoBound = Prod;
2172 HiOverflow = LoOverflow = ProdOV;
2173 if (!HiOverflow) {
2174 // If this is not an exact divide, then many values in the range collapse
2175 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002176 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002177 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002178 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002179 if (C.isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002180 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
Craig Topper6e025a32017-10-01 23:53:54 +00002181 LoBound = -(RangeSize - 1);
Sanjay Patel16554142016-08-24 23:03:36 +00002182 HiBound = RangeSize;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002183 } else if (C.isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002184 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2185 HiOverflow = LoOverflow = ProdOV;
2186 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002187 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002188 } else { // (X / pos) op neg
2189 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002190 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002191 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2192 if (!LoOverflow) {
Craig Topper6e025a32017-10-01 23:53:54 +00002193 APInt DivNeg = -RangeSize;
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002194 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002195 }
2196 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002197 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002198 if (Div->isExact())
Craig Topper6e025a32017-10-01 23:53:54 +00002199 RangeSize.negate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00002200 if (C.isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002201 // e.g. X/-5 op 0 --> [-4, 5)
Craig Topper6e025a32017-10-01 23:53:54 +00002202 LoBound = RangeSize + 1;
2203 HiBound = -RangeSize;
2204 if (HiBound == *C2) { // -INTMIN = INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002205 HiOverflow = 1; // [INTMIN+1, overflow)
Craig Topper6e025a32017-10-01 23:53:54 +00002206 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002207 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002208 } else if (C.isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002209 // e.g. X/-5 op 3 --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002210 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002211 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2212 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002213 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002214 } else { // (X / neg) op neg
2215 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2216 LoOverflow = HiOverflow = ProdOV;
2217 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002218 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002219 }
2220
2221 // Dividing by a negative swaps the condition. LT <-> GT
2222 Pred = ICmpInst::getSwappedPredicate(Pred);
2223 }
2224
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002225 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002226 switch (Pred) {
2227 default: llvm_unreachable("Unhandled icmp opcode!");
2228 case ICmpInst::ICMP_EQ:
2229 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002230 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002231 if (HiOverflow)
2232 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002233 ICmpInst::ICMP_UGE, X,
2234 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002235 if (LoOverflow)
2236 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002237 ICmpInst::ICMP_ULT, X,
2238 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel85d79742016-08-31 19:49:56 +00002239 return replaceInstUsesWith(
Craig Topper6e025a32017-10-01 23:53:54 +00002240 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002241 case ICmpInst::ICMP_NE:
2242 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002243 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002244 if (HiOverflow)
2245 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002246 ICmpInst::ICMP_ULT, X,
2247 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002248 if (LoOverflow)
2249 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002250 ICmpInst::ICMP_UGE, X,
2251 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel541aef42016-08-31 21:57:21 +00002252 return replaceInstUsesWith(Cmp,
Craig Topper6e025a32017-10-01 23:53:54 +00002253 insertRangeTest(X, LoBound, HiBound,
Sanjay Patel541aef42016-08-31 21:57:21 +00002254 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002255 case ICmpInst::ICMP_ULT:
2256 case ICmpInst::ICMP_SLT:
2257 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002258 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002259 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002260 return replaceInstUsesWith(Cmp, Builder.getFalse());
Craig Topper6e025a32017-10-01 23:53:54 +00002261 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002262 case ICmpInst::ICMP_UGT:
2263 case ICmpInst::ICMP_SGT:
2264 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002265 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002266 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002267 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002268 if (Pred == ICmpInst::ICMP_UGT)
Craig Topper6e025a32017-10-01 23:53:54 +00002269 return new ICmpInst(ICmpInst::ICMP_UGE, X,
2270 ConstantInt::get(Div->getType(), HiBound));
2271 return new ICmpInst(ICmpInst::ICMP_SGE, X,
2272 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002273 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002274
2275 return nullptr;
2276}
2277
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002278/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002279Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2280 BinaryOperator *Sub,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002281 const APInt &C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002282 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2283 ICmpInst::Predicate Pred = Cmp.getPredicate();
2284
2285 // The following transforms are only worth it if the only user of the subtract
2286 // is the icmp.
2287 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002288 return nullptr;
2289
Sanjay Patel886a5422016-09-15 18:05:17 +00002290 if (Sub->hasNoSignedWrap()) {
2291 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002292 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002293 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002294
Sanjay Patel886a5422016-09-15 18:05:17 +00002295 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002296 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002297 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2298
2299 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002300 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002301 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2302
2303 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002304 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002305 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2306 }
2307
2308 const APInt *C2;
2309 if (!match(X, m_APInt(C2)))
2310 return nullptr;
2311
2312 // C2 - Y <u C -> (Y | (C - 1)) == C2
2313 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002314 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() &&
2315 (*C2 & (C - 1)) == (C - 1))
2316 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002317
2318 // C2 - Y >u C -> (Y | C) != C2
2319 // iff C2 & C == C and C + 1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002320 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C)
2321 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002322
2323 return nullptr;
2324}
2325
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002326/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002327Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2328 BinaryOperator *Add,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002329 const APInt &C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002330 Value *Y = Add->getOperand(1);
2331 const APInt *C2;
2332 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002333 return nullptr;
2334
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002335 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002336 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002337 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002338 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002339
2340 // If the add does not wrap, we can always adjust the compare by subtracting
2341 // the constants. Equality comparisons are handled elsewhere. SGE/SLE are
2342 // canonicalized to SGT/SLT.
2343 if (Add->hasNoSignedWrap() &&
2344 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) {
2345 bool Overflow;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002346 APInt NewC = C.ssub_ov(*C2, Overflow);
Sanjay Patel45b7e692017-02-12 16:40:30 +00002347 // If there is overflow, the result must be true or false.
2348 // TODO: Can we assert there is no overflow because InstSimplify always
2349 // handles those cases?
2350 if (!Overflow)
2351 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2352 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2353 }
2354
Craig Topper8ed1aa92017-10-03 05:31:07 +00002355 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002356 const APInt &Upper = CR.getUpper();
2357 const APInt &Lower = CR.getLower();
2358 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002359 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002360 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002361 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002362 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002363 } else {
2364 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002365 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002366 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002367 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002368 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002369
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002370 if (!Add->hasOneUse())
2371 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00002372
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002373 // X+C <u C2 -> (X & -C2) == C
2374 // iff C & (C2-1) == 0
2375 // C2 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002376 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0)
2377 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002378 ConstantExpr::getNeg(cast<Constant>(Y)));
2379
2380 // X+C >u C2 -> (X & ~C2) != C
2381 // iff C & C2 == 0
2382 // C2+1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002383 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0)
2384 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002385 ConstantExpr::getNeg(cast<Constant>(Y)));
2386
Sanjay Patela3f4f082016-08-16 17:54:36 +00002387 return nullptr;
2388}
2389
Anna Thomasd67165c2017-06-23 13:41:45 +00002390bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2391 Value *&RHS, ConstantInt *&Less,
2392 ConstantInt *&Equal,
2393 ConstantInt *&Greater) {
2394 // TODO: Generalize this to work with other comparison idioms or ensure
2395 // they get canonicalized into this form.
2396
2397 // select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32
2398 // Greater), where Equal, Less and Greater are placeholders for any three
2399 // constants.
2400 ICmpInst::Predicate PredA, PredB;
2401 if (match(SI->getTrueValue(), m_ConstantInt(Equal)) &&
2402 match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) &&
2403 PredA == ICmpInst::ICMP_EQ &&
2404 match(SI->getFalseValue(),
2405 m_Select(m_ICmp(PredB, m_Specific(LHS), m_Specific(RHS)),
2406 m_ConstantInt(Less), m_ConstantInt(Greater))) &&
2407 PredB == ICmpInst::ICMP_SLT) {
2408 return true;
2409 }
2410 return false;
2411}
2412
2413Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002414 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002415 ConstantInt *C) {
2416
2417 assert(C && "Cmp RHS should be a constant int!");
2418 // If we're testing a constant value against the result of a three way
2419 // comparison, the result can be expressed directly in terms of the
2420 // original values being compared. Note: We could possibly be more
2421 // aggressive here and remove the hasOneUse test. The original select is
2422 // really likely to simplify or sink when we remove a test of the result.
2423 Value *OrigLHS, *OrigRHS;
2424 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2425 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002426 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2427 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002428 assert(C1LessThan && C2Equal && C3GreaterThan);
2429
2430 bool TrueWhenLessThan =
2431 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2432 ->isAllOnesValue();
2433 bool TrueWhenEqual =
2434 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2435 ->isAllOnesValue();
2436 bool TrueWhenGreaterThan =
2437 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2438 ->isAllOnesValue();
2439
2440 // This generates the new instruction that will replace the original Cmp
2441 // Instruction. Instead of enumerating the various combinations when
2442 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2443 // false, we rely on chaining of ORs and future passes of InstCombine to
2444 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2445
2446 // When none of the three constants satisfy the predicate for the RHS (C),
2447 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002448 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002449 if (TrueWhenLessThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002450 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002451 if (TrueWhenEqual)
Craig Topperbb4069e2017-07-07 23:16:26 +00002452 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002453 if (TrueWhenGreaterThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002454 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002455
2456 return replaceInstUsesWith(Cmp, Cond);
2457 }
2458 return nullptr;
2459}
2460
Daniel Neilson901acfa2018-04-03 17:26:20 +00002461Instruction *InstCombiner::foldICmpBitCastConstant(ICmpInst &Cmp,
2462 BitCastInst *Bitcast,
2463 const APInt &C) {
2464 // Folding: icmp <pred> iN X, C
2465 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN
2466 // and C is a splat of a K-bit pattern
2467 // and SC is a constant vector = <C', C', C', ..., C'>
2468 // Into:
2469 // %E = extractelement <M x iK> %vec, i32 C'
2470 // icmp <pred> iK %E, trunc(C)
2471 if (!Bitcast->getType()->isIntegerTy() ||
2472 !Bitcast->getSrcTy()->isIntOrIntVectorTy())
2473 return nullptr;
2474
2475 Value *BCIOp = Bitcast->getOperand(0);
2476 Value *Vec = nullptr; // 1st vector arg of the shufflevector
2477 Constant *Mask = nullptr; // Mask arg of the shufflevector
2478 if (match(BCIOp,
2479 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) {
2480 // Check whether every element of Mask is the same constant
2481 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) {
2482 auto *VecTy = cast<VectorType>(BCIOp->getType());
2483 auto *EltTy = cast<IntegerType>(VecTy->getElementType());
2484 auto Pred = Cmp.getPredicate();
2485 if (C.isSplat(EltTy->getBitWidth())) {
2486 // Fold the icmp based on the value of C
2487 // If C is M copies of an iK sized bit pattern,
2488 // then:
2489 // => %E = extractelement <N x iK> %vec, i32 Elem
2490 // icmp <pred> iK %SplatVal, <pattern>
2491 Value *Extract = Builder.CreateExtractElement(Vec, Elem);
2492 Value *NewC = ConstantInt::get(EltTy, C.trunc(EltTy->getBitWidth()));
2493 return new ICmpInst(Pred, Extract, NewC);
2494 }
2495 }
2496 }
2497 return nullptr;
2498}
2499
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002500/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2501/// where X is some kind of instruction.
2502Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002503 const APInt *C;
2504 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002505 return nullptr;
2506
Craig Toppera94069f2017-08-23 05:46:08 +00002507 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002508 switch (BO->getOpcode()) {
2509 case Instruction::Xor:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002510 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002511 return I;
2512 break;
2513 case Instruction::And:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002514 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002515 return I;
2516 break;
2517 case Instruction::Or:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002518 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002519 return I;
2520 break;
2521 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002522 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002523 return I;
2524 break;
2525 case Instruction::Shl:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002526 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002527 return I;
2528 break;
2529 case Instruction::LShr:
2530 case Instruction::AShr:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002531 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002532 return I;
2533 break;
2534 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002535 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002536 return I;
2537 LLVM_FALLTHROUGH;
2538 case Instruction::SDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002539 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002540 return I;
2541 break;
2542 case Instruction::Sub:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002543 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002544 return I;
2545 break;
2546 case Instruction::Add:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002547 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002548 return I;
2549 break;
2550 default:
2551 break;
2552 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002553 // TODO: These folds could be refactored to be part of the above calls.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002554 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002555 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002556 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002557
Anna Thomasd67165c2017-06-23 13:41:45 +00002558 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002559
2560 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2561 // For now, we only support constant integers while folding the
2562 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2563 // similar to the cases handled by binary ops above.
2564 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2565 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002566 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002567 }
2568
2569 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002570 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C))
Craig Topper524c44f2017-08-23 05:46:07 +00002571 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002572 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002573
Daniel Neilson901acfa2018-04-03 17:26:20 +00002574 if (auto *BCI = dyn_cast<BitCastInst>(Cmp.getOperand(0))) {
2575 if (Instruction *I = foldICmpBitCastConstant(Cmp, BCI, *C))
2576 return I;
2577 }
2578
Craig Topper8ed1aa92017-10-03 05:31:07 +00002579 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002580 return I;
2581
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002582 return nullptr;
2583}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002584
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002585/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2586/// icmp eq/ne BO, C.
2587Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2588 BinaryOperator *BO,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002589 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002590 // TODO: Some of these folds could work with arbitrary constants, but this
2591 // function is limited to scalar and vector splat constants.
2592 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002593 return nullptr;
2594
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002595 ICmpInst::Predicate Pred = Cmp.getPredicate();
2596 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2597 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002598 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002599
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002600 switch (BO->getOpcode()) {
2601 case Instruction::SRem:
2602 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002603 if (C.isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002604 const APInt *BOC;
2605 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002606 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002607 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002608 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002609 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002610 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002611 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002612 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002613 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002614 const APInt *BOC;
2615 if (match(BOp1, m_APInt(BOC))) {
2616 if (BO->hasOneUse()) {
2617 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002618 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002619 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002620 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002621 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2622 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002623 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002624 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002625 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002626 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002627 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002628 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002629 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002630 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002631 }
2632 }
2633 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002634 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002635 case Instruction::Xor:
2636 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002637 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002638 // For the xor case, we can xor two constants together, eliminating
2639 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002640 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002641 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002642 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002643 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002644 }
2645 }
2646 break;
2647 case Instruction::Sub:
2648 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002649 const APInt *BOC;
2650 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002651 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002652 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002653 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002654 } else if (C.isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002655 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002656 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002657 }
2658 }
2659 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002660 case Instruction::Or: {
2661 const APInt *BOC;
2662 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002663 // Comparing if all bits outside of a constant mask are set?
2664 // Replace (X | C) == -1 with (X & ~C) == ~C.
2665 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002666 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002667 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002668 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002669 }
2670 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002671 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002672 case Instruction::And: {
2673 const APInt *BOC;
2674 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002675 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Craig Topper8ed1aa92017-10-03 05:31:07 +00002676 if (C == *BOC && C.isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002677 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002678 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002679
2680 // Don't perform the following transforms if the AND has multiple uses
2681 if (!BO->hasOneUse())
2682 break;
2683
2684 // Replace (and X, (1 << size(X)-1) != 0) with x s< 0
Craig Topperbcfd2d12017-04-20 16:56:25 +00002685 if (BOC->isSignMask()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002686 Constant *Zero = Constant::getNullValue(BOp0->getType());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002687 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
2688 return new ICmpInst(NewPred, BOp0, Zero);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002689 }
2690
2691 // ((X & ~7) == 0) --> X < 8
Craig Topper8ed1aa92017-10-03 05:31:07 +00002692 if (C.isNullValue() && (~(*BOC) + 1).isPowerOf2()) {
Sanjay Pateld938e882016-08-04 20:05:02 +00002693 Constant *NegBOC = ConstantExpr::getNeg(cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002694 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
2695 return new ICmpInst(NewPred, BOp0, NegBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002696 }
2697 }
2698 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002699 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002700 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002701 if (C.isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002702 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002703 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002704 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002705 // General case : (mul X, C) != 0 iff X != 0
2706 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002707 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002708 }
2709 }
2710 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002711 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002712 if (C.isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002713 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002714 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2715 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002716 }
2717 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002718 default:
2719 break;
2720 }
2721 return nullptr;
2722}
2723
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002724/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
2725Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002726 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002727 IntrinsicInst *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0));
2728 if (!II || !Cmp.isEquality())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002729 return nullptr;
2730
Sanjay Patelb51e0722017-07-02 16:05:11 +00002731 // Handle icmp {eq|ne} <intrinsic>, Constant.
2732 Type *Ty = II->getType();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002733 switch (II->getIntrinsicID()) {
2734 case Intrinsic::bswap:
2735 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002736 Cmp.setOperand(0, II->getArgOperand(0));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002737 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002738 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002739
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002740 case Intrinsic::ctlz:
2741 case Intrinsic::cttz:
Amaury Sechet6bea6742016-08-04 05:27:20 +00002742 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002743 if (C == C.getBitWidth()) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002744 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002745 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002746 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002747 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002748 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002749 break;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002750
Amaury Sechet6bea6742016-08-04 05:27:20 +00002751 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002752 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002753 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002754 bool IsZero = C.isNullValue();
2755 if (IsZero || C == C.getBitWidth()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002756 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002757 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002758 auto *NewOp =
2759 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002760 Cmp.setOperand(1, NewOp);
2761 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002762 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002763 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002764 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002765 default:
2766 break;
Chris Lattner2188e402010-01-04 07:37:31 +00002767 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002768
Craig Topperf40110f2014-04-25 05:29:35 +00002769 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00002770}
2771
Sanjay Patel10494b22016-09-16 16:10:22 +00002772/// Handle icmp with constant (but not simple integer constant) RHS.
2773Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
2774 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2775 Constant *RHSC = dyn_cast<Constant>(Op1);
2776 Instruction *LHSI = dyn_cast<Instruction>(Op0);
2777 if (!RHSC || !LHSI)
2778 return nullptr;
2779
2780 switch (LHSI->getOpcode()) {
2781 case Instruction::GetElementPtr:
2782 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
2783 if (RHSC->isNullValue() &&
2784 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
2785 return new ICmpInst(
2786 I.getPredicate(), LHSI->getOperand(0),
2787 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2788 break;
2789 case Instruction::PHI:
2790 // Only fold icmp into the PHI if the phi and icmp are in the same
2791 // block. If in the same block, we're encouraging jump threading. If
2792 // not, we are just pessimizing the code by making an i1 phi.
2793 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00002794 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00002795 return NV;
2796 break;
2797 case Instruction::Select: {
2798 // If either operand of the select is a constant, we can fold the
2799 // comparison into the select arms, which will cause one to be
2800 // constant folded and the select turned into a bitwise or.
2801 Value *Op1 = nullptr, *Op2 = nullptr;
2802 ConstantInt *CI = nullptr;
2803 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
2804 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2805 CI = dyn_cast<ConstantInt>(Op1);
2806 }
2807 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
2808 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2809 CI = dyn_cast<ConstantInt>(Op2);
2810 }
2811
2812 // We only want to perform this transformation if it will not lead to
2813 // additional code. This is true if either both sides of the select
2814 // fold to a constant (in which case the icmp is replaced with a select
2815 // which will usually simplify) or this is the only user of the
2816 // select (in which case we are trading a select+icmp for a simpler
2817 // select+icmp) or all uses of the select can be replaced based on
2818 // dominance information ("Global cases").
2819 bool Transform = false;
2820 if (Op1 && Op2)
2821 Transform = true;
2822 else if (Op1 || Op2) {
2823 // Local case
2824 if (LHSI->hasOneUse())
2825 Transform = true;
2826 // Global cases
2827 else if (CI && !CI->isZero())
2828 // When Op1 is constant try replacing select with second operand.
2829 // Otherwise Op2 is constant and try replacing select with first
2830 // operand.
2831 Transform =
2832 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
2833 }
2834 if (Transform) {
2835 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00002836 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
2837 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002838 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00002839 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
2840 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002841 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
2842 }
2843 break;
2844 }
2845 case Instruction::IntToPtr:
2846 // icmp pred inttoptr(X), null -> icmp pred X, 0
2847 if (RHSC->isNullValue() &&
2848 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
2849 return new ICmpInst(
2850 I.getPredicate(), LHSI->getOperand(0),
2851 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2852 break;
2853
2854 case Instruction::Load:
2855 // Try to optimize things like "A[i] > 4" to index computations.
2856 if (GetElementPtrInst *GEP =
2857 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
2858 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
2859 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
2860 !cast<LoadInst>(LHSI)->isVolatile())
2861 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
2862 return Res;
2863 }
2864 break;
2865 }
2866
2867 return nullptr;
2868}
2869
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002870/// Some comparisons can be simplified.
2871/// In this case, we are looking for comparisons that look like
2872/// a check for a lossy truncation.
2873/// Folds:
2874/// x & (-1 >> y) SrcPred x to x DstPred (-1 >> y)
2875/// The Mask can be a constant, too.
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00002876/// For some predicates, the operands are commutative.
2877/// For others, x can only be on a specific side.
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002878static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I,
2879 InstCombiner::BuilderTy &Builder) {
2880 ICmpInst::Predicate SrcPred;
2881 Value *X, *M;
2882 auto m_Mask = m_CombineOr(m_LShr(m_AllOnes(), m_Value()), m_LowBitMask());
2883 if (!match(&I, m_c_ICmp(SrcPred,
2884 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)),
2885 m_Deferred(X))))
2886 return nullptr;
2887
2888 ICmpInst::Predicate DstPred;
2889 switch (SrcPred) {
2890 case ICmpInst::Predicate::ICMP_EQ:
2891 // x & (-1 >> y) == x -> x u<= (-1 >> y)
2892 DstPred = ICmpInst::Predicate::ICMP_ULE;
2893 break;
Roman Lebedev74f899f2018-07-12 14:56:12 +00002894 case ICmpInst::Predicate::ICMP_NE:
2895 // x & (-1 >> y) != x -> x u> (-1 >> y)
2896 DstPred = ICmpInst::Predicate::ICMP_UGT;
2897 break;
Roman Lebedev74f611a2018-07-14 16:44:43 +00002898 case ICmpInst::Predicate::ICMP_UGT:
2899 // x u> x & (-1 >> y) -> x u> (-1 >> y)
2900 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
2901 DstPred = ICmpInst::Predicate::ICMP_UGT;
2902 break;
Roman Lebedevfac48472018-07-14 12:20:06 +00002903 case ICmpInst::Predicate::ICMP_UGE:
2904 // x & (-1 >> y) u>= x -> x u<= (-1 >> y)
2905 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
2906 DstPred = ICmpInst::Predicate::ICMP_ULE;
2907 break;
Roman Lebedeve3dc5872018-07-14 12:20:16 +00002908 case ICmpInst::Predicate::ICMP_ULT:
2909 // x & (-1 >> y) u< x -> x u> (-1 >> y)
2910 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
2911 DstPred = ICmpInst::Predicate::ICMP_UGT;
2912 break;
Roman Lebedev0f5ec892018-07-14 16:44:54 +00002913 case ICmpInst::Predicate::ICMP_ULE:
2914 // x u<= x & (-1 >> y) -> x u<= (-1 >> y)
2915 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
2916 DstPred = ICmpInst::Predicate::ICMP_ULE;
2917 break;
Roman Lebedev859e14a2018-07-14 20:08:16 +00002918 case ICmpInst::Predicate::ICMP_SGT:
2919 // x s> x & (-1 >> y) -> x s> (-1 >> y)
2920 if (X != I.getOperand(0)) // X must be on LHS of comparison!
2921 return nullptr; // Ignore the other case.
2922 DstPred = ICmpInst::Predicate::ICMP_SGT;
2923 break;
Roman Lebedevf1442612018-07-14 20:08:37 +00002924 case ICmpInst::Predicate::ICMP_SGE:
2925 // x & (-1 >> y) s>= x -> x s<= (-1 >> y)
2926 if (X != I.getOperand(1)) // X must be on RHS of comparison!
2927 return nullptr; // Ignore the other case.
2928 DstPred = ICmpInst::Predicate::ICMP_SLE;
2929 break;
Roman Lebedevb972fc32018-07-14 20:08:47 +00002930 case ICmpInst::Predicate::ICMP_SLT:
2931 // x & (-1 >> y) s< x -> x s> (-1 >> y)
2932 if (X != I.getOperand(1)) // X must be on RHS of comparison!
2933 return nullptr; // Ignore the other case.
2934 DstPred = ICmpInst::Predicate::ICMP_SGT;
2935 break;
Roman Lebedev1e61e352018-07-14 20:08:26 +00002936 case ICmpInst::Predicate::ICMP_SLE:
2937 // x s<= x & (-1 >> y) -> x s<= (-1 >> y)
2938 if (X != I.getOperand(0)) // X must be on LHS of comparison!
2939 return nullptr; // Ignore the other case.
2940 DstPred = ICmpInst::Predicate::ICMP_SLE;
2941 break;
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002942 default:
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00002943 llvm_unreachable("All possible folds are handled.");
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002944 }
2945
2946 return Builder.CreateICmp(DstPred, X, M);
2947}
2948
Roman Lebedev3cb87e92018-07-18 10:55:17 +00002949/// Some comparisons can be simplified.
2950/// In this case, we are looking for comparisons that look like
2951/// a check for a lossy signed truncation.
2952/// Folds: (MaskedBits is a constant.)
2953/// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x
2954/// Into:
2955/// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits)
2956/// Where KeptBits = bitwidth(%x) - MaskedBits
2957static Value *
2958foldICmpWithTruncSignExtendedVal(ICmpInst &I,
2959 InstCombiner::BuilderTy &Builder) {
2960 ICmpInst::Predicate SrcPred;
2961 Value *X;
2962 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef.
2963 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use.
2964 if (!match(&I, m_c_ICmp(SrcPred,
2965 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)),
2966 m_APInt(C1))),
2967 m_Deferred(X))))
2968 return nullptr;
2969
2970 // Potential handling of non-splats: for each element:
2971 // * if both are undef, replace with constant 0.
2972 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0.
2973 // * if both are not undef, and are different, bailout.
2974 // * else, only one is undef, then pick the non-undef one.
2975
2976 // The shift amount must be equal.
2977 if (*C0 != *C1)
2978 return nullptr;
2979 const APInt &MaskedBits = *C0;
2980 assert(MaskedBits != 0 && "shift by zero should be folded away already.");
2981
2982 ICmpInst::Predicate DstPred;
2983 switch (SrcPred) {
2984 case ICmpInst::Predicate::ICMP_EQ:
2985 // ((%x << MaskedBits) a>> MaskedBits) == %x
2986 // =>
2987 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits)
2988 DstPred = ICmpInst::Predicate::ICMP_ULT;
2989 break;
2990 case ICmpInst::Predicate::ICMP_NE:
2991 // ((%x << MaskedBits) a>> MaskedBits) != %x
2992 // =>
2993 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits)
2994 DstPred = ICmpInst::Predicate::ICMP_UGE;
2995 break;
2996 // FIXME: are more folds possible?
2997 default:
2998 return nullptr;
2999 }
3000
3001 auto *XType = X->getType();
3002 const unsigned XBitWidth = XType->getScalarSizeInBits();
3003 const APInt BitWidth = APInt(XBitWidth, XBitWidth);
3004 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched");
3005
3006 // KeptBits = bitwidth(%x) - MaskedBits
3007 const APInt KeptBits = BitWidth - MaskedBits;
3008 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable");
3009 // ICmpCst = (1 << KeptBits)
3010 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits);
3011 assert(ICmpCst.isPowerOf2());
3012 // AddCst = (1 << (KeptBits-1))
3013 const APInt AddCst = ICmpCst.lshr(1);
3014 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2());
3015
3016 // T0 = add %x, AddCst
3017 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst));
3018 // T1 = T0 DstPred ICmpCst
3019 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst));
3020
3021 return T1;
3022}
3023
Sanjay Patel10494b22016-09-16 16:10:22 +00003024/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00003025/// TODO: A large part of this logic is duplicated in InstSimplify's
3026/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
3027/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00003028Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
3029 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3030
3031 // Special logic for binary operators.
3032 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
3033 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
3034 if (!BO0 && !BO1)
3035 return nullptr;
3036
Sanjay Patel2a062632017-05-08 16:33:42 +00003037 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00003038 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
3039 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
3040 NoOp0WrapProblem =
3041 ICmpInst::isEquality(Pred) ||
3042 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
3043 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
3044 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
3045 NoOp1WrapProblem =
3046 ICmpInst::isEquality(Pred) ||
3047 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
3048 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
3049
3050 // Analyze the case when either Op0 or Op1 is an add instruction.
3051 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
3052 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
3053 if (BO0 && BO0->getOpcode() == Instruction::Add) {
3054 A = BO0->getOperand(0);
3055 B = BO0->getOperand(1);
3056 }
3057 if (BO1 && BO1->getOpcode() == Instruction::Add) {
3058 C = BO1->getOperand(0);
3059 D = BO1->getOperand(1);
3060 }
3061
Sanjay Patel10494b22016-09-16 16:10:22 +00003062 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
3063 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
3064 return new ICmpInst(Pred, A == Op1 ? B : A,
3065 Constant::getNullValue(Op1->getType()));
3066
3067 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
3068 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
3069 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
3070 C == Op0 ? D : C);
3071
3072 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
3073 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
3074 NoOp1WrapProblem &&
3075 // Try not to increase register pressure.
3076 BO0->hasOneUse() && BO1->hasOneUse()) {
3077 // Determine Y and Z in the form icmp (X+Y), (X+Z).
3078 Value *Y, *Z;
3079 if (A == C) {
3080 // C + B == C + D -> B == D
3081 Y = B;
3082 Z = D;
3083 } else if (A == D) {
3084 // D + B == C + D -> B == C
3085 Y = B;
3086 Z = C;
3087 } else if (B == C) {
3088 // A + C == C + D -> A == D
3089 Y = A;
3090 Z = D;
3091 } else {
3092 assert(B == D);
3093 // A + D == C + D -> A == C
3094 Y = A;
3095 Z = C;
3096 }
3097 return new ICmpInst(Pred, Y, Z);
3098 }
3099
3100 // icmp slt (X + -1), Y -> icmp sle X, Y
3101 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
3102 match(B, m_AllOnes()))
3103 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
3104
3105 // icmp sge (X + -1), Y -> icmp sgt X, Y
3106 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
3107 match(B, m_AllOnes()))
3108 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
3109
3110 // icmp sle (X + 1), Y -> icmp slt X, Y
3111 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
3112 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
3113
3114 // icmp sgt (X + 1), Y -> icmp sge X, Y
3115 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
3116 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
3117
3118 // icmp sgt X, (Y + -1) -> icmp sge X, Y
3119 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
3120 match(D, m_AllOnes()))
3121 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
3122
3123 // icmp sle X, (Y + -1) -> icmp slt X, Y
3124 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
3125 match(D, m_AllOnes()))
3126 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
3127
3128 // icmp sge X, (Y + 1) -> icmp sgt X, Y
3129 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
3130 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
3131
3132 // icmp slt X, (Y + 1) -> icmp sle X, Y
3133 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
3134 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
3135
Sanjay Patel40f40172017-01-13 23:25:46 +00003136 // TODO: The subtraction-related identities shown below also hold, but
3137 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
3138 // wouldn't happen even if they were implemented.
3139 //
3140 // icmp ult (X - 1), Y -> icmp ule X, Y
3141 // icmp uge (X - 1), Y -> icmp ugt X, Y
3142 // icmp ugt X, (Y - 1) -> icmp uge X, Y
3143 // icmp ule X, (Y - 1) -> icmp ult X, Y
3144
3145 // icmp ule (X + 1), Y -> icmp ult X, Y
3146 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
3147 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
3148
3149 // icmp ugt (X + 1), Y -> icmp uge X, Y
3150 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
3151 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
3152
3153 // icmp uge X, (Y + 1) -> icmp ugt X, Y
3154 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
3155 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
3156
3157 // icmp ult X, (Y + 1) -> icmp ule X, Y
3158 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
3159 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
3160
Sanjay Patel10494b22016-09-16 16:10:22 +00003161 // if C1 has greater magnitude than C2:
3162 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
3163 // s.t. C3 = C1 - C2
3164 //
3165 // if C2 has greater magnitude than C1:
3166 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
3167 // s.t. C3 = C2 - C1
3168 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
3169 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
3170 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
3171 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
3172 const APInt &AP1 = C1->getValue();
3173 const APInt &AP2 = C2->getValue();
3174 if (AP1.isNegative() == AP2.isNegative()) {
3175 APInt AP1Abs = C1->getValue().abs();
3176 APInt AP2Abs = C2->getValue().abs();
3177 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003178 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
3179 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003180 return new ICmpInst(Pred, NewAdd, C);
3181 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00003182 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
3183 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003184 return new ICmpInst(Pred, A, NewAdd);
3185 }
3186 }
3187 }
3188
3189 // Analyze the case when either Op0 or Op1 is a sub instruction.
3190 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
3191 A = nullptr;
3192 B = nullptr;
3193 C = nullptr;
3194 D = nullptr;
3195 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
3196 A = BO0->getOperand(0);
3197 B = BO0->getOperand(1);
3198 }
3199 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
3200 C = BO1->getOperand(0);
3201 D = BO1->getOperand(1);
3202 }
3203
3204 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
3205 if (A == Op1 && NoOp0WrapProblem)
3206 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
Sanjay Patel10494b22016-09-16 16:10:22 +00003207 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
3208 if (C == Op0 && NoOp1WrapProblem)
3209 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3210
Sanjay Patelcbb04502018-04-02 20:37:40 +00003211 // (A - B) >u A --> A <u B
3212 if (A == Op1 && Pred == ICmpInst::ICMP_UGT)
3213 return new ICmpInst(ICmpInst::ICMP_ULT, A, B);
3214 // C <u (C - D) --> C <u D
3215 if (C == Op0 && Pred == ICmpInst::ICMP_ULT)
3216 return new ICmpInst(ICmpInst::ICMP_ULT, C, D);
3217
Sanjay Patel10494b22016-09-16 16:10:22 +00003218 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
3219 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
3220 // Try not to increase register pressure.
3221 BO0->hasOneUse() && BO1->hasOneUse())
3222 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003223 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
3224 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
3225 // Try not to increase register pressure.
3226 BO0->hasOneUse() && BO1->hasOneUse())
3227 return new ICmpInst(Pred, D, B);
3228
3229 // icmp (0-X) < cst --> x > -cst
3230 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3231 Value *X;
3232 if (match(BO0, m_Neg(m_Value(X))))
Chen Zhengb9722732018-07-16 00:51:40 +00003233 if (Constant *RHSC = dyn_cast<Constant>(Op1))
3234 if (RHSC->isNotMinSignedValue())
Sanjay Patel10494b22016-09-16 16:10:22 +00003235 return new ICmpInst(I.getSwappedPredicate(), X,
3236 ConstantExpr::getNeg(RHSC));
3237 }
3238
3239 BinaryOperator *SRem = nullptr;
3240 // icmp (srem X, Y), Y
3241 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3242 SRem = BO0;
3243 // icmp Y, (srem X, Y)
3244 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3245 Op0 == BO1->getOperand(1))
3246 SRem = BO1;
3247 if (SRem) {
3248 // We don't check hasOneUse to avoid increasing register pressure because
3249 // the value we use is the same value this instruction was already using.
3250 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3251 default:
3252 break;
3253 case ICmpInst::ICMP_EQ:
3254 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3255 case ICmpInst::ICMP_NE:
3256 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3257 case ICmpInst::ICMP_SGT:
3258 case ICmpInst::ICMP_SGE:
3259 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3260 Constant::getAllOnesValue(SRem->getType()));
3261 case ICmpInst::ICMP_SLT:
3262 case ICmpInst::ICMP_SLE:
3263 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3264 Constant::getNullValue(SRem->getType()));
3265 }
3266 }
3267
3268 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3269 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3270 switch (BO0->getOpcode()) {
3271 default:
3272 break;
3273 case Instruction::Add:
3274 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003275 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003276 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003277 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003278
3279 const APInt *C;
3280 if (match(BO0->getOperand(1), m_APInt(C))) {
3281 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3282 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003283 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003284 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003285 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003286 }
3287
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003288 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3289 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003290 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003291 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003292 NewPred = I.getSwappedPredicate(NewPred);
3293 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003294 }
3295 }
3296 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003297 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003298 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003299 if (!I.isEquality())
3300 break;
3301
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003302 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003303 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3304 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003305 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3306 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003307 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003308 Constant *Mask = ConstantInt::get(
3309 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003310 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003311 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3312 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003313 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003314 }
Sanjay Patel51506122017-05-25 14:13:57 +00003315 // If there are no trailing zeros in the multiplier, just eliminate
3316 // the multiplies (no masking is needed):
3317 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3318 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003319 }
3320 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003321 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003322 case Instruction::UDiv:
3323 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003324 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003325 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003326 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3327
Sanjay Patel10494b22016-09-16 16:10:22 +00003328 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003329 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3330 break;
3331 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3332
Sanjay Patel10494b22016-09-16 16:10:22 +00003333 case Instruction::AShr:
3334 if (!BO0->isExact() || !BO1->isExact())
3335 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003336 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003337
Sanjay Patel10494b22016-09-16 16:10:22 +00003338 case Instruction::Shl: {
3339 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3340 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3341 if (!NUW && !NSW)
3342 break;
3343 if (!NSW && I.isSigned())
3344 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003345 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003346 }
3347 }
3348 }
3349
3350 if (BO0) {
3351 // Transform A & (L - 1) `ult` L --> L != 0
3352 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003353 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003354
Sanjay Patel2a062632017-05-08 16:33:42 +00003355 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003356 auto *Zero = Constant::getNullValue(BO0->getType());
3357 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3358 }
3359 }
3360
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003361 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder))
3362 return replaceInstUsesWith(I, V);
3363
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003364 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder))
3365 return replaceInstUsesWith(I, V);
3366
Sanjay Patel10494b22016-09-16 16:10:22 +00003367 return nullptr;
3368}
3369
Sanjay Pateldd46b522016-12-19 17:32:37 +00003370/// Fold icmp Pred min|max(X, Y), X.
3371static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003372 ICmpInst::Predicate Pred = Cmp.getPredicate();
3373 Value *Op0 = Cmp.getOperand(0);
3374 Value *X = Cmp.getOperand(1);
3375
Sanjay Pateldd46b522016-12-19 17:32:37 +00003376 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003377 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003378 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3379 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3380 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003381 std::swap(Op0, X);
3382 Pred = Cmp.getSwappedPredicate();
3383 }
3384
3385 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003386 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003387 // smin(X, Y) == X --> X s<= Y
3388 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003389 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3390 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3391
Sanjay Pateldd46b522016-12-19 17:32:37 +00003392 // smin(X, Y) != X --> X s> Y
3393 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003394 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3395 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3396
3397 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003398 // smin(X, Y) s<= X --> true
3399 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003400 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003401 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003402
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003403 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003404 // smax(X, Y) == X --> X s>= Y
3405 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003406 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3407 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003408
Sanjay Pateldd46b522016-12-19 17:32:37 +00003409 // smax(X, Y) != X --> X s< Y
3410 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003411 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3412 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003413
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003414 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003415 // smax(X, Y) s>= X --> true
3416 // smax(X, Y) s< X --> false
3417 return nullptr;
3418 }
3419
3420 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3421 // umin(X, Y) == X --> X u<= Y
3422 // umin(X, Y) u>= X --> X u<= Y
3423 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3424 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3425
3426 // umin(X, Y) != X --> X u> Y
3427 // umin(X, Y) u< X --> X u> Y
3428 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3429 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3430
3431 // These cases should be handled in InstSimplify:
3432 // umin(X, Y) u<= X --> true
3433 // umin(X, Y) u> X --> false
3434 return nullptr;
3435 }
3436
3437 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3438 // umax(X, Y) == X --> X u>= Y
3439 // umax(X, Y) u<= X --> X u>= Y
3440 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3441 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3442
3443 // umax(X, Y) != X --> X u< Y
3444 // umax(X, Y) u> X --> X u< Y
3445 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3446 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3447
3448 // These cases should be handled in InstSimplify:
3449 // umax(X, Y) u>= X --> true
3450 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003451 return nullptr;
3452 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003453
Sanjay Pateld6406412016-12-15 19:13:37 +00003454 return nullptr;
3455}
3456
Sanjay Patel10494b22016-09-16 16:10:22 +00003457Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3458 if (!I.isEquality())
3459 return nullptr;
3460
3461 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003462 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00003463 Value *A, *B, *C, *D;
3464 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3465 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3466 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003467 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003468 }
3469
3470 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3471 // A^c1 == C^c2 --> A == C^(c1^c2)
3472 ConstantInt *C1, *C2;
3473 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3474 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003475 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
3476 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003477 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00003478 }
3479
3480 // A^B == A^D -> B == D
3481 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003482 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003483 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003484 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003485 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003486 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003487 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003488 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003489 }
3490 }
3491
3492 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3493 // A == (A^B) -> B == 0
3494 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003495 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003496 }
3497
3498 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3499 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3500 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3501 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3502
3503 if (A == C) {
3504 X = B;
3505 Y = D;
3506 Z = A;
3507 } else if (A == D) {
3508 X = B;
3509 Y = C;
3510 Z = A;
3511 } else if (B == C) {
3512 X = A;
3513 Y = D;
3514 Z = B;
3515 } else if (B == D) {
3516 X = A;
3517 Y = C;
3518 Z = B;
3519 }
3520
3521 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00003522 Op1 = Builder.CreateXor(X, Y);
3523 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00003524 I.setOperand(0, Op1);
3525 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3526 return &I;
3527 }
3528 }
3529
3530 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3531 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3532 ConstantInt *Cst1;
3533 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3534 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3535 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3536 match(Op1, m_ZExt(m_Value(A))))) {
3537 APInt Pow2 = Cst1->getValue() + 1;
3538 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3539 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00003540 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003541 }
3542
3543 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3544 // For lshr and ashr pairs.
3545 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3546 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
3547 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3548 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
3549 unsigned TypeBits = Cst1->getBitWidth();
3550 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3551 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00003552 ICmpInst::Predicate NewPred =
3553 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00003554 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003555 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003556 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00003557 }
3558 }
3559
3560 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
3561 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
3562 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
3563 unsigned TypeBits = Cst1->getBitWidth();
3564 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3565 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003566 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003567 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003568 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00003569 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00003570 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003571 }
3572 }
3573
3574 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
3575 // "icmp (and X, mask), cst"
3576 uint64_t ShAmt = 0;
3577 if (Op0->hasOneUse() &&
3578 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
3579 match(Op1, m_ConstantInt(Cst1)) &&
3580 // Only do this when A has multiple uses. This is most important to do
3581 // when it exposes other optimizations.
3582 !A->hasOneUse()) {
3583 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
3584
3585 if (ShAmt < ASize) {
3586 APInt MaskV =
3587 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
3588 MaskV <<= ShAmt;
3589
3590 APInt CmpV = Cst1->getValue().zext(ASize);
3591 CmpV <<= ShAmt;
3592
Craig Topperbb4069e2017-07-07 23:16:26 +00003593 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
3594 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00003595 }
3596 }
3597
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003598 // If both operands are byte-swapped or bit-reversed, just compare the
3599 // original values.
3600 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
3601 // and handle more intrinsics.
3602 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00003603 (match(Op0, m_BitReverse(m_Value(A))) &&
3604 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003605 return new ICmpInst(Pred, A, B);
3606
Sanjay Patel10494b22016-09-16 16:10:22 +00003607 return nullptr;
3608}
3609
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003610/// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so
3611/// far.
Sanjay Patel43395062016-07-21 18:07:40 +00003612Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) {
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003613 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +00003614 Value *LHSCIOp = LHSCI->getOperand(0);
Chris Lattner229907c2011-07-18 04:54:35 +00003615 Type *SrcTy = LHSCIOp->getType();
3616 Type *DestTy = LHSCI->getType();
Chris Lattner2188e402010-01-04 07:37:31 +00003617 Value *RHSCIOp;
3618
Jim Grosbach129c52a2011-09-30 18:09:53 +00003619 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00003620 // integer type is the same size as the pointer type.
Daniel Neilsonbdda1152018-03-05 18:05:51 +00003621 const auto& CompatibleSizes = [&](Type* SrcTy, Type* DestTy) -> bool {
3622 if (isa<VectorType>(SrcTy)) {
3623 SrcTy = cast<VectorType>(SrcTy)->getElementType();
3624 DestTy = cast<VectorType>(DestTy)->getElementType();
3625 }
3626 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth();
3627 };
Mehdi Aminia28d91d2015-03-10 02:37:25 +00003628 if (LHSCI->getOpcode() == Instruction::PtrToInt &&
Daniel Neilsonbdda1152018-03-05 18:05:51 +00003629 CompatibleSizes(SrcTy, DestTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +00003630 Value *RHSOp = nullptr;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003631 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
Michael Liaod266b922015-02-13 04:51:26 +00003632 Value *RHSCIOp = RHSC->getOperand(0);
3633 if (RHSCIOp->getType()->getPointerAddressSpace() ==
3634 LHSCIOp->getType()->getPointerAddressSpace()) {
3635 RHSOp = RHSC->getOperand(0);
3636 // If the pointer types don't match, insert a bitcast.
3637 if (LHSCIOp->getType() != RHSOp->getType())
Craig Topperbb4069e2017-07-07 23:16:26 +00003638 RHSOp = Builder.CreateBitCast(RHSOp, LHSCIOp->getType());
Michael Liaod266b922015-02-13 04:51:26 +00003639 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003640 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003641 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003642 }
Chris Lattner2188e402010-01-04 07:37:31 +00003643
3644 if (RHSOp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003645 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003646 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003647
Chris Lattner2188e402010-01-04 07:37:31 +00003648 // The code below only handles extension cast instructions, so far.
3649 // Enforce this.
3650 if (LHSCI->getOpcode() != Instruction::ZExt &&
3651 LHSCI->getOpcode() != Instruction::SExt)
Craig Topperf40110f2014-04-25 05:29:35 +00003652 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003653
3654 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003655 bool isSignedCmp = ICmp.isSigned();
Chris Lattner2188e402010-01-04 07:37:31 +00003656
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003657 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003658 // Not an extension from the same type?
3659 RHSCIOp = CI->getOperand(0);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003660 if (RHSCIOp->getType() != LHSCIOp->getType())
Craig Topperf40110f2014-04-25 05:29:35 +00003661 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +00003662
Chris Lattner2188e402010-01-04 07:37:31 +00003663 // If the signedness of the two casts doesn't agree (i.e. one is a sext
3664 // and the other is a zext), then we can't handle this.
3665 if (CI->getOpcode() != LHSCI->getOpcode())
Craig Topperf40110f2014-04-25 05:29:35 +00003666 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003667
3668 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003669 if (ICmp.isEquality())
3670 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003671
3672 // A signed comparison of sign extended values simplifies into a
3673 // signed comparison.
3674 if (isSignedCmp && isSignedExt)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003675 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003676
3677 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003678 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003679 }
3680
Sanjay Patel4c204232016-06-04 20:39:22 +00003681 // If we aren't dealing with a constant on the RHS, exit early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003682 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
3683 if (!C)
Craig Topperf40110f2014-04-25 05:29:35 +00003684 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003685
3686 // Compute the constant that would happen if we truncated to SrcTy then
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003687 // re-extended to DestTy.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003688 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003689 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy);
Chris Lattner2188e402010-01-04 07:37:31 +00003690
3691 // If the re-extended constant didn't change...
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003692 if (Res2 == C) {
Chris Lattner2188e402010-01-04 07:37:31 +00003693 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003694 if (ICmp.isEquality())
3695 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003696
3697 // A signed comparison of sign extended values simplifies into a
3698 // signed comparison.
3699 if (isSignedExt && isSignedCmp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003700 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003701
3702 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003703 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003704 }
3705
Sanjay Patel6a333c32016-06-06 16:56:57 +00003706 // The re-extended constant changed, partly changed (in the case of a vector),
3707 // or could not be determined to be equal (in the case of a constant
3708 // expression), so the constant cannot be represented in the shorter type.
3709 // Consequently, we cannot emit a simple comparison.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003710 // All the cases that fold to true or false will have already been handled
3711 // by SimplifyICmpInst, so only deal with the tricky case.
Chris Lattner2188e402010-01-04 07:37:31 +00003712
Sanjay Patel6a333c32016-06-06 16:56:57 +00003713 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C))
Craig Topperf40110f2014-04-25 05:29:35 +00003714 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003715
3716 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases
3717 // should have been folded away previously and not enter in here.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003718
3719 // We're performing an unsigned comp with a sign extended value.
3720 // This is true if the input is >= 0. [aka >s -1]
3721 Constant *NegOne = Constant::getAllOnesValue(SrcTy);
Craig Topperbb4069e2017-07-07 23:16:26 +00003722 Value *Result = Builder.CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName());
Chris Lattner2188e402010-01-04 07:37:31 +00003723
3724 // Finally, return the value computed.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003725 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
3726 return replaceInstUsesWith(ICmp, Result);
Chris Lattner2188e402010-01-04 07:37:31 +00003727
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003728 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
Chris Lattner2188e402010-01-04 07:37:31 +00003729 return BinaryOperator::CreateNot(Result);
3730}
3731
Sanjoy Dasb0984472015-04-08 04:27:22 +00003732bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS,
3733 Value *RHS, Instruction &OrigI,
3734 Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00003735 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
3736 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003737
3738 auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) {
3739 Result = OpResult;
3740 Overflow = OverflowVal;
3741 if (ReuseName)
3742 Result->takeName(&OrigI);
3743 return true;
3744 };
3745
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003746 // If the overflow check was an add followed by a compare, the insertion point
3747 // may be pointing to the compare. We want to insert the new instructions
3748 // before the add in case there are uses of the add between the add and the
3749 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00003750 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003751
Sanjoy Dasb0984472015-04-08 04:27:22 +00003752 switch (OCF) {
3753 case OCF_INVALID:
3754 llvm_unreachable("bad overflow check kind!");
3755
3756 case OCF_UNSIGNED_ADD: {
3757 OverflowResult OR = computeOverflowForUnsignedAdd(LHS, RHS, &OrigI);
3758 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003759 return SetResult(Builder.CreateNUWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003760 true);
3761
3762 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003763 return SetResult(Builder.CreateAdd(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003764
3765 // Fall through uadd into sadd
3766 LLVM_FALLTHROUGH;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003767 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003768 case OCF_SIGNED_ADD: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003769 // X + 0 -> {X, false}
3770 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003771 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003772
3773 // We can strength reduce this signed add into a regular add if we can prove
3774 // that it will never overflow.
3775 if (OCF == OCF_SIGNED_ADD)
Craig Topper2b1fc322017-05-22 06:25:31 +00003776 if (willNotOverflowSignedAdd(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003777 return SetResult(Builder.CreateNSWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003778 true);
Sanjoy Das72cb5e12015-06-05 18:04:42 +00003779 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003780 }
3781
3782 case OCF_UNSIGNED_SUB:
3783 case OCF_SIGNED_SUB: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003784 // X - 0 -> {X, false}
3785 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003786 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003787
3788 if (OCF == OCF_SIGNED_SUB) {
Craig Topper2b1fc322017-05-22 06:25:31 +00003789 if (willNotOverflowSignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003790 return SetResult(Builder.CreateNSWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003791 true);
3792 } else {
Craig Topper2b1fc322017-05-22 06:25:31 +00003793 if (willNotOverflowUnsignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003794 return SetResult(Builder.CreateNUWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003795 true);
3796 }
3797 break;
3798 }
3799
3800 case OCF_UNSIGNED_MUL: {
3801 OverflowResult OR = computeOverflowForUnsignedMul(LHS, RHS, &OrigI);
3802 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003803 return SetResult(Builder.CreateNUWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003804 true);
3805 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003806 return SetResult(Builder.CreateMul(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003807 LLVM_FALLTHROUGH;
3808 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003809 case OCF_SIGNED_MUL:
3810 // X * undef -> undef
3811 if (isa<UndefValue>(RHS))
Craig Topperbb4069e2017-07-07 23:16:26 +00003812 return SetResult(RHS, UndefValue::get(Builder.getInt1Ty()), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003813
David Majnemer27e89ba2015-05-21 23:04:21 +00003814 // X * 0 -> {0, false}
3815 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003816 return SetResult(RHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003817
David Majnemer27e89ba2015-05-21 23:04:21 +00003818 // X * 1 -> {X, false}
3819 if (match(RHS, m_One()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003820 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003821
3822 if (OCF == OCF_SIGNED_MUL)
Craig Topper2b1fc322017-05-22 06:25:31 +00003823 if (willNotOverflowSignedMul(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003824 return SetResult(Builder.CreateNSWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003825 true);
Sanjoy Dasc80dad62015-06-05 18:04:46 +00003826 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003827 }
3828
3829 return false;
3830}
3831
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00003832/// Recognize and process idiom involving test for multiplication
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003833/// overflow.
3834///
3835/// The caller has matched a pattern of the form:
3836/// I = cmp u (mul(zext A, zext B), V
3837/// The function checks if this is a test for overflow and if so replaces
3838/// multiplication with call to 'mul.with.overflow' intrinsic.
3839///
3840/// \param I Compare instruction.
3841/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
3842/// the compare instruction. Must be of integer type.
3843/// \param OtherVal The other argument of compare instruction.
3844/// \returns Instruction which must replace the compare instruction, NULL if no
3845/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00003846static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003847 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00003848 // Don't bother doing this transformation for pointers, don't do it for
3849 // vectors.
3850 if (!isa<IntegerType>(MulVal->getType()))
3851 return nullptr;
3852
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003853 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
3854 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00003855 auto *MulInstr = dyn_cast<Instruction>(MulVal);
3856 if (!MulInstr)
3857 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003858 assert(MulInstr->getOpcode() == Instruction::Mul);
3859
David Majnemer634ca232014-11-01 23:46:05 +00003860 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
3861 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003862 assert(LHS->getOpcode() == Instruction::ZExt);
3863 assert(RHS->getOpcode() == Instruction::ZExt);
3864 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
3865
3866 // Calculate type and width of the result produced by mul.with.overflow.
3867 Type *TyA = A->getType(), *TyB = B->getType();
3868 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
3869 WidthB = TyB->getPrimitiveSizeInBits();
3870 unsigned MulWidth;
3871 Type *MulType;
3872 if (WidthB > WidthA) {
3873 MulWidth = WidthB;
3874 MulType = TyB;
3875 } else {
3876 MulWidth = WidthA;
3877 MulType = TyA;
3878 }
3879
3880 // In order to replace the original mul with a narrower mul.with.overflow,
3881 // all uses must ignore upper bits of the product. The number of used low
3882 // bits must be not greater than the width of mul.with.overflow.
3883 if (MulVal->hasNUsesOrMore(2))
3884 for (User *U : MulVal->users()) {
3885 if (U == &I)
3886 continue;
3887 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3888 // Check if truncation ignores bits above MulWidth.
3889 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
3890 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003891 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003892 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3893 // Check if AND ignores bits above MulWidth.
3894 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00003895 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003896 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
3897 const APInt &CVal = CI->getValue();
3898 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003899 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00003900 } else {
3901 // In this case we could have the operand of the binary operation
3902 // being defined in another block, and performing the replacement
3903 // could break the dominance relation.
3904 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003905 }
3906 } else {
3907 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00003908 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003909 }
3910 }
3911
3912 // Recognize patterns
3913 switch (I.getPredicate()) {
3914 case ICmpInst::ICMP_EQ:
3915 case ICmpInst::ICMP_NE:
3916 // Recognize pattern:
3917 // mulval = mul(zext A, zext B)
3918 // cmp eq/neq mulval, zext trunc mulval
3919 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
3920 if (Zext->hasOneUse()) {
3921 Value *ZextArg = Zext->getOperand(0);
3922 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
3923 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
3924 break; //Recognized
3925 }
3926
3927 // Recognize pattern:
3928 // mulval = mul(zext A, zext B)
3929 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
3930 ConstantInt *CI;
3931 Value *ValToMask;
3932 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
3933 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00003934 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003935 const APInt &CVal = CI->getValue() + 1;
3936 if (CVal.isPowerOf2()) {
3937 unsigned MaskWidth = CVal.logBase2();
3938 if (MaskWidth == MulWidth)
3939 break; // Recognized
3940 }
3941 }
Craig Topperf40110f2014-04-25 05:29:35 +00003942 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003943
3944 case ICmpInst::ICMP_UGT:
3945 // Recognize pattern:
3946 // mulval = mul(zext A, zext B)
3947 // cmp ugt mulval, max
3948 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3949 APInt MaxVal = APInt::getMaxValue(MulWidth);
3950 MaxVal = MaxVal.zext(CI->getBitWidth());
3951 if (MaxVal.eq(CI->getValue()))
3952 break; // Recognized
3953 }
Craig Topperf40110f2014-04-25 05:29:35 +00003954 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003955
3956 case ICmpInst::ICMP_UGE:
3957 // Recognize pattern:
3958 // mulval = mul(zext A, zext B)
3959 // cmp uge mulval, max+1
3960 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3961 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
3962 if (MaxVal.eq(CI->getValue()))
3963 break; // Recognized
3964 }
Craig Topperf40110f2014-04-25 05:29:35 +00003965 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003966
3967 case ICmpInst::ICMP_ULE:
3968 // Recognize pattern:
3969 // mulval = mul(zext A, zext B)
3970 // cmp ule mulval, max
3971 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3972 APInt MaxVal = APInt::getMaxValue(MulWidth);
3973 MaxVal = MaxVal.zext(CI->getBitWidth());
3974 if (MaxVal.eq(CI->getValue()))
3975 break; // Recognized
3976 }
Craig Topperf40110f2014-04-25 05:29:35 +00003977 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003978
3979 case ICmpInst::ICMP_ULT:
3980 // Recognize pattern:
3981 // mulval = mul(zext A, zext B)
3982 // cmp ule mulval, max + 1
3983 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00003984 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003985 if (MaxVal.eq(CI->getValue()))
3986 break; // Recognized
3987 }
Craig Topperf40110f2014-04-25 05:29:35 +00003988 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003989
3990 default:
Craig Topperf40110f2014-04-25 05:29:35 +00003991 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003992 }
3993
Craig Topperbb4069e2017-07-07 23:16:26 +00003994 InstCombiner::BuilderTy &Builder = IC.Builder;
3995 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003996
3997 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
3998 Value *MulA = A, *MulB = B;
3999 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004000 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004001 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004002 MulB = Builder.CreateZExt(B, MulType);
Sanjay Patelaf674fb2015-12-14 17:24:23 +00004003 Value *F = Intrinsic::getDeclaration(I.getModule(),
4004 Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00004005 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004006 IC.Worklist.Add(MulInstr);
4007
4008 // If there are uses of mul result other than the comparison, we know that
4009 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004010 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004011 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004012 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Joseph Tremoulet6f406d42018-06-15 16:52:40 +00004013 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) {
4014 User *U = *UI++;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004015 if (U == &I || U == OtherVal)
4016 continue;
4017 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4018 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00004019 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004020 else
4021 TI->setOperand(0, Mul);
4022 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4023 assert(BO->getOpcode() == Instruction::And);
4024 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00004025 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
4026 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00004027 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00004028 Instruction *Zext =
4029 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
4030 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00004031 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004032 } else {
4033 llvm_unreachable("Unexpected Binary operation");
4034 }
Davide Italiano579064e2017-07-16 18:56:30 +00004035 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004036 }
4037 }
4038 if (isa<Instruction>(OtherVal))
4039 IC.Worklist.Add(cast<Instruction>(OtherVal));
4040
4041 // The original icmp gets replaced with the overflow value, maybe inverted
4042 // depending on predicate.
4043 bool Inverse = false;
4044 switch (I.getPredicate()) {
4045 case ICmpInst::ICMP_NE:
4046 break;
4047 case ICmpInst::ICMP_EQ:
4048 Inverse = true;
4049 break;
4050 case ICmpInst::ICMP_UGT:
4051 case ICmpInst::ICMP_UGE:
4052 if (I.getOperand(0) == MulVal)
4053 break;
4054 Inverse = true;
4055 break;
4056 case ICmpInst::ICMP_ULT:
4057 case ICmpInst::ICMP_ULE:
4058 if (I.getOperand(1) == MulVal)
4059 break;
4060 Inverse = true;
4061 break;
4062 default:
4063 llvm_unreachable("Unexpected predicate");
4064 }
4065 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004066 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004067 return BinaryOperator::CreateNot(Res);
4068 }
4069
4070 return ExtractValueInst::Create(Call, 1);
4071}
4072
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004073/// When performing a comparison against a constant, it is possible that not all
4074/// the bits in the LHS are demanded. This helper method computes the mask that
4075/// IS demanded.
Craig Topper3edda872017-09-22 18:57:23 +00004076static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) {
Craig Topper18887bf2017-09-20 23:48:58 +00004077 const APInt *RHS;
4078 if (!match(I.getOperand(1), m_APInt(RHS)))
4079 return APInt::getAllOnesValue(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004080
Craig Topper3edda872017-09-22 18:57:23 +00004081 // If this is a normal comparison, it demands all bits. If it is a sign bit
4082 // comparison, it only demands the sign bit.
4083 bool UnusedBit;
4084 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit))
4085 return APInt::getSignMask(BitWidth);
4086
Owen Andersond490c2d2011-01-11 00:36:45 +00004087 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004088 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00004089 // correspond to the trailing ones of the comparand. The value of these
4090 // bits doesn't impact the outcome of the comparison, because any value
4091 // greater than the RHS must differ in a bit higher than these due to carry.
Craig Topper18887bf2017-09-20 23:48:58 +00004092 case ICmpInst::ICMP_UGT:
4093 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004094
Owen Andersond490c2d2011-01-11 00:36:45 +00004095 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
4096 // Any value less than the RHS must differ in a higher bit because of carries.
Craig Topper18887bf2017-09-20 23:48:58 +00004097 case ICmpInst::ICMP_ULT:
4098 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004099
Owen Andersond490c2d2011-01-11 00:36:45 +00004100 default:
4101 return APInt::getAllOnesValue(BitWidth);
4102 }
Owen Andersond490c2d2011-01-11 00:36:45 +00004103}
Chris Lattner2188e402010-01-04 07:37:31 +00004104
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004105/// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst
Quentin Colombet5ab55552013-09-09 20:56:48 +00004106/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00004107/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00004108/// as subtract operands and their positions in those instructions.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004109/// The rationale is that several architectures use the same instruction for
4110/// both subtract and cmp. Thus, it is better if the order of those operands
Quentin Colombet5ab55552013-09-09 20:56:48 +00004111/// match.
4112/// \return true if Op0 and Op1 should be swapped.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004113static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) {
4114 // Filter out pointer values as those cannot appear directly in subtract.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004115 // FIXME: we may want to go through inttoptrs or bitcasts.
4116 if (Op0->getType()->isPointerTy())
4117 return false;
Sanjay Patel1ea86972018-02-02 19:08:12 +00004118 // If a subtract already has the same operands as a compare, swapping would be
4119 // bad. If a subtract has the same operands as a compare but in reverse order,
4120 // then swapping is good.
4121 int GoodToSwap = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00004122 for (const User *U : Op0->users()) {
Sanjay Patel1ea86972018-02-02 19:08:12 +00004123 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0))))
4124 GoodToSwap++;
4125 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1))))
4126 GoodToSwap--;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004127 }
Sanjay Patel1ea86972018-02-02 19:08:12 +00004128 return GoodToSwap > 0;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004129}
4130
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004131/// Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00004132/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004133///
4134/// \param DI Definition
4135/// \param UI Use
4136/// \param DB Block that must dominate all uses of \p DI outside
4137/// the parent block
4138/// \return true when \p UI is the only use of \p DI in the parent block
4139/// and all other uses of \p DI are in blocks dominated by \p DB.
4140///
4141bool InstCombiner::dominatesAllUses(const Instruction *DI,
4142 const Instruction *UI,
4143 const BasicBlock *DB) const {
4144 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00004145 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004146 if (!DI->getParent())
4147 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004148 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004149 if (DI->getParent() != UI->getParent())
4150 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004151 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004152 if (DI->getParent() == DB)
4153 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004154 for (const User *U : DI->users()) {
4155 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00004156 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004157 return false;
4158 }
4159 return true;
4160}
4161
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004162/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004163static bool isChainSelectCmpBranch(const SelectInst *SI) {
4164 const BasicBlock *BB = SI->getParent();
4165 if (!BB)
4166 return false;
4167 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
4168 if (!BI || BI->getNumSuccessors() != 2)
4169 return false;
4170 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
4171 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
4172 return false;
4173 return true;
4174}
4175
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004176/// True when a select result is replaced by one of its operands
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004177/// in select-icmp sequence. This will eventually result in the elimination
4178/// of the select.
4179///
4180/// \param SI Select instruction
4181/// \param Icmp Compare instruction
4182/// \param SIOpd Operand that replaces the select
4183///
4184/// Notes:
4185/// - The replacement is global and requires dominator information
4186/// - The caller is responsible for the actual replacement
4187///
4188/// Example:
4189///
4190/// entry:
4191/// %4 = select i1 %3, %C* %0, %C* null
4192/// %5 = icmp eq %C* %4, null
4193/// br i1 %5, label %9, label %7
4194/// ...
4195/// ; <label>:7 ; preds = %entry
4196/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
4197/// ...
4198///
4199/// can be transformed to
4200///
4201/// %5 = icmp eq %C* %0, null
4202/// %6 = select i1 %3, i1 %5, i1 true
4203/// br i1 %6, label %9, label %7
4204/// ...
4205/// ; <label>:7 ; preds = %entry
4206/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4207///
4208/// Similar when the first operand of the select is a constant or/and
4209/// the compare is for not equal rather than equal.
4210///
4211/// NOTE: The function is only called when the select and compare constants
4212/// are equal, the optimization can work only for EQ predicates. This is not a
4213/// major restriction since a NE compare should be 'normalized' to an equal
4214/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004215/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004216bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4217 const ICmpInst *Icmp,
4218 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004219 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004220 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4221 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004222 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004223 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004224 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4225 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4226 // replaced can be reached on either path. So the uniqueness check
4227 // guarantees that the path all uses of SI (outside SI's parent) are on
4228 // is disjoint from all other paths out of SI. But that information
4229 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004230 // of compile-time. It should also be noticed that we check for a single
4231 // predecessor and not only uniqueness. This to handle the situation when
4232 // Succ and Succ1 points to the same basic block.
4233 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004234 NumSel++;
4235 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4236 return true;
4237 }
4238 }
4239 return false;
4240}
4241
Sanjay Patel3151dec2016-09-12 15:24:31 +00004242/// Try to fold the comparison based on range information we can get by checking
4243/// whether bits are known to be zero or one in the inputs.
4244Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4245 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4246 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004247 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004248
4249 // Get scalar or pointer size.
4250 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4251 ? Ty->getScalarSizeInBits()
Elena Demikhovsky945b7e52018-02-14 06:58:08 +00004252 : DL.getIndexTypeSizeInBits(Ty->getScalarType());
Sanjay Patel3151dec2016-09-12 15:24:31 +00004253
4254 if (!BitWidth)
4255 return nullptr;
4256
Craig Topperb45eabc2017-04-26 16:39:58 +00004257 KnownBits Op0Known(BitWidth);
4258 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004259
Craig Topper47596dd2017-03-25 06:52:52 +00004260 if (SimplifyDemandedBits(&I, 0,
Craig Topper3edda872017-09-22 18:57:23 +00004261 getDemandedBitsLHSMask(I, BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004262 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004263 return &I;
4264
Craig Topper47596dd2017-03-25 06:52:52 +00004265 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004266 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004267 return &I;
4268
4269 // Given the known and unknown bits, compute a range that the LHS could be
4270 // in. Compute the Min, Max and RHS values based on the known bits. For the
4271 // EQ and NE we use unsigned values.
4272 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4273 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4274 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004275 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4276 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004277 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004278 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4279 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004280 }
4281
Sanjay Patelc63f9012018-01-04 14:31:56 +00004282 // If Min and Max are known to be the same, then SimplifyDemandedBits figured
4283 // out that the LHS or RHS is a constant. Constant fold this now, so that
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004284 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004285 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004286 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004287 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004288 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004289
4290 // Based on the range information we know about the LHS, see if we can
4291 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004292 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004293 default:
4294 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004295 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004296 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004297 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4298 return Pred == CmpInst::ICMP_EQ
4299 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4300 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4301 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004302
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004303 // If all bits are known zero except for one, then we know at most one bit
4304 // is set. If the comparison is against zero, then this is a check to see if
4305 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004306 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004307 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004308 // If the LHS is an AND with the same constant, look through it.
4309 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004310 const APInt *LHSC;
4311 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4312 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004313 LHS = Op0;
4314
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004315 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004316 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4317 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004318 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004319 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004320 // ((1 << X) & 8) == 0 -> X != 3
4321 // ((1 << X) & 8) != 0 -> X == 3
4322 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4323 auto NewPred = ICmpInst::getInversePredicate(Pred);
4324 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004325 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004326 // ((1 << X) & 7) == 0 -> X >= 3
4327 // ((1 << X) & 7) != 0 -> X < 3
4328 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4329 auto NewPred =
4330 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4331 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004332 }
4333 }
4334
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004335 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004336 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004337 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004338 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4339 // ((8 >>u X) & 1) == 0 -> X != 3
4340 // ((8 >>u X) & 1) != 0 -> X == 3
4341 unsigned CmpVal = CI->countTrailingZeros();
4342 auto NewPred = ICmpInst::getInversePredicate(Pred);
4343 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4344 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004345 }
4346 break;
4347 }
4348 case ICmpInst::ICMP_ULT: {
4349 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4350 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4351 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4352 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4353 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4354 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4355
Craig Topper0cd25942017-09-27 22:57:18 +00004356 const APInt *CmpC;
4357 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004358 // A <u C -> A == C-1 if min(A)+1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004359 if (*CmpC == Op0Min + 1)
Craig Topper2c9b7d72017-09-22 18:57:20 +00004360 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004361 ConstantInt::get(Op1->getType(), *CmpC - 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004362 // X <u C --> X == 0, if the number of zero bits in the bottom of X
4363 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004364 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2())
Craig Topper30dc9792017-09-25 21:15:00 +00004365 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4366 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004367 }
4368 break;
4369 }
4370 case ICmpInst::ICMP_UGT: {
4371 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4372 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004373 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4374 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004375 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4376 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4377
Craig Topper0cd25942017-09-27 22:57:18 +00004378 const APInt *CmpC;
4379 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004380 // A >u C -> A == C+1 if max(a)-1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004381 if (*CmpC == Op0Max - 1)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004382 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004383 ConstantInt::get(Op1->getType(), *CmpC + 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004384 // X >u C --> X != 0, if the number of zero bits in the bottom of X
4385 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004386 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits())
Craig Topper30dc9792017-09-25 21:15:00 +00004387 return new ICmpInst(ICmpInst::ICMP_NE, Op0,
4388 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004389 }
4390 break;
4391 }
Craig Topper0cd25942017-09-27 22:57:18 +00004392 case ICmpInst::ICMP_SLT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004393 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4394 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4395 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4396 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4397 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4398 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004399 const APInt *CmpC;
4400 if (match(Op1, m_APInt(CmpC))) {
4401 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004402 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004403 ConstantInt::get(Op1->getType(), *CmpC - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004404 }
4405 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004406 }
4407 case ICmpInst::ICMP_SGT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004408 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4409 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4410 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4411 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004412 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4413 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004414 const APInt *CmpC;
4415 if (match(Op1, m_APInt(CmpC))) {
4416 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004417 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004418 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004419 }
4420 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004421 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004422 case ICmpInst::ICMP_SGE:
4423 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4424 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4425 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4426 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4427 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004428 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B)
4429 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004430 break;
4431 case ICmpInst::ICMP_SLE:
4432 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4433 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4434 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4435 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4436 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004437 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B)
4438 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004439 break;
4440 case ICmpInst::ICMP_UGE:
4441 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4442 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4443 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4444 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4445 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004446 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B)
4447 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004448 break;
4449 case ICmpInst::ICMP_ULE:
4450 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4451 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4452 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4453 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4454 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004455 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B)
4456 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004457 break;
4458 }
4459
4460 // Turn a signed comparison into an unsigned one if both operands are known to
4461 // have the same sign.
4462 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004463 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4464 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004465 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4466
4467 return nullptr;
4468}
4469
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004470/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4471/// it into the appropriate icmp lt or icmp gt instruction. This transform
4472/// allows them to be folded in visitICmpInst.
Sanjay Patele9b2c322016-05-17 00:57:57 +00004473static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
4474 ICmpInst::Predicate Pred = I.getPredicate();
4475 if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGE &&
4476 Pred != ICmpInst::ICMP_ULE && Pred != ICmpInst::ICMP_UGE)
4477 return nullptr;
4478
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004479 Value *Op0 = I.getOperand(0);
4480 Value *Op1 = I.getOperand(1);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004481 auto *Op1C = dyn_cast<Constant>(Op1);
4482 if (!Op1C)
4483 return nullptr;
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004484
Sanjay Patele9b2c322016-05-17 00:57:57 +00004485 // Check if the constant operand can be safely incremented/decremented without
4486 // overflowing/underflowing. For scalars, SimplifyICmpInst has already handled
4487 // the edge cases for us, so we just assert on them. For vectors, we must
4488 // handle the edge cases.
4489 Type *Op1Type = Op1->getType();
4490 bool IsSigned = I.isSigned();
4491 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE);
Sanjay Patel18254932016-05-17 01:12:31 +00004492 auto *CI = dyn_cast<ConstantInt>(Op1C);
4493 if (CI) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004494 // A <= MAX -> TRUE ; A >= MIN -> TRUE
4495 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned));
4496 } else if (Op1Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004497 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004498 // are for scalar, we could remove the min/max checks. However, to do that,
4499 // we would have to use insertelement/shufflevector to replace edge values.
4500 unsigned NumElts = Op1Type->getVectorNumElements();
4501 for (unsigned i = 0; i != NumElts; ++i) {
4502 Constant *Elt = Op1C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004503 if (!Elt)
4504 return nullptr;
4505
Sanjay Patele9b2c322016-05-17 00:57:57 +00004506 if (isa<UndefValue>(Elt))
4507 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004508
Sanjay Patele9b2c322016-05-17 00:57:57 +00004509 // Bail out if we can't determine if this constant is min/max or if we
4510 // know that this constant is min/max.
4511 auto *CI = dyn_cast<ConstantInt>(Elt);
4512 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned)))
4513 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004514 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004515 } else {
4516 // ConstantExpr?
4517 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004518 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004519
Sanjay Patele9b2c322016-05-17 00:57:57 +00004520 // Increment or decrement the constant and set the new comparison predicate:
4521 // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT
Sanjay Patel22b01fe2016-05-17 20:20:40 +00004522 Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004523 CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT;
4524 NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred;
4525 return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne));
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004526}
4527
Sanjay Patele5747e32017-05-17 22:15:07 +00004528/// Integer compare with boolean values can always be turned into bitwise ops.
4529static Instruction *canonicalizeICmpBool(ICmpInst &I,
4530 InstCombiner::BuilderTy &Builder) {
4531 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00004532 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00004533
Sanjay Patelba212c22017-05-17 22:29:40 +00004534 // A boolean compared to true/false can be simplified to Op0/true/false in
4535 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
4536 // Cases not handled by InstSimplify are always 'not' of Op0.
4537 if (match(B, m_Zero())) {
4538 switch (I.getPredicate()) {
4539 case CmpInst::ICMP_EQ: // A == 0 -> !A
4540 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
4541 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
4542 return BinaryOperator::CreateNot(A);
4543 default:
4544 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4545 }
4546 } else if (match(B, m_One())) {
4547 switch (I.getPredicate()) {
4548 case CmpInst::ICMP_NE: // A != 1 -> !A
4549 case CmpInst::ICMP_ULT: // A <u 1 -> !A
4550 case CmpInst::ICMP_SGT: // A >s -1 -> !A
4551 return BinaryOperator::CreateNot(A);
4552 default:
4553 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4554 }
4555 }
4556
Sanjay Patele5747e32017-05-17 22:15:07 +00004557 switch (I.getPredicate()) {
4558 default:
4559 llvm_unreachable("Invalid icmp instruction!");
4560 case ICmpInst::ICMP_EQ:
4561 // icmp eq i1 A, B -> ~(A ^ B)
4562 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
4563
4564 case ICmpInst::ICMP_NE:
4565 // icmp ne i1 A, B -> A ^ B
4566 return BinaryOperator::CreateXor(A, B);
4567
4568 case ICmpInst::ICMP_UGT:
4569 // icmp ugt -> icmp ult
4570 std::swap(A, B);
4571 LLVM_FALLTHROUGH;
4572 case ICmpInst::ICMP_ULT:
4573 // icmp ult i1 A, B -> ~A & B
4574 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
4575
4576 case ICmpInst::ICMP_SGT:
4577 // icmp sgt -> icmp slt
4578 std::swap(A, B);
4579 LLVM_FALLTHROUGH;
4580 case ICmpInst::ICMP_SLT:
4581 // icmp slt i1 A, B -> A & ~B
4582 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
4583
4584 case ICmpInst::ICMP_UGE:
4585 // icmp uge -> icmp ule
4586 std::swap(A, B);
4587 LLVM_FALLTHROUGH;
4588 case ICmpInst::ICMP_ULE:
4589 // icmp ule i1 A, B -> ~A | B
4590 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
4591
4592 case ICmpInst::ICMP_SGE:
4593 // icmp sge -> icmp sle
4594 std::swap(A, B);
4595 LLVM_FALLTHROUGH;
4596 case ICmpInst::ICMP_SLE:
4597 // icmp sle i1 A, B -> A | ~B
4598 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
4599 }
4600}
4601
Sanjay Patel039f5562018-08-16 12:52:17 +00004602static Instruction *foldVectorCmp(CmpInst &Cmp,
4603 InstCombiner::BuilderTy &Builder) {
4604 // If both arguments of the cmp are shuffles that use the same mask and
4605 // shuffle within a single vector, move the shuffle after the cmp.
4606 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1);
4607 Value *V1, *V2;
4608 Constant *M;
4609 if (match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Constant(M))) &&
4610 match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_Specific(M))) &&
4611 V1->getType() == V2->getType() &&
4612 (LHS->hasOneUse() || RHS->hasOneUse())) {
4613 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M
4614 CmpInst::Predicate P = Cmp.getPredicate();
4615 Value *NewCmp = isa<ICmpInst>(Cmp) ? Builder.CreateICmp(P, V1, V2)
4616 : Builder.CreateFCmp(P, V1, V2);
4617 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M);
4618 }
4619 return nullptr;
4620}
4621
Chris Lattner2188e402010-01-04 07:37:31 +00004622Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
4623 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00004624 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00004625 unsigned Op0Cplxity = getComplexity(Op0);
4626 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004627
Chris Lattner2188e402010-01-04 07:37:31 +00004628 /// Orders the operands of the compare so that they are listed from most
4629 /// complex to least complex. This puts constants before unary operators,
4630 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004631 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00004632 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004633 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00004634 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00004635 Changed = true;
4636 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004637
Daniel Berlin2c75c632017-04-26 20:56:07 +00004638 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
4639 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004640 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004641
Uriel Korach18972232017-09-10 08:31:22 +00004642 // Comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00004643 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00004644 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004645 Value *Cond, *SelectTrue, *SelectFalse;
4646 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00004647 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004648 if (Value *V = dyn_castNegVal(SelectTrue)) {
4649 if (V == SelectFalse)
4650 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
4651 }
4652 else if (Value *V = dyn_castNegVal(SelectFalse)) {
4653 if (V == SelectTrue)
4654 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00004655 }
4656 }
4657 }
4658
Craig Topperfde47232017-07-09 07:04:03 +00004659 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00004660 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00004661 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004662
Sanjay Patele9b2c322016-05-17 00:57:57 +00004663 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004664 return NewICmp;
4665
Sanjay Patel06b127a2016-09-15 14:37:50 +00004666 if (Instruction *Res = foldICmpWithConstant(I))
4667 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004668
Max Kazantsev20da7e42018-07-06 04:04:13 +00004669 if (Instruction *Res = foldICmpUsingKnownBits(I))
4670 return Res;
4671
Chris Lattner2188e402010-01-04 07:37:31 +00004672 // Test if the ICmpInst instruction is used exclusively by a select as
4673 // part of a minimum or maximum operation. If so, refrain from doing
4674 // any other folding. This helps out other analyses which understand
4675 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4676 // and CodeGen. And in this case, at least one of the comparison
4677 // operands has at least one user besides the compare (the select),
4678 // which would often largely negate the benefit of folding anyway.
Craig Topperd3e57812017-11-12 02:28:21 +00004679 //
4680 // Do the same for the other patterns recognized by matchSelectPattern.
Chris Lattner2188e402010-01-04 07:37:31 +00004681 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00004682 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
4683 Value *A, *B;
4684 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
4685 if (SPR.Flavor != SPF_UNKNOWN)
Craig Topperf40110f2014-04-25 05:29:35 +00004686 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00004687 }
Chris Lattner2188e402010-01-04 07:37:31 +00004688
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00004689 // Do this after checking for min/max to prevent infinite looping.
4690 if (Instruction *Res = foldICmpWithZero(I))
4691 return Res;
4692
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00004693 // FIXME: We only do this after checking for min/max to prevent infinite
4694 // looping caused by a reverse canonicalization of these patterns for min/max.
4695 // FIXME: The organization of folds is a mess. These would naturally go into
4696 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
4697 // down here after the min/max restriction.
4698 ICmpInst::Predicate Pred = I.getPredicate();
4699 const APInt *C;
4700 if (match(Op1, m_APInt(C))) {
4701 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
4702 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
4703 Constant *Zero = Constant::getNullValue(Op0->getType());
4704 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
4705 }
4706
4707 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
4708 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
4709 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
4710 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
4711 }
4712 }
4713
Sanjay Patelf58f68c2016-09-10 15:03:44 +00004714 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00004715 return Res;
4716
Sanjay Patel10494b22016-09-16 16:10:22 +00004717 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
4718 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004719
4720 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
4721 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00004722 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00004723 return NI;
4724 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004725 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00004726 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
4727 return NI;
4728
Hans Wennborgf1f36512015-10-07 00:20:07 +00004729 // Try to optimize equality comparisons against alloca-based pointers.
4730 if (Op0->getType()->isPointerTy() && I.isEquality()) {
4731 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
4732 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004733 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004734 return New;
4735 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004736 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004737 return New;
4738 }
4739
Sanjay Patel841aac02018-03-25 14:01:42 +00004740 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast.
Roman Lebedeve6da3062018-03-18 15:53:02 +00004741 Value *X;
Sanjay Patel745a9c62018-03-24 15:45:02 +00004742 if (match(Op0, m_BitCast(m_SIToFP(m_Value(X))))) {
Sanjay Patel841aac02018-03-25 14:01:42 +00004743 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0
4744 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0
4745 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0
4746 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0
4747 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT ||
4748 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) &&
4749 match(Op1, m_Zero()))
Sanjay Patel745a9c62018-03-24 15:45:02 +00004750 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patel841aac02018-03-25 14:01:42 +00004751
4752 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1
4753 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One()))
4754 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1));
4755
4756 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1
Sanjay Patel745a9c62018-03-24 15:45:02 +00004757 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes()))
4758 return new ICmpInst(Pred, X, ConstantInt::getAllOnesValue(X->getType()));
4759 }
Roman Lebedeve6da3062018-03-18 15:53:02 +00004760
4761 // Zero-equality checks are preserved through unsigned floating-point casts:
4762 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0
4763 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0
4764 if (match(Op0, m_BitCast(m_UIToFP(m_Value(X)))))
4765 if (I.isEquality() && match(Op1, m_Zero()))
4766 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
4767
Chris Lattner2188e402010-01-04 07:37:31 +00004768 // Test to see if the operands of the icmp are casted versions of other
4769 // values. If the ptr->ptr cast can be stripped off both arguments, we do so
4770 // now.
4771 if (BitCastInst *CI = dyn_cast<BitCastInst>(Op0)) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004772 if (Op0->getType()->isPointerTy() &&
4773 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004774 // We keep moving the cast from the left operand over to the right
4775 // operand, where it can often be eliminated completely.
4776 Op0 = CI->getOperand(0);
4777
4778 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
4779 // so eliminate it as well.
4780 if (BitCastInst *CI2 = dyn_cast<BitCastInst>(Op1))
4781 Op1 = CI2->getOperand(0);
4782
4783 // If Op1 is a constant, we can fold the cast into the constant.
4784 if (Op0->getType() != Op1->getType()) {
4785 if (Constant *Op1C = dyn_cast<Constant>(Op1)) {
4786 Op1 = ConstantExpr::getBitCast(Op1C, Op0->getType());
4787 } else {
4788 // Otherwise, cast the RHS right before the icmp
Craig Topperbb4069e2017-07-07 23:16:26 +00004789 Op1 = Builder.CreateBitCast(Op1, Op0->getType());
Chris Lattner2188e402010-01-04 07:37:31 +00004790 }
4791 }
4792 return new ICmpInst(I.getPredicate(), Op0, Op1);
4793 }
4794 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004795
Chris Lattner2188e402010-01-04 07:37:31 +00004796 if (isa<CastInst>(Op0)) {
4797 // Handle the special case of: icmp (cast bool to X), <cst>
4798 // This comes up when you have code like
4799 // int X = A < B;
4800 // if (X) ...
4801 // For generality, we handle any zero-extension of any operand comparison
4802 // with a constant or another cast from the same type.
4803 if (isa<Constant>(Op1) || isa<CastInst>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004804 if (Instruction *R = foldICmpWithCastAndCast(I))
Chris Lattner2188e402010-01-04 07:37:31 +00004805 return R;
4806 }
Chris Lattner2188e402010-01-04 07:37:31 +00004807
Sanjay Patel10494b22016-09-16 16:10:22 +00004808 if (Instruction *Res = foldICmpBinOp(I))
4809 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00004810
Sanjay Pateldd46b522016-12-19 17:32:37 +00004811 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00004812 return Res;
4813
Sanjay Patel10494b22016-09-16 16:10:22 +00004814 {
4815 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00004816 // Transform (A & ~B) == 0 --> (A & B) != 0
4817 // and (A & ~B) != 0 --> (A & B) == 0
4818 // if A is a power of 2.
4819 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00004820 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00004821 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00004822 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00004823 Op1);
4824
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004825 // ~X < ~Y --> Y < X
4826 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004827 if (match(Op0, m_Not(m_Value(A)))) {
4828 if (match(Op1, m_Not(m_Value(B))))
4829 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004830
Sanjay Patelce241f42017-06-02 16:29:41 +00004831 const APInt *C;
4832 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004833 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00004834 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004835 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00004836
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004837 Instruction *AddI = nullptr;
4838 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
4839 m_Instruction(AddI))) &&
4840 isa<IntegerType>(A->getType())) {
4841 Value *Result;
4842 Constant *Overflow;
4843 if (OptimizeOverflowCheck(OCF_UNSIGNED_ADD, A, B, *AddI, Result,
4844 Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00004845 replaceInstUsesWith(*AddI, Result);
4846 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004847 }
4848 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004849
4850 // (zext a) * (zext b) --> llvm.umul.with.overflow.
4851 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004852 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004853 return R;
4854 }
4855 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004856 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004857 return R;
4858 }
Chris Lattner2188e402010-01-04 07:37:31 +00004859 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004860
Sanjay Patel10494b22016-09-16 16:10:22 +00004861 if (Instruction *Res = foldICmpEquality(I))
4862 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004863
David Majnemerc1eca5a2014-11-06 23:23:30 +00004864 // The 'cmpxchg' instruction returns an aggregate containing the old value and
4865 // an i1 which indicates whether or not we successfully did the swap.
4866 //
4867 // Replace comparisons between the old value and the expected value with the
4868 // indicator that 'cmpxchg' returns.
4869 //
4870 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
4871 // spuriously fail. In those cases, the old value may equal the expected
4872 // value but it is possible for the swap to not occur.
4873 if (I.getPredicate() == ICmpInst::ICMP_EQ)
4874 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
4875 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
4876 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
4877 !ACXI->isWeak())
4878 return ExtractValueInst::Create(ACXI, 1);
4879
Chris Lattner2188e402010-01-04 07:37:31 +00004880 {
Craig Topperbee74792018-08-20 23:04:25 +00004881 Value *X;
4882 const APInt *C;
Chris Lattner2188e402010-01-04 07:37:31 +00004883 // icmp X+Cst, X
Craig Topperbee74792018-08-20 23:04:25 +00004884 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X)
4885 return foldICmpAddOpConst(X, *C, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004886
4887 // icmp X, X+Cst
Craig Topperbee74792018-08-20 23:04:25 +00004888 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X)
4889 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004890 }
Roman Lebedev68d54cf2018-07-11 19:05:04 +00004891
Sanjay Patel039f5562018-08-16 12:52:17 +00004892 if (I.getType()->isVectorTy())
4893 if (Instruction *Res = foldVectorCmp(I, Builder))
4894 return Res;
4895
Craig Topperf40110f2014-04-25 05:29:35 +00004896 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004897}
4898
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004899/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00004900Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00004901 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00004902 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004903 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00004904
Chris Lattner2188e402010-01-04 07:37:31 +00004905 // Get the width of the mantissa. We don't want to hack on conversions that
4906 // might lose information from the integer, e.g. "i64 -> float"
4907 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00004908 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00004909
Matt Arsenault55e73122015-01-06 15:50:59 +00004910 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
4911
Chris Lattner2188e402010-01-04 07:37:31 +00004912 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004913
Matt Arsenault55e73122015-01-06 15:50:59 +00004914 if (I.isEquality()) {
4915 FCmpInst::Predicate P = I.getPredicate();
4916 bool IsExact = false;
4917 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
4918 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
4919
4920 // If the floating point constant isn't an integer value, we know if we will
4921 // ever compare equal / not equal to it.
4922 if (!IsExact) {
4923 // TODO: Can never be -0.0 and other non-representable values
4924 APFloat RHSRoundInt(RHS);
4925 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
4926 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
4927 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00004928 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00004929
4930 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00004931 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00004932 }
4933 }
4934
4935 // TODO: If the constant is exactly representable, is it always OK to do
4936 // equality compares as integer?
4937 }
4938
Arch D. Robison8ed08542015-09-15 17:51:59 +00004939 // Check to see that the input is converted from an integer type that is small
4940 // enough that preserves all bits. TODO: check here for "known" sign bits.
4941 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
4942 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00004943
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004944 // Following test does NOT adjust InputSize downwards for signed inputs,
4945 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00004946 // to distinguish it from one less than that value.
4947 if ((int)InputSize > MantissaWidth) {
4948 // Conversion would lose accuracy. Check if loss can impact comparison.
4949 int Exp = ilogb(RHS);
4950 if (Exp == APFloat::IEK_Inf) {
4951 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004952 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00004953 // Conversion could create infinity.
4954 return nullptr;
4955 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004956 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00004957 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004958 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00004959 // Conversion could affect comparison.
4960 return nullptr;
4961 }
4962 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004963
Chris Lattner2188e402010-01-04 07:37:31 +00004964 // Otherwise, we can potentially simplify the comparison. We know that it
4965 // will always come through as an integer value and we know the constant is
4966 // not a NAN (it would have been previously simplified).
4967 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00004968
Chris Lattner2188e402010-01-04 07:37:31 +00004969 ICmpInst::Predicate Pred;
4970 switch (I.getPredicate()) {
4971 default: llvm_unreachable("Unexpected predicate!");
4972 case FCmpInst::FCMP_UEQ:
4973 case FCmpInst::FCMP_OEQ:
4974 Pred = ICmpInst::ICMP_EQ;
4975 break;
4976 case FCmpInst::FCMP_UGT:
4977 case FCmpInst::FCMP_OGT:
4978 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
4979 break;
4980 case FCmpInst::FCMP_UGE:
4981 case FCmpInst::FCMP_OGE:
4982 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
4983 break;
4984 case FCmpInst::FCMP_ULT:
4985 case FCmpInst::FCMP_OLT:
4986 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
4987 break;
4988 case FCmpInst::FCMP_ULE:
4989 case FCmpInst::FCMP_OLE:
4990 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
4991 break;
4992 case FCmpInst::FCMP_UNE:
4993 case FCmpInst::FCMP_ONE:
4994 Pred = ICmpInst::ICMP_NE;
4995 break;
4996 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00004997 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004998 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00004999 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005000 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005001
Chris Lattner2188e402010-01-04 07:37:31 +00005002 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005003
Chris Lattner2188e402010-01-04 07:37:31 +00005004 // See if the FP constant is too large for the integer. For example,
5005 // comparing an i8 to 300.0.
5006 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005007
Chris Lattner2188e402010-01-04 07:37:31 +00005008 if (!LHSUnsigned) {
5009 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
5010 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005011 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005012 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
5013 APFloat::rmNearestTiesToEven);
5014 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
5015 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
5016 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005017 return replaceInstUsesWith(I, Builder.getTrue());
5018 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005019 }
5020 } else {
5021 // If the RHS value is > UnsignedMax, fold the comparison. This handles
5022 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005023 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005024 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
5025 APFloat::rmNearestTiesToEven);
5026 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
5027 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
5028 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005029 return replaceInstUsesWith(I, Builder.getTrue());
5030 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005031 }
5032 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005033
Chris Lattner2188e402010-01-04 07:37:31 +00005034 if (!LHSUnsigned) {
5035 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005036 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005037 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
5038 APFloat::rmNearestTiesToEven);
5039 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
5040 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
5041 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005042 return replaceInstUsesWith(I, Builder.getTrue());
5043 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005044 }
Devang Patel698452b2012-02-13 23:05:18 +00005045 } else {
5046 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005047 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00005048 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
5049 APFloat::rmNearestTiesToEven);
5050 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
5051 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
5052 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005053 return replaceInstUsesWith(I, Builder.getTrue());
5054 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00005055 }
Chris Lattner2188e402010-01-04 07:37:31 +00005056 }
5057
5058 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
5059 // [0, UMAX], but it may still be fractional. See if it is fractional by
5060 // casting the FP value to the integer value and back, checking for equality.
5061 // Don't do this for zero, because -0.0 is not fractional.
5062 Constant *RHSInt = LHSUnsigned
5063 ? ConstantExpr::getFPToUI(RHSC, IntTy)
5064 : ConstantExpr::getFPToSI(RHSC, IntTy);
5065 if (!RHS.isZero()) {
5066 bool Equal = LHSUnsigned
5067 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
5068 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
5069 if (!Equal) {
5070 // If we had a comparison against a fractional value, we have to adjust
5071 // the compare predicate and sometimes the value. RHSC is rounded towards
5072 // zero at this point.
5073 switch (Pred) {
5074 default: llvm_unreachable("Unexpected integer comparison!");
5075 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00005076 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005077 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00005078 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005079 case ICmpInst::ICMP_ULE:
5080 // (float)int <= 4.4 --> int <= 4
5081 // (float)int <= -4.4 --> false
5082 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005083 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005084 break;
5085 case ICmpInst::ICMP_SLE:
5086 // (float)int <= 4.4 --> int <= 4
5087 // (float)int <= -4.4 --> int < -4
5088 if (RHS.isNegative())
5089 Pred = ICmpInst::ICMP_SLT;
5090 break;
5091 case ICmpInst::ICMP_ULT:
5092 // (float)int < -4.4 --> false
5093 // (float)int < 4.4 --> int <= 4
5094 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005095 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005096 Pred = ICmpInst::ICMP_ULE;
5097 break;
5098 case ICmpInst::ICMP_SLT:
5099 // (float)int < -4.4 --> int < -4
5100 // (float)int < 4.4 --> int <= 4
5101 if (!RHS.isNegative())
5102 Pred = ICmpInst::ICMP_SLE;
5103 break;
5104 case ICmpInst::ICMP_UGT:
5105 // (float)int > 4.4 --> int > 4
5106 // (float)int > -4.4 --> true
5107 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005108 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005109 break;
5110 case ICmpInst::ICMP_SGT:
5111 // (float)int > 4.4 --> int > 4
5112 // (float)int > -4.4 --> int >= -4
5113 if (RHS.isNegative())
5114 Pred = ICmpInst::ICMP_SGE;
5115 break;
5116 case ICmpInst::ICMP_UGE:
5117 // (float)int >= -4.4 --> true
5118 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00005119 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005120 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005121 Pred = ICmpInst::ICMP_UGT;
5122 break;
5123 case ICmpInst::ICMP_SGE:
5124 // (float)int >= -4.4 --> int >= -4
5125 // (float)int >= 4.4 --> int > 4
5126 if (!RHS.isNegative())
5127 Pred = ICmpInst::ICMP_SGT;
5128 break;
5129 }
5130 }
5131 }
5132
5133 // Lower this FP comparison into an appropriate integer version of the
5134 // comparison.
5135 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
5136}
5137
5138Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
5139 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005140
Chris Lattner2188e402010-01-04 07:37:31 +00005141 /// Orders the operands of the compare so that they are listed from most
5142 /// complex to least complex. This puts constants before unary operators,
5143 /// before binary operators.
5144 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
5145 I.swapOperands();
5146 Changed = true;
5147 }
5148
Sanjay Patel6b139462017-09-02 15:11:55 +00005149 const CmpInst::Predicate Pred = I.getPredicate();
Chris Lattner2188e402010-01-04 07:37:31 +00005150 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel6b139462017-09-02 15:11:55 +00005151 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(),
5152 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005153 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00005154
5155 // Simplify 'fcmp pred X, X'
5156 if (Op0 == Op1) {
Sanjay Patel6b139462017-09-02 15:11:55 +00005157 switch (Pred) {
5158 default: break;
Chris Lattner2188e402010-01-04 07:37:31 +00005159 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
5160 case FCmpInst::FCMP_ULT: // True if unordered or less than
5161 case FCmpInst::FCMP_UGT: // True if unordered or greater than
5162 case FCmpInst::FCMP_UNE: // True if unordered or not equal
5163 // Canonicalize these to be 'fcmp uno %X, 0.0'.
5164 I.setPredicate(FCmpInst::FCMP_UNO);
5165 I.setOperand(1, Constant::getNullValue(Op0->getType()));
5166 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005167
Chris Lattner2188e402010-01-04 07:37:31 +00005168 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
5169 case FCmpInst::FCMP_OEQ: // True if ordered and equal
5170 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
5171 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
5172 // Canonicalize these to be 'fcmp ord %X, 0.0'.
5173 I.setPredicate(FCmpInst::FCMP_ORD);
5174 I.setOperand(1, Constant::getNullValue(Op0->getType()));
5175 return &I;
5176 }
5177 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005178
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005179 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand,
5180 // then canonicalize the operand to 0.0.
5181 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) {
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005182 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) {
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005183 I.setOperand(0, ConstantFP::getNullValue(Op0->getType()));
5184 return &I;
5185 }
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005186 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) {
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005187 I.setOperand(1, ConstantFP::getNullValue(Op0->getType()));
5188 return &I;
5189 }
5190 }
5191
James Molloy2b21a7c2015-05-20 18:41:25 +00005192 // Test if the FCmpInst instruction is used exclusively by a select as
5193 // part of a minimum or maximum operation. If so, refrain from doing
5194 // any other folding. This helps out other analyses which understand
5195 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5196 // and CodeGen. And in this case, at least one of the comparison
5197 // operands has at least one user besides the compare (the select),
5198 // which would often largely negate the benefit of folding anyway.
5199 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005200 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5201 Value *A, *B;
5202 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5203 if (SPR.Flavor != SPF_UNKNOWN)
James Molloy2b21a7c2015-05-20 18:41:25 +00005204 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005205 }
James Molloy2b21a7c2015-05-20 18:41:25 +00005206
Chris Lattner2188e402010-01-04 07:37:31 +00005207 // Handle fcmp with constant RHS
5208 if (Constant *RHSC = dyn_cast<Constant>(Op1)) {
5209 if (Instruction *LHSI = dyn_cast<Instruction>(Op0))
5210 switch (LHSI->getOpcode()) {
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005211 case Instruction::FPExt: {
5212 // fcmp (fpext x), C -> fcmp x, (fptrunc C) if fptrunc is lossless
5213 FPExtInst *LHSExt = cast<FPExtInst>(LHSI);
5214 ConstantFP *RHSF = dyn_cast<ConstantFP>(RHSC);
5215 if (!RHSF)
5216 break;
5217
5218 const fltSemantics *Sem;
5219 // FIXME: This shouldn't be here.
Dan Gohman518cda42011-12-17 00:04:22 +00005220 if (LHSExt->getSrcTy()->isHalfTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005221 Sem = &APFloat::IEEEhalf();
Dan Gohman518cda42011-12-17 00:04:22 +00005222 else if (LHSExt->getSrcTy()->isFloatTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005223 Sem = &APFloat::IEEEsingle();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005224 else if (LHSExt->getSrcTy()->isDoubleTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005225 Sem = &APFloat::IEEEdouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005226 else if (LHSExt->getSrcTy()->isFP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005227 Sem = &APFloat::IEEEquad();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005228 else if (LHSExt->getSrcTy()->isX86_FP80Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005229 Sem = &APFloat::x87DoubleExtended();
Ulrich Weigand6a9bb512012-10-30 12:33:18 +00005230 else if (LHSExt->getSrcTy()->isPPC_FP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005231 Sem = &APFloat::PPCDoubleDouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005232 else
5233 break;
5234
5235 bool Lossy;
5236 APFloat F = RHSF->getValueAPF();
5237 F.convert(*Sem, APFloat::rmNearestTiesToEven, &Lossy);
5238
Jim Grosbach24ff8342011-09-30 18:45:50 +00005239 // Avoid lossy conversions and denormals. Zero is a special case
5240 // that's OK to convert.
Jim Grosbach011dafb2011-09-30 19:58:46 +00005241 APFloat Fabs = F;
5242 Fabs.clearSign();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005243 if (!Lossy &&
Jim Grosbach011dafb2011-09-30 19:58:46 +00005244 ((Fabs.compare(APFloat::getSmallestNormalized(*Sem)) !=
5245 APFloat::cmpLessThan) || Fabs.isZero()))
Jim Grosbach24ff8342011-09-30 18:45:50 +00005246
Sanjay Patel6b139462017-09-02 15:11:55 +00005247 return new FCmpInst(Pred, LHSExt->getOperand(0),
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005248 ConstantFP::get(RHSC->getContext(), F));
5249 break;
5250 }
Chris Lattner2188e402010-01-04 07:37:31 +00005251 case Instruction::PHI:
5252 // Only fold fcmp into the PHI if the phi and fcmp are in the same
5253 // block. If in the same block, we're encouraging jump threading. If
5254 // not, we are just pessimizing the code by making an i1 phi.
5255 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00005256 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00005257 return NV;
5258 break;
5259 case Instruction::SIToFP:
5260 case Instruction::UIToFP:
Sanjay Patel43395062016-07-21 18:07:40 +00005261 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
Chris Lattner2188e402010-01-04 07:37:31 +00005262 return NV;
5263 break;
Benjamin Kramera8c5d082011-03-31 10:12:15 +00005264 case Instruction::FSub: {
5265 // fcmp pred (fneg x), C -> fcmp swap(pred) x, -C
5266 Value *Op;
5267 if (match(LHSI, m_FNeg(m_Value(Op))))
5268 return new FCmpInst(I.getSwappedPredicate(), Op,
5269 ConstantExpr::getFNeg(RHSC));
5270 break;
5271 }
Dan Gohman94732022010-02-24 06:46:09 +00005272 case Instruction::Load:
5273 if (GetElementPtrInst *GEP =
5274 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
5275 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
5276 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
5277 !cast<LoadInst>(LHSI)->isVolatile())
Sanjay Patel43395062016-07-21 18:07:40 +00005278 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
Dan Gohman94732022010-02-24 06:46:09 +00005279 return Res;
5280 }
5281 break;
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005282 case Instruction::Call: {
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00005283 if (!RHSC->isNullValue())
5284 break;
5285
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005286 CallInst *CI = cast<CallInst>(LHSI);
Justin Bogner99798402016-08-05 01:06:44 +00005287 Intrinsic::ID IID = getIntrinsicForCallSite(CI, &TLI);
David Majnemer2e02ba72016-04-15 17:21:03 +00005288 if (IID != Intrinsic::fabs)
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00005289 break;
5290
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005291 // Various optimization for fabs compared with zero.
Sanjay Patel6b139462017-09-02 15:11:55 +00005292 switch (Pred) {
David Majnemer2e02ba72016-04-15 17:21:03 +00005293 default:
5294 break;
5295 // fabs(x) < 0 --> false
5296 case FCmpInst::FCMP_OLT:
5297 llvm_unreachable("handled by SimplifyFCmpInst");
5298 // fabs(x) > 0 --> x != 0
5299 case FCmpInst::FCMP_OGT:
5300 return new FCmpInst(FCmpInst::FCMP_ONE, CI->getArgOperand(0), RHSC);
5301 // fabs(x) <= 0 --> x == 0
5302 case FCmpInst::FCMP_OLE:
5303 return new FCmpInst(FCmpInst::FCMP_OEQ, CI->getArgOperand(0), RHSC);
5304 // fabs(x) >= 0 --> !isnan(x)
5305 case FCmpInst::FCMP_OGE:
5306 return new FCmpInst(FCmpInst::FCMP_ORD, CI->getArgOperand(0), RHSC);
5307 // fabs(x) == 0 --> x == 0
5308 // fabs(x) != 0 --> x != 0
5309 case FCmpInst::FCMP_OEQ:
5310 case FCmpInst::FCMP_UEQ:
5311 case FCmpInst::FCMP_ONE:
5312 case FCmpInst::FCMP_UNE:
Sanjay Patel6b139462017-09-02 15:11:55 +00005313 return new FCmpInst(Pred, CI->getArgOperand(0), RHSC);
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005314 }
5315 }
Chris Lattner2188e402010-01-04 07:37:31 +00005316 }
Chris Lattner2188e402010-01-04 07:37:31 +00005317 }
5318
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00005319 // fcmp pred (fneg x), (fneg y) -> fcmp swap(pred) x, y
Benjamin Kramerd159d942011-03-31 10:12:22 +00005320 Value *X, *Y;
5321 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00005322 return new FCmpInst(I.getSwappedPredicate(), X, Y);
Benjamin Kramerd159d942011-03-31 10:12:22 +00005323
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005324 // fcmp (fpext x), (fpext y) -> fcmp x, y
5325 if (FPExtInst *LHSExt = dyn_cast<FPExtInst>(Op0))
5326 if (FPExtInst *RHSExt = dyn_cast<FPExtInst>(Op1))
5327 if (LHSExt->getSrcTy() == RHSExt->getSrcTy())
Sanjay Patel6b139462017-09-02 15:11:55 +00005328 return new FCmpInst(Pred, LHSExt->getOperand(0), RHSExt->getOperand(0));
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005329
Sanjay Patel039f5562018-08-16 12:52:17 +00005330 if (I.getType()->isVectorTy())
5331 if (Instruction *Res = foldVectorCmp(I, Builder))
5332 return Res;
5333
Craig Topperf40110f2014-04-25 05:29:35 +00005334 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005335}