Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 1 | //===- SymbolTable.cpp ----------------------------------------------------===// |
| 2 | // |
| 3 | // The LLVM Linker |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | |
| 10 | #include "SymbolTable.h" |
| 11 | |
| 12 | #include "Config.h" |
Sam Clegg | 5fa274b | 2018-01-10 01:13:34 +0000 | [diff] [blame] | 13 | #include "InputChunks.h" |
Sam Clegg | b862159 | 2017-11-30 01:40:08 +0000 | [diff] [blame] | 14 | #include "WriterUtils.h" |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 15 | #include "lld/Common/ErrorHandler.h" |
Rui Ueyama | 2017d52 | 2017-11-28 20:39:17 +0000 | [diff] [blame] | 16 | #include "lld/Common/Memory.h" |
Rui Ueyama | 7d67dd1 | 2018-02-13 22:30:52 +0000 | [diff] [blame] | 17 | #include "llvm/ADT/SetVector.h" |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 18 | |
| 19 | #define DEBUG_TYPE "lld" |
| 20 | |
| 21 | using namespace llvm; |
Sam Clegg | 20db381 | 2018-01-10 00:52:20 +0000 | [diff] [blame] | 22 | using namespace llvm::wasm; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 23 | using namespace lld; |
| 24 | using namespace lld::wasm; |
| 25 | |
| 26 | SymbolTable *lld::wasm::Symtab; |
| 27 | |
| 28 | void SymbolTable::addFile(InputFile *File) { |
| 29 | log("Processing: " + toString(File)); |
| 30 | File->parse(); |
| 31 | |
| 32 | if (auto *F = dyn_cast<ObjFile>(File)) |
| 33 | ObjectFiles.push_back(F); |
| 34 | } |
| 35 | |
| 36 | void SymbolTable::reportRemainingUndefines() { |
Rui Ueyama | 7d67dd1 | 2018-02-13 22:30:52 +0000 | [diff] [blame] | 37 | SetVector<Symbol *> Undefs; |
Sam Clegg | 74fe0ba | 2017-12-07 01:51:24 +0000 | [diff] [blame] | 38 | for (Symbol *Sym : SymVector) { |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 39 | if (Sym->isUndefined() && !Sym->isWeak() && |
| 40 | Config->AllowUndefinedSymbols.count(Sym->getName()) == 0) { |
| 41 | Undefs.insert(Sym); |
| 42 | } |
| 43 | } |
| 44 | |
| 45 | if (Undefs.empty()) |
| 46 | return; |
| 47 | |
| 48 | for (ObjFile *File : ObjectFiles) |
| 49 | for (Symbol *Sym : File->getSymbols()) |
| 50 | if (Undefs.count(Sym)) |
| 51 | error(toString(File) + ": undefined symbol: " + toString(*Sym)); |
| 52 | |
| 53 | for (Symbol *Sym : Undefs) |
| 54 | if (!Sym->getFile()) |
| 55 | error("undefined symbol: " + toString(*Sym)); |
| 56 | } |
| 57 | |
| 58 | Symbol *SymbolTable::find(StringRef Name) { |
Sam Clegg | a80d94d | 2017-11-27 23:16:06 +0000 | [diff] [blame] | 59 | auto It = SymMap.find(CachedHashStringRef(Name)); |
| 60 | if (It == SymMap.end()) |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 61 | return nullptr; |
| 62 | return It->second; |
| 63 | } |
| 64 | |
| 65 | std::pair<Symbol *, bool> SymbolTable::insert(StringRef Name) { |
Sam Clegg | a80d94d | 2017-11-27 23:16:06 +0000 | [diff] [blame] | 66 | Symbol *&Sym = SymMap[CachedHashStringRef(Name)]; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 67 | if (Sym) |
| 68 | return {Sym, false}; |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 69 | Sym = reinterpret_cast<Symbol *>(make<SymbolUnion>()); |
Sam Clegg | 74fe0ba | 2017-12-07 01:51:24 +0000 | [diff] [blame] | 70 | SymVector.emplace_back(Sym); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 71 | return {Sym, true}; |
| 72 | } |
| 73 | |
Sam Clegg | b862159 | 2017-11-30 01:40:08 +0000 | [diff] [blame] | 74 | // Check the type of new symbol matches that of the symbol is replacing. |
| 75 | // For functions this can also involve verifying that the signatures match. |
| 76 | static void checkSymbolTypes(const Symbol &Existing, const InputFile &F, |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 77 | bool NewIsFunction, const WasmSignature *NewSig) { |
Sam Clegg | b862159 | 2017-11-30 01:40:08 +0000 | [diff] [blame] | 78 | if (Existing.isLazy()) |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 79 | return; |
| 80 | |
Sam Clegg | b862159 | 2017-11-30 01:40:08 +0000 | [diff] [blame] | 81 | // First check the symbol types match (i.e. either both are function |
| 82 | // symbols or both are data symbols). |
Sam Clegg | caca8d5 | 2018-02-17 00:44:21 +0000 | [diff] [blame] | 83 | if (isa<FunctionSymbol>(Existing) != NewIsFunction) { |
Sam Clegg | 20db381 | 2018-01-10 00:52:20 +0000 | [diff] [blame] | 84 | error("symbol type mismatch: " + Existing.getName() + "\n>>> defined as " + |
Sam Clegg | caca8d5 | 2018-02-17 00:44:21 +0000 | [diff] [blame] | 85 | (isa<FunctionSymbol>(Existing) ? "Function" : "Global") + " in " + |
Sam Clegg | b862159 | 2017-11-30 01:40:08 +0000 | [diff] [blame] | 86 | toString(Existing.getFile()) + "\n>>> defined as " + |
| 87 | (NewIsFunction ? "Function" : "Global") + " in " + F.getName()); |
| 88 | return; |
| 89 | } |
| 90 | |
| 91 | // For function symbols, optionally check the function signature matches too. |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 92 | auto *ExistingFunc = dyn_cast<FunctionSymbol>(&Existing); |
| 93 | if (!ExistingFunc || !Config->CheckSignatures) |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 94 | return; |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 95 | |
Sam Clegg | 3f8db98 | 2018-02-16 23:50:23 +0000 | [diff] [blame] | 96 | const WasmSignature *OldSig = ExistingFunc->getFunctionType(); |
| 97 | |
Sam Clegg | 31de2f0 | 2017-12-07 03:19:53 +0000 | [diff] [blame] | 98 | // Skip the signature check if the existing function has no signature (e.g. |
| 99 | // if it is an undefined symbol generated by --undefined command line flag). |
Sam Clegg | 3f8db98 | 2018-02-16 23:50:23 +0000 | [diff] [blame] | 100 | if (OldSig == nullptr) |
Sam Clegg | 31de2f0 | 2017-12-07 03:19:53 +0000 | [diff] [blame] | 101 | return; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 102 | |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 103 | DEBUG(dbgs() << "checkSymbolTypes: " << ExistingFunc->getName() << "\n"); |
Sam Clegg | b862159 | 2017-11-30 01:40:08 +0000 | [diff] [blame] | 104 | assert(NewSig); |
| 105 | |
Sam Clegg | 3f8db98 | 2018-02-16 23:50:23 +0000 | [diff] [blame] | 106 | if (*NewSig == *OldSig) |
Sam Clegg | b862159 | 2017-11-30 01:40:08 +0000 | [diff] [blame] | 107 | return; |
| 108 | |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 109 | error("function signature mismatch: " + ExistingFunc->getName() + |
Sam Clegg | 3f8db98 | 2018-02-16 23:50:23 +0000 | [diff] [blame] | 110 | "\n>>> defined as " + toString(*OldSig) + " in " + |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 111 | toString(ExistingFunc->getFile()) + "\n>>> defined as " + |
| 112 | toString(*NewSig) + " in " + F.getName()); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 113 | } |
| 114 | |
Sam Clegg | 24b3dcd | 2018-01-28 19:57:01 +0000 | [diff] [blame] | 115 | static void checkSymbolTypes(const Symbol &Existing, const InputFile &F, |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 116 | bool IsFunction, const InputChunk *Chunk) { |
Sam Clegg | fc50c62 | 2018-01-28 19:57:02 +0000 | [diff] [blame] | 117 | const WasmSignature *Sig = nullptr; |
| 118 | if (auto *F = dyn_cast_or_null<InputFunction>(Chunk)) |
Sam Clegg | 24b3dcd | 2018-01-28 19:57:01 +0000 | [diff] [blame] | 119 | Sig = &F->Signature; |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 120 | return checkSymbolTypes(Existing, F, IsFunction, Sig); |
Sam Clegg | 24b3dcd | 2018-01-28 19:57:01 +0000 | [diff] [blame] | 121 | } |
| 122 | |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 123 | DefinedFunction *SymbolTable::addSyntheticFunction(StringRef Name, |
| 124 | const WasmSignature *Type, |
| 125 | uint32_t Flags) { |
Sam Clegg | a189230 | 2018-02-13 20:14:26 +0000 | [diff] [blame] | 126 | DEBUG(dbgs() << "addSyntheticFunction: " << Name << "\n"); |
Sam Clegg | 5068685 | 2018-01-12 18:35:13 +0000 | [diff] [blame] | 127 | Symbol *S; |
| 128 | bool WasInserted; |
| 129 | std::tie(S, WasInserted) = insert(Name); |
Sam Clegg | a189230 | 2018-02-13 20:14:26 +0000 | [diff] [blame] | 130 | assert(WasInserted); |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 131 | return replaceSymbol<DefinedFunction>(S, Name, Flags, Type); |
Sam Clegg | 5068685 | 2018-01-12 18:35:13 +0000 | [diff] [blame] | 132 | } |
| 133 | |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 134 | DefinedGlobal *SymbolTable::addSyntheticGlobal(StringRef Name, uint32_t Flags) { |
Sam Clegg | a189230 | 2018-02-13 20:14:26 +0000 | [diff] [blame] | 135 | DEBUG(dbgs() << "addSyntheticGlobal: " << Name << "\n"); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 136 | Symbol *S; |
| 137 | bool WasInserted; |
| 138 | std::tie(S, WasInserted) = insert(Name); |
Sam Clegg | a189230 | 2018-02-13 20:14:26 +0000 | [diff] [blame] | 139 | assert(WasInserted); |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 140 | return replaceSymbol<DefinedGlobal>(S, Name, Flags); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 141 | } |
| 142 | |
Sam Clegg | f60b0d5 | 2018-02-20 18:55:07 +0000 | [diff] [blame] | 143 | static bool shouldReplace(const Symbol &Existing, InputFile *NewFile, |
| 144 | uint32_t NewFlags, InputChunk *NewChunk, |
| 145 | bool NewIsFunction) { |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 146 | bool Replace = false; |
| 147 | bool CheckTypes = false; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 148 | |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 149 | if (Existing.isLazy()) { |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 150 | // Existing symbol is lazy. Replace it without checking types since |
Sam Clegg | b862159 | 2017-11-30 01:40:08 +0000 | [diff] [blame] | 151 | // lazy symbols don't have any type information. |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 152 | DEBUG(dbgs() << "replacing existing lazy symbol: " << Existing.getName() |
| 153 | << "\n"); |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 154 | Replace = true; |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 155 | } else if (!Existing.isDefined()) { |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 156 | // Existing symbol is undefined: replace it, while check types. |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 157 | DEBUG(dbgs() << "resolving existing undefined symbol: " |
| 158 | << Existing.getName() << "\n"); |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 159 | Replace = true; |
| 160 | CheckTypes = true; |
Sam Clegg | f60b0d5 | 2018-02-20 18:55:07 +0000 | [diff] [blame] | 161 | } else if ((NewFlags & WASM_SYMBOL_BINDING_MASK) == WASM_SYMBOL_BINDING_WEAK) { |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 162 | // the new symbol is weak we can ignore it |
Sam Clegg | 49ed926 | 2017-12-01 00:53:21 +0000 | [diff] [blame] | 163 | DEBUG(dbgs() << "existing symbol takes precedence\n"); |
Sam Clegg | c7e885b | 2018-02-20 17:20:44 +0000 | [diff] [blame] | 164 | CheckTypes = true; |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 165 | } else if (Existing.isWeak()) { |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 166 | // the existing symbol is, so we replace it |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 167 | DEBUG(dbgs() << "replacing existing weak symbol\n"); |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 168 | Replace = true; |
| 169 | CheckTypes = true; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 170 | } else { |
Sam Clegg | 49ed926 | 2017-12-01 00:53:21 +0000 | [diff] [blame] | 171 | // neither symbol is week. They conflict. |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 172 | error("duplicate symbol: " + toString(Existing) + "\n>>> defined in " + |
| 173 | toString(Existing.getFile()) + "\n>>> defined in " + |
Sam Clegg | f60b0d5 | 2018-02-20 18:55:07 +0000 | [diff] [blame] | 174 | toString(NewFile)); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 175 | } |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 176 | |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 177 | if (CheckTypes) |
Sam Clegg | f60b0d5 | 2018-02-20 18:55:07 +0000 | [diff] [blame] | 178 | checkSymbolTypes(Existing, *NewFile, NewIsFunction, NewChunk); |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 179 | |
| 180 | return Replace; |
| 181 | } |
| 182 | |
| 183 | Symbol *SymbolTable::addDefinedFunction(StringRef Name, uint32_t Flags, |
| 184 | InputFile *F, InputFunction *Function) { |
| 185 | DEBUG(dbgs() << "addDefinedFunction: " << Name << "\n"); |
| 186 | Symbol *S; |
| 187 | bool WasInserted; |
| 188 | std::tie(S, WasInserted) = insert(Name); |
Sam Clegg | f60b0d5 | 2018-02-20 18:55:07 +0000 | [diff] [blame] | 189 | if (WasInserted || shouldReplace(*S, F, Flags, Function, true)) |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 190 | replaceSymbol<DefinedFunction>(S, Name, Flags, F, Function); |
| 191 | return S; |
| 192 | } |
| 193 | |
| 194 | Symbol *SymbolTable::addDefinedGlobal(StringRef Name, uint32_t Flags, |
| 195 | InputFile *F, InputSegment *Segment, |
| 196 | uint32_t Address) { |
| 197 | DEBUG(dbgs() << "addDefinedGlobal:" << Name << " addr:" << Address << "\n"); |
| 198 | Symbol *S; |
| 199 | bool WasInserted; |
| 200 | std::tie(S, WasInserted) = insert(Name); |
Sam Clegg | f60b0d5 | 2018-02-20 18:55:07 +0000 | [diff] [blame] | 201 | if (WasInserted || shouldReplace(*S, F, Flags, Segment, false)) |
Sam Clegg | 93e559b | 2018-02-20 18:55:06 +0000 | [diff] [blame] | 202 | replaceSymbol<DefinedGlobal>(S, Name, Flags, F, Segment, Address); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 203 | return S; |
| 204 | } |
| 205 | |
Sam Clegg | 20db381 | 2018-01-10 00:52:20 +0000 | [diff] [blame] | 206 | Symbol *SymbolTable::addUndefined(StringRef Name, Symbol::Kind Kind, |
| 207 | uint32_t Flags, InputFile *F, |
Sam Clegg | 8d146bb | 2018-01-09 23:56:44 +0000 | [diff] [blame] | 208 | const WasmSignature *Type) { |
Sam Clegg | 20db381 | 2018-01-10 00:52:20 +0000 | [diff] [blame] | 209 | DEBUG(dbgs() << "addUndefined: " << Name << "\n"); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 210 | Symbol *S; |
| 211 | bool WasInserted; |
Sam Clegg | 20db381 | 2018-01-10 00:52:20 +0000 | [diff] [blame] | 212 | std::tie(S, WasInserted) = insert(Name); |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 213 | bool IsFunction = Kind == Symbol::UndefinedFunctionKind; |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 214 | if (WasInserted) { |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 215 | if (IsFunction) |
| 216 | replaceSymbol<UndefinedFunction>(S, Name, Flags, F, Type); |
| 217 | else |
| 218 | replaceSymbol<UndefinedGlobal>(S, Name, Flags, F); |
| 219 | } else if (auto *LazySym = dyn_cast<LazySymbol>(S)) { |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 220 | DEBUG(dbgs() << "resolved by existing lazy\n"); |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 221 | auto *AF = cast<ArchiveFile>(LazySym->getFile()); |
| 222 | AF->addMember(&LazySym->getArchiveSymbol()); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 223 | } else if (S->isDefined()) { |
| 224 | DEBUG(dbgs() << "resolved by existing\n"); |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 225 | checkSymbolTypes(*S, *F, IsFunction, Type); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 226 | } |
| 227 | return S; |
| 228 | } |
| 229 | |
| 230 | void SymbolTable::addLazy(ArchiveFile *F, const Archive::Symbol *Sym) { |
Sam Clegg | a681a11 | 2017-12-06 03:10:39 +0000 | [diff] [blame] | 231 | DEBUG(dbgs() << "addLazy: " << Sym->getName() << "\n"); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 232 | StringRef Name = Sym->getName(); |
| 233 | Symbol *S; |
| 234 | bool WasInserted; |
| 235 | std::tie(S, WasInserted) = insert(Name); |
| 236 | if (WasInserted) { |
Sam Clegg | dfb0b2c | 2018-02-14 18:27:59 +0000 | [diff] [blame] | 237 | replaceSymbol<LazySymbol>(S, Name, F, *Sym); |
Sam Clegg | c94d393 | 2017-11-17 18:14:09 +0000 | [diff] [blame] | 238 | } else if (S->isUndefined()) { |
| 239 | // There is an existing undefined symbol. The can load from the |
| 240 | // archive. |
| 241 | DEBUG(dbgs() << "replacing existing undefined\n"); |
| 242 | F->addMember(Sym); |
| 243 | } |
| 244 | } |
Sam Clegg | e0f6fcd | 2018-01-12 22:25:17 +0000 | [diff] [blame] | 245 | |
| 246 | bool SymbolTable::addComdat(StringRef Name, ObjFile *F) { |
| 247 | DEBUG(dbgs() << "addComdat: " << Name << "\n"); |
| 248 | ObjFile *&File = ComdatMap[CachedHashStringRef(Name)]; |
| 249 | if (File) { |
| 250 | DEBUG(dbgs() << "COMDAT already defined\n"); |
| 251 | return false; |
| 252 | } |
| 253 | File = F; |
| 254 | return true; |
| 255 | } |
| 256 | |
| 257 | ObjFile *SymbolTable::findComdat(StringRef Name) const { |
| 258 | auto It = ComdatMap.find(CachedHashStringRef(Name)); |
| 259 | return It == ComdatMap.end() ? nullptr : It->second; |
| 260 | } |