blob: 0930808f3c2589b8ff0e4b654c2925fe19a4e371 [file] [log] [blame]
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001//=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines malloc/free checker, which checks for potential memory
11// leaks, double free, and use-after-free problems.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +000015#include "ClangSACheckers.h"
Anna Zakse56167e2012-02-17 22:35:31 +000016#include "InterCheckerAPI.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000017#include "clang/AST/Attr.h"
Anton Yartsev4e4cb6b2014-08-05 18:26:05 +000018#include "clang/AST/ParentMap.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000019#include "clang/Basic/SourceManager.h"
Jordan Rose6b33c6f2014-03-26 17:05:46 +000020#include "clang/Basic/TargetInfo.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000021#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Argyrios Kyrtzidis6a5674f2011-03-01 01:16:21 +000022#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +000023#include "clang/StaticAnalyzer/Core/CheckerManager.h"
Jordan Rose4f7df9b2012-07-26 21:39:41 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000025#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek001fd5b2011-08-15 22:09:50 +000026#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
27#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Ted Kremenekf8cbac42011-02-10 01:03:03 +000028#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
Zhongxing Xu88cca6b2009-11-12 08:38:56 +000029#include "llvm/ADT/ImmutableMap.h"
Benjamin Kramer3307c5082012-02-04 12:31:12 +000030#include "llvm/ADT/STLExtras.h"
Benjamin Kramerea70eb32012-12-01 15:09:41 +000031#include "llvm/ADT/SmallString.h"
Jordan Rosec102b352012-09-22 01:24:42 +000032#include "llvm/ADT/StringExtras.h"
Anna Zaks199e8e52012-02-22 03:14:20 +000033#include <climits>
34
Zhongxing Xu88cca6b2009-11-12 08:38:56 +000035using namespace clang;
Ted Kremenek98857c92010-12-23 07:20:52 +000036using namespace ento;
Zhongxing Xu88cca6b2009-11-12 08:38:56 +000037
38namespace {
39
Anton Yartsev05789592013-03-28 17:05:19 +000040// Used to check correspondence between allocators and deallocators.
41enum AllocationFamily {
42 AF_None,
43 AF_Malloc,
44 AF_CXXNew,
Anna Zaksd79b8402014-10-03 21:48:59 +000045 AF_CXXNewArray,
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +000046 AF_IfNameIndex,
47 AF_Alloca
Anton Yartsev05789592013-03-28 17:05:19 +000048};
49
Zhongxing Xu1239de12009-12-11 00:55:44 +000050class RefState {
Anna Zaks9050ffd2012-06-20 20:57:46 +000051 enum Kind { // Reference to allocated memory.
52 Allocated,
53 // Reference to released/freed memory.
54 Released,
Alp Toker5faf0c02013-12-02 03:50:25 +000055 // The responsibility for freeing resources has transferred from
Anna Zaks9050ffd2012-06-20 20:57:46 +000056 // this reference. A relinquished symbol should not be freed.
Anna Zaks93a21a82013-04-09 00:30:28 +000057 Relinquished,
58 // We are no longer guaranteed to have observed all manipulations
59 // of this pointer/memory. For example, it could have been
60 // passed as a parameter to an opaque function.
61 Escaped
62 };
Anton Yartsev05789592013-03-28 17:05:19 +000063
Zhongxing Xu4668c7e2009-11-17 07:54:15 +000064 const Stmt *S;
Anton Yartsev05789592013-03-28 17:05:19 +000065 unsigned K : 2; // Kind enum, but stored as a bitfield.
66 unsigned Family : 30; // Rest of 32-bit word, currently just an allocation
67 // family.
Zhongxing Xu4668c7e2009-11-17 07:54:15 +000068
Anton Yartsev05789592013-03-28 17:05:19 +000069 RefState(Kind k, const Stmt *s, unsigned family)
Anna Zaks93a21a82013-04-09 00:30:28 +000070 : S(s), K(k), Family(family) {
71 assert(family != AF_None);
72 }
Zhongxing Xu1239de12009-12-11 00:55:44 +000073public:
Anna Zaks9050ffd2012-06-20 20:57:46 +000074 bool isAllocated() const { return K == Allocated; }
Zhongxing Xu4668c7e2009-11-17 07:54:15 +000075 bool isReleased() const { return K == Released; }
Anna Zaks9050ffd2012-06-20 20:57:46 +000076 bool isRelinquished() const { return K == Relinquished; }
Anna Zaks93a21a82013-04-09 00:30:28 +000077 bool isEscaped() const { return K == Escaped; }
78 AllocationFamily getAllocationFamily() const {
Anton Yartsev05789592013-03-28 17:05:19 +000079 return (AllocationFamily)Family;
80 }
Anna Zaksd56c8792012-02-13 18:05:39 +000081 const Stmt *getStmt() const { return S; }
Zhongxing Xu4668c7e2009-11-17 07:54:15 +000082
83 bool operator==(const RefState &X) const {
Anton Yartsev05789592013-03-28 17:05:19 +000084 return K == X.K && S == X.S && Family == X.Family;
Zhongxing Xu4668c7e2009-11-17 07:54:15 +000085 }
86
Anton Yartsev05789592013-03-28 17:05:19 +000087 static RefState getAllocated(unsigned family, const Stmt *s) {
88 return RefState(Allocated, s, family);
Zhongxing Xub0e15df2009-12-31 06:13:07 +000089 }
Anton Yartsev05789592013-03-28 17:05:19 +000090 static RefState getReleased(unsigned family, const Stmt *s) {
91 return RefState(Released, s, family);
92 }
93 static RefState getRelinquished(unsigned family, const Stmt *s) {
94 return RefState(Relinquished, s, family);
Ted Kremenek0bbf24d2010-08-06 21:12:55 +000095 }
Anna Zaks93a21a82013-04-09 00:30:28 +000096 static RefState getEscaped(const RefState *RS) {
97 return RefState(Escaped, RS->getStmt(), RS->getAllocationFamily());
98 }
Zhongxing Xu4668c7e2009-11-17 07:54:15 +000099
100 void Profile(llvm::FoldingSetNodeID &ID) const {
101 ID.AddInteger(K);
102 ID.AddPointer(S);
Anton Yartsev05789592013-03-28 17:05:19 +0000103 ID.AddInteger(Family);
Zhongxing Xu4668c7e2009-11-17 07:54:15 +0000104 }
Ted Kremenek6fcefb52013-01-03 01:30:12 +0000105
Dmitri Gribenkof8579502013-01-12 19:30:44 +0000106 void dump(raw_ostream &OS) const {
Jordan Rose6adadb92014-01-23 03:59:01 +0000107 switch (static_cast<Kind>(K)) {
108#define CASE(ID) case ID: OS << #ID; break;
109 CASE(Allocated)
110 CASE(Released)
111 CASE(Relinquished)
112 CASE(Escaped)
113 }
Ted Kremenek6fcefb52013-01-03 01:30:12 +0000114 }
115
Alp Tokeref6b0072014-01-04 13:47:14 +0000116 LLVM_DUMP_METHOD void dump() const { dump(llvm::errs()); }
Zhongxing Xu88cca6b2009-11-12 08:38:56 +0000117};
118
Anna Zaks75cfbb62012-09-12 22:57:34 +0000119enum ReallocPairKind {
120 RPToBeFreedAfterFailure,
121 // The symbol has been freed when reallocation failed.
122 RPIsFreeOnFailure,
123 // The symbol does not need to be freed after reallocation fails.
124 RPDoNotTrackAfterFailure
125};
126
Anna Zaksfe6eb672012-08-24 02:28:20 +0000127/// \class ReallocPair
128/// \brief Stores information about the symbol being reallocated by a call to
129/// 'realloc' to allow modeling failed reallocation later in the path.
Anna Zaksac068142012-02-15 00:11:25 +0000130struct ReallocPair {
Anna Zaksfe6eb672012-08-24 02:28:20 +0000131 // \brief The symbol which realloc reallocated.
Anna Zaksac068142012-02-15 00:11:25 +0000132 SymbolRef ReallocatedSym;
Anna Zaks75cfbb62012-09-12 22:57:34 +0000133 ReallocPairKind Kind;
Anna Zaksfe6eb672012-08-24 02:28:20 +0000134
Anna Zaks75cfbb62012-09-12 22:57:34 +0000135 ReallocPair(SymbolRef S, ReallocPairKind K) :
136 ReallocatedSym(S), Kind(K) {}
Anna Zaksac068142012-02-15 00:11:25 +0000137 void Profile(llvm::FoldingSetNodeID &ID) const {
Anna Zaks75cfbb62012-09-12 22:57:34 +0000138 ID.AddInteger(Kind);
Anna Zaksac068142012-02-15 00:11:25 +0000139 ID.AddPointer(ReallocatedSym);
140 }
141 bool operator==(const ReallocPair &X) const {
142 return ReallocatedSym == X.ReallocatedSym &&
Anna Zaks75cfbb62012-09-12 22:57:34 +0000143 Kind == X.Kind;
Anna Zaksac068142012-02-15 00:11:25 +0000144 }
145};
146
Anna Zaksa043d0c2013-01-08 00:25:29 +0000147typedef std::pair<const ExplodedNode*, const MemRegion*> LeakInfo;
Anna Zaksfc2e1532012-03-21 19:45:08 +0000148
Anna Zaksc68bf4c2012-02-08 20:13:28 +0000149class MallocChecker : public Checker<check::DeadSymbols,
Anna Zaksdc154152012-12-20 00:38:25 +0000150 check::PointerEscape,
Anna Zaks333481b2013-03-28 23:15:29 +0000151 check::ConstPointerEscape,
Ted Kremenek778d2bb2012-01-04 23:48:37 +0000152 check::PreStmt<ReturnStmt>,
Anton Yartsevcb2ccd62013-04-10 22:21:41 +0000153 check::PreCall,
Anna Zaksc68bf4c2012-02-08 20:13:28 +0000154 check::PostStmt<CallExpr>,
Anton Yartsev13df0362013-03-25 01:35:45 +0000155 check::PostStmt<CXXNewExpr>,
156 check::PreStmt<CXXDeleteExpr>,
Anna Zaks9fe80982012-03-22 00:57:20 +0000157 check::PostStmt<BlockExpr>,
Anna Zaks67291b92012-11-13 03:18:01 +0000158 check::PostObjCMessage,
Ted Kremenek778d2bb2012-01-04 23:48:37 +0000159 check::Location,
Anna Zaksdc154152012-12-20 00:38:25 +0000160 eval::Assume>
Ted Kremenek778d2bb2012-01-04 23:48:37 +0000161{
Zhongxing Xu88cca6b2009-11-12 08:38:56 +0000162public:
Craig Topper0dbb7832014-05-27 02:45:47 +0000163 MallocChecker()
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000164 : II_alloca(nullptr), II_alloca_builtin(nullptr), II_malloc(nullptr),
165 II_free(nullptr), II_realloc(nullptr), II_calloc(nullptr),
166 II_valloc(nullptr), II_reallocf(nullptr), II_strndup(nullptr),
167 II_strdup(nullptr), II_kmalloc(nullptr), II_if_nameindex(nullptr),
168 II_if_freenameindex(nullptr) {}
Anna Zakscd37bf42012-02-08 23:16:52 +0000169
170 /// In pessimistic mode, the checker assumes that it does not know which
171 /// functions might free the memory.
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000172 enum CheckKind {
173 CK_MallocPessimistic,
174 CK_MallocOptimistic,
175 CK_NewDeleteChecker,
176 CK_NewDeleteLeaksChecker,
177 CK_MismatchedDeallocatorChecker,
178 CK_NumCheckKinds
Anna Zakscd37bf42012-02-08 23:16:52 +0000179 };
180
Anna Zaksd79b8402014-10-03 21:48:59 +0000181 enum class MemoryOperationKind {
182 MOK_Allocate,
183 MOK_Free,
184 MOK_Any
185 };
186
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000187 DefaultBool ChecksEnabled[CK_NumCheckKinds];
188 CheckName CheckNames[CK_NumCheckKinds];
Anton Yartseve5c0c142015-02-18 00:39:06 +0000189 typedef llvm::SmallVector<CheckKind, CK_NumCheckKinds> CKVecTy;
Anna Zakscd37bf42012-02-08 23:16:52 +0000190
Anton Yartsevcb2ccd62013-04-10 22:21:41 +0000191 void checkPreCall(const CallEvent &Call, CheckerContext &C) const;
Anna Zaksc68bf4c2012-02-08 20:13:28 +0000192 void checkPostStmt(const CallExpr *CE, CheckerContext &C) const;
Anton Yartsev13df0362013-03-25 01:35:45 +0000193 void checkPostStmt(const CXXNewExpr *NE, CheckerContext &C) const;
194 void checkPreStmt(const CXXDeleteExpr *DE, CheckerContext &C) const;
Anna Zaks67291b92012-11-13 03:18:01 +0000195 void checkPostObjCMessage(const ObjCMethodCall &Call, CheckerContext &C) const;
Anna Zaks9fe80982012-03-22 00:57:20 +0000196 void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const;
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +0000197 void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +0000198 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
Ted Kremenek49b1e382012-01-26 21:29:00 +0000199 ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond,
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +0000200 bool Assumption) const;
Anna Zaks3e0f4152011-10-06 00:43:15 +0000201 void checkLocation(SVal l, bool isLoad, const Stmt *S,
202 CheckerContext &C) const;
Anna Zaksdc154152012-12-20 00:38:25 +0000203
204 ProgramStateRef checkPointerEscape(ProgramStateRef State,
205 const InvalidatedSymbols &Escaped,
Anna Zaksacdc13c2013-02-07 23:05:43 +0000206 const CallEvent *Call,
207 PointerEscapeKind Kind) const;
Anna Zaks333481b2013-03-28 23:15:29 +0000208 ProgramStateRef checkConstPointerEscape(ProgramStateRef State,
209 const InvalidatedSymbols &Escaped,
210 const CallEvent *Call,
211 PointerEscapeKind Kind) const;
Zhongxing Xub0e15df2009-12-31 06:13:07 +0000212
Anna Zaks263b7e02012-05-02 00:05:20 +0000213 void printState(raw_ostream &Out, ProgramStateRef State,
Craig Topperfb6b25b2014-03-15 04:29:04 +0000214 const char *NL, const char *Sep) const override;
Anna Zaks263b7e02012-05-02 00:05:20 +0000215
Zhongxing Xuc4902a52009-11-13 07:25:27 +0000216private:
Ahmed Charlesb8984322014-03-07 20:03:18 +0000217 mutable std::unique_ptr<BugType> BT_DoubleFree[CK_NumCheckKinds];
218 mutable std::unique_ptr<BugType> BT_DoubleDelete;
219 mutable std::unique_ptr<BugType> BT_Leak[CK_NumCheckKinds];
220 mutable std::unique_ptr<BugType> BT_UseFree[CK_NumCheckKinds];
221 mutable std::unique_ptr<BugType> BT_BadFree[CK_NumCheckKinds];
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000222 mutable std::unique_ptr<BugType> BT_FreeAlloca[CK_NumCheckKinds];
Ahmed Charlesb8984322014-03-07 20:03:18 +0000223 mutable std::unique_ptr<BugType> BT_MismatchedDealloc;
224 mutable std::unique_ptr<BugType> BT_OffsetFree[CK_NumCheckKinds];
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000225 mutable IdentifierInfo *II_alloca, *II_alloca_builtin, *II_malloc, *II_free,
226 *II_realloc, *II_calloc, *II_valloc, *II_reallocf,
227 *II_strndup, *II_strdup, *II_kmalloc, *II_if_nameindex,
228 *II_if_freenameindex;
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000229 mutable Optional<uint64_t> KernelZeroFlagVal;
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000230
Anna Zaks3d348342012-02-14 21:55:24 +0000231 void initIdentifierInfo(ASTContext &C) const;
232
Anton Yartsev05789592013-03-28 17:05:19 +0000233 /// \brief Determine family of a deallocation expression.
Anton Yartseve3377fb2013-04-04 23:46:29 +0000234 AllocationFamily getAllocationFamily(CheckerContext &C, const Stmt *S) const;
Anton Yartsev05789592013-03-28 17:05:19 +0000235
236 /// \brief Print names of allocators and deallocators.
237 ///
238 /// \returns true on success.
239 bool printAllocDeallocName(raw_ostream &os, CheckerContext &C,
240 const Expr *E) const;
241
242 /// \brief Print expected name of an allocator based on the deallocator's
243 /// family derived from the DeallocExpr.
244 void printExpectedAllocName(raw_ostream &os, CheckerContext &C,
245 const Expr *DeallocExpr) const;
246 /// \brief Print expected name of a deallocator based on the allocator's
247 /// family.
248 void printExpectedDeallocName(raw_ostream &os, AllocationFamily Family) const;
249
Jordan Rose613f3c02013-03-09 00:59:10 +0000250 ///@{
Anna Zaks3d348342012-02-14 21:55:24 +0000251 /// Check if this is one of the functions which can allocate/reallocate memory
252 /// pointed to by one of its arguments.
253 bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaksd79b8402014-10-03 21:48:59 +0000254 bool isCMemFunction(const FunctionDecl *FD,
255 ASTContext &C,
256 AllocationFamily Family,
Benjamin Kramer719772c2014-10-03 22:20:30 +0000257 MemoryOperationKind MemKind) const;
Anton Yartsev13df0362013-03-25 01:35:45 +0000258 bool isStandardNewDelete(const FunctionDecl *FD, ASTContext &C) const;
Jordan Rose613f3c02013-03-09 00:59:10 +0000259 ///@}
Richard Smith852e9ce2013-11-27 01:46:48 +0000260 ProgramStateRef MallocMemReturnsAttr(CheckerContext &C,
261 const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000262 const OwnershipAttr* Att,
263 ProgramStateRef State) const;
Ted Kremenek49b1e382012-01-26 21:29:00 +0000264 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000265 const Expr *SizeEx, SVal Init,
266 ProgramStateRef State,
267 AllocationFamily Family = AF_Malloc);
Ted Kremenek49b1e382012-01-26 21:29:00 +0000268 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000269 SVal SizeEx, SVal Init,
270 ProgramStateRef State,
271 AllocationFamily Family = AF_Malloc);
Zhongxing Xu527ff6d2010-06-01 03:01:33 +0000272
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000273 // Check if this malloc() for special flags. At present that means M_ZERO or
274 // __GFP_ZERO (in which case, treat it like calloc).
275 llvm::Optional<ProgramStateRef>
276 performKernelMalloc(const CallExpr *CE, CheckerContext &C,
277 const ProgramStateRef &State) const;
278
Anna Zaks40a7eb32012-02-22 19:24:52 +0000279 /// Update the RefState to reflect the new memory allocation.
Anton Yartsev05789592013-03-28 17:05:19 +0000280 static ProgramStateRef
281 MallocUpdateRefState(CheckerContext &C, const Expr *E, ProgramStateRef State,
282 AllocationFamily Family = AF_Malloc);
Anna Zaks40a7eb32012-02-22 19:24:52 +0000283
284 ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000285 const OwnershipAttr* Att,
286 ProgramStateRef State) const;
Ted Kremenek49b1e382012-01-26 21:29:00 +0000287 ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE,
Anna Zaks0d6989b2012-06-22 02:04:31 +0000288 ProgramStateRef state, unsigned Num,
Anna Zaksfe6eb672012-08-24 02:28:20 +0000289 bool Hold,
Anna Zaks67291b92012-11-13 03:18:01 +0000290 bool &ReleasedAllocated,
291 bool ReturnsNullOnFailure = false) const;
Anna Zaks0d6989b2012-06-22 02:04:31 +0000292 ProgramStateRef FreeMemAux(CheckerContext &C, const Expr *Arg,
293 const Expr *ParentExpr,
Anna Zaks67291b92012-11-13 03:18:01 +0000294 ProgramStateRef State,
Anna Zaksfe6eb672012-08-24 02:28:20 +0000295 bool Hold,
Anna Zaks67291b92012-11-13 03:18:01 +0000296 bool &ReleasedAllocated,
297 bool ReturnsNullOnFailure = false) const;
Zhongxing Xuc0484fa2009-12-12 12:29:38 +0000298
Anna Zaks40a7eb32012-02-22 19:24:52 +0000299 ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000300 bool FreesMemOnFailure,
301 ProgramStateRef State) const;
302 static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE,
303 ProgramStateRef State);
Jordy Rose3597b212010-06-07 19:32:37 +0000304
Anna Zaks46d01602012-05-18 01:16:10 +0000305 ///\brief Check if the memory associated with this symbol was released.
306 bool isReleased(SymbolRef Sym, CheckerContext &C) const;
307
Anton Yartsev13df0362013-03-25 01:35:45 +0000308 bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C, const Stmt *S) const;
Anna Zaksa1b227b2012-02-08 23:16:56 +0000309
Jordan Rose656fdd52014-01-08 18:46:55 +0000310 bool checkDoubleDelete(SymbolRef Sym, CheckerContext &C) const;
311
Anna Zaksa4bc5e12013-05-31 23:47:32 +0000312 /// Check if the function is known free memory, or if it is
Jordan Rose613f3c02013-03-09 00:59:10 +0000313 /// "interesting" and should be modeled explicitly.
314 ///
Anna Zaks8ebeb642013-06-08 00:29:29 +0000315 /// \param [out] EscapingSymbol A function might not free memory in general,
316 /// but could be known to free a particular symbol. In this case, false is
Anna Zaksa4bc5e12013-05-31 23:47:32 +0000317 /// returned and the single escaping symbol is returned through the out
318 /// parameter.
319 ///
Jordan Rose613f3c02013-03-09 00:59:10 +0000320 /// We assume that pointers do not escape through calls to system functions
321 /// not handled by this checker.
Anna Zaks8ebeb642013-06-08 00:29:29 +0000322 bool mayFreeAnyEscapedMemoryOrIsModeledExplicitly(const CallEvent *Call,
Anna Zaksa4bc5e12013-05-31 23:47:32 +0000323 ProgramStateRef State,
324 SymbolRef &EscapingSymbol) const;
Anna Zaks3d348342012-02-14 21:55:24 +0000325
Anna Zaks333481b2013-03-28 23:15:29 +0000326 // Implementation of the checkPointerEscape callabcks.
327 ProgramStateRef checkPointerEscapeAux(ProgramStateRef State,
328 const InvalidatedSymbols &Escaped,
329 const CallEvent *Call,
330 PointerEscapeKind Kind,
331 bool(*CheckRefState)(const RefState*)) const;
332
Anton Yartsev1e2bc9b2013-04-11 00:05:20 +0000333 ///@{
334 /// Tells if a given family/call/symbol is tracked by the current checker.
Anton Yartseve5c0c142015-02-18 00:39:06 +0000335 /// Looks through incoming CheckKind(s) and returns the kind of the checker
336 /// responsible for this family/call/symbol.
337 Optional<CheckKind> getCheckIfTracked(CheckKind CK,
338 AllocationFamily Family) const;
339 Optional<CheckKind> getCheckIfTracked(CKVecTy CKVec,
340 AllocationFamily Family) const;
341 Optional<CheckKind> getCheckIfTracked(CKVecTy CKVec, CheckerContext &C,
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000342 const Stmt *AllocDeallocStmt) const;
Anton Yartseve5c0c142015-02-18 00:39:06 +0000343 Optional<CheckKind> getCheckIfTracked(CKVecTy CKVec, CheckerContext &C,
344 SymbolRef Sym) const;
Anton Yartsev1e2bc9b2013-04-11 00:05:20 +0000345 ///@}
Ted Kremenek5ef32db2011-08-12 23:37:29 +0000346 static bool SummarizeValue(raw_ostream &os, SVal V);
347 static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR);
Anton Yartsev05789592013-03-28 17:05:19 +0000348 void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange Range,
349 const Expr *DeallocExpr) const;
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000350 void ReportFreeAlloca(CheckerContext &C, SVal ArgVal,
351 SourceRange Range) const;
Anton Yartseve3377fb2013-04-04 23:46:29 +0000352 void ReportMismatchedDealloc(CheckerContext &C, SourceRange Range,
Anton Yartsevf0593d62013-04-05 11:25:10 +0000353 const Expr *DeallocExpr, const RefState *RS,
Anton Yartsevf5bccce2013-09-16 17:51:25 +0000354 SymbolRef Sym, bool OwnershipTransferred) const;
Anton Yartsev05789592013-03-28 17:05:19 +0000355 void ReportOffsetFree(CheckerContext &C, SVal ArgVal, SourceRange Range,
356 const Expr *DeallocExpr,
Craig Topper0dbb7832014-05-27 02:45:47 +0000357 const Expr *AllocExpr = nullptr) const;
Anton Yartsev59ed15b2013-03-13 14:39:10 +0000358 void ReportUseAfterFree(CheckerContext &C, SourceRange Range,
359 SymbolRef Sym) const;
360 void ReportDoubleFree(CheckerContext &C, SourceRange Range, bool Released,
Anton Yartsev6c2af432013-03-13 17:07:32 +0000361 SymbolRef Sym, SymbolRef PrevSym) const;
Anna Zaks2b5bb972012-02-09 06:25:51 +0000362
Jordan Rose656fdd52014-01-08 18:46:55 +0000363 void ReportDoubleDelete(CheckerContext &C, SymbolRef Sym) const;
364
Anna Zaksdf901a42012-02-23 21:38:21 +0000365 /// Find the location of the allocation for Sym on the path leading to the
366 /// exploded node N.
Anna Zaksfc2e1532012-03-21 19:45:08 +0000367 LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
368 CheckerContext &C) const;
Anna Zaksdf901a42012-02-23 21:38:21 +0000369
Anna Zaksd3571e5a2012-02-11 21:02:40 +0000370 void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const;
371
Anna Zaks2b5bb972012-02-09 06:25:51 +0000372 /// The bug visitor which allows us to print extra diagnostics along the
373 /// BugReport path. For example, showing the allocation site of the leaked
374 /// region.
Jordy Rosef78877e2012-03-24 02:45:35 +0000375 class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> {
Anna Zaks2b5bb972012-02-09 06:25:51 +0000376 protected:
Anna Zaks9eb7bc82012-02-16 22:26:07 +0000377 enum NotificationMode {
378 Normal,
Anna Zaks9eb7bc82012-02-16 22:26:07 +0000379 ReallocationFailed
380 };
381
Anna Zaks2b5bb972012-02-09 06:25:51 +0000382 // The allocated region symbol tracked by the main analysis.
383 SymbolRef Sym;
384
Anna Zaks62cce9e2012-05-10 01:37:40 +0000385 // The mode we are in, i.e. what kind of diagnostics will be emitted.
386 NotificationMode Mode;
Jordy Rose21ff76e2012-03-24 03:15:09 +0000387
Anna Zaks62cce9e2012-05-10 01:37:40 +0000388 // A symbol from when the primary region should have been reallocated.
389 SymbolRef FailedReallocSymbol;
Jordy Rose21ff76e2012-03-24 03:15:09 +0000390
Anna Zaks62cce9e2012-05-10 01:37:40 +0000391 bool IsLeak;
392
393 public:
394 MallocBugVisitor(SymbolRef S, bool isLeak = false)
Craig Topper0dbb7832014-05-27 02:45:47 +0000395 : Sym(S), Mode(Normal), FailedReallocSymbol(nullptr), IsLeak(isLeak) {}
Jordy Rose21ff76e2012-03-24 03:15:09 +0000396
Anna Zaks2b5bb972012-02-09 06:25:51 +0000397 virtual ~MallocBugVisitor() {}
398
Craig Topperfb6b25b2014-03-15 04:29:04 +0000399 void Profile(llvm::FoldingSetNodeID &ID) const override {
Anna Zaks2b5bb972012-02-09 06:25:51 +0000400 static int X = 0;
401 ID.AddPointer(&X);
402 ID.AddPointer(Sym);
403 }
404
Anna Zaks9eb7bc82012-02-16 22:26:07 +0000405 inline bool isAllocated(const RefState *S, const RefState *SPrev,
406 const Stmt *Stmt) {
Anna Zaks2b5bb972012-02-09 06:25:51 +0000407 // Did not track -> allocated. Other state (released) -> allocated.
Anton Yartsev13df0362013-03-25 01:35:45 +0000408 return (Stmt && (isa<CallExpr>(Stmt) || isa<CXXNewExpr>(Stmt)) &&
Anna Zaks9eb7bc82012-02-16 22:26:07 +0000409 (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated()));
Anna Zaks2b5bb972012-02-09 06:25:51 +0000410 }
411
Anna Zaks9eb7bc82012-02-16 22:26:07 +0000412 inline bool isReleased(const RefState *S, const RefState *SPrev,
413 const Stmt *Stmt) {
Anna Zaks2b5bb972012-02-09 06:25:51 +0000414 // Did not track -> released. Other state (allocated) -> released.
Anton Yartsev13df0362013-03-25 01:35:45 +0000415 return (Stmt && (isa<CallExpr>(Stmt) || isa<CXXDeleteExpr>(Stmt)) &&
Anna Zaks9eb7bc82012-02-16 22:26:07 +0000416 (S && S->isReleased()) && (!SPrev || !SPrev->isReleased()));
417 }
418
Anna Zaks0d6989b2012-06-22 02:04:31 +0000419 inline bool isRelinquished(const RefState *S, const RefState *SPrev,
420 const Stmt *Stmt) {
421 // Did not track -> relinquished. Other state (allocated) -> relinquished.
422 return (Stmt && (isa<CallExpr>(Stmt) || isa<ObjCMessageExpr>(Stmt) ||
423 isa<ObjCPropertyRefExpr>(Stmt)) &&
424 (S && S->isRelinquished()) &&
425 (!SPrev || !SPrev->isRelinquished()));
426 }
427
Anna Zaks9eb7bc82012-02-16 22:26:07 +0000428 inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev,
429 const Stmt *Stmt) {
430 // If the expression is not a call, and the state change is
431 // released -> allocated, it must be the realloc return value
432 // check. If we have to handle more cases here, it might be cleaner just
433 // to track this extra bit in the state itself.
434 return ((!Stmt || !isa<CallExpr>(Stmt)) &&
435 (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated()));
Anna Zaks2b5bb972012-02-09 06:25:51 +0000436 }
437
438 PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
439 const ExplodedNode *PrevN,
440 BugReporterContext &BRC,
Craig Topperfb6b25b2014-03-15 04:29:04 +0000441 BugReport &BR) override;
Anna Zaks62cce9e2012-05-10 01:37:40 +0000442
David Blaikied15481c2014-08-29 18:18:43 +0000443 std::unique_ptr<PathDiagnosticPiece>
444 getEndPath(BugReporterContext &BRC, const ExplodedNode *EndPathNode,
445 BugReport &BR) override {
Anna Zaks62cce9e2012-05-10 01:37:40 +0000446 if (!IsLeak)
Craig Topper0dbb7832014-05-27 02:45:47 +0000447 return nullptr;
Anna Zaks62cce9e2012-05-10 01:37:40 +0000448
449 PathDiagnosticLocation L =
450 PathDiagnosticLocation::createEndOfPath(EndPathNode,
451 BRC.getSourceManager());
452 // Do not add the statement itself as a range in case of leak.
David Blaikied15481c2014-08-29 18:18:43 +0000453 return llvm::make_unique<PathDiagnosticEventPiece>(L, BR.getDescription(),
454 false);
Anna Zaks62cce9e2012-05-10 01:37:40 +0000455 }
456
Anna Zakscba4f292012-03-16 23:24:20 +0000457 private:
458 class StackHintGeneratorForReallocationFailed
459 : public StackHintGeneratorForSymbol {
460 public:
461 StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M)
462 : StackHintGeneratorForSymbol(S, M) {}
463
Craig Topperfb6b25b2014-03-15 04:29:04 +0000464 std::string getMessageForArg(const Expr *ArgE,
465 unsigned ArgIndex) override {
Jordan Rosec102b352012-09-22 01:24:42 +0000466 // Printed parameters start at 1, not 0.
467 ++ArgIndex;
468
Anna Zakscba4f292012-03-16 23:24:20 +0000469 SmallString<200> buf;
470 llvm::raw_svector_ostream os(buf);
471
Jordan Rosec102b352012-09-22 01:24:42 +0000472 os << "Reallocation of " << ArgIndex << llvm::getOrdinalSuffix(ArgIndex)
473 << " parameter failed";
Anna Zakscba4f292012-03-16 23:24:20 +0000474
475 return os.str();
476 }
477
Craig Topperfb6b25b2014-03-15 04:29:04 +0000478 std::string getMessageForReturn(const CallExpr *CallExpr) override {
Anna Zaksa7f457a2012-03-16 23:44:28 +0000479 return "Reallocation of returned value failed";
Anna Zakscba4f292012-03-16 23:24:20 +0000480 }
481 };
Anna Zaks2b5bb972012-02-09 06:25:51 +0000482 };
Zhongxing Xu88cca6b2009-11-12 08:38:56 +0000483};
Kovarththanan Rajaratnam65c65662009-11-28 06:07:30 +0000484} // end anonymous namespace
Zhongxing Xu88cca6b2009-11-12 08:38:56 +0000485
Jordan Rose0c153cb2012-11-02 01:54:06 +0000486REGISTER_MAP_WITH_PROGRAMSTATE(RegionState, SymbolRef, RefState)
487REGISTER_MAP_WITH_PROGRAMSTATE(ReallocPairs, SymbolRef, ReallocPair)
Zhongxing Xu88cca6b2009-11-12 08:38:56 +0000488
Anna Zaks67291b92012-11-13 03:18:01 +0000489// A map from the freed symbol to the symbol representing the return value of
490// the free function.
491REGISTER_MAP_WITH_PROGRAMSTATE(FreeReturnValue, SymbolRef, SymbolRef)
492
Anna Zaksbb1ef902012-02-11 21:02:35 +0000493namespace {
494class StopTrackingCallback : public SymbolVisitor {
495 ProgramStateRef state;
496public:
497 StopTrackingCallback(ProgramStateRef st) : state(st) {}
498 ProgramStateRef getState() const { return state; }
499
Craig Topperfb6b25b2014-03-15 04:29:04 +0000500 bool VisitSymbol(SymbolRef sym) override {
Anna Zaksbb1ef902012-02-11 21:02:35 +0000501 state = state->remove<RegionState>(sym);
502 return true;
503 }
504};
505} // end anonymous namespace
506
Anna Zaks3d348342012-02-14 21:55:24 +0000507void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const {
Anna Zaksb3436602012-05-18 22:47:40 +0000508 if (II_malloc)
509 return;
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000510 II_alloca = &Ctx.Idents.get("alloca");
511 II_alloca_builtin = &Ctx.Idents.get("__builtin_alloca");
Anna Zaksb3436602012-05-18 22:47:40 +0000512 II_malloc = &Ctx.Idents.get("malloc");
513 II_free = &Ctx.Idents.get("free");
514 II_realloc = &Ctx.Idents.get("realloc");
515 II_reallocf = &Ctx.Idents.get("reallocf");
516 II_calloc = &Ctx.Idents.get("calloc");
517 II_valloc = &Ctx.Idents.get("valloc");
518 II_strdup = &Ctx.Idents.get("strdup");
519 II_strndup = &Ctx.Idents.get("strndup");
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000520 II_kmalloc = &Ctx.Idents.get("kmalloc");
Anna Zaksd79b8402014-10-03 21:48:59 +0000521 II_if_nameindex = &Ctx.Idents.get("if_nameindex");
522 II_if_freenameindex = &Ctx.Idents.get("if_freenameindex");
Anna Zaksc68bf4c2012-02-08 20:13:28 +0000523}
524
Anna Zaks3d348342012-02-14 21:55:24 +0000525bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const {
Anna Zaksd79b8402014-10-03 21:48:59 +0000526 if (isCMemFunction(FD, C, AF_Malloc, MemoryOperationKind::MOK_Any))
Anna Zaks46d01602012-05-18 01:16:10 +0000527 return true;
528
Anna Zaksd79b8402014-10-03 21:48:59 +0000529 if (isCMemFunction(FD, C, AF_IfNameIndex, MemoryOperationKind::MOK_Any))
Anna Zaks46d01602012-05-18 01:16:10 +0000530 return true;
531
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000532 if (isCMemFunction(FD, C, AF_Alloca, MemoryOperationKind::MOK_Any))
533 return true;
534
Anton Yartsev13df0362013-03-25 01:35:45 +0000535 if (isStandardNewDelete(FD, C))
536 return true;
537
Anna Zaks46d01602012-05-18 01:16:10 +0000538 return false;
539}
540
Anna Zaksd79b8402014-10-03 21:48:59 +0000541bool MallocChecker::isCMemFunction(const FunctionDecl *FD,
542 ASTContext &C,
543 AllocationFamily Family,
Benjamin Kramer719772c2014-10-03 22:20:30 +0000544 MemoryOperationKind MemKind) const {
Anna Zaksd1ff1cb2012-02-15 02:12:00 +0000545 if (!FD)
546 return false;
Anna Zaks46d01602012-05-18 01:16:10 +0000547
Anna Zaksd79b8402014-10-03 21:48:59 +0000548 bool CheckFree = (MemKind == MemoryOperationKind::MOK_Any ||
549 MemKind == MemoryOperationKind::MOK_Free);
550 bool CheckAlloc = (MemKind == MemoryOperationKind::MOK_Any ||
551 MemKind == MemoryOperationKind::MOK_Allocate);
552
Jordan Rose6cd16c52012-07-10 23:13:01 +0000553 if (FD->getKind() == Decl::Function) {
Anna Zaksd79b8402014-10-03 21:48:59 +0000554 const IdentifierInfo *FunI = FD->getIdentifier();
Jordan Rose6cd16c52012-07-10 23:13:01 +0000555 initIdentifierInfo(C);
Anna Zaks3d348342012-02-14 21:55:24 +0000556
Anna Zaksd79b8402014-10-03 21:48:59 +0000557 if (Family == AF_Malloc && CheckFree) {
558 if (FunI == II_free || FunI == II_realloc || FunI == II_reallocf)
559 return true;
560 }
561
562 if (Family == AF_Malloc && CheckAlloc) {
563 if (FunI == II_malloc || FunI == II_realloc || FunI == II_reallocf ||
564 FunI == II_calloc || FunI == II_valloc || FunI == II_strdup ||
565 FunI == II_strndup || FunI == II_kmalloc)
566 return true;
567 }
568
569 if (Family == AF_IfNameIndex && CheckFree) {
570 if (FunI == II_if_freenameindex)
571 return true;
572 }
573
574 if (Family == AF_IfNameIndex && CheckAlloc) {
575 if (FunI == II_if_nameindex)
576 return true;
577 }
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000578
579 if (Family == AF_Alloca && CheckAlloc) {
580 if (FunI == II_alloca || FunI == II_alloca_builtin)
581 return true;
582 }
Jordan Rose6cd16c52012-07-10 23:13:01 +0000583 }
Anna Zaks3d348342012-02-14 21:55:24 +0000584
Anna Zaksd79b8402014-10-03 21:48:59 +0000585 if (Family != AF_Malloc)
Anna Zaks46d01602012-05-18 01:16:10 +0000586 return false;
587
Anna Zaksd79b8402014-10-03 21:48:59 +0000588 if (ChecksEnabled[CK_MallocOptimistic] && FD->hasAttrs()) {
589 for (const auto *I : FD->specific_attrs<OwnershipAttr>()) {
590 OwnershipAttr::OwnershipKind OwnKind = I->getOwnKind();
591 if(OwnKind == OwnershipAttr::Takes || OwnKind == OwnershipAttr::Holds) {
592 if (CheckFree)
593 return true;
594 } else if (OwnKind == OwnershipAttr::Returns) {
595 if (CheckAlloc)
596 return true;
597 }
598 }
Jordan Rose6cd16c52012-07-10 23:13:01 +0000599 }
Anna Zaks3d348342012-02-14 21:55:24 +0000600
Anna Zaks3d348342012-02-14 21:55:24 +0000601 return false;
602}
603
Anton Yartsev8b662702013-03-28 16:10:38 +0000604// Tells if the callee is one of the following:
605// 1) A global non-placement new/delete operator function.
606// 2) A global placement operator function with the single placement argument
607// of type std::nothrow_t.
Anton Yartsev13df0362013-03-25 01:35:45 +0000608bool MallocChecker::isStandardNewDelete(const FunctionDecl *FD,
609 ASTContext &C) const {
610 if (!FD)
611 return false;
612
613 OverloadedOperatorKind Kind = FD->getOverloadedOperator();
614 if (Kind != OO_New && Kind != OO_Array_New &&
615 Kind != OO_Delete && Kind != OO_Array_Delete)
616 return false;
617
Anton Yartsev8b662702013-03-28 16:10:38 +0000618 // Skip all operator new/delete methods.
619 if (isa<CXXMethodDecl>(FD))
Anton Yartsev13df0362013-03-25 01:35:45 +0000620 return false;
621
622 // Return true if tested operator is a standard placement nothrow operator.
623 if (FD->getNumParams() == 2) {
624 QualType T = FD->getParamDecl(1)->getType();
625 if (const IdentifierInfo *II = T.getBaseTypeIdentifier())
626 return II->getName().equals("nothrow_t");
627 }
628
629 // Skip placement operators.
630 if (FD->getNumParams() != 1 || FD->isVariadic())
631 return false;
632
633 // One of the standard new/new[]/delete/delete[] non-placement operators.
634 return true;
635}
636
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000637llvm::Optional<ProgramStateRef> MallocChecker::performKernelMalloc(
638 const CallExpr *CE, CheckerContext &C, const ProgramStateRef &State) const {
639 // 3-argument malloc(), as commonly used in {Free,Net,Open}BSD Kernels:
640 //
641 // void *malloc(unsigned long size, struct malloc_type *mtp, int flags);
642 //
643 // One of the possible flags is M_ZERO, which means 'give me back an
644 // allocation which is already zeroed', like calloc.
645
646 // 2-argument kmalloc(), as used in the Linux kernel:
647 //
648 // void *kmalloc(size_t size, gfp_t flags);
649 //
650 // Has the similar flag value __GFP_ZERO.
651
652 // This logic is largely cloned from O_CREAT in UnixAPIChecker, maybe some
653 // code could be shared.
654
655 ASTContext &Ctx = C.getASTContext();
656 llvm::Triple::OSType OS = Ctx.getTargetInfo().getTriple().getOS();
657
658 if (!KernelZeroFlagVal.hasValue()) {
659 if (OS == llvm::Triple::FreeBSD)
660 KernelZeroFlagVal = 0x0100;
661 else if (OS == llvm::Triple::NetBSD)
662 KernelZeroFlagVal = 0x0002;
663 else if (OS == llvm::Triple::OpenBSD)
664 KernelZeroFlagVal = 0x0008;
665 else if (OS == llvm::Triple::Linux)
666 // __GFP_ZERO
667 KernelZeroFlagVal = 0x8000;
668 else
669 // FIXME: We need a more general way of getting the M_ZERO value.
670 // See also: O_CREAT in UnixAPIChecker.cpp.
671
672 // Fall back to normal malloc behavior on platforms where we don't
673 // know M_ZERO.
674 return None;
675 }
676
677 // We treat the last argument as the flags argument, and callers fall-back to
678 // normal malloc on a None return. This works for the FreeBSD kernel malloc
679 // as well as Linux kmalloc.
680 if (CE->getNumArgs() < 2)
681 return None;
682
683 const Expr *FlagsEx = CE->getArg(CE->getNumArgs() - 1);
684 const SVal V = State->getSVal(FlagsEx, C.getLocationContext());
685 if (!V.getAs<NonLoc>()) {
686 // The case where 'V' can be a location can only be due to a bad header,
687 // so in this case bail out.
688 return None;
689 }
690
691 NonLoc Flags = V.castAs<NonLoc>();
692 NonLoc ZeroFlag = C.getSValBuilder()
693 .makeIntVal(KernelZeroFlagVal.getValue(), FlagsEx->getType())
694 .castAs<NonLoc>();
695 SVal MaskedFlagsUC = C.getSValBuilder().evalBinOpNN(State, BO_And,
696 Flags, ZeroFlag,
697 FlagsEx->getType());
698 if (MaskedFlagsUC.isUnknownOrUndef())
699 return None;
700 DefinedSVal MaskedFlags = MaskedFlagsUC.castAs<DefinedSVal>();
701
702 // Check if maskedFlags is non-zero.
703 ProgramStateRef TrueState, FalseState;
704 std::tie(TrueState, FalseState) = State->assume(MaskedFlags);
705
706 // If M_ZERO is set, treat this like calloc (initialized).
707 if (TrueState && !FalseState) {
708 SVal ZeroVal = C.getSValBuilder().makeZeroVal(Ctx.CharTy);
709 return MallocMemAux(C, CE, CE->getArg(0), ZeroVal, TrueState);
710 }
711
712 return None;
713}
714
Anna Zaksc68bf4c2012-02-08 20:13:28 +0000715void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const {
Jordan Rosed6e5fd52012-09-20 01:55:32 +0000716 if (C.wasInlined)
717 return;
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000718
Anna Zaksc68bf4c2012-02-08 20:13:28 +0000719 const FunctionDecl *FD = C.getCalleeDecl(CE);
720 if (!FD)
721 return;
Zhongxing Xu88cca6b2009-11-12 08:38:56 +0000722
Anna Zaks40a7eb32012-02-22 19:24:52 +0000723 ProgramStateRef State = C.getState();
Anna Zaksfe6eb672012-08-24 02:28:20 +0000724 bool ReleasedAllocatedMemory = false;
Jordan Rose6cd16c52012-07-10 23:13:01 +0000725
726 if (FD->getKind() == Decl::Function) {
727 initIdentifierInfo(C.getASTContext());
728 IdentifierInfo *FunI = FD->getIdentifier();
729
Jordan Rose6b33c6f2014-03-26 17:05:46 +0000730 if (FunI == II_malloc) {
731 if (CE->getNumArgs() < 1)
732 return;
733 if (CE->getNumArgs() < 3) {
734 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
735 } else if (CE->getNumArgs() == 3) {
736 llvm::Optional<ProgramStateRef> MaybeState =
737 performKernelMalloc(CE, C, State);
738 if (MaybeState.hasValue())
739 State = MaybeState.getValue();
740 else
741 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
742 }
743 } else if (FunI == II_kmalloc) {
744 llvm::Optional<ProgramStateRef> MaybeState =
745 performKernelMalloc(CE, C, State);
746 if (MaybeState.hasValue())
747 State = MaybeState.getValue();
748 else
749 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
750 } else if (FunI == II_valloc) {
Anton Yartseve3377fb2013-04-04 23:46:29 +0000751 if (CE->getNumArgs() < 1)
752 return;
753 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
754 } else if (FunI == II_realloc) {
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000755 State = ReallocMem(C, CE, false, State);
Anton Yartseve3377fb2013-04-04 23:46:29 +0000756 } else if (FunI == II_reallocf) {
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000757 State = ReallocMem(C, CE, true, State);
Anton Yartseve3377fb2013-04-04 23:46:29 +0000758 } else if (FunI == II_calloc) {
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000759 State = CallocMem(C, CE, State);
Anton Yartseve3377fb2013-04-04 23:46:29 +0000760 } else if (FunI == II_free) {
761 State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory);
762 } else if (FunI == II_strdup) {
763 State = MallocUpdateRefState(C, CE, State);
764 } else if (FunI == II_strndup) {
765 State = MallocUpdateRefState(C, CE, State);
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +0000766 } else if (FunI == II_alloca || FunI == II_alloca_builtin) {
767 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State,
768 AF_Alloca);
769 } else if (isStandardNewDelete(FD, C.getASTContext())) {
Anton Yartseve3377fb2013-04-04 23:46:29 +0000770 // Process direct calls to operator new/new[]/delete/delete[] functions
771 // as distinct from new/new[]/delete/delete[] expressions that are
772 // processed by the checkPostStmt callbacks for CXXNewExpr and
773 // CXXDeleteExpr.
774 OverloadedOperatorKind K = FD->getOverloadedOperator();
775 if (K == OO_New)
776 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State,
777 AF_CXXNew);
778 else if (K == OO_Array_New)
779 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State,
780 AF_CXXNewArray);
781 else if (K == OO_Delete || K == OO_Array_Delete)
782 State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory);
783 else
784 llvm_unreachable("not a new/delete operator");
Anna Zaksd79b8402014-10-03 21:48:59 +0000785 } else if (FunI == II_if_nameindex) {
786 // Should we model this differently? We can allocate a fixed number of
787 // elements with zeros in the last one.
788 State = MallocMemAux(C, CE, UnknownVal(), UnknownVal(), State,
789 AF_IfNameIndex);
790 } else if (FunI == II_if_freenameindex) {
791 State = FreeMemAux(C, CE, State, 0, false, ReleasedAllocatedMemory);
Jordan Rose6cd16c52012-07-10 23:13:01 +0000792 }
793 }
794
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000795 if (ChecksEnabled[CK_MallocOptimistic] ||
796 ChecksEnabled[CK_MismatchedDeallocatorChecker]) {
Anna Zaks40a7eb32012-02-22 19:24:52 +0000797 // Check all the attributes, if there are any.
798 // There can be multiple of these attributes.
799 if (FD->hasAttrs())
Aaron Ballmanbe22bcb2014-03-10 17:08:28 +0000800 for (const auto *I : FD->specific_attrs<OwnershipAttr>()) {
801 switch (I->getOwnKind()) {
Anna Zaks40a7eb32012-02-22 19:24:52 +0000802 case OwnershipAttr::Returns:
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000803 State = MallocMemReturnsAttr(C, CE, I, State);
Anna Zaks40a7eb32012-02-22 19:24:52 +0000804 break;
805 case OwnershipAttr::Takes:
806 case OwnershipAttr::Holds:
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000807 State = FreeMemAttr(C, CE, I, State);
Anna Zaks40a7eb32012-02-22 19:24:52 +0000808 break;
809 }
810 }
Zhongxing Xu527ff6d2010-06-01 03:01:33 +0000811 }
Anna Zaks199e8e52012-02-22 03:14:20 +0000812 C.addTransition(State);
Zhongxing Xuc0484fa2009-12-12 12:29:38 +0000813}
814
Anton Yartsev4e4cb6b2014-08-05 18:26:05 +0000815static QualType getDeepPointeeType(QualType T) {
816 QualType Result = T, PointeeType = T->getPointeeType();
817 while (!PointeeType.isNull()) {
818 Result = PointeeType;
819 PointeeType = PointeeType->getPointeeType();
820 }
821 return Result;
822}
823
824static bool treatUnusedNewEscaped(const CXXNewExpr *NE) {
825
826 const CXXConstructExpr *ConstructE = NE->getConstructExpr();
827 if (!ConstructE)
828 return false;
829
830 if (!NE->getAllocatedType()->getAsCXXRecordDecl())
831 return false;
832
833 const CXXConstructorDecl *CtorD = ConstructE->getConstructor();
834
835 // Iterate over the constructor parameters.
836 for (const auto *CtorParam : CtorD->params()) {
837
838 QualType CtorParamPointeeT = CtorParam->getType()->getPointeeType();
839 if (CtorParamPointeeT.isNull())
840 continue;
841
842 CtorParamPointeeT = getDeepPointeeType(CtorParamPointeeT);
843
844 if (CtorParamPointeeT->getAsCXXRecordDecl())
845 return true;
846 }
847
848 return false;
849}
850
Anton Yartsev13df0362013-03-25 01:35:45 +0000851void MallocChecker::checkPostStmt(const CXXNewExpr *NE,
852 CheckerContext &C) const {
853
854 if (NE->getNumPlacementArgs())
855 for (CXXNewExpr::const_arg_iterator I = NE->placement_arg_begin(),
856 E = NE->placement_arg_end(); I != E; ++I)
857 if (SymbolRef Sym = C.getSVal(*I).getAsSymbol())
858 checkUseAfterFree(Sym, C, *I);
859
Anton Yartsev13df0362013-03-25 01:35:45 +0000860 if (!isStandardNewDelete(NE->getOperatorNew(), C.getASTContext()))
861 return;
862
Anton Yartsev4e4cb6b2014-08-05 18:26:05 +0000863 ParentMap &PM = C.getLocationContext()->getParentMap();
864 if (!PM.isConsumedExpr(NE) && treatUnusedNewEscaped(NE))
865 return;
866
Anton Yartsev13df0362013-03-25 01:35:45 +0000867 ProgramStateRef State = C.getState();
868 // The return value from operator new is bound to a specified initialization
869 // value (if any) and we don't want to loose this value. So we call
870 // MallocUpdateRefState() instead of MallocMemAux() which breakes the
871 // existing binding.
Anton Yartsev05789592013-03-28 17:05:19 +0000872 State = MallocUpdateRefState(C, NE, State, NE->isArray() ? AF_CXXNewArray
873 : AF_CXXNew);
Anton Yartsev13df0362013-03-25 01:35:45 +0000874 C.addTransition(State);
875}
876
877void MallocChecker::checkPreStmt(const CXXDeleteExpr *DE,
878 CheckerContext &C) const {
879
Alexander Kornienko4aca9b12014-02-11 21:49:21 +0000880 if (!ChecksEnabled[CK_NewDeleteChecker])
Anton Yartsev13df0362013-03-25 01:35:45 +0000881 if (SymbolRef Sym = C.getSVal(DE->getArgument()).getAsSymbol())
882 checkUseAfterFree(Sym, C, DE->getArgument());
883
Anton Yartsev13df0362013-03-25 01:35:45 +0000884 if (!isStandardNewDelete(DE->getOperatorDelete(), C.getASTContext()))
885 return;
886
887 ProgramStateRef State = C.getState();
888 bool ReleasedAllocated;
889 State = FreeMemAux(C, DE->getArgument(), DE, State,
890 /*Hold*/false, ReleasedAllocated);
891
892 C.addTransition(State);
893}
894
Jordan Rose613f3c02013-03-09 00:59:10 +0000895static bool isKnownDeallocObjCMethodName(const ObjCMethodCall &Call) {
896 // If the first selector piece is one of the names below, assume that the
897 // object takes ownership of the memory, promising to eventually deallocate it
898 // with free().
899 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
900 // (...unless a 'freeWhenDone' parameter is false, but that's checked later.)
901 StringRef FirstSlot = Call.getSelector().getNameForSlot(0);
902 if (FirstSlot == "dataWithBytesNoCopy" ||
903 FirstSlot == "initWithBytesNoCopy" ||
904 FirstSlot == "initWithCharactersNoCopy")
905 return true;
Anna Zaks0d6989b2012-06-22 02:04:31 +0000906
907 return false;
908}
909
Jordan Rose613f3c02013-03-09 00:59:10 +0000910static Optional<bool> getFreeWhenDoneArg(const ObjCMethodCall &Call) {
911 Selector S = Call.getSelector();
912
913 // FIXME: We should not rely on fully-constrained symbols being folded.
914 for (unsigned i = 1; i < S.getNumArgs(); ++i)
915 if (S.getNameForSlot(i).equals("freeWhenDone"))
916 return !Call.getArgSVal(i).isZeroConstant();
917
918 return None;
919}
920
Anna Zaks67291b92012-11-13 03:18:01 +0000921void MallocChecker::checkPostObjCMessage(const ObjCMethodCall &Call,
922 CheckerContext &C) const {
Anna Zaksa7b1c472012-12-11 00:17:53 +0000923 if (C.wasInlined)
924 return;
925
Jordan Rose613f3c02013-03-09 00:59:10 +0000926 if (!isKnownDeallocObjCMethodName(Call))
927 return;
Anna Zaks67291b92012-11-13 03:18:01 +0000928
Jordan Rose613f3c02013-03-09 00:59:10 +0000929 if (Optional<bool> FreeWhenDone = getFreeWhenDoneArg(Call))
930 if (!*FreeWhenDone)
931 return;
932
933 bool ReleasedAllocatedMemory;
934 ProgramStateRef State = FreeMemAux(C, Call.getArgExpr(0),
935 Call.getOriginExpr(), C.getState(),
936 /*Hold=*/true, ReleasedAllocatedMemory,
937 /*RetNullOnFailure=*/true);
938
939 C.addTransition(State);
Anna Zaks0d6989b2012-06-22 02:04:31 +0000940}
941
Richard Smith852e9ce2013-11-27 01:46:48 +0000942ProgramStateRef
943MallocChecker::MallocMemReturnsAttr(CheckerContext &C, const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000944 const OwnershipAttr *Att,
945 ProgramStateRef State) const {
946 if (!State)
947 return nullptr;
948
Richard Smith852e9ce2013-11-27 01:46:48 +0000949 if (Att->getModule() != II_malloc)
Craig Topper0dbb7832014-05-27 02:45:47 +0000950 return nullptr;
Ted Kremenekd21139a2010-07-31 01:52:11 +0000951
Alexis Huntdcfba7b2010-08-18 23:23:40 +0000952 OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
Ted Kremenekd21139a2010-07-31 01:52:11 +0000953 if (I != E) {
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000954 return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), State);
Ted Kremenekd21139a2010-07-31 01:52:11 +0000955 }
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000956 return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), State);
957}
958
959ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
960 const CallExpr *CE,
961 const Expr *SizeEx, SVal Init,
962 ProgramStateRef State,
963 AllocationFamily Family) {
964 if (!State)
965 return nullptr;
966
967 return MallocMemAux(C, CE, State->getSVal(SizeEx, C.getLocationContext()),
968 Init, State, Family);
Ted Kremenekd21139a2010-07-31 01:52:11 +0000969}
970
Anna Zaksc68bf4c2012-02-08 20:13:28 +0000971ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
Zhongxing Xuc0484fa2009-12-12 12:29:38 +0000972 const CallExpr *CE,
Zhongxing Xu527ff6d2010-06-01 03:01:33 +0000973 SVal Size, SVal Init,
Anton Yartsev05789592013-03-28 17:05:19 +0000974 ProgramStateRef State,
975 AllocationFamily Family) {
Anton Yartsevb3fa86d2015-02-10 20:13:08 +0000976 if (!State)
977 return nullptr;
Anna Zaks3563fde2012-06-07 03:57:32 +0000978
Jordan Rosef69e65f2014-09-05 16:33:51 +0000979 // We expect the malloc functions to return a pointer.
980 if (!Loc::isLocType(CE->getType()))
981 return nullptr;
982
Anna Zaks3563fde2012-06-07 03:57:32 +0000983 // Bind the return value to the symbolic value from the heap region.
984 // TODO: We could rewrite post visit to eval call; 'malloc' does not have
985 // side effects other than what we model here.
Ted Kremenekd94854a2012-08-22 06:26:15 +0000986 unsigned Count = C.blockCount();
Anna Zaks3563fde2012-06-07 03:57:32 +0000987 SValBuilder &svalBuilder = C.getSValBuilder();
988 const LocationContext *LCtx = C.getPredecessor()->getLocationContext();
David Blaikie2fdacbc2013-02-20 05:52:05 +0000989 DefinedSVal RetVal = svalBuilder.getConjuredHeapSymbolVal(CE, LCtx, Count)
990 .castAs<DefinedSVal>();
Anton Yartsev05789592013-03-28 17:05:19 +0000991 State = State->BindExpr(CE, C.getLocationContext(), RetVal);
Zhongxing Xu9cb53b82009-12-11 03:09:01 +0000992
Jordy Rose674bd552010-07-04 00:00:41 +0000993 // Fill the region with the initialization value.
Anton Yartsev05789592013-03-28 17:05:19 +0000994 State = State->bindDefault(RetVal, Init);
Zhongxing Xu527ff6d2010-06-01 03:01:33 +0000995
Jordy Rose674bd552010-07-04 00:00:41 +0000996 // Set the region's extent equal to the Size parameter.
Anna Zaks31886862012-02-10 01:11:00 +0000997 const SymbolicRegion *R =
Anna Zaks3563fde2012-06-07 03:57:32 +0000998 dyn_cast_or_null<SymbolicRegion>(RetVal.getAsRegion());
Anna Zaks199e8e52012-02-22 03:14:20 +0000999 if (!R)
Craig Topper0dbb7832014-05-27 02:45:47 +00001000 return nullptr;
David Blaikie05785d12013-02-20 22:23:23 +00001001 if (Optional<DefinedOrUnknownSVal> DefinedSize =
David Blaikie2fdacbc2013-02-20 05:52:05 +00001002 Size.getAs<DefinedOrUnknownSVal>()) {
Anna Zaks40a7eb32012-02-22 19:24:52 +00001003 SValBuilder &svalBuilder = C.getSValBuilder();
Anna Zaks199e8e52012-02-22 03:14:20 +00001004 DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder);
Anna Zaks199e8e52012-02-22 03:14:20 +00001005 DefinedOrUnknownSVal extentMatchesSize =
Anton Yartsev05789592013-03-28 17:05:19 +00001006 svalBuilder.evalEQ(State, Extent, *DefinedSize);
Anna Zaks31886862012-02-10 01:11:00 +00001007
Anton Yartsev05789592013-03-28 17:05:19 +00001008 State = State->assume(extentMatchesSize, true);
1009 assert(State);
Anna Zaks199e8e52012-02-22 03:14:20 +00001010 }
Ted Kremenek90af9092010-12-02 07:49:45 +00001011
Anton Yartsev05789592013-03-28 17:05:19 +00001012 return MallocUpdateRefState(C, CE, State, Family);
Anna Zaks40a7eb32012-02-22 19:24:52 +00001013}
1014
1015ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C,
Anton Yartsev13df0362013-03-25 01:35:45 +00001016 const Expr *E,
Anton Yartsev05789592013-03-28 17:05:19 +00001017 ProgramStateRef State,
1018 AllocationFamily Family) {
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001019 if (!State)
1020 return nullptr;
1021
Anna Zaks40a7eb32012-02-22 19:24:52 +00001022 // Get the return value.
Anton Yartsev05789592013-03-28 17:05:19 +00001023 SVal retVal = State->getSVal(E, C.getLocationContext());
Anna Zaks40a7eb32012-02-22 19:24:52 +00001024
1025 // We expect the malloc functions to return a pointer.
David Blaikie2fdacbc2013-02-20 05:52:05 +00001026 if (!retVal.getAs<Loc>())
Craig Topper0dbb7832014-05-27 02:45:47 +00001027 return nullptr;
Anna Zaks40a7eb32012-02-22 19:24:52 +00001028
Ted Kremenek90af9092010-12-02 07:49:45 +00001029 SymbolRef Sym = retVal.getAsLocSymbol();
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001030 assert(Sym);
Ted Kremenek90af9092010-12-02 07:49:45 +00001031
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001032 // Set the symbol's state to Allocated.
Anton Yartsev05789592013-03-28 17:05:19 +00001033 return State->set<RegionState>(Sym, RefState::getAllocated(Family, E));
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001034}
1035
Anna Zaks40a7eb32012-02-22 19:24:52 +00001036ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C,
1037 const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001038 const OwnershipAttr *Att,
1039 ProgramStateRef State) const {
1040 if (!State)
1041 return nullptr;
1042
Richard Smith852e9ce2013-11-27 01:46:48 +00001043 if (Att->getModule() != II_malloc)
Craig Topper0dbb7832014-05-27 02:45:47 +00001044 return nullptr;
Ted Kremenekd21139a2010-07-31 01:52:11 +00001045
Anna Zaksfe6eb672012-08-24 02:28:20 +00001046 bool ReleasedAllocated = false;
Anna Zaks8dc53af2012-03-01 22:06:06 +00001047
Aaron Ballmana82eaa72014-05-02 13:35:42 +00001048 for (const auto &Arg : Att->args()) {
1049 ProgramStateRef StateI = FreeMemAux(C, CE, State, Arg,
Anna Zaksfe6eb672012-08-24 02:28:20 +00001050 Att->getOwnKind() == OwnershipAttr::Holds,
1051 ReleasedAllocated);
Anna Zaks8dc53af2012-03-01 22:06:06 +00001052 if (StateI)
1053 State = StateI;
Ted Kremenekd21139a2010-07-31 01:52:11 +00001054 }
Anna Zaks8dc53af2012-03-01 22:06:06 +00001055 return State;
Ted Kremenekd21139a2010-07-31 01:52:11 +00001056}
1057
Ted Kremenek49b1e382012-01-26 21:29:00 +00001058ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
Anna Zaks31886862012-02-10 01:11:00 +00001059 const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001060 ProgramStateRef State,
Anna Zaks31886862012-02-10 01:11:00 +00001061 unsigned Num,
Anna Zaksfe6eb672012-08-24 02:28:20 +00001062 bool Hold,
Anna Zaks67291b92012-11-13 03:18:01 +00001063 bool &ReleasedAllocated,
1064 bool ReturnsNullOnFailure) const {
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001065 if (!State)
1066 return nullptr;
1067
Anna Zaksb508d292012-04-10 23:41:11 +00001068 if (CE->getNumArgs() < (Num + 1))
Craig Topper0dbb7832014-05-27 02:45:47 +00001069 return nullptr;
Anna Zaksb508d292012-04-10 23:41:11 +00001070
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001071 return FreeMemAux(C, CE->getArg(Num), CE, State, Hold,
Anna Zaks67291b92012-11-13 03:18:01 +00001072 ReleasedAllocated, ReturnsNullOnFailure);
1073}
1074
Anna Zaksa14c1d02012-11-13 19:47:40 +00001075/// Checks if the previous call to free on the given symbol failed - if free
1076/// failed, returns true. Also, returns the corresponding return value symbol.
Benjamin Kramerba4c85e2012-11-22 15:02:44 +00001077static bool didPreviousFreeFail(ProgramStateRef State,
1078 SymbolRef Sym, SymbolRef &RetStatusSymbol) {
Anna Zaksa14c1d02012-11-13 19:47:40 +00001079 const SymbolRef *Ret = State->get<FreeReturnValue>(Sym);
Anna Zaks67291b92012-11-13 03:18:01 +00001080 if (Ret) {
1081 assert(*Ret && "We should not store the null return symbol");
1082 ConstraintManager &CMgr = State->getConstraintManager();
1083 ConditionTruthVal FreeFailed = CMgr.isNull(State, *Ret);
Anna Zaksa14c1d02012-11-13 19:47:40 +00001084 RetStatusSymbol = *Ret;
1085 return FreeFailed.isConstrainedTrue();
Anna Zaks67291b92012-11-13 03:18:01 +00001086 }
Anna Zaksa14c1d02012-11-13 19:47:40 +00001087 return false;
Anna Zaks0d6989b2012-06-22 02:04:31 +00001088}
1089
Anton Yartsev05789592013-03-28 17:05:19 +00001090AllocationFamily MallocChecker::getAllocationFamily(CheckerContext &C,
Anton Yartseve3377fb2013-04-04 23:46:29 +00001091 const Stmt *S) const {
1092 if (!S)
Anton Yartsev05789592013-03-28 17:05:19 +00001093 return AF_None;
1094
Anton Yartseve3377fb2013-04-04 23:46:29 +00001095 if (const CallExpr *CE = dyn_cast<CallExpr>(S)) {
Anton Yartsev05789592013-03-28 17:05:19 +00001096 const FunctionDecl *FD = C.getCalleeDecl(CE);
Anton Yartseve3377fb2013-04-04 23:46:29 +00001097
1098 if (!FD)
1099 FD = dyn_cast<FunctionDecl>(CE->getCalleeDecl());
1100
Anton Yartsev05789592013-03-28 17:05:19 +00001101 ASTContext &Ctx = C.getASTContext();
1102
Anna Zaksd79b8402014-10-03 21:48:59 +00001103 if (isCMemFunction(FD, Ctx, AF_Malloc, MemoryOperationKind::MOK_Any))
Anton Yartsev05789592013-03-28 17:05:19 +00001104 return AF_Malloc;
1105
1106 if (isStandardNewDelete(FD, Ctx)) {
1107 OverloadedOperatorKind Kind = FD->getOverloadedOperator();
Anton Yartseve3377fb2013-04-04 23:46:29 +00001108 if (Kind == OO_New || Kind == OO_Delete)
Anton Yartsev05789592013-03-28 17:05:19 +00001109 return AF_CXXNew;
Anton Yartseve3377fb2013-04-04 23:46:29 +00001110 else if (Kind == OO_Array_New || Kind == OO_Array_Delete)
Anton Yartsev05789592013-03-28 17:05:19 +00001111 return AF_CXXNewArray;
1112 }
1113
Anna Zaksd79b8402014-10-03 21:48:59 +00001114 if (isCMemFunction(FD, Ctx, AF_IfNameIndex, MemoryOperationKind::MOK_Any))
1115 return AF_IfNameIndex;
1116
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001117 if (isCMemFunction(FD, Ctx, AF_Alloca, MemoryOperationKind::MOK_Any))
1118 return AF_Alloca;
1119
Anton Yartsev05789592013-03-28 17:05:19 +00001120 return AF_None;
1121 }
1122
Anton Yartseve3377fb2013-04-04 23:46:29 +00001123 if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(S))
1124 return NE->isArray() ? AF_CXXNewArray : AF_CXXNew;
1125
1126 if (const CXXDeleteExpr *DE = dyn_cast<CXXDeleteExpr>(S))
Anton Yartsev05789592013-03-28 17:05:19 +00001127 return DE->isArrayForm() ? AF_CXXNewArray : AF_CXXNew;
1128
Anton Yartseve3377fb2013-04-04 23:46:29 +00001129 if (isa<ObjCMessageExpr>(S))
Anton Yartsev05789592013-03-28 17:05:19 +00001130 return AF_Malloc;
1131
1132 return AF_None;
1133}
1134
1135bool MallocChecker::printAllocDeallocName(raw_ostream &os, CheckerContext &C,
1136 const Expr *E) const {
1137 if (const CallExpr *CE = dyn_cast<CallExpr>(E)) {
1138 // FIXME: This doesn't handle indirect calls.
1139 const FunctionDecl *FD = CE->getDirectCallee();
1140 if (!FD)
1141 return false;
1142
1143 os << *FD;
1144 if (!FD->isOverloadedOperator())
1145 os << "()";
1146 return true;
1147 }
1148
1149 if (const ObjCMessageExpr *Msg = dyn_cast<ObjCMessageExpr>(E)) {
1150 if (Msg->isInstanceMessage())
1151 os << "-";
1152 else
1153 os << "+";
Aaron Ballmanb190f972014-01-03 17:59:55 +00001154 Msg->getSelector().print(os);
Anton Yartsev05789592013-03-28 17:05:19 +00001155 return true;
1156 }
1157
1158 if (const CXXNewExpr *NE = dyn_cast<CXXNewExpr>(E)) {
1159 os << "'"
1160 << getOperatorSpelling(NE->getOperatorNew()->getOverloadedOperator())
1161 << "'";
1162 return true;
1163 }
1164
1165 if (const CXXDeleteExpr *DE = dyn_cast<CXXDeleteExpr>(E)) {
1166 os << "'"
1167 << getOperatorSpelling(DE->getOperatorDelete()->getOverloadedOperator())
1168 << "'";
1169 return true;
1170 }
1171
1172 return false;
1173}
1174
1175void MallocChecker::printExpectedAllocName(raw_ostream &os, CheckerContext &C,
1176 const Expr *E) const {
1177 AllocationFamily Family = getAllocationFamily(C, E);
1178
1179 switch(Family) {
1180 case AF_Malloc: os << "malloc()"; return;
1181 case AF_CXXNew: os << "'new'"; return;
1182 case AF_CXXNewArray: os << "'new[]'"; return;
Anna Zaksd79b8402014-10-03 21:48:59 +00001183 case AF_IfNameIndex: os << "'if_nameindex()'"; return;
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001184 case AF_Alloca:
Anton Yartsev05789592013-03-28 17:05:19 +00001185 case AF_None: llvm_unreachable("not a deallocation expression");
1186 }
1187}
1188
1189void MallocChecker::printExpectedDeallocName(raw_ostream &os,
1190 AllocationFamily Family) const {
1191 switch(Family) {
1192 case AF_Malloc: os << "free()"; return;
1193 case AF_CXXNew: os << "'delete'"; return;
1194 case AF_CXXNewArray: os << "'delete[]'"; return;
Anna Zaksd79b8402014-10-03 21:48:59 +00001195 case AF_IfNameIndex: os << "'if_freenameindex()'"; return;
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001196 case AF_Alloca:
1197 case AF_None: llvm_unreachable("suspicious argument");
Anton Yartsev05789592013-03-28 17:05:19 +00001198 }
1199}
1200
Anna Zaks0d6989b2012-06-22 02:04:31 +00001201ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
1202 const Expr *ArgExpr,
1203 const Expr *ParentExpr,
Anna Zaks67291b92012-11-13 03:18:01 +00001204 ProgramStateRef State,
Anna Zaksfe6eb672012-08-24 02:28:20 +00001205 bool Hold,
Anna Zaks67291b92012-11-13 03:18:01 +00001206 bool &ReleasedAllocated,
1207 bool ReturnsNullOnFailure) const {
Anna Zaks0d6989b2012-06-22 02:04:31 +00001208
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001209 if (!State)
1210 return nullptr;
1211
Anna Zaks67291b92012-11-13 03:18:01 +00001212 SVal ArgVal = State->getSVal(ArgExpr, C.getLocationContext());
David Blaikie2fdacbc2013-02-20 05:52:05 +00001213 if (!ArgVal.getAs<DefinedOrUnknownSVal>())
Craig Topper0dbb7832014-05-27 02:45:47 +00001214 return nullptr;
David Blaikie2fdacbc2013-02-20 05:52:05 +00001215 DefinedOrUnknownSVal location = ArgVal.castAs<DefinedOrUnknownSVal>();
Ted Kremenekd21139a2010-07-31 01:52:11 +00001216
1217 // Check for null dereferences.
David Blaikie2fdacbc2013-02-20 05:52:05 +00001218 if (!location.getAs<Loc>())
Craig Topper0dbb7832014-05-27 02:45:47 +00001219 return nullptr;
Ted Kremenekd21139a2010-07-31 01:52:11 +00001220
Anna Zaksad01ef52012-02-14 00:26:13 +00001221 // The explicit NULL case, no operation is performed.
Ted Kremenek49b1e382012-01-26 21:29:00 +00001222 ProgramStateRef notNullState, nullState;
Benjamin Kramer867ea1d2014-03-02 13:01:17 +00001223 std::tie(notNullState, nullState) = State->assume(location);
Ted Kremenekd21139a2010-07-31 01:52:11 +00001224 if (nullState && !notNullState)
Craig Topper0dbb7832014-05-27 02:45:47 +00001225 return nullptr;
Ted Kremenekd21139a2010-07-31 01:52:11 +00001226
Jordy Rose3597b212010-06-07 19:32:37 +00001227 // Unknown values could easily be okay
1228 // Undefined values are handled elsewhere
1229 if (ArgVal.isUnknownOrUndef())
Craig Topper0dbb7832014-05-27 02:45:47 +00001230 return nullptr;
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001231
Jordy Rose3597b212010-06-07 19:32:37 +00001232 const MemRegion *R = ArgVal.getAsRegion();
1233
1234 // Nonlocs can't be freed, of course.
1235 // Non-region locations (labels and fixed addresses) also shouldn't be freed.
1236 if (!R) {
Anton Yartsev05789592013-03-28 17:05:19 +00001237 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr);
Craig Topper0dbb7832014-05-27 02:45:47 +00001238 return nullptr;
Jordy Rose3597b212010-06-07 19:32:37 +00001239 }
1240
1241 R = R->StripCasts();
1242
1243 // Blocks might show up as heap data, but should not be free()d
1244 if (isa<BlockDataRegion>(R)) {
Anton Yartsev05789592013-03-28 17:05:19 +00001245 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr);
Craig Topper0dbb7832014-05-27 02:45:47 +00001246 return nullptr;
Jordy Rose3597b212010-06-07 19:32:37 +00001247 }
1248
1249 const MemSpaceRegion *MS = R->getMemorySpace();
1250
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001251 // Parameters, locals, statics and globals shouldn't be freed.
Jordy Rose3597b212010-06-07 19:32:37 +00001252 if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) {
1253 // FIXME: at the time this code was written, malloc() regions were
1254 // represented by conjured symbols, which are all in UnknownSpaceRegion.
1255 // This means that there isn't actually anything from HeapSpaceRegion
1256 // that should be freed, even though we allow it here.
1257 // Of course, free() can work on memory allocated outside the current
1258 // function, so UnknownSpaceRegion is always a possibility.
1259 // False negatives are better than false positives.
1260
Anton Yartsev05789592013-03-28 17:05:19 +00001261 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr);
Craig Topper0dbb7832014-05-27 02:45:47 +00001262 return nullptr;
Jordy Rose3597b212010-06-07 19:32:37 +00001263 }
Anna Zaksc89ad072013-02-07 23:05:47 +00001264
1265 const SymbolicRegion *SrBase = dyn_cast<SymbolicRegion>(R->getBaseRegion());
Jordy Rose3597b212010-06-07 19:32:37 +00001266 // Various cases could lead to non-symbol values here.
1267 // For now, ignore them.
Anna Zaksc89ad072013-02-07 23:05:47 +00001268 if (!SrBase)
Craig Topper0dbb7832014-05-27 02:45:47 +00001269 return nullptr;
Jordy Rose3597b212010-06-07 19:32:37 +00001270
Anna Zaksc89ad072013-02-07 23:05:47 +00001271 SymbolRef SymBase = SrBase->getSymbol();
1272 const RefState *RsBase = State->get<RegionState>(SymBase);
Craig Topper0dbb7832014-05-27 02:45:47 +00001273 SymbolRef PreviousRetStatusSymbol = nullptr;
Zhongxing Xue2bdb9a2010-01-18 03:27:34 +00001274
Anton Yartseve3377fb2013-04-04 23:46:29 +00001275 if (RsBase) {
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001276
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001277 // Memory returned by alloca() shouldn't be freed.
1278 if (RsBase->getAllocationFamily() == AF_Alloca) {
1279 ReportFreeAlloca(C, ArgVal, ArgExpr->getSourceRange());
1280 return nullptr;
1281 }
1282
Anna Zaks93a21a82013-04-09 00:30:28 +00001283 // Check for double free first.
1284 if ((RsBase->isReleased() || RsBase->isRelinquished()) &&
Anton Yartseve3377fb2013-04-04 23:46:29 +00001285 !didPreviousFreeFail(State, SymBase, PreviousRetStatusSymbol)) {
1286 ReportDoubleFree(C, ParentExpr->getSourceRange(), RsBase->isReleased(),
1287 SymBase, PreviousRetStatusSymbol);
Craig Topper0dbb7832014-05-27 02:45:47 +00001288 return nullptr;
Anton Yartseve3377fb2013-04-04 23:46:29 +00001289
Anna Zaks93a21a82013-04-09 00:30:28 +00001290 // If the pointer is allocated or escaped, but we are now trying to free it,
1291 // check that the call to free is proper.
1292 } else if (RsBase->isAllocated() || RsBase->isEscaped()) {
1293
1294 // Check if an expected deallocation function matches the real one.
1295 bool DeallocMatchesAlloc =
1296 RsBase->getAllocationFamily() == getAllocationFamily(C, ParentExpr);
1297 if (!DeallocMatchesAlloc) {
1298 ReportMismatchedDealloc(C, ArgExpr->getSourceRange(),
Anton Yartsevf5bccce2013-09-16 17:51:25 +00001299 ParentExpr, RsBase, SymBase, Hold);
Craig Topper0dbb7832014-05-27 02:45:47 +00001300 return nullptr;
Anna Zaks93a21a82013-04-09 00:30:28 +00001301 }
1302
1303 // Check if the memory location being freed is the actual location
1304 // allocated, or an offset.
1305 RegionOffset Offset = R->getAsOffset();
1306 if (Offset.isValid() &&
1307 !Offset.hasSymbolicOffset() &&
1308 Offset.getOffset() != 0) {
1309 const Expr *AllocExpr = cast<Expr>(RsBase->getStmt());
1310 ReportOffsetFree(C, ArgVal, ArgExpr->getSourceRange(), ParentExpr,
1311 AllocExpr);
Craig Topper0dbb7832014-05-27 02:45:47 +00001312 return nullptr;
Anna Zaks93a21a82013-04-09 00:30:28 +00001313 }
Anton Yartseve3377fb2013-04-04 23:46:29 +00001314 }
Anna Zaksc89ad072013-02-07 23:05:47 +00001315 }
1316
Craig Topper0dbb7832014-05-27 02:45:47 +00001317 ReleasedAllocated = (RsBase != nullptr) && RsBase->isAllocated();
Anna Zaksfe6eb672012-08-24 02:28:20 +00001318
Anna Zaksa14c1d02012-11-13 19:47:40 +00001319 // Clean out the info on previous call to free return info.
Anna Zaksc89ad072013-02-07 23:05:47 +00001320 State = State->remove<FreeReturnValue>(SymBase);
Anna Zaksa14c1d02012-11-13 19:47:40 +00001321
Anna Zaks67291b92012-11-13 03:18:01 +00001322 // Keep track of the return value. If it is NULL, we will know that free
1323 // failed.
1324 if (ReturnsNullOnFailure) {
1325 SVal RetVal = C.getSVal(ParentExpr);
1326 SymbolRef RetStatusSymbol = RetVal.getAsSymbol();
1327 if (RetStatusSymbol) {
Anna Zaksc89ad072013-02-07 23:05:47 +00001328 C.getSymbolManager().addSymbolDependency(SymBase, RetStatusSymbol);
1329 State = State->set<FreeReturnValue>(SymBase, RetStatusSymbol);
Anna Zaks67291b92012-11-13 03:18:01 +00001330 }
1331 }
1332
Anton Yartsev030bcdd2013-04-05 19:08:04 +00001333 AllocationFamily Family = RsBase ? RsBase->getAllocationFamily()
1334 : getAllocationFamily(C, ParentExpr);
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001335 // Normal free.
Anton Yartsev05789592013-03-28 17:05:19 +00001336 if (Hold)
Anna Zaksc89ad072013-02-07 23:05:47 +00001337 return State->set<RegionState>(SymBase,
Anton Yartsev05789592013-03-28 17:05:19 +00001338 RefState::getRelinquished(Family,
1339 ParentExpr));
1340
1341 return State->set<RegionState>(SymBase,
1342 RefState::getReleased(Family, ParentExpr));
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00001343}
1344
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001345Optional<MallocChecker::CheckKind>
Anton Yartseve5c0c142015-02-18 00:39:06 +00001346MallocChecker::getCheckIfTracked(MallocChecker::CheckKind CK,
1347 AllocationFamily Family) const {
1348
1349 if (CK == CK_NumCheckKinds || !ChecksEnabled[CK])
1350 return Optional<MallocChecker::CheckKind>();
1351
1352 // C/C++ checkers.
1353 if (CK == CK_MismatchedDeallocatorChecker)
1354 return CK;
1355
Anton Yartsev717aa0e2013-04-05 00:31:02 +00001356 switch (Family) {
Anna Zaksd79b8402014-10-03 21:48:59 +00001357 case AF_Malloc:
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001358 case AF_IfNameIndex:
1359 case AF_Alloca: {
Anton Yartseve5c0c142015-02-18 00:39:06 +00001360 // C checkers.
1361 if (CK == CK_MallocOptimistic ||
1362 CK == CK_MallocPessimistic) {
1363 return CK;
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001364 }
1365 return Optional<MallocChecker::CheckKind>();
Anton Yartsev717aa0e2013-04-05 00:31:02 +00001366 }
1367 case AF_CXXNew:
1368 case AF_CXXNewArray: {
Anton Yartseve5c0c142015-02-18 00:39:06 +00001369 // C++ checkers.
1370 if (CK == CK_NewDeleteChecker ||
1371 CK == CK_NewDeleteLeaksChecker) {
1372 return CK;
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001373 }
1374 return Optional<MallocChecker::CheckKind>();
Anton Yartsev717aa0e2013-04-05 00:31:02 +00001375 }
1376 case AF_None: {
Anton Yartsev030bcdd2013-04-05 19:08:04 +00001377 llvm_unreachable("no family");
Anton Yartsev717aa0e2013-04-05 00:31:02 +00001378 }
Anton Yartsev717aa0e2013-04-05 00:31:02 +00001379 }
Anton Yartsev2f910042013-04-05 02:12:04 +00001380 llvm_unreachable("unhandled family");
Anton Yartseve3377fb2013-04-04 23:46:29 +00001381}
1382
Anton Yartseve5c0c142015-02-18 00:39:06 +00001383static MallocChecker::CKVecTy MakeVecFromCK(MallocChecker::CheckKind CK1,
1384 MallocChecker::CheckKind CK2 = MallocChecker::CK_NumCheckKinds,
1385 MallocChecker::CheckKind CK3 = MallocChecker::CK_NumCheckKinds,
1386 MallocChecker::CheckKind CK4 = MallocChecker::CK_NumCheckKinds) {
1387 MallocChecker::CKVecTy CKVec;
1388 CKVec.push_back(CK1);
1389 if (CK2 != MallocChecker::CK_NumCheckKinds) {
1390 CKVec.push_back(CK2);
1391 if (CK3 != MallocChecker::CK_NumCheckKinds) {
1392 CKVec.push_back(CK3);
1393 if (CK4 != MallocChecker::CK_NumCheckKinds)
1394 CKVec.push_back(CK4);
1395 }
1396 }
1397 return CKVec;
Anton Yartseve3377fb2013-04-04 23:46:29 +00001398}
1399
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001400Optional<MallocChecker::CheckKind>
Anton Yartseve5c0c142015-02-18 00:39:06 +00001401MallocChecker::getCheckIfTracked(CKVecTy CKVec, AllocationFamily Family) const {
1402 for (auto CK: CKVec) {
1403 auto RetCK = getCheckIfTracked(CK, Family);
1404 if (RetCK.hasValue())
1405 return RetCK;
1406 }
1407 return Optional<MallocChecker::CheckKind>();
1408}
Anton Yartseve3377fb2013-04-04 23:46:29 +00001409
Anton Yartseve5c0c142015-02-18 00:39:06 +00001410Optional<MallocChecker::CheckKind>
1411MallocChecker::getCheckIfTracked(CKVecTy CKVec, CheckerContext &C,
1412 const Stmt *AllocDeallocStmt) const {
1413 return getCheckIfTracked(CKVec, getAllocationFamily(C, AllocDeallocStmt));
1414}
1415
1416Optional<MallocChecker::CheckKind>
1417MallocChecker::getCheckIfTracked(CKVecTy CKVec, CheckerContext &C,
1418 SymbolRef Sym) const {
Anton Yartsev030bcdd2013-04-05 19:08:04 +00001419 const RefState *RS = C.getState()->get<RegionState>(Sym);
1420 assert(RS);
Anton Yartseve5c0c142015-02-18 00:39:06 +00001421 return getCheckIfTracked(CKVec, RS->getAllocationFamily());
Anton Yartseve3377fb2013-04-04 23:46:29 +00001422}
1423
Ted Kremenek5ef32db2011-08-12 23:37:29 +00001424bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {
David Blaikie05785d12013-02-20 22:23:23 +00001425 if (Optional<nonloc::ConcreteInt> IntVal = V.getAs<nonloc::ConcreteInt>())
Jordy Rose3597b212010-06-07 19:32:37 +00001426 os << "an integer (" << IntVal->getValue() << ")";
David Blaikie05785d12013-02-20 22:23:23 +00001427 else if (Optional<loc::ConcreteInt> ConstAddr = V.getAs<loc::ConcreteInt>())
Jordy Rose3597b212010-06-07 19:32:37 +00001428 os << "a constant address (" << ConstAddr->getValue() << ")";
David Blaikie05785d12013-02-20 22:23:23 +00001429 else if (Optional<loc::GotoLabel> Label = V.getAs<loc::GotoLabel>())
Chris Lattner5a9b1ec2011-02-17 05:38:27 +00001430 os << "the address of the label '" << Label->getLabel()->getName() << "'";
Jordy Rose3597b212010-06-07 19:32:37 +00001431 else
1432 return false;
1433
1434 return true;
1435}
1436
Ted Kremenek5ef32db2011-08-12 23:37:29 +00001437bool MallocChecker::SummarizeRegion(raw_ostream &os,
Jordy Rose3597b212010-06-07 19:32:37 +00001438 const MemRegion *MR) {
1439 switch (MR->getKind()) {
1440 case MemRegion::FunctionTextRegionKind: {
Anna Zaks42782342012-09-17 19:13:56 +00001441 const NamedDecl *FD = cast<FunctionTextRegion>(MR)->getDecl();
Jordy Rose3597b212010-06-07 19:32:37 +00001442 if (FD)
Benjamin Kramerb89514a2011-10-14 18:45:37 +00001443 os << "the address of the function '" << *FD << '\'';
Jordy Rose3597b212010-06-07 19:32:37 +00001444 else
1445 os << "the address of a function";
1446 return true;
1447 }
1448 case MemRegion::BlockTextRegionKind:
1449 os << "block text";
1450 return true;
1451 case MemRegion::BlockDataRegionKind:
1452 // FIXME: where the block came from?
1453 os << "a block";
1454 return true;
1455 default: {
1456 const MemSpaceRegion *MS = MR->getMemorySpace();
1457
Anna Zaks8158ef02012-01-04 23:54:01 +00001458 if (isa<StackLocalsSpaceRegion>(MS)) {
Jordy Rose3597b212010-06-07 19:32:37 +00001459 const VarRegion *VR = dyn_cast<VarRegion>(MR);
1460 const VarDecl *VD;
1461 if (VR)
1462 VD = VR->getDecl();
1463 else
Craig Topper0dbb7832014-05-27 02:45:47 +00001464 VD = nullptr;
1465
Jordy Rose3597b212010-06-07 19:32:37 +00001466 if (VD)
1467 os << "the address of the local variable '" << VD->getName() << "'";
1468 else
1469 os << "the address of a local stack variable";
1470 return true;
1471 }
Anna Zaks8158ef02012-01-04 23:54:01 +00001472
1473 if (isa<StackArgumentsSpaceRegion>(MS)) {
Jordy Rose3597b212010-06-07 19:32:37 +00001474 const VarRegion *VR = dyn_cast<VarRegion>(MR);
1475 const VarDecl *VD;
1476 if (VR)
1477 VD = VR->getDecl();
1478 else
Craig Topper0dbb7832014-05-27 02:45:47 +00001479 VD = nullptr;
1480
Jordy Rose3597b212010-06-07 19:32:37 +00001481 if (VD)
1482 os << "the address of the parameter '" << VD->getName() << "'";
1483 else
1484 os << "the address of a parameter";
1485 return true;
1486 }
Anna Zaks8158ef02012-01-04 23:54:01 +00001487
1488 if (isa<GlobalsSpaceRegion>(MS)) {
Jordy Rose3597b212010-06-07 19:32:37 +00001489 const VarRegion *VR = dyn_cast<VarRegion>(MR);
1490 const VarDecl *VD;
1491 if (VR)
1492 VD = VR->getDecl();
1493 else
Craig Topper0dbb7832014-05-27 02:45:47 +00001494 VD = nullptr;
1495
Jordy Rose3597b212010-06-07 19:32:37 +00001496 if (VD) {
1497 if (VD->isStaticLocal())
1498 os << "the address of the static variable '" << VD->getName() << "'";
1499 else
1500 os << "the address of the global variable '" << VD->getName() << "'";
1501 } else
1502 os << "the address of a global variable";
1503 return true;
1504 }
Anna Zaks8158ef02012-01-04 23:54:01 +00001505
1506 return false;
Jordy Rose3597b212010-06-07 19:32:37 +00001507 }
1508 }
1509}
1510
Anton Yartsev05789592013-03-28 17:05:19 +00001511void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal,
1512 SourceRange Range,
1513 const Expr *DeallocExpr) const {
1514
Anton Yartseve5c0c142015-02-18 00:39:06 +00001515 auto CheckKind = getCheckIfTracked(MakeVecFromCK(CK_MallocOptimistic,
1516 CK_MallocPessimistic,
1517 CK_NewDeleteChecker),
1518 C, DeallocExpr);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001519 if (!CheckKind.hasValue())
Anton Yartseve3377fb2013-04-04 23:46:29 +00001520 return;
1521
Ted Kremenek750b7ac2010-12-20 21:19:09 +00001522 if (ExplodedNode *N = C.generateSink()) {
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001523 if (!BT_BadFree[*CheckKind])
1524 BT_BadFree[*CheckKind].reset(
1525 new BugType(CheckNames[*CheckKind], "Bad free", "Memory Error"));
1526
Dylan Noblesmith2c1dd272012-02-05 02:13:05 +00001527 SmallString<100> buf;
Jordy Rose3597b212010-06-07 19:32:37 +00001528 llvm::raw_svector_ostream os(buf);
Anton Yartsev05789592013-03-28 17:05:19 +00001529
Jordy Rose3597b212010-06-07 19:32:37 +00001530 const MemRegion *MR = ArgVal.getAsRegion();
Anton Yartsev05789592013-03-28 17:05:19 +00001531 while (const ElementRegion *ER = dyn_cast_or_null<ElementRegion>(MR))
1532 MR = ER->getSuperRegion();
1533
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001534 os << "Argument to ";
1535 if (!printAllocDeallocName(os, C, DeallocExpr))
1536 os << "deallocator";
Anton Yartsev05789592013-03-28 17:05:19 +00001537
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001538 os << " is ";
1539 bool Summarized = MR ? SummarizeRegion(os, MR)
1540 : SummarizeValue(os, ArgVal);
1541 if (Summarized)
1542 os << ", which is not memory allocated by ";
1543 else
1544 os << "not memory allocated by ";
Anton Yartsev05789592013-03-28 17:05:19 +00001545
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001546 printExpectedAllocName(os, C, DeallocExpr);
Anton Yartsev05789592013-03-28 17:05:19 +00001547
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001548 BugReport *R = new BugReport(*BT_BadFree[*CheckKind], os.str(), N);
Ted Kremenek1e809b42012-03-09 01:13:14 +00001549 R->markInteresting(MR);
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001550 R->addRange(Range);
Jordan Rosee10d5a72012-11-02 01:53:40 +00001551 C.emitReport(R);
Jordy Rose3597b212010-06-07 19:32:37 +00001552 }
1553}
1554
Anton Yartsev5b5c7ce2015-02-19 13:36:20 +00001555void MallocChecker::ReportFreeAlloca(CheckerContext &C, SVal ArgVal,
1556 SourceRange Range) const {
1557
1558 auto CheckKind = getCheckIfTracked(MakeVecFromCK(CK_MallocOptimistic,
1559 CK_MallocPessimistic,
1560 CK_MismatchedDeallocatorChecker),
1561 AF_Alloca);
1562 if (!CheckKind.hasValue())
1563 return;
1564
1565 if (ExplodedNode *N = C.generateSink()) {
1566 if (!BT_FreeAlloca[*CheckKind])
1567 BT_FreeAlloca[*CheckKind].reset(
1568 new BugType(CheckNames[*CheckKind], "Free alloca()", "Memory Error"));
1569
1570 BugReport *R = new BugReport(*BT_FreeAlloca[*CheckKind],
1571 "Memory allocated by alloca() should not be deallocated", N);
1572 R->markInteresting(ArgVal.getAsRegion());
1573 R->addRange(Range);
1574 C.emitReport(R);
1575 }
1576}
1577
Anton Yartseve3377fb2013-04-04 23:46:29 +00001578void MallocChecker::ReportMismatchedDealloc(CheckerContext &C,
1579 SourceRange Range,
1580 const Expr *DeallocExpr,
Anton Yartsevf0593d62013-04-05 11:25:10 +00001581 const RefState *RS,
Anton Yartsevf5bccce2013-09-16 17:51:25 +00001582 SymbolRef Sym,
1583 bool OwnershipTransferred) const {
Anton Yartsev05789592013-03-28 17:05:19 +00001584
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001585 if (!ChecksEnabled[CK_MismatchedDeallocatorChecker])
Anton Yartsev05789592013-03-28 17:05:19 +00001586 return;
1587
1588 if (ExplodedNode *N = C.generateSink()) {
Anton Yartseve3377fb2013-04-04 23:46:29 +00001589 if (!BT_MismatchedDealloc)
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001590 BT_MismatchedDealloc.reset(
1591 new BugType(CheckNames[CK_MismatchedDeallocatorChecker],
1592 "Bad deallocator", "Memory Error"));
1593
Anton Yartsev05789592013-03-28 17:05:19 +00001594 SmallString<100> buf;
1595 llvm::raw_svector_ostream os(buf);
1596
1597 const Expr *AllocExpr = cast<Expr>(RS->getStmt());
1598 SmallString<20> AllocBuf;
1599 llvm::raw_svector_ostream AllocOs(AllocBuf);
1600 SmallString<20> DeallocBuf;
1601 llvm::raw_svector_ostream DeallocOs(DeallocBuf);
1602
Anton Yartsevf5bccce2013-09-16 17:51:25 +00001603 if (OwnershipTransferred) {
1604 if (printAllocDeallocName(DeallocOs, C, DeallocExpr))
1605 os << DeallocOs.str() << " cannot";
1606 else
1607 os << "Cannot";
Anton Yartsev05789592013-03-28 17:05:19 +00001608
Anton Yartsevf5bccce2013-09-16 17:51:25 +00001609 os << " take ownership of memory";
Anton Yartsev05789592013-03-28 17:05:19 +00001610
Anton Yartsevf5bccce2013-09-16 17:51:25 +00001611 if (printAllocDeallocName(AllocOs, C, AllocExpr))
1612 os << " allocated by " << AllocOs.str();
1613 } else {
1614 os << "Memory";
1615 if (printAllocDeallocName(AllocOs, C, AllocExpr))
1616 os << " allocated by " << AllocOs.str();
1617
1618 os << " should be deallocated by ";
1619 printExpectedDeallocName(os, RS->getAllocationFamily());
1620
1621 if (printAllocDeallocName(DeallocOs, C, DeallocExpr))
1622 os << ", not " << DeallocOs.str();
1623 }
Anton Yartsev05789592013-03-28 17:05:19 +00001624
Anton Yartseve3377fb2013-04-04 23:46:29 +00001625 BugReport *R = new BugReport(*BT_MismatchedDealloc, os.str(), N);
Anton Yartsevf0593d62013-04-05 11:25:10 +00001626 R->markInteresting(Sym);
Anton Yartsev05789592013-03-28 17:05:19 +00001627 R->addRange(Range);
David Blaikie91e79022014-09-04 23:54:33 +00001628 R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym));
Anton Yartsev05789592013-03-28 17:05:19 +00001629 C.emitReport(R);
1630 }
1631}
1632
Anna Zaksc89ad072013-02-07 23:05:47 +00001633void MallocChecker::ReportOffsetFree(CheckerContext &C, SVal ArgVal,
Anton Yartsev05789592013-03-28 17:05:19 +00001634 SourceRange Range, const Expr *DeallocExpr,
1635 const Expr *AllocExpr) const {
1636
Anton Yartsev05789592013-03-28 17:05:19 +00001637
Anton Yartseve5c0c142015-02-18 00:39:06 +00001638 auto CheckKind = getCheckIfTracked(MakeVecFromCK(CK_MallocOptimistic,
1639 CK_MallocPessimistic,
1640 CK_NewDeleteChecker),
1641 C, AllocExpr);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001642 if (!CheckKind.hasValue())
Anton Yartseve3377fb2013-04-04 23:46:29 +00001643 return;
1644
Anna Zaksc89ad072013-02-07 23:05:47 +00001645 ExplodedNode *N = C.generateSink();
Craig Topper0dbb7832014-05-27 02:45:47 +00001646 if (!N)
Anna Zaksc89ad072013-02-07 23:05:47 +00001647 return;
1648
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001649 if (!BT_OffsetFree[*CheckKind])
1650 BT_OffsetFree[*CheckKind].reset(
1651 new BugType(CheckNames[*CheckKind], "Offset free", "Memory Error"));
Anna Zaksc89ad072013-02-07 23:05:47 +00001652
1653 SmallString<100> buf;
1654 llvm::raw_svector_ostream os(buf);
Anton Yartsev05789592013-03-28 17:05:19 +00001655 SmallString<20> AllocNameBuf;
1656 llvm::raw_svector_ostream AllocNameOs(AllocNameBuf);
Anna Zaksc89ad072013-02-07 23:05:47 +00001657
1658 const MemRegion *MR = ArgVal.getAsRegion();
1659 assert(MR && "Only MemRegion based symbols can have offset free errors");
1660
1661 RegionOffset Offset = MR->getAsOffset();
1662 assert((Offset.isValid() &&
1663 !Offset.hasSymbolicOffset() &&
1664 Offset.getOffset() != 0) &&
1665 "Only symbols with a valid offset can have offset free errors");
1666
1667 int offsetBytes = Offset.getOffset() / C.getASTContext().getCharWidth();
1668
Anton Yartsev05789592013-03-28 17:05:19 +00001669 os << "Argument to ";
1670 if (!printAllocDeallocName(os, C, DeallocExpr))
1671 os << "deallocator";
1672 os << " is offset by "
Anna Zaksc89ad072013-02-07 23:05:47 +00001673 << offsetBytes
1674 << " "
1675 << ((abs(offsetBytes) > 1) ? "bytes" : "byte")
Anton Yartsev05789592013-03-28 17:05:19 +00001676 << " from the start of ";
1677 if (AllocExpr && printAllocDeallocName(AllocNameOs, C, AllocExpr))
1678 os << "memory allocated by " << AllocNameOs.str();
1679 else
1680 os << "allocated memory";
Anna Zaksc89ad072013-02-07 23:05:47 +00001681
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001682 BugReport *R = new BugReport(*BT_OffsetFree[*CheckKind], os.str(), N);
Anna Zaksc89ad072013-02-07 23:05:47 +00001683 R->markInteresting(MR->getBaseRegion());
1684 R->addRange(Range);
1685 C.emitReport(R);
1686}
1687
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001688void MallocChecker::ReportUseAfterFree(CheckerContext &C, SourceRange Range,
1689 SymbolRef Sym) const {
1690
Anton Yartseve5c0c142015-02-18 00:39:06 +00001691 auto CheckKind = getCheckIfTracked(MakeVecFromCK(CK_MallocOptimistic,
1692 CK_MallocPessimistic,
1693 CK_NewDeleteChecker),
1694 C, Sym);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001695 if (!CheckKind.hasValue())
Anton Yartseve3377fb2013-04-04 23:46:29 +00001696 return;
1697
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001698 if (ExplodedNode *N = C.generateSink()) {
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001699 if (!BT_UseFree[*CheckKind])
1700 BT_UseFree[*CheckKind].reset(new BugType(
1701 CheckNames[*CheckKind], "Use-after-free", "Memory Error"));
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001702
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001703 BugReport *R = new BugReport(*BT_UseFree[*CheckKind],
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001704 "Use of memory after it is freed", N);
1705
1706 R->markInteresting(Sym);
1707 R->addRange(Range);
David Blaikie91e79022014-09-04 23:54:33 +00001708 R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym));
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001709 C.emitReport(R);
1710 }
1711}
1712
1713void MallocChecker::ReportDoubleFree(CheckerContext &C, SourceRange Range,
1714 bool Released, SymbolRef Sym,
Anton Yartsev6c2af432013-03-13 17:07:32 +00001715 SymbolRef PrevSym) const {
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001716
Anton Yartseve5c0c142015-02-18 00:39:06 +00001717 auto CheckKind = getCheckIfTracked(MakeVecFromCK(CK_MallocOptimistic,
1718 CK_MallocPessimistic,
1719 CK_NewDeleteChecker),
1720 C, Sym);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001721 if (!CheckKind.hasValue())
Anton Yartseve3377fb2013-04-04 23:46:29 +00001722 return;
1723
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001724 if (ExplodedNode *N = C.generateSink()) {
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001725 if (!BT_DoubleFree[*CheckKind])
1726 BT_DoubleFree[*CheckKind].reset(
1727 new BugType(CheckNames[*CheckKind], "Double free", "Memory Error"));
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001728
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001729 BugReport *R =
1730 new BugReport(*BT_DoubleFree[*CheckKind],
1731 (Released ? "Attempt to free released memory"
1732 : "Attempt to free non-owned memory"),
1733 N);
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001734 R->addRange(Range);
Anton Yartsev6c2af432013-03-13 17:07:32 +00001735 R->markInteresting(Sym);
1736 if (PrevSym)
1737 R->markInteresting(PrevSym);
David Blaikie91e79022014-09-04 23:54:33 +00001738 R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym));
Anton Yartsev59ed15b2013-03-13 14:39:10 +00001739 C.emitReport(R);
1740 }
1741}
1742
Jordan Rose656fdd52014-01-08 18:46:55 +00001743void MallocChecker::ReportDoubleDelete(CheckerContext &C, SymbolRef Sym) const {
1744
Anton Yartseve5c0c142015-02-18 00:39:06 +00001745 auto CheckKind = getCheckIfTracked(MakeVecFromCK(CK_NewDeleteChecker),
1746 C, Sym);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001747 if (!CheckKind.hasValue())
Jordan Rose656fdd52014-01-08 18:46:55 +00001748 return;
1749
1750 if (ExplodedNode *N = C.generateSink()) {
1751 if (!BT_DoubleDelete)
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001752 BT_DoubleDelete.reset(new BugType(CheckNames[CK_NewDeleteChecker],
1753 "Double delete", "Memory Error"));
Jordan Rose656fdd52014-01-08 18:46:55 +00001754
1755 BugReport *R = new BugReport(*BT_DoubleDelete,
1756 "Attempt to delete released memory", N);
1757
1758 R->markInteresting(Sym);
David Blaikie91e79022014-09-04 23:54:33 +00001759 R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym));
Jordan Rose656fdd52014-01-08 18:46:55 +00001760 C.emitReport(R);
1761 }
1762}
1763
Anna Zaks40a7eb32012-02-22 19:24:52 +00001764ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C,
1765 const CallExpr *CE,
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001766 bool FreesOnFail,
1767 ProgramStateRef State) const {
1768 if (!State)
1769 return nullptr;
1770
Anna Zaksb508d292012-04-10 23:41:11 +00001771 if (CE->getNumArgs() < 2)
Craig Topper0dbb7832014-05-27 02:45:47 +00001772 return nullptr;
Anna Zaksb508d292012-04-10 23:41:11 +00001773
Ted Kremenek90af9092010-12-02 07:49:45 +00001774 const Expr *arg0Expr = CE->getArg(0);
Ted Kremenek632e3b72012-01-06 22:09:28 +00001775 const LocationContext *LCtx = C.getLocationContext();
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001776 SVal Arg0Val = State->getSVal(arg0Expr, LCtx);
David Blaikie2fdacbc2013-02-20 05:52:05 +00001777 if (!Arg0Val.getAs<DefinedOrUnknownSVal>())
Craig Topper0dbb7832014-05-27 02:45:47 +00001778 return nullptr;
David Blaikie2fdacbc2013-02-20 05:52:05 +00001779 DefinedOrUnknownSVal arg0Val = Arg0Val.castAs<DefinedOrUnknownSVal>();
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00001780
Ted Kremenek9d0bb1e2010-12-01 21:28:31 +00001781 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00001782
Ted Kremenek90af9092010-12-02 07:49:45 +00001783 DefinedOrUnknownSVal PtrEQ =
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001784 svalBuilder.evalEQ(State, arg0Val, svalBuilder.makeNull());
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00001785
Lenny Maiorani005b5c12011-04-27 14:49:29 +00001786 // Get the size argument. If there is no size arg then give up.
1787 const Expr *Arg1 = CE->getArg(1);
1788 if (!Arg1)
Craig Topper0dbb7832014-05-27 02:45:47 +00001789 return nullptr;
Lenny Maiorani005b5c12011-04-27 14:49:29 +00001790
1791 // Get the value of the size argument.
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001792 SVal Arg1ValG = State->getSVal(Arg1, LCtx);
David Blaikie2fdacbc2013-02-20 05:52:05 +00001793 if (!Arg1ValG.getAs<DefinedOrUnknownSVal>())
Craig Topper0dbb7832014-05-27 02:45:47 +00001794 return nullptr;
David Blaikie2fdacbc2013-02-20 05:52:05 +00001795 DefinedOrUnknownSVal Arg1Val = Arg1ValG.castAs<DefinedOrUnknownSVal>();
Lenny Maiorani005b5c12011-04-27 14:49:29 +00001796
1797 // Compare the size argument to 0.
1798 DefinedOrUnknownSVal SizeZero =
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001799 svalBuilder.evalEQ(State, Arg1Val,
Lenny Maiorani005b5c12011-04-27 14:49:29 +00001800 svalBuilder.makeIntValWithPtrWidth(0, false));
1801
Anna Zaksd56c8792012-02-13 18:05:39 +00001802 ProgramStateRef StatePtrIsNull, StatePtrNotNull;
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001803 std::tie(StatePtrIsNull, StatePtrNotNull) = State->assume(PtrEQ);
Anna Zaksd56c8792012-02-13 18:05:39 +00001804 ProgramStateRef StateSizeIsZero, StateSizeNotZero;
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001805 std::tie(StateSizeIsZero, StateSizeNotZero) = State->assume(SizeZero);
Anna Zaksd56c8792012-02-13 18:05:39 +00001806 // We only assume exceptional states if they are definitely true; if the
1807 // state is under-constrained, assume regular realloc behavior.
1808 bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull;
1809 bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero;
1810
Lenny Maiorani005b5c12011-04-27 14:49:29 +00001811 // If the ptr is NULL and the size is not 0, the call is equivalent to
1812 // malloc(size).
Anna Zaksd56c8792012-02-13 18:05:39 +00001813 if ( PrtIsNull && !SizeIsZero) {
Anna Zaks40a7eb32012-02-22 19:24:52 +00001814 ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1),
Anna Zaksd56c8792012-02-13 18:05:39 +00001815 UndefinedVal(), StatePtrIsNull);
Anna Zaks40a7eb32012-02-22 19:24:52 +00001816 return stateMalloc;
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00001817 }
1818
Anna Zaksd56c8792012-02-13 18:05:39 +00001819 if (PrtIsNull && SizeIsZero)
Craig Topper0dbb7832014-05-27 02:45:47 +00001820 return nullptr;
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00001821
Anna Zaks8fd0f2a2012-02-13 20:57:07 +00001822 // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size).
Anna Zaksd56c8792012-02-13 18:05:39 +00001823 assert(!PrtIsNull);
Anna Zaks8fd0f2a2012-02-13 20:57:07 +00001824 SymbolRef FromPtr = arg0Val.getAsSymbol();
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001825 SVal RetVal = State->getSVal(CE, LCtx);
Anna Zaks8fd0f2a2012-02-13 20:57:07 +00001826 SymbolRef ToPtr = RetVal.getAsSymbol();
1827 if (!FromPtr || !ToPtr)
Craig Topper0dbb7832014-05-27 02:45:47 +00001828 return nullptr;
Anna Zaksd56c8792012-02-13 18:05:39 +00001829
Anna Zaksfe6eb672012-08-24 02:28:20 +00001830 bool ReleasedAllocated = false;
1831
Anna Zaksd56c8792012-02-13 18:05:39 +00001832 // If the size is 0, free the memory.
1833 if (SizeIsZero)
Anna Zaksfe6eb672012-08-24 02:28:20 +00001834 if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero, 0,
1835 false, ReleasedAllocated)){
Anna Zaksd56c8792012-02-13 18:05:39 +00001836 // The semantics of the return value are:
1837 // If size was equal to 0, either NULL or a pointer suitable to be passed
Anna Zaks52242a62012-08-03 18:30:18 +00001838 // to free() is returned. We just free the input pointer and do not add
1839 // any constrains on the output pointer.
Anna Zaks40a7eb32012-02-22 19:24:52 +00001840 return stateFree;
Anna Zaksd56c8792012-02-13 18:05:39 +00001841 }
1842
1843 // Default behavior.
Anna Zaksfe6eb672012-08-24 02:28:20 +00001844 if (ProgramStateRef stateFree =
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001845 FreeMemAux(C, CE, State, 0, false, ReleasedAllocated)) {
Anna Zaksfe6eb672012-08-24 02:28:20 +00001846
Anna Zaksd56c8792012-02-13 18:05:39 +00001847 ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1),
1848 UnknownVal(), stateFree);
Anna Zaks8fd0f2a2012-02-13 20:57:07 +00001849 if (!stateRealloc)
Craig Topper0dbb7832014-05-27 02:45:47 +00001850 return nullptr;
Anna Zaksfe6eb672012-08-24 02:28:20 +00001851
Anna Zaks75cfbb62012-09-12 22:57:34 +00001852 ReallocPairKind Kind = RPToBeFreedAfterFailure;
1853 if (FreesOnFail)
1854 Kind = RPIsFreeOnFailure;
1855 else if (!ReleasedAllocated)
1856 Kind = RPDoNotTrackAfterFailure;
1857
Anna Zaksfe6eb672012-08-24 02:28:20 +00001858 // Record the info about the reallocated symbol so that we could properly
1859 // process failed reallocation.
Anna Zaksac068142012-02-15 00:11:25 +00001860 stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr,
Anna Zaks75cfbb62012-09-12 22:57:34 +00001861 ReallocPair(FromPtr, Kind));
Anna Zaksfe6eb672012-08-24 02:28:20 +00001862 // The reallocated symbol should stay alive for as long as the new symbol.
Anna Zaksad01ef52012-02-14 00:26:13 +00001863 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks40a7eb32012-02-22 19:24:52 +00001864 return stateRealloc;
Zhongxing Xuc0484fa2009-12-12 12:29:38 +00001865 }
Craig Topper0dbb7832014-05-27 02:45:47 +00001866 return nullptr;
Zhongxing Xu88cca6b2009-11-12 08:38:56 +00001867}
Zhongxing Xuc4902a52009-11-13 07:25:27 +00001868
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001869ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE,
1870 ProgramStateRef State) {
1871 if (!State)
1872 return nullptr;
1873
Anna Zaksb508d292012-04-10 23:41:11 +00001874 if (CE->getNumArgs() < 2)
Craig Topper0dbb7832014-05-27 02:45:47 +00001875 return nullptr;
Anna Zaksb508d292012-04-10 23:41:11 +00001876
Ted Kremenek9d0bb1e2010-12-01 21:28:31 +00001877 SValBuilder &svalBuilder = C.getSValBuilder();
Ted Kremenek632e3b72012-01-06 22:09:28 +00001878 const LocationContext *LCtx = C.getLocationContext();
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001879 SVal count = State->getSVal(CE->getArg(0), LCtx);
1880 SVal elementSize = State->getSVal(CE->getArg(1), LCtx);
1881 SVal TotalSize = svalBuilder.evalBinOp(State, BO_Mul, count, elementSize,
Ted Kremenek90af9092010-12-02 07:49:45 +00001882 svalBuilder.getContext().getSizeType());
1883 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
Zhongxing Xu527ff6d2010-06-01 03:01:33 +00001884
Anton Yartsevb3fa86d2015-02-10 20:13:08 +00001885 return MallocMemAux(C, CE, TotalSize, zeroVal, State);
Zhongxing Xu527ff6d2010-06-01 03:01:33 +00001886}
1887
Anna Zaksfc2e1532012-03-21 19:45:08 +00001888LeakInfo
Anna Zaksdf901a42012-02-23 21:38:21 +00001889MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
1890 CheckerContext &C) const {
Anna Zaks43ffba22012-02-27 23:40:55 +00001891 const LocationContext *LeakContext = N->getLocationContext();
Anna Zaksdf901a42012-02-23 21:38:21 +00001892 // Walk the ExplodedGraph backwards and find the first node that referred to
1893 // the tracked symbol.
1894 const ExplodedNode *AllocNode = N;
Craig Topper0dbb7832014-05-27 02:45:47 +00001895 const MemRegion *ReferenceRegion = nullptr;
Anna Zaksdf901a42012-02-23 21:38:21 +00001896
1897 while (N) {
Anna Zaksfc2e1532012-03-21 19:45:08 +00001898 ProgramStateRef State = N->getState();
1899 if (!State->get<RegionState>(Sym))
Anna Zaksdf901a42012-02-23 21:38:21 +00001900 break;
Anna Zaksfc2e1532012-03-21 19:45:08 +00001901
1902 // Find the most recent expression bound to the symbol in the current
1903 // context.
Anna Zaks7c19abe2013-04-10 21:42:02 +00001904 if (!ReferenceRegion) {
1905 if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) {
1906 SVal Val = State->getSVal(MR);
1907 if (Val.getAsLocSymbol() == Sym) {
Anna Zaks07804ef2013-04-10 22:56:33 +00001908 const VarRegion* VR = MR->getBaseRegion()->getAs<VarRegion>();
Anna Zaks7c19abe2013-04-10 21:42:02 +00001909 // Do not show local variables belonging to a function other than
1910 // where the error is reported.
1911 if (!VR ||
1912 (VR->getStackFrame() == LeakContext->getCurrentStackFrame()))
1913 ReferenceRegion = MR;
1914 }
1915 }
Benjamin Kramerc25c5e02012-03-21 21:03:48 +00001916 }
Anna Zaksfc2e1532012-03-21 19:45:08 +00001917
Anna Zaks486a0ff2015-02-05 01:02:53 +00001918 // Allocation node, is the last node in the current or parent context in
1919 // which the symbol was tracked.
1920 const LocationContext *NContext = N->getLocationContext();
1921 if (NContext == LeakContext ||
1922 NContext->isParentOf(LeakContext))
Anna Zaks43ffba22012-02-27 23:40:55 +00001923 AllocNode = N;
Craig Topper0dbb7832014-05-27 02:45:47 +00001924 N = N->pred_empty() ? nullptr : *(N->pred_begin());
Anna Zaksdf901a42012-02-23 21:38:21 +00001925 }
1926
Anna Zaksa043d0c2013-01-08 00:25:29 +00001927 return LeakInfo(AllocNode, ReferenceRegion);
Anna Zaksdf901a42012-02-23 21:38:21 +00001928}
1929
Anna Zaksd3571e5a2012-02-11 21:02:40 +00001930void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N,
1931 CheckerContext &C) const {
Anton Yartsev05789592013-03-28 17:05:19 +00001932
Anton Yartseve5c0c142015-02-18 00:39:06 +00001933 auto CheckKind = getCheckIfTracked(MakeVecFromCK(CK_MallocOptimistic,
1934 CK_MallocPessimistic,
1935 CK_NewDeleteLeaksChecker),
1936 C, Sym);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001937 if (!CheckKind.hasValue())
Anton Yartsev6e499252013-04-05 02:25:02 +00001938 return;
1939
Anna Zaksd3571e5a2012-02-11 21:02:40 +00001940 assert(N);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001941 if (!BT_Leak[*CheckKind]) {
1942 BT_Leak[*CheckKind].reset(
1943 new BugType(CheckNames[*CheckKind], "Memory leak", "Memory Error"));
Anna Zaksd3571e5a2012-02-11 21:02:40 +00001944 // Leaks should not be reported if they are post-dominated by a sink:
1945 // (1) Sinks are higher importance bugs.
1946 // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending
1947 // with __noreturn functions such as assert() or exit(). We choose not
1948 // to report leaks on such paths.
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001949 BT_Leak[*CheckKind]->setSuppressOnSink(true);
Anna Zaksd3571e5a2012-02-11 21:02:40 +00001950 }
1951
Anna Zaksdf901a42012-02-23 21:38:21 +00001952 // Most bug reports are cached at the location where they occurred.
1953 // With leaks, we want to unique them by the location where they were
1954 // allocated, and only report a single path.
Anna Zaks43ffba22012-02-27 23:40:55 +00001955 PathDiagnosticLocation LocUsedForUniqueing;
Craig Topper0dbb7832014-05-27 02:45:47 +00001956 const ExplodedNode *AllocNode = nullptr;
1957 const MemRegion *Region = nullptr;
Benjamin Kramer867ea1d2014-03-02 13:01:17 +00001958 std::tie(AllocNode, Region) = getAllocationSite(N, Sym, C);
Anna Zaksa043d0c2013-01-08 00:25:29 +00001959
1960 ProgramPoint P = AllocNode->getLocation();
Craig Topper0dbb7832014-05-27 02:45:47 +00001961 const Stmt *AllocationStmt = nullptr;
David Blaikie87396b92013-02-21 22:23:56 +00001962 if (Optional<CallExitEnd> Exit = P.getAs<CallExitEnd>())
Anna Zaksa043d0c2013-01-08 00:25:29 +00001963 AllocationStmt = Exit->getCalleeContext()->getCallSite();
David Blaikie87396b92013-02-21 22:23:56 +00001964 else if (Optional<StmtPoint> SP = P.getAs<StmtPoint>())
Anna Zaksa043d0c2013-01-08 00:25:29 +00001965 AllocationStmt = SP->getStmt();
Anton Yartsev6e499252013-04-05 02:25:02 +00001966 if (AllocationStmt)
Anna Zaksa043d0c2013-01-08 00:25:29 +00001967 LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocationStmt,
1968 C.getSourceManager(),
1969 AllocNode->getLocationContext());
Anna Zaksdf901a42012-02-23 21:38:21 +00001970
Anna Zaksfc2e1532012-03-21 19:45:08 +00001971 SmallString<200> buf;
1972 llvm::raw_svector_ostream os(buf);
Jordan Rosed86b3bd2012-08-08 18:23:36 +00001973 if (Region && Region->canPrintPretty()) {
Anna Zaks6cea7d92013-04-12 18:40:21 +00001974 os << "Potential leak of memory pointed to by ";
Jordan Rosed86b3bd2012-08-08 18:23:36 +00001975 Region->printPretty(os);
Anna Zaksa1de8562013-04-06 00:41:36 +00001976 } else {
1977 os << "Potential memory leak";
Anna Zaksfc2e1532012-03-21 19:45:08 +00001978 }
1979
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00001980 BugReport *R =
1981 new BugReport(*BT_Leak[*CheckKind], os.str(), N, LocUsedForUniqueing,
1982 AllocNode->getLocationContext()->getDecl());
Ted Kremenek1e809b42012-03-09 01:13:14 +00001983 R->markInteresting(Sym);
David Blaikie91e79022014-09-04 23:54:33 +00001984 R->addVisitor(llvm::make_unique<MallocBugVisitor>(Sym, true));
Jordan Rosee10d5a72012-11-02 01:53:40 +00001985 C.emitReport(R);
Anna Zaksd3571e5a2012-02-11 21:02:40 +00001986}
1987
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +00001988void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper,
1989 CheckerContext &C) const
Ted Kremenek90af9092010-12-02 07:49:45 +00001990{
Zhongxing Xubce831f2010-08-15 08:19:57 +00001991 if (!SymReaper.hasDeadSymbols())
1992 return;
Zhongxing Xuc7460962009-11-13 07:48:11 +00001993
Ted Kremenek49b1e382012-01-26 21:29:00 +00001994 ProgramStateRef state = C.getState();
Zhongxing Xubce831f2010-08-15 08:19:57 +00001995 RegionStateTy RS = state->get<RegionState>();
Jordy Rose82584992010-08-18 04:33:47 +00001996 RegionStateTy::Factory &F = state->get_context<RegionState>();
Zhongxing Xubce831f2010-08-15 08:19:57 +00001997
Dmitri Gribenkof8579502013-01-12 19:30:44 +00001998 SmallVector<SymbolRef, 2> Errors;
Zhongxing Xubce831f2010-08-15 08:19:57 +00001999 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
2000 if (SymReaper.isDead(I->first)) {
Anna Zaks58a2c4e2012-10-29 22:51:54 +00002001 if (I->second.isAllocated())
Anna Zaks78edc2f2012-02-09 06:48:19 +00002002 Errors.push_back(I->first);
Jordy Rose82584992010-08-18 04:33:47 +00002003 // Remove the dead symbol from the map.
Ted Kremenekb3b56c62010-11-24 00:54:37 +00002004 RS = F.remove(RS, I->first);
Ted Kremeneke227f492011-07-28 23:07:51 +00002005
Zhongxing Xuc7460962009-11-13 07:48:11 +00002006 }
2007 }
Ted Kremeneke227f492011-07-28 23:07:51 +00002008
Anna Zaksd56c8792012-02-13 18:05:39 +00002009 // Cleanup the Realloc Pairs Map.
Jordan Rose0c153cb2012-11-02 01:54:06 +00002010 ReallocPairsTy RP = state->get<ReallocPairs>();
2011 for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Anna Zaksac068142012-02-15 00:11:25 +00002012 if (SymReaper.isDead(I->first) ||
2013 SymReaper.isDead(I->second.ReallocatedSym)) {
Anna Zaksd56c8792012-02-13 18:05:39 +00002014 state = state->remove<ReallocPairs>(I->first);
2015 }
2016 }
2017
Anna Zaks67291b92012-11-13 03:18:01 +00002018 // Cleanup the FreeReturnValue Map.
2019 FreeReturnValueTy FR = state->get<FreeReturnValue>();
2020 for (FreeReturnValueTy::iterator I = FR.begin(), E = FR.end(); I != E; ++I) {
2021 if (SymReaper.isDead(I->first) ||
2022 SymReaper.isDead(I->second)) {
2023 state = state->remove<FreeReturnValue>(I->first);
2024 }
2025 }
2026
Anna Zaksdf901a42012-02-23 21:38:21 +00002027 // Generate leak node.
Anna Zaks58a2c4e2012-10-29 22:51:54 +00002028 ExplodedNode *N = C.getPredecessor();
2029 if (!Errors.empty()) {
Anton Yartsev6a619222014-02-17 18:25:34 +00002030 static CheckerProgramPointTag Tag("MallocChecker", "DeadSymbolsLeak");
Anna Zaks58a2c4e2012-10-29 22:51:54 +00002031 N = C.addTransition(C.getState(), C.getPredecessor(), &Tag);
Craig Topper2341c0d2013-07-04 03:08:24 +00002032 for (SmallVectorImpl<SymbolRef>::iterator
2033 I = Errors.begin(), E = Errors.end(); I != E; ++I) {
Anna Zaksd3571e5a2012-02-11 21:02:40 +00002034 reportLeak(*I, N, C);
Anna Zaks78edc2f2012-02-09 06:48:19 +00002035 }
Ted Kremeneke227f492011-07-28 23:07:51 +00002036 }
Anna Zaks58a2c4e2012-10-29 22:51:54 +00002037
Anna Zaksdf901a42012-02-23 21:38:21 +00002038 C.addTransition(state->set<RegionState>(RS), N);
Zhongxing Xuc4902a52009-11-13 07:25:27 +00002039}
Zhongxing Xu4668c7e2009-11-17 07:54:15 +00002040
Anton Yartsevcb2ccd62013-04-10 22:21:41 +00002041void MallocChecker::checkPreCall(const CallEvent &Call,
2042 CheckerContext &C) const {
2043
Jordan Rose656fdd52014-01-08 18:46:55 +00002044 if (const CXXDestructorCall *DC = dyn_cast<CXXDestructorCall>(&Call)) {
2045 SymbolRef Sym = DC->getCXXThisVal().getAsSymbol();
2046 if (!Sym || checkDoubleDelete(Sym, C))
2047 return;
2048 }
2049
Anna Zaks46d01602012-05-18 01:16:10 +00002050 // We will check for double free in the post visit.
Anton Yartsevcb2ccd62013-04-10 22:21:41 +00002051 if (const AnyFunctionCall *FC = dyn_cast<AnyFunctionCall>(&Call)) {
2052 const FunctionDecl *FD = FC->getDecl();
2053 if (!FD)
2054 return;
Anton Yartsev13df0362013-03-25 01:35:45 +00002055
Anna Zaksd79b8402014-10-03 21:48:59 +00002056 ASTContext &Ctx = C.getASTContext();
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00002057 if ((ChecksEnabled[CK_MallocOptimistic] ||
2058 ChecksEnabled[CK_MallocPessimistic]) &&
Anna Zaksd79b8402014-10-03 21:48:59 +00002059 (isCMemFunction(FD, Ctx, AF_Malloc, MemoryOperationKind::MOK_Free) ||
2060 isCMemFunction(FD, Ctx, AF_IfNameIndex,
2061 MemoryOperationKind::MOK_Free)))
Anton Yartsevcb2ccd62013-04-10 22:21:41 +00002062 return;
Anna Zaks3d348342012-02-14 21:55:24 +00002063
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00002064 if (ChecksEnabled[CK_NewDeleteChecker] &&
Anna Zaksd79b8402014-10-03 21:48:59 +00002065 isStandardNewDelete(FD, Ctx))
Anton Yartsevcb2ccd62013-04-10 22:21:41 +00002066 return;
2067 }
2068
2069 // Check if the callee of a method is deleted.
2070 if (const CXXInstanceCall *CC = dyn_cast<CXXInstanceCall>(&Call)) {
2071 SymbolRef Sym = CC->getCXXThisVal().getAsSymbol();
2072 if (!Sym || checkUseAfterFree(Sym, C, CC->getCXXThisExpr()))
2073 return;
2074 }
2075
2076 // Check arguments for being used after free.
2077 for (unsigned I = 0, E = Call.getNumArgs(); I != E; ++I) {
2078 SVal ArgSVal = Call.getArgSVal(I);
2079 if (ArgSVal.getAs<Loc>()) {
2080 SymbolRef Sym = ArgSVal.getAsSymbol();
Anna Zaks3d348342012-02-14 21:55:24 +00002081 if (!Sym)
2082 continue;
Anton Yartsevcb2ccd62013-04-10 22:21:41 +00002083 if (checkUseAfterFree(Sym, C, Call.getArgExpr(I)))
Anna Zaks3d348342012-02-14 21:55:24 +00002084 return;
2085 }
2086 }
2087}
2088
Anna Zaksa1b227b2012-02-08 23:16:56 +00002089void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const {
2090 const Expr *E = S->getRetValue();
2091 if (!E)
2092 return;
Anna Zaks3aa52252012-02-11 21:44:39 +00002093
2094 // Check if we are returning a symbol.
Jordan Rose356279c2012-08-08 18:23:31 +00002095 ProgramStateRef State = C.getState();
2096 SVal RetVal = State->getSVal(E, C.getLocationContext());
Anna Zaks4ca45b12012-02-22 02:36:01 +00002097 SymbolRef Sym = RetVal.getAsSymbol();
2098 if (!Sym)
2099 // If we are returning a field of the allocated struct or an array element,
2100 // the callee could still free the memory.
2101 // TODO: This logic should be a part of generic symbol escape callback.
2102 if (const MemRegion *MR = RetVal.getAsRegion())
2103 if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR))
2104 if (const SymbolicRegion *BMR =
2105 dyn_cast<SymbolicRegion>(MR->getBaseRegion()))
2106 Sym = BMR->getSymbol();
Zhongxing Xu23baa012009-11-17 08:58:18 +00002107
Anna Zaks3aa52252012-02-11 21:44:39 +00002108 // Check if we are returning freed memory.
Jordan Rose356279c2012-08-08 18:23:31 +00002109 if (Sym)
Jordan Rosef1f26142012-11-15 19:11:33 +00002110 checkUseAfterFree(Sym, C, E);
Zhongxing Xu23baa012009-11-17 08:58:18 +00002111}
Zhongxing Xub0e15df2009-12-31 06:13:07 +00002112
Anna Zaks9fe80982012-03-22 00:57:20 +00002113// TODO: Blocks should be either inlined or should call invalidate regions
2114// upon invocation. After that's in place, special casing here will not be
2115// needed.
2116void MallocChecker::checkPostStmt(const BlockExpr *BE,
2117 CheckerContext &C) const {
2118
2119 // Scan the BlockDecRefExprs for any object the retain count checker
2120 // may be tracking.
2121 if (!BE->getBlockDecl()->hasCaptures())
2122 return;
2123
2124 ProgramStateRef state = C.getState();
2125 const BlockDataRegion *R =
2126 cast<BlockDataRegion>(state->getSVal(BE,
2127 C.getLocationContext()).getAsRegion());
2128
2129 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
2130 E = R->referenced_vars_end();
2131
2132 if (I == E)
2133 return;
2134
2135 SmallVector<const MemRegion*, 10> Regions;
2136 const LocationContext *LC = C.getLocationContext();
2137 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
2138
2139 for ( ; I != E; ++I) {
Ted Kremenekbcf90532012-12-06 07:17:20 +00002140 const VarRegion *VR = I.getCapturedRegion();
Anna Zaks9fe80982012-03-22 00:57:20 +00002141 if (VR->getSuperRegion() == R) {
2142 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
2143 }
2144 Regions.push_back(VR);
2145 }
2146
2147 state =
2148 state->scanReachableSymbols<StopTrackingCallback>(Regions.data(),
2149 Regions.data() + Regions.size()).getState();
2150 C.addTransition(state);
2151}
2152
Anna Zaks46d01602012-05-18 01:16:10 +00002153bool MallocChecker::isReleased(SymbolRef Sym, CheckerContext &C) const {
Anna Zaksa1b227b2012-02-08 23:16:56 +00002154 assert(Sym);
2155 const RefState *RS = C.getState()->get<RegionState>(Sym);
Anna Zaks46d01602012-05-18 01:16:10 +00002156 return (RS && RS->isReleased());
2157}
2158
2159bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
2160 const Stmt *S) const {
Anna Zaksa1b227b2012-02-08 23:16:56 +00002161
Jordan Rose656fdd52014-01-08 18:46:55 +00002162 if (isReleased(Sym, C)) {
Anton Yartsev59ed15b2013-03-13 14:39:10 +00002163 ReportUseAfterFree(C, S->getSourceRange(), Sym);
2164 return true;
Anna Zaksa1b227b2012-02-08 23:16:56 +00002165 }
Anton Yartsev59ed15b2013-03-13 14:39:10 +00002166
Anna Zaksa1b227b2012-02-08 23:16:56 +00002167 return false;
2168}
2169
Jordan Rose656fdd52014-01-08 18:46:55 +00002170bool MallocChecker::checkDoubleDelete(SymbolRef Sym, CheckerContext &C) const {
2171
2172 if (isReleased(Sym, C)) {
2173 ReportDoubleDelete(C, Sym);
2174 return true;
2175 }
2176 return false;
2177}
2178
Zhongxing Xu1bb6a1a2010-03-10 04:58:55 +00002179// Check if the location is a freed symbolic region.
Anna Zaks3e0f4152011-10-06 00:43:15 +00002180void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S,
2181 CheckerContext &C) const {
Zhongxing Xu1bb6a1a2010-03-10 04:58:55 +00002182 SymbolRef Sym = l.getLocSymbolInBase();
Anna Zaksa1b227b2012-02-08 23:16:56 +00002183 if (Sym)
Anna Zaks46d01602012-05-18 01:16:10 +00002184 checkUseAfterFree(Sym, C, S);
Zhongxing Xu1bb6a1a2010-03-10 04:58:55 +00002185}
Ted Kremenekd21139a2010-07-31 01:52:11 +00002186
Anna Zaksbb1ef902012-02-11 21:02:35 +00002187// If a symbolic region is assumed to NULL (or another constant), stop tracking
2188// it - assuming that allocation failed on this path.
2189ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state,
2190 SVal Cond,
2191 bool Assumption) const {
2192 RegionStateTy RS = state->get<RegionState>();
Anna Zaksbb1ef902012-02-11 21:02:35 +00002193 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
Ted Kremenek244e1d72012-09-07 22:31:01 +00002194 // If the symbol is assumed to be NULL, remove it from consideration.
Jordan Rose14fe9f32012-11-01 00:18:27 +00002195 ConstraintManager &CMgr = state->getConstraintManager();
2196 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
2197 if (AllocFailed.isConstrainedTrue())
Anna Zaksbb1ef902012-02-11 21:02:35 +00002198 state = state->remove<RegionState>(I.getKey());
2199 }
2200
Anna Zaksd56c8792012-02-13 18:05:39 +00002201 // Realloc returns 0 when reallocation fails, which means that we should
2202 // restore the state of the pointer being reallocated.
Jordan Rose0c153cb2012-11-02 01:54:06 +00002203 ReallocPairsTy RP = state->get<ReallocPairs>();
2204 for (ReallocPairsTy::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Ted Kremenek244e1d72012-09-07 22:31:01 +00002205 // If the symbol is assumed to be NULL, remove it from consideration.
Jordan Rose14fe9f32012-11-01 00:18:27 +00002206 ConstraintManager &CMgr = state->getConstraintManager();
2207 ConditionTruthVal AllocFailed = CMgr.isNull(state, I.getKey());
Jordan Rose40bb12492012-11-01 00:25:15 +00002208 if (!AllocFailed.isConstrainedTrue())
Anna Zaks75cfbb62012-09-12 22:57:34 +00002209 continue;
Jordan Rose14fe9f32012-11-01 00:18:27 +00002210
Anna Zaks75cfbb62012-09-12 22:57:34 +00002211 SymbolRef ReallocSym = I.getData().ReallocatedSym;
2212 if (const RefState *RS = state->get<RegionState>(ReallocSym)) {
2213 if (RS->isReleased()) {
2214 if (I.getData().Kind == RPToBeFreedAfterFailure)
Anna Zaksac068142012-02-15 00:11:25 +00002215 state = state->set<RegionState>(ReallocSym,
Anton Yartsev05789592013-03-28 17:05:19 +00002216 RefState::getAllocated(RS->getAllocationFamily(), RS->getStmt()));
Anna Zaks75cfbb62012-09-12 22:57:34 +00002217 else if (I.getData().Kind == RPDoNotTrackAfterFailure)
2218 state = state->remove<RegionState>(ReallocSym);
2219 else
2220 assert(I.getData().Kind == RPIsFreeOnFailure);
Anna Zaksd56c8792012-02-13 18:05:39 +00002221 }
Anna Zaksd56c8792012-02-13 18:05:39 +00002222 }
Anna Zaks75cfbb62012-09-12 22:57:34 +00002223 state = state->remove<ReallocPairs>(I.getKey());
Anna Zaksd56c8792012-02-13 18:05:39 +00002224 }
2225
Anna Zaksbb1ef902012-02-11 21:02:35 +00002226 return state;
2227}
2228
Anna Zaks8ebeb642013-06-08 00:29:29 +00002229bool MallocChecker::mayFreeAnyEscapedMemoryOrIsModeledExplicitly(
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002230 const CallEvent *Call,
2231 ProgramStateRef State,
2232 SymbolRef &EscapingSymbol) const {
Jordan Rose7ab01822012-07-02 19:27:51 +00002233 assert(Call);
Craig Topper0dbb7832014-05-27 02:45:47 +00002234 EscapingSymbol = nullptr;
2235
Jordan Rose2a833ca2014-01-15 17:25:15 +00002236 // For now, assume that any C++ or block call can free memory.
Anna Zaks7ac344a2012-02-24 23:56:53 +00002237 // TODO: If we want to be more optimistic here, we'll need to make sure that
2238 // regions escape to C++ containers. They seem to do that even now, but for
2239 // mysterious reasons.
Jordan Rose2a833ca2014-01-15 17:25:15 +00002240 if (!(isa<SimpleFunctionCall>(Call) || isa<ObjCMethodCall>(Call)))
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002241 return true;
Anna Zaks7ac344a2012-02-24 23:56:53 +00002242
Jordan Rose742920c2012-07-02 19:27:35 +00002243 // Check Objective-C messages by selector name.
Jordan Rose6bad4902012-07-02 19:27:56 +00002244 if (const ObjCMethodCall *Msg = dyn_cast<ObjCMethodCall>(Call)) {
Jordan Rose7ab01822012-07-02 19:27:51 +00002245 // If it's not a framework call, or if it takes a callback, assume it
2246 // can free memory.
2247 if (!Call->isInSystemHeader() || Call->hasNonZeroCallbackArg())
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002248 return true;
Anna Zaks06a77fc2012-02-28 01:54:22 +00002249
Jordan Rose613f3c02013-03-09 00:59:10 +00002250 // If it's a method we know about, handle it explicitly post-call.
2251 // This should happen before the "freeWhenDone" check below.
2252 if (isKnownDeallocObjCMethodName(*Msg))
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002253 return false;
Anna Zaks886dfb82012-06-20 23:35:57 +00002254
Jordan Rose613f3c02013-03-09 00:59:10 +00002255 // If there's a "freeWhenDone" parameter, but the method isn't one we know
2256 // about, we can't be sure that the object will use free() to deallocate the
2257 // memory, so we can't model it explicitly. The best we can do is use it to
2258 // decide whether the pointer escapes.
2259 if (Optional<bool> FreeWhenDone = getFreeWhenDoneArg(*Msg))
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002260 return *FreeWhenDone;
Anna Zaks7ac344a2012-02-24 23:56:53 +00002261
Jordan Rose613f3c02013-03-09 00:59:10 +00002262 // If the first selector piece ends with "NoCopy", and there is no
2263 // "freeWhenDone" parameter set to zero, we know ownership is being
2264 // transferred. Again, though, we can't be sure that the object will use
2265 // free() to deallocate the memory, so we can't model it explicitly.
2266 StringRef FirstSlot = Msg->getSelector().getNameForSlot(0);
Jordan Rose742920c2012-07-02 19:27:35 +00002267 if (FirstSlot.endswith("NoCopy"))
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002268 return true;
Anna Zaks12a8b902012-03-05 17:42:10 +00002269
Anna Zaks42908c72012-06-19 05:10:32 +00002270 // If the first selector starts with addPointer, insertPointer,
2271 // or replacePointer, assume we are dealing with NSPointerArray or similar.
2272 // This is similar to C++ containers (vector); we still might want to check
Jordan Rose742920c2012-07-02 19:27:35 +00002273 // that the pointers get freed by following the container itself.
2274 if (FirstSlot.startswith("addPointer") ||
2275 FirstSlot.startswith("insertPointer") ||
Jordan Rose514f9352014-01-07 21:39:48 +00002276 FirstSlot.startswith("replacePointer") ||
2277 FirstSlot.equals("valueWithPointer")) {
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002278 return true;
Anna Zaks42908c72012-06-19 05:10:32 +00002279 }
2280
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002281 // We should escape receiver on call to 'init'. This is especially relevant
2282 // to the receiver, as the corresponding symbol is usually not referenced
2283 // after the call.
2284 if (Msg->getMethodFamily() == OMF_init) {
2285 EscapingSymbol = Msg->getReceiverSVal().getAsSymbol();
2286 return true;
2287 }
Anna Zaks737926b2013-05-31 22:39:13 +00002288
Jordan Rose742920c2012-07-02 19:27:35 +00002289 // Otherwise, assume that the method does not free memory.
2290 // Most framework methods do not free memory.
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002291 return false;
Anna Zaks3d348342012-02-14 21:55:24 +00002292 }
2293
Jordan Rose742920c2012-07-02 19:27:35 +00002294 // At this point the only thing left to handle is straight function calls.
Jordan Rose2a833ca2014-01-15 17:25:15 +00002295 const FunctionDecl *FD = cast<SimpleFunctionCall>(Call)->getDecl();
Jordan Rose742920c2012-07-02 19:27:35 +00002296 if (!FD)
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002297 return true;
Anna Zaks7ac344a2012-02-24 23:56:53 +00002298
Jordan Rose742920c2012-07-02 19:27:35 +00002299 ASTContext &ASTC = State->getStateManager().getContext();
2300
2301 // If it's one of the allocation functions we can reason about, we model
2302 // its behavior explicitly.
2303 if (isMemFunction(FD, ASTC))
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002304 return false;
Jordan Rose742920c2012-07-02 19:27:35 +00002305
2306 // If it's not a system call, assume it frees memory.
2307 if (!Call->isInSystemHeader())
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002308 return true;
Jordan Rose742920c2012-07-02 19:27:35 +00002309
2310 // White list the system functions whose arguments escape.
2311 const IdentifierInfo *II = FD->getIdentifier();
2312 if (!II)
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002313 return true;
Jordan Rose742920c2012-07-02 19:27:35 +00002314 StringRef FName = II->getName();
2315
Jordan Rose742920c2012-07-02 19:27:35 +00002316 // White list the 'XXXNoCopy' CoreFoundation functions.
Jordan Rose7ab01822012-07-02 19:27:51 +00002317 // We specifically check these before
Jordan Rose742920c2012-07-02 19:27:35 +00002318 if (FName.endswith("NoCopy")) {
2319 // Look for the deallocator argument. We know that the memory ownership
2320 // is not transferred only if the deallocator argument is
2321 // 'kCFAllocatorNull'.
2322 for (unsigned i = 1; i < Call->getNumArgs(); ++i) {
2323 const Expr *ArgE = Call->getArgExpr(i)->IgnoreParenCasts();
2324 if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) {
2325 StringRef DeallocatorName = DE->getFoundDecl()->getName();
2326 if (DeallocatorName == "kCFAllocatorNull")
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002327 return false;
Jordan Rose742920c2012-07-02 19:27:35 +00002328 }
2329 }
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002330 return true;
Jordan Rose742920c2012-07-02 19:27:35 +00002331 }
2332
Jordan Rose742920c2012-07-02 19:27:35 +00002333 // Associating streams with malloced buffers. The pointer can escape if
Jordan Rose7ab01822012-07-02 19:27:51 +00002334 // 'closefn' is specified (and if that function does free memory),
2335 // but it will not if closefn is not specified.
Jordan Rose742920c2012-07-02 19:27:35 +00002336 // Currently, we do not inspect the 'closefn' function (PR12101).
2337 if (FName == "funopen")
Jordan Rose7ab01822012-07-02 19:27:51 +00002338 if (Call->getNumArgs() >= 4 && Call->getArgSVal(4).isConstant(0))
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002339 return false;
Jordan Rose742920c2012-07-02 19:27:35 +00002340
2341 // Do not warn on pointers passed to 'setbuf' when used with std streams,
2342 // these leaks might be intentional when setting the buffer for stdio.
2343 // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer
2344 if (FName == "setbuf" || FName =="setbuffer" ||
2345 FName == "setlinebuf" || FName == "setvbuf") {
2346 if (Call->getNumArgs() >= 1) {
2347 const Expr *ArgE = Call->getArgExpr(0)->IgnoreParenCasts();
2348 if (const DeclRefExpr *ArgDRE = dyn_cast<DeclRefExpr>(ArgE))
2349 if (const VarDecl *D = dyn_cast<VarDecl>(ArgDRE->getDecl()))
2350 if (D->getCanonicalDecl()->getName().find("std") != StringRef::npos)
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002351 return true;
Jordan Rose742920c2012-07-02 19:27:35 +00002352 }
2353 }
2354
2355 // A bunch of other functions which either take ownership of a pointer or
2356 // wrap the result up in a struct or object, meaning it can be freed later.
2357 // (See RetainCountChecker.) Not all the parameters here are invalidated,
2358 // but the Malloc checker cannot differentiate between them. The right way
2359 // of doing this would be to implement a pointer escapes callback.
2360 if (FName == "CGBitmapContextCreate" ||
2361 FName == "CGBitmapContextCreateWithData" ||
2362 FName == "CVPixelBufferCreateWithBytes" ||
2363 FName == "CVPixelBufferCreateWithPlanarBytes" ||
2364 FName == "OSAtomicEnqueue") {
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002365 return true;
Jordan Rose742920c2012-07-02 19:27:35 +00002366 }
2367
Jordan Rose7ab01822012-07-02 19:27:51 +00002368 // Handle cases where we know a buffer's /address/ can escape.
2369 // Note that the above checks handle some special cases where we know that
2370 // even though the address escapes, it's still our responsibility to free the
2371 // buffer.
2372 if (Call->argumentsMayEscape())
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002373 return true;
Jordan Rose742920c2012-07-02 19:27:35 +00002374
2375 // Otherwise, assume that the function does not free memory.
2376 // Most system calls do not free the memory.
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002377 return false;
Anna Zaks3d348342012-02-14 21:55:24 +00002378}
2379
Anna Zaks333481b2013-03-28 23:15:29 +00002380static bool retTrue(const RefState *RS) {
2381 return true;
2382}
2383
2384static bool checkIfNewOrNewArrayFamily(const RefState *RS) {
2385 return (RS->getAllocationFamily() == AF_CXXNewArray ||
2386 RS->getAllocationFamily() == AF_CXXNew);
2387}
2388
Anna Zaksdc154152012-12-20 00:38:25 +00002389ProgramStateRef MallocChecker::checkPointerEscape(ProgramStateRef State,
2390 const InvalidatedSymbols &Escaped,
Anna Zaksacdc13c2013-02-07 23:05:43 +00002391 const CallEvent *Call,
2392 PointerEscapeKind Kind) const {
Anna Zaks333481b2013-03-28 23:15:29 +00002393 return checkPointerEscapeAux(State, Escaped, Call, Kind, &retTrue);
2394}
2395
2396ProgramStateRef MallocChecker::checkConstPointerEscape(ProgramStateRef State,
2397 const InvalidatedSymbols &Escaped,
2398 const CallEvent *Call,
2399 PointerEscapeKind Kind) const {
2400 return checkPointerEscapeAux(State, Escaped, Call, Kind,
2401 &checkIfNewOrNewArrayFamily);
2402}
2403
2404ProgramStateRef MallocChecker::checkPointerEscapeAux(ProgramStateRef State,
2405 const InvalidatedSymbols &Escaped,
2406 const CallEvent *Call,
2407 PointerEscapeKind Kind,
2408 bool(*CheckRefState)(const RefState*)) const {
Jordan Rose613f3c02013-03-09 00:59:10 +00002409 // If we know that the call does not free memory, or we want to process the
2410 // call later, keep tracking the top level arguments.
Craig Topper0dbb7832014-05-27 02:45:47 +00002411 SymbolRef EscapingSymbol = nullptr;
Jordan Rose757fbb02013-05-10 17:07:16 +00002412 if (Kind == PSK_DirectEscapeOnCall &&
Anna Zaks8ebeb642013-06-08 00:29:29 +00002413 !mayFreeAnyEscapedMemoryOrIsModeledExplicitly(Call, State,
2414 EscapingSymbol) &&
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002415 !EscapingSymbol) {
Anna Zaks3d348342012-02-14 21:55:24 +00002416 return State;
Anna Zaksacdc13c2013-02-07 23:05:43 +00002417 }
Anna Zaks3d348342012-02-14 21:55:24 +00002418
Anna Zaksdc154152012-12-20 00:38:25 +00002419 for (InvalidatedSymbols::const_iterator I = Escaped.begin(),
Anna Zaks333481b2013-03-28 23:15:29 +00002420 E = Escaped.end();
2421 I != E; ++I) {
Anna Zaksbb1ef902012-02-11 21:02:35 +00002422 SymbolRef sym = *I;
Anna Zaksdc154152012-12-20 00:38:25 +00002423
Anna Zaksa4bc5e12013-05-31 23:47:32 +00002424 if (EscapingSymbol && EscapingSymbol != sym)
2425 continue;
2426
Anna Zaks0d6989b2012-06-22 02:04:31 +00002427 if (const RefState *RS = State->get<RegionState>(sym)) {
Anna Zaks93a21a82013-04-09 00:30:28 +00002428 if (RS->isAllocated() && CheckRefState(RS)) {
Anna Zaks23a62012012-08-09 00:42:24 +00002429 State = State->remove<RegionState>(sym);
Anna Zaks93a21a82013-04-09 00:30:28 +00002430 State = State->set<RegionState>(sym, RefState::getEscaped(RS));
2431 }
Anna Zaks0d6989b2012-06-22 02:04:31 +00002432 }
Anna Zaksbb1ef902012-02-11 21:02:35 +00002433 }
Anna Zaks3d348342012-02-14 21:55:24 +00002434 return State;
Ted Kremenekd21139a2010-07-31 01:52:11 +00002435}
Argyrios Kyrtzidis183f0fb2011-02-28 01:26:35 +00002436
Jordy Rosebf38f202012-03-18 07:43:35 +00002437static SymbolRef findFailedReallocSymbol(ProgramStateRef currState,
2438 ProgramStateRef prevState) {
Jordan Rose0c153cb2012-11-02 01:54:06 +00002439 ReallocPairsTy currMap = currState->get<ReallocPairs>();
2440 ReallocPairsTy prevMap = prevState->get<ReallocPairs>();
Jordy Rosebf38f202012-03-18 07:43:35 +00002441
Jordan Rose0c153cb2012-11-02 01:54:06 +00002442 for (ReallocPairsTy::iterator I = prevMap.begin(), E = prevMap.end();
Jordy Rosebf38f202012-03-18 07:43:35 +00002443 I != E; ++I) {
2444 SymbolRef sym = I.getKey();
2445 if (!currMap.lookup(sym))
2446 return sym;
2447 }
2448
Craig Topper0dbb7832014-05-27 02:45:47 +00002449 return nullptr;
Jordy Rosebf38f202012-03-18 07:43:35 +00002450}
2451
Anna Zaks2b5bb972012-02-09 06:25:51 +00002452PathDiagnosticPiece *
2453MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N,
2454 const ExplodedNode *PrevN,
2455 BugReporterContext &BRC,
2456 BugReport &BR) {
Jordy Rosebf38f202012-03-18 07:43:35 +00002457 ProgramStateRef state = N->getState();
2458 ProgramStateRef statePrev = PrevN->getState();
2459
2460 const RefState *RS = state->get<RegionState>(Sym);
2461 const RefState *RSPrev = statePrev->get<RegionState>(Sym);
Anna Zaks52242a62012-08-03 18:30:18 +00002462 if (!RS)
Craig Topper0dbb7832014-05-27 02:45:47 +00002463 return nullptr;
Anna Zaks2b5bb972012-02-09 06:25:51 +00002464
Craig Topper0dbb7832014-05-27 02:45:47 +00002465 const Stmt *S = nullptr;
2466 const char *Msg = nullptr;
2467 StackHintGeneratorForSymbol *StackHint = nullptr;
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002468
2469 // Retrieve the associated statement.
2470 ProgramPoint ProgLoc = N->getLocation();
David Blaikie87396b92013-02-21 22:23:56 +00002471 if (Optional<StmtPoint> SP = ProgLoc.getAs<StmtPoint>()) {
Jordan Rosefbe6dba2012-07-10 22:07:52 +00002472 S = SP->getStmt();
David Blaikie87396b92013-02-21 22:23:56 +00002473 } else if (Optional<CallExitEnd> Exit = ProgLoc.getAs<CallExitEnd>()) {
Jordan Rosefbe6dba2012-07-10 22:07:52 +00002474 S = Exit->getCalleeContext()->getCallSite();
David Blaikie87396b92013-02-21 22:23:56 +00002475 } else if (Optional<BlockEdge> Edge = ProgLoc.getAs<BlockEdge>()) {
Ted Kremenek7505b5a2013-01-04 19:04:36 +00002476 // If an assumption was made on a branch, it should be caught
2477 // here by looking at the state transition.
2478 S = Edge->getSrc()->getTerminator();
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002479 }
Ted Kremenek7505b5a2013-01-04 19:04:36 +00002480
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002481 if (!S)
Craig Topper0dbb7832014-05-27 02:45:47 +00002482 return nullptr;
Anna Zaks2b5bb972012-02-09 06:25:51 +00002483
Jordan Rose681cce92012-07-10 22:07:42 +00002484 // FIXME: We will eventually need to handle non-statement-based events
2485 // (__attribute__((cleanup))).
2486
Anna Zaks2b5bb972012-02-09 06:25:51 +00002487 // Find out if this is an interesting point and what is the kind.
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002488 if (Mode == Normal) {
Anna Zaks1ff57d52012-03-15 21:13:02 +00002489 if (isAllocated(RS, RSPrev, S)) {
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002490 Msg = "Memory is allocated";
Anna Zaksa7f457a2012-03-16 23:44:28 +00002491 StackHint = new StackHintGeneratorForSymbol(Sym,
2492 "Returned allocated memory");
Anna Zaks1ff57d52012-03-15 21:13:02 +00002493 } else if (isReleased(RS, RSPrev, S)) {
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002494 Msg = "Memory is released";
Anna Zaksa7f457a2012-03-16 23:44:28 +00002495 StackHint = new StackHintGeneratorForSymbol(Sym,
Anna Zakse4cfcd42013-04-16 00:22:55 +00002496 "Returning; memory was released");
Anna Zaks0d6989b2012-06-22 02:04:31 +00002497 } else if (isRelinquished(RS, RSPrev, S)) {
Alp Toker5faf0c02013-12-02 03:50:25 +00002498 Msg = "Memory ownership is transferred";
Anna Zaks0d6989b2012-06-22 02:04:31 +00002499 StackHint = new StackHintGeneratorForSymbol(Sym, "");
Anna Zaks1ff57d52012-03-15 21:13:02 +00002500 } else if (isReallocFailedCheck(RS, RSPrev, S)) {
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002501 Mode = ReallocationFailed;
2502 Msg = "Reallocation failed";
Anna Zakscba4f292012-03-16 23:24:20 +00002503 StackHint = new StackHintGeneratorForReallocationFailed(Sym,
Anna Zaksa7f457a2012-03-16 23:44:28 +00002504 "Reallocation failed");
Jordy Rosebf38f202012-03-18 07:43:35 +00002505
Jordy Rose21ff76e2012-03-24 03:15:09 +00002506 if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) {
2507 // Is it possible to fail two reallocs WITHOUT testing in between?
2508 assert((!FailedReallocSymbol || FailedReallocSymbol == sym) &&
2509 "We only support one failed realloc at a time.");
Jordy Rosebf38f202012-03-18 07:43:35 +00002510 BR.markInteresting(sym);
Jordy Rose21ff76e2012-03-24 03:15:09 +00002511 FailedReallocSymbol = sym;
2512 }
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002513 }
2514
2515 // We are in a special mode if a reallocation failed later in the path.
2516 } else if (Mode == ReallocationFailed) {
Jordy Rose21ff76e2012-03-24 03:15:09 +00002517 assert(FailedReallocSymbol && "No symbol to look for.");
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002518
Jordy Rose21ff76e2012-03-24 03:15:09 +00002519 // Is this is the first appearance of the reallocated symbol?
2520 if (!statePrev->get<RegionState>(FailedReallocSymbol)) {
Jordy Rose21ff76e2012-03-24 03:15:09 +00002521 // We're at the reallocation point.
2522 Msg = "Attempt to reallocate memory";
2523 StackHint = new StackHintGeneratorForSymbol(Sym,
2524 "Returned reallocated memory");
Craig Topper0dbb7832014-05-27 02:45:47 +00002525 FailedReallocSymbol = nullptr;
Jordy Rose21ff76e2012-03-24 03:15:09 +00002526 Mode = Normal;
2527 }
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002528 }
2529
Anna Zaks2b5bb972012-02-09 06:25:51 +00002530 if (!Msg)
Craig Topper0dbb7832014-05-27 02:45:47 +00002531 return nullptr;
Anna Zakscba4f292012-03-16 23:24:20 +00002532 assert(StackHint);
Anna Zaks2b5bb972012-02-09 06:25:51 +00002533
2534 // Generate the extra diagnostic.
Anna Zaks9eb7bc82012-02-16 22:26:07 +00002535 PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
Anna Zaks2b5bb972012-02-09 06:25:51 +00002536 N->getLocationContext());
Anna Zakscba4f292012-03-16 23:24:20 +00002537 return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint);
Anna Zaks2b5bb972012-02-09 06:25:51 +00002538}
2539
Anna Zaks263b7e02012-05-02 00:05:20 +00002540void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State,
2541 const char *NL, const char *Sep) const {
2542
2543 RegionStateTy RS = State->get<RegionState>();
2544
Ted Kremenek6fcefb52013-01-03 01:30:12 +00002545 if (!RS.isEmpty()) {
Anton Yartsev6a619222014-02-17 18:25:34 +00002546 Out << Sep << "MallocChecker :" << NL;
Ted Kremenek6fcefb52013-01-03 01:30:12 +00002547 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
Anton Yartsev6a619222014-02-17 18:25:34 +00002548 const RefState *RefS = State->get<RegionState>(I.getKey());
2549 AllocationFamily Family = RefS->getAllocationFamily();
Anton Yartseve5c0c142015-02-18 00:39:06 +00002550 auto CheckKind = getCheckIfTracked(MakeVecFromCK(CK_MallocOptimistic,
2551 CK_MallocPessimistic,
2552 CK_NewDeleteChecker),
2553 Family);
Ted Kremenek6fcefb52013-01-03 01:30:12 +00002554 I.getKey()->dumpToStream(Out);
2555 Out << " : ";
2556 I.getData().dump(Out);
Anton Yartsev6a619222014-02-17 18:25:34 +00002557 if (CheckKind.hasValue())
2558 Out << " (" << CheckNames[*CheckKind].getName() << ")";
Ted Kremenek6fcefb52013-01-03 01:30:12 +00002559 Out << NL;
2560 }
2561 }
Anna Zaks263b7e02012-05-02 00:05:20 +00002562}
Anna Zaks2b5bb972012-02-09 06:25:51 +00002563
Anna Zakse4cfcd42013-04-16 00:22:55 +00002564void ento::registerNewDeleteLeaksChecker(CheckerManager &mgr) {
2565 registerCStringCheckerBasic(mgr);
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00002566 MallocChecker *checker = mgr.registerChecker<MallocChecker>();
2567 checker->ChecksEnabled[MallocChecker::CK_NewDeleteLeaksChecker] = true;
2568 checker->CheckNames[MallocChecker::CK_NewDeleteLeaksChecker] =
2569 mgr.getCurrentCheckName();
Anna Zakse4cfcd42013-04-16 00:22:55 +00002570 // We currently treat NewDeleteLeaks checker as a subchecker of NewDelete
2571 // checker.
Anton Yartsev6a619222014-02-17 18:25:34 +00002572 if (!checker->ChecksEnabled[MallocChecker::CK_NewDeleteChecker])
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00002573 checker->ChecksEnabled[MallocChecker::CK_NewDeleteChecker] = true;
Anna Zakse4cfcd42013-04-16 00:22:55 +00002574}
Anton Yartsev7af0aa82013-04-12 23:25:40 +00002575
Alexander Kornienko4aca9b12014-02-11 21:49:21 +00002576#define REGISTER_CHECKER(name) \
2577 void ento::register##name(CheckerManager &mgr) { \
2578 registerCStringCheckerBasic(mgr); \
2579 MallocChecker *checker = mgr.registerChecker<MallocChecker>(); \
2580 checker->ChecksEnabled[MallocChecker::CK_##name] = true; \
2581 checker->CheckNames[MallocChecker::CK_##name] = mgr.getCurrentCheckName(); \
2582 }
Anna Zakscd37bf42012-02-08 23:16:52 +00002583
2584REGISTER_CHECKER(MallocPessimistic)
2585REGISTER_CHECKER(MallocOptimistic)
Anton Yartsev13df0362013-03-25 01:35:45 +00002586REGISTER_CHECKER(NewDeleteChecker)
Anton Yartsev05789592013-03-28 17:05:19 +00002587REGISTER_CHECKER(MismatchedDeallocatorChecker)