blob: c3b81b6683d24be412c23e12f24f6ea5d50af8c2 [file] [log] [blame]
Chris Lattnerb87b1b32007-08-10 20:18:51 +00001//===--- SemaChecking.cpp - Extra Semantic Checking -----------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner5b12ab82007-12-29 19:59:25 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Chris Lattnerb87b1b32007-08-10 20:18:51 +00007//
8//===----------------------------------------------------------------------===//
9//
Mike Stump11289f42009-09-09 15:08:12 +000010// This file implements extra semantic analysis beyond what is enforced
Chris Lattnerb87b1b32007-08-10 20:18:51 +000011// by the C type system.
12//
13//===----------------------------------------------------------------------===//
14
John McCall83024632010-08-25 22:03:47 +000015#include "clang/Sema/SemaInternal.h"
Chris Lattnerb87b1b32007-08-10 20:18:51 +000016#include "clang/AST/ASTContext.h"
Ken Dyck40775002010-01-11 17:06:35 +000017#include "clang/AST/CharUnits.h"
John McCall28a0cf72010-08-25 07:42:41 +000018#include "clang/AST/DeclCXX.h"
Daniel Dunbar6e8aa532008-08-11 05:35:13 +000019#include "clang/AST/DeclObjC.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000020#include "clang/AST/EvaluatedExprVisitor.h"
David Blaikie7555b6a2012-05-15 16:56:36 +000021#include "clang/AST/Expr.h"
Ted Kremenekc81614d2007-08-20 16:18:38 +000022#include "clang/AST/ExprCXX.h"
Ted Kremenek34f664d2008-06-16 18:00:42 +000023#include "clang/AST/ExprObjC.h"
Mike Stump0c2ec772010-01-21 03:59:47 +000024#include "clang/AST/StmtCXX.h"
25#include "clang/AST/StmtObjC.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000026#include "clang/Analysis/Analyses/FormatString.h"
Jordan Rosea7d03842013-02-08 22:30:41 +000027#include "clang/Basic/CharInfo.h"
Eric Christopher8d0c6212010-04-17 02:26:23 +000028#include "clang/Basic/TargetBuiltins.h"
Nate Begeman4904e322010-06-08 02:47:44 +000029#include "clang/Basic/TargetInfo.h"
Alp Tokerb6cc5922014-05-03 03:45:55 +000030#include "clang/Lex/Lexer.h" // TODO: Extract static functions to fix layering.
Chandler Carruth3a022472012-12-04 09:13:33 +000031#include "clang/Sema/Initialization.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000032#include "clang/Sema/Lookup.h"
33#include "clang/Sema/ScopeInfo.h"
34#include "clang/Sema/Sema.h"
Chandler Carruth5553d0d2014-01-07 11:51:46 +000035#include "llvm/ADT/STLExtras.h"
Richard Smithd7293d72013-08-05 18:49:43 +000036#include "llvm/ADT/SmallBitVector.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000037#include "llvm/ADT/SmallString.h"
Dmitri Gribenko9feeef42013-01-30 12:06:08 +000038#include "llvm/Support/ConvertUTF.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000039#include "llvm/Support/raw_ostream.h"
Zhongxing Xu050379b2009-05-20 01:55:10 +000040#include <limits>
Chris Lattnerb87b1b32007-08-10 20:18:51 +000041using namespace clang;
John McCallaab3e412010-08-25 08:40:02 +000042using namespace sema;
Chris Lattnerb87b1b32007-08-10 20:18:51 +000043
Chris Lattnera26fb342009-02-18 17:49:48 +000044SourceLocation Sema::getLocationOfStringLiteralByte(const StringLiteral *SL,
45 unsigned ByteNo) const {
Alp Tokerb6cc5922014-05-03 03:45:55 +000046 return SL->getLocationOfByte(ByteNo, getSourceManager(), LangOpts,
47 Context.getTargetInfo());
Chris Lattnera26fb342009-02-18 17:49:48 +000048}
49
John McCallbebede42011-02-26 05:39:39 +000050/// Checks that a call expression's argument count is the desired number.
51/// This is useful when doing custom type-checking. Returns true on error.
52static bool checkArgCount(Sema &S, CallExpr *call, unsigned desiredArgCount) {
53 unsigned argCount = call->getNumArgs();
54 if (argCount == desiredArgCount) return false;
55
56 if (argCount < desiredArgCount)
57 return S.Diag(call->getLocEnd(), diag::err_typecheck_call_too_few_args)
58 << 0 /*function call*/ << desiredArgCount << argCount
59 << call->getSourceRange();
60
61 // Highlight all the excess arguments.
62 SourceRange range(call->getArg(desiredArgCount)->getLocStart(),
63 call->getArg(argCount - 1)->getLocEnd());
64
65 return S.Diag(range.getBegin(), diag::err_typecheck_call_too_many_args)
66 << 0 /*function call*/ << desiredArgCount << argCount
67 << call->getArg(1)->getSourceRange();
68}
69
Julien Lerouge4a5b4442012-04-28 17:39:16 +000070/// Check that the first argument to __builtin_annotation is an integer
71/// and the second argument is a non-wide string literal.
72static bool SemaBuiltinAnnotation(Sema &S, CallExpr *TheCall) {
73 if (checkArgCount(S, TheCall, 2))
74 return true;
75
76 // First argument should be an integer.
77 Expr *ValArg = TheCall->getArg(0);
78 QualType Ty = ValArg->getType();
79 if (!Ty->isIntegerType()) {
80 S.Diag(ValArg->getLocStart(), diag::err_builtin_annotation_first_arg)
81 << ValArg->getSourceRange();
Julien Lerouge5a6b6982011-09-09 22:41:49 +000082 return true;
83 }
Julien Lerouge4a5b4442012-04-28 17:39:16 +000084
85 // Second argument should be a constant string.
86 Expr *StrArg = TheCall->getArg(1)->IgnoreParenCasts();
87 StringLiteral *Literal = dyn_cast<StringLiteral>(StrArg);
88 if (!Literal || !Literal->isAscii()) {
89 S.Diag(StrArg->getLocStart(), diag::err_builtin_annotation_second_arg)
90 << StrArg->getSourceRange();
91 return true;
92 }
93
94 TheCall->setType(Ty);
Julien Lerouge5a6b6982011-09-09 22:41:49 +000095 return false;
96}
97
Richard Smith6cbd65d2013-07-11 02:27:57 +000098/// Check that the argument to __builtin_addressof is a glvalue, and set the
99/// result type to the corresponding pointer type.
100static bool SemaBuiltinAddressof(Sema &S, CallExpr *TheCall) {
101 if (checkArgCount(S, TheCall, 1))
102 return true;
103
Nikola Smiljanic03ff2592014-05-29 14:05:12 +0000104 ExprResult Arg(TheCall->getArg(0));
Richard Smith6cbd65d2013-07-11 02:27:57 +0000105 QualType ResultType = S.CheckAddressOfOperand(Arg, TheCall->getLocStart());
106 if (ResultType.isNull())
107 return true;
108
Nikola Smiljanic01a75982014-05-29 10:55:11 +0000109 TheCall->setArg(0, Arg.get());
Richard Smith6cbd65d2013-07-11 02:27:57 +0000110 TheCall->setType(ResultType);
111 return false;
112}
113
Fariborz Jahanian3e6a0be2014-09-18 17:58:27 +0000114static void SemaBuiltinMemChkCall(Sema &S, FunctionDecl *FDecl,
115 CallExpr *TheCall, unsigned SizeIdx,
116 unsigned DstSizeIdx) {
117 if (TheCall->getNumArgs() <= SizeIdx ||
118 TheCall->getNumArgs() <= DstSizeIdx)
119 return;
120
121 const Expr *SizeArg = TheCall->getArg(SizeIdx);
122 const Expr *DstSizeArg = TheCall->getArg(DstSizeIdx);
123
124 llvm::APSInt Size, DstSize;
125
126 // find out if both sizes are known at compile time
127 if (!SizeArg->EvaluateAsInt(Size, S.Context) ||
128 !DstSizeArg->EvaluateAsInt(DstSize, S.Context))
129 return;
130
131 if (Size.ule(DstSize))
132 return;
133
134 // confirmed overflow so generate the diagnostic.
135 IdentifierInfo *FnName = FDecl->getIdentifier();
136 SourceLocation SL = TheCall->getLocStart();
137 SourceRange SR = TheCall->getSourceRange();
138
139 S.Diag(SL, diag::warn_memcpy_chk_overflow) << SR << FnName;
140}
141
Peter Collingbournef7706832014-12-12 23:41:25 +0000142static bool SemaBuiltinCallWithStaticChain(Sema &S, CallExpr *BuiltinCall) {
143 if (checkArgCount(S, BuiltinCall, 2))
144 return true;
145
146 SourceLocation BuiltinLoc = BuiltinCall->getLocStart();
147 Expr *Builtin = BuiltinCall->getCallee()->IgnoreImpCasts();
148 Expr *Call = BuiltinCall->getArg(0);
149 Expr *Chain = BuiltinCall->getArg(1);
150
151 if (Call->getStmtClass() != Stmt::CallExprClass) {
152 S.Diag(BuiltinLoc, diag::err_first_argument_to_cwsc_not_call)
153 << Call->getSourceRange();
154 return true;
155 }
156
157 auto CE = cast<CallExpr>(Call);
158 if (CE->getCallee()->getType()->isBlockPointerType()) {
159 S.Diag(BuiltinLoc, diag::err_first_argument_to_cwsc_block_call)
160 << Call->getSourceRange();
161 return true;
162 }
163
164 const Decl *TargetDecl = CE->getCalleeDecl();
165 if (const FunctionDecl *FD = dyn_cast_or_null<FunctionDecl>(TargetDecl))
166 if (FD->getBuiltinID()) {
167 S.Diag(BuiltinLoc, diag::err_first_argument_to_cwsc_builtin_call)
168 << Call->getSourceRange();
169 return true;
170 }
171
172 if (isa<CXXPseudoDestructorExpr>(CE->getCallee()->IgnoreParens())) {
173 S.Diag(BuiltinLoc, diag::err_first_argument_to_cwsc_pdtor_call)
174 << Call->getSourceRange();
175 return true;
176 }
177
178 ExprResult ChainResult = S.UsualUnaryConversions(Chain);
179 if (ChainResult.isInvalid())
180 return true;
181 if (!ChainResult.get()->getType()->isPointerType()) {
182 S.Diag(BuiltinLoc, diag::err_second_argument_to_cwsc_not_pointer)
183 << Chain->getSourceRange();
184 return true;
185 }
186
David Majnemerced8bdf2015-02-25 17:36:15 +0000187 QualType ReturnTy = CE->getCallReturnType(S.Context);
Peter Collingbournef7706832014-12-12 23:41:25 +0000188 QualType ArgTys[2] = { ReturnTy, ChainResult.get()->getType() };
189 QualType BuiltinTy = S.Context.getFunctionType(
190 ReturnTy, ArgTys, FunctionProtoType::ExtProtoInfo());
191 QualType BuiltinPtrTy = S.Context.getPointerType(BuiltinTy);
192
193 Builtin =
194 S.ImpCastExprToType(Builtin, BuiltinPtrTy, CK_BuiltinFnToFnPtr).get();
195
196 BuiltinCall->setType(CE->getType());
197 BuiltinCall->setValueKind(CE->getValueKind());
198 BuiltinCall->setObjectKind(CE->getObjectKind());
199 BuiltinCall->setCallee(Builtin);
200 BuiltinCall->setArg(1, ChainResult.get());
201
202 return false;
203}
204
Reid Kleckner1d59f992015-01-22 01:36:17 +0000205static bool SemaBuiltinSEHScopeCheck(Sema &SemaRef, CallExpr *TheCall,
206 Scope::ScopeFlags NeededScopeFlags,
207 unsigned DiagID) {
208 // Scopes aren't available during instantiation. Fortunately, builtin
209 // functions cannot be template args so they cannot be formed through template
210 // instantiation. Therefore checking once during the parse is sufficient.
211 if (!SemaRef.ActiveTemplateInstantiations.empty())
212 return false;
213
214 Scope *S = SemaRef.getCurScope();
215 while (S && !S->isSEHExceptScope())
216 S = S->getParent();
217 if (!S || !(S->getFlags() & NeededScopeFlags)) {
218 auto *DRE = cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
219 SemaRef.Diag(TheCall->getExprLoc(), DiagID)
220 << DRE->getDecl()->getIdentifier();
221 return true;
222 }
223
224 return false;
225}
226
John McCalldadc5752010-08-24 06:29:42 +0000227ExprResult
Fariborz Jahanian3e6a0be2014-09-18 17:58:27 +0000228Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID,
229 CallExpr *TheCall) {
Nikola Smiljanic03ff2592014-05-29 14:05:12 +0000230 ExprResult TheCallResult(TheCall);
Douglas Gregorae2fbad2008-11-17 20:34:05 +0000231
Chris Lattner3be167f2010-10-01 23:23:24 +0000232 // Find out if any arguments are required to be integer constant expressions.
233 unsigned ICEArguments = 0;
234 ASTContext::GetBuiltinTypeError Error;
235 Context.GetBuiltinType(BuiltinID, Error, &ICEArguments);
236 if (Error != ASTContext::GE_None)
237 ICEArguments = 0; // Don't diagnose previously diagnosed errors.
238
239 // If any arguments are required to be ICE's, check and diagnose.
240 for (unsigned ArgNo = 0; ICEArguments != 0; ++ArgNo) {
241 // Skip arguments not required to be ICE's.
242 if ((ICEArguments & (1 << ArgNo)) == 0) continue;
243
244 llvm::APSInt Result;
245 if (SemaBuiltinConstantArg(TheCall, ArgNo, Result))
246 return true;
247 ICEArguments &= ~(1 << ArgNo);
248 }
249
Anders Carlssonbc4c1072009-08-16 01:56:34 +0000250 switch (BuiltinID) {
Chris Lattner43be2e62007-12-19 23:59:04 +0000251 case Builtin::BI__builtin___CFStringMakeConstantString:
Chris Lattner08464942007-12-28 05:29:59 +0000252 assert(TheCall->getNumArgs() == 1 &&
Chris Lattner2da14fb2007-12-20 00:26:33 +0000253 "Wrong # arguments to builtin CFStringMakeConstantString");
Chris Lattner6436fb62009-02-18 06:01:06 +0000254 if (CheckObjCString(TheCall->getArg(0)))
Sebastian Redlc215cfc2009-01-19 00:08:26 +0000255 return ExprError();
Anders Carlssonbc4c1072009-08-16 01:56:34 +0000256 break;
Ted Kremeneka174c522008-07-09 17:58:53 +0000257 case Builtin::BI__builtin_stdarg_start:
Chris Lattner43be2e62007-12-19 23:59:04 +0000258 case Builtin::BI__builtin_va_start:
Sebastian Redlc215cfc2009-01-19 00:08:26 +0000259 if (SemaBuiltinVAStart(TheCall))
260 return ExprError();
Anders Carlssonbc4c1072009-08-16 01:56:34 +0000261 break;
Saleem Abdulrasool202aac12014-07-22 02:01:04 +0000262 case Builtin::BI__va_start: {
263 switch (Context.getTargetInfo().getTriple().getArch()) {
264 case llvm::Triple::arm:
265 case llvm::Triple::thumb:
266 if (SemaBuiltinVAStartARM(TheCall))
267 return ExprError();
268 break;
269 default:
270 if (SemaBuiltinVAStart(TheCall))
271 return ExprError();
272 break;
273 }
274 break;
275 }
Chris Lattner2da14fb2007-12-20 00:26:33 +0000276 case Builtin::BI__builtin_isgreater:
277 case Builtin::BI__builtin_isgreaterequal:
278 case Builtin::BI__builtin_isless:
279 case Builtin::BI__builtin_islessequal:
280 case Builtin::BI__builtin_islessgreater:
281 case Builtin::BI__builtin_isunordered:
Sebastian Redlc215cfc2009-01-19 00:08:26 +0000282 if (SemaBuiltinUnorderedCompare(TheCall))
283 return ExprError();
Anders Carlssonbc4c1072009-08-16 01:56:34 +0000284 break;
Benjamin Kramer634fc102010-02-15 22:42:31 +0000285 case Builtin::BI__builtin_fpclassify:
286 if (SemaBuiltinFPClassification(TheCall, 6))
287 return ExprError();
288 break;
Eli Friedman7e4faac2009-08-31 20:06:00 +0000289 case Builtin::BI__builtin_isfinite:
290 case Builtin::BI__builtin_isinf:
291 case Builtin::BI__builtin_isinf_sign:
292 case Builtin::BI__builtin_isnan:
293 case Builtin::BI__builtin_isnormal:
Benjamin Kramer64aae502010-02-16 10:07:31 +0000294 if (SemaBuiltinFPClassification(TheCall, 1))
Eli Friedman7e4faac2009-08-31 20:06:00 +0000295 return ExprError();
296 break;
Eli Friedmana1b4ed82008-05-14 19:38:39 +0000297 case Builtin::BI__builtin_shufflevector:
Sebastian Redlc215cfc2009-01-19 00:08:26 +0000298 return SemaBuiltinShuffleVector(TheCall);
299 // TheCall will be freed by the smart pointer here, but that's fine, since
300 // SemaBuiltinShuffleVector guts it, but then doesn't release it.
Daniel Dunbarb7257262008-07-21 22:59:13 +0000301 case Builtin::BI__builtin_prefetch:
Sebastian Redlc215cfc2009-01-19 00:08:26 +0000302 if (SemaBuiltinPrefetch(TheCall))
303 return ExprError();
Anders Carlssonbc4c1072009-08-16 01:56:34 +0000304 break;
Hal Finkelf0417332014-07-17 14:25:55 +0000305 case Builtin::BI__assume:
Hal Finkelbcc06082014-09-07 22:58:14 +0000306 case Builtin::BI__builtin_assume:
Hal Finkelf0417332014-07-17 14:25:55 +0000307 if (SemaBuiltinAssume(TheCall))
308 return ExprError();
309 break;
Hal Finkelbcc06082014-09-07 22:58:14 +0000310 case Builtin::BI__builtin_assume_aligned:
311 if (SemaBuiltinAssumeAligned(TheCall))
312 return ExprError();
313 break;
Daniel Dunbarb0d34c82008-09-03 21:13:56 +0000314 case Builtin::BI__builtin_object_size:
Richard Sandiford28940af2014-04-16 08:47:51 +0000315 if (SemaBuiltinConstantArgRange(TheCall, 1, 0, 3))
Sebastian Redlc215cfc2009-01-19 00:08:26 +0000316 return ExprError();
Anders Carlssonbc4c1072009-08-16 01:56:34 +0000317 break;
Eli Friedmaneed8ad22009-05-03 04:46:36 +0000318 case Builtin::BI__builtin_longjmp:
319 if (SemaBuiltinLongjmp(TheCall))
320 return ExprError();
Anders Carlssonbc4c1072009-08-16 01:56:34 +0000321 break;
Joerg Sonnenberger27173282015-03-11 23:46:32 +0000322 case Builtin::BI__builtin_setjmp:
323 if (SemaBuiltinSetjmp(TheCall))
324 return ExprError();
325 break;
David Majnemerc403a1c2015-03-20 17:03:35 +0000326 case Builtin::BI_setjmp:
327 case Builtin::BI_setjmpex:
328 if (checkArgCount(*this, TheCall, 1))
329 return true;
330 break;
John McCallbebede42011-02-26 05:39:39 +0000331
332 case Builtin::BI__builtin_classify_type:
333 if (checkArgCount(*this, TheCall, 1)) return true;
334 TheCall->setType(Context.IntTy);
335 break;
Chris Lattner17c0eac2010-10-12 17:47:42 +0000336 case Builtin::BI__builtin_constant_p:
John McCallbebede42011-02-26 05:39:39 +0000337 if (checkArgCount(*this, TheCall, 1)) return true;
338 TheCall->setType(Context.IntTy);
Chris Lattner17c0eac2010-10-12 17:47:42 +0000339 break;
Chris Lattnerdc046542009-05-08 06:58:22 +0000340 case Builtin::BI__sync_fetch_and_add:
Douglas Gregor73722482011-11-28 16:30:08 +0000341 case Builtin::BI__sync_fetch_and_add_1:
342 case Builtin::BI__sync_fetch_and_add_2:
343 case Builtin::BI__sync_fetch_and_add_4:
344 case Builtin::BI__sync_fetch_and_add_8:
345 case Builtin::BI__sync_fetch_and_add_16:
Chris Lattnerdc046542009-05-08 06:58:22 +0000346 case Builtin::BI__sync_fetch_and_sub:
Douglas Gregor73722482011-11-28 16:30:08 +0000347 case Builtin::BI__sync_fetch_and_sub_1:
348 case Builtin::BI__sync_fetch_and_sub_2:
349 case Builtin::BI__sync_fetch_and_sub_4:
350 case Builtin::BI__sync_fetch_and_sub_8:
351 case Builtin::BI__sync_fetch_and_sub_16:
Chris Lattnerdc046542009-05-08 06:58:22 +0000352 case Builtin::BI__sync_fetch_and_or:
Douglas Gregor73722482011-11-28 16:30:08 +0000353 case Builtin::BI__sync_fetch_and_or_1:
354 case Builtin::BI__sync_fetch_and_or_2:
355 case Builtin::BI__sync_fetch_and_or_4:
356 case Builtin::BI__sync_fetch_and_or_8:
357 case Builtin::BI__sync_fetch_and_or_16:
Chris Lattnerdc046542009-05-08 06:58:22 +0000358 case Builtin::BI__sync_fetch_and_and:
Douglas Gregor73722482011-11-28 16:30:08 +0000359 case Builtin::BI__sync_fetch_and_and_1:
360 case Builtin::BI__sync_fetch_and_and_2:
361 case Builtin::BI__sync_fetch_and_and_4:
362 case Builtin::BI__sync_fetch_and_and_8:
363 case Builtin::BI__sync_fetch_and_and_16:
Chris Lattnerdc046542009-05-08 06:58:22 +0000364 case Builtin::BI__sync_fetch_and_xor:
Douglas Gregor73722482011-11-28 16:30:08 +0000365 case Builtin::BI__sync_fetch_and_xor_1:
366 case Builtin::BI__sync_fetch_and_xor_2:
367 case Builtin::BI__sync_fetch_and_xor_4:
368 case Builtin::BI__sync_fetch_and_xor_8:
369 case Builtin::BI__sync_fetch_and_xor_16:
Hal Finkeld2208b52014-10-02 20:53:50 +0000370 case Builtin::BI__sync_fetch_and_nand:
371 case Builtin::BI__sync_fetch_and_nand_1:
372 case Builtin::BI__sync_fetch_and_nand_2:
373 case Builtin::BI__sync_fetch_and_nand_4:
374 case Builtin::BI__sync_fetch_and_nand_8:
375 case Builtin::BI__sync_fetch_and_nand_16:
Chris Lattnerdc046542009-05-08 06:58:22 +0000376 case Builtin::BI__sync_add_and_fetch:
Douglas Gregor73722482011-11-28 16:30:08 +0000377 case Builtin::BI__sync_add_and_fetch_1:
378 case Builtin::BI__sync_add_and_fetch_2:
379 case Builtin::BI__sync_add_and_fetch_4:
380 case Builtin::BI__sync_add_and_fetch_8:
381 case Builtin::BI__sync_add_and_fetch_16:
Chris Lattnerdc046542009-05-08 06:58:22 +0000382 case Builtin::BI__sync_sub_and_fetch:
Douglas Gregor73722482011-11-28 16:30:08 +0000383 case Builtin::BI__sync_sub_and_fetch_1:
384 case Builtin::BI__sync_sub_and_fetch_2:
385 case Builtin::BI__sync_sub_and_fetch_4:
386 case Builtin::BI__sync_sub_and_fetch_8:
387 case Builtin::BI__sync_sub_and_fetch_16:
Chris Lattnerdc046542009-05-08 06:58:22 +0000388 case Builtin::BI__sync_and_and_fetch:
Douglas Gregor73722482011-11-28 16:30:08 +0000389 case Builtin::BI__sync_and_and_fetch_1:
390 case Builtin::BI__sync_and_and_fetch_2:
391 case Builtin::BI__sync_and_and_fetch_4:
392 case Builtin::BI__sync_and_and_fetch_8:
393 case Builtin::BI__sync_and_and_fetch_16:
Chris Lattnerdc046542009-05-08 06:58:22 +0000394 case Builtin::BI__sync_or_and_fetch:
Douglas Gregor73722482011-11-28 16:30:08 +0000395 case Builtin::BI__sync_or_and_fetch_1:
396 case Builtin::BI__sync_or_and_fetch_2:
397 case Builtin::BI__sync_or_and_fetch_4:
398 case Builtin::BI__sync_or_and_fetch_8:
399 case Builtin::BI__sync_or_and_fetch_16:
Chris Lattnerdc046542009-05-08 06:58:22 +0000400 case Builtin::BI__sync_xor_and_fetch:
Douglas Gregor73722482011-11-28 16:30:08 +0000401 case Builtin::BI__sync_xor_and_fetch_1:
402 case Builtin::BI__sync_xor_and_fetch_2:
403 case Builtin::BI__sync_xor_and_fetch_4:
404 case Builtin::BI__sync_xor_and_fetch_8:
405 case Builtin::BI__sync_xor_and_fetch_16:
Hal Finkeld2208b52014-10-02 20:53:50 +0000406 case Builtin::BI__sync_nand_and_fetch:
407 case Builtin::BI__sync_nand_and_fetch_1:
408 case Builtin::BI__sync_nand_and_fetch_2:
409 case Builtin::BI__sync_nand_and_fetch_4:
410 case Builtin::BI__sync_nand_and_fetch_8:
411 case Builtin::BI__sync_nand_and_fetch_16:
Chris Lattnerdc046542009-05-08 06:58:22 +0000412 case Builtin::BI__sync_val_compare_and_swap:
Douglas Gregor73722482011-11-28 16:30:08 +0000413 case Builtin::BI__sync_val_compare_and_swap_1:
414 case Builtin::BI__sync_val_compare_and_swap_2:
415 case Builtin::BI__sync_val_compare_and_swap_4:
416 case Builtin::BI__sync_val_compare_and_swap_8:
417 case Builtin::BI__sync_val_compare_and_swap_16:
Chris Lattnerdc046542009-05-08 06:58:22 +0000418 case Builtin::BI__sync_bool_compare_and_swap:
Douglas Gregor73722482011-11-28 16:30:08 +0000419 case Builtin::BI__sync_bool_compare_and_swap_1:
420 case Builtin::BI__sync_bool_compare_and_swap_2:
421 case Builtin::BI__sync_bool_compare_and_swap_4:
422 case Builtin::BI__sync_bool_compare_and_swap_8:
423 case Builtin::BI__sync_bool_compare_and_swap_16:
Chris Lattnerdc046542009-05-08 06:58:22 +0000424 case Builtin::BI__sync_lock_test_and_set:
Douglas Gregor73722482011-11-28 16:30:08 +0000425 case Builtin::BI__sync_lock_test_and_set_1:
426 case Builtin::BI__sync_lock_test_and_set_2:
427 case Builtin::BI__sync_lock_test_and_set_4:
428 case Builtin::BI__sync_lock_test_and_set_8:
429 case Builtin::BI__sync_lock_test_and_set_16:
Chris Lattnerdc046542009-05-08 06:58:22 +0000430 case Builtin::BI__sync_lock_release:
Douglas Gregor73722482011-11-28 16:30:08 +0000431 case Builtin::BI__sync_lock_release_1:
432 case Builtin::BI__sync_lock_release_2:
433 case Builtin::BI__sync_lock_release_4:
434 case Builtin::BI__sync_lock_release_8:
435 case Builtin::BI__sync_lock_release_16:
Chris Lattner9cb59fa2011-04-09 03:57:26 +0000436 case Builtin::BI__sync_swap:
Douglas Gregor73722482011-11-28 16:30:08 +0000437 case Builtin::BI__sync_swap_1:
438 case Builtin::BI__sync_swap_2:
439 case Builtin::BI__sync_swap_4:
440 case Builtin::BI__sync_swap_8:
441 case Builtin::BI__sync_swap_16:
Benjamin Kramer62b95d82012-08-23 21:35:17 +0000442 return SemaBuiltinAtomicOverloaded(TheCallResult);
Richard Smithfeea8832012-04-12 05:08:17 +0000443#define BUILTIN(ID, TYPE, ATTRS)
444#define ATOMIC_BUILTIN(ID, TYPE, ATTRS) \
445 case Builtin::BI##ID: \
Benjamin Kramer62b95d82012-08-23 21:35:17 +0000446 return SemaAtomicOpsOverloaded(TheCallResult, AtomicExpr::AO##ID);
Richard Smithfeea8832012-04-12 05:08:17 +0000447#include "clang/Basic/Builtins.def"
Julien Lerouge5a6b6982011-09-09 22:41:49 +0000448 case Builtin::BI__builtin_annotation:
Julien Lerouge4a5b4442012-04-28 17:39:16 +0000449 if (SemaBuiltinAnnotation(*this, TheCall))
Julien Lerouge5a6b6982011-09-09 22:41:49 +0000450 return ExprError();
451 break;
Richard Smith6cbd65d2013-07-11 02:27:57 +0000452 case Builtin::BI__builtin_addressof:
453 if (SemaBuiltinAddressof(*this, TheCall))
454 return ExprError();
455 break;
Richard Smith760520b2014-06-03 23:27:44 +0000456 case Builtin::BI__builtin_operator_new:
457 case Builtin::BI__builtin_operator_delete:
458 if (!getLangOpts().CPlusPlus) {
459 Diag(TheCall->getExprLoc(), diag::err_builtin_requires_language)
460 << (BuiltinID == Builtin::BI__builtin_operator_new
461 ? "__builtin_operator_new"
462 : "__builtin_operator_delete")
463 << "C++";
464 return ExprError();
465 }
466 // CodeGen assumes it can find the global new and delete to call,
467 // so ensure that they are declared.
468 DeclareGlobalNewDelete();
469 break;
Fariborz Jahanian3e6a0be2014-09-18 17:58:27 +0000470
471 // check secure string manipulation functions where overflows
472 // are detectable at compile time
473 case Builtin::BI__builtin___memcpy_chk:
Fariborz Jahanian3e6a0be2014-09-18 17:58:27 +0000474 case Builtin::BI__builtin___memmove_chk:
475 case Builtin::BI__builtin___memset_chk:
476 case Builtin::BI__builtin___strlcat_chk:
477 case Builtin::BI__builtin___strlcpy_chk:
478 case Builtin::BI__builtin___strncat_chk:
479 case Builtin::BI__builtin___strncpy_chk:
480 case Builtin::BI__builtin___stpncpy_chk:
481 SemaBuiltinMemChkCall(*this, FDecl, TheCall, 2, 3);
482 break;
Steven Wu566c14e2014-09-24 04:37:33 +0000483 case Builtin::BI__builtin___memccpy_chk:
484 SemaBuiltinMemChkCall(*this, FDecl, TheCall, 3, 4);
485 break;
Fariborz Jahanian3e6a0be2014-09-18 17:58:27 +0000486 case Builtin::BI__builtin___snprintf_chk:
487 case Builtin::BI__builtin___vsnprintf_chk:
488 SemaBuiltinMemChkCall(*this, FDecl, TheCall, 1, 3);
489 break;
Peter Collingbournef7706832014-12-12 23:41:25 +0000490
491 case Builtin::BI__builtin_call_with_static_chain:
492 if (SemaBuiltinCallWithStaticChain(*this, TheCall))
493 return ExprError();
494 break;
Reid Kleckner1d59f992015-01-22 01:36:17 +0000495
496 case Builtin::BI__exception_code:
497 case Builtin::BI_exception_code: {
498 if (SemaBuiltinSEHScopeCheck(*this, TheCall, Scope::SEHExceptScope,
499 diag::err_seh___except_block))
500 return ExprError();
501 break;
502 }
503 case Builtin::BI__exception_info:
504 case Builtin::BI_exception_info: {
505 if (SemaBuiltinSEHScopeCheck(*this, TheCall, Scope::SEHFilterScope,
506 diag::err_seh___except_filter))
507 return ExprError();
508 break;
509 }
510
David Majnemerba3e5ec2015-03-13 18:26:17 +0000511 case Builtin::BI__GetExceptionInfo:
512 if (checkArgCount(*this, TheCall, 1))
513 return ExprError();
514
515 if (CheckCXXThrowOperand(
516 TheCall->getLocStart(),
517 Context.getExceptionObjectType(FDecl->getParamDecl(0)->getType()),
518 TheCall))
519 return ExprError();
520
521 TheCall->setType(Context.VoidPtrTy);
522 break;
523
Nate Begeman4904e322010-06-08 02:47:44 +0000524 }
Richard Smith760520b2014-06-03 23:27:44 +0000525
Nate Begeman4904e322010-06-08 02:47:44 +0000526 // Since the target specific builtins for each arch overlap, only check those
527 // of the arch we are compiling for.
528 if (BuiltinID >= Builtin::FirstTSBuiltin) {
Douglas Gregore8bbc122011-09-02 00:18:52 +0000529 switch (Context.getTargetInfo().getTriple().getArch()) {
Nate Begeman4904e322010-06-08 02:47:44 +0000530 case llvm::Triple::arm:
Christian Pirkerf01cd6f2014-03-28 14:40:46 +0000531 case llvm::Triple::armeb:
Nate Begeman4904e322010-06-08 02:47:44 +0000532 case llvm::Triple::thumb:
Christian Pirkerf01cd6f2014-03-28 14:40:46 +0000533 case llvm::Triple::thumbeb:
Nate Begeman4904e322010-06-08 02:47:44 +0000534 if (CheckARMBuiltinFunctionCall(BuiltinID, TheCall))
535 return ExprError();
536 break;
Tim Northover25e8a672014-05-24 12:51:25 +0000537 case llvm::Triple::aarch64:
538 case llvm::Triple::aarch64_be:
Tim Northover573cbee2014-05-24 12:52:07 +0000539 if (CheckAArch64BuiltinFunctionCall(BuiltinID, TheCall))
Tim Northovera2ee4332014-03-29 15:09:45 +0000540 return ExprError();
541 break;
Simon Atanasyanecedf3d2012-07-08 09:30:00 +0000542 case llvm::Triple::mips:
543 case llvm::Triple::mipsel:
544 case llvm::Triple::mips64:
545 case llvm::Triple::mips64el:
546 if (CheckMipsBuiltinFunctionCall(BuiltinID, TheCall))
547 return ExprError();
548 break;
Ulrich Weigand3a610eb2015-04-01 12:54:25 +0000549 case llvm::Triple::systemz:
550 if (CheckSystemZBuiltinFunctionCall(BuiltinID, TheCall))
551 return ExprError();
552 break;
Warren Hunt20e4a5d2014-02-21 23:08:53 +0000553 case llvm::Triple::x86:
554 case llvm::Triple::x86_64:
555 if (CheckX86BuiltinFunctionCall(BuiltinID, TheCall))
556 return ExprError();
557 break;
Kit Bartone50adcb2015-03-30 19:40:59 +0000558 case llvm::Triple::ppc:
559 case llvm::Triple::ppc64:
560 case llvm::Triple::ppc64le:
561 if (CheckPPCBuiltinFunctionCall(BuiltinID, TheCall))
562 return ExprError();
563 break;
Nate Begeman4904e322010-06-08 02:47:44 +0000564 default:
565 break;
566 }
567 }
568
Benjamin Kramer62b95d82012-08-23 21:35:17 +0000569 return TheCallResult;
Nate Begeman4904e322010-06-08 02:47:44 +0000570}
571
Nate Begeman91e1fea2010-06-14 05:21:25 +0000572// Get the valid immediate range for the specified NEON type code.
Tim Northover3402dc72014-02-12 12:04:59 +0000573static unsigned RFT(unsigned t, bool shift = false, bool ForceQuad = false) {
Bob Wilson98bc98c2011-11-08 01:16:11 +0000574 NeonTypeFlags Type(t);
Tim Northover3402dc72014-02-12 12:04:59 +0000575 int IsQuad = ForceQuad ? true : Type.isQuad();
Bob Wilson98bc98c2011-11-08 01:16:11 +0000576 switch (Type.getEltType()) {
577 case NeonTypeFlags::Int8:
578 case NeonTypeFlags::Poly8:
579 return shift ? 7 : (8 << IsQuad) - 1;
580 case NeonTypeFlags::Int16:
581 case NeonTypeFlags::Poly16:
582 return shift ? 15 : (4 << IsQuad) - 1;
583 case NeonTypeFlags::Int32:
584 return shift ? 31 : (2 << IsQuad) - 1;
585 case NeonTypeFlags::Int64:
Kevin Qincaac85e2013-11-14 03:29:16 +0000586 case NeonTypeFlags::Poly64:
Bob Wilson98bc98c2011-11-08 01:16:11 +0000587 return shift ? 63 : (1 << IsQuad) - 1;
Kevin Qinfb79d7f2013-12-10 06:49:01 +0000588 case NeonTypeFlags::Poly128:
589 return shift ? 127 : (1 << IsQuad) - 1;
Bob Wilson98bc98c2011-11-08 01:16:11 +0000590 case NeonTypeFlags::Float16:
591 assert(!shift && "cannot shift float types!");
592 return (4 << IsQuad) - 1;
593 case NeonTypeFlags::Float32:
594 assert(!shift && "cannot shift float types!");
595 return (2 << IsQuad) - 1;
Tim Northover2fe823a2013-08-01 09:23:19 +0000596 case NeonTypeFlags::Float64:
597 assert(!shift && "cannot shift float types!");
598 return (1 << IsQuad) - 1;
Nate Begeman91e1fea2010-06-14 05:21:25 +0000599 }
David Blaikie8a40f702012-01-17 06:56:22 +0000600 llvm_unreachable("Invalid NeonTypeFlag!");
Nate Begeman91e1fea2010-06-14 05:21:25 +0000601}
602
Bob Wilsone4d77232011-11-08 05:04:11 +0000603/// getNeonEltType - Return the QualType corresponding to the elements of
604/// the vector type specified by the NeonTypeFlags. This is used to check
605/// the pointer arguments for Neon load/store intrinsics.
Kevin Qincaac85e2013-11-14 03:29:16 +0000606static QualType getNeonEltType(NeonTypeFlags Flags, ASTContext &Context,
Tim Northovera2ee4332014-03-29 15:09:45 +0000607 bool IsPolyUnsigned, bool IsInt64Long) {
Bob Wilsone4d77232011-11-08 05:04:11 +0000608 switch (Flags.getEltType()) {
609 case NeonTypeFlags::Int8:
610 return Flags.isUnsigned() ? Context.UnsignedCharTy : Context.SignedCharTy;
611 case NeonTypeFlags::Int16:
612 return Flags.isUnsigned() ? Context.UnsignedShortTy : Context.ShortTy;
613 case NeonTypeFlags::Int32:
614 return Flags.isUnsigned() ? Context.UnsignedIntTy : Context.IntTy;
615 case NeonTypeFlags::Int64:
Tim Northovera2ee4332014-03-29 15:09:45 +0000616 if (IsInt64Long)
Kevin Qinad64f6d2014-02-24 02:45:03 +0000617 return Flags.isUnsigned() ? Context.UnsignedLongTy : Context.LongTy;
618 else
619 return Flags.isUnsigned() ? Context.UnsignedLongLongTy
620 : Context.LongLongTy;
Bob Wilsone4d77232011-11-08 05:04:11 +0000621 case NeonTypeFlags::Poly8:
Tim Northovera2ee4332014-03-29 15:09:45 +0000622 return IsPolyUnsigned ? Context.UnsignedCharTy : Context.SignedCharTy;
Bob Wilsone4d77232011-11-08 05:04:11 +0000623 case NeonTypeFlags::Poly16:
Tim Northovera2ee4332014-03-29 15:09:45 +0000624 return IsPolyUnsigned ? Context.UnsignedShortTy : Context.ShortTy;
Kevin Qincaac85e2013-11-14 03:29:16 +0000625 case NeonTypeFlags::Poly64:
Kevin Qin78b86532015-05-14 08:18:05 +0000626 if (IsInt64Long)
627 return Context.UnsignedLongTy;
628 else
629 return Context.UnsignedLongLongTy;
Kevin Qinfb79d7f2013-12-10 06:49:01 +0000630 case NeonTypeFlags::Poly128:
631 break;
Bob Wilsone4d77232011-11-08 05:04:11 +0000632 case NeonTypeFlags::Float16:
Kevin Qincaac85e2013-11-14 03:29:16 +0000633 return Context.HalfTy;
Bob Wilsone4d77232011-11-08 05:04:11 +0000634 case NeonTypeFlags::Float32:
635 return Context.FloatTy;
Tim Northover2fe823a2013-08-01 09:23:19 +0000636 case NeonTypeFlags::Float64:
637 return Context.DoubleTy;
Bob Wilsone4d77232011-11-08 05:04:11 +0000638 }
David Blaikie8a40f702012-01-17 06:56:22 +0000639 llvm_unreachable("Invalid NeonTypeFlag!");
Bob Wilsone4d77232011-11-08 05:04:11 +0000640}
641
Tim Northover12670412014-02-19 10:37:05 +0000642bool Sema::CheckNeonBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Tim Northover2fe823a2013-08-01 09:23:19 +0000643 llvm::APSInt Result;
Tim Northover2fe823a2013-08-01 09:23:19 +0000644 uint64_t mask = 0;
645 unsigned TV = 0;
646 int PtrArgNum = -1;
647 bool HasConstPtr = false;
648 switch (BuiltinID) {
Tim Northover12670412014-02-19 10:37:05 +0000649#define GET_NEON_OVERLOAD_CHECK
Tim Northover2fe823a2013-08-01 09:23:19 +0000650#include "clang/Basic/arm_neon.inc"
Tim Northover12670412014-02-19 10:37:05 +0000651#undef GET_NEON_OVERLOAD_CHECK
Tim Northover2fe823a2013-08-01 09:23:19 +0000652 }
653
654 // For NEON intrinsics which are overloaded on vector element type, validate
655 // the immediate which specifies which variant to emit.
Tim Northover12670412014-02-19 10:37:05 +0000656 unsigned ImmArg = TheCall->getNumArgs()-1;
Tim Northover2fe823a2013-08-01 09:23:19 +0000657 if (mask) {
658 if (SemaBuiltinConstantArg(TheCall, ImmArg, Result))
659 return true;
660
661 TV = Result.getLimitedValue(64);
662 if ((TV > 63) || (mask & (1ULL << TV)) == 0)
663 return Diag(TheCall->getLocStart(), diag::err_invalid_neon_type_code)
Tim Northover12670412014-02-19 10:37:05 +0000664 << TheCall->getArg(ImmArg)->getSourceRange();
Tim Northover2fe823a2013-08-01 09:23:19 +0000665 }
666
667 if (PtrArgNum >= 0) {
668 // Check that pointer arguments have the specified type.
669 Expr *Arg = TheCall->getArg(PtrArgNum);
670 if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg))
671 Arg = ICE->getSubExpr();
672 ExprResult RHS = DefaultFunctionArrayLvalueConversion(Arg);
673 QualType RHSTy = RHS.get()->getType();
Tim Northover12670412014-02-19 10:37:05 +0000674
Tim Northovera2ee4332014-03-29 15:09:45 +0000675 llvm::Triple::ArchType Arch = Context.getTargetInfo().getTriple().getArch();
Tim Northover40956e62014-07-23 12:32:58 +0000676 bool IsPolyUnsigned = Arch == llvm::Triple::aarch64;
Tim Northovera2ee4332014-03-29 15:09:45 +0000677 bool IsInt64Long =
678 Context.getTargetInfo().getInt64Type() == TargetInfo::SignedLong;
679 QualType EltTy =
680 getNeonEltType(NeonTypeFlags(TV), Context, IsPolyUnsigned, IsInt64Long);
Tim Northover2fe823a2013-08-01 09:23:19 +0000681 if (HasConstPtr)
682 EltTy = EltTy.withConst();
683 QualType LHSTy = Context.getPointerType(EltTy);
684 AssignConvertType ConvTy;
685 ConvTy = CheckSingleAssignmentConstraints(LHSTy, RHS);
686 if (RHS.isInvalid())
687 return true;
688 if (DiagnoseAssignmentResult(ConvTy, Arg->getLocStart(), LHSTy, RHSTy,
689 RHS.get(), AA_Assigning))
690 return true;
691 }
692
693 // For NEON intrinsics which take an immediate value as part of the
694 // instruction, range check them here.
695 unsigned i = 0, l = 0, u = 0;
696 switch (BuiltinID) {
697 default:
698 return false;
Tim Northover12670412014-02-19 10:37:05 +0000699#define GET_NEON_IMMEDIATE_CHECK
Tim Northover2fe823a2013-08-01 09:23:19 +0000700#include "clang/Basic/arm_neon.inc"
Tim Northover12670412014-02-19 10:37:05 +0000701#undef GET_NEON_IMMEDIATE_CHECK
Tim Northover2fe823a2013-08-01 09:23:19 +0000702 }
Tim Northover2fe823a2013-08-01 09:23:19 +0000703
Richard Sandiford28940af2014-04-16 08:47:51 +0000704 return SemaBuiltinConstantArgRange(TheCall, i, l, u + l);
Tim Northover2fe823a2013-08-01 09:23:19 +0000705}
706
Tim Northovera2ee4332014-03-29 15:09:45 +0000707bool Sema::CheckARMBuiltinExclusiveCall(unsigned BuiltinID, CallExpr *TheCall,
708 unsigned MaxWidth) {
Tim Northover6aacd492013-07-16 09:47:53 +0000709 assert((BuiltinID == ARM::BI__builtin_arm_ldrex ||
Tim Northover3acd6bd2014-07-02 12:56:02 +0000710 BuiltinID == ARM::BI__builtin_arm_ldaex ||
Tim Northovera2ee4332014-03-29 15:09:45 +0000711 BuiltinID == ARM::BI__builtin_arm_strex ||
Tim Northover3acd6bd2014-07-02 12:56:02 +0000712 BuiltinID == ARM::BI__builtin_arm_stlex ||
Tim Northover573cbee2014-05-24 12:52:07 +0000713 BuiltinID == AArch64::BI__builtin_arm_ldrex ||
Tim Northover3acd6bd2014-07-02 12:56:02 +0000714 BuiltinID == AArch64::BI__builtin_arm_ldaex ||
715 BuiltinID == AArch64::BI__builtin_arm_strex ||
716 BuiltinID == AArch64::BI__builtin_arm_stlex) &&
Tim Northover6aacd492013-07-16 09:47:53 +0000717 "unexpected ARM builtin");
Tim Northovera2ee4332014-03-29 15:09:45 +0000718 bool IsLdrex = BuiltinID == ARM::BI__builtin_arm_ldrex ||
Tim Northover3acd6bd2014-07-02 12:56:02 +0000719 BuiltinID == ARM::BI__builtin_arm_ldaex ||
720 BuiltinID == AArch64::BI__builtin_arm_ldrex ||
721 BuiltinID == AArch64::BI__builtin_arm_ldaex;
Tim Northover6aacd492013-07-16 09:47:53 +0000722
723 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
724
725 // Ensure that we have the proper number of arguments.
726 if (checkArgCount(*this, TheCall, IsLdrex ? 1 : 2))
727 return true;
728
729 // Inspect the pointer argument of the atomic builtin. This should always be
730 // a pointer type, whose element is an integral scalar or pointer type.
731 // Because it is a pointer type, we don't have to worry about any implicit
732 // casts here.
733 Expr *PointerArg = TheCall->getArg(IsLdrex ? 0 : 1);
734 ExprResult PointerArgRes = DefaultFunctionArrayLvalueConversion(PointerArg);
735 if (PointerArgRes.isInvalid())
736 return true;
Nikola Smiljanic01a75982014-05-29 10:55:11 +0000737 PointerArg = PointerArgRes.get();
Tim Northover6aacd492013-07-16 09:47:53 +0000738
739 const PointerType *pointerType = PointerArg->getType()->getAs<PointerType>();
740 if (!pointerType) {
741 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
742 << PointerArg->getType() << PointerArg->getSourceRange();
743 return true;
744 }
745
746 // ldrex takes a "const volatile T*" and strex takes a "volatile T*". Our next
747 // task is to insert the appropriate casts into the AST. First work out just
748 // what the appropriate type is.
749 QualType ValType = pointerType->getPointeeType();
750 QualType AddrType = ValType.getUnqualifiedType().withVolatile();
751 if (IsLdrex)
752 AddrType.addConst();
753
754 // Issue a warning if the cast is dodgy.
755 CastKind CastNeeded = CK_NoOp;
756 if (!AddrType.isAtLeastAsQualifiedAs(ValType)) {
757 CastNeeded = CK_BitCast;
758 Diag(DRE->getLocStart(), diag::ext_typecheck_convert_discards_qualifiers)
759 << PointerArg->getType()
760 << Context.getPointerType(AddrType)
761 << AA_Passing << PointerArg->getSourceRange();
762 }
763
764 // Finally, do the cast and replace the argument with the corrected version.
765 AddrType = Context.getPointerType(AddrType);
766 PointerArgRes = ImpCastExprToType(PointerArg, AddrType, CastNeeded);
767 if (PointerArgRes.isInvalid())
768 return true;
Nikola Smiljanic01a75982014-05-29 10:55:11 +0000769 PointerArg = PointerArgRes.get();
Tim Northover6aacd492013-07-16 09:47:53 +0000770
771 TheCall->setArg(IsLdrex ? 0 : 1, PointerArg);
772
773 // In general, we allow ints, floats and pointers to be loaded and stored.
774 if (!ValType->isIntegerType() && !ValType->isAnyPointerType() &&
775 !ValType->isBlockPointerType() && !ValType->isFloatingType()) {
776 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intfltptr)
777 << PointerArg->getType() << PointerArg->getSourceRange();
778 return true;
779 }
780
781 // But ARM doesn't have instructions to deal with 128-bit versions.
Tim Northovera2ee4332014-03-29 15:09:45 +0000782 if (Context.getTypeSize(ValType) > MaxWidth) {
783 assert(MaxWidth == 64 && "Diagnostic unexpectedly inaccurate");
Tim Northover6aacd492013-07-16 09:47:53 +0000784 Diag(DRE->getLocStart(), diag::err_atomic_exclusive_builtin_pointer_size)
785 << PointerArg->getType() << PointerArg->getSourceRange();
786 return true;
787 }
788
789 switch (ValType.getObjCLifetime()) {
790 case Qualifiers::OCL_None:
791 case Qualifiers::OCL_ExplicitNone:
792 // okay
793 break;
794
795 case Qualifiers::OCL_Weak:
796 case Qualifiers::OCL_Strong:
797 case Qualifiers::OCL_Autoreleasing:
798 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
799 << ValType << PointerArg->getSourceRange();
800 return true;
801 }
802
803
804 if (IsLdrex) {
805 TheCall->setType(ValType);
806 return false;
807 }
808
809 // Initialize the argument to be stored.
810 ExprResult ValArg = TheCall->getArg(0);
811 InitializedEntity Entity = InitializedEntity::InitializeParameter(
812 Context, ValType, /*consume*/ false);
813 ValArg = PerformCopyInitialization(Entity, SourceLocation(), ValArg);
814 if (ValArg.isInvalid())
815 return true;
Tim Northover6aacd492013-07-16 09:47:53 +0000816 TheCall->setArg(0, ValArg.get());
Tim Northover58d2bb12013-10-29 12:32:58 +0000817
818 // __builtin_arm_strex always returns an int. It's marked as such in the .def,
819 // but the custom checker bypasses all default analysis.
820 TheCall->setType(Context.IntTy);
Tim Northover6aacd492013-07-16 09:47:53 +0000821 return false;
822}
823
Nate Begeman4904e322010-06-08 02:47:44 +0000824bool Sema::CheckARMBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Nate Begeman55483092010-06-09 01:10:23 +0000825 llvm::APSInt Result;
826
Tim Northover6aacd492013-07-16 09:47:53 +0000827 if (BuiltinID == ARM::BI__builtin_arm_ldrex ||
Tim Northover3acd6bd2014-07-02 12:56:02 +0000828 BuiltinID == ARM::BI__builtin_arm_ldaex ||
829 BuiltinID == ARM::BI__builtin_arm_strex ||
830 BuiltinID == ARM::BI__builtin_arm_stlex) {
Tim Northovera2ee4332014-03-29 15:09:45 +0000831 return CheckARMBuiltinExclusiveCall(BuiltinID, TheCall, 64);
Tim Northover6aacd492013-07-16 09:47:53 +0000832 }
833
Yi Kong26d104a2014-08-13 19:18:14 +0000834 if (BuiltinID == ARM::BI__builtin_arm_prefetch) {
835 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 1) ||
836 SemaBuiltinConstantArgRange(TheCall, 2, 0, 1);
837 }
838
Tim Northover12670412014-02-19 10:37:05 +0000839 if (CheckNeonBuiltinFunctionCall(BuiltinID, TheCall))
840 return true;
Nico Weber0e6daef2013-12-26 23:38:39 +0000841
Yi Kong4efadfb2014-07-03 16:01:25 +0000842 // For intrinsics which take an immediate value as part of the instruction,
843 // range check them here.
Nate Begeman91e1fea2010-06-14 05:21:25 +0000844 unsigned i = 0, l = 0, u = 0;
Nate Begemand773fe62010-06-13 04:47:52 +0000845 switch (BuiltinID) {
846 default: return false;
Nate Begeman1194bd22010-07-29 22:48:34 +0000847 case ARM::BI__builtin_arm_ssat: i = 1; l = 1; u = 31; break;
848 case ARM::BI__builtin_arm_usat: i = 1; u = 31; break;
Nate Begemanf568b072010-08-03 21:32:34 +0000849 case ARM::BI__builtin_arm_vcvtr_f:
850 case ARM::BI__builtin_arm_vcvtr_d: i = 1; u = 1; break;
Weiming Zhao87bb4922013-11-12 21:42:50 +0000851 case ARM::BI__builtin_arm_dmb:
Yi Kong4efadfb2014-07-03 16:01:25 +0000852 case ARM::BI__builtin_arm_dsb:
Yi Kong1d268af2014-08-26 12:48:06 +0000853 case ARM::BI__builtin_arm_isb:
854 case ARM::BI__builtin_arm_dbg: l = 0; u = 15; break;
Richard Sandiford28940af2014-04-16 08:47:51 +0000855 }
Nate Begemand773fe62010-06-13 04:47:52 +0000856
Nate Begemanf568b072010-08-03 21:32:34 +0000857 // FIXME: VFP Intrinsics should error if VFP not present.
Richard Sandiford28940af2014-04-16 08:47:51 +0000858 return SemaBuiltinConstantArgRange(TheCall, i, l, u + l);
Anders Carlssonbc4c1072009-08-16 01:56:34 +0000859}
Daniel Dunbardd9b2d12008-10-02 18:44:07 +0000860
Tim Northover573cbee2014-05-24 12:52:07 +0000861bool Sema::CheckAArch64BuiltinFunctionCall(unsigned BuiltinID,
Tim Northovera2ee4332014-03-29 15:09:45 +0000862 CallExpr *TheCall) {
863 llvm::APSInt Result;
864
Tim Northover573cbee2014-05-24 12:52:07 +0000865 if (BuiltinID == AArch64::BI__builtin_arm_ldrex ||
Tim Northover3acd6bd2014-07-02 12:56:02 +0000866 BuiltinID == AArch64::BI__builtin_arm_ldaex ||
867 BuiltinID == AArch64::BI__builtin_arm_strex ||
868 BuiltinID == AArch64::BI__builtin_arm_stlex) {
Tim Northovera2ee4332014-03-29 15:09:45 +0000869 return CheckARMBuiltinExclusiveCall(BuiltinID, TheCall, 128);
870 }
871
Yi Konga5548432014-08-13 19:18:20 +0000872 if (BuiltinID == AArch64::BI__builtin_arm_prefetch) {
873 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 1) ||
874 SemaBuiltinConstantArgRange(TheCall, 2, 0, 2) ||
875 SemaBuiltinConstantArgRange(TheCall, 3, 0, 1) ||
876 SemaBuiltinConstantArgRange(TheCall, 4, 0, 1);
877 }
878
Tim Northovera2ee4332014-03-29 15:09:45 +0000879 if (CheckNeonBuiltinFunctionCall(BuiltinID, TheCall))
880 return true;
881
Yi Kong19a29ac2014-07-17 10:52:06 +0000882 // For intrinsics which take an immediate value as part of the instruction,
883 // range check them here.
884 unsigned i = 0, l = 0, u = 0;
885 switch (BuiltinID) {
886 default: return false;
887 case AArch64::BI__builtin_arm_dmb:
888 case AArch64::BI__builtin_arm_dsb:
889 case AArch64::BI__builtin_arm_isb: l = 0; u = 15; break;
890 }
891
Yi Kong19a29ac2014-07-17 10:52:06 +0000892 return SemaBuiltinConstantArgRange(TheCall, i, l, u + l);
Tim Northovera2ee4332014-03-29 15:09:45 +0000893}
894
Simon Atanasyanecedf3d2012-07-08 09:30:00 +0000895bool Sema::CheckMipsBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
896 unsigned i = 0, l = 0, u = 0;
897 switch (BuiltinID) {
898 default: return false;
899 case Mips::BI__builtin_mips_wrdsp: i = 1; l = 0; u = 63; break;
900 case Mips::BI__builtin_mips_rddsp: i = 0; l = 0; u = 63; break;
Simon Atanasyan8f06f2f2012-08-27 12:29:20 +0000901 case Mips::BI__builtin_mips_append: i = 2; l = 0; u = 31; break;
902 case Mips::BI__builtin_mips_balign: i = 2; l = 0; u = 3; break;
903 case Mips::BI__builtin_mips_precr_sra_ph_w: i = 2; l = 0; u = 31; break;
904 case Mips::BI__builtin_mips_precr_sra_r_ph_w: i = 2; l = 0; u = 31; break;
905 case Mips::BI__builtin_mips_prepend: i = 2; l = 0; u = 31; break;
Richard Sandiford28940af2014-04-16 08:47:51 +0000906 }
Simon Atanasyanecedf3d2012-07-08 09:30:00 +0000907
Richard Sandiford28940af2014-04-16 08:47:51 +0000908 return SemaBuiltinConstantArgRange(TheCall, i, l, u);
Simon Atanasyanecedf3d2012-07-08 09:30:00 +0000909}
910
Kit Bartone50adcb2015-03-30 19:40:59 +0000911bool Sema::CheckPPCBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
912 unsigned i = 0, l = 0, u = 0;
Nemanja Ivanovic239eec72015-04-09 23:58:16 +0000913 bool Is64BitBltin = BuiltinID == PPC::BI__builtin_divde ||
914 BuiltinID == PPC::BI__builtin_divdeu ||
915 BuiltinID == PPC::BI__builtin_bpermd;
916 bool IsTarget64Bit = Context.getTargetInfo()
917 .getTypeWidth(Context
918 .getTargetInfo()
919 .getIntPtrType()) == 64;
920 bool IsBltinExtDiv = BuiltinID == PPC::BI__builtin_divwe ||
921 BuiltinID == PPC::BI__builtin_divweu ||
922 BuiltinID == PPC::BI__builtin_divde ||
923 BuiltinID == PPC::BI__builtin_divdeu;
924
925 if (Is64BitBltin && !IsTarget64Bit)
926 return Diag(TheCall->getLocStart(), diag::err_64_bit_builtin_32_bit_tgt)
927 << TheCall->getSourceRange();
928
929 if ((IsBltinExtDiv && !Context.getTargetInfo().hasFeature("extdiv")) ||
930 (BuiltinID == PPC::BI__builtin_bpermd &&
931 !Context.getTargetInfo().hasFeature("bpermd")))
932 return Diag(TheCall->getLocStart(), diag::err_ppc_builtin_only_on_pwr7)
933 << TheCall->getSourceRange();
934
Kit Bartone50adcb2015-03-30 19:40:59 +0000935 switch (BuiltinID) {
936 default: return false;
937 case PPC::BI__builtin_altivec_crypto_vshasigmaw:
938 case PPC::BI__builtin_altivec_crypto_vshasigmad:
939 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 1) ||
940 SemaBuiltinConstantArgRange(TheCall, 2, 0, 15);
941 case PPC::BI__builtin_tbegin:
942 case PPC::BI__builtin_tend: i = 0; l = 0; u = 1; break;
943 case PPC::BI__builtin_tsr: i = 0; l = 0; u = 7; break;
944 case PPC::BI__builtin_tabortwc:
945 case PPC::BI__builtin_tabortdc: i = 0; l = 0; u = 31; break;
946 case PPC::BI__builtin_tabortwci:
947 case PPC::BI__builtin_tabortdci:
948 return SemaBuiltinConstantArgRange(TheCall, 0, 0, 31) ||
949 SemaBuiltinConstantArgRange(TheCall, 2, 0, 31);
950 }
951 return SemaBuiltinConstantArgRange(TheCall, i, l, u);
952}
953
Ulrich Weigand3a610eb2015-04-01 12:54:25 +0000954bool Sema::CheckSystemZBuiltinFunctionCall(unsigned BuiltinID,
955 CallExpr *TheCall) {
956 if (BuiltinID == SystemZ::BI__builtin_tabort) {
957 Expr *Arg = TheCall->getArg(0);
958 llvm::APSInt AbortCode(32);
959 if (Arg->isIntegerConstantExpr(AbortCode, Context) &&
960 AbortCode.getSExtValue() >= 0 && AbortCode.getSExtValue() < 256)
961 return Diag(Arg->getLocStart(), diag::err_systemz_invalid_tabort_code)
962 << Arg->getSourceRange();
963 }
964
Ulrich Weigand5722c0f2015-05-05 19:36:42 +0000965 // For intrinsics which take an immediate value as part of the instruction,
966 // range check them here.
967 unsigned i = 0, l = 0, u = 0;
968 switch (BuiltinID) {
969 default: return false;
970 case SystemZ::BI__builtin_s390_lcbb: i = 1; l = 0; u = 15; break;
971 case SystemZ::BI__builtin_s390_verimb:
972 case SystemZ::BI__builtin_s390_verimh:
973 case SystemZ::BI__builtin_s390_verimf:
974 case SystemZ::BI__builtin_s390_verimg: i = 3; l = 0; u = 255; break;
975 case SystemZ::BI__builtin_s390_vfaeb:
976 case SystemZ::BI__builtin_s390_vfaeh:
977 case SystemZ::BI__builtin_s390_vfaef:
978 case SystemZ::BI__builtin_s390_vfaebs:
979 case SystemZ::BI__builtin_s390_vfaehs:
980 case SystemZ::BI__builtin_s390_vfaefs:
981 case SystemZ::BI__builtin_s390_vfaezb:
982 case SystemZ::BI__builtin_s390_vfaezh:
983 case SystemZ::BI__builtin_s390_vfaezf:
984 case SystemZ::BI__builtin_s390_vfaezbs:
985 case SystemZ::BI__builtin_s390_vfaezhs:
986 case SystemZ::BI__builtin_s390_vfaezfs: i = 2; l = 0; u = 15; break;
987 case SystemZ::BI__builtin_s390_vfidb:
988 return SemaBuiltinConstantArgRange(TheCall, 1, 0, 15) ||
989 SemaBuiltinConstantArgRange(TheCall, 2, 0, 15);
990 case SystemZ::BI__builtin_s390_vftcidb: i = 1; l = 0; u = 4095; break;
991 case SystemZ::BI__builtin_s390_vlbb: i = 1; l = 0; u = 15; break;
992 case SystemZ::BI__builtin_s390_vpdi: i = 2; l = 0; u = 15; break;
993 case SystemZ::BI__builtin_s390_vsldb: i = 2; l = 0; u = 15; break;
994 case SystemZ::BI__builtin_s390_vstrcb:
995 case SystemZ::BI__builtin_s390_vstrch:
996 case SystemZ::BI__builtin_s390_vstrcf:
997 case SystemZ::BI__builtin_s390_vstrczb:
998 case SystemZ::BI__builtin_s390_vstrczh:
999 case SystemZ::BI__builtin_s390_vstrczf:
1000 case SystemZ::BI__builtin_s390_vstrcbs:
1001 case SystemZ::BI__builtin_s390_vstrchs:
1002 case SystemZ::BI__builtin_s390_vstrcfs:
1003 case SystemZ::BI__builtin_s390_vstrczbs:
1004 case SystemZ::BI__builtin_s390_vstrczhs:
1005 case SystemZ::BI__builtin_s390_vstrczfs: i = 3; l = 0; u = 15; break;
1006 }
1007 return SemaBuiltinConstantArgRange(TheCall, i, l, u);
Ulrich Weigand3a610eb2015-04-01 12:54:25 +00001008}
1009
Warren Hunt20e4a5d2014-02-21 23:08:53 +00001010bool Sema::CheckX86BuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
Craig Topperdd84ec52014-12-27 07:00:08 +00001011 unsigned i = 0, l = 0, u = 0;
Warren Hunt20e4a5d2014-02-21 23:08:53 +00001012 switch (BuiltinID) {
Craig Topperdd84ec52014-12-27 07:00:08 +00001013 default: return false;
1014 case X86::BI_mm_prefetch: i = 1; l = 0; u = 3; break;
Craig Topper16015252015-01-31 06:31:23 +00001015 case X86::BI__builtin_ia32_sha1rnds4: i = 2, l = 0; u = 3; break;
Craig Topper1a8b0472015-01-31 08:57:52 +00001016 case X86::BI__builtin_ia32_vpermil2pd:
1017 case X86::BI__builtin_ia32_vpermil2pd256:
1018 case X86::BI__builtin_ia32_vpermil2ps:
1019 case X86::BI__builtin_ia32_vpermil2ps256: i = 3, l = 0; u = 3; break;
Craig Topper95b0d732015-01-25 23:30:05 +00001020 case X86::BI__builtin_ia32_cmpb128_mask:
1021 case X86::BI__builtin_ia32_cmpw128_mask:
1022 case X86::BI__builtin_ia32_cmpd128_mask:
1023 case X86::BI__builtin_ia32_cmpq128_mask:
1024 case X86::BI__builtin_ia32_cmpb256_mask:
1025 case X86::BI__builtin_ia32_cmpw256_mask:
1026 case X86::BI__builtin_ia32_cmpd256_mask:
1027 case X86::BI__builtin_ia32_cmpq256_mask:
1028 case X86::BI__builtin_ia32_cmpb512_mask:
1029 case X86::BI__builtin_ia32_cmpw512_mask:
1030 case X86::BI__builtin_ia32_cmpd512_mask:
1031 case X86::BI__builtin_ia32_cmpq512_mask:
1032 case X86::BI__builtin_ia32_ucmpb128_mask:
1033 case X86::BI__builtin_ia32_ucmpw128_mask:
1034 case X86::BI__builtin_ia32_ucmpd128_mask:
1035 case X86::BI__builtin_ia32_ucmpq128_mask:
1036 case X86::BI__builtin_ia32_ucmpb256_mask:
1037 case X86::BI__builtin_ia32_ucmpw256_mask:
1038 case X86::BI__builtin_ia32_ucmpd256_mask:
1039 case X86::BI__builtin_ia32_ucmpq256_mask:
1040 case X86::BI__builtin_ia32_ucmpb512_mask:
1041 case X86::BI__builtin_ia32_ucmpw512_mask:
1042 case X86::BI__builtin_ia32_ucmpd512_mask:
1043 case X86::BI__builtin_ia32_ucmpq512_mask: i = 2; l = 0; u = 7; break;
Craig Topper16015252015-01-31 06:31:23 +00001044 case X86::BI__builtin_ia32_roundps:
1045 case X86::BI__builtin_ia32_roundpd:
1046 case X86::BI__builtin_ia32_roundps256:
1047 case X86::BI__builtin_ia32_roundpd256: i = 1, l = 0; u = 15; break;
1048 case X86::BI__builtin_ia32_roundss:
1049 case X86::BI__builtin_ia32_roundsd: i = 2, l = 0; u = 15; break;
1050 case X86::BI__builtin_ia32_cmpps:
1051 case X86::BI__builtin_ia32_cmpss:
1052 case X86::BI__builtin_ia32_cmppd:
1053 case X86::BI__builtin_ia32_cmpsd:
1054 case X86::BI__builtin_ia32_cmpps256:
1055 case X86::BI__builtin_ia32_cmppd256:
1056 case X86::BI__builtin_ia32_cmpps512_mask:
1057 case X86::BI__builtin_ia32_cmppd512_mask: i = 2; l = 0; u = 31; break;
Craig Topper8dd7d0d2015-02-13 06:04:48 +00001058 case X86::BI__builtin_ia32_vpcomub:
1059 case X86::BI__builtin_ia32_vpcomuw:
1060 case X86::BI__builtin_ia32_vpcomud:
1061 case X86::BI__builtin_ia32_vpcomuq:
1062 case X86::BI__builtin_ia32_vpcomb:
1063 case X86::BI__builtin_ia32_vpcomw:
1064 case X86::BI__builtin_ia32_vpcomd:
1065 case X86::BI__builtin_ia32_vpcomq: i = 2; l = 0; u = 7; break;
Warren Hunt20e4a5d2014-02-21 23:08:53 +00001066 }
Craig Topperdd84ec52014-12-27 07:00:08 +00001067 return SemaBuiltinConstantArgRange(TheCall, i, l, u);
Warren Hunt20e4a5d2014-02-21 23:08:53 +00001068}
1069
Richard Smith55ce3522012-06-25 20:30:08 +00001070/// Given a FunctionDecl's FormatAttr, attempts to populate the FomatStringInfo
1071/// parameter with the FormatAttr's correct format_idx and firstDataArg.
1072/// Returns true when the format fits the function and the FormatStringInfo has
1073/// been populated.
1074bool Sema::getFormatStringInfo(const FormatAttr *Format, bool IsCXXMember,
1075 FormatStringInfo *FSI) {
1076 FSI->HasVAListArg = Format->getFirstArg() == 0;
1077 FSI->FormatIdx = Format->getFormatIdx() - 1;
1078 FSI->FirstDataArg = FSI->HasVAListArg ? 0 : Format->getFirstArg() - 1;
Anders Carlssonbc4c1072009-08-16 01:56:34 +00001079
Richard Smith55ce3522012-06-25 20:30:08 +00001080 // The way the format attribute works in GCC, the implicit this argument
1081 // of member functions is counted. However, it doesn't appear in our own
1082 // lists, so decrement format_idx in that case.
1083 if (IsCXXMember) {
1084 if(FSI->FormatIdx == 0)
1085 return false;
1086 --FSI->FormatIdx;
1087 if (FSI->FirstDataArg != 0)
1088 --FSI->FirstDataArg;
1089 }
1090 return true;
1091}
Mike Stump11289f42009-09-09 15:08:12 +00001092
Ted Kremenekef9e7f82014-01-22 06:10:28 +00001093/// Checks if a the given expression evaluates to null.
1094///
1095/// \brief Returns true if the value evaluates to null.
1096static bool CheckNonNullExpr(Sema &S,
1097 const Expr *Expr) {
Ted Kremeneka146db32014-01-17 06:24:47 +00001098 // As a special case, transparent unions initialized with zero are
1099 // considered null for the purposes of the nonnull attribute.
Ted Kremenekef9e7f82014-01-22 06:10:28 +00001100 if (const RecordType *UT = Expr->getType()->getAsUnionType()) {
Ted Kremeneka146db32014-01-17 06:24:47 +00001101 if (UT->getDecl()->hasAttr<TransparentUnionAttr>())
1102 if (const CompoundLiteralExpr *CLE =
Ted Kremenekef9e7f82014-01-22 06:10:28 +00001103 dyn_cast<CompoundLiteralExpr>(Expr))
Ted Kremeneka146db32014-01-17 06:24:47 +00001104 if (const InitListExpr *ILE =
1105 dyn_cast<InitListExpr>(CLE->getInitializer()))
Ted Kremenekef9e7f82014-01-22 06:10:28 +00001106 Expr = ILE->getInit(0);
Ted Kremeneka146db32014-01-17 06:24:47 +00001107 }
1108
1109 bool Result;
Artyom Skrobov9f213442014-01-24 11:10:39 +00001110 return (!Expr->isValueDependent() &&
1111 Expr->EvaluateAsBooleanCondition(Result, S.Context) &&
1112 !Result);
Ted Kremenekef9e7f82014-01-22 06:10:28 +00001113}
1114
1115static void CheckNonNullArgument(Sema &S,
1116 const Expr *ArgExpr,
1117 SourceLocation CallSiteLoc) {
1118 if (CheckNonNullExpr(S, ArgExpr))
Ted Kremeneka146db32014-01-17 06:24:47 +00001119 S.Diag(CallSiteLoc, diag::warn_null_arg) << ArgExpr->getSourceRange();
1120}
1121
Fariborz Jahanianfba4fe62014-09-11 19:13:23 +00001122bool Sema::GetFormatNSStringIdx(const FormatAttr *Format, unsigned &Idx) {
1123 FormatStringInfo FSI;
1124 if ((GetFormatStringType(Format) == FST_NSString) &&
1125 getFormatStringInfo(Format, false, &FSI)) {
1126 Idx = FSI.FormatIdx;
1127 return true;
1128 }
1129 return false;
1130}
Fariborz Jahanian6485fe42014-09-09 23:10:54 +00001131/// \brief Diagnose use of %s directive in an NSString which is being passed
1132/// as formatting string to formatting method.
1133static void
1134DiagnoseCStringFormatDirectiveInCFAPI(Sema &S,
1135 const NamedDecl *FDecl,
1136 Expr **Args,
1137 unsigned NumArgs) {
Fariborz Jahanianfba4fe62014-09-11 19:13:23 +00001138 unsigned Idx = 0;
1139 bool Format = false;
Fariborz Jahanian6485fe42014-09-09 23:10:54 +00001140 ObjCStringFormatFamily SFFamily = FDecl->getObjCFStringFormattingFamily();
1141 if (SFFamily == ObjCStringFormatFamily::SFF_CFString) {
Fariborz Jahanianfba4fe62014-09-11 19:13:23 +00001142 Idx = 2;
1143 Format = true;
1144 }
1145 else
1146 for (const auto *I : FDecl->specific_attrs<FormatAttr>()) {
1147 if (S.GetFormatNSStringIdx(I, Idx)) {
1148 Format = true;
1149 break;
1150 }
Fariborz Jahanian6485fe42014-09-09 23:10:54 +00001151 }
Fariborz Jahanianfba4fe62014-09-11 19:13:23 +00001152 if (!Format || NumArgs <= Idx)
1153 return;
1154 const Expr *FormatExpr = Args[Idx];
1155 if (const CStyleCastExpr *CSCE = dyn_cast<CStyleCastExpr>(FormatExpr))
1156 FormatExpr = CSCE->getSubExpr();
1157 const StringLiteral *FormatString;
1158 if (const ObjCStringLiteral *OSL =
1159 dyn_cast<ObjCStringLiteral>(FormatExpr->IgnoreParenImpCasts()))
1160 FormatString = OSL->getString();
1161 else
1162 FormatString = dyn_cast<StringLiteral>(FormatExpr->IgnoreParenImpCasts());
1163 if (!FormatString)
1164 return;
1165 if (S.FormatStringHasSArg(FormatString)) {
1166 S.Diag(FormatExpr->getExprLoc(), diag::warn_objc_cdirective_format_string)
1167 << "%s" << 1 << 1;
1168 S.Diag(FDecl->getLocation(), diag::note_entity_declared_at)
1169 << FDecl->getDeclName();
Fariborz Jahanian6485fe42014-09-09 23:10:54 +00001170 }
1171}
1172
Ted Kremenek2bc73332014-01-17 06:24:43 +00001173static void CheckNonNullArguments(Sema &S,
Ted Kremeneka146db32014-01-17 06:24:47 +00001174 const NamedDecl *FDecl,
Richard Smith588bd9b2014-08-27 04:59:42 +00001175 ArrayRef<const Expr *> Args,
Ted Kremenek2bc73332014-01-17 06:24:43 +00001176 SourceLocation CallSiteLoc) {
Ted Kremenek9aedc152014-01-17 06:24:56 +00001177 // Check the attributes attached to the method/function itself.
Richard Smith588bd9b2014-08-27 04:59:42 +00001178 llvm::SmallBitVector NonNullArgs;
Aaron Ballmanbe22bcb2014-03-10 17:08:28 +00001179 for (const auto *NonNull : FDecl->specific_attrs<NonNullAttr>()) {
Richard Smith588bd9b2014-08-27 04:59:42 +00001180 if (!NonNull->args_size()) {
1181 // Easy case: all pointer arguments are nonnull.
1182 for (const auto *Arg : Args)
Hal Finkelee90a222014-09-26 05:04:30 +00001183 if (S.isValidPointerAttrType(Arg->getType()))
Richard Smith588bd9b2014-08-27 04:59:42 +00001184 CheckNonNullArgument(S, Arg, CallSiteLoc);
1185 return;
1186 }
1187
1188 for (unsigned Val : NonNull->args()) {
1189 if (Val >= Args.size())
1190 continue;
1191 if (NonNullArgs.empty())
1192 NonNullArgs.resize(Args.size());
1193 NonNullArgs.set(Val);
1194 }
Ted Kremenek2bc73332014-01-17 06:24:43 +00001195 }
Ted Kremenek9aedc152014-01-17 06:24:56 +00001196
1197 // Check the attributes on the parameters.
1198 ArrayRef<ParmVarDecl*> parms;
1199 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(FDecl))
1200 parms = FD->parameters();
1201 else if (const ObjCMethodDecl *MD = dyn_cast<ObjCMethodDecl>(FDecl))
1202 parms = MD->parameters();
1203
Richard Smith588bd9b2014-08-27 04:59:42 +00001204 unsigned ArgIndex = 0;
Ted Kremenek9aedc152014-01-17 06:24:56 +00001205 for (ArrayRef<ParmVarDecl*>::iterator I = parms.begin(), E = parms.end();
Richard Smith588bd9b2014-08-27 04:59:42 +00001206 I != E; ++I, ++ArgIndex) {
Ted Kremenek9aedc152014-01-17 06:24:56 +00001207 const ParmVarDecl *PVD = *I;
Richard Smith588bd9b2014-08-27 04:59:42 +00001208 if (PVD->hasAttr<NonNullAttr>() ||
1209 (ArgIndex < NonNullArgs.size() && NonNullArgs[ArgIndex]))
1210 CheckNonNullArgument(S, Args[ArgIndex], CallSiteLoc);
Ted Kremenek9aedc152014-01-17 06:24:56 +00001211 }
Richard Smith588bd9b2014-08-27 04:59:42 +00001212
1213 // In case this is a variadic call, check any remaining arguments.
1214 for (/**/; ArgIndex < NonNullArgs.size(); ++ArgIndex)
1215 if (NonNullArgs[ArgIndex])
1216 CheckNonNullArgument(S, Args[ArgIndex], CallSiteLoc);
Ted Kremenek2bc73332014-01-17 06:24:43 +00001217}
1218
Richard Smith55ce3522012-06-25 20:30:08 +00001219/// Handles the checks for format strings, non-POD arguments to vararg
1220/// functions, and NULL arguments passed to non-NULL parameters.
Alp Toker9cacbab2014-01-20 20:26:09 +00001221void Sema::checkCall(NamedDecl *FDecl, ArrayRef<const Expr *> Args,
1222 unsigned NumParams, bool IsMemberFunction,
1223 SourceLocation Loc, SourceRange Range,
Richard Smith55ce3522012-06-25 20:30:08 +00001224 VariadicCallType CallType) {
Richard Smithd7293d72013-08-05 18:49:43 +00001225 // FIXME: We should check as much as we can in the template definition.
Jordan Rose3c14b232012-10-02 01:49:54 +00001226 if (CurContext->isDependentContext())
1227 return;
Daniel Dunbardd9b2d12008-10-02 18:44:07 +00001228
Ted Kremenekb8176da2010-09-09 04:33:05 +00001229 // Printf and scanf checking.
Richard Smithd7293d72013-08-05 18:49:43 +00001230 llvm::SmallBitVector CheckedVarArgs;
1231 if (FDecl) {
Aaron Ballmanbe22bcb2014-03-10 17:08:28 +00001232 for (const auto *I : FDecl->specific_attrs<FormatAttr>()) {
Benjamin Kramer989ab8b2013-08-09 09:39:17 +00001233 // Only create vector if there are format attributes.
1234 CheckedVarArgs.resize(Args.size());
1235
Aaron Ballmanbe22bcb2014-03-10 17:08:28 +00001236 CheckFormatArguments(I, Args, IsMemberFunction, CallType, Loc, Range,
Benjamin Kramerf62e81d2013-08-08 11:08:26 +00001237 CheckedVarArgs);
Benjamin Kramer989ab8b2013-08-09 09:39:17 +00001238 }
Richard Smithd7293d72013-08-05 18:49:43 +00001239 }
Richard Smith55ce3522012-06-25 20:30:08 +00001240
1241 // Refuse POD arguments that weren't caught by the format string
1242 // checks above.
Richard Smithd7293d72013-08-05 18:49:43 +00001243 if (CallType != VariadicDoesNotApply) {
Alp Toker9cacbab2014-01-20 20:26:09 +00001244 for (unsigned ArgIdx = NumParams; ArgIdx < Args.size(); ++ArgIdx) {
Ted Kremenek241f1ef2012-10-11 19:06:43 +00001245 // Args[ArgIdx] can be null in malformed code.
Richard Smithd7293d72013-08-05 18:49:43 +00001246 if (const Expr *Arg = Args[ArgIdx]) {
1247 if (CheckedVarArgs.empty() || !CheckedVarArgs[ArgIdx])
1248 checkVariadicArgument(Arg, CallType);
1249 }
Ted Kremenek241f1ef2012-10-11 19:06:43 +00001250 }
Richard Smithd7293d72013-08-05 18:49:43 +00001251 }
Mike Stump11289f42009-09-09 15:08:12 +00001252
Richard Trieu41bc0992013-06-22 00:20:41 +00001253 if (FDecl) {
Richard Smith588bd9b2014-08-27 04:59:42 +00001254 CheckNonNullArguments(*this, FDecl, Args, Loc);
Dmitri Gribenkoe4a5a902012-08-17 00:08:38 +00001255
Richard Trieu41bc0992013-06-22 00:20:41 +00001256 // Type safety checking.
Aaron Ballmanbe22bcb2014-03-10 17:08:28 +00001257 for (const auto *I : FDecl->specific_attrs<ArgumentWithTypeTagAttr>())
1258 CheckArgumentWithTypeTag(I, Args.data());
Dmitri Gribenkoe4a5a902012-08-17 00:08:38 +00001259 }
Richard Smith55ce3522012-06-25 20:30:08 +00001260}
1261
1262/// CheckConstructorCall - Check a constructor call for correctness and safety
1263/// properties not enforced by the C type system.
Dmitri Gribenko765396f2013-01-13 20:46:02 +00001264void Sema::CheckConstructorCall(FunctionDecl *FDecl,
1265 ArrayRef<const Expr *> Args,
Richard Smith55ce3522012-06-25 20:30:08 +00001266 const FunctionProtoType *Proto,
1267 SourceLocation Loc) {
1268 VariadicCallType CallType =
1269 Proto->isVariadic() ? VariadicConstructor : VariadicDoesNotApply;
Alp Toker9cacbab2014-01-20 20:26:09 +00001270 checkCall(FDecl, Args, Proto->getNumParams(),
Richard Smith55ce3522012-06-25 20:30:08 +00001271 /*IsMemberFunction=*/true, Loc, SourceRange(), CallType);
1272}
1273
1274/// CheckFunctionCall - Check a direct function call for various correctness
1275/// and safety properties not strictly enforced by the C type system.
1276bool Sema::CheckFunctionCall(FunctionDecl *FDecl, CallExpr *TheCall,
1277 const FunctionProtoType *Proto) {
Eli Friedman726d11c2012-10-11 00:30:58 +00001278 bool IsMemberOperatorCall = isa<CXXOperatorCallExpr>(TheCall) &&
1279 isa<CXXMethodDecl>(FDecl);
1280 bool IsMemberFunction = isa<CXXMemberCallExpr>(TheCall) ||
1281 IsMemberOperatorCall;
Richard Smith55ce3522012-06-25 20:30:08 +00001282 VariadicCallType CallType = getVariadicCallType(FDecl, Proto,
1283 TheCall->getCallee());
Alp Toker9cacbab2014-01-20 20:26:09 +00001284 unsigned NumParams = Proto ? Proto->getNumParams() : 0;
Eli Friedman726d11c2012-10-11 00:30:58 +00001285 Expr** Args = TheCall->getArgs();
1286 unsigned NumArgs = TheCall->getNumArgs();
Eli Friedmanadf42182012-10-11 00:34:15 +00001287 if (IsMemberOperatorCall) {
Eli Friedman726d11c2012-10-11 00:30:58 +00001288 // If this is a call to a member operator, hide the first argument
1289 // from checkCall.
1290 // FIXME: Our choice of AST representation here is less than ideal.
1291 ++Args;
1292 --NumArgs;
1293 }
Craig Topper8c2a2a02014-08-30 16:55:39 +00001294 checkCall(FDecl, llvm::makeArrayRef(Args, NumArgs), NumParams,
Richard Smith55ce3522012-06-25 20:30:08 +00001295 IsMemberFunction, TheCall->getRParenLoc(),
1296 TheCall->getCallee()->getSourceRange(), CallType);
1297
1298 IdentifierInfo *FnInfo = FDecl->getIdentifier();
1299 // None of the checks below are needed for functions that don't have
1300 // simple names (e.g., C++ conversion functions).
1301 if (!FnInfo)
1302 return false;
Sebastian Redlc215cfc2009-01-19 00:08:26 +00001303
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00001304 CheckAbsoluteValueFunction(TheCall, FDecl, FnInfo);
Fariborz Jahanianfba4fe62014-09-11 19:13:23 +00001305 if (getLangOpts().ObjC1)
1306 DiagnoseCStringFormatDirectiveInCFAPI(*this, FDecl, Args, NumArgs);
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00001307
Anna Zaks22122702012-01-17 00:37:07 +00001308 unsigned CMId = FDecl->getMemoryFunctionKind();
1309 if (CMId == 0)
Anna Zaks201d4892012-01-13 21:52:01 +00001310 return false;
Ted Kremenek6865f772011-08-18 20:55:45 +00001311
Anna Zaks201d4892012-01-13 21:52:01 +00001312 // Handle memory setting and copying functions.
Anna Zaks22122702012-01-17 00:37:07 +00001313 if (CMId == Builtin::BIstrlcpy || CMId == Builtin::BIstrlcat)
Ted Kremenek6865f772011-08-18 20:55:45 +00001314 CheckStrlcpycatArguments(TheCall, FnInfo);
Anna Zaks314cd092012-02-01 19:08:57 +00001315 else if (CMId == Builtin::BIstrncat)
1316 CheckStrncatArguments(TheCall, FnInfo);
Anna Zaks201d4892012-01-13 21:52:01 +00001317 else
Anna Zaks22122702012-01-17 00:37:07 +00001318 CheckMemaccessArguments(TheCall, CMId, FnInfo);
Chandler Carruth53caa4d2011-04-27 07:05:31 +00001319
Anders Carlssonbc4c1072009-08-16 01:56:34 +00001320 return false;
Anders Carlsson98f07902007-08-17 05:31:46 +00001321}
1322
Jean-Daniel Dupas0ae6e672012-01-17 20:03:31 +00001323bool Sema::CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation lbrac,
Dmitri Gribenko1debc462013-05-05 19:42:09 +00001324 ArrayRef<const Expr *> Args) {
Richard Smith55ce3522012-06-25 20:30:08 +00001325 VariadicCallType CallType =
1326 Method->isVariadic() ? VariadicMethod : VariadicDoesNotApply;
Jean-Daniel Dupas0ae6e672012-01-17 20:03:31 +00001327
Dmitri Gribenko1debc462013-05-05 19:42:09 +00001328 checkCall(Method, Args, Method->param_size(),
Richard Smith55ce3522012-06-25 20:30:08 +00001329 /*IsMemberFunction=*/false,
1330 lbrac, Method->getSourceRange(), CallType);
Jean-Daniel Dupas0ae6e672012-01-17 20:03:31 +00001331
1332 return false;
1333}
1334
Richard Trieu664c4c62013-06-20 21:03:13 +00001335bool Sema::CheckPointerCall(NamedDecl *NDecl, CallExpr *TheCall,
1336 const FunctionProtoType *Proto) {
Aaron Ballmanb673c652015-04-23 16:14:19 +00001337 QualType Ty;
1338 if (const auto *V = dyn_cast<VarDecl>(NDecl))
1339 Ty = V->getType();
1340 else if (const auto *F = dyn_cast<FieldDecl>(NDecl))
1341 Ty = F->getType();
1342 else
Anders Carlssonbc4c1072009-08-16 01:56:34 +00001343 return false;
Mike Stump11289f42009-09-09 15:08:12 +00001344
Richard Trieu664c4c62013-06-20 21:03:13 +00001345 if (!Ty->isBlockPointerType() && !Ty->isFunctionPointerType())
Anders Carlssonbc4c1072009-08-16 01:56:34 +00001346 return false;
Mike Stump11289f42009-09-09 15:08:12 +00001347
Richard Trieu664c4c62013-06-20 21:03:13 +00001348 VariadicCallType CallType;
Richard Trieu72ae1732013-06-20 23:21:54 +00001349 if (!Proto || !Proto->isVariadic()) {
Richard Trieu664c4c62013-06-20 21:03:13 +00001350 CallType = VariadicDoesNotApply;
1351 } else if (Ty->isBlockPointerType()) {
1352 CallType = VariadicBlock;
1353 } else { // Ty->isFunctionPointerType()
1354 CallType = VariadicFunction;
1355 }
Alp Toker9cacbab2014-01-20 20:26:09 +00001356 unsigned NumParams = Proto ? Proto->getNumParams() : 0;
Anders Carlssonbc4c1072009-08-16 01:56:34 +00001357
Craig Topper8c2a2a02014-08-30 16:55:39 +00001358 checkCall(NDecl, llvm::makeArrayRef(TheCall->getArgs(),
1359 TheCall->getNumArgs()),
Alp Toker9cacbab2014-01-20 20:26:09 +00001360 NumParams, /*IsMemberFunction=*/false, TheCall->getRParenLoc(),
Richard Smith55ce3522012-06-25 20:30:08 +00001361 TheCall->getCallee()->getSourceRange(), CallType);
Alp Toker9cacbab2014-01-20 20:26:09 +00001362
Anders Carlssonbc4c1072009-08-16 01:56:34 +00001363 return false;
Fariborz Jahanianc1585be2009-05-18 21:05:18 +00001364}
1365
Richard Trieu41bc0992013-06-22 00:20:41 +00001366/// Checks function calls when a FunctionDecl or a NamedDecl is not available,
1367/// such as function pointers returned from functions.
1368bool Sema::CheckOtherCall(CallExpr *TheCall, const FunctionProtoType *Proto) {
Craig Topperc3ec1492014-05-26 06:22:03 +00001369 VariadicCallType CallType = getVariadicCallType(/*FDecl=*/nullptr, Proto,
Richard Trieu41bc0992013-06-22 00:20:41 +00001370 TheCall->getCallee());
Alp Toker9cacbab2014-01-20 20:26:09 +00001371 unsigned NumParams = Proto ? Proto->getNumParams() : 0;
Richard Trieu41bc0992013-06-22 00:20:41 +00001372
Craig Topperc3ec1492014-05-26 06:22:03 +00001373 checkCall(/*FDecl=*/nullptr,
Craig Topper8c2a2a02014-08-30 16:55:39 +00001374 llvm::makeArrayRef(TheCall->getArgs(), TheCall->getNumArgs()),
Alp Toker9cacbab2014-01-20 20:26:09 +00001375 NumParams, /*IsMemberFunction=*/false, TheCall->getRParenLoc(),
Richard Trieu41bc0992013-06-22 00:20:41 +00001376 TheCall->getCallee()->getSourceRange(), CallType);
1377
1378 return false;
1379}
1380
Tim Northovere94a34c2014-03-11 10:49:14 +00001381static bool isValidOrderingForOp(int64_t Ordering, AtomicExpr::AtomicOp Op) {
1382 if (Ordering < AtomicExpr::AO_ABI_memory_order_relaxed ||
1383 Ordering > AtomicExpr::AO_ABI_memory_order_seq_cst)
1384 return false;
1385
1386 switch (Op) {
1387 case AtomicExpr::AO__c11_atomic_init:
1388 llvm_unreachable("There is no ordering argument for an init");
1389
1390 case AtomicExpr::AO__c11_atomic_load:
1391 case AtomicExpr::AO__atomic_load_n:
1392 case AtomicExpr::AO__atomic_load:
1393 return Ordering != AtomicExpr::AO_ABI_memory_order_release &&
1394 Ordering != AtomicExpr::AO_ABI_memory_order_acq_rel;
1395
1396 case AtomicExpr::AO__c11_atomic_store:
1397 case AtomicExpr::AO__atomic_store:
1398 case AtomicExpr::AO__atomic_store_n:
1399 return Ordering != AtomicExpr::AO_ABI_memory_order_consume &&
1400 Ordering != AtomicExpr::AO_ABI_memory_order_acquire &&
1401 Ordering != AtomicExpr::AO_ABI_memory_order_acq_rel;
1402
1403 default:
1404 return true;
1405 }
1406}
1407
Richard Smithfeea8832012-04-12 05:08:17 +00001408ExprResult Sema::SemaAtomicOpsOverloaded(ExprResult TheCallResult,
1409 AtomicExpr::AtomicOp Op) {
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001410 CallExpr *TheCall = cast<CallExpr>(TheCallResult.get());
1411 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001412
Richard Smithfeea8832012-04-12 05:08:17 +00001413 // All these operations take one of the following forms:
1414 enum {
1415 // C __c11_atomic_init(A *, C)
1416 Init,
1417 // C __c11_atomic_load(A *, int)
1418 Load,
1419 // void __atomic_load(A *, CP, int)
1420 Copy,
1421 // C __c11_atomic_add(A *, M, int)
1422 Arithmetic,
1423 // C __atomic_exchange_n(A *, CP, int)
1424 Xchg,
1425 // void __atomic_exchange(A *, C *, CP, int)
1426 GNUXchg,
1427 // bool __c11_atomic_compare_exchange_strong(A *, C *, CP, int, int)
1428 C11CmpXchg,
1429 // bool __atomic_compare_exchange(A *, C *, CP, bool, int, int)
1430 GNUCmpXchg
1431 } Form = Init;
1432 const unsigned NumArgs[] = { 2, 2, 3, 3, 3, 4, 5, 6 };
1433 const unsigned NumVals[] = { 1, 0, 1, 1, 1, 2, 2, 3 };
1434 // where:
1435 // C is an appropriate type,
1436 // A is volatile _Atomic(C) for __c11 builtins and is C for GNU builtins,
1437 // CP is C for __c11 builtins and GNU _n builtins and is C * otherwise,
1438 // M is C if C is an integer, and ptrdiff_t if C is a pointer, and
1439 // the int parameters are for orderings.
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001440
Gabor Horvath98bd0982015-03-16 09:59:54 +00001441 static_assert(AtomicExpr::AO__c11_atomic_init == 0 &&
1442 AtomicExpr::AO__c11_atomic_fetch_xor + 1 ==
1443 AtomicExpr::AO__atomic_load,
1444 "need to update code for modified C11 atomics");
Richard Smithfeea8832012-04-12 05:08:17 +00001445 bool IsC11 = Op >= AtomicExpr::AO__c11_atomic_init &&
1446 Op <= AtomicExpr::AO__c11_atomic_fetch_xor;
1447 bool IsN = Op == AtomicExpr::AO__atomic_load_n ||
1448 Op == AtomicExpr::AO__atomic_store_n ||
1449 Op == AtomicExpr::AO__atomic_exchange_n ||
1450 Op == AtomicExpr::AO__atomic_compare_exchange_n;
1451 bool IsAddSub = false;
1452
1453 switch (Op) {
1454 case AtomicExpr::AO__c11_atomic_init:
1455 Form = Init;
1456 break;
1457
1458 case AtomicExpr::AO__c11_atomic_load:
1459 case AtomicExpr::AO__atomic_load_n:
1460 Form = Load;
1461 break;
1462
1463 case AtomicExpr::AO__c11_atomic_store:
1464 case AtomicExpr::AO__atomic_load:
1465 case AtomicExpr::AO__atomic_store:
1466 case AtomicExpr::AO__atomic_store_n:
1467 Form = Copy;
1468 break;
1469
1470 case AtomicExpr::AO__c11_atomic_fetch_add:
1471 case AtomicExpr::AO__c11_atomic_fetch_sub:
1472 case AtomicExpr::AO__atomic_fetch_add:
1473 case AtomicExpr::AO__atomic_fetch_sub:
1474 case AtomicExpr::AO__atomic_add_fetch:
1475 case AtomicExpr::AO__atomic_sub_fetch:
1476 IsAddSub = true;
1477 // Fall through.
1478 case AtomicExpr::AO__c11_atomic_fetch_and:
1479 case AtomicExpr::AO__c11_atomic_fetch_or:
1480 case AtomicExpr::AO__c11_atomic_fetch_xor:
1481 case AtomicExpr::AO__atomic_fetch_and:
1482 case AtomicExpr::AO__atomic_fetch_or:
1483 case AtomicExpr::AO__atomic_fetch_xor:
Richard Smithd65cee92012-04-13 06:31:38 +00001484 case AtomicExpr::AO__atomic_fetch_nand:
Richard Smithfeea8832012-04-12 05:08:17 +00001485 case AtomicExpr::AO__atomic_and_fetch:
1486 case AtomicExpr::AO__atomic_or_fetch:
1487 case AtomicExpr::AO__atomic_xor_fetch:
Richard Smithd65cee92012-04-13 06:31:38 +00001488 case AtomicExpr::AO__atomic_nand_fetch:
Richard Smithfeea8832012-04-12 05:08:17 +00001489 Form = Arithmetic;
1490 break;
1491
1492 case AtomicExpr::AO__c11_atomic_exchange:
1493 case AtomicExpr::AO__atomic_exchange_n:
1494 Form = Xchg;
1495 break;
1496
1497 case AtomicExpr::AO__atomic_exchange:
1498 Form = GNUXchg;
1499 break;
1500
1501 case AtomicExpr::AO__c11_atomic_compare_exchange_strong:
1502 case AtomicExpr::AO__c11_atomic_compare_exchange_weak:
1503 Form = C11CmpXchg;
1504 break;
1505
1506 case AtomicExpr::AO__atomic_compare_exchange:
1507 case AtomicExpr::AO__atomic_compare_exchange_n:
1508 Form = GNUCmpXchg;
1509 break;
1510 }
1511
1512 // Check we have the right number of arguments.
1513 if (TheCall->getNumArgs() < NumArgs[Form]) {
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001514 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Richard Smithfeea8832012-04-12 05:08:17 +00001515 << 0 << NumArgs[Form] << TheCall->getNumArgs()
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001516 << TheCall->getCallee()->getSourceRange();
1517 return ExprError();
Richard Smithfeea8832012-04-12 05:08:17 +00001518 } else if (TheCall->getNumArgs() > NumArgs[Form]) {
1519 Diag(TheCall->getArg(NumArgs[Form])->getLocStart(),
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001520 diag::err_typecheck_call_too_many_args)
Richard Smithfeea8832012-04-12 05:08:17 +00001521 << 0 << NumArgs[Form] << TheCall->getNumArgs()
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001522 << TheCall->getCallee()->getSourceRange();
1523 return ExprError();
1524 }
1525
Richard Smithfeea8832012-04-12 05:08:17 +00001526 // Inspect the first argument of the atomic operation.
Eli Friedman8d3e43f2011-10-14 22:48:56 +00001527 Expr *Ptr = TheCall->getArg(0);
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001528 Ptr = DefaultFunctionArrayLvalueConversion(Ptr).get();
1529 const PointerType *pointerType = Ptr->getType()->getAs<PointerType>();
1530 if (!pointerType) {
Richard Smithfeea8832012-04-12 05:08:17 +00001531 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001532 << Ptr->getType() << Ptr->getSourceRange();
1533 return ExprError();
1534 }
1535
Richard Smithfeea8832012-04-12 05:08:17 +00001536 // For a __c11 builtin, this should be a pointer to an _Atomic type.
1537 QualType AtomTy = pointerType->getPointeeType(); // 'A'
1538 QualType ValType = AtomTy; // 'C'
1539 if (IsC11) {
1540 if (!AtomTy->isAtomicType()) {
1541 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic)
1542 << Ptr->getType() << Ptr->getSourceRange();
1543 return ExprError();
1544 }
Richard Smithe00921a2012-09-15 06:09:58 +00001545 if (AtomTy.isConstQualified()) {
1546 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_non_const_atomic)
1547 << Ptr->getType() << Ptr->getSourceRange();
1548 return ExprError();
1549 }
Richard Smithfeea8832012-04-12 05:08:17 +00001550 ValType = AtomTy->getAs<AtomicType>()->getValueType();
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001551 }
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001552
Richard Smithfeea8832012-04-12 05:08:17 +00001553 // For an arithmetic operation, the implied arithmetic must be well-formed.
1554 if (Form == Arithmetic) {
1555 // gcc does not enforce these rules for GNU atomics, but we do so for sanity.
1556 if (IsAddSub && !ValType->isIntegerType() && !ValType->isPointerType()) {
1557 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
1558 << IsC11 << Ptr->getType() << Ptr->getSourceRange();
1559 return ExprError();
1560 }
1561 if (!IsAddSub && !ValType->isIntegerType()) {
1562 Diag(DRE->getLocStart(), diag::err_atomic_op_bitwise_needs_atomic_int)
1563 << IsC11 << Ptr->getType() << Ptr->getSourceRange();
1564 return ExprError();
1565 }
David Majnemere85cff82015-01-28 05:48:06 +00001566 if (IsC11 && ValType->isPointerType() &&
1567 RequireCompleteType(Ptr->getLocStart(), ValType->getPointeeType(),
1568 diag::err_incomplete_type)) {
1569 return ExprError();
1570 }
Richard Smithfeea8832012-04-12 05:08:17 +00001571 } else if (IsN && !ValType->isIntegerType() && !ValType->isPointerType()) {
1572 // For __atomic_*_n operations, the value type must be a scalar integral or
1573 // pointer type which is 1, 2, 4, 8 or 16 bytes in length.
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001574 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_atomic_int_or_ptr)
Richard Smithfeea8832012-04-12 05:08:17 +00001575 << IsC11 << Ptr->getType() << Ptr->getSourceRange();
1576 return ExprError();
1577 }
1578
Eli Friedmanaa769812013-09-11 03:49:34 +00001579 if (!IsC11 && !AtomTy.isTriviallyCopyableType(Context) &&
1580 !AtomTy->isScalarType()) {
Richard Smithfeea8832012-04-12 05:08:17 +00001581 // For GNU atomics, require a trivially-copyable type. This is not part of
1582 // the GNU atomics specification, but we enforce it for sanity.
1583 Diag(DRE->getLocStart(), diag::err_atomic_op_needs_trivial_copy)
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001584 << Ptr->getType() << Ptr->getSourceRange();
1585 return ExprError();
1586 }
1587
Richard Smithfeea8832012-04-12 05:08:17 +00001588 // FIXME: For any builtin other than a load, the ValType must not be
1589 // const-qualified.
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001590
1591 switch (ValType.getObjCLifetime()) {
1592 case Qualifiers::OCL_None:
1593 case Qualifiers::OCL_ExplicitNone:
1594 // okay
1595 break;
1596
1597 case Qualifiers::OCL_Weak:
1598 case Qualifiers::OCL_Strong:
1599 case Qualifiers::OCL_Autoreleasing:
Richard Smithfeea8832012-04-12 05:08:17 +00001600 // FIXME: Can this happen? By this point, ValType should be known
1601 // to be trivially copyable.
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001602 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
1603 << ValType << Ptr->getSourceRange();
1604 return ExprError();
1605 }
1606
David Majnemerc6eb6502015-06-03 00:26:35 +00001607 // atomic_fetch_or takes a pointer to a volatile 'A'. We shouldn't let the
1608 // volatile-ness of the pointee-type inject itself into the result or the
1609 // other operands.
1610 ValType.removeLocalVolatile();
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001611 QualType ResultType = ValType;
Richard Smithfeea8832012-04-12 05:08:17 +00001612 if (Form == Copy || Form == GNUXchg || Form == Init)
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001613 ResultType = Context.VoidTy;
Richard Smithfeea8832012-04-12 05:08:17 +00001614 else if (Form == C11CmpXchg || Form == GNUCmpXchg)
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001615 ResultType = Context.BoolTy;
1616
Richard Smithfeea8832012-04-12 05:08:17 +00001617 // The type of a parameter passed 'by value'. In the GNU atomics, such
1618 // arguments are actually passed as pointers.
1619 QualType ByValType = ValType; // 'CP'
1620 if (!IsC11 && !IsN)
1621 ByValType = Ptr->getType();
1622
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001623 // The first argument --- the pointer --- has a fixed type; we
1624 // deduce the types of the rest of the arguments accordingly. Walk
1625 // the remaining arguments, converting them to the deduced value type.
Richard Smithfeea8832012-04-12 05:08:17 +00001626 for (unsigned i = 1; i != NumArgs[Form]; ++i) {
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001627 QualType Ty;
Richard Smithfeea8832012-04-12 05:08:17 +00001628 if (i < NumVals[Form] + 1) {
1629 switch (i) {
1630 case 1:
1631 // The second argument is the non-atomic operand. For arithmetic, this
1632 // is always passed by value, and for a compare_exchange it is always
1633 // passed by address. For the rest, GNU uses by-address and C11 uses
1634 // by-value.
1635 assert(Form != Load);
1636 if (Form == Init || (Form == Arithmetic && ValType->isIntegerType()))
1637 Ty = ValType;
1638 else if (Form == Copy || Form == Xchg)
1639 Ty = ByValType;
1640 else if (Form == Arithmetic)
1641 Ty = Context.getPointerDiffType();
1642 else
1643 Ty = Context.getPointerType(ValType.getUnqualifiedType());
1644 break;
1645 case 2:
1646 // The third argument to compare_exchange / GNU exchange is a
1647 // (pointer to a) desired value.
1648 Ty = ByValType;
1649 break;
1650 case 3:
1651 // The fourth argument to GNU compare_exchange is a 'weak' flag.
1652 Ty = Context.BoolTy;
1653 break;
1654 }
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001655 } else {
1656 // The order(s) are always converted to int.
1657 Ty = Context.IntTy;
1658 }
Richard Smithfeea8832012-04-12 05:08:17 +00001659
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001660 InitializedEntity Entity =
1661 InitializedEntity::InitializeParameter(Context, Ty, false);
Richard Smithfeea8832012-04-12 05:08:17 +00001662 ExprResult Arg = TheCall->getArg(i);
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001663 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
1664 if (Arg.isInvalid())
1665 return true;
1666 TheCall->setArg(i, Arg.get());
1667 }
1668
Richard Smithfeea8832012-04-12 05:08:17 +00001669 // Permute the arguments into a 'consistent' order.
Eli Friedman8d3e43f2011-10-14 22:48:56 +00001670 SmallVector<Expr*, 5> SubExprs;
1671 SubExprs.push_back(Ptr);
Richard Smithfeea8832012-04-12 05:08:17 +00001672 switch (Form) {
1673 case Init:
1674 // Note, AtomicExpr::getVal1() has a special case for this atomic.
David Chisnallfa35df62012-01-16 17:27:18 +00001675 SubExprs.push_back(TheCall->getArg(1)); // Val1
Richard Smithfeea8832012-04-12 05:08:17 +00001676 break;
1677 case Load:
1678 SubExprs.push_back(TheCall->getArg(1)); // Order
1679 break;
1680 case Copy:
1681 case Arithmetic:
1682 case Xchg:
Eli Friedman8d3e43f2011-10-14 22:48:56 +00001683 SubExprs.push_back(TheCall->getArg(2)); // Order
1684 SubExprs.push_back(TheCall->getArg(1)); // Val1
Richard Smithfeea8832012-04-12 05:08:17 +00001685 break;
1686 case GNUXchg:
1687 // Note, AtomicExpr::getVal2() has a special case for this atomic.
1688 SubExprs.push_back(TheCall->getArg(3)); // Order
1689 SubExprs.push_back(TheCall->getArg(1)); // Val1
1690 SubExprs.push_back(TheCall->getArg(2)); // Val2
1691 break;
1692 case C11CmpXchg:
Eli Friedman8d3e43f2011-10-14 22:48:56 +00001693 SubExprs.push_back(TheCall->getArg(3)); // Order
1694 SubExprs.push_back(TheCall->getArg(1)); // Val1
Eli Friedman8d3e43f2011-10-14 22:48:56 +00001695 SubExprs.push_back(TheCall->getArg(4)); // OrderFail
David Chisnall891ec282012-03-29 17:58:59 +00001696 SubExprs.push_back(TheCall->getArg(2)); // Val2
Richard Smithfeea8832012-04-12 05:08:17 +00001697 break;
1698 case GNUCmpXchg:
1699 SubExprs.push_back(TheCall->getArg(4)); // Order
1700 SubExprs.push_back(TheCall->getArg(1)); // Val1
1701 SubExprs.push_back(TheCall->getArg(5)); // OrderFail
1702 SubExprs.push_back(TheCall->getArg(2)); // Val2
1703 SubExprs.push_back(TheCall->getArg(3)); // Weak
1704 break;
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001705 }
Tim Northovere94a34c2014-03-11 10:49:14 +00001706
1707 if (SubExprs.size() >= 2 && Form != Init) {
1708 llvm::APSInt Result(32);
1709 if (SubExprs[1]->isIntegerConstantExpr(Result, Context) &&
1710 !isValidOrderingForOp(Result.getSExtValue(), Op))
Tim Northoverc83472e2014-03-11 11:35:10 +00001711 Diag(SubExprs[1]->getLocStart(),
1712 diag::warn_atomic_op_has_invalid_memory_order)
1713 << SubExprs[1]->getSourceRange();
Tim Northovere94a34c2014-03-11 10:49:14 +00001714 }
1715
Fariborz Jahanian615de762013-05-28 17:37:39 +00001716 AtomicExpr *AE = new (Context) AtomicExpr(TheCall->getCallee()->getLocStart(),
1717 SubExprs, ResultType, Op,
1718 TheCall->getRParenLoc());
1719
1720 if ((Op == AtomicExpr::AO__c11_atomic_load ||
1721 (Op == AtomicExpr::AO__c11_atomic_store)) &&
1722 Context.AtomicUsesUnsupportedLibcall(AE))
1723 Diag(AE->getLocStart(), diag::err_atomic_load_store_uses_lib) <<
1724 ((Op == AtomicExpr::AO__c11_atomic_load) ? 0 : 1);
Eli Friedman8d3e43f2011-10-14 22:48:56 +00001725
Nikola Smiljanic03ff2592014-05-29 14:05:12 +00001726 return AE;
Eli Friedmandf14b3a2011-10-11 02:20:01 +00001727}
1728
1729
John McCall29ad95b2011-08-27 01:09:30 +00001730/// checkBuiltinArgument - Given a call to a builtin function, perform
1731/// normal type-checking on the given argument, updating the call in
1732/// place. This is useful when a builtin function requires custom
1733/// type-checking for some of its arguments but not necessarily all of
1734/// them.
1735///
1736/// Returns true on error.
1737static bool checkBuiltinArgument(Sema &S, CallExpr *E, unsigned ArgIndex) {
1738 FunctionDecl *Fn = E->getDirectCallee();
1739 assert(Fn && "builtin call without direct callee!");
1740
1741 ParmVarDecl *Param = Fn->getParamDecl(ArgIndex);
1742 InitializedEntity Entity =
1743 InitializedEntity::InitializeParameter(S.Context, Param);
1744
1745 ExprResult Arg = E->getArg(0);
1746 Arg = S.PerformCopyInitialization(Entity, SourceLocation(), Arg);
1747 if (Arg.isInvalid())
1748 return true;
1749
Nikola Smiljanic01a75982014-05-29 10:55:11 +00001750 E->setArg(ArgIndex, Arg.get());
John McCall29ad95b2011-08-27 01:09:30 +00001751 return false;
1752}
1753
Chris Lattnerdc046542009-05-08 06:58:22 +00001754/// SemaBuiltinAtomicOverloaded - We have a call to a function like
1755/// __sync_fetch_and_add, which is an overloaded function based on the pointer
1756/// type of its first argument. The main ActOnCallExpr routines have already
1757/// promoted the types of arguments because all of these calls are prototyped as
1758/// void(...).
1759///
1760/// This function goes through and does final semantic checking for these
1761/// builtins,
John McCalldadc5752010-08-24 06:29:42 +00001762ExprResult
1763Sema::SemaBuiltinAtomicOverloaded(ExprResult TheCallResult) {
Chandler Carruth741e5ce2010-07-09 18:59:35 +00001764 CallExpr *TheCall = (CallExpr *)TheCallResult.get();
Chris Lattnerdc046542009-05-08 06:58:22 +00001765 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
1766 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
1767
1768 // Ensure that we have at least one argument to do type inference from.
Chandler Carruth741e5ce2010-07-09 18:59:35 +00001769 if (TheCall->getNumArgs() < 1) {
1770 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
1771 << 0 << 1 << TheCall->getNumArgs()
1772 << TheCall->getCallee()->getSourceRange();
1773 return ExprError();
1774 }
Mike Stump11289f42009-09-09 15:08:12 +00001775
Chris Lattnerdc046542009-05-08 06:58:22 +00001776 // Inspect the first argument of the atomic builtin. This should always be
1777 // a pointer type, whose element is an integral scalar or pointer type.
1778 // Because it is a pointer type, we don't have to worry about any implicit
1779 // casts here.
Chandler Carruth741e5ce2010-07-09 18:59:35 +00001780 // FIXME: We don't allow floating point scalars as input.
Chris Lattnerdc046542009-05-08 06:58:22 +00001781 Expr *FirstArg = TheCall->getArg(0);
Eli Friedman844f9452012-01-23 02:35:22 +00001782 ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg);
1783 if (FirstArgResult.isInvalid())
1784 return ExprError();
Nikola Smiljanic01a75982014-05-29 10:55:11 +00001785 FirstArg = FirstArgResult.get();
Eli Friedman844f9452012-01-23 02:35:22 +00001786 TheCall->setArg(0, FirstArg);
1787
John McCall31168b02011-06-15 23:02:42 +00001788 const PointerType *pointerType = FirstArg->getType()->getAs<PointerType>();
1789 if (!pointerType) {
Chandler Carruth741e5ce2010-07-09 18:59:35 +00001790 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer)
1791 << FirstArg->getType() << FirstArg->getSourceRange();
1792 return ExprError();
1793 }
Mike Stump11289f42009-09-09 15:08:12 +00001794
John McCall31168b02011-06-15 23:02:42 +00001795 QualType ValType = pointerType->getPointeeType();
Chris Lattnerbb3bcd82010-09-17 21:12:38 +00001796 if (!ValType->isIntegerType() && !ValType->isAnyPointerType() &&
Chandler Carruth741e5ce2010-07-09 18:59:35 +00001797 !ValType->isBlockPointerType()) {
1798 Diag(DRE->getLocStart(), diag::err_atomic_builtin_must_be_pointer_intptr)
1799 << FirstArg->getType() << FirstArg->getSourceRange();
1800 return ExprError();
1801 }
Chris Lattnerdc046542009-05-08 06:58:22 +00001802
John McCall31168b02011-06-15 23:02:42 +00001803 switch (ValType.getObjCLifetime()) {
1804 case Qualifiers::OCL_None:
1805 case Qualifiers::OCL_ExplicitNone:
1806 // okay
1807 break;
1808
1809 case Qualifiers::OCL_Weak:
1810 case Qualifiers::OCL_Strong:
1811 case Qualifiers::OCL_Autoreleasing:
Argyrios Kyrtzidiscff00d92011-06-24 00:08:59 +00001812 Diag(DRE->getLocStart(), diag::err_arc_atomic_ownership)
John McCall31168b02011-06-15 23:02:42 +00001813 << ValType << FirstArg->getSourceRange();
1814 return ExprError();
1815 }
1816
John McCallb50451a2011-10-05 07:41:44 +00001817 // Strip any qualifiers off ValType.
1818 ValType = ValType.getUnqualifiedType();
1819
Chandler Carruth3973af72010-07-18 20:54:12 +00001820 // The majority of builtins return a value, but a few have special return
1821 // types, so allow them to override appropriately below.
1822 QualType ResultType = ValType;
1823
Chris Lattnerdc046542009-05-08 06:58:22 +00001824 // We need to figure out which concrete builtin this maps onto. For example,
1825 // __sync_fetch_and_add with a 2 byte object turns into
1826 // __sync_fetch_and_add_2.
1827#define BUILTIN_ROW(x) \
1828 { Builtin::BI##x##_1, Builtin::BI##x##_2, Builtin::BI##x##_4, \
1829 Builtin::BI##x##_8, Builtin::BI##x##_16 }
Mike Stump11289f42009-09-09 15:08:12 +00001830
Chris Lattnerdc046542009-05-08 06:58:22 +00001831 static const unsigned BuiltinIndices[][5] = {
1832 BUILTIN_ROW(__sync_fetch_and_add),
1833 BUILTIN_ROW(__sync_fetch_and_sub),
1834 BUILTIN_ROW(__sync_fetch_and_or),
1835 BUILTIN_ROW(__sync_fetch_and_and),
1836 BUILTIN_ROW(__sync_fetch_and_xor),
Hal Finkeld2208b52014-10-02 20:53:50 +00001837 BUILTIN_ROW(__sync_fetch_and_nand),
Mike Stump11289f42009-09-09 15:08:12 +00001838
Chris Lattnerdc046542009-05-08 06:58:22 +00001839 BUILTIN_ROW(__sync_add_and_fetch),
1840 BUILTIN_ROW(__sync_sub_and_fetch),
1841 BUILTIN_ROW(__sync_and_and_fetch),
1842 BUILTIN_ROW(__sync_or_and_fetch),
1843 BUILTIN_ROW(__sync_xor_and_fetch),
Hal Finkeld2208b52014-10-02 20:53:50 +00001844 BUILTIN_ROW(__sync_nand_and_fetch),
Mike Stump11289f42009-09-09 15:08:12 +00001845
Chris Lattnerdc046542009-05-08 06:58:22 +00001846 BUILTIN_ROW(__sync_val_compare_and_swap),
1847 BUILTIN_ROW(__sync_bool_compare_and_swap),
1848 BUILTIN_ROW(__sync_lock_test_and_set),
Chris Lattner9cb59fa2011-04-09 03:57:26 +00001849 BUILTIN_ROW(__sync_lock_release),
1850 BUILTIN_ROW(__sync_swap)
Chris Lattnerdc046542009-05-08 06:58:22 +00001851 };
Mike Stump11289f42009-09-09 15:08:12 +00001852#undef BUILTIN_ROW
1853
Chris Lattnerdc046542009-05-08 06:58:22 +00001854 // Determine the index of the size.
1855 unsigned SizeIndex;
Ken Dyck40775002010-01-11 17:06:35 +00001856 switch (Context.getTypeSizeInChars(ValType).getQuantity()) {
Chris Lattnerdc046542009-05-08 06:58:22 +00001857 case 1: SizeIndex = 0; break;
1858 case 2: SizeIndex = 1; break;
1859 case 4: SizeIndex = 2; break;
1860 case 8: SizeIndex = 3; break;
1861 case 16: SizeIndex = 4; break;
1862 default:
Chandler Carruth741e5ce2010-07-09 18:59:35 +00001863 Diag(DRE->getLocStart(), diag::err_atomic_builtin_pointer_size)
1864 << FirstArg->getType() << FirstArg->getSourceRange();
1865 return ExprError();
Chris Lattnerdc046542009-05-08 06:58:22 +00001866 }
Mike Stump11289f42009-09-09 15:08:12 +00001867
Chris Lattnerdc046542009-05-08 06:58:22 +00001868 // Each of these builtins has one pointer argument, followed by some number of
1869 // values (0, 1 or 2) followed by a potentially empty varags list of stuff
1870 // that we ignore. Find out which row of BuiltinIndices to read from as well
1871 // as the number of fixed args.
Douglas Gregor15fc9562009-09-12 00:22:50 +00001872 unsigned BuiltinID = FDecl->getBuiltinID();
Chris Lattnerdc046542009-05-08 06:58:22 +00001873 unsigned BuiltinIndex, NumFixed = 1;
Hal Finkeld2208b52014-10-02 20:53:50 +00001874 bool WarnAboutSemanticsChange = false;
Chris Lattnerdc046542009-05-08 06:58:22 +00001875 switch (BuiltinID) {
David Blaikie83d382b2011-09-23 05:06:16 +00001876 default: llvm_unreachable("Unknown overloaded atomic builtin!");
Douglas Gregor73722482011-11-28 16:30:08 +00001877 case Builtin::BI__sync_fetch_and_add:
1878 case Builtin::BI__sync_fetch_and_add_1:
1879 case Builtin::BI__sync_fetch_and_add_2:
1880 case Builtin::BI__sync_fetch_and_add_4:
1881 case Builtin::BI__sync_fetch_and_add_8:
1882 case Builtin::BI__sync_fetch_and_add_16:
1883 BuiltinIndex = 0;
1884 break;
1885
1886 case Builtin::BI__sync_fetch_and_sub:
1887 case Builtin::BI__sync_fetch_and_sub_1:
1888 case Builtin::BI__sync_fetch_and_sub_2:
1889 case Builtin::BI__sync_fetch_and_sub_4:
1890 case Builtin::BI__sync_fetch_and_sub_8:
1891 case Builtin::BI__sync_fetch_and_sub_16:
1892 BuiltinIndex = 1;
1893 break;
1894
1895 case Builtin::BI__sync_fetch_and_or:
1896 case Builtin::BI__sync_fetch_and_or_1:
1897 case Builtin::BI__sync_fetch_and_or_2:
1898 case Builtin::BI__sync_fetch_and_or_4:
1899 case Builtin::BI__sync_fetch_and_or_8:
1900 case Builtin::BI__sync_fetch_and_or_16:
1901 BuiltinIndex = 2;
1902 break;
1903
1904 case Builtin::BI__sync_fetch_and_and:
1905 case Builtin::BI__sync_fetch_and_and_1:
1906 case Builtin::BI__sync_fetch_and_and_2:
1907 case Builtin::BI__sync_fetch_and_and_4:
1908 case Builtin::BI__sync_fetch_and_and_8:
1909 case Builtin::BI__sync_fetch_and_and_16:
1910 BuiltinIndex = 3;
1911 break;
Mike Stump11289f42009-09-09 15:08:12 +00001912
Douglas Gregor73722482011-11-28 16:30:08 +00001913 case Builtin::BI__sync_fetch_and_xor:
1914 case Builtin::BI__sync_fetch_and_xor_1:
1915 case Builtin::BI__sync_fetch_and_xor_2:
1916 case Builtin::BI__sync_fetch_and_xor_4:
1917 case Builtin::BI__sync_fetch_and_xor_8:
1918 case Builtin::BI__sync_fetch_and_xor_16:
1919 BuiltinIndex = 4;
1920 break;
1921
Hal Finkeld2208b52014-10-02 20:53:50 +00001922 case Builtin::BI__sync_fetch_and_nand:
1923 case Builtin::BI__sync_fetch_and_nand_1:
1924 case Builtin::BI__sync_fetch_and_nand_2:
1925 case Builtin::BI__sync_fetch_and_nand_4:
1926 case Builtin::BI__sync_fetch_and_nand_8:
1927 case Builtin::BI__sync_fetch_and_nand_16:
1928 BuiltinIndex = 5;
1929 WarnAboutSemanticsChange = true;
1930 break;
1931
Douglas Gregor73722482011-11-28 16:30:08 +00001932 case Builtin::BI__sync_add_and_fetch:
1933 case Builtin::BI__sync_add_and_fetch_1:
1934 case Builtin::BI__sync_add_and_fetch_2:
1935 case Builtin::BI__sync_add_and_fetch_4:
1936 case Builtin::BI__sync_add_and_fetch_8:
1937 case Builtin::BI__sync_add_and_fetch_16:
Hal Finkeld2208b52014-10-02 20:53:50 +00001938 BuiltinIndex = 6;
Douglas Gregor73722482011-11-28 16:30:08 +00001939 break;
1940
1941 case Builtin::BI__sync_sub_and_fetch:
1942 case Builtin::BI__sync_sub_and_fetch_1:
1943 case Builtin::BI__sync_sub_and_fetch_2:
1944 case Builtin::BI__sync_sub_and_fetch_4:
1945 case Builtin::BI__sync_sub_and_fetch_8:
1946 case Builtin::BI__sync_sub_and_fetch_16:
Hal Finkeld2208b52014-10-02 20:53:50 +00001947 BuiltinIndex = 7;
Douglas Gregor73722482011-11-28 16:30:08 +00001948 break;
1949
1950 case Builtin::BI__sync_and_and_fetch:
1951 case Builtin::BI__sync_and_and_fetch_1:
1952 case Builtin::BI__sync_and_and_fetch_2:
1953 case Builtin::BI__sync_and_and_fetch_4:
1954 case Builtin::BI__sync_and_and_fetch_8:
1955 case Builtin::BI__sync_and_and_fetch_16:
Hal Finkeld2208b52014-10-02 20:53:50 +00001956 BuiltinIndex = 8;
Douglas Gregor73722482011-11-28 16:30:08 +00001957 break;
1958
1959 case Builtin::BI__sync_or_and_fetch:
1960 case Builtin::BI__sync_or_and_fetch_1:
1961 case Builtin::BI__sync_or_and_fetch_2:
1962 case Builtin::BI__sync_or_and_fetch_4:
1963 case Builtin::BI__sync_or_and_fetch_8:
1964 case Builtin::BI__sync_or_and_fetch_16:
Hal Finkeld2208b52014-10-02 20:53:50 +00001965 BuiltinIndex = 9;
Douglas Gregor73722482011-11-28 16:30:08 +00001966 break;
1967
1968 case Builtin::BI__sync_xor_and_fetch:
1969 case Builtin::BI__sync_xor_and_fetch_1:
1970 case Builtin::BI__sync_xor_and_fetch_2:
1971 case Builtin::BI__sync_xor_and_fetch_4:
1972 case Builtin::BI__sync_xor_and_fetch_8:
1973 case Builtin::BI__sync_xor_and_fetch_16:
Hal Finkeld2208b52014-10-02 20:53:50 +00001974 BuiltinIndex = 10;
1975 break;
1976
1977 case Builtin::BI__sync_nand_and_fetch:
1978 case Builtin::BI__sync_nand_and_fetch_1:
1979 case Builtin::BI__sync_nand_and_fetch_2:
1980 case Builtin::BI__sync_nand_and_fetch_4:
1981 case Builtin::BI__sync_nand_and_fetch_8:
1982 case Builtin::BI__sync_nand_and_fetch_16:
1983 BuiltinIndex = 11;
1984 WarnAboutSemanticsChange = true;
Douglas Gregor73722482011-11-28 16:30:08 +00001985 break;
Mike Stump11289f42009-09-09 15:08:12 +00001986
Chris Lattnerdc046542009-05-08 06:58:22 +00001987 case Builtin::BI__sync_val_compare_and_swap:
Douglas Gregor73722482011-11-28 16:30:08 +00001988 case Builtin::BI__sync_val_compare_and_swap_1:
1989 case Builtin::BI__sync_val_compare_and_swap_2:
1990 case Builtin::BI__sync_val_compare_and_swap_4:
1991 case Builtin::BI__sync_val_compare_and_swap_8:
1992 case Builtin::BI__sync_val_compare_and_swap_16:
Hal Finkeld2208b52014-10-02 20:53:50 +00001993 BuiltinIndex = 12;
Chris Lattnerdc046542009-05-08 06:58:22 +00001994 NumFixed = 2;
1995 break;
Douglas Gregor73722482011-11-28 16:30:08 +00001996
Chris Lattnerdc046542009-05-08 06:58:22 +00001997 case Builtin::BI__sync_bool_compare_and_swap:
Douglas Gregor73722482011-11-28 16:30:08 +00001998 case Builtin::BI__sync_bool_compare_and_swap_1:
1999 case Builtin::BI__sync_bool_compare_and_swap_2:
2000 case Builtin::BI__sync_bool_compare_and_swap_4:
2001 case Builtin::BI__sync_bool_compare_and_swap_8:
2002 case Builtin::BI__sync_bool_compare_and_swap_16:
Hal Finkeld2208b52014-10-02 20:53:50 +00002003 BuiltinIndex = 13;
Chris Lattnerdc046542009-05-08 06:58:22 +00002004 NumFixed = 2;
Chandler Carruth3973af72010-07-18 20:54:12 +00002005 ResultType = Context.BoolTy;
Chris Lattnerdc046542009-05-08 06:58:22 +00002006 break;
Douglas Gregor73722482011-11-28 16:30:08 +00002007
2008 case Builtin::BI__sync_lock_test_and_set:
2009 case Builtin::BI__sync_lock_test_and_set_1:
2010 case Builtin::BI__sync_lock_test_and_set_2:
2011 case Builtin::BI__sync_lock_test_and_set_4:
2012 case Builtin::BI__sync_lock_test_and_set_8:
2013 case Builtin::BI__sync_lock_test_and_set_16:
Hal Finkeld2208b52014-10-02 20:53:50 +00002014 BuiltinIndex = 14;
Douglas Gregor73722482011-11-28 16:30:08 +00002015 break;
2016
Chris Lattnerdc046542009-05-08 06:58:22 +00002017 case Builtin::BI__sync_lock_release:
Douglas Gregor73722482011-11-28 16:30:08 +00002018 case Builtin::BI__sync_lock_release_1:
2019 case Builtin::BI__sync_lock_release_2:
2020 case Builtin::BI__sync_lock_release_4:
2021 case Builtin::BI__sync_lock_release_8:
2022 case Builtin::BI__sync_lock_release_16:
Hal Finkeld2208b52014-10-02 20:53:50 +00002023 BuiltinIndex = 15;
Chris Lattnerdc046542009-05-08 06:58:22 +00002024 NumFixed = 0;
Chandler Carruth3973af72010-07-18 20:54:12 +00002025 ResultType = Context.VoidTy;
Chris Lattnerdc046542009-05-08 06:58:22 +00002026 break;
Douglas Gregor73722482011-11-28 16:30:08 +00002027
2028 case Builtin::BI__sync_swap:
2029 case Builtin::BI__sync_swap_1:
2030 case Builtin::BI__sync_swap_2:
2031 case Builtin::BI__sync_swap_4:
2032 case Builtin::BI__sync_swap_8:
2033 case Builtin::BI__sync_swap_16:
Hal Finkeld2208b52014-10-02 20:53:50 +00002034 BuiltinIndex = 16;
Douglas Gregor73722482011-11-28 16:30:08 +00002035 break;
Chris Lattnerdc046542009-05-08 06:58:22 +00002036 }
Mike Stump11289f42009-09-09 15:08:12 +00002037
Chris Lattnerdc046542009-05-08 06:58:22 +00002038 // Now that we know how many fixed arguments we expect, first check that we
2039 // have at least that many.
Chandler Carruth741e5ce2010-07-09 18:59:35 +00002040 if (TheCall->getNumArgs() < 1+NumFixed) {
2041 Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args_at_least)
2042 << 0 << 1+NumFixed << TheCall->getNumArgs()
2043 << TheCall->getCallee()->getSourceRange();
2044 return ExprError();
2045 }
Mike Stump11289f42009-09-09 15:08:12 +00002046
Hal Finkeld2208b52014-10-02 20:53:50 +00002047 if (WarnAboutSemanticsChange) {
2048 Diag(TheCall->getLocEnd(), diag::warn_sync_fetch_and_nand_semantics_change)
2049 << TheCall->getCallee()->getSourceRange();
2050 }
2051
Chris Lattner5b9241b2009-05-08 15:36:58 +00002052 // Get the decl for the concrete builtin from this, we can tell what the
2053 // concrete integer type we should convert to is.
2054 unsigned NewBuiltinID = BuiltinIndices[BuiltinIndex][SizeIndex];
2055 const char *NewBuiltinName = Context.BuiltinInfo.GetName(NewBuiltinID);
Abramo Bagnara6cba23a2012-09-22 09:05:22 +00002056 FunctionDecl *NewBuiltinDecl;
2057 if (NewBuiltinID == BuiltinID)
2058 NewBuiltinDecl = FDecl;
2059 else {
2060 // Perform builtin lookup to avoid redeclaring it.
2061 DeclarationName DN(&Context.Idents.get(NewBuiltinName));
2062 LookupResult Res(*this, DN, DRE->getLocStart(), LookupOrdinaryName);
2063 LookupName(Res, TUScope, /*AllowBuiltinCreation=*/true);
2064 assert(Res.getFoundDecl());
2065 NewBuiltinDecl = dyn_cast<FunctionDecl>(Res.getFoundDecl());
Craig Topperc3ec1492014-05-26 06:22:03 +00002066 if (!NewBuiltinDecl)
Abramo Bagnara6cba23a2012-09-22 09:05:22 +00002067 return ExprError();
2068 }
Chandler Carruth741e5ce2010-07-09 18:59:35 +00002069
John McCallcf142162010-08-07 06:22:56 +00002070 // The first argument --- the pointer --- has a fixed type; we
2071 // deduce the types of the rest of the arguments accordingly. Walk
2072 // the remaining arguments, converting them to the deduced value type.
Chris Lattnerdc046542009-05-08 06:58:22 +00002073 for (unsigned i = 0; i != NumFixed; ++i) {
John Wiegley01296292011-04-08 18:41:53 +00002074 ExprResult Arg = TheCall->getArg(i+1);
Mike Stump11289f42009-09-09 15:08:12 +00002075
Chris Lattnerdc046542009-05-08 06:58:22 +00002076 // GCC does an implicit conversion to the pointer or integer ValType. This
2077 // can fail in some cases (1i -> int**), check for this error case now.
John McCallb50451a2011-10-05 07:41:44 +00002078 // Initialize the argument.
2079 InitializedEntity Entity = InitializedEntity::InitializeParameter(Context,
2080 ValType, /*consume*/ false);
2081 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
John Wiegley01296292011-04-08 18:41:53 +00002082 if (Arg.isInvalid())
Chandler Carruth741e5ce2010-07-09 18:59:35 +00002083 return ExprError();
Mike Stump11289f42009-09-09 15:08:12 +00002084
Chris Lattnerdc046542009-05-08 06:58:22 +00002085 // Okay, we have something that *can* be converted to the right type. Check
2086 // to see if there is a potentially weird extension going on here. This can
2087 // happen when you do an atomic operation on something like an char* and
2088 // pass in 42. The 42 gets converted to char. This is even more strange
2089 // for things like 45.123 -> char, etc.
Mike Stump11289f42009-09-09 15:08:12 +00002090 // FIXME: Do this check.
Nikola Smiljanic01a75982014-05-29 10:55:11 +00002091 TheCall->setArg(i+1, Arg.get());
Chris Lattnerdc046542009-05-08 06:58:22 +00002092 }
Mike Stump11289f42009-09-09 15:08:12 +00002093
Douglas Gregor6b3bcf22011-09-09 16:51:10 +00002094 ASTContext& Context = this->getASTContext();
2095
2096 // Create a new DeclRefExpr to refer to the new decl.
2097 DeclRefExpr* NewDRE = DeclRefExpr::Create(
2098 Context,
2099 DRE->getQualifierLoc(),
Abramo Bagnara7945c982012-01-27 09:46:47 +00002100 SourceLocation(),
Douglas Gregor6b3bcf22011-09-09 16:51:10 +00002101 NewBuiltinDecl,
John McCall113bee02012-03-10 09:33:50 +00002102 /*enclosing*/ false,
Douglas Gregor6b3bcf22011-09-09 16:51:10 +00002103 DRE->getLocation(),
Eli Friedman34866c72012-08-31 00:14:07 +00002104 Context.BuiltinFnTy,
Douglas Gregor6b3bcf22011-09-09 16:51:10 +00002105 DRE->getValueKind());
Mike Stump11289f42009-09-09 15:08:12 +00002106
Chris Lattnerdc046542009-05-08 06:58:22 +00002107 // Set the callee in the CallExpr.
Eli Friedman34866c72012-08-31 00:14:07 +00002108 // FIXME: This loses syntactic information.
2109 QualType CalleePtrTy = Context.getPointerType(NewBuiltinDecl->getType());
2110 ExprResult PromotedCall = ImpCastExprToType(NewDRE, CalleePtrTy,
2111 CK_BuiltinFnToFnPtr);
Nikola Smiljanic01a75982014-05-29 10:55:11 +00002112 TheCall->setCallee(PromotedCall.get());
Mike Stump11289f42009-09-09 15:08:12 +00002113
Chandler Carruthbc8cab12010-07-18 07:23:17 +00002114 // Change the result type of the call to match the original value type. This
2115 // is arbitrary, but the codegen for these builtins ins design to handle it
2116 // gracefully.
Chandler Carruth3973af72010-07-18 20:54:12 +00002117 TheCall->setType(ResultType);
Chandler Carruth741e5ce2010-07-09 18:59:35 +00002118
Benjamin Kramer62b95d82012-08-23 21:35:17 +00002119 return TheCallResult;
Chris Lattnerdc046542009-05-08 06:58:22 +00002120}
2121
Chris Lattner6436fb62009-02-18 06:01:06 +00002122/// CheckObjCString - Checks that the argument to the builtin
Anders Carlsson98f07902007-08-17 05:31:46 +00002123/// CFString constructor is correct
Steve Narofffb46e862009-04-13 20:26:29 +00002124/// Note: It might also make sense to do the UTF-16 conversion here (would
2125/// simplify the backend).
Chris Lattner6436fb62009-02-18 06:01:06 +00002126bool Sema::CheckObjCString(Expr *Arg) {
Chris Lattnerf2660962008-02-13 01:02:39 +00002127 Arg = Arg->IgnoreParenCasts();
Anders Carlsson98f07902007-08-17 05:31:46 +00002128 StringLiteral *Literal = dyn_cast<StringLiteral>(Arg);
2129
Douglas Gregorfb65e592011-07-27 05:40:30 +00002130 if (!Literal || !Literal->isAscii()) {
Chris Lattner3b054132008-11-19 05:08:23 +00002131 Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant)
2132 << Arg->getSourceRange();
Anders Carlssona3a9c432007-08-17 15:44:17 +00002133 return true;
Anders Carlsson98f07902007-08-17 05:31:46 +00002134 }
Mike Stump11289f42009-09-09 15:08:12 +00002135
Fariborz Jahanian56603ef2010-09-07 19:38:13 +00002136 if (Literal->containsNonAsciiOrNull()) {
Chris Lattner0e62c1c2011-07-23 10:55:15 +00002137 StringRef String = Literal->getString();
Fariborz Jahanian56603ef2010-09-07 19:38:13 +00002138 unsigned NumBytes = String.size();
Chris Lattner0e62c1c2011-07-23 10:55:15 +00002139 SmallVector<UTF16, 128> ToBuf(NumBytes);
Roman Divackye6377112012-09-06 15:59:27 +00002140 const UTF8 *FromPtr = (const UTF8 *)String.data();
Fariborz Jahanian56603ef2010-09-07 19:38:13 +00002141 UTF16 *ToPtr = &ToBuf[0];
2142
2143 ConversionResult Result = ConvertUTF8toUTF16(&FromPtr, FromPtr + NumBytes,
2144 &ToPtr, ToPtr + NumBytes,
2145 strictConversion);
2146 // Check for conversion failure.
2147 if (Result != conversionOK)
2148 Diag(Arg->getLocStart(),
2149 diag::warn_cfstring_truncated) << Arg->getSourceRange();
2150 }
Anders Carlssona3a9c432007-08-17 15:44:17 +00002151 return false;
Chris Lattnerb87b1b32007-08-10 20:18:51 +00002152}
2153
Chris Lattnere202e6a2007-12-20 00:05:45 +00002154/// SemaBuiltinVAStart - Check the arguments to __builtin_va_start for validity.
2155/// Emit an error and return true on failure, return false on success.
Chris Lattner08464942007-12-28 05:29:59 +00002156bool Sema::SemaBuiltinVAStart(CallExpr *TheCall) {
2157 Expr *Fn = TheCall->getCallee();
2158 if (TheCall->getNumArgs() > 2) {
Chris Lattnercedef8d2008-11-21 18:44:24 +00002159 Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattner3b054132008-11-19 05:08:23 +00002160 diag::err_typecheck_call_too_many_args)
Eric Christopher2a5aaff2010-04-16 04:56:46 +00002161 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
2162 << Fn->getSourceRange()
Mike Stump11289f42009-09-09 15:08:12 +00002163 << SourceRange(TheCall->getArg(2)->getLocStart(),
Chris Lattner3b054132008-11-19 05:08:23 +00002164 (*(TheCall->arg_end()-1))->getLocEnd());
Chris Lattner43be2e62007-12-19 23:59:04 +00002165 return true;
2166 }
Eli Friedmanbb2b3be2008-12-15 22:05:35 +00002167
2168 if (TheCall->getNumArgs() < 2) {
Eric Christopherabf1e182010-04-16 04:48:22 +00002169 return Diag(TheCall->getLocEnd(),
2170 diag::err_typecheck_call_too_few_args_at_least)
2171 << 0 /*function call*/ << 2 << TheCall->getNumArgs();
Eli Friedmanbb2b3be2008-12-15 22:05:35 +00002172 }
2173
John McCall29ad95b2011-08-27 01:09:30 +00002174 // Type-check the first argument normally.
2175 if (checkBuiltinArgument(*this, TheCall, 0))
2176 return true;
2177
Chris Lattnere202e6a2007-12-20 00:05:45 +00002178 // Determine whether the current function is variadic or not.
Douglas Gregor9a28e842010-03-01 23:15:13 +00002179 BlockScopeInfo *CurBlock = getCurBlock();
Chris Lattnere202e6a2007-12-20 00:05:45 +00002180 bool isVariadic;
Steve Naroff439a3e42009-04-15 19:33:47 +00002181 if (CurBlock)
John McCall8e346702010-06-04 19:02:56 +00002182 isVariadic = CurBlock->TheDecl->isVariadic();
Ted Kremenek186a0742010-04-29 16:49:01 +00002183 else if (FunctionDecl *FD = getCurFunctionDecl())
2184 isVariadic = FD->isVariadic();
2185 else
Argyrios Kyrtzidis853fbea2008-06-28 06:07:14 +00002186 isVariadic = getCurMethodDecl()->isVariadic();
Mike Stump11289f42009-09-09 15:08:12 +00002187
Chris Lattnere202e6a2007-12-20 00:05:45 +00002188 if (!isVariadic) {
Chris Lattner43be2e62007-12-19 23:59:04 +00002189 Diag(Fn->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
2190 return true;
2191 }
Mike Stump11289f42009-09-09 15:08:12 +00002192
Chris Lattner43be2e62007-12-19 23:59:04 +00002193 // Verify that the second argument to the builtin is the last argument of the
2194 // current function or method.
2195 bool SecondArgIsLastNamedArgument = false;
Anders Carlsson73cc5072008-02-13 01:22:59 +00002196 const Expr *Arg = TheCall->getArg(1)->IgnoreParenCasts();
Mike Stump11289f42009-09-09 15:08:12 +00002197
Nico Weber9eea7642013-05-24 23:31:57 +00002198 // These are valid if SecondArgIsLastNamedArgument is false after the next
2199 // block.
2200 QualType Type;
2201 SourceLocation ParamLoc;
2202
Anders Carlsson6a8350b2008-02-11 04:20:54 +00002203 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Arg)) {
2204 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(DR->getDecl())) {
Chris Lattner43be2e62007-12-19 23:59:04 +00002205 // FIXME: This isn't correct for methods (results in bogus warning).
2206 // Get the last formal in the current function.
Anders Carlsson6a8350b2008-02-11 04:20:54 +00002207 const ParmVarDecl *LastArg;
Steve Naroff439a3e42009-04-15 19:33:47 +00002208 if (CurBlock)
2209 LastArg = *(CurBlock->TheDecl->param_end()-1);
2210 else if (FunctionDecl *FD = getCurFunctionDecl())
Chris Lattner79413952008-12-04 23:50:19 +00002211 LastArg = *(FD->param_end()-1);
Chris Lattner43be2e62007-12-19 23:59:04 +00002212 else
Argyrios Kyrtzidis853fbea2008-06-28 06:07:14 +00002213 LastArg = *(getCurMethodDecl()->param_end()-1);
Chris Lattner43be2e62007-12-19 23:59:04 +00002214 SecondArgIsLastNamedArgument = PV == LastArg;
Nico Weber9eea7642013-05-24 23:31:57 +00002215
2216 Type = PV->getType();
2217 ParamLoc = PV->getLocation();
Chris Lattner43be2e62007-12-19 23:59:04 +00002218 }
2219 }
Mike Stump11289f42009-09-09 15:08:12 +00002220
Chris Lattner43be2e62007-12-19 23:59:04 +00002221 if (!SecondArgIsLastNamedArgument)
Mike Stump11289f42009-09-09 15:08:12 +00002222 Diag(TheCall->getArg(1)->getLocStart(),
Chris Lattner43be2e62007-12-19 23:59:04 +00002223 diag::warn_second_parameter_of_va_start_not_last_named_argument);
Nico Weber9eea7642013-05-24 23:31:57 +00002224 else if (Type->isReferenceType()) {
2225 Diag(Arg->getLocStart(),
2226 diag::warn_va_start_of_reference_type_is_undefined);
2227 Diag(ParamLoc, diag::note_parameter_type) << Type;
2228 }
2229
Enea Zaffanellab1b1b8a2013-11-07 08:14:26 +00002230 TheCall->setType(Context.VoidTy);
Chris Lattner43be2e62007-12-19 23:59:04 +00002231 return false;
Eli Friedmanf8353032008-05-20 08:23:37 +00002232}
Chris Lattner43be2e62007-12-19 23:59:04 +00002233
Saleem Abdulrasool202aac12014-07-22 02:01:04 +00002234bool Sema::SemaBuiltinVAStartARM(CallExpr *Call) {
2235 // void __va_start(va_list *ap, const char *named_addr, size_t slot_size,
2236 // const char *named_addr);
2237
2238 Expr *Func = Call->getCallee();
2239
2240 if (Call->getNumArgs() < 3)
2241 return Diag(Call->getLocEnd(),
2242 diag::err_typecheck_call_too_few_args_at_least)
2243 << 0 /*function call*/ << 3 << Call->getNumArgs();
2244
2245 // Determine whether the current function is variadic or not.
2246 bool IsVariadic;
2247 if (BlockScopeInfo *CurBlock = getCurBlock())
2248 IsVariadic = CurBlock->TheDecl->isVariadic();
2249 else if (FunctionDecl *FD = getCurFunctionDecl())
2250 IsVariadic = FD->isVariadic();
2251 else if (ObjCMethodDecl *MD = getCurMethodDecl())
2252 IsVariadic = MD->isVariadic();
2253 else
2254 llvm_unreachable("unexpected statement type");
2255
2256 if (!IsVariadic) {
2257 Diag(Func->getLocStart(), diag::err_va_start_used_in_non_variadic_function);
2258 return true;
2259 }
2260
2261 // Type-check the first argument normally.
2262 if (checkBuiltinArgument(*this, Call, 0))
2263 return true;
2264
Benjamin Kramere0ca6e12015-03-01 18:09:50 +00002265 const struct {
Saleem Abdulrasool202aac12014-07-22 02:01:04 +00002266 unsigned ArgNo;
2267 QualType Type;
2268 } ArgumentTypes[] = {
2269 { 1, Context.getPointerType(Context.CharTy.withConst()) },
2270 { 2, Context.getSizeType() },
2271 };
2272
2273 for (const auto &AT : ArgumentTypes) {
2274 const Expr *Arg = Call->getArg(AT.ArgNo)->IgnoreParens();
2275 if (Arg->getType().getCanonicalType() == AT.Type.getCanonicalType())
2276 continue;
2277 Diag(Arg->getLocStart(), diag::err_typecheck_convert_incompatible)
2278 << Arg->getType() << AT.Type << 1 /* different class */
2279 << 0 /* qualifier difference */ << 3 /* parameter mismatch */
2280 << AT.ArgNo + 1 << Arg->getType() << AT.Type;
2281 }
2282
2283 return false;
2284}
2285
Chris Lattner2da14fb2007-12-20 00:26:33 +00002286/// SemaBuiltinUnorderedCompare - Handle functions like __builtin_isgreater and
2287/// friends. This is declared to take (...), so we have to check everything.
Chris Lattner08464942007-12-28 05:29:59 +00002288bool Sema::SemaBuiltinUnorderedCompare(CallExpr *TheCall) {
2289 if (TheCall->getNumArgs() < 2)
Chris Lattnercedef8d2008-11-21 18:44:24 +00002290 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherabf1e182010-04-16 04:48:22 +00002291 << 0 << 2 << TheCall->getNumArgs()/*function call*/;
Chris Lattner08464942007-12-28 05:29:59 +00002292 if (TheCall->getNumArgs() > 2)
Mike Stump11289f42009-09-09 15:08:12 +00002293 return Diag(TheCall->getArg(2)->getLocStart(),
Chris Lattner3b054132008-11-19 05:08:23 +00002294 diag::err_typecheck_call_too_many_args)
Eric Christopher2a5aaff2010-04-16 04:56:46 +00002295 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
Chris Lattner3b054132008-11-19 05:08:23 +00002296 << SourceRange(TheCall->getArg(2)->getLocStart(),
2297 (*(TheCall->arg_end()-1))->getLocEnd());
Mike Stump11289f42009-09-09 15:08:12 +00002298
John Wiegley01296292011-04-08 18:41:53 +00002299 ExprResult OrigArg0 = TheCall->getArg(0);
2300 ExprResult OrigArg1 = TheCall->getArg(1);
Douglas Gregorc25f7662009-05-19 22:10:17 +00002301
Chris Lattner2da14fb2007-12-20 00:26:33 +00002302 // Do standard promotions between the two arguments, returning their common
2303 // type.
Chris Lattner08464942007-12-28 05:29:59 +00002304 QualType Res = UsualArithmeticConversions(OrigArg0, OrigArg1, false);
John Wiegley01296292011-04-08 18:41:53 +00002305 if (OrigArg0.isInvalid() || OrigArg1.isInvalid())
2306 return true;
Daniel Dunbar96f86772009-02-19 19:28:43 +00002307
2308 // Make sure any conversions are pushed back into the call; this is
2309 // type safe since unordered compare builtins are declared as "_Bool
2310 // foo(...)".
John Wiegley01296292011-04-08 18:41:53 +00002311 TheCall->setArg(0, OrigArg0.get());
2312 TheCall->setArg(1, OrigArg1.get());
Mike Stump11289f42009-09-09 15:08:12 +00002313
John Wiegley01296292011-04-08 18:41:53 +00002314 if (OrigArg0.get()->isTypeDependent() || OrigArg1.get()->isTypeDependent())
Douglas Gregorc25f7662009-05-19 22:10:17 +00002315 return false;
2316
Chris Lattner2da14fb2007-12-20 00:26:33 +00002317 // If the common type isn't a real floating type, then the arguments were
2318 // invalid for this operation.
Eli Friedman93ee5ca2012-06-16 02:19:17 +00002319 if (Res.isNull() || !Res->isRealFloatingType())
John Wiegley01296292011-04-08 18:41:53 +00002320 return Diag(OrigArg0.get()->getLocStart(),
Chris Lattner3b054132008-11-19 05:08:23 +00002321 diag::err_typecheck_call_invalid_ordered_compare)
John Wiegley01296292011-04-08 18:41:53 +00002322 << OrigArg0.get()->getType() << OrigArg1.get()->getType()
2323 << SourceRange(OrigArg0.get()->getLocStart(), OrigArg1.get()->getLocEnd());
Mike Stump11289f42009-09-09 15:08:12 +00002324
Chris Lattner2da14fb2007-12-20 00:26:33 +00002325 return false;
2326}
2327
Benjamin Kramer634fc102010-02-15 22:42:31 +00002328/// SemaBuiltinSemaBuiltinFPClassification - Handle functions like
2329/// __builtin_isnan and friends. This is declared to take (...), so we have
Benjamin Kramer64aae502010-02-16 10:07:31 +00002330/// to check everything. We expect the last argument to be a floating point
2331/// value.
2332bool Sema::SemaBuiltinFPClassification(CallExpr *TheCall, unsigned NumArgs) {
2333 if (TheCall->getNumArgs() < NumArgs)
Eli Friedman7e4faac2009-08-31 20:06:00 +00002334 return Diag(TheCall->getLocEnd(), diag::err_typecheck_call_too_few_args)
Eric Christopherabf1e182010-04-16 04:48:22 +00002335 << 0 << NumArgs << TheCall->getNumArgs()/*function call*/;
Benjamin Kramer64aae502010-02-16 10:07:31 +00002336 if (TheCall->getNumArgs() > NumArgs)
2337 return Diag(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman7e4faac2009-08-31 20:06:00 +00002338 diag::err_typecheck_call_too_many_args)
Eric Christopher2a5aaff2010-04-16 04:56:46 +00002339 << 0 /*function call*/ << NumArgs << TheCall->getNumArgs()
Benjamin Kramer64aae502010-02-16 10:07:31 +00002340 << SourceRange(TheCall->getArg(NumArgs)->getLocStart(),
Eli Friedman7e4faac2009-08-31 20:06:00 +00002341 (*(TheCall->arg_end()-1))->getLocEnd());
2342
Benjamin Kramer64aae502010-02-16 10:07:31 +00002343 Expr *OrigArg = TheCall->getArg(NumArgs-1);
Mike Stump11289f42009-09-09 15:08:12 +00002344
Eli Friedman7e4faac2009-08-31 20:06:00 +00002345 if (OrigArg->isTypeDependent())
2346 return false;
2347
Chris Lattner68784ef2010-05-06 05:50:07 +00002348 // This operation requires a non-_Complex floating-point number.
Eli Friedman7e4faac2009-08-31 20:06:00 +00002349 if (!OrigArg->getType()->isRealFloatingType())
Mike Stump11289f42009-09-09 15:08:12 +00002350 return Diag(OrigArg->getLocStart(),
Eli Friedman7e4faac2009-08-31 20:06:00 +00002351 diag::err_typecheck_call_invalid_unary_fp)
2352 << OrigArg->getType() << OrigArg->getSourceRange();
Mike Stump11289f42009-09-09 15:08:12 +00002353
Chris Lattner68784ef2010-05-06 05:50:07 +00002354 // If this is an implicit conversion from float -> double, remove it.
2355 if (ImplicitCastExpr *Cast = dyn_cast<ImplicitCastExpr>(OrigArg)) {
2356 Expr *CastArg = Cast->getSubExpr();
2357 if (CastArg->getType()->isSpecificBuiltinType(BuiltinType::Float)) {
2358 assert(Cast->getType()->isSpecificBuiltinType(BuiltinType::Double) &&
2359 "promotion from float to double is the only expected cast here");
Craig Topperc3ec1492014-05-26 06:22:03 +00002360 Cast->setSubExpr(nullptr);
Chris Lattner68784ef2010-05-06 05:50:07 +00002361 TheCall->setArg(NumArgs-1, CastArg);
Chris Lattner68784ef2010-05-06 05:50:07 +00002362 }
2363 }
2364
Eli Friedman7e4faac2009-08-31 20:06:00 +00002365 return false;
2366}
2367
Eli Friedmana1b4ed82008-05-14 19:38:39 +00002368/// SemaBuiltinShuffleVector - Handle __builtin_shufflevector.
2369// This is declared to take (...), so we have to check everything.
John McCalldadc5752010-08-24 06:29:42 +00002370ExprResult Sema::SemaBuiltinShuffleVector(CallExpr *TheCall) {
Nate Begemana0110022010-06-08 00:16:34 +00002371 if (TheCall->getNumArgs() < 2)
Sebastian Redlc215cfc2009-01-19 00:08:26 +00002372 return ExprError(Diag(TheCall->getLocEnd(),
Eric Christopherabf1e182010-04-16 04:48:22 +00002373 diag::err_typecheck_call_too_few_args_at_least)
Craig Topper304602a2013-07-28 21:50:10 +00002374 << 0 /*function call*/ << 2 << TheCall->getNumArgs()
2375 << TheCall->getSourceRange());
Eli Friedmana1b4ed82008-05-14 19:38:39 +00002376
Nate Begemana0110022010-06-08 00:16:34 +00002377 // Determine which of the following types of shufflevector we're checking:
2378 // 1) unary, vector mask: (lhs, mask)
2379 // 2) binary, vector mask: (lhs, rhs, mask)
2380 // 3) binary, scalar mask: (lhs, rhs, index, ..., index)
2381 QualType resType = TheCall->getArg(0)->getType();
2382 unsigned numElements = 0;
Craig Topper61d01cc2013-07-19 04:46:31 +00002383
Douglas Gregorc25f7662009-05-19 22:10:17 +00002384 if (!TheCall->getArg(0)->isTypeDependent() &&
2385 !TheCall->getArg(1)->isTypeDependent()) {
Nate Begemana0110022010-06-08 00:16:34 +00002386 QualType LHSType = TheCall->getArg(0)->getType();
2387 QualType RHSType = TheCall->getArg(1)->getType();
Craig Topper61d01cc2013-07-19 04:46:31 +00002388
Craig Topperbaca3892013-07-29 06:47:04 +00002389 if (!LHSType->isVectorType() || !RHSType->isVectorType())
2390 return ExprError(Diag(TheCall->getLocStart(),
2391 diag::err_shufflevector_non_vector)
2392 << SourceRange(TheCall->getArg(0)->getLocStart(),
2393 TheCall->getArg(1)->getLocEnd()));
Craig Topper61d01cc2013-07-19 04:46:31 +00002394
Nate Begemana0110022010-06-08 00:16:34 +00002395 numElements = LHSType->getAs<VectorType>()->getNumElements();
2396 unsigned numResElements = TheCall->getNumArgs() - 2;
Mike Stump11289f42009-09-09 15:08:12 +00002397
Nate Begemana0110022010-06-08 00:16:34 +00002398 // Check to see if we have a call with 2 vector arguments, the unary shuffle
2399 // with mask. If so, verify that RHS is an integer vector type with the
2400 // same number of elts as lhs.
2401 if (TheCall->getNumArgs() == 2) {
Sylvestre Ledru8e5d82e2013-07-06 08:00:09 +00002402 if (!RHSType->hasIntegerRepresentation() ||
Nate Begemana0110022010-06-08 00:16:34 +00002403 RHSType->getAs<VectorType>()->getNumElements() != numElements)
Craig Topperbaca3892013-07-29 06:47:04 +00002404 return ExprError(Diag(TheCall->getLocStart(),
2405 diag::err_shufflevector_incompatible_vector)
2406 << SourceRange(TheCall->getArg(1)->getLocStart(),
2407 TheCall->getArg(1)->getLocEnd()));
Craig Topper61d01cc2013-07-19 04:46:31 +00002408 } else if (!Context.hasSameUnqualifiedType(LHSType, RHSType)) {
Craig Topperbaca3892013-07-29 06:47:04 +00002409 return ExprError(Diag(TheCall->getLocStart(),
2410 diag::err_shufflevector_incompatible_vector)
2411 << SourceRange(TheCall->getArg(0)->getLocStart(),
2412 TheCall->getArg(1)->getLocEnd()));
Nate Begemana0110022010-06-08 00:16:34 +00002413 } else if (numElements != numResElements) {
2414 QualType eltType = LHSType->getAs<VectorType>()->getElementType();
Chris Lattner37141f42010-06-23 06:00:24 +00002415 resType = Context.getVectorType(eltType, numResElements,
Bob Wilsonaeb56442010-11-10 21:56:12 +00002416 VectorType::GenericVector);
Douglas Gregorc25f7662009-05-19 22:10:17 +00002417 }
Eli Friedmana1b4ed82008-05-14 19:38:39 +00002418 }
2419
2420 for (unsigned i = 2; i < TheCall->getNumArgs(); i++) {
Douglas Gregorc25f7662009-05-19 22:10:17 +00002421 if (TheCall->getArg(i)->isTypeDependent() ||
2422 TheCall->getArg(i)->isValueDependent())
2423 continue;
2424
Nate Begemana0110022010-06-08 00:16:34 +00002425 llvm::APSInt Result(32);
2426 if (!TheCall->getArg(i)->isIntegerConstantExpr(Result, Context))
2427 return ExprError(Diag(TheCall->getLocStart(),
Craig Topper304602a2013-07-28 21:50:10 +00002428 diag::err_shufflevector_nonconstant_argument)
2429 << TheCall->getArg(i)->getSourceRange());
Sebastian Redlc215cfc2009-01-19 00:08:26 +00002430
Craig Topper50ad5b72013-08-03 17:40:38 +00002431 // Allow -1 which will be translated to undef in the IR.
2432 if (Result.isSigned() && Result.isAllOnesValue())
2433 continue;
2434
Chris Lattner7ab824e2008-08-10 02:05:13 +00002435 if (Result.getActiveBits() > 64 || Result.getZExtValue() >= numElements*2)
Sebastian Redlc215cfc2009-01-19 00:08:26 +00002436 return ExprError(Diag(TheCall->getLocStart(),
Craig Topper304602a2013-07-28 21:50:10 +00002437 diag::err_shufflevector_argument_too_large)
2438 << TheCall->getArg(i)->getSourceRange());
Eli Friedmana1b4ed82008-05-14 19:38:39 +00002439 }
2440
Chris Lattner0e62c1c2011-07-23 10:55:15 +00002441 SmallVector<Expr*, 32> exprs;
Eli Friedmana1b4ed82008-05-14 19:38:39 +00002442
Chris Lattner7ab824e2008-08-10 02:05:13 +00002443 for (unsigned i = 0, e = TheCall->getNumArgs(); i != e; i++) {
Eli Friedmana1b4ed82008-05-14 19:38:39 +00002444 exprs.push_back(TheCall->getArg(i));
Craig Topperc3ec1492014-05-26 06:22:03 +00002445 TheCall->setArg(i, nullptr);
Eli Friedmana1b4ed82008-05-14 19:38:39 +00002446 }
2447
Nikola Smiljanic03ff2592014-05-29 14:05:12 +00002448 return new (Context) ShuffleVectorExpr(Context, exprs, resType,
2449 TheCall->getCallee()->getLocStart(),
2450 TheCall->getRParenLoc());
Eli Friedmana1b4ed82008-05-14 19:38:39 +00002451}
Chris Lattner43be2e62007-12-19 23:59:04 +00002452
Hal Finkelc4d7c822013-09-18 03:29:45 +00002453/// SemaConvertVectorExpr - Handle __builtin_convertvector
2454ExprResult Sema::SemaConvertVectorExpr(Expr *E, TypeSourceInfo *TInfo,
2455 SourceLocation BuiltinLoc,
2456 SourceLocation RParenLoc) {
2457 ExprValueKind VK = VK_RValue;
2458 ExprObjectKind OK = OK_Ordinary;
2459 QualType DstTy = TInfo->getType();
2460 QualType SrcTy = E->getType();
2461
2462 if (!SrcTy->isVectorType() && !SrcTy->isDependentType())
2463 return ExprError(Diag(BuiltinLoc,
2464 diag::err_convertvector_non_vector)
2465 << E->getSourceRange());
2466 if (!DstTy->isVectorType() && !DstTy->isDependentType())
2467 return ExprError(Diag(BuiltinLoc,
2468 diag::err_convertvector_non_vector_type));
2469
2470 if (!SrcTy->isDependentType() && !DstTy->isDependentType()) {
2471 unsigned SrcElts = SrcTy->getAs<VectorType>()->getNumElements();
2472 unsigned DstElts = DstTy->getAs<VectorType>()->getNumElements();
2473 if (SrcElts != DstElts)
2474 return ExprError(Diag(BuiltinLoc,
2475 diag::err_convertvector_incompatible_vector)
2476 << E->getSourceRange());
2477 }
2478
Nikola Smiljanic03ff2592014-05-29 14:05:12 +00002479 return new (Context)
2480 ConvertVectorExpr(E, TInfo, DstTy, VK, OK, BuiltinLoc, RParenLoc);
Hal Finkelc4d7c822013-09-18 03:29:45 +00002481}
2482
Daniel Dunbarb7257262008-07-21 22:59:13 +00002483/// SemaBuiltinPrefetch - Handle __builtin_prefetch.
2484// This is declared to take (const void*, ...) and can take two
2485// optional constant int args.
2486bool Sema::SemaBuiltinPrefetch(CallExpr *TheCall) {
Chris Lattner3b054132008-11-19 05:08:23 +00002487 unsigned NumArgs = TheCall->getNumArgs();
Daniel Dunbarb7257262008-07-21 22:59:13 +00002488
Chris Lattner3b054132008-11-19 05:08:23 +00002489 if (NumArgs > 3)
Eric Christopher2a5aaff2010-04-16 04:56:46 +00002490 return Diag(TheCall->getLocEnd(),
2491 diag::err_typecheck_call_too_many_args_at_most)
2492 << 0 /*function call*/ << 3 << NumArgs
2493 << TheCall->getSourceRange();
Daniel Dunbarb7257262008-07-21 22:59:13 +00002494
2495 // Argument 0 is checked for us and the remaining arguments must be
2496 // constant integers.
Richard Sandiford28940af2014-04-16 08:47:51 +00002497 for (unsigned i = 1; i != NumArgs; ++i)
2498 if (SemaBuiltinConstantArgRange(TheCall, i, 0, i == 1 ? 1 : 3))
Eric Christopher8d0c6212010-04-17 02:26:23 +00002499 return true;
Mike Stump11289f42009-09-09 15:08:12 +00002500
Warren Hunt20e4a5d2014-02-21 23:08:53 +00002501 return false;
2502}
2503
Hal Finkelf0417332014-07-17 14:25:55 +00002504/// SemaBuiltinAssume - Handle __assume (MS Extension).
2505// __assume does not evaluate its arguments, and should warn if its argument
2506// has side effects.
2507bool Sema::SemaBuiltinAssume(CallExpr *TheCall) {
2508 Expr *Arg = TheCall->getArg(0);
2509 if (Arg->isInstantiationDependent()) return false;
2510
2511 if (Arg->HasSideEffects(Context))
David Majnemer51236642015-02-26 00:57:33 +00002512 Diag(Arg->getLocStart(), diag::warn_assume_side_effects)
Hal Finkelbcc06082014-09-07 22:58:14 +00002513 << Arg->getSourceRange()
2514 << cast<FunctionDecl>(TheCall->getCalleeDecl())->getIdentifier();
2515
2516 return false;
2517}
2518
2519/// Handle __builtin_assume_aligned. This is declared
2520/// as (const void*, size_t, ...) and can take one optional constant int arg.
2521bool Sema::SemaBuiltinAssumeAligned(CallExpr *TheCall) {
2522 unsigned NumArgs = TheCall->getNumArgs();
2523
2524 if (NumArgs > 3)
2525 return Diag(TheCall->getLocEnd(),
2526 diag::err_typecheck_call_too_many_args_at_most)
2527 << 0 /*function call*/ << 3 << NumArgs
2528 << TheCall->getSourceRange();
2529
2530 // The alignment must be a constant integer.
2531 Expr *Arg = TheCall->getArg(1);
2532
2533 // We can't check the value of a dependent argument.
2534 if (!Arg->isTypeDependent() && !Arg->isValueDependent()) {
2535 llvm::APSInt Result;
2536 if (SemaBuiltinConstantArg(TheCall, 1, Result))
2537 return true;
2538
2539 if (!Result.isPowerOf2())
2540 return Diag(TheCall->getLocStart(),
2541 diag::err_alignment_not_power_of_two)
2542 << Arg->getSourceRange();
2543 }
2544
2545 if (NumArgs > 2) {
2546 ExprResult Arg(TheCall->getArg(2));
2547 InitializedEntity Entity = InitializedEntity::InitializeParameter(Context,
2548 Context.getSizeType(), false);
2549 Arg = PerformCopyInitialization(Entity, SourceLocation(), Arg);
2550 if (Arg.isInvalid()) return true;
2551 TheCall->setArg(2, Arg.get());
2552 }
Hal Finkelf0417332014-07-17 14:25:55 +00002553
2554 return false;
2555}
2556
Eric Christopher8d0c6212010-04-17 02:26:23 +00002557/// SemaBuiltinConstantArg - Handle a check if argument ArgNum of CallExpr
2558/// TheCall is a constant expression.
2559bool Sema::SemaBuiltinConstantArg(CallExpr *TheCall, int ArgNum,
2560 llvm::APSInt &Result) {
2561 Expr *Arg = TheCall->getArg(ArgNum);
2562 DeclRefExpr *DRE =cast<DeclRefExpr>(TheCall->getCallee()->IgnoreParenCasts());
2563 FunctionDecl *FDecl = cast<FunctionDecl>(DRE->getDecl());
2564
2565 if (Arg->isTypeDependent() || Arg->isValueDependent()) return false;
2566
2567 if (!Arg->isIntegerConstantExpr(Result, Context))
2568 return Diag(TheCall->getLocStart(), diag::err_constant_integer_arg_type)
Eric Christopher63448c32010-04-19 18:23:02 +00002569 << FDecl->getDeclName() << Arg->getSourceRange();
Eric Christopher8d0c6212010-04-17 02:26:23 +00002570
Chris Lattnerd545ad12009-09-23 06:06:36 +00002571 return false;
2572}
2573
Richard Sandiford28940af2014-04-16 08:47:51 +00002574/// SemaBuiltinConstantArgRange - Handle a check if argument ArgNum of CallExpr
2575/// TheCall is a constant expression in the range [Low, High].
2576bool Sema::SemaBuiltinConstantArgRange(CallExpr *TheCall, int ArgNum,
2577 int Low, int High) {
Eric Christopher8d0c6212010-04-17 02:26:23 +00002578 llvm::APSInt Result;
Douglas Gregor98c3cfc2012-06-29 01:05:22 +00002579
2580 // We can't check the value of a dependent argument.
Richard Sandiford28940af2014-04-16 08:47:51 +00002581 Expr *Arg = TheCall->getArg(ArgNum);
2582 if (Arg->isTypeDependent() || Arg->isValueDependent())
Douglas Gregor98c3cfc2012-06-29 01:05:22 +00002583 return false;
2584
Eric Christopher8d0c6212010-04-17 02:26:23 +00002585 // Check constant-ness first.
Richard Sandiford28940af2014-04-16 08:47:51 +00002586 if (SemaBuiltinConstantArg(TheCall, ArgNum, Result))
Eric Christopher8d0c6212010-04-17 02:26:23 +00002587 return true;
2588
Richard Sandiford28940af2014-04-16 08:47:51 +00002589 if (Result.getSExtValue() < Low || Result.getSExtValue() > High)
Chris Lattner3b054132008-11-19 05:08:23 +00002590 return Diag(TheCall->getLocStart(), diag::err_argument_invalid_range)
Richard Sandiford28940af2014-04-16 08:47:51 +00002591 << Low << High << Arg->getSourceRange();
Daniel Dunbarb0d34c82008-09-03 21:13:56 +00002592
2593 return false;
2594}
2595
Eli Friedmanc97d0142009-05-03 06:04:26 +00002596/// SemaBuiltinLongjmp - Handle __builtin_longjmp(void *env[5], int val).
Joerg Sonnenberger27173282015-03-11 23:46:32 +00002597/// This checks that the target supports __builtin_longjmp and
2598/// that val is a constant 1.
Eli Friedmaneed8ad22009-05-03 04:46:36 +00002599bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) {
Joerg Sonnenberger27173282015-03-11 23:46:32 +00002600 if (!Context.getTargetInfo().hasSjLjLowering())
2601 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_unsupported)
2602 << SourceRange(TheCall->getLocStart(), TheCall->getLocEnd());
2603
Eli Friedmaneed8ad22009-05-03 04:46:36 +00002604 Expr *Arg = TheCall->getArg(1);
Eric Christopher8d0c6212010-04-17 02:26:23 +00002605 llvm::APSInt Result;
Douglas Gregorc25f7662009-05-19 22:10:17 +00002606
Eric Christopher8d0c6212010-04-17 02:26:23 +00002607 // TODO: This is less than ideal. Overload this to take a value.
2608 if (SemaBuiltinConstantArg(TheCall, 1, Result))
2609 return true;
2610
2611 if (Result != 1)
Eli Friedmaneed8ad22009-05-03 04:46:36 +00002612 return Diag(TheCall->getLocStart(), diag::err_builtin_longjmp_invalid_val)
2613 << SourceRange(Arg->getLocStart(), Arg->getLocEnd());
2614
2615 return false;
2616}
2617
Joerg Sonnenberger27173282015-03-11 23:46:32 +00002618
2619/// SemaBuiltinSetjmp - Handle __builtin_setjmp(void *env[5]).
2620/// This checks that the target supports __builtin_setjmp.
2621bool Sema::SemaBuiltinSetjmp(CallExpr *TheCall) {
2622 if (!Context.getTargetInfo().hasSjLjLowering())
2623 return Diag(TheCall->getLocStart(), diag::err_builtin_setjmp_unsupported)
2624 << SourceRange(TheCall->getLocStart(), TheCall->getLocEnd());
2625 return false;
2626}
2627
Richard Smithd7293d72013-08-05 18:49:43 +00002628namespace {
2629enum StringLiteralCheckType {
2630 SLCT_NotALiteral,
2631 SLCT_UncheckedLiteral,
2632 SLCT_CheckedLiteral
2633};
2634}
2635
Richard Smith55ce3522012-06-25 20:30:08 +00002636// Determine if an expression is a string literal or constant string.
2637// If this function returns false on the arguments to a function expecting a
2638// format string, we will usually need to emit a warning.
2639// True string literals are then checked by CheckFormatString.
Richard Smithd7293d72013-08-05 18:49:43 +00002640static StringLiteralCheckType
2641checkFormatStringExpr(Sema &S, const Expr *E, ArrayRef<const Expr *> Args,
2642 bool HasVAListArg, unsigned format_idx,
2643 unsigned firstDataArg, Sema::FormatStringType Type,
2644 Sema::VariadicCallType CallType, bool InFunctionCall,
2645 llvm::SmallBitVector &CheckedVarArgs) {
Ted Kremenek808829352010-09-09 03:51:39 +00002646 tryAgain:
Douglas Gregorc25f7662009-05-19 22:10:17 +00002647 if (E->isTypeDependent() || E->isValueDependent())
Richard Smith55ce3522012-06-25 20:30:08 +00002648 return SLCT_NotALiteral;
Ted Kremenek6dfeb552009-01-12 23:09:09 +00002649
Jean-Daniel Dupas028573e72012-01-30 08:46:47 +00002650 E = E->IgnoreParenCasts();
Peter Collingbourne91147592011-04-15 00:35:48 +00002651
Richard Smithd7293d72013-08-05 18:49:43 +00002652 if (E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull))
David Blaikie59fe3f82012-02-10 21:07:25 +00002653 // Technically -Wformat-nonliteral does not warn about this case.
2654 // The behavior of printf and friends in this case is implementation
2655 // dependent. Ideally if the format string cannot be null then
2656 // it should have a 'nonnull' attribute in the function prototype.
Richard Smithd7293d72013-08-05 18:49:43 +00002657 return SLCT_UncheckedLiteral;
David Blaikie59fe3f82012-02-10 21:07:25 +00002658
Ted Kremenek6dfeb552009-01-12 23:09:09 +00002659 switch (E->getStmtClass()) {
John McCallc07a0c72011-02-17 10:25:35 +00002660 case Stmt::BinaryConditionalOperatorClass:
Ted Kremenek6dfeb552009-01-12 23:09:09 +00002661 case Stmt::ConditionalOperatorClass: {
Richard Smith55ce3522012-06-25 20:30:08 +00002662 // The expression is a literal if both sub-expressions were, and it was
2663 // completely checked only if both sub-expressions were checked.
2664 const AbstractConditionalOperator *C =
2665 cast<AbstractConditionalOperator>(E);
2666 StringLiteralCheckType Left =
Richard Smithd7293d72013-08-05 18:49:43 +00002667 checkFormatStringExpr(S, C->getTrueExpr(), Args,
Richard Smith55ce3522012-06-25 20:30:08 +00002668 HasVAListArg, format_idx, firstDataArg,
Richard Smithd7293d72013-08-05 18:49:43 +00002669 Type, CallType, InFunctionCall, CheckedVarArgs);
Richard Smith55ce3522012-06-25 20:30:08 +00002670 if (Left == SLCT_NotALiteral)
2671 return SLCT_NotALiteral;
2672 StringLiteralCheckType Right =
Richard Smithd7293d72013-08-05 18:49:43 +00002673 checkFormatStringExpr(S, C->getFalseExpr(), Args,
Richard Smith55ce3522012-06-25 20:30:08 +00002674 HasVAListArg, format_idx, firstDataArg,
Richard Smithd7293d72013-08-05 18:49:43 +00002675 Type, CallType, InFunctionCall, CheckedVarArgs);
Richard Smith55ce3522012-06-25 20:30:08 +00002676 return Left < Right ? Left : Right;
Ted Kremenek6dfeb552009-01-12 23:09:09 +00002677 }
2678
2679 case Stmt::ImplicitCastExprClass: {
Ted Kremenek808829352010-09-09 03:51:39 +00002680 E = cast<ImplicitCastExpr>(E)->getSubExpr();
2681 goto tryAgain;
Ted Kremenek6dfeb552009-01-12 23:09:09 +00002682 }
2683
John McCallc07a0c72011-02-17 10:25:35 +00002684 case Stmt::OpaqueValueExprClass:
2685 if (const Expr *src = cast<OpaqueValueExpr>(E)->getSourceExpr()) {
2686 E = src;
2687 goto tryAgain;
2688 }
Richard Smith55ce3522012-06-25 20:30:08 +00002689 return SLCT_NotALiteral;
John McCallc07a0c72011-02-17 10:25:35 +00002690
Ted Kremeneka8890832011-02-24 23:03:04 +00002691 case Stmt::PredefinedExprClass:
2692 // While __func__, etc., are technically not string literals, they
2693 // cannot contain format specifiers and thus are not a security
2694 // liability.
Richard Smith55ce3522012-06-25 20:30:08 +00002695 return SLCT_UncheckedLiteral;
Ted Kremeneka8890832011-02-24 23:03:04 +00002696
Ted Kremenekdfd72c22009-03-20 21:35:28 +00002697 case Stmt::DeclRefExprClass: {
2698 const DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump11289f42009-09-09 15:08:12 +00002699
Ted Kremenekdfd72c22009-03-20 21:35:28 +00002700 // As an exception, do not flag errors for variables binding to
2701 // const string literals.
2702 if (const VarDecl *VD = dyn_cast<VarDecl>(DR->getDecl())) {
2703 bool isConstant = false;
2704 QualType T = DR->getType();
Ted Kremenek6dfeb552009-01-12 23:09:09 +00002705
Richard Smithd7293d72013-08-05 18:49:43 +00002706 if (const ArrayType *AT = S.Context.getAsArrayType(T)) {
2707 isConstant = AT->getElementType().isConstant(S.Context);
Mike Stump12b8ce12009-08-04 21:02:39 +00002708 } else if (const PointerType *PT = T->getAs<PointerType>()) {
Richard Smithd7293d72013-08-05 18:49:43 +00002709 isConstant = T.isConstant(S.Context) &&
2710 PT->getPointeeType().isConstant(S.Context);
Jean-Daniel Dupasd5f7ef42012-01-25 10:35:33 +00002711 } else if (T->isObjCObjectPointerType()) {
2712 // In ObjC, there is usually no "const ObjectPointer" type,
2713 // so don't check if the pointee type is constant.
Richard Smithd7293d72013-08-05 18:49:43 +00002714 isConstant = T.isConstant(S.Context);
Ted Kremenekdfd72c22009-03-20 21:35:28 +00002715 }
Mike Stump11289f42009-09-09 15:08:12 +00002716
Ted Kremenekdfd72c22009-03-20 21:35:28 +00002717 if (isConstant) {
Matt Beaumont-Gayd8735082012-05-11 22:10:59 +00002718 if (const Expr *Init = VD->getAnyInitializer()) {
2719 // Look through initializers like const char c[] = { "foo" }
2720 if (const InitListExpr *InitList = dyn_cast<InitListExpr>(Init)) {
2721 if (InitList->isStringLiteralInit())
2722 Init = InitList->getInit(0)->IgnoreParenImpCasts();
2723 }
Richard Smithd7293d72013-08-05 18:49:43 +00002724 return checkFormatStringExpr(S, Init, Args,
Richard Smith55ce3522012-06-25 20:30:08 +00002725 HasVAListArg, format_idx,
Jordan Rose3e0ec582012-07-19 18:10:23 +00002726 firstDataArg, Type, CallType,
Richard Smithd7293d72013-08-05 18:49:43 +00002727 /*InFunctionCall*/false, CheckedVarArgs);
Matt Beaumont-Gayd8735082012-05-11 22:10:59 +00002728 }
Ted Kremenekdfd72c22009-03-20 21:35:28 +00002729 }
Mike Stump11289f42009-09-09 15:08:12 +00002730
Anders Carlssonb012ca92009-06-28 19:55:58 +00002731 // For vprintf* functions (i.e., HasVAListArg==true), we add a
2732 // special check to see if the format string is a function parameter
2733 // of the function calling the printf function. If the function
2734 // has an attribute indicating it is a printf-like function, then we
2735 // should suppress warnings concerning non-literals being used in a call
2736 // to a vprintf function. For example:
2737 //
2738 // void
2739 // logmessage(char const *fmt __attribute__ (format (printf, 1, 2)), ...){
2740 // va_list ap;
2741 // va_start(ap, fmt);
2742 // vprintf(fmt, ap); // Do NOT emit a warning about "fmt".
2743 // ...
Richard Smithd7293d72013-08-05 18:49:43 +00002744 // }
Jean-Daniel Dupas58dab682012-02-21 20:00:53 +00002745 if (HasVAListArg) {
2746 if (const ParmVarDecl *PV = dyn_cast<ParmVarDecl>(VD)) {
2747 if (const NamedDecl *ND = dyn_cast<NamedDecl>(PV->getDeclContext())) {
2748 int PVIndex = PV->getFunctionScopeIndex() + 1;
Aaron Ballmanbe22bcb2014-03-10 17:08:28 +00002749 for (const auto *PVFormat : ND->specific_attrs<FormatAttr>()) {
Jean-Daniel Dupas58dab682012-02-21 20:00:53 +00002750 // adjust for implicit parameter
2751 if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
2752 if (MD->isInstance())
2753 ++PVIndex;
2754 // We also check if the formats are compatible.
2755 // We can't pass a 'scanf' string to a 'printf' function.
2756 if (PVIndex == PVFormat->getFormatIdx() &&
Richard Smithd7293d72013-08-05 18:49:43 +00002757 Type == S.GetFormatStringType(PVFormat))
Richard Smith55ce3522012-06-25 20:30:08 +00002758 return SLCT_UncheckedLiteral;
Jean-Daniel Dupas58dab682012-02-21 20:00:53 +00002759 }
2760 }
2761 }
2762 }
Ted Kremenekdfd72c22009-03-20 21:35:28 +00002763 }
Mike Stump11289f42009-09-09 15:08:12 +00002764
Richard Smith55ce3522012-06-25 20:30:08 +00002765 return SLCT_NotALiteral;
Ted Kremenekdfd72c22009-03-20 21:35:28 +00002766 }
Ted Kremenek6dfeb552009-01-12 23:09:09 +00002767
Jean-Daniel Dupas6255bd12012-02-07 19:01:42 +00002768 case Stmt::CallExprClass:
2769 case Stmt::CXXMemberCallExprClass: {
Anders Carlssonf0a7f3b2009-06-27 04:05:33 +00002770 const CallExpr *CE = cast<CallExpr>(E);
Jean-Daniel Dupas6255bd12012-02-07 19:01:42 +00002771 if (const NamedDecl *ND = dyn_cast_or_null<NamedDecl>(CE->getCalleeDecl())) {
2772 if (const FormatArgAttr *FA = ND->getAttr<FormatArgAttr>()) {
2773 unsigned ArgIndex = FA->getFormatIdx();
2774 if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(ND))
2775 if (MD->isInstance())
2776 --ArgIndex;
2777 const Expr *Arg = CE->getArg(ArgIndex - 1);
Mike Stump11289f42009-09-09 15:08:12 +00002778
Richard Smithd7293d72013-08-05 18:49:43 +00002779 return checkFormatStringExpr(S, Arg, Args,
Richard Smith55ce3522012-06-25 20:30:08 +00002780 HasVAListArg, format_idx, firstDataArg,
Richard Smithd7293d72013-08-05 18:49:43 +00002781 Type, CallType, InFunctionCall,
2782 CheckedVarArgs);
Jordan Rose97c6f2b2012-06-04 23:52:23 +00002783 } else if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(ND)) {
2784 unsigned BuiltinID = FD->getBuiltinID();
2785 if (BuiltinID == Builtin::BI__builtin___CFStringMakeConstantString ||
2786 BuiltinID == Builtin::BI__builtin___NSStringMakeConstantString) {
2787 const Expr *Arg = CE->getArg(0);
Richard Smithd7293d72013-08-05 18:49:43 +00002788 return checkFormatStringExpr(S, Arg, Args,
Richard Smith55ce3522012-06-25 20:30:08 +00002789 HasVAListArg, format_idx,
Jordan Rose3e0ec582012-07-19 18:10:23 +00002790 firstDataArg, Type, CallType,
Richard Smithd7293d72013-08-05 18:49:43 +00002791 InFunctionCall, CheckedVarArgs);
Jordan Rose97c6f2b2012-06-04 23:52:23 +00002792 }
Anders Carlssonf0a7f3b2009-06-27 04:05:33 +00002793 }
2794 }
Mike Stump11289f42009-09-09 15:08:12 +00002795
Richard Smith55ce3522012-06-25 20:30:08 +00002796 return SLCT_NotALiteral;
Anders Carlssonf0a7f3b2009-06-27 04:05:33 +00002797 }
Ted Kremenekdfd72c22009-03-20 21:35:28 +00002798 case Stmt::ObjCStringLiteralClass:
2799 case Stmt::StringLiteralClass: {
Craig Topperc3ec1492014-05-26 06:22:03 +00002800 const StringLiteral *StrE = nullptr;
Mike Stump11289f42009-09-09 15:08:12 +00002801
Ted Kremenekdfd72c22009-03-20 21:35:28 +00002802 if (const ObjCStringLiteral *ObjCFExpr = dyn_cast<ObjCStringLiteral>(E))
Ted Kremenek6dfeb552009-01-12 23:09:09 +00002803 StrE = ObjCFExpr->getString();
2804 else
Ted Kremenekdfd72c22009-03-20 21:35:28 +00002805 StrE = cast<StringLiteral>(E);
Mike Stump11289f42009-09-09 15:08:12 +00002806
Ted Kremenek6dfeb552009-01-12 23:09:09 +00002807 if (StrE) {
Richard Smithd7293d72013-08-05 18:49:43 +00002808 S.CheckFormatString(StrE, E, Args, HasVAListArg, format_idx, firstDataArg,
2809 Type, InFunctionCall, CallType, CheckedVarArgs);
Richard Smith55ce3522012-06-25 20:30:08 +00002810 return SLCT_CheckedLiteral;
Ted Kremenek6dfeb552009-01-12 23:09:09 +00002811 }
Mike Stump11289f42009-09-09 15:08:12 +00002812
Richard Smith55ce3522012-06-25 20:30:08 +00002813 return SLCT_NotALiteral;
Ted Kremenek6dfeb552009-01-12 23:09:09 +00002814 }
Mike Stump11289f42009-09-09 15:08:12 +00002815
Ted Kremenekdfd72c22009-03-20 21:35:28 +00002816 default:
Richard Smith55ce3522012-06-25 20:30:08 +00002817 return SLCT_NotALiteral;
Ted Kremenek6dfeb552009-01-12 23:09:09 +00002818 }
2819}
2820
Jean-Daniel Dupas028573e72012-01-30 08:46:47 +00002821Sema::FormatStringType Sema::GetFormatStringType(const FormatAttr *Format) {
Aaron Ballmanf58070b2013-09-03 21:02:22 +00002822 return llvm::StringSwitch<FormatStringType>(Format->getType()->getName())
Jean-Daniel Dupas028573e72012-01-30 08:46:47 +00002823 .Case("scanf", FST_Scanf)
2824 .Cases("printf", "printf0", FST_Printf)
2825 .Cases("NSString", "CFString", FST_NSString)
2826 .Case("strftime", FST_Strftime)
2827 .Case("strfmon", FST_Strfmon)
2828 .Cases("kprintf", "cmn_err", "vcmn_err", "zcmn_err", FST_Kprintf)
Dimitry Andric6b5ed342015-02-19 22:32:33 +00002829 .Case("freebsd_kprintf", FST_FreeBSDKPrintf)
Fariborz Jahanianf8dce0f2015-02-21 00:45:58 +00002830 .Case("os_trace", FST_OSTrace)
Jean-Daniel Dupas028573e72012-01-30 08:46:47 +00002831 .Default(FST_Unknown);
2832}
2833
Jordan Rose3e0ec582012-07-19 18:10:23 +00002834/// CheckFormatArguments - Check calls to printf and scanf (and similar
Ted Kremenek02087932010-07-16 02:11:22 +00002835/// functions) for correct use of format strings.
Richard Smith55ce3522012-06-25 20:30:08 +00002836/// Returns true if a format string has been fully checked.
Dmitri Gribenko765396f2013-01-13 20:46:02 +00002837bool Sema::CheckFormatArguments(const FormatAttr *Format,
2838 ArrayRef<const Expr *> Args,
2839 bool IsCXXMember,
Jordan Rose3e0ec582012-07-19 18:10:23 +00002840 VariadicCallType CallType,
Richard Smithd7293d72013-08-05 18:49:43 +00002841 SourceLocation Loc, SourceRange Range,
2842 llvm::SmallBitVector &CheckedVarArgs) {
Richard Smith55ce3522012-06-25 20:30:08 +00002843 FormatStringInfo FSI;
2844 if (getFormatStringInfo(Format, IsCXXMember, &FSI))
Dmitri Gribenko765396f2013-01-13 20:46:02 +00002845 return CheckFormatArguments(Args, FSI.HasVAListArg, FSI.FormatIdx,
Richard Smith55ce3522012-06-25 20:30:08 +00002846 FSI.FirstDataArg, GetFormatStringType(Format),
Richard Smithd7293d72013-08-05 18:49:43 +00002847 CallType, Loc, Range, CheckedVarArgs);
Richard Smith55ce3522012-06-25 20:30:08 +00002848 return false;
Jean-Daniel Dupas0ae6e672012-01-17 20:03:31 +00002849}
Sebastian Redl6eedcc12009-11-17 18:02:24 +00002850
Dmitri Gribenko765396f2013-01-13 20:46:02 +00002851bool Sema::CheckFormatArguments(ArrayRef<const Expr *> Args,
Jean-Daniel Dupas028573e72012-01-30 08:46:47 +00002852 bool HasVAListArg, unsigned format_idx,
2853 unsigned firstDataArg, FormatStringType Type,
Jordan Rose3e0ec582012-07-19 18:10:23 +00002854 VariadicCallType CallType,
Richard Smithd7293d72013-08-05 18:49:43 +00002855 SourceLocation Loc, SourceRange Range,
2856 llvm::SmallBitVector &CheckedVarArgs) {
Ted Kremenek02087932010-07-16 02:11:22 +00002857 // CHECK: printf/scanf-like function is called with no format string.
Dmitri Gribenko765396f2013-01-13 20:46:02 +00002858 if (format_idx >= Args.size()) {
Jean-Daniel Dupas0ae6e672012-01-17 20:03:31 +00002859 Diag(Loc, diag::warn_missing_format_string) << Range;
Richard Smith55ce3522012-06-25 20:30:08 +00002860 return false;
Ted Kremeneke68f1aa2007-08-14 17:39:48 +00002861 }
Mike Stump11289f42009-09-09 15:08:12 +00002862
Jean-Daniel Dupas0ae6e672012-01-17 20:03:31 +00002863 const Expr *OrigFormatExpr = Args[format_idx]->IgnoreParenCasts();
Mike Stump11289f42009-09-09 15:08:12 +00002864
Chris Lattnerb87b1b32007-08-10 20:18:51 +00002865 // CHECK: format string is not a string literal.
Mike Stump11289f42009-09-09 15:08:12 +00002866 //
Ted Kremeneke68f1aa2007-08-14 17:39:48 +00002867 // Dynamically generated format strings are difficult to
2868 // automatically vet at compile time. Requiring that format strings
2869 // are string literals: (1) permits the checking of format strings by
2870 // the compiler and thereby (2) can practically remove the source of
2871 // many format string exploits.
Ted Kremenek34f664d2008-06-16 18:00:42 +00002872
Mike Stump11289f42009-09-09 15:08:12 +00002873 // Format string can be either ObjC string (e.g. @"%d") or
Ted Kremenek34f664d2008-06-16 18:00:42 +00002874 // C string (e.g. "%d")
Mike Stump11289f42009-09-09 15:08:12 +00002875 // ObjC string uses the same format specifiers as C string, so we can use
Ted Kremenek34f664d2008-06-16 18:00:42 +00002876 // the same format string checking logic for both ObjC and C strings.
Richard Smith55ce3522012-06-25 20:30:08 +00002877 StringLiteralCheckType CT =
Richard Smithd7293d72013-08-05 18:49:43 +00002878 checkFormatStringExpr(*this, OrigFormatExpr, Args, HasVAListArg,
2879 format_idx, firstDataArg, Type, CallType,
2880 /*IsFunctionCall*/true, CheckedVarArgs);
Richard Smith55ce3522012-06-25 20:30:08 +00002881 if (CT != SLCT_NotALiteral)
2882 // Literal format string found, check done!
2883 return CT == SLCT_CheckedLiteral;
Ted Kremenek34f664d2008-06-16 18:00:42 +00002884
Jean-Daniel Dupas6567f482012-02-07 23:10:53 +00002885 // Strftime is particular as it always uses a single 'time' argument,
2886 // so it is safe to pass a non-literal string.
2887 if (Type == FST_Strftime)
Richard Smith55ce3522012-06-25 20:30:08 +00002888 return false;
Jean-Daniel Dupas6567f482012-02-07 23:10:53 +00002889
Jean-Daniel Dupas537aa1a2012-01-30 19:46:17 +00002890 // Do not emit diag when the string param is a macro expansion and the
2891 // format is either NSString or CFString. This is a hack to prevent
2892 // diag when using the NSLocalizedString and CFCopyLocalizedString macros
2893 // which are usually used in place of NS and CF string literals.
Jean-Daniel Dupas2b7da832012-05-04 21:08:08 +00002894 if (Type == FST_NSString &&
2895 SourceMgr.isInSystemMacro(Args[format_idx]->getLocStart()))
Richard Smith55ce3522012-06-25 20:30:08 +00002896 return false;
Jean-Daniel Dupas537aa1a2012-01-30 19:46:17 +00002897
Chris Lattnercc5d1c22009-04-29 04:59:47 +00002898 // If there are no arguments specified, warn with -Wformat-security, otherwise
2899 // warn only with -Wformat-nonliteral.
Eli Friedman0e5d6772013-06-18 18:10:01 +00002900 if (Args.size() == firstDataArg)
Jean-Daniel Dupas0ae6e672012-01-17 20:03:31 +00002901 Diag(Args[format_idx]->getLocStart(),
Ted Kremenek02087932010-07-16 02:11:22 +00002902 diag::warn_format_nonliteral_noargs)
Chris Lattnercc5d1c22009-04-29 04:59:47 +00002903 << OrigFormatExpr->getSourceRange();
2904 else
Jean-Daniel Dupas0ae6e672012-01-17 20:03:31 +00002905 Diag(Args[format_idx]->getLocStart(),
Ted Kremenek02087932010-07-16 02:11:22 +00002906 diag::warn_format_nonliteral)
Chris Lattnercc5d1c22009-04-29 04:59:47 +00002907 << OrigFormatExpr->getSourceRange();
Richard Smith55ce3522012-06-25 20:30:08 +00002908 return false;
Ted Kremenek6dfeb552009-01-12 23:09:09 +00002909}
Ted Kremeneke68f1aa2007-08-14 17:39:48 +00002910
Ted Kremenekab278de2010-01-28 23:39:18 +00002911namespace {
Ted Kremenek02087932010-07-16 02:11:22 +00002912class CheckFormatHandler : public analyze_format_string::FormatStringHandler {
2913protected:
Ted Kremenekab278de2010-01-28 23:39:18 +00002914 Sema &S;
2915 const StringLiteral *FExpr;
2916 const Expr *OrigFormatExpr;
Ted Kremenek4d745dd2010-03-25 03:59:12 +00002917 const unsigned FirstDataArg;
Ted Kremenekab278de2010-01-28 23:39:18 +00002918 const unsigned NumDataArgs;
Ted Kremenekab278de2010-01-28 23:39:18 +00002919 const char *Beg; // Start of format string.
Ted Kremenek5739de72010-01-29 01:06:55 +00002920 const bool HasVAListArg;
Dmitri Gribenko765396f2013-01-13 20:46:02 +00002921 ArrayRef<const Expr *> Args;
Ted Kremenek5739de72010-01-29 01:06:55 +00002922 unsigned FormatIdx;
Richard Smithd7293d72013-08-05 18:49:43 +00002923 llvm::SmallBitVector CoveredArgs;
Ted Kremenekd1668192010-02-27 01:41:03 +00002924 bool usesPositionalArgs;
2925 bool atFirstArg;
Richard Trieu03cf7b72011-10-28 00:41:25 +00002926 bool inFunctionCall;
Jordan Rose3e0ec582012-07-19 18:10:23 +00002927 Sema::VariadicCallType CallType;
Richard Smithd7293d72013-08-05 18:49:43 +00002928 llvm::SmallBitVector &CheckedVarArgs;
Ted Kremenekc8b188d2010-02-16 01:46:59 +00002929public:
Ted Kremenek02087932010-07-16 02:11:22 +00002930 CheckFormatHandler(Sema &s, const StringLiteral *fexpr,
Ted Kremenek4d745dd2010-03-25 03:59:12 +00002931 const Expr *origFormatExpr, unsigned firstDataArg,
Jordan Rose97c6f2b2012-06-04 23:52:23 +00002932 unsigned numDataArgs, const char *beg, bool hasVAListArg,
Dmitri Gribenko765396f2013-01-13 20:46:02 +00002933 ArrayRef<const Expr *> Args,
Jordan Rose3e0ec582012-07-19 18:10:23 +00002934 unsigned formatIdx, bool inFunctionCall,
Richard Smithd7293d72013-08-05 18:49:43 +00002935 Sema::VariadicCallType callType,
2936 llvm::SmallBitVector &CheckedVarArgs)
Ted Kremenekab278de2010-01-28 23:39:18 +00002937 : S(s), FExpr(fexpr), OrigFormatExpr(origFormatExpr),
Jordan Rose97c6f2b2012-06-04 23:52:23 +00002938 FirstDataArg(firstDataArg), NumDataArgs(numDataArgs),
2939 Beg(beg), HasVAListArg(hasVAListArg),
Dmitri Gribenko765396f2013-01-13 20:46:02 +00002940 Args(Args), FormatIdx(formatIdx),
Richard Trieu03cf7b72011-10-28 00:41:25 +00002941 usesPositionalArgs(false), atFirstArg(true),
Richard Smithd7293d72013-08-05 18:49:43 +00002942 inFunctionCall(inFunctionCall), CallType(callType),
2943 CheckedVarArgs(CheckedVarArgs) {
2944 CoveredArgs.resize(numDataArgs);
2945 CoveredArgs.reset();
2946 }
Ted Kremenekc8b188d2010-02-16 01:46:59 +00002947
Ted Kremenek019d2242010-01-29 01:50:07 +00002948 void DoneProcessing();
Ted Kremenekc8b188d2010-02-16 01:46:59 +00002949
Ted Kremenek02087932010-07-16 02:11:22 +00002950 void HandleIncompleteSpecifier(const char *startSpecifier,
Craig Toppere14c0f82014-03-12 04:55:44 +00002951 unsigned specifierLen) override;
Hans Wennborgc9dd9462012-02-22 10:17:01 +00002952
Jordan Rose92303592012-09-08 04:00:03 +00002953 void HandleInvalidLengthModifier(
Craig Toppere14c0f82014-03-12 04:55:44 +00002954 const analyze_format_string::FormatSpecifier &FS,
2955 const analyze_format_string::ConversionSpecifier &CS,
2956 const char *startSpecifier, unsigned specifierLen,
2957 unsigned DiagID);
Jordan Rose92303592012-09-08 04:00:03 +00002958
Hans Wennborgc9dd9462012-02-22 10:17:01 +00002959 void HandleNonStandardLengthModifier(
Craig Toppere14c0f82014-03-12 04:55:44 +00002960 const analyze_format_string::FormatSpecifier &FS,
2961 const char *startSpecifier, unsigned specifierLen);
Hans Wennborgc9dd9462012-02-22 10:17:01 +00002962
2963 void HandleNonStandardConversionSpecifier(
Craig Toppere14c0f82014-03-12 04:55:44 +00002964 const analyze_format_string::ConversionSpecifier &CS,
2965 const char *startSpecifier, unsigned specifierLen);
Hans Wennborgc9dd9462012-02-22 10:17:01 +00002966
Craig Toppere14c0f82014-03-12 04:55:44 +00002967 void HandlePosition(const char *startPos, unsigned posLen) override;
Hans Wennborgaa8c61c2012-03-09 10:10:54 +00002968
Craig Toppere14c0f82014-03-12 04:55:44 +00002969 void HandleInvalidPosition(const char *startSpecifier,
2970 unsigned specifierLen,
2971 analyze_format_string::PositionContext p) override;
Ted Kremenekd1668192010-02-27 01:41:03 +00002972
Craig Toppere14c0f82014-03-12 04:55:44 +00002973 void HandleZeroPosition(const char *startPos, unsigned posLen) override;
Ted Kremenekd1668192010-02-27 01:41:03 +00002974
Craig Toppere14c0f82014-03-12 04:55:44 +00002975 void HandleNullChar(const char *nullCharacter) override;
Ted Kremenekc8b188d2010-02-16 01:46:59 +00002976
Richard Trieu03cf7b72011-10-28 00:41:25 +00002977 template <typename Range>
2978 static void EmitFormatDiagnostic(Sema &S, bool inFunctionCall,
2979 const Expr *ArgumentExpr,
2980 PartialDiagnostic PDiag,
2981 SourceLocation StringLoc,
2982 bool IsStringLocation, Range StringRange,
Dmitri Gribenko44ebbd52013-05-05 00:41:58 +00002983 ArrayRef<FixItHint> Fixit = None);
Richard Trieu03cf7b72011-10-28 00:41:25 +00002984
Ted Kremenek02087932010-07-16 02:11:22 +00002985protected:
Ted Kremenekce815422010-07-19 21:25:57 +00002986 bool HandleInvalidConversionSpecifier(unsigned argIndex, SourceLocation Loc,
2987 const char *startSpec,
2988 unsigned specifierLen,
2989 const char *csStart, unsigned csLen);
Richard Trieu03cf7b72011-10-28 00:41:25 +00002990
2991 void HandlePositionalNonpositionalArgs(SourceLocation Loc,
2992 const char *startSpec,
2993 unsigned specifierLen);
Ted Kremenekce815422010-07-19 21:25:57 +00002994
Ted Kremenek8d9842d2010-01-29 20:55:36 +00002995 SourceRange getFormatStringRange();
Ted Kremenek02087932010-07-16 02:11:22 +00002996 CharSourceRange getSpecifierRange(const char *startSpecifier,
2997 unsigned specifierLen);
Ted Kremenekab278de2010-01-28 23:39:18 +00002998 SourceLocation getLocationOfByte(const char *x);
Ted Kremenekc8b188d2010-02-16 01:46:59 +00002999
Ted Kremenek5739de72010-01-29 01:06:55 +00003000 const Expr *getDataArg(unsigned i) const;
Ted Kremenek6adb7e32010-07-26 19:45:42 +00003001
3002 bool CheckNumArgs(const analyze_format_string::FormatSpecifier &FS,
3003 const analyze_format_string::ConversionSpecifier &CS,
3004 const char *startSpecifier, unsigned specifierLen,
3005 unsigned argIndex);
Richard Trieu03cf7b72011-10-28 00:41:25 +00003006
3007 template <typename Range>
3008 void EmitFormatDiagnostic(PartialDiagnostic PDiag, SourceLocation StringLoc,
3009 bool IsStringLocation, Range StringRange,
Dmitri Gribenko44ebbd52013-05-05 00:41:58 +00003010 ArrayRef<FixItHint> Fixit = None);
Ted Kremenekab278de2010-01-28 23:39:18 +00003011};
3012}
3013
Ted Kremenek02087932010-07-16 02:11:22 +00003014SourceRange CheckFormatHandler::getFormatStringRange() {
Ted Kremenekab278de2010-01-28 23:39:18 +00003015 return OrigFormatExpr->getSourceRange();
3016}
3017
Ted Kremenek02087932010-07-16 02:11:22 +00003018CharSourceRange CheckFormatHandler::
3019getSpecifierRange(const char *startSpecifier, unsigned specifierLen) {
Tom Care3f272b82010-06-21 21:21:01 +00003020 SourceLocation Start = getLocationOfByte(startSpecifier);
3021 SourceLocation End = getLocationOfByte(startSpecifier + specifierLen - 1);
3022
3023 // Advance the end SourceLocation by one due to half-open ranges.
Argyrios Kyrtzidise6e67de2011-09-19 20:40:19 +00003024 End = End.getLocWithOffset(1);
Tom Care3f272b82010-06-21 21:21:01 +00003025
3026 return CharSourceRange::getCharRange(Start, End);
Ted Kremenek8d9842d2010-01-29 20:55:36 +00003027}
3028
Ted Kremenek02087932010-07-16 02:11:22 +00003029SourceLocation CheckFormatHandler::getLocationOfByte(const char *x) {
Ted Kremenekc8b188d2010-02-16 01:46:59 +00003030 return S.getLocationOfStringLiteralByte(FExpr, x - Beg);
Ted Kremenekab278de2010-01-28 23:39:18 +00003031}
3032
Ted Kremenek02087932010-07-16 02:11:22 +00003033void CheckFormatHandler::HandleIncompleteSpecifier(const char *startSpecifier,
3034 unsigned specifierLen){
Richard Trieu03cf7b72011-10-28 00:41:25 +00003035 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_incomplete_specifier),
3036 getLocationOfByte(startSpecifier),
3037 /*IsStringLocation*/true,
3038 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenekc22f78d2010-01-29 03:16:21 +00003039}
3040
Jordan Rose92303592012-09-08 04:00:03 +00003041void CheckFormatHandler::HandleInvalidLengthModifier(
3042 const analyze_format_string::FormatSpecifier &FS,
3043 const analyze_format_string::ConversionSpecifier &CS,
Jordan Rose2f9cc042012-09-08 04:00:12 +00003044 const char *startSpecifier, unsigned specifierLen, unsigned DiagID) {
Jordan Rose92303592012-09-08 04:00:03 +00003045 using namespace analyze_format_string;
3046
3047 const LengthModifier &LM = FS.getLengthModifier();
3048 CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength());
3049
3050 // See if we know how to fix this length modifier.
David Blaikie05785d12013-02-20 22:23:23 +00003051 Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier();
Jordan Rose92303592012-09-08 04:00:03 +00003052 if (FixedLM) {
Jordan Rose2f9cc042012-09-08 04:00:12 +00003053 EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(),
Jordan Rose92303592012-09-08 04:00:03 +00003054 getLocationOfByte(LM.getStart()),
3055 /*IsStringLocation*/true,
3056 getSpecifierRange(startSpecifier, specifierLen));
3057
3058 S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier)
3059 << FixedLM->toString()
3060 << FixItHint::CreateReplacement(LMRange, FixedLM->toString());
3061
3062 } else {
Jordan Rose2f9cc042012-09-08 04:00:12 +00003063 FixItHint Hint;
3064 if (DiagID == diag::warn_format_nonsensical_length)
3065 Hint = FixItHint::CreateRemoval(LMRange);
3066
3067 EmitFormatDiagnostic(S.PDiag(DiagID) << LM.toString() << CS.toString(),
Jordan Rose92303592012-09-08 04:00:03 +00003068 getLocationOfByte(LM.getStart()),
3069 /*IsStringLocation*/true,
3070 getSpecifierRange(startSpecifier, specifierLen),
Jordan Rose2f9cc042012-09-08 04:00:12 +00003071 Hint);
Jordan Rose92303592012-09-08 04:00:03 +00003072 }
3073}
3074
Hans Wennborgc9dd9462012-02-22 10:17:01 +00003075void CheckFormatHandler::HandleNonStandardLengthModifier(
Jordan Rose2f9cc042012-09-08 04:00:12 +00003076 const analyze_format_string::FormatSpecifier &FS,
Hans Wennborgc9dd9462012-02-22 10:17:01 +00003077 const char *startSpecifier, unsigned specifierLen) {
Jordan Rose2f9cc042012-09-08 04:00:12 +00003078 using namespace analyze_format_string;
3079
3080 const LengthModifier &LM = FS.getLengthModifier();
3081 CharSourceRange LMRange = getSpecifierRange(LM.getStart(), LM.getLength());
3082
3083 // See if we know how to fix this length modifier.
David Blaikie05785d12013-02-20 22:23:23 +00003084 Optional<LengthModifier> FixedLM = FS.getCorrectedLengthModifier();
Jordan Rose2f9cc042012-09-08 04:00:12 +00003085 if (FixedLM) {
3086 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
3087 << LM.toString() << 0,
3088 getLocationOfByte(LM.getStart()),
3089 /*IsStringLocation*/true,
3090 getSpecifierRange(startSpecifier, specifierLen));
3091
3092 S.Diag(getLocationOfByte(LM.getStart()), diag::note_format_fix_specifier)
3093 << FixedLM->toString()
3094 << FixItHint::CreateReplacement(LMRange, FixedLM->toString());
3095
3096 } else {
3097 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
3098 << LM.toString() << 0,
3099 getLocationOfByte(LM.getStart()),
3100 /*IsStringLocation*/true,
3101 getSpecifierRange(startSpecifier, specifierLen));
3102 }
Hans Wennborgc9dd9462012-02-22 10:17:01 +00003103}
3104
3105void CheckFormatHandler::HandleNonStandardConversionSpecifier(
3106 const analyze_format_string::ConversionSpecifier &CS,
3107 const char *startSpecifier, unsigned specifierLen) {
Jordan Rose4c266aa2012-09-13 02:11:15 +00003108 using namespace analyze_format_string;
3109
3110 // See if we know how to fix this conversion specifier.
David Blaikie05785d12013-02-20 22:23:23 +00003111 Optional<ConversionSpecifier> FixedCS = CS.getStandardSpecifier();
Jordan Rose4c266aa2012-09-13 02:11:15 +00003112 if (FixedCS) {
3113 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
3114 << CS.toString() << /*conversion specifier*/1,
3115 getLocationOfByte(CS.getStart()),
3116 /*IsStringLocation*/true,
3117 getSpecifierRange(startSpecifier, specifierLen));
3118
3119 CharSourceRange CSRange = getSpecifierRange(CS.getStart(), CS.getLength());
3120 S.Diag(getLocationOfByte(CS.getStart()), diag::note_format_fix_specifier)
3121 << FixedCS->toString()
3122 << FixItHint::CreateReplacement(CSRange, FixedCS->toString());
3123 } else {
3124 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard)
3125 << CS.toString() << /*conversion specifier*/1,
3126 getLocationOfByte(CS.getStart()),
3127 /*IsStringLocation*/true,
3128 getSpecifierRange(startSpecifier, specifierLen));
3129 }
Hans Wennborgc9dd9462012-02-22 10:17:01 +00003130}
3131
Hans Wennborgaa8c61c2012-03-09 10:10:54 +00003132void CheckFormatHandler::HandlePosition(const char *startPos,
3133 unsigned posLen) {
3134 EmitFormatDiagnostic(S.PDiag(diag::warn_format_non_standard_positional_arg),
3135 getLocationOfByte(startPos),
3136 /*IsStringLocation*/true,
3137 getSpecifierRange(startPos, posLen));
3138}
3139
Ted Kremenekd1668192010-02-27 01:41:03 +00003140void
Ted Kremenek02087932010-07-16 02:11:22 +00003141CheckFormatHandler::HandleInvalidPosition(const char *startPos, unsigned posLen,
3142 analyze_format_string::PositionContext p) {
Richard Trieu03cf7b72011-10-28 00:41:25 +00003143 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_positional_specifier)
3144 << (unsigned) p,
3145 getLocationOfByte(startPos), /*IsStringLocation*/true,
3146 getSpecifierRange(startPos, posLen));
Ted Kremenekd1668192010-02-27 01:41:03 +00003147}
3148
Ted Kremenek02087932010-07-16 02:11:22 +00003149void CheckFormatHandler::HandleZeroPosition(const char *startPos,
Ted Kremenekd1668192010-02-27 01:41:03 +00003150 unsigned posLen) {
Richard Trieu03cf7b72011-10-28 00:41:25 +00003151 EmitFormatDiagnostic(S.PDiag(diag::warn_format_zero_positional_specifier),
3152 getLocationOfByte(startPos),
3153 /*IsStringLocation*/true,
3154 getSpecifierRange(startPos, posLen));
Ted Kremenekd1668192010-02-27 01:41:03 +00003155}
3156
Ted Kremenek02087932010-07-16 02:11:22 +00003157void CheckFormatHandler::HandleNullChar(const char *nullCharacter) {
Jordan Rose97c6f2b2012-06-04 23:52:23 +00003158 if (!isa<ObjCStringLiteral>(OrigFormatExpr)) {
Ted Kremenek0d5b9ef2011-03-15 21:18:48 +00003159 // The presence of a null character is likely an error.
Richard Trieu03cf7b72011-10-28 00:41:25 +00003160 EmitFormatDiagnostic(
3161 S.PDiag(diag::warn_printf_format_string_contains_null_char),
3162 getLocationOfByte(nullCharacter), /*IsStringLocation*/true,
3163 getFormatStringRange());
Ted Kremenek0d5b9ef2011-03-15 21:18:48 +00003164 }
Ted Kremenek02087932010-07-16 02:11:22 +00003165}
Ted Kremenekc8b188d2010-02-16 01:46:59 +00003166
Jordan Rose58bbe422012-07-19 18:10:08 +00003167// Note that this may return NULL if there was an error parsing or building
3168// one of the argument expressions.
Ted Kremenek02087932010-07-16 02:11:22 +00003169const Expr *CheckFormatHandler::getDataArg(unsigned i) const {
Jean-Daniel Dupas0ae6e672012-01-17 20:03:31 +00003170 return Args[FirstDataArg + i];
Ted Kremenek02087932010-07-16 02:11:22 +00003171}
3172
3173void CheckFormatHandler::DoneProcessing() {
3174 // Does the number of data arguments exceed the number of
3175 // format conversions in the format string?
3176 if (!HasVAListArg) {
3177 // Find any arguments that weren't covered.
3178 CoveredArgs.flip();
3179 signed notCoveredArg = CoveredArgs.find_first();
3180 if (notCoveredArg >= 0) {
3181 assert((unsigned)notCoveredArg < NumDataArgs);
Jordan Rose58bbe422012-07-19 18:10:08 +00003182 if (const Expr *E = getDataArg((unsigned) notCoveredArg)) {
3183 SourceLocation Loc = E->getLocStart();
3184 if (!S.getSourceManager().isInSystemMacro(Loc)) {
3185 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_data_arg_not_used),
3186 Loc, /*IsStringLocation*/false,
3187 getFormatStringRange());
3188 }
Bob Wilson23cd4342012-05-03 19:47:19 +00003189 }
Ted Kremenek02087932010-07-16 02:11:22 +00003190 }
3191 }
3192}
3193
Ted Kremenekce815422010-07-19 21:25:57 +00003194bool
3195CheckFormatHandler::HandleInvalidConversionSpecifier(unsigned argIndex,
3196 SourceLocation Loc,
3197 const char *startSpec,
3198 unsigned specifierLen,
3199 const char *csStart,
3200 unsigned csLen) {
3201
3202 bool keepGoing = true;
3203 if (argIndex < NumDataArgs) {
3204 // Consider the argument coverered, even though the specifier doesn't
3205 // make sense.
3206 CoveredArgs.set(argIndex);
3207 }
3208 else {
3209 // If argIndex exceeds the number of data arguments we
3210 // don't issue a warning because that is just a cascade of warnings (and
3211 // they may have intended '%%' anyway). We don't want to continue processing
3212 // the format string after this point, however, as we will like just get
3213 // gibberish when trying to match arguments.
3214 keepGoing = false;
3215 }
3216
Richard Trieu03cf7b72011-10-28 00:41:25 +00003217 EmitFormatDiagnostic(S.PDiag(diag::warn_format_invalid_conversion)
3218 << StringRef(csStart, csLen),
3219 Loc, /*IsStringLocation*/true,
3220 getSpecifierRange(startSpec, specifierLen));
Ted Kremenekce815422010-07-19 21:25:57 +00003221
3222 return keepGoing;
3223}
3224
Richard Trieu03cf7b72011-10-28 00:41:25 +00003225void
3226CheckFormatHandler::HandlePositionalNonpositionalArgs(SourceLocation Loc,
3227 const char *startSpec,
3228 unsigned specifierLen) {
3229 EmitFormatDiagnostic(
3230 S.PDiag(diag::warn_format_mix_positional_nonpositional_args),
3231 Loc, /*isStringLoc*/true, getSpecifierRange(startSpec, specifierLen));
3232}
3233
Ted Kremenek6adb7e32010-07-26 19:45:42 +00003234bool
3235CheckFormatHandler::CheckNumArgs(
3236 const analyze_format_string::FormatSpecifier &FS,
3237 const analyze_format_string::ConversionSpecifier &CS,
3238 const char *startSpecifier, unsigned specifierLen, unsigned argIndex) {
3239
3240 if (argIndex >= NumDataArgs) {
Richard Trieu03cf7b72011-10-28 00:41:25 +00003241 PartialDiagnostic PDiag = FS.usesPositionalArg()
3242 ? (S.PDiag(diag::warn_printf_positional_arg_exceeds_data_args)
3243 << (argIndex+1) << NumDataArgs)
3244 : S.PDiag(diag::warn_printf_insufficient_data_args);
3245 EmitFormatDiagnostic(
3246 PDiag, getLocationOfByte(CS.getStart()), /*IsStringLocation*/true,
3247 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek6adb7e32010-07-26 19:45:42 +00003248 return false;
3249 }
3250 return true;
3251}
3252
Richard Trieu03cf7b72011-10-28 00:41:25 +00003253template<typename Range>
3254void CheckFormatHandler::EmitFormatDiagnostic(PartialDiagnostic PDiag,
3255 SourceLocation Loc,
3256 bool IsStringLocation,
3257 Range StringRange,
Jordan Roseaee34382012-09-05 22:56:26 +00003258 ArrayRef<FixItHint> FixIt) {
Jean-Daniel Dupas0ae6e672012-01-17 20:03:31 +00003259 EmitFormatDiagnostic(S, inFunctionCall, Args[FormatIdx], PDiag,
Richard Trieu03cf7b72011-10-28 00:41:25 +00003260 Loc, IsStringLocation, StringRange, FixIt);
3261}
3262
3263/// \brief If the format string is not within the funcion call, emit a note
3264/// so that the function call and string are in diagnostic messages.
3265///
Dmitri Gribenkoadba9be2012-08-23 17:58:28 +00003266/// \param InFunctionCall if true, the format string is within the function
Richard Trieu03cf7b72011-10-28 00:41:25 +00003267/// call and only one diagnostic message will be produced. Otherwise, an
3268/// extra note will be emitted pointing to location of the format string.
3269///
3270/// \param ArgumentExpr the expression that is passed as the format string
3271/// argument in the function call. Used for getting locations when two
3272/// diagnostics are emitted.
3273///
3274/// \param PDiag the callee should already have provided any strings for the
3275/// diagnostic message. This function only adds locations and fixits
3276/// to diagnostics.
3277///
3278/// \param Loc primary location for diagnostic. If two diagnostics are
3279/// required, one will be at Loc and a new SourceLocation will be created for
3280/// the other one.
3281///
3282/// \param IsStringLocation if true, Loc points to the format string should be
3283/// used for the note. Otherwise, Loc points to the argument list and will
3284/// be used with PDiag.
3285///
3286/// \param StringRange some or all of the string to highlight. This is
3287/// templated so it can accept either a CharSourceRange or a SourceRange.
3288///
Dmitri Gribenkoadba9be2012-08-23 17:58:28 +00003289/// \param FixIt optional fix it hint for the format string.
Richard Trieu03cf7b72011-10-28 00:41:25 +00003290template<typename Range>
3291void CheckFormatHandler::EmitFormatDiagnostic(Sema &S, bool InFunctionCall,
3292 const Expr *ArgumentExpr,
3293 PartialDiagnostic PDiag,
3294 SourceLocation Loc,
3295 bool IsStringLocation,
3296 Range StringRange,
Jordan Roseaee34382012-09-05 22:56:26 +00003297 ArrayRef<FixItHint> FixIt) {
3298 if (InFunctionCall) {
3299 const Sema::SemaDiagnosticBuilder &D = S.Diag(Loc, PDiag);
3300 D << StringRange;
Alexander Kornienkoa9b01eb2015-02-25 14:40:56 +00003301 D << FixIt;
Jordan Roseaee34382012-09-05 22:56:26 +00003302 } else {
Richard Trieu03cf7b72011-10-28 00:41:25 +00003303 S.Diag(IsStringLocation ? ArgumentExpr->getExprLoc() : Loc, PDiag)
3304 << ArgumentExpr->getSourceRange();
Jordan Roseaee34382012-09-05 22:56:26 +00003305
3306 const Sema::SemaDiagnosticBuilder &Note =
3307 S.Diag(IsStringLocation ? Loc : StringRange.getBegin(),
3308 diag::note_format_string_defined);
3309
3310 Note << StringRange;
Alexander Kornienkoa9b01eb2015-02-25 14:40:56 +00003311 Note << FixIt;
Richard Trieu03cf7b72011-10-28 00:41:25 +00003312 }
3313}
3314
Ted Kremenek02087932010-07-16 02:11:22 +00003315//===--- CHECK: Printf format string checking ------------------------------===//
3316
3317namespace {
3318class CheckPrintfHandler : public CheckFormatHandler {
Jordan Rose97c6f2b2012-06-04 23:52:23 +00003319 bool ObjCContext;
Ted Kremenek02087932010-07-16 02:11:22 +00003320public:
3321 CheckPrintfHandler(Sema &s, const StringLiteral *fexpr,
3322 const Expr *origFormatExpr, unsigned firstDataArg,
Jordan Rose97c6f2b2012-06-04 23:52:23 +00003323 unsigned numDataArgs, bool isObjC,
Ted Kremenek02087932010-07-16 02:11:22 +00003324 const char *beg, bool hasVAListArg,
Dmitri Gribenko765396f2013-01-13 20:46:02 +00003325 ArrayRef<const Expr *> Args,
Jordan Rose3e0ec582012-07-19 18:10:23 +00003326 unsigned formatIdx, bool inFunctionCall,
Richard Smithd7293d72013-08-05 18:49:43 +00003327 Sema::VariadicCallType CallType,
3328 llvm::SmallBitVector &CheckedVarArgs)
3329 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
3330 numDataArgs, beg, hasVAListArg, Args,
3331 formatIdx, inFunctionCall, CallType, CheckedVarArgs),
3332 ObjCContext(isObjC)
Jordan Rose3e0ec582012-07-19 18:10:23 +00003333 {}
3334
Craig Toppere14c0f82014-03-12 04:55:44 +00003335
Ted Kremenek02087932010-07-16 02:11:22 +00003336 bool HandleInvalidPrintfConversionSpecifier(
3337 const analyze_printf::PrintfSpecifier &FS,
3338 const char *startSpecifier,
Craig Toppere14c0f82014-03-12 04:55:44 +00003339 unsigned specifierLen) override;
3340
Ted Kremenek02087932010-07-16 02:11:22 +00003341 bool HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier &FS,
3342 const char *startSpecifier,
Craig Toppere14c0f82014-03-12 04:55:44 +00003343 unsigned specifierLen) override;
Richard Smith55ce3522012-06-25 20:30:08 +00003344 bool checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
3345 const char *StartSpecifier,
3346 unsigned SpecifierLen,
3347 const Expr *E);
3348
Ted Kremenek02087932010-07-16 02:11:22 +00003349 bool HandleAmount(const analyze_format_string::OptionalAmount &Amt, unsigned k,
3350 const char *startSpecifier, unsigned specifierLen);
3351 void HandleInvalidAmount(const analyze_printf::PrintfSpecifier &FS,
3352 const analyze_printf::OptionalAmount &Amt,
3353 unsigned type,
3354 const char *startSpecifier, unsigned specifierLen);
3355 void HandleFlag(const analyze_printf::PrintfSpecifier &FS,
3356 const analyze_printf::OptionalFlag &flag,
3357 const char *startSpecifier, unsigned specifierLen);
3358 void HandleIgnoredFlag(const analyze_printf::PrintfSpecifier &FS,
3359 const analyze_printf::OptionalFlag &ignoredFlag,
3360 const analyze_printf::OptionalFlag &flag,
3361 const char *startSpecifier, unsigned specifierLen);
Hans Wennborgc3b3da02012-08-07 08:11:26 +00003362 bool checkForCStrMembers(const analyze_printf::ArgType &AT,
Richard Smith2868a732014-02-28 01:36:39 +00003363 const Expr *E);
Richard Smith55ce3522012-06-25 20:30:08 +00003364
Ted Kremenek02087932010-07-16 02:11:22 +00003365};
3366}
3367
3368bool CheckPrintfHandler::HandleInvalidPrintfConversionSpecifier(
3369 const analyze_printf::PrintfSpecifier &FS,
3370 const char *startSpecifier,
3371 unsigned specifierLen) {
Ted Kremenekf03e6d852010-07-20 20:04:27 +00003372 const analyze_printf::PrintfConversionSpecifier &CS =
Ted Kremenekce815422010-07-19 21:25:57 +00003373 FS.getConversionSpecifier();
Ted Kremenek02087932010-07-16 02:11:22 +00003374
Ted Kremenekce815422010-07-19 21:25:57 +00003375 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
3376 getLocationOfByte(CS.getStart()),
3377 startSpecifier, specifierLen,
3378 CS.getStart(), CS.getLength());
Ted Kremenek94af5752010-01-29 02:40:24 +00003379}
3380
Ted Kremenek02087932010-07-16 02:11:22 +00003381bool CheckPrintfHandler::HandleAmount(
3382 const analyze_format_string::OptionalAmount &Amt,
3383 unsigned k, const char *startSpecifier,
3384 unsigned specifierLen) {
Ted Kremenek5739de72010-01-29 01:06:55 +00003385
3386 if (Amt.hasDataArgument()) {
Ted Kremenek5739de72010-01-29 01:06:55 +00003387 if (!HasVAListArg) {
Ted Kremenek4a49d982010-02-26 19:18:41 +00003388 unsigned argIndex = Amt.getArgIndex();
3389 if (argIndex >= NumDataArgs) {
Richard Trieu03cf7b72011-10-28 00:41:25 +00003390 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_missing_arg)
3391 << k,
3392 getLocationOfByte(Amt.getStart()),
3393 /*IsStringLocation*/true,
3394 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek5739de72010-01-29 01:06:55 +00003395 // Don't do any more checking. We will just emit
3396 // spurious errors.
3397 return false;
3398 }
Ted Kremenekc8b188d2010-02-16 01:46:59 +00003399
Ted Kremenek5739de72010-01-29 01:06:55 +00003400 // Type check the data argument. It should be an 'int'.
Ted Kremenek605b0112010-01-29 23:32:22 +00003401 // Although not in conformance with C99, we also allow the argument to be
3402 // an 'unsigned int' as that is a reasonably safe case. GCC also
3403 // doesn't emit a warning for that case.
Ted Kremenek4a49d982010-02-26 19:18:41 +00003404 CoveredArgs.set(argIndex);
3405 const Expr *Arg = getDataArg(argIndex);
Jordan Rose58bbe422012-07-19 18:10:08 +00003406 if (!Arg)
3407 return false;
3408
Ted Kremenek5739de72010-01-29 01:06:55 +00003409 QualType T = Arg->getType();
Ted Kremenekc8b188d2010-02-16 01:46:59 +00003410
Hans Wennborgc3b3da02012-08-07 08:11:26 +00003411 const analyze_printf::ArgType &AT = Amt.getArgType(S.Context);
3412 assert(AT.isValid());
Ted Kremenekc8b188d2010-02-16 01:46:59 +00003413
Hans Wennborgc3b3da02012-08-07 08:11:26 +00003414 if (!AT.matchesType(S.Context, T)) {
Richard Trieu03cf7b72011-10-28 00:41:25 +00003415 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_asterisk_wrong_type)
Hans Wennborgc3b3da02012-08-07 08:11:26 +00003416 << k << AT.getRepresentativeTypeName(S.Context)
Richard Trieu03cf7b72011-10-28 00:41:25 +00003417 << T << Arg->getSourceRange(),
3418 getLocationOfByte(Amt.getStart()),
3419 /*IsStringLocation*/true,
3420 getSpecifierRange(startSpecifier, specifierLen));
Ted Kremenek5739de72010-01-29 01:06:55 +00003421 // Don't do any more checking. We will just emit
3422 // spurious errors.
3423 return false;
3424 }
3425 }
3426 }
3427 return true;
3428}
Ted Kremenek5739de72010-01-29 01:06:55 +00003429
Tom Careb49ec692010-06-17 19:00:27 +00003430void CheckPrintfHandler::HandleInvalidAmount(
Ted Kremenek02087932010-07-16 02:11:22 +00003431 const analyze_printf::PrintfSpecifier &FS,
Tom Careb49ec692010-06-17 19:00:27 +00003432 const analyze_printf::OptionalAmount &Amt,
3433 unsigned type,
3434 const char *startSpecifier,
3435 unsigned specifierLen) {
Ted Kremenekf03e6d852010-07-20 20:04:27 +00003436 const analyze_printf::PrintfConversionSpecifier &CS =
3437 FS.getConversionSpecifier();
Tom Careb49ec692010-06-17 19:00:27 +00003438
Richard Trieu03cf7b72011-10-28 00:41:25 +00003439 FixItHint fixit =
3440 Amt.getHowSpecified() == analyze_printf::OptionalAmount::Constant
3441 ? FixItHint::CreateRemoval(getSpecifierRange(Amt.getStart(),
3442 Amt.getConstantLength()))
3443 : FixItHint();
3444
3445 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_optional_amount)
3446 << type << CS.toString(),
3447 getLocationOfByte(Amt.getStart()),
3448 /*IsStringLocation*/true,
3449 getSpecifierRange(startSpecifier, specifierLen),
3450 fixit);
Tom Careb49ec692010-06-17 19:00:27 +00003451}
3452
Ted Kremenek02087932010-07-16 02:11:22 +00003453void CheckPrintfHandler::HandleFlag(const analyze_printf::PrintfSpecifier &FS,
Tom Careb49ec692010-06-17 19:00:27 +00003454 const analyze_printf::OptionalFlag &flag,
3455 const char *startSpecifier,
3456 unsigned specifierLen) {
3457 // Warn about pointless flag with a fixit removal.
Ted Kremenekf03e6d852010-07-20 20:04:27 +00003458 const analyze_printf::PrintfConversionSpecifier &CS =
3459 FS.getConversionSpecifier();
Richard Trieu03cf7b72011-10-28 00:41:25 +00003460 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_nonsensical_flag)
3461 << flag.toString() << CS.toString(),
3462 getLocationOfByte(flag.getPosition()),
3463 /*IsStringLocation*/true,
3464 getSpecifierRange(startSpecifier, specifierLen),
3465 FixItHint::CreateRemoval(
3466 getSpecifierRange(flag.getPosition(), 1)));
Tom Careb49ec692010-06-17 19:00:27 +00003467}
3468
3469void CheckPrintfHandler::HandleIgnoredFlag(
Ted Kremenek02087932010-07-16 02:11:22 +00003470 const analyze_printf::PrintfSpecifier &FS,
Tom Careb49ec692010-06-17 19:00:27 +00003471 const analyze_printf::OptionalFlag &ignoredFlag,
3472 const analyze_printf::OptionalFlag &flag,
3473 const char *startSpecifier,
3474 unsigned specifierLen) {
3475 // Warn about ignored flag with a fixit removal.
Richard Trieu03cf7b72011-10-28 00:41:25 +00003476 EmitFormatDiagnostic(S.PDiag(diag::warn_printf_ignored_flag)
3477 << ignoredFlag.toString() << flag.toString(),
3478 getLocationOfByte(ignoredFlag.getPosition()),
3479 /*IsStringLocation*/true,
3480 getSpecifierRange(startSpecifier, specifierLen),
3481 FixItHint::CreateRemoval(
3482 getSpecifierRange(ignoredFlag.getPosition(), 1)));
Tom Careb49ec692010-06-17 19:00:27 +00003483}
3484
Richard Smith55ce3522012-06-25 20:30:08 +00003485// Determines if the specified is a C++ class or struct containing
3486// a member with the specified name and kind (e.g. a CXXMethodDecl named
3487// "c_str()").
3488template<typename MemberKind>
3489static llvm::SmallPtrSet<MemberKind*, 1>
3490CXXRecordMembersNamed(StringRef Name, Sema &S, QualType Ty) {
3491 const RecordType *RT = Ty->getAs<RecordType>();
3492 llvm::SmallPtrSet<MemberKind*, 1> Results;
3493
3494 if (!RT)
3495 return Results;
3496 const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(RT->getDecl());
Richard Smith2868a732014-02-28 01:36:39 +00003497 if (!RD || !RD->getDefinition())
Richard Smith55ce3522012-06-25 20:30:08 +00003498 return Results;
3499
Alp Tokerb6cc5922014-05-03 03:45:55 +00003500 LookupResult R(S, &S.Context.Idents.get(Name), SourceLocation(),
Richard Smith55ce3522012-06-25 20:30:08 +00003501 Sema::LookupMemberName);
Richard Smith2868a732014-02-28 01:36:39 +00003502 R.suppressDiagnostics();
Richard Smith55ce3522012-06-25 20:30:08 +00003503
3504 // We just need to include all members of the right kind turned up by the
3505 // filter, at this point.
3506 if (S.LookupQualifiedName(R, RT->getDecl()))
3507 for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) {
3508 NamedDecl *decl = (*I)->getUnderlyingDecl();
3509 if (MemberKind *FK = dyn_cast<MemberKind>(decl))
3510 Results.insert(FK);
3511 }
3512 return Results;
3513}
3514
Richard Smith2868a732014-02-28 01:36:39 +00003515/// Check if we could call '.c_str()' on an object.
3516///
3517/// FIXME: This returns the wrong results in some cases (if cv-qualifiers don't
3518/// allow the call, or if it would be ambiguous).
3519bool Sema::hasCStrMethod(const Expr *E) {
3520 typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet;
3521 MethodSet Results =
3522 CXXRecordMembersNamed<CXXMethodDecl>("c_str", *this, E->getType());
3523 for (MethodSet::iterator MI = Results.begin(), ME = Results.end();
3524 MI != ME; ++MI)
3525 if ((*MI)->getMinRequiredArguments() == 0)
3526 return true;
3527 return false;
3528}
3529
Richard Smith55ce3522012-06-25 20:30:08 +00003530// Check if a (w)string was passed when a (w)char* was needed, and offer a
Hans Wennborgc3b3da02012-08-07 08:11:26 +00003531// better diagnostic if so. AT is assumed to be valid.
Richard Smith55ce3522012-06-25 20:30:08 +00003532// Returns true when a c_str() conversion method is found.
3533bool CheckPrintfHandler::checkForCStrMembers(
Richard Smith2868a732014-02-28 01:36:39 +00003534 const analyze_printf::ArgType &AT, const Expr *E) {
Richard Smith55ce3522012-06-25 20:30:08 +00003535 typedef llvm::SmallPtrSet<CXXMethodDecl*, 1> MethodSet;
3536
3537 MethodSet Results =
3538 CXXRecordMembersNamed<CXXMethodDecl>("c_str", S, E->getType());
3539
3540 for (MethodSet::iterator MI = Results.begin(), ME = Results.end();
3541 MI != ME; ++MI) {
3542 const CXXMethodDecl *Method = *MI;
Richard Smith2868a732014-02-28 01:36:39 +00003543 if (Method->getMinRequiredArguments() == 0 &&
Alp Toker314cc812014-01-25 16:55:45 +00003544 AT.matchesType(S.Context, Method->getReturnType())) {
Richard Smith55ce3522012-06-25 20:30:08 +00003545 // FIXME: Suggest parens if the expression needs them.
Alp Tokerb6cc5922014-05-03 03:45:55 +00003546 SourceLocation EndLoc = S.getLocForEndOfToken(E->getLocEnd());
Richard Smith55ce3522012-06-25 20:30:08 +00003547 S.Diag(E->getLocStart(), diag::note_printf_c_str)
3548 << "c_str()"
3549 << FixItHint::CreateInsertion(EndLoc, ".c_str()");
3550 return true;
3551 }
3552 }
3553
3554 return false;
3555}
3556
Ted Kremenekab278de2010-01-28 23:39:18 +00003557bool
Ted Kremenek02087932010-07-16 02:11:22 +00003558CheckPrintfHandler::HandlePrintfSpecifier(const analyze_printf::PrintfSpecifier
Ted Kremenekd31b2632010-02-11 09:27:41 +00003559 &FS,
Ted Kremenekab278de2010-01-28 23:39:18 +00003560 const char *startSpecifier,
3561 unsigned specifierLen) {
3562
Ted Kremenekf03e6d852010-07-20 20:04:27 +00003563 using namespace analyze_format_string;
Ted Kremenekd1668192010-02-27 01:41:03 +00003564 using namespace analyze_printf;
Ted Kremenekf03e6d852010-07-20 20:04:27 +00003565 const PrintfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremenekab278de2010-01-28 23:39:18 +00003566
Ted Kremenek6cd69422010-07-19 22:01:06 +00003567 if (FS.consumesDataArgument()) {
3568 if (atFirstArg) {
3569 atFirstArg = false;
3570 usesPositionalArgs = FS.usesPositionalArg();
3571 }
3572 else if (usesPositionalArgs != FS.usesPositionalArg()) {
Richard Trieu03cf7b72011-10-28 00:41:25 +00003573 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
3574 startSpecifier, specifierLen);
Ted Kremenek6cd69422010-07-19 22:01:06 +00003575 return false;
3576 }
Ted Kremenek5739de72010-01-29 01:06:55 +00003577 }
Ted Kremenekc8b188d2010-02-16 01:46:59 +00003578
Ted Kremenekd1668192010-02-27 01:41:03 +00003579 // First check if the field width, precision, and conversion specifier
3580 // have matching data arguments.
3581 if (!HandleAmount(FS.getFieldWidth(), /* field width */ 0,
3582 startSpecifier, specifierLen)) {
3583 return false;
3584 }
3585
3586 if (!HandleAmount(FS.getPrecision(), /* precision */ 1,
3587 startSpecifier, specifierLen)) {
Ted Kremenek5739de72010-01-29 01:06:55 +00003588 return false;
3589 }
3590
Ted Kremenek8d9842d2010-01-29 20:55:36 +00003591 if (!CS.consumesDataArgument()) {
3592 // FIXME: Technically specifying a precision or field width here
3593 // makes no sense. Worth issuing a warning at some point.
Ted Kremenekfb45d352010-02-10 02:16:30 +00003594 return true;
Ted Kremenek8d9842d2010-01-29 20:55:36 +00003595 }
Ted Kremenekc8b188d2010-02-16 01:46:59 +00003596
Ted Kremenek4a49d982010-02-26 19:18:41 +00003597 // Consume the argument.
3598 unsigned argIndex = FS.getArgIndex();
Ted Kremenek09597b42010-02-27 08:34:51 +00003599 if (argIndex < NumDataArgs) {
3600 // The check to see if the argIndex is valid will come later.
3601 // We set the bit here because we may exit early from this
3602 // function if we encounter some other error.
3603 CoveredArgs.set(argIndex);
3604 }
Ted Kremenek4a49d982010-02-26 19:18:41 +00003605
Dimitry Andric6b5ed342015-02-19 22:32:33 +00003606 // FreeBSD kernel extensions.
3607 if (CS.getKind() == ConversionSpecifier::FreeBSDbArg ||
3608 CS.getKind() == ConversionSpecifier::FreeBSDDArg) {
3609 // We need at least two arguments.
3610 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex + 1))
3611 return false;
3612
3613 // Claim the second argument.
3614 CoveredArgs.set(argIndex + 1);
3615
3616 // Type check the first argument (int for %b, pointer for %D)
3617 const Expr *Ex = getDataArg(argIndex);
3618 const analyze_printf::ArgType &AT =
3619 (CS.getKind() == ConversionSpecifier::FreeBSDbArg) ?
3620 ArgType(S.Context.IntTy) : ArgType::CPointerTy;
3621 if (AT.isValid() && !AT.matchesType(S.Context, Ex->getType()))
3622 EmitFormatDiagnostic(
3623 S.PDiag(diag::warn_format_conversion_argument_type_mismatch)
3624 << AT.getRepresentativeTypeName(S.Context) << Ex->getType()
3625 << false << Ex->getSourceRange(),
3626 Ex->getLocStart(), /*IsStringLocation*/false,
3627 getSpecifierRange(startSpecifier, specifierLen));
3628
3629 // Type check the second argument (char * for both %b and %D)
3630 Ex = getDataArg(argIndex + 1);
3631 const analyze_printf::ArgType &AT2 = ArgType::CStrTy;
3632 if (AT2.isValid() && !AT2.matchesType(S.Context, Ex->getType()))
3633 EmitFormatDiagnostic(
3634 S.PDiag(diag::warn_format_conversion_argument_type_mismatch)
3635 << AT2.getRepresentativeTypeName(S.Context) << Ex->getType()
3636 << false << Ex->getSourceRange(),
3637 Ex->getLocStart(), /*IsStringLocation*/false,
3638 getSpecifierRange(startSpecifier, specifierLen));
3639
3640 return true;
3641 }
3642
Ted Kremenek4a49d982010-02-26 19:18:41 +00003643 // Check for using an Objective-C specific conversion specifier
3644 // in a non-ObjC literal.
Jordan Rose97c6f2b2012-06-04 23:52:23 +00003645 if (!ObjCContext && CS.isObjCArg()) {
Ted Kremenek02087932010-07-16 02:11:22 +00003646 return HandleInvalidPrintfConversionSpecifier(FS, startSpecifier,
3647 specifierLen);
Ted Kremenek4a49d982010-02-26 19:18:41 +00003648 }
Ted Kremenekc8b188d2010-02-16 01:46:59 +00003649
Tom Careb49ec692010-06-17 19:00:27 +00003650 // Check for invalid use of field width
3651 if (!FS.hasValidFieldWidth()) {
Tom Care3f272b82010-06-21 21:21:01 +00003652 HandleInvalidAmount(FS, FS.getFieldWidth(), /* field width */ 0,
Tom Careb49ec692010-06-17 19:00:27 +00003653 startSpecifier, specifierLen);
3654 }
3655
3656 // Check for invalid use of precision
3657 if (!FS.hasValidPrecision()) {
3658 HandleInvalidAmount(FS, FS.getPrecision(), /* precision */ 1,
3659 startSpecifier, specifierLen);
3660 }
3661
3662 // Check each flag does not conflict with any other component.
Ted Kremenekbf4832c2011-01-08 05:28:46 +00003663 if (!FS.hasValidThousandsGroupingPrefix())
3664 HandleFlag(FS, FS.hasThousandsGrouping(), startSpecifier, specifierLen);
Tom Careb49ec692010-06-17 19:00:27 +00003665 if (!FS.hasValidLeadingZeros())
3666 HandleFlag(FS, FS.hasLeadingZeros(), startSpecifier, specifierLen);
3667 if (!FS.hasValidPlusPrefix())
3668 HandleFlag(FS, FS.hasPlusPrefix(), startSpecifier, specifierLen);
Tom Care3f272b82010-06-21 21:21:01 +00003669 if (!FS.hasValidSpacePrefix())
3670 HandleFlag(FS, FS.hasSpacePrefix(), startSpecifier, specifierLen);
Tom Careb49ec692010-06-17 19:00:27 +00003671 if (!FS.hasValidAlternativeForm())
3672 HandleFlag(FS, FS.hasAlternativeForm(), startSpecifier, specifierLen);
3673 if (!FS.hasValidLeftJustified())
3674 HandleFlag(FS, FS.isLeftJustified(), startSpecifier, specifierLen);
3675
3676 // Check that flags are not ignored by another flag
Tom Care3f272b82010-06-21 21:21:01 +00003677 if (FS.hasSpacePrefix() && FS.hasPlusPrefix()) // ' ' ignored by '+'
3678 HandleIgnoredFlag(FS, FS.hasSpacePrefix(), FS.hasPlusPrefix(),
3679 startSpecifier, specifierLen);
Tom Careb49ec692010-06-17 19:00:27 +00003680 if (FS.hasLeadingZeros() && FS.isLeftJustified()) // '0' ignored by '-'
3681 HandleIgnoredFlag(FS, FS.hasLeadingZeros(), FS.isLeftJustified(),
3682 startSpecifier, specifierLen);
3683
3684 // Check the length modifier is valid with the given conversion specifier.
Jordan Rose92303592012-09-08 04:00:03 +00003685 if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo()))
Jordan Rose2f9cc042012-09-08 04:00:12 +00003686 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
3687 diag::warn_format_nonsensical_length);
Jordan Rose92303592012-09-08 04:00:03 +00003688 else if (!FS.hasStandardLengthModifier())
Jordan Rose2f9cc042012-09-08 04:00:12 +00003689 HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen);
Jordan Rose92303592012-09-08 04:00:03 +00003690 else if (!FS.hasStandardLengthConversionCombination())
Jordan Rose2f9cc042012-09-08 04:00:12 +00003691 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
3692 diag::warn_format_non_standard_conversion_spec);
Tom Careb49ec692010-06-17 19:00:27 +00003693
Jordan Rose92303592012-09-08 04:00:03 +00003694 if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
3695 HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
3696
Ted Kremenek9fcd8302010-01-29 01:43:31 +00003697 // The remaining checks depend on the data arguments.
3698 if (HasVAListArg)
3699 return true;
Ted Kremenekc8b188d2010-02-16 01:46:59 +00003700
Ted Kremenek6adb7e32010-07-26 19:45:42 +00003701 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenek9fcd8302010-01-29 01:43:31 +00003702 return false;
Ted Kremenekc8b188d2010-02-16 01:46:59 +00003703
Jordan Rose58bbe422012-07-19 18:10:08 +00003704 const Expr *Arg = getDataArg(argIndex);
3705 if (!Arg)
3706 return true;
3707
3708 return checkFormatExpr(FS, startSpecifier, specifierLen, Arg);
Richard Smith55ce3522012-06-25 20:30:08 +00003709}
3710
Jordan Roseaee34382012-09-05 22:56:26 +00003711static bool requiresParensToAddCast(const Expr *E) {
3712 // FIXME: We should have a general way to reason about operator
3713 // precedence and whether parens are actually needed here.
3714 // Take care of a few common cases where they aren't.
3715 const Expr *Inside = E->IgnoreImpCasts();
3716 if (const PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(Inside))
3717 Inside = POE->getSyntacticForm()->IgnoreImpCasts();
3718
3719 switch (Inside->getStmtClass()) {
3720 case Stmt::ArraySubscriptExprClass:
3721 case Stmt::CallExprClass:
Jordan Roseea0fdfe2012-12-05 18:44:44 +00003722 case Stmt::CharacterLiteralClass:
3723 case Stmt::CXXBoolLiteralExprClass:
Jordan Roseaee34382012-09-05 22:56:26 +00003724 case Stmt::DeclRefExprClass:
Jordan Roseea0fdfe2012-12-05 18:44:44 +00003725 case Stmt::FloatingLiteralClass:
3726 case Stmt::IntegerLiteralClass:
Jordan Roseaee34382012-09-05 22:56:26 +00003727 case Stmt::MemberExprClass:
Jordan Roseea0fdfe2012-12-05 18:44:44 +00003728 case Stmt::ObjCArrayLiteralClass:
3729 case Stmt::ObjCBoolLiteralExprClass:
3730 case Stmt::ObjCBoxedExprClass:
3731 case Stmt::ObjCDictionaryLiteralClass:
3732 case Stmt::ObjCEncodeExprClass:
Jordan Roseaee34382012-09-05 22:56:26 +00003733 case Stmt::ObjCIvarRefExprClass:
3734 case Stmt::ObjCMessageExprClass:
3735 case Stmt::ObjCPropertyRefExprClass:
Jordan Roseea0fdfe2012-12-05 18:44:44 +00003736 case Stmt::ObjCStringLiteralClass:
3737 case Stmt::ObjCSubscriptRefExprClass:
Jordan Roseaee34382012-09-05 22:56:26 +00003738 case Stmt::ParenExprClass:
Jordan Roseea0fdfe2012-12-05 18:44:44 +00003739 case Stmt::StringLiteralClass:
Jordan Roseaee34382012-09-05 22:56:26 +00003740 case Stmt::UnaryOperatorClass:
3741 return false;
3742 default:
3743 return true;
3744 }
3745}
3746
Anton Korobeynikov5f951ee2014-11-14 22:09:15 +00003747static std::pair<QualType, StringRef>
3748shouldNotPrintDirectly(const ASTContext &Context,
3749 QualType IntendedTy,
3750 const Expr *E) {
3751 // Use a 'while' to peel off layers of typedefs.
3752 QualType TyTy = IntendedTy;
3753 while (const TypedefType *UserTy = TyTy->getAs<TypedefType>()) {
3754 StringRef Name = UserTy->getDecl()->getName();
3755 QualType CastTy = llvm::StringSwitch<QualType>(Name)
3756 .Case("NSInteger", Context.LongTy)
3757 .Case("NSUInteger", Context.UnsignedLongTy)
3758 .Case("SInt32", Context.IntTy)
3759 .Case("UInt32", Context.UnsignedIntTy)
3760 .Default(QualType());
3761
3762 if (!CastTy.isNull())
3763 return std::make_pair(CastTy, Name);
3764
3765 TyTy = UserTy->desugar();
3766 }
3767
3768 // Strip parens if necessary.
3769 if (const ParenExpr *PE = dyn_cast<ParenExpr>(E))
3770 return shouldNotPrintDirectly(Context,
3771 PE->getSubExpr()->getType(),
3772 PE->getSubExpr());
3773
3774 // If this is a conditional expression, then its result type is constructed
3775 // via usual arithmetic conversions and thus there might be no necessary
3776 // typedef sugar there. Recurse to operands to check for NSInteger &
3777 // Co. usage condition.
3778 if (const ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
3779 QualType TrueTy, FalseTy;
3780 StringRef TrueName, FalseName;
3781
3782 std::tie(TrueTy, TrueName) =
3783 shouldNotPrintDirectly(Context,
3784 CO->getTrueExpr()->getType(),
3785 CO->getTrueExpr());
3786 std::tie(FalseTy, FalseName) =
3787 shouldNotPrintDirectly(Context,
3788 CO->getFalseExpr()->getType(),
3789 CO->getFalseExpr());
3790
3791 if (TrueTy == FalseTy)
3792 return std::make_pair(TrueTy, TrueName);
3793 else if (TrueTy.isNull())
3794 return std::make_pair(FalseTy, FalseName);
3795 else if (FalseTy.isNull())
3796 return std::make_pair(TrueTy, TrueName);
3797 }
3798
3799 return std::make_pair(QualType(), StringRef());
3800}
3801
Richard Smith55ce3522012-06-25 20:30:08 +00003802bool
3803CheckPrintfHandler::checkFormatExpr(const analyze_printf::PrintfSpecifier &FS,
3804 const char *StartSpecifier,
3805 unsigned SpecifierLen,
3806 const Expr *E) {
3807 using namespace analyze_format_string;
3808 using namespace analyze_printf;
Michael J. Spencer2c35bc12010-07-27 04:46:02 +00003809 // Now type check the data expression that matches the
3810 // format specifier.
Hans Wennborgc3b3da02012-08-07 08:11:26 +00003811 const analyze_printf::ArgType &AT = FS.getArgType(S.Context,
3812 ObjCContext);
Jordan Rose22b74712012-09-05 22:56:19 +00003813 if (!AT.isValid())
3814 return true;
Jordan Roseaee34382012-09-05 22:56:26 +00003815
Jordan Rose598ec092012-12-05 18:44:40 +00003816 QualType ExprTy = E->getType();
Ted Kremenek3365e522013-04-10 06:26:26 +00003817 while (const TypeOfExprType *TET = dyn_cast<TypeOfExprType>(ExprTy)) {
3818 ExprTy = TET->getUnderlyingExpr()->getType();
3819 }
3820
Seth Cantrellb4802962015-03-04 03:12:10 +00003821 analyze_printf::ArgType::MatchKind match = AT.matchesType(S.Context, ExprTy);
3822
3823 if (match == analyze_printf::ArgType::Match) {
Jordan Rose22b74712012-09-05 22:56:19 +00003824 return true;
Seth Cantrellb4802962015-03-04 03:12:10 +00003825 }
Jordan Rose98709982012-06-04 22:48:57 +00003826
Jordan Rose22b74712012-09-05 22:56:19 +00003827 // Look through argument promotions for our error message's reported type.
3828 // This includes the integral and floating promotions, but excludes array
3829 // and function pointer decay; seeing that an argument intended to be a
3830 // string has type 'char [6]' is probably more confusing than 'char *'.
3831 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
3832 if (ICE->getCastKind() == CK_IntegralCast ||
3833 ICE->getCastKind() == CK_FloatingCast) {
3834 E = ICE->getSubExpr();
Jordan Rose598ec092012-12-05 18:44:40 +00003835 ExprTy = E->getType();
Jordan Rose22b74712012-09-05 22:56:19 +00003836
3837 // Check if we didn't match because of an implicit cast from a 'char'
3838 // or 'short' to an 'int'. This is done because printf is a varargs
3839 // function.
3840 if (ICE->getType() == S.Context.IntTy ||
3841 ICE->getType() == S.Context.UnsignedIntTy) {
3842 // All further checking is done on the subexpression.
Jordan Rose598ec092012-12-05 18:44:40 +00003843 if (AT.matchesType(S.Context, ExprTy))
Jordan Rose22b74712012-09-05 22:56:19 +00003844 return true;
Ted Kremenek12a37de2010-10-21 04:00:58 +00003845 }
Jordan Rose98709982012-06-04 22:48:57 +00003846 }
Jordan Rose598ec092012-12-05 18:44:40 +00003847 } else if (const CharacterLiteral *CL = dyn_cast<CharacterLiteral>(E)) {
3848 // Special case for 'a', which has type 'int' in C.
3849 // Note, however, that we do /not/ want to treat multibyte constants like
3850 // 'MooV' as characters! This form is deprecated but still exists.
3851 if (ExprTy == S.Context.IntTy)
3852 if (llvm::isUIntN(S.Context.getCharWidth(), CL->getValue()))
3853 ExprTy = S.Context.CharTy;
Jordan Rose22b74712012-09-05 22:56:19 +00003854 }
Michael J. Spencer2c35bc12010-07-27 04:46:02 +00003855
Jordan Rosebc53ed12014-05-31 04:12:14 +00003856 // Look through enums to their underlying type.
3857 bool IsEnum = false;
3858 if (auto EnumTy = ExprTy->getAs<EnumType>()) {
3859 ExprTy = EnumTy->getDecl()->getIntegerType();
3860 IsEnum = true;
3861 }
3862
Jordan Rose0e5badd2012-12-05 18:44:49 +00003863 // %C in an Objective-C context prints a unichar, not a wchar_t.
3864 // If the argument is an integer of some kind, believe the %C and suggest
3865 // a cast instead of changing the conversion specifier.
Jordan Rose598ec092012-12-05 18:44:40 +00003866 QualType IntendedTy = ExprTy;
Jordan Rose0e5badd2012-12-05 18:44:49 +00003867 if (ObjCContext &&
3868 FS.getConversionSpecifier().getKind() == ConversionSpecifier::CArg) {
3869 if (ExprTy->isIntegralOrUnscopedEnumerationType() &&
3870 !ExprTy->isCharType()) {
3871 // 'unichar' is defined as a typedef of unsigned short, but we should
3872 // prefer using the typedef if it is visible.
3873 IntendedTy = S.Context.UnsignedShortTy;
Ted Kremenekda2f4052013-10-15 05:25:17 +00003874
3875 // While we are here, check if the value is an IntegerLiteral that happens
3876 // to be within the valid range.
3877 if (const IntegerLiteral *IL = dyn_cast<IntegerLiteral>(E)) {
3878 const llvm::APInt &V = IL->getValue();
3879 if (V.getActiveBits() <= S.Context.getTypeSize(IntendedTy))
3880 return true;
3881 }
3882
Jordan Rose0e5badd2012-12-05 18:44:49 +00003883 LookupResult Result(S, &S.Context.Idents.get("unichar"), E->getLocStart(),
3884 Sema::LookupOrdinaryName);
3885 if (S.LookupName(Result, S.getCurScope())) {
3886 NamedDecl *ND = Result.getFoundDecl();
3887 if (TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(ND))
3888 if (TD->getUnderlyingType() == IntendedTy)
3889 IntendedTy = S.Context.getTypedefType(TD);
3890 }
3891 }
3892 }
3893
3894 // Special-case some of Darwin's platform-independence types by suggesting
3895 // casts to primitive types that are known to be large enough.
Anton Korobeynikov5f951ee2014-11-14 22:09:15 +00003896 bool ShouldNotPrintDirectly = false; StringRef CastTyName;
Jordan Roseaee34382012-09-05 22:56:26 +00003897 if (S.Context.getTargetInfo().getTriple().isOSDarwin()) {
Anton Korobeynikov5f951ee2014-11-14 22:09:15 +00003898 QualType CastTy;
3899 std::tie(CastTy, CastTyName) = shouldNotPrintDirectly(S.Context, IntendedTy, E);
3900 if (!CastTy.isNull()) {
3901 IntendedTy = CastTy;
3902 ShouldNotPrintDirectly = true;
Jordan Roseaee34382012-09-05 22:56:26 +00003903 }
3904 }
3905
Jordan Rose22b74712012-09-05 22:56:19 +00003906 // We may be able to offer a FixItHint if it is a supported type.
3907 PrintfSpecifier fixedFS = FS;
Jordan Roseaee34382012-09-05 22:56:26 +00003908 bool success = fixedFS.fixType(IntendedTy, S.getLangOpts(),
Jordan Rose22b74712012-09-05 22:56:19 +00003909 S.Context, ObjCContext);
Michael J. Spencer2c35bc12010-07-27 04:46:02 +00003910
Jordan Rose22b74712012-09-05 22:56:19 +00003911 if (success) {
3912 // Get the fix string from the fixed format specifier
3913 SmallString<16> buf;
3914 llvm::raw_svector_ostream os(buf);
3915 fixedFS.toString(os);
Michael J. Spencer2c35bc12010-07-27 04:46:02 +00003916
Jordan Roseaee34382012-09-05 22:56:26 +00003917 CharSourceRange SpecRange = getSpecifierRange(StartSpecifier, SpecifierLen);
3918
Anton Korobeynikov5f951ee2014-11-14 22:09:15 +00003919 if (IntendedTy == ExprTy && !ShouldNotPrintDirectly) {
Daniel Jasperad8d8492015-03-04 14:18:20 +00003920 unsigned diag = diag::warn_format_conversion_argument_type_mismatch;
3921 if (match == analyze_format_string::ArgType::NoMatchPedantic) {
3922 diag = diag::warn_format_conversion_argument_type_mismatch_pedantic;
3923 }
Jordan Rose0e5badd2012-12-05 18:44:49 +00003924 // In this case, the specifier is wrong and should be changed to match
3925 // the argument.
Daniel Jasperad8d8492015-03-04 14:18:20 +00003926 EmitFormatDiagnostic(S.PDiag(diag)
3927 << AT.getRepresentativeTypeName(S.Context)
3928 << IntendedTy << IsEnum << E->getSourceRange(),
3929 E->getLocStart(),
3930 /*IsStringLocation*/ false, SpecRange,
3931 FixItHint::CreateReplacement(SpecRange, os.str()));
Jordan Rose0e5badd2012-12-05 18:44:49 +00003932
3933 } else {
Jordan Roseaee34382012-09-05 22:56:26 +00003934 // The canonical type for formatting this value is different from the
3935 // actual type of the expression. (This occurs, for example, with Darwin's
3936 // NSInteger on 32-bit platforms, where it is typedef'd as 'int', but
3937 // should be printed as 'long' for 64-bit compatibility.)
3938 // Rather than emitting a normal format/argument mismatch, we want to
3939 // add a cast to the recommended type (and correct the format string
3940 // if necessary).
3941 SmallString<16> CastBuf;
3942 llvm::raw_svector_ostream CastFix(CastBuf);
3943 CastFix << "(";
3944 IntendedTy.print(CastFix, S.Context.getPrintingPolicy());
3945 CastFix << ")";
3946
3947 SmallVector<FixItHint,4> Hints;
3948 if (!AT.matchesType(S.Context, IntendedTy))
3949 Hints.push_back(FixItHint::CreateReplacement(SpecRange, os.str()));
3950
3951 if (const CStyleCastExpr *CCast = dyn_cast<CStyleCastExpr>(E)) {
3952 // If there's already a cast present, just replace it.
3953 SourceRange CastRange(CCast->getLParenLoc(), CCast->getRParenLoc());
3954 Hints.push_back(FixItHint::CreateReplacement(CastRange, CastFix.str()));
3955
3956 } else if (!requiresParensToAddCast(E)) {
3957 // If the expression has high enough precedence,
3958 // just write the C-style cast.
3959 Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(),
3960 CastFix.str()));
3961 } else {
3962 // Otherwise, add parens around the expression as well as the cast.
3963 CastFix << "(";
3964 Hints.push_back(FixItHint::CreateInsertion(E->getLocStart(),
3965 CastFix.str()));
3966
Alp Tokerb6cc5922014-05-03 03:45:55 +00003967 SourceLocation After = S.getLocForEndOfToken(E->getLocEnd());
Jordan Roseaee34382012-09-05 22:56:26 +00003968 Hints.push_back(FixItHint::CreateInsertion(After, ")"));
3969 }
3970
Jordan Rose0e5badd2012-12-05 18:44:49 +00003971 if (ShouldNotPrintDirectly) {
3972 // The expression has a type that should not be printed directly.
3973 // We extract the name from the typedef because we don't want to show
3974 // the underlying type in the diagnostic.
Anton Korobeynikov5f951ee2014-11-14 22:09:15 +00003975 StringRef Name;
3976 if (const TypedefType *TypedefTy = dyn_cast<TypedefType>(ExprTy))
3977 Name = TypedefTy->getDecl()->getName();
3978 else
3979 Name = CastTyName;
Jordan Rose0e5badd2012-12-05 18:44:49 +00003980 EmitFormatDiagnostic(S.PDiag(diag::warn_format_argument_needs_cast)
Jordan Rosebc53ed12014-05-31 04:12:14 +00003981 << Name << IntendedTy << IsEnum
Jordan Rose0e5badd2012-12-05 18:44:49 +00003982 << E->getSourceRange(),
3983 E->getLocStart(), /*IsStringLocation=*/false,
3984 SpecRange, Hints);
3985 } else {
3986 // In this case, the expression could be printed using a different
3987 // specifier, but we've decided that the specifier is probably correct
3988 // and we should cast instead. Just use the normal warning message.
3989 EmitFormatDiagnostic(
Jordan Rosebc53ed12014-05-31 04:12:14 +00003990 S.PDiag(diag::warn_format_conversion_argument_type_mismatch)
3991 << AT.getRepresentativeTypeName(S.Context) << ExprTy << IsEnum
Jordan Rose0e5badd2012-12-05 18:44:49 +00003992 << E->getSourceRange(),
3993 E->getLocStart(), /*IsStringLocation*/false,
3994 SpecRange, Hints);
3995 }
Jordan Roseaee34382012-09-05 22:56:26 +00003996 }
Jordan Rose22b74712012-09-05 22:56:19 +00003997 } else {
3998 const CharSourceRange &CSR = getSpecifierRange(StartSpecifier,
3999 SpecifierLen);
4000 // Since the warning for passing non-POD types to variadic functions
4001 // was deferred until now, we emit a warning for non-POD
4002 // arguments here.
Richard Smithd7293d72013-08-05 18:49:43 +00004003 switch (S.isValidVarArgType(ExprTy)) {
4004 case Sema::VAK_Valid:
Seth Cantrellb4802962015-03-04 03:12:10 +00004005 case Sema::VAK_ValidInCXX11: {
4006 unsigned diag = diag::warn_format_conversion_argument_type_mismatch;
4007 if (match == analyze_printf::ArgType::NoMatchPedantic) {
4008 diag = diag::warn_format_conversion_argument_type_mismatch_pedantic;
4009 }
Richard Smithd7293d72013-08-05 18:49:43 +00004010
Seth Cantrellb4802962015-03-04 03:12:10 +00004011 EmitFormatDiagnostic(
4012 S.PDiag(diag) << AT.getRepresentativeTypeName(S.Context) << ExprTy
4013 << IsEnum << CSR << E->getSourceRange(),
4014 E->getLocStart(), /*IsStringLocation*/ false, CSR);
4015 break;
4016 }
Richard Smithd7293d72013-08-05 18:49:43 +00004017 case Sema::VAK_Undefined:
Hans Wennborgd9dd4d22014-09-29 23:06:57 +00004018 case Sema::VAK_MSVCUndefined:
Richard Smithd7293d72013-08-05 18:49:43 +00004019 EmitFormatDiagnostic(
4020 S.PDiag(diag::warn_non_pod_vararg_with_format_string)
Richard Smith2bf7fdb2013-01-02 11:42:31 +00004021 << S.getLangOpts().CPlusPlus11
Jordan Rose598ec092012-12-05 18:44:40 +00004022 << ExprTy
Jordan Rose22b74712012-09-05 22:56:19 +00004023 << CallType
4024 << AT.getRepresentativeTypeName(S.Context)
4025 << CSR
4026 << E->getSourceRange(),
4027 E->getLocStart(), /*IsStringLocation*/false, CSR);
Richard Smith2868a732014-02-28 01:36:39 +00004028 checkForCStrMembers(AT, E);
Richard Smithd7293d72013-08-05 18:49:43 +00004029 break;
4030
4031 case Sema::VAK_Invalid:
4032 if (ExprTy->isObjCObjectType())
4033 EmitFormatDiagnostic(
4034 S.PDiag(diag::err_cannot_pass_objc_interface_to_vararg_format)
4035 << S.getLangOpts().CPlusPlus11
4036 << ExprTy
4037 << CallType
4038 << AT.getRepresentativeTypeName(S.Context)
4039 << CSR
4040 << E->getSourceRange(),
4041 E->getLocStart(), /*IsStringLocation*/false, CSR);
4042 else
4043 // FIXME: If this is an initializer list, suggest removing the braces
4044 // or inserting a cast to the target type.
4045 S.Diag(E->getLocStart(), diag::err_cannot_pass_to_vararg_format)
4046 << isa<InitListExpr>(E) << ExprTy << CallType
4047 << AT.getRepresentativeTypeName(S.Context)
4048 << E->getSourceRange();
4049 break;
4050 }
4051
4052 assert(FirstDataArg + FS.getArgIndex() < CheckedVarArgs.size() &&
4053 "format string specifier index out of range");
4054 CheckedVarArgs[FirstDataArg + FS.getArgIndex()] = true;
Michael J. Spencer2c35bc12010-07-27 04:46:02 +00004055 }
4056
Ted Kremenekab278de2010-01-28 23:39:18 +00004057 return true;
4058}
4059
Ted Kremenek02087932010-07-16 02:11:22 +00004060//===--- CHECK: Scanf format string checking ------------------------------===//
4061
4062namespace {
4063class CheckScanfHandler : public CheckFormatHandler {
4064public:
4065 CheckScanfHandler(Sema &s, const StringLiteral *fexpr,
4066 const Expr *origFormatExpr, unsigned firstDataArg,
Jordan Rose97c6f2b2012-06-04 23:52:23 +00004067 unsigned numDataArgs, const char *beg, bool hasVAListArg,
Dmitri Gribenko765396f2013-01-13 20:46:02 +00004068 ArrayRef<const Expr *> Args,
Jordan Rose3e0ec582012-07-19 18:10:23 +00004069 unsigned formatIdx, bool inFunctionCall,
Richard Smithd7293d72013-08-05 18:49:43 +00004070 Sema::VariadicCallType CallType,
4071 llvm::SmallBitVector &CheckedVarArgs)
4072 : CheckFormatHandler(s, fexpr, origFormatExpr, firstDataArg,
4073 numDataArgs, beg, hasVAListArg,
4074 Args, formatIdx, inFunctionCall, CallType,
4075 CheckedVarArgs)
Jordan Rose3e0ec582012-07-19 18:10:23 +00004076 {}
Ted Kremenek02087932010-07-16 02:11:22 +00004077
4078 bool HandleScanfSpecifier(const analyze_scanf::ScanfSpecifier &FS,
4079 const char *startSpecifier,
Craig Toppere14c0f82014-03-12 04:55:44 +00004080 unsigned specifierLen) override;
Ted Kremenekce815422010-07-19 21:25:57 +00004081
4082 bool HandleInvalidScanfConversionSpecifier(
4083 const analyze_scanf::ScanfSpecifier &FS,
4084 const char *startSpecifier,
Craig Toppere14c0f82014-03-12 04:55:44 +00004085 unsigned specifierLen) override;
Ted Kremenekd7b31cc2010-07-16 18:28:03 +00004086
Craig Toppere14c0f82014-03-12 04:55:44 +00004087 void HandleIncompleteScanList(const char *start, const char *end) override;
Ted Kremenek02087932010-07-16 02:11:22 +00004088};
Ted Kremenek019d2242010-01-29 01:50:07 +00004089}
Ted Kremenekab278de2010-01-28 23:39:18 +00004090
Ted Kremenekd7b31cc2010-07-16 18:28:03 +00004091void CheckScanfHandler::HandleIncompleteScanList(const char *start,
4092 const char *end) {
Richard Trieu03cf7b72011-10-28 00:41:25 +00004093 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_scanlist_incomplete),
4094 getLocationOfByte(end), /*IsStringLocation*/true,
4095 getSpecifierRange(start, end - start));
Ted Kremenekd7b31cc2010-07-16 18:28:03 +00004096}
4097
Ted Kremenekce815422010-07-19 21:25:57 +00004098bool CheckScanfHandler::HandleInvalidScanfConversionSpecifier(
4099 const analyze_scanf::ScanfSpecifier &FS,
4100 const char *startSpecifier,
4101 unsigned specifierLen) {
4102
Ted Kremenekf03e6d852010-07-20 20:04:27 +00004103 const analyze_scanf::ScanfConversionSpecifier &CS =
Ted Kremenekce815422010-07-19 21:25:57 +00004104 FS.getConversionSpecifier();
4105
4106 return HandleInvalidConversionSpecifier(FS.getArgIndex(),
4107 getLocationOfByte(CS.getStart()),
4108 startSpecifier, specifierLen,
4109 CS.getStart(), CS.getLength());
4110}
4111
Ted Kremenek02087932010-07-16 02:11:22 +00004112bool CheckScanfHandler::HandleScanfSpecifier(
4113 const analyze_scanf::ScanfSpecifier &FS,
4114 const char *startSpecifier,
4115 unsigned specifierLen) {
4116
4117 using namespace analyze_scanf;
4118 using namespace analyze_format_string;
4119
Ted Kremenekf03e6d852010-07-20 20:04:27 +00004120 const ScanfConversionSpecifier &CS = FS.getConversionSpecifier();
Ted Kremenek02087932010-07-16 02:11:22 +00004121
Ted Kremenek6cd69422010-07-19 22:01:06 +00004122 // Handle case where '%' and '*' don't consume an argument. These shouldn't
4123 // be used to decide if we are using positional arguments consistently.
4124 if (FS.consumesDataArgument()) {
4125 if (atFirstArg) {
4126 atFirstArg = false;
4127 usesPositionalArgs = FS.usesPositionalArg();
4128 }
4129 else if (usesPositionalArgs != FS.usesPositionalArg()) {
Richard Trieu03cf7b72011-10-28 00:41:25 +00004130 HandlePositionalNonpositionalArgs(getLocationOfByte(CS.getStart()),
4131 startSpecifier, specifierLen);
Ted Kremenek6cd69422010-07-19 22:01:06 +00004132 return false;
4133 }
Ted Kremenek02087932010-07-16 02:11:22 +00004134 }
4135
4136 // Check if the field with is non-zero.
4137 const OptionalAmount &Amt = FS.getFieldWidth();
4138 if (Amt.getHowSpecified() == OptionalAmount::Constant) {
4139 if (Amt.getConstantAmount() == 0) {
4140 const CharSourceRange &R = getSpecifierRange(Amt.getStart(),
4141 Amt.getConstantLength());
Richard Trieu03cf7b72011-10-28 00:41:25 +00004142 EmitFormatDiagnostic(S.PDiag(diag::warn_scanf_nonzero_width),
4143 getLocationOfByte(Amt.getStart()),
4144 /*IsStringLocation*/true, R,
4145 FixItHint::CreateRemoval(R));
Ted Kremenek02087932010-07-16 02:11:22 +00004146 }
4147 }
Seth Cantrellb4802962015-03-04 03:12:10 +00004148
Ted Kremenek02087932010-07-16 02:11:22 +00004149 if (!FS.consumesDataArgument()) {
4150 // FIXME: Technically specifying a precision or field width here
4151 // makes no sense. Worth issuing a warning at some point.
4152 return true;
4153 }
Seth Cantrellb4802962015-03-04 03:12:10 +00004154
Ted Kremenek02087932010-07-16 02:11:22 +00004155 // Consume the argument.
4156 unsigned argIndex = FS.getArgIndex();
4157 if (argIndex < NumDataArgs) {
4158 // The check to see if the argIndex is valid will come later.
4159 // We set the bit here because we may exit early from this
4160 // function if we encounter some other error.
4161 CoveredArgs.set(argIndex);
4162 }
Seth Cantrellb4802962015-03-04 03:12:10 +00004163
Ted Kremenek4407ea42010-07-20 20:04:47 +00004164 // Check the length modifier is valid with the given conversion specifier.
Jordan Rose92303592012-09-08 04:00:03 +00004165 if (!FS.hasValidLengthModifier(S.getASTContext().getTargetInfo()))
Jordan Rose2f9cc042012-09-08 04:00:12 +00004166 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
4167 diag::warn_format_nonsensical_length);
Jordan Rose92303592012-09-08 04:00:03 +00004168 else if (!FS.hasStandardLengthModifier())
Jordan Rose2f9cc042012-09-08 04:00:12 +00004169 HandleNonStandardLengthModifier(FS, startSpecifier, specifierLen);
Jordan Rose92303592012-09-08 04:00:03 +00004170 else if (!FS.hasStandardLengthConversionCombination())
Jordan Rose2f9cc042012-09-08 04:00:12 +00004171 HandleInvalidLengthModifier(FS, CS, startSpecifier, specifierLen,
4172 diag::warn_format_non_standard_conversion_spec);
Hans Wennborgc9dd9462012-02-22 10:17:01 +00004173
Jordan Rose92303592012-09-08 04:00:03 +00004174 if (!FS.hasStandardConversionSpecifier(S.getLangOpts()))
4175 HandleNonStandardConversionSpecifier(CS, startSpecifier, specifierLen);
4176
Ted Kremenek02087932010-07-16 02:11:22 +00004177 // The remaining checks depend on the data arguments.
4178 if (HasVAListArg)
4179 return true;
Seth Cantrellb4802962015-03-04 03:12:10 +00004180
Ted Kremenek6adb7e32010-07-26 19:45:42 +00004181 if (!CheckNumArgs(FS, CS, startSpecifier, specifierLen, argIndex))
Ted Kremenek02087932010-07-16 02:11:22 +00004182 return false;
Seth Cantrellb4802962015-03-04 03:12:10 +00004183
Hans Wennborgb1a5e092011-12-10 13:20:11 +00004184 // Check that the argument type matches the format specifier.
4185 const Expr *Ex = getDataArg(argIndex);
Jordan Rose58bbe422012-07-19 18:10:08 +00004186 if (!Ex)
4187 return true;
4188
Hans Wennborgb1ab2a82012-08-07 08:59:46 +00004189 const analyze_format_string::ArgType &AT = FS.getArgType(S.Context);
Seth Cantrell79340072015-03-04 05:58:08 +00004190
4191 if (!AT.isValid()) {
4192 return true;
4193 }
4194
Seth Cantrellb4802962015-03-04 03:12:10 +00004195 analyze_format_string::ArgType::MatchKind match =
4196 AT.matchesType(S.Context, Ex->getType());
Seth Cantrell79340072015-03-04 05:58:08 +00004197 if (match == analyze_format_string::ArgType::Match) {
4198 return true;
4199 }
Seth Cantrellb4802962015-03-04 03:12:10 +00004200
Seth Cantrell79340072015-03-04 05:58:08 +00004201 ScanfSpecifier fixedFS = FS;
4202 bool success = fixedFS.fixType(Ex->getType(), Ex->IgnoreImpCasts()->getType(),
4203 S.getLangOpts(), S.Context);
Hans Wennborgb1a5e092011-12-10 13:20:11 +00004204
Seth Cantrell79340072015-03-04 05:58:08 +00004205 unsigned diag = diag::warn_format_conversion_argument_type_mismatch;
4206 if (match == analyze_format_string::ArgType::NoMatchPedantic) {
4207 diag = diag::warn_format_conversion_argument_type_mismatch_pedantic;
4208 }
Hans Wennborgb1a5e092011-12-10 13:20:11 +00004209
Seth Cantrell79340072015-03-04 05:58:08 +00004210 if (success) {
4211 // Get the fix string from the fixed format specifier.
4212 SmallString<128> buf;
4213 llvm::raw_svector_ostream os(buf);
4214 fixedFS.toString(os);
4215
4216 EmitFormatDiagnostic(
4217 S.PDiag(diag) << AT.getRepresentativeTypeName(S.Context)
4218 << Ex->getType() << false << Ex->getSourceRange(),
4219 Ex->getLocStart(),
4220 /*IsStringLocation*/ false,
4221 getSpecifierRange(startSpecifier, specifierLen),
4222 FixItHint::CreateReplacement(
4223 getSpecifierRange(startSpecifier, specifierLen), os.str()));
4224 } else {
4225 EmitFormatDiagnostic(S.PDiag(diag)
4226 << AT.getRepresentativeTypeName(S.Context)
4227 << Ex->getType() << false << Ex->getSourceRange(),
4228 Ex->getLocStart(),
4229 /*IsStringLocation*/ false,
4230 getSpecifierRange(startSpecifier, specifierLen));
Hans Wennborgb1a5e092011-12-10 13:20:11 +00004231 }
4232
Ted Kremenek02087932010-07-16 02:11:22 +00004233 return true;
4234}
4235
4236void Sema::CheckFormatString(const StringLiteral *FExpr,
Ted Kremenekfb45d352010-02-10 02:16:30 +00004237 const Expr *OrigFormatExpr,
Dmitri Gribenko765396f2013-01-13 20:46:02 +00004238 ArrayRef<const Expr *> Args,
Jean-Daniel Dupas0ae6e672012-01-17 20:03:31 +00004239 bool HasVAListArg, unsigned format_idx,
Jean-Daniel Dupas028573e72012-01-30 08:46:47 +00004240 unsigned firstDataArg, FormatStringType Type,
Richard Smithd7293d72013-08-05 18:49:43 +00004241 bool inFunctionCall, VariadicCallType CallType,
4242 llvm::SmallBitVector &CheckedVarArgs) {
Ted Kremenek02087932010-07-16 02:11:22 +00004243
Ted Kremenekab278de2010-01-28 23:39:18 +00004244 // CHECK: is the format string a wide literal?
Richard Smith4060f772012-06-13 05:37:23 +00004245 if (!FExpr->isAscii() && !FExpr->isUTF8()) {
Richard Trieu03cf7b72011-10-28 00:41:25 +00004246 CheckFormatHandler::EmitFormatDiagnostic(
Jean-Daniel Dupas0ae6e672012-01-17 20:03:31 +00004247 *this, inFunctionCall, Args[format_idx],
Richard Trieu03cf7b72011-10-28 00:41:25 +00004248 PDiag(diag::warn_format_string_is_wide_literal), FExpr->getLocStart(),
4249 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
Ted Kremenekab278de2010-01-28 23:39:18 +00004250 return;
4251 }
Ted Kremenek02087932010-07-16 02:11:22 +00004252
Ted Kremenekab278de2010-01-28 23:39:18 +00004253 // Str - The format string. NOTE: this is NOT null-terminated!
Chris Lattner0e62c1c2011-07-23 10:55:15 +00004254 StringRef StrRef = FExpr->getString();
Benjamin Kramer35b077e2010-08-17 12:54:38 +00004255 const char *Str = StrRef.data();
Benjamin Kramer6c6a4f42014-02-20 17:05:38 +00004256 // Account for cases where the string literal is truncated in a declaration.
4257 const ConstantArrayType *T = Context.getAsConstantArrayType(FExpr->getType());
4258 assert(T && "String literal not of constant array type!");
4259 size_t TypeSize = T->getSize().getZExtValue();
4260 size_t StrLen = std::min(std::max(TypeSize, size_t(1)) - 1, StrRef.size());
Dmitri Gribenko765396f2013-01-13 20:46:02 +00004261 const unsigned numDataArgs = Args.size() - firstDataArg;
Benjamin Kramer6c6a4f42014-02-20 17:05:38 +00004262
4263 // Emit a warning if the string literal is truncated and does not contain an
4264 // embedded null character.
4265 if (TypeSize <= StrRef.size() &&
4266 StrRef.substr(0, TypeSize).find('\0') == StringRef::npos) {
4267 CheckFormatHandler::EmitFormatDiagnostic(
4268 *this, inFunctionCall, Args[format_idx],
4269 PDiag(diag::warn_printf_format_string_not_null_terminated),
4270 FExpr->getLocStart(),
4271 /*IsStringLocation=*/true, OrigFormatExpr->getSourceRange());
4272 return;
4273 }
4274
Ted Kremenekab278de2010-01-28 23:39:18 +00004275 // CHECK: empty format string?
Ted Kremenek6e302b22011-09-29 05:52:16 +00004276 if (StrLen == 0 && numDataArgs > 0) {
Richard Trieu03cf7b72011-10-28 00:41:25 +00004277 CheckFormatHandler::EmitFormatDiagnostic(
Jean-Daniel Dupas0ae6e672012-01-17 20:03:31 +00004278 *this, inFunctionCall, Args[format_idx],
Richard Trieu03cf7b72011-10-28 00:41:25 +00004279 PDiag(diag::warn_empty_format_string), FExpr->getLocStart(),
4280 /*IsStringLocation*/true, OrigFormatExpr->getSourceRange());
Ted Kremenekab278de2010-01-28 23:39:18 +00004281 return;
4282 }
Ted Kremenek02087932010-07-16 02:11:22 +00004283
Dimitry Andric6b5ed342015-02-19 22:32:33 +00004284 if (Type == FST_Printf || Type == FST_NSString ||
Fariborz Jahanianf8dce0f2015-02-21 00:45:58 +00004285 Type == FST_FreeBSDKPrintf || Type == FST_OSTrace) {
Ted Kremenek02087932010-07-16 02:11:22 +00004286 CheckPrintfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg,
Fariborz Jahanianf8dce0f2015-02-21 00:45:58 +00004287 numDataArgs, (Type == FST_NSString || Type == FST_OSTrace),
Dmitri Gribenko765396f2013-01-13 20:46:02 +00004288 Str, HasVAListArg, Args, format_idx,
Richard Smithd7293d72013-08-05 18:49:43 +00004289 inFunctionCall, CallType, CheckedVarArgs);
Ted Kremenek02087932010-07-16 02:11:22 +00004290
Hans Wennborg23926bd2011-12-15 10:25:47 +00004291 if (!analyze_format_string::ParsePrintfString(H, Str, Str + StrLen,
Jordan Rose510260c2012-09-13 02:11:03 +00004292 getLangOpts(),
Dimitry Andric6b5ed342015-02-19 22:32:33 +00004293 Context.getTargetInfo(),
4294 Type == FST_FreeBSDKPrintf))
Ted Kremenek02087932010-07-16 02:11:22 +00004295 H.DoneProcessing();
Jean-Daniel Dupas028573e72012-01-30 08:46:47 +00004296 } else if (Type == FST_Scanf) {
Jordan Rose97c6f2b2012-06-04 23:52:23 +00004297 CheckScanfHandler H(*this, FExpr, OrigFormatExpr, firstDataArg, numDataArgs,
Dmitri Gribenko765396f2013-01-13 20:46:02 +00004298 Str, HasVAListArg, Args, format_idx,
Richard Smithd7293d72013-08-05 18:49:43 +00004299 inFunctionCall, CallType, CheckedVarArgs);
Ted Kremenek02087932010-07-16 02:11:22 +00004300
Hans Wennborg23926bd2011-12-15 10:25:47 +00004301 if (!analyze_format_string::ParseScanfString(H, Str, Str + StrLen,
Jordan Rose510260c2012-09-13 02:11:03 +00004302 getLangOpts(),
4303 Context.getTargetInfo()))
Ted Kremenek02087932010-07-16 02:11:22 +00004304 H.DoneProcessing();
Jean-Daniel Dupas028573e72012-01-30 08:46:47 +00004305 } // TODO: handle other formats
Ted Kremenekc70ee862010-01-28 01:18:22 +00004306}
4307
Fariborz Jahanian6485fe42014-09-09 23:10:54 +00004308bool Sema::FormatStringHasSArg(const StringLiteral *FExpr) {
4309 // Str - The format string. NOTE: this is NOT null-terminated!
4310 StringRef StrRef = FExpr->getString();
4311 const char *Str = StrRef.data();
4312 // Account for cases where the string literal is truncated in a declaration.
4313 const ConstantArrayType *T = Context.getAsConstantArrayType(FExpr->getType());
4314 assert(T && "String literal not of constant array type!");
4315 size_t TypeSize = T->getSize().getZExtValue();
4316 size_t StrLen = std::min(std::max(TypeSize, size_t(1)) - 1, StrRef.size());
4317 return analyze_format_string::ParseFormatStringHasSArg(Str, Str + StrLen,
4318 getLangOpts(),
4319 Context.getTargetInfo());
4320}
4321
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004322//===--- CHECK: Warn on use of wrong absolute value function. -------------===//
4323
4324// Returns the related absolute value function that is larger, of 0 if one
4325// does not exist.
4326static unsigned getLargerAbsoluteValueFunction(unsigned AbsFunction) {
4327 switch (AbsFunction) {
4328 default:
4329 return 0;
4330
4331 case Builtin::BI__builtin_abs:
4332 return Builtin::BI__builtin_labs;
4333 case Builtin::BI__builtin_labs:
4334 return Builtin::BI__builtin_llabs;
4335 case Builtin::BI__builtin_llabs:
4336 return 0;
4337
4338 case Builtin::BI__builtin_fabsf:
4339 return Builtin::BI__builtin_fabs;
4340 case Builtin::BI__builtin_fabs:
4341 return Builtin::BI__builtin_fabsl;
4342 case Builtin::BI__builtin_fabsl:
4343 return 0;
4344
4345 case Builtin::BI__builtin_cabsf:
4346 return Builtin::BI__builtin_cabs;
4347 case Builtin::BI__builtin_cabs:
4348 return Builtin::BI__builtin_cabsl;
4349 case Builtin::BI__builtin_cabsl:
4350 return 0;
4351
4352 case Builtin::BIabs:
4353 return Builtin::BIlabs;
4354 case Builtin::BIlabs:
4355 return Builtin::BIllabs;
4356 case Builtin::BIllabs:
4357 return 0;
4358
4359 case Builtin::BIfabsf:
4360 return Builtin::BIfabs;
4361 case Builtin::BIfabs:
4362 return Builtin::BIfabsl;
4363 case Builtin::BIfabsl:
4364 return 0;
4365
4366 case Builtin::BIcabsf:
4367 return Builtin::BIcabs;
4368 case Builtin::BIcabs:
4369 return Builtin::BIcabsl;
4370 case Builtin::BIcabsl:
4371 return 0;
4372 }
4373}
4374
4375// Returns the argument type of the absolute value function.
4376static QualType getAbsoluteValueArgumentType(ASTContext &Context,
4377 unsigned AbsType) {
4378 if (AbsType == 0)
4379 return QualType();
4380
4381 ASTContext::GetBuiltinTypeError Error = ASTContext::GE_None;
4382 QualType BuiltinType = Context.GetBuiltinType(AbsType, Error);
4383 if (Error != ASTContext::GE_None)
4384 return QualType();
4385
4386 const FunctionProtoType *FT = BuiltinType->getAs<FunctionProtoType>();
4387 if (!FT)
4388 return QualType();
4389
4390 if (FT->getNumParams() != 1)
4391 return QualType();
4392
4393 return FT->getParamType(0);
4394}
4395
4396// Returns the best absolute value function, or zero, based on type and
4397// current absolute value function.
4398static unsigned getBestAbsFunction(ASTContext &Context, QualType ArgType,
4399 unsigned AbsFunctionKind) {
4400 unsigned BestKind = 0;
4401 uint64_t ArgSize = Context.getTypeSize(ArgType);
4402 for (unsigned Kind = AbsFunctionKind; Kind != 0;
4403 Kind = getLargerAbsoluteValueFunction(Kind)) {
4404 QualType ParamType = getAbsoluteValueArgumentType(Context, Kind);
4405 if (Context.getTypeSize(ParamType) >= ArgSize) {
4406 if (BestKind == 0)
4407 BestKind = Kind;
4408 else if (Context.hasSameType(ParamType, ArgType)) {
4409 BestKind = Kind;
4410 break;
4411 }
4412 }
4413 }
4414 return BestKind;
4415}
4416
4417enum AbsoluteValueKind {
4418 AVK_Integer,
4419 AVK_Floating,
4420 AVK_Complex
4421};
4422
4423static AbsoluteValueKind getAbsoluteValueKind(QualType T) {
4424 if (T->isIntegralOrEnumerationType())
4425 return AVK_Integer;
4426 if (T->isRealFloatingType())
4427 return AVK_Floating;
4428 if (T->isAnyComplexType())
4429 return AVK_Complex;
4430
4431 llvm_unreachable("Type not integer, floating, or complex");
4432}
4433
4434// Changes the absolute value function to a different type. Preserves whether
4435// the function is a builtin.
4436static unsigned changeAbsFunction(unsigned AbsKind,
4437 AbsoluteValueKind ValueKind) {
4438 switch (ValueKind) {
4439 case AVK_Integer:
4440 switch (AbsKind) {
4441 default:
4442 return 0;
4443 case Builtin::BI__builtin_fabsf:
4444 case Builtin::BI__builtin_fabs:
4445 case Builtin::BI__builtin_fabsl:
4446 case Builtin::BI__builtin_cabsf:
4447 case Builtin::BI__builtin_cabs:
4448 case Builtin::BI__builtin_cabsl:
4449 return Builtin::BI__builtin_abs;
4450 case Builtin::BIfabsf:
4451 case Builtin::BIfabs:
4452 case Builtin::BIfabsl:
4453 case Builtin::BIcabsf:
4454 case Builtin::BIcabs:
4455 case Builtin::BIcabsl:
4456 return Builtin::BIabs;
4457 }
4458 case AVK_Floating:
4459 switch (AbsKind) {
4460 default:
4461 return 0;
4462 case Builtin::BI__builtin_abs:
4463 case Builtin::BI__builtin_labs:
4464 case Builtin::BI__builtin_llabs:
4465 case Builtin::BI__builtin_cabsf:
4466 case Builtin::BI__builtin_cabs:
4467 case Builtin::BI__builtin_cabsl:
4468 return Builtin::BI__builtin_fabsf;
4469 case Builtin::BIabs:
4470 case Builtin::BIlabs:
4471 case Builtin::BIllabs:
4472 case Builtin::BIcabsf:
4473 case Builtin::BIcabs:
4474 case Builtin::BIcabsl:
4475 return Builtin::BIfabsf;
4476 }
4477 case AVK_Complex:
4478 switch (AbsKind) {
4479 default:
4480 return 0;
4481 case Builtin::BI__builtin_abs:
4482 case Builtin::BI__builtin_labs:
4483 case Builtin::BI__builtin_llabs:
4484 case Builtin::BI__builtin_fabsf:
4485 case Builtin::BI__builtin_fabs:
4486 case Builtin::BI__builtin_fabsl:
4487 return Builtin::BI__builtin_cabsf;
4488 case Builtin::BIabs:
4489 case Builtin::BIlabs:
4490 case Builtin::BIllabs:
4491 case Builtin::BIfabsf:
4492 case Builtin::BIfabs:
4493 case Builtin::BIfabsl:
4494 return Builtin::BIcabsf;
4495 }
4496 }
4497 llvm_unreachable("Unable to convert function");
4498}
4499
Benjamin Kramer3d6220d2014-03-01 17:21:22 +00004500static unsigned getAbsoluteValueFunctionKind(const FunctionDecl *FDecl) {
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004501 const IdentifierInfo *FnInfo = FDecl->getIdentifier();
4502 if (!FnInfo)
4503 return 0;
4504
4505 switch (FDecl->getBuiltinID()) {
4506 default:
4507 return 0;
4508 case Builtin::BI__builtin_abs:
4509 case Builtin::BI__builtin_fabs:
4510 case Builtin::BI__builtin_fabsf:
4511 case Builtin::BI__builtin_fabsl:
4512 case Builtin::BI__builtin_labs:
4513 case Builtin::BI__builtin_llabs:
4514 case Builtin::BI__builtin_cabs:
4515 case Builtin::BI__builtin_cabsf:
4516 case Builtin::BI__builtin_cabsl:
4517 case Builtin::BIabs:
4518 case Builtin::BIlabs:
4519 case Builtin::BIllabs:
4520 case Builtin::BIfabs:
4521 case Builtin::BIfabsf:
4522 case Builtin::BIfabsl:
4523 case Builtin::BIcabs:
4524 case Builtin::BIcabsf:
4525 case Builtin::BIcabsl:
4526 return FDecl->getBuiltinID();
4527 }
4528 llvm_unreachable("Unknown Builtin type");
4529}
4530
4531// If the replacement is valid, emit a note with replacement function.
4532// Additionally, suggest including the proper header if not already included.
4533static void emitReplacement(Sema &S, SourceLocation Loc, SourceRange Range,
Richard Trieubeffb832014-04-15 23:47:53 +00004534 unsigned AbsKind, QualType ArgType) {
4535 bool EmitHeaderHint = true;
Craig Topperc3ec1492014-05-26 06:22:03 +00004536 const char *HeaderName = nullptr;
4537 const char *FunctionName = nullptr;
Richard Trieubeffb832014-04-15 23:47:53 +00004538 if (S.getLangOpts().CPlusPlus && !ArgType->isAnyComplexType()) {
4539 FunctionName = "std::abs";
4540 if (ArgType->isIntegralOrEnumerationType()) {
4541 HeaderName = "cstdlib";
4542 } else if (ArgType->isRealFloatingType()) {
4543 HeaderName = "cmath";
4544 } else {
4545 llvm_unreachable("Invalid Type");
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004546 }
Richard Trieubeffb832014-04-15 23:47:53 +00004547
4548 // Lookup all std::abs
4549 if (NamespaceDecl *Std = S.getStdNamespace()) {
Alp Tokerb6cc5922014-05-03 03:45:55 +00004550 LookupResult R(S, &S.Context.Idents.get("abs"), Loc, Sema::LookupAnyName);
Richard Trieubeffb832014-04-15 23:47:53 +00004551 R.suppressDiagnostics();
4552 S.LookupQualifiedName(R, Std);
4553
4554 for (const auto *I : R) {
Craig Topperc3ec1492014-05-26 06:22:03 +00004555 const FunctionDecl *FDecl = nullptr;
Richard Trieubeffb832014-04-15 23:47:53 +00004556 if (const UsingShadowDecl *UsingD = dyn_cast<UsingShadowDecl>(I)) {
4557 FDecl = dyn_cast<FunctionDecl>(UsingD->getTargetDecl());
4558 } else {
4559 FDecl = dyn_cast<FunctionDecl>(I);
4560 }
4561 if (!FDecl)
4562 continue;
4563
4564 // Found std::abs(), check that they are the right ones.
4565 if (FDecl->getNumParams() != 1)
4566 continue;
4567
4568 // Check that the parameter type can handle the argument.
4569 QualType ParamType = FDecl->getParamDecl(0)->getType();
4570 if (getAbsoluteValueKind(ArgType) == getAbsoluteValueKind(ParamType) &&
4571 S.Context.getTypeSize(ArgType) <=
4572 S.Context.getTypeSize(ParamType)) {
4573 // Found a function, don't need the header hint.
4574 EmitHeaderHint = false;
4575 break;
4576 }
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004577 }
Richard Trieubeffb832014-04-15 23:47:53 +00004578 }
4579 } else {
4580 FunctionName = S.Context.BuiltinInfo.GetName(AbsKind);
4581 HeaderName = S.Context.BuiltinInfo.getHeaderName(AbsKind);
4582
4583 if (HeaderName) {
4584 DeclarationName DN(&S.Context.Idents.get(FunctionName));
4585 LookupResult R(S, DN, Loc, Sema::LookupAnyName);
4586 R.suppressDiagnostics();
4587 S.LookupName(R, S.getCurScope());
4588
4589 if (R.isSingleResult()) {
4590 FunctionDecl *FD = dyn_cast<FunctionDecl>(R.getFoundDecl());
4591 if (FD && FD->getBuiltinID() == AbsKind) {
4592 EmitHeaderHint = false;
4593 } else {
4594 return;
4595 }
4596 } else if (!R.empty()) {
4597 return;
4598 }
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004599 }
4600 }
4601
4602 S.Diag(Loc, diag::note_replace_abs_function)
Richard Trieubeffb832014-04-15 23:47:53 +00004603 << FunctionName << FixItHint::CreateReplacement(Range, FunctionName);
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004604
Richard Trieubeffb832014-04-15 23:47:53 +00004605 if (!HeaderName)
4606 return;
4607
4608 if (!EmitHeaderHint)
4609 return;
4610
Alp Toker5d96e0a2014-07-11 20:53:51 +00004611 S.Diag(Loc, diag::note_include_header_or_declare) << HeaderName
4612 << FunctionName;
Richard Trieubeffb832014-04-15 23:47:53 +00004613}
4614
4615static bool IsFunctionStdAbs(const FunctionDecl *FDecl) {
4616 if (!FDecl)
4617 return false;
4618
4619 if (!FDecl->getIdentifier() || !FDecl->getIdentifier()->isStr("abs"))
4620 return false;
4621
4622 const NamespaceDecl *ND = dyn_cast<NamespaceDecl>(FDecl->getDeclContext());
4623
4624 while (ND && ND->isInlineNamespace()) {
4625 ND = dyn_cast<NamespaceDecl>(ND->getDeclContext());
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004626 }
Richard Trieubeffb832014-04-15 23:47:53 +00004627
4628 if (!ND || !ND->getIdentifier() || !ND->getIdentifier()->isStr("std"))
4629 return false;
4630
4631 if (!isa<TranslationUnitDecl>(ND->getDeclContext()))
4632 return false;
4633
4634 return true;
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004635}
4636
4637// Warn when using the wrong abs() function.
4638void Sema::CheckAbsoluteValueFunction(const CallExpr *Call,
4639 const FunctionDecl *FDecl,
4640 IdentifierInfo *FnInfo) {
4641 if (Call->getNumArgs() != 1)
4642 return;
4643
4644 unsigned AbsKind = getAbsoluteValueFunctionKind(FDecl);
Richard Trieubeffb832014-04-15 23:47:53 +00004645 bool IsStdAbs = IsFunctionStdAbs(FDecl);
4646 if (AbsKind == 0 && !IsStdAbs)
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004647 return;
4648
4649 QualType ArgType = Call->getArg(0)->IgnoreParenImpCasts()->getType();
4650 QualType ParamType = Call->getArg(0)->getType();
4651
Alp Toker5d96e0a2014-07-11 20:53:51 +00004652 // Unsigned types cannot be negative. Suggest removing the absolute value
4653 // function call.
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004654 if (ArgType->isUnsignedIntegerType()) {
Richard Trieubeffb832014-04-15 23:47:53 +00004655 const char *FunctionName =
4656 IsStdAbs ? "std::abs" : Context.BuiltinInfo.GetName(AbsKind);
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004657 Diag(Call->getExprLoc(), diag::warn_unsigned_abs) << ArgType << ParamType;
4658 Diag(Call->getExprLoc(), diag::note_remove_abs)
Richard Trieubeffb832014-04-15 23:47:53 +00004659 << FunctionName
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004660 << FixItHint::CreateRemoval(Call->getCallee()->getSourceRange());
4661 return;
4662 }
4663
Richard Trieubeffb832014-04-15 23:47:53 +00004664 // std::abs has overloads which prevent most of the absolute value problems
4665 // from occurring.
4666 if (IsStdAbs)
4667 return;
4668
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004669 AbsoluteValueKind ArgValueKind = getAbsoluteValueKind(ArgType);
4670 AbsoluteValueKind ParamValueKind = getAbsoluteValueKind(ParamType);
4671
4672 // The argument and parameter are the same kind. Check if they are the right
4673 // size.
4674 if (ArgValueKind == ParamValueKind) {
4675 if (Context.getTypeSize(ArgType) <= Context.getTypeSize(ParamType))
4676 return;
4677
4678 unsigned NewAbsKind = getBestAbsFunction(Context, ArgType, AbsKind);
4679 Diag(Call->getExprLoc(), diag::warn_abs_too_small)
4680 << FDecl << ArgType << ParamType;
4681
4682 if (NewAbsKind == 0)
4683 return;
4684
4685 emitReplacement(*this, Call->getExprLoc(),
Richard Trieubeffb832014-04-15 23:47:53 +00004686 Call->getCallee()->getSourceRange(), NewAbsKind, ArgType);
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004687 return;
4688 }
4689
4690 // ArgValueKind != ParamValueKind
4691 // The wrong type of absolute value function was used. Attempt to find the
4692 // proper one.
4693 unsigned NewAbsKind = changeAbsFunction(AbsKind, ArgValueKind);
4694 NewAbsKind = getBestAbsFunction(Context, ArgType, NewAbsKind);
4695 if (NewAbsKind == 0)
4696 return;
4697
4698 Diag(Call->getExprLoc(), diag::warn_wrong_absolute_value_type)
4699 << FDecl << ParamValueKind << ArgValueKind;
4700
4701 emitReplacement(*this, Call->getExprLoc(),
Richard Trieubeffb832014-04-15 23:47:53 +00004702 Call->getCallee()->getSourceRange(), NewAbsKind, ArgType);
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00004703 return;
4704}
4705
Chandler Carruth53caa4d2011-04-27 07:05:31 +00004706//===--- CHECK: Standard memory functions ---------------------------------===//
4707
Nico Weber0e6daef2013-12-26 23:38:39 +00004708/// \brief Takes the expression passed to the size_t parameter of functions
4709/// such as memcmp, strncat, etc and warns if it's a comparison.
4710///
4711/// This is to catch typos like `if (memcmp(&a, &b, sizeof(a) > 0))`.
4712static bool CheckMemorySizeofForComparison(Sema &S, const Expr *E,
4713 IdentifierInfo *FnName,
4714 SourceLocation FnLoc,
4715 SourceLocation RParenLoc) {
4716 const BinaryOperator *Size = dyn_cast<BinaryOperator>(E);
4717 if (!Size)
4718 return false;
4719
4720 // if E is binop and op is >, <, >=, <=, ==, &&, ||:
4721 if (!Size->isComparisonOp() && !Size->isEqualityOp() && !Size->isLogicalOp())
4722 return false;
4723
Nico Weber0e6daef2013-12-26 23:38:39 +00004724 SourceRange SizeRange = Size->getSourceRange();
4725 S.Diag(Size->getOperatorLoc(), diag::warn_memsize_comparison)
4726 << SizeRange << FnName;
Alp Tokerb0869032014-05-17 01:13:18 +00004727 S.Diag(FnLoc, diag::note_memsize_comparison_paren)
Alp Tokerb6cc5922014-05-03 03:45:55 +00004728 << FnName << FixItHint::CreateInsertion(
4729 S.getLocForEndOfToken(Size->getLHS()->getLocEnd()), ")")
Nico Weber0e6daef2013-12-26 23:38:39 +00004730 << FixItHint::CreateRemoval(RParenLoc);
Alp Tokerb0869032014-05-17 01:13:18 +00004731 S.Diag(SizeRange.getBegin(), diag::note_memsize_comparison_cast_silence)
Nico Weber0e6daef2013-12-26 23:38:39 +00004732 << FixItHint::CreateInsertion(SizeRange.getBegin(), "(size_t)(")
Alp Tokerb6cc5922014-05-03 03:45:55 +00004733 << FixItHint::CreateInsertion(S.getLocForEndOfToken(SizeRange.getEnd()),
4734 ")");
Nico Weber0e6daef2013-12-26 23:38:39 +00004735
4736 return true;
4737}
4738
Reid Kleckner5fb5b122014-06-27 23:58:21 +00004739/// \brief Determine whether the given type is or contains a dynamic class type
4740/// (e.g., whether it has a vtable).
4741static const CXXRecordDecl *getContainedDynamicClass(QualType T,
4742 bool &IsContained) {
4743 // Look through array types while ignoring qualifiers.
4744 const Type *Ty = T->getBaseElementTypeUnsafe();
4745 IsContained = false;
4746
4747 const CXXRecordDecl *RD = Ty->getAsCXXRecordDecl();
4748 RD = RD ? RD->getDefinition() : nullptr;
4749 if (!RD)
4750 return nullptr;
4751
4752 if (RD->isDynamicClass())
4753 return RD;
4754
4755 // Check all the fields. If any bases were dynamic, the class is dynamic.
4756 // It's impossible for a class to transitively contain itself by value, so
4757 // infinite recursion is impossible.
4758 for (auto *FD : RD->fields()) {
4759 bool SubContained;
4760 if (const CXXRecordDecl *ContainedRD =
4761 getContainedDynamicClass(FD->getType(), SubContained)) {
4762 IsContained = true;
4763 return ContainedRD;
4764 }
4765 }
4766
4767 return nullptr;
Douglas Gregora74926b2011-05-03 20:05:22 +00004768}
4769
Chandler Carruth889ed862011-06-21 23:04:20 +00004770/// \brief If E is a sizeof expression, returns its argument expression,
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004771/// otherwise returns NULL.
Nico Weberc44b35e2015-03-21 17:37:46 +00004772static const Expr *getSizeOfExprArg(const Expr *E) {
Nico Weberc5e73862011-06-14 16:14:58 +00004773 if (const UnaryExprOrTypeTraitExpr *SizeOf =
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004774 dyn_cast<UnaryExprOrTypeTraitExpr>(E))
4775 if (SizeOf->getKind() == clang::UETT_SizeOf && !SizeOf->isArgumentType())
4776 return SizeOf->getArgumentExpr()->IgnoreParenImpCasts();
Nico Weberc5e73862011-06-14 16:14:58 +00004777
Craig Topperc3ec1492014-05-26 06:22:03 +00004778 return nullptr;
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004779}
4780
Chandler Carruth889ed862011-06-21 23:04:20 +00004781/// \brief If E is a sizeof expression, returns its argument type.
Nico Weberc44b35e2015-03-21 17:37:46 +00004782static QualType getSizeOfArgType(const Expr *E) {
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004783 if (const UnaryExprOrTypeTraitExpr *SizeOf =
4784 dyn_cast<UnaryExprOrTypeTraitExpr>(E))
4785 if (SizeOf->getKind() == clang::UETT_SizeOf)
4786 return SizeOf->getTypeOfArgument();
4787
4788 return QualType();
Nico Weberc5e73862011-06-14 16:14:58 +00004789}
4790
Chandler Carruth53caa4d2011-04-27 07:05:31 +00004791/// \brief Check for dangerous or invalid arguments to memset().
4792///
Chandler Carruthac687262011-06-03 06:23:57 +00004793/// This issues warnings on known problematic, dangerous or unspecified
Matt Beaumont-Gay3c489902011-08-05 00:22:34 +00004794/// arguments to the standard 'memset', 'memcpy', 'memmove', and 'memcmp'
4795/// function calls.
Chandler Carruth53caa4d2011-04-27 07:05:31 +00004796///
4797/// \param Call The call expression to diagnose.
Matt Beaumont-Gay3c489902011-08-05 00:22:34 +00004798void Sema::CheckMemaccessArguments(const CallExpr *Call,
Anna Zaks22122702012-01-17 00:37:07 +00004799 unsigned BId,
Matt Beaumont-Gay3c489902011-08-05 00:22:34 +00004800 IdentifierInfo *FnName) {
Anna Zaks22122702012-01-17 00:37:07 +00004801 assert(BId != 0);
4802
Ted Kremenekb5fabb22011-04-28 01:38:02 +00004803 // It is possible to have a non-standard definition of memset. Validate
Douglas Gregor18739c32011-06-16 17:56:04 +00004804 // we have enough arguments, and if not, abort further checking.
Anna Zaks22122702012-01-17 00:37:07 +00004805 unsigned ExpectedNumArgs = (BId == Builtin::BIstrndup ? 2 : 3);
Nico Weber39bfed82011-10-13 22:30:23 +00004806 if (Call->getNumArgs() < ExpectedNumArgs)
Ted Kremenekb5fabb22011-04-28 01:38:02 +00004807 return;
4808
Anna Zaks22122702012-01-17 00:37:07 +00004809 unsigned LastArg = (BId == Builtin::BImemset ||
4810 BId == Builtin::BIstrndup ? 1 : 2);
4811 unsigned LenArg = (BId == Builtin::BIstrndup ? 1 : 2);
Nico Weber39bfed82011-10-13 22:30:23 +00004812 const Expr *LenExpr = Call->getArg(LenArg)->IgnoreParenImpCasts();
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004813
Nico Weber0e6daef2013-12-26 23:38:39 +00004814 if (CheckMemorySizeofForComparison(*this, LenExpr, FnName,
4815 Call->getLocStart(), Call->getRParenLoc()))
4816 return;
4817
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004818 // We have special checking when the length is a sizeof expression.
4819 QualType SizeOfArgTy = getSizeOfArgType(LenExpr);
4820 const Expr *SizeOfArg = getSizeOfExprArg(LenExpr);
4821 llvm::FoldingSetNodeID SizeOfArgID;
4822
Douglas Gregor3bb2a812011-05-03 20:37:33 +00004823 for (unsigned ArgIdx = 0; ArgIdx != LastArg; ++ArgIdx) {
4824 const Expr *Dest = Call->getArg(ArgIdx)->IgnoreParenImpCasts();
Nico Weberc5e73862011-06-14 16:14:58 +00004825 SourceRange ArgRange = Call->getArg(ArgIdx)->getSourceRange();
Chandler Carruth53caa4d2011-04-27 07:05:31 +00004826
Douglas Gregor3bb2a812011-05-03 20:37:33 +00004827 QualType DestTy = Dest->getType();
Nico Weberc44b35e2015-03-21 17:37:46 +00004828 QualType PointeeTy;
Douglas Gregor3bb2a812011-05-03 20:37:33 +00004829 if (const PointerType *DestPtrTy = DestTy->getAs<PointerType>()) {
Nico Weberc44b35e2015-03-21 17:37:46 +00004830 PointeeTy = DestPtrTy->getPointeeType();
John McCall31168b02011-06-15 23:02:42 +00004831
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004832 // Never warn about void type pointers. This can be used to suppress
4833 // false positives.
4834 if (PointeeTy->isVoidType())
Douglas Gregor3bb2a812011-05-03 20:37:33 +00004835 continue;
Chandler Carruth53caa4d2011-04-27 07:05:31 +00004836
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004837 // Catch "memset(p, 0, sizeof(p))" -- needs to be sizeof(*p). Do this by
4838 // actually comparing the expressions for equality. Because computing the
4839 // expression IDs can be expensive, we only do this if the diagnostic is
4840 // enabled.
4841 if (SizeOfArg &&
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00004842 !Diags.isIgnored(diag::warn_sizeof_pointer_expr_memaccess,
4843 SizeOfArg->getExprLoc())) {
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004844 // We only compute IDs for expressions if the warning is enabled, and
4845 // cache the sizeof arg's ID.
4846 if (SizeOfArgID == llvm::FoldingSetNodeID())
4847 SizeOfArg->Profile(SizeOfArgID, Context, true);
4848 llvm::FoldingSetNodeID DestID;
4849 Dest->Profile(DestID, Context, true);
4850 if (DestID == SizeOfArgID) {
Nico Weber39bfed82011-10-13 22:30:23 +00004851 // TODO: For strncpy() and friends, this could suggest sizeof(dst)
4852 // over sizeof(src) as well.
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004853 unsigned ActionIdx = 0; // Default is to suggest dereferencing.
Anna Zaks869aecc2012-05-30 00:34:21 +00004854 StringRef ReadableName = FnName->getName();
4855
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004856 if (const UnaryOperator *UnaryOp = dyn_cast<UnaryOperator>(Dest))
Anna Zaksd08d9152012-05-30 23:14:52 +00004857 if (UnaryOp->getOpcode() == UO_AddrOf)
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004858 ActionIdx = 1; // If its an address-of operator, just remove it.
Fariborz Jahanian4d365ba2013-01-30 01:12:44 +00004859 if (!PointeeTy->isIncompleteType() &&
4860 (Context.getTypeSize(PointeeTy) == Context.getCharWidth()))
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004861 ActionIdx = 2; // If the pointee's size is sizeof(char),
4862 // suggest an explicit length.
Anna Zaks869aecc2012-05-30 00:34:21 +00004863
4864 // If the function is defined as a builtin macro, do not show macro
4865 // expansion.
4866 SourceLocation SL = SizeOfArg->getExprLoc();
4867 SourceRange DSR = Dest->getSourceRange();
4868 SourceRange SSR = SizeOfArg->getSourceRange();
Alp Tokerb6cc5922014-05-03 03:45:55 +00004869 SourceManager &SM = getSourceManager();
Anna Zaks869aecc2012-05-30 00:34:21 +00004870
4871 if (SM.isMacroArgExpansion(SL)) {
4872 ReadableName = Lexer::getImmediateMacroName(SL, SM, LangOpts);
4873 SL = SM.getSpellingLoc(SL);
4874 DSR = SourceRange(SM.getSpellingLoc(DSR.getBegin()),
4875 SM.getSpellingLoc(DSR.getEnd()));
4876 SSR = SourceRange(SM.getSpellingLoc(SSR.getBegin()),
4877 SM.getSpellingLoc(SSR.getEnd()));
4878 }
4879
Anna Zaksd08d9152012-05-30 23:14:52 +00004880 DiagRuntimeBehavior(SL, SizeOfArg,
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004881 PDiag(diag::warn_sizeof_pointer_expr_memaccess)
Anna Zaks869aecc2012-05-30 00:34:21 +00004882 << ReadableName
Anna Zaksd08d9152012-05-30 23:14:52 +00004883 << PointeeTy
4884 << DestTy
Anna Zaks869aecc2012-05-30 00:34:21 +00004885 << DSR
Anna Zaksd08d9152012-05-30 23:14:52 +00004886 << SSR);
4887 DiagRuntimeBehavior(SL, SizeOfArg,
4888 PDiag(diag::warn_sizeof_pointer_expr_memaccess_note)
4889 << ActionIdx
4890 << SSR);
4891
Chandler Carruth8b9e5a72011-06-16 09:09:40 +00004892 break;
4893 }
4894 }
4895
4896 // Also check for cases where the sizeof argument is the exact same
4897 // type as the memory argument, and where it points to a user-defined
4898 // record type.
4899 if (SizeOfArgTy != QualType()) {
4900 if (PointeeTy->isRecordType() &&
4901 Context.typesAreCompatible(SizeOfArgTy, DestTy)) {
4902 DiagRuntimeBehavior(LenExpr->getExprLoc(), Dest,
4903 PDiag(diag::warn_sizeof_pointer_type_memaccess)
4904 << FnName << SizeOfArgTy << ArgIdx
4905 << PointeeTy << Dest->getSourceRange()
4906 << LenExpr->getSourceRange());
4907 break;
4908 }
Nico Weberc5e73862011-06-14 16:14:58 +00004909 }
Nico Weberbac8b6b2015-03-21 17:56:44 +00004910 } else if (DestTy->isArrayType()) {
4911 PointeeTy = DestTy;
Nico Weberc44b35e2015-03-21 17:37:46 +00004912 }
Nico Weberc5e73862011-06-14 16:14:58 +00004913
Nico Weberc44b35e2015-03-21 17:37:46 +00004914 if (PointeeTy == QualType())
4915 continue;
Anna Zaks22122702012-01-17 00:37:07 +00004916
Nico Weberc44b35e2015-03-21 17:37:46 +00004917 // Always complain about dynamic classes.
4918 bool IsContained;
4919 if (const CXXRecordDecl *ContainedRD =
4920 getContainedDynamicClass(PointeeTy, IsContained)) {
John McCall31168b02011-06-15 23:02:42 +00004921
Nico Weberc44b35e2015-03-21 17:37:46 +00004922 unsigned OperationType = 0;
4923 // "overwritten" if we're warning about the destination for any call
4924 // but memcmp; otherwise a verb appropriate to the call.
4925 if (ArgIdx != 0 || BId == Builtin::BImemcmp) {
4926 if (BId == Builtin::BImemcpy)
4927 OperationType = 1;
4928 else if(BId == Builtin::BImemmove)
4929 OperationType = 2;
4930 else if (BId == Builtin::BImemcmp)
4931 OperationType = 3;
4932 }
4933
John McCall31168b02011-06-15 23:02:42 +00004934 DiagRuntimeBehavior(
4935 Dest->getExprLoc(), Dest,
Nico Weberc44b35e2015-03-21 17:37:46 +00004936 PDiag(diag::warn_dyn_class_memaccess)
4937 << (BId == Builtin::BImemcmp ? ArgIdx + 2 : ArgIdx)
4938 << FnName << IsContained << ContainedRD << OperationType
4939 << Call->getCallee()->getSourceRange());
4940 } else if (PointeeTy.hasNonTrivialObjCLifetime() &&
4941 BId != Builtin::BImemset)
4942 DiagRuntimeBehavior(
4943 Dest->getExprLoc(), Dest,
4944 PDiag(diag::warn_arc_object_memaccess)
4945 << ArgIdx << FnName << PointeeTy
4946 << Call->getCallee()->getSourceRange());
4947 else
4948 continue;
4949
4950 DiagRuntimeBehavior(
4951 Dest->getExprLoc(), Dest,
4952 PDiag(diag::note_bad_memaccess_silence)
4953 << FixItHint::CreateInsertion(ArgRange.getBegin(), "(void*)"));
4954 break;
Chandler Carruth53caa4d2011-04-27 07:05:31 +00004955 }
Nico Weberc44b35e2015-03-21 17:37:46 +00004956
Chandler Carruth53caa4d2011-04-27 07:05:31 +00004957}
4958
Ted Kremenek6865f772011-08-18 20:55:45 +00004959// A little helper routine: ignore addition and subtraction of integer literals.
4960// This intentionally does not ignore all integer constant expressions because
4961// we don't want to remove sizeof().
4962static const Expr *ignoreLiteralAdditions(const Expr *Ex, ASTContext &Ctx) {
4963 Ex = Ex->IgnoreParenCasts();
4964
4965 for (;;) {
4966 const BinaryOperator * BO = dyn_cast<BinaryOperator>(Ex);
4967 if (!BO || !BO->isAdditiveOp())
4968 break;
4969
4970 const Expr *RHS = BO->getRHS()->IgnoreParenCasts();
4971 const Expr *LHS = BO->getLHS()->IgnoreParenCasts();
4972
4973 if (isa<IntegerLiteral>(RHS))
4974 Ex = LHS;
4975 else if (isa<IntegerLiteral>(LHS))
4976 Ex = RHS;
4977 else
4978 break;
4979 }
4980
4981 return Ex;
4982}
4983
Anna Zaks13b08572012-08-08 21:42:23 +00004984static bool isConstantSizeArrayWithMoreThanOneElement(QualType Ty,
4985 ASTContext &Context) {
4986 // Only handle constant-sized or VLAs, but not flexible members.
4987 if (const ConstantArrayType *CAT = Context.getAsConstantArrayType(Ty)) {
4988 // Only issue the FIXIT for arrays of size > 1.
4989 if (CAT->getSize().getSExtValue() <= 1)
4990 return false;
4991 } else if (!Ty->isVariableArrayType()) {
4992 return false;
4993 }
4994 return true;
4995}
4996
Ted Kremenek6865f772011-08-18 20:55:45 +00004997// Warn if the user has made the 'size' argument to strlcpy or strlcat
4998// be the size of the source, instead of the destination.
4999void Sema::CheckStrlcpycatArguments(const CallExpr *Call,
5000 IdentifierInfo *FnName) {
5001
5002 // Don't crash if the user has the wrong number of arguments
Fariborz Jahanianab4fe982014-09-12 18:44:36 +00005003 unsigned NumArgs = Call->getNumArgs();
5004 if ((NumArgs != 3) && (NumArgs != 4))
Ted Kremenek6865f772011-08-18 20:55:45 +00005005 return;
5006
5007 const Expr *SrcArg = ignoreLiteralAdditions(Call->getArg(1), Context);
5008 const Expr *SizeArg = ignoreLiteralAdditions(Call->getArg(2), Context);
Craig Topperc3ec1492014-05-26 06:22:03 +00005009 const Expr *CompareWithSrc = nullptr;
Nico Weber0e6daef2013-12-26 23:38:39 +00005010
5011 if (CheckMemorySizeofForComparison(*this, SizeArg, FnName,
5012 Call->getLocStart(), Call->getRParenLoc()))
5013 return;
Ted Kremenek6865f772011-08-18 20:55:45 +00005014
5015 // Look for 'strlcpy(dst, x, sizeof(x))'
5016 if (const Expr *Ex = getSizeOfExprArg(SizeArg))
5017 CompareWithSrc = Ex;
5018 else {
5019 // Look for 'strlcpy(dst, x, strlen(x))'
5020 if (const CallExpr *SizeCall = dyn_cast<CallExpr>(SizeArg)) {
Alp Tokera724cff2013-12-28 21:59:02 +00005021 if (SizeCall->getBuiltinCallee() == Builtin::BIstrlen &&
5022 SizeCall->getNumArgs() == 1)
Ted Kremenek6865f772011-08-18 20:55:45 +00005023 CompareWithSrc = ignoreLiteralAdditions(SizeCall->getArg(0), Context);
5024 }
5025 }
5026
5027 if (!CompareWithSrc)
5028 return;
5029
5030 // Determine if the argument to sizeof/strlen is equal to the source
5031 // argument. In principle there's all kinds of things you could do
5032 // here, for instance creating an == expression and evaluating it with
5033 // EvaluateAsBooleanCondition, but this uses a more direct technique:
5034 const DeclRefExpr *SrcArgDRE = dyn_cast<DeclRefExpr>(SrcArg);
5035 if (!SrcArgDRE)
5036 return;
5037
5038 const DeclRefExpr *CompareWithSrcDRE = dyn_cast<DeclRefExpr>(CompareWithSrc);
5039 if (!CompareWithSrcDRE ||
5040 SrcArgDRE->getDecl() != CompareWithSrcDRE->getDecl())
5041 return;
5042
5043 const Expr *OriginalSizeArg = Call->getArg(2);
5044 Diag(CompareWithSrcDRE->getLocStart(), diag::warn_strlcpycat_wrong_size)
5045 << OriginalSizeArg->getSourceRange() << FnName;
5046
5047 // Output a FIXIT hint if the destination is an array (rather than a
5048 // pointer to an array). This could be enhanced to handle some
5049 // pointers if we know the actual size, like if DstArg is 'array+2'
5050 // we could say 'sizeof(array)-2'.
5051 const Expr *DstArg = Call->getArg(0)->IgnoreParenImpCasts();
Anna Zaks13b08572012-08-08 21:42:23 +00005052 if (!isConstantSizeArrayWithMoreThanOneElement(DstArg->getType(), Context))
Ted Kremenek18db5d42011-08-18 22:48:41 +00005053 return;
Ted Kremenek18db5d42011-08-18 22:48:41 +00005054
Dylan Noblesmith2c1dd272012-02-05 02:13:05 +00005055 SmallString<128> sizeString;
Ted Kremenek18db5d42011-08-18 22:48:41 +00005056 llvm::raw_svector_ostream OS(sizeString);
5057 OS << "sizeof(";
Craig Topperc3ec1492014-05-26 06:22:03 +00005058 DstArg->printPretty(OS, nullptr, getPrintingPolicy());
Ted Kremenek18db5d42011-08-18 22:48:41 +00005059 OS << ")";
5060
5061 Diag(OriginalSizeArg->getLocStart(), diag::note_strlcpycat_wrong_size)
5062 << FixItHint::CreateReplacement(OriginalSizeArg->getSourceRange(),
5063 OS.str());
Ted Kremenek6865f772011-08-18 20:55:45 +00005064}
5065
Anna Zaks314cd092012-02-01 19:08:57 +00005066/// Check if two expressions refer to the same declaration.
5067static bool referToTheSameDecl(const Expr *E1, const Expr *E2) {
5068 if (const DeclRefExpr *D1 = dyn_cast_or_null<DeclRefExpr>(E1))
5069 if (const DeclRefExpr *D2 = dyn_cast_or_null<DeclRefExpr>(E2))
5070 return D1->getDecl() == D2->getDecl();
5071 return false;
5072}
5073
5074static const Expr *getStrlenExprArg(const Expr *E) {
5075 if (const CallExpr *CE = dyn_cast<CallExpr>(E)) {
5076 const FunctionDecl *FD = CE->getDirectCallee();
5077 if (!FD || FD->getMemoryFunctionKind() != Builtin::BIstrlen)
Craig Topperc3ec1492014-05-26 06:22:03 +00005078 return nullptr;
Anna Zaks314cd092012-02-01 19:08:57 +00005079 return CE->getArg(0)->IgnoreParenCasts();
5080 }
Craig Topperc3ec1492014-05-26 06:22:03 +00005081 return nullptr;
Anna Zaks314cd092012-02-01 19:08:57 +00005082}
5083
5084// Warn on anti-patterns as the 'size' argument to strncat.
5085// The correct size argument should look like following:
5086// strncat(dst, src, sizeof(dst) - strlen(dest) - 1);
5087void Sema::CheckStrncatArguments(const CallExpr *CE,
5088 IdentifierInfo *FnName) {
5089 // Don't crash if the user has the wrong number of arguments.
5090 if (CE->getNumArgs() < 3)
5091 return;
5092 const Expr *DstArg = CE->getArg(0)->IgnoreParenCasts();
5093 const Expr *SrcArg = CE->getArg(1)->IgnoreParenCasts();
5094 const Expr *LenArg = CE->getArg(2)->IgnoreParenCasts();
5095
Nico Weber0e6daef2013-12-26 23:38:39 +00005096 if (CheckMemorySizeofForComparison(*this, LenArg, FnName, CE->getLocStart(),
5097 CE->getRParenLoc()))
5098 return;
5099
Anna Zaks314cd092012-02-01 19:08:57 +00005100 // Identify common expressions, which are wrongly used as the size argument
5101 // to strncat and may lead to buffer overflows.
5102 unsigned PatternType = 0;
5103 if (const Expr *SizeOfArg = getSizeOfExprArg(LenArg)) {
5104 // - sizeof(dst)
5105 if (referToTheSameDecl(SizeOfArg, DstArg))
5106 PatternType = 1;
5107 // - sizeof(src)
5108 else if (referToTheSameDecl(SizeOfArg, SrcArg))
5109 PatternType = 2;
5110 } else if (const BinaryOperator *BE = dyn_cast<BinaryOperator>(LenArg)) {
5111 if (BE->getOpcode() == BO_Sub) {
5112 const Expr *L = BE->getLHS()->IgnoreParenCasts();
5113 const Expr *R = BE->getRHS()->IgnoreParenCasts();
5114 // - sizeof(dst) - strlen(dst)
5115 if (referToTheSameDecl(DstArg, getSizeOfExprArg(L)) &&
5116 referToTheSameDecl(DstArg, getStrlenExprArg(R)))
5117 PatternType = 1;
5118 // - sizeof(src) - (anything)
5119 else if (referToTheSameDecl(SrcArg, getSizeOfExprArg(L)))
5120 PatternType = 2;
5121 }
5122 }
5123
5124 if (PatternType == 0)
5125 return;
5126
Anna Zaks5069aa32012-02-03 01:27:37 +00005127 // Generate the diagnostic.
5128 SourceLocation SL = LenArg->getLocStart();
5129 SourceRange SR = LenArg->getSourceRange();
Alp Tokerb6cc5922014-05-03 03:45:55 +00005130 SourceManager &SM = getSourceManager();
Anna Zaks5069aa32012-02-03 01:27:37 +00005131
5132 // If the function is defined as a builtin macro, do not show macro expansion.
5133 if (SM.isMacroArgExpansion(SL)) {
5134 SL = SM.getSpellingLoc(SL);
5135 SR = SourceRange(SM.getSpellingLoc(SR.getBegin()),
5136 SM.getSpellingLoc(SR.getEnd()));
5137 }
5138
Anna Zaks13b08572012-08-08 21:42:23 +00005139 // Check if the destination is an array (rather than a pointer to an array).
5140 QualType DstTy = DstArg->getType();
5141 bool isKnownSizeArray = isConstantSizeArrayWithMoreThanOneElement(DstTy,
5142 Context);
5143 if (!isKnownSizeArray) {
5144 if (PatternType == 1)
5145 Diag(SL, diag::warn_strncat_wrong_size) << SR;
5146 else
5147 Diag(SL, diag::warn_strncat_src_size) << SR;
5148 return;
5149 }
5150
Anna Zaks314cd092012-02-01 19:08:57 +00005151 if (PatternType == 1)
Anna Zaks5069aa32012-02-03 01:27:37 +00005152 Diag(SL, diag::warn_strncat_large_size) << SR;
Anna Zaks314cd092012-02-01 19:08:57 +00005153 else
Anna Zaks5069aa32012-02-03 01:27:37 +00005154 Diag(SL, diag::warn_strncat_src_size) << SR;
Anna Zaks314cd092012-02-01 19:08:57 +00005155
Dylan Noblesmith2c1dd272012-02-05 02:13:05 +00005156 SmallString<128> sizeString;
Anna Zaks314cd092012-02-01 19:08:57 +00005157 llvm::raw_svector_ostream OS(sizeString);
5158 OS << "sizeof(";
Craig Topperc3ec1492014-05-26 06:22:03 +00005159 DstArg->printPretty(OS, nullptr, getPrintingPolicy());
Anna Zaks314cd092012-02-01 19:08:57 +00005160 OS << ") - ";
5161 OS << "strlen(";
Craig Topperc3ec1492014-05-26 06:22:03 +00005162 DstArg->printPretty(OS, nullptr, getPrintingPolicy());
Anna Zaks314cd092012-02-01 19:08:57 +00005163 OS << ") - 1";
5164
Anna Zaks5069aa32012-02-03 01:27:37 +00005165 Diag(SL, diag::note_strncat_wrong_size)
5166 << FixItHint::CreateReplacement(SR, OS.str());
Anna Zaks314cd092012-02-01 19:08:57 +00005167}
5168
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005169//===--- CHECK: Return Address of Stack Variable --------------------------===//
5170
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005171static Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
5172 Decl *ParentDecl);
5173static Expr *EvalAddr(Expr* E, SmallVectorImpl<DeclRefExpr *> &refVars,
5174 Decl *ParentDecl);
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005175
5176/// CheckReturnStackAddr - Check if a return statement returns the address
5177/// of a stack variable.
Ted Kremenekef9e7f82014-01-22 06:10:28 +00005178static void
5179CheckReturnStackAddr(Sema &S, Expr *RetValExp, QualType lhsType,
5180 SourceLocation ReturnLoc) {
Mike Stump11289f42009-09-09 15:08:12 +00005181
Craig Topperc3ec1492014-05-26 06:22:03 +00005182 Expr *stackE = nullptr;
Chris Lattner0e62c1c2011-07-23 10:55:15 +00005183 SmallVector<DeclRefExpr *, 8> refVars;
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005184
5185 // Perform checking for returned stack addresses, local blocks,
5186 // label addresses or references to temporaries.
John McCall31168b02011-06-15 23:02:42 +00005187 if (lhsType->isPointerType() ||
Ted Kremenekef9e7f82014-01-22 06:10:28 +00005188 (!S.getLangOpts().ObjCAutoRefCount && lhsType->isBlockPointerType())) {
Craig Topperc3ec1492014-05-26 06:22:03 +00005189 stackE = EvalAddr(RetValExp, refVars, /*ParentDecl=*/nullptr);
Mike Stump12b8ce12009-08-04 21:02:39 +00005190 } else if (lhsType->isReferenceType()) {
Craig Topperc3ec1492014-05-26 06:22:03 +00005191 stackE = EvalVal(RetValExp, refVars, /*ParentDecl=*/nullptr);
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005192 }
5193
Craig Topperc3ec1492014-05-26 06:22:03 +00005194 if (!stackE)
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005195 return; // Nothing suspicious was found.
5196
5197 SourceLocation diagLoc;
5198 SourceRange diagRange;
5199 if (refVars.empty()) {
5200 diagLoc = stackE->getLocStart();
5201 diagRange = stackE->getSourceRange();
5202 } else {
5203 // We followed through a reference variable. 'stackE' contains the
5204 // problematic expression but we will warn at the return statement pointing
5205 // at the reference variable. We will later display the "trail" of
5206 // reference variables using notes.
5207 diagLoc = refVars[0]->getLocStart();
5208 diagRange = refVars[0]->getSourceRange();
5209 }
5210
5211 if (DeclRefExpr *DR = dyn_cast<DeclRefExpr>(stackE)) { //address of local var.
Ted Kremenekef9e7f82014-01-22 06:10:28 +00005212 S.Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_stack_ref
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005213 : diag::warn_ret_stack_addr)
5214 << DR->getDecl()->getDeclName() << diagRange;
5215 } else if (isa<BlockExpr>(stackE)) { // local block.
Ted Kremenekef9e7f82014-01-22 06:10:28 +00005216 S.Diag(diagLoc, diag::err_ret_local_block) << diagRange;
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005217 } else if (isa<AddrLabelExpr>(stackE)) { // address of label.
Ted Kremenekef9e7f82014-01-22 06:10:28 +00005218 S.Diag(diagLoc, diag::warn_ret_addr_label) << diagRange;
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005219 } else { // local temporary.
Ted Kremenekef9e7f82014-01-22 06:10:28 +00005220 S.Diag(diagLoc, lhsType->isReferenceType() ? diag::warn_ret_local_temp_ref
5221 : diag::warn_ret_local_temp_addr)
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005222 << diagRange;
5223 }
5224
5225 // Display the "trail" of reference variables that we followed until we
5226 // found the problematic expression using notes.
5227 for (unsigned i = 0, e = refVars.size(); i != e; ++i) {
5228 VarDecl *VD = cast<VarDecl>(refVars[i]->getDecl());
5229 // If this var binds to another reference var, show the range of the next
5230 // var, otherwise the var binds to the problematic expression, in which case
5231 // show the range of the expression.
5232 SourceRange range = (i < e-1) ? refVars[i+1]->getSourceRange()
5233 : stackE->getSourceRange();
Ted Kremenekef9e7f82014-01-22 06:10:28 +00005234 S.Diag(VD->getLocation(), diag::note_ref_var_local_bind)
5235 << VD->getDeclName() << range;
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005236 }
5237}
5238
5239/// EvalAddr - EvalAddr and EvalVal are mutually recursive functions that
5240/// check if the expression in a return statement evaluates to an address
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005241/// to a location on the stack, a local block, an address of a label, or a
5242/// reference to local temporary. The recursion is used to traverse the
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005243/// AST of the return expression, with recursion backtracking when we
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005244/// encounter a subexpression that (1) clearly does not lead to one of the
5245/// above problematic expressions (2) is something we cannot determine leads to
5246/// a problematic expression based on such local checking.
5247///
5248/// Both EvalAddr and EvalVal follow through reference variables to evaluate
5249/// the expression that they point to. Such variables are added to the
5250/// 'refVars' vector so that we know what the reference variable "trail" was.
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005251///
Ted Kremeneke07a8cd2007-08-28 17:02:55 +00005252/// EvalAddr processes expressions that are pointers that are used as
5253/// references (and not L-values). EvalVal handles all other values.
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005254/// At the base case of the recursion is a check for the above problematic
5255/// expressions.
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005256///
5257/// This implementation handles:
5258///
5259/// * pointer-to-pointer casts
5260/// * implicit conversions from array references to pointers
5261/// * taking the address of fields
5262/// * arbitrary interplay between "&" and "*" operators
5263/// * pointer arithmetic from an address of a stack variable
5264/// * taking the address of an array element where the array is on the stack
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005265static Expr *EvalAddr(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
5266 Decl *ParentDecl) {
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005267 if (E->isTypeDependent())
Craig Topperc3ec1492014-05-26 06:22:03 +00005268 return nullptr;
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005269
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005270 // We should only be called for evaluating pointer expressions.
David Chisnall9f57c292009-08-17 16:35:33 +00005271 assert((E->getType()->isAnyPointerType() ||
Steve Naroff8de9c3a2008-09-05 22:11:13 +00005272 E->getType()->isBlockPointerType() ||
Ted Kremenek1b0ea822008-01-07 19:49:32 +00005273 E->getType()->isObjCQualifiedIdType()) &&
Chris Lattner934edb22007-12-28 05:31:15 +00005274 "EvalAddr only works on pointers");
Mike Stump11289f42009-09-09 15:08:12 +00005275
Peter Collingbourne91147592011-04-15 00:35:48 +00005276 E = E->IgnoreParens();
5277
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005278 // Our "symbolic interpreter" is just a dispatch off the currently
5279 // viewed AST node. We then recursively traverse the AST by calling
5280 // EvalAddr and EvalVal appropriately.
5281 switch (E->getStmtClass()) {
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005282 case Stmt::DeclRefExprClass: {
5283 DeclRefExpr *DR = cast<DeclRefExpr>(E);
5284
Richard Smith40f08eb2014-01-30 22:05:38 +00005285 // If we leave the immediate function, the lifetime isn't about to end.
Alexey Bataev19acc3d2015-01-12 10:17:46 +00005286 if (DR->refersToEnclosingVariableOrCapture())
Craig Topperc3ec1492014-05-26 06:22:03 +00005287 return nullptr;
Richard Smith40f08eb2014-01-30 22:05:38 +00005288
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005289 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
5290 // If this is a reference variable, follow through to the expression that
5291 // it points to.
5292 if (V->hasLocalStorage() &&
5293 V->getType()->isReferenceType() && V->hasInit()) {
5294 // Add the reference variable to the "trail".
5295 refVars.push_back(DR);
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005296 return EvalAddr(V->getInit(), refVars, ParentDecl);
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005297 }
5298
Craig Topperc3ec1492014-05-26 06:22:03 +00005299 return nullptr;
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005300 }
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005301
Chris Lattner934edb22007-12-28 05:31:15 +00005302 case Stmt::UnaryOperatorClass: {
5303 // The only unary operator that make sense to handle here
5304 // is AddrOf. All others don't make sense as pointers.
5305 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump11289f42009-09-09 15:08:12 +00005306
John McCalle3027922010-08-25 11:45:40 +00005307 if (U->getOpcode() == UO_AddrOf)
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005308 return EvalVal(U->getSubExpr(), refVars, ParentDecl);
Chris Lattner934edb22007-12-28 05:31:15 +00005309 else
Craig Topperc3ec1492014-05-26 06:22:03 +00005310 return nullptr;
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005311 }
Mike Stump11289f42009-09-09 15:08:12 +00005312
Chris Lattner934edb22007-12-28 05:31:15 +00005313 case Stmt::BinaryOperatorClass: {
5314 // Handle pointer arithmetic. All other binary operators are not valid
5315 // in this context.
5316 BinaryOperator *B = cast<BinaryOperator>(E);
John McCalle3027922010-08-25 11:45:40 +00005317 BinaryOperatorKind op = B->getOpcode();
Mike Stump11289f42009-09-09 15:08:12 +00005318
John McCalle3027922010-08-25 11:45:40 +00005319 if (op != BO_Add && op != BO_Sub)
Craig Topperc3ec1492014-05-26 06:22:03 +00005320 return nullptr;
Mike Stump11289f42009-09-09 15:08:12 +00005321
Chris Lattner934edb22007-12-28 05:31:15 +00005322 Expr *Base = B->getLHS();
5323
5324 // Determine which argument is the real pointer base. It could be
5325 // the RHS argument instead of the LHS.
5326 if (!Base->getType()->isPointerType()) Base = B->getRHS();
Mike Stump11289f42009-09-09 15:08:12 +00005327
Chris Lattner934edb22007-12-28 05:31:15 +00005328 assert (Base->getType()->isPointerType());
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005329 return EvalAddr(Base, refVars, ParentDecl);
Chris Lattner934edb22007-12-28 05:31:15 +00005330 }
Steve Naroff2752a172008-09-10 19:17:48 +00005331
Chris Lattner934edb22007-12-28 05:31:15 +00005332 // For conditional operators we need to see if either the LHS or RHS are
5333 // valid DeclRefExpr*s. If one of them is valid, we return it.
5334 case Stmt::ConditionalOperatorClass: {
5335 ConditionalOperator *C = cast<ConditionalOperator>(E);
Mike Stump11289f42009-09-09 15:08:12 +00005336
Chris Lattner934edb22007-12-28 05:31:15 +00005337 // Handle the GNU extension for missing LHS.
Richard Smith6a6a4bb2014-01-27 04:19:56 +00005338 // FIXME: That isn't a ConditionalOperator, so doesn't get here.
5339 if (Expr *LHSExpr = C->getLHS()) {
5340 // In C++, we can have a throw-expression, which has 'void' type.
5341 if (!LHSExpr->getType()->isVoidType())
5342 if (Expr *LHS = EvalAddr(LHSExpr, refVars, ParentDecl))
Douglas Gregor270b2ef2010-10-21 16:21:08 +00005343 return LHS;
5344 }
Chris Lattner934edb22007-12-28 05:31:15 +00005345
Douglas Gregor270b2ef2010-10-21 16:21:08 +00005346 // In C++, we can have a throw-expression, which has 'void' type.
5347 if (C->getRHS()->getType()->isVoidType())
Craig Topperc3ec1492014-05-26 06:22:03 +00005348 return nullptr;
Douglas Gregor270b2ef2010-10-21 16:21:08 +00005349
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005350 return EvalAddr(C->getRHS(), refVars, ParentDecl);
Chris Lattner934edb22007-12-28 05:31:15 +00005351 }
Richard Smith6a6a4bb2014-01-27 04:19:56 +00005352
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005353 case Stmt::BlockExprClass:
John McCallc63de662011-02-02 13:00:07 +00005354 if (cast<BlockExpr>(E)->getBlockDecl()->hasCaptures())
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005355 return E; // local block.
Craig Topperc3ec1492014-05-26 06:22:03 +00005356 return nullptr;
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005357
5358 case Stmt::AddrLabelExprClass:
5359 return E; // address of label.
Mike Stump11289f42009-09-09 15:08:12 +00005360
John McCall28fc7092011-11-10 05:35:25 +00005361 case Stmt::ExprWithCleanupsClass:
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005362 return EvalAddr(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,
5363 ParentDecl);
John McCall28fc7092011-11-10 05:35:25 +00005364
Ted Kremenekc3b4c522008-08-07 00:49:01 +00005365 // For casts, we need to handle conversions from arrays to
5366 // pointer values, and pointer-to-pointer conversions.
Douglas Gregore200adc2008-10-27 19:41:14 +00005367 case Stmt::ImplicitCastExprClass:
Douglas Gregorf19b2312008-10-28 15:36:24 +00005368 case Stmt::CStyleCastExprClass:
John McCall31168b02011-06-15 23:02:42 +00005369 case Stmt::CXXFunctionalCastExprClass:
Eli Friedman8195ad72012-02-23 23:04:32 +00005370 case Stmt::ObjCBridgedCastExprClass:
Mike Stump11289f42009-09-09 15:08:12 +00005371 case Stmt::CXXStaticCastExprClass:
5372 case Stmt::CXXDynamicCastExprClass:
Douglas Gregore200adc2008-10-27 19:41:14 +00005373 case Stmt::CXXConstCastExprClass:
5374 case Stmt::CXXReinterpretCastExprClass: {
Eli Friedman8195ad72012-02-23 23:04:32 +00005375 Expr* SubExpr = cast<CastExpr>(E)->getSubExpr();
5376 switch (cast<CastExpr>(E)->getCastKind()) {
Eli Friedman8195ad72012-02-23 23:04:32 +00005377 case CK_LValueToRValue:
5378 case CK_NoOp:
5379 case CK_BaseToDerived:
5380 case CK_DerivedToBase:
5381 case CK_UncheckedDerivedToBase:
5382 case CK_Dynamic:
5383 case CK_CPointerToObjCPointerCast:
5384 case CK_BlockPointerToObjCPointerCast:
5385 case CK_AnyPointerToBlockPointerCast:
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005386 return EvalAddr(SubExpr, refVars, ParentDecl);
Eli Friedman8195ad72012-02-23 23:04:32 +00005387
5388 case CK_ArrayToPointerDecay:
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005389 return EvalVal(SubExpr, refVars, ParentDecl);
Eli Friedman8195ad72012-02-23 23:04:32 +00005390
Richard Trieudadefde2014-07-02 04:39:38 +00005391 case CK_BitCast:
5392 if (SubExpr->getType()->isAnyPointerType() ||
5393 SubExpr->getType()->isBlockPointerType() ||
5394 SubExpr->getType()->isObjCQualifiedIdType())
5395 return EvalAddr(SubExpr, refVars, ParentDecl);
5396 else
5397 return nullptr;
5398
Eli Friedman8195ad72012-02-23 23:04:32 +00005399 default:
Craig Topperc3ec1492014-05-26 06:22:03 +00005400 return nullptr;
Eli Friedman8195ad72012-02-23 23:04:32 +00005401 }
Chris Lattner934edb22007-12-28 05:31:15 +00005402 }
Mike Stump11289f42009-09-09 15:08:12 +00005403
Douglas Gregorfe314812011-06-21 17:03:29 +00005404 case Stmt::MaterializeTemporaryExprClass:
5405 if (Expr *Result = EvalAddr(
5406 cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005407 refVars, ParentDecl))
Douglas Gregorfe314812011-06-21 17:03:29 +00005408 return Result;
5409
5410 return E;
5411
Chris Lattner934edb22007-12-28 05:31:15 +00005412 // Everything else: we simply don't reason about them.
5413 default:
Craig Topperc3ec1492014-05-26 06:22:03 +00005414 return nullptr;
Chris Lattner934edb22007-12-28 05:31:15 +00005415 }
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005416}
Mike Stump11289f42009-09-09 15:08:12 +00005417
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005418
5419/// EvalVal - This function is complements EvalAddr in the mutual recursion.
5420/// See the comments for EvalAddr for more details.
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005421static Expr *EvalVal(Expr *E, SmallVectorImpl<DeclRefExpr *> &refVars,
5422 Decl *ParentDecl) {
Ted Kremenekb7861562010-08-04 20:01:07 +00005423do {
Ted Kremeneke07a8cd2007-08-28 17:02:55 +00005424 // We should only be called for evaluating non-pointer expressions, or
5425 // expressions with a pointer type that are not used as references but instead
5426 // are l-values (e.g., DeclRefExpr with a pointer type).
Mike Stump11289f42009-09-09 15:08:12 +00005427
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005428 // Our "symbolic interpreter" is just a dispatch off the currently
5429 // viewed AST node. We then recursively traverse the AST by calling
5430 // EvalAddr and EvalVal appropriately.
Peter Collingbourne91147592011-04-15 00:35:48 +00005431
5432 E = E->IgnoreParens();
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005433 switch (E->getStmtClass()) {
Ted Kremenekb7861562010-08-04 20:01:07 +00005434 case Stmt::ImplicitCastExprClass: {
5435 ImplicitCastExpr *IE = cast<ImplicitCastExpr>(E);
John McCall2536c6d2010-08-25 10:28:54 +00005436 if (IE->getValueKind() == VK_LValue) {
Ted Kremenekb7861562010-08-04 20:01:07 +00005437 E = IE->getSubExpr();
5438 continue;
5439 }
Craig Topperc3ec1492014-05-26 06:22:03 +00005440 return nullptr;
Ted Kremenekb7861562010-08-04 20:01:07 +00005441 }
5442
John McCall28fc7092011-11-10 05:35:25 +00005443 case Stmt::ExprWithCleanupsClass:
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005444 return EvalVal(cast<ExprWithCleanups>(E)->getSubExpr(), refVars,ParentDecl);
John McCall28fc7092011-11-10 05:35:25 +00005445
Douglas Gregor4bd90e52009-10-23 18:54:35 +00005446 case Stmt::DeclRefExprClass: {
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005447 // When we hit a DeclRefExpr we are looking at code that refers to a
5448 // variable's name. If it's not a reference variable we check if it has
5449 // local storage within the function, and if so, return the expression.
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005450 DeclRefExpr *DR = cast<DeclRefExpr>(E);
Mike Stump11289f42009-09-09 15:08:12 +00005451
Richard Smith40f08eb2014-01-30 22:05:38 +00005452 // If we leave the immediate function, the lifetime isn't about to end.
Alexey Bataev19acc3d2015-01-12 10:17:46 +00005453 if (DR->refersToEnclosingVariableOrCapture())
Craig Topperc3ec1492014-05-26 06:22:03 +00005454 return nullptr;
Richard Smith40f08eb2014-01-30 22:05:38 +00005455
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005456 if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl())) {
5457 // Check if it refers to itself, e.g. "int& i = i;".
5458 if (V == ParentDecl)
5459 return DR;
5460
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005461 if (V->hasLocalStorage()) {
5462 if (!V->getType()->isReferenceType())
5463 return DR;
5464
5465 // Reference variable, follow through to the expression that
5466 // it points to.
5467 if (V->hasInit()) {
5468 // Add the reference variable to the "trail".
5469 refVars.push_back(DR);
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005470 return EvalVal(V->getInit(), refVars, V);
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005471 }
5472 }
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005473 }
Mike Stump11289f42009-09-09 15:08:12 +00005474
Craig Topperc3ec1492014-05-26 06:22:03 +00005475 return nullptr;
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005476 }
Mike Stump11289f42009-09-09 15:08:12 +00005477
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005478 case Stmt::UnaryOperatorClass: {
5479 // The only unary operator that make sense to handle here
5480 // is Deref. All others don't resolve to a "name." This includes
5481 // handling all sorts of rvalues passed to a unary operator.
5482 UnaryOperator *U = cast<UnaryOperator>(E);
Mike Stump11289f42009-09-09 15:08:12 +00005483
John McCalle3027922010-08-25 11:45:40 +00005484 if (U->getOpcode() == UO_Deref)
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005485 return EvalAddr(U->getSubExpr(), refVars, ParentDecl);
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005486
Craig Topperc3ec1492014-05-26 06:22:03 +00005487 return nullptr;
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005488 }
Mike Stump11289f42009-09-09 15:08:12 +00005489
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005490 case Stmt::ArraySubscriptExprClass: {
5491 // Array subscripts are potential references to data on the stack. We
5492 // retrieve the DeclRefExpr* for the array variable if it indeed
5493 // has local storage.
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005494 return EvalAddr(cast<ArraySubscriptExpr>(E)->getBase(), refVars,ParentDecl);
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005495 }
Mike Stump11289f42009-09-09 15:08:12 +00005496
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005497 case Stmt::ConditionalOperatorClass: {
5498 // For conditional operators we need to see if either the LHS or RHS are
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005499 // non-NULL Expr's. If one is non-NULL, we return it.
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005500 ConditionalOperator *C = cast<ConditionalOperator>(E);
5501
Anders Carlsson801c5c72007-11-30 19:04:31 +00005502 // Handle the GNU extension for missing LHS.
Richard Smith6a6a4bb2014-01-27 04:19:56 +00005503 if (Expr *LHSExpr = C->getLHS()) {
5504 // In C++, we can have a throw-expression, which has 'void' type.
5505 if (!LHSExpr->getType()->isVoidType())
5506 if (Expr *LHS = EvalVal(LHSExpr, refVars, ParentDecl))
5507 return LHS;
5508 }
5509
5510 // In C++, we can have a throw-expression, which has 'void' type.
5511 if (C->getRHS()->getType()->isVoidType())
Craig Topperc3ec1492014-05-26 06:22:03 +00005512 return nullptr;
Anders Carlsson801c5c72007-11-30 19:04:31 +00005513
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005514 return EvalVal(C->getRHS(), refVars, ParentDecl);
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005515 }
Mike Stump11289f42009-09-09 15:08:12 +00005516
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005517 // Accesses to members are potential references to data on the stack.
Douglas Gregorf405d7e2009-08-31 23:41:50 +00005518 case Stmt::MemberExprClass: {
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005519 MemberExpr *M = cast<MemberExpr>(E);
Mike Stump11289f42009-09-09 15:08:12 +00005520
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005521 // Check for indirect access. We only want direct field accesses.
Ted Kremenekcbe6b0b2010-09-02 01:12:13 +00005522 if (M->isArrow())
Craig Topperc3ec1492014-05-26 06:22:03 +00005523 return nullptr;
Ted Kremenekcbe6b0b2010-09-02 01:12:13 +00005524
5525 // Check whether the member type is itself a reference, in which case
5526 // we're not going to refer to the member, but to what the member refers to.
5527 if (M->getMemberDecl()->getType()->isReferenceType())
Craig Topperc3ec1492014-05-26 06:22:03 +00005528 return nullptr;
Ted Kremenekcbe6b0b2010-09-02 01:12:13 +00005529
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005530 return EvalVal(M->getBase(), refVars, ParentDecl);
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005531 }
Mike Stump11289f42009-09-09 15:08:12 +00005532
Douglas Gregorfe314812011-06-21 17:03:29 +00005533 case Stmt::MaterializeTemporaryExprClass:
5534 if (Expr *Result = EvalVal(
5535 cast<MaterializeTemporaryExpr>(E)->GetTemporaryExpr(),
Argyrios Kyrtzidisb4015e12012-04-30 23:23:55 +00005536 refVars, ParentDecl))
Douglas Gregorfe314812011-06-21 17:03:29 +00005537 return Result;
5538
5539 return E;
5540
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005541 default:
Argyrios Kyrtzidise72f7152010-11-30 22:57:32 +00005542 // Check that we don't return or take the address of a reference to a
5543 // temporary. This is only useful in C++.
5544 if (!E->isTypeDependent() && E->isRValue())
5545 return E;
5546
5547 // Everything else: we simply don't reason about them.
Craig Topperc3ec1492014-05-26 06:22:03 +00005548 return nullptr;
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005549 }
Ted Kremenekb7861562010-08-04 20:01:07 +00005550} while (true);
Ted Kremenekcff94fa2007-08-17 16:46:58 +00005551}
Ted Kremenek43fb8b02007-11-25 00:58:00 +00005552
Ted Kremenekef9e7f82014-01-22 06:10:28 +00005553void
5554Sema::CheckReturnValExpr(Expr *RetValExp, QualType lhsType,
5555 SourceLocation ReturnLoc,
5556 bool isObjCMethod,
Artyom Skrobov9f213442014-01-24 11:10:39 +00005557 const AttrVec *Attrs,
5558 const FunctionDecl *FD) {
Ted Kremenekef9e7f82014-01-22 06:10:28 +00005559 CheckReturnStackAddr(*this, RetValExp, lhsType, ReturnLoc);
5560
5561 // Check if the return value is null but should not be.
Benjamin Kramerae852a62014-02-23 14:34:50 +00005562 if (Attrs && hasSpecificAttr<ReturnsNonNullAttr>(*Attrs) &&
5563 CheckNonNullExpr(*this, RetValExp))
5564 Diag(ReturnLoc, diag::warn_null_ret)
5565 << (isObjCMethod ? 1 : 0) << RetValExp->getSourceRange();
Artyom Skrobov9f213442014-01-24 11:10:39 +00005566
5567 // C++11 [basic.stc.dynamic.allocation]p4:
5568 // If an allocation function declared with a non-throwing
5569 // exception-specification fails to allocate storage, it shall return
5570 // a null pointer. Any other allocation function that fails to allocate
5571 // storage shall indicate failure only by throwing an exception [...]
5572 if (FD) {
5573 OverloadedOperatorKind Op = FD->getOverloadedOperator();
5574 if (Op == OO_New || Op == OO_Array_New) {
5575 const FunctionProtoType *Proto
5576 = FD->getType()->castAs<FunctionProtoType>();
5577 if (!Proto->isNothrow(Context, /*ResultIfDependent*/true) &&
5578 CheckNonNullExpr(*this, RetValExp))
5579 Diag(ReturnLoc, diag::warn_operator_new_returns_null)
5580 << FD << getLangOpts().CPlusPlus11;
5581 }
5582 }
Ted Kremenekef9e7f82014-01-22 06:10:28 +00005583}
5584
Ted Kremenek43fb8b02007-11-25 00:58:00 +00005585//===--- CHECK: Floating-Point comparisons (-Wfloat-equal) ---------------===//
5586
5587/// Check for comparisons of floating point operands using != and ==.
5588/// Issue a warning if these are no self-comparisons, as they are not likely
5589/// to do what the programmer intended.
Richard Trieu82402a02011-09-15 21:56:47 +00005590void Sema::CheckFloatComparison(SourceLocation Loc, Expr* LHS, Expr *RHS) {
Richard Trieu82402a02011-09-15 21:56:47 +00005591 Expr* LeftExprSansParen = LHS->IgnoreParenImpCasts();
5592 Expr* RightExprSansParen = RHS->IgnoreParenImpCasts();
Ted Kremenek43fb8b02007-11-25 00:58:00 +00005593
5594 // Special case: check for x == x (which is OK).
5595 // Do not emit warnings for such cases.
5596 if (DeclRefExpr* DRL = dyn_cast<DeclRefExpr>(LeftExprSansParen))
5597 if (DeclRefExpr* DRR = dyn_cast<DeclRefExpr>(RightExprSansParen))
5598 if (DRL->getDecl() == DRR->getDecl())
David Blaikie1f4ff152012-07-16 20:47:22 +00005599 return;
Mike Stump11289f42009-09-09 15:08:12 +00005600
5601
Ted Kremenekeda40e22007-11-29 00:59:04 +00005602 // Special case: check for comparisons against literals that can be exactly
5603 // represented by APFloat. In such cases, do not emit a warning. This
5604 // is a heuristic: often comparison against such literals are used to
5605 // detect if a value in a variable has not changed. This clearly can
5606 // lead to false negatives.
David Blaikie1f4ff152012-07-16 20:47:22 +00005607 if (FloatingLiteral* FLL = dyn_cast<FloatingLiteral>(LeftExprSansParen)) {
5608 if (FLL->isExact())
5609 return;
5610 } else
5611 if (FloatingLiteral* FLR = dyn_cast<FloatingLiteral>(RightExprSansParen))
5612 if (FLR->isExact())
5613 return;
Mike Stump11289f42009-09-09 15:08:12 +00005614
Ted Kremenek43fb8b02007-11-25 00:58:00 +00005615 // Check for comparisons with builtin types.
David Blaikie1f4ff152012-07-16 20:47:22 +00005616 if (CallExpr* CL = dyn_cast<CallExpr>(LeftExprSansParen))
Alp Tokera724cff2013-12-28 21:59:02 +00005617 if (CL->getBuiltinCallee())
David Blaikie1f4ff152012-07-16 20:47:22 +00005618 return;
Mike Stump11289f42009-09-09 15:08:12 +00005619
David Blaikie1f4ff152012-07-16 20:47:22 +00005620 if (CallExpr* CR = dyn_cast<CallExpr>(RightExprSansParen))
Alp Tokera724cff2013-12-28 21:59:02 +00005621 if (CR->getBuiltinCallee())
David Blaikie1f4ff152012-07-16 20:47:22 +00005622 return;
Mike Stump11289f42009-09-09 15:08:12 +00005623
Ted Kremenek43fb8b02007-11-25 00:58:00 +00005624 // Emit the diagnostic.
David Blaikie1f4ff152012-07-16 20:47:22 +00005625 Diag(Loc, diag::warn_floatingpoint_eq)
5626 << LHS->getSourceRange() << RHS->getSourceRange();
Ted Kremenek43fb8b02007-11-25 00:58:00 +00005627}
John McCallca01b222010-01-04 23:21:16 +00005628
John McCall70aa5392010-01-06 05:24:50 +00005629//===--- CHECK: Integer mixed-sign comparisons (-Wsign-compare) --------===//
5630//===--- CHECK: Lossy implicit conversions (-Wconversion) --------------===//
John McCallca01b222010-01-04 23:21:16 +00005631
John McCall70aa5392010-01-06 05:24:50 +00005632namespace {
John McCallca01b222010-01-04 23:21:16 +00005633
John McCall70aa5392010-01-06 05:24:50 +00005634/// Structure recording the 'active' range of an integer-valued
5635/// expression.
5636struct IntRange {
5637 /// The number of bits active in the int.
5638 unsigned Width;
John McCallca01b222010-01-04 23:21:16 +00005639
John McCall70aa5392010-01-06 05:24:50 +00005640 /// True if the int is known not to have negative values.
5641 bool NonNegative;
John McCallca01b222010-01-04 23:21:16 +00005642
John McCall70aa5392010-01-06 05:24:50 +00005643 IntRange(unsigned Width, bool NonNegative)
5644 : Width(Width), NonNegative(NonNegative)
5645 {}
John McCallca01b222010-01-04 23:21:16 +00005646
John McCall817d4af2010-11-10 23:38:19 +00005647 /// Returns the range of the bool type.
John McCall70aa5392010-01-06 05:24:50 +00005648 static IntRange forBoolType() {
5649 return IntRange(1, true);
John McCall263a48b2010-01-04 23:31:57 +00005650 }
5651
John McCall817d4af2010-11-10 23:38:19 +00005652 /// Returns the range of an opaque value of the given integral type.
5653 static IntRange forValueOfType(ASTContext &C, QualType T) {
5654 return forValueOfCanonicalType(C,
5655 T->getCanonicalTypeInternal().getTypePtr());
John McCall263a48b2010-01-04 23:31:57 +00005656 }
5657
John McCall817d4af2010-11-10 23:38:19 +00005658 /// Returns the range of an opaque value of a canonical integral type.
5659 static IntRange forValueOfCanonicalType(ASTContext &C, const Type *T) {
John McCall70aa5392010-01-06 05:24:50 +00005660 assert(T->isCanonicalUnqualified());
5661
5662 if (const VectorType *VT = dyn_cast<VectorType>(T))
5663 T = VT->getElementType().getTypePtr();
5664 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
5665 T = CT->getElementType().getTypePtr();
Justin Bogner4f42fc42014-07-21 18:01:53 +00005666 if (const AtomicType *AT = dyn_cast<AtomicType>(T))
5667 T = AT->getValueType().getTypePtr();
John McCallcc7e5bf2010-05-06 08:58:33 +00005668
David Majnemer6a426652013-06-07 22:07:20 +00005669 // For enum types, use the known bit width of the enumerators.
John McCallcc7e5bf2010-05-06 08:58:33 +00005670 if (const EnumType *ET = dyn_cast<EnumType>(T)) {
David Majnemer6a426652013-06-07 22:07:20 +00005671 EnumDecl *Enum = ET->getDecl();
5672 if (!Enum->isCompleteDefinition())
5673 return IntRange(C.getIntWidth(QualType(T, 0)), false);
John McCall18a2c2c2010-11-09 22:22:12 +00005674
David Majnemer6a426652013-06-07 22:07:20 +00005675 unsigned NumPositive = Enum->getNumPositiveBits();
5676 unsigned NumNegative = Enum->getNumNegativeBits();
John McCallcc7e5bf2010-05-06 08:58:33 +00005677
David Majnemer6a426652013-06-07 22:07:20 +00005678 if (NumNegative == 0)
5679 return IntRange(NumPositive, true/*NonNegative*/);
5680 else
5681 return IntRange(std::max(NumPositive + 1, NumNegative),
5682 false/*NonNegative*/);
John McCallcc7e5bf2010-05-06 08:58:33 +00005683 }
John McCall70aa5392010-01-06 05:24:50 +00005684
5685 const BuiltinType *BT = cast<BuiltinType>(T);
5686 assert(BT->isInteger());
5687
5688 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
5689 }
5690
John McCall817d4af2010-11-10 23:38:19 +00005691 /// Returns the "target" range of a canonical integral type, i.e.
5692 /// the range of values expressible in the type.
5693 ///
5694 /// This matches forValueOfCanonicalType except that enums have the
5695 /// full range of their type, not the range of their enumerators.
5696 static IntRange forTargetOfCanonicalType(ASTContext &C, const Type *T) {
5697 assert(T->isCanonicalUnqualified());
5698
5699 if (const VectorType *VT = dyn_cast<VectorType>(T))
5700 T = VT->getElementType().getTypePtr();
5701 if (const ComplexType *CT = dyn_cast<ComplexType>(T))
5702 T = CT->getElementType().getTypePtr();
Justin Bogner4f42fc42014-07-21 18:01:53 +00005703 if (const AtomicType *AT = dyn_cast<AtomicType>(T))
5704 T = AT->getValueType().getTypePtr();
John McCall817d4af2010-11-10 23:38:19 +00005705 if (const EnumType *ET = dyn_cast<EnumType>(T))
Douglas Gregor3168dcf2011-09-08 23:29:05 +00005706 T = C.getCanonicalType(ET->getDecl()->getIntegerType()).getTypePtr();
John McCall817d4af2010-11-10 23:38:19 +00005707
5708 const BuiltinType *BT = cast<BuiltinType>(T);
5709 assert(BT->isInteger());
5710
5711 return IntRange(C.getIntWidth(QualType(T, 0)), BT->isUnsignedInteger());
5712 }
5713
5714 /// Returns the supremum of two ranges: i.e. their conservative merge.
John McCallff96ccd2010-02-23 19:22:29 +00005715 static IntRange join(IntRange L, IntRange R) {
John McCall70aa5392010-01-06 05:24:50 +00005716 return IntRange(std::max(L.Width, R.Width),
John McCall2ce81ad2010-01-06 22:07:33 +00005717 L.NonNegative && R.NonNegative);
5718 }
5719
John McCall817d4af2010-11-10 23:38:19 +00005720 /// Returns the infinum of two ranges: i.e. their aggressive merge.
John McCallff96ccd2010-02-23 19:22:29 +00005721 static IntRange meet(IntRange L, IntRange R) {
John McCall2ce81ad2010-01-06 22:07:33 +00005722 return IntRange(std::min(L.Width, R.Width),
5723 L.NonNegative || R.NonNegative);
John McCall70aa5392010-01-06 05:24:50 +00005724 }
5725};
5726
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00005727static IntRange GetValueRange(ASTContext &C, llvm::APSInt &value,
5728 unsigned MaxWidth) {
John McCall70aa5392010-01-06 05:24:50 +00005729 if (value.isSigned() && value.isNegative())
5730 return IntRange(value.getMinSignedBits(), false);
5731
5732 if (value.getBitWidth() > MaxWidth)
Jay Foad6d4db0c2010-12-07 08:25:34 +00005733 value = value.trunc(MaxWidth);
John McCall70aa5392010-01-06 05:24:50 +00005734
5735 // isNonNegative() just checks the sign bit without considering
5736 // signedness.
5737 return IntRange(value.getActiveBits(), true);
5738}
5739
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00005740static IntRange GetValueRange(ASTContext &C, APValue &result, QualType Ty,
5741 unsigned MaxWidth) {
John McCall70aa5392010-01-06 05:24:50 +00005742 if (result.isInt())
5743 return GetValueRange(C, result.getInt(), MaxWidth);
5744
5745 if (result.isVector()) {
John McCall74430522010-01-06 22:57:21 +00005746 IntRange R = GetValueRange(C, result.getVectorElt(0), Ty, MaxWidth);
5747 for (unsigned i = 1, e = result.getVectorLength(); i != e; ++i) {
5748 IntRange El = GetValueRange(C, result.getVectorElt(i), Ty, MaxWidth);
5749 R = IntRange::join(R, El);
5750 }
John McCall70aa5392010-01-06 05:24:50 +00005751 return R;
5752 }
5753
5754 if (result.isComplexInt()) {
5755 IntRange R = GetValueRange(C, result.getComplexIntReal(), MaxWidth);
5756 IntRange I = GetValueRange(C, result.getComplexIntImag(), MaxWidth);
5757 return IntRange::join(R, I);
John McCall263a48b2010-01-04 23:31:57 +00005758 }
5759
5760 // This can happen with lossless casts to intptr_t of "based" lvalues.
5761 // Assume it might use arbitrary bits.
John McCall74430522010-01-06 22:57:21 +00005762 // FIXME: The only reason we need to pass the type in here is to get
5763 // the sign right on this one case. It would be nice if APValue
5764 // preserved this.
Eli Friedmanfd5e54d2012-01-04 23:13:47 +00005765 assert(result.isLValue() || result.isAddrLabelDiff());
Douglas Gregor61b6e492011-05-21 16:28:01 +00005766 return IntRange(MaxWidth, Ty->isUnsignedIntegerOrEnumerationType());
John McCall263a48b2010-01-04 23:31:57 +00005767}
John McCall70aa5392010-01-06 05:24:50 +00005768
Eli Friedmane6d33952013-07-08 20:20:06 +00005769static QualType GetExprType(Expr *E) {
5770 QualType Ty = E->getType();
5771 if (const AtomicType *AtomicRHS = Ty->getAs<AtomicType>())
5772 Ty = AtomicRHS->getValueType();
5773 return Ty;
5774}
5775
John McCall70aa5392010-01-06 05:24:50 +00005776/// Pseudo-evaluate the given integer expression, estimating the
5777/// range of values it might take.
5778///
5779/// \param MaxWidth - the width to which the value will be truncated
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00005780static IntRange GetExprRange(ASTContext &C, Expr *E, unsigned MaxWidth) {
John McCall70aa5392010-01-06 05:24:50 +00005781 E = E->IgnoreParens();
5782
5783 // Try a full evaluation first.
5784 Expr::EvalResult result;
Richard Smith7b553f12011-10-29 00:50:52 +00005785 if (E->EvaluateAsRValue(result, C))
Eli Friedmane6d33952013-07-08 20:20:06 +00005786 return GetValueRange(C, result.Val, GetExprType(E), MaxWidth);
John McCall70aa5392010-01-06 05:24:50 +00005787
5788 // I think we only want to look through implicit casts here; if the
5789 // user has an explicit widening cast, we should treat the value as
5790 // being of the new, wider type.
5791 if (ImplicitCastExpr *CE = dyn_cast<ImplicitCastExpr>(E)) {
Eli Friedman8349dc12011-12-15 02:41:52 +00005792 if (CE->getCastKind() == CK_NoOp || CE->getCastKind() == CK_LValueToRValue)
John McCall70aa5392010-01-06 05:24:50 +00005793 return GetExprRange(C, CE->getSubExpr(), MaxWidth);
5794
Eli Friedmane6d33952013-07-08 20:20:06 +00005795 IntRange OutputTypeRange = IntRange::forValueOfType(C, GetExprType(CE));
John McCall70aa5392010-01-06 05:24:50 +00005796
John McCalle3027922010-08-25 11:45:40 +00005797 bool isIntegerCast = (CE->getCastKind() == CK_IntegralCast);
John McCall2ce81ad2010-01-06 22:07:33 +00005798
John McCall70aa5392010-01-06 05:24:50 +00005799 // Assume that non-integer casts can span the full range of the type.
John McCall2ce81ad2010-01-06 22:07:33 +00005800 if (!isIntegerCast)
John McCall70aa5392010-01-06 05:24:50 +00005801 return OutputTypeRange;
5802
5803 IntRange SubRange
5804 = GetExprRange(C, CE->getSubExpr(),
5805 std::min(MaxWidth, OutputTypeRange.Width));
5806
5807 // Bail out if the subexpr's range is as wide as the cast type.
5808 if (SubRange.Width >= OutputTypeRange.Width)
5809 return OutputTypeRange;
5810
5811 // Otherwise, we take the smaller width, and we're non-negative if
5812 // either the output type or the subexpr is.
5813 return IntRange(SubRange.Width,
5814 SubRange.NonNegative || OutputTypeRange.NonNegative);
5815 }
5816
5817 if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
5818 // If we can fold the condition, just take that operand.
5819 bool CondResult;
5820 if (CO->getCond()->EvaluateAsBooleanCondition(CondResult, C))
5821 return GetExprRange(C, CondResult ? CO->getTrueExpr()
5822 : CO->getFalseExpr(),
5823 MaxWidth);
5824
5825 // Otherwise, conservatively merge.
5826 IntRange L = GetExprRange(C, CO->getTrueExpr(), MaxWidth);
5827 IntRange R = GetExprRange(C, CO->getFalseExpr(), MaxWidth);
5828 return IntRange::join(L, R);
5829 }
5830
5831 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
5832 switch (BO->getOpcode()) {
5833
5834 // Boolean-valued operations are single-bit and positive.
John McCalle3027922010-08-25 11:45:40 +00005835 case BO_LAnd:
5836 case BO_LOr:
5837 case BO_LT:
5838 case BO_GT:
5839 case BO_LE:
5840 case BO_GE:
5841 case BO_EQ:
5842 case BO_NE:
John McCall70aa5392010-01-06 05:24:50 +00005843 return IntRange::forBoolType();
5844
John McCallc3688382011-07-13 06:35:24 +00005845 // The type of the assignments is the type of the LHS, so the RHS
5846 // is not necessarily the same type.
John McCalle3027922010-08-25 11:45:40 +00005847 case BO_MulAssign:
5848 case BO_DivAssign:
5849 case BO_RemAssign:
5850 case BO_AddAssign:
5851 case BO_SubAssign:
John McCallc3688382011-07-13 06:35:24 +00005852 case BO_XorAssign:
5853 case BO_OrAssign:
5854 // TODO: bitfields?
Eli Friedmane6d33952013-07-08 20:20:06 +00005855 return IntRange::forValueOfType(C, GetExprType(E));
John McCallff96ccd2010-02-23 19:22:29 +00005856
John McCallc3688382011-07-13 06:35:24 +00005857 // Simple assignments just pass through the RHS, which will have
5858 // been coerced to the LHS type.
5859 case BO_Assign:
5860 // TODO: bitfields?
5861 return GetExprRange(C, BO->getRHS(), MaxWidth);
5862
John McCall70aa5392010-01-06 05:24:50 +00005863 // Operations with opaque sources are black-listed.
John McCalle3027922010-08-25 11:45:40 +00005864 case BO_PtrMemD:
5865 case BO_PtrMemI:
Eli Friedmane6d33952013-07-08 20:20:06 +00005866 return IntRange::forValueOfType(C, GetExprType(E));
John McCall70aa5392010-01-06 05:24:50 +00005867
John McCall2ce81ad2010-01-06 22:07:33 +00005868 // Bitwise-and uses the *infinum* of the two source ranges.
John McCalle3027922010-08-25 11:45:40 +00005869 case BO_And:
5870 case BO_AndAssign:
John McCall2ce81ad2010-01-06 22:07:33 +00005871 return IntRange::meet(GetExprRange(C, BO->getLHS(), MaxWidth),
5872 GetExprRange(C, BO->getRHS(), MaxWidth));
5873
John McCall70aa5392010-01-06 05:24:50 +00005874 // Left shift gets black-listed based on a judgement call.
John McCalle3027922010-08-25 11:45:40 +00005875 case BO_Shl:
John McCall1bff9932010-04-07 01:14:35 +00005876 // ...except that we want to treat '1 << (blah)' as logically
5877 // positive. It's an important idiom.
5878 if (IntegerLiteral *I
5879 = dyn_cast<IntegerLiteral>(BO->getLHS()->IgnoreParenCasts())) {
5880 if (I->getValue() == 1) {
Eli Friedmane6d33952013-07-08 20:20:06 +00005881 IntRange R = IntRange::forValueOfType(C, GetExprType(E));
John McCall1bff9932010-04-07 01:14:35 +00005882 return IntRange(R.Width, /*NonNegative*/ true);
5883 }
5884 }
5885 // fallthrough
5886
John McCalle3027922010-08-25 11:45:40 +00005887 case BO_ShlAssign:
Eli Friedmane6d33952013-07-08 20:20:06 +00005888 return IntRange::forValueOfType(C, GetExprType(E));
John McCall70aa5392010-01-06 05:24:50 +00005889
John McCall2ce81ad2010-01-06 22:07:33 +00005890 // Right shift by a constant can narrow its left argument.
John McCalle3027922010-08-25 11:45:40 +00005891 case BO_Shr:
5892 case BO_ShrAssign: {
John McCall2ce81ad2010-01-06 22:07:33 +00005893 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
5894
5895 // If the shift amount is a positive constant, drop the width by
5896 // that much.
5897 llvm::APSInt shift;
5898 if (BO->getRHS()->isIntegerConstantExpr(shift, C) &&
5899 shift.isNonNegative()) {
5900 unsigned zext = shift.getZExtValue();
5901 if (zext >= L.Width)
5902 L.Width = (L.NonNegative ? 0 : 1);
5903 else
5904 L.Width -= zext;
5905 }
5906
5907 return L;
5908 }
5909
5910 // Comma acts as its right operand.
John McCalle3027922010-08-25 11:45:40 +00005911 case BO_Comma:
John McCall70aa5392010-01-06 05:24:50 +00005912 return GetExprRange(C, BO->getRHS(), MaxWidth);
5913
John McCall2ce81ad2010-01-06 22:07:33 +00005914 // Black-list pointer subtractions.
John McCalle3027922010-08-25 11:45:40 +00005915 case BO_Sub:
John McCall70aa5392010-01-06 05:24:50 +00005916 if (BO->getLHS()->getType()->isPointerType())
Eli Friedmane6d33952013-07-08 20:20:06 +00005917 return IntRange::forValueOfType(C, GetExprType(E));
John McCall51431812011-07-14 22:39:48 +00005918 break;
Ted Kremenekc8b188d2010-02-16 01:46:59 +00005919
John McCall51431812011-07-14 22:39:48 +00005920 // The width of a division result is mostly determined by the size
5921 // of the LHS.
5922 case BO_Div: {
5923 // Don't 'pre-truncate' the operands.
Eli Friedmane6d33952013-07-08 20:20:06 +00005924 unsigned opWidth = C.getIntWidth(GetExprType(E));
John McCall51431812011-07-14 22:39:48 +00005925 IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
5926
5927 // If the divisor is constant, use that.
5928 llvm::APSInt divisor;
5929 if (BO->getRHS()->isIntegerConstantExpr(divisor, C)) {
5930 unsigned log2 = divisor.logBase2(); // floor(log_2(divisor))
5931 if (log2 >= L.Width)
5932 L.Width = (L.NonNegative ? 0 : 1);
5933 else
5934 L.Width = std::min(L.Width - log2, MaxWidth);
5935 return L;
5936 }
5937
5938 // Otherwise, just use the LHS's width.
5939 IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
5940 return IntRange(L.Width, L.NonNegative && R.NonNegative);
5941 }
5942
5943 // The result of a remainder can't be larger than the result of
5944 // either side.
5945 case BO_Rem: {
5946 // Don't 'pre-truncate' the operands.
Eli Friedmane6d33952013-07-08 20:20:06 +00005947 unsigned opWidth = C.getIntWidth(GetExprType(E));
John McCall51431812011-07-14 22:39:48 +00005948 IntRange L = GetExprRange(C, BO->getLHS(), opWidth);
5949 IntRange R = GetExprRange(C, BO->getRHS(), opWidth);
5950
5951 IntRange meet = IntRange::meet(L, R);
5952 meet.Width = std::min(meet.Width, MaxWidth);
5953 return meet;
5954 }
5955
5956 // The default behavior is okay for these.
5957 case BO_Mul:
5958 case BO_Add:
5959 case BO_Xor:
5960 case BO_Or:
John McCall70aa5392010-01-06 05:24:50 +00005961 break;
5962 }
5963
John McCall51431812011-07-14 22:39:48 +00005964 // The default case is to treat the operation as if it were closed
5965 // on the narrowest type that encompasses both operands.
John McCall70aa5392010-01-06 05:24:50 +00005966 IntRange L = GetExprRange(C, BO->getLHS(), MaxWidth);
5967 IntRange R = GetExprRange(C, BO->getRHS(), MaxWidth);
5968 return IntRange::join(L, R);
5969 }
5970
5971 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
5972 switch (UO->getOpcode()) {
5973 // Boolean-valued operations are white-listed.
John McCalle3027922010-08-25 11:45:40 +00005974 case UO_LNot:
John McCall70aa5392010-01-06 05:24:50 +00005975 return IntRange::forBoolType();
5976
5977 // Operations with opaque sources are black-listed.
John McCalle3027922010-08-25 11:45:40 +00005978 case UO_Deref:
5979 case UO_AddrOf: // should be impossible
Eli Friedmane6d33952013-07-08 20:20:06 +00005980 return IntRange::forValueOfType(C, GetExprType(E));
John McCall70aa5392010-01-06 05:24:50 +00005981
5982 default:
5983 return GetExprRange(C, UO->getSubExpr(), MaxWidth);
5984 }
5985 }
5986
Ted Kremeneka553fbf2013-10-14 18:55:27 +00005987 if (OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(E))
5988 return GetExprRange(C, OVE->getSourceExpr(), MaxWidth);
5989
John McCalld25db7e2013-05-06 21:39:12 +00005990 if (FieldDecl *BitField = E->getSourceBitField())
Richard Smithcaf33902011-10-10 18:28:20 +00005991 return IntRange(BitField->getBitWidthValue(C),
Douglas Gregor61b6e492011-05-21 16:28:01 +00005992 BitField->getType()->isUnsignedIntegerOrEnumerationType());
John McCall70aa5392010-01-06 05:24:50 +00005993
Eli Friedmane6d33952013-07-08 20:20:06 +00005994 return IntRange::forValueOfType(C, GetExprType(E));
John McCall70aa5392010-01-06 05:24:50 +00005995}
John McCall263a48b2010-01-04 23:31:57 +00005996
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00005997static IntRange GetExprRange(ASTContext &C, Expr *E) {
Eli Friedmane6d33952013-07-08 20:20:06 +00005998 return GetExprRange(C, E, C.getIntWidth(GetExprType(E)));
John McCallcc7e5bf2010-05-06 08:58:33 +00005999}
6000
John McCall263a48b2010-01-04 23:31:57 +00006001/// Checks whether the given value, which currently has the given
6002/// source semantics, has the same value when coerced through the
6003/// target semantics.
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00006004static bool IsSameFloatAfterCast(const llvm::APFloat &value,
6005 const llvm::fltSemantics &Src,
6006 const llvm::fltSemantics &Tgt) {
John McCall263a48b2010-01-04 23:31:57 +00006007 llvm::APFloat truncated = value;
6008
6009 bool ignored;
6010 truncated.convert(Src, llvm::APFloat::rmNearestTiesToEven, &ignored);
6011 truncated.convert(Tgt, llvm::APFloat::rmNearestTiesToEven, &ignored);
6012
6013 return truncated.bitwiseIsEqual(value);
6014}
6015
6016/// Checks whether the given value, which currently has the given
6017/// source semantics, has the same value when coerced through the
6018/// target semantics.
6019///
6020/// The value might be a vector of floats (or a complex number).
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00006021static bool IsSameFloatAfterCast(const APValue &value,
6022 const llvm::fltSemantics &Src,
6023 const llvm::fltSemantics &Tgt) {
John McCall263a48b2010-01-04 23:31:57 +00006024 if (value.isFloat())
6025 return IsSameFloatAfterCast(value.getFloat(), Src, Tgt);
6026
6027 if (value.isVector()) {
6028 for (unsigned i = 0, e = value.getVectorLength(); i != e; ++i)
6029 if (!IsSameFloatAfterCast(value.getVectorElt(i), Src, Tgt))
6030 return false;
6031 return true;
6032 }
6033
6034 assert(value.isComplexFloat());
6035 return (IsSameFloatAfterCast(value.getComplexFloatReal(), Src, Tgt) &&
6036 IsSameFloatAfterCast(value.getComplexFloatImag(), Src, Tgt));
6037}
6038
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00006039static void AnalyzeImplicitConversions(Sema &S, Expr *E, SourceLocation CC);
John McCallcc7e5bf2010-05-06 08:58:33 +00006040
Ted Kremenek6274be42010-09-23 21:43:44 +00006041static bool IsZero(Sema &S, Expr *E) {
6042 // Suppress cases where we are comparing against an enum constant.
6043 if (const DeclRefExpr *DR =
6044 dyn_cast<DeclRefExpr>(E->IgnoreParenImpCasts()))
6045 if (isa<EnumConstantDecl>(DR->getDecl()))
6046 return false;
6047
6048 // Suppress cases where the '0' value is expanded from a macro.
6049 if (E->getLocStart().isMacroID())
6050 return false;
6051
John McCallcc7e5bf2010-05-06 08:58:33 +00006052 llvm::APSInt Value;
6053 return E->isIntegerConstantExpr(Value, S.Context) && Value == 0;
6054}
6055
John McCall2551c1b2010-10-06 00:25:24 +00006056static bool HasEnumType(Expr *E) {
6057 // Strip off implicit integral promotions.
6058 while (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)) {
Argyrios Kyrtzidis15a9edc2010-10-07 21:52:18 +00006059 if (ICE->getCastKind() != CK_IntegralCast &&
6060 ICE->getCastKind() != CK_NoOp)
John McCall2551c1b2010-10-06 00:25:24 +00006061 break;
Argyrios Kyrtzidis15a9edc2010-10-07 21:52:18 +00006062 E = ICE->getSubExpr();
John McCall2551c1b2010-10-06 00:25:24 +00006063 }
6064
6065 return E->getType()->isEnumeralType();
6066}
6067
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00006068static void CheckTrivialUnsignedComparison(Sema &S, BinaryOperator *E) {
Richard Trieu36594562013-11-01 21:47:19 +00006069 // Disable warning in template instantiations.
6070 if (!S.ActiveTemplateInstantiations.empty())
6071 return;
6072
John McCalle3027922010-08-25 11:45:40 +00006073 BinaryOperatorKind op = E->getOpcode();
Douglas Gregorb14dbd72010-12-21 07:22:56 +00006074 if (E->isValueDependent())
6075 return;
6076
John McCalle3027922010-08-25 11:45:40 +00006077 if (op == BO_LT && IsZero(S, E->getRHS())) {
John McCallcc7e5bf2010-05-06 08:58:33 +00006078 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
John McCall2551c1b2010-10-06 00:25:24 +00006079 << "< 0" << "false" << HasEnumType(E->getLHS())
John McCallcc7e5bf2010-05-06 08:58:33 +00006080 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCalle3027922010-08-25 11:45:40 +00006081 } else if (op == BO_GE && IsZero(S, E->getRHS())) {
John McCallcc7e5bf2010-05-06 08:58:33 +00006082 S.Diag(E->getOperatorLoc(), diag::warn_lunsigned_always_true_comparison)
John McCall2551c1b2010-10-06 00:25:24 +00006083 << ">= 0" << "true" << HasEnumType(E->getLHS())
John McCallcc7e5bf2010-05-06 08:58:33 +00006084 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCalle3027922010-08-25 11:45:40 +00006085 } else if (op == BO_GT && IsZero(S, E->getLHS())) {
John McCallcc7e5bf2010-05-06 08:58:33 +00006086 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
John McCall2551c1b2010-10-06 00:25:24 +00006087 << "0 >" << "false" << HasEnumType(E->getRHS())
John McCallcc7e5bf2010-05-06 08:58:33 +00006088 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
John McCalle3027922010-08-25 11:45:40 +00006089 } else if (op == BO_LE && IsZero(S, E->getLHS())) {
John McCallcc7e5bf2010-05-06 08:58:33 +00006090 S.Diag(E->getOperatorLoc(), diag::warn_runsigned_always_true_comparison)
John McCall2551c1b2010-10-06 00:25:24 +00006091 << "0 <=" << "true" << HasEnumType(E->getRHS())
John McCallcc7e5bf2010-05-06 08:58:33 +00006092 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange();
6093 }
6094}
6095
Fariborz Jahanianb1885422012-09-18 17:37:21 +00006096static void DiagnoseOutOfRangeComparison(Sema &S, BinaryOperator *E,
Fariborz Jahanian2f4e33a2012-09-20 19:36:41 +00006097 Expr *Constant, Expr *Other,
Fariborz Jahanianb1885422012-09-18 17:37:21 +00006098 llvm::APSInt Value,
Fariborz Jahanian2f4e33a2012-09-20 19:36:41 +00006099 bool RhsConstant) {
Richard Trieudd51d742013-11-01 21:19:43 +00006100 // Disable warning in template instantiations.
6101 if (!S.ActiveTemplateInstantiations.empty())
6102 return;
6103
Richard Trieu0f097742014-04-04 04:13:47 +00006104 // TODO: Investigate using GetExprRange() to get tighter bounds
6105 // on the bit ranges.
6106 QualType OtherT = Other->getType();
David Majnemer7800f1f2015-05-23 01:32:17 +00006107 if (const auto *AT = OtherT->getAs<AtomicType>())
Justin Bogner4f42fc42014-07-21 18:01:53 +00006108 OtherT = AT->getValueType();
Richard Trieu0f097742014-04-04 04:13:47 +00006109 IntRange OtherRange = IntRange::forValueOfType(S.Context, OtherT);
6110 unsigned OtherWidth = OtherRange.Width;
6111
6112 bool OtherIsBooleanType = Other->isKnownToHaveBooleanValue();
6113
Richard Trieu560910c2012-11-14 22:50:24 +00006114 // 0 values are handled later by CheckTrivialUnsignedComparison().
Richard Trieu0f097742014-04-04 04:13:47 +00006115 if ((Value == 0) && (!OtherIsBooleanType))
Richard Trieu560910c2012-11-14 22:50:24 +00006116 return;
6117
Fariborz Jahanianb1885422012-09-18 17:37:21 +00006118 BinaryOperatorKind op = E->getOpcode();
Richard Trieu0f097742014-04-04 04:13:47 +00006119 bool IsTrue = true;
Richard Trieu560910c2012-11-14 22:50:24 +00006120
Richard Trieu0f097742014-04-04 04:13:47 +00006121 // Used for diagnostic printout.
6122 enum {
6123 LiteralConstant = 0,
6124 CXXBoolLiteralTrue,
6125 CXXBoolLiteralFalse
6126 } LiteralOrBoolConstant = LiteralConstant;
Richard Trieu560910c2012-11-14 22:50:24 +00006127
Richard Trieu0f097742014-04-04 04:13:47 +00006128 if (!OtherIsBooleanType) {
6129 QualType ConstantT = Constant->getType();
6130 QualType CommonT = E->getLHS()->getType();
Richard Trieu560910c2012-11-14 22:50:24 +00006131
Richard Trieu0f097742014-04-04 04:13:47 +00006132 if (S.Context.hasSameUnqualifiedType(OtherT, ConstantT))
6133 return;
6134 assert((OtherT->isIntegerType() && ConstantT->isIntegerType()) &&
6135 "comparison with non-integer type");
6136
6137 bool ConstantSigned = ConstantT->isSignedIntegerType();
6138 bool CommonSigned = CommonT->isSignedIntegerType();
6139
6140 bool EqualityOnly = false;
6141
6142 if (CommonSigned) {
6143 // The common type is signed, therefore no signed to unsigned conversion.
6144 if (!OtherRange.NonNegative) {
6145 // Check that the constant is representable in type OtherT.
6146 if (ConstantSigned) {
6147 if (OtherWidth >= Value.getMinSignedBits())
6148 return;
6149 } else { // !ConstantSigned
6150 if (OtherWidth >= Value.getActiveBits() + 1)
6151 return;
6152 }
6153 } else { // !OtherSigned
6154 // Check that the constant is representable in type OtherT.
6155 // Negative values are out of range.
6156 if (ConstantSigned) {
6157 if (Value.isNonNegative() && OtherWidth >= Value.getActiveBits())
6158 return;
6159 } else { // !ConstantSigned
6160 if (OtherWidth >= Value.getActiveBits())
6161 return;
6162 }
Richard Trieu560910c2012-11-14 22:50:24 +00006163 }
Richard Trieu0f097742014-04-04 04:13:47 +00006164 } else { // !CommonSigned
6165 if (OtherRange.NonNegative) {
Richard Trieu560910c2012-11-14 22:50:24 +00006166 if (OtherWidth >= Value.getActiveBits())
6167 return;
Craig Toppercf360162014-06-18 05:13:11 +00006168 } else { // OtherSigned
6169 assert(!ConstantSigned &&
6170 "Two signed types converted to unsigned types.");
Richard Trieu0f097742014-04-04 04:13:47 +00006171 // Check to see if the constant is representable in OtherT.
6172 if (OtherWidth > Value.getActiveBits())
6173 return;
6174 // Check to see if the constant is equivalent to a negative value
6175 // cast to CommonT.
6176 if (S.Context.getIntWidth(ConstantT) ==
6177 S.Context.getIntWidth(CommonT) &&
6178 Value.isNegative() && Value.getMinSignedBits() <= OtherWidth)
6179 return;
6180 // The constant value rests between values that OtherT can represent
6181 // after conversion. Relational comparison still works, but equality
6182 // comparisons will be tautological.
6183 EqualityOnly = true;
Richard Trieu560910c2012-11-14 22:50:24 +00006184 }
6185 }
Richard Trieu0f097742014-04-04 04:13:47 +00006186
6187 bool PositiveConstant = !ConstantSigned || Value.isNonNegative();
6188
6189 if (op == BO_EQ || op == BO_NE) {
6190 IsTrue = op == BO_NE;
6191 } else if (EqualityOnly) {
6192 return;
6193 } else if (RhsConstant) {
6194 if (op == BO_GT || op == BO_GE)
6195 IsTrue = !PositiveConstant;
6196 else // op == BO_LT || op == BO_LE
6197 IsTrue = PositiveConstant;
6198 } else {
6199 if (op == BO_LT || op == BO_LE)
6200 IsTrue = !PositiveConstant;
6201 else // op == BO_GT || op == BO_GE
6202 IsTrue = PositiveConstant;
Richard Trieu560910c2012-11-14 22:50:24 +00006203 }
Fariborz Jahanian2f4e33a2012-09-20 19:36:41 +00006204 } else {
Richard Trieu0f097742014-04-04 04:13:47 +00006205 // Other isKnownToHaveBooleanValue
6206 enum CompareBoolWithConstantResult { AFals, ATrue, Unkwn };
6207 enum ConstantValue { LT_Zero, Zero, One, GT_One, SizeOfConstVal };
6208 enum ConstantSide { Lhs, Rhs, SizeOfConstSides };
6209
6210 static const struct LinkedConditions {
6211 CompareBoolWithConstantResult BO_LT_OP[SizeOfConstSides][SizeOfConstVal];
6212 CompareBoolWithConstantResult BO_GT_OP[SizeOfConstSides][SizeOfConstVal];
6213 CompareBoolWithConstantResult BO_LE_OP[SizeOfConstSides][SizeOfConstVal];
6214 CompareBoolWithConstantResult BO_GE_OP[SizeOfConstSides][SizeOfConstVal];
6215 CompareBoolWithConstantResult BO_EQ_OP[SizeOfConstSides][SizeOfConstVal];
6216 CompareBoolWithConstantResult BO_NE_OP[SizeOfConstSides][SizeOfConstVal];
6217
6218 } TruthTable = {
6219 // Constant on LHS. | Constant on RHS. |
6220 // LT_Zero| Zero | One |GT_One| LT_Zero| Zero | One |GT_One|
6221 { { ATrue, Unkwn, AFals, AFals }, { AFals, AFals, Unkwn, ATrue } },
6222 { { AFals, AFals, Unkwn, ATrue }, { ATrue, Unkwn, AFals, AFals } },
6223 { { ATrue, ATrue, Unkwn, AFals }, { AFals, Unkwn, ATrue, ATrue } },
6224 { { AFals, Unkwn, ATrue, ATrue }, { ATrue, ATrue, Unkwn, AFals } },
6225 { { AFals, Unkwn, Unkwn, AFals }, { AFals, Unkwn, Unkwn, AFals } },
6226 { { ATrue, Unkwn, Unkwn, ATrue }, { ATrue, Unkwn, Unkwn, ATrue } }
6227 };
6228
6229 bool ConstantIsBoolLiteral = isa<CXXBoolLiteralExpr>(Constant);
6230
6231 enum ConstantValue ConstVal = Zero;
6232 if (Value.isUnsigned() || Value.isNonNegative()) {
6233 if (Value == 0) {
6234 LiteralOrBoolConstant =
6235 ConstantIsBoolLiteral ? CXXBoolLiteralFalse : LiteralConstant;
6236 ConstVal = Zero;
6237 } else if (Value == 1) {
6238 LiteralOrBoolConstant =
6239 ConstantIsBoolLiteral ? CXXBoolLiteralTrue : LiteralConstant;
6240 ConstVal = One;
6241 } else {
6242 LiteralOrBoolConstant = LiteralConstant;
6243 ConstVal = GT_One;
6244 }
6245 } else {
6246 ConstVal = LT_Zero;
6247 }
6248
6249 CompareBoolWithConstantResult CmpRes;
6250
6251 switch (op) {
6252 case BO_LT:
6253 CmpRes = TruthTable.BO_LT_OP[RhsConstant][ConstVal];
6254 break;
6255 case BO_GT:
6256 CmpRes = TruthTable.BO_GT_OP[RhsConstant][ConstVal];
6257 break;
6258 case BO_LE:
6259 CmpRes = TruthTable.BO_LE_OP[RhsConstant][ConstVal];
6260 break;
6261 case BO_GE:
6262 CmpRes = TruthTable.BO_GE_OP[RhsConstant][ConstVal];
6263 break;
6264 case BO_EQ:
6265 CmpRes = TruthTable.BO_EQ_OP[RhsConstant][ConstVal];
6266 break;
6267 case BO_NE:
6268 CmpRes = TruthTable.BO_NE_OP[RhsConstant][ConstVal];
6269 break;
6270 default:
6271 CmpRes = Unkwn;
6272 break;
6273 }
6274
6275 if (CmpRes == AFals) {
6276 IsTrue = false;
6277 } else if (CmpRes == ATrue) {
6278 IsTrue = true;
6279 } else {
6280 return;
6281 }
Fariborz Jahanianb1885422012-09-18 17:37:21 +00006282 }
Ted Kremenekb7d7dd42013-03-15 21:50:10 +00006283
6284 // If this is a comparison to an enum constant, include that
6285 // constant in the diagnostic.
Craig Topperc3ec1492014-05-26 06:22:03 +00006286 const EnumConstantDecl *ED = nullptr;
Ted Kremenekb7d7dd42013-03-15 21:50:10 +00006287 if (const DeclRefExpr *DR = dyn_cast<DeclRefExpr>(Constant))
6288 ED = dyn_cast<EnumConstantDecl>(DR->getDecl());
6289
6290 SmallString<64> PrettySourceValue;
6291 llvm::raw_svector_ostream OS(PrettySourceValue);
6292 if (ED)
Ted Kremeneke943ce12013-03-15 22:02:46 +00006293 OS << '\'' << *ED << "' (" << Value << ")";
Ted Kremenekb7d7dd42013-03-15 21:50:10 +00006294 else
6295 OS << Value;
6296
Richard Trieu0f097742014-04-04 04:13:47 +00006297 S.DiagRuntimeBehavior(
6298 E->getOperatorLoc(), E,
6299 S.PDiag(diag::warn_out_of_range_compare)
6300 << OS.str() << LiteralOrBoolConstant
6301 << OtherT << (OtherIsBooleanType && !OtherT->isBooleanType()) << IsTrue
6302 << E->getLHS()->getSourceRange() << E->getRHS()->getSourceRange());
Fariborz Jahanianb1885422012-09-18 17:37:21 +00006303}
6304
John McCallcc7e5bf2010-05-06 08:58:33 +00006305/// Analyze the operands of the given comparison. Implements the
6306/// fallback case from AnalyzeComparison.
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00006307static void AnalyzeImpConvsInComparison(Sema &S, BinaryOperator *E) {
John McCallacf0ee52010-10-08 02:01:28 +00006308 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
6309 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
John McCallcc7e5bf2010-05-06 08:58:33 +00006310}
John McCall263a48b2010-01-04 23:31:57 +00006311
John McCallca01b222010-01-04 23:21:16 +00006312/// \brief Implements -Wsign-compare.
6313///
Richard Trieu82402a02011-09-15 21:56:47 +00006314/// \param E the binary operator to check for warnings
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00006315static void AnalyzeComparison(Sema &S, BinaryOperator *E) {
John McCallcc7e5bf2010-05-06 08:58:33 +00006316 // The type the comparison is being performed in.
6317 QualType T = E->getLHS()->getType();
Chandler Carruthb29a7432014-10-11 11:03:30 +00006318
6319 // Only analyze comparison operators where both sides have been converted to
6320 // the same type.
6321 if (!S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()))
6322 return AnalyzeImpConvsInComparison(S, E);
6323
6324 // Don't analyze value-dependent comparisons directly.
Fariborz Jahanian282071e2012-09-18 17:46:26 +00006325 if (E->isValueDependent())
6326 return AnalyzeImpConvsInComparison(S, E);
John McCallca01b222010-01-04 23:21:16 +00006327
Fariborz Jahanianb1885422012-09-18 17:37:21 +00006328 Expr *LHS = E->getLHS()->IgnoreParenImpCasts();
6329 Expr *RHS = E->getRHS()->IgnoreParenImpCasts();
Fariborz Jahanianb1885422012-09-18 17:37:21 +00006330
6331 bool IsComparisonConstant = false;
6332
Fariborz Jahanian2f4e33a2012-09-20 19:36:41 +00006333 // Check whether an integer constant comparison results in a value
Fariborz Jahanianb1885422012-09-18 17:37:21 +00006334 // of 'true' or 'false'.
6335 if (T->isIntegralType(S.Context)) {
6336 llvm::APSInt RHSValue;
6337 bool IsRHSIntegralLiteral =
6338 RHS->isIntegerConstantExpr(RHSValue, S.Context);
6339 llvm::APSInt LHSValue;
6340 bool IsLHSIntegralLiteral =
6341 LHS->isIntegerConstantExpr(LHSValue, S.Context);
6342 if (IsRHSIntegralLiteral && !IsLHSIntegralLiteral)
6343 DiagnoseOutOfRangeComparison(S, E, RHS, LHS, RHSValue, true);
6344 else if (!IsRHSIntegralLiteral && IsLHSIntegralLiteral)
6345 DiagnoseOutOfRangeComparison(S, E, LHS, RHS, LHSValue, false);
6346 else
6347 IsComparisonConstant =
6348 (IsRHSIntegralLiteral && IsLHSIntegralLiteral);
Fariborz Jahanian2f4e33a2012-09-20 19:36:41 +00006349 } else if (!T->hasUnsignedIntegerRepresentation())
6350 IsComparisonConstant = E->isIntegerConstantExpr(S.Context);
Fariborz Jahanianb1885422012-09-18 17:37:21 +00006351
John McCallcc7e5bf2010-05-06 08:58:33 +00006352 // We don't do anything special if this isn't an unsigned integral
6353 // comparison: we're only interested in integral comparisons, and
6354 // signed comparisons only happen in cases we don't care to warn about.
Douglas Gregor5b054542011-02-19 22:34:59 +00006355 //
6356 // We also don't care about value-dependent expressions or expressions
6357 // whose result is a constant.
Fariborz Jahanianb1885422012-09-18 17:37:21 +00006358 if (!T->hasUnsignedIntegerRepresentation() || IsComparisonConstant)
John McCallcc7e5bf2010-05-06 08:58:33 +00006359 return AnalyzeImpConvsInComparison(S, E);
Fariborz Jahanianb1885422012-09-18 17:37:21 +00006360
John McCallcc7e5bf2010-05-06 08:58:33 +00006361 // Check to see if one of the (unmodified) operands is of different
6362 // signedness.
6363 Expr *signedOperand, *unsignedOperand;
Richard Trieu82402a02011-09-15 21:56:47 +00006364 if (LHS->getType()->hasSignedIntegerRepresentation()) {
6365 assert(!RHS->getType()->hasSignedIntegerRepresentation() &&
John McCallcc7e5bf2010-05-06 08:58:33 +00006366 "unsigned comparison between two signed integer expressions?");
Richard Trieu82402a02011-09-15 21:56:47 +00006367 signedOperand = LHS;
6368 unsignedOperand = RHS;
6369 } else if (RHS->getType()->hasSignedIntegerRepresentation()) {
6370 signedOperand = RHS;
6371 unsignedOperand = LHS;
John McCallca01b222010-01-04 23:21:16 +00006372 } else {
John McCallcc7e5bf2010-05-06 08:58:33 +00006373 CheckTrivialUnsignedComparison(S, E);
6374 return AnalyzeImpConvsInComparison(S, E);
John McCallca01b222010-01-04 23:21:16 +00006375 }
6376
John McCallcc7e5bf2010-05-06 08:58:33 +00006377 // Otherwise, calculate the effective range of the signed operand.
6378 IntRange signedRange = GetExprRange(S.Context, signedOperand);
John McCall70aa5392010-01-06 05:24:50 +00006379
John McCallcc7e5bf2010-05-06 08:58:33 +00006380 // Go ahead and analyze implicit conversions in the operands. Note
6381 // that we skip the implicit conversions on both sides.
Richard Trieu82402a02011-09-15 21:56:47 +00006382 AnalyzeImplicitConversions(S, LHS, E->getOperatorLoc());
6383 AnalyzeImplicitConversions(S, RHS, E->getOperatorLoc());
John McCallca01b222010-01-04 23:21:16 +00006384
John McCallcc7e5bf2010-05-06 08:58:33 +00006385 // If the signed range is non-negative, -Wsign-compare won't fire,
6386 // but we should still check for comparisons which are always true
6387 // or false.
6388 if (signedRange.NonNegative)
6389 return CheckTrivialUnsignedComparison(S, E);
John McCallca01b222010-01-04 23:21:16 +00006390
6391 // For (in)equality comparisons, if the unsigned operand is a
6392 // constant which cannot collide with a overflowed signed operand,
6393 // then reinterpreting the signed operand as unsigned will not
6394 // change the result of the comparison.
John McCallcc7e5bf2010-05-06 08:58:33 +00006395 if (E->isEqualityOp()) {
6396 unsigned comparisonWidth = S.Context.getIntWidth(T);
6397 IntRange unsignedRange = GetExprRange(S.Context, unsignedOperand);
John McCallca01b222010-01-04 23:21:16 +00006398
John McCallcc7e5bf2010-05-06 08:58:33 +00006399 // We should never be unable to prove that the unsigned operand is
6400 // non-negative.
6401 assert(unsignedRange.NonNegative && "unsigned range includes negative?");
6402
6403 if (unsignedRange.Width < comparisonWidth)
6404 return;
6405 }
6406
Douglas Gregorbfb4a212012-05-01 01:53:49 +00006407 S.DiagRuntimeBehavior(E->getOperatorLoc(), E,
6408 S.PDiag(diag::warn_mixed_sign_comparison)
6409 << LHS->getType() << RHS->getType()
6410 << LHS->getSourceRange() << RHS->getSourceRange());
John McCallca01b222010-01-04 23:21:16 +00006411}
6412
John McCall1f425642010-11-11 03:21:53 +00006413/// Analyzes an attempt to assign the given value to a bitfield.
6414///
6415/// Returns true if there was something fishy about the attempt.
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00006416static bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init,
6417 SourceLocation InitLoc) {
John McCall1f425642010-11-11 03:21:53 +00006418 assert(Bitfield->isBitField());
6419 if (Bitfield->isInvalidDecl())
6420 return false;
6421
John McCalldeebbcf2010-11-11 05:33:51 +00006422 // White-list bool bitfields.
6423 if (Bitfield->getType()->isBooleanType())
6424 return false;
6425
Douglas Gregor789adec2011-02-04 13:09:01 +00006426 // Ignore value- or type-dependent expressions.
6427 if (Bitfield->getBitWidth()->isValueDependent() ||
6428 Bitfield->getBitWidth()->isTypeDependent() ||
6429 Init->isValueDependent() ||
6430 Init->isTypeDependent())
6431 return false;
6432
John McCall1f425642010-11-11 03:21:53 +00006433 Expr *OriginalInit = Init->IgnoreParenImpCasts();
6434
Richard Smith5fab0c92011-12-28 19:48:30 +00006435 llvm::APSInt Value;
6436 if (!OriginalInit->EvaluateAsInt(Value, S.Context, Expr::SE_AllowSideEffects))
John McCall1f425642010-11-11 03:21:53 +00006437 return false;
6438
John McCall1f425642010-11-11 03:21:53 +00006439 unsigned OriginalWidth = Value.getBitWidth();
Richard Smithcaf33902011-10-10 18:28:20 +00006440 unsigned FieldWidth = Bitfield->getBitWidthValue(S.Context);
John McCall1f425642010-11-11 03:21:53 +00006441
6442 if (OriginalWidth <= FieldWidth)
6443 return false;
6444
Eli Friedmanc267a322012-01-26 23:11:39 +00006445 // Compute the value which the bitfield will contain.
Jay Foad6d4db0c2010-12-07 08:25:34 +00006446 llvm::APSInt TruncatedValue = Value.trunc(FieldWidth);
Eli Friedmanc267a322012-01-26 23:11:39 +00006447 TruncatedValue.setIsSigned(Bitfield->getType()->isSignedIntegerType());
John McCall1f425642010-11-11 03:21:53 +00006448
Eli Friedmanc267a322012-01-26 23:11:39 +00006449 // Check whether the stored value is equal to the original value.
6450 TruncatedValue = TruncatedValue.extend(OriginalWidth);
Richard Trieuc320c742012-07-23 20:21:35 +00006451 if (llvm::APSInt::isSameValue(Value, TruncatedValue))
John McCall1f425642010-11-11 03:21:53 +00006452 return false;
6453
Eli Friedmanc267a322012-01-26 23:11:39 +00006454 // Special-case bitfields of width 1: booleans are naturally 0/1, and
Eli Friedmane1ffd492012-02-02 00:40:20 +00006455 // therefore don't strictly fit into a signed bitfield of width 1.
6456 if (FieldWidth == 1 && Value == 1)
Eli Friedmanc267a322012-01-26 23:11:39 +00006457 return false;
6458
John McCall1f425642010-11-11 03:21:53 +00006459 std::string PrettyValue = Value.toString(10);
6460 std::string PrettyTrunc = TruncatedValue.toString(10);
6461
6462 S.Diag(InitLoc, diag::warn_impcast_bitfield_precision_constant)
6463 << PrettyValue << PrettyTrunc << OriginalInit->getType()
6464 << Init->getSourceRange();
6465
6466 return true;
6467}
6468
John McCalld2a53122010-11-09 23:24:47 +00006469/// Analyze the given simple or compound assignment for warning-worthy
6470/// operations.
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00006471static void AnalyzeAssignment(Sema &S, BinaryOperator *E) {
John McCalld2a53122010-11-09 23:24:47 +00006472 // Just recurse on the LHS.
6473 AnalyzeImplicitConversions(S, E->getLHS(), E->getOperatorLoc());
6474
6475 // We want to recurse on the RHS as normal unless we're assigning to
6476 // a bitfield.
John McCalld25db7e2013-05-06 21:39:12 +00006477 if (FieldDecl *Bitfield = E->getLHS()->getSourceBitField()) {
Timur Iskhodzhanov554bdc62013-03-29 00:22:03 +00006478 if (AnalyzeBitFieldAssignment(S, Bitfield, E->getRHS(),
John McCall1f425642010-11-11 03:21:53 +00006479 E->getOperatorLoc())) {
6480 // Recurse, ignoring any implicit conversions on the RHS.
6481 return AnalyzeImplicitConversions(S, E->getRHS()->IgnoreParenImpCasts(),
6482 E->getOperatorLoc());
John McCalld2a53122010-11-09 23:24:47 +00006483 }
6484 }
6485
6486 AnalyzeImplicitConversions(S, E->getRHS(), E->getOperatorLoc());
6487}
6488
John McCall263a48b2010-01-04 23:31:57 +00006489/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00006490static void DiagnoseImpCast(Sema &S, Expr *E, QualType SourceType, QualType T,
Anna Zaks314cd092012-02-01 19:08:57 +00006491 SourceLocation CContext, unsigned diag,
6492 bool pruneControlFlow = false) {
6493 if (pruneControlFlow) {
6494 S.DiagRuntimeBehavior(E->getExprLoc(), E,
6495 S.PDiag(diag)
6496 << SourceType << T << E->getSourceRange()
6497 << SourceRange(CContext));
6498 return;
6499 }
Douglas Gregor364f7db2011-03-12 00:14:31 +00006500 S.Diag(E->getExprLoc(), diag)
6501 << SourceType << T << E->getSourceRange() << SourceRange(CContext);
6502}
6503
Chandler Carruth7f3654f2011-04-05 06:47:57 +00006504/// Diagnose an implicit cast; purely a helper for CheckImplicitConversion.
Ted Kremenek8a92c8b2012-01-31 05:37:37 +00006505static void DiagnoseImpCast(Sema &S, Expr *E, QualType T,
Anna Zaks314cd092012-02-01 19:08:57 +00006506 SourceLocation CContext, unsigned diag,
6507 bool pruneControlFlow = false) {
6508 DiagnoseImpCast(S, E, E->getType(), T, CContext, diag, pruneControlFlow);
Chandler Carruth7f3654f2011-04-05 06:47:57 +00006509}
6510
Matt Beaumont-Gayc6221632011-10-14 15:36:25 +00006511/// Diagnose an implicit cast from a literal expression. Does not warn when the
6512/// cast wouldn't lose information.
Chandler Carruth016ef402011-04-10 08:36:24 +00006513void DiagnoseFloatingLiteralImpCast(Sema &S, FloatingLiteral *FL, QualType T,
6514 SourceLocation CContext) {
Matt Beaumont-Gayc6221632011-10-14 15:36:25 +00006515 // Try to convert the literal exactly to an integer. If we can, don't warn.
Chandler Carruth016ef402011-04-10 08:36:24 +00006516 bool isExact = false;
Matt Beaumont-Gayc6221632011-10-14 15:36:25 +00006517 const llvm::APFloat &Value = FL->getValue();
Jeffrey Yasskind0f079d2011-07-15 17:03:07 +00006518 llvm::APSInt IntegerValue(S.Context.getIntWidth(T),
6519 T->hasUnsignedIntegerRepresentation());
6520 if (Value.convertToInteger(IntegerValue,
Chandler Carruth016ef402011-04-10 08:36:24 +00006521 llvm::APFloat::rmTowardZero, &isExact)
Matt Beaumont-Gayc6221632011-10-14 15:36:25 +00006522 == llvm::APFloat::opOK && isExact)
Chandler Carruth016ef402011-04-10 08:36:24 +00006523 return;
6524
Eli Friedman07185912013-08-29 23:44:43 +00006525 // FIXME: Force the precision of the source value down so we don't print
6526 // digits which are usually useless (we don't really care here if we
6527 // truncate a digit by accident in edge cases). Ideally, APFloat::toString
6528 // would automatically print the shortest representation, but it's a bit
6529 // tricky to implement.
David Blaikie7555b6a2012-05-15 16:56:36 +00006530 SmallString<16> PrettySourceValue;
Eli Friedman07185912013-08-29 23:44:43 +00006531 unsigned precision = llvm::APFloat::semanticsPrecision(Value.getSemantics());
6532 precision = (precision * 59 + 195) / 196;
6533 Value.toString(PrettySourceValue, precision);
6534
David Blaikie9b88cc02012-05-15 17:18:27 +00006535 SmallString<16> PrettyTargetValue;
David Blaikie7555b6a2012-05-15 16:56:36 +00006536 if (T->isSpecificBuiltinType(BuiltinType::Bool))
6537 PrettyTargetValue = IntegerValue == 0 ? "false" : "true";
6538 else
David Blaikie9b88cc02012-05-15 17:18:27 +00006539 IntegerValue.toString(PrettyTargetValue);
David Blaikie7555b6a2012-05-15 16:56:36 +00006540
Matt Beaumont-Gayc6221632011-10-14 15:36:25 +00006541 S.Diag(FL->getExprLoc(), diag::warn_impcast_literal_float_to_integer)
David Blaikie7555b6a2012-05-15 16:56:36 +00006542 << FL->getType() << T.getUnqualifiedType() << PrettySourceValue
6543 << PrettyTargetValue << FL->getSourceRange() << SourceRange(CContext);
Chandler Carruth016ef402011-04-10 08:36:24 +00006544}
6545
John McCall18a2c2c2010-11-09 22:22:12 +00006546std::string PrettyPrintInRange(const llvm::APSInt &Value, IntRange Range) {
6547 if (!Range.Width) return "0";
6548
6549 llvm::APSInt ValueInRange = Value;
6550 ValueInRange.setIsSigned(!Range.NonNegative);
Jay Foad6d4db0c2010-12-07 08:25:34 +00006551 ValueInRange = ValueInRange.trunc(Range.Width);
John McCall18a2c2c2010-11-09 22:22:12 +00006552 return ValueInRange.toString(10);
6553}
6554
Hans Wennborgf4ad2322012-08-28 15:44:30 +00006555static bool IsImplicitBoolFloatConversion(Sema &S, Expr *Ex, bool ToBool) {
6556 if (!isa<ImplicitCastExpr>(Ex))
6557 return false;
6558
6559 Expr *InnerE = Ex->IgnoreParenImpCasts();
6560 const Type *Target = S.Context.getCanonicalType(Ex->getType()).getTypePtr();
6561 const Type *Source =
6562 S.Context.getCanonicalType(InnerE->getType()).getTypePtr();
6563 if (Target->isDependentType())
6564 return false;
6565
6566 const BuiltinType *FloatCandidateBT =
6567 dyn_cast<BuiltinType>(ToBool ? Source : Target);
6568 const Type *BoolCandidateType = ToBool ? Target : Source;
6569
6570 return (BoolCandidateType->isSpecificBuiltinType(BuiltinType::Bool) &&
6571 FloatCandidateBT && (FloatCandidateBT->isFloatingPoint()));
6572}
6573
6574void CheckImplicitArgumentConversions(Sema &S, CallExpr *TheCall,
6575 SourceLocation CC) {
6576 unsigned NumArgs = TheCall->getNumArgs();
6577 for (unsigned i = 0; i < NumArgs; ++i) {
6578 Expr *CurrA = TheCall->getArg(i);
6579 if (!IsImplicitBoolFloatConversion(S, CurrA, true))
6580 continue;
6581
6582 bool IsSwapped = ((i > 0) &&
6583 IsImplicitBoolFloatConversion(S, TheCall->getArg(i - 1), false));
6584 IsSwapped |= ((i < (NumArgs - 1)) &&
6585 IsImplicitBoolFloatConversion(S, TheCall->getArg(i + 1), false));
6586 if (IsSwapped) {
6587 // Warn on this floating-point to bool conversion.
6588 DiagnoseImpCast(S, CurrA->IgnoreParenImpCasts(),
6589 CurrA->getType(), CC,
6590 diag::warn_impcast_floating_point_to_bool);
6591 }
6592 }
6593}
6594
Richard Trieu5b993502014-10-15 03:42:06 +00006595static void DiagnoseNullConversion(Sema &S, Expr *E, QualType T,
6596 SourceLocation CC) {
6597 if (S.Diags.isIgnored(diag::warn_impcast_null_pointer_to_integer,
6598 E->getExprLoc()))
6599 return;
6600
6601 // Check for NULL (GNUNull) or nullptr (CXX11_nullptr).
6602 const Expr::NullPointerConstantKind NullKind =
6603 E->isNullPointerConstant(S.Context, Expr::NPC_ValueDependentIsNotNull);
6604 if (NullKind != Expr::NPCK_GNUNull && NullKind != Expr::NPCK_CXX11_nullptr)
6605 return;
6606
6607 // Return if target type is a safe conversion.
6608 if (T->isAnyPointerType() || T->isBlockPointerType() ||
6609 T->isMemberPointerType() || !T->isScalarType() || T->isNullPtrType())
6610 return;
6611
6612 SourceLocation Loc = E->getSourceRange().getBegin();
6613
6614 // __null is usually wrapped in a macro. Go up a macro if that is the case.
6615 if (NullKind == Expr::NPCK_GNUNull) {
6616 if (Loc.isMacroID())
6617 Loc = S.SourceMgr.getImmediateExpansionRange(Loc).first;
6618 }
6619
6620 // Only warn if the null and context location are in the same macro expansion.
6621 if (S.SourceMgr.getFileID(Loc) != S.SourceMgr.getFileID(CC))
6622 return;
6623
6624 S.Diag(Loc, diag::warn_impcast_null_pointer_to_integer)
6625 << (NullKind == Expr::NPCK_CXX11_nullptr) << T << clang::SourceRange(CC)
6626 << FixItHint::CreateReplacement(Loc,
6627 S.getFixItZeroLiteralForType(T, Loc));
6628}
6629
John McCallcc7e5bf2010-05-06 08:58:33 +00006630void CheckImplicitConversion(Sema &S, Expr *E, QualType T,
Craig Topperc3ec1492014-05-26 06:22:03 +00006631 SourceLocation CC, bool *ICContext = nullptr) {
John McCallcc7e5bf2010-05-06 08:58:33 +00006632 if (E->isTypeDependent() || E->isValueDependent()) return;
John McCall263a48b2010-01-04 23:31:57 +00006633
John McCallcc7e5bf2010-05-06 08:58:33 +00006634 const Type *Source = S.Context.getCanonicalType(E->getType()).getTypePtr();
6635 const Type *Target = S.Context.getCanonicalType(T).getTypePtr();
6636 if (Source == Target) return;
6637 if (Target->isDependentType()) return;
John McCall263a48b2010-01-04 23:31:57 +00006638
Chandler Carruthc22845a2011-07-26 05:40:03 +00006639 // If the conversion context location is invalid don't complain. We also
6640 // don't want to emit a warning if the issue occurs from the expansion of
6641 // a system macro. The problem is that 'getSpellingLoc()' is slow, so we
6642 // delay this check as long as possible. Once we detect we are in that
6643 // scenario, we just return.
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006644 if (CC.isInvalid())
John McCallacf0ee52010-10-08 02:01:28 +00006645 return;
6646
Richard Trieu021baa32011-09-23 20:10:00 +00006647 // Diagnose implicit casts to bool.
6648 if (Target->isSpecificBuiltinType(BuiltinType::Bool)) {
6649 if (isa<StringLiteral>(E))
6650 // Warn on string literal to bool. Checks for string literals in logical
Richard Trieu955231d2014-01-25 01:10:35 +00006651 // and expressions, for instance, assert(0 && "error here"), are
6652 // prevented by a check in AnalyzeImplicitConversions().
Richard Trieu021baa32011-09-23 20:10:00 +00006653 return DiagnoseImpCast(S, E, T, CC,
6654 diag::warn_impcast_string_literal_to_bool);
Richard Trieu1e632af2014-01-28 23:40:26 +00006655 if (isa<ObjCStringLiteral>(E) || isa<ObjCArrayLiteral>(E) ||
6656 isa<ObjCDictionaryLiteral>(E) || isa<ObjCBoxedExpr>(E)) {
6657 // This covers the literal expressions that evaluate to Objective-C
6658 // objects.
6659 return DiagnoseImpCast(S, E, T, CC,
6660 diag::warn_impcast_objective_c_literal_to_bool);
6661 }
Richard Trieu3bb8b562014-02-26 02:36:06 +00006662 if (Source->isPointerType() || Source->canDecayToPointerType()) {
6663 // Warn on pointer to bool conversion that is always true.
6664 S.DiagnoseAlwaysNonNullPointer(E, Expr::NPCK_NotNull, /*IsEqual*/ false,
6665 SourceRange(CC));
Lang Hamesdf5c1212011-12-05 20:49:50 +00006666 }
Richard Trieu021baa32011-09-23 20:10:00 +00006667 }
John McCall263a48b2010-01-04 23:31:57 +00006668
6669 // Strip vector types.
6670 if (isa<VectorType>(Source)) {
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006671 if (!isa<VectorType>(Target)) {
Matt Beaumont-Gay7a57ada2012-01-06 22:43:58 +00006672 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006673 return;
John McCallacf0ee52010-10-08 02:01:28 +00006674 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_vector_scalar);
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006675 }
Chris Lattneree7286f2011-06-14 04:51:15 +00006676
6677 // If the vector cast is cast between two vectors of the same size, it is
6678 // a bitcast, not a conversion.
6679 if (S.Context.getTypeSize(Source) == S.Context.getTypeSize(Target))
6680 return;
John McCall263a48b2010-01-04 23:31:57 +00006681
6682 Source = cast<VectorType>(Source)->getElementType().getTypePtr();
6683 Target = cast<VectorType>(Target)->getElementType().getTypePtr();
6684 }
Stephen Canon3ba640d2014-04-03 10:33:25 +00006685 if (auto VecTy = dyn_cast<VectorType>(Target))
6686 Target = VecTy->getElementType().getTypePtr();
John McCall263a48b2010-01-04 23:31:57 +00006687
6688 // Strip complex types.
6689 if (isa<ComplexType>(Source)) {
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006690 if (!isa<ComplexType>(Target)) {
Matt Beaumont-Gay7a57ada2012-01-06 22:43:58 +00006691 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006692 return;
6693
John McCallacf0ee52010-10-08 02:01:28 +00006694 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_complex_scalar);
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006695 }
John McCall263a48b2010-01-04 23:31:57 +00006696
6697 Source = cast<ComplexType>(Source)->getElementType().getTypePtr();
6698 Target = cast<ComplexType>(Target)->getElementType().getTypePtr();
6699 }
6700
6701 const BuiltinType *SourceBT = dyn_cast<BuiltinType>(Source);
6702 const BuiltinType *TargetBT = dyn_cast<BuiltinType>(Target);
6703
6704 // If the source is floating point...
6705 if (SourceBT && SourceBT->isFloatingPoint()) {
6706 // ...and the target is floating point...
6707 if (TargetBT && TargetBT->isFloatingPoint()) {
6708 // ...then warn if we're dropping FP rank.
6709
6710 // Builtin FP kinds are ordered by increasing FP rank.
6711 if (SourceBT->getKind() > TargetBT->getKind()) {
6712 // Don't warn about float constants that are precisely
6713 // representable in the target type.
6714 Expr::EvalResult result;
Richard Smith7b553f12011-10-29 00:50:52 +00006715 if (E->EvaluateAsRValue(result, S.Context)) {
John McCall263a48b2010-01-04 23:31:57 +00006716 // Value might be a float, a float vector, or a float complex.
6717 if (IsSameFloatAfterCast(result.Val,
John McCallcc7e5bf2010-05-06 08:58:33 +00006718 S.Context.getFloatTypeSemantics(QualType(TargetBT, 0)),
6719 S.Context.getFloatTypeSemantics(QualType(SourceBT, 0))))
John McCall263a48b2010-01-04 23:31:57 +00006720 return;
6721 }
6722
Matt Beaumont-Gay7a57ada2012-01-06 22:43:58 +00006723 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006724 return;
6725
John McCallacf0ee52010-10-08 02:01:28 +00006726 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_precision);
John McCall263a48b2010-01-04 23:31:57 +00006727 }
6728 return;
6729 }
6730
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006731 // If the target is integral, always warn.
David Blaikie7555b6a2012-05-15 16:56:36 +00006732 if (TargetBT && TargetBT->isInteger()) {
Matt Beaumont-Gay7a57ada2012-01-06 22:43:58 +00006733 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006734 return;
6735
Chandler Carruth22c7a792011-02-17 11:05:49 +00006736 Expr *InnerE = E->IgnoreParenImpCasts();
Matt Beaumont-Gay042ce8e2011-09-08 22:30:47 +00006737 // We also want to warn on, e.g., "int i = -1.234"
6738 if (UnaryOperator *UOp = dyn_cast<UnaryOperator>(InnerE))
6739 if (UOp->getOpcode() == UO_Minus || UOp->getOpcode() == UO_Plus)
6740 InnerE = UOp->getSubExpr()->IgnoreParenImpCasts();
6741
Chandler Carruth016ef402011-04-10 08:36:24 +00006742 if (FloatingLiteral *FL = dyn_cast<FloatingLiteral>(InnerE)) {
6743 DiagnoseFloatingLiteralImpCast(S, FL, T, CC);
Chandler Carruth22c7a792011-02-17 11:05:49 +00006744 } else {
6745 DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_float_integer);
6746 }
6747 }
John McCall263a48b2010-01-04 23:31:57 +00006748
Hans Wennborgf4ad2322012-08-28 15:44:30 +00006749 // If the target is bool, warn if expr is a function or method call.
6750 if (Target->isSpecificBuiltinType(BuiltinType::Bool) &&
6751 isa<CallExpr>(E)) {
6752 // Check last argument of function call to see if it is an
6753 // implicit cast from a type matching the type the result
6754 // is being cast to.
6755 CallExpr *CEx = cast<CallExpr>(E);
6756 unsigned NumArgs = CEx->getNumArgs();
6757 if (NumArgs > 0) {
6758 Expr *LastA = CEx->getArg(NumArgs - 1);
6759 Expr *InnerE = LastA->IgnoreParenImpCasts();
6760 const Type *InnerType =
6761 S.Context.getCanonicalType(InnerE->getType()).getTypePtr();
6762 if (isa<ImplicitCastExpr>(LastA) && (InnerType == Target)) {
6763 // Warn on this floating-point to bool conversion
6764 DiagnoseImpCast(S, E, T, CC,
6765 diag::warn_impcast_floating_point_to_bool);
6766 }
6767 }
6768 }
John McCall263a48b2010-01-04 23:31:57 +00006769 return;
6770 }
6771
Richard Trieu5b993502014-10-15 03:42:06 +00006772 DiagnoseNullConversion(S, E, T, CC);
Richard Trieubeaf3452011-05-29 19:59:02 +00006773
David Blaikie9366d2b2012-06-19 21:19:06 +00006774 if (!Source->isIntegerType() || !Target->isIntegerType())
6775 return;
6776
David Blaikie7555b6a2012-05-15 16:56:36 +00006777 // TODO: remove this early return once the false positives for constant->bool
6778 // in templates, macros, etc, are reduced or removed.
6779 if (Target->isSpecificBuiltinType(BuiltinType::Bool))
6780 return;
6781
John McCallcc7e5bf2010-05-06 08:58:33 +00006782 IntRange SourceRange = GetExprRange(S.Context, E);
John McCall817d4af2010-11-10 23:38:19 +00006783 IntRange TargetRange = IntRange::forTargetOfCanonicalType(S.Context, Target);
John McCall70aa5392010-01-06 05:24:50 +00006784
Timur Iskhodzhanov554bdc62013-03-29 00:22:03 +00006785 if (SourceRange.Width > TargetRange.Width) {
Sam Panzer6fffec62013-03-28 19:07:11 +00006786 // If the source is a constant, use a default-on diagnostic.
Timur Iskhodzhanov554bdc62013-03-29 00:22:03 +00006787 // TODO: this should happen for bitfield stores, too.
6788 llvm::APSInt Value(32);
6789 if (E->isIntegerConstantExpr(Value, S.Context)) {
6790 if (S.SourceMgr.isInSystemMacro(CC))
6791 return;
6792
John McCall18a2c2c2010-11-09 22:22:12 +00006793 std::string PrettySourceValue = Value.toString(10);
6794 std::string PrettyTargetValue = PrettyPrintInRange(Value, TargetRange);
Timur Iskhodzhanov554bdc62013-03-29 00:22:03 +00006795
Ted Kremenek33ba9952011-10-22 02:37:33 +00006796 S.DiagRuntimeBehavior(E->getExprLoc(), E,
6797 S.PDiag(diag::warn_impcast_integer_precision_constant)
6798 << PrettySourceValue << PrettyTargetValue
6799 << E->getType() << T << E->getSourceRange()
6800 << clang::SourceRange(CC));
John McCall18a2c2c2010-11-09 22:22:12 +00006801 return;
6802 }
6803
Timur Iskhodzhanov554bdc62013-03-29 00:22:03 +00006804 // People want to build with -Wshorten-64-to-32 and not -Wconversion.
6805 if (S.SourceMgr.isInSystemMacro(CC))
6806 return;
6807
David Blaikie9455da02012-04-12 22:40:54 +00006808 if (TargetRange.Width == 32 && S.Context.getIntWidth(E->getType()) == 64)
Anna Zaks314cd092012-02-01 19:08:57 +00006809 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_64_32,
6810 /* pruneControlFlow */ true);
John McCallacf0ee52010-10-08 02:01:28 +00006811 return DiagnoseImpCast(S, E, T, CC, diag::warn_impcast_integer_precision);
John McCallcc7e5bf2010-05-06 08:58:33 +00006812 }
6813
6814 if ((TargetRange.NonNegative && !SourceRange.NonNegative) ||
6815 (!TargetRange.NonNegative && SourceRange.NonNegative &&
6816 SourceRange.Width == TargetRange.Width)) {
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006817
Matt Beaumont-Gay7a57ada2012-01-06 22:43:58 +00006818 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006819 return;
6820
John McCallcc7e5bf2010-05-06 08:58:33 +00006821 unsigned DiagID = diag::warn_impcast_integer_sign;
6822
6823 // Traditionally, gcc has warned about this under -Wsign-compare.
6824 // We also want to warn about it in -Wconversion.
6825 // So if -Wconversion is off, use a completely identical diagnostic
6826 // in the sign-compare group.
6827 // The conditional-checking code will
6828 if (ICContext) {
6829 DiagID = diag::warn_impcast_integer_sign_conditional;
6830 *ICContext = true;
6831 }
6832
John McCallacf0ee52010-10-08 02:01:28 +00006833 return DiagnoseImpCast(S, E, T, CC, DiagID);
John McCall263a48b2010-01-04 23:31:57 +00006834 }
6835
Douglas Gregora78f1932011-02-22 02:45:07 +00006836 // Diagnose conversions between different enumeration types.
Douglas Gregor364f7db2011-03-12 00:14:31 +00006837 // In C, we pretend that the type of an EnumConstantDecl is its enumeration
6838 // type, to give us better diagnostics.
6839 QualType SourceType = E->getType();
David Blaikiebbafb8a2012-03-11 07:00:24 +00006840 if (!S.getLangOpts().CPlusPlus) {
Douglas Gregor364f7db2011-03-12 00:14:31 +00006841 if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E))
6842 if (EnumConstantDecl *ECD = dyn_cast<EnumConstantDecl>(DRE->getDecl())) {
6843 EnumDecl *Enum = cast<EnumDecl>(ECD->getDeclContext());
6844 SourceType = S.Context.getTypeDeclType(Enum);
6845 Source = S.Context.getCanonicalType(SourceType).getTypePtr();
6846 }
6847 }
6848
Douglas Gregora78f1932011-02-22 02:45:07 +00006849 if (const EnumType *SourceEnum = Source->getAs<EnumType>())
6850 if (const EnumType *TargetEnum = Target->getAs<EnumType>())
John McCall5ea95772013-03-09 00:54:27 +00006851 if (SourceEnum->getDecl()->hasNameForLinkage() &&
6852 TargetEnum->getDecl()->hasNameForLinkage() &&
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006853 SourceEnum != TargetEnum) {
Matt Beaumont-Gay7a57ada2012-01-06 22:43:58 +00006854 if (S.SourceMgr.isInSystemMacro(CC))
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006855 return;
6856
Douglas Gregor364f7db2011-03-12 00:14:31 +00006857 return DiagnoseImpCast(S, E, SourceType, T, CC,
Douglas Gregora78f1932011-02-22 02:45:07 +00006858 diag::warn_impcast_different_enum_types);
Ted Kremenek4c0826c2011-03-10 20:03:42 +00006859 }
Douglas Gregora78f1932011-02-22 02:45:07 +00006860
John McCall263a48b2010-01-04 23:31:57 +00006861 return;
6862}
6863
David Blaikie18e9ac72012-05-15 21:57:38 +00006864void CheckConditionalOperator(Sema &S, ConditionalOperator *E,
6865 SourceLocation CC, QualType T);
John McCallcc7e5bf2010-05-06 08:58:33 +00006866
6867void CheckConditionalOperand(Sema &S, Expr *E, QualType T,
John McCallacf0ee52010-10-08 02:01:28 +00006868 SourceLocation CC, bool &ICContext) {
John McCallcc7e5bf2010-05-06 08:58:33 +00006869 E = E->IgnoreParenImpCasts();
6870
6871 if (isa<ConditionalOperator>(E))
David Blaikie18e9ac72012-05-15 21:57:38 +00006872 return CheckConditionalOperator(S, cast<ConditionalOperator>(E), CC, T);
John McCallcc7e5bf2010-05-06 08:58:33 +00006873
John McCallacf0ee52010-10-08 02:01:28 +00006874 AnalyzeImplicitConversions(S, E, CC);
John McCallcc7e5bf2010-05-06 08:58:33 +00006875 if (E->getType() != T)
John McCallacf0ee52010-10-08 02:01:28 +00006876 return CheckImplicitConversion(S, E, T, CC, &ICContext);
John McCallcc7e5bf2010-05-06 08:58:33 +00006877 return;
6878}
6879
David Blaikie18e9ac72012-05-15 21:57:38 +00006880void CheckConditionalOperator(Sema &S, ConditionalOperator *E,
6881 SourceLocation CC, QualType T) {
Richard Trieubd3305b2014-08-07 02:09:05 +00006882 AnalyzeImplicitConversions(S, E->getCond(), E->getQuestionLoc());
John McCallcc7e5bf2010-05-06 08:58:33 +00006883
6884 bool Suspicious = false;
John McCallacf0ee52010-10-08 02:01:28 +00006885 CheckConditionalOperand(S, E->getTrueExpr(), T, CC, Suspicious);
6886 CheckConditionalOperand(S, E->getFalseExpr(), T, CC, Suspicious);
John McCallcc7e5bf2010-05-06 08:58:33 +00006887
6888 // If -Wconversion would have warned about either of the candidates
6889 // for a signedness conversion to the context type...
6890 if (!Suspicious) return;
6891
6892 // ...but it's currently ignored...
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00006893 if (!S.Diags.isIgnored(diag::warn_impcast_integer_sign_conditional, CC))
John McCallcc7e5bf2010-05-06 08:58:33 +00006894 return;
6895
John McCallcc7e5bf2010-05-06 08:58:33 +00006896 // ...then check whether it would have warned about either of the
6897 // candidates for a signedness conversion to the condition type.
Richard Trieubb43dec2011-07-21 02:46:28 +00006898 if (E->getType() == T) return;
6899
6900 Suspicious = false;
6901 CheckImplicitConversion(S, E->getTrueExpr()->IgnoreParenImpCasts(),
6902 E->getType(), CC, &Suspicious);
6903 if (!Suspicious)
6904 CheckImplicitConversion(S, E->getFalseExpr()->IgnoreParenImpCasts(),
John McCallacf0ee52010-10-08 02:01:28 +00006905 E->getType(), CC, &Suspicious);
John McCallcc7e5bf2010-05-06 08:58:33 +00006906}
6907
Richard Trieu65724892014-11-15 06:37:39 +00006908/// CheckBoolLikeConversion - Check conversion of given expression to boolean.
6909/// Input argument E is a logical expression.
6910static void CheckBoolLikeConversion(Sema &S, Expr *E, SourceLocation CC) {
6911 if (S.getLangOpts().Bool)
6912 return;
6913 CheckImplicitConversion(S, E->IgnoreParenImpCasts(), S.Context.BoolTy, CC);
6914}
6915
John McCallcc7e5bf2010-05-06 08:58:33 +00006916/// AnalyzeImplicitConversions - Find and report any interesting
6917/// implicit conversions in the given expression. There are a couple
6918/// of competing diagnostics here, -Wconversion and -Wsign-compare.
John McCallacf0ee52010-10-08 02:01:28 +00006919void AnalyzeImplicitConversions(Sema &S, Expr *OrigE, SourceLocation CC) {
Fariborz Jahanian148c8c82014-04-07 16:32:54 +00006920 QualType T = OrigE->getType();
John McCallcc7e5bf2010-05-06 08:58:33 +00006921 Expr *E = OrigE->IgnoreParenImpCasts();
6922
Douglas Gregor6e8da6a2011-10-10 17:38:18 +00006923 if (E->isTypeDependent() || E->isValueDependent())
6924 return;
Fariborz Jahanianad95da72014-04-04 19:33:39 +00006925
John McCallcc7e5bf2010-05-06 08:58:33 +00006926 // For conditional operators, we analyze the arguments as if they
6927 // were being fed directly into the output.
6928 if (isa<ConditionalOperator>(E)) {
6929 ConditionalOperator *CO = cast<ConditionalOperator>(E);
David Blaikie18e9ac72012-05-15 21:57:38 +00006930 CheckConditionalOperator(S, CO, CC, T);
John McCallcc7e5bf2010-05-06 08:58:33 +00006931 return;
6932 }
6933
Hans Wennborgf4ad2322012-08-28 15:44:30 +00006934 // Check implicit argument conversions for function calls.
6935 if (CallExpr *Call = dyn_cast<CallExpr>(E))
6936 CheckImplicitArgumentConversions(S, Call, CC);
6937
John McCallcc7e5bf2010-05-06 08:58:33 +00006938 // Go ahead and check any implicit conversions we might have skipped.
6939 // The non-canonical typecheck is just an optimization;
6940 // CheckImplicitConversion will filter out dead implicit conversions.
6941 if (E->getType() != T)
John McCallacf0ee52010-10-08 02:01:28 +00006942 CheckImplicitConversion(S, E, T, CC);
John McCallcc7e5bf2010-05-06 08:58:33 +00006943
6944 // Now continue drilling into this expression.
Fariborz Jahanian2cb4a952013-05-15 19:03:04 +00006945
6946 if (PseudoObjectExpr * POE = dyn_cast<PseudoObjectExpr>(E)) {
Fariborz Jahanian0b11ef22013-05-15 22:25:03 +00006947 if (POE->getResultExpr())
6948 E = POE->getResultExpr();
Fariborz Jahanian2cb4a952013-05-15 19:03:04 +00006949 }
6950
Fariborz Jahanian947efbc2015-02-26 17:59:54 +00006951 if (const OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(E)) {
6952 if (OVE->getSourceExpr())
6953 AnalyzeImplicitConversions(S, OVE->getSourceExpr(), CC);
6954 return;
6955 }
Fariborz Jahanian0b11ef22013-05-15 22:25:03 +00006956
John McCallcc7e5bf2010-05-06 08:58:33 +00006957 // Skip past explicit casts.
6958 if (isa<ExplicitCastExpr>(E)) {
6959 E = cast<ExplicitCastExpr>(E)->getSubExpr()->IgnoreParenImpCasts();
John McCallacf0ee52010-10-08 02:01:28 +00006960 return AnalyzeImplicitConversions(S, E, CC);
John McCallcc7e5bf2010-05-06 08:58:33 +00006961 }
6962
John McCalld2a53122010-11-09 23:24:47 +00006963 if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
6964 // Do a somewhat different check with comparison operators.
6965 if (BO->isComparisonOp())
6966 return AnalyzeComparison(S, BO);
6967
Timur Iskhodzhanov554bdc62013-03-29 00:22:03 +00006968 // And with simple assignments.
6969 if (BO->getOpcode() == BO_Assign)
John McCalld2a53122010-11-09 23:24:47 +00006970 return AnalyzeAssignment(S, BO);
6971 }
John McCallcc7e5bf2010-05-06 08:58:33 +00006972
6973 // These break the otherwise-useful invariant below. Fortunately,
6974 // we don't really need to recurse into them, because any internal
6975 // expressions should have been analyzed already when they were
6976 // built into statements.
6977 if (isa<StmtExpr>(E)) return;
6978
6979 // Don't descend into unevaluated contexts.
Peter Collingbournee190dee2011-03-11 19:24:49 +00006980 if (isa<UnaryExprOrTypeTraitExpr>(E)) return;
John McCallcc7e5bf2010-05-06 08:58:33 +00006981
6982 // Now just recurse over the expression's children.
John McCallacf0ee52010-10-08 02:01:28 +00006983 CC = E->getExprLoc();
Richard Trieu021baa32011-09-23 20:10:00 +00006984 BinaryOperator *BO = dyn_cast<BinaryOperator>(E);
Richard Trieu955231d2014-01-25 01:10:35 +00006985 bool IsLogicalAndOperator = BO && BO->getOpcode() == BO_LAnd;
Richard Trieu021baa32011-09-23 20:10:00 +00006986 for (Stmt::child_range I = E->children(); I; ++I) {
Douglas Gregor73456262012-02-09 10:18:50 +00006987 Expr *ChildExpr = dyn_cast_or_null<Expr>(*I);
Douglas Gregor8c50e7c2012-02-09 00:47:04 +00006988 if (!ChildExpr)
6989 continue;
6990
Richard Trieu955231d2014-01-25 01:10:35 +00006991 if (IsLogicalAndOperator &&
Richard Trieu021baa32011-09-23 20:10:00 +00006992 isa<StringLiteral>(ChildExpr->IgnoreParenImpCasts()))
Richard Trieu955231d2014-01-25 01:10:35 +00006993 // Ignore checking string literals that are in logical and operators.
6994 // This is a common pattern for asserts.
Richard Trieu021baa32011-09-23 20:10:00 +00006995 continue;
6996 AnalyzeImplicitConversions(S, ChildExpr, CC);
6997 }
Richard Trieu791b86e2014-11-19 06:08:18 +00006998
Fariborz Jahanianb7859dd2014-11-14 17:12:50 +00006999 if (BO && BO->isLogicalOp()) {
Richard Trieu791b86e2014-11-19 06:08:18 +00007000 Expr *SubExpr = BO->getLHS()->IgnoreParenImpCasts();
7001 if (!IsLogicalAndOperator || !isa<StringLiteral>(SubExpr))
Fariborz Jahanian0fc95ad2014-12-18 23:14:51 +00007002 ::CheckBoolLikeConversion(S, SubExpr, BO->getExprLoc());
Richard Trieu791b86e2014-11-19 06:08:18 +00007003
7004 SubExpr = BO->getRHS()->IgnoreParenImpCasts();
7005 if (!IsLogicalAndOperator || !isa<StringLiteral>(SubExpr))
Fariborz Jahanian0fc95ad2014-12-18 23:14:51 +00007006 ::CheckBoolLikeConversion(S, SubExpr, BO->getExprLoc());
Fariborz Jahanianb7859dd2014-11-14 17:12:50 +00007007 }
Richard Trieu791b86e2014-11-19 06:08:18 +00007008
Fariborz Jahanianb7859dd2014-11-14 17:12:50 +00007009 if (const UnaryOperator *U = dyn_cast<UnaryOperator>(E))
7010 if (U->getOpcode() == UO_LNot)
Richard Trieu65724892014-11-15 06:37:39 +00007011 ::CheckBoolLikeConversion(S, U->getSubExpr(), CC);
John McCallcc7e5bf2010-05-06 08:58:33 +00007012}
7013
7014} // end anonymous namespace
7015
Richard Trieu3bb8b562014-02-26 02:36:06 +00007016enum {
7017 AddressOf,
7018 FunctionPointer,
7019 ArrayPointer
7020};
7021
Richard Trieuc1888e02014-06-28 23:25:37 +00007022// Helper function for Sema::DiagnoseAlwaysNonNullPointer.
7023// Returns true when emitting a warning about taking the address of a reference.
7024static bool CheckForReference(Sema &SemaRef, const Expr *E,
7025 PartialDiagnostic PD) {
7026 E = E->IgnoreParenImpCasts();
7027
7028 const FunctionDecl *FD = nullptr;
7029
7030 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E)) {
7031 if (!DRE->getDecl()->getType()->isReferenceType())
7032 return false;
7033 } else if (const MemberExpr *M = dyn_cast<MemberExpr>(E)) {
7034 if (!M->getMemberDecl()->getType()->isReferenceType())
7035 return false;
7036 } else if (const CallExpr *Call = dyn_cast<CallExpr>(E)) {
David Majnemerced8bdf2015-02-25 17:36:15 +00007037 if (!Call->getCallReturnType(SemaRef.Context)->isReferenceType())
Richard Trieuc1888e02014-06-28 23:25:37 +00007038 return false;
7039 FD = Call->getDirectCallee();
7040 } else {
7041 return false;
7042 }
7043
7044 SemaRef.Diag(E->getExprLoc(), PD);
7045
7046 // If possible, point to location of function.
7047 if (FD) {
7048 SemaRef.Diag(FD->getLocation(), diag::note_reference_is_return_value) << FD;
7049 }
7050
7051 return true;
7052}
7053
Richard Trieu4cbff5c2014-08-08 22:41:43 +00007054// Returns true if the SourceLocation is expanded from any macro body.
7055// Returns false if the SourceLocation is invalid, is from not in a macro
7056// expansion, or is from expanded from a top-level macro argument.
7057static bool IsInAnyMacroBody(const SourceManager &SM, SourceLocation Loc) {
7058 if (Loc.isInvalid())
7059 return false;
7060
7061 while (Loc.isMacroID()) {
7062 if (SM.isMacroBodyExpansion(Loc))
7063 return true;
7064 Loc = SM.getImmediateMacroCallerLoc(Loc);
7065 }
7066
7067 return false;
7068}
7069
Richard Trieu3bb8b562014-02-26 02:36:06 +00007070/// \brief Diagnose pointers that are always non-null.
7071/// \param E the expression containing the pointer
7072/// \param NullKind NPCK_NotNull if E is a cast to bool, otherwise, E is
7073/// compared to a null pointer
7074/// \param IsEqual True when the comparison is equal to a null pointer
7075/// \param Range Extra SourceRange to highlight in the diagnostic
7076void Sema::DiagnoseAlwaysNonNullPointer(Expr *E,
7077 Expr::NullPointerConstantKind NullKind,
7078 bool IsEqual, SourceRange Range) {
Richard Trieuddd01ce2014-06-09 22:53:25 +00007079 if (!E)
7080 return;
Richard Trieu3bb8b562014-02-26 02:36:06 +00007081
7082 // Don't warn inside macros.
Richard Trieu4cbff5c2014-08-08 22:41:43 +00007083 if (E->getExprLoc().isMacroID()) {
7084 const SourceManager &SM = getSourceManager();
7085 if (IsInAnyMacroBody(SM, E->getExprLoc()) ||
7086 IsInAnyMacroBody(SM, Range.getBegin()))
Richard Trieu3bb8b562014-02-26 02:36:06 +00007087 return;
Richard Trieu4cbff5c2014-08-08 22:41:43 +00007088 }
Richard Trieu3bb8b562014-02-26 02:36:06 +00007089 E = E->IgnoreImpCasts();
7090
7091 const bool IsCompare = NullKind != Expr::NPCK_NotNull;
7092
Richard Trieuf7432752014-06-06 21:39:26 +00007093 if (isa<CXXThisExpr>(E)) {
7094 unsigned DiagID = IsCompare ? diag::warn_this_null_compare
7095 : diag::warn_this_bool_conversion;
7096 Diag(E->getExprLoc(), DiagID) << E->getSourceRange() << Range << IsEqual;
7097 return;
7098 }
7099
Richard Trieu3bb8b562014-02-26 02:36:06 +00007100 bool IsAddressOf = false;
7101
7102 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
7103 if (UO->getOpcode() != UO_AddrOf)
7104 return;
7105 IsAddressOf = true;
7106 E = UO->getSubExpr();
7107 }
7108
Richard Trieuc1888e02014-06-28 23:25:37 +00007109 if (IsAddressOf) {
7110 unsigned DiagID = IsCompare
7111 ? diag::warn_address_of_reference_null_compare
7112 : diag::warn_address_of_reference_bool_conversion;
7113 PartialDiagnostic PD = PDiag(DiagID) << E->getSourceRange() << Range
7114 << IsEqual;
7115 if (CheckForReference(*this, E, PD)) {
7116 return;
7117 }
7118 }
7119
Richard Trieu3bb8b562014-02-26 02:36:06 +00007120 // Expect to find a single Decl. Skip anything more complicated.
Craig Topperc3ec1492014-05-26 06:22:03 +00007121 ValueDecl *D = nullptr;
Richard Trieu3bb8b562014-02-26 02:36:06 +00007122 if (DeclRefExpr *R = dyn_cast<DeclRefExpr>(E)) {
7123 D = R->getDecl();
7124 } else if (MemberExpr *M = dyn_cast<MemberExpr>(E)) {
7125 D = M->getMemberDecl();
7126 }
7127
7128 // Weak Decls can be null.
7129 if (!D || D->isWeak())
7130 return;
Fariborz Jahanianef202d92014-11-18 21:57:54 +00007131
7132 // Check for parameter decl with nonnull attribute
7133 if (const ParmVarDecl* PV = dyn_cast<ParmVarDecl>(D)) {
7134 if (getCurFunction() && !getCurFunction()->ModifiedNonNullParams.count(PV))
7135 if (const FunctionDecl* FD = dyn_cast<FunctionDecl>(PV->getDeclContext())) {
7136 unsigned NumArgs = FD->getNumParams();
7137 llvm::SmallBitVector AttrNonNull(NumArgs);
7138 for (const auto *NonNull : FD->specific_attrs<NonNullAttr>()) {
7139 if (!NonNull->args_size()) {
7140 AttrNonNull.set(0, NumArgs);
7141 break;
7142 }
7143 for (unsigned Val : NonNull->args()) {
7144 if (Val >= NumArgs)
7145 continue;
7146 AttrNonNull.set(Val);
7147 }
7148 }
7149 if (!AttrNonNull.empty())
7150 for (unsigned i = 0; i < NumArgs; ++i)
Aaron Ballman2521f362014-12-11 19:35:42 +00007151 if (FD->getParamDecl(i) == PV &&
7152 (AttrNonNull[i] || PV->hasAttr<NonNullAttr>())) {
Fariborz Jahanianef202d92014-11-18 21:57:54 +00007153 std::string Str;
7154 llvm::raw_string_ostream S(Str);
7155 E->printPretty(S, nullptr, getPrintingPolicy());
7156 unsigned DiagID = IsCompare ? diag::warn_nonnull_parameter_compare
7157 : diag::warn_cast_nonnull_to_bool;
7158 Diag(E->getExprLoc(), DiagID) << S.str() << E->getSourceRange()
7159 << Range << IsEqual;
7160 return;
7161 }
7162 }
7163 }
7164
Richard Trieu3bb8b562014-02-26 02:36:06 +00007165 QualType T = D->getType();
7166 const bool IsArray = T->isArrayType();
7167 const bool IsFunction = T->isFunctionType();
7168
Richard Trieuc1888e02014-06-28 23:25:37 +00007169 // Address of function is used to silence the function warning.
7170 if (IsAddressOf && IsFunction) {
7171 return;
Richard Trieu3bb8b562014-02-26 02:36:06 +00007172 }
7173
7174 // Found nothing.
7175 if (!IsAddressOf && !IsFunction && !IsArray)
7176 return;
7177
7178 // Pretty print the expression for the diagnostic.
7179 std::string Str;
7180 llvm::raw_string_ostream S(Str);
Craig Topperc3ec1492014-05-26 06:22:03 +00007181 E->printPretty(S, nullptr, getPrintingPolicy());
Richard Trieu3bb8b562014-02-26 02:36:06 +00007182
7183 unsigned DiagID = IsCompare ? diag::warn_null_pointer_compare
7184 : diag::warn_impcast_pointer_to_bool;
7185 unsigned DiagType;
7186 if (IsAddressOf)
7187 DiagType = AddressOf;
7188 else if (IsFunction)
7189 DiagType = FunctionPointer;
7190 else if (IsArray)
7191 DiagType = ArrayPointer;
7192 else
7193 llvm_unreachable("Could not determine diagnostic.");
7194 Diag(E->getExprLoc(), DiagID) << DiagType << S.str() << E->getSourceRange()
7195 << Range << IsEqual;
7196
7197 if (!IsFunction)
7198 return;
7199
7200 // Suggest '&' to silence the function warning.
7201 Diag(E->getExprLoc(), diag::note_function_warning_silence)
7202 << FixItHint::CreateInsertion(E->getLocStart(), "&");
7203
7204 // Check to see if '()' fixit should be emitted.
7205 QualType ReturnType;
7206 UnresolvedSet<4> NonTemplateOverloads;
7207 tryExprAsCall(*E, ReturnType, NonTemplateOverloads);
7208 if (ReturnType.isNull())
7209 return;
7210
7211 if (IsCompare) {
7212 // There are two cases here. If there is null constant, the only suggest
7213 // for a pointer return type. If the null is 0, then suggest if the return
7214 // type is a pointer or an integer type.
7215 if (!ReturnType->isPointerType()) {
7216 if (NullKind == Expr::NPCK_ZeroExpression ||
7217 NullKind == Expr::NPCK_ZeroLiteral) {
7218 if (!ReturnType->isIntegerType())
7219 return;
7220 } else {
7221 return;
7222 }
7223 }
7224 } else { // !IsCompare
7225 // For function to bool, only suggest if the function pointer has bool
7226 // return type.
7227 if (!ReturnType->isSpecificBuiltinType(BuiltinType::Bool))
7228 return;
7229 }
7230 Diag(E->getExprLoc(), diag::note_function_to_function_call)
Alp Tokerb6cc5922014-05-03 03:45:55 +00007231 << FixItHint::CreateInsertion(getLocForEndOfToken(E->getLocEnd()), "()");
Richard Trieu3bb8b562014-02-26 02:36:06 +00007232}
7233
7234
John McCallcc7e5bf2010-05-06 08:58:33 +00007235/// Diagnoses "dangerous" implicit conversions within the given
7236/// expression (which is a full expression). Implements -Wconversion
7237/// and -Wsign-compare.
John McCallacf0ee52010-10-08 02:01:28 +00007238///
7239/// \param CC the "context" location of the implicit conversion, i.e.
7240/// the most location of the syntactic entity requiring the implicit
7241/// conversion
7242void Sema::CheckImplicitConversions(Expr *E, SourceLocation CC) {
John McCallcc7e5bf2010-05-06 08:58:33 +00007243 // Don't diagnose in unevaluated contexts.
David Blaikie131fcb42012-08-06 22:47:24 +00007244 if (isUnevaluatedContext())
John McCallcc7e5bf2010-05-06 08:58:33 +00007245 return;
7246
7247 // Don't diagnose for value- or type-dependent expressions.
7248 if (E->isTypeDependent() || E->isValueDependent())
7249 return;
7250
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00007251 // Check for array bounds violations in cases where the check isn't triggered
7252 // elsewhere for other Expr types (like BinaryOperators), e.g. when an
7253 // ArraySubscriptExpr is on the RHS of a variable initialization.
7254 CheckArrayAccess(E);
7255
John McCallacf0ee52010-10-08 02:01:28 +00007256 // This is not the right CC for (e.g.) a variable initialization.
7257 AnalyzeImplicitConversions(*this, E, CC);
John McCallcc7e5bf2010-05-06 08:58:33 +00007258}
7259
Richard Trieu65724892014-11-15 06:37:39 +00007260/// CheckBoolLikeConversion - Check conversion of given expression to boolean.
7261/// Input argument E is a logical expression.
7262void Sema::CheckBoolLikeConversion(Expr *E, SourceLocation CC) {
7263 ::CheckBoolLikeConversion(*this, E, CC);
7264}
7265
Fariborz Jahaniane735ff92013-01-24 22:11:45 +00007266/// Diagnose when expression is an integer constant expression and its evaluation
7267/// results in integer overflow
7268void Sema::CheckForIntOverflow (Expr *E) {
Fariborz Jahanianc694e692014-10-14 20:27:05 +00007269 if (isa<BinaryOperator>(E->IgnoreParenCasts()))
7270 E->IgnoreParenCasts()->EvaluateForOverflow(Context);
Fariborz Jahaniane735ff92013-01-24 22:11:45 +00007271}
7272
Richard Smithc406cb72013-01-17 01:17:56 +00007273namespace {
7274/// \brief Visitor for expressions which looks for unsequenced operations on the
7275/// same object.
7276class SequenceChecker : public EvaluatedExprVisitor<SequenceChecker> {
Richard Smithe3dbfe02013-06-30 10:40:20 +00007277 typedef EvaluatedExprVisitor<SequenceChecker> Base;
7278
Richard Smithc406cb72013-01-17 01:17:56 +00007279 /// \brief A tree of sequenced regions within an expression. Two regions are
7280 /// unsequenced if one is an ancestor or a descendent of the other. When we
7281 /// finish processing an expression with sequencing, such as a comma
7282 /// expression, we fold its tree nodes into its parent, since they are
7283 /// unsequenced with respect to nodes we will visit later.
7284 class SequenceTree {
7285 struct Value {
7286 explicit Value(unsigned Parent) : Parent(Parent), Merged(false) {}
7287 unsigned Parent : 31;
7288 bool Merged : 1;
7289 };
Robert Wilhelmb869a8f2013-08-10 12:33:24 +00007290 SmallVector<Value, 8> Values;
Richard Smithc406cb72013-01-17 01:17:56 +00007291
7292 public:
7293 /// \brief A region within an expression which may be sequenced with respect
7294 /// to some other region.
7295 class Seq {
7296 explicit Seq(unsigned N) : Index(N) {}
7297 unsigned Index;
7298 friend class SequenceTree;
7299 public:
7300 Seq() : Index(0) {}
7301 };
7302
7303 SequenceTree() { Values.push_back(Value(0)); }
7304 Seq root() const { return Seq(0); }
7305
7306 /// \brief Create a new sequence of operations, which is an unsequenced
7307 /// subset of \p Parent. This sequence of operations is sequenced with
7308 /// respect to other children of \p Parent.
7309 Seq allocate(Seq Parent) {
7310 Values.push_back(Value(Parent.Index));
7311 return Seq(Values.size() - 1);
7312 }
7313
7314 /// \brief Merge a sequence of operations into its parent.
7315 void merge(Seq S) {
7316 Values[S.Index].Merged = true;
7317 }
7318
7319 /// \brief Determine whether two operations are unsequenced. This operation
7320 /// is asymmetric: \p Cur should be the more recent sequence, and \p Old
7321 /// should have been merged into its parent as appropriate.
7322 bool isUnsequenced(Seq Cur, Seq Old) {
7323 unsigned C = representative(Cur.Index);
7324 unsigned Target = representative(Old.Index);
7325 while (C >= Target) {
7326 if (C == Target)
7327 return true;
7328 C = Values[C].Parent;
7329 }
7330 return false;
7331 }
7332
7333 private:
7334 /// \brief Pick a representative for a sequence.
7335 unsigned representative(unsigned K) {
7336 if (Values[K].Merged)
7337 // Perform path compression as we go.
7338 return Values[K].Parent = representative(Values[K].Parent);
7339 return K;
7340 }
7341 };
7342
7343 /// An object for which we can track unsequenced uses.
7344 typedef NamedDecl *Object;
7345
7346 /// Different flavors of object usage which we track. We only track the
7347 /// least-sequenced usage of each kind.
7348 enum UsageKind {
7349 /// A read of an object. Multiple unsequenced reads are OK.
7350 UK_Use,
7351 /// A modification of an object which is sequenced before the value
Richard Smith83e37bee2013-06-26 23:16:51 +00007352 /// computation of the expression, such as ++n in C++.
Richard Smithc406cb72013-01-17 01:17:56 +00007353 UK_ModAsValue,
7354 /// A modification of an object which is not sequenced before the value
7355 /// computation of the expression, such as n++.
7356 UK_ModAsSideEffect,
7357
7358 UK_Count = UK_ModAsSideEffect + 1
7359 };
7360
7361 struct Usage {
Craig Topperc3ec1492014-05-26 06:22:03 +00007362 Usage() : Use(nullptr), Seq() {}
Richard Smithc406cb72013-01-17 01:17:56 +00007363 Expr *Use;
7364 SequenceTree::Seq Seq;
7365 };
7366
7367 struct UsageInfo {
7368 UsageInfo() : Diagnosed(false) {}
7369 Usage Uses[UK_Count];
7370 /// Have we issued a diagnostic for this variable already?
7371 bool Diagnosed;
7372 };
7373 typedef llvm::SmallDenseMap<Object, UsageInfo, 16> UsageInfoMap;
7374
7375 Sema &SemaRef;
7376 /// Sequenced regions within the expression.
7377 SequenceTree Tree;
7378 /// Declaration modifications and references which we have seen.
7379 UsageInfoMap UsageMap;
7380 /// The region we are currently within.
7381 SequenceTree::Seq Region;
7382 /// Filled in with declarations which were modified as a side-effect
7383 /// (that is, post-increment operations).
Robert Wilhelmb869a8f2013-08-10 12:33:24 +00007384 SmallVectorImpl<std::pair<Object, Usage> > *ModAsSideEffect;
Richard Smithd33f5202013-01-17 23:18:09 +00007385 /// Expressions to check later. We defer checking these to reduce
7386 /// stack usage.
Robert Wilhelmb869a8f2013-08-10 12:33:24 +00007387 SmallVectorImpl<Expr *> &WorkList;
Richard Smithc406cb72013-01-17 01:17:56 +00007388
7389 /// RAII object wrapping the visitation of a sequenced subexpression of an
7390 /// expression. At the end of this process, the side-effects of the evaluation
7391 /// become sequenced with respect to the value computation of the result, so
7392 /// we downgrade any UK_ModAsSideEffect within the evaluation to
7393 /// UK_ModAsValue.
7394 struct SequencedSubexpression {
7395 SequencedSubexpression(SequenceChecker &Self)
7396 : Self(Self), OldModAsSideEffect(Self.ModAsSideEffect) {
7397 Self.ModAsSideEffect = &ModAsSideEffect;
7398 }
7399 ~SequencedSubexpression() {
Richard Smithe8efd992014-12-03 01:05:50 +00007400 for (auto MI = ModAsSideEffect.rbegin(), ME = ModAsSideEffect.rend();
7401 MI != ME; ++MI) {
7402 UsageInfo &U = Self.UsageMap[MI->first];
7403 auto &SideEffectUsage = U.Uses[UK_ModAsSideEffect];
7404 Self.addUsage(U, MI->first, SideEffectUsage.Use, UK_ModAsValue);
7405 SideEffectUsage = MI->second;
Richard Smithc406cb72013-01-17 01:17:56 +00007406 }
7407 Self.ModAsSideEffect = OldModAsSideEffect;
7408 }
7409
7410 SequenceChecker &Self;
Robert Wilhelmb869a8f2013-08-10 12:33:24 +00007411 SmallVector<std::pair<Object, Usage>, 4> ModAsSideEffect;
7412 SmallVectorImpl<std::pair<Object, Usage> > *OldModAsSideEffect;
Richard Smithc406cb72013-01-17 01:17:56 +00007413 };
7414
Richard Smith40238f02013-06-20 22:21:56 +00007415 /// RAII object wrapping the visitation of a subexpression which we might
7416 /// choose to evaluate as a constant. If any subexpression is evaluated and
7417 /// found to be non-constant, this allows us to suppress the evaluation of
7418 /// the outer expression.
7419 class EvaluationTracker {
7420 public:
7421 EvaluationTracker(SequenceChecker &Self)
7422 : Self(Self), Prev(Self.EvalTracker), EvalOK(true) {
7423 Self.EvalTracker = this;
7424 }
7425 ~EvaluationTracker() {
7426 Self.EvalTracker = Prev;
7427 if (Prev)
7428 Prev->EvalOK &= EvalOK;
7429 }
7430
7431 bool evaluate(const Expr *E, bool &Result) {
7432 if (!EvalOK || E->isValueDependent())
7433 return false;
7434 EvalOK = E->EvaluateAsBooleanCondition(Result, Self.SemaRef.Context);
7435 return EvalOK;
7436 }
7437
7438 private:
7439 SequenceChecker &Self;
7440 EvaluationTracker *Prev;
7441 bool EvalOK;
7442 } *EvalTracker;
7443
Richard Smithc406cb72013-01-17 01:17:56 +00007444 /// \brief Find the object which is produced by the specified expression,
7445 /// if any.
7446 Object getObject(Expr *E, bool Mod) const {
7447 E = E->IgnoreParenCasts();
7448 if (UnaryOperator *UO = dyn_cast<UnaryOperator>(E)) {
7449 if (Mod && (UO->getOpcode() == UO_PreInc || UO->getOpcode() == UO_PreDec))
7450 return getObject(UO->getSubExpr(), Mod);
7451 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
7452 if (BO->getOpcode() == BO_Comma)
7453 return getObject(BO->getRHS(), Mod);
7454 if (Mod && BO->isAssignmentOp())
7455 return getObject(BO->getLHS(), Mod);
7456 } else if (MemberExpr *ME = dyn_cast<MemberExpr>(E)) {
7457 // FIXME: Check for more interesting cases, like "x.n = ++x.n".
7458 if (isa<CXXThisExpr>(ME->getBase()->IgnoreParenCasts()))
7459 return ME->getMemberDecl();
7460 } else if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E))
7461 // FIXME: If this is a reference, map through to its value.
7462 return DRE->getDecl();
Craig Topperc3ec1492014-05-26 06:22:03 +00007463 return nullptr;
Richard Smithc406cb72013-01-17 01:17:56 +00007464 }
7465
7466 /// \brief Note that an object was modified or used by an expression.
7467 void addUsage(UsageInfo &UI, Object O, Expr *Ref, UsageKind UK) {
7468 Usage &U = UI.Uses[UK];
7469 if (!U.Use || !Tree.isUnsequenced(Region, U.Seq)) {
7470 if (UK == UK_ModAsSideEffect && ModAsSideEffect)
7471 ModAsSideEffect->push_back(std::make_pair(O, U));
7472 U.Use = Ref;
7473 U.Seq = Region;
7474 }
7475 }
7476 /// \brief Check whether a modification or use conflicts with a prior usage.
7477 void checkUsage(Object O, UsageInfo &UI, Expr *Ref, UsageKind OtherKind,
7478 bool IsModMod) {
7479 if (UI.Diagnosed)
7480 return;
7481
7482 const Usage &U = UI.Uses[OtherKind];
7483 if (!U.Use || !Tree.isUnsequenced(Region, U.Seq))
7484 return;
7485
7486 Expr *Mod = U.Use;
7487 Expr *ModOrUse = Ref;
7488 if (OtherKind == UK_Use)
7489 std::swap(Mod, ModOrUse);
7490
7491 SemaRef.Diag(Mod->getExprLoc(),
7492 IsModMod ? diag::warn_unsequenced_mod_mod
7493 : diag::warn_unsequenced_mod_use)
7494 << O << SourceRange(ModOrUse->getExprLoc());
7495 UI.Diagnosed = true;
7496 }
7497
7498 void notePreUse(Object O, Expr *Use) {
7499 UsageInfo &U = UsageMap[O];
7500 // Uses conflict with other modifications.
7501 checkUsage(O, U, Use, UK_ModAsValue, false);
7502 }
7503 void notePostUse(Object O, Expr *Use) {
7504 UsageInfo &U = UsageMap[O];
7505 checkUsage(O, U, Use, UK_ModAsSideEffect, false);
7506 addUsage(U, O, Use, UK_Use);
7507 }
7508
7509 void notePreMod(Object O, Expr *Mod) {
7510 UsageInfo &U = UsageMap[O];
7511 // Modifications conflict with other modifications and with uses.
7512 checkUsage(O, U, Mod, UK_ModAsValue, true);
7513 checkUsage(O, U, Mod, UK_Use, false);
7514 }
7515 void notePostMod(Object O, Expr *Use, UsageKind UK) {
7516 UsageInfo &U = UsageMap[O];
7517 checkUsage(O, U, Use, UK_ModAsSideEffect, true);
7518 addUsage(U, O, Use, UK);
7519 }
7520
7521public:
Robert Wilhelmb869a8f2013-08-10 12:33:24 +00007522 SequenceChecker(Sema &S, Expr *E, SmallVectorImpl<Expr *> &WorkList)
Craig Topperc3ec1492014-05-26 06:22:03 +00007523 : Base(S.Context), SemaRef(S), Region(Tree.root()),
7524 ModAsSideEffect(nullptr), WorkList(WorkList), EvalTracker(nullptr) {
Richard Smithc406cb72013-01-17 01:17:56 +00007525 Visit(E);
7526 }
7527
7528 void VisitStmt(Stmt *S) {
7529 // Skip all statements which aren't expressions for now.
7530 }
7531
7532 void VisitExpr(Expr *E) {
7533 // By default, just recurse to evaluated subexpressions.
Richard Smithe3dbfe02013-06-30 10:40:20 +00007534 Base::VisitStmt(E);
Richard Smithc406cb72013-01-17 01:17:56 +00007535 }
7536
7537 void VisitCastExpr(CastExpr *E) {
7538 Object O = Object();
7539 if (E->getCastKind() == CK_LValueToRValue)
7540 O = getObject(E->getSubExpr(), false);
7541
7542 if (O)
7543 notePreUse(O, E);
7544 VisitExpr(E);
7545 if (O)
7546 notePostUse(O, E);
7547 }
7548
7549 void VisitBinComma(BinaryOperator *BO) {
7550 // C++11 [expr.comma]p1:
7551 // Every value computation and side effect associated with the left
7552 // expression is sequenced before every value computation and side
7553 // effect associated with the right expression.
7554 SequenceTree::Seq LHS = Tree.allocate(Region);
7555 SequenceTree::Seq RHS = Tree.allocate(Region);
7556 SequenceTree::Seq OldRegion = Region;
7557
7558 {
7559 SequencedSubexpression SeqLHS(*this);
7560 Region = LHS;
7561 Visit(BO->getLHS());
7562 }
7563
7564 Region = RHS;
7565 Visit(BO->getRHS());
7566
7567 Region = OldRegion;
7568
7569 // Forget that LHS and RHS are sequenced. They are both unsequenced
7570 // with respect to other stuff.
7571 Tree.merge(LHS);
7572 Tree.merge(RHS);
7573 }
7574
7575 void VisitBinAssign(BinaryOperator *BO) {
7576 // The modification is sequenced after the value computation of the LHS
7577 // and RHS, so check it before inspecting the operands and update the
7578 // map afterwards.
7579 Object O = getObject(BO->getLHS(), true);
7580 if (!O)
7581 return VisitExpr(BO);
7582
7583 notePreMod(O, BO);
7584
7585 // C++11 [expr.ass]p7:
7586 // E1 op= E2 is equivalent to E1 = E1 op E2, except that E1 is evaluated
7587 // only once.
7588 //
7589 // Therefore, for a compound assignment operator, O is considered used
7590 // everywhere except within the evaluation of E1 itself.
7591 if (isa<CompoundAssignOperator>(BO))
7592 notePreUse(O, BO);
7593
7594 Visit(BO->getLHS());
7595
7596 if (isa<CompoundAssignOperator>(BO))
7597 notePostUse(O, BO);
7598
7599 Visit(BO->getRHS());
7600
Richard Smith83e37bee2013-06-26 23:16:51 +00007601 // C++11 [expr.ass]p1:
7602 // the assignment is sequenced [...] before the value computation of the
7603 // assignment expression.
7604 // C11 6.5.16/3 has no such rule.
7605 notePostMod(O, BO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue
7606 : UK_ModAsSideEffect);
Richard Smithc406cb72013-01-17 01:17:56 +00007607 }
7608 void VisitCompoundAssignOperator(CompoundAssignOperator *CAO) {
7609 VisitBinAssign(CAO);
7610 }
7611
7612 void VisitUnaryPreInc(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); }
7613 void VisitUnaryPreDec(UnaryOperator *UO) { VisitUnaryPreIncDec(UO); }
7614 void VisitUnaryPreIncDec(UnaryOperator *UO) {
7615 Object O = getObject(UO->getSubExpr(), true);
7616 if (!O)
7617 return VisitExpr(UO);
7618
7619 notePreMod(O, UO);
7620 Visit(UO->getSubExpr());
Richard Smith83e37bee2013-06-26 23:16:51 +00007621 // C++11 [expr.pre.incr]p1:
7622 // the expression ++x is equivalent to x+=1
7623 notePostMod(O, UO, SemaRef.getLangOpts().CPlusPlus ? UK_ModAsValue
7624 : UK_ModAsSideEffect);
Richard Smithc406cb72013-01-17 01:17:56 +00007625 }
7626
7627 void VisitUnaryPostInc(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); }
7628 void VisitUnaryPostDec(UnaryOperator *UO) { VisitUnaryPostIncDec(UO); }
7629 void VisitUnaryPostIncDec(UnaryOperator *UO) {
7630 Object O = getObject(UO->getSubExpr(), true);
7631 if (!O)
7632 return VisitExpr(UO);
7633
7634 notePreMod(O, UO);
7635 Visit(UO->getSubExpr());
7636 notePostMod(O, UO, UK_ModAsSideEffect);
7637 }
7638
7639 /// Don't visit the RHS of '&&' or '||' if it might not be evaluated.
7640 void VisitBinLOr(BinaryOperator *BO) {
7641 // The side-effects of the LHS of an '&&' are sequenced before the
7642 // value computation of the RHS, and hence before the value computation
7643 // of the '&&' itself, unless the LHS evaluates to zero. We treat them
7644 // as if they were unconditionally sequenced.
Richard Smith40238f02013-06-20 22:21:56 +00007645 EvaluationTracker Eval(*this);
Richard Smithc406cb72013-01-17 01:17:56 +00007646 {
7647 SequencedSubexpression Sequenced(*this);
7648 Visit(BO->getLHS());
7649 }
7650
7651 bool Result;
Richard Smith40238f02013-06-20 22:21:56 +00007652 if (Eval.evaluate(BO->getLHS(), Result)) {
Richard Smith01a7fba2013-01-17 22:06:26 +00007653 if (!Result)
7654 Visit(BO->getRHS());
7655 } else {
7656 // Check for unsequenced operations in the RHS, treating it as an
7657 // entirely separate evaluation.
7658 //
7659 // FIXME: If there are operations in the RHS which are unsequenced
7660 // with respect to operations outside the RHS, and those operations
7661 // are unconditionally evaluated, diagnose them.
Richard Smithd33f5202013-01-17 23:18:09 +00007662 WorkList.push_back(BO->getRHS());
Richard Smith01a7fba2013-01-17 22:06:26 +00007663 }
Richard Smithc406cb72013-01-17 01:17:56 +00007664 }
7665 void VisitBinLAnd(BinaryOperator *BO) {
Richard Smith40238f02013-06-20 22:21:56 +00007666 EvaluationTracker Eval(*this);
Richard Smithc406cb72013-01-17 01:17:56 +00007667 {
7668 SequencedSubexpression Sequenced(*this);
7669 Visit(BO->getLHS());
7670 }
7671
7672 bool Result;
Richard Smith40238f02013-06-20 22:21:56 +00007673 if (Eval.evaluate(BO->getLHS(), Result)) {
Richard Smith01a7fba2013-01-17 22:06:26 +00007674 if (Result)
7675 Visit(BO->getRHS());
7676 } else {
Richard Smithd33f5202013-01-17 23:18:09 +00007677 WorkList.push_back(BO->getRHS());
Richard Smith01a7fba2013-01-17 22:06:26 +00007678 }
Richard Smithc406cb72013-01-17 01:17:56 +00007679 }
7680
7681 // Only visit the condition, unless we can be sure which subexpression will
7682 // be chosen.
7683 void VisitAbstractConditionalOperator(AbstractConditionalOperator *CO) {
Richard Smith40238f02013-06-20 22:21:56 +00007684 EvaluationTracker Eval(*this);
Richard Smith83e37bee2013-06-26 23:16:51 +00007685 {
7686 SequencedSubexpression Sequenced(*this);
7687 Visit(CO->getCond());
7688 }
Richard Smithc406cb72013-01-17 01:17:56 +00007689
7690 bool Result;
Richard Smith40238f02013-06-20 22:21:56 +00007691 if (Eval.evaluate(CO->getCond(), Result))
Richard Smithc406cb72013-01-17 01:17:56 +00007692 Visit(Result ? CO->getTrueExpr() : CO->getFalseExpr());
Richard Smith01a7fba2013-01-17 22:06:26 +00007693 else {
Richard Smithd33f5202013-01-17 23:18:09 +00007694 WorkList.push_back(CO->getTrueExpr());
7695 WorkList.push_back(CO->getFalseExpr());
Richard Smith01a7fba2013-01-17 22:06:26 +00007696 }
Richard Smithc406cb72013-01-17 01:17:56 +00007697 }
7698
Richard Smithe3dbfe02013-06-30 10:40:20 +00007699 void VisitCallExpr(CallExpr *CE) {
7700 // C++11 [intro.execution]p15:
7701 // When calling a function [...], every value computation and side effect
7702 // associated with any argument expression, or with the postfix expression
7703 // designating the called function, is sequenced before execution of every
7704 // expression or statement in the body of the function [and thus before
7705 // the value computation of its result].
7706 SequencedSubexpression Sequenced(*this);
7707 Base::VisitCallExpr(CE);
7708
7709 // FIXME: CXXNewExpr and CXXDeleteExpr implicitly call functions.
7710 }
7711
Richard Smithc406cb72013-01-17 01:17:56 +00007712 void VisitCXXConstructExpr(CXXConstructExpr *CCE) {
Richard Smithe3dbfe02013-06-30 10:40:20 +00007713 // This is a call, so all subexpressions are sequenced before the result.
7714 SequencedSubexpression Sequenced(*this);
7715
Richard Smithc406cb72013-01-17 01:17:56 +00007716 if (!CCE->isListInitialization())
7717 return VisitExpr(CCE);
7718
7719 // In C++11, list initializations are sequenced.
Robert Wilhelmb869a8f2013-08-10 12:33:24 +00007720 SmallVector<SequenceTree::Seq, 32> Elts;
Richard Smithc406cb72013-01-17 01:17:56 +00007721 SequenceTree::Seq Parent = Region;
7722 for (CXXConstructExpr::arg_iterator I = CCE->arg_begin(),
7723 E = CCE->arg_end();
7724 I != E; ++I) {
7725 Region = Tree.allocate(Parent);
7726 Elts.push_back(Region);
7727 Visit(*I);
7728 }
7729
7730 // Forget that the initializers are sequenced.
7731 Region = Parent;
7732 for (unsigned I = 0; I < Elts.size(); ++I)
7733 Tree.merge(Elts[I]);
7734 }
7735
7736 void VisitInitListExpr(InitListExpr *ILE) {
7737 if (!SemaRef.getLangOpts().CPlusPlus11)
7738 return VisitExpr(ILE);
7739
7740 // In C++11, list initializations are sequenced.
Robert Wilhelmb869a8f2013-08-10 12:33:24 +00007741 SmallVector<SequenceTree::Seq, 32> Elts;
Richard Smithc406cb72013-01-17 01:17:56 +00007742 SequenceTree::Seq Parent = Region;
7743 for (unsigned I = 0; I < ILE->getNumInits(); ++I) {
7744 Expr *E = ILE->getInit(I);
7745 if (!E) continue;
7746 Region = Tree.allocate(Parent);
7747 Elts.push_back(Region);
7748 Visit(E);
7749 }
7750
7751 // Forget that the initializers are sequenced.
7752 Region = Parent;
7753 for (unsigned I = 0; I < Elts.size(); ++I)
7754 Tree.merge(Elts[I]);
7755 }
7756};
7757}
7758
7759void Sema::CheckUnsequencedOperations(Expr *E) {
Robert Wilhelmb869a8f2013-08-10 12:33:24 +00007760 SmallVector<Expr *, 8> WorkList;
Richard Smithd33f5202013-01-17 23:18:09 +00007761 WorkList.push_back(E);
7762 while (!WorkList.empty()) {
Robert Wilhelm25284cc2013-08-23 16:11:15 +00007763 Expr *Item = WorkList.pop_back_val();
Richard Smithd33f5202013-01-17 23:18:09 +00007764 SequenceChecker(*this, Item, WorkList);
7765 }
Richard Smithc406cb72013-01-17 01:17:56 +00007766}
7767
Fariborz Jahaniane735ff92013-01-24 22:11:45 +00007768void Sema::CheckCompletedExpr(Expr *E, SourceLocation CheckLoc,
7769 bool IsConstexpr) {
Richard Smithc406cb72013-01-17 01:17:56 +00007770 CheckImplicitConversions(E, CheckLoc);
7771 CheckUnsequencedOperations(E);
Fariborz Jahaniane735ff92013-01-24 22:11:45 +00007772 if (!IsConstexpr && !E->isValueDependent())
7773 CheckForIntOverflow(E);
Richard Smithc406cb72013-01-17 01:17:56 +00007774}
7775
John McCall1f425642010-11-11 03:21:53 +00007776void Sema::CheckBitFieldInitialization(SourceLocation InitLoc,
7777 FieldDecl *BitField,
7778 Expr *Init) {
7779 (void) AnalyzeBitFieldAssignment(*this, BitField, Init, InitLoc);
7780}
7781
David Majnemer61a5bbf2015-04-07 22:08:51 +00007782static void diagnoseArrayStarInParamType(Sema &S, QualType PType,
7783 SourceLocation Loc) {
7784 if (!PType->isVariablyModifiedType())
7785 return;
7786 if (const auto *PointerTy = dyn_cast<PointerType>(PType)) {
7787 diagnoseArrayStarInParamType(S, PointerTy->getPointeeType(), Loc);
7788 return;
7789 }
David Majnemerdf8f73f2015-04-09 19:53:25 +00007790 if (const auto *ReferenceTy = dyn_cast<ReferenceType>(PType)) {
7791 diagnoseArrayStarInParamType(S, ReferenceTy->getPointeeType(), Loc);
7792 return;
7793 }
David Majnemer61a5bbf2015-04-07 22:08:51 +00007794 if (const auto *ParenTy = dyn_cast<ParenType>(PType)) {
7795 diagnoseArrayStarInParamType(S, ParenTy->getInnerType(), Loc);
7796 return;
7797 }
7798
7799 const ArrayType *AT = S.Context.getAsArrayType(PType);
7800 if (!AT)
7801 return;
7802
7803 if (AT->getSizeModifier() != ArrayType::Star) {
7804 diagnoseArrayStarInParamType(S, AT->getElementType(), Loc);
7805 return;
7806 }
7807
7808 S.Diag(Loc, diag::err_array_star_in_function_definition);
7809}
7810
Mike Stump0c2ec772010-01-21 03:59:47 +00007811/// CheckParmsForFunctionDef - Check that the parameters of the given
7812/// function are appropriate for the definition of a function. This
7813/// takes care of any checks that cannot be performed on the
7814/// declaration itself, e.g., that the types of each of the function
7815/// parameters are complete.
Reid Kleckner5a115802013-06-24 14:38:26 +00007816bool Sema::CheckParmsForFunctionDef(ParmVarDecl *const *P,
7817 ParmVarDecl *const *PEnd,
Douglas Gregorb524d902010-11-01 18:37:59 +00007818 bool CheckParameterNames) {
Mike Stump0c2ec772010-01-21 03:59:47 +00007819 bool HasInvalidParm = false;
Douglas Gregorb524d902010-11-01 18:37:59 +00007820 for (; P != PEnd; ++P) {
7821 ParmVarDecl *Param = *P;
7822
Mike Stump0c2ec772010-01-21 03:59:47 +00007823 // C99 6.7.5.3p4: the parameters in a parameter type list in a
7824 // function declarator that is part of a function definition of
7825 // that function shall not have incomplete type.
7826 //
7827 // This is also C++ [dcl.fct]p6.
7828 if (!Param->isInvalidDecl() &&
7829 RequireCompleteType(Param->getLocation(), Param->getType(),
Douglas Gregor7bfb2d02012-05-04 16:32:21 +00007830 diag::err_typecheck_decl_incomplete_type)) {
Mike Stump0c2ec772010-01-21 03:59:47 +00007831 Param->setInvalidDecl();
7832 HasInvalidParm = true;
7833 }
7834
7835 // C99 6.9.1p5: If the declarator includes a parameter type list, the
7836 // declaration of each parameter shall include an identifier.
Douglas Gregorb524d902010-11-01 18:37:59 +00007837 if (CheckParameterNames &&
Craig Topperc3ec1492014-05-26 06:22:03 +00007838 Param->getIdentifier() == nullptr &&
Mike Stump0c2ec772010-01-21 03:59:47 +00007839 !Param->isImplicit() &&
David Blaikiebbafb8a2012-03-11 07:00:24 +00007840 !getLangOpts().CPlusPlus)
Mike Stump0c2ec772010-01-21 03:59:47 +00007841 Diag(Param->getLocation(), diag::err_parameter_name_omitted);
Sam Weinigdeb55d52010-02-01 05:02:49 +00007842
7843 // C99 6.7.5.3p12:
7844 // If the function declarator is not part of a definition of that
7845 // function, parameters may have incomplete type and may use the [*]
7846 // notation in their sequences of declarator specifiers to specify
7847 // variable length array types.
7848 QualType PType = Param->getOriginalType();
David Majnemer61a5bbf2015-04-07 22:08:51 +00007849 // FIXME: This diagnostic should point the '[*]' if source-location
7850 // information is added for it.
7851 diagnoseArrayStarInParamType(*this, PType, Param->getLocation());
Reid Kleckner23f4c4b2013-06-21 12:45:15 +00007852
7853 // MSVC destroys objects passed by value in the callee. Therefore a
7854 // function definition which takes such a parameter must be able to call the
Hans Wennborg0f3c10c2014-01-13 17:23:24 +00007855 // object's destructor. However, we don't perform any direct access check
7856 // on the dtor.
Reid Kleckner739756c2013-12-04 19:23:12 +00007857 if (getLangOpts().CPlusPlus && Context.getTargetInfo()
7858 .getCXXABI()
7859 .areArgsDestroyedLeftToRightInCallee()) {
Hans Wennborg13ac4bd2014-01-13 19:24:31 +00007860 if (!Param->isInvalidDecl()) {
7861 if (const RecordType *RT = Param->getType()->getAs<RecordType>()) {
7862 CXXRecordDecl *ClassDecl = cast<CXXRecordDecl>(RT->getDecl());
7863 if (!ClassDecl->isInvalidDecl() &&
7864 !ClassDecl->hasIrrelevantDestructor() &&
7865 !ClassDecl->isDependentContext()) {
7866 CXXDestructorDecl *Destructor = LookupDestructor(ClassDecl);
7867 MarkFunctionReferenced(Param->getLocation(), Destructor);
7868 DiagnoseUseOfDecl(Destructor, Param->getLocation());
7869 }
Hans Wennborg0f3c10c2014-01-13 17:23:24 +00007870 }
7871 }
Reid Kleckner23f4c4b2013-06-21 12:45:15 +00007872 }
Mike Stump0c2ec772010-01-21 03:59:47 +00007873 }
7874
7875 return HasInvalidParm;
7876}
John McCall2b5c1b22010-08-12 21:44:57 +00007877
7878/// CheckCastAlign - Implements -Wcast-align, which warns when a
7879/// pointer cast increases the alignment requirements.
7880void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) {
7881 // This is actually a lot of work to potentially be doing on every
7882 // cast; don't do it if we're ignoring -Wcast_align (as is the default).
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00007883 if (getDiagnostics().isIgnored(diag::warn_cast_align, TRange.getBegin()))
John McCall2b5c1b22010-08-12 21:44:57 +00007884 return;
7885
7886 // Ignore dependent types.
7887 if (T->isDependentType() || Op->getType()->isDependentType())
7888 return;
7889
7890 // Require that the destination be a pointer type.
7891 const PointerType *DestPtr = T->getAs<PointerType>();
7892 if (!DestPtr) return;
7893
7894 // If the destination has alignment 1, we're done.
7895 QualType DestPointee = DestPtr->getPointeeType();
7896 if (DestPointee->isIncompleteType()) return;
7897 CharUnits DestAlign = Context.getTypeAlignInChars(DestPointee);
7898 if (DestAlign.isOne()) return;
7899
7900 // Require that the source be a pointer type.
7901 const PointerType *SrcPtr = Op->getType()->getAs<PointerType>();
7902 if (!SrcPtr) return;
7903 QualType SrcPointee = SrcPtr->getPointeeType();
7904
7905 // Whitelist casts from cv void*. We already implicitly
7906 // whitelisted casts to cv void*, since they have alignment 1.
7907 // Also whitelist casts involving incomplete types, which implicitly
7908 // includes 'void'.
7909 if (SrcPointee->isIncompleteType()) return;
7910
7911 CharUnits SrcAlign = Context.getTypeAlignInChars(SrcPointee);
7912 if (SrcAlign >= DestAlign) return;
7913
7914 Diag(TRange.getBegin(), diag::warn_cast_align)
7915 << Op->getType() << T
7916 << static_cast<unsigned>(SrcAlign.getQuantity())
7917 << static_cast<unsigned>(DestAlign.getQuantity())
7918 << TRange << Op->getSourceRange();
7919}
7920
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00007921static const Type* getElementType(const Expr *BaseExpr) {
7922 const Type* EltType = BaseExpr->getType().getTypePtr();
7923 if (EltType->isAnyPointerType())
7924 return EltType->getPointeeType().getTypePtr();
7925 else if (EltType->isArrayType())
7926 return EltType->getBaseElementTypeUnsafe();
7927 return EltType;
7928}
7929
Chandler Carruth28389f02011-08-05 09:10:50 +00007930/// \brief Check whether this array fits the idiom of a size-one tail padded
7931/// array member of a struct.
7932///
7933/// We avoid emitting out-of-bounds access warnings for such arrays as they are
7934/// commonly used to emulate flexible arrays in C89 code.
7935static bool IsTailPaddedMemberArray(Sema &S, llvm::APInt Size,
7936 const NamedDecl *ND) {
7937 if (Size != 1 || !ND) return false;
7938
7939 const FieldDecl *FD = dyn_cast<FieldDecl>(ND);
7940 if (!FD) return false;
7941
7942 // Don't consider sizes resulting from macro expansions or template argument
7943 // substitution to form C89 tail-padded arrays.
Sean Callanan06a48a62012-05-04 18:22:53 +00007944
7945 TypeSourceInfo *TInfo = FD->getTypeSourceInfo();
Ted Kremenek7ebb4932012-05-09 05:35:08 +00007946 while (TInfo) {
7947 TypeLoc TL = TInfo->getTypeLoc();
7948 // Look through typedefs.
David Blaikie6adc78e2013-02-18 22:06:02 +00007949 if (TypedefTypeLoc TTL = TL.getAs<TypedefTypeLoc>()) {
7950 const TypedefNameDecl *TDL = TTL.getTypedefNameDecl();
Ted Kremenek7ebb4932012-05-09 05:35:08 +00007951 TInfo = TDL->getTypeSourceInfo();
7952 continue;
7953 }
David Blaikie6adc78e2013-02-18 22:06:02 +00007954 if (ConstantArrayTypeLoc CTL = TL.getAs<ConstantArrayTypeLoc>()) {
7955 const Expr *SizeExpr = dyn_cast<IntegerLiteral>(CTL.getSizeExpr());
Chad Rosier70299922013-02-06 00:58:34 +00007956 if (!SizeExpr || SizeExpr->getExprLoc().isMacroID())
7957 return false;
7958 }
Ted Kremenek7ebb4932012-05-09 05:35:08 +00007959 break;
Sean Callanan06a48a62012-05-04 18:22:53 +00007960 }
Chandler Carruth28389f02011-08-05 09:10:50 +00007961
7962 const RecordDecl *RD = dyn_cast<RecordDecl>(FD->getDeclContext());
Matt Beaumont-Gayc93b4892011-11-29 22:43:53 +00007963 if (!RD) return false;
7964 if (RD->isUnion()) return false;
7965 if (const CXXRecordDecl *CRD = dyn_cast<CXXRecordDecl>(RD)) {
7966 if (!CRD->isStandardLayout()) return false;
7967 }
Chandler Carruth28389f02011-08-05 09:10:50 +00007968
Benjamin Kramer8c543672011-08-06 03:04:42 +00007969 // See if this is the last field decl in the record.
7970 const Decl *D = FD;
7971 while ((D = D->getNextDeclInContext()))
7972 if (isa<FieldDecl>(D))
7973 return false;
7974 return true;
Chandler Carruth28389f02011-08-05 09:10:50 +00007975}
7976
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00007977void Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr,
Matt Beaumont-Gay5533a552011-12-14 16:02:15 +00007978 const ArraySubscriptExpr *ASE,
Richard Smith13f67182011-12-16 19:31:14 +00007979 bool AllowOnePastEnd, bool IndexNegated) {
Eli Friedman84e6e5c2012-02-27 21:21:40 +00007980 IndexExpr = IndexExpr->IgnoreParenImpCasts();
Matt Beaumont-Gay5533a552011-12-14 16:02:15 +00007981 if (IndexExpr->isValueDependent())
7982 return;
7983
Matt Beaumont-Gay9d570c42011-12-12 22:35:02 +00007984 const Type *EffectiveType = getElementType(BaseExpr);
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00007985 BaseExpr = BaseExpr->IgnoreParenCasts();
Chandler Carruth2a666fc2011-02-17 20:55:08 +00007986 const ConstantArrayType *ArrayTy =
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00007987 Context.getAsConstantArrayType(BaseExpr->getType());
Chandler Carruth2a666fc2011-02-17 20:55:08 +00007988 if (!ArrayTy)
Ted Kremenek64699be2011-02-16 01:57:07 +00007989 return;
Chandler Carruth1af88f12011-02-17 21:10:52 +00007990
Chandler Carruth2a666fc2011-02-17 20:55:08 +00007991 llvm::APSInt index;
Matt Beaumont-Gay5533a552011-12-14 16:02:15 +00007992 if (!IndexExpr->EvaluateAsInt(index, Context))
Ted Kremenek64699be2011-02-16 01:57:07 +00007993 return;
Richard Smith13f67182011-12-16 19:31:14 +00007994 if (IndexNegated)
7995 index = -index;
Ted Kremenek108b2d52011-02-16 04:01:44 +00007996
Craig Topperc3ec1492014-05-26 06:22:03 +00007997 const NamedDecl *ND = nullptr;
Chandler Carruth126b1552011-08-05 08:07:29 +00007998 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
7999 ND = dyn_cast<NamedDecl>(DRE->getDecl());
Chandler Carruth28389f02011-08-05 09:10:50 +00008000 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
Chandler Carruth126b1552011-08-05 08:07:29 +00008001 ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
Chandler Carruth126b1552011-08-05 08:07:29 +00008002
Ted Kremeneke4b316c2011-02-23 23:06:04 +00008003 if (index.isUnsigned() || !index.isNegative()) {
Ted Kremeneka7ced2c2011-02-18 02:27:00 +00008004 llvm::APInt size = ArrayTy->getSize();
Chandler Carruth1af88f12011-02-17 21:10:52 +00008005 if (!size.isStrictlyPositive())
8006 return;
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008007
8008 const Type* BaseType = getElementType(BaseExpr);
Nico Weber7c299802011-09-17 22:59:41 +00008009 if (BaseType != EffectiveType) {
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008010 // Make sure we're comparing apples to apples when comparing index to size
8011 uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType);
8012 uint64_t array_typesize = Context.getTypeSize(BaseType);
Kaelyn Uhrain0fb0bb12011-08-10 19:47:25 +00008013 // Handle ptrarith_typesize being zero, such as when casting to void*
Kaelyn Uhraine5353762011-08-10 18:49:28 +00008014 if (!ptrarith_typesize) ptrarith_typesize = 1;
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008015 if (ptrarith_typesize != array_typesize) {
8016 // There's a cast to a different size type involved
8017 uint64_t ratio = array_typesize / ptrarith_typesize;
8018 // TODO: Be smarter about handling cases where array_typesize is not a
8019 // multiple of ptrarith_typesize
8020 if (ptrarith_typesize * ratio == array_typesize)
8021 size *= llvm::APInt(size.getBitWidth(), ratio);
8022 }
8023 }
8024
Chandler Carruth2a666fc2011-02-17 20:55:08 +00008025 if (size.getBitWidth() > index.getBitWidth())
Eli Friedman84e6e5c2012-02-27 21:21:40 +00008026 index = index.zext(size.getBitWidth());
Ted Kremeneka7ced2c2011-02-18 02:27:00 +00008027 else if (size.getBitWidth() < index.getBitWidth())
Eli Friedman84e6e5c2012-02-27 21:21:40 +00008028 size = size.zext(index.getBitWidth());
Ted Kremeneka7ced2c2011-02-18 02:27:00 +00008029
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008030 // For array subscripting the index must be less than size, but for pointer
8031 // arithmetic also allow the index (offset) to be equal to size since
8032 // computing the next address after the end of the array is legal and
8033 // commonly done e.g. in C++ iterators and range-based for loops.
Eli Friedman84e6e5c2012-02-27 21:21:40 +00008034 if (AllowOnePastEnd ? index.ule(size) : index.ult(size))
Chandler Carruth126b1552011-08-05 08:07:29 +00008035 return;
8036
8037 // Also don't warn for arrays of size 1 which are members of some
8038 // structure. These are often used to approximate flexible arrays in C89
8039 // code.
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008040 if (IsTailPaddedMemberArray(*this, size, ND))
Ted Kremenek108b2d52011-02-16 04:01:44 +00008041 return;
Chandler Carruth2a666fc2011-02-17 20:55:08 +00008042
Matt Beaumont-Gay5533a552011-12-14 16:02:15 +00008043 // Suppress the warning if the subscript expression (as identified by the
8044 // ']' location) and the index expression are both from macro expansions
8045 // within a system header.
8046 if (ASE) {
8047 SourceLocation RBracketLoc = SourceMgr.getSpellingLoc(
8048 ASE->getRBracketLoc());
8049 if (SourceMgr.isInSystemHeader(RBracketLoc)) {
8050 SourceLocation IndexLoc = SourceMgr.getSpellingLoc(
8051 IndexExpr->getLocStart());
Eli Friedman5ba37d52013-08-22 00:27:10 +00008052 if (SourceMgr.isWrittenInSameFile(RBracketLoc, IndexLoc))
Matt Beaumont-Gay5533a552011-12-14 16:02:15 +00008053 return;
8054 }
8055 }
8056
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008057 unsigned DiagID = diag::warn_ptr_arith_exceeds_bounds;
Matt Beaumont-Gay5533a552011-12-14 16:02:15 +00008058 if (ASE)
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008059 DiagID = diag::warn_array_index_exceeds_bounds;
8060
8061 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
8062 PDiag(DiagID) << index.toString(10, true)
8063 << size.toString(10, true)
8064 << (unsigned)size.getLimitedValue(~0U)
8065 << IndexExpr->getSourceRange());
Chandler Carruth2a666fc2011-02-17 20:55:08 +00008066 } else {
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008067 unsigned DiagID = diag::warn_array_index_precedes_bounds;
Matt Beaumont-Gay5533a552011-12-14 16:02:15 +00008068 if (!ASE) {
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008069 DiagID = diag::warn_ptr_arith_precedes_bounds;
8070 if (index.isNegative()) index = -index;
8071 }
8072
8073 DiagRuntimeBehavior(BaseExpr->getLocStart(), BaseExpr,
8074 PDiag(DiagID) << index.toString(10, true)
8075 << IndexExpr->getSourceRange());
Ted Kremenek64699be2011-02-16 01:57:07 +00008076 }
Chandler Carruth1af88f12011-02-17 21:10:52 +00008077
Matt Beaumont-Gayb2339822011-11-29 19:27:11 +00008078 if (!ND) {
8079 // Try harder to find a NamedDecl to point at in the note.
8080 while (const ArraySubscriptExpr *ASE =
8081 dyn_cast<ArraySubscriptExpr>(BaseExpr))
8082 BaseExpr = ASE->getBase()->IgnoreParenCasts();
8083 if (const DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(BaseExpr))
8084 ND = dyn_cast<NamedDecl>(DRE->getDecl());
8085 if (const MemberExpr *ME = dyn_cast<MemberExpr>(BaseExpr))
8086 ND = dyn_cast<NamedDecl>(ME->getMemberDecl());
8087 }
8088
Chandler Carruth1af88f12011-02-17 21:10:52 +00008089 if (ND)
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008090 DiagRuntimeBehavior(ND->getLocStart(), BaseExpr,
8091 PDiag(diag::note_array_index_out_of_bounds)
8092 << ND->getDeclName());
Ted Kremenek64699be2011-02-16 01:57:07 +00008093}
8094
Ted Kremenekdf26df72011-03-01 18:41:00 +00008095void Sema::CheckArrayAccess(const Expr *expr) {
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008096 int AllowOnePastEnd = 0;
8097 while (expr) {
8098 expr = expr->IgnoreParenImpCasts();
Ted Kremenekdf26df72011-03-01 18:41:00 +00008099 switch (expr->getStmtClass()) {
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008100 case Stmt::ArraySubscriptExprClass: {
8101 const ArraySubscriptExpr *ASE = cast<ArraySubscriptExpr>(expr);
Matt Beaumont-Gay5533a552011-12-14 16:02:15 +00008102 CheckArrayAccess(ASE->getBase(), ASE->getIdx(), ASE,
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008103 AllowOnePastEnd > 0);
Ted Kremenekdf26df72011-03-01 18:41:00 +00008104 return;
Kaelyn Uhrain2e7aa5a2011-08-05 23:18:04 +00008105 }
8106 case Stmt::UnaryOperatorClass: {
8107 // Only unwrap the * and & unary operators
8108 const UnaryOperator *UO = cast<UnaryOperator>(expr);
8109 expr = UO->getSubExpr();
8110 switch (UO->getOpcode()) {
8111 case UO_AddrOf:
8112 AllowOnePastEnd++;
8113 break;
8114 case UO_Deref:
8115 AllowOnePastEnd--;
8116 break;
8117 default:
8118 return;
8119 }
8120 break;
8121 }
Ted Kremenekdf26df72011-03-01 18:41:00 +00008122 case Stmt::ConditionalOperatorClass: {
8123 const ConditionalOperator *cond = cast<ConditionalOperator>(expr);
8124 if (const Expr *lhs = cond->getLHS())
8125 CheckArrayAccess(lhs);
8126 if (const Expr *rhs = cond->getRHS())
8127 CheckArrayAccess(rhs);
8128 return;
8129 }
8130 default:
8131 return;
8132 }
Peter Collingbourne91147592011-04-15 00:35:48 +00008133 }
Ted Kremenekdf26df72011-03-01 18:41:00 +00008134}
John McCall31168b02011-06-15 23:02:42 +00008135
8136//===--- CHECK: Objective-C retain cycles ----------------------------------//
8137
8138namespace {
8139 struct RetainCycleOwner {
Craig Topperc3ec1492014-05-26 06:22:03 +00008140 RetainCycleOwner() : Variable(nullptr), Indirect(false) {}
John McCall31168b02011-06-15 23:02:42 +00008141 VarDecl *Variable;
8142 SourceRange Range;
8143 SourceLocation Loc;
8144 bool Indirect;
8145
8146 void setLocsFrom(Expr *e) {
8147 Loc = e->getExprLoc();
8148 Range = e->getSourceRange();
8149 }
8150 };
8151}
8152
8153/// Consider whether capturing the given variable can possibly lead to
8154/// a retain cycle.
8155static bool considerVariable(VarDecl *var, Expr *ref, RetainCycleOwner &owner) {
Sylvestre Ledru33b5baf2012-09-27 10:16:10 +00008156 // In ARC, it's captured strongly iff the variable has __strong
John McCall31168b02011-06-15 23:02:42 +00008157 // lifetime. In MRR, it's captured strongly if the variable is
8158 // __block and has an appropriate type.
8159 if (var->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
8160 return false;
8161
8162 owner.Variable = var;
Jordan Rosefa9e4ba2012-09-15 02:48:31 +00008163 if (ref)
8164 owner.setLocsFrom(ref);
John McCall31168b02011-06-15 23:02:42 +00008165 return true;
8166}
8167
Fariborz Jahanianedbc3452012-01-10 19:28:26 +00008168static bool findRetainCycleOwner(Sema &S, Expr *e, RetainCycleOwner &owner) {
John McCall31168b02011-06-15 23:02:42 +00008169 while (true) {
8170 e = e->IgnoreParens();
8171 if (CastExpr *cast = dyn_cast<CastExpr>(e)) {
8172 switch (cast->getCastKind()) {
8173 case CK_BitCast:
8174 case CK_LValueBitCast:
8175 case CK_LValueToRValue:
John McCall2d637d22011-09-10 06:18:15 +00008176 case CK_ARCReclaimReturnedObject:
John McCall31168b02011-06-15 23:02:42 +00008177 e = cast->getSubExpr();
8178 continue;
8179
John McCall31168b02011-06-15 23:02:42 +00008180 default:
8181 return false;
8182 }
8183 }
8184
8185 if (ObjCIvarRefExpr *ref = dyn_cast<ObjCIvarRefExpr>(e)) {
8186 ObjCIvarDecl *ivar = ref->getDecl();
8187 if (ivar->getType().getObjCLifetime() != Qualifiers::OCL_Strong)
8188 return false;
8189
8190 // Try to find a retain cycle in the base.
Fariborz Jahanianedbc3452012-01-10 19:28:26 +00008191 if (!findRetainCycleOwner(S, ref->getBase(), owner))
John McCall31168b02011-06-15 23:02:42 +00008192 return false;
8193
8194 if (ref->isFreeIvar()) owner.setLocsFrom(ref);
8195 owner.Indirect = true;
8196 return true;
8197 }
8198
8199 if (DeclRefExpr *ref = dyn_cast<DeclRefExpr>(e)) {
8200 VarDecl *var = dyn_cast<VarDecl>(ref->getDecl());
8201 if (!var) return false;
8202 return considerVariable(var, ref, owner);
8203 }
8204
John McCall31168b02011-06-15 23:02:42 +00008205 if (MemberExpr *member = dyn_cast<MemberExpr>(e)) {
8206 if (member->isArrow()) return false;
8207
8208 // Don't count this as an indirect ownership.
8209 e = member->getBase();
8210 continue;
8211 }
8212
John McCallfe96e0b2011-11-06 09:01:30 +00008213 if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(e)) {
8214 // Only pay attention to pseudo-objects on property references.
8215 ObjCPropertyRefExpr *pre
8216 = dyn_cast<ObjCPropertyRefExpr>(pseudo->getSyntacticForm()
8217 ->IgnoreParens());
8218 if (!pre) return false;
8219 if (pre->isImplicitProperty()) return false;
8220 ObjCPropertyDecl *property = pre->getExplicitProperty();
8221 if (!property->isRetaining() &&
8222 !(property->getPropertyIvarDecl() &&
8223 property->getPropertyIvarDecl()->getType()
8224 .getObjCLifetime() == Qualifiers::OCL_Strong))
8225 return false;
8226
8227 owner.Indirect = true;
Fariborz Jahanianedbc3452012-01-10 19:28:26 +00008228 if (pre->isSuperReceiver()) {
8229 owner.Variable = S.getCurMethodDecl()->getSelfDecl();
8230 if (!owner.Variable)
8231 return false;
8232 owner.Loc = pre->getLocation();
8233 owner.Range = pre->getSourceRange();
8234 return true;
8235 }
John McCallfe96e0b2011-11-06 09:01:30 +00008236 e = const_cast<Expr*>(cast<OpaqueValueExpr>(pre->getBase())
8237 ->getSourceExpr());
8238 continue;
8239 }
8240
John McCall31168b02011-06-15 23:02:42 +00008241 // Array ivars?
8242
8243 return false;
8244 }
8245}
8246
8247namespace {
8248 struct FindCaptureVisitor : EvaluatedExprVisitor<FindCaptureVisitor> {
8249 FindCaptureVisitor(ASTContext &Context, VarDecl *variable)
8250 : EvaluatedExprVisitor<FindCaptureVisitor>(Context),
Fariborz Jahanian8df9e242014-06-12 20:57:14 +00008251 Context(Context), Variable(variable), Capturer(nullptr),
8252 VarWillBeReased(false) {}
8253 ASTContext &Context;
John McCall31168b02011-06-15 23:02:42 +00008254 VarDecl *Variable;
8255 Expr *Capturer;
Fariborz Jahanian8df9e242014-06-12 20:57:14 +00008256 bool VarWillBeReased;
John McCall31168b02011-06-15 23:02:42 +00008257
8258 void VisitDeclRefExpr(DeclRefExpr *ref) {
8259 if (ref->getDecl() == Variable && !Capturer)
8260 Capturer = ref;
8261 }
8262
John McCall31168b02011-06-15 23:02:42 +00008263 void VisitObjCIvarRefExpr(ObjCIvarRefExpr *ref) {
8264 if (Capturer) return;
8265 Visit(ref->getBase());
8266 if (Capturer && ref->isFreeIvar())
8267 Capturer = ref;
8268 }
8269
8270 void VisitBlockExpr(BlockExpr *block) {
8271 // Look inside nested blocks
8272 if (block->getBlockDecl()->capturesVariable(Variable))
8273 Visit(block->getBlockDecl()->getBody());
8274 }
Fariborz Jahanian0e337542012-08-31 20:04:47 +00008275
8276 void VisitOpaqueValueExpr(OpaqueValueExpr *OVE) {
8277 if (Capturer) return;
8278 if (OVE->getSourceExpr())
8279 Visit(OVE->getSourceExpr());
8280 }
Fariborz Jahanian8df9e242014-06-12 20:57:14 +00008281 void VisitBinaryOperator(BinaryOperator *BinOp) {
8282 if (!Variable || VarWillBeReased || BinOp->getOpcode() != BO_Assign)
8283 return;
8284 Expr *LHS = BinOp->getLHS();
8285 if (const DeclRefExpr *DRE = dyn_cast_or_null<DeclRefExpr>(LHS)) {
8286 if (DRE->getDecl() != Variable)
8287 return;
8288 if (Expr *RHS = BinOp->getRHS()) {
8289 RHS = RHS->IgnoreParenCasts();
8290 llvm::APSInt Value;
8291 VarWillBeReased =
8292 (RHS && RHS->isIntegerConstantExpr(Value, Context) && Value == 0);
8293 }
8294 }
8295 }
John McCall31168b02011-06-15 23:02:42 +00008296 };
8297}
8298
8299/// Check whether the given argument is a block which captures a
8300/// variable.
8301static Expr *findCapturingExpr(Sema &S, Expr *e, RetainCycleOwner &owner) {
8302 assert(owner.Variable && owner.Loc.isValid());
8303
8304 e = e->IgnoreParenCasts();
Jordan Rose67e887c2012-09-17 17:54:30 +00008305
8306 // Look through [^{...} copy] and Block_copy(^{...}).
8307 if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(e)) {
8308 Selector Cmd = ME->getSelector();
8309 if (Cmd.isUnarySelector() && Cmd.getNameForSlot(0) == "copy") {
8310 e = ME->getInstanceReceiver();
8311 if (!e)
Craig Topperc3ec1492014-05-26 06:22:03 +00008312 return nullptr;
Jordan Rose67e887c2012-09-17 17:54:30 +00008313 e = e->IgnoreParenCasts();
8314 }
8315 } else if (CallExpr *CE = dyn_cast<CallExpr>(e)) {
8316 if (CE->getNumArgs() == 1) {
8317 FunctionDecl *Fn = dyn_cast_or_null<FunctionDecl>(CE->getCalleeDecl());
Ted Kremenekb67c6cc2012-10-02 04:36:54 +00008318 if (Fn) {
8319 const IdentifierInfo *FnI = Fn->getIdentifier();
8320 if (FnI && FnI->isStr("_Block_copy")) {
8321 e = CE->getArg(0)->IgnoreParenCasts();
8322 }
8323 }
Jordan Rose67e887c2012-09-17 17:54:30 +00008324 }
8325 }
8326
John McCall31168b02011-06-15 23:02:42 +00008327 BlockExpr *block = dyn_cast<BlockExpr>(e);
8328 if (!block || !block->getBlockDecl()->capturesVariable(owner.Variable))
Craig Topperc3ec1492014-05-26 06:22:03 +00008329 return nullptr;
John McCall31168b02011-06-15 23:02:42 +00008330
8331 FindCaptureVisitor visitor(S.Context, owner.Variable);
8332 visitor.Visit(block->getBlockDecl()->getBody());
Fariborz Jahanian8df9e242014-06-12 20:57:14 +00008333 return visitor.VarWillBeReased ? nullptr : visitor.Capturer;
John McCall31168b02011-06-15 23:02:42 +00008334}
8335
8336static void diagnoseRetainCycle(Sema &S, Expr *capturer,
8337 RetainCycleOwner &owner) {
8338 assert(capturer);
8339 assert(owner.Variable && owner.Loc.isValid());
8340
8341 S.Diag(capturer->getExprLoc(), diag::warn_arc_retain_cycle)
8342 << owner.Variable << capturer->getSourceRange();
8343 S.Diag(owner.Loc, diag::note_arc_retain_cycle_owner)
8344 << owner.Indirect << owner.Range;
8345}
8346
8347/// Check for a keyword selector that starts with the word 'add' or
8348/// 'set'.
8349static bool isSetterLikeSelector(Selector sel) {
8350 if (sel.isUnarySelector()) return false;
8351
Chris Lattner0e62c1c2011-07-23 10:55:15 +00008352 StringRef str = sel.getNameForSlot(0);
John McCall31168b02011-06-15 23:02:42 +00008353 while (!str.empty() && str.front() == '_') str = str.substr(1);
Ted Kremenek764d63a2011-12-01 00:59:21 +00008354 if (str.startswith("set"))
John McCall31168b02011-06-15 23:02:42 +00008355 str = str.substr(3);
Ted Kremenek764d63a2011-12-01 00:59:21 +00008356 else if (str.startswith("add")) {
8357 // Specially whitelist 'addOperationWithBlock:'.
8358 if (sel.getNumArgs() == 1 && str.startswith("addOperationWithBlock"))
8359 return false;
8360 str = str.substr(3);
8361 }
John McCall31168b02011-06-15 23:02:42 +00008362 else
8363 return false;
8364
8365 if (str.empty()) return true;
Jordan Rosea7d03842013-02-08 22:30:41 +00008366 return !isLowercase(str.front());
John McCall31168b02011-06-15 23:02:42 +00008367}
8368
Benjamin Kramer3a743452015-03-09 15:03:32 +00008369static Optional<int> GetNSMutableArrayArgumentIndex(Sema &S,
8370 ObjCMessageExpr *Message) {
Alex Denisove1d882c2015-03-04 17:55:52 +00008371 if (S.NSMutableArrayPointer.isNull()) {
8372 IdentifierInfo *NSMutableArrayId =
8373 S.NSAPIObj->getNSClassId(NSAPI::ClassId_NSMutableArray);
8374 NamedDecl *IF = S.LookupSingleName(S.TUScope, NSMutableArrayId,
8375 Message->getLocStart(),
8376 Sema::LookupOrdinaryName);
8377 ObjCInterfaceDecl *InterfaceDecl = dyn_cast_or_null<ObjCInterfaceDecl>(IF);
8378 if (!InterfaceDecl) {
8379 return None;
8380 }
8381 QualType NSMutableArrayObject =
8382 S.Context.getObjCInterfaceType(InterfaceDecl);
8383 S.NSMutableArrayPointer =
8384 S.Context.getObjCObjectPointerType(NSMutableArrayObject);
8385 }
8386
8387 if (S.NSMutableArrayPointer != Message->getReceiverType()) {
8388 return None;
8389 }
8390
8391 Selector Sel = Message->getSelector();
8392
8393 Optional<NSAPI::NSArrayMethodKind> MKOpt =
8394 S.NSAPIObj->getNSArrayMethodKind(Sel);
8395 if (!MKOpt) {
8396 return None;
8397 }
8398
8399 NSAPI::NSArrayMethodKind MK = *MKOpt;
8400
8401 switch (MK) {
8402 case NSAPI::NSMutableArr_addObject:
8403 case NSAPI::NSMutableArr_insertObjectAtIndex:
8404 case NSAPI::NSMutableArr_setObjectAtIndexedSubscript:
8405 return 0;
8406 case NSAPI::NSMutableArr_replaceObjectAtIndex:
8407 return 1;
8408
8409 default:
8410 return None;
8411 }
8412
8413 return None;
8414}
8415
8416static
8417Optional<int> GetNSMutableDictionaryArgumentIndex(Sema &S,
8418 ObjCMessageExpr *Message) {
8419
8420 if (S.NSMutableDictionaryPointer.isNull()) {
8421 IdentifierInfo *NSMutableDictionaryId =
8422 S.NSAPIObj->getNSClassId(NSAPI::ClassId_NSMutableDictionary);
8423 NamedDecl *IF = S.LookupSingleName(S.TUScope, NSMutableDictionaryId,
8424 Message->getLocStart(),
8425 Sema::LookupOrdinaryName);
8426 ObjCInterfaceDecl *InterfaceDecl = dyn_cast_or_null<ObjCInterfaceDecl>(IF);
8427 if (!InterfaceDecl) {
8428 return None;
8429 }
8430 QualType NSMutableDictionaryObject =
8431 S.Context.getObjCInterfaceType(InterfaceDecl);
8432 S.NSMutableDictionaryPointer =
8433 S.Context.getObjCObjectPointerType(NSMutableDictionaryObject);
8434 }
8435
8436 if (S.NSMutableDictionaryPointer != Message->getReceiverType()) {
8437 return None;
8438 }
8439
8440 Selector Sel = Message->getSelector();
8441
8442 Optional<NSAPI::NSDictionaryMethodKind> MKOpt =
8443 S.NSAPIObj->getNSDictionaryMethodKind(Sel);
8444 if (!MKOpt) {
8445 return None;
8446 }
8447
8448 NSAPI::NSDictionaryMethodKind MK = *MKOpt;
8449
8450 switch (MK) {
8451 case NSAPI::NSMutableDict_setObjectForKey:
8452 case NSAPI::NSMutableDict_setValueForKey:
8453 case NSAPI::NSMutableDict_setObjectForKeyedSubscript:
8454 return 0;
8455
8456 default:
8457 return None;
8458 }
8459
8460 return None;
8461}
8462
8463static Optional<int> GetNSSetArgumentIndex(Sema &S, ObjCMessageExpr *Message) {
8464
8465 ObjCInterfaceDecl *InterfaceDecl;
8466 if (S.NSMutableSetPointer.isNull()) {
8467 IdentifierInfo *NSMutableSetId =
8468 S.NSAPIObj->getNSClassId(NSAPI::ClassId_NSMutableSet);
8469 NamedDecl *IF = S.LookupSingleName(S.TUScope, NSMutableSetId,
8470 Message->getLocStart(),
8471 Sema::LookupOrdinaryName);
8472 InterfaceDecl = dyn_cast_or_null<ObjCInterfaceDecl>(IF);
8473 if (InterfaceDecl) {
8474 QualType NSMutableSetObject =
8475 S.Context.getObjCInterfaceType(InterfaceDecl);
8476 S.NSMutableSetPointer =
8477 S.Context.getObjCObjectPointerType(NSMutableSetObject);
8478 }
8479 }
8480
8481 if (S.NSCountedSetPointer.isNull()) {
8482 IdentifierInfo *NSCountedSetId =
8483 S.NSAPIObj->getNSClassId(NSAPI::ClassId_NSCountedSet);
8484 NamedDecl *IF = S.LookupSingleName(S.TUScope, NSCountedSetId,
8485 Message->getLocStart(),
8486 Sema::LookupOrdinaryName);
8487 InterfaceDecl = dyn_cast_or_null<ObjCInterfaceDecl>(IF);
8488 if (InterfaceDecl) {
8489 QualType NSCountedSetObject =
8490 S.Context.getObjCInterfaceType(InterfaceDecl);
8491 S.NSCountedSetPointer =
8492 S.Context.getObjCObjectPointerType(NSCountedSetObject);
8493 }
8494 }
8495
8496 if (S.NSMutableOrderedSetPointer.isNull()) {
8497 IdentifierInfo *NSOrderedSetId =
8498 S.NSAPIObj->getNSClassId(NSAPI::ClassId_NSMutableOrderedSet);
8499 NamedDecl *IF = S.LookupSingleName(S.TUScope, NSOrderedSetId,
8500 Message->getLocStart(),
8501 Sema::LookupOrdinaryName);
8502 InterfaceDecl = dyn_cast_or_null<ObjCInterfaceDecl>(IF);
8503 if (InterfaceDecl) {
8504 QualType NSOrderedSetObject =
8505 S.Context.getObjCInterfaceType(InterfaceDecl);
8506 S.NSMutableOrderedSetPointer =
8507 S.Context.getObjCObjectPointerType(NSOrderedSetObject);
8508 }
8509 }
8510
8511 QualType ReceiverType = Message->getReceiverType();
8512
8513 bool IsMutableSet = !S.NSMutableSetPointer.isNull() &&
8514 ReceiverType == S.NSMutableSetPointer;
8515 bool IsMutableOrderedSet = !S.NSMutableOrderedSetPointer.isNull() &&
8516 ReceiverType == S.NSMutableOrderedSetPointer;
8517 bool IsCountedSet = !S.NSCountedSetPointer.isNull() &&
8518 ReceiverType == S.NSCountedSetPointer;
8519
8520 if (!IsMutableSet && !IsMutableOrderedSet && !IsCountedSet) {
8521 return None;
8522 }
8523
8524 Selector Sel = Message->getSelector();
8525
8526 Optional<NSAPI::NSSetMethodKind> MKOpt = S.NSAPIObj->getNSSetMethodKind(Sel);
8527 if (!MKOpt) {
8528 return None;
8529 }
8530
8531 NSAPI::NSSetMethodKind MK = *MKOpt;
8532
8533 switch (MK) {
8534 case NSAPI::NSMutableSet_addObject:
8535 case NSAPI::NSOrderedSet_setObjectAtIndex:
8536 case NSAPI::NSOrderedSet_setObjectAtIndexedSubscript:
8537 case NSAPI::NSOrderedSet_insertObjectAtIndex:
8538 return 0;
8539 case NSAPI::NSOrderedSet_replaceObjectAtIndexWithObject:
8540 return 1;
8541 }
8542
8543 return None;
8544}
8545
8546void Sema::CheckObjCCircularContainer(ObjCMessageExpr *Message) {
8547 if (!Message->isInstanceMessage()) {
8548 return;
8549 }
8550
8551 Optional<int> ArgOpt;
8552
8553 if (!(ArgOpt = GetNSMutableArrayArgumentIndex(*this, Message)) &&
8554 !(ArgOpt = GetNSMutableDictionaryArgumentIndex(*this, Message)) &&
8555 !(ArgOpt = GetNSSetArgumentIndex(*this, Message))) {
8556 return;
8557 }
8558
8559 int ArgIndex = *ArgOpt;
8560
8561 Expr *Receiver = Message->getInstanceReceiver()->IgnoreImpCasts();
8562 if (OpaqueValueExpr *OE = dyn_cast<OpaqueValueExpr>(Receiver)) {
8563 Receiver = OE->getSourceExpr()->IgnoreImpCasts();
8564 }
8565
8566 Expr *Arg = Message->getArg(ArgIndex)->IgnoreImpCasts();
8567 if (OpaqueValueExpr *OE = dyn_cast<OpaqueValueExpr>(Arg)) {
8568 Arg = OE->getSourceExpr()->IgnoreImpCasts();
8569 }
8570
8571 if (DeclRefExpr *ReceiverRE = dyn_cast<DeclRefExpr>(Receiver)) {
8572 if (DeclRefExpr *ArgRE = dyn_cast<DeclRefExpr>(Arg)) {
8573 if (ReceiverRE->getDecl() == ArgRE->getDecl()) {
8574 ValueDecl *Decl = ReceiverRE->getDecl();
8575 Diag(Message->getSourceRange().getBegin(),
8576 diag::warn_objc_circular_container)
8577 << Decl->getName();
8578 Diag(Decl->getLocation(),
8579 diag::note_objc_circular_container_declared_here)
8580 << Decl->getName();
8581 }
8582 }
8583 } else if (ObjCIvarRefExpr *IvarRE = dyn_cast<ObjCIvarRefExpr>(Receiver)) {
8584 if (ObjCIvarRefExpr *IvarArgRE = dyn_cast<ObjCIvarRefExpr>(Arg)) {
8585 if (IvarRE->getDecl() == IvarArgRE->getDecl()) {
8586 ObjCIvarDecl *Decl = IvarRE->getDecl();
8587 Diag(Message->getSourceRange().getBegin(),
8588 diag::warn_objc_circular_container)
8589 << Decl->getName();
8590 Diag(Decl->getLocation(),
8591 diag::note_objc_circular_container_declared_here)
8592 << Decl->getName();
8593 }
8594 }
8595 }
8596
8597}
8598
John McCall31168b02011-06-15 23:02:42 +00008599/// Check a message send to see if it's likely to cause a retain cycle.
8600void Sema::checkRetainCycles(ObjCMessageExpr *msg) {
8601 // Only check instance methods whose selector looks like a setter.
8602 if (!msg->isInstanceMessage() || !isSetterLikeSelector(msg->getSelector()))
8603 return;
8604
8605 // Try to find a variable that the receiver is strongly owned by.
8606 RetainCycleOwner owner;
8607 if (msg->getReceiverKind() == ObjCMessageExpr::Instance) {
Fariborz Jahanianedbc3452012-01-10 19:28:26 +00008608 if (!findRetainCycleOwner(*this, msg->getInstanceReceiver(), owner))
John McCall31168b02011-06-15 23:02:42 +00008609 return;
8610 } else {
8611 assert(msg->getReceiverKind() == ObjCMessageExpr::SuperInstance);
8612 owner.Variable = getCurMethodDecl()->getSelfDecl();
8613 owner.Loc = msg->getSuperLoc();
8614 owner.Range = msg->getSuperLoc();
8615 }
8616
8617 // Check whether the receiver is captured by any of the arguments.
8618 for (unsigned i = 0, e = msg->getNumArgs(); i != e; ++i)
8619 if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner))
8620 return diagnoseRetainCycle(*this, capturer, owner);
8621}
8622
8623/// Check a property assign to see if it's likely to cause a retain cycle.
8624void Sema::checkRetainCycles(Expr *receiver, Expr *argument) {
8625 RetainCycleOwner owner;
Fariborz Jahanianedbc3452012-01-10 19:28:26 +00008626 if (!findRetainCycleOwner(*this, receiver, owner))
John McCall31168b02011-06-15 23:02:42 +00008627 return;
8628
8629 if (Expr *capturer = findCapturingExpr(*this, argument, owner))
8630 diagnoseRetainCycle(*this, capturer, owner);
8631}
8632
Jordan Rosefa9e4ba2012-09-15 02:48:31 +00008633void Sema::checkRetainCycles(VarDecl *Var, Expr *Init) {
8634 RetainCycleOwner Owner;
Craig Topperc3ec1492014-05-26 06:22:03 +00008635 if (!considerVariable(Var, /*DeclRefExpr=*/nullptr, Owner))
Jordan Rosefa9e4ba2012-09-15 02:48:31 +00008636 return;
8637
8638 // Because we don't have an expression for the variable, we have to set the
8639 // location explicitly here.
8640 Owner.Loc = Var->getLocation();
8641 Owner.Range = Var->getSourceRange();
8642
8643 if (Expr *Capturer = findCapturingExpr(*this, Init, Owner))
8644 diagnoseRetainCycle(*this, Capturer, Owner);
8645}
8646
Ted Kremenek9304da92012-12-21 08:04:28 +00008647static bool checkUnsafeAssignLiteral(Sema &S, SourceLocation Loc,
8648 Expr *RHS, bool isProperty) {
8649 // Check if RHS is an Objective-C object literal, which also can get
8650 // immediately zapped in a weak reference. Note that we explicitly
8651 // allow ObjCStringLiterals, since those are designed to never really die.
8652 RHS = RHS->IgnoreParenImpCasts();
Ted Kremenek44c2a2a2012-12-21 21:59:39 +00008653
Ted Kremenek64873352012-12-21 22:46:35 +00008654 // This enum needs to match with the 'select' in
8655 // warn_objc_arc_literal_assign (off-by-1).
8656 Sema::ObjCLiteralKind Kind = S.CheckLiteralKind(RHS);
8657 if (Kind == Sema::LK_String || Kind == Sema::LK_None)
8658 return false;
Ted Kremenek44c2a2a2012-12-21 21:59:39 +00008659
8660 S.Diag(Loc, diag::warn_arc_literal_assign)
Ted Kremenek64873352012-12-21 22:46:35 +00008661 << (unsigned) Kind
Ted Kremenek9304da92012-12-21 08:04:28 +00008662 << (isProperty ? 0 : 1)
8663 << RHS->getSourceRange();
Ted Kremenek44c2a2a2012-12-21 21:59:39 +00008664
8665 return true;
Ted Kremenek9304da92012-12-21 08:04:28 +00008666}
8667
Ted Kremenekc1f014a2012-12-21 19:45:30 +00008668static bool checkUnsafeAssignObject(Sema &S, SourceLocation Loc,
8669 Qualifiers::ObjCLifetime LT,
8670 Expr *RHS, bool isProperty) {
8671 // Strip off any implicit cast added to get to the one ARC-specific.
8672 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
8673 if (cast->getCastKind() == CK_ARCConsumeObject) {
8674 S.Diag(Loc, diag::warn_arc_retained_assign)
8675 << (LT == Qualifiers::OCL_ExplicitNone)
8676 << (isProperty ? 0 : 1)
8677 << RHS->getSourceRange();
8678 return true;
8679 }
8680 RHS = cast->getSubExpr();
8681 }
8682
8683 if (LT == Qualifiers::OCL_Weak &&
8684 checkUnsafeAssignLiteral(S, Loc, RHS, isProperty))
8685 return true;
8686
8687 return false;
8688}
8689
Ted Kremenekb36234d2012-12-21 08:04:20 +00008690bool Sema::checkUnsafeAssigns(SourceLocation Loc,
8691 QualType LHS, Expr *RHS) {
8692 Qualifiers::ObjCLifetime LT = LHS.getObjCLifetime();
8693
8694 if (LT != Qualifiers::OCL_Weak && LT != Qualifiers::OCL_ExplicitNone)
8695 return false;
8696
8697 if (checkUnsafeAssignObject(*this, Loc, LT, RHS, false))
8698 return true;
8699
8700 return false;
8701}
8702
Fariborz Jahanian5f98da02011-06-24 18:25:34 +00008703void Sema::checkUnsafeExprAssigns(SourceLocation Loc,
8704 Expr *LHS, Expr *RHS) {
Fariborz Jahanianc72a8072012-01-17 22:58:16 +00008705 QualType LHSType;
8706 // PropertyRef on LHS type need be directly obtained from
Alp Tokerf6a24ce2013-12-05 16:25:25 +00008707 // its declaration as it has a PseudoType.
Fariborz Jahanianc72a8072012-01-17 22:58:16 +00008708 ObjCPropertyRefExpr *PRE
8709 = dyn_cast<ObjCPropertyRefExpr>(LHS->IgnoreParens());
8710 if (PRE && !PRE->isImplicitProperty()) {
8711 const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
8712 if (PD)
8713 LHSType = PD->getType();
8714 }
8715
8716 if (LHSType.isNull())
8717 LHSType = LHS->getType();
Jordan Rose657b5f42012-09-28 22:21:35 +00008718
8719 Qualifiers::ObjCLifetime LT = LHSType.getObjCLifetime();
8720
8721 if (LT == Qualifiers::OCL_Weak) {
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00008722 if (!Diags.isIgnored(diag::warn_arc_repeated_use_of_weak, Loc))
Jordan Rose657b5f42012-09-28 22:21:35 +00008723 getCurFunction()->markSafeWeakUse(LHS);
8724 }
8725
Fariborz Jahanian5f98da02011-06-24 18:25:34 +00008726 if (checkUnsafeAssigns(Loc, LHSType, RHS))
8727 return;
Jordan Rose657b5f42012-09-28 22:21:35 +00008728
Fariborz Jahanian5f98da02011-06-24 18:25:34 +00008729 // FIXME. Check for other life times.
8730 if (LT != Qualifiers::OCL_None)
8731 return;
8732
Fariborz Jahanianc72a8072012-01-17 22:58:16 +00008733 if (PRE) {
Fariborz Jahanian5f98da02011-06-24 18:25:34 +00008734 if (PRE->isImplicitProperty())
8735 return;
8736 const ObjCPropertyDecl *PD = PRE->getExplicitProperty();
8737 if (!PD)
8738 return;
8739
Bill Wendling44426052012-12-20 19:22:21 +00008740 unsigned Attributes = PD->getPropertyAttributes();
8741 if (Attributes & ObjCPropertyDecl::OBJC_PR_assign) {
Fariborz Jahanianc72a8072012-01-17 22:58:16 +00008742 // when 'assign' attribute was not explicitly specified
8743 // by user, ignore it and rely on property type itself
8744 // for lifetime info.
8745 unsigned AsWrittenAttr = PD->getPropertyAttributesAsWritten();
8746 if (!(AsWrittenAttr & ObjCPropertyDecl::OBJC_PR_assign) &&
8747 LHSType->isObjCRetainableType())
8748 return;
8749
Fariborz Jahanian5f98da02011-06-24 18:25:34 +00008750 while (ImplicitCastExpr *cast = dyn_cast<ImplicitCastExpr>(RHS)) {
John McCall2d637d22011-09-10 06:18:15 +00008751 if (cast->getCastKind() == CK_ARCConsumeObject) {
Fariborz Jahanian5f98da02011-06-24 18:25:34 +00008752 Diag(Loc, diag::warn_arc_retained_property_assign)
8753 << RHS->getSourceRange();
8754 return;
8755 }
8756 RHS = cast->getSubExpr();
8757 }
Fariborz Jahanianc72a8072012-01-17 22:58:16 +00008758 }
Bill Wendling44426052012-12-20 19:22:21 +00008759 else if (Attributes & ObjCPropertyDecl::OBJC_PR_weak) {
Ted Kremenekb36234d2012-12-21 08:04:20 +00008760 if (checkUnsafeAssignObject(*this, Loc, Qualifiers::OCL_Weak, RHS, true))
8761 return;
Fariborz Jahaniandabd1332012-07-06 21:09:27 +00008762 }
Fariborz Jahanian5f98da02011-06-24 18:25:34 +00008763 }
8764}
Dmitri Gribenko800ddf32012-02-14 22:14:32 +00008765
8766//===--- CHECK: Empty statement body (-Wempty-body) ---------------------===//
8767
8768namespace {
8769bool ShouldDiagnoseEmptyStmtBody(const SourceManager &SourceMgr,
8770 SourceLocation StmtLoc,
8771 const NullStmt *Body) {
8772 // Do not warn if the body is a macro that expands to nothing, e.g:
8773 //
8774 // #define CALL(x)
8775 // if (condition)
8776 // CALL(0);
8777 //
8778 if (Body->hasLeadingEmptyMacro())
8779 return false;
8780
8781 // Get line numbers of statement and body.
8782 bool StmtLineInvalid;
Dmitri Gribenkoad80af82015-03-15 01:08:23 +00008783 unsigned StmtLine = SourceMgr.getPresumedLineNumber(StmtLoc,
Dmitri Gribenko800ddf32012-02-14 22:14:32 +00008784 &StmtLineInvalid);
8785 if (StmtLineInvalid)
8786 return false;
8787
8788 bool BodyLineInvalid;
8789 unsigned BodyLine = SourceMgr.getSpellingLineNumber(Body->getSemiLoc(),
8790 &BodyLineInvalid);
8791 if (BodyLineInvalid)
8792 return false;
8793
8794 // Warn if null statement and body are on the same line.
8795 if (StmtLine != BodyLine)
8796 return false;
8797
8798 return true;
8799}
8800} // Unnamed namespace
8801
8802void Sema::DiagnoseEmptyStmtBody(SourceLocation StmtLoc,
8803 const Stmt *Body,
8804 unsigned DiagID) {
8805 // Since this is a syntactic check, don't emit diagnostic for template
8806 // instantiations, this just adds noise.
8807 if (CurrentInstantiationScope)
8808 return;
8809
8810 // The body should be a null statement.
8811 const NullStmt *NBody = dyn_cast<NullStmt>(Body);
8812 if (!NBody)
8813 return;
8814
8815 // Do the usual checks.
8816 if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
8817 return;
8818
8819 Diag(NBody->getSemiLoc(), DiagID);
8820 Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
8821}
8822
8823void Sema::DiagnoseEmptyLoopBody(const Stmt *S,
8824 const Stmt *PossibleBody) {
8825 assert(!CurrentInstantiationScope); // Ensured by caller
8826
8827 SourceLocation StmtLoc;
8828 const Stmt *Body;
8829 unsigned DiagID;
8830 if (const ForStmt *FS = dyn_cast<ForStmt>(S)) {
8831 StmtLoc = FS->getRParenLoc();
8832 Body = FS->getBody();
8833 DiagID = diag::warn_empty_for_body;
8834 } else if (const WhileStmt *WS = dyn_cast<WhileStmt>(S)) {
8835 StmtLoc = WS->getCond()->getSourceRange().getEnd();
8836 Body = WS->getBody();
8837 DiagID = diag::warn_empty_while_body;
8838 } else
8839 return; // Neither `for' nor `while'.
8840
8841 // The body should be a null statement.
8842 const NullStmt *NBody = dyn_cast<NullStmt>(Body);
8843 if (!NBody)
8844 return;
8845
8846 // Skip expensive checks if diagnostic is disabled.
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00008847 if (Diags.isIgnored(DiagID, NBody->getSemiLoc()))
Dmitri Gribenko800ddf32012-02-14 22:14:32 +00008848 return;
8849
8850 // Do the usual checks.
8851 if (!ShouldDiagnoseEmptyStmtBody(SourceMgr, StmtLoc, NBody))
8852 return;
8853
8854 // `for(...);' and `while(...);' are popular idioms, so in order to keep
8855 // noise level low, emit diagnostics only if for/while is followed by a
8856 // CompoundStmt, e.g.:
8857 // for (int i = 0; i < n; i++);
8858 // {
8859 // a(i);
8860 // }
8861 // or if for/while is followed by a statement with more indentation
8862 // than for/while itself:
8863 // for (int i = 0; i < n; i++);
8864 // a(i);
8865 bool ProbableTypo = isa<CompoundStmt>(PossibleBody);
8866 if (!ProbableTypo) {
8867 bool BodyColInvalid;
8868 unsigned BodyCol = SourceMgr.getPresumedColumnNumber(
8869 PossibleBody->getLocStart(),
8870 &BodyColInvalid);
8871 if (BodyColInvalid)
8872 return;
8873
8874 bool StmtColInvalid;
8875 unsigned StmtCol = SourceMgr.getPresumedColumnNumber(
8876 S->getLocStart(),
8877 &StmtColInvalid);
8878 if (StmtColInvalid)
8879 return;
8880
8881 if (BodyCol > StmtCol)
8882 ProbableTypo = true;
8883 }
8884
8885 if (ProbableTypo) {
8886 Diag(NBody->getSemiLoc(), DiagID);
8887 Diag(NBody->getSemiLoc(), diag::note_empty_body_on_separate_line);
8888 }
8889}
Dmitri Gribenkoe4a5a902012-08-17 00:08:38 +00008890
Richard Trieu36d0b2b2015-01-13 02:32:02 +00008891//===--- CHECK: Warn on self move with std::move. -------------------------===//
8892
8893/// DiagnoseSelfMove - Emits a warning if a value is moved to itself.
8894void Sema::DiagnoseSelfMove(const Expr *LHSExpr, const Expr *RHSExpr,
8895 SourceLocation OpLoc) {
8896
8897 if (Diags.isIgnored(diag::warn_sizeof_pointer_expr_memaccess, OpLoc))
8898 return;
8899
8900 if (!ActiveTemplateInstantiations.empty())
8901 return;
8902
8903 // Strip parens and casts away.
8904 LHSExpr = LHSExpr->IgnoreParenImpCasts();
8905 RHSExpr = RHSExpr->IgnoreParenImpCasts();
8906
8907 // Check for a call expression
8908 const CallExpr *CE = dyn_cast<CallExpr>(RHSExpr);
8909 if (!CE || CE->getNumArgs() != 1)
8910 return;
8911
8912 // Check for a call to std::move
8913 const FunctionDecl *FD = CE->getDirectCallee();
8914 if (!FD || !FD->isInStdNamespace() || !FD->getIdentifier() ||
8915 !FD->getIdentifier()->isStr("move"))
8916 return;
8917
8918 // Get argument from std::move
8919 RHSExpr = CE->getArg(0);
8920
8921 const DeclRefExpr *LHSDeclRef = dyn_cast<DeclRefExpr>(LHSExpr);
8922 const DeclRefExpr *RHSDeclRef = dyn_cast<DeclRefExpr>(RHSExpr);
8923
8924 // Two DeclRefExpr's, check that the decls are the same.
8925 if (LHSDeclRef && RHSDeclRef) {
8926 if (!LHSDeclRef->getDecl() || !RHSDeclRef->getDecl())
8927 return;
8928 if (LHSDeclRef->getDecl()->getCanonicalDecl() !=
8929 RHSDeclRef->getDecl()->getCanonicalDecl())
8930 return;
8931
8932 Diag(OpLoc, diag::warn_self_move) << LHSExpr->getType()
8933 << LHSExpr->getSourceRange()
8934 << RHSExpr->getSourceRange();
8935 return;
8936 }
8937
8938 // Member variables require a different approach to check for self moves.
8939 // MemberExpr's are the same if every nested MemberExpr refers to the same
8940 // Decl and that the base Expr's are DeclRefExpr's with the same Decl or
8941 // the base Expr's are CXXThisExpr's.
8942 const Expr *LHSBase = LHSExpr;
8943 const Expr *RHSBase = RHSExpr;
8944 const MemberExpr *LHSME = dyn_cast<MemberExpr>(LHSExpr);
8945 const MemberExpr *RHSME = dyn_cast<MemberExpr>(RHSExpr);
8946 if (!LHSME || !RHSME)
8947 return;
8948
8949 while (LHSME && RHSME) {
8950 if (LHSME->getMemberDecl()->getCanonicalDecl() !=
8951 RHSME->getMemberDecl()->getCanonicalDecl())
8952 return;
8953
8954 LHSBase = LHSME->getBase();
8955 RHSBase = RHSME->getBase();
8956 LHSME = dyn_cast<MemberExpr>(LHSBase);
8957 RHSME = dyn_cast<MemberExpr>(RHSBase);
8958 }
8959
8960 LHSDeclRef = dyn_cast<DeclRefExpr>(LHSBase);
8961 RHSDeclRef = dyn_cast<DeclRefExpr>(RHSBase);
8962 if (LHSDeclRef && RHSDeclRef) {
8963 if (!LHSDeclRef->getDecl() || !RHSDeclRef->getDecl())
8964 return;
8965 if (LHSDeclRef->getDecl()->getCanonicalDecl() !=
8966 RHSDeclRef->getDecl()->getCanonicalDecl())
8967 return;
8968
8969 Diag(OpLoc, diag::warn_self_move) << LHSExpr->getType()
8970 << LHSExpr->getSourceRange()
8971 << RHSExpr->getSourceRange();
8972 return;
8973 }
8974
8975 if (isa<CXXThisExpr>(LHSBase) && isa<CXXThisExpr>(RHSBase))
8976 Diag(OpLoc, diag::warn_self_move) << LHSExpr->getType()
8977 << LHSExpr->getSourceRange()
8978 << RHSExpr->getSourceRange();
8979}
8980
Dmitri Gribenkoe4a5a902012-08-17 00:08:38 +00008981//===--- Layout compatibility ----------------------------------------------//
8982
8983namespace {
8984
8985bool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2);
8986
8987/// \brief Check if two enumeration types are layout-compatible.
8988bool isLayoutCompatible(ASTContext &C, EnumDecl *ED1, EnumDecl *ED2) {
8989 // C++11 [dcl.enum] p8:
8990 // Two enumeration types are layout-compatible if they have the same
8991 // underlying type.
8992 return ED1->isComplete() && ED2->isComplete() &&
8993 C.hasSameType(ED1->getIntegerType(), ED2->getIntegerType());
8994}
8995
8996/// \brief Check if two fields are layout-compatible.
8997bool isLayoutCompatible(ASTContext &C, FieldDecl *Field1, FieldDecl *Field2) {
8998 if (!isLayoutCompatible(C, Field1->getType(), Field2->getType()))
8999 return false;
9000
9001 if (Field1->isBitField() != Field2->isBitField())
9002 return false;
9003
9004 if (Field1->isBitField()) {
9005 // Make sure that the bit-fields are the same length.
9006 unsigned Bits1 = Field1->getBitWidthValue(C);
9007 unsigned Bits2 = Field2->getBitWidthValue(C);
9008
9009 if (Bits1 != Bits2)
9010 return false;
9011 }
9012
9013 return true;
9014}
9015
9016/// \brief Check if two standard-layout structs are layout-compatible.
9017/// (C++11 [class.mem] p17)
9018bool isLayoutCompatibleStruct(ASTContext &C,
9019 RecordDecl *RD1,
9020 RecordDecl *RD2) {
9021 // If both records are C++ classes, check that base classes match.
9022 if (const CXXRecordDecl *D1CXX = dyn_cast<CXXRecordDecl>(RD1)) {
9023 // If one of records is a CXXRecordDecl we are in C++ mode,
9024 // thus the other one is a CXXRecordDecl, too.
9025 const CXXRecordDecl *D2CXX = cast<CXXRecordDecl>(RD2);
9026 // Check number of base classes.
9027 if (D1CXX->getNumBases() != D2CXX->getNumBases())
9028 return false;
9029
9030 // Check the base classes.
9031 for (CXXRecordDecl::base_class_const_iterator
9032 Base1 = D1CXX->bases_begin(),
9033 BaseEnd1 = D1CXX->bases_end(),
9034 Base2 = D2CXX->bases_begin();
9035 Base1 != BaseEnd1;
9036 ++Base1, ++Base2) {
9037 if (!isLayoutCompatible(C, Base1->getType(), Base2->getType()))
9038 return false;
9039 }
9040 } else if (const CXXRecordDecl *D2CXX = dyn_cast<CXXRecordDecl>(RD2)) {
9041 // If only RD2 is a C++ class, it should have zero base classes.
9042 if (D2CXX->getNumBases() > 0)
9043 return false;
9044 }
9045
9046 // Check the fields.
9047 RecordDecl::field_iterator Field2 = RD2->field_begin(),
9048 Field2End = RD2->field_end(),
9049 Field1 = RD1->field_begin(),
9050 Field1End = RD1->field_end();
9051 for ( ; Field1 != Field1End && Field2 != Field2End; ++Field1, ++Field2) {
9052 if (!isLayoutCompatible(C, *Field1, *Field2))
9053 return false;
9054 }
9055 if (Field1 != Field1End || Field2 != Field2End)
9056 return false;
9057
9058 return true;
9059}
9060
9061/// \brief Check if two standard-layout unions are layout-compatible.
9062/// (C++11 [class.mem] p18)
9063bool isLayoutCompatibleUnion(ASTContext &C,
9064 RecordDecl *RD1,
9065 RecordDecl *RD2) {
9066 llvm::SmallPtrSet<FieldDecl *, 8> UnmatchedFields;
Aaron Ballmane8a8bae2014-03-08 20:12:42 +00009067 for (auto *Field2 : RD2->fields())
9068 UnmatchedFields.insert(Field2);
Dmitri Gribenkoe4a5a902012-08-17 00:08:38 +00009069
Aaron Ballmane8a8bae2014-03-08 20:12:42 +00009070 for (auto *Field1 : RD1->fields()) {
Dmitri Gribenkoe4a5a902012-08-17 00:08:38 +00009071 llvm::SmallPtrSet<FieldDecl *, 8>::iterator
9072 I = UnmatchedFields.begin(),
9073 E = UnmatchedFields.end();
9074
9075 for ( ; I != E; ++I) {
Aaron Ballmane8a8bae2014-03-08 20:12:42 +00009076 if (isLayoutCompatible(C, Field1, *I)) {
Dmitri Gribenkoe4a5a902012-08-17 00:08:38 +00009077 bool Result = UnmatchedFields.erase(*I);
9078 (void) Result;
9079 assert(Result);
9080 break;
9081 }
9082 }
9083 if (I == E)
9084 return false;
9085 }
9086
9087 return UnmatchedFields.empty();
9088}
9089
9090bool isLayoutCompatible(ASTContext &C, RecordDecl *RD1, RecordDecl *RD2) {
9091 if (RD1->isUnion() != RD2->isUnion())
9092 return false;
9093
9094 if (RD1->isUnion())
9095 return isLayoutCompatibleUnion(C, RD1, RD2);
9096 else
9097 return isLayoutCompatibleStruct(C, RD1, RD2);
9098}
9099
9100/// \brief Check if two types are layout-compatible in C++11 sense.
9101bool isLayoutCompatible(ASTContext &C, QualType T1, QualType T2) {
9102 if (T1.isNull() || T2.isNull())
9103 return false;
9104
9105 // C++11 [basic.types] p11:
9106 // If two types T1 and T2 are the same type, then T1 and T2 are
9107 // layout-compatible types.
9108 if (C.hasSameType(T1, T2))
9109 return true;
9110
9111 T1 = T1.getCanonicalType().getUnqualifiedType();
9112 T2 = T2.getCanonicalType().getUnqualifiedType();
9113
9114 const Type::TypeClass TC1 = T1->getTypeClass();
9115 const Type::TypeClass TC2 = T2->getTypeClass();
9116
9117 if (TC1 != TC2)
9118 return false;
9119
9120 if (TC1 == Type::Enum) {
9121 return isLayoutCompatible(C,
9122 cast<EnumType>(T1)->getDecl(),
9123 cast<EnumType>(T2)->getDecl());
9124 } else if (TC1 == Type::Record) {
9125 if (!T1->isStandardLayoutType() || !T2->isStandardLayoutType())
9126 return false;
9127
9128 return isLayoutCompatible(C,
9129 cast<RecordType>(T1)->getDecl(),
9130 cast<RecordType>(T2)->getDecl());
9131 }
9132
9133 return false;
9134}
9135}
9136
9137//===--- CHECK: pointer_with_type_tag attribute: datatypes should match ----//
9138
9139namespace {
9140/// \brief Given a type tag expression find the type tag itself.
9141///
9142/// \param TypeExpr Type tag expression, as it appears in user's code.
9143///
9144/// \param VD Declaration of an identifier that appears in a type tag.
9145///
9146/// \param MagicValue Type tag magic value.
9147bool FindTypeTagExpr(const Expr *TypeExpr, const ASTContext &Ctx,
9148 const ValueDecl **VD, uint64_t *MagicValue) {
9149 while(true) {
9150 if (!TypeExpr)
9151 return false;
9152
9153 TypeExpr = TypeExpr->IgnoreParenImpCasts()->IgnoreParenCasts();
9154
9155 switch (TypeExpr->getStmtClass()) {
9156 case Stmt::UnaryOperatorClass: {
9157 const UnaryOperator *UO = cast<UnaryOperator>(TypeExpr);
9158 if (UO->getOpcode() == UO_AddrOf || UO->getOpcode() == UO_Deref) {
9159 TypeExpr = UO->getSubExpr();
9160 continue;
9161 }
9162 return false;
9163 }
9164
9165 case Stmt::DeclRefExprClass: {
9166 const DeclRefExpr *DRE = cast<DeclRefExpr>(TypeExpr);
9167 *VD = DRE->getDecl();
9168 return true;
9169 }
9170
9171 case Stmt::IntegerLiteralClass: {
9172 const IntegerLiteral *IL = cast<IntegerLiteral>(TypeExpr);
9173 llvm::APInt MagicValueAPInt = IL->getValue();
9174 if (MagicValueAPInt.getActiveBits() <= 64) {
9175 *MagicValue = MagicValueAPInt.getZExtValue();
9176 return true;
9177 } else
9178 return false;
9179 }
9180
9181 case Stmt::BinaryConditionalOperatorClass:
9182 case Stmt::ConditionalOperatorClass: {
9183 const AbstractConditionalOperator *ACO =
9184 cast<AbstractConditionalOperator>(TypeExpr);
9185 bool Result;
9186 if (ACO->getCond()->EvaluateAsBooleanCondition(Result, Ctx)) {
9187 if (Result)
9188 TypeExpr = ACO->getTrueExpr();
9189 else
9190 TypeExpr = ACO->getFalseExpr();
9191 continue;
9192 }
9193 return false;
9194 }
9195
9196 case Stmt::BinaryOperatorClass: {
9197 const BinaryOperator *BO = cast<BinaryOperator>(TypeExpr);
9198 if (BO->getOpcode() == BO_Comma) {
9199 TypeExpr = BO->getRHS();
9200 continue;
9201 }
9202 return false;
9203 }
9204
9205 default:
9206 return false;
9207 }
9208 }
9209}
9210
9211/// \brief Retrieve the C type corresponding to type tag TypeExpr.
9212///
9213/// \param TypeExpr Expression that specifies a type tag.
9214///
9215/// \param MagicValues Registered magic values.
9216///
9217/// \param FoundWrongKind Set to true if a type tag was found, but of a wrong
9218/// kind.
9219///
9220/// \param TypeInfo Information about the corresponding C type.
9221///
9222/// \returns true if the corresponding C type was found.
9223bool GetMatchingCType(
9224 const IdentifierInfo *ArgumentKind,
9225 const Expr *TypeExpr, const ASTContext &Ctx,
9226 const llvm::DenseMap<Sema::TypeTagMagicValue,
9227 Sema::TypeTagData> *MagicValues,
9228 bool &FoundWrongKind,
9229 Sema::TypeTagData &TypeInfo) {
9230 FoundWrongKind = false;
9231
9232 // Variable declaration that has type_tag_for_datatype attribute.
Craig Topperc3ec1492014-05-26 06:22:03 +00009233 const ValueDecl *VD = nullptr;
Dmitri Gribenkoe4a5a902012-08-17 00:08:38 +00009234
9235 uint64_t MagicValue;
9236
9237 if (!FindTypeTagExpr(TypeExpr, Ctx, &VD, &MagicValue))
9238 return false;
9239
9240 if (VD) {
Benjamin Kramerae852a62014-02-23 14:34:50 +00009241 if (TypeTagForDatatypeAttr *I = VD->getAttr<TypeTagForDatatypeAttr>()) {
Dmitri Gribenkoe4a5a902012-08-17 00:08:38 +00009242 if (I->getArgumentKind() != ArgumentKind) {
9243 FoundWrongKind = true;
9244 return false;
9245 }
9246 TypeInfo.Type = I->getMatchingCType();
9247 TypeInfo.LayoutCompatible = I->getLayoutCompatible();
9248 TypeInfo.MustBeNull = I->getMustBeNull();
9249 return true;
9250 }
9251 return false;
9252 }
9253
9254 if (!MagicValues)
9255 return false;
9256
9257 llvm::DenseMap<Sema::TypeTagMagicValue,
9258 Sema::TypeTagData>::const_iterator I =
9259 MagicValues->find(std::make_pair(ArgumentKind, MagicValue));
9260 if (I == MagicValues->end())
9261 return false;
9262
9263 TypeInfo = I->second;
9264 return true;
9265}
9266} // unnamed namespace
9267
9268void Sema::RegisterTypeTagForDatatype(const IdentifierInfo *ArgumentKind,
9269 uint64_t MagicValue, QualType Type,
9270 bool LayoutCompatible,
9271 bool MustBeNull) {
9272 if (!TypeTagForDatatypeMagicValues)
9273 TypeTagForDatatypeMagicValues.reset(
9274 new llvm::DenseMap<TypeTagMagicValue, TypeTagData>);
9275
9276 TypeTagMagicValue Magic(ArgumentKind, MagicValue);
9277 (*TypeTagForDatatypeMagicValues)[Magic] =
9278 TypeTagData(Type, LayoutCompatible, MustBeNull);
9279}
9280
9281namespace {
9282bool IsSameCharType(QualType T1, QualType T2) {
9283 const BuiltinType *BT1 = T1->getAs<BuiltinType>();
9284 if (!BT1)
9285 return false;
9286
9287 const BuiltinType *BT2 = T2->getAs<BuiltinType>();
9288 if (!BT2)
9289 return false;
9290
9291 BuiltinType::Kind T1Kind = BT1->getKind();
9292 BuiltinType::Kind T2Kind = BT2->getKind();
9293
9294 return (T1Kind == BuiltinType::SChar && T2Kind == BuiltinType::Char_S) ||
9295 (T1Kind == BuiltinType::UChar && T2Kind == BuiltinType::Char_U) ||
9296 (T1Kind == BuiltinType::Char_U && T2Kind == BuiltinType::UChar) ||
9297 (T1Kind == BuiltinType::Char_S && T2Kind == BuiltinType::SChar);
9298}
9299} // unnamed namespace
9300
9301void Sema::CheckArgumentWithTypeTag(const ArgumentWithTypeTagAttr *Attr,
9302 const Expr * const *ExprArgs) {
9303 const IdentifierInfo *ArgumentKind = Attr->getArgumentKind();
9304 bool IsPointerAttr = Attr->getIsPointer();
9305
9306 const Expr *TypeTagExpr = ExprArgs[Attr->getTypeTagIdx()];
9307 bool FoundWrongKind;
9308 TypeTagData TypeInfo;
9309 if (!GetMatchingCType(ArgumentKind, TypeTagExpr, Context,
9310 TypeTagForDatatypeMagicValues.get(),
9311 FoundWrongKind, TypeInfo)) {
9312 if (FoundWrongKind)
9313 Diag(TypeTagExpr->getExprLoc(),
9314 diag::warn_type_tag_for_datatype_wrong_kind)
9315 << TypeTagExpr->getSourceRange();
9316 return;
9317 }
9318
9319 const Expr *ArgumentExpr = ExprArgs[Attr->getArgumentIdx()];
9320 if (IsPointerAttr) {
9321 // Skip implicit cast of pointer to `void *' (as a function argument).
9322 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgumentExpr))
Dmitri Gribenko5ac744e2012-11-03 16:07:49 +00009323 if (ICE->getType()->isVoidPointerType() &&
Dmitri Gribenkof21203b2012-11-03 22:10:18 +00009324 ICE->getCastKind() == CK_BitCast)
Dmitri Gribenkoe4a5a902012-08-17 00:08:38 +00009325 ArgumentExpr = ICE->getSubExpr();
9326 }
9327 QualType ArgumentType = ArgumentExpr->getType();
9328
9329 // Passing a `void*' pointer shouldn't trigger a warning.
9330 if (IsPointerAttr && ArgumentType->isVoidPointerType())
9331 return;
9332
9333 if (TypeInfo.MustBeNull) {
9334 // Type tag with matching void type requires a null pointer.
9335 if (!ArgumentExpr->isNullPointerConstant(Context,
9336 Expr::NPC_ValueDependentIsNotNull)) {
9337 Diag(ArgumentExpr->getExprLoc(),
9338 diag::warn_type_safety_null_pointer_required)
9339 << ArgumentKind->getName()
9340 << ArgumentExpr->getSourceRange()
9341 << TypeTagExpr->getSourceRange();
9342 }
9343 return;
9344 }
9345
9346 QualType RequiredType = TypeInfo.Type;
9347 if (IsPointerAttr)
9348 RequiredType = Context.getPointerType(RequiredType);
9349
9350 bool mismatch = false;
9351 if (!TypeInfo.LayoutCompatible) {
9352 mismatch = !Context.hasSameType(ArgumentType, RequiredType);
9353
9354 // C++11 [basic.fundamental] p1:
9355 // Plain char, signed char, and unsigned char are three distinct types.
9356 //
9357 // But we treat plain `char' as equivalent to `signed char' or `unsigned
9358 // char' depending on the current char signedness mode.
9359 if (mismatch)
9360 if ((IsPointerAttr && IsSameCharType(ArgumentType->getPointeeType(),
9361 RequiredType->getPointeeType())) ||
9362 (!IsPointerAttr && IsSameCharType(ArgumentType, RequiredType)))
9363 mismatch = false;
9364 } else
9365 if (IsPointerAttr)
9366 mismatch = !isLayoutCompatible(Context,
9367 ArgumentType->getPointeeType(),
9368 RequiredType->getPointeeType());
9369 else
9370 mismatch = !isLayoutCompatible(Context, ArgumentType, RequiredType);
9371
9372 if (mismatch)
9373 Diag(ArgumentExpr->getExprLoc(), diag::warn_type_safety_type_mismatch)
Aaron Ballman25dc1e12014-01-03 02:14:08 +00009374 << ArgumentType << ArgumentKind
Dmitri Gribenkoe4a5a902012-08-17 00:08:38 +00009375 << TypeInfo.LayoutCompatible << RequiredType
9376 << ArgumentExpr->getSourceRange()
9377 << TypeTagExpr->getSourceRange();
9378}
Richard Trieu7eb0b2c2014-02-26 01:17:28 +00009379