blob: e4841cca00139588295a153e714a8ee816f50dcf [file] [log] [blame]
John Thompsond977c1e2013-03-27 18:34:38 +00001//===- extra/modularize/Modularize.cpp - Check modularized headers --------===//
John Thompson4f8ba652013-03-12 02:07:30 +00002//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements a tool that checks whether a set of headers provides
11// the consistent definitions required to use modules. For example, it detects
12// whether the same entity (say, a NULL macro or size_t typedef) is defined in
13// multiple headers or whether a header produces different definitions under
14// different circumstances. These conditions cause modules built from the
John Thompsonf5db45b2013-03-27 01:02:46 +000015// headers to behave poorly, and should be fixed before introducing a module
John Thompson4f8ba652013-03-12 02:07:30 +000016// map.
17//
18// Modularize takes as argument a file name for a file containing the
19// newline-separated list of headers to check with respect to each other.
John Thompsonf5db45b2013-03-27 01:02:46 +000020// Lines beginning with '#' and empty lines are ignored.
John Thompson7d0213c2013-09-04 20:46:24 +000021// Header file names followed by a colon and other space-separated
22// file names will include those extra files as dependencies.
23// The file names can be relative or full paths, but must be on the
24// same line.
25//
John Thompson4f8ba652013-03-12 02:07:30 +000026// Modularize also accepts regular front-end arguments.
27//
John Thompsonf5db45b2013-03-27 01:02:46 +000028// Usage: modularize [-prefix (optional header path prefix)]
John Thompsona2de1082013-03-26 01:17:48 +000029// (include-files_list) [(front-end-options) ...]
30//
John Thompsona44f85a2013-04-15 22:32:28 +000031// Note that unless a "-prefix (header path)" option is specified,
John Thompsona2de1082013-03-26 01:17:48 +000032// non-absolute file paths in the header list file will be relative
33// to the header list file directory. Use -prefix to specify a different
34// directory.
John Thompson4f8ba652013-03-12 02:07:30 +000035//
John Thompsonfd8ca382013-03-27 19:31:22 +000036// Note that by default, the underlying Clang front end assumes .h files
37// contain C source. If your .h files in the file list contain C++ source,
John Thompsonea6c8db2013-03-27 21:23:21 +000038// you should append the following to your command lines: -x c++
John Thompsonfd8ca382013-03-27 19:31:22 +000039//
John Thompson4f8ba652013-03-12 02:07:30 +000040// Modularize will do normal parsing, reporting normal errors and warnings,
41// but will also report special error messages like the following:
42//
John Thompson7c6e79f32013-07-29 19:07:00 +000043// error: '(symbol)' defined at multiple locations:
44// (file):(row):(column)
45// (file):(row):(column)
John Thompson4f8ba652013-03-12 02:07:30 +000046//
John Thompsondc118272013-07-29 21:59:41 +000047// error: header '(file)' has different contents depending on how it was
John Thompson7c6e79f32013-07-29 19:07:00 +000048// included
John Thompson4f8ba652013-03-12 02:07:30 +000049//
50// The latter might be followed by messages like the following:
51//
John Thompson7c6e79f32013-07-29 19:07:00 +000052// note: '(symbol)' in (file) at (row):(column) not always provided
John Thompson4f8ba652013-03-12 02:07:30 +000053//
John Thompson7c6e79f32013-07-29 19:07:00 +000054// Checks will also be performed for macro expansions, defined(macro)
55// expressions, and preprocessor conditional directives that evaluate
56// inconsistently, and can produce error messages like the following:
57//
Nico Weber8e20be22013-08-12 11:43:36 +000058// (...)/SubHeader.h:11:5:
59// #if SYMBOL == 1
60// ^
61// error: Macro instance 'SYMBOL' has different values in this header,
62// depending on how it was included.
63// 'SYMBOL' expanded to: '1' with respect to these inclusion paths:
64// (...)/Header1.h
65// (...)/SubHeader.h
66// (...)/SubHeader.h:3:9:
67// #define SYMBOL 1
68// ^
69// Macro defined here.
70// 'SYMBOL' expanded to: '2' with respect to these inclusion paths:
71// (...)/Header2.h
72// (...)/SubHeader.h
73// (...)/SubHeader.h:7:9:
74// #define SYMBOL 2
75// ^
76// Macro defined here.
77//
John Thompson74083922013-09-18 18:19:43 +000078// Checks will also be performed for '#include' directives that are
79// nested inside 'extern "C/C++" {}' or 'namespace (name) {}' blocks,
80// and can produce error message like the following:
81//
82// IncludeInExtern.h:2:3
83// #include "Empty.h"
84// ^
85// error: Include directive within extern "C" {}.
86// IncludeInExtern.h:1:1
87// extern "C" {
88// ^
89// The "extern "C" {}" block is here.
90//
John Thompson4fa9c2c2013-08-09 00:19:03 +000091// See PreprocessorTracker.cpp for additional details.
John Thompsoncc2e2912013-09-03 18:44:11 +000092//
John Thompson5ab4f112013-10-15 13:52:33 +000093// Modularize also has an option ("-module-map-path=module.map") that will
94// skip the checks, and instead act as a module.map generation assistant,
95// generating a module map file based on the header list. An optional
96// "-root-module=(rootName)" argument can specify a root module to be
97// created in the generated module.map file. Note that you will likely
98// need to edit this file to suit the needs of your headers.
99//
100// An example command line for generating a module.map file:
101//
102// modularize -module-map-path=module.map -root-module=myroot headerlist.txt
103//
104// Note that if the headers in the header list have partial paths, sub-modules
105// will be created for the subdirectires involved, assuming that the
106// subdirectories contain headers to be grouped into a module, but still with
107// individual modules for the headers in the subdirectory.
108//
109// See the ModuleAssistant.cpp file comments for additional details about the
110// implementation of the assistant mode.
111//
John Thompson74751802013-09-03 18:48:43 +0000112// Future directions:
113//
114// Basically, we want to add new checks for whatever we can check with respect
115// to checking headers for module'ability.
116//
117// Some ideas:
118//
John Thompson74083922013-09-18 18:19:43 +0000119// 1. Omit duplicate "not always provided" messages
John Thompson53a9d2d2013-09-04 18:29:36 +0000120//
John Thompson74083922013-09-18 18:19:43 +0000121// 2. Add options to disable any of the checks, in case
John Thompson74751802013-09-03 18:48:43 +0000122// there is some problem with them, or the messages get too verbose.
123//
John Thompson74083922013-09-18 18:19:43 +0000124// 3. Try to figure out the preprocessor conditional directives that
John Thompson74751802013-09-03 18:48:43 +0000125// contribute to problems and tie them to the inconsistent definitions.
126//
John Thompson74083922013-09-18 18:19:43 +0000127// 4. There are some legitimate uses of preprocessor macros that
Bob Wilsonf5999bd2013-09-04 16:48:28 +0000128// modularize will flag as errors, such as repeatedly #include'ing
129// a file and using interleaving defined/undefined macros
130// to change declarations in the included file. Is there a way
131// to address this? Maybe have modularize accept a list of macros
132// to ignore. Otherwise you can just exclude the file, after checking
133// for legitimate errors.
134//
John Thompson74083922013-09-18 18:19:43 +0000135// 5. What else?
John Thompsonce601e22013-03-14 01:41:29 +0000136//
137// General clean-up and refactoring:
138//
139// 1. The Location class seems to be something that we might
140// want to design to be applicable to a wider range of tools, and stick it
141// somewhere into Tooling/ in mainline
142//
John Thompson4f8ba652013-03-12 02:07:30 +0000143//===----------------------------------------------------------------------===//
John Thompsonf5db45b2013-03-27 01:02:46 +0000144
Chandler Carruth85e6e872014-01-07 20:05:01 +0000145#include "Modularize.h"
146#include "PreprocessorTracker.h"
Chandler Carruthf7e45c02014-01-07 22:15:39 +0000147#include "clang/AST/ASTConsumer.h"
John Thompsond977c1e2013-03-27 18:34:38 +0000148#include "clang/AST/ASTContext.h"
149#include "clang/AST/RecursiveASTVisitor.h"
150#include "clang/Basic/SourceManager.h"
John Thompson7d0213c2013-09-04 20:46:24 +0000151#include "clang/Driver/Options.h"
John Thompsond977c1e2013-03-27 18:34:38 +0000152#include "clang/Frontend/CompilerInstance.h"
153#include "clang/Frontend/FrontendActions.h"
154#include "clang/Lex/Preprocessor.h"
155#include "clang/Tooling/CompilationDatabase.h"
156#include "clang/Tooling/Tooling.h"
John Thompson7d0213c2013-09-04 20:46:24 +0000157#include "llvm/Option/Arg.h"
158#include "llvm/Option/ArgList.h"
159#include "llvm/Option/OptTable.h"
160#include "llvm/Option/Option.h"
John Thompsona2de1082013-03-26 01:17:48 +0000161#include "llvm/Support/CommandLine.h"
John Thompson4f8ba652013-03-12 02:07:30 +0000162#include "llvm/Support/FileSystem.h"
John Thompsonf5db45b2013-03-27 01:02:46 +0000163#include "llvm/Support/MemoryBuffer.h"
John Thompsona2de1082013-03-26 01:17:48 +0000164#include "llvm/Support/Path.h"
John Thompson4f8ba652013-03-12 02:07:30 +0000165#include <algorithm>
John Thompsond977c1e2013-03-27 18:34:38 +0000166#include <fstream>
John Thompson4f8ba652013-03-12 02:07:30 +0000167#include <iterator>
John Thompsond977c1e2013-03-27 18:34:38 +0000168#include <string>
169#include <vector>
John Thompson4f8ba652013-03-12 02:07:30 +0000170
Bob Wilsonf5999bd2013-09-04 16:48:28 +0000171using namespace clang;
John Thompson7d0213c2013-09-04 20:46:24 +0000172using namespace clang::driver;
173using namespace clang::driver::options;
174using namespace clang::tooling;
John Thompsona2de1082013-03-26 01:17:48 +0000175using namespace llvm;
John Thompson7d0213c2013-09-04 20:46:24 +0000176using namespace llvm::opt;
John Thompson94faa4d2013-07-26 23:56:42 +0000177using namespace Modularize;
John Thompson4f8ba652013-03-12 02:07:30 +0000178
John Thompsonea6c8db2013-03-27 21:23:21 +0000179// Option to specify a file name for a list of header files to check.
John Thompsonb809dfc2013-07-19 14:19:31 +0000180cl::opt<std::string>
181ListFileName(cl::Positional,
182 cl::desc("<name of file containing list of headers to check>"));
John Thompsonea6c8db2013-03-27 21:23:21 +0000183
184// Collect all other arguments, which will be passed to the front end.
John Thompson161381e2013-06-27 18:52:23 +0000185cl::list<std::string>
John Thompsonb809dfc2013-07-19 14:19:31 +0000186CC1Arguments(cl::ConsumeAfter,
187 cl::desc("<arguments to be passed to front end>..."));
John Thompsonea6c8db2013-03-27 21:23:21 +0000188
189// Option to specify a prefix to be prepended to the header names.
190cl::opt<std::string> HeaderPrefix(
191 "prefix", cl::init(""),
192 cl::desc(
193 "Prepend header file paths with this prefix."
194 " If not specified,"
195 " the files are considered to be relative to the header list file."));
196
John Thompson5ab4f112013-10-15 13:52:33 +0000197// Option for assistant mode, telling modularize to output a module map
198// based on the headers list, and where to put it.
199cl::opt<std::string> ModuleMapPath(
200 "module-map-path", cl::init(""),
201 cl::desc("Turn on module map output and specify output path or file name."
202 " If no path is specified and if prefix option is specified,"
203 " use prefix for file path."));
204
205// Option for assistant mode, telling modularize to output a module map
206// based on the headers list, and where to put it.
207cl::opt<std::string>
208RootModule("root-module", cl::init(""),
209 cl::desc("Specify the name of the root module."));
210
211// Save the program name for error messages.
212const char *Argv0;
213// Save the command line for comments.
214std::string CommandLine;
Bob Wilsonf5999bd2013-09-04 16:48:28 +0000215
John Thompson7d0213c2013-09-04 20:46:24 +0000216// Read the header list file and collect the header file names and
217// optional dependencies.
Rafael Espindolac7f0d232014-06-12 22:08:48 +0000218std::error_code
219getHeaderFileNames(SmallVectorImpl<std::string> &HeaderFileNames,
220 DependencyMap &Dependencies, StringRef ListFileName,
221 StringRef HeaderPrefix) {
John Thompsonea6c8db2013-03-27 21:23:21 +0000222 // By default, use the path component of the list file name.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000223 SmallString<256> HeaderDirectory(ListFileName);
224 sys::path::remove_filename(HeaderDirectory);
John Thompson7d0213c2013-09-04 20:46:24 +0000225 SmallString<256> CurrentDirectory;
226 sys::fs::current_path(CurrentDirectory);
John Thompsonea6c8db2013-03-27 21:23:21 +0000227
228 // Get the prefix if we have one.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000229 if (HeaderPrefix.size() != 0)
230 HeaderDirectory = HeaderPrefix;
John Thompsonea6c8db2013-03-27 21:23:21 +0000231
232 // Read the header list file into a buffer.
Ahmed Charles6a2dc5c2014-03-09 09:24:40 +0000233 std::unique_ptr<MemoryBuffer> listBuffer;
Rafael Espindolac7f0d232014-06-12 22:08:48 +0000234 if (std::error_code ec = MemoryBuffer::getFile(ListFileName, listBuffer)) {
John Thompsonea6c8db2013-03-27 21:23:21 +0000235 return ec;
236 }
237
238 // Parse the header list into strings.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000239 SmallVector<StringRef, 32> Strings;
240 listBuffer->getBuffer().split(Strings, "\n", -1, false);
John Thompsonea6c8db2013-03-27 21:23:21 +0000241
242 // Collect the header file names from the string list.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000243 for (SmallVectorImpl<StringRef>::iterator I = Strings.begin(),
244 E = Strings.end();
John Thompsonea6c8db2013-03-27 21:23:21 +0000245 I != E; ++I) {
John Thompson7d0213c2013-09-04 20:46:24 +0000246 StringRef Line = I->trim();
John Thompsonea6c8db2013-03-27 21:23:21 +0000247 // Ignore comments and empty lines.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000248 if (Line.empty() || (Line[0] == '#'))
John Thompsonea6c8db2013-03-27 21:23:21 +0000249 continue;
John Thompson7d0213c2013-09-04 20:46:24 +0000250 std::pair<StringRef, StringRef> TargetAndDependents = Line.split(':');
John Thompsonbb0a3b02013-08-09 13:52:09 +0000251 SmallString<256> HeaderFileName;
John Thompsonea6c8db2013-03-27 21:23:21 +0000252 // Prepend header file name prefix if it's not absolute.
John Thompson7d0213c2013-09-04 20:46:24 +0000253 if (sys::path::is_absolute(TargetAndDependents.first))
254 llvm::sys::path::native(TargetAndDependents.first, HeaderFileName);
John Thompsonea6c8db2013-03-27 21:23:21 +0000255 else {
John Thompson7d0213c2013-09-04 20:46:24 +0000256 if (HeaderDirectory.size() != 0)
257 HeaderFileName = HeaderDirectory;
258 else
259 HeaderFileName = CurrentDirectory;
260 sys::path::append(HeaderFileName, TargetAndDependents.first);
Benjamin Kramer3353a102013-09-11 10:45:25 +0000261 sys::path::native(HeaderFileName);
John Thompsonea6c8db2013-03-27 21:23:21 +0000262 }
John Thompson7d0213c2013-09-04 20:46:24 +0000263 // Handle optional dependencies.
264 DependentsVector Dependents;
265 SmallVector<StringRef, 4> DependentsList;
266 TargetAndDependents.second.split(DependentsList, " ", -1, false);
267 int Count = DependentsList.size();
268 for (int Index = 0; Index < Count; ++Index) {
269 SmallString<256> Dependent;
270 if (sys::path::is_absolute(DependentsList[Index]))
271 Dependent = DependentsList[Index];
272 else {
273 if (HeaderDirectory.size() != 0)
274 Dependent = HeaderDirectory;
275 else
276 Dependent = CurrentDirectory;
277 sys::path::append(Dependent, DependentsList[Index]);
278 }
Benjamin Kramer3353a102013-09-11 10:45:25 +0000279 sys::path::native(Dependent);
John Thompson7d0213c2013-09-04 20:46:24 +0000280 Dependents.push_back(Dependent.str());
281 }
282 // Save the resulting header file path and dependencies.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000283 HeaderFileNames.push_back(HeaderFileName.str());
John Thompson7d0213c2013-09-04 20:46:24 +0000284 Dependencies[HeaderFileName.str()] = Dependents;
John Thompsonea6c8db2013-03-27 21:23:21 +0000285 }
286
Rafael Espindolac7f0d232014-06-12 22:08:48 +0000287 return std::error_code();
John Thompsonea6c8db2013-03-27 21:23:21 +0000288}
289
John Thompson7d0213c2013-09-04 20:46:24 +0000290// Helper function for finding the input file in an arguments list.
291std::string findInputFile(const CommandLineArguments &CLArgs) {
Ahmed Charles6a2dc5c2014-03-09 09:24:40 +0000292 std::unique_ptr<OptTable> Opts(createDriverOptTable());
John Thompson7d0213c2013-09-04 20:46:24 +0000293 const unsigned IncludedFlagsBitmask = options::CC1Option;
294 unsigned MissingArgIndex, MissingArgCount;
295 SmallVector<const char *, 256> Argv;
296 for (CommandLineArguments::const_iterator I = CLArgs.begin(),
297 E = CLArgs.end();
298 I != E; ++I)
299 Argv.push_back(I->c_str());
Ahmed Charles6a2dc5c2014-03-09 09:24:40 +0000300 std::unique_ptr<InputArgList> Args(
John Thompson7d0213c2013-09-04 20:46:24 +0000301 Opts->ParseArgs(Argv.data(), Argv.data() + Argv.size(), MissingArgIndex,
302 MissingArgCount, IncludedFlagsBitmask));
303 std::vector<std::string> Inputs = Args->getAllArgValues(OPT_INPUT);
304 return Inputs.back();
305}
306
307// We provide this derivation to add in "-include (file)" arguments for header
308// dependencies.
309class AddDependenciesAdjuster : public ArgumentsAdjuster {
310public:
311 AddDependenciesAdjuster(DependencyMap &Dependencies)
312 : Dependencies(Dependencies) {}
313
314private:
315 // Callback for adjusting commandline arguments.
316 CommandLineArguments Adjust(const CommandLineArguments &Args) {
317 std::string InputFile = findInputFile(Args);
318 DependentsVector &FileDependents = Dependencies[InputFile];
319 int Count = FileDependents.size();
320 if (Count == 0)
321 return Args;
322 CommandLineArguments NewArgs(Args);
323 for (int Index = 0; Index < Count; ++Index) {
324 NewArgs.push_back("-include");
325 std::string File(std::string("\"") + FileDependents[Index] +
326 std::string("\""));
327 NewArgs.push_back(FileDependents[Index]);
328 }
329 return NewArgs;
330 }
331 DependencyMap &Dependencies;
332};
333
John Thompsonce601e22013-03-14 01:41:29 +0000334// FIXME: The Location class seems to be something that we might
335// want to design to be applicable to a wider range of tools, and stick it
336// somewhere into Tooling/ in mainline
John Thompson4f8ba652013-03-12 02:07:30 +0000337struct Location {
338 const FileEntry *File;
339 unsigned Line, Column;
John Thompsonf5db45b2013-03-27 01:02:46 +0000340
341 Location() : File(), Line(), Column() {}
342
John Thompson4f8ba652013-03-12 02:07:30 +0000343 Location(SourceManager &SM, SourceLocation Loc) : File(), Line(), Column() {
344 Loc = SM.getExpansionLoc(Loc);
345 if (Loc.isInvalid())
346 return;
John Thompsonf5db45b2013-03-27 01:02:46 +0000347
John Thompson4f8ba652013-03-12 02:07:30 +0000348 std::pair<FileID, unsigned> Decomposed = SM.getDecomposedLoc(Loc);
349 File = SM.getFileEntryForID(Decomposed.first);
350 if (!File)
351 return;
John Thompsonf5db45b2013-03-27 01:02:46 +0000352
John Thompson4f8ba652013-03-12 02:07:30 +0000353 Line = SM.getLineNumber(Decomposed.first, Decomposed.second);
354 Column = SM.getColumnNumber(Decomposed.first, Decomposed.second);
355 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000356
Craig Topperf61be9c2014-06-09 02:03:06 +0000357 operator bool() const { return File != nullptr; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000358
John Thompson4f8ba652013-03-12 02:07:30 +0000359 friend bool operator==(const Location &X, const Location &Y) {
360 return X.File == Y.File && X.Line == Y.Line && X.Column == Y.Column;
361 }
362
363 friend bool operator!=(const Location &X, const Location &Y) {
364 return !(X == Y);
365 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000366
John Thompson4f8ba652013-03-12 02:07:30 +0000367 friend bool operator<(const Location &X, const Location &Y) {
368 if (X.File != Y.File)
369 return X.File < Y.File;
370 if (X.Line != Y.Line)
371 return X.Line < Y.Line;
372 return X.Column < Y.Column;
373 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000374 friend bool operator>(const Location &X, const Location &Y) { return Y < X; }
John Thompson4f8ba652013-03-12 02:07:30 +0000375 friend bool operator<=(const Location &X, const Location &Y) {
376 return !(Y < X);
377 }
378 friend bool operator>=(const Location &X, const Location &Y) {
379 return !(X < Y);
380 }
John Thompson4f8ba652013-03-12 02:07:30 +0000381};
382
John Thompson4f8ba652013-03-12 02:07:30 +0000383struct Entry {
John Thompson52d98862013-03-28 18:38:43 +0000384 enum EntryKind {
385 EK_Tag,
386 EK_Value,
387 EK_Macro,
388
389 EK_NumberOfKinds
John Thompson4f8ba652013-03-12 02:07:30 +0000390 } Kind;
John Thompsonf5db45b2013-03-27 01:02:46 +0000391
John Thompson4f8ba652013-03-12 02:07:30 +0000392 Location Loc;
John Thompson4e4d9b32013-03-28 01:20:19 +0000393
394 StringRef getKindName() { return getKindName(Kind); }
John Thompson52d98862013-03-28 18:38:43 +0000395 static StringRef getKindName(EntryKind kind);
John Thompson4f8ba652013-03-12 02:07:30 +0000396};
397
John Thompson4e4d9b32013-03-28 01:20:19 +0000398// Return a string representing the given kind.
John Thompson52d98862013-03-28 18:38:43 +0000399StringRef Entry::getKindName(Entry::EntryKind kind) {
John Thompson4e4d9b32013-03-28 01:20:19 +0000400 switch (kind) {
John Thompson52d98862013-03-28 18:38:43 +0000401 case EK_Tag:
John Thompson4e4d9b32013-03-28 01:20:19 +0000402 return "tag";
John Thompson52d98862013-03-28 18:38:43 +0000403 case EK_Value:
John Thompson4e4d9b32013-03-28 01:20:19 +0000404 return "value";
John Thompson52d98862013-03-28 18:38:43 +0000405 case EK_Macro:
John Thompson4e4d9b32013-03-28 01:20:19 +0000406 return "macro";
John Thompson52d98862013-03-28 18:38:43 +0000407 case EK_NumberOfKinds:
John Thompson4e4d9b32013-03-28 01:20:19 +0000408 break;
John Thompson4e4d9b32013-03-28 01:20:19 +0000409 }
David Blaikiec66c07d2013-03-28 02:30:37 +0000410 llvm_unreachable("invalid Entry kind");
John Thompson4e4d9b32013-03-28 01:20:19 +0000411}
412
John Thompson4f8ba652013-03-12 02:07:30 +0000413struct HeaderEntry {
414 std::string Name;
415 Location Loc;
John Thompsonf5db45b2013-03-27 01:02:46 +0000416
John Thompson4f8ba652013-03-12 02:07:30 +0000417 friend bool operator==(const HeaderEntry &X, const HeaderEntry &Y) {
418 return X.Loc == Y.Loc && X.Name == Y.Name;
419 }
420 friend bool operator!=(const HeaderEntry &X, const HeaderEntry &Y) {
421 return !(X == Y);
422 }
423 friend bool operator<(const HeaderEntry &X, const HeaderEntry &Y) {
424 return X.Loc < Y.Loc || (X.Loc == Y.Loc && X.Name < Y.Name);
425 }
426 friend bool operator>(const HeaderEntry &X, const HeaderEntry &Y) {
427 return Y < X;
428 }
429 friend bool operator<=(const HeaderEntry &X, const HeaderEntry &Y) {
430 return !(Y < X);
431 }
432 friend bool operator>=(const HeaderEntry &X, const HeaderEntry &Y) {
433 return !(X < Y);
434 }
435};
436
437typedef std::vector<HeaderEntry> HeaderContents;
438
John Thompsonf5db45b2013-03-27 01:02:46 +0000439class EntityMap : public StringMap<SmallVector<Entry, 2> > {
John Thompson4f8ba652013-03-12 02:07:30 +0000440public:
John Thompsonf5db45b2013-03-27 01:02:46 +0000441 DenseMap<const FileEntry *, HeaderContents> HeaderContentMismatches;
442
John Thompson52d98862013-03-28 18:38:43 +0000443 void add(const std::string &Name, enum Entry::EntryKind Kind, Location Loc) {
John Thompson4f8ba652013-03-12 02:07:30 +0000444 // Record this entity in its header.
445 HeaderEntry HE = { Name, Loc };
446 CurHeaderContents[Loc.File].push_back(HE);
John Thompsonf5db45b2013-03-27 01:02:46 +0000447
John Thompson4f8ba652013-03-12 02:07:30 +0000448 // Check whether we've seen this entry before.
John Thompsonf5db45b2013-03-27 01:02:46 +0000449 SmallVector<Entry, 2> &Entries = (*this)[Name];
John Thompson4f8ba652013-03-12 02:07:30 +0000450 for (unsigned I = 0, N = Entries.size(); I != N; ++I) {
451 if (Entries[I].Kind == Kind && Entries[I].Loc == Loc)
452 return;
453 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000454
John Thompson4f8ba652013-03-12 02:07:30 +0000455 // We have not seen this entry before; record it.
456 Entry E = { Kind, Loc };
457 Entries.push_back(E);
458 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000459
John Thompson4f8ba652013-03-12 02:07:30 +0000460 void mergeCurHeaderContents() {
John Thompsonf5db45b2013-03-27 01:02:46 +0000461 for (DenseMap<const FileEntry *, HeaderContents>::iterator
462 H = CurHeaderContents.begin(),
463 HEnd = CurHeaderContents.end();
John Thompson4f8ba652013-03-12 02:07:30 +0000464 H != HEnd; ++H) {
465 // Sort contents.
466 std::sort(H->second.begin(), H->second.end());
467
468 // Check whether we've seen this header before.
John Thompsonf5db45b2013-03-27 01:02:46 +0000469 DenseMap<const FileEntry *, HeaderContents>::iterator KnownH =
470 AllHeaderContents.find(H->first);
John Thompson4f8ba652013-03-12 02:07:30 +0000471 if (KnownH == AllHeaderContents.end()) {
472 // We haven't seen this header before; record its contents.
473 AllHeaderContents.insert(*H);
474 continue;
475 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000476
John Thompson4f8ba652013-03-12 02:07:30 +0000477 // If the header contents are the same, we're done.
478 if (H->second == KnownH->second)
479 continue;
John Thompsonf5db45b2013-03-27 01:02:46 +0000480
John Thompson4f8ba652013-03-12 02:07:30 +0000481 // Determine what changed.
John Thompsonf5db45b2013-03-27 01:02:46 +0000482 std::set_symmetric_difference(
483 H->second.begin(), H->second.end(), KnownH->second.begin(),
484 KnownH->second.end(),
485 std::back_inserter(HeaderContentMismatches[H->first]));
John Thompson4f8ba652013-03-12 02:07:30 +0000486 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000487
John Thompson4f8ba652013-03-12 02:07:30 +0000488 CurHeaderContents.clear();
489 }
John Thompson161381e2013-06-27 18:52:23 +0000490
John Thompson1f67ccb2013-03-12 18:51:47 +0000491private:
John Thompsonf5db45b2013-03-27 01:02:46 +0000492 DenseMap<const FileEntry *, HeaderContents> CurHeaderContents;
493 DenseMap<const FileEntry *, HeaderContents> AllHeaderContents;
John Thompson4f8ba652013-03-12 02:07:30 +0000494};
495
John Thompson161381e2013-06-27 18:52:23 +0000496class CollectEntitiesVisitor
497 : public RecursiveASTVisitor<CollectEntitiesVisitor> {
John Thompson4f8ba652013-03-12 02:07:30 +0000498public:
John Thompson74083922013-09-18 18:19:43 +0000499 CollectEntitiesVisitor(SourceManager &SM, EntityMap &Entities,
500 Preprocessor &PP, PreprocessorTracker &PPTracker,
501 int &HadErrors)
502 : SM(SM), Entities(Entities), PP(PP), PPTracker(PPTracker),
503 HadErrors(HadErrors) {}
John Thompsonf5db45b2013-03-27 01:02:46 +0000504
John Thompson4f8ba652013-03-12 02:07:30 +0000505 bool TraverseStmt(Stmt *S) { return true; }
506 bool TraverseType(QualType T) { return true; }
507 bool TraverseTypeLoc(TypeLoc TL) { return true; }
508 bool TraverseNestedNameSpecifier(NestedNameSpecifier *NNS) { return true; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000509 bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNS) {
510 return true;
511 }
512 bool TraverseDeclarationNameInfo(DeclarationNameInfo NameInfo) {
513 return true;
514 }
John Thompson4f8ba652013-03-12 02:07:30 +0000515 bool TraverseTemplateName(TemplateName Template) { return true; }
516 bool TraverseTemplateArgument(const TemplateArgument &Arg) { return true; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000517 bool TraverseTemplateArgumentLoc(const TemplateArgumentLoc &ArgLoc) {
518 return true;
519 }
John Thompson4f8ba652013-03-12 02:07:30 +0000520 bool TraverseTemplateArguments(const TemplateArgument *Args,
John Thompsonf5db45b2013-03-27 01:02:46 +0000521 unsigned NumArgs) {
522 return true;
523 }
John Thompson4f8ba652013-03-12 02:07:30 +0000524 bool TraverseConstructorInitializer(CXXCtorInitializer *Init) { return true; }
Benjamin Kramer281f9d02014-05-10 16:32:07 +0000525 bool TraverseLambdaCapture(LambdaCapture C) { return true; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000526
John Thompson74083922013-09-18 18:19:43 +0000527 // Check 'extern "*" {}' block for #include directives.
528 bool VisitLinkageSpecDecl(LinkageSpecDecl *D) {
529 // Bail if not a block.
530 if (!D->hasBraces())
531 return true;
532 SourceRange BlockRange = D->getSourceRange();
533 const char *LinkageLabel;
534 switch (D->getLanguage()) {
535 case LinkageSpecDecl::lang_c:
536 LinkageLabel = "extern \"C\" {}";
537 break;
538 case LinkageSpecDecl::lang_cxx:
539 LinkageLabel = "extern \"C++\" {}";
540 break;
John Thompson74083922013-09-18 18:19:43 +0000541 }
542 if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, LinkageLabel,
543 errs()))
544 HadErrors = 1;
545 return true;
546 }
547
548 // Check 'namespace (name) {}' block for #include directives.
549 bool VisitNamespaceDecl(const NamespaceDecl *D) {
550 SourceRange BlockRange = D->getSourceRange();
551 std::string Label("namespace ");
552 Label += D->getName();
553 Label += " {}";
554 if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, Label.c_str(),
555 errs()))
556 HadErrors = 1;
557 return true;
558 }
559
560 // Collect definition entities.
John Thompson4f8ba652013-03-12 02:07:30 +0000561 bool VisitNamedDecl(NamedDecl *ND) {
562 // We only care about file-context variables.
563 if (!ND->getDeclContext()->isFileContext())
564 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000565
John Thompson4f8ba652013-03-12 02:07:30 +0000566 // Skip declarations that tend to be properly multiply-declared.
567 if (isa<NamespaceDecl>(ND) || isa<UsingDirectiveDecl>(ND) ||
John Thompsonf5db45b2013-03-27 01:02:46 +0000568 isa<NamespaceAliasDecl>(ND) ||
569 isa<ClassTemplateSpecializationDecl>(ND) || isa<UsingDecl>(ND) ||
John Thompson8e01c062013-08-26 15:17:23 +0000570 isa<ClassTemplateDecl>(ND) || isa<TemplateTypeParmDecl>(ND) ||
John Thompsoncc2e2912013-09-03 18:44:11 +0000571 isa<TypeAliasTemplateDecl>(ND) || isa<UsingShadowDecl>(ND) ||
572 isa<FunctionDecl>(ND) || isa<FunctionTemplateDecl>(ND) ||
John Thompson4f8ba652013-03-12 02:07:30 +0000573 (isa<TagDecl>(ND) &&
574 !cast<TagDecl>(ND)->isThisDeclarationADefinition()))
575 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000576
John Thompson8e01c062013-08-26 15:17:23 +0000577 // Skip anonymous declarations.
578 if (!ND->getDeclName())
579 return true;
580
581 // Get the qualified name.
John Thompsoncc2e2912013-09-03 18:44:11 +0000582 std::string Name;
583 llvm::raw_string_ostream OS(Name);
584 ND->printQualifiedName(OS);
585 OS.flush();
John Thompson4f8ba652013-03-12 02:07:30 +0000586 if (Name.empty())
587 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000588
John Thompson4f8ba652013-03-12 02:07:30 +0000589 Location Loc(SM, ND->getLocation());
590 if (!Loc)
591 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000592
John Thompson52d98862013-03-28 18:38:43 +0000593 Entities.add(Name, isa<TagDecl>(ND) ? Entry::EK_Tag : Entry::EK_Value, Loc);
John Thompson4f8ba652013-03-12 02:07:30 +0000594 return true;
595 }
John Thompson161381e2013-06-27 18:52:23 +0000596
John Thompson1f67ccb2013-03-12 18:51:47 +0000597private:
598 SourceManager &SM;
599 EntityMap &Entities;
John Thompson74083922013-09-18 18:19:43 +0000600 Preprocessor &PP;
601 PreprocessorTracker &PPTracker;
602 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000603};
604
605class CollectEntitiesConsumer : public ASTConsumer {
John Thompson4f8ba652013-03-12 02:07:30 +0000606public:
John Thompson94faa4d2013-07-26 23:56:42 +0000607 CollectEntitiesConsumer(EntityMap &Entities,
608 PreprocessorTracker &preprocessorTracker,
John Thompson74083922013-09-18 18:19:43 +0000609 Preprocessor &PP, StringRef InFile, int &HadErrors)
610 : Entities(Entities), PPTracker(preprocessorTracker), PP(PP),
611 HadErrors(HadErrors) {
John Thompson94faa4d2013-07-26 23:56:42 +0000612 PPTracker.handlePreprocessorEntry(PP, InFile);
613 }
614
615 ~CollectEntitiesConsumer() { PPTracker.handlePreprocessorExit(); }
John Thompsonf5db45b2013-03-27 01:02:46 +0000616
John Thompson4f8ba652013-03-12 02:07:30 +0000617 virtual void HandleTranslationUnit(ASTContext &Ctx) {
618 SourceManager &SM = Ctx.getSourceManager();
John Thompsonf5db45b2013-03-27 01:02:46 +0000619
John Thompson4f8ba652013-03-12 02:07:30 +0000620 // Collect declared entities.
John Thompson74083922013-09-18 18:19:43 +0000621 CollectEntitiesVisitor(SM, Entities, PP, PPTracker, HadErrors)
John Thompsonf5db45b2013-03-27 01:02:46 +0000622 .TraverseDecl(Ctx.getTranslationUnitDecl());
623
John Thompson4f8ba652013-03-12 02:07:30 +0000624 // Collect macro definitions.
625 for (Preprocessor::macro_iterator M = PP.macro_begin(),
John Thompsonf5db45b2013-03-27 01:02:46 +0000626 MEnd = PP.macro_end();
John Thompson4f8ba652013-03-12 02:07:30 +0000627 M != MEnd; ++M) {
628 Location Loc(SM, M->second->getLocation());
629 if (!Loc)
630 continue;
631
John Thompson52d98862013-03-28 18:38:43 +0000632 Entities.add(M->first->getName().str(), Entry::EK_Macro, Loc);
John Thompson4f8ba652013-03-12 02:07:30 +0000633 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000634
John Thompson4f8ba652013-03-12 02:07:30 +0000635 // Merge header contents.
636 Entities.mergeCurHeaderContents();
637 }
John Thompson161381e2013-06-27 18:52:23 +0000638
John Thompson1f67ccb2013-03-12 18:51:47 +0000639private:
640 EntityMap &Entities;
John Thompson94faa4d2013-07-26 23:56:42 +0000641 PreprocessorTracker &PPTracker;
John Thompson1f67ccb2013-03-12 18:51:47 +0000642 Preprocessor &PP;
John Thompson74083922013-09-18 18:19:43 +0000643 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000644};
645
646class CollectEntitiesAction : public SyntaxOnlyAction {
John Thompson1f67ccb2013-03-12 18:51:47 +0000647public:
John Thompson94faa4d2013-07-26 23:56:42 +0000648 CollectEntitiesAction(EntityMap &Entities,
John Thompson74083922013-09-18 18:19:43 +0000649 PreprocessorTracker &preprocessorTracker,
650 int &HadErrors)
651 : Entities(Entities), PPTracker(preprocessorTracker),
652 HadErrors(HadErrors) {}
John Thompson161381e2013-06-27 18:52:23 +0000653
John Thompson4f8ba652013-03-12 02:07:30 +0000654protected:
John Thompson161381e2013-06-27 18:52:23 +0000655 virtual clang::ASTConsumer *CreateASTConsumer(CompilerInstance &CI,
656 StringRef InFile) {
John Thompson94faa4d2013-07-26 23:56:42 +0000657 return new CollectEntitiesConsumer(Entities, PPTracker,
John Thompson74083922013-09-18 18:19:43 +0000658 CI.getPreprocessor(), InFile, HadErrors);
John Thompson4f8ba652013-03-12 02:07:30 +0000659 }
John Thompson161381e2013-06-27 18:52:23 +0000660
John Thompson1f67ccb2013-03-12 18:51:47 +0000661private:
John Thompsonf5db45b2013-03-27 01:02:46 +0000662 EntityMap &Entities;
John Thompson94faa4d2013-07-26 23:56:42 +0000663 PreprocessorTracker &PPTracker;
John Thompson74083922013-09-18 18:19:43 +0000664 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000665};
666
667class ModularizeFrontendActionFactory : public FrontendActionFactory {
John Thompson4f8ba652013-03-12 02:07:30 +0000668public:
John Thompson94faa4d2013-07-26 23:56:42 +0000669 ModularizeFrontendActionFactory(EntityMap &Entities,
John Thompson74083922013-09-18 18:19:43 +0000670 PreprocessorTracker &preprocessorTracker,
671 int &HadErrors)
672 : Entities(Entities), PPTracker(preprocessorTracker),
673 HadErrors(HadErrors) {}
John Thompson4f8ba652013-03-12 02:07:30 +0000674
675 virtual CollectEntitiesAction *create() {
John Thompson74083922013-09-18 18:19:43 +0000676 return new CollectEntitiesAction(Entities, PPTracker, HadErrors);
John Thompson4f8ba652013-03-12 02:07:30 +0000677 }
John Thompson161381e2013-06-27 18:52:23 +0000678
John Thompson1f67ccb2013-03-12 18:51:47 +0000679private:
John Thompsonf5db45b2013-03-27 01:02:46 +0000680 EntityMap &Entities;
John Thompson94faa4d2013-07-26 23:56:42 +0000681 PreprocessorTracker &PPTracker;
John Thompson74083922013-09-18 18:19:43 +0000682 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000683};
684
John Thompsonbb0a3b02013-08-09 13:52:09 +0000685int main(int Argc, const char **Argv) {
John Thompsona2de1082013-03-26 01:17:48 +0000686
John Thompson5ab4f112013-10-15 13:52:33 +0000687 // Save program name for error messages.
688 Argv0 = Argv[0];
689
690 // Save program arguments for use in module.map comment.
691 CommandLine = sys::path::stem(sys::path::filename(Argv0));
692 for (int ArgIndex = 1; ArgIndex < Argc; ArgIndex++) {
693 CommandLine.append(" ");
694 CommandLine.append(Argv[ArgIndex]);
695 }
696
John Thompsona2de1082013-03-26 01:17:48 +0000697 // This causes options to be parsed.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000698 cl::ParseCommandLineOptions(Argc, Argv, "modularize.\n");
John Thompsona2de1082013-03-26 01:17:48 +0000699
700 // No go if we have no header list file.
701 if (ListFileName.size() == 0) {
702 cl::PrintHelpMessage();
John Thompsonea6c8db2013-03-27 21:23:21 +0000703 return 1;
John Thompson4f8ba652013-03-12 02:07:30 +0000704 }
John Thompsona2de1082013-03-26 01:17:48 +0000705
John Thompson7d0213c2013-09-04 20:46:24 +0000706 // Get header file names and dependencies.
John Thompsonf5db45b2013-03-27 01:02:46 +0000707 SmallVector<std::string, 32> Headers;
John Thompson7d0213c2013-09-04 20:46:24 +0000708 DependencyMap Dependencies;
Rafael Espindolac7f0d232014-06-12 22:08:48 +0000709 if (std::error_code EC = getHeaderFileNames(Headers, Dependencies,
710 ListFileName, HeaderPrefix)) {
John Thompsonbb0a3b02013-08-09 13:52:09 +0000711 errs() << Argv[0] << ": error: Unable to get header list '" << ListFileName
712 << "': " << EC.message() << '\n';
John Thompsonea6c8db2013-03-27 21:23:21 +0000713 return 1;
John Thompson4f8ba652013-03-12 02:07:30 +0000714 }
John Thompsona2de1082013-03-26 01:17:48 +0000715
John Thompson5ab4f112013-10-15 13:52:33 +0000716 // If we are in assistant mode, output the module map and quit.
John Thompsone744d2b2013-12-10 02:26:44 +0000717 if (ModuleMapPath.length() != 0) {
John Thompson5ab4f112013-10-15 13:52:33 +0000718 if (!createModuleMap(ModuleMapPath, Headers, Dependencies, HeaderPrefix,
719 RootModule))
720 return 1; // Failed.
721 return 0; // Success - Skip checks in assistant mode.
722 }
723
John Thompson4f8ba652013-03-12 02:07:30 +0000724 // Create the compilation database.
John Thompsona2de1082013-03-26 01:17:48 +0000725 SmallString<256> PathBuf;
John Thompsonf5db45b2013-03-27 01:02:46 +0000726 sys::fs::current_path(PathBuf);
Ahmed Charles6a2dc5c2014-03-09 09:24:40 +0000727 std::unique_ptr<CompilationDatabase> Compilations;
John Thompsonf5db45b2013-03-27 01:02:46 +0000728 Compilations.reset(
729 new FixedCompilationDatabase(Twine(PathBuf), CC1Arguments));
John Thompsona2de1082013-03-26 01:17:48 +0000730
John Thompson94faa4d2013-07-26 23:56:42 +0000731 // Create preprocessor tracker, to watch for macro and conditional problems.
Ahmed Charles6a2dc5c2014-03-09 09:24:40 +0000732 std::unique_ptr<PreprocessorTracker> PPTracker(PreprocessorTracker::create());
John Thompson94faa4d2013-07-26 23:56:42 +0000733
John Thompson4f8ba652013-03-12 02:07:30 +0000734 // Parse all of the headers, detecting duplicates.
735 EntityMap Entities;
736 ClangTool Tool(*Compilations, Headers);
John Thompson7d0213c2013-09-04 20:46:24 +0000737 Tool.appendArgumentsAdjuster(new AddDependenciesAdjuster(Dependencies));
John Thompson74083922013-09-18 18:19:43 +0000738 int HadErrors = 0;
739 HadErrors |= Tool.run(
740 new ModularizeFrontendActionFactory(Entities, *PPTracker, HadErrors));
John Thompsonce601e22013-03-14 01:41:29 +0000741
John Thompson4e4d9b32013-03-28 01:20:19 +0000742 // Create a place to save duplicate entity locations, separate bins per kind.
743 typedef SmallVector<Location, 8> LocationArray;
John Thompson52d98862013-03-28 18:38:43 +0000744 typedef SmallVector<LocationArray, Entry::EK_NumberOfKinds> EntryBinArray;
John Thompson4e4d9b32013-03-28 01:20:19 +0000745 EntryBinArray EntryBins;
John Thompsonbb0a3b02013-08-09 13:52:09 +0000746 int KindIndex;
747 for (KindIndex = 0; KindIndex < Entry::EK_NumberOfKinds; ++KindIndex) {
748 LocationArray Array;
749 EntryBins.push_back(Array);
Michael Gottesman4b249212013-03-28 06:07:15 +0000750 }
John Thompson4e4d9b32013-03-28 01:20:19 +0000751
John Thompson4f8ba652013-03-12 02:07:30 +0000752 // Check for the same entity being defined in multiple places.
753 for (EntityMap::iterator E = Entities.begin(), EEnd = Entities.end();
754 E != EEnd; ++E) {
Alp Toker9a5134e2013-12-01 05:08:12 +0000755 // If only one occurrence, exit early.
John Thompson4e4d9b32013-03-28 01:20:19 +0000756 if (E->second.size() == 1)
757 continue;
758 // Clear entity locations.
759 for (EntryBinArray::iterator CI = EntryBins.begin(), CE = EntryBins.end();
760 CI != CE; ++CI) {
John Thompson52d98862013-03-28 18:38:43 +0000761 CI->clear();
John Thompson4e4d9b32013-03-28 01:20:19 +0000762 }
763 // Walk the entities of a single name, collecting the locations,
764 // separated into separate bins.
John Thompson4f8ba652013-03-12 02:07:30 +0000765 for (unsigned I = 0, N = E->second.size(); I != N; ++I) {
John Thompson52d98862013-03-28 18:38:43 +0000766 EntryBins[E->second[I].Kind].push_back(E->second[I].Loc);
John Thompson4e4d9b32013-03-28 01:20:19 +0000767 }
768 // Report any duplicate entity definition errors.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000769 int KindIndex = 0;
John Thompson4e4d9b32013-03-28 01:20:19 +0000770 for (EntryBinArray::iterator DI = EntryBins.begin(), DE = EntryBins.end();
John Thompsonbb0a3b02013-08-09 13:52:09 +0000771 DI != DE; ++DI, ++KindIndex) {
772 int ECount = DI->size();
John Thompsonabe79d92013-12-04 20:41:30 +0000773 // If only 1 occurrence of this entity, skip it, as we only report duplicates.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000774 if (ECount <= 1)
John Thompson4f8ba652013-03-12 02:07:30 +0000775 continue;
John Thompson52d98862013-03-28 18:38:43 +0000776 LocationArray::iterator FI = DI->begin();
John Thompsonbb0a3b02013-08-09 13:52:09 +0000777 StringRef kindName = Entry::getKindName((Entry::EntryKind)KindIndex);
John Thompson4e4d9b32013-03-28 01:20:19 +0000778 errs() << "error: " << kindName << " '" << E->first()
779 << "' defined at multiple locations:\n";
John Thompson52d98862013-03-28 18:38:43 +0000780 for (LocationArray::iterator FE = DI->end(); FI != FE; ++FI) {
John Thompson4e4d9b32013-03-28 01:20:19 +0000781 errs() << " " << FI->File->getName() << ":" << FI->Line << ":"
782 << FI->Column << "\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000783 }
John Thompson4f8ba652013-03-12 02:07:30 +0000784 HadErrors = 1;
785 }
786 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000787
John Thompson94faa4d2013-07-26 23:56:42 +0000788 // Complain about macro instance in header files that differ based on how
789 // they are included.
790 if (PPTracker->reportInconsistentMacros(errs()))
791 HadErrors = 1;
792
793 // Complain about preprocessor conditional directives in header files that
794 // differ based on how they are included.
795 if (PPTracker->reportInconsistentConditionals(errs()))
796 HadErrors = 1;
797
John Thompson4f8ba652013-03-12 02:07:30 +0000798 // Complain about any headers that have contents that differ based on how
799 // they are included.
John Thompsonce601e22013-03-14 01:41:29 +0000800 // FIXME: Could we provide information about which preprocessor conditionals
801 // are involved?
John Thompsonf5db45b2013-03-27 01:02:46 +0000802 for (DenseMap<const FileEntry *, HeaderContents>::iterator
803 H = Entities.HeaderContentMismatches.begin(),
804 HEnd = Entities.HeaderContentMismatches.end();
John Thompson4f8ba652013-03-12 02:07:30 +0000805 H != HEnd; ++H) {
806 if (H->second.empty()) {
John Thompsonf5db45b2013-03-27 01:02:46 +0000807 errs() << "internal error: phantom header content mismatch\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000808 continue;
809 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000810
John Thompson4f8ba652013-03-12 02:07:30 +0000811 HadErrors = 1;
John Thompsonf5db45b2013-03-27 01:02:46 +0000812 errs() << "error: header '" << H->first->getName()
John Thompson94faa4d2013-07-26 23:56:42 +0000813 << "' has different contents depending on how it was included.\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000814 for (unsigned I = 0, N = H->second.size(); I != N; ++I) {
John Thompson161381e2013-06-27 18:52:23 +0000815 errs() << "note: '" << H->second[I].Name << "' in "
816 << H->second[I].Loc.File->getName() << " at "
817 << H->second[I].Loc.Line << ":" << H->second[I].Loc.Column
818 << " not always provided\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000819 }
820 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000821
John Thompson4f8ba652013-03-12 02:07:30 +0000822 return HadErrors;
823}