blob: 07bd98b30ab5e718df370a0bfdcc64ffeff789f0 [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements the visitICmp and visitFCmp functions.
11//
12//===----------------------------------------------------------------------===//
13
Chandler Carrutha9174582015-01-22 05:25:13 +000014#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000015#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000016#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000017#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000018#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000019#include "llvm/Analysis/InstructionSimplify.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000020#include "llvm/Analysis/TargetLibraryInfo.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000021#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000022#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000023#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000024#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000025#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000026#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000027#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000028
Chris Lattner2188e402010-01-04 07:37:31 +000029using namespace llvm;
30using namespace PatternMatch;
31
Chandler Carruth964daaa2014-04-22 02:55:47 +000032#define DEBUG_TYPE "instcombine"
33
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000034// How many times is a select replaced by one of its operands?
35STATISTIC(NumSel, "Number of select opts");
36
Chris Lattner98457102011-02-10 05:23:05 +000037
Sanjay Patel5f0217f2016-06-05 16:46:18 +000038/// Compute Result = In1+In2, returning true if the result overflowed for this
39/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000040static bool addWithOverflow(APInt &Result, const APInt &In1,
41 const APInt &In2, bool IsSigned = false) {
42 bool Overflow;
43 if (IsSigned)
44 Result = In1.sadd_ov(In2, Overflow);
45 else
46 Result = In1.uadd_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000047
Craig Topper6e025a32017-10-01 23:53:54 +000048 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000049}
50
Sanjay Patel5f0217f2016-06-05 16:46:18 +000051/// Compute Result = In1-In2, returning true if the result overflowed for this
52/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000053static bool subWithOverflow(APInt &Result, const APInt &In1,
54 const APInt &In2, bool IsSigned = false) {
55 bool Overflow;
56 if (IsSigned)
57 Result = In1.ssub_ov(In2, Overflow);
58 else
59 Result = In1.usub_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000060
Craig Topper6e025a32017-10-01 23:53:54 +000061 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000062}
63
Balaram Makam569eaec2016-05-04 21:32:14 +000064/// Given an icmp instruction, return true if any use of this comparison is a
65/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +000066static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +000067 for (auto *U : I.users())
68 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +000069 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +000070 return false;
71}
72
Sanjay Patel5f0217f2016-06-05 16:46:18 +000073/// Given an exploded icmp instruction, return true if the comparison only
74/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
75/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +000076static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +000077 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +000078 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +000079 case ICmpInst::ICMP_SLT: // True if LHS s< 0
80 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +000081 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +000082 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
83 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000084 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000085 case ICmpInst::ICMP_SGT: // True if LHS s> -1
86 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +000087 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000088 case ICmpInst::ICMP_UGT:
89 // True if LHS u> RHS and RHS == high-bit-mask - 1
90 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000091 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +000092 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +000093 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
94 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +000095 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +000096 default:
97 return false;
98 }
99}
100
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000101/// Returns true if the exploded icmp can be expressed as a signed comparison
102/// to zero and updates the predicate accordingly.
103/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000104/// TODO: Refactor with decomposeBitTestICmp()?
105static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000106 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000107 return false;
108
Craig Topper73ba1c82017-06-07 07:40:37 +0000109 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000110 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000111
Craig Topper73ba1c82017-06-07 07:40:37 +0000112 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000113 if (Pred == ICmpInst::ICMP_SLT) {
114 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000115 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000116 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000117 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000118 if (Pred == ICmpInst::ICMP_SGT) {
119 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000120 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000121 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000122 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000123
124 return false;
125}
126
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000127/// Given a signed integer type and a set of known zero and one bits, compute
128/// the maximum and minimum values that could have the specified known zero and
129/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000130/// TODO: Move to method on KnownBits struct?
131static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000132 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000133 assert(Known.getBitWidth() == Min.getBitWidth() &&
134 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000135 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000136 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000137
138 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
139 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000140 Min = Known.One;
141 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000142
Chris Lattner2188e402010-01-04 07:37:31 +0000143 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000144 Min.setSignBit();
145 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000146 }
147}
148
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000149/// Given an unsigned integer type and a set of known zero and one bits, compute
150/// the maximum and minimum values that could have the specified known zero and
151/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000152/// TODO: Move to method on KnownBits struct?
153static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000154 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000155 assert(Known.getBitWidth() == Min.getBitWidth() &&
156 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000157 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000158 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000159
Chris Lattner2188e402010-01-04 07:37:31 +0000160 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000161 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000162 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000163 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000164}
165
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000166/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000167/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000168/// where GV is a global variable with a constant initializer. Try to simplify
169/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000170/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
171///
172/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000173/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000174Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
175 GlobalVariable *GV,
176 CmpInst &ICI,
177 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000178 Constant *Init = GV->getInitializer();
179 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000180 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000181
Chris Lattnerfe741762012-01-31 02:55:06 +0000182 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000183 // Don't blow up on huge arrays.
184 if (ArrayElementCount > MaxArraySizeForCombine)
185 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000186
Chris Lattner2188e402010-01-04 07:37:31 +0000187 // There are many forms of this optimization we can handle, for now, just do
188 // the simple index into a single-dimensional array.
189 //
190 // Require: GEP GV, 0, i {{, constant indices}}
191 if (GEP->getNumOperands() < 3 ||
192 !isa<ConstantInt>(GEP->getOperand(1)) ||
193 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
194 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000195 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000196
197 // Check that indices after the variable are constants and in-range for the
198 // type they index. Collect the indices. This is typically for arrays of
199 // structs.
200 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000201
Chris Lattnerfe741762012-01-31 02:55:06 +0000202 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000203 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
204 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000205 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000206
Chris Lattner2188e402010-01-04 07:37:31 +0000207 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000208 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000209
Chris Lattner229907c2011-07-18 04:54:35 +0000210 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000211 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000212 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000213 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000214 EltTy = ATy->getElementType();
215 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000216 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000217 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000218
Chris Lattner2188e402010-01-04 07:37:31 +0000219 LaterIndices.push_back(IdxVal);
220 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000221
Chris Lattner2188e402010-01-04 07:37:31 +0000222 enum { Overdefined = -3, Undefined = -2 };
223
224 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000225
Chris Lattner2188e402010-01-04 07:37:31 +0000226 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
227 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
228 // and 87 is the second (and last) index. FirstTrueElement is -2 when
229 // undefined, otherwise set to the first true element. SecondTrueElement is
230 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
231 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
232
233 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
234 // form "i != 47 & i != 87". Same state transitions as for true elements.
235 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000236
Chris Lattner2188e402010-01-04 07:37:31 +0000237 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
238 /// define a state machine that triggers for ranges of values that the index
239 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
240 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
241 /// index in the range (inclusive). We use -2 for undefined here because we
242 /// use relative comparisons and don't want 0-1 to match -1.
243 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000244
Chris Lattner2188e402010-01-04 07:37:31 +0000245 // MagicBitvector - This is a magic bitvector where we set a bit if the
246 // comparison is true for element 'i'. If there are 64 elements or less in
247 // the array, this will fully represent all the comparison results.
248 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000249
Chris Lattner2188e402010-01-04 07:37:31 +0000250 // Scan the array and see if one of our patterns matches.
251 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000252 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
253 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000254 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000255
Chris Lattner2188e402010-01-04 07:37:31 +0000256 // If this is indexing an array of structures, get the structure element.
257 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000258 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000259
Chris Lattner2188e402010-01-04 07:37:31 +0000260 // If the element is masked, handle it.
261 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000262
Chris Lattner2188e402010-01-04 07:37:31 +0000263 // Find out if the comparison would be true or false for the i'th element.
264 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000265 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000266 // If the result is undef for this element, ignore it.
267 if (isa<UndefValue>(C)) {
268 // Extend range state machines to cover this element in case there is an
269 // undef in the middle of the range.
270 if (TrueRangeEnd == (int)i-1)
271 TrueRangeEnd = i;
272 if (FalseRangeEnd == (int)i-1)
273 FalseRangeEnd = i;
274 continue;
275 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000276
Chris Lattner2188e402010-01-04 07:37:31 +0000277 // If we can't compute the result for any of the elements, we have to give
278 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000279 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000280
Chris Lattner2188e402010-01-04 07:37:31 +0000281 // Otherwise, we know if the comparison is true or false for this element,
282 // update our state machines.
283 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000284
Chris Lattner2188e402010-01-04 07:37:31 +0000285 // State machine for single/double/range index comparison.
286 if (IsTrueForElt) {
287 // Update the TrueElement state machine.
288 if (FirstTrueElement == Undefined)
289 FirstTrueElement = TrueRangeEnd = i; // First true element.
290 else {
291 // Update double-compare state machine.
292 if (SecondTrueElement == Undefined)
293 SecondTrueElement = i;
294 else
295 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000296
Chris Lattner2188e402010-01-04 07:37:31 +0000297 // Update range state machine.
298 if (TrueRangeEnd == (int)i-1)
299 TrueRangeEnd = i;
300 else
301 TrueRangeEnd = Overdefined;
302 }
303 } else {
304 // Update the FalseElement state machine.
305 if (FirstFalseElement == Undefined)
306 FirstFalseElement = FalseRangeEnd = i; // First false element.
307 else {
308 // Update double-compare state machine.
309 if (SecondFalseElement == Undefined)
310 SecondFalseElement = i;
311 else
312 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000313
Chris Lattner2188e402010-01-04 07:37:31 +0000314 // Update range state machine.
315 if (FalseRangeEnd == (int)i-1)
316 FalseRangeEnd = i;
317 else
318 FalseRangeEnd = Overdefined;
319 }
320 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000321
Chris Lattner2188e402010-01-04 07:37:31 +0000322 // If this element is in range, update our magic bitvector.
323 if (i < 64 && IsTrueForElt)
324 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000325
Chris Lattner2188e402010-01-04 07:37:31 +0000326 // If all of our states become overdefined, bail out early. Since the
327 // predicate is expensive, only check it every 8 elements. This is only
328 // really useful for really huge arrays.
329 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
330 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
331 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000332 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000333 }
334
335 // Now that we've scanned the entire array, emit our new comparison(s). We
336 // order the state machines in complexity of the generated code.
337 Value *Idx = GEP->getOperand(2);
338
Matt Arsenault5aeae182013-08-19 21:40:31 +0000339 // If the index is larger than the pointer size of the target, truncate the
340 // index down like the GEP would do implicitly. We don't have to do this for
341 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000342 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000343 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000344 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
345 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000346 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000347 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000348
Chris Lattner2188e402010-01-04 07:37:31 +0000349 // If the comparison is only true for one or two elements, emit direct
350 // comparisons.
351 if (SecondTrueElement != Overdefined) {
352 // None true -> false.
353 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000354 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000355
Chris Lattner2188e402010-01-04 07:37:31 +0000356 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000357
Chris Lattner2188e402010-01-04 07:37:31 +0000358 // True for one element -> 'i == 47'.
359 if (SecondTrueElement == Undefined)
360 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000361
Chris Lattner2188e402010-01-04 07:37:31 +0000362 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000363 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000364 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000365 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000366 return BinaryOperator::CreateOr(C1, C2);
367 }
368
369 // If the comparison is only false for one or two elements, emit direct
370 // comparisons.
371 if (SecondFalseElement != Overdefined) {
372 // None false -> true.
373 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000374 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000375
Chris Lattner2188e402010-01-04 07:37:31 +0000376 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
377
378 // False for one element -> 'i != 47'.
379 if (SecondFalseElement == Undefined)
380 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000381
Chris Lattner2188e402010-01-04 07:37:31 +0000382 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000383 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000384 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000385 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000386 return BinaryOperator::CreateAnd(C1, C2);
387 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000388
Chris Lattner2188e402010-01-04 07:37:31 +0000389 // If the comparison can be replaced with a range comparison for the elements
390 // where it is true, emit the range check.
391 if (TrueRangeEnd != Overdefined) {
392 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000393
Chris Lattner2188e402010-01-04 07:37:31 +0000394 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
395 if (FirstTrueElement) {
396 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000397 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000398 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000399
Chris Lattner2188e402010-01-04 07:37:31 +0000400 Value *End = ConstantInt::get(Idx->getType(),
401 TrueRangeEnd-FirstTrueElement+1);
402 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
403 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000404
Chris Lattner2188e402010-01-04 07:37:31 +0000405 // False range check.
406 if (FalseRangeEnd != Overdefined) {
407 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
408 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
409 if (FirstFalseElement) {
410 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000411 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000412 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000413
Chris Lattner2188e402010-01-04 07:37:31 +0000414 Value *End = ConstantInt::get(Idx->getType(),
415 FalseRangeEnd-FirstFalseElement);
416 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
417 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000418
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000419 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000420 // of this load, replace it with computation that does:
421 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000422 {
Craig Topperf40110f2014-04-25 05:29:35 +0000423 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000424
425 // Look for an appropriate type:
426 // - The type of Idx if the magic fits
Craig Topper386fc252017-11-07 17:37:32 +0000427 // - The smallest fitting legal type
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000428 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
429 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000430 else
431 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000432
Craig Topperf40110f2014-04-25 05:29:35 +0000433 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000434 Value *V = Builder.CreateIntCast(Idx, Ty, false);
435 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
436 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000437 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
438 }
Chris Lattner2188e402010-01-04 07:37:31 +0000439 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000440
Craig Topperf40110f2014-04-25 05:29:35 +0000441 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000442}
443
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000444/// Return a value that can be used to compare the *offset* implied by a GEP to
445/// zero. For example, if we have &A[i], we want to return 'i' for
446/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
447/// are involved. The above expression would also be legal to codegen as
448/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
449/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000450/// to generate the first by knowing that pointer arithmetic doesn't overflow.
451///
452/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000453///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000454static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000455 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000456 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000457
Chris Lattner2188e402010-01-04 07:37:31 +0000458 // Check to see if this gep only has a single variable index. If so, and if
459 // any constant indices are a multiple of its scale, then we can compute this
460 // in terms of the scale of the variable index. For example, if the GEP
461 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
462 // because the expression will cross zero at the same point.
463 unsigned i, e = GEP->getNumOperands();
464 int64_t Offset = 0;
465 for (i = 1; i != e; ++i, ++GTI) {
466 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
467 // Compute the aggregate offset of constant indices.
468 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000469
Chris Lattner2188e402010-01-04 07:37:31 +0000470 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000471 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000472 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000473 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000474 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000475 Offset += Size*CI->getSExtValue();
476 }
477 } else {
478 // Found our variable index.
479 break;
480 }
481 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000482
Chris Lattner2188e402010-01-04 07:37:31 +0000483 // If there are no variable indices, we must have a constant offset, just
484 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000485 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000486
Chris Lattner2188e402010-01-04 07:37:31 +0000487 Value *VariableIdx = GEP->getOperand(i);
488 // Determine the scale factor of the variable element. For example, this is
489 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000490 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000491
Chris Lattner2188e402010-01-04 07:37:31 +0000492 // Verify that there are no other variable indices. If so, emit the hard way.
493 for (++i, ++GTI; i != e; ++i, ++GTI) {
494 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000495 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000496
Chris Lattner2188e402010-01-04 07:37:31 +0000497 // Compute the aggregate offset of constant indices.
498 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000499
Chris Lattner2188e402010-01-04 07:37:31 +0000500 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000501 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000502 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000503 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000504 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000505 Offset += Size*CI->getSExtValue();
506 }
507 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000508
Chris Lattner2188e402010-01-04 07:37:31 +0000509 // Okay, we know we have a single variable index, which must be a
510 // pointer/array/vector index. If there is no offset, life is simple, return
511 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000512 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000513 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000514 if (Offset == 0) {
515 // Cast to intptrty in case a truncation occurs. If an extension is needed,
516 // we don't need to bother extending: the extension won't affect where the
517 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000518 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000519 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000520 }
Chris Lattner2188e402010-01-04 07:37:31 +0000521 return VariableIdx;
522 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000523
Chris Lattner2188e402010-01-04 07:37:31 +0000524 // Otherwise, there is an index. The computation we will do will be modulo
525 // the pointer size, so get it.
526 uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000527
Chris Lattner2188e402010-01-04 07:37:31 +0000528 Offset &= PtrSizeMask;
529 VariableScale &= PtrSizeMask;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000530
Chris Lattner2188e402010-01-04 07:37:31 +0000531 // To do this transformation, any constant index must be a multiple of the
532 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
533 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
534 // multiple of the variable scale.
535 int64_t NewOffs = Offset / (int64_t)VariableScale;
536 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000537 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000538
Chris Lattner2188e402010-01-04 07:37:31 +0000539 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000540 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000541 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000542 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000543 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000544 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000545}
546
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000547/// Returns true if we can rewrite Start as a GEP with pointer Base
548/// and some integer offset. The nodes that need to be re-written
549/// for this transformation will be added to Explored.
550static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
551 const DataLayout &DL,
552 SetVector<Value *> &Explored) {
553 SmallVector<Value *, 16> WorkList(1, Start);
554 Explored.insert(Base);
555
556 // The following traversal gives us an order which can be used
557 // when doing the final transformation. Since in the final
558 // transformation we create the PHI replacement instructions first,
559 // we don't have to get them in any particular order.
560 //
561 // However, for other instructions we will have to traverse the
562 // operands of an instruction first, which means that we have to
563 // do a post-order traversal.
564 while (!WorkList.empty()) {
565 SetVector<PHINode *> PHIs;
566
567 while (!WorkList.empty()) {
568 if (Explored.size() >= 100)
569 return false;
570
571 Value *V = WorkList.back();
572
573 if (Explored.count(V) != 0) {
574 WorkList.pop_back();
575 continue;
576 }
577
578 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000579 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000580 // We've found some value that we can't explore which is different from
581 // the base. Therefore we can't do this transformation.
582 return false;
583
584 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
585 auto *CI = dyn_cast<CastInst>(V);
586 if (!CI->isNoopCast(DL))
587 return false;
588
589 if (Explored.count(CI->getOperand(0)) == 0)
590 WorkList.push_back(CI->getOperand(0));
591 }
592
593 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
594 // We're limiting the GEP to having one index. This will preserve
595 // the original pointer type. We could handle more cases in the
596 // future.
597 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
598 GEP->getType() != Start->getType())
599 return false;
600
601 if (Explored.count(GEP->getOperand(0)) == 0)
602 WorkList.push_back(GEP->getOperand(0));
603 }
604
605 if (WorkList.back() == V) {
606 WorkList.pop_back();
607 // We've finished visiting this node, mark it as such.
608 Explored.insert(V);
609 }
610
611 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000612 // We cannot transform PHIs on unsplittable basic blocks.
613 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
614 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000615 Explored.insert(PN);
616 PHIs.insert(PN);
617 }
618 }
619
620 // Explore the PHI nodes further.
621 for (auto *PN : PHIs)
622 for (Value *Op : PN->incoming_values())
623 if (Explored.count(Op) == 0)
624 WorkList.push_back(Op);
625 }
626
627 // Make sure that we can do this. Since we can't insert GEPs in a basic
628 // block before a PHI node, we can't easily do this transformation if
629 // we have PHI node users of transformed instructions.
630 for (Value *Val : Explored) {
631 for (Value *Use : Val->uses()) {
632
633 auto *PHI = dyn_cast<PHINode>(Use);
634 auto *Inst = dyn_cast<Instruction>(Val);
635
636 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
637 Explored.count(PHI) == 0)
638 continue;
639
640 if (PHI->getParent() == Inst->getParent())
641 return false;
642 }
643 }
644 return true;
645}
646
647// Sets the appropriate insert point on Builder where we can add
648// a replacement Instruction for V (if that is possible).
649static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
650 bool Before = true) {
651 if (auto *PHI = dyn_cast<PHINode>(V)) {
652 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
653 return;
654 }
655 if (auto *I = dyn_cast<Instruction>(V)) {
656 if (!Before)
657 I = &*std::next(I->getIterator());
658 Builder.SetInsertPoint(I);
659 return;
660 }
661 if (auto *A = dyn_cast<Argument>(V)) {
662 // Set the insertion point in the entry block.
663 BasicBlock &Entry = A->getParent()->getEntryBlock();
664 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
665 return;
666 }
667 // Otherwise, this is a constant and we don't need to set a new
668 // insertion point.
669 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
670}
671
672/// Returns a re-written value of Start as an indexed GEP using Base as a
673/// pointer.
674static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
675 const DataLayout &DL,
676 SetVector<Value *> &Explored) {
677 // Perform all the substitutions. This is a bit tricky because we can
678 // have cycles in our use-def chains.
679 // 1. Create the PHI nodes without any incoming values.
680 // 2. Create all the other values.
681 // 3. Add the edges for the PHI nodes.
682 // 4. Emit GEPs to get the original pointers.
683 // 5. Remove the original instructions.
684 Type *IndexType = IntegerType::get(
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000685 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000686
687 DenseMap<Value *, Value *> NewInsts;
688 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
689
690 // Create the new PHI nodes, without adding any incoming values.
691 for (Value *Val : Explored) {
692 if (Val == Base)
693 continue;
694 // Create empty phi nodes. This avoids cyclic dependencies when creating
695 // the remaining instructions.
696 if (auto *PHI = dyn_cast<PHINode>(Val))
697 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
698 PHI->getName() + ".idx", PHI);
699 }
700 IRBuilder<> Builder(Base->getContext());
701
702 // Create all the other instructions.
703 for (Value *Val : Explored) {
704
705 if (NewInsts.find(Val) != NewInsts.end())
706 continue;
707
708 if (auto *CI = dyn_cast<CastInst>(Val)) {
709 NewInsts[CI] = NewInsts[CI->getOperand(0)];
710 continue;
711 }
712 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
713 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
714 : GEP->getOperand(1);
715 setInsertionPoint(Builder, GEP);
716 // Indices might need to be sign extended. GEPs will magically do
717 // this, but we need to do it ourselves here.
718 if (Index->getType()->getScalarSizeInBits() !=
719 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
720 Index = Builder.CreateSExtOrTrunc(
721 Index, NewInsts[GEP->getOperand(0)]->getType(),
722 GEP->getOperand(0)->getName() + ".sext");
723 }
724
725 auto *Op = NewInsts[GEP->getOperand(0)];
Craig Topper781aa182018-05-05 01:57:00 +0000726 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero())
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000727 NewInsts[GEP] = Index;
728 else
729 NewInsts[GEP] = Builder.CreateNSWAdd(
730 Op, Index, GEP->getOperand(0)->getName() + ".add");
731 continue;
732 }
733 if (isa<PHINode>(Val))
734 continue;
735
736 llvm_unreachable("Unexpected instruction type");
737 }
738
739 // Add the incoming values to the PHI nodes.
740 for (Value *Val : Explored) {
741 if (Val == Base)
742 continue;
743 // All the instructions have been created, we can now add edges to the
744 // phi nodes.
745 if (auto *PHI = dyn_cast<PHINode>(Val)) {
746 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
747 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
748 Value *NewIncoming = PHI->getIncomingValue(I);
749
750 if (NewInsts.find(NewIncoming) != NewInsts.end())
751 NewIncoming = NewInsts[NewIncoming];
752
753 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
754 }
755 }
756 }
757
758 for (Value *Val : Explored) {
759 if (Val == Base)
760 continue;
761
762 // Depending on the type, for external users we have to emit
763 // a GEP or a GEP + ptrtoint.
764 setInsertionPoint(Builder, Val, false);
765
766 // If required, create an inttoptr instruction for Base.
767 Value *NewBase = Base;
768 if (!Base->getType()->isPointerTy())
769 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
770 Start->getName() + "to.ptr");
771
772 Value *GEP = Builder.CreateInBoundsGEP(
773 Start->getType()->getPointerElementType(), NewBase,
774 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
775
776 if (!Val->getType()->isPointerTy()) {
777 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
778 Val->getName() + ".conv");
779 GEP = Cast;
780 }
781 Val->replaceAllUsesWith(GEP);
782 }
783
784 return NewInsts[Start];
785}
786
787/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
788/// the input Value as a constant indexed GEP. Returns a pair containing
789/// the GEPs Pointer and Index.
790static std::pair<Value *, Value *>
791getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
792 Type *IndexType = IntegerType::get(V->getContext(),
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000793 DL.getIndexTypeSizeInBits(V->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000794
795 Constant *Index = ConstantInt::getNullValue(IndexType);
796 while (true) {
797 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
798 // We accept only inbouds GEPs here to exclude the possibility of
799 // overflow.
800 if (!GEP->isInBounds())
801 break;
802 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
803 GEP->getType() == V->getType()) {
804 V = GEP->getOperand(0);
805 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
806 Index = ConstantExpr::getAdd(
807 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
808 continue;
809 }
810 break;
811 }
812 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
813 if (!CI->isNoopCast(DL))
814 break;
815 V = CI->getOperand(0);
816 continue;
817 }
818 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
819 if (!CI->isNoopCast(DL))
820 break;
821 V = CI->getOperand(0);
822 continue;
823 }
824 break;
825 }
826 return {V, Index};
827}
828
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000829/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
830/// We can look through PHIs, GEPs and casts in order to determine a common base
831/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000832static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
833 ICmpInst::Predicate Cond,
834 const DataLayout &DL) {
835 if (!GEPLHS->hasAllConstantIndices())
836 return nullptr;
837
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000838 // Make sure the pointers have the same type.
839 if (GEPLHS->getType() != RHS->getType())
840 return nullptr;
841
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000842 Value *PtrBase, *Index;
843 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
844
845 // The set of nodes that will take part in this transformation.
846 SetVector<Value *> Nodes;
847
848 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
849 return nullptr;
850
851 // We know we can re-write this as
852 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
853 // Since we've only looked through inbouds GEPs we know that we
854 // can't have overflow on either side. We can therefore re-write
855 // this as:
856 // OFFSET1 cmp OFFSET2
857 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
858
859 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
860 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
861 // offset. Since Index is the offset of LHS to the base pointer, we will now
862 // compare the offsets instead of comparing the pointers.
863 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
864}
865
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000866/// Fold comparisons between a GEP instruction and something else. At this point
867/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000868Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000869 ICmpInst::Predicate Cond,
870 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000871 // Don't transform signed compares of GEPs into index compares. Even if the
872 // GEP is inbounds, the final add of the base pointer can have signed overflow
873 // and would change the result of the icmp.
874 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000875 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000876 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000877 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000878
Matt Arsenault44f60d02014-06-09 19:20:29 +0000879 // Look through bitcasts and addrspacecasts. We do not however want to remove
880 // 0 GEPs.
881 if (!isa<GetElementPtrInst>(RHS))
882 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000883
884 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000885 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000886 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
887 // This transformation (ignoring the base and scales) is valid because we
888 // know pointers can't overflow since the gep is inbounds. See if we can
889 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000890 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000891
Chris Lattner2188e402010-01-04 07:37:31 +0000892 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000893 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000894 Offset = EmitGEPOffset(GEPLHS);
895 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
896 Constant::getNullValue(Offset->getType()));
897 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
898 // If the base pointers are different, but the indices are the same, just
899 // compare the base pointer.
900 if (PtrBase != GEPRHS->getOperand(0)) {
901 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
902 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
903 GEPRHS->getOperand(0)->getType();
904 if (IndicesTheSame)
905 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
906 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
907 IndicesTheSame = false;
908 break;
909 }
910
911 // If all indices are the same, just compare the base pointers.
Jesper Antonssonc954b862018-10-01 14:59:25 +0000912 Type *BaseType = GEPLHS->getOperand(0)->getType();
913 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType())
David Majnemer5953d372013-06-29 10:28:04 +0000914 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000915
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000916 // If we're comparing GEPs with two base pointers that only differ in type
917 // and both GEPs have only constant indices or just one use, then fold
918 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000919 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000920 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
921 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
922 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000923 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000924 Value *LOffset = EmitGEPOffset(GEPLHS);
925 Value *ROffset = EmitGEPOffset(GEPRHS);
926
927 // If we looked through an addrspacecast between different sized address
928 // spaces, the LHS and RHS pointers are different sized
929 // integers. Truncate to the smaller one.
930 Type *LHSIndexTy = LOffset->getType();
931 Type *RHSIndexTy = ROffset->getType();
932 if (LHSIndexTy != RHSIndexTy) {
933 if (LHSIndexTy->getPrimitiveSizeInBits() <
934 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000935 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000936 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000937 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000938 }
939
Craig Topperbb4069e2017-07-07 23:16:26 +0000940 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
941 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000942 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000943 }
944
Chris Lattner2188e402010-01-04 07:37:31 +0000945 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000946 // different. Try convert this to an indexed compare by looking through
947 // PHIs/casts.
948 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000949 }
950
951 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000952 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000953 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +0000954 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +0000955
956 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000957 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000958 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +0000959
Stuart Hastings66a82b92011-05-14 05:55:10 +0000960 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +0000961 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
962 // If the GEPs only differ by one index, compare it.
963 unsigned NumDifferences = 0; // Keep track of # differences.
964 unsigned DiffOperand = 0; // The operand that differs.
965 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
966 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
967 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
968 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
969 // Irreconcilable differences.
970 NumDifferences = 2;
971 break;
972 } else {
973 if (NumDifferences++) break;
974 DiffOperand = i;
975 }
976 }
977
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +0000978 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +0000979 return replaceInstUsesWith(I, // No comparison is needed here.
Jesper Antonsson719fa052018-09-20 13:37:28 +0000980 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +0000981
Stuart Hastings66a82b92011-05-14 05:55:10 +0000982 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +0000983 Value *LHSV = GEPLHS->getOperand(DiffOperand);
984 Value *RHSV = GEPRHS->getOperand(DiffOperand);
985 // Make sure we do a signed comparison here.
986 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
987 }
988 }
989
990 // Only lower this if the icmp is the only user of the GEP or if we expect
991 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000992 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +0000993 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
994 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
995 Value *L = EmitGEPOffset(GEPLHS);
996 Value *R = EmitGEPOffset(GEPRHS);
997 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
998 }
999 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001000
1001 // Try convert this to an indexed compare by looking through PHIs/casts as a
1002 // last resort.
1003 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001004}
1005
Pete Cooper980a9352016-08-12 17:13:28 +00001006Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1007 const AllocaInst *Alloca,
1008 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001009 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1010
1011 // It would be tempting to fold away comparisons between allocas and any
1012 // pointer not based on that alloca (e.g. an argument). However, even
1013 // though such pointers cannot alias, they can still compare equal.
1014 //
1015 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1016 // doesn't escape we can argue that it's impossible to guess its value, and we
1017 // can therefore act as if any such guesses are wrong.
1018 //
1019 // The code below checks that the alloca doesn't escape, and that it's only
1020 // used in a comparison once (the current instruction). The
1021 // single-comparison-use condition ensures that we're trivially folding all
1022 // comparisons against the alloca consistently, and avoids the risk of
1023 // erroneously folding a comparison of the pointer with itself.
1024
1025 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1026
Pete Cooper980a9352016-08-12 17:13:28 +00001027 SmallVector<const Use *, 32> Worklist;
1028 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001029 if (Worklist.size() >= MaxIter)
1030 return nullptr;
1031 Worklist.push_back(&U);
1032 }
1033
1034 unsigned NumCmps = 0;
1035 while (!Worklist.empty()) {
1036 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001037 const Use *U = Worklist.pop_back_val();
1038 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001039 --MaxIter;
1040
1041 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1042 isa<SelectInst>(V)) {
1043 // Track the uses.
1044 } else if (isa<LoadInst>(V)) {
1045 // Loading from the pointer doesn't escape it.
1046 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001047 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001048 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1049 if (SI->getValueOperand() == U->get())
1050 return nullptr;
1051 continue;
1052 } else if (isa<ICmpInst>(V)) {
1053 if (NumCmps++)
1054 return nullptr; // Found more than one cmp.
1055 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001056 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001057 switch (Intrin->getIntrinsicID()) {
1058 // These intrinsics don't escape or compare the pointer. Memset is safe
1059 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1060 // we don't allow stores, so src cannot point to V.
1061 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001062 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1063 continue;
1064 default:
1065 return nullptr;
1066 }
1067 } else {
1068 return nullptr;
1069 }
Pete Cooper980a9352016-08-12 17:13:28 +00001070 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001071 if (Worklist.size() >= MaxIter)
1072 return nullptr;
1073 Worklist.push_back(&U);
1074 }
1075 }
1076
1077 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001078 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001079 ICI,
1080 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1081}
1082
Craig Topperbee74792018-08-20 23:04:25 +00001083/// Fold "icmp pred (X+C), X".
1084Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C,
Sanjay Patel43395062016-07-21 18:07:40 +00001085 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001086 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001087 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001088 // operators.
Craig Topperbee74792018-08-20 23:04:25 +00001089 assert(!!C && "C should not be zero!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00001090
Chris Lattner8c92b572010-01-08 17:48:19 +00001091 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001092 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1093 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1094 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Craig Topperbee74792018-08-20 23:04:25 +00001095 Constant *R = ConstantInt::get(X->getType(),
1096 APInt::getMaxValue(C.getBitWidth()) - C);
Chris Lattner2188e402010-01-04 07:37:31 +00001097 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1098 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001099
Chris Lattner2188e402010-01-04 07:37:31 +00001100 // (X+1) >u X --> X <u (0-1) --> X != 255
1101 // (X+2) >u X --> X <u (0-2) --> X <u 254
1102 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001103 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Craig Topperbee74792018-08-20 23:04:25 +00001104 return new ICmpInst(ICmpInst::ICMP_ULT, X,
1105 ConstantInt::get(X->getType(), -C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001106
Craig Topperbee74792018-08-20 23:04:25 +00001107 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth());
Chris Lattner2188e402010-01-04 07:37:31 +00001108
1109 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1110 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1111 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1112 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1113 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1114 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001115 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Craig Topperbee74792018-08-20 23:04:25 +00001116 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1117 ConstantInt::get(X->getType(), SMax - C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001118
Chris Lattner2188e402010-01-04 07:37:31 +00001119 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1120 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1121 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1122 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1123 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1124 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001125
Chris Lattner2188e402010-01-04 07:37:31 +00001126 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbee74792018-08-20 23:04:25 +00001127 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1128 ConstantInt::get(X->getType(), SMax - (C - 1)));
Chris Lattner2188e402010-01-04 07:37:31 +00001129}
1130
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001131/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1132/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1133/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1134Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1135 const APInt &AP1,
1136 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001137 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1138
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001139 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1140 if (I.getPredicate() == I.ICMP_NE)
1141 Pred = CmpInst::getInversePredicate(Pred);
1142 return new ICmpInst(Pred, LHS, RHS);
1143 };
1144
David Majnemer2abb8182014-10-25 07:13:13 +00001145 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001146 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001147 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001148
1149 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001150 if (IsAShr) {
1151 if (AP2.isAllOnesValue())
1152 return nullptr;
1153 if (AP2.isNegative() != AP1.isNegative())
1154 return nullptr;
1155 if (AP2.sgt(AP1))
1156 return nullptr;
1157 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001158
David Majnemerd2056022014-10-21 19:51:55 +00001159 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001160 // 'A' must be large enough to shift out the highest set bit.
1161 return getICmp(I.ICMP_UGT, A,
1162 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001163
David Majnemerd2056022014-10-21 19:51:55 +00001164 if (AP1 == AP2)
1165 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001166
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001167 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001168 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001169 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001170 else
David Majnemere5977eb2015-09-19 00:48:26 +00001171 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001172
David Majnemerd2056022014-10-21 19:51:55 +00001173 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001174 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1175 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001176 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001177 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1178 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001179 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001180 } else if (AP1 == AP2.lshr(Shift)) {
1181 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1182 }
David Majnemerd2056022014-10-21 19:51:55 +00001183 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001184
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001185 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001186 // FIXME: This should always be handled by InstSimplify?
1187 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1188 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001189}
Chris Lattner2188e402010-01-04 07:37:31 +00001190
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001191/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1192/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1193Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1194 const APInt &AP1,
1195 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001196 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1197
David Majnemer59939ac2014-10-19 08:23:08 +00001198 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1199 if (I.getPredicate() == I.ICMP_NE)
1200 Pred = CmpInst::getInversePredicate(Pred);
1201 return new ICmpInst(Pred, LHS, RHS);
1202 };
1203
David Majnemer2abb8182014-10-25 07:13:13 +00001204 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001205 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001206 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001207
1208 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1209
1210 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001211 return getICmp(
1212 I.ICMP_UGE, A,
1213 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001214
1215 if (AP1 == AP2)
1216 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1217
1218 // Get the distance between the lowest bits that are set.
1219 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1220
1221 if (Shift > 0 && AP2.shl(Shift) == AP1)
1222 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1223
1224 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001225 // FIXME: This should always be handled by InstSimplify?
1226 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1227 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001228}
1229
Sanjay Patel06b127a2016-09-15 14:37:50 +00001230/// The caller has matched a pattern of the form:
1231/// I = icmp ugt (add (add A, B), CI2), CI1
1232/// If this is of the form:
1233/// sum = a + b
1234/// if (sum+128 >u 255)
1235/// Then replace it with llvm.sadd.with.overflow.i8.
1236///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001237static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001238 ConstantInt *CI2, ConstantInt *CI1,
1239 InstCombiner &IC) {
1240 // The transformation we're trying to do here is to transform this into an
1241 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1242 // with a narrower add, and discard the add-with-constant that is part of the
1243 // range check (if we can't eliminate it, this isn't profitable).
1244
1245 // In order to eliminate the add-with-constant, the compare can be its only
1246 // use.
1247 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1248 if (!AddWithCst->hasOneUse())
1249 return nullptr;
1250
1251 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1252 if (!CI2->getValue().isPowerOf2())
1253 return nullptr;
1254 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1255 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1256 return nullptr;
1257
1258 // The width of the new add formed is 1 more than the bias.
1259 ++NewWidth;
1260
1261 // Check to see that CI1 is an all-ones value with NewWidth bits.
1262 if (CI1->getBitWidth() == NewWidth ||
1263 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1264 return nullptr;
1265
1266 // This is only really a signed overflow check if the inputs have been
1267 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1268 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1269 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1270 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1271 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1272 return nullptr;
1273
1274 // In order to replace the original add with a narrower
1275 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1276 // and truncates that discard the high bits of the add. Verify that this is
1277 // the case.
1278 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1279 for (User *U : OrigAdd->users()) {
1280 if (U == AddWithCst)
1281 continue;
1282
1283 // Only accept truncates for now. We would really like a nice recursive
1284 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1285 // chain to see which bits of a value are actually demanded. If the
1286 // original add had another add which was then immediately truncated, we
1287 // could still do the transformation.
1288 TruncInst *TI = dyn_cast<TruncInst>(U);
1289 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1290 return nullptr;
1291 }
1292
1293 // If the pattern matches, truncate the inputs to the narrower type and
1294 // use the sadd_with_overflow intrinsic to efficiently compute both the
1295 // result and the overflow bit.
1296 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
1297 Value *F = Intrinsic::getDeclaration(I.getModule(),
1298 Intrinsic::sadd_with_overflow, NewType);
1299
Craig Topperbb4069e2017-07-07 23:16:26 +00001300 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001301
1302 // Put the new code above the original add, in case there are any uses of the
1303 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001304 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001305
Craig Topperbb4069e2017-07-07 23:16:26 +00001306 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1307 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1308 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1309 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1310 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001311
1312 // The inner add was the result of the narrow add, zero extended to the
1313 // wider type. Replace it with the result computed by the intrinsic.
1314 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1315
1316 // The original icmp gets replaced with the overflow value.
1317 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1318}
1319
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001320// Handle (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
1321Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) {
1322 CmpInst::Predicate Pred = Cmp.getPredicate();
1323 Value *X = Cmp.getOperand(0);
1324
1325 if (match(Cmp.getOperand(1), m_Zero()) && Pred == ICmpInst::ICMP_SGT) {
1326 Value *A, *B;
1327 SelectPatternResult SPR = matchSelectPattern(X, A, B);
1328 if (SPR.Flavor == SPF_SMIN) {
1329 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
1330 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1331 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
1332 return new ICmpInst(Pred, A, Cmp.getOperand(1));
1333 }
1334 }
1335 return nullptr;
1336}
1337
Sanjay Patel06b127a2016-09-15 14:37:50 +00001338// Fold icmp Pred X, C.
Sanjay Patel97459832016-09-15 15:11:12 +00001339Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
1340 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001341 Value *X = Cmp.getOperand(0);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001342
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001343 const APInt *C;
1344 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel97459832016-09-15 15:11:12 +00001345 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001346
Sanjay Patel97459832016-09-15 15:11:12 +00001347 Value *A = nullptr, *B = nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001348
Sanjay Patel97459832016-09-15 15:11:12 +00001349 // Match the following pattern, which is a common idiom when writing
1350 // overflow-safe integer arithmetic functions. The source performs an addition
1351 // in wider type and explicitly checks for overflow using comparisons against
1352 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1353 //
1354 // TODO: This could probably be generalized to handle other overflow-safe
1355 // operations if we worked out the formulas to compute the appropriate magic
1356 // constants.
1357 //
1358 // sum = a + b
1359 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
1360 {
1361 ConstantInt *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1362 if (Pred == ICmpInst::ICMP_UGT &&
1363 match(X, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001364 if (Instruction *Res = processUGT_ADDCST_ADD(
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001365 Cmp, A, B, CI2, cast<ConstantInt>(Cmp.getOperand(1)), *this))
Sanjay Patel97459832016-09-15 15:11:12 +00001366 return Res;
1367 }
Sanjay Patel06b127a2016-09-15 14:37:50 +00001368
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001369 // FIXME: Use m_APInt to allow folds for splat constants.
1370 ConstantInt *CI = dyn_cast<ConstantInt>(Cmp.getOperand(1));
1371 if (!CI)
1372 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001373
Sanjay Patel97459832016-09-15 15:11:12 +00001374 // Canonicalize icmp instructions based on dominating conditions.
1375 BasicBlock *Parent = Cmp.getParent();
1376 BasicBlock *Dom = Parent->getSinglePredecessor();
1377 auto *BI = Dom ? dyn_cast<BranchInst>(Dom->getTerminator()) : nullptr;
1378 ICmpInst::Predicate Pred2;
1379 BasicBlock *TrueBB, *FalseBB;
1380 ConstantInt *CI2;
1381 if (BI && match(BI, m_Br(m_ICmp(Pred2, m_Specific(X), m_ConstantInt(CI2)),
1382 TrueBB, FalseBB)) &&
1383 TrueBB != FalseBB) {
1384 ConstantRange CR =
1385 ConstantRange::makeAllowedICmpRegion(Pred, CI->getValue());
1386 ConstantRange DominatingCR =
1387 (Parent == TrueBB)
1388 ? ConstantRange::makeExactICmpRegion(Pred2, CI2->getValue())
1389 : ConstantRange::makeExactICmpRegion(
1390 CmpInst::getInversePredicate(Pred2), CI2->getValue());
1391 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1392 ConstantRange Difference = DominatingCR.difference(CR);
1393 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001394 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001395 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001396 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001397
Sanjay Patel97459832016-09-15 15:11:12 +00001398 // If this is a normal comparison, it demands all bits. If it is a sign
1399 // bit comparison, it only demands the sign bit.
1400 bool UnusedBit;
1401 bool IsSignBit = isSignBitCheck(Pred, CI->getValue(), UnusedBit);
1402
1403 // Canonicalizing a sign bit comparison that gets used in a branch,
1404 // pessimizes codegen by generating branch on zero instruction instead
1405 // of a test and branch. So we avoid canonicalizing in such situations
1406 // because test and branch instruction has better branch displacement
1407 // than compare and branch instruction.
Eric Christophera95aac32017-06-30 01:57:48 +00001408 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1409 return nullptr;
1410
1411 if (auto *AI = Intersection.getSingleElement())
Craig Topperbb4069e2017-07-07 23:16:26 +00001412 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*AI));
Eric Christophera95aac32017-06-30 01:57:48 +00001413 if (auto *AD = Difference.getSingleElement())
Craig Topperbb4069e2017-07-07 23:16:26 +00001414 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*AD));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001415 }
1416
1417 return nullptr;
1418}
1419
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001420/// Fold icmp (trunc X, Y), C.
1421Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001422 TruncInst *Trunc,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001423 const APInt &C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001424 ICmpInst::Predicate Pred = Cmp.getPredicate();
1425 Value *X = Trunc->getOperand(0);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001426 if (C.isOneValue() && C.getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001427 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1428 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001429 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001430 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1431 ConstantInt::get(V->getType(), 1));
1432 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001433
1434 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001435 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1436 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001437 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1438 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001439 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001440
1441 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001442 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001443 // Pull in the high bits from known-ones set.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001444 APInt NewRHS = C.zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001445 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001446 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001447 }
1448 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001449
Sanjay Patela3f4f082016-08-16 17:54:36 +00001450 return nullptr;
1451}
1452
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001453/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001454Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1455 BinaryOperator *Xor,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001456 const APInt &C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001457 Value *X = Xor->getOperand(0);
1458 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001459 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001460 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001461 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001462
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001463 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1464 // fold the xor.
1465 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topperdf63b962017-10-03 19:14:23 +00001466 bool TrueIfSigned = false;
1467 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001468
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001469 // If the sign bit of the XorCst is not set, there is no change to
1470 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001471 if (!XorC->isNegative()) {
1472 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001473 Worklist.Add(Xor);
1474 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001475 }
1476
Craig Topperdf63b962017-10-03 19:14:23 +00001477 // Emit the opposite comparison.
1478 if (TrueIfSigned)
1479 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1480 ConstantInt::getAllOnesValue(X->getType()));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001481 else
Craig Topperdf63b962017-10-03 19:14:23 +00001482 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1483 ConstantInt::getNullValue(X->getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001484 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001485
1486 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001487 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1488 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001489 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1490 : Cmp.getSignedPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001491 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001492 }
1493
Craig Topperbcfd2d12017-04-20 16:56:25 +00001494 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001495 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1496 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1497 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001498 Pred = Cmp.getSwappedPredicate(Pred);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001499 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001500 }
1501 }
1502
Sanjay Patel26725bd2018-09-11 22:00:15 +00001503 // Mask constant magic can eliminate an 'xor' with unsigned compares.
1504 if (Pred == ICmpInst::ICMP_UGT) {
1505 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2)
1506 if (*XorC == ~C && (C + 1).isPowerOf2())
1507 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
1508 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2)
1509 if (*XorC == C && (C + 1).isPowerOf2())
1510 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
1511 }
1512 if (Pred == ICmpInst::ICMP_ULT) {
1513 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2)
1514 if (*XorC == -C && C.isPowerOf2())
1515 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1516 ConstantInt::get(X->getType(), ~C));
1517 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2)
1518 if (*XorC == C && (-C).isPowerOf2())
1519 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1520 ConstantInt::get(X->getType(), ~C));
1521 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001522 return nullptr;
1523}
1524
Sanjay Patel14e0e182016-08-26 18:28:46 +00001525/// Fold icmp (and (sh X, Y), C2), C1.
1526Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001527 const APInt &C1, const APInt &C2) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001528 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1529 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001530 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001531
Sanjay Patelda9c5622016-08-26 17:15:22 +00001532 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1533 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1534 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001535 // This seemingly simple opportunity to fold away a shift turns out to be
1536 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001537 unsigned ShiftOpcode = Shift->getOpcode();
1538 bool IsShl = ShiftOpcode == Instruction::Shl;
1539 const APInt *C3;
1540 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001541 bool CanFold = false;
Craig Topper7a930922017-10-04 23:06:13 +00001542 if (ShiftOpcode == Instruction::Shl) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001543 // For a left shift, we can fold if the comparison is not signed. We can
1544 // also fold a signed comparison if the mask value and comparison value
1545 // are not negative. These constraints may not be obvious, but we can
1546 // prove that they are correct using an SMT solver.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001547 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001548 CanFold = true;
Craig Topper7a930922017-10-04 23:06:13 +00001549 } else {
1550 bool IsAshr = ShiftOpcode == Instruction::AShr;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001551 // For a logical right shift, we can fold if the comparison is not signed.
1552 // We can also fold a signed comparison if the shifted mask value and the
1553 // shifted comparison value are not negative. These constraints may not be
1554 // obvious, but we can prove that they are correct using an SMT solver.
Craig Topper7a930922017-10-04 23:06:13 +00001555 // For an arithmetic shift right we can do the same, if we ensure
1556 // the And doesn't use any bits being shifted in. Normally these would
1557 // be turned into lshr by SimplifyDemandedBits, but not if there is an
1558 // additional user.
1559 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) {
1560 if (!Cmp.isSigned() ||
1561 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative()))
1562 CanFold = true;
1563 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001564 }
1565
Sanjay Patelda9c5622016-08-26 17:15:22 +00001566 if (CanFold) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001567 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001568 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001569 // Check to see if we are shifting out any of the bits being compared.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001570 if (SameAsC1 != C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001571 // If we shifted bits out, the fold is not going to work out. As a
1572 // special case, check to see if this means that the result is always
1573 // true or false now.
1574 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001575 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001576 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001577 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001578 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001579 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
Craig Topper8ed1aa92017-10-03 05:31:07 +00001580 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001581 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001582 And->setOperand(0, Shift->getOperand(0));
1583 Worklist.Add(Shift); // Shift is dead.
1584 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001585 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001586 }
1587 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001588
Sanjay Patelda9c5622016-08-26 17:15:22 +00001589 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1590 // preferable because it allows the C2 << Y expression to be hoisted out of a
1591 // loop if Y is invariant and X is not.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001592 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001593 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1594 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001595 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001596 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1597 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001598
Sanjay Patelda9c5622016-08-26 17:15:22 +00001599 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001600 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001601 Cmp.setOperand(0, NewAnd);
1602 return &Cmp;
1603 }
1604
Sanjay Patel14e0e182016-08-26 18:28:46 +00001605 return nullptr;
1606}
1607
1608/// Fold icmp (and X, C2), C1.
1609Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1610 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001611 const APInt &C1) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001612 const APInt *C2;
1613 if (!match(And->getOperand(1), m_APInt(C2)))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001614 return nullptr;
1615
Craig Topper8bf62212017-09-26 18:47:25 +00001616 if (!And->hasOneUse())
Sanjay Patel14e0e182016-08-26 18:28:46 +00001617 return nullptr;
1618
Sanjay Patel6b490972016-09-04 14:32:15 +00001619 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1620 // the input width without changing the value produced, eliminate the cast:
1621 //
1622 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1623 //
1624 // We can do this transformation if the constants do not have their sign bits
1625 // set or if it is an equality comparison. Extending a relational comparison
1626 // when we're checking the sign bit would not work.
1627 Value *W;
Craig Topper8bf62212017-09-26 18:47:25 +00001628 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001629 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001630 // TODO: Is this a good transform for vectors? Wider types may reduce
1631 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001632 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001633 if (!Cmp.getType()->isVectorTy()) {
1634 Type *WideType = W->getType();
1635 unsigned WideScalarBits = WideType->getScalarSizeInBits();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001636 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits));
Sanjay Patel6b490972016-09-04 14:32:15 +00001637 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001638 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001639 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001640 }
1641 }
1642
Craig Topper8ed1aa92017-10-03 05:31:07 +00001643 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001644 return I;
1645
Sanjay Patelda9c5622016-08-26 17:15:22 +00001646 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001647 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001648 //
1649 // iff pred isn't signed
Craig Topper8ed1aa92017-10-03 05:31:07 +00001650 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() &&
Craig Topper73ba1c82017-06-07 07:40:37 +00001651 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001652 Constant *One = cast<Constant>(And->getOperand(1));
1653 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001654 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001655 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1656 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1657 unsigned UsesRemoved = 0;
1658 if (And->hasOneUse())
1659 ++UsesRemoved;
1660 if (Or->hasOneUse())
1661 ++UsesRemoved;
1662 if (LShr->hasOneUse())
1663 ++UsesRemoved;
1664
1665 // Compute A & ((1 << B) | 1)
1666 Value *NewOr = nullptr;
1667 if (auto *C = dyn_cast<Constant>(B)) {
1668 if (UsesRemoved >= 1)
1669 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1670 } else {
1671 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001672 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1673 /*HasNUW=*/true),
1674 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001675 }
1676 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001677 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001678 Cmp.setOperand(0, NewAnd);
1679 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001680 }
1681 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001682 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001683
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001684 return nullptr;
1685}
1686
1687/// Fold icmp (and X, Y), C.
1688Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1689 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001690 const APInt &C) {
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001691 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1692 return I;
1693
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001694 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001695
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001696 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1697 Value *X = And->getOperand(0);
1698 Value *Y = And->getOperand(1);
1699 if (auto *LI = dyn_cast<LoadInst>(X))
1700 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1701 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001702 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001703 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1704 ConstantInt *C2 = cast<ConstantInt>(Y);
1705 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001706 return Res;
1707 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001708
1709 if (!Cmp.isEquality())
1710 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001711
1712 // X & -C == -C -> X > u ~C
1713 // X & -C != -C -> X <= u ~C
1714 // iff C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001715 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001716 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1717 : CmpInst::ICMP_ULE;
1718 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1719 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001720
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001721 // (X & C2) == 0 -> (trunc X) >= 0
1722 // (X & C2) != 0 -> (trunc X) < 0
1723 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1724 const APInt *C2;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001725 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001726 int32_t ExactLogBase2 = C2->exactLogBase2();
1727 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1728 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1729 if (And->getType()->isVectorTy())
1730 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001731 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001732 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1733 : CmpInst::ICMP_SLT;
1734 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001735 }
1736 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001737
Sanjay Patela3f4f082016-08-16 17:54:36 +00001738 return nullptr;
1739}
1740
Sanjay Patel943e92e2016-08-17 16:30:43 +00001741/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001742Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001743 const APInt &C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001744 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001745 if (C.isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001746 // icmp slt signum(V) 1 --> icmp slt V, 1
1747 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001748 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001749 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1750 ConstantInt::get(V->getType(), 1));
1751 }
1752
Sanjay Patel50c82c42017-04-05 17:57:05 +00001753 // X | C == C --> X <=u C
1754 // X | C != C --> X >u C
1755 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1756 if (Cmp.isEquality() && Cmp.getOperand(1) == Or->getOperand(1) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001757 (C + 1).isPowerOf2()) {
Sanjay Patel50c82c42017-04-05 17:57:05 +00001758 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1759 return new ICmpInst(Pred, Or->getOperand(0), Or->getOperand(1));
1760 }
1761
Craig Topper8ed1aa92017-10-03 05:31:07 +00001762 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001763 return nullptr;
1764
1765 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001766 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001767 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1768 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001769 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001770 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001771 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001772 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001773 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1774 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1775 }
1776
1777 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1778 // a shorter form that has more potential to be folded even further.
1779 Value *X1, *X2, *X3, *X4;
1780 if (match(Or->getOperand(0), m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1781 match(Or->getOperand(1), m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
1782 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1783 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1784 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1785 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1786 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1787 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001788 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001789
Sanjay Patela3f4f082016-08-16 17:54:36 +00001790 return nullptr;
1791}
1792
Sanjay Patel63478072016-08-18 15:44:44 +00001793/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001794Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1795 BinaryOperator *Mul,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001796 const APInt &C) {
Sanjay Patel63478072016-08-18 15:44:44 +00001797 const APInt *MulC;
1798 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001799 return nullptr;
1800
Sanjay Patel63478072016-08-18 15:44:44 +00001801 // If this is a test of the sign bit and the multiply is sign-preserving with
1802 // a constant operand, use the multiply LHS operand instead.
1803 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001804 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001805 if (MulC->isNegative())
1806 Pred = ICmpInst::getSwappedPredicate(Pred);
1807 return new ICmpInst(Pred, Mul->getOperand(0),
1808 Constant::getNullValue(Mul->getType()));
1809 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001810
1811 return nullptr;
1812}
1813
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001814/// Fold icmp (shl 1, Y), C.
1815static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001816 const APInt &C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001817 Value *Y;
1818 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1819 return nullptr;
1820
1821 Type *ShiftType = Shl->getType();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001822 unsigned TypeBits = C.getBitWidth();
1823 bool CIsPowerOf2 = C.isPowerOf2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001824 ICmpInst::Predicate Pred = Cmp.getPredicate();
1825 if (Cmp.isUnsigned()) {
1826 // (1 << Y) pred C -> Y pred Log2(C)
1827 if (!CIsPowerOf2) {
1828 // (1 << Y) < 30 -> Y <= 4
1829 // (1 << Y) <= 30 -> Y <= 4
1830 // (1 << Y) >= 30 -> Y > 4
1831 // (1 << Y) > 30 -> Y > 4
1832 if (Pred == ICmpInst::ICMP_ULT)
1833 Pred = ICmpInst::ICMP_ULE;
1834 else if (Pred == ICmpInst::ICMP_UGE)
1835 Pred = ICmpInst::ICMP_UGT;
1836 }
1837
1838 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1839 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
Craig Topper8ed1aa92017-10-03 05:31:07 +00001840 unsigned CLog2 = C.logBase2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001841 if (CLog2 == TypeBits - 1) {
1842 if (Pred == ICmpInst::ICMP_UGE)
1843 Pred = ICmpInst::ICMP_EQ;
1844 else if (Pred == ICmpInst::ICMP_ULT)
1845 Pred = ICmpInst::ICMP_NE;
1846 }
1847 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1848 } else if (Cmp.isSigned()) {
1849 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001850 if (C.isAllOnesValue()) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001851 // (1 << Y) <= -1 -> Y == 31
1852 if (Pred == ICmpInst::ICMP_SLE)
1853 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1854
1855 // (1 << Y) > -1 -> Y != 31
1856 if (Pred == ICmpInst::ICMP_SGT)
1857 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001858 } else if (!C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001859 // (1 << Y) < 0 -> Y == 31
1860 // (1 << Y) <= 0 -> Y == 31
1861 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1862 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1863
1864 // (1 << Y) >= 0 -> Y != 31
1865 // (1 << Y) > 0 -> Y != 31
1866 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1867 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1868 }
1869 } else if (Cmp.isEquality() && CIsPowerOf2) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001870 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2()));
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001871 }
1872
1873 return nullptr;
1874}
1875
Sanjay Patel38b75062016-08-19 17:20:37 +00001876/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001877Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1878 BinaryOperator *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001879 const APInt &C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001880 const APInt *ShiftVal;
1881 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00001882 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001883
Sanjay Patelfa7de602016-08-19 22:33:26 +00001884 const APInt *ShiftAmt;
1885 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00001886 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00001887
Sanjay Patel38b75062016-08-19 17:20:37 +00001888 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00001889 // shifts. When the shift is visited, it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001890 unsigned TypeBits = C.getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00001891 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001892 return nullptr;
1893
Sanjay Patele38e79c2016-08-19 17:34:05 +00001894 ICmpInst::Predicate Pred = Cmp.getPredicate();
1895 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00001896 Type *ShType = Shl->getType();
1897
Sanjay Patel291c3d82017-01-19 16:12:10 +00001898 // NSW guarantees that we are only shifting out sign bits from the high bits,
1899 // so we can ASHR the compare constant without needing a mask and eliminate
1900 // the shift.
1901 if (Shl->hasNoSignedWrap()) {
1902 if (Pred == ICmpInst::ICMP_SGT) {
1903 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001904 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001905 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1906 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00001907 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
1908 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001909 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001910 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1911 }
1912 if (Pred == ICmpInst::ICMP_SLT) {
1913 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
1914 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
1915 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
1916 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
Craig Topper8ed1aa92017-10-03 05:31:07 +00001917 assert(!C.isMinSignedValue() && "Unexpected icmp slt");
1918 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1;
Sanjay Patel291c3d82017-01-19 16:12:10 +00001919 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1920 }
1921 // If this is a signed comparison to 0 and the shift is sign preserving,
1922 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
1923 // do that if we're sure to not continue on in this function.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001924 if (isSignTest(Pred, C))
Sanjay Patel291c3d82017-01-19 16:12:10 +00001925 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
1926 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001927
Sanjay Patel291c3d82017-01-19 16:12:10 +00001928 // NUW guarantees that we are only shifting out zero bits from the high bits,
1929 // so we can LSHR the compare constant without needing a mask and eliminate
1930 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00001931 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00001932 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00001933 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001934 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patel14715b32017-01-17 21:25:16 +00001935 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1936 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00001937 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
1938 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001939 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patelae23d652017-01-18 21:16:12 +00001940 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1941 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001942 if (Pred == ICmpInst::ICMP_ULT) {
1943 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
1944 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
1945 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
1946 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
Craig Topper8ed1aa92017-10-03 05:31:07 +00001947 assert(C.ugt(0) && "ult 0 should have been eliminated");
1948 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1;
Sanjay Patel14715b32017-01-17 21:25:16 +00001949 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1950 }
1951 }
1952
Sanjay Patel291c3d82017-01-19 16:12:10 +00001953 if (Cmp.isEquality() && Shl->hasOneUse()) {
1954 // Strength-reduce the shift into an 'and'.
1955 Constant *Mask = ConstantInt::get(
1956 ShType,
1957 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00001958 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Craig Topper8ed1aa92017-10-03 05:31:07 +00001959 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00001960 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001961 }
1962
Sanjay Patela3f4f082016-08-16 17:54:36 +00001963 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
1964 bool TrueIfSigned = false;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001965 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00001966 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00001967 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00001968 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00001969 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00001970 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00001971 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00001972 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00001973 }
1974
Sanjay Patel643d21a2016-08-21 17:10:07 +00001975 // Transform (icmp pred iM (shl iM %v, N), C)
1976 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
1977 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00001978 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00001979 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00001980 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00001981 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001982 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt &&
Sanjay Patelf3dda132016-10-25 20:11:47 +00001983 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00001984 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00001985 if (ShType->isVectorTy())
1986 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00001987 Constant *NewC =
Craig Topper8ed1aa92017-10-03 05:31:07 +00001988 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00001989 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001990 }
1991
1992 return nullptr;
1993}
1994
Sanjay Patela3920492016-08-22 20:45:06 +00001995/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001996Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
1997 BinaryOperator *Shr,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001998 const APInt &C) {
Sanjay Patela3920492016-08-22 20:45:06 +00001999 // An exact shr only shifts out zero bits, so:
2000 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00002001 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00002002 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00002003 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00002004 C.isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00002005 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00002006
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002007 const APInt *ShiftVal;
2008 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002009 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002010
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002011 const APInt *ShiftAmt;
2012 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002013 return nullptr;
2014
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002015 // Check that the shift amount is in range. If not, don't perform undefined
2016 // shifts. When the shift is visited it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002017 unsigned TypeBits = C.getBitWidth();
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002018 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002019 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2020 return nullptr;
2021
Sanjay Pateld64e9882016-08-23 22:05:55 +00002022 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002023 bool IsExact = Shr->isExact();
2024 Type *ShrTy = Shr->getType();
2025 // TODO: If we could guarantee that InstSimplify would handle all of the
2026 // constant-value-based preconditions in the folds below, then we could assert
2027 // those conditions rather than checking them. This is difficult because of
2028 // undef/poison (PR34838).
2029 if (IsAShr) {
2030 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) {
2031 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC)
2032 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC)
2033 APInt ShiftedC = C.shl(ShAmtVal);
2034 if (ShiftedC.ashr(ShAmtVal) == C)
2035 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2036 }
2037 if (Pred == CmpInst::ICMP_SGT) {
2038 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1
2039 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2040 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() &&
2041 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1))
2042 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2043 }
2044 } else {
2045 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) {
2046 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC)
2047 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC)
2048 APInt ShiftedC = C.shl(ShAmtVal);
2049 if (ShiftedC.lshr(ShAmtVal) == C)
2050 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2051 }
2052 if (Pred == CmpInst::ICMP_UGT) {
2053 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1
2054 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2055 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1))
2056 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2057 }
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002058 }
2059
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002060 if (!Cmp.isEquality())
2061 return nullptr;
2062
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002063 // Handle equality comparisons of shift-by-constant.
2064
Sanjay Patel8e297742016-08-24 13:55:55 +00002065 // If the comparison constant changes with the shift, the comparison cannot
2066 // succeed (bits of the comparison constant cannot match the shifted value).
2067 // This should be known by InstSimplify and already be folded to true/false.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002068 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) ||
2069 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) &&
Sanjay Patel8e297742016-08-24 13:55:55 +00002070 "Expected icmp+shr simplify did not occur.");
2071
Sanjay Patel934738a2017-10-15 15:39:15 +00002072 // If the bits shifted out are known zero, compare the unshifted value:
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002073 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Patel934738a2017-10-15 15:39:15 +00002074 if (Shr->isExact())
Sanjay Patel42135be2017-10-16 14:47:24 +00002075 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Patelf11b5b42017-10-05 14:26:15 +00002076
Sanjay Patel934738a2017-10-15 15:39:15 +00002077 if (Shr->hasOneUse()) {
2078 // Canonicalize the shift into an 'and':
2079 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt)
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002080 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002081 Constant *Mask = ConstantInt::get(ShrTy, Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002082 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Patel42135be2017-10-16 14:47:24 +00002083 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002084 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002085
2086 return nullptr;
2087}
2088
Sanjay Patel12a41052016-08-18 17:37:26 +00002089/// Fold icmp (udiv X, Y), C.
2090Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002091 BinaryOperator *UDiv,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002092 const APInt &C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002093 const APInt *C2;
2094 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2095 return nullptr;
2096
Craig Topper29c282e2017-06-07 07:40:29 +00002097 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002098
2099 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2100 Value *Y = UDiv->getOperand(1);
2101 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002102 assert(!C.isMaxValue() &&
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002103 "icmp ugt X, UINT_MAX should have been simplified already.");
2104 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002105 ConstantInt::get(Y->getType(), C2->udiv(C + 1)));
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002106 }
2107
2108 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2109 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002110 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002111 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002112 ConstantInt::get(Y->getType(), C2->udiv(C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002113 }
2114
2115 return nullptr;
2116}
2117
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002118/// Fold icmp ({su}div X, Y), C.
2119Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2120 BinaryOperator *Div,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002121 const APInt &C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002122 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002123 // Fold this div into the comparison, producing a range check.
2124 // Determine, based on the divide type, what the range is being
2125 // checked. If there is an overflow on the low or high side, remember
2126 // it, otherwise compute the range [low, hi) bounding the new value.
2127 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002128 const APInt *C2;
2129 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002130 return nullptr;
2131
Sanjay Patel16554142016-08-24 23:03:36 +00002132 // FIXME: If the operand types don't match the type of the divide
2133 // then don't attempt this transform. The code below doesn't have the
2134 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002135 // vice versa). This is because (x /s C2) <s C produces different
2136 // results than (x /s C2) <u C or (x /u C2) <s C or even
2137 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002138 // work. :( The if statement below tests that condition and bails
2139 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002140 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2141 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002142 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002143
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002144 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2145 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2146 // division-by-constant cases should be present, we can not assert that they
2147 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002148 if (C2->isNullValue() || C2->isOneValue() ||
2149 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002150 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002151
Craig Topper6e025a32017-10-01 23:53:54 +00002152 // Compute Prod = C * C2. We are essentially solving an equation of
2153 // form X / C2 = C. We solve for X by multiplying C2 and C.
Sanjay Patel541aef42016-08-31 21:57:21 +00002154 // By solving for X, we can turn this into a range check instead of computing
2155 // a divide.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002156 APInt Prod = C * *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002157
Sanjay Patel541aef42016-08-31 21:57:21 +00002158 // Determine if the product overflows by seeing if the product is not equal to
2159 // the divide. Make sure we do the same kind of divide as in the LHS
2160 // instruction that we're folding.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002161 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C;
Sanjay Patel16554142016-08-24 23:03:36 +00002162
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002163 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002164
2165 // If the division is known to be exact, then there is no remainder from the
2166 // divide, so the covered range size is unit, otherwise it is the divisor.
Craig Topper6e025a32017-10-01 23:53:54 +00002167 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002168
2169 // Figure out the interval that is being checked. For example, a comparison
2170 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2171 // Compute this interval based on the constants involved and the signedness of
2172 // the compare/divide. This computes a half-open interval, keeping track of
2173 // whether either value in the interval overflows. After analysis each
2174 // overflow variable is set to 0 if it's corresponding bound variable is valid
2175 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2176 int LoOverflow = 0, HiOverflow = 0;
Craig Topper6e025a32017-10-01 23:53:54 +00002177 APInt LoBound, HiBound;
Sanjay Patel16554142016-08-24 23:03:36 +00002178
2179 if (!DivIsSigned) { // udiv
2180 // e.g. X/5 op 3 --> [15, 20)
2181 LoBound = Prod;
2182 HiOverflow = LoOverflow = ProdOV;
2183 if (!HiOverflow) {
2184 // If this is not an exact divide, then many values in the range collapse
2185 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002186 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002187 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002188 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002189 if (C.isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002190 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
Craig Topper6e025a32017-10-01 23:53:54 +00002191 LoBound = -(RangeSize - 1);
Sanjay Patel16554142016-08-24 23:03:36 +00002192 HiBound = RangeSize;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002193 } else if (C.isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002194 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2195 HiOverflow = LoOverflow = ProdOV;
2196 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002197 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002198 } else { // (X / pos) op neg
2199 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002200 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002201 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2202 if (!LoOverflow) {
Craig Topper6e025a32017-10-01 23:53:54 +00002203 APInt DivNeg = -RangeSize;
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002204 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002205 }
2206 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002207 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002208 if (Div->isExact())
Craig Topper6e025a32017-10-01 23:53:54 +00002209 RangeSize.negate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00002210 if (C.isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002211 // e.g. X/-5 op 0 --> [-4, 5)
Craig Topper6e025a32017-10-01 23:53:54 +00002212 LoBound = RangeSize + 1;
2213 HiBound = -RangeSize;
2214 if (HiBound == *C2) { // -INTMIN = INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002215 HiOverflow = 1; // [INTMIN+1, overflow)
Craig Topper6e025a32017-10-01 23:53:54 +00002216 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002217 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002218 } else if (C.isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002219 // e.g. X/-5 op 3 --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002220 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002221 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2222 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002223 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002224 } else { // (X / neg) op neg
2225 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2226 LoOverflow = HiOverflow = ProdOV;
2227 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002228 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002229 }
2230
2231 // Dividing by a negative swaps the condition. LT <-> GT
2232 Pred = ICmpInst::getSwappedPredicate(Pred);
2233 }
2234
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002235 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002236 switch (Pred) {
2237 default: llvm_unreachable("Unhandled icmp opcode!");
2238 case ICmpInst::ICMP_EQ:
2239 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002240 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002241 if (HiOverflow)
2242 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002243 ICmpInst::ICMP_UGE, X,
2244 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002245 if (LoOverflow)
2246 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002247 ICmpInst::ICMP_ULT, X,
2248 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel85d79742016-08-31 19:49:56 +00002249 return replaceInstUsesWith(
Craig Topper6e025a32017-10-01 23:53:54 +00002250 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002251 case ICmpInst::ICMP_NE:
2252 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002253 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002254 if (HiOverflow)
2255 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002256 ICmpInst::ICMP_ULT, X,
2257 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002258 if (LoOverflow)
2259 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002260 ICmpInst::ICMP_UGE, X,
2261 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel541aef42016-08-31 21:57:21 +00002262 return replaceInstUsesWith(Cmp,
Craig Topper6e025a32017-10-01 23:53:54 +00002263 insertRangeTest(X, LoBound, HiBound,
Sanjay Patel541aef42016-08-31 21:57:21 +00002264 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002265 case ICmpInst::ICMP_ULT:
2266 case ICmpInst::ICMP_SLT:
2267 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002268 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002269 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002270 return replaceInstUsesWith(Cmp, Builder.getFalse());
Craig Topper6e025a32017-10-01 23:53:54 +00002271 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002272 case ICmpInst::ICMP_UGT:
2273 case ICmpInst::ICMP_SGT:
2274 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002275 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002276 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002277 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002278 if (Pred == ICmpInst::ICMP_UGT)
Craig Topper6e025a32017-10-01 23:53:54 +00002279 return new ICmpInst(ICmpInst::ICMP_UGE, X,
2280 ConstantInt::get(Div->getType(), HiBound));
2281 return new ICmpInst(ICmpInst::ICMP_SGE, X,
2282 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002283 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002284
2285 return nullptr;
2286}
2287
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002288/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002289Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2290 BinaryOperator *Sub,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002291 const APInt &C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002292 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2293 ICmpInst::Predicate Pred = Cmp.getPredicate();
2294
2295 // The following transforms are only worth it if the only user of the subtract
2296 // is the icmp.
2297 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002298 return nullptr;
2299
Sanjay Patel886a5422016-09-15 18:05:17 +00002300 if (Sub->hasNoSignedWrap()) {
2301 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002302 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002303 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002304
Sanjay Patel886a5422016-09-15 18:05:17 +00002305 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002306 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002307 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2308
2309 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002310 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002311 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2312
2313 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002314 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002315 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2316 }
2317
2318 const APInt *C2;
2319 if (!match(X, m_APInt(C2)))
2320 return nullptr;
2321
2322 // C2 - Y <u C -> (Y | (C - 1)) == C2
2323 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002324 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() &&
2325 (*C2 & (C - 1)) == (C - 1))
2326 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002327
2328 // C2 - Y >u C -> (Y | C) != C2
2329 // iff C2 & C == C and C + 1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002330 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C)
2331 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002332
2333 return nullptr;
2334}
2335
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002336/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002337Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2338 BinaryOperator *Add,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002339 const APInt &C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002340 Value *Y = Add->getOperand(1);
2341 const APInt *C2;
2342 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002343 return nullptr;
2344
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002345 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002346 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002347 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002348 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002349
Tim Northover12c1f762018-09-10 14:26:44 +00002350 if (!Add->hasOneUse())
2351 return nullptr;
2352
Sanjay Patel45b7e692017-02-12 16:40:30 +00002353 // If the add does not wrap, we can always adjust the compare by subtracting
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002354 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE
2355 // are canonicalized to SGT/SLT/UGT/ULT.
2356 if ((Add->hasNoSignedWrap() &&
2357 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) ||
2358 (Add->hasNoUnsignedWrap() &&
2359 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) {
Sanjay Patel45b7e692017-02-12 16:40:30 +00002360 bool Overflow;
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002361 APInt NewC =
2362 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow);
Sanjay Patel45b7e692017-02-12 16:40:30 +00002363 // If there is overflow, the result must be true or false.
2364 // TODO: Can we assert there is no overflow because InstSimplify always
2365 // handles those cases?
2366 if (!Overflow)
2367 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2368 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2369 }
2370
Craig Topper8ed1aa92017-10-03 05:31:07 +00002371 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002372 const APInt &Upper = CR.getUpper();
2373 const APInt &Lower = CR.getLower();
2374 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002375 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002376 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002377 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002378 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002379 } else {
2380 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002381 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002382 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002383 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002384 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002385
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002386 // X+C <u C2 -> (X & -C2) == C
2387 // iff C & (C2-1) == 0
2388 // C2 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002389 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0)
2390 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002391 ConstantExpr::getNeg(cast<Constant>(Y)));
2392
2393 // X+C >u C2 -> (X & ~C2) != C
2394 // iff C & C2 == 0
2395 // C2+1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002396 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0)
2397 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002398 ConstantExpr::getNeg(cast<Constant>(Y)));
2399
Sanjay Patela3f4f082016-08-16 17:54:36 +00002400 return nullptr;
2401}
2402
Anna Thomasd67165c2017-06-23 13:41:45 +00002403bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2404 Value *&RHS, ConstantInt *&Less,
2405 ConstantInt *&Equal,
2406 ConstantInt *&Greater) {
2407 // TODO: Generalize this to work with other comparison idioms or ensure
2408 // they get canonicalized into this form.
2409
2410 // select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32
2411 // Greater), where Equal, Less and Greater are placeholders for any three
2412 // constants.
2413 ICmpInst::Predicate PredA, PredB;
2414 if (match(SI->getTrueValue(), m_ConstantInt(Equal)) &&
2415 match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) &&
2416 PredA == ICmpInst::ICMP_EQ &&
2417 match(SI->getFalseValue(),
2418 m_Select(m_ICmp(PredB, m_Specific(LHS), m_Specific(RHS)),
2419 m_ConstantInt(Less), m_ConstantInt(Greater))) &&
2420 PredB == ICmpInst::ICMP_SLT) {
2421 return true;
2422 }
2423 return false;
2424}
2425
2426Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002427 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002428 ConstantInt *C) {
2429
2430 assert(C && "Cmp RHS should be a constant int!");
2431 // If we're testing a constant value against the result of a three way
2432 // comparison, the result can be expressed directly in terms of the
2433 // original values being compared. Note: We could possibly be more
2434 // aggressive here and remove the hasOneUse test. The original select is
2435 // really likely to simplify or sink when we remove a test of the result.
2436 Value *OrigLHS, *OrigRHS;
2437 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2438 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002439 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2440 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002441 assert(C1LessThan && C2Equal && C3GreaterThan);
2442
2443 bool TrueWhenLessThan =
2444 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2445 ->isAllOnesValue();
2446 bool TrueWhenEqual =
2447 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2448 ->isAllOnesValue();
2449 bool TrueWhenGreaterThan =
2450 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2451 ->isAllOnesValue();
2452
2453 // This generates the new instruction that will replace the original Cmp
2454 // Instruction. Instead of enumerating the various combinations when
2455 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2456 // false, we rely on chaining of ORs and future passes of InstCombine to
2457 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2458
2459 // When none of the three constants satisfy the predicate for the RHS (C),
2460 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002461 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002462 if (TrueWhenLessThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002463 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002464 if (TrueWhenEqual)
Craig Topperbb4069e2017-07-07 23:16:26 +00002465 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002466 if (TrueWhenGreaterThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002467 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002468
2469 return replaceInstUsesWith(Cmp, Cond);
2470 }
2471 return nullptr;
2472}
2473
Daniel Neilson901acfa2018-04-03 17:26:20 +00002474Instruction *InstCombiner::foldICmpBitCastConstant(ICmpInst &Cmp,
2475 BitCastInst *Bitcast,
2476 const APInt &C) {
2477 // Folding: icmp <pred> iN X, C
2478 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN
2479 // and C is a splat of a K-bit pattern
2480 // and SC is a constant vector = <C', C', C', ..., C'>
2481 // Into:
2482 // %E = extractelement <M x iK> %vec, i32 C'
2483 // icmp <pred> iK %E, trunc(C)
2484 if (!Bitcast->getType()->isIntegerTy() ||
2485 !Bitcast->getSrcTy()->isIntOrIntVectorTy())
2486 return nullptr;
2487
2488 Value *BCIOp = Bitcast->getOperand(0);
2489 Value *Vec = nullptr; // 1st vector arg of the shufflevector
2490 Constant *Mask = nullptr; // Mask arg of the shufflevector
2491 if (match(BCIOp,
2492 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) {
2493 // Check whether every element of Mask is the same constant
2494 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) {
2495 auto *VecTy = cast<VectorType>(BCIOp->getType());
2496 auto *EltTy = cast<IntegerType>(VecTy->getElementType());
2497 auto Pred = Cmp.getPredicate();
2498 if (C.isSplat(EltTy->getBitWidth())) {
2499 // Fold the icmp based on the value of C
2500 // If C is M copies of an iK sized bit pattern,
2501 // then:
2502 // => %E = extractelement <N x iK> %vec, i32 Elem
2503 // icmp <pred> iK %SplatVal, <pattern>
2504 Value *Extract = Builder.CreateExtractElement(Vec, Elem);
2505 Value *NewC = ConstantInt::get(EltTy, C.trunc(EltTy->getBitWidth()));
2506 return new ICmpInst(Pred, Extract, NewC);
2507 }
2508 }
2509 }
2510 return nullptr;
2511}
2512
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002513/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2514/// where X is some kind of instruction.
2515Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002516 const APInt *C;
2517 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002518 return nullptr;
2519
Craig Toppera94069f2017-08-23 05:46:08 +00002520 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002521 switch (BO->getOpcode()) {
2522 case Instruction::Xor:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002523 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002524 return I;
2525 break;
2526 case Instruction::And:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002527 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002528 return I;
2529 break;
2530 case Instruction::Or:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002531 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002532 return I;
2533 break;
2534 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002535 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002536 return I;
2537 break;
2538 case Instruction::Shl:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002539 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002540 return I;
2541 break;
2542 case Instruction::LShr:
2543 case Instruction::AShr:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002544 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002545 return I;
2546 break;
2547 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002548 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002549 return I;
2550 LLVM_FALLTHROUGH;
2551 case Instruction::SDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002552 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002553 return I;
2554 break;
2555 case Instruction::Sub:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002556 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002557 return I;
2558 break;
2559 case Instruction::Add:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002560 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002561 return I;
2562 break;
2563 default:
2564 break;
2565 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002566 // TODO: These folds could be refactored to be part of the above calls.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002567 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002568 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002569 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002570
Anna Thomasd67165c2017-06-23 13:41:45 +00002571 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002572
2573 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2574 // For now, we only support constant integers while folding the
2575 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2576 // similar to the cases handled by binary ops above.
2577 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2578 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002579 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002580 }
2581
2582 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002583 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C))
Craig Topper524c44f2017-08-23 05:46:07 +00002584 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002585 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002586
Daniel Neilson901acfa2018-04-03 17:26:20 +00002587 if (auto *BCI = dyn_cast<BitCastInst>(Cmp.getOperand(0))) {
2588 if (Instruction *I = foldICmpBitCastConstant(Cmp, BCI, *C))
2589 return I;
2590 }
2591
Craig Topper8ed1aa92017-10-03 05:31:07 +00002592 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002593 return I;
2594
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002595 return nullptr;
2596}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002597
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002598/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2599/// icmp eq/ne BO, C.
2600Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2601 BinaryOperator *BO,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002602 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002603 // TODO: Some of these folds could work with arbitrary constants, but this
2604 // function is limited to scalar and vector splat constants.
2605 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002606 return nullptr;
2607
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002608 ICmpInst::Predicate Pred = Cmp.getPredicate();
2609 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2610 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002611 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002612
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002613 switch (BO->getOpcode()) {
2614 case Instruction::SRem:
2615 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002616 if (C.isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002617 const APInt *BOC;
2618 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002619 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002620 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002621 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002622 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002623 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002624 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002625 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002626 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002627 const APInt *BOC;
2628 if (match(BOp1, m_APInt(BOC))) {
2629 if (BO->hasOneUse()) {
2630 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002631 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002632 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002633 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002634 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2635 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002636 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002637 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002638 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002639 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002640 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002641 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002642 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002643 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002644 }
2645 }
2646 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002647 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002648 case Instruction::Xor:
2649 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002650 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002651 // For the xor case, we can xor two constants together, eliminating
2652 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002653 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002654 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002655 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002656 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002657 }
2658 }
2659 break;
2660 case Instruction::Sub:
2661 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002662 const APInt *BOC;
2663 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002664 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002665 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002666 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002667 } else if (C.isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002668 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002669 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002670 }
2671 }
2672 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002673 case Instruction::Or: {
2674 const APInt *BOC;
2675 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002676 // Comparing if all bits outside of a constant mask are set?
2677 // Replace (X | C) == -1 with (X & ~C) == ~C.
2678 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002679 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002680 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002681 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002682 }
2683 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002684 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002685 case Instruction::And: {
2686 const APInt *BOC;
2687 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002688 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Craig Topper8ed1aa92017-10-03 05:31:07 +00002689 if (C == *BOC && C.isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002690 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002691 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002692
2693 // Don't perform the following transforms if the AND has multiple uses
2694 if (!BO->hasOneUse())
2695 break;
2696
2697 // Replace (and X, (1 << size(X)-1) != 0) with x s< 0
Craig Topperbcfd2d12017-04-20 16:56:25 +00002698 if (BOC->isSignMask()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002699 Constant *Zero = Constant::getNullValue(BOp0->getType());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002700 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
2701 return new ICmpInst(NewPred, BOp0, Zero);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002702 }
2703
2704 // ((X & ~7) == 0) --> X < 8
Craig Topper8ed1aa92017-10-03 05:31:07 +00002705 if (C.isNullValue() && (~(*BOC) + 1).isPowerOf2()) {
Sanjay Pateld938e882016-08-04 20:05:02 +00002706 Constant *NegBOC = ConstantExpr::getNeg(cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002707 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
2708 return new ICmpInst(NewPred, BOp0, NegBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002709 }
2710 }
2711 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002712 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002713 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002714 if (C.isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002715 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002716 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002717 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002718 // General case : (mul X, C) != 0 iff X != 0
2719 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002720 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002721 }
2722 }
2723 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002724 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002725 if (C.isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002726 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002727 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2728 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002729 }
2730 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002731 default:
2732 break;
2733 }
2734 return nullptr;
2735}
2736
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002737/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
2738Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002739 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002740 IntrinsicInst *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0));
2741 if (!II || !Cmp.isEquality())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002742 return nullptr;
2743
Sanjay Patelb51e0722017-07-02 16:05:11 +00002744 // Handle icmp {eq|ne} <intrinsic>, Constant.
2745 Type *Ty = II->getType();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002746 switch (II->getIntrinsicID()) {
2747 case Intrinsic::bswap:
2748 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002749 Cmp.setOperand(0, II->getArgOperand(0));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002750 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002751 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002752
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002753 case Intrinsic::ctlz:
2754 case Intrinsic::cttz:
Amaury Sechet6bea6742016-08-04 05:27:20 +00002755 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002756 if (C == C.getBitWidth()) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002757 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002758 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002759 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002760 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002761 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002762 break;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002763
Amaury Sechet6bea6742016-08-04 05:27:20 +00002764 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002765 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002766 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002767 bool IsZero = C.isNullValue();
2768 if (IsZero || C == C.getBitWidth()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002769 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002770 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002771 auto *NewOp =
2772 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002773 Cmp.setOperand(1, NewOp);
2774 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002775 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002776 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002777 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002778 default:
2779 break;
Chris Lattner2188e402010-01-04 07:37:31 +00002780 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002781
Craig Topperf40110f2014-04-25 05:29:35 +00002782 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00002783}
2784
Sanjay Patel10494b22016-09-16 16:10:22 +00002785/// Handle icmp with constant (but not simple integer constant) RHS.
2786Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
2787 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2788 Constant *RHSC = dyn_cast<Constant>(Op1);
2789 Instruction *LHSI = dyn_cast<Instruction>(Op0);
2790 if (!RHSC || !LHSI)
2791 return nullptr;
2792
2793 switch (LHSI->getOpcode()) {
2794 case Instruction::GetElementPtr:
2795 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
2796 if (RHSC->isNullValue() &&
2797 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
2798 return new ICmpInst(
2799 I.getPredicate(), LHSI->getOperand(0),
2800 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2801 break;
2802 case Instruction::PHI:
2803 // Only fold icmp into the PHI if the phi and icmp are in the same
2804 // block. If in the same block, we're encouraging jump threading. If
2805 // not, we are just pessimizing the code by making an i1 phi.
2806 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00002807 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00002808 return NV;
2809 break;
2810 case Instruction::Select: {
2811 // If either operand of the select is a constant, we can fold the
2812 // comparison into the select arms, which will cause one to be
2813 // constant folded and the select turned into a bitwise or.
2814 Value *Op1 = nullptr, *Op2 = nullptr;
2815 ConstantInt *CI = nullptr;
2816 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
2817 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2818 CI = dyn_cast<ConstantInt>(Op1);
2819 }
2820 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
2821 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2822 CI = dyn_cast<ConstantInt>(Op2);
2823 }
2824
2825 // We only want to perform this transformation if it will not lead to
2826 // additional code. This is true if either both sides of the select
2827 // fold to a constant (in which case the icmp is replaced with a select
2828 // which will usually simplify) or this is the only user of the
2829 // select (in which case we are trading a select+icmp for a simpler
2830 // select+icmp) or all uses of the select can be replaced based on
2831 // dominance information ("Global cases").
2832 bool Transform = false;
2833 if (Op1 && Op2)
2834 Transform = true;
2835 else if (Op1 || Op2) {
2836 // Local case
2837 if (LHSI->hasOneUse())
2838 Transform = true;
2839 // Global cases
2840 else if (CI && !CI->isZero())
2841 // When Op1 is constant try replacing select with second operand.
2842 // Otherwise Op2 is constant and try replacing select with first
2843 // operand.
2844 Transform =
2845 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
2846 }
2847 if (Transform) {
2848 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00002849 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
2850 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002851 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00002852 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
2853 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002854 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
2855 }
2856 break;
2857 }
2858 case Instruction::IntToPtr:
2859 // icmp pred inttoptr(X), null -> icmp pred X, 0
2860 if (RHSC->isNullValue() &&
2861 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
2862 return new ICmpInst(
2863 I.getPredicate(), LHSI->getOperand(0),
2864 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2865 break;
2866
2867 case Instruction::Load:
2868 // Try to optimize things like "A[i] > 4" to index computations.
2869 if (GetElementPtrInst *GEP =
2870 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
2871 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
2872 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
2873 !cast<LoadInst>(LHSI)->isVolatile())
2874 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
2875 return Res;
2876 }
2877 break;
2878 }
2879
2880 return nullptr;
2881}
2882
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002883/// Some comparisons can be simplified.
2884/// In this case, we are looking for comparisons that look like
2885/// a check for a lossy truncation.
2886/// Folds:
Roman Lebedev183a4652018-09-19 13:35:27 +00002887/// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask
2888/// Where Mask is some pattern that produces all-ones in low bits:
2889/// (-1 >> y)
Roman Lebedevf50023d2018-09-19 13:35:46 +00002890/// ((-1 << y) >> y) <- non-canonical, has extra uses
Roman Lebedev183a4652018-09-19 13:35:27 +00002891/// ~(-1 << y)
Roman Lebedevca2bdb02018-09-19 13:35:40 +00002892/// ((1 << y) + (-1)) <- non-canonical, has extra uses
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002893/// The Mask can be a constant, too.
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00002894/// For some predicates, the operands are commutative.
2895/// For others, x can only be on a specific side.
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002896static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I,
2897 InstCombiner::BuilderTy &Builder) {
2898 ICmpInst::Predicate SrcPred;
Roman Lebedevf50023d2018-09-19 13:35:46 +00002899 Value *X, *M, *Y;
2900 auto m_VariableMask = m_CombineOr(
2901 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())),
2902 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())),
2903 m_CombineOr(m_LShr(m_AllOnes(), m_Value()),
2904 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y))));
Roman Lebedev183a4652018-09-19 13:35:27 +00002905 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask());
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002906 if (!match(&I, m_c_ICmp(SrcPred,
2907 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)),
2908 m_Deferred(X))))
2909 return nullptr;
2910
2911 ICmpInst::Predicate DstPred;
2912 switch (SrcPred) {
2913 case ICmpInst::Predicate::ICMP_EQ:
2914 // x & (-1 >> y) == x -> x u<= (-1 >> y)
2915 DstPred = ICmpInst::Predicate::ICMP_ULE;
2916 break;
Roman Lebedev74f899f2018-07-12 14:56:12 +00002917 case ICmpInst::Predicate::ICMP_NE:
2918 // x & (-1 >> y) != x -> x u> (-1 >> y)
2919 DstPred = ICmpInst::Predicate::ICMP_UGT;
2920 break;
Roman Lebedev74f611a2018-07-14 16:44:43 +00002921 case ICmpInst::Predicate::ICMP_UGT:
2922 // x u> x & (-1 >> y) -> x u> (-1 >> y)
2923 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
2924 DstPred = ICmpInst::Predicate::ICMP_UGT;
2925 break;
Roman Lebedevfac48472018-07-14 12:20:06 +00002926 case ICmpInst::Predicate::ICMP_UGE:
2927 // x & (-1 >> y) u>= x -> x u<= (-1 >> y)
2928 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
2929 DstPred = ICmpInst::Predicate::ICMP_ULE;
2930 break;
Roman Lebedeve3dc5872018-07-14 12:20:16 +00002931 case ICmpInst::Predicate::ICMP_ULT:
2932 // x & (-1 >> y) u< x -> x u> (-1 >> y)
2933 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
2934 DstPred = ICmpInst::Predicate::ICMP_UGT;
2935 break;
Roman Lebedev0f5ec892018-07-14 16:44:54 +00002936 case ICmpInst::Predicate::ICMP_ULE:
2937 // x u<= x & (-1 >> y) -> x u<= (-1 >> y)
2938 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
2939 DstPred = ICmpInst::Predicate::ICMP_ULE;
2940 break;
Roman Lebedev859e14a2018-07-14 20:08:16 +00002941 case ICmpInst::Predicate::ICMP_SGT:
2942 // x s> x & (-1 >> y) -> x s> (-1 >> y)
2943 if (X != I.getOperand(0)) // X must be on LHS of comparison!
2944 return nullptr; // Ignore the other case.
2945 DstPred = ICmpInst::Predicate::ICMP_SGT;
2946 break;
Roman Lebedevf1442612018-07-14 20:08:37 +00002947 case ICmpInst::Predicate::ICMP_SGE:
2948 // x & (-1 >> y) s>= x -> x s<= (-1 >> y)
2949 if (X != I.getOperand(1)) // X must be on RHS of comparison!
2950 return nullptr; // Ignore the other case.
2951 DstPred = ICmpInst::Predicate::ICMP_SLE;
2952 break;
Roman Lebedevb972fc32018-07-14 20:08:47 +00002953 case ICmpInst::Predicate::ICMP_SLT:
2954 // x & (-1 >> y) s< x -> x s> (-1 >> y)
2955 if (X != I.getOperand(1)) // X must be on RHS of comparison!
2956 return nullptr; // Ignore the other case.
2957 DstPred = ICmpInst::Predicate::ICMP_SGT;
2958 break;
Roman Lebedev1e61e352018-07-14 20:08:26 +00002959 case ICmpInst::Predicate::ICMP_SLE:
2960 // x s<= x & (-1 >> y) -> x s<= (-1 >> y)
2961 if (X != I.getOperand(0)) // X must be on LHS of comparison!
2962 return nullptr; // Ignore the other case.
2963 DstPred = ICmpInst::Predicate::ICMP_SLE;
2964 break;
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002965 default:
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00002966 llvm_unreachable("All possible folds are handled.");
Roman Lebedev68d54cf2018-07-11 19:05:04 +00002967 }
2968
2969 return Builder.CreateICmp(DstPred, X, M);
2970}
2971
Roman Lebedev3cb87e92018-07-18 10:55:17 +00002972/// Some comparisons can be simplified.
2973/// In this case, we are looking for comparisons that look like
2974/// a check for a lossy signed truncation.
2975/// Folds: (MaskedBits is a constant.)
2976/// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x
2977/// Into:
2978/// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits)
2979/// Where KeptBits = bitwidth(%x) - MaskedBits
2980static Value *
2981foldICmpWithTruncSignExtendedVal(ICmpInst &I,
2982 InstCombiner::BuilderTy &Builder) {
2983 ICmpInst::Predicate SrcPred;
2984 Value *X;
2985 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef.
2986 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use.
2987 if (!match(&I, m_c_ICmp(SrcPred,
2988 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)),
2989 m_APInt(C1))),
2990 m_Deferred(X))))
2991 return nullptr;
2992
2993 // Potential handling of non-splats: for each element:
2994 // * if both are undef, replace with constant 0.
2995 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0.
2996 // * if both are not undef, and are different, bailout.
2997 // * else, only one is undef, then pick the non-undef one.
2998
2999 // The shift amount must be equal.
3000 if (*C0 != *C1)
3001 return nullptr;
3002 const APInt &MaskedBits = *C0;
3003 assert(MaskedBits != 0 && "shift by zero should be folded away already.");
3004
3005 ICmpInst::Predicate DstPred;
3006 switch (SrcPred) {
3007 case ICmpInst::Predicate::ICMP_EQ:
3008 // ((%x << MaskedBits) a>> MaskedBits) == %x
3009 // =>
3010 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits)
3011 DstPred = ICmpInst::Predicate::ICMP_ULT;
3012 break;
3013 case ICmpInst::Predicate::ICMP_NE:
3014 // ((%x << MaskedBits) a>> MaskedBits) != %x
3015 // =>
3016 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits)
3017 DstPred = ICmpInst::Predicate::ICMP_UGE;
3018 break;
3019 // FIXME: are more folds possible?
3020 default:
3021 return nullptr;
3022 }
3023
3024 auto *XType = X->getType();
3025 const unsigned XBitWidth = XType->getScalarSizeInBits();
3026 const APInt BitWidth = APInt(XBitWidth, XBitWidth);
3027 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched");
3028
3029 // KeptBits = bitwidth(%x) - MaskedBits
3030 const APInt KeptBits = BitWidth - MaskedBits;
3031 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable");
3032 // ICmpCst = (1 << KeptBits)
3033 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits);
3034 assert(ICmpCst.isPowerOf2());
3035 // AddCst = (1 << (KeptBits-1))
3036 const APInt AddCst = ICmpCst.lshr(1);
3037 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2());
3038
3039 // T0 = add %x, AddCst
3040 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst));
3041 // T1 = T0 DstPred ICmpCst
3042 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst));
3043
3044 return T1;
3045}
3046
Sanjay Patel10494b22016-09-16 16:10:22 +00003047/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00003048/// TODO: A large part of this logic is duplicated in InstSimplify's
3049/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
3050/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00003051Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
3052 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3053
3054 // Special logic for binary operators.
3055 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
3056 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
3057 if (!BO0 && !BO1)
3058 return nullptr;
3059
Sanjay Patel2a062632017-05-08 16:33:42 +00003060 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel1cf07342018-09-11 22:40:20 +00003061 Value *X;
3062
3063 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare.
3064 // (Op1 + X) <u Op1 --> ~Op1 <u X
3065 // Op0 >u (Op0 + X) --> X >u ~Op0
3066 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) &&
3067 Pred == ICmpInst::ICMP_ULT)
3068 return new ICmpInst(Pred, Builder.CreateNot(Op1), X);
3069 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) &&
3070 Pred == ICmpInst::ICMP_UGT)
3071 return new ICmpInst(Pred, X, Builder.CreateNot(Op0));
3072
Sanjay Patel10494b22016-09-16 16:10:22 +00003073 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
3074 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
3075 NoOp0WrapProblem =
3076 ICmpInst::isEquality(Pred) ||
3077 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
3078 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
3079 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
3080 NoOp1WrapProblem =
3081 ICmpInst::isEquality(Pred) ||
3082 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
3083 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
3084
3085 // Analyze the case when either Op0 or Op1 is an add instruction.
3086 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
3087 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
3088 if (BO0 && BO0->getOpcode() == Instruction::Add) {
3089 A = BO0->getOperand(0);
3090 B = BO0->getOperand(1);
3091 }
3092 if (BO1 && BO1->getOpcode() == Instruction::Add) {
3093 C = BO1->getOperand(0);
3094 D = BO1->getOperand(1);
3095 }
3096
Sanjay Patel10494b22016-09-16 16:10:22 +00003097 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
3098 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
3099 return new ICmpInst(Pred, A == Op1 ? B : A,
3100 Constant::getNullValue(Op1->getType()));
3101
3102 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
3103 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
3104 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
3105 C == Op0 ? D : C);
3106
3107 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
3108 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
3109 NoOp1WrapProblem &&
3110 // Try not to increase register pressure.
3111 BO0->hasOneUse() && BO1->hasOneUse()) {
3112 // Determine Y and Z in the form icmp (X+Y), (X+Z).
3113 Value *Y, *Z;
3114 if (A == C) {
3115 // C + B == C + D -> B == D
3116 Y = B;
3117 Z = D;
3118 } else if (A == D) {
3119 // D + B == C + D -> B == C
3120 Y = B;
3121 Z = C;
3122 } else if (B == C) {
3123 // A + C == C + D -> A == D
3124 Y = A;
3125 Z = D;
3126 } else {
3127 assert(B == D);
3128 // A + D == C + D -> A == C
3129 Y = A;
3130 Z = C;
3131 }
3132 return new ICmpInst(Pred, Y, Z);
3133 }
3134
3135 // icmp slt (X + -1), Y -> icmp sle X, Y
3136 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
3137 match(B, m_AllOnes()))
3138 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
3139
3140 // icmp sge (X + -1), Y -> icmp sgt X, Y
3141 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
3142 match(B, m_AllOnes()))
3143 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
3144
3145 // icmp sle (X + 1), Y -> icmp slt X, Y
3146 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
3147 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
3148
3149 // icmp sgt (X + 1), Y -> icmp sge X, Y
3150 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
3151 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
3152
3153 // icmp sgt X, (Y + -1) -> icmp sge X, Y
3154 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
3155 match(D, m_AllOnes()))
3156 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
3157
3158 // icmp sle X, (Y + -1) -> icmp slt X, Y
3159 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
3160 match(D, m_AllOnes()))
3161 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
3162
3163 // icmp sge X, (Y + 1) -> icmp sgt X, Y
3164 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
3165 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
3166
3167 // icmp slt X, (Y + 1) -> icmp sle X, Y
3168 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
3169 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
3170
Sanjay Patel40f40172017-01-13 23:25:46 +00003171 // TODO: The subtraction-related identities shown below also hold, but
3172 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
3173 // wouldn't happen even if they were implemented.
3174 //
3175 // icmp ult (X - 1), Y -> icmp ule X, Y
3176 // icmp uge (X - 1), Y -> icmp ugt X, Y
3177 // icmp ugt X, (Y - 1) -> icmp uge X, Y
3178 // icmp ule X, (Y - 1) -> icmp ult X, Y
3179
3180 // icmp ule (X + 1), Y -> icmp ult X, Y
3181 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
3182 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
3183
3184 // icmp ugt (X + 1), Y -> icmp uge X, Y
3185 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
3186 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
3187
3188 // icmp uge X, (Y + 1) -> icmp ugt X, Y
3189 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
3190 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
3191
3192 // icmp ult X, (Y + 1) -> icmp ule X, Y
3193 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
3194 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
3195
Sanjay Patel10494b22016-09-16 16:10:22 +00003196 // if C1 has greater magnitude than C2:
3197 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
3198 // s.t. C3 = C1 - C2
3199 //
3200 // if C2 has greater magnitude than C1:
3201 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
3202 // s.t. C3 = C2 - C1
3203 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
3204 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
3205 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
3206 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
3207 const APInt &AP1 = C1->getValue();
3208 const APInt &AP2 = C2->getValue();
3209 if (AP1.isNegative() == AP2.isNegative()) {
3210 APInt AP1Abs = C1->getValue().abs();
3211 APInt AP2Abs = C2->getValue().abs();
3212 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003213 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
3214 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003215 return new ICmpInst(Pred, NewAdd, C);
3216 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00003217 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
3218 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003219 return new ICmpInst(Pred, A, NewAdd);
3220 }
3221 }
3222 }
3223
3224 // Analyze the case when either Op0 or Op1 is a sub instruction.
3225 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
3226 A = nullptr;
3227 B = nullptr;
3228 C = nullptr;
3229 D = nullptr;
3230 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
3231 A = BO0->getOperand(0);
3232 B = BO0->getOperand(1);
3233 }
3234 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
3235 C = BO1->getOperand(0);
3236 D = BO1->getOperand(1);
3237 }
3238
3239 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
3240 if (A == Op1 && NoOp0WrapProblem)
3241 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
Sanjay Patel10494b22016-09-16 16:10:22 +00003242 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
3243 if (C == Op0 && NoOp1WrapProblem)
3244 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3245
Sanjay Patelcbb04502018-04-02 20:37:40 +00003246 // (A - B) >u A --> A <u B
3247 if (A == Op1 && Pred == ICmpInst::ICMP_UGT)
3248 return new ICmpInst(ICmpInst::ICMP_ULT, A, B);
3249 // C <u (C - D) --> C <u D
3250 if (C == Op0 && Pred == ICmpInst::ICMP_ULT)
3251 return new ICmpInst(ICmpInst::ICMP_ULT, C, D);
3252
Sanjay Patel10494b22016-09-16 16:10:22 +00003253 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
3254 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
3255 // Try not to increase register pressure.
3256 BO0->hasOneUse() && BO1->hasOneUse())
3257 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003258 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
3259 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
3260 // Try not to increase register pressure.
3261 BO0->hasOneUse() && BO1->hasOneUse())
3262 return new ICmpInst(Pred, D, B);
3263
3264 // icmp (0-X) < cst --> x > -cst
3265 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3266 Value *X;
3267 if (match(BO0, m_Neg(m_Value(X))))
Chen Zhengb9722732018-07-16 00:51:40 +00003268 if (Constant *RHSC = dyn_cast<Constant>(Op1))
3269 if (RHSC->isNotMinSignedValue())
Sanjay Patel10494b22016-09-16 16:10:22 +00003270 return new ICmpInst(I.getSwappedPredicate(), X,
3271 ConstantExpr::getNeg(RHSC));
3272 }
3273
3274 BinaryOperator *SRem = nullptr;
3275 // icmp (srem X, Y), Y
3276 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3277 SRem = BO0;
3278 // icmp Y, (srem X, Y)
3279 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3280 Op0 == BO1->getOperand(1))
3281 SRem = BO1;
3282 if (SRem) {
3283 // We don't check hasOneUse to avoid increasing register pressure because
3284 // the value we use is the same value this instruction was already using.
3285 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3286 default:
3287 break;
3288 case ICmpInst::ICMP_EQ:
3289 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3290 case ICmpInst::ICMP_NE:
3291 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3292 case ICmpInst::ICMP_SGT:
3293 case ICmpInst::ICMP_SGE:
3294 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3295 Constant::getAllOnesValue(SRem->getType()));
3296 case ICmpInst::ICMP_SLT:
3297 case ICmpInst::ICMP_SLE:
3298 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3299 Constant::getNullValue(SRem->getType()));
3300 }
3301 }
3302
3303 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3304 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3305 switch (BO0->getOpcode()) {
3306 default:
3307 break;
3308 case Instruction::Add:
3309 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003310 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003311 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003312 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003313
3314 const APInt *C;
3315 if (match(BO0->getOperand(1), m_APInt(C))) {
3316 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3317 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003318 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003319 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003320 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003321 }
3322
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003323 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3324 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003325 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003326 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003327 NewPred = I.getSwappedPredicate(NewPred);
3328 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003329 }
3330 }
3331 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003332 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003333 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003334 if (!I.isEquality())
3335 break;
3336
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003337 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003338 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3339 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003340 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3341 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003342 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003343 Constant *Mask = ConstantInt::get(
3344 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003345 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003346 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3347 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003348 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003349 }
Sanjay Patel51506122017-05-25 14:13:57 +00003350 // If there are no trailing zeros in the multiplier, just eliminate
3351 // the multiplies (no masking is needed):
3352 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3353 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003354 }
3355 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003356 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003357 case Instruction::UDiv:
3358 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003359 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003360 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003361 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3362
Sanjay Patel10494b22016-09-16 16:10:22 +00003363 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003364 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3365 break;
3366 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3367
Sanjay Patel10494b22016-09-16 16:10:22 +00003368 case Instruction::AShr:
3369 if (!BO0->isExact() || !BO1->isExact())
3370 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003371 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003372
Sanjay Patel10494b22016-09-16 16:10:22 +00003373 case Instruction::Shl: {
3374 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3375 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3376 if (!NUW && !NSW)
3377 break;
3378 if (!NSW && I.isSigned())
3379 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003380 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003381 }
3382 }
3383 }
3384
3385 if (BO0) {
3386 // Transform A & (L - 1) `ult` L --> L != 0
3387 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003388 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003389
Sanjay Patel2a062632017-05-08 16:33:42 +00003390 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003391 auto *Zero = Constant::getNullValue(BO0->getType());
3392 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3393 }
3394 }
3395
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003396 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder))
3397 return replaceInstUsesWith(I, V);
3398
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003399 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder))
3400 return replaceInstUsesWith(I, V);
3401
Sanjay Patel10494b22016-09-16 16:10:22 +00003402 return nullptr;
3403}
3404
Sanjay Pateldd46b522016-12-19 17:32:37 +00003405/// Fold icmp Pred min|max(X, Y), X.
3406static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003407 ICmpInst::Predicate Pred = Cmp.getPredicate();
3408 Value *Op0 = Cmp.getOperand(0);
3409 Value *X = Cmp.getOperand(1);
3410
Sanjay Pateldd46b522016-12-19 17:32:37 +00003411 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003412 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003413 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3414 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3415 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003416 std::swap(Op0, X);
3417 Pred = Cmp.getSwappedPredicate();
3418 }
3419
3420 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003421 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003422 // smin(X, Y) == X --> X s<= Y
3423 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003424 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3425 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3426
Sanjay Pateldd46b522016-12-19 17:32:37 +00003427 // smin(X, Y) != X --> X s> Y
3428 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003429 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3430 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3431
3432 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003433 // smin(X, Y) s<= X --> true
3434 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003435 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003436 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003437
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003438 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003439 // smax(X, Y) == X --> X s>= Y
3440 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003441 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3442 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003443
Sanjay Pateldd46b522016-12-19 17:32:37 +00003444 // smax(X, Y) != X --> X s< Y
3445 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003446 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3447 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003448
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003449 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003450 // smax(X, Y) s>= X --> true
3451 // smax(X, Y) s< X --> false
3452 return nullptr;
3453 }
3454
3455 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3456 // umin(X, Y) == X --> X u<= Y
3457 // umin(X, Y) u>= X --> X u<= Y
3458 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3459 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3460
3461 // umin(X, Y) != X --> X u> Y
3462 // umin(X, Y) u< X --> X u> Y
3463 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3464 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3465
3466 // These cases should be handled in InstSimplify:
3467 // umin(X, Y) u<= X --> true
3468 // umin(X, Y) u> X --> false
3469 return nullptr;
3470 }
3471
3472 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3473 // umax(X, Y) == X --> X u>= Y
3474 // umax(X, Y) u<= X --> X u>= Y
3475 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3476 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3477
3478 // umax(X, Y) != X --> X u< Y
3479 // umax(X, Y) u> X --> X u< Y
3480 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3481 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3482
3483 // These cases should be handled in InstSimplify:
3484 // umax(X, Y) u>= X --> true
3485 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003486 return nullptr;
3487 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003488
Sanjay Pateld6406412016-12-15 19:13:37 +00003489 return nullptr;
3490}
3491
Sanjay Patel10494b22016-09-16 16:10:22 +00003492Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3493 if (!I.isEquality())
3494 return nullptr;
3495
3496 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003497 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00003498 Value *A, *B, *C, *D;
3499 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3500 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3501 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003502 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003503 }
3504
3505 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3506 // A^c1 == C^c2 --> A == C^(c1^c2)
3507 ConstantInt *C1, *C2;
3508 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3509 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003510 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
3511 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003512 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00003513 }
3514
3515 // A^B == A^D -> B == D
3516 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003517 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003518 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003519 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003520 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003521 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003522 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003523 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003524 }
3525 }
3526
3527 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3528 // A == (A^B) -> B == 0
3529 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003530 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003531 }
3532
3533 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3534 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3535 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3536 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3537
3538 if (A == C) {
3539 X = B;
3540 Y = D;
3541 Z = A;
3542 } else if (A == D) {
3543 X = B;
3544 Y = C;
3545 Z = A;
3546 } else if (B == C) {
3547 X = A;
3548 Y = D;
3549 Z = B;
3550 } else if (B == D) {
3551 X = A;
3552 Y = C;
3553 Z = B;
3554 }
3555
3556 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00003557 Op1 = Builder.CreateXor(X, Y);
3558 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00003559 I.setOperand(0, Op1);
3560 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3561 return &I;
3562 }
3563 }
3564
3565 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3566 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3567 ConstantInt *Cst1;
3568 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3569 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3570 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3571 match(Op1, m_ZExt(m_Value(A))))) {
3572 APInt Pow2 = Cst1->getValue() + 1;
3573 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3574 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00003575 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003576 }
3577
3578 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3579 // For lshr and ashr pairs.
3580 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3581 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
3582 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3583 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
3584 unsigned TypeBits = Cst1->getBitWidth();
3585 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3586 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00003587 ICmpInst::Predicate NewPred =
3588 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00003589 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003590 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003591 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00003592 }
3593 }
3594
3595 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
3596 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
3597 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
3598 unsigned TypeBits = Cst1->getBitWidth();
3599 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3600 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003601 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003602 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003603 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00003604 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00003605 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003606 }
3607 }
3608
3609 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
3610 // "icmp (and X, mask), cst"
3611 uint64_t ShAmt = 0;
3612 if (Op0->hasOneUse() &&
3613 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
3614 match(Op1, m_ConstantInt(Cst1)) &&
3615 // Only do this when A has multiple uses. This is most important to do
3616 // when it exposes other optimizations.
3617 !A->hasOneUse()) {
3618 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
3619
3620 if (ShAmt < ASize) {
3621 APInt MaskV =
3622 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
3623 MaskV <<= ShAmt;
3624
3625 APInt CmpV = Cst1->getValue().zext(ASize);
3626 CmpV <<= ShAmt;
3627
Craig Topperbb4069e2017-07-07 23:16:26 +00003628 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
3629 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00003630 }
3631 }
3632
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003633 // If both operands are byte-swapped or bit-reversed, just compare the
3634 // original values.
3635 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
3636 // and handle more intrinsics.
3637 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00003638 (match(Op0, m_BitReverse(m_Value(A))) &&
3639 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003640 return new ICmpInst(Pred, A, B);
3641
Sanjay Patel10494b22016-09-16 16:10:22 +00003642 return nullptr;
3643}
3644
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003645/// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so
3646/// far.
Sanjay Patel43395062016-07-21 18:07:40 +00003647Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) {
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003648 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +00003649 Value *LHSCIOp = LHSCI->getOperand(0);
Chris Lattner229907c2011-07-18 04:54:35 +00003650 Type *SrcTy = LHSCIOp->getType();
3651 Type *DestTy = LHSCI->getType();
Chris Lattner2188e402010-01-04 07:37:31 +00003652 Value *RHSCIOp;
3653
Jim Grosbach129c52a2011-09-30 18:09:53 +00003654 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00003655 // integer type is the same size as the pointer type.
Daniel Neilsonbdda1152018-03-05 18:05:51 +00003656 const auto& CompatibleSizes = [&](Type* SrcTy, Type* DestTy) -> bool {
3657 if (isa<VectorType>(SrcTy)) {
3658 SrcTy = cast<VectorType>(SrcTy)->getElementType();
3659 DestTy = cast<VectorType>(DestTy)->getElementType();
3660 }
3661 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth();
3662 };
Mehdi Aminia28d91d2015-03-10 02:37:25 +00003663 if (LHSCI->getOpcode() == Instruction::PtrToInt &&
Daniel Neilsonbdda1152018-03-05 18:05:51 +00003664 CompatibleSizes(SrcTy, DestTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +00003665 Value *RHSOp = nullptr;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003666 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
Michael Liaod266b922015-02-13 04:51:26 +00003667 Value *RHSCIOp = RHSC->getOperand(0);
3668 if (RHSCIOp->getType()->getPointerAddressSpace() ==
3669 LHSCIOp->getType()->getPointerAddressSpace()) {
3670 RHSOp = RHSC->getOperand(0);
3671 // If the pointer types don't match, insert a bitcast.
3672 if (LHSCIOp->getType() != RHSOp->getType())
Craig Topperbb4069e2017-07-07 23:16:26 +00003673 RHSOp = Builder.CreateBitCast(RHSOp, LHSCIOp->getType());
Michael Liaod266b922015-02-13 04:51:26 +00003674 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003675 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003676 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003677 }
Chris Lattner2188e402010-01-04 07:37:31 +00003678
3679 if (RHSOp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003680 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003681 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003682
Chris Lattner2188e402010-01-04 07:37:31 +00003683 // The code below only handles extension cast instructions, so far.
3684 // Enforce this.
3685 if (LHSCI->getOpcode() != Instruction::ZExt &&
3686 LHSCI->getOpcode() != Instruction::SExt)
Craig Topperf40110f2014-04-25 05:29:35 +00003687 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003688
3689 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003690 bool isSignedCmp = ICmp.isSigned();
Chris Lattner2188e402010-01-04 07:37:31 +00003691
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003692 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003693 // Not an extension from the same type?
3694 RHSCIOp = CI->getOperand(0);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003695 if (RHSCIOp->getType() != LHSCIOp->getType())
Craig Topperf40110f2014-04-25 05:29:35 +00003696 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +00003697
Chris Lattner2188e402010-01-04 07:37:31 +00003698 // If the signedness of the two casts doesn't agree (i.e. one is a sext
3699 // and the other is a zext), then we can't handle this.
3700 if (CI->getOpcode() != LHSCI->getOpcode())
Craig Topperf40110f2014-04-25 05:29:35 +00003701 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003702
3703 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003704 if (ICmp.isEquality())
3705 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003706
3707 // A signed comparison of sign extended values simplifies into a
3708 // signed comparison.
3709 if (isSignedCmp && isSignedExt)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003710 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003711
3712 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003713 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003714 }
3715
Sanjay Patel4c204232016-06-04 20:39:22 +00003716 // If we aren't dealing with a constant on the RHS, exit early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003717 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
3718 if (!C)
Craig Topperf40110f2014-04-25 05:29:35 +00003719 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003720
3721 // Compute the constant that would happen if we truncated to SrcTy then
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003722 // re-extended to DestTy.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003723 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003724 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy);
Chris Lattner2188e402010-01-04 07:37:31 +00003725
3726 // If the re-extended constant didn't change...
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003727 if (Res2 == C) {
Chris Lattner2188e402010-01-04 07:37:31 +00003728 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003729 if (ICmp.isEquality())
3730 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003731
3732 // A signed comparison of sign extended values simplifies into a
3733 // signed comparison.
3734 if (isSignedExt && isSignedCmp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003735 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003736
3737 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003738 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003739 }
3740
Sanjay Patel6a333c32016-06-06 16:56:57 +00003741 // The re-extended constant changed, partly changed (in the case of a vector),
3742 // or could not be determined to be equal (in the case of a constant
3743 // expression), so the constant cannot be represented in the shorter type.
3744 // Consequently, we cannot emit a simple comparison.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003745 // All the cases that fold to true or false will have already been handled
3746 // by SimplifyICmpInst, so only deal with the tricky case.
Chris Lattner2188e402010-01-04 07:37:31 +00003747
Sanjay Patel6a333c32016-06-06 16:56:57 +00003748 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C))
Craig Topperf40110f2014-04-25 05:29:35 +00003749 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003750
3751 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases
3752 // should have been folded away previously and not enter in here.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003753
3754 // We're performing an unsigned comp with a sign extended value.
3755 // This is true if the input is >= 0. [aka >s -1]
3756 Constant *NegOne = Constant::getAllOnesValue(SrcTy);
Craig Topperbb4069e2017-07-07 23:16:26 +00003757 Value *Result = Builder.CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName());
Chris Lattner2188e402010-01-04 07:37:31 +00003758
3759 // Finally, return the value computed.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003760 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
3761 return replaceInstUsesWith(ICmp, Result);
Chris Lattner2188e402010-01-04 07:37:31 +00003762
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003763 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
Chris Lattner2188e402010-01-04 07:37:31 +00003764 return BinaryOperator::CreateNot(Result);
3765}
3766
Sanjoy Dasb0984472015-04-08 04:27:22 +00003767bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS,
3768 Value *RHS, Instruction &OrigI,
3769 Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00003770 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
3771 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003772
3773 auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) {
3774 Result = OpResult;
3775 Overflow = OverflowVal;
3776 if (ReuseName)
3777 Result->takeName(&OrigI);
3778 return true;
3779 };
3780
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003781 // If the overflow check was an add followed by a compare, the insertion point
3782 // may be pointing to the compare. We want to insert the new instructions
3783 // before the add in case there are uses of the add between the add and the
3784 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00003785 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003786
Sanjoy Dasb0984472015-04-08 04:27:22 +00003787 switch (OCF) {
3788 case OCF_INVALID:
3789 llvm_unreachable("bad overflow check kind!");
3790
3791 case OCF_UNSIGNED_ADD: {
3792 OverflowResult OR = computeOverflowForUnsignedAdd(LHS, RHS, &OrigI);
3793 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003794 return SetResult(Builder.CreateNUWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003795 true);
3796
3797 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003798 return SetResult(Builder.CreateAdd(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003799
3800 // Fall through uadd into sadd
3801 LLVM_FALLTHROUGH;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003802 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003803 case OCF_SIGNED_ADD: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003804 // X + 0 -> {X, false}
3805 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003806 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003807
3808 // We can strength reduce this signed add into a regular add if we can prove
3809 // that it will never overflow.
3810 if (OCF == OCF_SIGNED_ADD)
Craig Topper2b1fc322017-05-22 06:25:31 +00003811 if (willNotOverflowSignedAdd(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003812 return SetResult(Builder.CreateNSWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003813 true);
Sanjoy Das72cb5e12015-06-05 18:04:42 +00003814 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003815 }
3816
3817 case OCF_UNSIGNED_SUB:
3818 case OCF_SIGNED_SUB: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003819 // X - 0 -> {X, false}
3820 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003821 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003822
3823 if (OCF == OCF_SIGNED_SUB) {
Craig Topper2b1fc322017-05-22 06:25:31 +00003824 if (willNotOverflowSignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003825 return SetResult(Builder.CreateNSWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003826 true);
3827 } else {
Craig Topper2b1fc322017-05-22 06:25:31 +00003828 if (willNotOverflowUnsignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003829 return SetResult(Builder.CreateNUWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003830 true);
3831 }
3832 break;
3833 }
3834
3835 case OCF_UNSIGNED_MUL: {
3836 OverflowResult OR = computeOverflowForUnsignedMul(LHS, RHS, &OrigI);
3837 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003838 return SetResult(Builder.CreateNUWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003839 true);
3840 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003841 return SetResult(Builder.CreateMul(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003842 LLVM_FALLTHROUGH;
3843 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003844 case OCF_SIGNED_MUL:
3845 // X * undef -> undef
3846 if (isa<UndefValue>(RHS))
Craig Topperbb4069e2017-07-07 23:16:26 +00003847 return SetResult(RHS, UndefValue::get(Builder.getInt1Ty()), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003848
David Majnemer27e89ba2015-05-21 23:04:21 +00003849 // X * 0 -> {0, false}
3850 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003851 return SetResult(RHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003852
David Majnemer27e89ba2015-05-21 23:04:21 +00003853 // X * 1 -> {X, false}
3854 if (match(RHS, m_One()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003855 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003856
3857 if (OCF == OCF_SIGNED_MUL)
Craig Topper2b1fc322017-05-22 06:25:31 +00003858 if (willNotOverflowSignedMul(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003859 return SetResult(Builder.CreateNSWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003860 true);
Sanjoy Dasc80dad62015-06-05 18:04:46 +00003861 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003862 }
3863
3864 return false;
3865}
3866
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00003867/// Recognize and process idiom involving test for multiplication
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003868/// overflow.
3869///
3870/// The caller has matched a pattern of the form:
3871/// I = cmp u (mul(zext A, zext B), V
3872/// The function checks if this is a test for overflow and if so replaces
3873/// multiplication with call to 'mul.with.overflow' intrinsic.
3874///
3875/// \param I Compare instruction.
3876/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
3877/// the compare instruction. Must be of integer type.
3878/// \param OtherVal The other argument of compare instruction.
3879/// \returns Instruction which must replace the compare instruction, NULL if no
3880/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00003881static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003882 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00003883 // Don't bother doing this transformation for pointers, don't do it for
3884 // vectors.
3885 if (!isa<IntegerType>(MulVal->getType()))
3886 return nullptr;
3887
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003888 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
3889 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00003890 auto *MulInstr = dyn_cast<Instruction>(MulVal);
3891 if (!MulInstr)
3892 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003893 assert(MulInstr->getOpcode() == Instruction::Mul);
3894
David Majnemer634ca232014-11-01 23:46:05 +00003895 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
3896 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003897 assert(LHS->getOpcode() == Instruction::ZExt);
3898 assert(RHS->getOpcode() == Instruction::ZExt);
3899 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
3900
3901 // Calculate type and width of the result produced by mul.with.overflow.
3902 Type *TyA = A->getType(), *TyB = B->getType();
3903 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
3904 WidthB = TyB->getPrimitiveSizeInBits();
3905 unsigned MulWidth;
3906 Type *MulType;
3907 if (WidthB > WidthA) {
3908 MulWidth = WidthB;
3909 MulType = TyB;
3910 } else {
3911 MulWidth = WidthA;
3912 MulType = TyA;
3913 }
3914
3915 // In order to replace the original mul with a narrower mul.with.overflow,
3916 // all uses must ignore upper bits of the product. The number of used low
3917 // bits must be not greater than the width of mul.with.overflow.
3918 if (MulVal->hasNUsesOrMore(2))
3919 for (User *U : MulVal->users()) {
3920 if (U == &I)
3921 continue;
3922 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3923 // Check if truncation ignores bits above MulWidth.
3924 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
3925 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003926 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003927 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3928 // Check if AND ignores bits above MulWidth.
3929 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00003930 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003931 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
3932 const APInt &CVal = CI->getValue();
3933 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003934 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00003935 } else {
3936 // In this case we could have the operand of the binary operation
3937 // being defined in another block, and performing the replacement
3938 // could break the dominance relation.
3939 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003940 }
3941 } else {
3942 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00003943 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003944 }
3945 }
3946
3947 // Recognize patterns
3948 switch (I.getPredicate()) {
3949 case ICmpInst::ICMP_EQ:
3950 case ICmpInst::ICMP_NE:
3951 // Recognize pattern:
3952 // mulval = mul(zext A, zext B)
3953 // cmp eq/neq mulval, zext trunc mulval
3954 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
3955 if (Zext->hasOneUse()) {
3956 Value *ZextArg = Zext->getOperand(0);
3957 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
3958 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
3959 break; //Recognized
3960 }
3961
3962 // Recognize pattern:
3963 // mulval = mul(zext A, zext B)
3964 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
3965 ConstantInt *CI;
3966 Value *ValToMask;
3967 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
3968 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00003969 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003970 const APInt &CVal = CI->getValue() + 1;
3971 if (CVal.isPowerOf2()) {
3972 unsigned MaskWidth = CVal.logBase2();
3973 if (MaskWidth == MulWidth)
3974 break; // Recognized
3975 }
3976 }
Craig Topperf40110f2014-04-25 05:29:35 +00003977 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003978
3979 case ICmpInst::ICMP_UGT:
3980 // Recognize pattern:
3981 // mulval = mul(zext A, zext B)
3982 // cmp ugt mulval, max
3983 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3984 APInt MaxVal = APInt::getMaxValue(MulWidth);
3985 MaxVal = MaxVal.zext(CI->getBitWidth());
3986 if (MaxVal.eq(CI->getValue()))
3987 break; // Recognized
3988 }
Craig Topperf40110f2014-04-25 05:29:35 +00003989 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003990
3991 case ICmpInst::ICMP_UGE:
3992 // Recognize pattern:
3993 // mulval = mul(zext A, zext B)
3994 // cmp uge mulval, max+1
3995 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3996 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
3997 if (MaxVal.eq(CI->getValue()))
3998 break; // Recognized
3999 }
Craig Topperf40110f2014-04-25 05:29:35 +00004000 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004001
4002 case ICmpInst::ICMP_ULE:
4003 // Recognize pattern:
4004 // mulval = mul(zext A, zext B)
4005 // cmp ule mulval, max
4006 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4007 APInt MaxVal = APInt::getMaxValue(MulWidth);
4008 MaxVal = MaxVal.zext(CI->getBitWidth());
4009 if (MaxVal.eq(CI->getValue()))
4010 break; // Recognized
4011 }
Craig Topperf40110f2014-04-25 05:29:35 +00004012 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004013
4014 case ICmpInst::ICMP_ULT:
4015 // Recognize pattern:
4016 // mulval = mul(zext A, zext B)
4017 // cmp ule mulval, max + 1
4018 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004019 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004020 if (MaxVal.eq(CI->getValue()))
4021 break; // Recognized
4022 }
Craig Topperf40110f2014-04-25 05:29:35 +00004023 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004024
4025 default:
Craig Topperf40110f2014-04-25 05:29:35 +00004026 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004027 }
4028
Craig Topperbb4069e2017-07-07 23:16:26 +00004029 InstCombiner::BuilderTy &Builder = IC.Builder;
4030 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004031
4032 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
4033 Value *MulA = A, *MulB = B;
4034 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004035 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004036 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004037 MulB = Builder.CreateZExt(B, MulType);
Sanjay Patelaf674fb2015-12-14 17:24:23 +00004038 Value *F = Intrinsic::getDeclaration(I.getModule(),
4039 Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00004040 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004041 IC.Worklist.Add(MulInstr);
4042
4043 // If there are uses of mul result other than the comparison, we know that
4044 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004045 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004046 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004047 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Joseph Tremoulet6f406d42018-06-15 16:52:40 +00004048 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) {
4049 User *U = *UI++;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004050 if (U == &I || U == OtherVal)
4051 continue;
4052 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4053 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00004054 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004055 else
4056 TI->setOperand(0, Mul);
4057 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4058 assert(BO->getOpcode() == Instruction::And);
4059 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00004060 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
4061 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00004062 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00004063 Instruction *Zext =
4064 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
4065 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00004066 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004067 } else {
4068 llvm_unreachable("Unexpected Binary operation");
4069 }
Davide Italiano579064e2017-07-16 18:56:30 +00004070 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004071 }
4072 }
4073 if (isa<Instruction>(OtherVal))
4074 IC.Worklist.Add(cast<Instruction>(OtherVal));
4075
4076 // The original icmp gets replaced with the overflow value, maybe inverted
4077 // depending on predicate.
4078 bool Inverse = false;
4079 switch (I.getPredicate()) {
4080 case ICmpInst::ICMP_NE:
4081 break;
4082 case ICmpInst::ICMP_EQ:
4083 Inverse = true;
4084 break;
4085 case ICmpInst::ICMP_UGT:
4086 case ICmpInst::ICMP_UGE:
4087 if (I.getOperand(0) == MulVal)
4088 break;
4089 Inverse = true;
4090 break;
4091 case ICmpInst::ICMP_ULT:
4092 case ICmpInst::ICMP_ULE:
4093 if (I.getOperand(1) == MulVal)
4094 break;
4095 Inverse = true;
4096 break;
4097 default:
4098 llvm_unreachable("Unexpected predicate");
4099 }
4100 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004101 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004102 return BinaryOperator::CreateNot(Res);
4103 }
4104
4105 return ExtractValueInst::Create(Call, 1);
4106}
4107
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004108/// When performing a comparison against a constant, it is possible that not all
4109/// the bits in the LHS are demanded. This helper method computes the mask that
4110/// IS demanded.
Craig Topper3edda872017-09-22 18:57:23 +00004111static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) {
Craig Topper18887bf2017-09-20 23:48:58 +00004112 const APInt *RHS;
4113 if (!match(I.getOperand(1), m_APInt(RHS)))
4114 return APInt::getAllOnesValue(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004115
Craig Topper3edda872017-09-22 18:57:23 +00004116 // If this is a normal comparison, it demands all bits. If it is a sign bit
4117 // comparison, it only demands the sign bit.
4118 bool UnusedBit;
4119 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit))
4120 return APInt::getSignMask(BitWidth);
4121
Owen Andersond490c2d2011-01-11 00:36:45 +00004122 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004123 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00004124 // correspond to the trailing ones of the comparand. The value of these
4125 // bits doesn't impact the outcome of the comparison, because any value
4126 // greater than the RHS must differ in a bit higher than these due to carry.
Craig Topper18887bf2017-09-20 23:48:58 +00004127 case ICmpInst::ICMP_UGT:
4128 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004129
Owen Andersond490c2d2011-01-11 00:36:45 +00004130 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
4131 // Any value less than the RHS must differ in a higher bit because of carries.
Craig Topper18887bf2017-09-20 23:48:58 +00004132 case ICmpInst::ICMP_ULT:
4133 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004134
Owen Andersond490c2d2011-01-11 00:36:45 +00004135 default:
4136 return APInt::getAllOnesValue(BitWidth);
4137 }
Owen Andersond490c2d2011-01-11 00:36:45 +00004138}
Chris Lattner2188e402010-01-04 07:37:31 +00004139
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004140/// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst
Quentin Colombet5ab55552013-09-09 20:56:48 +00004141/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00004142/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00004143/// as subtract operands and their positions in those instructions.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004144/// The rationale is that several architectures use the same instruction for
4145/// both subtract and cmp. Thus, it is better if the order of those operands
Quentin Colombet5ab55552013-09-09 20:56:48 +00004146/// match.
4147/// \return true if Op0 and Op1 should be swapped.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004148static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) {
4149 // Filter out pointer values as those cannot appear directly in subtract.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004150 // FIXME: we may want to go through inttoptrs or bitcasts.
4151 if (Op0->getType()->isPointerTy())
4152 return false;
Sanjay Patel1ea86972018-02-02 19:08:12 +00004153 // If a subtract already has the same operands as a compare, swapping would be
4154 // bad. If a subtract has the same operands as a compare but in reverse order,
4155 // then swapping is good.
4156 int GoodToSwap = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00004157 for (const User *U : Op0->users()) {
Sanjay Patel1ea86972018-02-02 19:08:12 +00004158 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0))))
4159 GoodToSwap++;
4160 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1))))
4161 GoodToSwap--;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004162 }
Sanjay Patel1ea86972018-02-02 19:08:12 +00004163 return GoodToSwap > 0;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004164}
4165
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004166/// Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00004167/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004168///
4169/// \param DI Definition
4170/// \param UI Use
4171/// \param DB Block that must dominate all uses of \p DI outside
4172/// the parent block
4173/// \return true when \p UI is the only use of \p DI in the parent block
4174/// and all other uses of \p DI are in blocks dominated by \p DB.
4175///
4176bool InstCombiner::dominatesAllUses(const Instruction *DI,
4177 const Instruction *UI,
4178 const BasicBlock *DB) const {
4179 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00004180 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004181 if (!DI->getParent())
4182 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004183 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004184 if (DI->getParent() != UI->getParent())
4185 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004186 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004187 if (DI->getParent() == DB)
4188 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004189 for (const User *U : DI->users()) {
4190 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00004191 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004192 return false;
4193 }
4194 return true;
4195}
4196
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004197/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004198static bool isChainSelectCmpBranch(const SelectInst *SI) {
4199 const BasicBlock *BB = SI->getParent();
4200 if (!BB)
4201 return false;
4202 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
4203 if (!BI || BI->getNumSuccessors() != 2)
4204 return false;
4205 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
4206 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
4207 return false;
4208 return true;
4209}
4210
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004211/// True when a select result is replaced by one of its operands
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004212/// in select-icmp sequence. This will eventually result in the elimination
4213/// of the select.
4214///
4215/// \param SI Select instruction
4216/// \param Icmp Compare instruction
4217/// \param SIOpd Operand that replaces the select
4218///
4219/// Notes:
4220/// - The replacement is global and requires dominator information
4221/// - The caller is responsible for the actual replacement
4222///
4223/// Example:
4224///
4225/// entry:
4226/// %4 = select i1 %3, %C* %0, %C* null
4227/// %5 = icmp eq %C* %4, null
4228/// br i1 %5, label %9, label %7
4229/// ...
4230/// ; <label>:7 ; preds = %entry
4231/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
4232/// ...
4233///
4234/// can be transformed to
4235///
4236/// %5 = icmp eq %C* %0, null
4237/// %6 = select i1 %3, i1 %5, i1 true
4238/// br i1 %6, label %9, label %7
4239/// ...
4240/// ; <label>:7 ; preds = %entry
4241/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4242///
4243/// Similar when the first operand of the select is a constant or/and
4244/// the compare is for not equal rather than equal.
4245///
4246/// NOTE: The function is only called when the select and compare constants
4247/// are equal, the optimization can work only for EQ predicates. This is not a
4248/// major restriction since a NE compare should be 'normalized' to an equal
4249/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004250/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004251bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4252 const ICmpInst *Icmp,
4253 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004254 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004255 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4256 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004257 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004258 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004259 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4260 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4261 // replaced can be reached on either path. So the uniqueness check
4262 // guarantees that the path all uses of SI (outside SI's parent) are on
4263 // is disjoint from all other paths out of SI. But that information
4264 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004265 // of compile-time. It should also be noticed that we check for a single
4266 // predecessor and not only uniqueness. This to handle the situation when
4267 // Succ and Succ1 points to the same basic block.
4268 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004269 NumSel++;
4270 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4271 return true;
4272 }
4273 }
4274 return false;
4275}
4276
Sanjay Patel3151dec2016-09-12 15:24:31 +00004277/// Try to fold the comparison based on range information we can get by checking
4278/// whether bits are known to be zero or one in the inputs.
4279Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4280 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4281 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004282 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004283
4284 // Get scalar or pointer size.
4285 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4286 ? Ty->getScalarSizeInBits()
Elena Demikhovsky945b7e52018-02-14 06:58:08 +00004287 : DL.getIndexTypeSizeInBits(Ty->getScalarType());
Sanjay Patel3151dec2016-09-12 15:24:31 +00004288
4289 if (!BitWidth)
4290 return nullptr;
4291
Craig Topperb45eabc2017-04-26 16:39:58 +00004292 KnownBits Op0Known(BitWidth);
4293 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004294
Craig Topper47596dd2017-03-25 06:52:52 +00004295 if (SimplifyDemandedBits(&I, 0,
Craig Topper3edda872017-09-22 18:57:23 +00004296 getDemandedBitsLHSMask(I, BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004297 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004298 return &I;
4299
Craig Topper47596dd2017-03-25 06:52:52 +00004300 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004301 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004302 return &I;
4303
4304 // Given the known and unknown bits, compute a range that the LHS could be
4305 // in. Compute the Min, Max and RHS values based on the known bits. For the
4306 // EQ and NE we use unsigned values.
4307 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4308 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4309 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004310 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4311 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004312 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004313 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4314 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004315 }
4316
Sanjay Patelc63f9012018-01-04 14:31:56 +00004317 // If Min and Max are known to be the same, then SimplifyDemandedBits figured
4318 // out that the LHS or RHS is a constant. Constant fold this now, so that
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004319 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004320 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004321 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004322 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004323 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004324
4325 // Based on the range information we know about the LHS, see if we can
4326 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004327 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004328 default:
4329 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004330 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004331 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004332 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4333 return Pred == CmpInst::ICMP_EQ
4334 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4335 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4336 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004337
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004338 // If all bits are known zero except for one, then we know at most one bit
4339 // is set. If the comparison is against zero, then this is a check to see if
4340 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004341 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004342 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004343 // If the LHS is an AND with the same constant, look through it.
4344 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004345 const APInt *LHSC;
4346 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4347 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004348 LHS = Op0;
4349
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004350 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004351 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4352 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004353 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004354 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004355 // ((1 << X) & 8) == 0 -> X != 3
4356 // ((1 << X) & 8) != 0 -> X == 3
4357 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4358 auto NewPred = ICmpInst::getInversePredicate(Pred);
4359 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004360 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004361 // ((1 << X) & 7) == 0 -> X >= 3
4362 // ((1 << X) & 7) != 0 -> X < 3
4363 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4364 auto NewPred =
4365 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4366 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004367 }
4368 }
4369
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004370 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004371 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004372 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004373 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4374 // ((8 >>u X) & 1) == 0 -> X != 3
4375 // ((8 >>u X) & 1) != 0 -> X == 3
4376 unsigned CmpVal = CI->countTrailingZeros();
4377 auto NewPred = ICmpInst::getInversePredicate(Pred);
4378 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4379 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004380 }
4381 break;
4382 }
4383 case ICmpInst::ICMP_ULT: {
4384 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4385 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4386 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4387 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4388 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4389 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4390
Craig Topper0cd25942017-09-27 22:57:18 +00004391 const APInt *CmpC;
4392 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004393 // A <u C -> A == C-1 if min(A)+1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004394 if (*CmpC == Op0Min + 1)
Craig Topper2c9b7d72017-09-22 18:57:20 +00004395 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004396 ConstantInt::get(Op1->getType(), *CmpC - 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004397 // X <u C --> X == 0, if the number of zero bits in the bottom of X
4398 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004399 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2())
Craig Topper30dc9792017-09-25 21:15:00 +00004400 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4401 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004402 }
4403 break;
4404 }
4405 case ICmpInst::ICMP_UGT: {
4406 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4407 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004408 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4409 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004410 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4411 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4412
Craig Topper0cd25942017-09-27 22:57:18 +00004413 const APInt *CmpC;
4414 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004415 // A >u C -> A == C+1 if max(a)-1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004416 if (*CmpC == Op0Max - 1)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004417 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004418 ConstantInt::get(Op1->getType(), *CmpC + 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004419 // X >u C --> X != 0, if the number of zero bits in the bottom of X
4420 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004421 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits())
Craig Topper30dc9792017-09-25 21:15:00 +00004422 return new ICmpInst(ICmpInst::ICMP_NE, Op0,
4423 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004424 }
4425 break;
4426 }
Craig Topper0cd25942017-09-27 22:57:18 +00004427 case ICmpInst::ICMP_SLT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004428 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4429 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4430 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4431 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4432 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4433 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004434 const APInt *CmpC;
4435 if (match(Op1, m_APInt(CmpC))) {
4436 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004437 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004438 ConstantInt::get(Op1->getType(), *CmpC - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004439 }
4440 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004441 }
4442 case ICmpInst::ICMP_SGT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004443 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4444 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4445 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4446 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004447 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4448 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004449 const APInt *CmpC;
4450 if (match(Op1, m_APInt(CmpC))) {
4451 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004452 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004453 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004454 }
4455 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004456 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004457 case ICmpInst::ICMP_SGE:
4458 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4459 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4460 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4461 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4462 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004463 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B)
4464 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004465 break;
4466 case ICmpInst::ICMP_SLE:
4467 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4468 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4469 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4470 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4471 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004472 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B)
4473 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004474 break;
4475 case ICmpInst::ICMP_UGE:
4476 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4477 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4478 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4479 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4480 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004481 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B)
4482 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004483 break;
4484 case ICmpInst::ICMP_ULE:
4485 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4486 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4487 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4488 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4489 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004490 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B)
4491 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004492 break;
4493 }
4494
4495 // Turn a signed comparison into an unsigned one if both operands are known to
4496 // have the same sign.
4497 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004498 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4499 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004500 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4501
4502 return nullptr;
4503}
4504
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004505/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4506/// it into the appropriate icmp lt or icmp gt instruction. This transform
4507/// allows them to be folded in visitICmpInst.
Sanjay Patele9b2c322016-05-17 00:57:57 +00004508static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
4509 ICmpInst::Predicate Pred = I.getPredicate();
4510 if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGE &&
4511 Pred != ICmpInst::ICMP_ULE && Pred != ICmpInst::ICMP_UGE)
4512 return nullptr;
4513
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004514 Value *Op0 = I.getOperand(0);
4515 Value *Op1 = I.getOperand(1);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004516 auto *Op1C = dyn_cast<Constant>(Op1);
4517 if (!Op1C)
4518 return nullptr;
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004519
Sanjay Patele9b2c322016-05-17 00:57:57 +00004520 // Check if the constant operand can be safely incremented/decremented without
4521 // overflowing/underflowing. For scalars, SimplifyICmpInst has already handled
4522 // the edge cases for us, so we just assert on them. For vectors, we must
4523 // handle the edge cases.
4524 Type *Op1Type = Op1->getType();
4525 bool IsSigned = I.isSigned();
4526 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE);
Sanjay Patel18254932016-05-17 01:12:31 +00004527 auto *CI = dyn_cast<ConstantInt>(Op1C);
4528 if (CI) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004529 // A <= MAX -> TRUE ; A >= MIN -> TRUE
4530 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned));
4531 } else if (Op1Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004532 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004533 // are for scalar, we could remove the min/max checks. However, to do that,
4534 // we would have to use insertelement/shufflevector to replace edge values.
4535 unsigned NumElts = Op1Type->getVectorNumElements();
4536 for (unsigned i = 0; i != NumElts; ++i) {
4537 Constant *Elt = Op1C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004538 if (!Elt)
4539 return nullptr;
4540
Sanjay Patele9b2c322016-05-17 00:57:57 +00004541 if (isa<UndefValue>(Elt))
4542 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004543
Sanjay Patele9b2c322016-05-17 00:57:57 +00004544 // Bail out if we can't determine if this constant is min/max or if we
4545 // know that this constant is min/max.
4546 auto *CI = dyn_cast<ConstantInt>(Elt);
4547 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned)))
4548 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004549 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004550 } else {
4551 // ConstantExpr?
4552 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004553 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004554
Sanjay Patele9b2c322016-05-17 00:57:57 +00004555 // Increment or decrement the constant and set the new comparison predicate:
4556 // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT
Sanjay Patel22b01fe2016-05-17 20:20:40 +00004557 Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004558 CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT;
4559 NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred;
4560 return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne));
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004561}
4562
Sanjay Patele5747e32017-05-17 22:15:07 +00004563/// Integer compare with boolean values can always be turned into bitwise ops.
4564static Instruction *canonicalizeICmpBool(ICmpInst &I,
4565 InstCombiner::BuilderTy &Builder) {
4566 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00004567 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00004568
Sanjay Patelba212c22017-05-17 22:29:40 +00004569 // A boolean compared to true/false can be simplified to Op0/true/false in
4570 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
4571 // Cases not handled by InstSimplify are always 'not' of Op0.
4572 if (match(B, m_Zero())) {
4573 switch (I.getPredicate()) {
4574 case CmpInst::ICMP_EQ: // A == 0 -> !A
4575 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
4576 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
4577 return BinaryOperator::CreateNot(A);
4578 default:
4579 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4580 }
4581 } else if (match(B, m_One())) {
4582 switch (I.getPredicate()) {
4583 case CmpInst::ICMP_NE: // A != 1 -> !A
4584 case CmpInst::ICMP_ULT: // A <u 1 -> !A
4585 case CmpInst::ICMP_SGT: // A >s -1 -> !A
4586 return BinaryOperator::CreateNot(A);
4587 default:
4588 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4589 }
4590 }
4591
Sanjay Patele5747e32017-05-17 22:15:07 +00004592 switch (I.getPredicate()) {
4593 default:
4594 llvm_unreachable("Invalid icmp instruction!");
4595 case ICmpInst::ICMP_EQ:
4596 // icmp eq i1 A, B -> ~(A ^ B)
4597 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
4598
4599 case ICmpInst::ICMP_NE:
4600 // icmp ne i1 A, B -> A ^ B
4601 return BinaryOperator::CreateXor(A, B);
4602
4603 case ICmpInst::ICMP_UGT:
4604 // icmp ugt -> icmp ult
4605 std::swap(A, B);
4606 LLVM_FALLTHROUGH;
4607 case ICmpInst::ICMP_ULT:
4608 // icmp ult i1 A, B -> ~A & B
4609 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
4610
4611 case ICmpInst::ICMP_SGT:
4612 // icmp sgt -> icmp slt
4613 std::swap(A, B);
4614 LLVM_FALLTHROUGH;
4615 case ICmpInst::ICMP_SLT:
4616 // icmp slt i1 A, B -> A & ~B
4617 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
4618
4619 case ICmpInst::ICMP_UGE:
4620 // icmp uge -> icmp ule
4621 std::swap(A, B);
4622 LLVM_FALLTHROUGH;
4623 case ICmpInst::ICMP_ULE:
4624 // icmp ule i1 A, B -> ~A | B
4625 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
4626
4627 case ICmpInst::ICMP_SGE:
4628 // icmp sge -> icmp sle
4629 std::swap(A, B);
4630 LLVM_FALLTHROUGH;
4631 case ICmpInst::ICMP_SLE:
4632 // icmp sle i1 A, B -> A | ~B
4633 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
4634 }
4635}
4636
Roman Lebedev75404fb2018-09-12 18:19:43 +00004637// Transform pattern like:
Roman Lebedev1b7fc872018-09-15 12:04:13 +00004638// (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X
4639// (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X
Roman Lebedev75404fb2018-09-12 18:19:43 +00004640// Into:
4641// (X l>> Y) != 0
4642// (X l>> Y) == 0
4643static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp,
4644 InstCombiner::BuilderTy &Builder) {
Roman Lebedev6dc87002018-09-13 20:33:12 +00004645 ICmpInst::Predicate Pred, NewPred;
Roman Lebedev75404fb2018-09-12 18:19:43 +00004646 Value *X, *Y;
Roman Lebedev6dc87002018-09-13 20:33:12 +00004647 if (match(&Cmp,
4648 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) {
4649 // We want X to be the icmp's second operand, so swap predicate if it isn't.
4650 if (Cmp.getOperand(0) == X)
4651 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00004652
Roman Lebedev6dc87002018-09-13 20:33:12 +00004653 switch (Pred) {
4654 case ICmpInst::ICMP_ULE:
4655 NewPred = ICmpInst::ICMP_NE;
4656 break;
4657 case ICmpInst::ICMP_UGT:
4658 NewPred = ICmpInst::ICMP_EQ;
4659 break;
4660 default:
4661 return nullptr;
4662 }
Roman Lebedev1b7fc872018-09-15 12:04:13 +00004663 } else if (match(&Cmp, m_c_ICmp(Pred,
4664 m_OneUse(m_CombineOr(
4665 m_Not(m_Shl(m_AllOnes(), m_Value(Y))),
4666 m_Add(m_Shl(m_One(), m_Value(Y)),
4667 m_AllOnes()))),
4668 m_Value(X)))) {
4669 // The variant with 'add' is not canonical, (the variant with 'not' is)
4670 // we only get it because it has extra uses, and can't be canonicalized,
4671
Roman Lebedev6dc87002018-09-13 20:33:12 +00004672 // We want X to be the icmp's second operand, so swap predicate if it isn't.
4673 if (Cmp.getOperand(0) == X)
4674 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00004675
Roman Lebedev6dc87002018-09-13 20:33:12 +00004676 switch (Pred) {
4677 case ICmpInst::ICMP_ULT:
4678 NewPred = ICmpInst::ICMP_NE;
4679 break;
4680 case ICmpInst::ICMP_UGE:
4681 NewPred = ICmpInst::ICMP_EQ;
4682 break;
4683 default:
4684 return nullptr;
4685 }
4686 } else
Roman Lebedev75404fb2018-09-12 18:19:43 +00004687 return nullptr;
Roman Lebedev75404fb2018-09-12 18:19:43 +00004688
4689 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits");
4690 Constant *Zero = Constant::getNullValue(NewX->getType());
4691 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero);
4692}
4693
Sanjay Patel039f5562018-08-16 12:52:17 +00004694static Instruction *foldVectorCmp(CmpInst &Cmp,
4695 InstCombiner::BuilderTy &Builder) {
4696 // If both arguments of the cmp are shuffles that use the same mask and
4697 // shuffle within a single vector, move the shuffle after the cmp.
4698 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1);
4699 Value *V1, *V2;
4700 Constant *M;
4701 if (match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Constant(M))) &&
4702 match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_Specific(M))) &&
4703 V1->getType() == V2->getType() &&
4704 (LHS->hasOneUse() || RHS->hasOneUse())) {
4705 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M
4706 CmpInst::Predicate P = Cmp.getPredicate();
4707 Value *NewCmp = isa<ICmpInst>(Cmp) ? Builder.CreateICmp(P, V1, V2)
4708 : Builder.CreateFCmp(P, V1, V2);
4709 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M);
4710 }
4711 return nullptr;
4712}
4713
Chris Lattner2188e402010-01-04 07:37:31 +00004714Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
4715 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00004716 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00004717 unsigned Op0Cplxity = getComplexity(Op0);
4718 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004719
Chris Lattner2188e402010-01-04 07:37:31 +00004720 /// Orders the operands of the compare so that they are listed from most
4721 /// complex to least complex. This puts constants before unary operators,
4722 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004723 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00004724 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004725 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00004726 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00004727 Changed = true;
4728 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004729
Daniel Berlin2c75c632017-04-26 20:56:07 +00004730 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
4731 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004732 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004733
Uriel Korach18972232017-09-10 08:31:22 +00004734 // Comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00004735 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00004736 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004737 Value *Cond, *SelectTrue, *SelectFalse;
4738 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00004739 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004740 if (Value *V = dyn_castNegVal(SelectTrue)) {
4741 if (V == SelectFalse)
4742 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
4743 }
4744 else if (Value *V = dyn_castNegVal(SelectFalse)) {
4745 if (V == SelectTrue)
4746 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00004747 }
4748 }
4749 }
4750
Craig Topperfde47232017-07-09 07:04:03 +00004751 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00004752 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00004753 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004754
Sanjay Patele9b2c322016-05-17 00:57:57 +00004755 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004756 return NewICmp;
4757
Sanjay Patel06b127a2016-09-15 14:37:50 +00004758 if (Instruction *Res = foldICmpWithConstant(I))
4759 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004760
Max Kazantsev20da7e42018-07-06 04:04:13 +00004761 if (Instruction *Res = foldICmpUsingKnownBits(I))
4762 return Res;
4763
Chris Lattner2188e402010-01-04 07:37:31 +00004764 // Test if the ICmpInst instruction is used exclusively by a select as
4765 // part of a minimum or maximum operation. If so, refrain from doing
4766 // any other folding. This helps out other analyses which understand
4767 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4768 // and CodeGen. And in this case, at least one of the comparison
4769 // operands has at least one user besides the compare (the select),
4770 // which would often largely negate the benefit of folding anyway.
Craig Topperd3e57812017-11-12 02:28:21 +00004771 //
4772 // Do the same for the other patterns recognized by matchSelectPattern.
Chris Lattner2188e402010-01-04 07:37:31 +00004773 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00004774 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
4775 Value *A, *B;
4776 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
4777 if (SPR.Flavor != SPF_UNKNOWN)
Craig Topperf40110f2014-04-25 05:29:35 +00004778 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00004779 }
Chris Lattner2188e402010-01-04 07:37:31 +00004780
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00004781 // Do this after checking for min/max to prevent infinite looping.
4782 if (Instruction *Res = foldICmpWithZero(I))
4783 return Res;
4784
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00004785 // FIXME: We only do this after checking for min/max to prevent infinite
4786 // looping caused by a reverse canonicalization of these patterns for min/max.
4787 // FIXME: The organization of folds is a mess. These would naturally go into
4788 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
4789 // down here after the min/max restriction.
4790 ICmpInst::Predicate Pred = I.getPredicate();
4791 const APInt *C;
4792 if (match(Op1, m_APInt(C))) {
4793 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
4794 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
4795 Constant *Zero = Constant::getNullValue(Op0->getType());
4796 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
4797 }
4798
4799 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
4800 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
4801 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
4802 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
4803 }
4804 }
4805
Sanjay Patelf58f68c2016-09-10 15:03:44 +00004806 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00004807 return Res;
4808
Sanjay Patel10494b22016-09-16 16:10:22 +00004809 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
4810 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004811
4812 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
4813 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00004814 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00004815 return NI;
4816 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004817 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00004818 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
4819 return NI;
4820
Hans Wennborgf1f36512015-10-07 00:20:07 +00004821 // Try to optimize equality comparisons against alloca-based pointers.
4822 if (Op0->getType()->isPointerTy() && I.isEquality()) {
4823 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
4824 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004825 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004826 return New;
4827 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004828 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004829 return New;
4830 }
4831
Sanjay Patel841aac02018-03-25 14:01:42 +00004832 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast.
Roman Lebedeve6da3062018-03-18 15:53:02 +00004833 Value *X;
Sanjay Patel745a9c62018-03-24 15:45:02 +00004834 if (match(Op0, m_BitCast(m_SIToFP(m_Value(X))))) {
Sanjay Patel841aac02018-03-25 14:01:42 +00004835 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0
4836 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0
4837 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0
4838 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0
4839 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT ||
4840 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) &&
4841 match(Op1, m_Zero()))
Sanjay Patel745a9c62018-03-24 15:45:02 +00004842 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patel841aac02018-03-25 14:01:42 +00004843
4844 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1
4845 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One()))
4846 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1));
4847
4848 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1
Sanjay Patel745a9c62018-03-24 15:45:02 +00004849 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes()))
4850 return new ICmpInst(Pred, X, ConstantInt::getAllOnesValue(X->getType()));
4851 }
Roman Lebedeve6da3062018-03-18 15:53:02 +00004852
4853 // Zero-equality checks are preserved through unsigned floating-point casts:
4854 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0
4855 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0
4856 if (match(Op0, m_BitCast(m_UIToFP(m_Value(X)))))
4857 if (I.isEquality() && match(Op1, m_Zero()))
4858 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
4859
Chris Lattner2188e402010-01-04 07:37:31 +00004860 // Test to see if the operands of the icmp are casted versions of other
4861 // values. If the ptr->ptr cast can be stripped off both arguments, we do so
4862 // now.
4863 if (BitCastInst *CI = dyn_cast<BitCastInst>(Op0)) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004864 if (Op0->getType()->isPointerTy() &&
4865 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004866 // We keep moving the cast from the left operand over to the right
4867 // operand, where it can often be eliminated completely.
4868 Op0 = CI->getOperand(0);
4869
4870 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
4871 // so eliminate it as well.
4872 if (BitCastInst *CI2 = dyn_cast<BitCastInst>(Op1))
4873 Op1 = CI2->getOperand(0);
4874
4875 // If Op1 is a constant, we can fold the cast into the constant.
4876 if (Op0->getType() != Op1->getType()) {
4877 if (Constant *Op1C = dyn_cast<Constant>(Op1)) {
4878 Op1 = ConstantExpr::getBitCast(Op1C, Op0->getType());
4879 } else {
4880 // Otherwise, cast the RHS right before the icmp
Craig Topperbb4069e2017-07-07 23:16:26 +00004881 Op1 = Builder.CreateBitCast(Op1, Op0->getType());
Chris Lattner2188e402010-01-04 07:37:31 +00004882 }
4883 }
4884 return new ICmpInst(I.getPredicate(), Op0, Op1);
4885 }
4886 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004887
Chris Lattner2188e402010-01-04 07:37:31 +00004888 if (isa<CastInst>(Op0)) {
4889 // Handle the special case of: icmp (cast bool to X), <cst>
4890 // This comes up when you have code like
4891 // int X = A < B;
4892 // if (X) ...
4893 // For generality, we handle any zero-extension of any operand comparison
4894 // with a constant or another cast from the same type.
4895 if (isa<Constant>(Op1) || isa<CastInst>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004896 if (Instruction *R = foldICmpWithCastAndCast(I))
Chris Lattner2188e402010-01-04 07:37:31 +00004897 return R;
4898 }
Chris Lattner2188e402010-01-04 07:37:31 +00004899
Sanjay Patel10494b22016-09-16 16:10:22 +00004900 if (Instruction *Res = foldICmpBinOp(I))
4901 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00004902
Sanjay Pateldd46b522016-12-19 17:32:37 +00004903 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00004904 return Res;
4905
Sanjay Patel10494b22016-09-16 16:10:22 +00004906 {
4907 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00004908 // Transform (A & ~B) == 0 --> (A & B) != 0
4909 // and (A & ~B) != 0 --> (A & B) == 0
4910 // if A is a power of 2.
4911 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00004912 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00004913 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00004914 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00004915 Op1);
4916
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004917 // ~X < ~Y --> Y < X
4918 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004919 if (match(Op0, m_Not(m_Value(A)))) {
4920 if (match(Op1, m_Not(m_Value(B))))
4921 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004922
Sanjay Patelce241f42017-06-02 16:29:41 +00004923 const APInt *C;
4924 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004925 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00004926 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004927 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00004928
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004929 Instruction *AddI = nullptr;
4930 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
4931 m_Instruction(AddI))) &&
4932 isa<IntegerType>(A->getType())) {
4933 Value *Result;
4934 Constant *Overflow;
4935 if (OptimizeOverflowCheck(OCF_UNSIGNED_ADD, A, B, *AddI, Result,
4936 Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00004937 replaceInstUsesWith(*AddI, Result);
4938 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004939 }
4940 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004941
4942 // (zext a) * (zext b) --> llvm.umul.with.overflow.
4943 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004944 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004945 return R;
4946 }
4947 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004948 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004949 return R;
4950 }
Chris Lattner2188e402010-01-04 07:37:31 +00004951 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004952
Sanjay Patel10494b22016-09-16 16:10:22 +00004953 if (Instruction *Res = foldICmpEquality(I))
4954 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004955
David Majnemerc1eca5a2014-11-06 23:23:30 +00004956 // The 'cmpxchg' instruction returns an aggregate containing the old value and
4957 // an i1 which indicates whether or not we successfully did the swap.
4958 //
4959 // Replace comparisons between the old value and the expected value with the
4960 // indicator that 'cmpxchg' returns.
4961 //
4962 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
4963 // spuriously fail. In those cases, the old value may equal the expected
4964 // value but it is possible for the swap to not occur.
4965 if (I.getPredicate() == ICmpInst::ICMP_EQ)
4966 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
4967 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
4968 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
4969 !ACXI->isWeak())
4970 return ExtractValueInst::Create(ACXI, 1);
4971
Chris Lattner2188e402010-01-04 07:37:31 +00004972 {
Craig Topperbee74792018-08-20 23:04:25 +00004973 Value *X;
4974 const APInt *C;
Chris Lattner2188e402010-01-04 07:37:31 +00004975 // icmp X+Cst, X
Craig Topperbee74792018-08-20 23:04:25 +00004976 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X)
4977 return foldICmpAddOpConst(X, *C, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004978
4979 // icmp X, X+Cst
Craig Topperbee74792018-08-20 23:04:25 +00004980 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X)
4981 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004982 }
Roman Lebedev68d54cf2018-07-11 19:05:04 +00004983
Roman Lebedev75404fb2018-09-12 18:19:43 +00004984 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder))
4985 return Res;
4986
Sanjay Patel039f5562018-08-16 12:52:17 +00004987 if (I.getType()->isVectorTy())
4988 if (Instruction *Res = foldVectorCmp(I, Builder))
4989 return Res;
4990
Craig Topperf40110f2014-04-25 05:29:35 +00004991 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004992}
4993
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004994/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00004995Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00004996 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00004997 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004998 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00004999
Chris Lattner2188e402010-01-04 07:37:31 +00005000 // Get the width of the mantissa. We don't want to hack on conversions that
5001 // might lose information from the integer, e.g. "i64 -> float"
5002 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00005003 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005004
Matt Arsenault55e73122015-01-06 15:50:59 +00005005 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
5006
Chris Lattner2188e402010-01-04 07:37:31 +00005007 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005008
Matt Arsenault55e73122015-01-06 15:50:59 +00005009 if (I.isEquality()) {
5010 FCmpInst::Predicate P = I.getPredicate();
5011 bool IsExact = false;
5012 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
5013 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
5014
5015 // If the floating point constant isn't an integer value, we know if we will
5016 // ever compare equal / not equal to it.
5017 if (!IsExact) {
5018 // TODO: Can never be -0.0 and other non-representable values
5019 APFloat RHSRoundInt(RHS);
5020 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
5021 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
5022 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00005023 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00005024
5025 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00005026 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00005027 }
5028 }
5029
5030 // TODO: If the constant is exactly representable, is it always OK to do
5031 // equality compares as integer?
5032 }
5033
Arch D. Robison8ed08542015-09-15 17:51:59 +00005034 // Check to see that the input is converted from an integer type that is small
5035 // enough that preserves all bits. TODO: check here for "known" sign bits.
5036 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
5037 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00005038
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005039 // Following test does NOT adjust InputSize downwards for signed inputs,
5040 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00005041 // to distinguish it from one less than that value.
5042 if ((int)InputSize > MantissaWidth) {
5043 // Conversion would lose accuracy. Check if loss can impact comparison.
5044 int Exp = ilogb(RHS);
5045 if (Exp == APFloat::IEK_Inf) {
5046 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005047 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005048 // Conversion could create infinity.
5049 return nullptr;
5050 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005051 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00005052 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005053 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005054 // Conversion could affect comparison.
5055 return nullptr;
5056 }
5057 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005058
Chris Lattner2188e402010-01-04 07:37:31 +00005059 // Otherwise, we can potentially simplify the comparison. We know that it
5060 // will always come through as an integer value and we know the constant is
5061 // not a NAN (it would have been previously simplified).
5062 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00005063
Chris Lattner2188e402010-01-04 07:37:31 +00005064 ICmpInst::Predicate Pred;
5065 switch (I.getPredicate()) {
5066 default: llvm_unreachable("Unexpected predicate!");
5067 case FCmpInst::FCMP_UEQ:
5068 case FCmpInst::FCMP_OEQ:
5069 Pred = ICmpInst::ICMP_EQ;
5070 break;
5071 case FCmpInst::FCMP_UGT:
5072 case FCmpInst::FCMP_OGT:
5073 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
5074 break;
5075 case FCmpInst::FCMP_UGE:
5076 case FCmpInst::FCMP_OGE:
5077 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
5078 break;
5079 case FCmpInst::FCMP_ULT:
5080 case FCmpInst::FCMP_OLT:
5081 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
5082 break;
5083 case FCmpInst::FCMP_ULE:
5084 case FCmpInst::FCMP_OLE:
5085 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
5086 break;
5087 case FCmpInst::FCMP_UNE:
5088 case FCmpInst::FCMP_ONE:
5089 Pred = ICmpInst::ICMP_NE;
5090 break;
5091 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00005092 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005093 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00005094 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005095 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005096
Chris Lattner2188e402010-01-04 07:37:31 +00005097 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005098
Chris Lattner2188e402010-01-04 07:37:31 +00005099 // See if the FP constant is too large for the integer. For example,
5100 // comparing an i8 to 300.0.
5101 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005102
Chris Lattner2188e402010-01-04 07:37:31 +00005103 if (!LHSUnsigned) {
5104 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
5105 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005106 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005107 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
5108 APFloat::rmNearestTiesToEven);
5109 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
5110 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
5111 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005112 return replaceInstUsesWith(I, Builder.getTrue());
5113 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005114 }
5115 } else {
5116 // If the RHS value is > UnsignedMax, fold the comparison. This handles
5117 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005118 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005119 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
5120 APFloat::rmNearestTiesToEven);
5121 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
5122 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
5123 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005124 return replaceInstUsesWith(I, Builder.getTrue());
5125 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005126 }
5127 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005128
Chris Lattner2188e402010-01-04 07:37:31 +00005129 if (!LHSUnsigned) {
5130 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005131 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005132 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
5133 APFloat::rmNearestTiesToEven);
5134 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
5135 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
5136 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005137 return replaceInstUsesWith(I, Builder.getTrue());
5138 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005139 }
Devang Patel698452b2012-02-13 23:05:18 +00005140 } else {
5141 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005142 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00005143 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
5144 APFloat::rmNearestTiesToEven);
5145 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
5146 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
5147 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005148 return replaceInstUsesWith(I, Builder.getTrue());
5149 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00005150 }
Chris Lattner2188e402010-01-04 07:37:31 +00005151 }
5152
5153 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
5154 // [0, UMAX], but it may still be fractional. See if it is fractional by
5155 // casting the FP value to the integer value and back, checking for equality.
5156 // Don't do this for zero, because -0.0 is not fractional.
5157 Constant *RHSInt = LHSUnsigned
5158 ? ConstantExpr::getFPToUI(RHSC, IntTy)
5159 : ConstantExpr::getFPToSI(RHSC, IntTy);
5160 if (!RHS.isZero()) {
5161 bool Equal = LHSUnsigned
5162 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
5163 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
5164 if (!Equal) {
5165 // If we had a comparison against a fractional value, we have to adjust
5166 // the compare predicate and sometimes the value. RHSC is rounded towards
5167 // zero at this point.
5168 switch (Pred) {
5169 default: llvm_unreachable("Unexpected integer comparison!");
5170 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00005171 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005172 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00005173 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005174 case ICmpInst::ICMP_ULE:
5175 // (float)int <= 4.4 --> int <= 4
5176 // (float)int <= -4.4 --> false
5177 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005178 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005179 break;
5180 case ICmpInst::ICMP_SLE:
5181 // (float)int <= 4.4 --> int <= 4
5182 // (float)int <= -4.4 --> int < -4
5183 if (RHS.isNegative())
5184 Pred = ICmpInst::ICMP_SLT;
5185 break;
5186 case ICmpInst::ICMP_ULT:
5187 // (float)int < -4.4 --> false
5188 // (float)int < 4.4 --> int <= 4
5189 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005190 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005191 Pred = ICmpInst::ICMP_ULE;
5192 break;
5193 case ICmpInst::ICMP_SLT:
5194 // (float)int < -4.4 --> int < -4
5195 // (float)int < 4.4 --> int <= 4
5196 if (!RHS.isNegative())
5197 Pred = ICmpInst::ICMP_SLE;
5198 break;
5199 case ICmpInst::ICMP_UGT:
5200 // (float)int > 4.4 --> int > 4
5201 // (float)int > -4.4 --> true
5202 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005203 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005204 break;
5205 case ICmpInst::ICMP_SGT:
5206 // (float)int > 4.4 --> int > 4
5207 // (float)int > -4.4 --> int >= -4
5208 if (RHS.isNegative())
5209 Pred = ICmpInst::ICMP_SGE;
5210 break;
5211 case ICmpInst::ICMP_UGE:
5212 // (float)int >= -4.4 --> true
5213 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00005214 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005215 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005216 Pred = ICmpInst::ICMP_UGT;
5217 break;
5218 case ICmpInst::ICMP_SGE:
5219 // (float)int >= -4.4 --> int >= -4
5220 // (float)int >= 4.4 --> int > 4
5221 if (!RHS.isNegative())
5222 Pred = ICmpInst::ICMP_SGT;
5223 break;
5224 }
5225 }
5226 }
5227
5228 // Lower this FP comparison into an appropriate integer version of the
5229 // comparison.
5230 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
5231}
5232
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005233/// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary.
5234static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI,
5235 Constant *RHSC) {
5236 // When C is not 0.0 and infinities are not allowed:
5237 // (C / X) < 0.0 is a sign-bit test of X
5238 // (C / X) < 0.0 --> X < 0.0 (if C is positive)
5239 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate)
5240 //
5241 // Proof:
5242 // Multiply (C / X) < 0.0 by X * X / C.
5243 // - X is non zero, if it is the flag 'ninf' is violated.
5244 // - C defines the sign of X * X * C. Thus it also defines whether to swap
5245 // the predicate. C is also non zero by definition.
5246 //
5247 // Thus X * X / C is non zero and the transformation is valid. [qed]
5248
5249 FCmpInst::Predicate Pred = I.getPredicate();
5250
5251 // Check that predicates are valid.
5252 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) &&
5253 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE))
5254 return nullptr;
5255
5256 // Check that RHS operand is zero.
5257 if (!match(RHSC, m_AnyZeroFP()))
5258 return nullptr;
5259
5260 // Check fastmath flags ('ninf').
5261 if (!LHSI->hasNoInfs() || !I.hasNoInfs())
5262 return nullptr;
5263
5264 // Check the properties of the dividend. It must not be zero to avoid a
5265 // division by zero (see Proof).
5266 const APFloat *C;
5267 if (!match(LHSI->getOperand(0), m_APFloat(C)))
5268 return nullptr;
5269
5270 if (C->isZero())
5271 return nullptr;
5272
5273 // Get swapped predicate if necessary.
5274 if (C->isNegative())
5275 Pred = I.getSwappedPredicate();
5276
5277 // Finally emit the new fcmp.
5278 Value *X = LHSI->getOperand(1);
5279 FCmpInst *NewFCI = new FCmpInst(Pred, X, RHSC);
5280 NewFCI->setFastMathFlags(I.getFastMathFlags());
5281 return NewFCI;
5282}
5283
Chris Lattner2188e402010-01-04 07:37:31 +00005284Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
5285 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005286
Chris Lattner2188e402010-01-04 07:37:31 +00005287 /// Orders the operands of the compare so that they are listed from most
5288 /// complex to least complex. This puts constants before unary operators,
5289 /// before binary operators.
5290 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
5291 I.swapOperands();
5292 Changed = true;
5293 }
5294
Sanjay Patel6b139462017-09-02 15:11:55 +00005295 const CmpInst::Predicate Pred = I.getPredicate();
Chris Lattner2188e402010-01-04 07:37:31 +00005296 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel6b139462017-09-02 15:11:55 +00005297 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(),
5298 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005299 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00005300
5301 // Simplify 'fcmp pred X, X'
5302 if (Op0 == Op1) {
Sanjay Patel6b139462017-09-02 15:11:55 +00005303 switch (Pred) {
5304 default: break;
Chris Lattner2188e402010-01-04 07:37:31 +00005305 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
5306 case FCmpInst::FCMP_ULT: // True if unordered or less than
5307 case FCmpInst::FCMP_UGT: // True if unordered or greater than
5308 case FCmpInst::FCMP_UNE: // True if unordered or not equal
5309 // Canonicalize these to be 'fcmp uno %X, 0.0'.
5310 I.setPredicate(FCmpInst::FCMP_UNO);
5311 I.setOperand(1, Constant::getNullValue(Op0->getType()));
5312 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005313
Chris Lattner2188e402010-01-04 07:37:31 +00005314 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
5315 case FCmpInst::FCMP_OEQ: // True if ordered and equal
5316 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
5317 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
5318 // Canonicalize these to be 'fcmp ord %X, 0.0'.
5319 I.setPredicate(FCmpInst::FCMP_ORD);
5320 I.setOperand(1, Constant::getNullValue(Op0->getType()));
5321 return &I;
5322 }
5323 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005324
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005325 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand,
5326 // then canonicalize the operand to 0.0.
5327 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) {
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005328 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) {
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005329 I.setOperand(0, ConstantFP::getNullValue(Op0->getType()));
5330 return &I;
5331 }
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005332 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) {
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005333 I.setOperand(1, ConstantFP::getNullValue(Op0->getType()));
5334 return &I;
5335 }
5336 }
5337
James Molloy2b21a7c2015-05-20 18:41:25 +00005338 // Test if the FCmpInst instruction is used exclusively by a select as
5339 // part of a minimum or maximum operation. If so, refrain from doing
5340 // any other folding. This helps out other analyses which understand
5341 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5342 // and CodeGen. And in this case, at least one of the comparison
5343 // operands has at least one user besides the compare (the select),
5344 // which would often largely negate the benefit of folding anyway.
5345 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005346 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5347 Value *A, *B;
5348 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5349 if (SPR.Flavor != SPF_UNKNOWN)
James Molloy2b21a7c2015-05-20 18:41:25 +00005350 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005351 }
James Molloy2b21a7c2015-05-20 18:41:25 +00005352
Chris Lattner2188e402010-01-04 07:37:31 +00005353 // Handle fcmp with constant RHS
5354 if (Constant *RHSC = dyn_cast<Constant>(Op1)) {
5355 if (Instruction *LHSI = dyn_cast<Instruction>(Op0))
5356 switch (LHSI->getOpcode()) {
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005357 case Instruction::FPExt: {
5358 // fcmp (fpext x), C -> fcmp x, (fptrunc C) if fptrunc is lossless
5359 FPExtInst *LHSExt = cast<FPExtInst>(LHSI);
5360 ConstantFP *RHSF = dyn_cast<ConstantFP>(RHSC);
5361 if (!RHSF)
5362 break;
5363
5364 const fltSemantics *Sem;
5365 // FIXME: This shouldn't be here.
Dan Gohman518cda42011-12-17 00:04:22 +00005366 if (LHSExt->getSrcTy()->isHalfTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005367 Sem = &APFloat::IEEEhalf();
Dan Gohman518cda42011-12-17 00:04:22 +00005368 else if (LHSExt->getSrcTy()->isFloatTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005369 Sem = &APFloat::IEEEsingle();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005370 else if (LHSExt->getSrcTy()->isDoubleTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005371 Sem = &APFloat::IEEEdouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005372 else if (LHSExt->getSrcTy()->isFP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005373 Sem = &APFloat::IEEEquad();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005374 else if (LHSExt->getSrcTy()->isX86_FP80Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005375 Sem = &APFloat::x87DoubleExtended();
Ulrich Weigand6a9bb512012-10-30 12:33:18 +00005376 else if (LHSExt->getSrcTy()->isPPC_FP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00005377 Sem = &APFloat::PPCDoubleDouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005378 else
5379 break;
5380
5381 bool Lossy;
5382 APFloat F = RHSF->getValueAPF();
5383 F.convert(*Sem, APFloat::rmNearestTiesToEven, &Lossy);
5384
Jim Grosbach24ff8342011-09-30 18:45:50 +00005385 // Avoid lossy conversions and denormals. Zero is a special case
5386 // that's OK to convert.
Jim Grosbach011dafb2011-09-30 19:58:46 +00005387 APFloat Fabs = F;
5388 Fabs.clearSign();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005389 if (!Lossy &&
Jim Grosbach011dafb2011-09-30 19:58:46 +00005390 ((Fabs.compare(APFloat::getSmallestNormalized(*Sem)) !=
5391 APFloat::cmpLessThan) || Fabs.isZero()))
Jim Grosbach24ff8342011-09-30 18:45:50 +00005392
Sanjay Patel6b139462017-09-02 15:11:55 +00005393 return new FCmpInst(Pred, LHSExt->getOperand(0),
Benjamin Kramercbb18e92011-03-31 10:12:07 +00005394 ConstantFP::get(RHSC->getContext(), F));
5395 break;
5396 }
Chris Lattner2188e402010-01-04 07:37:31 +00005397 case Instruction::PHI:
5398 // Only fold fcmp into the PHI if the phi and fcmp are in the same
5399 // block. If in the same block, we're encouraging jump threading. If
5400 // not, we are just pessimizing the code by making an i1 phi.
5401 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00005402 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00005403 return NV;
5404 break;
5405 case Instruction::SIToFP:
5406 case Instruction::UIToFP:
Sanjay Patel43395062016-07-21 18:07:40 +00005407 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
Chris Lattner2188e402010-01-04 07:37:31 +00005408 return NV;
5409 break;
Benjamin Kramera8c5d082011-03-31 10:12:15 +00005410 case Instruction::FSub: {
5411 // fcmp pred (fneg x), C -> fcmp swap(pred) x, -C
5412 Value *Op;
5413 if (match(LHSI, m_FNeg(m_Value(Op))))
5414 return new FCmpInst(I.getSwappedPredicate(), Op,
5415 ConstantExpr::getFNeg(RHSC));
5416 break;
5417 }
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005418 case Instruction::FDiv:
5419 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC))
5420 return NV;
5421 break;
Dan Gohman94732022010-02-24 06:46:09 +00005422 case Instruction::Load:
5423 if (GetElementPtrInst *GEP =
5424 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
5425 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
5426 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
5427 !cast<LoadInst>(LHSI)->isVolatile())
Sanjay Patel43395062016-07-21 18:07:40 +00005428 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
Dan Gohman94732022010-02-24 06:46:09 +00005429 return Res;
5430 }
5431 break;
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005432 case Instruction::Call: {
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00005433 if (!RHSC->isNullValue())
5434 break;
5435
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005436 CallInst *CI = cast<CallInst>(LHSI);
Justin Bogner99798402016-08-05 01:06:44 +00005437 Intrinsic::ID IID = getIntrinsicForCallSite(CI, &TLI);
David Majnemer2e02ba72016-04-15 17:21:03 +00005438 if (IID != Intrinsic::fabs)
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00005439 break;
5440
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005441 // Various optimization for fabs compared with zero.
Sanjay Patel6b139462017-09-02 15:11:55 +00005442 switch (Pred) {
David Majnemer2e02ba72016-04-15 17:21:03 +00005443 default:
5444 break;
5445 // fabs(x) < 0 --> false
5446 case FCmpInst::FCMP_OLT:
5447 llvm_unreachable("handled by SimplifyFCmpInst");
5448 // fabs(x) > 0 --> x != 0
5449 case FCmpInst::FCMP_OGT:
5450 return new FCmpInst(FCmpInst::FCMP_ONE, CI->getArgOperand(0), RHSC);
5451 // fabs(x) <= 0 --> x == 0
5452 case FCmpInst::FCMP_OLE:
5453 return new FCmpInst(FCmpInst::FCMP_OEQ, CI->getArgOperand(0), RHSC);
5454 // fabs(x) >= 0 --> !isnan(x)
5455 case FCmpInst::FCMP_OGE:
5456 return new FCmpInst(FCmpInst::FCMP_ORD, CI->getArgOperand(0), RHSC);
5457 // fabs(x) == 0 --> x == 0
5458 // fabs(x) != 0 --> x != 0
5459 case FCmpInst::FCMP_OEQ:
5460 case FCmpInst::FCMP_UEQ:
5461 case FCmpInst::FCMP_ONE:
5462 case FCmpInst::FCMP_UNE:
Sanjay Patel6b139462017-09-02 15:11:55 +00005463 return new FCmpInst(Pred, CI->getArgOperand(0), RHSC);
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005464 }
5465 }
Chris Lattner2188e402010-01-04 07:37:31 +00005466 }
Chris Lattner2188e402010-01-04 07:37:31 +00005467 }
5468
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00005469 // fcmp pred (fneg x), (fneg y) -> fcmp swap(pred) x, y
Benjamin Kramerd159d942011-03-31 10:12:22 +00005470 Value *X, *Y;
5471 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00005472 return new FCmpInst(I.getSwappedPredicate(), X, Y);
Benjamin Kramerd159d942011-03-31 10:12:22 +00005473
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005474 // fcmp (fpext x), (fpext y) -> fcmp x, y
5475 if (FPExtInst *LHSExt = dyn_cast<FPExtInst>(Op0))
5476 if (FPExtInst *RHSExt = dyn_cast<FPExtInst>(Op1))
5477 if (LHSExt->getSrcTy() == RHSExt->getSrcTy())
Sanjay Patel6b139462017-09-02 15:11:55 +00005478 return new FCmpInst(Pred, LHSExt->getOperand(0), RHSExt->getOperand(0));
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005479
Sanjay Patel039f5562018-08-16 12:52:17 +00005480 if (I.getType()->isVectorTy())
5481 if (Instruction *Res = foldVectorCmp(I, Builder))
5482 return Res;
5483
Craig Topperf40110f2014-04-25 05:29:35 +00005484 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005485}