blob: 2c8080dbf02b9dd12d2edf507906cf898e06fed0 [file] [log] [blame]
Chris Lattnerda463fe2007-12-12 07:09:47 +00001//===--- SemaDeclObjC.cpp - Semantic Analysis for ObjC Declarations -------===//
2//
3// The LLVM Compiler Infrastructure
4//
Chris Lattner5b12ab82007-12-29 19:59:25 +00005// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
Chris Lattnerda463fe2007-12-12 07:09:47 +00007//
8//===----------------------------------------------------------------------===//
9//
10// This file implements semantic analysis for Objective C declarations.
11//
12//===----------------------------------------------------------------------===//
13
Mehdi Amini9670f842016-07-18 19:02:11 +000014#include "TypeLocBuilder.h"
John McCall31168b02011-06-15 23:02:42 +000015#include "clang/AST/ASTConsumer.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000016#include "clang/AST/ASTContext.h"
17#include "clang/AST/ASTMutationListener.h"
18#include "clang/AST/DeclObjC.h"
Steve Naroff157599f2009-03-03 14:49:36 +000019#include "clang/AST/Expr.h"
John McCall31168b02011-06-15 23:02:42 +000020#include "clang/AST/ExprObjC.h"
Mehdi Amini9670f842016-07-18 19:02:11 +000021#include "clang/AST/RecursiveASTVisitor.h"
John McCall31168b02011-06-15 23:02:42 +000022#include "clang/Basic/SourceManager.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000023#include "clang/Sema/DeclSpec.h"
Chandler Carruth3a022472012-12-04 09:13:33 +000024#include "clang/Sema/Lookup.h"
25#include "clang/Sema/Scope.h"
26#include "clang/Sema/ScopeInfo.h"
Mehdi Amini9670f842016-07-18 19:02:11 +000027#include "clang/Sema/SemaInternal.h"
Douglas Gregor85f3f952015-07-07 03:57:15 +000028#include "llvm/ADT/DenseMap.h"
John McCalla1e130b2010-08-25 07:03:20 +000029#include "llvm/ADT/DenseSet.h"
30
Chris Lattnerda463fe2007-12-12 07:09:47 +000031using namespace clang;
32
John McCall31168b02011-06-15 23:02:42 +000033/// Check whether the given method, which must be in the 'init'
34/// family, is a valid member of that family.
35///
36/// \param receiverTypeIfCall - if null, check this as if declaring it;
37/// if non-null, check this as if making a call to it with the given
38/// receiver type
39///
40/// \return true to indicate that there was an error and appropriate
41/// actions were taken
42bool Sema::checkInitMethod(ObjCMethodDecl *method,
43 QualType receiverTypeIfCall) {
44 if (method->isInvalidDecl()) return true;
45
46 // This castAs is safe: methods that don't return an object
47 // pointer won't be inferred as inits and will reject an explicit
48 // objc_method_family(init).
49
50 // We ignore protocols here. Should we? What about Class?
51
Alp Toker314cc812014-01-25 16:55:45 +000052 const ObjCObjectType *result =
53 method->getReturnType()->castAs<ObjCObjectPointerType>()->getObjectType();
John McCall31168b02011-06-15 23:02:42 +000054
55 if (result->isObjCId()) {
56 return false;
57 } else if (result->isObjCClass()) {
58 // fall through: always an error
59 } else {
60 ObjCInterfaceDecl *resultClass = result->getInterface();
61 assert(resultClass && "unexpected object type!");
62
63 // It's okay for the result type to still be a forward declaration
64 // if we're checking an interface declaration.
Douglas Gregordc9166c2011-12-15 20:29:51 +000065 if (!resultClass->hasDefinition()) {
John McCall31168b02011-06-15 23:02:42 +000066 if (receiverTypeIfCall.isNull() &&
67 !isa<ObjCImplementationDecl>(method->getDeclContext()))
68 return false;
69
70 // Otherwise, we try to compare class types.
71 } else {
72 // If this method was declared in a protocol, we can't check
73 // anything unless we have a receiver type that's an interface.
Craig Topperc3ec1492014-05-26 06:22:03 +000074 const ObjCInterfaceDecl *receiverClass = nullptr;
John McCall31168b02011-06-15 23:02:42 +000075 if (isa<ObjCProtocolDecl>(method->getDeclContext())) {
76 if (receiverTypeIfCall.isNull())
77 return false;
78
79 receiverClass = receiverTypeIfCall->castAs<ObjCObjectPointerType>()
80 ->getInterfaceDecl();
81
82 // This can be null for calls to e.g. id<Foo>.
83 if (!receiverClass) return false;
84 } else {
85 receiverClass = method->getClassInterface();
86 assert(receiverClass && "method not associated with a class!");
87 }
88
89 // If either class is a subclass of the other, it's fine.
90 if (receiverClass->isSuperClassOf(resultClass) ||
91 resultClass->isSuperClassOf(receiverClass))
92 return false;
93 }
94 }
95
96 SourceLocation loc = method->getLocation();
97
98 // If we're in a system header, and this is not a call, just make
99 // the method unusable.
100 if (receiverTypeIfCall.isNull() && getSourceManager().isInSystemHeader(loc)) {
John McCallc6af8c62015-10-28 05:03:19 +0000101 method->addAttr(UnavailableAttr::CreateImplicit(Context, "",
102 UnavailableAttr::IR_ARCInitReturnsUnrelated, loc));
John McCall31168b02011-06-15 23:02:42 +0000103 return true;
104 }
105
106 // Otherwise, it's an error.
107 Diag(loc, diag::err_arc_init_method_unrelated_result_type);
108 method->setInvalidDecl();
109 return true;
110}
111
Fariborz Jahanianac8dbf02011-09-27 22:35:36 +0000112void Sema::CheckObjCMethodOverride(ObjCMethodDecl *NewMethod,
Douglas Gregor66a8ca02013-01-15 22:43:08 +0000113 const ObjCMethodDecl *Overridden) {
Douglas Gregor33823722011-06-11 01:09:30 +0000114 if (Overridden->hasRelatedResultType() &&
115 !NewMethod->hasRelatedResultType()) {
116 // This can only happen when the method follows a naming convention that
117 // implies a related result type, and the original (overridden) method has
118 // a suitable return type, but the new (overriding) method does not have
119 // a suitable return type.
Alp Toker314cc812014-01-25 16:55:45 +0000120 QualType ResultType = NewMethod->getReturnType();
Aaron Ballman41b10ac2014-08-01 13:20:09 +0000121 SourceRange ResultTypeRange = NewMethod->getReturnTypeSourceRange();
Douglas Gregor33823722011-06-11 01:09:30 +0000122
123 // Figure out which class this method is part of, if any.
124 ObjCInterfaceDecl *CurrentClass
125 = dyn_cast<ObjCInterfaceDecl>(NewMethod->getDeclContext());
126 if (!CurrentClass) {
127 DeclContext *DC = NewMethod->getDeclContext();
128 if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(DC))
129 CurrentClass = Cat->getClassInterface();
130 else if (ObjCImplDecl *Impl = dyn_cast<ObjCImplDecl>(DC))
131 CurrentClass = Impl->getClassInterface();
132 else if (ObjCCategoryImplDecl *CatImpl
133 = dyn_cast<ObjCCategoryImplDecl>(DC))
134 CurrentClass = CatImpl->getClassInterface();
135 }
136
137 if (CurrentClass) {
138 Diag(NewMethod->getLocation(),
139 diag::warn_related_result_type_compatibility_class)
140 << Context.getObjCInterfaceType(CurrentClass)
141 << ResultType
142 << ResultTypeRange;
143 } else {
144 Diag(NewMethod->getLocation(),
145 diag::warn_related_result_type_compatibility_protocol)
146 << ResultType
147 << ResultTypeRange;
148 }
149
Douglas Gregorbab8a962011-09-08 01:46:34 +0000150 if (ObjCMethodFamily Family = Overridden->getMethodFamily())
151 Diag(Overridden->getLocation(),
John McCall5ec7e7d2013-03-19 07:04:25 +0000152 diag::note_related_result_type_family)
153 << /*overridden method*/ 0
Douglas Gregorbab8a962011-09-08 01:46:34 +0000154 << Family;
155 else
156 Diag(Overridden->getLocation(),
157 diag::note_related_result_type_overridden);
Douglas Gregor33823722011-06-11 01:09:30 +0000158 }
David Blaikiebbafb8a2012-03-11 07:00:24 +0000159 if (getLangOpts().ObjCAutoRefCount) {
Fariborz Jahanianac8dbf02011-09-27 22:35:36 +0000160 if ((NewMethod->hasAttr<NSReturnsRetainedAttr>() !=
161 Overridden->hasAttr<NSReturnsRetainedAttr>())) {
162 Diag(NewMethod->getLocation(),
163 diag::err_nsreturns_retained_attribute_mismatch) << 1;
164 Diag(Overridden->getLocation(), diag::note_previous_decl)
165 << "method";
166 }
167 if ((NewMethod->hasAttr<NSReturnsNotRetainedAttr>() !=
168 Overridden->hasAttr<NSReturnsNotRetainedAttr>())) {
169 Diag(NewMethod->getLocation(),
170 diag::err_nsreturns_retained_attribute_mismatch) << 0;
171 Diag(Overridden->getLocation(), diag::note_previous_decl)
172 << "method";
173 }
Douglas Gregor0bf70f42012-05-17 23:13:29 +0000174 ObjCMethodDecl::param_const_iterator oi = Overridden->param_begin(),
175 oe = Overridden->param_end();
Argyrios Kyrtzidisb8c3aaf2011-10-03 06:37:04 +0000176 for (ObjCMethodDecl::param_iterator
177 ni = NewMethod->param_begin(), ne = NewMethod->param_end();
Douglas Gregor0bf70f42012-05-17 23:13:29 +0000178 ni != ne && oi != oe; ++ni, ++oi) {
Argyrios Kyrtzidisb8c3aaf2011-10-03 06:37:04 +0000179 const ParmVarDecl *oldDecl = (*oi);
Fariborz Jahanianac8dbf02011-09-27 22:35:36 +0000180 ParmVarDecl *newDecl = (*ni);
181 if (newDecl->hasAttr<NSConsumedAttr>() !=
182 oldDecl->hasAttr<NSConsumedAttr>()) {
183 Diag(newDecl->getLocation(),
184 diag::err_nsconsumed_attribute_mismatch);
185 Diag(oldDecl->getLocation(), diag::note_previous_decl)
186 << "parameter";
187 }
188 }
189 }
Douglas Gregor33823722011-06-11 01:09:30 +0000190}
191
John McCall31168b02011-06-15 23:02:42 +0000192/// \brief Check a method declaration for compatibility with the Objective-C
193/// ARC conventions.
John McCalle48f3892013-04-04 01:38:37 +0000194bool Sema::CheckARCMethodDecl(ObjCMethodDecl *method) {
John McCall31168b02011-06-15 23:02:42 +0000195 ObjCMethodFamily family = method->getMethodFamily();
196 switch (family) {
197 case OMF_None:
Nico Weber1fb82662011-08-28 22:35:17 +0000198 case OMF_finalize:
John McCall31168b02011-06-15 23:02:42 +0000199 case OMF_retain:
200 case OMF_release:
201 case OMF_autorelease:
202 case OMF_retainCount:
203 case OMF_self:
Fariborz Jahanian78e9deb2014-08-22 16:57:26 +0000204 case OMF_initialize:
John McCalld2930c22011-07-22 02:45:48 +0000205 case OMF_performSelector:
John McCall31168b02011-06-15 23:02:42 +0000206 return false;
207
Fariborz Jahanianb7f03c12012-07-30 20:52:48 +0000208 case OMF_dealloc:
Alp Toker314cc812014-01-25 16:55:45 +0000209 if (!Context.hasSameType(method->getReturnType(), Context.VoidTy)) {
Aaron Ballman41b10ac2014-08-01 13:20:09 +0000210 SourceRange ResultTypeRange = method->getReturnTypeSourceRange();
Fariborz Jahanianb7f03c12012-07-30 20:52:48 +0000211 if (ResultTypeRange.isInvalid())
Richard Smithf8812672016-12-02 22:38:31 +0000212 Diag(method->getLocation(), diag::err_dealloc_bad_result_type)
Alp Toker314cc812014-01-25 16:55:45 +0000213 << method->getReturnType()
214 << FixItHint::CreateInsertion(method->getSelectorLoc(0), "(void)");
Fariborz Jahanianb7f03c12012-07-30 20:52:48 +0000215 else
Richard Smithf8812672016-12-02 22:38:31 +0000216 Diag(method->getLocation(), diag::err_dealloc_bad_result_type)
Alp Toker314cc812014-01-25 16:55:45 +0000217 << method->getReturnType()
218 << FixItHint::CreateReplacement(ResultTypeRange, "void");
Fariborz Jahanianb7f03c12012-07-30 20:52:48 +0000219 return true;
220 }
221 return false;
222
John McCall31168b02011-06-15 23:02:42 +0000223 case OMF_init:
224 // If the method doesn't obey the init rules, don't bother annotating it.
John McCalle48f3892013-04-04 01:38:37 +0000225 if (checkInitMethod(method, QualType()))
John McCall31168b02011-06-15 23:02:42 +0000226 return true;
227
Aaron Ballman36a53502014-01-16 13:03:14 +0000228 method->addAttr(NSConsumesSelfAttr::CreateImplicit(Context));
John McCall31168b02011-06-15 23:02:42 +0000229
230 // Don't add a second copy of this attribute, but otherwise don't
231 // let it be suppressed.
232 if (method->hasAttr<NSReturnsRetainedAttr>())
233 return false;
234 break;
235
236 case OMF_alloc:
237 case OMF_copy:
238 case OMF_mutableCopy:
239 case OMF_new:
240 if (method->hasAttr<NSReturnsRetainedAttr>() ||
241 method->hasAttr<NSReturnsNotRetainedAttr>() ||
242 method->hasAttr<NSReturnsAutoreleasedAttr>())
243 return false;
244 break;
245 }
246
Aaron Ballman36a53502014-01-16 13:03:14 +0000247 method->addAttr(NSReturnsRetainedAttr::CreateImplicit(Context));
John McCall31168b02011-06-15 23:02:42 +0000248 return false;
249}
250
Fariborz Jahaniand724a102011-02-15 17:49:58 +0000251static void DiagnoseObjCImplementedDeprecations(Sema &S,
252 NamedDecl *ND,
253 SourceLocation ImplLoc,
254 int select) {
Douglas Gregor20b2ebd2011-03-23 00:50:03 +0000255 if (ND && ND->isDeprecated()) {
Fariborz Jahanian6fd94352011-02-16 00:30:31 +0000256 S.Diag(ImplLoc, diag::warn_deprecated_def) << select;
Fariborz Jahaniand724a102011-02-15 17:49:58 +0000257 if (select == 0)
Ted Kremenek59b10db2012-02-27 22:55:11 +0000258 S.Diag(ND->getLocation(), diag::note_method_declared_at)
259 << ND->getDeclName();
Fariborz Jahaniand724a102011-02-15 17:49:58 +0000260 else
Alex Lorenzf9371392017-03-23 11:44:25 +0000261 S.Diag(ND->getLocation(), diag::note_previous_decl)
262 << (isa<ObjCCategoryDecl>(ND) ? "category" : "class");
Fariborz Jahaniand724a102011-02-15 17:49:58 +0000263 }
264}
265
Fariborz Jahanianbd0642f2011-08-31 17:37:55 +0000266/// AddAnyMethodToGlobalPool - Add any method, instance or factory to global
267/// pool.
268void Sema::AddAnyMethodToGlobalPool(Decl *D) {
269 ObjCMethodDecl *MDecl = dyn_cast_or_null<ObjCMethodDecl>(D);
270
271 // If we don't have a valid method decl, simply return.
272 if (!MDecl)
273 return;
274 if (MDecl->isInstanceMethod())
275 AddInstanceMethodToGlobalPool(MDecl, true);
276 else
277 AddFactoryMethodToGlobalPool(MDecl, true);
278}
279
Fariborz Jahanian1dfeace2012-09-13 18:53:14 +0000280/// HasExplicitOwnershipAttr - returns true when pointer to ObjC pointer
281/// has explicit ownership attribute; false otherwise.
282static bool
283HasExplicitOwnershipAttr(Sema &S, ParmVarDecl *Param) {
284 QualType T = Param->getType();
285
Fariborz Jahanian1dfeace2012-09-13 18:53:14 +0000286 if (const PointerType *PT = T->getAs<PointerType>()) {
287 T = PT->getPointeeType();
288 } else if (const ReferenceType *RT = T->getAs<ReferenceType>()) {
289 T = RT->getPointeeType();
290 } else {
291 return true;
292 }
293
294 // If we have a lifetime qualifier, but it's local, we must have
295 // inferred it. So, it is implicit.
296 return !T.getLocalQualifiers().hasObjCLifetime();
297}
298
Fariborz Jahanian18d0a5d2012-08-08 23:41:08 +0000299/// ActOnStartOfObjCMethodDef - This routine sets up parameters; invisible
300/// and user declared, in the method definition's AST.
301void Sema::ActOnStartOfObjCMethodDef(Scope *FnBodyScope, Decl *D) {
Craig Topperc3ec1492014-05-26 06:22:03 +0000302 assert((getCurMethodDecl() == nullptr) && "Methodparsing confused");
John McCall48871652010-08-21 09:40:31 +0000303 ObjCMethodDecl *MDecl = dyn_cast_or_null<ObjCMethodDecl>(D);
Fariborz Jahanian577574a2012-07-02 23:37:09 +0000304
Steve Naroff542cd5d2008-07-25 17:57:26 +0000305 // If we don't have a valid method decl, simply return.
306 if (!MDecl)
307 return;
Steve Naroff1d2538c2007-12-18 01:30:32 +0000308
Chris Lattnerda463fe2007-12-12 07:09:47 +0000309 // Allow all of Sema to see that we are entering a method definition.
Douglas Gregor91f84212008-12-11 16:49:14 +0000310 PushDeclContext(FnBodyScope, MDecl);
Douglas Gregor9a28e842010-03-01 23:15:13 +0000311 PushFunctionScope();
312
Chris Lattnerda463fe2007-12-12 07:09:47 +0000313 // Create Decl objects for each parameter, entrring them in the scope for
314 // binding to their use.
Chris Lattnerda463fe2007-12-12 07:09:47 +0000315
316 // Insert the invisible arguments, self and _cmd!
Fariborz Jahanian3d8552a2008-12-09 20:23:04 +0000317 MDecl->createImplicitParams(Context, MDecl->getClassInterface());
Mike Stump11289f42009-09-09 15:08:12 +0000318
Daniel Dunbar279d1cc2008-08-26 06:07:48 +0000319 PushOnScopeChains(MDecl->getSelfDecl(), FnBodyScope);
320 PushOnScopeChains(MDecl->getCmdDecl(), FnBodyScope);
Chris Lattneraa9c7ae2008-04-08 04:40:51 +0000321
Reid Kleckner5a115802013-06-24 14:38:26 +0000322 // The ObjC parser requires parameter names so there's no need to check.
David Majnemer59f77922016-06-24 04:05:48 +0000323 CheckParmsForFunctionDef(MDecl->parameters(),
Reid Kleckner5a115802013-06-24 14:38:26 +0000324 /*CheckParameterNames=*/false);
325
Chris Lattner58258242008-04-10 02:22:51 +0000326 // Introduce all of the other parameters into this scope.
David Majnemer59f77922016-06-24 04:05:48 +0000327 for (auto *Param : MDecl->parameters()) {
Fariborz Jahanianb3e87122010-09-17 22:07:07 +0000328 if (!Param->isInvalidDecl() &&
Fariborz Jahanian1dfeace2012-09-13 18:53:14 +0000329 getLangOpts().ObjCAutoRefCount &&
330 !HasExplicitOwnershipAttr(*this, Param))
331 Diag(Param->getLocation(), diag::warn_arc_strong_pointer_objc_pointer) <<
332 Param->getType();
Fariborz Jahaniancd278ff2012-08-30 23:56:02 +0000333
Aaron Ballman43b68be2014-03-07 17:50:17 +0000334 if (Param->getIdentifier())
335 PushOnScopeChains(Param, FnBodyScope);
Fariborz Jahanianb3e87122010-09-17 22:07:07 +0000336 }
John McCall31168b02011-06-15 23:02:42 +0000337
338 // In ARC, disallow definition of retain/release/autorelease/retainCount
David Blaikiebbafb8a2012-03-11 07:00:24 +0000339 if (getLangOpts().ObjCAutoRefCount) {
John McCall31168b02011-06-15 23:02:42 +0000340 switch (MDecl->getMethodFamily()) {
341 case OMF_retain:
342 case OMF_retainCount:
343 case OMF_release:
344 case OMF_autorelease:
345 Diag(MDecl->getLocation(), diag::err_arc_illegal_method_def)
Fariborz Jahanian39d1c422013-05-16 19:08:44 +0000346 << 0 << MDecl->getSelector();
John McCall31168b02011-06-15 23:02:42 +0000347 break;
348
349 case OMF_None:
350 case OMF_dealloc:
Nico Weber1fb82662011-08-28 22:35:17 +0000351 case OMF_finalize:
John McCall31168b02011-06-15 23:02:42 +0000352 case OMF_alloc:
353 case OMF_init:
354 case OMF_mutableCopy:
355 case OMF_copy:
356 case OMF_new:
357 case OMF_self:
Fariborz Jahanian78e9deb2014-08-22 16:57:26 +0000358 case OMF_initialize:
Fariborz Jahanianb7a77362011-07-05 22:38:59 +0000359 case OMF_performSelector:
John McCall31168b02011-06-15 23:02:42 +0000360 break;
361 }
362 }
363
Nico Weber715abaf2011-08-22 17:25:57 +0000364 // Warn on deprecated methods under -Wdeprecated-implementations,
365 // and prepare for warning on missing super calls.
366 if (ObjCInterfaceDecl *IC = MDecl->getClassInterface()) {
Fariborz Jahanian566fff02012-09-07 23:46:23 +0000367 ObjCMethodDecl *IMD =
368 IC->lookupMethod(MDecl->getSelector(), MDecl->isInstanceMethod());
369
Fariborz Jahaniand91d21c2012-11-17 20:53:53 +0000370 if (IMD) {
371 ObjCImplDecl *ImplDeclOfMethodDef =
372 dyn_cast<ObjCImplDecl>(MDecl->getDeclContext());
373 ObjCContainerDecl *ContDeclOfMethodDecl =
374 dyn_cast<ObjCContainerDecl>(IMD->getDeclContext());
Craig Topperc3ec1492014-05-26 06:22:03 +0000375 ObjCImplDecl *ImplDeclOfMethodDecl = nullptr;
Fariborz Jahaniand91d21c2012-11-17 20:53:53 +0000376 if (ObjCInterfaceDecl *OID = dyn_cast<ObjCInterfaceDecl>(ContDeclOfMethodDecl))
377 ImplDeclOfMethodDecl = OID->getImplementation();
Fariborz Jahanianed39e7c2014-03-18 16:25:22 +0000378 else if (ObjCCategoryDecl *CD = dyn_cast<ObjCCategoryDecl>(ContDeclOfMethodDecl)) {
379 if (CD->IsClassExtension()) {
380 if (ObjCInterfaceDecl *OID = CD->getClassInterface())
381 ImplDeclOfMethodDecl = OID->getImplementation();
382 } else
383 ImplDeclOfMethodDecl = CD->getImplementation();
Fariborz Jahanian19a08bb2014-03-18 00:10:37 +0000384 }
Fariborz Jahaniand91d21c2012-11-17 20:53:53 +0000385 // No need to issue deprecated warning if deprecated mehod in class/category
386 // is being implemented in its own implementation (no overriding is involved).
Fariborz Jahanianed39e7c2014-03-18 16:25:22 +0000387 if (!ImplDeclOfMethodDecl || ImplDeclOfMethodDecl != ImplDeclOfMethodDef)
Fariborz Jahaniand91d21c2012-11-17 20:53:53 +0000388 DiagnoseObjCImplementedDeprecations(*this,
Fariborz Jahaniand724a102011-02-15 17:49:58 +0000389 dyn_cast<NamedDecl>(IMD),
390 MDecl->getLocation(), 0);
Fariborz Jahaniand91d21c2012-11-17 20:53:53 +0000391 }
Nico Weber715abaf2011-08-22 17:25:57 +0000392
Argyrios Kyrtzidisb66d3cf2013-12-03 21:11:49 +0000393 if (MDecl->getMethodFamily() == OMF_init) {
394 if (MDecl->isDesignatedInitializerForTheInterface()) {
395 getCurFunction()->ObjCIsDesignatedInit = true;
Fariborz Jahaniane3b5c992014-03-14 23:30:18 +0000396 getCurFunction()->ObjCWarnForNoDesignatedInitChain =
Craig Topperc3ec1492014-05-26 06:22:03 +0000397 IC->getSuperClass() != nullptr;
Argyrios Kyrtzidisb66d3cf2013-12-03 21:11:49 +0000398 } else if (IC->hasDesignatedInitializers()) {
399 getCurFunction()->ObjCIsSecondaryInit = true;
Fariborz Jahaniane3b5c992014-03-14 23:30:18 +0000400 getCurFunction()->ObjCWarnForNoInitDelegation = true;
Argyrios Kyrtzidisb66d3cf2013-12-03 21:11:49 +0000401 }
402 }
Argyrios Kyrtzidis22bfa2c2013-12-03 21:11:36 +0000403
Nico Weber1fb82662011-08-28 22:35:17 +0000404 // If this is "dealloc" or "finalize", set some bit here.
Nico Weber715abaf2011-08-22 17:25:57 +0000405 // Then in ActOnSuperMessage() (SemaExprObjC), set it back to false.
406 // Finally, in ActOnFinishFunctionBody() (SemaDecl), warn if flag is set.
407 // Only do this if the current class actually has a superclass.
Jordan Rosed03d99d2013-03-05 01:27:54 +0000408 if (const ObjCInterfaceDecl *SuperClass = IC->getSuperClass()) {
Jordan Rose2afd6612012-10-19 16:05:26 +0000409 ObjCMethodFamily Family = MDecl->getMethodFamily();
410 if (Family == OMF_dealloc) {
411 if (!(getLangOpts().ObjCAutoRefCount ||
412 getLangOpts().getGC() == LangOptions::GCOnly))
413 getCurFunction()->ObjCShouldCallSuper = true;
414
415 } else if (Family == OMF_finalize) {
416 if (Context.getLangOpts().getGC() != LangOptions::NonGC)
417 getCurFunction()->ObjCShouldCallSuper = true;
418
Fariborz Jahaniance4bbb22013-11-05 00:28:21 +0000419 } else {
Jordan Rose2afd6612012-10-19 16:05:26 +0000420 const ObjCMethodDecl *SuperMethod =
Jordan Rosed03d99d2013-03-05 01:27:54 +0000421 SuperClass->lookupMethod(MDecl->getSelector(),
422 MDecl->isInstanceMethod());
Jordan Rose2afd6612012-10-19 16:05:26 +0000423 getCurFunction()->ObjCShouldCallSuper =
424 (SuperMethod && SuperMethod->hasAttr<ObjCRequiresSuperAttr>());
Fariborz Jahaniand6876b22012-09-10 18:04:25 +0000425 }
Nico Weber1fb82662011-08-28 22:35:17 +0000426 }
Nico Weber715abaf2011-08-22 17:25:57 +0000427 }
Chris Lattnerda463fe2007-12-12 07:09:47 +0000428}
429
Kaelyn Uhraine31b8882012-01-13 01:32:50 +0000430namespace {
431
432// Callback to only accept typo corrections that are Objective-C classes.
433// If an ObjCInterfaceDecl* is given to the constructor, then the validation
434// function will reject corrections to that class.
435class ObjCInterfaceValidatorCCC : public CorrectionCandidateCallback {
436 public:
Craig Topperc3ec1492014-05-26 06:22:03 +0000437 ObjCInterfaceValidatorCCC() : CurrentIDecl(nullptr) {}
Kaelyn Uhraine31b8882012-01-13 01:32:50 +0000438 explicit ObjCInterfaceValidatorCCC(ObjCInterfaceDecl *IDecl)
439 : CurrentIDecl(IDecl) {}
440
Craig Toppere14c0f82014-03-12 04:55:44 +0000441 bool ValidateCandidate(const TypoCorrection &candidate) override {
Kaelyn Uhraine31b8882012-01-13 01:32:50 +0000442 ObjCInterfaceDecl *ID = candidate.getCorrectionDeclAs<ObjCInterfaceDecl>();
443 return ID && !declaresSameEntity(ID, CurrentIDecl);
444 }
445
446 private:
447 ObjCInterfaceDecl *CurrentIDecl;
448};
449
Hans Wennborgdcfba332015-10-06 23:40:43 +0000450} // end anonymous namespace
Kaelyn Uhraine31b8882012-01-13 01:32:50 +0000451
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +0000452static void diagnoseUseOfProtocols(Sema &TheSema,
453 ObjCContainerDecl *CD,
454 ObjCProtocolDecl *const *ProtoRefs,
455 unsigned NumProtoRefs,
456 const SourceLocation *ProtoLocs) {
457 assert(ProtoRefs);
458 // Diagnose availability in the context of the ObjC container.
459 Sema::ContextRAII SavedContext(TheSema, CD);
460 for (unsigned i = 0; i < NumProtoRefs; ++i) {
461 (void)TheSema.DiagnoseUseOfDecl(ProtoRefs[i], ProtoLocs[i]);
462 }
463}
464
Douglas Gregore9d95f12015-07-07 03:57:35 +0000465void Sema::
466ActOnSuperClassOfClassInterface(Scope *S,
467 SourceLocation AtInterfaceLoc,
468 ObjCInterfaceDecl *IDecl,
469 IdentifierInfo *ClassName,
470 SourceLocation ClassLoc,
471 IdentifierInfo *SuperName,
472 SourceLocation SuperLoc,
473 ArrayRef<ParsedType> SuperTypeArgs,
474 SourceRange SuperTypeArgsRange) {
475 // Check if a different kind of symbol declared in this scope.
476 NamedDecl *PrevDecl = LookupSingleName(TUScope, SuperName, SuperLoc,
477 LookupOrdinaryName);
478
479 if (!PrevDecl) {
480 // Try to correct for a typo in the superclass name without correcting
481 // to the class we're defining.
482 if (TypoCorrection Corrected = CorrectTypo(
483 DeclarationNameInfo(SuperName, SuperLoc),
484 LookupOrdinaryName, TUScope,
Hans Wennborgdcfba332015-10-06 23:40:43 +0000485 nullptr, llvm::make_unique<ObjCInterfaceValidatorCCC>(IDecl),
Douglas Gregore9d95f12015-07-07 03:57:35 +0000486 CTK_ErrorRecovery)) {
487 diagnoseTypo(Corrected, PDiag(diag::err_undef_superclass_suggest)
488 << SuperName << ClassName);
489 PrevDecl = Corrected.getCorrectionDeclAs<ObjCInterfaceDecl>();
490 }
491 }
492
493 if (declaresSameEntity(PrevDecl, IDecl)) {
494 Diag(SuperLoc, diag::err_recursive_superclass)
495 << SuperName << ClassName << SourceRange(AtInterfaceLoc, ClassLoc);
496 IDecl->setEndOfDefinitionLoc(ClassLoc);
497 } else {
498 ObjCInterfaceDecl *SuperClassDecl =
499 dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
500 QualType SuperClassType;
501
502 // Diagnose classes that inherit from deprecated classes.
503 if (SuperClassDecl) {
504 (void)DiagnoseUseOfDecl(SuperClassDecl, SuperLoc);
505 SuperClassType = Context.getObjCInterfaceType(SuperClassDecl);
506 }
507
Hans Wennborgdcfba332015-10-06 23:40:43 +0000508 if (PrevDecl && !SuperClassDecl) {
Douglas Gregore9d95f12015-07-07 03:57:35 +0000509 // The previous declaration was not a class decl. Check if we have a
510 // typedef. If we do, get the underlying class type.
511 if (const TypedefNameDecl *TDecl =
512 dyn_cast_or_null<TypedefNameDecl>(PrevDecl)) {
513 QualType T = TDecl->getUnderlyingType();
514 if (T->isObjCObjectType()) {
515 if (NamedDecl *IDecl = T->getAs<ObjCObjectType>()->getInterface()) {
516 SuperClassDecl = dyn_cast<ObjCInterfaceDecl>(IDecl);
517 SuperClassType = Context.getTypeDeclType(TDecl);
518
519 // This handles the following case:
520 // @interface NewI @end
521 // typedef NewI DeprI __attribute__((deprecated("blah")))
522 // @interface SI : DeprI /* warn here */ @end
523 (void)DiagnoseUseOfDecl(const_cast<TypedefNameDecl*>(TDecl), SuperLoc);
524 }
525 }
526 }
527
528 // This handles the following case:
529 //
530 // typedef int SuperClass;
531 // @interface MyClass : SuperClass {} @end
532 //
533 if (!SuperClassDecl) {
534 Diag(SuperLoc, diag::err_redefinition_different_kind) << SuperName;
535 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
536 }
537 }
538
539 if (!dyn_cast_or_null<TypedefNameDecl>(PrevDecl)) {
540 if (!SuperClassDecl)
541 Diag(SuperLoc, diag::err_undef_superclass)
542 << SuperName << ClassName << SourceRange(AtInterfaceLoc, ClassLoc);
543 else if (RequireCompleteType(SuperLoc,
544 SuperClassType,
545 diag::err_forward_superclass,
546 SuperClassDecl->getDeclName(),
547 ClassName,
548 SourceRange(AtInterfaceLoc, ClassLoc))) {
Hans Wennborgdcfba332015-10-06 23:40:43 +0000549 SuperClassDecl = nullptr;
Douglas Gregore9d95f12015-07-07 03:57:35 +0000550 SuperClassType = QualType();
551 }
552 }
553
554 if (SuperClassType.isNull()) {
555 assert(!SuperClassDecl && "Failed to set SuperClassType?");
556 return;
557 }
558
559 // Handle type arguments on the superclass.
560 TypeSourceInfo *SuperClassTInfo = nullptr;
Douglas Gregor9bda6cf2015-07-07 03:58:14 +0000561 if (!SuperTypeArgs.empty()) {
562 TypeResult fullSuperClassType = actOnObjCTypeArgsAndProtocolQualifiers(
563 S,
564 SuperLoc,
565 CreateParsedType(SuperClassType,
566 nullptr),
567 SuperTypeArgsRange.getBegin(),
568 SuperTypeArgs,
569 SuperTypeArgsRange.getEnd(),
570 SourceLocation(),
571 { },
572 { },
573 SourceLocation());
Douglas Gregore9d95f12015-07-07 03:57:35 +0000574 if (!fullSuperClassType.isUsable())
575 return;
576
577 SuperClassType = GetTypeFromParser(fullSuperClassType.get(),
578 &SuperClassTInfo);
579 }
580
581 if (!SuperClassTInfo) {
582 SuperClassTInfo = Context.getTrivialTypeSourceInfo(SuperClassType,
583 SuperLoc);
584 }
585
586 IDecl->setSuperClass(SuperClassTInfo);
587 IDecl->setEndOfDefinitionLoc(SuperClassTInfo->getTypeLoc().getLocEnd());
588 }
589}
590
Douglas Gregor1ac1b632015-07-07 03:58:54 +0000591DeclResult Sema::actOnObjCTypeParam(Scope *S,
592 ObjCTypeParamVariance variance,
593 SourceLocation varianceLoc,
594 unsigned index,
Douglas Gregore83b9562015-07-07 03:57:53 +0000595 IdentifierInfo *paramName,
Douglas Gregor85f3f952015-07-07 03:57:15 +0000596 SourceLocation paramLoc,
597 SourceLocation colonLoc,
598 ParsedType parsedTypeBound) {
599 // If there was an explicitly-provided type bound, check it.
600 TypeSourceInfo *typeBoundInfo = nullptr;
601 if (parsedTypeBound) {
602 // The type bound can be any Objective-C pointer type.
603 QualType typeBound = GetTypeFromParser(parsedTypeBound, &typeBoundInfo);
604 if (typeBound->isObjCObjectPointerType()) {
605 // okay
606 } else if (typeBound->isObjCObjectType()) {
607 // The user forgot the * on an Objective-C pointer type, e.g.,
608 // "T : NSView".
Craig Topper07fa1762015-11-15 02:31:46 +0000609 SourceLocation starLoc = getLocForEndOfToken(
Douglas Gregor85f3f952015-07-07 03:57:15 +0000610 typeBoundInfo->getTypeLoc().getEndLoc());
611 Diag(typeBoundInfo->getTypeLoc().getBeginLoc(),
612 diag::err_objc_type_param_bound_missing_pointer)
613 << typeBound << paramName
614 << FixItHint::CreateInsertion(starLoc, " *");
615
616 // Create a new type location builder so we can update the type
617 // location information we have.
618 TypeLocBuilder builder;
619 builder.pushFullCopy(typeBoundInfo->getTypeLoc());
620
621 // Create the Objective-C pointer type.
622 typeBound = Context.getObjCObjectPointerType(typeBound);
623 ObjCObjectPointerTypeLoc newT
624 = builder.push<ObjCObjectPointerTypeLoc>(typeBound);
625 newT.setStarLoc(starLoc);
626
627 // Form the new type source information.
628 typeBoundInfo = builder.getTypeSourceInfo(Context, typeBound);
629 } else {
Douglas Gregore9d95f12015-07-07 03:57:35 +0000630 // Not a valid type bound.
Douglas Gregor85f3f952015-07-07 03:57:15 +0000631 Diag(typeBoundInfo->getTypeLoc().getBeginLoc(),
632 diag::err_objc_type_param_bound_nonobject)
633 << typeBound << paramName;
634
635 // Forget the bound; we'll default to id later.
636 typeBoundInfo = nullptr;
637 }
Douglas Gregore83b9562015-07-07 03:57:53 +0000638
John McCall69975252015-09-23 22:14:21 +0000639 // Type bounds cannot have qualifiers (even indirectly) or explicit
640 // nullability.
Douglas Gregore83b9562015-07-07 03:57:53 +0000641 if (typeBoundInfo) {
John McCall69975252015-09-23 22:14:21 +0000642 QualType typeBound = typeBoundInfo->getType();
643 TypeLoc qual = typeBoundInfo->getTypeLoc().findExplicitQualifierLoc();
644 if (qual || typeBound.hasQualifiers()) {
645 bool diagnosed = false;
646 SourceRange rangeToRemove;
647 if (qual) {
648 if (auto attr = qual.getAs<AttributedTypeLoc>()) {
649 rangeToRemove = attr.getLocalSourceRange();
650 if (attr.getTypePtr()->getImmediateNullability()) {
651 Diag(attr.getLocStart(),
652 diag::err_objc_type_param_bound_explicit_nullability)
653 << paramName << typeBound
654 << FixItHint::CreateRemoval(rangeToRemove);
655 diagnosed = true;
656 }
657 }
658 }
659
660 if (!diagnosed) {
661 Diag(qual ? qual.getLocStart()
662 : typeBoundInfo->getTypeLoc().getLocStart(),
663 diag::err_objc_type_param_bound_qualified)
664 << paramName << typeBound << typeBound.getQualifiers().getAsString()
665 << FixItHint::CreateRemoval(rangeToRemove);
666 }
667
668 // If the type bound has qualifiers other than CVR, we need to strip
669 // them or we'll probably assert later when trying to apply new
670 // qualifiers.
671 Qualifiers quals = typeBound.getQualifiers();
672 quals.removeCVRQualifiers();
673 if (!quals.empty()) {
674 typeBoundInfo =
675 Context.getTrivialTypeSourceInfo(typeBound.getUnqualifiedType());
676 }
Douglas Gregore83b9562015-07-07 03:57:53 +0000677 }
678 }
Douglas Gregor85f3f952015-07-07 03:57:15 +0000679 }
680
681 // If there was no explicit type bound (or we removed it due to an error),
682 // use 'id' instead.
683 if (!typeBoundInfo) {
684 colonLoc = SourceLocation();
685 typeBoundInfo = Context.getTrivialTypeSourceInfo(Context.getObjCIdType());
686 }
687
688 // Create the type parameter.
Douglas Gregor1ac1b632015-07-07 03:58:54 +0000689 return ObjCTypeParamDecl::Create(Context, CurContext, variance, varianceLoc,
690 index, paramLoc, paramName, colonLoc,
691 typeBoundInfo);
Douglas Gregor85f3f952015-07-07 03:57:15 +0000692}
693
694ObjCTypeParamList *Sema::actOnObjCTypeParamList(Scope *S,
695 SourceLocation lAngleLoc,
696 ArrayRef<Decl *> typeParamsIn,
697 SourceLocation rAngleLoc) {
698 // We know that the array only contains Objective-C type parameters.
699 ArrayRef<ObjCTypeParamDecl *>
700 typeParams(
701 reinterpret_cast<ObjCTypeParamDecl * const *>(typeParamsIn.data()),
702 typeParamsIn.size());
703
704 // Diagnose redeclarations of type parameters.
705 // We do this now because Objective-C type parameters aren't pushed into
706 // scope until later (after the instance variable block), but we want the
707 // diagnostics to occur right after we parse the type parameter list.
708 llvm::SmallDenseMap<IdentifierInfo *, ObjCTypeParamDecl *> knownParams;
709 for (auto typeParam : typeParams) {
710 auto known = knownParams.find(typeParam->getIdentifier());
711 if (known != knownParams.end()) {
712 Diag(typeParam->getLocation(), diag::err_objc_type_param_redecl)
713 << typeParam->getIdentifier()
714 << SourceRange(known->second->getLocation());
715
716 typeParam->setInvalidDecl();
717 } else {
718 knownParams.insert(std::make_pair(typeParam->getIdentifier(), typeParam));
719
720 // Push the type parameter into scope.
721 PushOnScopeChains(typeParam, S, /*AddToContext=*/false);
722 }
723 }
724
725 // Create the parameter list.
726 return ObjCTypeParamList::create(Context, lAngleLoc, typeParams, rAngleLoc);
727}
728
729void Sema::popObjCTypeParamList(Scope *S, ObjCTypeParamList *typeParamList) {
730 for (auto typeParam : *typeParamList) {
731 if (!typeParam->isInvalidDecl()) {
732 S->RemoveDecl(typeParam);
733 IdResolver.RemoveDecl(typeParam);
734 }
735 }
736}
737
738namespace {
739 /// The context in which an Objective-C type parameter list occurs, for use
740 /// in diagnostics.
741 enum class TypeParamListContext {
742 ForwardDeclaration,
743 Definition,
744 Category,
745 Extension
746 };
Hans Wennborgdcfba332015-10-06 23:40:43 +0000747} // end anonymous namespace
Douglas Gregor85f3f952015-07-07 03:57:15 +0000748
749/// Check consistency between two Objective-C type parameter lists, e.g.,
NAKAMURA Takumi4c3ab452015-07-08 02:35:56 +0000750/// between a category/extension and an \@interface or between an \@class and an
751/// \@interface.
Douglas Gregor85f3f952015-07-07 03:57:15 +0000752static bool checkTypeParamListConsistency(Sema &S,
753 ObjCTypeParamList *prevTypeParams,
754 ObjCTypeParamList *newTypeParams,
755 TypeParamListContext newContext) {
756 // If the sizes don't match, complain about that.
757 if (prevTypeParams->size() != newTypeParams->size()) {
758 SourceLocation diagLoc;
759 if (newTypeParams->size() > prevTypeParams->size()) {
760 diagLoc = newTypeParams->begin()[prevTypeParams->size()]->getLocation();
761 } else {
Craig Topper07fa1762015-11-15 02:31:46 +0000762 diagLoc = S.getLocForEndOfToken(newTypeParams->back()->getLocEnd());
Douglas Gregor85f3f952015-07-07 03:57:15 +0000763 }
764
765 S.Diag(diagLoc, diag::err_objc_type_param_arity_mismatch)
766 << static_cast<unsigned>(newContext)
767 << (newTypeParams->size() > prevTypeParams->size())
768 << prevTypeParams->size()
769 << newTypeParams->size();
770
771 return true;
772 }
773
774 // Match up the type parameters.
775 for (unsigned i = 0, n = prevTypeParams->size(); i != n; ++i) {
776 ObjCTypeParamDecl *prevTypeParam = prevTypeParams->begin()[i];
777 ObjCTypeParamDecl *newTypeParam = newTypeParams->begin()[i];
778
Douglas Gregor1ac1b632015-07-07 03:58:54 +0000779 // Check for consistency of the variance.
780 if (newTypeParam->getVariance() != prevTypeParam->getVariance()) {
781 if (newTypeParam->getVariance() == ObjCTypeParamVariance::Invariant &&
782 newContext != TypeParamListContext::Definition) {
783 // When the new type parameter is invariant and is not part
784 // of the definition, just propagate the variance.
785 newTypeParam->setVariance(prevTypeParam->getVariance());
786 } else if (prevTypeParam->getVariance()
787 == ObjCTypeParamVariance::Invariant &&
788 !(isa<ObjCInterfaceDecl>(prevTypeParam->getDeclContext()) &&
789 cast<ObjCInterfaceDecl>(prevTypeParam->getDeclContext())
790 ->getDefinition() == prevTypeParam->getDeclContext())) {
791 // When the old parameter is invariant and was not part of the
792 // definition, just ignore the difference because it doesn't
793 // matter.
794 } else {
795 {
796 // Diagnose the conflict and update the second declaration.
797 SourceLocation diagLoc = newTypeParam->getVarianceLoc();
798 if (diagLoc.isInvalid())
799 diagLoc = newTypeParam->getLocStart();
800
801 auto diag = S.Diag(diagLoc,
802 diag::err_objc_type_param_variance_conflict)
803 << static_cast<unsigned>(newTypeParam->getVariance())
804 << newTypeParam->getDeclName()
805 << static_cast<unsigned>(prevTypeParam->getVariance())
806 << prevTypeParam->getDeclName();
807 switch (prevTypeParam->getVariance()) {
808 case ObjCTypeParamVariance::Invariant:
809 diag << FixItHint::CreateRemoval(newTypeParam->getVarianceLoc());
810 break;
811
812 case ObjCTypeParamVariance::Covariant:
813 case ObjCTypeParamVariance::Contravariant: {
814 StringRef newVarianceStr
815 = prevTypeParam->getVariance() == ObjCTypeParamVariance::Covariant
816 ? "__covariant"
817 : "__contravariant";
818 if (newTypeParam->getVariance()
819 == ObjCTypeParamVariance::Invariant) {
820 diag << FixItHint::CreateInsertion(newTypeParam->getLocStart(),
821 (newVarianceStr + " ").str());
822 } else {
823 diag << FixItHint::CreateReplacement(newTypeParam->getVarianceLoc(),
824 newVarianceStr);
825 }
826 }
827 }
828 }
829
830 S.Diag(prevTypeParam->getLocation(), diag::note_objc_type_param_here)
831 << prevTypeParam->getDeclName();
832
833 // Override the variance.
834 newTypeParam->setVariance(prevTypeParam->getVariance());
835 }
836 }
837
Douglas Gregor85f3f952015-07-07 03:57:15 +0000838 // If the bound types match, there's nothing to do.
839 if (S.Context.hasSameType(prevTypeParam->getUnderlyingType(),
840 newTypeParam->getUnderlyingType()))
841 continue;
842
843 // If the new type parameter's bound was explicit, complain about it being
844 // different from the original.
845 if (newTypeParam->hasExplicitBound()) {
846 SourceRange newBoundRange = newTypeParam->getTypeSourceInfo()
847 ->getTypeLoc().getSourceRange();
848 S.Diag(newBoundRange.getBegin(), diag::err_objc_type_param_bound_conflict)
849 << newTypeParam->getUnderlyingType()
850 << newTypeParam->getDeclName()
851 << prevTypeParam->hasExplicitBound()
852 << prevTypeParam->getUnderlyingType()
853 << (newTypeParam->getDeclName() == prevTypeParam->getDeclName())
854 << prevTypeParam->getDeclName()
855 << FixItHint::CreateReplacement(
856 newBoundRange,
857 prevTypeParam->getUnderlyingType().getAsString(
858 S.Context.getPrintingPolicy()));
859
860 S.Diag(prevTypeParam->getLocation(), diag::note_objc_type_param_here)
861 << prevTypeParam->getDeclName();
862
863 // Override the new type parameter's bound type with the previous type,
864 // so that it's consistent.
865 newTypeParam->setTypeSourceInfo(
866 S.Context.getTrivialTypeSourceInfo(prevTypeParam->getUnderlyingType()));
867 continue;
868 }
869
870 // The new type parameter got the implicit bound of 'id'. That's okay for
871 // categories and extensions (overwrite it later), but not for forward
872 // declarations and @interfaces, because those must be standalone.
873 if (newContext == TypeParamListContext::ForwardDeclaration ||
874 newContext == TypeParamListContext::Definition) {
875 // Diagnose this problem for forward declarations and definitions.
876 SourceLocation insertionLoc
Craig Topper07fa1762015-11-15 02:31:46 +0000877 = S.getLocForEndOfToken(newTypeParam->getLocation());
Douglas Gregor85f3f952015-07-07 03:57:15 +0000878 std::string newCode
879 = " : " + prevTypeParam->getUnderlyingType().getAsString(
880 S.Context.getPrintingPolicy());
881 S.Diag(newTypeParam->getLocation(),
882 diag::err_objc_type_param_bound_missing)
883 << prevTypeParam->getUnderlyingType()
884 << newTypeParam->getDeclName()
885 << (newContext == TypeParamListContext::ForwardDeclaration)
886 << FixItHint::CreateInsertion(insertionLoc, newCode);
887
888 S.Diag(prevTypeParam->getLocation(), diag::note_objc_type_param_here)
889 << prevTypeParam->getDeclName();
890 }
891
892 // Update the new type parameter's bound to match the previous one.
893 newTypeParam->setTypeSourceInfo(
894 S.Context.getTrivialTypeSourceInfo(prevTypeParam->getUnderlyingType()));
895 }
896
897 return false;
898}
899
John McCall48871652010-08-21 09:40:31 +0000900Decl *Sema::
Douglas Gregore9d95f12015-07-07 03:57:35 +0000901ActOnStartClassInterface(Scope *S, SourceLocation AtInterfaceLoc,
Chris Lattnerd7352d62008-07-21 22:17:28 +0000902 IdentifierInfo *ClassName, SourceLocation ClassLoc,
Douglas Gregor85f3f952015-07-07 03:57:15 +0000903 ObjCTypeParamList *typeParamList,
Chris Lattnerd7352d62008-07-21 22:17:28 +0000904 IdentifierInfo *SuperName, SourceLocation SuperLoc,
Douglas Gregore9d95f12015-07-07 03:57:35 +0000905 ArrayRef<ParsedType> SuperTypeArgs,
906 SourceRange SuperTypeArgsRange,
John McCall48871652010-08-21 09:40:31 +0000907 Decl * const *ProtoRefs, unsigned NumProtoRefs,
Douglas Gregor002b6712010-01-16 15:02:53 +0000908 const SourceLocation *ProtoLocs,
Chris Lattnerd7352d62008-07-21 22:17:28 +0000909 SourceLocation EndProtoLoc, AttributeList *AttrList) {
Chris Lattnerda463fe2007-12-12 07:09:47 +0000910 assert(ClassName && "Missing class identifier");
Mike Stump11289f42009-09-09 15:08:12 +0000911
Chris Lattnerda463fe2007-12-12 07:09:47 +0000912 // Check for another declaration kind with the same name.
Douglas Gregorb2ccf012010-04-15 22:33:43 +0000913 NamedDecl *PrevDecl = LookupSingleName(TUScope, ClassName, ClassLoc,
Douglas Gregorb8eaf292010-04-15 23:40:53 +0000914 LookupOrdinaryName, ForRedeclaration);
Douglas Gregor5101c242008-12-05 18:15:24 +0000915
Ted Kremenek1b0ea822008-01-07 19:49:32 +0000916 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
Chris Lattner4bd8dd82008-11-19 08:23:25 +0000917 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName;
Chris Lattner0369c572008-11-23 23:12:31 +0000918 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
Chris Lattnerda463fe2007-12-12 07:09:47 +0000919 }
Mike Stump11289f42009-09-09 15:08:12 +0000920
Douglas Gregordc9166c2011-12-15 20:29:51 +0000921 // Create a declaration to describe this @interface.
Douglas Gregorab1ec82e2011-12-16 03:12:41 +0000922 ObjCInterfaceDecl* PrevIDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
Argyrios Kyrtzidisdd710632013-06-18 21:26:33 +0000923
924 if (PrevIDecl && PrevIDecl->getIdentifier() != ClassName) {
925 // A previous decl with a different name is because of
926 // @compatibility_alias, for example:
927 // \code
928 // @class NewImage;
929 // @compatibility_alias OldImage NewImage;
930 // \endcode
931 // A lookup for 'OldImage' will return the 'NewImage' decl.
932 //
933 // In such a case use the real declaration name, instead of the alias one,
934 // otherwise we will break IdentifierResolver and redecls-chain invariants.
935 // FIXME: If necessary, add a bit to indicate that this ObjCInterfaceDecl
936 // has been aliased.
937 ClassName = PrevIDecl->getIdentifier();
938 }
939
Douglas Gregor85f3f952015-07-07 03:57:15 +0000940 // If there was a forward declaration with type parameters, check
941 // for consistency.
942 if (PrevIDecl) {
943 if (ObjCTypeParamList *prevTypeParamList = PrevIDecl->getTypeParamList()) {
944 if (typeParamList) {
945 // Both have type parameter lists; check for consistency.
946 if (checkTypeParamListConsistency(*this, prevTypeParamList,
947 typeParamList,
948 TypeParamListContext::Definition)) {
949 typeParamList = nullptr;
950 }
951 } else {
952 Diag(ClassLoc, diag::err_objc_parameterized_forward_class_first)
953 << ClassName;
954 Diag(prevTypeParamList->getLAngleLoc(), diag::note_previous_decl)
955 << ClassName;
956
957 // Clone the type parameter list.
958 SmallVector<ObjCTypeParamDecl *, 4> clonedTypeParams;
959 for (auto typeParam : *prevTypeParamList) {
960 clonedTypeParams.push_back(
961 ObjCTypeParamDecl::Create(
962 Context,
963 CurContext,
Douglas Gregor1ac1b632015-07-07 03:58:54 +0000964 typeParam->getVariance(),
965 SourceLocation(),
Douglas Gregore83b9562015-07-07 03:57:53 +0000966 typeParam->getIndex(),
Douglas Gregor85f3f952015-07-07 03:57:15 +0000967 SourceLocation(),
968 typeParam->getIdentifier(),
969 SourceLocation(),
970 Context.getTrivialTypeSourceInfo(typeParam->getUnderlyingType())));
971 }
972
973 typeParamList = ObjCTypeParamList::create(Context,
974 SourceLocation(),
975 clonedTypeParams,
976 SourceLocation());
977 }
978 }
979 }
980
Douglas Gregordc9166c2011-12-15 20:29:51 +0000981 ObjCInterfaceDecl *IDecl
982 = ObjCInterfaceDecl::Create(Context, CurContext, AtInterfaceLoc, ClassName,
Douglas Gregor85f3f952015-07-07 03:57:15 +0000983 typeParamList, PrevIDecl, ClassLoc);
Douglas Gregordc9166c2011-12-15 20:29:51 +0000984 if (PrevIDecl) {
985 // Class already seen. Was it a definition?
986 if (ObjCInterfaceDecl *Def = PrevIDecl->getDefinition()) {
987 Diag(AtInterfaceLoc, diag::err_duplicate_class_def)
988 << PrevIDecl->getDeclName();
Douglas Gregorc0ac7d62011-12-15 05:27:12 +0000989 Diag(Def->getLocation(), diag::note_previous_definition);
Douglas Gregordc9166c2011-12-15 20:29:51 +0000990 IDecl->setInvalidDecl();
Chris Lattnerda463fe2007-12-12 07:09:47 +0000991 }
Chris Lattnerda463fe2007-12-12 07:09:47 +0000992 }
Douglas Gregordc9166c2011-12-15 20:29:51 +0000993
994 if (AttrList)
995 ProcessDeclAttributeList(TUScope, IDecl, AttrList);
Alex Lorenz9e7bf162017-04-18 14:33:39 +0000996 AddPragmaAttributes(TUScope, IDecl);
Douglas Gregordc9166c2011-12-15 20:29:51 +0000997 PushOnScopeChains(IDecl, TUScope);
Mike Stump11289f42009-09-09 15:08:12 +0000998
Douglas Gregordc9166c2011-12-15 20:29:51 +0000999 // Start the definition of this class. If we're in a redefinition case, there
1000 // may already be a definition, so we'll end up adding to it.
Douglas Gregorc0ac7d62011-12-15 05:27:12 +00001001 if (!IDecl->hasDefinition())
1002 IDecl->startDefinition();
1003
Chris Lattnerda463fe2007-12-12 07:09:47 +00001004 if (SuperName) {
Douglas Gregore9d95f12015-07-07 03:57:35 +00001005 // Diagnose availability in the context of the @interface.
1006 ContextRAII SavedContext(*this, IDecl);
Douglas Gregor35b0bac2010-01-03 18:01:57 +00001007
Douglas Gregore9d95f12015-07-07 03:57:35 +00001008 ActOnSuperClassOfClassInterface(S, AtInterfaceLoc, IDecl,
1009 ClassName, ClassLoc,
1010 SuperName, SuperLoc, SuperTypeArgs,
1011 SuperTypeArgsRange);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001012 } else { // we have a root class.
Douglas Gregor16408322011-12-15 22:34:59 +00001013 IDecl->setEndOfDefinitionLoc(ClassLoc);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001014 }
Mike Stump11289f42009-09-09 15:08:12 +00001015
Sebastian Redle7c1fe62010-08-13 00:28:03 +00001016 // Check then save referenced protocols.
Chris Lattnerdf59f5a2008-07-26 04:13:19 +00001017 if (NumProtoRefs) {
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +00001018 diagnoseUseOfProtocols(*this, IDecl, (ObjCProtocolDecl*const*)ProtoRefs,
1019 NumProtoRefs, ProtoLocs);
Roman Divackye6377112012-09-06 15:59:27 +00001020 IDecl->setProtocolList((ObjCProtocolDecl*const*)ProtoRefs, NumProtoRefs,
Douglas Gregor002b6712010-01-16 15:02:53 +00001021 ProtoLocs, Context);
Douglas Gregor16408322011-12-15 22:34:59 +00001022 IDecl->setEndOfDefinitionLoc(EndProtoLoc);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001023 }
Mike Stump11289f42009-09-09 15:08:12 +00001024
Anders Carlssona6b508a2008-11-04 16:57:32 +00001025 CheckObjCDeclScope(IDecl);
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +00001026 return ActOnObjCContainerStartDefinition(IDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001027}
1028
Fariborz Jahanianb7c5f742013-09-25 19:36:32 +00001029/// ActOnTypedefedProtocols - this action finds protocol list as part of the
1030/// typedef'ed use for a qualified super class and adds them to the list
1031/// of the protocols.
1032void Sema::ActOnTypedefedProtocols(SmallVectorImpl<Decl *> &ProtocolRefs,
Argyrios Kyrtzidisf95a0002016-11-09 02:47:07 +00001033 SmallVectorImpl<SourceLocation> &ProtocolLocs,
Fariborz Jahanianb7c5f742013-09-25 19:36:32 +00001034 IdentifierInfo *SuperName,
1035 SourceLocation SuperLoc) {
1036 if (!SuperName)
1037 return;
1038 NamedDecl* IDecl = LookupSingleName(TUScope, SuperName, SuperLoc,
1039 LookupOrdinaryName);
1040 if (!IDecl)
1041 return;
1042
1043 if (const TypedefNameDecl *TDecl = dyn_cast_or_null<TypedefNameDecl>(IDecl)) {
1044 QualType T = TDecl->getUnderlyingType();
1045 if (T->isObjCObjectType())
Argyrios Kyrtzidisf95a0002016-11-09 02:47:07 +00001046 if (const ObjCObjectType *OPT = T->getAs<ObjCObjectType>()) {
Benjamin Kramerf9890422015-02-17 16:48:30 +00001047 ProtocolRefs.append(OPT->qual_begin(), OPT->qual_end());
Argyrios Kyrtzidisf95a0002016-11-09 02:47:07 +00001048 // FIXME: Consider whether this should be an invalid loc since the loc
1049 // is not actually pointing to a protocol name reference but to the
1050 // typedef reference. Note that the base class name loc is also pointing
1051 // at the typedef.
1052 ProtocolLocs.append(OPT->getNumProtocols(), SuperLoc);
1053 }
Fariborz Jahanianb7c5f742013-09-25 19:36:32 +00001054 }
1055}
1056
Richard Smithac4e36d2012-08-08 23:32:13 +00001057/// ActOnCompatibilityAlias - this action is called after complete parsing of
James Dennett634962f2012-06-14 21:40:34 +00001058/// a \@compatibility_alias declaration. It sets up the alias relationships.
Richard Smithac4e36d2012-08-08 23:32:13 +00001059Decl *Sema::ActOnCompatibilityAlias(SourceLocation AtLoc,
1060 IdentifierInfo *AliasName,
1061 SourceLocation AliasLocation,
1062 IdentifierInfo *ClassName,
1063 SourceLocation ClassLocation) {
Chris Lattnerda463fe2007-12-12 07:09:47 +00001064 // Look for previous declaration of alias name
Douglas Gregorb2ccf012010-04-15 22:33:43 +00001065 NamedDecl *ADecl = LookupSingleName(TUScope, AliasName, AliasLocation,
Douglas Gregorb8eaf292010-04-15 23:40:53 +00001066 LookupOrdinaryName, ForRedeclaration);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001067 if (ADecl) {
Eli Friedmanfd6b3f82013-06-21 01:49:53 +00001068 Diag(AliasLocation, diag::err_conflicting_aliasing_type) << AliasName;
Chris Lattnerd0685032008-11-23 23:20:13 +00001069 Diag(ADecl->getLocation(), diag::note_previous_declaration);
Craig Topperc3ec1492014-05-26 06:22:03 +00001070 return nullptr;
Chris Lattnerda463fe2007-12-12 07:09:47 +00001071 }
1072 // Check for class declaration
Douglas Gregorb2ccf012010-04-15 22:33:43 +00001073 NamedDecl *CDeclU = LookupSingleName(TUScope, ClassName, ClassLocation,
Douglas Gregorb8eaf292010-04-15 23:40:53 +00001074 LookupOrdinaryName, ForRedeclaration);
Richard Smithdda56e42011-04-15 14:24:37 +00001075 if (const TypedefNameDecl *TDecl =
1076 dyn_cast_or_null<TypedefNameDecl>(CDeclU)) {
Fariborz Jahanian17290c32009-01-08 01:10:55 +00001077 QualType T = TDecl->getUnderlyingType();
John McCall8b07ec22010-05-15 11:32:37 +00001078 if (T->isObjCObjectType()) {
1079 if (NamedDecl *IDecl = T->getAs<ObjCObjectType>()->getInterface()) {
Fariborz Jahanian17290c32009-01-08 01:10:55 +00001080 ClassName = IDecl->getIdentifier();
Douglas Gregorb2ccf012010-04-15 22:33:43 +00001081 CDeclU = LookupSingleName(TUScope, ClassName, ClassLocation,
Douglas Gregorb8eaf292010-04-15 23:40:53 +00001082 LookupOrdinaryName, ForRedeclaration);
Fariborz Jahanian17290c32009-01-08 01:10:55 +00001083 }
1084 }
1085 }
Chris Lattner219b3e92008-03-16 21:17:37 +00001086 ObjCInterfaceDecl *CDecl = dyn_cast_or_null<ObjCInterfaceDecl>(CDeclU);
Craig Topperc3ec1492014-05-26 06:22:03 +00001087 if (!CDecl) {
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001088 Diag(ClassLocation, diag::warn_undef_interface) << ClassName;
Chris Lattner219b3e92008-03-16 21:17:37 +00001089 if (CDeclU)
Chris Lattnerd0685032008-11-23 23:20:13 +00001090 Diag(CDeclU->getLocation(), diag::note_previous_declaration);
Craig Topperc3ec1492014-05-26 06:22:03 +00001091 return nullptr;
Chris Lattnerda463fe2007-12-12 07:09:47 +00001092 }
Mike Stump11289f42009-09-09 15:08:12 +00001093
Chris Lattner219b3e92008-03-16 21:17:37 +00001094 // Everything checked out, instantiate a new alias declaration AST.
Mike Stump11289f42009-09-09 15:08:12 +00001095 ObjCCompatibleAliasDecl *AliasDecl =
Douglas Gregorc25d7a72009-01-09 00:49:46 +00001096 ObjCCompatibleAliasDecl::Create(Context, CurContext, AtLoc, AliasName, CDecl);
Mike Stump11289f42009-09-09 15:08:12 +00001097
Anders Carlssona6b508a2008-11-04 16:57:32 +00001098 if (!CheckObjCDeclScope(AliasDecl))
Douglas Gregor38feed82009-04-24 02:57:34 +00001099 PushOnScopeChains(AliasDecl, TUScope);
Douglas Gregorc25d7a72009-01-09 00:49:46 +00001100
John McCall48871652010-08-21 09:40:31 +00001101 return AliasDecl;
Chris Lattnerda463fe2007-12-12 07:09:47 +00001102}
1103
Fariborz Jahanian7d622732011-05-13 18:02:08 +00001104bool Sema::CheckForwardProtocolDeclarationForCircularDependency(
Steve Naroff41d09ad2009-03-05 15:22:01 +00001105 IdentifierInfo *PName,
1106 SourceLocation &Ploc, SourceLocation PrevLoc,
Fariborz Jahanian7d622732011-05-13 18:02:08 +00001107 const ObjCList<ObjCProtocolDecl> &PList) {
1108
1109 bool res = false;
Steve Naroff41d09ad2009-03-05 15:22:01 +00001110 for (ObjCList<ObjCProtocolDecl>::iterator I = PList.begin(),
1111 E = PList.end(); I != E; ++I) {
Douglas Gregorb2ccf012010-04-15 22:33:43 +00001112 if (ObjCProtocolDecl *PDecl = LookupProtocol((*I)->getIdentifier(),
1113 Ploc)) {
Steve Naroff41d09ad2009-03-05 15:22:01 +00001114 if (PDecl->getIdentifier() == PName) {
1115 Diag(Ploc, diag::err_protocol_has_circular_dependency);
1116 Diag(PrevLoc, diag::note_previous_definition);
Fariborz Jahanian7d622732011-05-13 18:02:08 +00001117 res = true;
Steve Naroff41d09ad2009-03-05 15:22:01 +00001118 }
Douglas Gregore6e48b12012-01-01 19:29:29 +00001119
1120 if (!PDecl->hasDefinition())
1121 continue;
1122
Fariborz Jahanian7d622732011-05-13 18:02:08 +00001123 if (CheckForwardProtocolDeclarationForCircularDependency(PName, Ploc,
1124 PDecl->getLocation(), PDecl->getReferencedProtocols()))
1125 res = true;
Steve Naroff41d09ad2009-03-05 15:22:01 +00001126 }
1127 }
Fariborz Jahanian7d622732011-05-13 18:02:08 +00001128 return res;
Steve Naroff41d09ad2009-03-05 15:22:01 +00001129}
1130
John McCall48871652010-08-21 09:40:31 +00001131Decl *
Chris Lattner3bbae002008-07-26 04:03:38 +00001132Sema::ActOnStartProtocolInterface(SourceLocation AtProtoInterfaceLoc,
1133 IdentifierInfo *ProtocolName,
1134 SourceLocation ProtocolLoc,
John McCall48871652010-08-21 09:40:31 +00001135 Decl * const *ProtoRefs,
Chris Lattner3bbae002008-07-26 04:03:38 +00001136 unsigned NumProtoRefs,
Douglas Gregor002b6712010-01-16 15:02:53 +00001137 const SourceLocation *ProtoLocs,
Daniel Dunbar26e2ab42008-09-26 04:48:09 +00001138 SourceLocation EndProtoLoc,
1139 AttributeList *AttrList) {
Fariborz Jahaniancadf7c52011-05-12 22:04:39 +00001140 bool err = false;
Daniel Dunbar26e2ab42008-09-26 04:48:09 +00001141 // FIXME: Deal with AttrList.
Chris Lattnerda463fe2007-12-12 07:09:47 +00001142 assert(ProtocolName && "Missing protocol identifier");
Douglas Gregor32c17572012-01-01 20:30:41 +00001143 ObjCProtocolDecl *PrevDecl = LookupProtocol(ProtocolName, ProtocolLoc,
1144 ForRedeclaration);
Craig Topperc3ec1492014-05-26 06:22:03 +00001145 ObjCProtocolDecl *PDecl = nullptr;
1146 if (ObjCProtocolDecl *Def = PrevDecl? PrevDecl->getDefinition() : nullptr) {
Douglas Gregor32c17572012-01-01 20:30:41 +00001147 // If we already have a definition, complain.
1148 Diag(ProtocolLoc, diag::warn_duplicate_protocol_def) << ProtocolName;
1149 Diag(Def->getLocation(), diag::note_previous_definition);
Mike Stump11289f42009-09-09 15:08:12 +00001150
Douglas Gregor32c17572012-01-01 20:30:41 +00001151 // Create a new protocol that is completely distinct from previous
1152 // declarations, and do not make this protocol available for name lookup.
1153 // That way, we'll end up completely ignoring the duplicate.
1154 // FIXME: Can we turn this into an error?
1155 PDecl = ObjCProtocolDecl::Create(Context, CurContext, ProtocolName,
1156 ProtocolLoc, AtProtoInterfaceLoc,
Craig Topperc3ec1492014-05-26 06:22:03 +00001157 /*PrevDecl=*/nullptr);
Douglas Gregor32c17572012-01-01 20:30:41 +00001158 PDecl->startDefinition();
1159 } else {
1160 if (PrevDecl) {
1161 // Check for circular dependencies among protocol declarations. This can
1162 // only happen if this protocol was forward-declared.
Argyrios Kyrtzidis95dfc122011-11-13 22:08:30 +00001163 ObjCList<ObjCProtocolDecl> PList;
1164 PList.set((ObjCProtocolDecl *const*)ProtoRefs, NumProtoRefs, Context);
1165 err = CheckForwardProtocolDeclarationForCircularDependency(
Douglas Gregor32c17572012-01-01 20:30:41 +00001166 ProtocolName, ProtocolLoc, PrevDecl->getLocation(), PList);
Argyrios Kyrtzidis95dfc122011-11-13 22:08:30 +00001167 }
Douglas Gregor32c17572012-01-01 20:30:41 +00001168
1169 // Create the new declaration.
Argyrios Kyrtzidis52f53fb2011-10-04 04:48:02 +00001170 PDecl = ObjCProtocolDecl::Create(Context, CurContext, ProtocolName,
Argyrios Kyrtzidis1f4bee52011-10-17 19:48:06 +00001171 ProtocolLoc, AtProtoInterfaceLoc,
Douglas Gregor05a1f4d2012-01-01 22:06:18 +00001172 /*PrevDecl=*/PrevDecl);
Douglas Gregor32c17572012-01-01 20:30:41 +00001173
Douglas Gregorde9f17e2009-04-23 23:18:26 +00001174 PushOnScopeChains(PDecl, TUScope);
Douglas Gregore6e48b12012-01-01 19:29:29 +00001175 PDecl->startDefinition();
Chris Lattnerf87ca0a2008-03-16 01:23:04 +00001176 }
Douglas Gregore6e48b12012-01-01 19:29:29 +00001177
Fariborz Jahanian1470e932008-12-17 01:07:27 +00001178 if (AttrList)
Douglas Gregor758a8692009-06-17 21:51:59 +00001179 ProcessDeclAttributeList(TUScope, PDecl, AttrList);
Alex Lorenz9e7bf162017-04-18 14:33:39 +00001180 AddPragmaAttributes(TUScope, PDecl);
1181
Douglas Gregor32c17572012-01-01 20:30:41 +00001182 // Merge attributes from previous declarations.
1183 if (PrevDecl)
1184 mergeDeclAttributes(PDecl, PrevDecl);
1185
Fariborz Jahaniancadf7c52011-05-12 22:04:39 +00001186 if (!err && NumProtoRefs ) {
Chris Lattneracc04a92008-03-16 20:19:15 +00001187 /// Check then save referenced protocols.
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +00001188 diagnoseUseOfProtocols(*this, PDecl, (ObjCProtocolDecl*const*)ProtoRefs,
1189 NumProtoRefs, ProtoLocs);
Roman Divackye6377112012-09-06 15:59:27 +00001190 PDecl->setProtocolList((ObjCProtocolDecl*const*)ProtoRefs, NumProtoRefs,
Douglas Gregor002b6712010-01-16 15:02:53 +00001191 ProtoLocs, Context);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001192 }
Mike Stump11289f42009-09-09 15:08:12 +00001193
1194 CheckObjCDeclScope(PDecl);
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +00001195 return ActOnObjCContainerStartDefinition(PDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001196}
1197
Fariborz Jahanianbf678e82014-03-11 17:10:51 +00001198static bool NestedProtocolHasNoDefinition(ObjCProtocolDecl *PDecl,
1199 ObjCProtocolDecl *&UndefinedProtocol) {
1200 if (!PDecl->hasDefinition() || PDecl->getDefinition()->isHidden()) {
1201 UndefinedProtocol = PDecl;
1202 return true;
1203 }
1204
Aaron Ballman0f6e64d2014-03-13 22:58:06 +00001205 for (auto *PI : PDecl->protocols())
1206 if (NestedProtocolHasNoDefinition(PI, UndefinedProtocol)) {
1207 UndefinedProtocol = PI;
Fariborz Jahanianbf678e82014-03-11 17:10:51 +00001208 return true;
1209 }
1210 return false;
1211}
1212
Chris Lattnerda463fe2007-12-12 07:09:47 +00001213/// FindProtocolDeclaration - This routine looks up protocols and
Daniel Dunbarc7dfbfd2008-09-04 20:01:15 +00001214/// issues an error if they are not declared. It returns list of
1215/// protocol declarations in its 'Protocols' argument.
Chris Lattnerda463fe2007-12-12 07:09:47 +00001216void
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +00001217Sema::FindProtocolDeclaration(bool WarnOnDeclarations, bool ForObjCContainer,
Craig Toppera9247eb2015-10-22 04:59:56 +00001218 ArrayRef<IdentifierLocPair> ProtocolId,
Chris Lattner0e62c1c2011-07-23 10:55:15 +00001219 SmallVectorImpl<Decl *> &Protocols) {
Craig Toppera9247eb2015-10-22 04:59:56 +00001220 for (const IdentifierLocPair &Pair : ProtocolId) {
1221 ObjCProtocolDecl *PDecl = LookupProtocol(Pair.first, Pair.second);
Chris Lattner9c1842b2008-07-26 03:47:43 +00001222 if (!PDecl) {
Douglas Gregorc2fa1692011-06-28 16:20:02 +00001223 TypoCorrection Corrected = CorrectTypo(
Craig Toppera9247eb2015-10-22 04:59:56 +00001224 DeclarationNameInfo(Pair.first, Pair.second),
Kaelyn Takata89c881b2014-10-27 18:07:29 +00001225 LookupObjCProtocolName, TUScope, nullptr,
1226 llvm::make_unique<DeclFilterCCC<ObjCProtocolDecl>>(),
Craig Topperc3ec1492014-05-26 06:22:03 +00001227 CTK_ErrorRecovery);
Richard Smithf9b15102013-08-17 00:46:16 +00001228 if ((PDecl = Corrected.getCorrectionDeclAs<ObjCProtocolDecl>()))
1229 diagnoseTypo(Corrected, PDiag(diag::err_undeclared_protocol_suggest)
Craig Toppera9247eb2015-10-22 04:59:56 +00001230 << Pair.first);
Douglas Gregor35b0bac2010-01-03 18:01:57 +00001231 }
1232
1233 if (!PDecl) {
Craig Toppera9247eb2015-10-22 04:59:56 +00001234 Diag(Pair.second, diag::err_undeclared_protocol) << Pair.first;
Chris Lattner9c1842b2008-07-26 03:47:43 +00001235 continue;
1236 }
Fariborz Jahanianada44a22013-04-09 17:52:29 +00001237 // If this is a forward protocol declaration, get its definition.
1238 if (!PDecl->isThisDeclarationADefinition() && PDecl->getDefinition())
1239 PDecl = PDecl->getDefinition();
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +00001240
1241 // For an objc container, delay protocol reference checking until after we
1242 // can set the objc decl as the availability context, otherwise check now.
1243 if (!ForObjCContainer) {
Craig Toppera9247eb2015-10-22 04:59:56 +00001244 (void)DiagnoseUseOfDecl(PDecl, Pair.second);
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +00001245 }
Chris Lattner9c1842b2008-07-26 03:47:43 +00001246
1247 // If this is a forward declaration and we are supposed to warn in this
1248 // case, do it.
Douglas Gregoreed49792013-01-17 00:38:46 +00001249 // FIXME: Recover nicely in the hidden case.
Fariborz Jahanianbf678e82014-03-11 17:10:51 +00001250 ObjCProtocolDecl *UndefinedProtocol;
1251
Douglas Gregoreed49792013-01-17 00:38:46 +00001252 if (WarnOnDeclarations &&
Fariborz Jahanianbf678e82014-03-11 17:10:51 +00001253 NestedProtocolHasNoDefinition(PDecl, UndefinedProtocol)) {
Craig Toppera9247eb2015-10-22 04:59:56 +00001254 Diag(Pair.second, diag::warn_undef_protocolref) << Pair.first;
Fariborz Jahanianbf678e82014-03-11 17:10:51 +00001255 Diag(UndefinedProtocol->getLocation(), diag::note_protocol_decl_undefined)
1256 << UndefinedProtocol;
1257 }
John McCall48871652010-08-21 09:40:31 +00001258 Protocols.push_back(PDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001259 }
1260}
1261
Benjamin Kramer8b851d02015-07-13 20:42:13 +00001262namespace {
Douglas Gregore9d95f12015-07-07 03:57:35 +00001263// Callback to only accept typo corrections that are either
1264// Objective-C protocols or valid Objective-C type arguments.
1265class ObjCTypeArgOrProtocolValidatorCCC : public CorrectionCandidateCallback {
1266 ASTContext &Context;
1267 Sema::LookupNameKind LookupKind;
1268 public:
1269 ObjCTypeArgOrProtocolValidatorCCC(ASTContext &context,
1270 Sema::LookupNameKind lookupKind)
1271 : Context(context), LookupKind(lookupKind) { }
1272
1273 bool ValidateCandidate(const TypoCorrection &candidate) override {
1274 // If we're allowed to find protocols and we have a protocol, accept it.
1275 if (LookupKind != Sema::LookupOrdinaryName) {
1276 if (candidate.getCorrectionDeclAs<ObjCProtocolDecl>())
1277 return true;
1278 }
1279
1280 // If we're allowed to find type names and we have one, accept it.
1281 if (LookupKind != Sema::LookupObjCProtocolName) {
1282 // If we have a type declaration, we might accept this result.
1283 if (auto typeDecl = candidate.getCorrectionDeclAs<TypeDecl>()) {
1284 // If we found a tag declaration outside of C++, skip it. This
1285 // can happy because we look for any name when there is no
1286 // bias to protocol or type names.
1287 if (isa<RecordDecl>(typeDecl) && !Context.getLangOpts().CPlusPlus)
1288 return false;
1289
1290 // Make sure the type is something we would accept as a type
1291 // argument.
1292 auto type = Context.getTypeDeclType(typeDecl);
1293 if (type->isObjCObjectPointerType() ||
1294 type->isBlockPointerType() ||
1295 type->isDependentType() ||
1296 type->isObjCObjectType())
1297 return true;
1298
1299 return false;
1300 }
1301
1302 // If we have an Objective-C class type, accept it; there will
1303 // be another fix to add the '*'.
1304 if (candidate.getCorrectionDeclAs<ObjCInterfaceDecl>())
1305 return true;
1306
1307 return false;
1308 }
1309
1310 return false;
1311 }
1312};
Benjamin Kramer8b851d02015-07-13 20:42:13 +00001313} // end anonymous namespace
Douglas Gregore9d95f12015-07-07 03:57:35 +00001314
Bruno Cardoso Lopesc54768f2016-04-13 20:59:07 +00001315void Sema::DiagnoseTypeArgsAndProtocols(IdentifierInfo *ProtocolId,
1316 SourceLocation ProtocolLoc,
1317 IdentifierInfo *TypeArgId,
1318 SourceLocation TypeArgLoc,
1319 bool SelectProtocolFirst) {
1320 Diag(TypeArgLoc, diag::err_objc_type_args_and_protocols)
1321 << SelectProtocolFirst << TypeArgId << ProtocolId
1322 << SourceRange(ProtocolLoc);
1323}
1324
Douglas Gregore9d95f12015-07-07 03:57:35 +00001325void Sema::actOnObjCTypeArgsOrProtocolQualifiers(
1326 Scope *S,
Douglas Gregor10dc9d82015-07-07 03:58:28 +00001327 ParsedType baseType,
Douglas Gregore9d95f12015-07-07 03:57:35 +00001328 SourceLocation lAngleLoc,
1329 ArrayRef<IdentifierInfo *> identifiers,
1330 ArrayRef<SourceLocation> identifierLocs,
1331 SourceLocation rAngleLoc,
Douglas Gregor9bda6cf2015-07-07 03:58:14 +00001332 SourceLocation &typeArgsLAngleLoc,
1333 SmallVectorImpl<ParsedType> &typeArgs,
1334 SourceLocation &typeArgsRAngleLoc,
1335 SourceLocation &protocolLAngleLoc,
1336 SmallVectorImpl<Decl *> &protocols,
1337 SourceLocation &protocolRAngleLoc,
Douglas Gregore9d95f12015-07-07 03:57:35 +00001338 bool warnOnIncompleteProtocols) {
1339 // Local function that updates the declaration specifiers with
1340 // protocol information.
Douglas Gregore9d95f12015-07-07 03:57:35 +00001341 unsigned numProtocolsResolved = 0;
1342 auto resolvedAsProtocols = [&] {
1343 assert(numProtocolsResolved == identifiers.size() && "Unresolved protocols");
1344
Douglas Gregor10dc9d82015-07-07 03:58:28 +00001345 // Determine whether the base type is a parameterized class, in
1346 // which case we want to warn about typos such as
1347 // "NSArray<NSObject>" (that should be NSArray<NSObject *>).
1348 ObjCInterfaceDecl *baseClass = nullptr;
1349 QualType base = GetTypeFromParser(baseType, nullptr);
1350 bool allAreTypeNames = false;
1351 SourceLocation firstClassNameLoc;
1352 if (!base.isNull()) {
1353 if (const auto *objcObjectType = base->getAs<ObjCObjectType>()) {
1354 baseClass = objcObjectType->getInterface();
1355 if (baseClass) {
1356 if (auto typeParams = baseClass->getTypeParamList()) {
1357 if (typeParams->size() == numProtocolsResolved) {
1358 // Note that we should be looking for type names, too.
1359 allAreTypeNames = true;
1360 }
1361 }
1362 }
1363 }
1364 }
1365
Douglas Gregore9d95f12015-07-07 03:57:35 +00001366 for (unsigned i = 0, n = protocols.size(); i != n; ++i) {
Douglas Gregor9bda6cf2015-07-07 03:58:14 +00001367 ObjCProtocolDecl *&proto
1368 = reinterpret_cast<ObjCProtocolDecl *&>(protocols[i]);
Douglas Gregore9d95f12015-07-07 03:57:35 +00001369 // For an objc container, delay protocol reference checking until after we
1370 // can set the objc decl as the availability context, otherwise check now.
1371 if (!warnOnIncompleteProtocols) {
1372 (void)DiagnoseUseOfDecl(proto, identifierLocs[i]);
1373 }
1374
1375 // If this is a forward protocol declaration, get its definition.
1376 if (!proto->isThisDeclarationADefinition() && proto->getDefinition())
1377 proto = proto->getDefinition();
1378
1379 // If this is a forward declaration and we are supposed to warn in this
1380 // case, do it.
1381 // FIXME: Recover nicely in the hidden case.
1382 ObjCProtocolDecl *forwardDecl = nullptr;
1383 if (warnOnIncompleteProtocols &&
1384 NestedProtocolHasNoDefinition(proto, forwardDecl)) {
1385 Diag(identifierLocs[i], diag::warn_undef_protocolref)
1386 << proto->getDeclName();
1387 Diag(forwardDecl->getLocation(), diag::note_protocol_decl_undefined)
1388 << forwardDecl;
1389 }
Douglas Gregor10dc9d82015-07-07 03:58:28 +00001390
1391 // If everything this far has been a type name (and we care
1392 // about such things), check whether this name refers to a type
1393 // as well.
1394 if (allAreTypeNames) {
1395 if (auto *decl = LookupSingleName(S, identifiers[i], identifierLocs[i],
1396 LookupOrdinaryName)) {
1397 if (isa<ObjCInterfaceDecl>(decl)) {
1398 if (firstClassNameLoc.isInvalid())
1399 firstClassNameLoc = identifierLocs[i];
1400 } else if (!isa<TypeDecl>(decl)) {
1401 // Not a type.
1402 allAreTypeNames = false;
1403 }
1404 } else {
1405 allAreTypeNames = false;
1406 }
1407 }
1408 }
1409
1410 // All of the protocols listed also have type names, and at least
1411 // one is an Objective-C class name. Check whether all of the
1412 // protocol conformances are declared by the base class itself, in
1413 // which case we warn.
1414 if (allAreTypeNames && firstClassNameLoc.isValid()) {
1415 llvm::SmallPtrSet<ObjCProtocolDecl*, 8> knownProtocols;
1416 Context.CollectInheritedProtocols(baseClass, knownProtocols);
1417 bool allProtocolsDeclared = true;
1418 for (auto proto : protocols) {
1419 if (knownProtocols.count(static_cast<ObjCProtocolDecl *>(proto)) == 0) {
1420 allProtocolsDeclared = false;
1421 break;
1422 }
1423 }
1424
1425 if (allProtocolsDeclared) {
1426 Diag(firstClassNameLoc, diag::warn_objc_redundant_qualified_class_type)
1427 << baseClass->getDeclName() << SourceRange(lAngleLoc, rAngleLoc)
Craig Topper07fa1762015-11-15 02:31:46 +00001428 << FixItHint::CreateInsertion(getLocForEndOfToken(firstClassNameLoc),
1429 " *");
Douglas Gregor10dc9d82015-07-07 03:58:28 +00001430 }
Douglas Gregore9d95f12015-07-07 03:57:35 +00001431 }
1432
Douglas Gregor9bda6cf2015-07-07 03:58:14 +00001433 protocolLAngleLoc = lAngleLoc;
1434 protocolRAngleLoc = rAngleLoc;
1435 assert(protocols.size() == identifierLocs.size());
Douglas Gregore9d95f12015-07-07 03:57:35 +00001436 };
1437
1438 // Attempt to resolve all of the identifiers as protocols.
1439 for (unsigned i = 0, n = identifiers.size(); i != n; ++i) {
1440 ObjCProtocolDecl *proto = LookupProtocol(identifiers[i], identifierLocs[i]);
1441 protocols.push_back(proto);
1442 if (proto)
1443 ++numProtocolsResolved;
1444 }
1445
1446 // If all of the names were protocols, these were protocol qualifiers.
1447 if (numProtocolsResolved == identifiers.size())
1448 return resolvedAsProtocols();
1449
1450 // Attempt to resolve all of the identifiers as type names or
1451 // Objective-C class names. The latter is technically ill-formed,
1452 // but is probably something like \c NSArray<NSView *> missing the
1453 // \c*.
1454 typedef llvm::PointerUnion<TypeDecl *, ObjCInterfaceDecl *> TypeOrClassDecl;
1455 SmallVector<TypeOrClassDecl, 4> typeDecls;
1456 unsigned numTypeDeclsResolved = 0;
1457 for (unsigned i = 0, n = identifiers.size(); i != n; ++i) {
1458 NamedDecl *decl = LookupSingleName(S, identifiers[i], identifierLocs[i],
1459 LookupOrdinaryName);
1460 if (!decl) {
1461 typeDecls.push_back(TypeOrClassDecl());
1462 continue;
1463 }
1464
1465 if (auto typeDecl = dyn_cast<TypeDecl>(decl)) {
1466 typeDecls.push_back(typeDecl);
1467 ++numTypeDeclsResolved;
1468 continue;
1469 }
1470
1471 if (auto objcClass = dyn_cast<ObjCInterfaceDecl>(decl)) {
1472 typeDecls.push_back(objcClass);
1473 ++numTypeDeclsResolved;
1474 continue;
1475 }
1476
1477 typeDecls.push_back(TypeOrClassDecl());
1478 }
1479
1480 AttributeFactory attrFactory;
1481
1482 // Local function that forms a reference to the given type or
1483 // Objective-C class declaration.
1484 auto resolveTypeReference = [&](TypeOrClassDecl typeDecl, SourceLocation loc)
1485 -> TypeResult {
1486 // Form declaration specifiers. They simply refer to the type.
1487 DeclSpec DS(attrFactory);
1488 const char* prevSpec; // unused
1489 unsigned diagID; // unused
1490 QualType type;
1491 if (auto *actualTypeDecl = typeDecl.dyn_cast<TypeDecl *>())
1492 type = Context.getTypeDeclType(actualTypeDecl);
1493 else
1494 type = Context.getObjCInterfaceType(typeDecl.get<ObjCInterfaceDecl *>());
1495 TypeSourceInfo *parsedTSInfo = Context.getTrivialTypeSourceInfo(type, loc);
1496 ParsedType parsedType = CreateParsedType(type, parsedTSInfo);
1497 DS.SetTypeSpecType(DeclSpec::TST_typename, loc, prevSpec, diagID,
1498 parsedType, Context.getPrintingPolicy());
1499 // Use the identifier location for the type source range.
1500 DS.SetRangeStart(loc);
1501 DS.SetRangeEnd(loc);
1502
1503 // Form the declarator.
1504 Declarator D(DS, Declarator::TypeNameContext);
1505
1506 // If we have a typedef of an Objective-C class type that is missing a '*',
1507 // add the '*'.
1508 if (type->getAs<ObjCInterfaceType>()) {
Craig Topper07fa1762015-11-15 02:31:46 +00001509 SourceLocation starLoc = getLocForEndOfToken(loc);
Douglas Gregore9d95f12015-07-07 03:57:35 +00001510 ParsedAttributes parsedAttrs(attrFactory);
1511 D.AddTypeInfo(DeclaratorChunk::getPointer(/*typeQuals=*/0, starLoc,
1512 SourceLocation(),
1513 SourceLocation(),
1514 SourceLocation(),
Andrey Bokhanko45d41322016-05-11 18:38:21 +00001515 SourceLocation(),
Douglas Gregore9d95f12015-07-07 03:57:35 +00001516 SourceLocation()),
Hans Wennborgdcfba332015-10-06 23:40:43 +00001517 parsedAttrs,
1518 starLoc);
Douglas Gregore9d95f12015-07-07 03:57:35 +00001519
1520 // Diagnose the missing '*'.
1521 Diag(loc, diag::err_objc_type_arg_missing_star)
1522 << type
1523 << FixItHint::CreateInsertion(starLoc, " *");
1524 }
1525
1526 // Convert this to a type.
1527 return ActOnTypeName(S, D);
1528 };
1529
1530 // Local function that updates the declaration specifiers with
1531 // type argument information.
1532 auto resolvedAsTypeDecls = [&] {
Douglas Gregor9bda6cf2015-07-07 03:58:14 +00001533 // We did not resolve these as protocols.
1534 protocols.clear();
1535
Douglas Gregore9d95f12015-07-07 03:57:35 +00001536 assert(numTypeDeclsResolved == identifiers.size() && "Unresolved type decl");
1537 // Map type declarations to type arguments.
Douglas Gregore9d95f12015-07-07 03:57:35 +00001538 for (unsigned i = 0, n = identifiers.size(); i != n; ++i) {
1539 // Map type reference to a type.
1540 TypeResult type = resolveTypeReference(typeDecls[i], identifierLocs[i]);
Douglas Gregor9bda6cf2015-07-07 03:58:14 +00001541 if (!type.isUsable()) {
1542 typeArgs.clear();
Douglas Gregore9d95f12015-07-07 03:57:35 +00001543 return;
Douglas Gregor9bda6cf2015-07-07 03:58:14 +00001544 }
Douglas Gregore9d95f12015-07-07 03:57:35 +00001545
1546 typeArgs.push_back(type.get());
1547 }
1548
Douglas Gregor9bda6cf2015-07-07 03:58:14 +00001549 typeArgsLAngleLoc = lAngleLoc;
1550 typeArgsRAngleLoc = rAngleLoc;
Douglas Gregore9d95f12015-07-07 03:57:35 +00001551 };
1552
1553 // If all of the identifiers can be resolved as type names or
1554 // Objective-C class names, we have type arguments.
1555 if (numTypeDeclsResolved == identifiers.size())
1556 return resolvedAsTypeDecls();
1557
1558 // Error recovery: some names weren't found, or we have a mix of
1559 // type and protocol names. Go resolve all of the unresolved names
1560 // and complain if we can't find a consistent answer.
1561 LookupNameKind lookupKind = LookupAnyName;
1562 for (unsigned i = 0, n = identifiers.size(); i != n; ++i) {
1563 // If we already have a protocol or type. Check whether it is the
1564 // right thing.
1565 if (protocols[i] || typeDecls[i]) {
1566 // If we haven't figured out whether we want types or protocols
1567 // yet, try to figure it out from this name.
1568 if (lookupKind == LookupAnyName) {
1569 // If this name refers to both a protocol and a type (e.g., \c
1570 // NSObject), don't conclude anything yet.
1571 if (protocols[i] && typeDecls[i])
1572 continue;
1573
1574 // Otherwise, let this name decide whether we'll be correcting
1575 // toward types or protocols.
1576 lookupKind = protocols[i] ? LookupObjCProtocolName
1577 : LookupOrdinaryName;
1578 continue;
1579 }
1580
1581 // If we want protocols and we have a protocol, there's nothing
1582 // more to do.
1583 if (lookupKind == LookupObjCProtocolName && protocols[i])
1584 continue;
1585
1586 // If we want types and we have a type declaration, there's
1587 // nothing more to do.
1588 if (lookupKind == LookupOrdinaryName && typeDecls[i])
1589 continue;
1590
1591 // We have a conflict: some names refer to protocols and others
1592 // refer to types.
Bruno Cardoso Lopesc54768f2016-04-13 20:59:07 +00001593 DiagnoseTypeArgsAndProtocols(identifiers[0], identifierLocs[0],
1594 identifiers[i], identifierLocs[i],
1595 protocols[i] != nullptr);
Douglas Gregore9d95f12015-07-07 03:57:35 +00001596
Douglas Gregor9bda6cf2015-07-07 03:58:14 +00001597 protocols.clear();
1598 typeArgs.clear();
Douglas Gregore9d95f12015-07-07 03:57:35 +00001599 return;
1600 }
1601
1602 // Perform typo correction on the name.
1603 TypoCorrection corrected = CorrectTypo(
1604 DeclarationNameInfo(identifiers[i], identifierLocs[i]), lookupKind, S,
1605 nullptr,
1606 llvm::make_unique<ObjCTypeArgOrProtocolValidatorCCC>(Context,
1607 lookupKind),
1608 CTK_ErrorRecovery);
1609 if (corrected) {
1610 // Did we find a protocol?
1611 if (auto proto = corrected.getCorrectionDeclAs<ObjCProtocolDecl>()) {
1612 diagnoseTypo(corrected,
1613 PDiag(diag::err_undeclared_protocol_suggest)
1614 << identifiers[i]);
1615 lookupKind = LookupObjCProtocolName;
1616 protocols[i] = proto;
1617 ++numProtocolsResolved;
1618 continue;
1619 }
1620
1621 // Did we find a type?
1622 if (auto typeDecl = corrected.getCorrectionDeclAs<TypeDecl>()) {
1623 diagnoseTypo(corrected,
1624 PDiag(diag::err_unknown_typename_suggest)
1625 << identifiers[i]);
1626 lookupKind = LookupOrdinaryName;
1627 typeDecls[i] = typeDecl;
1628 ++numTypeDeclsResolved;
1629 continue;
1630 }
1631
1632 // Did we find an Objective-C class?
1633 if (auto objcClass = corrected.getCorrectionDeclAs<ObjCInterfaceDecl>()) {
1634 diagnoseTypo(corrected,
1635 PDiag(diag::err_unknown_type_or_class_name_suggest)
1636 << identifiers[i] << true);
1637 lookupKind = LookupOrdinaryName;
1638 typeDecls[i] = objcClass;
1639 ++numTypeDeclsResolved;
1640 continue;
1641 }
1642 }
1643
1644 // We couldn't find anything.
1645 Diag(identifierLocs[i],
1646 (lookupKind == LookupAnyName ? diag::err_objc_type_arg_missing
1647 : lookupKind == LookupObjCProtocolName ? diag::err_undeclared_protocol
1648 : diag::err_unknown_typename))
1649 << identifiers[i];
Douglas Gregor9bda6cf2015-07-07 03:58:14 +00001650 protocols.clear();
1651 typeArgs.clear();
Douglas Gregore9d95f12015-07-07 03:57:35 +00001652 return;
1653 }
1654
1655 // If all of the names were (corrected to) protocols, these were
1656 // protocol qualifiers.
1657 if (numProtocolsResolved == identifiers.size())
1658 return resolvedAsProtocols();
1659
1660 // Otherwise, all of the names were (corrected to) types.
1661 assert(numTypeDeclsResolved == identifiers.size() && "Not all types?");
1662 return resolvedAsTypeDecls();
1663}
1664
Fariborz Jahanianabf63e7b2009-03-02 19:06:08 +00001665/// DiagnoseClassExtensionDupMethods - Check for duplicate declaration of
Fariborz Jahanian33afd772009-03-02 19:05:07 +00001666/// a class method in its extension.
1667///
Mike Stump11289f42009-09-09 15:08:12 +00001668void Sema::DiagnoseClassExtensionDupMethods(ObjCCategoryDecl *CAT,
Fariborz Jahanian33afd772009-03-02 19:05:07 +00001669 ObjCInterfaceDecl *ID) {
1670 if (!ID)
1671 return; // Possibly due to previous error
1672
1673 llvm::DenseMap<Selector, const ObjCMethodDecl*> MethodMap;
Aaron Ballmanaff18c02014-03-13 19:03:34 +00001674 for (auto *MD : ID->methods())
Fariborz Jahanian33afd772009-03-02 19:05:07 +00001675 MethodMap[MD->getSelector()] = MD;
Fariborz Jahanian33afd772009-03-02 19:05:07 +00001676
1677 if (MethodMap.empty())
1678 return;
Aaron Ballmanaff18c02014-03-13 19:03:34 +00001679 for (const auto *Method : CAT->methods()) {
Fariborz Jahanian33afd772009-03-02 19:05:07 +00001680 const ObjCMethodDecl *&PrevMethod = MethodMap[Method->getSelector()];
Fariborz Jahanian83d674e2014-03-17 17:46:10 +00001681 if (PrevMethod &&
1682 (PrevMethod->isInstanceMethod() == Method->isInstanceMethod()) &&
1683 !MatchTwoMethodDeclarations(Method, PrevMethod)) {
Fariborz Jahanian33afd772009-03-02 19:05:07 +00001684 Diag(Method->getLocation(), diag::err_duplicate_method_decl)
1685 << Method->getDeclName();
1686 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
1687 }
1688 }
1689}
1690
James Dennett634962f2012-06-14 21:40:34 +00001691/// ActOnForwardProtocolDeclaration - Handle \@protocol foo;
Douglas Gregorf6102672012-01-01 21:23:57 +00001692Sema::DeclGroupPtrTy
Chris Lattnerda463fe2007-12-12 07:09:47 +00001693Sema::ActOnForwardProtocolDeclaration(SourceLocation AtProtocolLoc,
Craig Topper0f723bb2015-10-22 05:00:01 +00001694 ArrayRef<IdentifierLocPair> IdentList,
Fariborz Jahanian1470e932008-12-17 01:07:27 +00001695 AttributeList *attrList) {
Douglas Gregorf6102672012-01-01 21:23:57 +00001696 SmallVector<Decl *, 8> DeclsInGroup;
Craig Topper0f723bb2015-10-22 05:00:01 +00001697 for (const IdentifierLocPair &IdentPair : IdentList) {
1698 IdentifierInfo *Ident = IdentPair.first;
1699 ObjCProtocolDecl *PrevDecl = LookupProtocol(Ident, IdentPair.second,
Douglas Gregor32c17572012-01-01 20:30:41 +00001700 ForRedeclaration);
1701 ObjCProtocolDecl *PDecl
1702 = ObjCProtocolDecl::Create(Context, CurContext, Ident,
Craig Topper0f723bb2015-10-22 05:00:01 +00001703 IdentPair.second, AtProtocolLoc,
Douglas Gregor05a1f4d2012-01-01 22:06:18 +00001704 PrevDecl);
Douglas Gregor32c17572012-01-01 20:30:41 +00001705
1706 PushOnScopeChains(PDecl, TUScope);
Douglas Gregorf6102672012-01-01 21:23:57 +00001707 CheckObjCDeclScope(PDecl);
Douglas Gregor32c17572012-01-01 20:30:41 +00001708
Douglas Gregor42ff1bb2012-01-01 20:33:24 +00001709 if (attrList)
Douglas Gregor758a8692009-06-17 21:51:59 +00001710 ProcessDeclAttributeList(TUScope, PDecl, attrList);
Alex Lorenz9e7bf162017-04-18 14:33:39 +00001711 AddPragmaAttributes(TUScope, PDecl);
1712
Douglas Gregor32c17572012-01-01 20:30:41 +00001713 if (PrevDecl)
1714 mergeDeclAttributes(PDecl, PrevDecl);
1715
Douglas Gregorf6102672012-01-01 21:23:57 +00001716 DeclsInGroup.push_back(PDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001717 }
Mike Stump11289f42009-09-09 15:08:12 +00001718
Richard Smith3beb7c62017-01-12 02:27:38 +00001719 return BuildDeclaratorGroup(DeclsInGroup);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001720}
1721
John McCall48871652010-08-21 09:40:31 +00001722Decl *Sema::
Chris Lattnerd7352d62008-07-21 22:17:28 +00001723ActOnStartCategoryInterface(SourceLocation AtInterfaceLoc,
1724 IdentifierInfo *ClassName, SourceLocation ClassLoc,
Douglas Gregor85f3f952015-07-07 03:57:15 +00001725 ObjCTypeParamList *typeParamList,
Chris Lattnerd7352d62008-07-21 22:17:28 +00001726 IdentifierInfo *CategoryName,
1727 SourceLocation CategoryLoc,
John McCall48871652010-08-21 09:40:31 +00001728 Decl * const *ProtoRefs,
Chris Lattnerd7352d62008-07-21 22:17:28 +00001729 unsigned NumProtoRefs,
Douglas Gregor002b6712010-01-16 15:02:53 +00001730 const SourceLocation *ProtoLocs,
Alex Lorenzf9371392017-03-23 11:44:25 +00001731 SourceLocation EndProtoLoc,
1732 AttributeList *AttrList) {
Fariborz Jahanian3bf0ded2010-06-22 23:20:40 +00001733 ObjCCategoryDecl *CDecl;
Douglas Gregorb2ccf012010-04-15 22:33:43 +00001734 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName, ClassLoc, true);
Ted Kremenek514ff702010-02-23 19:39:46 +00001735
1736 /// Check that class of this category is already completely declared.
Douglas Gregor4123a862011-11-14 22:10:01 +00001737
1738 if (!IDecl
1739 || RequireCompleteType(ClassLoc, Context.getObjCInterfaceType(IDecl),
Douglas Gregor7bfb2d02012-05-04 16:32:21 +00001740 diag::err_category_forward_interface,
Craig Topperc3ec1492014-05-26 06:22:03 +00001741 CategoryName == nullptr)) {
Ted Kremenek514ff702010-02-23 19:39:46 +00001742 // Create an invalid ObjCCategoryDecl to serve as context for
1743 // the enclosing method declarations. We mark the decl invalid
1744 // to make it clear that this isn't a valid AST.
1745 CDecl = ObjCCategoryDecl::Create(Context, CurContext, AtInterfaceLoc,
Douglas Gregor85f3f952015-07-07 03:57:15 +00001746 ClassLoc, CategoryLoc, CategoryName,
1747 IDecl, typeParamList);
Ted Kremenek514ff702010-02-23 19:39:46 +00001748 CDecl->setInvalidDecl();
Argyrios Kyrtzidisb15def22012-03-12 18:34:26 +00001749 CurContext->addDecl(CDecl);
Douglas Gregor4123a862011-11-14 22:10:01 +00001750
1751 if (!IDecl)
1752 Diag(ClassLoc, diag::err_undef_interface) << ClassName;
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +00001753 return ActOnObjCContainerStartDefinition(CDecl);
Ted Kremenek514ff702010-02-23 19:39:46 +00001754 }
1755
Fariborz Jahanian3bf0ded2010-06-22 23:20:40 +00001756 if (!CategoryName && IDecl->getImplementation()) {
1757 Diag(ClassLoc, diag::err_class_extension_after_impl) << ClassName;
1758 Diag(IDecl->getImplementation()->getLocation(),
1759 diag::note_implementation_declared);
Ted Kremenek514ff702010-02-23 19:39:46 +00001760 }
1761
Fariborz Jahanian30a42922010-02-15 21:55:26 +00001762 if (CategoryName) {
1763 /// Check for duplicate interface declaration for this category
Douglas Gregor048fbfa2013-01-16 23:00:23 +00001764 if (ObjCCategoryDecl *Previous
1765 = IDecl->FindCategoryDeclaration(CategoryName)) {
1766 // Class extensions can be declared multiple times, categories cannot.
1767 Diag(CategoryLoc, diag::warn_dup_category_def)
1768 << ClassName << CategoryName;
1769 Diag(Previous->getLocation(), diag::note_previous_definition);
Chris Lattner9018ca82009-02-16 21:26:43 +00001770 }
1771 }
Chris Lattner9018ca82009-02-16 21:26:43 +00001772
Douglas Gregor85f3f952015-07-07 03:57:15 +00001773 // If we have a type parameter list, check it.
1774 if (typeParamList) {
1775 if (auto prevTypeParamList = IDecl->getTypeParamList()) {
1776 if (checkTypeParamListConsistency(*this, prevTypeParamList, typeParamList,
1777 CategoryName
1778 ? TypeParamListContext::Category
1779 : TypeParamListContext::Extension))
1780 typeParamList = nullptr;
1781 } else {
1782 Diag(typeParamList->getLAngleLoc(),
1783 diag::err_objc_parameterized_category_nonclass)
1784 << (CategoryName != nullptr)
1785 << ClassName
1786 << typeParamList->getSourceRange();
1787
1788 typeParamList = nullptr;
1789 }
1790 }
1791
Argyrios Kyrtzidis3a5094b2011-08-30 19:43:26 +00001792 CDecl = ObjCCategoryDecl::Create(Context, CurContext, AtInterfaceLoc,
Douglas Gregor85f3f952015-07-07 03:57:15 +00001793 ClassLoc, CategoryLoc, CategoryName, IDecl,
1794 typeParamList);
Argyrios Kyrtzidis3a5094b2011-08-30 19:43:26 +00001795 // FIXME: PushOnScopeChains?
1796 CurContext->addDecl(CDecl);
1797
Chris Lattnerda463fe2007-12-12 07:09:47 +00001798 if (NumProtoRefs) {
Argyrios Kyrtzidis4ecdd2c2015-04-19 20:15:55 +00001799 diagnoseUseOfProtocols(*this, CDecl, (ObjCProtocolDecl*const*)ProtoRefs,
1800 NumProtoRefs, ProtoLocs);
1801 CDecl->setProtocolList((ObjCProtocolDecl*const*)ProtoRefs, NumProtoRefs,
Douglas Gregor002b6712010-01-16 15:02:53 +00001802 ProtoLocs, Context);
Fariborz Jahanian092cd6e2009-10-05 20:41:32 +00001803 // Protocols in the class extension belong to the class.
Fariborz Jahanian30a42922010-02-15 21:55:26 +00001804 if (CDecl->IsClassExtension())
Roman Divackye6377112012-09-06 15:59:27 +00001805 IDecl->mergeClassExtensionProtocolList((ObjCProtocolDecl*const*)ProtoRefs,
Ted Kremenek0ef508d2010-09-01 01:21:15 +00001806 NumProtoRefs, Context);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001807 }
Mike Stump11289f42009-09-09 15:08:12 +00001808
Alex Lorenzf9371392017-03-23 11:44:25 +00001809 if (AttrList)
1810 ProcessDeclAttributeList(TUScope, CDecl, AttrList);
Alex Lorenz9e7bf162017-04-18 14:33:39 +00001811 AddPragmaAttributes(TUScope, CDecl);
Alex Lorenzf9371392017-03-23 11:44:25 +00001812
Anders Carlssona6b508a2008-11-04 16:57:32 +00001813 CheckObjCDeclScope(CDecl);
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +00001814 return ActOnObjCContainerStartDefinition(CDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001815}
1816
1817/// ActOnStartCategoryImplementation - Perform semantic checks on the
Ted Kremenek1b0ea822008-01-07 19:49:32 +00001818/// category implementation declaration and build an ObjCCategoryImplDecl
Chris Lattnerda463fe2007-12-12 07:09:47 +00001819/// object.
John McCall48871652010-08-21 09:40:31 +00001820Decl *Sema::ActOnStartCategoryImplementation(
Chris Lattnerda463fe2007-12-12 07:09:47 +00001821 SourceLocation AtCatImplLoc,
1822 IdentifierInfo *ClassName, SourceLocation ClassLoc,
1823 IdentifierInfo *CatName, SourceLocation CatLoc) {
Douglas Gregorb2ccf012010-04-15 22:33:43 +00001824 ObjCInterfaceDecl *IDecl = getObjCInterfaceDecl(ClassName, ClassLoc, true);
Craig Topperc3ec1492014-05-26 06:22:03 +00001825 ObjCCategoryDecl *CatIDecl = nullptr;
Argyrios Kyrtzidis4af2cb32012-03-02 19:14:29 +00001826 if (IDecl && IDecl->hasDefinition()) {
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +00001827 CatIDecl = IDecl->FindCategoryDeclaration(CatName);
1828 if (!CatIDecl) {
1829 // Category @implementation with no corresponding @interface.
1830 // Create and install one.
Argyrios Kyrtzidis41fc05c2011-11-23 20:27:26 +00001831 CatIDecl = ObjCCategoryDecl::Create(Context, CurContext, AtCatImplLoc,
1832 ClassLoc, CatLoc,
Douglas Gregor85f3f952015-07-07 03:57:15 +00001833 CatName, IDecl,
1834 /*typeParamList=*/nullptr);
Argyrios Kyrtzidis41fc05c2011-11-23 20:27:26 +00001835 CatIDecl->setImplicit();
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +00001836 }
1837 }
1838
Mike Stump11289f42009-09-09 15:08:12 +00001839 ObjCCategoryImplDecl *CDecl =
Argyrios Kyrtzidis52f53fb2011-10-04 04:48:02 +00001840 ObjCCategoryImplDecl::Create(Context, CurContext, CatName, IDecl,
Argyrios Kyrtzidis4996f5f2011-12-09 00:31:40 +00001841 ClassLoc, AtCatImplLoc, CatLoc);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001842 /// Check that class of this category is already completely declared.
Douglas Gregor4123a862011-11-14 22:10:01 +00001843 if (!IDecl) {
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001844 Diag(ClassLoc, diag::err_undef_interface) << ClassName;
John McCalld2930c22011-07-22 02:45:48 +00001845 CDecl->setInvalidDecl();
Douglas Gregor4123a862011-11-14 22:10:01 +00001846 } else if (RequireCompleteType(ClassLoc, Context.getObjCInterfaceType(IDecl),
1847 diag::err_undef_interface)) {
1848 CDecl->setInvalidDecl();
John McCalld2930c22011-07-22 02:45:48 +00001849 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00001850
Douglas Gregorc25d7a72009-01-09 00:49:46 +00001851 // FIXME: PushOnScopeChains?
Argyrios Kyrtzidiscfbfe782009-06-30 02:36:12 +00001852 CurContext->addDecl(CDecl);
Douglas Gregorc25d7a72009-01-09 00:49:46 +00001853
Douglas Gregor24ae22c2016-04-01 23:23:52 +00001854 // If the interface has the objc_runtime_visible attribute, we
1855 // cannot implement a category for it.
1856 if (IDecl && IDecl->hasAttr<ObjCRuntimeVisibleAttr>()) {
1857 Diag(ClassLoc, diag::err_objc_runtime_visible_category)
1858 << IDecl->getDeclName();
1859 }
1860
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +00001861 /// Check that CatName, category name, is not used in another implementation.
1862 if (CatIDecl) {
1863 if (CatIDecl->getImplementation()) {
1864 Diag(ClassLoc, diag::err_dup_implementation_category) << ClassName
1865 << CatName;
1866 Diag(CatIDecl->getImplementation()->getLocation(),
1867 diag::note_previous_definition);
Argyrios Kyrtzidis0f6d5ca2013-05-30 18:53:21 +00001868 CDecl->setInvalidDecl();
Fariborz Jahaniand33ab8c2011-02-15 00:59:30 +00001869 } else {
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +00001870 CatIDecl->setImplementation(CDecl);
Fariborz Jahaniand33ab8c2011-02-15 00:59:30 +00001871 // Warn on implementating category of deprecated class under
1872 // -Wdeprecated-implementations flag.
Alex Lorenzf9371392017-03-23 11:44:25 +00001873 DiagnoseObjCImplementedDeprecations(
1874 *this,
1875 CatIDecl->isDeprecated() ? CatIDecl : dyn_cast<NamedDecl>(IDecl),
1876 CDecl->getLocation(), 2);
Fariborz Jahaniand33ab8c2011-02-15 00:59:30 +00001877 }
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +00001878 }
Mike Stump11289f42009-09-09 15:08:12 +00001879
Anders Carlssona6b508a2008-11-04 16:57:32 +00001880 CheckObjCDeclScope(CDecl);
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +00001881 return ActOnObjCContainerStartDefinition(CDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001882}
1883
John McCall48871652010-08-21 09:40:31 +00001884Decl *Sema::ActOnStartClassImplementation(
Chris Lattnerda463fe2007-12-12 07:09:47 +00001885 SourceLocation AtClassImplLoc,
1886 IdentifierInfo *ClassName, SourceLocation ClassLoc,
Mike Stump11289f42009-09-09 15:08:12 +00001887 IdentifierInfo *SuperClassname,
Chris Lattnerda463fe2007-12-12 07:09:47 +00001888 SourceLocation SuperClassLoc) {
Craig Topperc3ec1492014-05-26 06:22:03 +00001889 ObjCInterfaceDecl *IDecl = nullptr;
Chris Lattnerda463fe2007-12-12 07:09:47 +00001890 // Check for another declaration kind with the same name.
John McCall9f3059a2009-10-09 21:13:30 +00001891 NamedDecl *PrevDecl
Douglas Gregorb8eaf292010-04-15 23:40:53 +00001892 = LookupSingleName(TUScope, ClassName, ClassLoc, LookupOrdinaryName,
1893 ForRedeclaration);
Ted Kremenek1b0ea822008-01-07 19:49:32 +00001894 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001895 Diag(ClassLoc, diag::err_redefinition_different_kind) << ClassName;
Chris Lattner0369c572008-11-23 23:12:31 +00001896 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
Douglas Gregor1c283312010-08-11 12:19:30 +00001897 } else if ((IDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl))) {
Richard Smithdb0ac552015-12-18 22:40:25 +00001898 // FIXME: This will produce an error if the definition of the interface has
1899 // been imported from a module but is not visible.
Douglas Gregorab1ec82e2011-12-16 03:12:41 +00001900 RequireCompleteType(ClassLoc, Context.getObjCInterfaceType(IDecl),
1901 diag::warn_undef_interface);
Douglas Gregor40f7a002010-01-04 17:27:12 +00001902 } else {
Richard Smithf9b15102013-08-17 00:46:16 +00001903 // We did not find anything with the name ClassName; try to correct for
Douglas Gregor40f7a002010-01-04 17:27:12 +00001904 // typos in the class name.
Kaelyn Takata89c881b2014-10-27 18:07:29 +00001905 TypoCorrection Corrected = CorrectTypo(
1906 DeclarationNameInfo(ClassName, ClassLoc), LookupOrdinaryName, TUScope,
1907 nullptr, llvm::make_unique<ObjCInterfaceValidatorCCC>(), CTK_NonError);
Richard Smithf9b15102013-08-17 00:46:16 +00001908 if (Corrected.getCorrectionDeclAs<ObjCInterfaceDecl>()) {
1909 // Suggest the (potentially) correct interface name. Don't provide a
1910 // code-modification hint or use the typo name for recovery, because
1911 // this is just a warning. The program may actually be correct.
1912 diagnoseTypo(Corrected,
1913 PDiag(diag::warn_undef_interface_suggest) << ClassName,
1914 /*ErrorRecovery*/false);
Douglas Gregor40f7a002010-01-04 17:27:12 +00001915 } else {
1916 Diag(ClassLoc, diag::warn_undef_interface) << ClassName;
1917 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00001918 }
Mike Stump11289f42009-09-09 15:08:12 +00001919
Chris Lattnerda463fe2007-12-12 07:09:47 +00001920 // Check that super class name is valid class name
Craig Topperc3ec1492014-05-26 06:22:03 +00001921 ObjCInterfaceDecl *SDecl = nullptr;
Chris Lattnerda463fe2007-12-12 07:09:47 +00001922 if (SuperClassname) {
1923 // Check if a different kind of symbol declared in this scope.
Douglas Gregorb2ccf012010-04-15 22:33:43 +00001924 PrevDecl = LookupSingleName(TUScope, SuperClassname, SuperClassLoc,
1925 LookupOrdinaryName);
Ted Kremenek1b0ea822008-01-07 19:49:32 +00001926 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001927 Diag(SuperClassLoc, diag::err_redefinition_different_kind)
1928 << SuperClassname;
Chris Lattner0369c572008-11-23 23:12:31 +00001929 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001930 } else {
Mike Stump11289f42009-09-09 15:08:12 +00001931 SDecl = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
Argyrios Kyrtzidis3b60cff2012-03-13 01:09:36 +00001932 if (SDecl && !SDecl->hasDefinition())
Craig Topperc3ec1492014-05-26 06:22:03 +00001933 SDecl = nullptr;
Chris Lattnerda463fe2007-12-12 07:09:47 +00001934 if (!SDecl)
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001935 Diag(SuperClassLoc, diag::err_undef_superclass)
1936 << SuperClassname << ClassName;
Douglas Gregor0b144e12011-12-15 00:29:59 +00001937 else if (IDecl && !declaresSameEntity(IDecl->getSuperClass(), SDecl)) {
Chris Lattnerda463fe2007-12-12 07:09:47 +00001938 // This implementation and its interface do not have the same
1939 // super class.
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001940 Diag(SuperClassLoc, diag::err_conflicting_super_class)
Chris Lattnere3d20d92008-11-23 21:45:46 +00001941 << SDecl->getDeclName();
Chris Lattner0369c572008-11-23 23:12:31 +00001942 Diag(SDecl->getLocation(), diag::note_previous_definition);
Chris Lattnerda463fe2007-12-12 07:09:47 +00001943 }
1944 }
1945 }
Mike Stump11289f42009-09-09 15:08:12 +00001946
Chris Lattnerda463fe2007-12-12 07:09:47 +00001947 if (!IDecl) {
1948 // Legacy case of @implementation with no corresponding @interface.
1949 // Build, chain & install the interface decl into the identifier.
Daniel Dunbar73a73f52008-08-20 18:02:42 +00001950
Mike Stump87c57ac2009-05-16 07:39:55 +00001951 // FIXME: Do we support attributes on the @implementation? If so we should
1952 // copy them over.
Mike Stump11289f42009-09-09 15:08:12 +00001953 IDecl = ObjCInterfaceDecl::Create(Context, CurContext, AtClassImplLoc,
Douglas Gregor85f3f952015-07-07 03:57:15 +00001954 ClassName, /*typeParamList=*/nullptr,
1955 /*PrevDecl=*/nullptr, ClassLoc,
Douglas Gregorab1ec82e2011-12-16 03:12:41 +00001956 true);
Alex Lorenz9e7bf162017-04-18 14:33:39 +00001957 AddPragmaAttributes(TUScope, IDecl);
Douglas Gregorc0ac7d62011-12-15 05:27:12 +00001958 IDecl->startDefinition();
Douglas Gregor16408322011-12-15 22:34:59 +00001959 if (SDecl) {
Douglas Gregore9d95f12015-07-07 03:57:35 +00001960 IDecl->setSuperClass(Context.getTrivialTypeSourceInfo(
1961 Context.getObjCInterfaceType(SDecl),
1962 SuperClassLoc));
Douglas Gregor16408322011-12-15 22:34:59 +00001963 IDecl->setEndOfDefinitionLoc(SuperClassLoc);
1964 } else {
1965 IDecl->setEndOfDefinitionLoc(ClassLoc);
1966 }
1967
Douglas Gregorac345a32009-04-24 00:16:12 +00001968 PushOnScopeChains(IDecl, TUScope);
Douglas Gregor1c283312010-08-11 12:19:30 +00001969 } else {
1970 // Mark the interface as being completed, even if it was just as
1971 // @class ....;
1972 // declaration; the user cannot reopen it.
Douglas Gregorc0ac7d62011-12-15 05:27:12 +00001973 if (!IDecl->hasDefinition())
1974 IDecl->startDefinition();
Chris Lattnerda463fe2007-12-12 07:09:47 +00001975 }
Mike Stump11289f42009-09-09 15:08:12 +00001976
1977 ObjCImplementationDecl* IMPDecl =
Argyrios Kyrtzidis52f53fb2011-10-04 04:48:02 +00001978 ObjCImplementationDecl::Create(Context, CurContext, IDecl, SDecl,
Argyrios Kyrtzidisfac31622013-05-03 18:05:44 +00001979 ClassLoc, AtClassImplLoc, SuperClassLoc);
Mike Stump11289f42009-09-09 15:08:12 +00001980
Anders Carlssona6b508a2008-11-04 16:57:32 +00001981 if (CheckObjCDeclScope(IMPDecl))
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +00001982 return ActOnObjCContainerStartDefinition(IMPDecl);
Mike Stump11289f42009-09-09 15:08:12 +00001983
Chris Lattnerda463fe2007-12-12 07:09:47 +00001984 // Check that there is no duplicate implementation of this class.
Douglas Gregor1c283312010-08-11 12:19:30 +00001985 if (IDecl->getImplementation()) {
1986 // FIXME: Don't leak everything!
Chris Lattner4bd8dd82008-11-19 08:23:25 +00001987 Diag(ClassLoc, diag::err_dup_implementation_class) << ClassName;
Argyrios Kyrtzidis43cee9352009-07-21 00:06:04 +00001988 Diag(IDecl->getImplementation()->getLocation(),
1989 diag::note_previous_definition);
Argyrios Kyrtzidis0f6d5ca2013-05-30 18:53:21 +00001990 IMPDecl->setInvalidDecl();
Douglas Gregor1c283312010-08-11 12:19:30 +00001991 } else { // add it to the list.
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +00001992 IDecl->setImplementation(IMPDecl);
Douglas Gregor79947a22009-04-24 00:11:27 +00001993 PushOnScopeChains(IMPDecl, TUScope);
Fariborz Jahaniand33ab8c2011-02-15 00:59:30 +00001994 // Warn on implementating deprecated class under
1995 // -Wdeprecated-implementations flag.
Fariborz Jahaniand724a102011-02-15 17:49:58 +00001996 DiagnoseObjCImplementedDeprecations(*this,
1997 dyn_cast<NamedDecl>(IDecl),
1998 IMPDecl->getLocation(), 1);
Argyrios Kyrtzidis6d9fab72009-07-21 00:05:53 +00001999 }
Douglas Gregor24ae22c2016-04-01 23:23:52 +00002000
2001 // If the superclass has the objc_runtime_visible attribute, we
2002 // cannot implement a subclass of it.
2003 if (IDecl->getSuperClass() &&
2004 IDecl->getSuperClass()->hasAttr<ObjCRuntimeVisibleAttr>()) {
2005 Diag(ClassLoc, diag::err_objc_runtime_visible_subclass)
2006 << IDecl->getDeclName()
2007 << IDecl->getSuperClass()->getDeclName();
2008 }
2009
Argyrios Kyrtzidis9321ad32011-10-06 23:23:20 +00002010 return ActOnObjCContainerStartDefinition(IMPDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +00002011}
2012
Argyrios Kyrtzidis2e85c5f2012-02-23 21:11:20 +00002013Sema::DeclGroupPtrTy
2014Sema::ActOnFinishObjCImplementation(Decl *ObjCImpDecl, ArrayRef<Decl *> Decls) {
2015 SmallVector<Decl *, 64> DeclsInGroup;
2016 DeclsInGroup.reserve(Decls.size() + 1);
2017
2018 for (unsigned i = 0, e = Decls.size(); i != e; ++i) {
2019 Decl *Dcl = Decls[i];
2020 if (!Dcl)
2021 continue;
2022 if (Dcl->getDeclContext()->isFileContext())
2023 Dcl->setTopLevelDeclInObjCContainer();
2024 DeclsInGroup.push_back(Dcl);
2025 }
2026
2027 DeclsInGroup.push_back(ObjCImpDecl);
2028
Richard Smith3beb7c62017-01-12 02:27:38 +00002029 return BuildDeclaratorGroup(DeclsInGroup);
Argyrios Kyrtzidis2e85c5f2012-02-23 21:11:20 +00002030}
2031
Ted Kremenek1b0ea822008-01-07 19:49:32 +00002032void Sema::CheckImplementationIvars(ObjCImplementationDecl *ImpDecl,
2033 ObjCIvarDecl **ivars, unsigned numIvars,
Chris Lattnerda463fe2007-12-12 07:09:47 +00002034 SourceLocation RBrace) {
2035 assert(ImpDecl && "missing implementation decl");
Douglas Gregor6e6ad602009-01-20 01:17:11 +00002036 ObjCInterfaceDecl* IDecl = ImpDecl->getClassInterface();
Chris Lattnerda463fe2007-12-12 07:09:47 +00002037 if (!IDecl)
2038 return;
James Dennett634962f2012-06-14 21:40:34 +00002039 /// Check case of non-existing \@interface decl.
2040 /// (legacy objective-c \@implementation decl without an \@interface decl).
Chris Lattnerda463fe2007-12-12 07:09:47 +00002041 /// Add implementations's ivar to the synthesize class's ivar list.
Steve Naroffaac654a2009-04-20 20:09:33 +00002042 if (IDecl->isImplicitInterfaceDecl()) {
Douglas Gregor16408322011-12-15 22:34:59 +00002043 IDecl->setEndOfDefinitionLoc(RBrace);
Fariborz Jahanian20912d62010-02-17 17:00:07 +00002044 // Add ivar's to class's DeclContext.
2045 for (unsigned i = 0, e = numIvars; i != e; ++i) {
Fariborz Jahanianc0309cd2010-02-17 18:10:54 +00002046 ivars[i]->setLexicalDeclContext(ImpDecl);
Richard Smith05afe5e2012-03-13 03:12:56 +00002047 IDecl->makeDeclVisibleInContext(ivars[i]);
Fariborz Jahanianaef66222010-02-19 00:31:17 +00002048 ImpDecl->addDecl(ivars[i]);
Fariborz Jahanian20912d62010-02-17 17:00:07 +00002049 }
2050
Chris Lattnerda463fe2007-12-12 07:09:47 +00002051 return;
2052 }
2053 // If implementation has empty ivar list, just return.
2054 if (numIvars == 0)
2055 return;
Mike Stump11289f42009-09-09 15:08:12 +00002056
Chris Lattnerda463fe2007-12-12 07:09:47 +00002057 assert(ivars && "missing @implementation ivars");
John McCall5fb5df92012-06-20 06:18:46 +00002058 if (LangOpts.ObjCRuntime.isNonFragile()) {
Fariborz Jahanian34e3cef2010-02-19 20:58:54 +00002059 if (ImpDecl->getSuperClass())
2060 Diag(ImpDecl->getLocation(), diag::warn_on_superclass_use);
2061 for (unsigned i = 0; i < numIvars; i++) {
2062 ObjCIvarDecl* ImplIvar = ivars[i];
2063 if (const ObjCIvarDecl *ClsIvar =
2064 IDecl->getIvarDecl(ImplIvar->getIdentifier())) {
2065 Diag(ImplIvar->getLocation(), diag::err_duplicate_ivar_declaration);
2066 Diag(ClsIvar->getLocation(), diag::note_previous_definition);
2067 continue;
2068 }
Fariborz Jahaniane23f26b2013-06-26 22:10:27 +00002069 // Check class extensions (unnamed categories) for duplicate ivars.
Aaron Ballmanf53d8dd2014-03-13 21:47:07 +00002070 for (const auto *CDecl : IDecl->visible_extensions()) {
Fariborz Jahaniane23f26b2013-06-26 22:10:27 +00002071 if (const ObjCIvarDecl *ClsExtIvar =
2072 CDecl->getIvarDecl(ImplIvar->getIdentifier())) {
2073 Diag(ImplIvar->getLocation(), diag::err_duplicate_ivar_declaration);
2074 Diag(ClsExtIvar->getLocation(), diag::note_previous_definition);
2075 continue;
2076 }
2077 }
Fariborz Jahanian34e3cef2010-02-19 20:58:54 +00002078 // Instance ivar to Implementation's DeclContext.
2079 ImplIvar->setLexicalDeclContext(ImpDecl);
Richard Smith05afe5e2012-03-13 03:12:56 +00002080 IDecl->makeDeclVisibleInContext(ImplIvar);
Fariborz Jahanian34e3cef2010-02-19 20:58:54 +00002081 ImpDecl->addDecl(ImplIvar);
2082 }
2083 return;
2084 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00002085 // Check interface's Ivar list against those in the implementation.
2086 // names and types must match.
2087 //
Chris Lattnerda463fe2007-12-12 07:09:47 +00002088 unsigned j = 0;
Mike Stump11289f42009-09-09 15:08:12 +00002089 ObjCInterfaceDecl::ivar_iterator
Chris Lattner061227a2007-12-12 17:58:05 +00002090 IVI = IDecl->ivar_begin(), IVE = IDecl->ivar_end();
2091 for (; numIvars > 0 && IVI != IVE; ++IVI) {
Ted Kremenek1b0ea822008-01-07 19:49:32 +00002092 ObjCIvarDecl* ImplIvar = ivars[j++];
David Blaikie40ed2972012-06-06 20:45:41 +00002093 ObjCIvarDecl* ClsIvar = *IVI;
Chris Lattnerda463fe2007-12-12 07:09:47 +00002094 assert (ImplIvar && "missing implementation ivar");
2095 assert (ClsIvar && "missing class ivar");
Mike Stump11289f42009-09-09 15:08:12 +00002096
Steve Naroff157599f2009-03-03 14:49:36 +00002097 // First, make sure the types match.
Richard Smithcaf33902011-10-10 18:28:20 +00002098 if (!Context.hasSameType(ImplIvar->getType(), ClsIvar->getType())) {
Chris Lattner3b054132008-11-19 05:08:23 +00002099 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_type)
Chris Lattnere3d20d92008-11-23 21:45:46 +00002100 << ImplIvar->getIdentifier()
2101 << ImplIvar->getType() << ClsIvar->getType();
Chris Lattner0369c572008-11-23 23:12:31 +00002102 Diag(ClsIvar->getLocation(), diag::note_previous_definition);
Richard Smithcaf33902011-10-10 18:28:20 +00002103 } else if (ImplIvar->isBitField() && ClsIvar->isBitField() &&
2104 ImplIvar->getBitWidthValue(Context) !=
2105 ClsIvar->getBitWidthValue(Context)) {
2106 Diag(ImplIvar->getBitWidth()->getLocStart(),
2107 diag::err_conflicting_ivar_bitwidth) << ImplIvar->getIdentifier();
2108 Diag(ClsIvar->getBitWidth()->getLocStart(),
2109 diag::note_previous_definition);
Mike Stump11289f42009-09-09 15:08:12 +00002110 }
Steve Naroff157599f2009-03-03 14:49:36 +00002111 // Make sure the names are identical.
2112 if (ImplIvar->getIdentifier() != ClsIvar->getIdentifier()) {
Chris Lattner3b054132008-11-19 05:08:23 +00002113 Diag(ImplIvar->getLocation(), diag::err_conflicting_ivar_name)
Chris Lattnere3d20d92008-11-23 21:45:46 +00002114 << ImplIvar->getIdentifier() << ClsIvar->getIdentifier();
Chris Lattner0369c572008-11-23 23:12:31 +00002115 Diag(ClsIvar->getLocation(), diag::note_previous_definition);
Chris Lattnerda463fe2007-12-12 07:09:47 +00002116 }
2117 --numIvars;
Chris Lattnerda463fe2007-12-12 07:09:47 +00002118 }
Mike Stump11289f42009-09-09 15:08:12 +00002119
Chris Lattner0f29d982007-12-12 18:11:49 +00002120 if (numIvars > 0)
Alp Tokerfff06742013-12-02 03:50:21 +00002121 Diag(ivars[j]->getLocation(), diag::err_inconsistent_ivar_count);
Chris Lattner0f29d982007-12-12 18:11:49 +00002122 else if (IVI != IVE)
Alp Tokerfff06742013-12-02 03:50:21 +00002123 Diag(IVI->getLocation(), diag::err_inconsistent_ivar_count);
Chris Lattnerda463fe2007-12-12 07:09:47 +00002124}
2125
Ted Kremenekf87decd2013-12-13 05:58:44 +00002126static void WarnUndefinedMethod(Sema &S, SourceLocation ImpLoc,
2127 ObjCMethodDecl *method,
2128 bool &IncompleteImpl,
Ted Kremenek2ccf19e2013-12-13 05:58:51 +00002129 unsigned DiagID,
Craig Topperc3ec1492014-05-26 06:22:03 +00002130 NamedDecl *NeededFor = nullptr) {
Fariborz Jahanian9fc39c42011-06-24 20:31:37 +00002131 // No point warning no definition of method which is 'unavailable'.
Douglas Gregorc2e3d5c2012-12-11 18:53:07 +00002132 switch (method->getAvailability()) {
2133 case AR_Available:
2134 case AR_Deprecated:
2135 break;
2136
2137 // Don't warn about unavailable or not-yet-introduced methods.
2138 case AR_NotYetIntroduced:
2139 case AR_Unavailable:
Fariborz Jahanian9fc39c42011-06-24 20:31:37 +00002140 return;
Douglas Gregorc2e3d5c2012-12-11 18:53:07 +00002141 }
2142
Ted Kremenek65d63572013-03-27 00:02:21 +00002143 // FIXME: For now ignore 'IncompleteImpl'.
2144 // Previously we grouped all unimplemented methods under a single
2145 // warning, but some users strongly voiced that they would prefer
2146 // separate warnings. We will give that approach a try, as that
2147 // matches what we do with protocols.
Ted Kremenek2ccf19e2013-12-13 05:58:51 +00002148 {
2149 const Sema::SemaDiagnosticBuilder &B = S.Diag(ImpLoc, DiagID);
2150 B << method;
2151 if (NeededFor)
2152 B << NeededFor;
2153 }
Ted Kremenek65d63572013-03-27 00:02:21 +00002154
2155 // Issue a note to the original declaration.
2156 SourceLocation MethodLoc = method->getLocStart();
2157 if (MethodLoc.isValid())
Ted Kremenekf87decd2013-12-13 05:58:44 +00002158 S.Diag(MethodLoc, diag::note_method_declared_at) << method;
Steve Naroff15833ed2008-02-10 21:38:56 +00002159}
2160
David Chisnallb62d15c2010-10-25 17:23:52 +00002161/// Determines if type B can be substituted for type A. Returns true if we can
2162/// guarantee that anything that the user will do to an object of type A can
2163/// also be done to an object of type B. This is trivially true if the two
2164/// types are the same, or if B is a subclass of A. It becomes more complex
2165/// in cases where protocols are involved.
2166///
2167/// Object types in Objective-C describe the minimum requirements for an
2168/// object, rather than providing a complete description of a type. For
2169/// example, if A is a subclass of B, then B* may refer to an instance of A.
2170/// The principle of substitutability means that we may use an instance of A
2171/// anywhere that we may use an instance of B - it will implement all of the
2172/// ivars of B and all of the methods of B.
2173///
2174/// This substitutability is important when type checking methods, because
2175/// the implementation may have stricter type definitions than the interface.
2176/// The interface specifies minimum requirements, but the implementation may
2177/// have more accurate ones. For example, a method may privately accept
2178/// instances of B, but only publish that it accepts instances of A. Any
2179/// object passed to it will be type checked against B, and so will implicitly
2180/// by a valid A*. Similarly, a method may return a subclass of the class that
2181/// it is declared as returning.
2182///
2183/// This is most important when considering subclassing. A method in a
2184/// subclass must accept any object as an argument that its superclass's
2185/// implementation accepts. It may, however, accept a more general type
2186/// without breaking substitutability (i.e. you can still use the subclass
2187/// anywhere that you can use the superclass, but not vice versa). The
2188/// converse requirement applies to return types: the return type for a
2189/// subclass method must be a valid object of the kind that the superclass
2190/// advertises, but it may be specified more accurately. This avoids the need
2191/// for explicit down-casting by callers.
2192///
2193/// Note: This is a stricter requirement than for assignment.
John McCall071df462010-10-28 02:34:38 +00002194static bool isObjCTypeSubstitutable(ASTContext &Context,
2195 const ObjCObjectPointerType *A,
2196 const ObjCObjectPointerType *B,
2197 bool rejectId) {
2198 // Reject a protocol-unqualified id.
2199 if (rejectId && B->isObjCIdType()) return false;
David Chisnallb62d15c2010-10-25 17:23:52 +00002200
2201 // If B is a qualified id, then A must also be a qualified id and it must
2202 // implement all of the protocols in B. It may not be a qualified class.
2203 // For example, MyClass<A> can be assigned to id<A>, but MyClass<A> is a
2204 // stricter definition so it is not substitutable for id<A>.
2205 if (B->isObjCQualifiedIdType()) {
2206 return A->isObjCQualifiedIdType() &&
John McCall071df462010-10-28 02:34:38 +00002207 Context.ObjCQualifiedIdTypesAreCompatible(QualType(A, 0),
2208 QualType(B,0),
2209 false);
David Chisnallb62d15c2010-10-25 17:23:52 +00002210 }
2211
2212 /*
2213 // id is a special type that bypasses type checking completely. We want a
2214 // warning when it is used in one place but not another.
2215 if (C.isObjCIdType(A) || C.isObjCIdType(B)) return false;
2216
2217
2218 // If B is a qualified id, then A must also be a qualified id (which it isn't
2219 // if we've got this far)
2220 if (B->isObjCQualifiedIdType()) return false;
2221 */
2222
2223 // Now we know that A and B are (potentially-qualified) class types. The
2224 // normal rules for assignment apply.
John McCall071df462010-10-28 02:34:38 +00002225 return Context.canAssignObjCInterfaces(A, B);
David Chisnallb62d15c2010-10-25 17:23:52 +00002226}
2227
John McCall071df462010-10-28 02:34:38 +00002228static SourceRange getTypeRange(TypeSourceInfo *TSI) {
2229 return (TSI ? TSI->getTypeLoc().getSourceRange() : SourceRange());
2230}
2231
Douglas Gregor813a0662015-06-19 18:14:38 +00002232/// Determine whether two set of Objective-C declaration qualifiers conflict.
2233static bool objcModifiersConflict(Decl::ObjCDeclQualifier x,
2234 Decl::ObjCDeclQualifier y) {
2235 return (x & ~Decl::OBJC_TQ_CSNullability) !=
2236 (y & ~Decl::OBJC_TQ_CSNullability);
2237}
2238
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002239static bool CheckMethodOverrideReturn(Sema &S,
John McCall071df462010-10-28 02:34:38 +00002240 ObjCMethodDecl *MethodImpl,
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00002241 ObjCMethodDecl *MethodDecl,
Fariborz Jahanian4ceec3f2011-07-24 20:53:26 +00002242 bool IsProtocolMethodDecl,
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00002243 bool IsOverridingMode,
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002244 bool Warn) {
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00002245 if (IsProtocolMethodDecl &&
Douglas Gregor813a0662015-06-19 18:14:38 +00002246 objcModifiersConflict(MethodDecl->getObjCDeclQualifier(),
2247 MethodImpl->getObjCDeclQualifier())) {
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002248 if (Warn) {
Alp Toker314cc812014-01-25 16:55:45 +00002249 S.Diag(MethodImpl->getLocation(),
2250 (IsOverridingMode
2251 ? diag::warn_conflicting_overriding_ret_type_modifiers
2252 : diag::warn_conflicting_ret_type_modifiers))
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00002253 << MethodImpl->getDeclName()
Aaron Ballman41b10ac2014-08-01 13:20:09 +00002254 << MethodImpl->getReturnTypeSourceRange();
Alp Toker314cc812014-01-25 16:55:45 +00002255 S.Diag(MethodDecl->getLocation(), diag::note_previous_declaration)
Aaron Ballman41b10ac2014-08-01 13:20:09 +00002256 << MethodDecl->getReturnTypeSourceRange();
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002257 }
2258 else
2259 return false;
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00002260 }
Douglas Gregor813a0662015-06-19 18:14:38 +00002261 if (Warn && IsOverridingMode &&
2262 !isa<ObjCImplementationDecl>(MethodImpl->getDeclContext()) &&
2263 !S.Context.hasSameNullabilityTypeQualifier(MethodImpl->getReturnType(),
2264 MethodDecl->getReturnType(),
2265 false)) {
Douglas Gregoraea7afd2015-06-24 22:02:08 +00002266 auto nullabilityMethodImpl =
2267 *MethodImpl->getReturnType()->getNullability(S.Context);
2268 auto nullabilityMethodDecl =
2269 *MethodDecl->getReturnType()->getNullability(S.Context);
Douglas Gregor813a0662015-06-19 18:14:38 +00002270 S.Diag(MethodImpl->getLocation(),
2271 diag::warn_conflicting_nullability_attr_overriding_ret_types)
Douglas Gregoraea7afd2015-06-24 22:02:08 +00002272 << DiagNullabilityKind(
2273 nullabilityMethodImpl,
2274 ((MethodImpl->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability)
2275 != 0))
2276 << DiagNullabilityKind(
2277 nullabilityMethodDecl,
2278 ((MethodDecl->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability)
2279 != 0));
Douglas Gregor813a0662015-06-19 18:14:38 +00002280 S.Diag(MethodDecl->getLocation(), diag::note_previous_declaration);
2281 }
2282
Alp Toker314cc812014-01-25 16:55:45 +00002283 if (S.Context.hasSameUnqualifiedType(MethodImpl->getReturnType(),
2284 MethodDecl->getReturnType()))
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002285 return true;
2286 if (!Warn)
2287 return false;
John McCall071df462010-10-28 02:34:38 +00002288
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00002289 unsigned DiagID =
2290 IsOverridingMode ? diag::warn_conflicting_overriding_ret_types
2291 : diag::warn_conflicting_ret_types;
John McCall071df462010-10-28 02:34:38 +00002292
2293 // Mismatches between ObjC pointers go into a different warning
2294 // category, and sometimes they're even completely whitelisted.
2295 if (const ObjCObjectPointerType *ImplPtrTy =
Alp Toker314cc812014-01-25 16:55:45 +00002296 MethodImpl->getReturnType()->getAs<ObjCObjectPointerType>()) {
John McCall071df462010-10-28 02:34:38 +00002297 if (const ObjCObjectPointerType *IfacePtrTy =
Alp Toker314cc812014-01-25 16:55:45 +00002298 MethodDecl->getReturnType()->getAs<ObjCObjectPointerType>()) {
John McCall071df462010-10-28 02:34:38 +00002299 // Allow non-matching return types as long as they don't violate
2300 // the principle of substitutability. Specifically, we permit
2301 // return types that are subclasses of the declared return type,
2302 // or that are more-qualified versions of the declared type.
2303 if (isObjCTypeSubstitutable(S.Context, IfacePtrTy, ImplPtrTy, false))
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002304 return false;
John McCall071df462010-10-28 02:34:38 +00002305
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00002306 DiagID =
2307 IsOverridingMode ? diag::warn_non_covariant_overriding_ret_types
Craig Topper8f7f3ea2015-11-17 05:40:05 +00002308 : diag::warn_non_covariant_ret_types;
John McCall071df462010-10-28 02:34:38 +00002309 }
2310 }
2311
2312 S.Diag(MethodImpl->getLocation(), DiagID)
Alp Toker314cc812014-01-25 16:55:45 +00002313 << MethodImpl->getDeclName() << MethodDecl->getReturnType()
2314 << MethodImpl->getReturnType()
Aaron Ballman41b10ac2014-08-01 13:20:09 +00002315 << MethodImpl->getReturnTypeSourceRange();
Alp Toker314cc812014-01-25 16:55:45 +00002316 S.Diag(MethodDecl->getLocation(), IsOverridingMode
2317 ? diag::note_previous_declaration
2318 : diag::note_previous_definition)
Aaron Ballman41b10ac2014-08-01 13:20:09 +00002319 << MethodDecl->getReturnTypeSourceRange();
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002320 return false;
John McCall071df462010-10-28 02:34:38 +00002321}
2322
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002323static bool CheckMethodOverrideParam(Sema &S,
John McCall071df462010-10-28 02:34:38 +00002324 ObjCMethodDecl *MethodImpl,
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00002325 ObjCMethodDecl *MethodDecl,
John McCall071df462010-10-28 02:34:38 +00002326 ParmVarDecl *ImplVar,
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00002327 ParmVarDecl *IfaceVar,
Fariborz Jahanian4ceec3f2011-07-24 20:53:26 +00002328 bool IsProtocolMethodDecl,
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00002329 bool IsOverridingMode,
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002330 bool Warn) {
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00002331 if (IsProtocolMethodDecl &&
Douglas Gregor813a0662015-06-19 18:14:38 +00002332 objcModifiersConflict(ImplVar->getObjCDeclQualifier(),
2333 IfaceVar->getObjCDeclQualifier())) {
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002334 if (Warn) {
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00002335 if (IsOverridingMode)
2336 S.Diag(ImplVar->getLocation(),
2337 diag::warn_conflicting_overriding_param_modifiers)
2338 << getTypeRange(ImplVar->getTypeSourceInfo())
2339 << MethodImpl->getDeclName();
2340 else S.Diag(ImplVar->getLocation(),
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002341 diag::warn_conflicting_param_modifiers)
2342 << getTypeRange(ImplVar->getTypeSourceInfo())
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00002343 << MethodImpl->getDeclName();
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002344 S.Diag(IfaceVar->getLocation(), diag::note_previous_declaration)
2345 << getTypeRange(IfaceVar->getTypeSourceInfo());
2346 }
2347 else
2348 return false;
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00002349 }
2350
John McCall071df462010-10-28 02:34:38 +00002351 QualType ImplTy = ImplVar->getType();
2352 QualType IfaceTy = IfaceVar->getType();
Douglas Gregor813a0662015-06-19 18:14:38 +00002353 if (Warn && IsOverridingMode &&
2354 !isa<ObjCImplementationDecl>(MethodImpl->getDeclContext()) &&
2355 !S.Context.hasSameNullabilityTypeQualifier(ImplTy, IfaceTy, true)) {
Douglas Gregor813a0662015-06-19 18:14:38 +00002356 S.Diag(ImplVar->getLocation(),
2357 diag::warn_conflicting_nullability_attr_overriding_param_types)
Douglas Gregoraea7afd2015-06-24 22:02:08 +00002358 << DiagNullabilityKind(
2359 *ImplTy->getNullability(S.Context),
2360 ((ImplVar->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability)
2361 != 0))
2362 << DiagNullabilityKind(
2363 *IfaceTy->getNullability(S.Context),
2364 ((IfaceVar->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability)
2365 != 0));
2366 S.Diag(IfaceVar->getLocation(), diag::note_previous_declaration);
Douglas Gregor813a0662015-06-19 18:14:38 +00002367 }
John McCall071df462010-10-28 02:34:38 +00002368 if (S.Context.hasSameUnqualifiedType(ImplTy, IfaceTy))
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002369 return true;
Manman Renc5705ba2016-09-13 17:41:05 +00002370
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002371 if (!Warn)
2372 return false;
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00002373 unsigned DiagID =
2374 IsOverridingMode ? diag::warn_conflicting_overriding_param_types
2375 : diag::warn_conflicting_param_types;
John McCall071df462010-10-28 02:34:38 +00002376
2377 // Mismatches between ObjC pointers go into a different warning
2378 // category, and sometimes they're even completely whitelisted.
2379 if (const ObjCObjectPointerType *ImplPtrTy =
2380 ImplTy->getAs<ObjCObjectPointerType>()) {
2381 if (const ObjCObjectPointerType *IfacePtrTy =
2382 IfaceTy->getAs<ObjCObjectPointerType>()) {
2383 // Allow non-matching argument types as long as they don't
2384 // violate the principle of substitutability. Specifically, the
2385 // implementation must accept any objects that the superclass
2386 // accepts, however it may also accept others.
2387 if (isObjCTypeSubstitutable(S.Context, ImplPtrTy, IfacePtrTy, true))
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002388 return false;
John McCall071df462010-10-28 02:34:38 +00002389
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00002390 DiagID =
2391 IsOverridingMode ? diag::warn_non_contravariant_overriding_param_types
Craig Topper8f7f3ea2015-11-17 05:40:05 +00002392 : diag::warn_non_contravariant_param_types;
John McCall071df462010-10-28 02:34:38 +00002393 }
2394 }
2395
2396 S.Diag(ImplVar->getLocation(), DiagID)
2397 << getTypeRange(ImplVar->getTypeSourceInfo())
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00002398 << MethodImpl->getDeclName() << IfaceTy << ImplTy;
2399 S.Diag(IfaceVar->getLocation(),
2400 (IsOverridingMode ? diag::note_previous_declaration
Craig Topper8f7f3ea2015-11-17 05:40:05 +00002401 : diag::note_previous_definition))
John McCall071df462010-10-28 02:34:38 +00002402 << getTypeRange(IfaceVar->getTypeSourceInfo());
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002403 return false;
John McCall071df462010-10-28 02:34:38 +00002404}
John McCall31168b02011-06-15 23:02:42 +00002405
2406/// In ARC, check whether the conventional meanings of the two methods
2407/// match. If they don't, it's a hard error.
2408static bool checkMethodFamilyMismatch(Sema &S, ObjCMethodDecl *impl,
2409 ObjCMethodDecl *decl) {
2410 ObjCMethodFamily implFamily = impl->getMethodFamily();
2411 ObjCMethodFamily declFamily = decl->getMethodFamily();
2412 if (implFamily == declFamily) return false;
2413
2414 // Since conventions are sorted by selector, the only possibility is
2415 // that the types differ enough to cause one selector or the other
2416 // to fall out of the family.
2417 assert(implFamily == OMF_None || declFamily == OMF_None);
2418
2419 // No further diagnostics required on invalid declarations.
2420 if (impl->isInvalidDecl() || decl->isInvalidDecl()) return true;
2421
2422 const ObjCMethodDecl *unmatched = impl;
2423 ObjCMethodFamily family = declFamily;
2424 unsigned errorID = diag::err_arc_lost_method_convention;
2425 unsigned noteID = diag::note_arc_lost_method_convention;
2426 if (declFamily == OMF_None) {
2427 unmatched = decl;
2428 family = implFamily;
2429 errorID = diag::err_arc_gained_method_convention;
2430 noteID = diag::note_arc_gained_method_convention;
2431 }
2432
2433 // Indexes into a %select clause in the diagnostic.
2434 enum FamilySelector {
2435 F_alloc, F_copy, F_mutableCopy = F_copy, F_init, F_new
2436 };
2437 FamilySelector familySelector = FamilySelector();
2438
2439 switch (family) {
2440 case OMF_None: llvm_unreachable("logic error, no method convention");
2441 case OMF_retain:
2442 case OMF_release:
2443 case OMF_autorelease:
2444 case OMF_dealloc:
Nico Weber1fb82662011-08-28 22:35:17 +00002445 case OMF_finalize:
John McCall31168b02011-06-15 23:02:42 +00002446 case OMF_retainCount:
2447 case OMF_self:
Fariborz Jahanian78e9deb2014-08-22 16:57:26 +00002448 case OMF_initialize:
Fariborz Jahanianb7a77362011-07-05 22:38:59 +00002449 case OMF_performSelector:
John McCall31168b02011-06-15 23:02:42 +00002450 // Mismatches for these methods don't change ownership
2451 // conventions, so we don't care.
2452 return false;
2453
2454 case OMF_init: familySelector = F_init; break;
2455 case OMF_alloc: familySelector = F_alloc; break;
2456 case OMF_copy: familySelector = F_copy; break;
2457 case OMF_mutableCopy: familySelector = F_mutableCopy; break;
2458 case OMF_new: familySelector = F_new; break;
2459 }
2460
2461 enum ReasonSelector { R_NonObjectReturn, R_UnrelatedReturn };
2462 ReasonSelector reasonSelector;
2463
2464 // The only reason these methods don't fall within their families is
2465 // due to unusual result types.
Alp Toker314cc812014-01-25 16:55:45 +00002466 if (unmatched->getReturnType()->isObjCObjectPointerType()) {
John McCall31168b02011-06-15 23:02:42 +00002467 reasonSelector = R_UnrelatedReturn;
2468 } else {
2469 reasonSelector = R_NonObjectReturn;
2470 }
2471
Joerg Sonnenbergerffc6d492013-06-26 21:31:47 +00002472 S.Diag(impl->getLocation(), errorID) << int(familySelector) << int(reasonSelector);
2473 S.Diag(decl->getLocation(), noteID) << int(familySelector) << int(reasonSelector);
John McCall31168b02011-06-15 23:02:42 +00002474
2475 return true;
2476}
John McCall071df462010-10-28 02:34:38 +00002477
Fariborz Jahanian7988d7d2008-12-05 18:18:52 +00002478void Sema::WarnConflictingTypedMethods(ObjCMethodDecl *ImpMethodDecl,
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00002479 ObjCMethodDecl *MethodDecl,
Fariborz Jahanian9a81f842011-10-10 17:53:29 +00002480 bool IsProtocolMethodDecl) {
David Blaikiebbafb8a2012-03-11 07:00:24 +00002481 if (getLangOpts().ObjCAutoRefCount &&
John McCall31168b02011-06-15 23:02:42 +00002482 checkMethodFamilyMismatch(*this, ImpMethodDecl, MethodDecl))
2483 return;
2484
Fariborz Jahaniand7b0cb52011-02-21 23:49:15 +00002485 CheckMethodOverrideReturn(*this, ImpMethodDecl, MethodDecl,
Fariborz Jahanian9a81f842011-10-10 17:53:29 +00002486 IsProtocolMethodDecl, false,
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00002487 true);
Mike Stump11289f42009-09-09 15:08:12 +00002488
Chris Lattner67f35b02009-04-11 19:58:42 +00002489 for (ObjCMethodDecl::param_iterator IM = ImpMethodDecl->param_begin(),
Douglas Gregor0bf70f42012-05-17 23:13:29 +00002490 IF = MethodDecl->param_begin(), EM = ImpMethodDecl->param_end(),
2491 EF = MethodDecl->param_end();
2492 IM != EM && IF != EF; ++IM, ++IF) {
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00002493 CheckMethodOverrideParam(*this, ImpMethodDecl, MethodDecl, *IM, *IF,
Fariborz Jahanian9a81f842011-10-10 17:53:29 +00002494 IsProtocolMethodDecl, false, true);
Fariborz Jahanian5ac085a2011-08-08 18:03:17 +00002495 }
Fariborz Jahanian3c12dd72011-08-10 17:16:30 +00002496
Fariborz Jahanian5ac085a2011-08-08 18:03:17 +00002497 if (ImpMethodDecl->isVariadic() != MethodDecl->isVariadic()) {
Fariborz Jahanian9a81f842011-10-10 17:53:29 +00002498 Diag(ImpMethodDecl->getLocation(),
2499 diag::warn_conflicting_variadic);
Fariborz Jahanian5ac085a2011-08-08 18:03:17 +00002500 Diag(MethodDecl->getLocation(), diag::note_previous_declaration);
Fariborz Jahanian5ac085a2011-08-08 18:03:17 +00002501 }
Fariborz Jahanian5ac085a2011-08-08 18:03:17 +00002502}
2503
Fariborz Jahanian9a81f842011-10-10 17:53:29 +00002504void Sema::CheckConflictingOverridingMethod(ObjCMethodDecl *Method,
2505 ObjCMethodDecl *Overridden,
2506 bool IsProtocolMethodDecl) {
2507
2508 CheckMethodOverrideReturn(*this, Method, Overridden,
2509 IsProtocolMethodDecl, true,
2510 true);
2511
2512 for (ObjCMethodDecl::param_iterator IM = Method->param_begin(),
Douglas Gregor0bf70f42012-05-17 23:13:29 +00002513 IF = Overridden->param_begin(), EM = Method->param_end(),
2514 EF = Overridden->param_end();
2515 IM != EM && IF != EF; ++IM, ++IF) {
Fariborz Jahanian9a81f842011-10-10 17:53:29 +00002516 CheckMethodOverrideParam(*this, Method, Overridden, *IM, *IF,
2517 IsProtocolMethodDecl, true, true);
2518 }
2519
2520 if (Method->isVariadic() != Overridden->isVariadic()) {
2521 Diag(Method->getLocation(),
2522 diag::warn_conflicting_overriding_variadic);
2523 Diag(Overridden->getLocation(), diag::note_previous_declaration);
2524 }
2525}
2526
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002527/// WarnExactTypedMethods - This routine issues a warning if method
2528/// implementation declaration matches exactly that of its declaration.
2529void Sema::WarnExactTypedMethods(ObjCMethodDecl *ImpMethodDecl,
2530 ObjCMethodDecl *MethodDecl,
2531 bool IsProtocolMethodDecl) {
2532 // don't issue warning when protocol method is optional because primary
2533 // class is not required to implement it and it is safe for protocol
2534 // to implement it.
2535 if (MethodDecl->getImplementationControl() == ObjCMethodDecl::Optional)
2536 return;
2537 // don't issue warning when primary class's method is
2538 // depecated/unavailable.
2539 if (MethodDecl->hasAttr<UnavailableAttr>() ||
2540 MethodDecl->hasAttr<DeprecatedAttr>())
2541 return;
2542
2543 bool match = CheckMethodOverrideReturn(*this, ImpMethodDecl, MethodDecl,
2544 IsProtocolMethodDecl, false, false);
2545 if (match)
2546 for (ObjCMethodDecl::param_iterator IM = ImpMethodDecl->param_begin(),
Douglas Gregor0bf70f42012-05-17 23:13:29 +00002547 IF = MethodDecl->param_begin(), EM = ImpMethodDecl->param_end(),
2548 EF = MethodDecl->param_end();
2549 IM != EM && IF != EF; ++IM, ++IF) {
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002550 match = CheckMethodOverrideParam(*this, ImpMethodDecl, MethodDecl,
2551 *IM, *IF,
2552 IsProtocolMethodDecl, false, false);
2553 if (!match)
2554 break;
2555 }
2556 if (match)
2557 match = (ImpMethodDecl->isVariadic() == MethodDecl->isVariadic());
David Chisnall92918512011-08-08 17:32:19 +00002558 if (match)
2559 match = !(MethodDecl->isClassMethod() &&
2560 MethodDecl->getSelector() == GetNullarySelector("load", Context));
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002561
2562 if (match) {
2563 Diag(ImpMethodDecl->getLocation(),
2564 diag::warn_category_method_impl_match);
Ted Kremenek59b10db2012-02-27 22:55:11 +00002565 Diag(MethodDecl->getLocation(), diag::note_method_declared_at)
2566 << MethodDecl->getDeclName();
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002567 }
2568}
2569
Mike Stump87c57ac2009-05-16 07:39:55 +00002570/// FIXME: Type hierarchies in Objective-C can be deep. We could most likely
2571/// improve the efficiency of selector lookups and type checking by associating
2572/// with each protocol / interface / category the flattened instance tables. If
2573/// we used an immutable set to keep the table then it wouldn't add significant
2574/// memory cost and it would be handy for lookups.
Daniel Dunbar4684f372008-08-27 05:40:03 +00002575
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00002576typedef llvm::DenseSet<IdentifierInfo*> ProtocolNameSet;
Ahmed Charlesaf94d562014-03-09 11:34:25 +00002577typedef std::unique_ptr<ProtocolNameSet> LazyProtocolNameSet;
Ted Kremenek760a2ac2014-03-05 23:18:22 +00002578
2579static void findProtocolsWithExplicitImpls(const ObjCProtocolDecl *PDecl,
2580 ProtocolNameSet &PNS) {
2581 if (PDecl->hasAttr<ObjCExplicitProtocolImplAttr>())
2582 PNS.insert(PDecl->getIdentifier());
Aaron Ballman0f6e64d2014-03-13 22:58:06 +00002583 for (const auto *PI : PDecl->protocols())
2584 findProtocolsWithExplicitImpls(PI, PNS);
Ted Kremenek760a2ac2014-03-05 23:18:22 +00002585}
2586
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00002587/// Recursively populates a set with all conformed protocols in a class
2588/// hierarchy that have the 'objc_protocol_requires_explicit_implementation'
2589/// attribute.
2590static void findProtocolsWithExplicitImpls(const ObjCInterfaceDecl *Super,
2591 ProtocolNameSet &PNS) {
2592 if (!Super)
2593 return;
2594
Aaron Ballmana9f49e32014-03-13 20:55:22 +00002595 for (const auto *I : Super->all_referenced_protocols())
2596 findProtocolsWithExplicitImpls(I, PNS);
Ted Kremenek760a2ac2014-03-05 23:18:22 +00002597
2598 findProtocolsWithExplicitImpls(Super->getSuperClass(), PNS);
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00002599}
2600
Steve Naroffa36992242008-02-08 22:06:17 +00002601/// CheckProtocolMethodDefs - This routine checks unimplemented methods
Chris Lattnerda463fe2007-12-12 07:09:47 +00002602/// Declared in protocol, and those referenced by it.
Ted Kremenek285ee852013-12-13 06:26:10 +00002603static void CheckProtocolMethodDefs(Sema &S,
2604 SourceLocation ImpLoc,
2605 ObjCProtocolDecl *PDecl,
2606 bool& IncompleteImpl,
2607 const Sema::SelectorSet &InsMap,
2608 const Sema::SelectorSet &ClsMap,
Ted Kremenek33e430f2013-12-13 06:26:14 +00002609 ObjCContainerDecl *CDecl,
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00002610 LazyProtocolNameSet &ProtocolsExplictImpl) {
Fariborz Jahanian29082a52012-02-09 21:30:24 +00002611 ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl);
2612 ObjCInterfaceDecl *IDecl = C ? C->getClassInterface()
2613 : dyn_cast<ObjCInterfaceDecl>(CDecl);
Fariborz Jahanian2e8074b2010-03-27 21:10:05 +00002614 assert (IDecl && "CheckProtocolMethodDefs - IDecl is null");
2615
Daniel Dunbarc7dfbfd2008-09-04 20:01:15 +00002616 ObjCInterfaceDecl *Super = IDecl->getSuperClass();
Craig Topperc3ec1492014-05-26 06:22:03 +00002617 ObjCInterfaceDecl *NSIDecl = nullptr;
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00002618
2619 // If this protocol is marked 'objc_protocol_requires_explicit_implementation'
2620 // then we should check if any class in the super class hierarchy also
2621 // conforms to this protocol, either directly or via protocol inheritance.
2622 // If so, we can skip checking this protocol completely because we
2623 // know that a parent class already satisfies this protocol.
2624 //
2625 // Note: we could generalize this logic for all protocols, and merely
2626 // add the limit on looking at the super class chain for just
2627 // specially marked protocols. This may be a good optimization. This
2628 // change is restricted to 'objc_protocol_requires_explicit_implementation'
2629 // protocols for now for controlled evaluation.
2630 if (PDecl->hasAttr<ObjCExplicitProtocolImplAttr>()) {
Ahmed Charlesaf94d562014-03-09 11:34:25 +00002631 if (!ProtocolsExplictImpl) {
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00002632 ProtocolsExplictImpl.reset(new ProtocolNameSet);
2633 findProtocolsWithExplicitImpls(Super, *ProtocolsExplictImpl);
2634 }
2635 if (ProtocolsExplictImpl->find(PDecl->getIdentifier()) !=
2636 ProtocolsExplictImpl->end())
2637 return;
2638
2639 // If no super class conforms to the protocol, we should not search
2640 // for methods in the super class to implicitly satisfy the protocol.
Craig Topperc3ec1492014-05-26 06:22:03 +00002641 Super = nullptr;
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00002642 }
2643
Ted Kremenek285ee852013-12-13 06:26:10 +00002644 if (S.getLangOpts().ObjCRuntime.isNeXTFamily()) {
Mike Stump11289f42009-09-09 15:08:12 +00002645 // check to see if class implements forwardInvocation method and objects
2646 // of this class are derived from 'NSProxy' so that to forward requests
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00002647 // from one object to another.
Mike Stump11289f42009-09-09 15:08:12 +00002648 // Under such conditions, which means that every method possible is
2649 // implemented in the class, we should not issue "Method definition not
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00002650 // found" warnings.
2651 // FIXME: Use a general GetUnarySelector method for this.
Ted Kremenek285ee852013-12-13 06:26:10 +00002652 IdentifierInfo* II = &S.Context.Idents.get("forwardInvocation");
2653 Selector fISelector = S.Context.Selectors.getSelector(1, &II);
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00002654 if (InsMap.count(fISelector))
2655 // Is IDecl derived from 'NSProxy'? If so, no instance methods
2656 // need be implemented in the implementation.
Ted Kremenek285ee852013-12-13 06:26:10 +00002657 NSIDecl = IDecl->lookupInheritedClass(&S.Context.Idents.get("NSProxy"));
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00002658 }
Mike Stump11289f42009-09-09 15:08:12 +00002659
Fariborz Jahanianc41cf052013-01-07 19:21:03 +00002660 // If this is a forward protocol declaration, get its definition.
2661 if (!PDecl->isThisDeclarationADefinition() &&
2662 PDecl->getDefinition())
2663 PDecl = PDecl->getDefinition();
2664
Daniel Dunbarc7dfbfd2008-09-04 20:01:15 +00002665 // If a method lookup fails locally we still need to look and see if
2666 // the method was implemented by a base class or an inherited
2667 // protocol. This lookup is slow, but occurs rarely in correct code
2668 // and otherwise would terminate in a warning.
2669
Chris Lattnerda463fe2007-12-12 07:09:47 +00002670 // check unimplemented instance methods.
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00002671 if (!NSIDecl)
Aaron Ballmanf26acce2014-03-13 19:50:17 +00002672 for (auto *method : PDecl->instance_methods()) {
Mike Stump11289f42009-09-09 15:08:12 +00002673 if (method->getImplementationControl() != ObjCMethodDecl::Optional &&
Jordan Rosed01e83a2012-10-10 16:42:25 +00002674 !method->isPropertyAccessor() &&
2675 !InsMap.count(method->getSelector()) &&
Ted Kremenek00781502013-11-23 01:01:29 +00002676 (!Super || !Super->lookupMethod(method->getSelector(),
2677 true /* instance */,
2678 false /* shallowCategory */,
Ted Kremenek28eace62013-11-23 01:01:34 +00002679 true /* followsSuper */,
Craig Topperc3ec1492014-05-26 06:22:03 +00002680 nullptr /* category */))) {
Fariborz Jahanian29082a52012-02-09 21:30:24 +00002681 // If a method is not implemented in the category implementation but
2682 // has been declared in its primary class, superclass,
2683 // or in one of their protocols, no need to issue the warning.
2684 // This is because method will be implemented in the primary class
2685 // or one of its super class implementation.
2686
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00002687 // Ugly, but necessary. Method declared in protcol might have
2688 // have been synthesized due to a property declared in the class which
2689 // uses the protocol.
Fariborz Jahanian29082a52012-02-09 21:30:24 +00002690 if (ObjCMethodDecl *MethodInClass =
Ted Kremenek00781502013-11-23 01:01:29 +00002691 IDecl->lookupMethod(method->getSelector(),
2692 true /* instance */,
2693 true /* shallowCategoryLookup */,
2694 false /* followSuper */))
Jordan Rosed01e83a2012-10-10 16:42:25 +00002695 if (C || MethodInClass->isPropertyAccessor())
Fariborz Jahanian29082a52012-02-09 21:30:24 +00002696 continue;
2697 unsigned DIAG = diag::warn_unimplemented_protocol_method;
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002698 if (!S.Diags.isIgnored(DIAG, ImpLoc)) {
Ted Kremenek285ee852013-12-13 06:26:10 +00002699 WarnUndefinedMethod(S, ImpLoc, method, IncompleteImpl, DIAG,
Ted Kremenek2ccf19e2013-12-13 05:58:51 +00002700 PDecl);
Fariborz Jahanian97752f72010-03-27 19:02:17 +00002701 }
Fariborz Jahaniandb3a4c12009-05-22 17:12:32 +00002702 }
2703 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00002704 // check unimplemented class methods
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00002705 for (auto *method : PDecl->class_methods()) {
Daniel Dunbarc7dfbfd2008-09-04 20:01:15 +00002706 if (method->getImplementationControl() != ObjCMethodDecl::Optional &&
2707 !ClsMap.count(method->getSelector()) &&
Ted Kremenek00781502013-11-23 01:01:29 +00002708 (!Super || !Super->lookupMethod(method->getSelector(),
2709 false /* class method */,
2710 false /* shallowCategoryLookup */,
Ted Kremenek28eace62013-11-23 01:01:34 +00002711 true /* followSuper */,
Craig Topperc3ec1492014-05-26 06:22:03 +00002712 nullptr /* category */))) {
Fariborz Jahanian29082a52012-02-09 21:30:24 +00002713 // See above comment for instance method lookups.
Ted Kremenek00781502013-11-23 01:01:29 +00002714 if (C && IDecl->lookupMethod(method->getSelector(),
2715 false /* class */,
2716 true /* shallowCategoryLookup */,
2717 false /* followSuper */))
Fariborz Jahanian29082a52012-02-09 21:30:24 +00002718 continue;
Ted Kremenek00781502013-11-23 01:01:29 +00002719
Fariborz Jahanianc1fb8622010-03-31 18:23:33 +00002720 unsigned DIAG = diag::warn_unimplemented_protocol_method;
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00002721 if (!S.Diags.isIgnored(DIAG, ImpLoc)) {
Ted Kremenek285ee852013-12-13 06:26:10 +00002722 WarnUndefinedMethod(S, ImpLoc, method, IncompleteImpl, DIAG, PDecl);
Fariborz Jahanianc1fb8622010-03-31 18:23:33 +00002723 }
Fariborz Jahanian97752f72010-03-27 19:02:17 +00002724 }
Steve Naroff3ce37a62007-12-14 23:37:57 +00002725 }
Chris Lattner390d39a2008-07-21 21:32:27 +00002726 // Check on this protocols's referenced protocols, recursively.
Aaron Ballman0f6e64d2014-03-13 22:58:06 +00002727 for (auto *PI : PDecl->protocols())
2728 CheckProtocolMethodDefs(S, ImpLoc, PI, IncompleteImpl, InsMap, ClsMap,
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00002729 CDecl, ProtocolsExplictImpl);
Chris Lattnerda463fe2007-12-12 07:09:47 +00002730}
2731
Fariborz Jahanianf9ae68a2011-07-16 00:08:33 +00002732/// MatchAllMethodDeclarations - Check methods declared in interface
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002733/// or protocol against those declared in their implementations.
2734///
Benjamin Kramerb33ffee2012-05-27 13:28:52 +00002735void Sema::MatchAllMethodDeclarations(const SelectorSet &InsMap,
2736 const SelectorSet &ClsMap,
2737 SelectorSet &InsMapSeen,
2738 SelectorSet &ClsMapSeen,
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002739 ObjCImplDecl* IMPDecl,
2740 ObjCContainerDecl* CDecl,
2741 bool &IncompleteImpl,
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002742 bool ImmediateClass,
Fariborz Jahanian29082a52012-02-09 21:30:24 +00002743 bool WarnCategoryMethodImpl) {
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002744 // Check and see if instance methods in class interface have been
2745 // implemented in the implementation class. If so, their types match.
Aaron Ballmanf26acce2014-03-13 19:50:17 +00002746 for (auto *I : CDecl->instance_methods()) {
David Blaikie82e95a32014-11-19 07:49:47 +00002747 if (!InsMapSeen.insert(I->getSelector()).second)
Benjamin Kramer9f8e2d72013-10-14 15:16:10 +00002748 continue;
Aaron Ballmanf26acce2014-03-13 19:50:17 +00002749 if (!I->isPropertyAccessor() &&
2750 !InsMap.count(I->getSelector())) {
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002751 if (ImmediateClass)
Aaron Ballmanf26acce2014-03-13 19:50:17 +00002752 WarnUndefinedMethod(*this, IMPDecl->getLocation(), I, IncompleteImpl,
Ted Kremenek65d63572013-03-27 00:02:21 +00002753 diag::warn_undef_method_impl);
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002754 continue;
Mike Stump12b8ce12009-08-04 21:02:39 +00002755 } else {
Mike Stump11289f42009-09-09 15:08:12 +00002756 ObjCMethodDecl *ImpMethodDecl =
Aaron Ballmanf26acce2014-03-13 19:50:17 +00002757 IMPDecl->getInstanceMethod(I->getSelector());
Manman Rena58f92f2016-10-11 21:18:20 +00002758 assert(CDecl->getInstanceMethod(I->getSelector(), true/*AllowHidden*/) &&
Argyrios Kyrtzidis342e08f2011-08-30 19:43:21 +00002759 "Expected to find the method through lookup as well");
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002760 // ImpMethodDecl may be null as in a @dynamic property.
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002761 if (ImpMethodDecl) {
Fariborz Jahanian29082a52012-02-09 21:30:24 +00002762 if (!WarnCategoryMethodImpl)
Aaron Ballmanf26acce2014-03-13 19:50:17 +00002763 WarnConflictingTypedMethods(ImpMethodDecl, I,
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002764 isa<ObjCProtocolDecl>(CDecl));
Aaron Ballmanf26acce2014-03-13 19:50:17 +00002765 else if (!I->isPropertyAccessor())
2766 WarnExactTypedMethods(ImpMethodDecl, I, isa<ObjCProtocolDecl>(CDecl));
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002767 }
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002768 }
2769 }
Mike Stump11289f42009-09-09 15:08:12 +00002770
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002771 // Check and see if class methods in class interface have been
2772 // implemented in the implementation class. If so, their types match.
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00002773 for (auto *I : CDecl->class_methods()) {
David Blaikie82e95a32014-11-19 07:49:47 +00002774 if (!ClsMapSeen.insert(I->getSelector()).second)
Benjamin Kramer9f8e2d72013-10-14 15:16:10 +00002775 continue;
Manman Rend36f7d52016-01-27 20:10:32 +00002776 if (!I->isPropertyAccessor() &&
2777 !ClsMap.count(I->getSelector())) {
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002778 if (ImmediateClass)
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00002779 WarnUndefinedMethod(*this, IMPDecl->getLocation(), I, IncompleteImpl,
Ted Kremenek65d63572013-03-27 00:02:21 +00002780 diag::warn_undef_method_impl);
Mike Stump12b8ce12009-08-04 21:02:39 +00002781 } else {
Argyrios Kyrtzidiscfbfe782009-06-30 02:36:12 +00002782 ObjCMethodDecl *ImpMethodDecl =
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00002783 IMPDecl->getClassMethod(I->getSelector());
Manman Rena58f92f2016-10-11 21:18:20 +00002784 assert(CDecl->getClassMethod(I->getSelector(), true/*AllowHidden*/) &&
Argyrios Kyrtzidis342e08f2011-08-30 19:43:21 +00002785 "Expected to find the method through lookup as well");
Manman Rend36f7d52016-01-27 20:10:32 +00002786 // ImpMethodDecl may be null as in a @dynamic property.
2787 if (ImpMethodDecl) {
2788 if (!WarnCategoryMethodImpl)
2789 WarnConflictingTypedMethods(ImpMethodDecl, I,
2790 isa<ObjCProtocolDecl>(CDecl));
2791 else if (!I->isPropertyAccessor())
2792 WarnExactTypedMethods(ImpMethodDecl, I, isa<ObjCProtocolDecl>(CDecl));
2793 }
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002794 }
2795 }
Fariborz Jahanian73853e52010-10-08 22:59:25 +00002796
Fariborz Jahanian8181caa2013-08-14 23:58:55 +00002797 if (ObjCProtocolDecl *PD = dyn_cast<ObjCProtocolDecl> (CDecl)) {
2798 // Also, check for methods declared in protocols inherited by
2799 // this protocol.
Aaron Ballman0f6e64d2014-03-13 22:58:06 +00002800 for (auto *PI : PD->protocols())
Fariborz Jahanian8181caa2013-08-14 23:58:55 +00002801 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
Aaron Ballman0f6e64d2014-03-13 22:58:06 +00002802 IMPDecl, PI, IncompleteImpl, false,
Fariborz Jahanian8181caa2013-08-14 23:58:55 +00002803 WarnCategoryMethodImpl);
2804 }
2805
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002806 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) {
Fariborz Jahanian6f5309c2012-10-23 23:06:22 +00002807 // when checking that methods in implementation match their declaration,
2808 // i.e. when WarnCategoryMethodImpl is false, check declarations in class
2809 // extension; as well as those in categories.
Douglas Gregor048fbfa2013-01-16 23:00:23 +00002810 if (!WarnCategoryMethodImpl) {
Aaron Ballmanf53d8dd2014-03-13 21:47:07 +00002811 for (auto *Cat : I->visible_categories())
Fariborz Jahanian6f5309c2012-10-23 23:06:22 +00002812 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
Argyrios Kyrtzidis3a437542015-10-13 23:27:34 +00002813 IMPDecl, Cat, IncompleteImpl,
2814 ImmediateClass && Cat->IsClassExtension(),
Fariborz Jahanian6f5309c2012-10-23 23:06:22 +00002815 WarnCategoryMethodImpl);
Douglas Gregor048fbfa2013-01-16 23:00:23 +00002816 } else {
Fariborz Jahanian6f5309c2012-10-23 23:06:22 +00002817 // Also methods in class extensions need be looked at next.
Aaron Ballmanf53d8dd2014-03-13 21:47:07 +00002818 for (auto *Ext : I->visible_extensions())
Fariborz Jahanian6f5309c2012-10-23 23:06:22 +00002819 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
Aaron Ballmanf53d8dd2014-03-13 21:47:07 +00002820 IMPDecl, Ext, IncompleteImpl, false,
Fariborz Jahanian6f5309c2012-10-23 23:06:22 +00002821 WarnCategoryMethodImpl);
Douglas Gregor048fbfa2013-01-16 23:00:23 +00002822 }
2823
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002824 // Check for any implementation of a methods declared in protocol.
Aaron Ballmana9f49e32014-03-13 20:55:22 +00002825 for (auto *PI : I->all_referenced_protocols())
Mike Stump11289f42009-09-09 15:08:12 +00002826 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
Aaron Ballmana9f49e32014-03-13 20:55:22 +00002827 IMPDecl, PI, IncompleteImpl, false,
Fariborz Jahanian29082a52012-02-09 21:30:24 +00002828 WarnCategoryMethodImpl);
Aaron Ballmana9f49e32014-03-13 20:55:22 +00002829
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002830 // FIXME. For now, we are not checking for extact match of methods
2831 // in category implementation and its primary class's super class.
Fariborz Jahanian29082a52012-02-09 21:30:24 +00002832 if (!WarnCategoryMethodImpl && I->getSuperClass())
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002833 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
Mike Stump11289f42009-09-09 15:08:12 +00002834 IMPDecl,
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002835 I->getSuperClass(), IncompleteImpl, false);
2836 }
2837}
2838
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002839/// CheckCategoryVsClassMethodMatches - Checks that methods implemented in
2840/// category matches with those implemented in its primary class and
2841/// warns each time an exact match is found.
2842void Sema::CheckCategoryVsClassMethodMatches(
2843 ObjCCategoryImplDecl *CatIMPDecl) {
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002844 // Get category's primary class.
2845 ObjCCategoryDecl *CatDecl = CatIMPDecl->getCategoryDecl();
2846 if (!CatDecl)
2847 return;
2848 ObjCInterfaceDecl *IDecl = CatDecl->getClassInterface();
2849 if (!IDecl)
2850 return;
Fariborz Jahanianf3077a22013-12-05 20:52:31 +00002851 ObjCInterfaceDecl *SuperIDecl = IDecl->getSuperClass();
2852 SelectorSet InsMap, ClsMap;
2853
Aaron Ballmanf26acce2014-03-13 19:50:17 +00002854 for (const auto *I : CatIMPDecl->instance_methods()) {
2855 Selector Sel = I->getSelector();
Fariborz Jahanianf3077a22013-12-05 20:52:31 +00002856 // When checking for methods implemented in the category, skip over
2857 // those declared in category class's super class. This is because
2858 // the super class must implement the method.
2859 if (SuperIDecl && SuperIDecl->lookupMethod(Sel, true))
2860 continue;
2861 InsMap.insert(Sel);
2862 }
2863
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00002864 for (const auto *I : CatIMPDecl->class_methods()) {
2865 Selector Sel = I->getSelector();
Fariborz Jahanianf3077a22013-12-05 20:52:31 +00002866 if (SuperIDecl && SuperIDecl->lookupMethod(Sel, false))
2867 continue;
2868 ClsMap.insert(Sel);
2869 }
2870 if (InsMap.empty() && ClsMap.empty())
2871 return;
2872
Benjamin Kramerb33ffee2012-05-27 13:28:52 +00002873 SelectorSet InsMapSeen, ClsMapSeen;
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002874 bool IncompleteImpl = false;
2875 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
2876 CatIMPDecl, IDecl,
Fariborz Jahanian29082a52012-02-09 21:30:24 +00002877 IncompleteImpl, false,
2878 true /*WarnCategoryMethodImpl*/);
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002879}
Fariborz Jahanian4ceec3f2011-07-24 20:53:26 +00002880
Fariborz Jahanian25491a22010-05-05 21:52:17 +00002881void Sema::ImplMethodsVsClassMethods(Scope *S, ObjCImplDecl* IMPDecl,
Mike Stump11289f42009-09-09 15:08:12 +00002882 ObjCContainerDecl* CDecl,
Chris Lattner9ef10f42009-03-01 00:56:52 +00002883 bool IncompleteImpl) {
Benjamin Kramerb33ffee2012-05-27 13:28:52 +00002884 SelectorSet InsMap;
Chris Lattnerda463fe2007-12-12 07:09:47 +00002885 // Check and see if instance methods in class interface have been
2886 // implemented in the implementation class.
Aaron Ballmanf26acce2014-03-13 19:50:17 +00002887 for (const auto *I : IMPDecl->instance_methods())
2888 InsMap.insert(I->getSelector());
Mike Stump11289f42009-09-09 15:08:12 +00002889
Douglas Gregoracf4fd32015-11-03 01:15:46 +00002890 // Add the selectors for getters/setters of @dynamic properties.
2891 for (const auto *PImpl : IMPDecl->property_impls()) {
2892 // We only care about @dynamic implementations.
2893 if (PImpl->getPropertyImplementation() != ObjCPropertyImplDecl::Dynamic)
2894 continue;
2895
2896 const auto *P = PImpl->getPropertyDecl();
2897 if (!P) continue;
2898
2899 InsMap.insert(P->getGetterName());
2900 if (!P->getSetterName().isNull())
2901 InsMap.insert(P->getSetterName());
2902 }
2903
Fariborz Jahanian6c6aea92009-04-14 23:15:21 +00002904 // Check and see if properties declared in the interface have either 1)
2905 // an implementation or 2) there is a @synthesize/@dynamic implementation
2906 // of the property in the @implementation.
Ted Kremenek348e88c2014-02-21 19:41:34 +00002907 if (const ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(CDecl)) {
2908 bool SynthesizeProperties = LangOpts.ObjCDefaultSynthProperties &&
2909 LangOpts.ObjCRuntime.isNonFragile() &&
2910 !IDecl->isObjCRequiresPropertyDefs();
2911 DiagnoseUnimplementedProperties(S, IMPDecl, CDecl, SynthesizeProperties);
2912 }
2913
Douglas Gregor849ebc22015-06-19 18:14:46 +00002914 // Diagnose null-resettable synthesized setters.
2915 diagnoseNullResettableSynthesizedSetters(IMPDecl);
2916
Benjamin Kramerb33ffee2012-05-27 13:28:52 +00002917 SelectorSet ClsMap;
Aaron Ballmane8a7dc92014-03-13 20:11:06 +00002918 for (const auto *I : IMPDecl->class_methods())
2919 ClsMap.insert(I->getSelector());
Mike Stump11289f42009-09-09 15:08:12 +00002920
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002921 // Check for type conflict of methods declared in a class/protocol and
2922 // its implementation; if any.
Benjamin Kramerb33ffee2012-05-27 13:28:52 +00002923 SelectorSet InsMapSeen, ClsMapSeen;
Mike Stump11289f42009-09-09 15:08:12 +00002924 MatchAllMethodDeclarations(InsMap, ClsMap, InsMapSeen, ClsMapSeen,
2925 IMPDecl, CDecl,
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002926 IncompleteImpl, true);
Fariborz Jahanian2bda1b62011-08-03 18:21:12 +00002927
Fariborz Jahanian9f8b19e2011-07-28 23:19:50 +00002928 // check all methods implemented in category against those declared
2929 // in its primary class.
2930 if (ObjCCategoryImplDecl *CatDecl =
2931 dyn_cast<ObjCCategoryImplDecl>(IMPDecl))
2932 CheckCategoryVsClassMethodMatches(CatDecl);
Mike Stump11289f42009-09-09 15:08:12 +00002933
Chris Lattnerda463fe2007-12-12 07:09:47 +00002934 // Check the protocol list for unimplemented methods in the @implementation
2935 // class.
Fariborz Jahanian07b71652009-05-01 20:07:12 +00002936 // Check and see if class methods in class interface have been
2937 // implemented in the implementation class.
Mike Stump11289f42009-09-09 15:08:12 +00002938
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00002939 LazyProtocolNameSet ExplicitImplProtocols;
2940
Chris Lattner9ef10f42009-03-01 00:56:52 +00002941 if (ObjCInterfaceDecl *I = dyn_cast<ObjCInterfaceDecl> (CDecl)) {
Aaron Ballmana9f49e32014-03-13 20:55:22 +00002942 for (auto *PI : I->all_referenced_protocols())
2943 CheckProtocolMethodDefs(*this, IMPDecl->getLocation(), PI, IncompleteImpl,
2944 InsMap, ClsMap, I, ExplicitImplProtocols);
Chris Lattner9ef10f42009-03-01 00:56:52 +00002945 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(CDecl)) {
Fariborz Jahanian8764c742009-10-05 21:32:49 +00002946 // For extended class, unimplemented methods in its protocols will
2947 // be reported in the primary class.
Fariborz Jahanian30a42922010-02-15 21:55:26 +00002948 if (!C->IsClassExtension()) {
Aaron Ballman19a41762014-03-14 12:55:57 +00002949 for (auto *P : C->protocols())
2950 CheckProtocolMethodDefs(*this, IMPDecl->getLocation(), P,
Ted Kremenek4b3c66e2014-03-05 08:13:08 +00002951 IncompleteImpl, InsMap, ClsMap, CDecl,
2952 ExplicitImplProtocols);
Ted Kremenek348e88c2014-02-21 19:41:34 +00002953 DiagnoseUnimplementedProperties(S, IMPDecl, CDecl,
Nico Weber2e0c8f72014-12-27 03:58:08 +00002954 /*SynthesizeProperties=*/false);
Fariborz Jahanian4f8a5712010-01-20 19:36:21 +00002955 }
Chris Lattner9ef10f42009-03-01 00:56:52 +00002956 } else
David Blaikie83d382b2011-09-23 05:06:16 +00002957 llvm_unreachable("invalid ObjCContainerDecl type.");
Chris Lattnerda463fe2007-12-12 07:09:47 +00002958}
2959
Fariborz Jahanian3a039e32011-08-27 20:50:59 +00002960Sema::DeclGroupPtrTy
Chris Lattnerda463fe2007-12-12 07:09:47 +00002961Sema::ActOnForwardClassDeclaration(SourceLocation AtClassLoc,
Chris Lattner99a83312009-02-16 19:25:52 +00002962 IdentifierInfo **IdentList,
Ted Kremeneka26da852009-11-17 23:12:20 +00002963 SourceLocation *IdentLocs,
Douglas Gregor85f3f952015-07-07 03:57:15 +00002964 ArrayRef<ObjCTypeParamList *> TypeParamLists,
Chris Lattner99a83312009-02-16 19:25:52 +00002965 unsigned NumElts) {
Fariborz Jahanian3a039e32011-08-27 20:50:59 +00002966 SmallVector<Decl *, 8> DeclsInGroup;
Chris Lattnerda463fe2007-12-12 07:09:47 +00002967 for (unsigned i = 0; i != NumElts; ++i) {
2968 // Check for another declaration kind with the same name.
John McCall9f3059a2009-10-09 21:13:30 +00002969 NamedDecl *PrevDecl
Douglas Gregorb2ccf012010-04-15 22:33:43 +00002970 = LookupSingleName(TUScope, IdentList[i], IdentLocs[i],
Douglas Gregorb8eaf292010-04-15 23:40:53 +00002971 LookupOrdinaryName, ForRedeclaration);
Ted Kremenek1b0ea822008-01-07 19:49:32 +00002972 if (PrevDecl && !isa<ObjCInterfaceDecl>(PrevDecl)) {
Steve Naroff946166f2008-06-05 22:57:10 +00002973 // GCC apparently allows the following idiom:
2974 //
2975 // typedef NSObject < XCElementTogglerP > XCElementToggler;
2976 // @class XCElementToggler;
2977 //
Fariborz Jahanian04c44552012-01-24 00:40:15 +00002978 // Here we have chosen to ignore the forward class declaration
2979 // with a warning. Since this is the implied behavior.
Richard Smithdda56e42011-04-15 14:24:37 +00002980 TypedefNameDecl *TDD = dyn_cast<TypedefNameDecl>(PrevDecl);
John McCall8b07ec22010-05-15 11:32:37 +00002981 if (!TDD || !TDD->getUnderlyingType()->isObjCObjectType()) {
Chris Lattner4bd8dd82008-11-19 08:23:25 +00002982 Diag(AtClassLoc, diag::err_redefinition_different_kind) << IdentList[i];
Chris Lattner0369c572008-11-23 23:12:31 +00002983 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
John McCall8b07ec22010-05-15 11:32:37 +00002984 } else {
Mike Stump12b8ce12009-08-04 21:02:39 +00002985 // a forward class declaration matching a typedef name of a class refers
Fariborz Jahanian04c44552012-01-24 00:40:15 +00002986 // to the underlying class. Just ignore the forward class with a warning
Nico Weber2e0c8f72014-12-27 03:58:08 +00002987 // as this will force the intended behavior which is to lookup the
2988 // typedef name.
Fariborz Jahanian04c44552012-01-24 00:40:15 +00002989 if (isa<ObjCObjectType>(TDD->getUnderlyingType())) {
Nico Weber2e0c8f72014-12-27 03:58:08 +00002990 Diag(AtClassLoc, diag::warn_forward_class_redefinition)
2991 << IdentList[i];
Fariborz Jahanian04c44552012-01-24 00:40:15 +00002992 Diag(PrevDecl->getLocation(), diag::note_previous_definition);
2993 continue;
2994 }
Fariborz Jahanian0d451812009-05-07 21:49:26 +00002995 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00002996 }
Douglas Gregordc9166c2011-12-15 20:29:51 +00002997
2998 // Create a declaration to describe this forward declaration.
Douglas Gregorab1ec82e2011-12-16 03:12:41 +00002999 ObjCInterfaceDecl *PrevIDecl
3000 = dyn_cast_or_null<ObjCInterfaceDecl>(PrevDecl);
Argyrios Kyrtzidisdd710632013-06-18 21:26:33 +00003001
3002 IdentifierInfo *ClassName = IdentList[i];
3003 if (PrevIDecl && PrevIDecl->getIdentifier() != ClassName) {
3004 // A previous decl with a different name is because of
3005 // @compatibility_alias, for example:
3006 // \code
3007 // @class NewImage;
3008 // @compatibility_alias OldImage NewImage;
3009 // \endcode
3010 // A lookup for 'OldImage' will return the 'NewImage' decl.
3011 //
3012 // In such a case use the real declaration name, instead of the alias one,
3013 // otherwise we will break IdentifierResolver and redecls-chain invariants.
3014 // FIXME: If necessary, add a bit to indicate that this ObjCInterfaceDecl
3015 // has been aliased.
3016 ClassName = PrevIDecl->getIdentifier();
3017 }
3018
Douglas Gregor85f3f952015-07-07 03:57:15 +00003019 // If this forward declaration has type parameters, compare them with the
3020 // type parameters of the previous declaration.
3021 ObjCTypeParamList *TypeParams = TypeParamLists[i];
3022 if (PrevIDecl && TypeParams) {
3023 if (ObjCTypeParamList *PrevTypeParams = PrevIDecl->getTypeParamList()) {
3024 // Check for consistency with the previous declaration.
3025 if (checkTypeParamListConsistency(
3026 *this, PrevTypeParams, TypeParams,
3027 TypeParamListContext::ForwardDeclaration)) {
3028 TypeParams = nullptr;
3029 }
3030 } else if (ObjCInterfaceDecl *Def = PrevIDecl->getDefinition()) {
3031 // The @interface does not have type parameters. Complain.
3032 Diag(IdentLocs[i], diag::err_objc_parameterized_forward_class)
3033 << ClassName
3034 << TypeParams->getSourceRange();
3035 Diag(Def->getLocation(), diag::note_defined_here)
3036 << ClassName;
3037
3038 TypeParams = nullptr;
3039 }
3040 }
3041
Douglas Gregordc9166c2011-12-15 20:29:51 +00003042 ObjCInterfaceDecl *IDecl
3043 = ObjCInterfaceDecl::Create(Context, CurContext, AtClassLoc,
Douglas Gregor85f3f952015-07-07 03:57:15 +00003044 ClassName, TypeParams, PrevIDecl,
3045 IdentLocs[i]);
Douglas Gregordc9166c2011-12-15 20:29:51 +00003046 IDecl->setAtEndRange(IdentLocs[i]);
Alex Lorenz9e7bf162017-04-18 14:33:39 +00003047
Douglas Gregordc9166c2011-12-15 20:29:51 +00003048 PushOnScopeChains(IDecl, TUScope);
Douglas Gregordeafd0b2011-12-27 22:43:10 +00003049 CheckObjCDeclScope(IDecl);
3050 DeclsInGroup.push_back(IDecl);
Chris Lattnerda463fe2007-12-12 07:09:47 +00003051 }
Rafael Espindolaab417692013-07-09 12:05:01 +00003052
Richard Smith3beb7c62017-01-12 02:27:38 +00003053 return BuildDeclaratorGroup(DeclsInGroup);
Chris Lattnerda463fe2007-12-12 07:09:47 +00003054}
3055
John McCall54507ab2011-06-16 01:15:19 +00003056static bool tryMatchRecordTypes(ASTContext &Context,
3057 Sema::MethodMatchStrategy strategy,
3058 const Type *left, const Type *right);
3059
John McCall31168b02011-06-15 23:02:42 +00003060static bool matchTypes(ASTContext &Context, Sema::MethodMatchStrategy strategy,
3061 QualType leftQT, QualType rightQT) {
3062 const Type *left =
3063 Context.getCanonicalType(leftQT).getUnqualifiedType().getTypePtr();
3064 const Type *right =
3065 Context.getCanonicalType(rightQT).getUnqualifiedType().getTypePtr();
3066
3067 if (left == right) return true;
3068
3069 // If we're doing a strict match, the types have to match exactly.
3070 if (strategy == Sema::MMS_strict) return false;
3071
3072 if (left->isIncompleteType() || right->isIncompleteType()) return false;
3073
3074 // Otherwise, use this absurdly complicated algorithm to try to
3075 // validate the basic, low-level compatibility of the two types.
3076
3077 // As a minimum, require the sizes and alignments to match.
David Majnemer34b57492014-07-30 01:30:47 +00003078 TypeInfo LeftTI = Context.getTypeInfo(left);
3079 TypeInfo RightTI = Context.getTypeInfo(right);
3080 if (LeftTI.Width != RightTI.Width)
3081 return false;
3082
3083 if (LeftTI.Align != RightTI.Align)
John McCall31168b02011-06-15 23:02:42 +00003084 return false;
3085
3086 // Consider all the kinds of non-dependent canonical types:
3087 // - functions and arrays aren't possible as return and parameter types
3088
3089 // - vector types of equal size can be arbitrarily mixed
3090 if (isa<VectorType>(left)) return isa<VectorType>(right);
3091 if (isa<VectorType>(right)) return false;
3092
3093 // - references should only match references of identical type
John McCall54507ab2011-06-16 01:15:19 +00003094 // - structs, unions, and Objective-C objects must match more-or-less
3095 // exactly
John McCall31168b02011-06-15 23:02:42 +00003096 // - everything else should be a scalar
3097 if (!left->isScalarType() || !right->isScalarType())
John McCall54507ab2011-06-16 01:15:19 +00003098 return tryMatchRecordTypes(Context, strategy, left, right);
John McCall31168b02011-06-15 23:02:42 +00003099
John McCall9320b872011-09-09 05:25:32 +00003100 // Make scalars agree in kind, except count bools as chars, and group
3101 // all non-member pointers together.
John McCall31168b02011-06-15 23:02:42 +00003102 Type::ScalarTypeKind leftSK = left->getScalarTypeKind();
3103 Type::ScalarTypeKind rightSK = right->getScalarTypeKind();
3104 if (leftSK == Type::STK_Bool) leftSK = Type::STK_Integral;
3105 if (rightSK == Type::STK_Bool) rightSK = Type::STK_Integral;
John McCall9320b872011-09-09 05:25:32 +00003106 if (leftSK == Type::STK_CPointer || leftSK == Type::STK_BlockPointer)
3107 leftSK = Type::STK_ObjCObjectPointer;
3108 if (rightSK == Type::STK_CPointer || rightSK == Type::STK_BlockPointer)
3109 rightSK = Type::STK_ObjCObjectPointer;
John McCall31168b02011-06-15 23:02:42 +00003110
3111 // Note that data member pointers and function member pointers don't
3112 // intermix because of the size differences.
3113
3114 return (leftSK == rightSK);
3115}
Chris Lattnerda463fe2007-12-12 07:09:47 +00003116
John McCall54507ab2011-06-16 01:15:19 +00003117static bool tryMatchRecordTypes(ASTContext &Context,
3118 Sema::MethodMatchStrategy strategy,
3119 const Type *lt, const Type *rt) {
3120 assert(lt && rt && lt != rt);
3121
3122 if (!isa<RecordType>(lt) || !isa<RecordType>(rt)) return false;
3123 RecordDecl *left = cast<RecordType>(lt)->getDecl();
3124 RecordDecl *right = cast<RecordType>(rt)->getDecl();
3125
3126 // Require union-hood to match.
3127 if (left->isUnion() != right->isUnion()) return false;
3128
3129 // Require an exact match if either is non-POD.
3130 if ((isa<CXXRecordDecl>(left) && !cast<CXXRecordDecl>(left)->isPOD()) ||
3131 (isa<CXXRecordDecl>(right) && !cast<CXXRecordDecl>(right)->isPOD()))
3132 return false;
3133
3134 // Require size and alignment to match.
David Majnemer34b57492014-07-30 01:30:47 +00003135 TypeInfo LeftTI = Context.getTypeInfo(lt);
3136 TypeInfo RightTI = Context.getTypeInfo(rt);
3137 if (LeftTI.Width != RightTI.Width)
3138 return false;
3139
3140 if (LeftTI.Align != RightTI.Align)
3141 return false;
John McCall54507ab2011-06-16 01:15:19 +00003142
3143 // Require fields to match.
3144 RecordDecl::field_iterator li = left->field_begin(), le = left->field_end();
3145 RecordDecl::field_iterator ri = right->field_begin(), re = right->field_end();
3146 for (; li != le && ri != re; ++li, ++ri) {
3147 if (!matchTypes(Context, strategy, li->getType(), ri->getType()))
3148 return false;
3149 }
3150 return (li == le && ri == re);
3151}
3152
Chris Lattnerda463fe2007-12-12 07:09:47 +00003153/// MatchTwoMethodDeclarations - Checks that two methods have matching type and
3154/// returns true, or false, accordingly.
3155/// TODO: Handle protocol list; such as id<p1,p2> in type comparisons
John McCall31168b02011-06-15 23:02:42 +00003156bool Sema::MatchTwoMethodDeclarations(const ObjCMethodDecl *left,
3157 const ObjCMethodDecl *right,
3158 MethodMatchStrategy strategy) {
Alp Toker314cc812014-01-25 16:55:45 +00003159 if (!matchTypes(Context, strategy, left->getReturnType(),
3160 right->getReturnType()))
John McCall31168b02011-06-15 23:02:42 +00003161 return false;
Mike Stump11289f42009-09-09 15:08:12 +00003162
Douglas Gregor560b7fa2013-02-07 19:13:24 +00003163 // If either is hidden, it is not considered to match.
3164 if (left->isHidden() || right->isHidden())
3165 return false;
3166
David Blaikiebbafb8a2012-03-11 07:00:24 +00003167 if (getLangOpts().ObjCAutoRefCount &&
John McCall31168b02011-06-15 23:02:42 +00003168 (left->hasAttr<NSReturnsRetainedAttr>()
3169 != right->hasAttr<NSReturnsRetainedAttr>() ||
3170 left->hasAttr<NSConsumesSelfAttr>()
3171 != right->hasAttr<NSConsumesSelfAttr>()))
3172 return false;
Mike Stump11289f42009-09-09 15:08:12 +00003173
Argyrios Kyrtzidisb8c3aaf2011-10-03 06:37:04 +00003174 ObjCMethodDecl::param_const_iterator
Douglas Gregor0bf70f42012-05-17 23:13:29 +00003175 li = left->param_begin(), le = left->param_end(), ri = right->param_begin(),
3176 re = right->param_end();
Mike Stump11289f42009-09-09 15:08:12 +00003177
Douglas Gregor0bf70f42012-05-17 23:13:29 +00003178 for (; li != le && ri != re; ++li, ++ri) {
John McCall31168b02011-06-15 23:02:42 +00003179 assert(ri != right->param_end() && "Param mismatch");
Argyrios Kyrtzidisb8c3aaf2011-10-03 06:37:04 +00003180 const ParmVarDecl *lparm = *li, *rparm = *ri;
John McCall31168b02011-06-15 23:02:42 +00003181
3182 if (!matchTypes(Context, strategy, lparm->getType(), rparm->getType()))
3183 return false;
3184
David Blaikiebbafb8a2012-03-11 07:00:24 +00003185 if (getLangOpts().ObjCAutoRefCount &&
John McCall31168b02011-06-15 23:02:42 +00003186 lparm->hasAttr<NSConsumedAttr>() != rparm->hasAttr<NSConsumedAttr>())
3187 return false;
Chris Lattnerda463fe2007-12-12 07:09:47 +00003188 }
3189 return true;
3190}
3191
Manman Ren71224532016-04-09 18:59:48 +00003192static bool isMethodContextSameForKindofLookup(ObjCMethodDecl *Method,
3193 ObjCMethodDecl *MethodInList) {
3194 auto *MethodProtocol = dyn_cast<ObjCProtocolDecl>(Method->getDeclContext());
3195 auto *MethodInListProtocol =
3196 dyn_cast<ObjCProtocolDecl>(MethodInList->getDeclContext());
3197 // If this method belongs to a protocol but the method in list does not, or
3198 // vice versa, we say the context is not the same.
3199 if ((MethodProtocol && !MethodInListProtocol) ||
3200 (!MethodProtocol && MethodInListProtocol))
3201 return false;
3202
3203 if (MethodProtocol && MethodInListProtocol)
3204 return true;
3205
3206 ObjCInterfaceDecl *MethodInterface = Method->getClassInterface();
3207 ObjCInterfaceDecl *MethodInListInterface =
3208 MethodInList->getClassInterface();
3209 return MethodInterface == MethodInListInterface;
3210}
3211
Nico Weber2e0c8f72014-12-27 03:58:08 +00003212void Sema::addMethodToGlobalList(ObjCMethodList *List,
3213 ObjCMethodDecl *Method) {
Argyrios Kyrtzidisd3da6e02013-04-17 00:08:58 +00003214 // Record at the head of the list whether there were 0, 1, or >= 2 methods
3215 // inside categories.
Nico Weber2e0c8f72014-12-27 03:58:08 +00003216 if (ObjCCategoryDecl *CD =
3217 dyn_cast<ObjCCategoryDecl>(Method->getDeclContext()))
Argyrios Kyrtzidis04703a62013-04-27 00:10:12 +00003218 if (!CD->IsClassExtension() && List->getBits() < 2)
Nico Weber2e0c8f72014-12-27 03:58:08 +00003219 List->setBits(List->getBits() + 1);
Argyrios Kyrtzidisd3da6e02013-04-17 00:08:58 +00003220
Douglas Gregorc454afe2012-01-25 00:19:56 +00003221 // If the list is empty, make it a singleton list.
Nico Weber2e0c8f72014-12-27 03:58:08 +00003222 if (List->getMethod() == nullptr) {
3223 List->setMethod(Method);
Craig Topperc3ec1492014-05-26 06:22:03 +00003224 List->setNext(nullptr);
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00003225 return;
Douglas Gregorc454afe2012-01-25 00:19:56 +00003226 }
Nico Weber2e0c8f72014-12-27 03:58:08 +00003227
Douglas Gregorc454afe2012-01-25 00:19:56 +00003228 // We've seen a method with this name, see if we have already seen this type
3229 // signature.
3230 ObjCMethodList *Previous = List;
Manman Ren051d0b62016-04-13 23:43:56 +00003231 ObjCMethodList *ListWithSameDeclaration = nullptr;
Argyrios Kyrtzidisd3da6e02013-04-17 00:08:58 +00003232 for (; List; Previous = List, List = List->getNext()) {
Douglas Gregor600a2f52013-06-21 00:20:25 +00003233 // If we are building a module, keep all of the methods.
Richard Smithbbcc9f02016-08-26 00:14:38 +00003234 if (getLangOpts().isCompilingModule())
Douglas Gregor600a2f52013-06-21 00:20:25 +00003235 continue;
3236
Manman Ren051d0b62016-04-13 23:43:56 +00003237 bool SameDeclaration = MatchTwoMethodDeclarations(Method,
3238 List->getMethod());
Manman Ren71224532016-04-09 18:59:48 +00003239 // Looking for method with a type bound requires the correct context exists.
Manman Ren051d0b62016-04-13 23:43:56 +00003240 // We need to insert a method into the list if the context is different.
3241 // If the method's declaration matches the list
3242 // a> the method belongs to a different context: we need to insert it, in
3243 // order to emit the availability message, we need to prioritize over
3244 // availability among the methods with the same declaration.
3245 // b> the method belongs to the same context: there is no need to insert a
3246 // new entry.
3247 // If the method's declaration does not match the list, we insert it to the
3248 // end.
3249 if (!SameDeclaration ||
Manman Ren71224532016-04-09 18:59:48 +00003250 !isMethodContextSameForKindofLookup(Method, List->getMethod())) {
Fariborz Jahaniand436b2a2015-04-07 16:56:27 +00003251 // Even if two method types do not match, we would like to say
3252 // there is more than one declaration so unavailability/deprecated
3253 // warning is not too noisy.
3254 if (!Method->isDefined())
3255 List->setHasMoreThanOneDecl(true);
Manman Ren051d0b62016-04-13 23:43:56 +00003256
3257 // For methods with the same declaration, the one that is deprecated
3258 // should be put in the front for better diagnostics.
3259 if (Method->isDeprecated() && SameDeclaration &&
3260 !ListWithSameDeclaration && !List->getMethod()->isDeprecated())
3261 ListWithSameDeclaration = List;
3262
3263 if (Method->isUnavailable() && SameDeclaration &&
3264 !ListWithSameDeclaration &&
3265 List->getMethod()->getAvailability() < AR_Deprecated)
3266 ListWithSameDeclaration = List;
Douglas Gregorc454afe2012-01-25 00:19:56 +00003267 continue;
Fariborz Jahaniand436b2a2015-04-07 16:56:27 +00003268 }
Nico Weber2e0c8f72014-12-27 03:58:08 +00003269
3270 ObjCMethodDecl *PrevObjCMethod = List->getMethod();
Douglas Gregorc454afe2012-01-25 00:19:56 +00003271
3272 // Propagate the 'defined' bit.
3273 if (Method->isDefined())
3274 PrevObjCMethod->setDefined(true);
Nico Webere3b11042014-12-27 07:09:37 +00003275 else {
Nico Weber2e0c8f72014-12-27 03:58:08 +00003276 // Objective-C doesn't allow an @interface for a class after its
3277 // @implementation. So if Method is not defined and there already is
3278 // an entry for this type signature, Method has to be for a different
3279 // class than PrevObjCMethod.
3280 List->setHasMoreThanOneDecl(true);
3281 }
3282
Douglas Gregorc454afe2012-01-25 00:19:56 +00003283 // If a method is deprecated, push it in the global pool.
3284 // This is used for better diagnostics.
3285 if (Method->isDeprecated()) {
3286 if (!PrevObjCMethod->isDeprecated())
Nico Weber2e0c8f72014-12-27 03:58:08 +00003287 List->setMethod(Method);
Douglas Gregorc454afe2012-01-25 00:19:56 +00003288 }
Nico Weber2e0c8f72014-12-27 03:58:08 +00003289 // If the new method is unavailable, push it into global pool
Douglas Gregorc454afe2012-01-25 00:19:56 +00003290 // unless previous one is deprecated.
3291 if (Method->isUnavailable()) {
3292 if (PrevObjCMethod->getAvailability() < AR_Deprecated)
Nico Weber2e0c8f72014-12-27 03:58:08 +00003293 List->setMethod(Method);
Douglas Gregorc454afe2012-01-25 00:19:56 +00003294 }
Nico Weber2e0c8f72014-12-27 03:58:08 +00003295
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00003296 return;
Douglas Gregorc454afe2012-01-25 00:19:56 +00003297 }
Nico Weber2e0c8f72014-12-27 03:58:08 +00003298
Douglas Gregorc454afe2012-01-25 00:19:56 +00003299 // We have a new signature for an existing method - add it.
3300 // This is extremely rare. Only 1% of Cocoa selectors are "overloaded".
Douglas Gregore1716012012-01-25 00:49:42 +00003301 ObjCMethodList *Mem = BumpAlloc.Allocate<ObjCMethodList>();
Manman Ren71224532016-04-09 18:59:48 +00003302
Manman Ren051d0b62016-04-13 23:43:56 +00003303 // We insert it right before ListWithSameDeclaration.
3304 if (ListWithSameDeclaration) {
3305 auto *List = new (Mem) ObjCMethodList(*ListWithSameDeclaration);
3306 // FIXME: should we clear the other bits in ListWithSameDeclaration?
3307 ListWithSameDeclaration->setMethod(Method);
3308 ListWithSameDeclaration->setNext(List);
Manman Ren71224532016-04-09 18:59:48 +00003309 return;
3310 }
3311
Nico Weber2e0c8f72014-12-27 03:58:08 +00003312 Previous->setNext(new (Mem) ObjCMethodList(Method));
Douglas Gregorc454afe2012-01-25 00:19:56 +00003313}
3314
Sebastian Redl75d8a322010-08-02 23:18:59 +00003315/// \brief Read the contents of the method pool for a given selector from
3316/// external storage.
Douglas Gregore1716012012-01-25 00:49:42 +00003317void Sema::ReadMethodPool(Selector Sel) {
Douglas Gregorc78d3462009-04-24 21:10:55 +00003318 assert(ExternalSource && "We need an external AST source");
Douglas Gregore1716012012-01-25 00:49:42 +00003319 ExternalSource->ReadMethodPool(Sel);
Douglas Gregorc78d3462009-04-24 21:10:55 +00003320}
3321
Manman Rena0f31a02016-04-29 19:04:05 +00003322void Sema::updateOutOfDateSelector(Selector Sel) {
3323 if (!ExternalSource)
3324 return;
3325 ExternalSource->updateOutOfDateSelector(Sel);
3326}
3327
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00003328void Sema::AddMethodToGlobalPool(ObjCMethodDecl *Method, bool impl,
Sebastian Redl75d8a322010-08-02 23:18:59 +00003329 bool instance) {
Argyrios Kyrtzidisb15def22012-03-12 18:34:26 +00003330 // Ignore methods of invalid containers.
3331 if (cast<Decl>(Method->getDeclContext())->isInvalidDecl())
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00003332 return;
Argyrios Kyrtzidisb15def22012-03-12 18:34:26 +00003333
Douglas Gregor70f449b2012-01-25 00:59:09 +00003334 if (ExternalSource)
3335 ReadMethodPool(Method->getSelector());
3336
Sebastian Redl75d8a322010-08-02 23:18:59 +00003337 GlobalMethodPool::iterator Pos = MethodPool.find(Method->getSelector());
Douglas Gregor70f449b2012-01-25 00:59:09 +00003338 if (Pos == MethodPool.end())
3339 Pos = MethodPool.insert(std::make_pair(Method->getSelector(),
3340 GlobalMethods())).first;
Nico Weber2e0c8f72014-12-27 03:58:08 +00003341
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00003342 Method->setDefined(impl);
Douglas Gregorc454afe2012-01-25 00:19:56 +00003343
Sebastian Redl75d8a322010-08-02 23:18:59 +00003344 ObjCMethodList &Entry = instance ? Pos->second.first : Pos->second.second;
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00003345 addMethodToGlobalList(&Entry, Method);
Chris Lattnerda463fe2007-12-12 07:09:47 +00003346}
3347
John McCall31168b02011-06-15 23:02:42 +00003348/// Determines if this is an "acceptable" loose mismatch in the global
3349/// method pool. This exists mostly as a hack to get around certain
3350/// global mismatches which we can't afford to make warnings / errors.
3351/// Really, what we want is a way to take a method out of the global
3352/// method pool.
3353static bool isAcceptableMethodMismatch(ObjCMethodDecl *chosen,
3354 ObjCMethodDecl *other) {
3355 if (!chosen->isInstanceMethod())
3356 return false;
3357
3358 Selector sel = chosen->getSelector();
3359 if (!sel.isUnarySelector() || sel.getNameForSlot(0) != "length")
3360 return false;
3361
3362 // Don't complain about mismatches for -length if the method we
3363 // chose has an integral result type.
Alp Toker314cc812014-01-25 16:55:45 +00003364 return (chosen->getReturnType()->isIntegerType());
John McCall31168b02011-06-15 23:02:42 +00003365}
3366
Manman Ren7ed4f982016-04-07 19:32:24 +00003367/// Return true if the given method is wthin the type bound.
3368static bool FilterMethodsByTypeBound(ObjCMethodDecl *Method,
3369 const ObjCObjectType *TypeBound) {
3370 if (!TypeBound)
3371 return true;
3372
3373 if (TypeBound->isObjCId())
3374 // FIXME: should we handle the case of bounding to id<A, B> differently?
3375 return true;
3376
3377 auto *BoundInterface = TypeBound->getInterface();
3378 assert(BoundInterface && "unexpected object type!");
3379
3380 // Check if the Method belongs to a protocol. We should allow any method
3381 // defined in any protocol, because any subclass could adopt the protocol.
3382 auto *MethodProtocol = dyn_cast<ObjCProtocolDecl>(Method->getDeclContext());
3383 if (MethodProtocol) {
3384 return true;
3385 }
3386
3387 // If the Method belongs to a class, check if it belongs to the class
3388 // hierarchy of the class bound.
3389 if (ObjCInterfaceDecl *MethodInterface = Method->getClassInterface()) {
3390 // We allow methods declared within classes that are part of the hierarchy
3391 // of the class bound (superclass of, subclass of, or the same as the class
3392 // bound).
3393 return MethodInterface == BoundInterface ||
3394 MethodInterface->isSuperClassOf(BoundInterface) ||
3395 BoundInterface->isSuperClassOf(MethodInterface);
3396 }
3397 llvm_unreachable("unknow method context");
3398}
3399
Manman Rend2a3cd72016-04-07 19:30:20 +00003400/// We first select the type of the method: Instance or Factory, then collect
3401/// all methods with that type.
Nico Weber2e0c8f72014-12-27 03:58:08 +00003402bool Sema::CollectMultipleMethodsInGlobalPool(
Manman Rend2a3cd72016-04-07 19:30:20 +00003403 Selector Sel, SmallVectorImpl<ObjCMethodDecl *> &Methods,
Manman Ren7ed4f982016-04-07 19:32:24 +00003404 bool InstanceFirst, bool CheckTheOther,
3405 const ObjCObjectType *TypeBound) {
Fariborz Jahanian30ae8d42014-08-13 21:07:35 +00003406 if (ExternalSource)
3407 ReadMethodPool(Sel);
3408
3409 GlobalMethodPool::iterator Pos = MethodPool.find(Sel);
3410 if (Pos == MethodPool.end())
3411 return false;
Manman Rend2a3cd72016-04-07 19:30:20 +00003412
Fariborz Jahanian30ae8d42014-08-13 21:07:35 +00003413 // Gather the non-hidden methods.
Manman Rend2a3cd72016-04-07 19:30:20 +00003414 ObjCMethodList &MethList = InstanceFirst ? Pos->second.first :
3415 Pos->second.second;
Fariborz Jahanian30ae8d42014-08-13 21:07:35 +00003416 for (ObjCMethodList *M = &MethList; M; M = M->getNext())
Manman Ren7ed4f982016-04-07 19:32:24 +00003417 if (M->getMethod() && !M->getMethod()->isHidden()) {
3418 if (FilterMethodsByTypeBound(M->getMethod(), TypeBound))
3419 Methods.push_back(M->getMethod());
3420 }
Manman Rend2a3cd72016-04-07 19:30:20 +00003421
3422 // Return if we find any method with the desired kind.
3423 if (!Methods.empty())
3424 return Methods.size() > 1;
3425
3426 if (!CheckTheOther)
3427 return false;
3428
3429 // Gather the other kind.
3430 ObjCMethodList &MethList2 = InstanceFirst ? Pos->second.second :
3431 Pos->second.first;
3432 for (ObjCMethodList *M = &MethList2; M; M = M->getNext())
Manman Ren7ed4f982016-04-07 19:32:24 +00003433 if (M->getMethod() && !M->getMethod()->isHidden()) {
3434 if (FilterMethodsByTypeBound(M->getMethod(), TypeBound))
3435 Methods.push_back(M->getMethod());
3436 }
Manman Rend2a3cd72016-04-07 19:30:20 +00003437
Nico Weber2e0c8f72014-12-27 03:58:08 +00003438 return Methods.size() > 1;
Fariborz Jahanian30ae8d42014-08-13 21:07:35 +00003439}
3440
Manman Rend2a3cd72016-04-07 19:30:20 +00003441bool Sema::AreMultipleMethodsInGlobalPool(
3442 Selector Sel, ObjCMethodDecl *BestMethod, SourceRange R,
3443 bool receiverIdOrClass, SmallVectorImpl<ObjCMethodDecl *> &Methods) {
3444 // Diagnose finding more than one method in global pool.
3445 SmallVector<ObjCMethodDecl *, 4> FilteredMethods;
3446 FilteredMethods.push_back(BestMethod);
3447
3448 for (auto *M : Methods)
3449 if (M != BestMethod && !M->hasAttr<UnavailableAttr>())
3450 FilteredMethods.push_back(M);
3451
3452 if (FilteredMethods.size() > 1)
3453 DiagnoseMultipleMethodInGlobalPool(FilteredMethods, Sel, R,
3454 receiverIdOrClass);
3455
Fariborz Jahanianc62d16f2014-11-13 22:27:05 +00003456 GlobalMethodPool::iterator Pos = MethodPool.find(Sel);
Nico Weber2e0c8f72014-12-27 03:58:08 +00003457 // Test for no method in the pool which should not trigger any warning by
3458 // caller.
Fariborz Jahanianc62d16f2014-11-13 22:27:05 +00003459 if (Pos == MethodPool.end())
3460 return true;
Fariborz Jahanian890803f2015-04-15 17:26:21 +00003461 ObjCMethodList &MethList =
3462 BestMethod->isInstanceMethod() ? Pos->second.first : Pos->second.second;
Nico Weber2e0c8f72014-12-27 03:58:08 +00003463 return MethList.hasMoreThanOneDecl();
Fariborz Jahanianc62d16f2014-11-13 22:27:05 +00003464}
3465
Sebastian Redl75d8a322010-08-02 23:18:59 +00003466ObjCMethodDecl *Sema::LookupMethodInGlobalPool(Selector Sel, SourceRange R,
Fariborz Jahanian3337b2e2010-08-09 23:27:58 +00003467 bool receiverIdOrClass,
Fariborz Jahanian890803f2015-04-15 17:26:21 +00003468 bool instance) {
Douglas Gregor70f449b2012-01-25 00:59:09 +00003469 if (ExternalSource)
3470 ReadMethodPool(Sel);
3471
Sebastian Redl75d8a322010-08-02 23:18:59 +00003472 GlobalMethodPool::iterator Pos = MethodPool.find(Sel);
Douglas Gregor70f449b2012-01-25 00:59:09 +00003473 if (Pos == MethodPool.end())
Craig Topperc3ec1492014-05-26 06:22:03 +00003474 return nullptr;
Douglas Gregorc78d3462009-04-24 21:10:55 +00003475
Douglas Gregor77f49a42013-01-16 18:47:38 +00003476 // Gather the non-hidden methods.
Sebastian Redl75d8a322010-08-02 23:18:59 +00003477 ObjCMethodList &MethList = instance ? Pos->second.first : Pos->second.second;
Robert Wilhelmb869a8f2013-08-10 12:33:24 +00003478 SmallVector<ObjCMethodDecl *, 4> Methods;
Argyrios Kyrtzidisd3da6e02013-04-17 00:08:58 +00003479 for (ObjCMethodList *M = &MethList; M; M = M->getNext()) {
Fariborz Jahanian890803f2015-04-15 17:26:21 +00003480 if (M->getMethod() && !M->getMethod()->isHidden())
3481 return M->getMethod();
Douglas Gregorc78d3462009-04-24 21:10:55 +00003482 }
Fariborz Jahanian890803f2015-04-15 17:26:21 +00003483 return nullptr;
3484}
Douglas Gregor77f49a42013-01-16 18:47:38 +00003485
Fariborz Jahanian890803f2015-04-15 17:26:21 +00003486void Sema::DiagnoseMultipleMethodInGlobalPool(SmallVectorImpl<ObjCMethodDecl*> &Methods,
3487 Selector Sel, SourceRange R,
3488 bool receiverIdOrClass) {
Douglas Gregor77f49a42013-01-16 18:47:38 +00003489 // We found multiple methods, so we may have to complain.
3490 bool issueDiagnostic = false, issueError = false;
Jonathan Roelofs74411362015-04-28 18:04:44 +00003491
Douglas Gregor77f49a42013-01-16 18:47:38 +00003492 // We support a warning which complains about *any* difference in
3493 // method signature.
3494 bool strictSelectorMatch =
Fariborz Jahanian890803f2015-04-15 17:26:21 +00003495 receiverIdOrClass &&
3496 !Diags.isIgnored(diag::warn_strict_multiple_method_decl, R.getBegin());
Douglas Gregor77f49a42013-01-16 18:47:38 +00003497 if (strictSelectorMatch) {
3498 for (unsigned I = 1, N = Methods.size(); I != N; ++I) {
3499 if (!MatchTwoMethodDeclarations(Methods[0], Methods[I], MMS_strict)) {
3500 issueDiagnostic = true;
3501 break;
3502 }
3503 }
3504 }
Jonathan Roelofs74411362015-04-28 18:04:44 +00003505
Douglas Gregor77f49a42013-01-16 18:47:38 +00003506 // If we didn't see any strict differences, we won't see any loose
3507 // differences. In ARC, however, we also need to check for loose
3508 // mismatches, because most of them are errors.
3509 if (!strictSelectorMatch ||
3510 (issueDiagnostic && getLangOpts().ObjCAutoRefCount))
3511 for (unsigned I = 1, N = Methods.size(); I != N; ++I) {
3512 // This checks if the methods differ in type mismatch.
3513 if (!MatchTwoMethodDeclarations(Methods[0], Methods[I], MMS_loose) &&
3514 !isAcceptableMethodMismatch(Methods[0], Methods[I])) {
3515 issueDiagnostic = true;
3516 if (getLangOpts().ObjCAutoRefCount)
3517 issueError = true;
3518 break;
3519 }
3520 }
Fariborz Jahanian890803f2015-04-15 17:26:21 +00003521
Douglas Gregor77f49a42013-01-16 18:47:38 +00003522 if (issueDiagnostic) {
3523 if (issueError)
3524 Diag(R.getBegin(), diag::err_arc_multiple_method_decl) << Sel << R;
3525 else if (strictSelectorMatch)
3526 Diag(R.getBegin(), diag::warn_strict_multiple_method_decl) << Sel << R;
3527 else
3528 Diag(R.getBegin(), diag::warn_multiple_method_decl) << Sel << R;
Fariborz Jahanian890803f2015-04-15 17:26:21 +00003529
Douglas Gregor77f49a42013-01-16 18:47:38 +00003530 Diag(Methods[0]->getLocStart(),
3531 issueError ? diag::note_possibility : diag::note_using)
Fariborz Jahanian890803f2015-04-15 17:26:21 +00003532 << Methods[0]->getSourceRange();
Douglas Gregor77f49a42013-01-16 18:47:38 +00003533 for (unsigned I = 1, N = Methods.size(); I != N; ++I) {
3534 Diag(Methods[I]->getLocStart(), diag::note_also_found)
Fariborz Jahanian890803f2015-04-15 17:26:21 +00003535 << Methods[I]->getSourceRange();
3536 }
Douglas Gregor77f49a42013-01-16 18:47:38 +00003537 }
Douglas Gregorc78d3462009-04-24 21:10:55 +00003538}
3539
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00003540ObjCMethodDecl *Sema::LookupImplementedMethodInGlobalPool(Selector Sel) {
Sebastian Redl75d8a322010-08-02 23:18:59 +00003541 GlobalMethodPool::iterator Pos = MethodPool.find(Sel);
3542 if (Pos == MethodPool.end())
Craig Topperc3ec1492014-05-26 06:22:03 +00003543 return nullptr;
Sebastian Redl75d8a322010-08-02 23:18:59 +00003544
3545 GlobalMethods &Methods = Pos->second;
Fariborz Jahanianec762bd2014-03-26 20:59:26 +00003546 for (const ObjCMethodList *Method = &Methods.first; Method;
3547 Method = Method->getNext())
Fariborz Jahanian4019c7f2015-02-19 21:52:41 +00003548 if (Method->getMethod() &&
3549 (Method->getMethod()->isDefined() ||
3550 Method->getMethod()->isPropertyAccessor()))
Nico Weber2e0c8f72014-12-27 03:58:08 +00003551 return Method->getMethod();
Fariborz Jahanianec762bd2014-03-26 20:59:26 +00003552
3553 for (const ObjCMethodList *Method = &Methods.second; Method;
3554 Method = Method->getNext())
Fariborz Jahanian4019c7f2015-02-19 21:52:41 +00003555 if (Method->getMethod() &&
3556 (Method->getMethod()->isDefined() ||
3557 Method->getMethod()->isPropertyAccessor()))
Nico Weber2e0c8f72014-12-27 03:58:08 +00003558 return Method->getMethod();
Craig Topperc3ec1492014-05-26 06:22:03 +00003559 return nullptr;
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00003560}
3561
Fariborz Jahanian42f89382013-05-30 21:48:58 +00003562static void
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00003563HelperSelectorsForTypoCorrection(
3564 SmallVectorImpl<const ObjCMethodDecl *> &BestMethod,
3565 StringRef Typo, const ObjCMethodDecl * Method) {
3566 const unsigned MaxEditDistance = 1;
3567 unsigned BestEditDistance = MaxEditDistance + 1;
Richard Trieuea8d3702013-06-06 02:22:29 +00003568 std::string MethodName = Method->getSelector().getAsString();
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00003569
3570 unsigned MinPossibleEditDistance = abs((int)MethodName.size() - (int)Typo.size());
3571 if (MinPossibleEditDistance > 0 &&
3572 Typo.size() / MinPossibleEditDistance < 1)
3573 return;
3574 unsigned EditDistance = Typo.edit_distance(MethodName, true, MaxEditDistance);
3575 if (EditDistance > MaxEditDistance)
3576 return;
3577 if (EditDistance == BestEditDistance)
3578 BestMethod.push_back(Method);
3579 else if (EditDistance < BestEditDistance) {
3580 BestMethod.clear();
3581 BestMethod.push_back(Method);
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00003582 }
3583}
3584
Fariborz Jahanian75481672013-06-17 17:10:54 +00003585static bool HelperIsMethodInObjCType(Sema &S, Selector Sel,
3586 QualType ObjectType) {
3587 if (ObjectType.isNull())
3588 return true;
3589 if (S.LookupMethodInObjectType(Sel, ObjectType, true/*Instance method*/))
3590 return true;
Craig Topperc3ec1492014-05-26 06:22:03 +00003591 return S.LookupMethodInObjectType(Sel, ObjectType, false/*Class method*/) !=
3592 nullptr;
Fariborz Jahanian75481672013-06-17 17:10:54 +00003593}
3594
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00003595const ObjCMethodDecl *
Fariborz Jahanian75481672013-06-17 17:10:54 +00003596Sema::SelectorsForTypoCorrection(Selector Sel,
3597 QualType ObjectType) {
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00003598 unsigned NumArgs = Sel.getNumArgs();
3599 SmallVector<const ObjCMethodDecl *, 8> Methods;
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00003600 bool ObjectIsId = true, ObjectIsClass = true;
3601 if (ObjectType.isNull())
3602 ObjectIsId = ObjectIsClass = false;
3603 else if (!ObjectType->isObjCObjectPointerType())
Craig Topperc3ec1492014-05-26 06:22:03 +00003604 return nullptr;
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00003605 else if (const ObjCObjectPointerType *ObjCPtr =
3606 ObjectType->getAsObjCInterfacePointerType()) {
3607 ObjectType = QualType(ObjCPtr->getInterfaceType(), 0);
3608 ObjectIsId = ObjectIsClass = false;
3609 }
3610 else if (ObjectType->isObjCIdType() || ObjectType->isObjCQualifiedIdType())
3611 ObjectIsClass = false;
3612 else if (ObjectType->isObjCClassType() || ObjectType->isObjCQualifiedClassType())
3613 ObjectIsId = false;
3614 else
Craig Topperc3ec1492014-05-26 06:22:03 +00003615 return nullptr;
3616
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00003617 for (GlobalMethodPool::iterator b = MethodPool.begin(),
3618 e = MethodPool.end(); b != e; b++) {
3619 // instance methods
3620 for (ObjCMethodList *M = &b->second.first; M; M=M->getNext())
Nico Weber2e0c8f72014-12-27 03:58:08 +00003621 if (M->getMethod() &&
3622 (M->getMethod()->getSelector().getNumArgs() == NumArgs) &&
3623 (M->getMethod()->getSelector() != Sel)) {
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00003624 if (ObjectIsId)
Nico Weber2e0c8f72014-12-27 03:58:08 +00003625 Methods.push_back(M->getMethod());
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00003626 else if (!ObjectIsClass &&
Nico Weber2e0c8f72014-12-27 03:58:08 +00003627 HelperIsMethodInObjCType(*this, M->getMethod()->getSelector(),
3628 ObjectType))
3629 Methods.push_back(M->getMethod());
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00003630 }
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00003631 // class methods
3632 for (ObjCMethodList *M = &b->second.second; M; M=M->getNext())
Nico Weber2e0c8f72014-12-27 03:58:08 +00003633 if (M->getMethod() &&
3634 (M->getMethod()->getSelector().getNumArgs() == NumArgs) &&
3635 (M->getMethod()->getSelector() != Sel)) {
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00003636 if (ObjectIsClass)
Nico Weber2e0c8f72014-12-27 03:58:08 +00003637 Methods.push_back(M->getMethod());
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00003638 else if (!ObjectIsId &&
Nico Weber2e0c8f72014-12-27 03:58:08 +00003639 HelperIsMethodInObjCType(*this, M->getMethod()->getSelector(),
3640 ObjectType))
3641 Methods.push_back(M->getMethod());
Fariborz Jahanian4cc55522013-06-18 15:31:36 +00003642 }
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00003643 }
3644
3645 SmallVector<const ObjCMethodDecl *, 8> SelectedMethods;
3646 for (unsigned i = 0, e = Methods.size(); i < e; i++) {
3647 HelperSelectorsForTypoCorrection(SelectedMethods,
3648 Sel.getAsString(), Methods[i]);
3649 }
Craig Topperc3ec1492014-05-26 06:22:03 +00003650 return (SelectedMethods.size() == 1) ? SelectedMethods[0] : nullptr;
Fariborz Jahanian0c0fc9e2013-06-05 18:46:14 +00003651}
3652
Fariborz Jahanian42f89382013-05-30 21:48:58 +00003653/// DiagnoseDuplicateIvars -
Fariborz Jahanian545643c2010-02-23 23:41:11 +00003654/// Check for duplicate ivars in the entire class at the start of
James Dennett634962f2012-06-14 21:40:34 +00003655/// \@implementation. This becomes necesssary because class extension can
Fariborz Jahanian545643c2010-02-23 23:41:11 +00003656/// add ivars to a class in random order which will not be known until
James Dennett634962f2012-06-14 21:40:34 +00003657/// class's \@implementation is seen.
Fariborz Jahanian545643c2010-02-23 23:41:11 +00003658void Sema::DiagnoseDuplicateIvars(ObjCInterfaceDecl *ID,
3659 ObjCInterfaceDecl *SID) {
Aaron Ballman59abbd42014-03-13 21:09:43 +00003660 for (auto *Ivar : ID->ivars()) {
Fariborz Jahanian545643c2010-02-23 23:41:11 +00003661 if (Ivar->isInvalidDecl())
3662 continue;
3663 if (IdentifierInfo *II = Ivar->getIdentifier()) {
3664 ObjCIvarDecl* prevIvar = SID->lookupInstanceVariable(II);
3665 if (prevIvar) {
3666 Diag(Ivar->getLocation(), diag::err_duplicate_member) << II;
3667 Diag(prevIvar->getLocation(), diag::note_previous_declaration);
3668 Ivar->setInvalidDecl();
3669 }
3670 }
3671 }
3672}
3673
John McCallb61e14e2015-10-27 04:54:50 +00003674/// Diagnose attempts to define ARC-__weak ivars when __weak is disabled.
3675static void DiagnoseWeakIvars(Sema &S, ObjCImplementationDecl *ID) {
3676 if (S.getLangOpts().ObjCWeak) return;
3677
3678 for (auto ivar = ID->getClassInterface()->all_declared_ivar_begin();
3679 ivar; ivar = ivar->getNextIvar()) {
3680 if (ivar->isInvalidDecl()) continue;
3681 if (ivar->getType().getObjCLifetime() == Qualifiers::OCL_Weak) {
3682 if (S.getLangOpts().ObjCWeakRuntime) {
3683 S.Diag(ivar->getLocation(), diag::err_arc_weak_disabled);
3684 } else {
3685 S.Diag(ivar->getLocation(), diag::err_arc_weak_no_runtime);
3686 }
3687 }
3688 }
3689}
3690
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00003691Sema::ObjCContainerKind Sema::getObjCContainerKind() const {
3692 switch (CurContext->getDeclKind()) {
3693 case Decl::ObjCInterface:
3694 return Sema::OCK_Interface;
3695 case Decl::ObjCProtocol:
3696 return Sema::OCK_Protocol;
3697 case Decl::ObjCCategory:
Benjamin Kramera008d3a2015-04-10 11:37:55 +00003698 if (cast<ObjCCategoryDecl>(CurContext)->IsClassExtension())
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00003699 return Sema::OCK_ClassExtension;
Benjamin Kramera008d3a2015-04-10 11:37:55 +00003700 return Sema::OCK_Category;
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00003701 case Decl::ObjCImplementation:
3702 return Sema::OCK_Implementation;
3703 case Decl::ObjCCategoryImpl:
3704 return Sema::OCK_CategoryImplementation;
3705
3706 default:
3707 return Sema::OCK_None;
3708 }
3709}
3710
Fariborz Jahanian0080fb52013-07-16 15:33:19 +00003711// Note: For class/category implementations, allMethods is always null.
Robert Wilhelm57c67112013-07-17 21:14:35 +00003712Decl *Sema::ActOnAtEnd(Scope *S, SourceRange AtEnd, ArrayRef<Decl *> allMethods,
Fariborz Jahaniandfb76872013-07-17 00:05:08 +00003713 ArrayRef<DeclGroupPtrTy> allTUVars) {
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00003714 if (getObjCContainerKind() == Sema::OCK_None)
Craig Topperc3ec1492014-05-26 06:22:03 +00003715 return nullptr;
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00003716
3717 assert(AtEnd.isValid() && "Invalid location for '@end'");
3718
Fariborz Jahanian8d382dc2011-08-22 15:54:49 +00003719 ObjCContainerDecl *OCD = dyn_cast<ObjCContainerDecl>(CurContext);
3720 Decl *ClassDecl = cast<Decl>(OCD);
Fariborz Jahanian9290ede2009-11-16 18:57:01 +00003721
Mike Stump11289f42009-09-09 15:08:12 +00003722 bool isInterfaceDeclKind =
Chris Lattner219b3e92008-03-16 21:17:37 +00003723 isa<ObjCInterfaceDecl>(ClassDecl) || isa<ObjCCategoryDecl>(ClassDecl)
3724 || isa<ObjCProtocolDecl>(ClassDecl);
Ted Kremenek1b0ea822008-01-07 19:49:32 +00003725 bool checkIdenticalMethods = isa<ObjCImplementationDecl>(ClassDecl);
Steve Naroffb3a87982009-01-09 15:36:25 +00003726
Steve Naroff35c62ae2009-01-08 17:28:14 +00003727 // FIXME: Remove these and use the ObjCContainerDecl/DeclContext.
3728 llvm::DenseMap<Selector, const ObjCMethodDecl*> InsMap;
3729 llvm::DenseMap<Selector, const ObjCMethodDecl*> ClsMap;
3730
Fariborz Jahanian0080fb52013-07-16 15:33:19 +00003731 for (unsigned i = 0, e = allMethods.size(); i != e; i++ ) {
Ted Kremenek1b0ea822008-01-07 19:49:32 +00003732 ObjCMethodDecl *Method =
John McCall48871652010-08-21 09:40:31 +00003733 cast_or_null<ObjCMethodDecl>(allMethods[i]);
Chris Lattnerda463fe2007-12-12 07:09:47 +00003734
3735 if (!Method) continue; // Already issued a diagnostic.
Douglas Gregorffca3a22009-01-09 17:18:27 +00003736 if (Method->isInstanceMethod()) {
Chris Lattnerda463fe2007-12-12 07:09:47 +00003737 /// Check for instance method of the same name with incompatible types
Ted Kremenek1b0ea822008-01-07 19:49:32 +00003738 const ObjCMethodDecl *&PrevMethod = InsMap[Method->getSelector()];
Mike Stump11289f42009-09-09 15:08:12 +00003739 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod)
Chris Lattnerda463fe2007-12-12 07:09:47 +00003740 : false;
Mike Stump11289f42009-09-09 15:08:12 +00003741 if ((isInterfaceDeclKind && PrevMethod && !match)
Eli Friedman42b1e9e2008-12-16 20:15:50 +00003742 || (checkIdenticalMethods && match)) {
Chris Lattner0369c572008-11-23 23:12:31 +00003743 Diag(Method->getLocation(), diag::err_duplicate_method_decl)
Chris Lattnere4b95692008-11-24 03:33:13 +00003744 << Method->getDeclName();
Chris Lattner0369c572008-11-23 23:12:31 +00003745 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
Douglas Gregor87e92752010-12-21 17:34:17 +00003746 Method->setInvalidDecl();
Chris Lattnerda463fe2007-12-12 07:09:47 +00003747 } else {
Fariborz Jahanianc17c86b2011-12-13 19:40:34 +00003748 if (PrevMethod) {
Argyrios Kyrtzidisdcaaa212011-10-14 08:02:31 +00003749 Method->setAsRedeclaration(PrevMethod);
Fariborz Jahanianc17c86b2011-12-13 19:40:34 +00003750 if (!Context.getSourceManager().isInSystemHeader(
3751 Method->getLocation()))
3752 Diag(Method->getLocation(), diag::warn_duplicate_method_decl)
3753 << Method->getDeclName();
3754 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
3755 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00003756 InsMap[Method->getSelector()] = Method;
3757 /// The following allows us to typecheck messages to "id".
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00003758 AddInstanceMethodToGlobalPool(Method);
Chris Lattnerda463fe2007-12-12 07:09:47 +00003759 }
Mike Stump12b8ce12009-08-04 21:02:39 +00003760 } else {
Chris Lattnerda463fe2007-12-12 07:09:47 +00003761 /// Check for class method of the same name with incompatible types
Ted Kremenek1b0ea822008-01-07 19:49:32 +00003762 const ObjCMethodDecl *&PrevMethod = ClsMap[Method->getSelector()];
Mike Stump11289f42009-09-09 15:08:12 +00003763 bool match = PrevMethod ? MatchTwoMethodDeclarations(Method, PrevMethod)
Chris Lattnerda463fe2007-12-12 07:09:47 +00003764 : false;
Mike Stump11289f42009-09-09 15:08:12 +00003765 if ((isInterfaceDeclKind && PrevMethod && !match)
Eli Friedman42b1e9e2008-12-16 20:15:50 +00003766 || (checkIdenticalMethods && match)) {
Chris Lattner0369c572008-11-23 23:12:31 +00003767 Diag(Method->getLocation(), diag::err_duplicate_method_decl)
Chris Lattnere4b95692008-11-24 03:33:13 +00003768 << Method->getDeclName();
Chris Lattner0369c572008-11-23 23:12:31 +00003769 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
Douglas Gregor87e92752010-12-21 17:34:17 +00003770 Method->setInvalidDecl();
Chris Lattnerda463fe2007-12-12 07:09:47 +00003771 } else {
Fariborz Jahanianc17c86b2011-12-13 19:40:34 +00003772 if (PrevMethod) {
Argyrios Kyrtzidisdcaaa212011-10-14 08:02:31 +00003773 Method->setAsRedeclaration(PrevMethod);
Fariborz Jahanianc17c86b2011-12-13 19:40:34 +00003774 if (!Context.getSourceManager().isInSystemHeader(
3775 Method->getLocation()))
3776 Diag(Method->getLocation(), diag::warn_duplicate_method_decl)
3777 << Method->getDeclName();
3778 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
3779 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00003780 ClsMap[Method->getSelector()] = Method;
Douglas Gregor0e6fc1a2012-05-01 23:37:00 +00003781 AddFactoryMethodToGlobalPool(Method);
Chris Lattnerda463fe2007-12-12 07:09:47 +00003782 }
3783 }
3784 }
Douglas Gregorb8982092013-01-21 19:42:21 +00003785 if (isa<ObjCInterfaceDecl>(ClassDecl)) {
3786 // Nothing to do here.
Steve Naroffb3a87982009-01-09 15:36:25 +00003787 } else if (ObjCCategoryDecl *C = dyn_cast<ObjCCategoryDecl>(ClassDecl)) {
Fariborz Jahanian62293f42008-12-06 19:59:02 +00003788 // Categories are used to extend the class by declaring new methods.
Mike Stump11289f42009-09-09 15:08:12 +00003789 // By the same token, they are also used to add new properties. No
Fariborz Jahanian62293f42008-12-06 19:59:02 +00003790 // need to compare the added property to those in the class.
Daniel Dunbar4684f372008-08-27 05:40:03 +00003791
Fariborz Jahanianc21f5432010-12-10 23:36:33 +00003792 if (C->IsClassExtension()) {
3793 ObjCInterfaceDecl *CCPrimary = C->getClassInterface();
3794 DiagnoseClassExtensionDupMethods(C, CCPrimary);
Fariborz Jahanianc21f5432010-12-10 23:36:33 +00003795 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00003796 }
Steve Naroffb3a87982009-01-09 15:36:25 +00003797 if (ObjCContainerDecl *CDecl = dyn_cast<ObjCContainerDecl>(ClassDecl)) {
Fariborz Jahanian30a42922010-02-15 21:55:26 +00003798 if (CDecl->getIdentifier())
3799 // ProcessPropertyDecl is responsible for diagnosing conflicts with any
3800 // user-defined setter/getter. It also synthesizes setter/getter methods
3801 // and adds them to the DeclContext and global method pools.
Manman Renefe1bac2016-01-27 20:00:32 +00003802 for (auto *I : CDecl->properties())
Douglas Gregore17765e2015-11-03 17:02:34 +00003803 ProcessPropertyDecl(I);
Ted Kremenekc7c64312010-01-07 01:20:12 +00003804 CDecl->setAtEndRange(AtEnd);
Steve Naroffb3a87982009-01-09 15:36:25 +00003805 }
3806 if (ObjCImplementationDecl *IC=dyn_cast<ObjCImplementationDecl>(ClassDecl)) {
Ted Kremenekc7c64312010-01-07 01:20:12 +00003807 IC->setAtEndRange(AtEnd);
Fariborz Jahanian13e0c902009-11-11 22:40:11 +00003808 if (ObjCInterfaceDecl* IDecl = IC->getClassInterface()) {
Fariborz Jahanian5d7e9162010-12-11 18:39:37 +00003809 // Any property declared in a class extension might have user
3810 // declared setter or getter in current class extension or one
3811 // of the other class extensions. Mark them as synthesized as
3812 // property will be synthesized when property with same name is
3813 // seen in the @implementation.
Aaron Ballmanf53d8dd2014-03-13 21:47:07 +00003814 for (const auto *Ext : IDecl->visible_extensions()) {
Manman Rena7a8b1f2016-01-26 18:05:23 +00003815 for (const auto *Property : Ext->instance_properties()) {
Fariborz Jahanian5d7e9162010-12-11 18:39:37 +00003816 // Skip over properties declared @dynamic
3817 if (const ObjCPropertyImplDecl *PIDecl
Manman Ren5b786402016-01-28 18:49:28 +00003818 = IC->FindPropertyImplDecl(Property->getIdentifier(),
3819 Property->getQueryKind()))
Fariborz Jahanian5d7e9162010-12-11 18:39:37 +00003820 if (PIDecl->getPropertyImplementation()
3821 == ObjCPropertyImplDecl::Dynamic)
3822 continue;
Douglas Gregor048fbfa2013-01-16 23:00:23 +00003823
Aaron Ballmanf53d8dd2014-03-13 21:47:07 +00003824 for (const auto *Ext : IDecl->visible_extensions()) {
Douglas Gregor048fbfa2013-01-16 23:00:23 +00003825 if (ObjCMethodDecl *GetterMethod
3826 = Ext->getInstanceMethod(Property->getGetterName()))
Jordan Rosed01e83a2012-10-10 16:42:25 +00003827 GetterMethod->setPropertyAccessor(true);
Fariborz Jahanian5d7e9162010-12-11 18:39:37 +00003828 if (!Property->isReadOnly())
Douglas Gregor048fbfa2013-01-16 23:00:23 +00003829 if (ObjCMethodDecl *SetterMethod
3830 = Ext->getInstanceMethod(Property->getSetterName()))
Jordan Rosed01e83a2012-10-10 16:42:25 +00003831 SetterMethod->setPropertyAccessor(true);
Douglas Gregor048fbfa2013-01-16 23:00:23 +00003832 }
Fariborz Jahanian5d7e9162010-12-11 18:39:37 +00003833 }
3834 }
Fariborz Jahanian25491a22010-05-05 21:52:17 +00003835 ImplMethodsVsClassMethods(S, IC, IDecl);
Fariborz Jahanian13e0c902009-11-11 22:40:11 +00003836 AtomicPropertySetterGetterRules(IC, IDecl);
John McCall31168b02011-06-15 23:02:42 +00003837 DiagnoseOwningPropertyGetterSynthesis(IC);
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00003838 DiagnoseUnusedBackingIvarInAccessor(S, IC);
Fariborz Jahanian20cfff32015-03-11 16:59:48 +00003839 if (IDecl->hasDesignatedInitializers())
3840 DiagnoseMissingDesignatedInitOverrides(IC, IDecl);
John McCallb61e14e2015-10-27 04:54:50 +00003841 DiagnoseWeakIvars(*this, IC);
Argyrios Kyrtzidisdb5ce0f2013-12-03 21:11:54 +00003842
Patrick Beardacfbe9e2012-04-06 18:12:22 +00003843 bool HasRootClassAttr = IDecl->hasAttr<ObjCRootClassAttr>();
Craig Topperc3ec1492014-05-26 06:22:03 +00003844 if (IDecl->getSuperClass() == nullptr) {
Patrick Beardacfbe9e2012-04-06 18:12:22 +00003845 // This class has no superclass, so check that it has been marked with
3846 // __attribute((objc_root_class)).
3847 if (!HasRootClassAttr) {
3848 SourceLocation DeclLoc(IDecl->getLocation());
Alp Tokerb6cc5922014-05-03 03:45:55 +00003849 SourceLocation SuperClassLoc(getLocForEndOfToken(DeclLoc));
Patrick Beardacfbe9e2012-04-06 18:12:22 +00003850 Diag(DeclLoc, diag::warn_objc_root_class_missing)
3851 << IDecl->getIdentifier();
3852 // See if NSObject is in the current scope, and if it is, suggest
3853 // adding " : NSObject " to the class declaration.
3854 NamedDecl *IF = LookupSingleName(TUScope,
3855 NSAPIObj->getNSClassId(NSAPI::ClassId_NSObject),
3856 DeclLoc, LookupOrdinaryName);
3857 ObjCInterfaceDecl *NSObjectDecl = dyn_cast_or_null<ObjCInterfaceDecl>(IF);
3858 if (NSObjectDecl && NSObjectDecl->getDefinition()) {
3859 Diag(SuperClassLoc, diag::note_objc_needs_superclass)
3860 << FixItHint::CreateInsertion(SuperClassLoc, " : NSObject ");
3861 } else {
3862 Diag(SuperClassLoc, diag::note_objc_needs_superclass);
3863 }
3864 }
3865 } else if (HasRootClassAttr) {
3866 // Complain that only root classes may have this attribute.
3867 Diag(IDecl->getLocation(), diag::err_objc_root_class_subclass);
3868 }
3869
Alex Lorenza8c44ba2016-10-28 10:25:10 +00003870 if (const ObjCInterfaceDecl *Super = IDecl->getSuperClass()) {
3871 // An interface can subclass another interface with a
3872 // objc_subclassing_restricted attribute when it has that attribute as
3873 // well (because of interfaces imported from Swift). Therefore we have
3874 // to check if we can subclass in the implementation as well.
3875 if (IDecl->hasAttr<ObjCSubclassingRestrictedAttr>() &&
3876 Super->hasAttr<ObjCSubclassingRestrictedAttr>()) {
3877 Diag(IC->getLocation(), diag::err_restricted_superclass_mismatch);
3878 Diag(Super->getLocation(), diag::note_class_declared);
3879 }
3880 }
3881
John McCall5fb5df92012-06-20 06:18:46 +00003882 if (LangOpts.ObjCRuntime.isNonFragile()) {
Fariborz Jahanian545643c2010-02-23 23:41:11 +00003883 while (IDecl->getSuperClass()) {
3884 DiagnoseDuplicateIvars(IDecl, IDecl->getSuperClass());
3885 IDecl = IDecl->getSuperClass();
3886 }
Patrick Beardacfbe9e2012-04-06 18:12:22 +00003887 }
Fariborz Jahanian13e0c902009-11-11 22:40:11 +00003888 }
Fariborz Jahanianc83726e2010-04-28 16:11:27 +00003889 SetIvarInitializers(IC);
Mike Stump11289f42009-09-09 15:08:12 +00003890 } else if (ObjCCategoryImplDecl* CatImplClass =
Steve Naroffb3a87982009-01-09 15:36:25 +00003891 dyn_cast<ObjCCategoryImplDecl>(ClassDecl)) {
Ted Kremenekc7c64312010-01-07 01:20:12 +00003892 CatImplClass->setAtEndRange(AtEnd);
Mike Stump11289f42009-09-09 15:08:12 +00003893
Chris Lattnerda463fe2007-12-12 07:09:47 +00003894 // Find category interface decl and then check that all methods declared
Daniel Dunbar4684f372008-08-27 05:40:03 +00003895 // in this interface are implemented in the category @implementation.
Chris Lattner41fd42e2009-02-16 18:32:47 +00003896 if (ObjCInterfaceDecl* IDecl = CatImplClass->getClassInterface()) {
Douglas Gregor048fbfa2013-01-16 23:00:23 +00003897 if (ObjCCategoryDecl *Cat
3898 = IDecl->FindCategoryDeclaration(CatImplClass->getIdentifier())) {
3899 ImplMethodsVsClassMethods(S, CatImplClass, Cat);
Chris Lattnerda463fe2007-12-12 07:09:47 +00003900 }
3901 }
Alex Lorenza8c44ba2016-10-28 10:25:10 +00003902 } else if (const auto *IntfDecl = dyn_cast<ObjCInterfaceDecl>(ClassDecl)) {
3903 if (const ObjCInterfaceDecl *Super = IntfDecl->getSuperClass()) {
3904 if (!IntfDecl->hasAttr<ObjCSubclassingRestrictedAttr>() &&
3905 Super->hasAttr<ObjCSubclassingRestrictedAttr>()) {
3906 Diag(IntfDecl->getLocation(), diag::err_restricted_superclass_mismatch);
3907 Diag(Super->getLocation(), diag::note_class_declared);
3908 }
3909 }
Chris Lattnerda463fe2007-12-12 07:09:47 +00003910 }
Chris Lattner5bbb3c82009-03-29 16:50:03 +00003911 if (isInterfaceDeclKind) {
3912 // Reject invalid vardecls.
Fariborz Jahanian0080fb52013-07-16 15:33:19 +00003913 for (unsigned i = 0, e = allTUVars.size(); i != e; i++) {
Serge Pavlov9ddb76e2013-08-27 13:15:56 +00003914 DeclGroupRef DG = allTUVars[i].get();
Chris Lattner5bbb3c82009-03-29 16:50:03 +00003915 for (DeclGroupRef::iterator I = DG.begin(), E = DG.end(); I != E; ++I)
3916 if (VarDecl *VDecl = dyn_cast<VarDecl>(*I)) {
Daniel Dunbar0ca16602009-04-14 02:25:56 +00003917 if (!VDecl->hasExternalStorage())
Steve Naroff42959b22009-04-13 17:58:46 +00003918 Diag(VDecl->getLocation(), diag::err_objc_var_decl_inclass);
Fariborz Jahanian629aed92009-03-21 18:06:45 +00003919 }
Chris Lattner5bbb3c82009-03-29 16:50:03 +00003920 }
Fariborz Jahanian3654e652009-03-18 22:33:24 +00003921 }
Fariborz Jahanian4327b322011-08-29 17:33:12 +00003922 ActOnObjCContainerFinishDefinition();
Argyrios Kyrtzidisbd8b1502011-10-17 19:48:13 +00003923
Fariborz Jahanian0080fb52013-07-16 15:33:19 +00003924 for (unsigned i = 0, e = allTUVars.size(); i != e; i++) {
Serge Pavlov9ddb76e2013-08-27 13:15:56 +00003925 DeclGroupRef DG = allTUVars[i].get();
Argyrios Kyrtzidis8ad3bab2011-11-23 20:27:36 +00003926 for (DeclGroupRef::iterator I = DG.begin(), E = DG.end(); I != E; ++I)
3927 (*I)->setTopLevelDeclInObjCContainer();
Argyrios Kyrtzidisbd8b1502011-10-17 19:48:13 +00003928 Consumer.HandleTopLevelDeclInObjCContainer(DG);
3929 }
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00003930
Dmitri Gribenkoe7bb9442012-07-13 01:06:46 +00003931 ActOnDocumentableDecl(ClassDecl);
Erik Verbruggenc6c8d932011-12-06 09:25:23 +00003932 return ClassDecl;
Chris Lattnerda463fe2007-12-12 07:09:47 +00003933}
3934
Chris Lattnerda463fe2007-12-12 07:09:47 +00003935/// CvtQTToAstBitMask - utility routine to produce an AST bitmask for
3936/// objective-c's type qualifier from the parser version of the same info.
Mike Stump11289f42009-09-09 15:08:12 +00003937static Decl::ObjCDeclQualifier
Ted Kremenek1b0ea822008-01-07 19:49:32 +00003938CvtQTToAstBitMask(ObjCDeclSpec::ObjCDeclQualifier PQTVal) {
John McCallca872902011-05-01 03:04:29 +00003939 return (Decl::ObjCDeclQualifier) (unsigned) PQTVal;
Chris Lattnerda463fe2007-12-12 07:09:47 +00003940}
3941
Douglas Gregor33823722011-06-11 01:09:30 +00003942/// \brief Check whether the declared result type of the given Objective-C
3943/// method declaration is compatible with the method's class.
3944///
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00003945static Sema::ResultTypeCompatibilityKind
Douglas Gregor33823722011-06-11 01:09:30 +00003946CheckRelatedResultTypeCompatibility(Sema &S, ObjCMethodDecl *Method,
3947 ObjCInterfaceDecl *CurrentClass) {
Alp Toker314cc812014-01-25 16:55:45 +00003948 QualType ResultType = Method->getReturnType();
3949
Douglas Gregor33823722011-06-11 01:09:30 +00003950 // If an Objective-C method inherits its related result type, then its
3951 // declared result type must be compatible with its own class type. The
3952 // declared result type is compatible if:
3953 if (const ObjCObjectPointerType *ResultObjectType
3954 = ResultType->getAs<ObjCObjectPointerType>()) {
3955 // - it is id or qualified id, or
3956 if (ResultObjectType->isObjCIdType() ||
3957 ResultObjectType->isObjCQualifiedIdType())
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00003958 return Sema::RTC_Compatible;
Douglas Gregor33823722011-06-11 01:09:30 +00003959
3960 if (CurrentClass) {
3961 if (ObjCInterfaceDecl *ResultClass
3962 = ResultObjectType->getInterfaceDecl()) {
3963 // - it is the same as the method's class type, or
Douglas Gregor0b144e12011-12-15 00:29:59 +00003964 if (declaresSameEntity(CurrentClass, ResultClass))
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00003965 return Sema::RTC_Compatible;
Douglas Gregor33823722011-06-11 01:09:30 +00003966
3967 // - it is a superclass of the method's class type
3968 if (ResultClass->isSuperClassOf(CurrentClass))
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00003969 return Sema::RTC_Compatible;
Douglas Gregor33823722011-06-11 01:09:30 +00003970 }
Douglas Gregorbab8a962011-09-08 01:46:34 +00003971 } else {
3972 // Any Objective-C pointer type might be acceptable for a protocol
3973 // method; we just don't know.
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00003974 return Sema::RTC_Unknown;
Douglas Gregor33823722011-06-11 01:09:30 +00003975 }
3976 }
3977
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00003978 return Sema::RTC_Incompatible;
Douglas Gregor33823722011-06-11 01:09:30 +00003979}
3980
John McCalld2930c22011-07-22 02:45:48 +00003981namespace {
3982/// A helper class for searching for methods which a particular method
3983/// overrides.
3984class OverrideSearch {
Daniel Dunbard6d74c32012-02-29 03:04:05 +00003985public:
John McCalld2930c22011-07-22 02:45:48 +00003986 Sema &S;
3987 ObjCMethodDecl *Method;
Daniel Dunbard6d74c32012-02-29 03:04:05 +00003988 llvm::SmallPtrSet<ObjCMethodDecl*, 4> Overridden;
John McCalld2930c22011-07-22 02:45:48 +00003989 bool Recursive;
3990
3991public:
3992 OverrideSearch(Sema &S, ObjCMethodDecl *method) : S(S), Method(method) {
3993 Selector selector = method->getSelector();
3994
3995 // Bypass this search if we've never seen an instance/class method
3996 // with this selector before.
3997 Sema::GlobalMethodPool::iterator it = S.MethodPool.find(selector);
3998 if (it == S.MethodPool.end()) {
Axel Naumanndd433f02012-10-18 19:05:02 +00003999 if (!S.getExternalSource()) return;
Douglas Gregore1716012012-01-25 00:49:42 +00004000 S.ReadMethodPool(selector);
4001
4002 it = S.MethodPool.find(selector);
4003 if (it == S.MethodPool.end())
4004 return;
John McCalld2930c22011-07-22 02:45:48 +00004005 }
4006 ObjCMethodList &list =
4007 method->isInstanceMethod() ? it->second.first : it->second.second;
Nico Weber2e0c8f72014-12-27 03:58:08 +00004008 if (!list.getMethod()) return;
John McCalld2930c22011-07-22 02:45:48 +00004009
4010 ObjCContainerDecl *container
4011 = cast<ObjCContainerDecl>(method->getDeclContext());
4012
4013 // Prevent the search from reaching this container again. This is
4014 // important with categories, which override methods from the
4015 // interface and each other.
Douglas Gregorcf4ac442012-05-03 21:25:24 +00004016 if (ObjCCategoryDecl *Category = dyn_cast<ObjCCategoryDecl>(container)) {
4017 searchFromContainer(container);
Douglas Gregorc5928af2012-05-17 22:39:14 +00004018 if (ObjCInterfaceDecl *Interface = Category->getClassInterface())
4019 searchFromContainer(Interface);
Douglas Gregorcf4ac442012-05-03 21:25:24 +00004020 } else {
4021 searchFromContainer(container);
4022 }
Douglas Gregor33823722011-06-11 01:09:30 +00004023 }
John McCalld2930c22011-07-22 02:45:48 +00004024
Matthias Braun1d030072016-01-30 01:27:06 +00004025 typedef llvm::SmallPtrSetImpl<ObjCMethodDecl*>::iterator iterator;
John McCalld2930c22011-07-22 02:45:48 +00004026 iterator begin() const { return Overridden.begin(); }
4027 iterator end() const { return Overridden.end(); }
4028
4029private:
4030 void searchFromContainer(ObjCContainerDecl *container) {
4031 if (container->isInvalidDecl()) return;
4032
4033 switch (container->getDeclKind()) {
4034#define OBJCCONTAINER(type, base) \
4035 case Decl::type: \
4036 searchFrom(cast<type##Decl>(container)); \
4037 break;
4038#define ABSTRACT_DECL(expansion)
4039#define DECL(type, base) \
4040 case Decl::type:
4041#include "clang/AST/DeclNodes.inc"
4042 llvm_unreachable("not an ObjC container!");
4043 }
4044 }
4045
4046 void searchFrom(ObjCProtocolDecl *protocol) {
Douglas Gregore6e48b12012-01-01 19:29:29 +00004047 if (!protocol->hasDefinition())
4048 return;
4049
John McCalld2930c22011-07-22 02:45:48 +00004050 // A method in a protocol declaration overrides declarations from
4051 // referenced ("parent") protocols.
4052 search(protocol->getReferencedProtocols());
4053 }
4054
4055 void searchFrom(ObjCCategoryDecl *category) {
4056 // A method in a category declaration overrides declarations from
4057 // the main class and from protocols the category references.
Douglas Gregorcf4ac442012-05-03 21:25:24 +00004058 // The main class is handled in the constructor.
John McCalld2930c22011-07-22 02:45:48 +00004059 search(category->getReferencedProtocols());
4060 }
4061
4062 void searchFrom(ObjCCategoryImplDecl *impl) {
4063 // A method in a category definition that has a category
4064 // declaration overrides declarations from the category
4065 // declaration.
4066 if (ObjCCategoryDecl *category = impl->getCategoryDecl()) {
4067 search(category);
Douglas Gregorc5928af2012-05-17 22:39:14 +00004068 if (ObjCInterfaceDecl *Interface = category->getClassInterface())
4069 search(Interface);
John McCalld2930c22011-07-22 02:45:48 +00004070
4071 // Otherwise it overrides declarations from the class.
Douglas Gregorc5928af2012-05-17 22:39:14 +00004072 } else if (ObjCInterfaceDecl *Interface = impl->getClassInterface()) {
4073 search(Interface);
John McCalld2930c22011-07-22 02:45:48 +00004074 }
4075 }
4076
4077 void searchFrom(ObjCInterfaceDecl *iface) {
4078 // A method in a class declaration overrides declarations from
Douglas Gregorc0ac7d62011-12-15 05:27:12 +00004079 if (!iface->hasDefinition())
4080 return;
4081
John McCalld2930c22011-07-22 02:45:48 +00004082 // - categories,
Aaron Ballman15063e12014-03-13 21:35:02 +00004083 for (auto *Cat : iface->known_categories())
4084 search(Cat);
John McCalld2930c22011-07-22 02:45:48 +00004085
4086 // - the super class, and
4087 if (ObjCInterfaceDecl *super = iface->getSuperClass())
4088 search(super);
4089
4090 // - any referenced protocols.
4091 search(iface->getReferencedProtocols());
4092 }
4093
4094 void searchFrom(ObjCImplementationDecl *impl) {
4095 // A method in a class implementation overrides declarations from
4096 // the class interface.
Douglas Gregorc5928af2012-05-17 22:39:14 +00004097 if (ObjCInterfaceDecl *Interface = impl->getClassInterface())
4098 search(Interface);
John McCalld2930c22011-07-22 02:45:48 +00004099 }
4100
John McCalld2930c22011-07-22 02:45:48 +00004101 void search(const ObjCProtocolList &protocols) {
4102 for (ObjCProtocolList::iterator i = protocols.begin(), e = protocols.end();
4103 i != e; ++i)
4104 search(*i);
4105 }
4106
4107 void search(ObjCContainerDecl *container) {
John McCalld2930c22011-07-22 02:45:48 +00004108 // Check for a method in this container which matches this selector.
4109 ObjCMethodDecl *meth = container->getMethod(Method->getSelector(),
Argyrios Kyrtzidisbd8cd3e2013-03-29 21:51:48 +00004110 Method->isInstanceMethod(),
4111 /*AllowHidden=*/true);
John McCalld2930c22011-07-22 02:45:48 +00004112
4113 // If we find one, record it and bail out.
4114 if (meth) {
4115 Overridden.insert(meth);
4116 return;
4117 }
4118
4119 // Otherwise, search for methods that a hypothetical method here
4120 // would have overridden.
4121
4122 // Note that we're now in a recursive case.
4123 Recursive = true;
4124
4125 searchFromContainer(container);
4126 }
4127};
Hans Wennborgdcfba332015-10-06 23:40:43 +00004128} // end anonymous namespace
Douglas Gregor33823722011-06-11 01:09:30 +00004129
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00004130void Sema::CheckObjCMethodOverrides(ObjCMethodDecl *ObjCMethod,
4131 ObjCInterfaceDecl *CurrentClass,
4132 ResultTypeCompatibilityKind RTC) {
4133 // Search for overridden methods and merge information down from them.
4134 OverrideSearch overrides(*this, ObjCMethod);
4135 // Keep track if the method overrides any method in the class's base classes,
4136 // its protocols, or its categories' protocols; we will keep that info
4137 // in the ObjCMethodDecl.
4138 // For this info, a method in an implementation is not considered as
4139 // overriding the same method in the interface or its categories.
4140 bool hasOverriddenMethodsInBaseOrProtocol = false;
4141 for (OverrideSearch::iterator
4142 i = overrides.begin(), e = overrides.end(); i != e; ++i) {
4143 ObjCMethodDecl *overridden = *i;
4144
Argyrios Kyrtzidisc2091d52013-04-17 00:09:08 +00004145 if (!hasOverriddenMethodsInBaseOrProtocol) {
4146 if (isa<ObjCProtocolDecl>(overridden->getDeclContext()) ||
4147 CurrentClass != overridden->getClassInterface() ||
4148 overridden->isOverriding()) {
4149 hasOverriddenMethodsInBaseOrProtocol = true;
4150
4151 } else if (isa<ObjCImplDecl>(ObjCMethod->getDeclContext())) {
4152 // OverrideSearch will return as "overridden" the same method in the
4153 // interface. For hasOverriddenMethodsInBaseOrProtocol, we need to
4154 // check whether a category of a base class introduced a method with the
4155 // same selector, after the interface method declaration.
4156 // To avoid unnecessary lookups in the majority of cases, we use the
4157 // extra info bits in GlobalMethodPool to check whether there were any
4158 // category methods with this selector.
4159 GlobalMethodPool::iterator It =
4160 MethodPool.find(ObjCMethod->getSelector());
4161 if (It != MethodPool.end()) {
4162 ObjCMethodList &List =
4163 ObjCMethod->isInstanceMethod()? It->second.first: It->second.second;
4164 unsigned CategCount = List.getBits();
4165 if (CategCount > 0) {
4166 // If the method is in a category we'll do lookup if there were at
4167 // least 2 category methods recorded, otherwise only one will do.
4168 if (CategCount > 1 ||
4169 !isa<ObjCCategoryImplDecl>(overridden->getDeclContext())) {
4170 OverrideSearch overrides(*this, overridden);
4171 for (OverrideSearch::iterator
4172 OI= overrides.begin(), OE= overrides.end(); OI!=OE; ++OI) {
4173 ObjCMethodDecl *SuperOverridden = *OI;
Argyrios Kyrtzidis04703a62013-04-27 00:10:12 +00004174 if (isa<ObjCProtocolDecl>(SuperOverridden->getDeclContext()) ||
4175 CurrentClass != SuperOverridden->getClassInterface()) {
Argyrios Kyrtzidisc2091d52013-04-17 00:09:08 +00004176 hasOverriddenMethodsInBaseOrProtocol = true;
4177 overridden->setOverriding(true);
4178 break;
4179 }
4180 }
4181 }
4182 }
4183 }
4184 }
4185 }
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00004186
4187 // Propagate down the 'related result type' bit from overridden methods.
4188 if (RTC != Sema::RTC_Incompatible && overridden->hasRelatedResultType())
4189 ObjCMethod->SetRelatedResultType();
4190
4191 // Then merge the declarations.
4192 mergeObjCMethodDecls(ObjCMethod, overridden);
4193
4194 if (ObjCMethod->isImplicit() && overridden->isImplicit())
4195 continue; // Conflicting properties are detected elsewhere.
4196
4197 // Check for overriding methods
4198 if (isa<ObjCInterfaceDecl>(ObjCMethod->getDeclContext()) ||
4199 isa<ObjCImplementationDecl>(ObjCMethod->getDeclContext()))
4200 CheckConflictingOverridingMethod(ObjCMethod, overridden,
4201 isa<ObjCProtocolDecl>(overridden->getDeclContext()));
4202
4203 if (CurrentClass && overridden->getDeclContext() != CurrentClass &&
Fariborz Jahanian31a25682012-07-05 22:26:07 +00004204 isa<ObjCInterfaceDecl>(overridden->getDeclContext()) &&
4205 !overridden->isImplicit() /* not meant for properties */) {
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00004206 ObjCMethodDecl::param_iterator ParamI = ObjCMethod->param_begin(),
4207 E = ObjCMethod->param_end();
Douglas Gregor0bf70f42012-05-17 23:13:29 +00004208 ObjCMethodDecl::param_iterator PrevI = overridden->param_begin(),
4209 PrevE = overridden->param_end();
4210 for (; ParamI != E && PrevI != PrevE; ++ParamI, ++PrevI) {
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00004211 assert(PrevI != overridden->param_end() && "Param mismatch");
4212 QualType T1 = Context.getCanonicalType((*ParamI)->getType());
4213 QualType T2 = Context.getCanonicalType((*PrevI)->getType());
4214 // If type of argument of method in this class does not match its
4215 // respective argument type in the super class method, issue warning;
4216 if (!Context.typesAreCompatible(T1, T2)) {
4217 Diag((*ParamI)->getLocation(), diag::ext_typecheck_base_super)
4218 << T1 << T2;
4219 Diag(overridden->getLocation(), diag::note_previous_declaration);
4220 break;
4221 }
4222 }
4223 }
4224 }
4225
4226 ObjCMethod->setOverriding(hasOverriddenMethodsInBaseOrProtocol);
4227}
4228
Douglas Gregor813a0662015-06-19 18:14:38 +00004229/// Merge type nullability from for a redeclaration of the same entity,
4230/// producing the updated type of the redeclared entity.
4231static QualType mergeTypeNullabilityForRedecl(Sema &S, SourceLocation loc,
4232 QualType type,
4233 bool usesCSKeyword,
4234 SourceLocation prevLoc,
4235 QualType prevType,
4236 bool prevUsesCSKeyword) {
4237 // Determine the nullability of both types.
4238 auto nullability = type->getNullability(S.Context);
4239 auto prevNullability = prevType->getNullability(S.Context);
4240
4241 // Easy case: both have nullability.
4242 if (nullability.hasValue() == prevNullability.hasValue()) {
4243 // Neither has nullability; continue.
4244 if (!nullability)
4245 return type;
4246
4247 // The nullabilities are equivalent; do nothing.
4248 if (*nullability == *prevNullability)
4249 return type;
4250
4251 // Complain about mismatched nullability.
4252 S.Diag(loc, diag::err_nullability_conflicting)
Douglas Gregoraea7afd2015-06-24 22:02:08 +00004253 << DiagNullabilityKind(*nullability, usesCSKeyword)
4254 << DiagNullabilityKind(*prevNullability, prevUsesCSKeyword);
Douglas Gregor813a0662015-06-19 18:14:38 +00004255 return type;
4256 }
4257
4258 // If it's the redeclaration that has nullability, don't change anything.
4259 if (nullability)
4260 return type;
4261
4262 // Otherwise, provide the result with the same nullability.
4263 return S.Context.getAttributedType(
4264 AttributedType::getNullabilityAttrKind(*prevNullability),
4265 type, type);
4266}
4267
NAKAMURA Takumi2df5c3c2015-06-20 03:52:52 +00004268/// Merge information from the declaration of a method in the \@interface
Douglas Gregor813a0662015-06-19 18:14:38 +00004269/// (or a category/extension) into the corresponding method in the
4270/// @implementation (for a class or category).
4271static void mergeInterfaceMethodToImpl(Sema &S,
4272 ObjCMethodDecl *method,
4273 ObjCMethodDecl *prevMethod) {
4274 // Merge the objc_requires_super attribute.
4275 if (prevMethod->hasAttr<ObjCRequiresSuperAttr>() &&
4276 !method->hasAttr<ObjCRequiresSuperAttr>()) {
4277 // merge the attribute into implementation.
4278 method->addAttr(
4279 ObjCRequiresSuperAttr::CreateImplicit(S.Context,
4280 method->getLocation()));
4281 }
4282
4283 // Merge nullability of the result type.
4284 QualType newReturnType
4285 = mergeTypeNullabilityForRedecl(
4286 S, method->getReturnTypeSourceRange().getBegin(),
4287 method->getReturnType(),
4288 method->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability,
4289 prevMethod->getReturnTypeSourceRange().getBegin(),
4290 prevMethod->getReturnType(),
4291 prevMethod->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability);
4292 method->setReturnType(newReturnType);
4293
4294 // Handle each of the parameters.
4295 unsigned numParams = method->param_size();
4296 unsigned numPrevParams = prevMethod->param_size();
4297 for (unsigned i = 0, n = std::min(numParams, numPrevParams); i != n; ++i) {
4298 ParmVarDecl *param = method->param_begin()[i];
4299 ParmVarDecl *prevParam = prevMethod->param_begin()[i];
4300
4301 // Merge nullability.
4302 QualType newParamType
4303 = mergeTypeNullabilityForRedecl(
4304 S, param->getLocation(), param->getType(),
4305 param->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability,
4306 prevParam->getLocation(), prevParam->getType(),
4307 prevParam->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability);
4308 param->setType(newParamType);
4309 }
4310}
4311
Alex Lorenza8a372d2017-04-27 10:43:48 +00004312/// Verify that the method parameters/return value have types that are supported
4313/// by the x86 target.
4314static void checkObjCMethodX86VectorTypes(Sema &SemaRef,
4315 const ObjCMethodDecl *Method) {
4316 assert(SemaRef.getASTContext().getTargetInfo().getTriple().getArch() ==
4317 llvm::Triple::x86 &&
4318 "x86-specific check invoked for a different target");
4319 SourceLocation Loc;
4320 QualType T;
4321 for (const ParmVarDecl *P : Method->parameters()) {
4322 if (P->getType()->isVectorType()) {
4323 Loc = P->getLocStart();
4324 T = P->getType();
4325 break;
4326 }
4327 }
4328 if (Loc.isInvalid()) {
4329 if (Method->getReturnType()->isVectorType()) {
4330 Loc = Method->getReturnTypeSourceRange().getBegin();
4331 T = Method->getReturnType();
4332 } else
4333 return;
4334 }
4335
4336 // Vector parameters/return values are not supported by objc_msgSend on x86 in
4337 // iOS < 9 and macOS < 10.11.
4338 const auto &Triple = SemaRef.getASTContext().getTargetInfo().getTriple();
4339 VersionTuple AcceptedInVersion;
4340 if (Triple.getOS() == llvm::Triple::IOS)
4341 AcceptedInVersion = VersionTuple(/*Major=*/9);
4342 else if (Triple.isMacOSX())
4343 AcceptedInVersion = VersionTuple(/*Major=*/10, /*Minor=*/11);
4344 else
4345 return;
Alex Lorenza8a372d2017-04-27 10:43:48 +00004346 if (SemaRef.getASTContext().getTargetInfo().getPlatformMinVersion() >=
Alex Lorenz92824832017-05-05 16:15:17 +00004347 AcceptedInVersion)
Alex Lorenza8a372d2017-04-27 10:43:48 +00004348 return;
4349 SemaRef.Diag(Loc, diag::err_objc_method_unsupported_param_ret_type)
4350 << T << (Method->getReturnType()->isVectorType() ? /*return value*/ 1
4351 : /*parameter*/ 0)
4352 << (Triple.isMacOSX() ? "macOS 10.11" : "iOS 9");
4353}
4354
John McCall48871652010-08-21 09:40:31 +00004355Decl *Sema::ActOnMethodDeclaration(
Fariborz Jahanianca3566f2011-02-09 22:20:01 +00004356 Scope *S,
Chris Lattnerda463fe2007-12-12 07:09:47 +00004357 SourceLocation MethodLoc, SourceLocation EndLoc,
Fariborz Jahanian8d382dc2011-08-22 15:54:49 +00004358 tok::TokenKind MethodType,
John McCallba7bf592010-08-24 05:47:05 +00004359 ObjCDeclSpec &ReturnQT, ParsedType ReturnType,
Argyrios Kyrtzidisdfd65702011-10-03 06:36:36 +00004360 ArrayRef<SourceLocation> SelectorLocs,
Chris Lattnerda463fe2007-12-12 07:09:47 +00004361 Selector Sel,
4362 // optional arguments. The number of types/arguments is obtained
4363 // from the Sel.getNumArgs().
Chris Lattnerd8626fd2009-04-11 18:57:04 +00004364 ObjCArgInfo *ArgInfo,
Fariborz Jahanian60462092010-04-08 00:30:06 +00004365 DeclaratorChunk::ParamInfo *CParamInfo, unsigned CNumArgs, // c-style args
Chris Lattnerda463fe2007-12-12 07:09:47 +00004366 AttributeList *AttrList, tok::ObjCKeywordKind MethodDeclKind,
Fariborz Jahanianc677f692011-03-12 18:54:30 +00004367 bool isVariadic, bool MethodDefinition) {
Steve Naroff83777fe2008-02-29 21:48:07 +00004368 // Make sure we can establish a context for the method.
Fariborz Jahanian8d382dc2011-08-22 15:54:49 +00004369 if (!CurContext->isObjCContainer()) {
Richard Smithf8812672016-12-02 22:38:31 +00004370 Diag(MethodLoc, diag::err_missing_method_context);
Craig Topperc3ec1492014-05-26 06:22:03 +00004371 return nullptr;
Steve Naroff83777fe2008-02-29 21:48:07 +00004372 }
Fariborz Jahanian8d382dc2011-08-22 15:54:49 +00004373 ObjCContainerDecl *OCD = dyn_cast<ObjCContainerDecl>(CurContext);
4374 Decl *ClassDecl = cast<Decl>(OCD);
Chris Lattnerda463fe2007-12-12 07:09:47 +00004375 QualType resultDeclType;
Mike Stump11289f42009-09-09 15:08:12 +00004376
Douglas Gregorbab8a962011-09-08 01:46:34 +00004377 bool HasRelatedResultType = false;
Craig Topperc3ec1492014-05-26 06:22:03 +00004378 TypeSourceInfo *ReturnTInfo = nullptr;
Steve Naroff32606412009-02-20 22:59:16 +00004379 if (ReturnType) {
Alp Toker314cc812014-01-25 16:55:45 +00004380 resultDeclType = GetTypeFromParser(ReturnType, &ReturnTInfo);
Mike Stump11289f42009-09-09 15:08:12 +00004381
Eli Friedman31a5bcc2013-06-14 21:14:10 +00004382 if (CheckFunctionReturnType(resultDeclType, MethodLoc))
Craig Topperc3ec1492014-05-26 06:22:03 +00004383 return nullptr;
Eli Friedman31a5bcc2013-06-14 21:14:10 +00004384
Douglas Gregor813a0662015-06-19 18:14:38 +00004385 QualType bareResultType = resultDeclType;
4386 (void)AttributedType::stripOuterNullability(bareResultType);
4387 HasRelatedResultType = (bareResultType == Context.getObjCInstanceType());
Fariborz Jahanianb5a52ca2011-07-21 17:00:47 +00004388 } else { // get the type for "id".
Ted Kremenek1b0ea822008-01-07 19:49:32 +00004389 resultDeclType = Context.getObjCIdType();
Fariborz Jahanianb21138f2011-07-21 17:38:14 +00004390 Diag(MethodLoc, diag::warn_missing_method_return_type)
Argyrios Kyrtzidisdfd65702011-10-03 06:36:36 +00004391 << FixItHint::CreateInsertion(SelectorLocs.front(), "(id)");
Fariborz Jahanianb5a52ca2011-07-21 17:00:47 +00004392 }
Mike Stump11289f42009-09-09 15:08:12 +00004393
Alp Toker314cc812014-01-25 16:55:45 +00004394 ObjCMethodDecl *ObjCMethod = ObjCMethodDecl::Create(
4395 Context, MethodLoc, EndLoc, Sel, resultDeclType, ReturnTInfo, CurContext,
4396 MethodType == tok::minus, isVariadic,
4397 /*isPropertyAccessor=*/false,
4398 /*isImplicitlyDeclared=*/false, /*isDefined=*/false,
4399 MethodDeclKind == tok::objc_optional ? ObjCMethodDecl::Optional
4400 : ObjCMethodDecl::Required,
4401 HasRelatedResultType);
Mike Stump11289f42009-09-09 15:08:12 +00004402
Chris Lattner0e62c1c2011-07-23 10:55:15 +00004403 SmallVector<ParmVarDecl*, 16> Params;
Mike Stump11289f42009-09-09 15:08:12 +00004404
Chris Lattner23b0faf2009-04-11 19:42:43 +00004405 for (unsigned i = 0, e = Sel.getNumArgs(); i != e; ++i) {
John McCall856bbea2009-10-23 21:48:59 +00004406 QualType ArgType;
John McCallbcd03502009-12-07 02:54:59 +00004407 TypeSourceInfo *DI;
Mike Stump11289f42009-09-09 15:08:12 +00004408
David Blaikie7d170102013-05-15 07:37:26 +00004409 if (!ArgInfo[i].Type) {
John McCall856bbea2009-10-23 21:48:59 +00004410 ArgType = Context.getObjCIdType();
Craig Topperc3ec1492014-05-26 06:22:03 +00004411 DI = nullptr;
Chris Lattnerd8626fd2009-04-11 18:57:04 +00004412 } else {
John McCall856bbea2009-10-23 21:48:59 +00004413 ArgType = GetTypeFromParser(ArgInfo[i].Type, &DI);
Chris Lattnerd8626fd2009-04-11 18:57:04 +00004414 }
Mike Stump11289f42009-09-09 15:08:12 +00004415
Fariborz Jahanianca3566f2011-02-09 22:20:01 +00004416 LookupResult R(*this, ArgInfo[i].Name, ArgInfo[i].NameLoc,
4417 LookupOrdinaryName, ForRedeclaration);
4418 LookupName(R, S);
4419 if (R.isSingleResult()) {
4420 NamedDecl *PrevDecl = R.getFoundDecl();
4421 if (S->isDeclScope(PrevDecl)) {
Fariborz Jahanianc677f692011-03-12 18:54:30 +00004422 Diag(ArgInfo[i].NameLoc,
4423 (MethodDefinition ? diag::warn_method_param_redefinition
4424 : diag::warn_method_param_declaration))
Fariborz Jahanianca3566f2011-02-09 22:20:01 +00004425 << ArgInfo[i].Name;
4426 Diag(PrevDecl->getLocation(),
4427 diag::note_previous_declaration);
4428 }
4429 }
4430
Abramo Bagnaradff19302011-03-08 08:55:46 +00004431 SourceLocation StartLoc = DI
4432 ? DI->getTypeLoc().getBeginLoc()
4433 : ArgInfo[i].NameLoc;
4434
John McCalld44f4d72011-04-23 02:46:06 +00004435 ParmVarDecl* Param = CheckParameter(ObjCMethod, StartLoc,
4436 ArgInfo[i].NameLoc, ArgInfo[i].Name,
Rafael Espindola6ae7e502013-04-03 19:27:57 +00004437 ArgType, DI, SC_None);
Mike Stump11289f42009-09-09 15:08:12 +00004438
John McCall82490832011-05-02 00:30:12 +00004439 Param->setObjCMethodScopeInfo(i);
4440
Chris Lattnerc5ffed42008-04-04 06:12:32 +00004441 Param->setObjCDeclQualifier(
Chris Lattnerd8626fd2009-04-11 18:57:04 +00004442 CvtQTToAstBitMask(ArgInfo[i].DeclSpec.getObjCDeclQualifier()));
Mike Stump11289f42009-09-09 15:08:12 +00004443
Chris Lattner9713a1c2009-04-11 19:34:56 +00004444 // Apply the attributes to the parameter.
Douglas Gregor758a8692009-06-17 21:51:59 +00004445 ProcessDeclAttributeList(TUScope, Param, ArgInfo[i].ArgAttrs);
Alex Lorenz9e7bf162017-04-18 14:33:39 +00004446 AddPragmaAttributes(TUScope, Param);
Mike Stump11289f42009-09-09 15:08:12 +00004447
Fariborz Jahanian52d02f62012-01-14 18:44:35 +00004448 if (Param->hasAttr<BlocksAttr>()) {
4449 Diag(Param->getLocation(), diag::err_block_on_nonlocal);
4450 Param->setInvalidDecl();
4451 }
Fariborz Jahanianca3566f2011-02-09 22:20:01 +00004452 S->AddDecl(Param);
4453 IdResolver.AddDecl(Param);
4454
Chris Lattnerc5ffed42008-04-04 06:12:32 +00004455 Params.push_back(Param);
4456 }
Fariborz Jahanianca3566f2011-02-09 22:20:01 +00004457
Fariborz Jahanian60462092010-04-08 00:30:06 +00004458 for (unsigned i = 0, e = CNumArgs; i != e; ++i) {
John McCall48871652010-08-21 09:40:31 +00004459 ParmVarDecl *Param = cast<ParmVarDecl>(CParamInfo[i].Param);
Fariborz Jahanian60462092010-04-08 00:30:06 +00004460 QualType ArgType = Param->getType();
4461 if (ArgType.isNull())
4462 ArgType = Context.getObjCIdType();
4463 else
4464 // Perform the default array/function conversions (C99 6.7.5.3p[7,8]).
Douglas Gregor84280642011-07-12 04:42:08 +00004465 ArgType = Context.getAdjustedParameterType(ArgType);
Eli Friedman31a5bcc2013-06-14 21:14:10 +00004466
Fariborz Jahanian60462092010-04-08 00:30:06 +00004467 Param->setDeclContext(ObjCMethod);
Fariborz Jahanian60462092010-04-08 00:30:06 +00004468 Params.push_back(Param);
4469 }
4470
Argyrios Kyrtzidisb8c3aaf2011-10-03 06:37:04 +00004471 ObjCMethod->setMethodParams(Context, Params, SelectorLocs);
Ted Kremenek1b0ea822008-01-07 19:49:32 +00004472 ObjCMethod->setObjCDeclQualifier(
4473 CvtQTToAstBitMask(ReturnQT.getObjCDeclQualifier()));
Daniel Dunbarc136e0c2008-09-26 04:12:28 +00004474
4475 if (AttrList)
Douglas Gregor758a8692009-06-17 21:51:59 +00004476 ProcessDeclAttributeList(TUScope, ObjCMethod, AttrList);
Alex Lorenz9e7bf162017-04-18 14:33:39 +00004477 AddPragmaAttributes(TUScope, ObjCMethod);
Mike Stump11289f42009-09-09 15:08:12 +00004478
Douglas Gregor87e92752010-12-21 17:34:17 +00004479 // Add the method now.
Craig Topperc3ec1492014-05-26 06:22:03 +00004480 const ObjCMethodDecl *PrevMethod = nullptr;
John McCalld2930c22011-07-22 02:45:48 +00004481 if (ObjCImplDecl *ImpDecl = dyn_cast<ObjCImplDecl>(ClassDecl)) {
Chris Lattnerda463fe2007-12-12 07:09:47 +00004482 if (MethodType == tok::minus) {
Argyrios Kyrtzidiscfbfe782009-06-30 02:36:12 +00004483 PrevMethod = ImpDecl->getInstanceMethod(Sel);
4484 ImpDecl->addInstanceMethod(ObjCMethod);
Chris Lattnerda463fe2007-12-12 07:09:47 +00004485 } else {
Argyrios Kyrtzidiscfbfe782009-06-30 02:36:12 +00004486 PrevMethod = ImpDecl->getClassMethod(Sel);
4487 ImpDecl->addClassMethod(ObjCMethod);
Chris Lattnerda463fe2007-12-12 07:09:47 +00004488 }
Douglas Gregor33823722011-06-11 01:09:30 +00004489
Douglas Gregor813a0662015-06-19 18:14:38 +00004490 // Merge information from the @interface declaration into the
4491 // @implementation.
4492 if (ObjCInterfaceDecl *IDecl = ImpDecl->getClassInterface()) {
4493 if (auto *IMD = IDecl->lookupMethod(ObjCMethod->getSelector(),
4494 ObjCMethod->isInstanceMethod())) {
4495 mergeInterfaceMethodToImpl(*this, ObjCMethod, IMD);
4496
4497 // Warn about defining -dealloc in a category.
4498 if (isa<ObjCCategoryImplDecl>(ImpDecl) && IMD->isOverriding() &&
4499 ObjCMethod->getSelector().getMethodFamily() == OMF_dealloc) {
4500 Diag(ObjCMethod->getLocation(), diag::warn_dealloc_in_category)
4501 << ObjCMethod->getDeclName();
4502 }
4503 }
Fariborz Jahanian7e350d22013-12-17 22:44:28 +00004504 }
Douglas Gregor87e92752010-12-21 17:34:17 +00004505 } else {
4506 cast<DeclContext>(ClassDecl)->addDecl(ObjCMethod);
Chris Lattnerda463fe2007-12-12 07:09:47 +00004507 }
John McCalld2930c22011-07-22 02:45:48 +00004508
Chris Lattnerda463fe2007-12-12 07:09:47 +00004509 if (PrevMethod) {
4510 // You can never have two method definitions with the same name.
Chris Lattner0369c572008-11-23 23:12:31 +00004511 Diag(ObjCMethod->getLocation(), diag::err_duplicate_method_decl)
Chris Lattnere4b95692008-11-24 03:33:13 +00004512 << ObjCMethod->getDeclName();
Chris Lattner0369c572008-11-23 23:12:31 +00004513 Diag(PrevMethod->getLocation(), diag::note_previous_declaration);
Fariborz Jahanian096f7c12013-05-13 17:27:00 +00004514 ObjCMethod->setInvalidDecl();
4515 return ObjCMethod;
Mike Stump11289f42009-09-09 15:08:12 +00004516 }
John McCall28a6aea2009-11-04 02:18:39 +00004517
Douglas Gregor33823722011-06-11 01:09:30 +00004518 // If this Objective-C method does not have a related result type, but we
4519 // are allowed to infer related result types, try to do so based on the
4520 // method family.
4521 ObjCInterfaceDecl *CurrentClass = dyn_cast<ObjCInterfaceDecl>(ClassDecl);
4522 if (!CurrentClass) {
4523 if (ObjCCategoryDecl *Cat = dyn_cast<ObjCCategoryDecl>(ClassDecl))
4524 CurrentClass = Cat->getClassInterface();
4525 else if (ObjCImplDecl *Impl = dyn_cast<ObjCImplDecl>(ClassDecl))
4526 CurrentClass = Impl->getClassInterface();
4527 else if (ObjCCategoryImplDecl *CatImpl
4528 = dyn_cast<ObjCCategoryImplDecl>(ClassDecl))
4529 CurrentClass = CatImpl->getClassInterface();
4530 }
John McCalld2930c22011-07-22 02:45:48 +00004531
Douglas Gregorbab8a962011-09-08 01:46:34 +00004532 ResultTypeCompatibilityKind RTC
4533 = CheckRelatedResultTypeCompatibility(*this, ObjCMethod, CurrentClass);
John McCalld2930c22011-07-22 02:45:48 +00004534
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00004535 CheckObjCMethodOverrides(ObjCMethod, CurrentClass, RTC);
John McCalld2930c22011-07-22 02:45:48 +00004536
John McCall31168b02011-06-15 23:02:42 +00004537 bool ARCError = false;
David Blaikiebbafb8a2012-03-11 07:00:24 +00004538 if (getLangOpts().ObjCAutoRefCount)
John McCalle48f3892013-04-04 01:38:37 +00004539 ARCError = CheckARCMethodDecl(ObjCMethod);
John McCall31168b02011-06-15 23:02:42 +00004540
Douglas Gregorbab8a962011-09-08 01:46:34 +00004541 // Infer the related result type when possible.
Argyrios Kyrtzidis08f96a92012-05-09 16:12:57 +00004542 if (!ARCError && RTC == Sema::RTC_Compatible &&
Douglas Gregorbab8a962011-09-08 01:46:34 +00004543 !ObjCMethod->hasRelatedResultType() &&
4544 LangOpts.ObjCInferRelatedResultType) {
Douglas Gregor33823722011-06-11 01:09:30 +00004545 bool InferRelatedResultType = false;
4546 switch (ObjCMethod->getMethodFamily()) {
4547 case OMF_None:
4548 case OMF_copy:
4549 case OMF_dealloc:
Nico Weber1fb82662011-08-28 22:35:17 +00004550 case OMF_finalize:
Douglas Gregor33823722011-06-11 01:09:30 +00004551 case OMF_mutableCopy:
4552 case OMF_release:
4553 case OMF_retainCount:
Fariborz Jahanian78e9deb2014-08-22 16:57:26 +00004554 case OMF_initialize:
Fariborz Jahanianb7a77362011-07-05 22:38:59 +00004555 case OMF_performSelector:
Douglas Gregor33823722011-06-11 01:09:30 +00004556 break;
4557
4558 case OMF_alloc:
4559 case OMF_new:
Fariborz Jahanian7a60b6d2015-04-16 18:38:44 +00004560 InferRelatedResultType = ObjCMethod->isClassMethod();
Douglas Gregor33823722011-06-11 01:09:30 +00004561 break;
4562
4563 case OMF_init:
4564 case OMF_autorelease:
4565 case OMF_retain:
4566 case OMF_self:
4567 InferRelatedResultType = ObjCMethod->isInstanceMethod();
4568 break;
4569 }
4570
Fariborz Jahanian7a60b6d2015-04-16 18:38:44 +00004571 if (InferRelatedResultType &&
4572 !ObjCMethod->getReturnType()->isObjCIndependentClassType())
Douglas Gregor33823722011-06-11 01:09:30 +00004573 ObjCMethod->SetRelatedResultType();
Douglas Gregor33823722011-06-11 01:09:30 +00004574 }
Dmitri Gribenkof26054f2012-07-11 21:38:39 +00004575
Alex Lorenza8a372d2017-04-27 10:43:48 +00004576 if (MethodDefinition &&
4577 Context.getTargetInfo().getTriple().getArch() == llvm::Triple::x86)
4578 checkObjCMethodX86VectorTypes(*this, ObjCMethod);
4579
Dmitri Gribenkof26054f2012-07-11 21:38:39 +00004580 ActOnDocumentableDecl(ObjCMethod);
4581
John McCall48871652010-08-21 09:40:31 +00004582 return ObjCMethod;
Chris Lattnerda463fe2007-12-12 07:09:47 +00004583}
4584
Chris Lattner438e5012008-12-17 07:13:27 +00004585bool Sema::CheckObjCDeclScope(Decl *D) {
Fariborz Jahanianf36734d2011-08-22 18:34:22 +00004586 // Following is also an error. But it is caused by a missing @end
4587 // and diagnostic is issued elsewhere.
Argyrios Kyrtzidis822c4332012-03-23 23:24:23 +00004588 if (isa<ObjCContainerDecl>(CurContext->getRedeclContext()))
Fariborz Jahanian8d382dc2011-08-22 15:54:49 +00004589 return false;
Argyrios Kyrtzidis822c4332012-03-23 23:24:23 +00004590
4591 // If we switched context to translation unit while we are still lexically in
4592 // an objc container, it means the parser missed emitting an error.
4593 if (isa<TranslationUnitDecl>(getCurLexicalContext()->getRedeclContext()))
4594 return false;
Fariborz Jahanian8d382dc2011-08-22 15:54:49 +00004595
Anders Carlssona6b508a2008-11-04 16:57:32 +00004596 Diag(D->getLocation(), diag::err_objc_decls_may_only_appear_in_global_scope);
4597 D->setInvalidDecl();
Mike Stump11289f42009-09-09 15:08:12 +00004598
Anders Carlssona6b508a2008-11-04 16:57:32 +00004599 return true;
4600}
Chris Lattner438e5012008-12-17 07:13:27 +00004601
James Dennett634962f2012-06-14 21:40:34 +00004602/// Called whenever \@defs(ClassName) is encountered in the source. Inserts the
Chris Lattner438e5012008-12-17 07:13:27 +00004603/// instance variables of ClassName into Decls.
John McCall48871652010-08-21 09:40:31 +00004604void Sema::ActOnDefs(Scope *S, Decl *TagD, SourceLocation DeclStart,
Chris Lattner438e5012008-12-17 07:13:27 +00004605 IdentifierInfo *ClassName,
Chris Lattner0e62c1c2011-07-23 10:55:15 +00004606 SmallVectorImpl<Decl*> &Decls) {
Chris Lattner438e5012008-12-17 07:13:27 +00004607 // Check that ClassName is a valid class
Douglas Gregorb2ccf012010-04-15 22:33:43 +00004608 ObjCInterfaceDecl *Class = getObjCInterfaceDecl(ClassName, DeclStart);
Chris Lattner438e5012008-12-17 07:13:27 +00004609 if (!Class) {
4610 Diag(DeclStart, diag::err_undef_interface) << ClassName;
4611 return;
4612 }
John McCall5fb5df92012-06-20 06:18:46 +00004613 if (LangOpts.ObjCRuntime.isNonFragile()) {
Fariborz Jahanianece1b2b2009-04-21 20:28:41 +00004614 Diag(DeclStart, diag::err_atdef_nonfragile_interface);
4615 return;
4616 }
Mike Stump11289f42009-09-09 15:08:12 +00004617
Chris Lattner438e5012008-12-17 07:13:27 +00004618 // Collect the instance variables
Jordy Rosea91768e2011-07-22 02:08:32 +00004619 SmallVector<const ObjCIvarDecl*, 32> Ivars;
Fariborz Jahaniana50b3a22010-08-20 21:21:08 +00004620 Context.DeepCollectObjCIvars(Class, true, Ivars);
Fariborz Jahanian7dae1142009-06-04 17:08:55 +00004621 // For each ivar, create a fresh ObjCAtDefsFieldDecl.
Fariborz Jahaniana50b3a22010-08-20 21:21:08 +00004622 for (unsigned i = 0; i < Ivars.size(); i++) {
Jordy Rosea91768e2011-07-22 02:08:32 +00004623 const FieldDecl* ID = cast<FieldDecl>(Ivars[i]);
John McCall48871652010-08-21 09:40:31 +00004624 RecordDecl *Record = dyn_cast<RecordDecl>(TagD);
Abramo Bagnaradff19302011-03-08 08:55:46 +00004625 Decl *FD = ObjCAtDefsFieldDecl::Create(Context, Record,
4626 /*FIXME: StartL=*/ID->getLocation(),
4627 ID->getLocation(),
Fariborz Jahanian7dae1142009-06-04 17:08:55 +00004628 ID->getIdentifier(), ID->getType(),
4629 ID->getBitWidth());
John McCall48871652010-08-21 09:40:31 +00004630 Decls.push_back(FD);
Fariborz Jahanian7dae1142009-06-04 17:08:55 +00004631 }
Mike Stump11289f42009-09-09 15:08:12 +00004632
Chris Lattner438e5012008-12-17 07:13:27 +00004633 // Introduce all of these fields into the appropriate scope.
Chris Lattner0e62c1c2011-07-23 10:55:15 +00004634 for (SmallVectorImpl<Decl*>::iterator D = Decls.begin();
Chris Lattner438e5012008-12-17 07:13:27 +00004635 D != Decls.end(); ++D) {
John McCall48871652010-08-21 09:40:31 +00004636 FieldDecl *FD = cast<FieldDecl>(*D);
David Blaikiebbafb8a2012-03-11 07:00:24 +00004637 if (getLangOpts().CPlusPlus)
Chris Lattner438e5012008-12-17 07:13:27 +00004638 PushOnScopeChains(cast<FieldDecl>(FD), S);
John McCall48871652010-08-21 09:40:31 +00004639 else if (RecordDecl *Record = dyn_cast<RecordDecl>(TagD))
Argyrios Kyrtzidiscfbfe782009-06-30 02:36:12 +00004640 Record->addDecl(FD);
Chris Lattner438e5012008-12-17 07:13:27 +00004641 }
4642}
4643
Douglas Gregorf3564192010-04-26 17:32:49 +00004644/// \brief Build a type-check a new Objective-C exception variable declaration.
Abramo Bagnaradff19302011-03-08 08:55:46 +00004645VarDecl *Sema::BuildObjCExceptionDecl(TypeSourceInfo *TInfo, QualType T,
4646 SourceLocation StartLoc,
4647 SourceLocation IdLoc,
4648 IdentifierInfo *Id,
Douglas Gregorf3564192010-04-26 17:32:49 +00004649 bool Invalid) {
4650 // ISO/IEC TR 18037 S6.7.3: "The type of an object with automatic storage
4651 // duration shall not be qualified by an address-space qualifier."
4652 // Since all parameters have automatic store duration, they can not have
4653 // an address space.
4654 if (T.getAddressSpace() != 0) {
Abramo Bagnaradff19302011-03-08 08:55:46 +00004655 Diag(IdLoc, diag::err_arg_with_address_space);
Douglas Gregorf3564192010-04-26 17:32:49 +00004656 Invalid = true;
4657 }
4658
4659 // An @catch parameter must be an unqualified object pointer type;
4660 // FIXME: Recover from "NSObject foo" by inserting the * in "NSObject *foo"?
4661 if (Invalid) {
4662 // Don't do any further checking.
Douglas Gregorf4e837f2010-04-26 17:57:08 +00004663 } else if (T->isDependentType()) {
4664 // Okay: we don't know what this type will instantiate to.
Douglas Gregorf3564192010-04-26 17:32:49 +00004665 } else if (!T->isObjCObjectPointerType()) {
4666 Invalid = true;
Abramo Bagnaradff19302011-03-08 08:55:46 +00004667 Diag(IdLoc ,diag::err_catch_param_not_objc_type);
Douglas Gregorf3564192010-04-26 17:32:49 +00004668 } else if (T->isObjCQualifiedIdType()) {
4669 Invalid = true;
Abramo Bagnaradff19302011-03-08 08:55:46 +00004670 Diag(IdLoc, diag::err_illegal_qualifiers_on_catch_parm);
Douglas Gregorf3564192010-04-26 17:32:49 +00004671 }
4672
Abramo Bagnaradff19302011-03-08 08:55:46 +00004673 VarDecl *New = VarDecl::Create(Context, CurContext, StartLoc, IdLoc, Id,
Rafael Espindola6ae7e502013-04-03 19:27:57 +00004674 T, TInfo, SC_None);
Douglas Gregor3f324d562010-05-03 18:51:14 +00004675 New->setExceptionVariable(true);
4676
Douglas Gregor8ca0c642011-12-10 01:22:52 +00004677 // In ARC, infer 'retaining' for variables of retainable type.
David Blaikiebbafb8a2012-03-11 07:00:24 +00004678 if (getLangOpts().ObjCAutoRefCount && inferObjCARCLifetime(New))
Douglas Gregor8ca0c642011-12-10 01:22:52 +00004679 Invalid = true;
4680
Douglas Gregorf3564192010-04-26 17:32:49 +00004681 if (Invalid)
4682 New->setInvalidDecl();
4683 return New;
4684}
4685
John McCall48871652010-08-21 09:40:31 +00004686Decl *Sema::ActOnObjCExceptionDecl(Scope *S, Declarator &D) {
Douglas Gregorf3564192010-04-26 17:32:49 +00004687 const DeclSpec &DS = D.getDeclSpec();
4688
4689 // We allow the "register" storage class on exception variables because
4690 // GCC did, but we drop it completely. Any other storage class is an error.
4691 if (DS.getStorageClassSpec() == DeclSpec::SCS_register) {
4692 Diag(DS.getStorageClassSpecLoc(), diag::warn_register_objc_catch_parm)
4693 << FixItHint::CreateRemoval(SourceRange(DS.getStorageClassSpecLoc()));
Richard Smithb4a9e862013-04-12 22:46:28 +00004694 } else if (DeclSpec::SCS SCS = DS.getStorageClassSpec()) {
Douglas Gregorf3564192010-04-26 17:32:49 +00004695 Diag(DS.getStorageClassSpecLoc(), diag::err_storage_spec_on_catch_parm)
Richard Smithb4a9e862013-04-12 22:46:28 +00004696 << DeclSpec::getSpecifierName(SCS);
4697 }
Richard Smith62f19e72016-06-25 00:15:56 +00004698 if (DS.isInlineSpecified())
4699 Diag(DS.getInlineSpecLoc(), diag::err_inline_non_function)
4700 << getLangOpts().CPlusPlus1z;
Richard Smithb4a9e862013-04-12 22:46:28 +00004701 if (DeclSpec::TSCS TSCS = D.getDeclSpec().getThreadStorageClassSpec())
4702 Diag(D.getDeclSpec().getThreadStorageClassSpecLoc(),
4703 diag::err_invalid_thread)
4704 << DeclSpec::getSpecifierName(TSCS);
Douglas Gregorf3564192010-04-26 17:32:49 +00004705 D.getMutableDeclSpec().ClearStorageClassSpecs();
4706
Richard Smithb1402ae2013-03-18 22:52:47 +00004707 DiagnoseFunctionSpecifiers(D.getDeclSpec());
Douglas Gregorf3564192010-04-26 17:32:49 +00004708
4709 // Check that there are no default arguments inside the type of this
4710 // exception object (C++ only).
David Blaikiebbafb8a2012-03-11 07:00:24 +00004711 if (getLangOpts().CPlusPlus)
Douglas Gregorf3564192010-04-26 17:32:49 +00004712 CheckExtraCXXDefaultArguments(D);
4713
Argyrios Kyrtzidisef7022f2011-06-28 03:01:15 +00004714 TypeSourceInfo *TInfo = GetTypeForDeclarator(D, S);
John McCall8cb7bdf2010-06-04 23:28:52 +00004715 QualType ExceptionType = TInfo->getType();
Douglas Gregorf3564192010-04-26 17:32:49 +00004716
Abramo Bagnaradff19302011-03-08 08:55:46 +00004717 VarDecl *New = BuildObjCExceptionDecl(TInfo, ExceptionType,
4718 D.getSourceRange().getBegin(),
4719 D.getIdentifierLoc(),
4720 D.getIdentifier(),
Douglas Gregorf3564192010-04-26 17:32:49 +00004721 D.isInvalidType());
4722
4723 // Parameter declarators cannot be qualified (C++ [dcl.meaning]p1).
4724 if (D.getCXXScopeSpec().isSet()) {
4725 Diag(D.getIdentifierLoc(), diag::err_qualified_objc_catch_parm)
4726 << D.getCXXScopeSpec().getRange();
4727 New->setInvalidDecl();
4728 }
4729
4730 // Add the parameter declaration into this scope.
John McCall48871652010-08-21 09:40:31 +00004731 S->AddDecl(New);
Douglas Gregorf3564192010-04-26 17:32:49 +00004732 if (D.getIdentifier())
4733 IdResolver.AddDecl(New);
4734
4735 ProcessDeclAttributes(S, New, D);
4736
4737 if (New->hasAttr<BlocksAttr>())
4738 Diag(New->getLocation(), diag::err_block_on_nonlocal);
John McCall48871652010-08-21 09:40:31 +00004739 return New;
Douglas Gregore11ee112010-04-23 23:01:43 +00004740}
Fariborz Jahanian38b77a92010-04-27 17:18:58 +00004741
4742/// CollectIvarsToConstructOrDestruct - Collect those ivars which require
Fariborz Jahanianc83726e2010-04-28 16:11:27 +00004743/// initialization.
Fariborz Jahaniana50b3a22010-08-20 21:21:08 +00004744void Sema::CollectIvarsToConstructOrDestruct(ObjCInterfaceDecl *OI,
Chris Lattner0e62c1c2011-07-23 10:55:15 +00004745 SmallVectorImpl<ObjCIvarDecl*> &Ivars) {
Fariborz Jahaniana50b3a22010-08-20 21:21:08 +00004746 for (ObjCIvarDecl *Iv = OI->all_declared_ivar_begin(); Iv;
4747 Iv= Iv->getNextIvar()) {
Fariborz Jahanian38b77a92010-04-27 17:18:58 +00004748 QualType QT = Context.getBaseElementType(Iv->getType());
Douglas Gregor527786e2010-05-20 02:24:22 +00004749 if (QT->isRecordType())
Fariborz Jahaniana50b3a22010-08-20 21:21:08 +00004750 Ivars.push_back(Iv);
Fariborz Jahanian38b77a92010-04-27 17:18:58 +00004751 }
4752}
Fariborz Jahanianc83726e2010-04-28 16:11:27 +00004753
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00004754void Sema::DiagnoseUseOfUnimplementedSelectors() {
Douglas Gregor72e357f2011-07-28 14:54:22 +00004755 // Load referenced selectors from the external source.
4756 if (ExternalSource) {
4757 SmallVector<std::pair<Selector, SourceLocation>, 4> Sels;
4758 ExternalSource->ReadReferencedSelectors(Sels);
4759 for (unsigned I = 0, N = Sels.size(); I != N; ++I)
4760 ReferencedSelectors[Sels[I].first] = Sels[I].second;
4761 }
4762
Fariborz Jahanianc9b7c202011-02-04 23:19:27 +00004763 // Warning will be issued only when selector table is
4764 // generated (which means there is at lease one implementation
4765 // in the TU). This is to match gcc's behavior.
4766 if (ReferencedSelectors.empty() ||
4767 !Context.AnyObjCImplementation())
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00004768 return;
Chandler Carruth12c8f652015-03-27 00:55:05 +00004769 for (auto &SelectorAndLocation : ReferencedSelectors) {
4770 Selector Sel = SelectorAndLocation.first;
4771 SourceLocation Loc = SelectorAndLocation.second;
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00004772 if (!LookupImplementedMethodInGlobalPool(Sel))
Chandler Carruth12c8f652015-03-27 00:55:05 +00004773 Diag(Loc, diag::warn_unimplemented_selector) << Sel;
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00004774 }
Fariborz Jahanian6e7e8cc2010-07-22 18:24:20 +00004775}
Fariborz Jahanian5e3429c2013-10-25 21:44:50 +00004776
4777ObjCIvarDecl *
4778Sema::GetIvarBackingPropertyAccessor(const ObjCMethodDecl *Method,
4779 const ObjCPropertyDecl *&PDecl) const {
Fariborz Jahanian1cc7ae12014-01-02 17:24:32 +00004780 if (Method->isClassMethod())
Craig Topperc3ec1492014-05-26 06:22:03 +00004781 return nullptr;
Fariborz Jahanian5e3429c2013-10-25 21:44:50 +00004782 const ObjCInterfaceDecl *IDecl = Method->getClassInterface();
4783 if (!IDecl)
Craig Topperc3ec1492014-05-26 06:22:03 +00004784 return nullptr;
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00004785 Method = IDecl->lookupMethod(Method->getSelector(), /*isInstance=*/true,
4786 /*shallowCategoryLookup=*/false,
4787 /*followSuper=*/false);
Fariborz Jahanian5e3429c2013-10-25 21:44:50 +00004788 if (!Method || !Method->isPropertyAccessor())
Craig Topperc3ec1492014-05-26 06:22:03 +00004789 return nullptr;
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00004790 if ((PDecl = Method->findPropertyDecl()))
Fariborz Jahanian122d94f2014-01-27 22:27:43 +00004791 if (ObjCIvarDecl *IV = PDecl->getPropertyIvarDecl()) {
4792 // property backing ivar must belong to property's class
4793 // or be a private ivar in class's implementation.
4794 // FIXME. fix the const-ness issue.
4795 IV = const_cast<ObjCInterfaceDecl *>(IDecl)->lookupInstanceVariable(
4796 IV->getIdentifier());
4797 return IV;
4798 }
Craig Topperc3ec1492014-05-26 06:22:03 +00004799 return nullptr;
Fariborz Jahanian5e3429c2013-10-25 21:44:50 +00004800}
4801
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00004802namespace {
4803 /// Used by Sema::DiagnoseUnusedBackingIvarInAccessor to check if a property
4804 /// accessor references the backing ivar.
Argyrios Kyrtzidis98045c12014-01-03 19:53:09 +00004805 class UnusedBackingIvarChecker :
Richard Smith50668452015-11-24 03:55:01 +00004806 public RecursiveASTVisitor<UnusedBackingIvarChecker> {
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00004807 public:
4808 Sema &S;
4809 const ObjCMethodDecl *Method;
4810 const ObjCIvarDecl *IvarD;
4811 bool AccessedIvar;
4812 bool InvokedSelfMethod;
4813
4814 UnusedBackingIvarChecker(Sema &S, const ObjCMethodDecl *Method,
4815 const ObjCIvarDecl *IvarD)
4816 : S(S), Method(Method), IvarD(IvarD),
4817 AccessedIvar(false), InvokedSelfMethod(false) {
4818 assert(IvarD);
4819 }
4820
4821 bool VisitObjCIvarRefExpr(ObjCIvarRefExpr *E) {
4822 if (E->getDecl() == IvarD) {
4823 AccessedIvar = true;
4824 return false;
4825 }
4826 return true;
4827 }
4828
4829 bool VisitObjCMessageExpr(ObjCMessageExpr *E) {
4830 if (E->getReceiverKind() == ObjCMessageExpr::Instance &&
4831 S.isSelfExpr(E->getInstanceReceiver(), Method)) {
4832 InvokedSelfMethod = true;
4833 }
4834 return true;
4835 }
4836 };
Hans Wennborgdcfba332015-10-06 23:40:43 +00004837} // end anonymous namespace
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00004838
4839void Sema::DiagnoseUnusedBackingIvarInAccessor(Scope *S,
4840 const ObjCImplementationDecl *ImplD) {
4841 if (S->hasUnrecoverableErrorOccurred())
Fariborz Jahanian5e3429c2013-10-25 21:44:50 +00004842 return;
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00004843
Aaron Ballmanf26acce2014-03-13 19:50:17 +00004844 for (const auto *CurMethod : ImplD->instance_methods()) {
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00004845 unsigned DIAG = diag::warn_unused_property_backing_ivar;
4846 SourceLocation Loc = CurMethod->getLocation();
Alp Tokerd4a3f0e2014-06-15 23:30:39 +00004847 if (Diags.isIgnored(DIAG, Loc))
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00004848 continue;
4849
4850 const ObjCPropertyDecl *PDecl;
4851 const ObjCIvarDecl *IV = GetIvarBackingPropertyAccessor(CurMethod, PDecl);
4852 if (!IV)
4853 continue;
4854
4855 UnusedBackingIvarChecker Checker(*this, CurMethod, IV);
4856 Checker.TraverseStmt(CurMethod->getBody());
4857 if (Checker.AccessedIvar)
4858 continue;
4859
Fariborz Jahanian5b3105d2014-01-02 22:42:09 +00004860 // Do not issue this warning if backing ivar is used somewhere and accessor
Argyrios Kyrtzidis2080d902014-01-03 18:32:18 +00004861 // implementation makes a self call. This is to prevent false positive in
4862 // cases where the ivar is accessed by another method that the accessor
4863 // delegates to.
4864 if (!IV->isReferenced() || !Checker.InvokedSelfMethod) {
Argyrios Kyrtzidisd8a35322014-01-03 19:39:23 +00004865 Diag(Loc, DIAG) << IV;
Fariborz Jahanian5b3105d2014-01-02 22:42:09 +00004866 Diag(PDecl->getLocation(), diag::note_property_declare);
4867 }
Fariborz Jahanian5e3429c2013-10-25 21:44:50 +00004868 }
4869}