blob: b80e9ade75d4620e6e4052ee834ba22a7be4deaf [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
Chandler Carruth2946cd72019-01-19 08:50:56 +00003// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Chris Lattner2188e402010-01-04 07:37:31 +00006//
7//===----------------------------------------------------------------------===//
8//
9// This file implements the visitICmp and visitFCmp functions.
10//
11//===----------------------------------------------------------------------===//
12
Chandler Carrutha9174582015-01-22 05:25:13 +000013#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000014#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000015#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000016#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000017#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000018#include "llvm/Analysis/InstructionSimplify.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000019#include "llvm/Analysis/TargetLibraryInfo.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000020#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000021#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000022#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000023#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000024#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000025#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000026#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000027
Chris Lattner2188e402010-01-04 07:37:31 +000028using namespace llvm;
29using namespace PatternMatch;
30
Chandler Carruth964daaa2014-04-22 02:55:47 +000031#define DEBUG_TYPE "instcombine"
32
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000033// How many times is a select replaced by one of its operands?
34STATISTIC(NumSel, "Number of select opts");
35
Chris Lattner98457102011-02-10 05:23:05 +000036
Sanjay Patel5f0217f2016-06-05 16:46:18 +000037/// Compute Result = In1+In2, returning true if the result overflowed for this
38/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000039static bool addWithOverflow(APInt &Result, const APInt &In1,
40 const APInt &In2, bool IsSigned = false) {
41 bool Overflow;
42 if (IsSigned)
43 Result = In1.sadd_ov(In2, Overflow);
44 else
45 Result = In1.uadd_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000046
Craig Topper6e025a32017-10-01 23:53:54 +000047 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000048}
49
Sanjay Patel5f0217f2016-06-05 16:46:18 +000050/// Compute Result = In1-In2, returning true if the result overflowed for this
51/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000052static bool subWithOverflow(APInt &Result, const APInt &In1,
53 const APInt &In2, bool IsSigned = false) {
54 bool Overflow;
55 if (IsSigned)
56 Result = In1.ssub_ov(In2, Overflow);
57 else
58 Result = In1.usub_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000059
Craig Topper6e025a32017-10-01 23:53:54 +000060 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000061}
62
Balaram Makam569eaec2016-05-04 21:32:14 +000063/// Given an icmp instruction, return true if any use of this comparison is a
64/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +000065static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +000066 for (auto *U : I.users())
67 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +000068 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +000069 return false;
70}
71
Sanjay Patel5f0217f2016-06-05 16:46:18 +000072/// Given an exploded icmp instruction, return true if the comparison only
73/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
74/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +000075static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +000076 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +000077 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +000078 case ICmpInst::ICMP_SLT: // True if LHS s< 0
79 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +000080 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +000081 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
82 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000083 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000084 case ICmpInst::ICMP_SGT: // True if LHS s> -1
85 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +000086 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000087 case ICmpInst::ICMP_UGT:
88 // True if LHS u> RHS and RHS == high-bit-mask - 1
89 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000090 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +000091 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +000092 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
93 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +000094 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +000095 default:
96 return false;
97 }
98}
99
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000100/// Returns true if the exploded icmp can be expressed as a signed comparison
101/// to zero and updates the predicate accordingly.
102/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000103/// TODO: Refactor with decomposeBitTestICmp()?
104static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000105 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000106 return false;
107
Craig Topper73ba1c82017-06-07 07:40:37 +0000108 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000109 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000110
Craig Topper73ba1c82017-06-07 07:40:37 +0000111 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000112 if (Pred == ICmpInst::ICMP_SLT) {
113 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000114 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000115 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000116 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000117 if (Pred == ICmpInst::ICMP_SGT) {
118 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000119 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000120 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000121 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000122
123 return false;
124}
125
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000126/// Given a signed integer type and a set of known zero and one bits, compute
127/// the maximum and minimum values that could have the specified known zero and
128/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000129/// TODO: Move to method on KnownBits struct?
130static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000131 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000132 assert(Known.getBitWidth() == Min.getBitWidth() &&
133 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000134 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000135 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000136
137 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
138 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000139 Min = Known.One;
140 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000141
Chris Lattner2188e402010-01-04 07:37:31 +0000142 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000143 Min.setSignBit();
144 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000145 }
146}
147
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000148/// Given an unsigned integer type and a set of known zero and one bits, compute
149/// the maximum and minimum values that could have the specified known zero and
150/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000151/// TODO: Move to method on KnownBits struct?
152static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000153 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000154 assert(Known.getBitWidth() == Min.getBitWidth() &&
155 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000156 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000157 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000158
Chris Lattner2188e402010-01-04 07:37:31 +0000159 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000160 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000161 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000162 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000163}
164
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000165/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000166/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000167/// where GV is a global variable with a constant initializer. Try to simplify
168/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000169/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
170///
171/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000172/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000173Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
174 GlobalVariable *GV,
175 CmpInst &ICI,
176 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000177 Constant *Init = GV->getInitializer();
178 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000179 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000180
Chris Lattnerfe741762012-01-31 02:55:06 +0000181 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000182 // Don't blow up on huge arrays.
183 if (ArrayElementCount > MaxArraySizeForCombine)
184 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000185
Chris Lattner2188e402010-01-04 07:37:31 +0000186 // There are many forms of this optimization we can handle, for now, just do
187 // the simple index into a single-dimensional array.
188 //
189 // Require: GEP GV, 0, i {{, constant indices}}
190 if (GEP->getNumOperands() < 3 ||
191 !isa<ConstantInt>(GEP->getOperand(1)) ||
192 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
193 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000194 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000195
196 // Check that indices after the variable are constants and in-range for the
197 // type they index. Collect the indices. This is typically for arrays of
198 // structs.
199 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000200
Chris Lattnerfe741762012-01-31 02:55:06 +0000201 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000202 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
203 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000204 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000205
Chris Lattner2188e402010-01-04 07:37:31 +0000206 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000207 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000208
Chris Lattner229907c2011-07-18 04:54:35 +0000209 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000210 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000211 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000212 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000213 EltTy = ATy->getElementType();
214 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000215 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000216 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000217
Chris Lattner2188e402010-01-04 07:37:31 +0000218 LaterIndices.push_back(IdxVal);
219 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000220
Chris Lattner2188e402010-01-04 07:37:31 +0000221 enum { Overdefined = -3, Undefined = -2 };
222
223 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000224
Chris Lattner2188e402010-01-04 07:37:31 +0000225 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
226 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
227 // and 87 is the second (and last) index. FirstTrueElement is -2 when
228 // undefined, otherwise set to the first true element. SecondTrueElement is
229 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
230 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
231
232 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
233 // form "i != 47 & i != 87". Same state transitions as for true elements.
234 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000235
Chris Lattner2188e402010-01-04 07:37:31 +0000236 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
237 /// define a state machine that triggers for ranges of values that the index
238 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
239 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
240 /// index in the range (inclusive). We use -2 for undefined here because we
241 /// use relative comparisons and don't want 0-1 to match -1.
242 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000243
Chris Lattner2188e402010-01-04 07:37:31 +0000244 // MagicBitvector - This is a magic bitvector where we set a bit if the
245 // comparison is true for element 'i'. If there are 64 elements or less in
246 // the array, this will fully represent all the comparison results.
247 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000248
Chris Lattner2188e402010-01-04 07:37:31 +0000249 // Scan the array and see if one of our patterns matches.
250 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000251 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
252 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000253 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000254
Chris Lattner2188e402010-01-04 07:37:31 +0000255 // If this is indexing an array of structures, get the structure element.
256 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000257 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000258
Chris Lattner2188e402010-01-04 07:37:31 +0000259 // If the element is masked, handle it.
260 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000261
Chris Lattner2188e402010-01-04 07:37:31 +0000262 // Find out if the comparison would be true or false for the i'th element.
263 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000264 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000265 // If the result is undef for this element, ignore it.
266 if (isa<UndefValue>(C)) {
267 // Extend range state machines to cover this element in case there is an
268 // undef in the middle of the range.
269 if (TrueRangeEnd == (int)i-1)
270 TrueRangeEnd = i;
271 if (FalseRangeEnd == (int)i-1)
272 FalseRangeEnd = i;
273 continue;
274 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000275
Chris Lattner2188e402010-01-04 07:37:31 +0000276 // If we can't compute the result for any of the elements, we have to give
277 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000278 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000279
Chris Lattner2188e402010-01-04 07:37:31 +0000280 // Otherwise, we know if the comparison is true or false for this element,
281 // update our state machines.
282 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000283
Chris Lattner2188e402010-01-04 07:37:31 +0000284 // State machine for single/double/range index comparison.
285 if (IsTrueForElt) {
286 // Update the TrueElement state machine.
287 if (FirstTrueElement == Undefined)
288 FirstTrueElement = TrueRangeEnd = i; // First true element.
289 else {
290 // Update double-compare state machine.
291 if (SecondTrueElement == Undefined)
292 SecondTrueElement = i;
293 else
294 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000295
Chris Lattner2188e402010-01-04 07:37:31 +0000296 // Update range state machine.
297 if (TrueRangeEnd == (int)i-1)
298 TrueRangeEnd = i;
299 else
300 TrueRangeEnd = Overdefined;
301 }
302 } else {
303 // Update the FalseElement state machine.
304 if (FirstFalseElement == Undefined)
305 FirstFalseElement = FalseRangeEnd = i; // First false element.
306 else {
307 // Update double-compare state machine.
308 if (SecondFalseElement == Undefined)
309 SecondFalseElement = i;
310 else
311 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000312
Chris Lattner2188e402010-01-04 07:37:31 +0000313 // Update range state machine.
314 if (FalseRangeEnd == (int)i-1)
315 FalseRangeEnd = i;
316 else
317 FalseRangeEnd = Overdefined;
318 }
319 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000320
Chris Lattner2188e402010-01-04 07:37:31 +0000321 // If this element is in range, update our magic bitvector.
322 if (i < 64 && IsTrueForElt)
323 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000324
Chris Lattner2188e402010-01-04 07:37:31 +0000325 // If all of our states become overdefined, bail out early. Since the
326 // predicate is expensive, only check it every 8 elements. This is only
327 // really useful for really huge arrays.
328 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
329 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
330 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000331 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000332 }
333
334 // Now that we've scanned the entire array, emit our new comparison(s). We
335 // order the state machines in complexity of the generated code.
336 Value *Idx = GEP->getOperand(2);
337
Matt Arsenault5aeae182013-08-19 21:40:31 +0000338 // If the index is larger than the pointer size of the target, truncate the
339 // index down like the GEP would do implicitly. We don't have to do this for
340 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000341 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000342 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000343 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
344 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000345 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000346 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000347
Chris Lattner2188e402010-01-04 07:37:31 +0000348 // If the comparison is only true for one or two elements, emit direct
349 // comparisons.
350 if (SecondTrueElement != Overdefined) {
351 // None true -> false.
352 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000353 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000354
Chris Lattner2188e402010-01-04 07:37:31 +0000355 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000356
Chris Lattner2188e402010-01-04 07:37:31 +0000357 // True for one element -> 'i == 47'.
358 if (SecondTrueElement == Undefined)
359 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000360
Chris Lattner2188e402010-01-04 07:37:31 +0000361 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000362 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000363 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000364 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000365 return BinaryOperator::CreateOr(C1, C2);
366 }
367
368 // If the comparison is only false for one or two elements, emit direct
369 // comparisons.
370 if (SecondFalseElement != Overdefined) {
371 // None false -> true.
372 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000373 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000374
Chris Lattner2188e402010-01-04 07:37:31 +0000375 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
376
377 // False for one element -> 'i != 47'.
378 if (SecondFalseElement == Undefined)
379 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000380
Chris Lattner2188e402010-01-04 07:37:31 +0000381 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000382 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000383 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000384 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000385 return BinaryOperator::CreateAnd(C1, C2);
386 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000387
Chris Lattner2188e402010-01-04 07:37:31 +0000388 // If the comparison can be replaced with a range comparison for the elements
389 // where it is true, emit the range check.
390 if (TrueRangeEnd != Overdefined) {
391 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000392
Chris Lattner2188e402010-01-04 07:37:31 +0000393 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
394 if (FirstTrueElement) {
395 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000396 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000397 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000398
Chris Lattner2188e402010-01-04 07:37:31 +0000399 Value *End = ConstantInt::get(Idx->getType(),
400 TrueRangeEnd-FirstTrueElement+1);
401 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
402 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000403
Chris Lattner2188e402010-01-04 07:37:31 +0000404 // False range check.
405 if (FalseRangeEnd != Overdefined) {
406 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
407 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
408 if (FirstFalseElement) {
409 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000410 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000411 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000412
Chris Lattner2188e402010-01-04 07:37:31 +0000413 Value *End = ConstantInt::get(Idx->getType(),
414 FalseRangeEnd-FirstFalseElement);
415 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
416 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000417
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000418 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000419 // of this load, replace it with computation that does:
420 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000421 {
Craig Topperf40110f2014-04-25 05:29:35 +0000422 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000423
424 // Look for an appropriate type:
425 // - The type of Idx if the magic fits
Craig Topper386fc252017-11-07 17:37:32 +0000426 // - The smallest fitting legal type
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000427 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
428 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000429 else
430 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000431
Craig Topperf40110f2014-04-25 05:29:35 +0000432 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000433 Value *V = Builder.CreateIntCast(Idx, Ty, false);
434 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
435 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000436 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
437 }
Chris Lattner2188e402010-01-04 07:37:31 +0000438 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000439
Craig Topperf40110f2014-04-25 05:29:35 +0000440 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000441}
442
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000443/// Return a value that can be used to compare the *offset* implied by a GEP to
444/// zero. For example, if we have &A[i], we want to return 'i' for
445/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
446/// are involved. The above expression would also be legal to codegen as
447/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
448/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000449/// to generate the first by knowing that pointer arithmetic doesn't overflow.
450///
451/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000452///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000453static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000454 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000455 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000456
Chris Lattner2188e402010-01-04 07:37:31 +0000457 // Check to see if this gep only has a single variable index. If so, and if
458 // any constant indices are a multiple of its scale, then we can compute this
459 // in terms of the scale of the variable index. For example, if the GEP
460 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
461 // because the expression will cross zero at the same point.
462 unsigned i, e = GEP->getNumOperands();
463 int64_t Offset = 0;
464 for (i = 1; i != e; ++i, ++GTI) {
465 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
466 // Compute the aggregate offset of constant indices.
467 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000468
Chris Lattner2188e402010-01-04 07:37:31 +0000469 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000470 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000471 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000472 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000473 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000474 Offset += Size*CI->getSExtValue();
475 }
476 } else {
477 // Found our variable index.
478 break;
479 }
480 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000481
Chris Lattner2188e402010-01-04 07:37:31 +0000482 // If there are no variable indices, we must have a constant offset, just
483 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000484 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000485
Chris Lattner2188e402010-01-04 07:37:31 +0000486 Value *VariableIdx = GEP->getOperand(i);
487 // Determine the scale factor of the variable element. For example, this is
488 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000489 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000490
Chris Lattner2188e402010-01-04 07:37:31 +0000491 // Verify that there are no other variable indices. If so, emit the hard way.
492 for (++i, ++GTI; i != e; ++i, ++GTI) {
493 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000494 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000495
Chris Lattner2188e402010-01-04 07:37:31 +0000496 // Compute the aggregate offset of constant indices.
497 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000498
Chris Lattner2188e402010-01-04 07:37:31 +0000499 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000500 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000501 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000502 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000503 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000504 Offset += Size*CI->getSExtValue();
505 }
506 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000507
Chris Lattner2188e402010-01-04 07:37:31 +0000508 // Okay, we know we have a single variable index, which must be a
509 // pointer/array/vector index. If there is no offset, life is simple, return
510 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000511 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000512 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000513 if (Offset == 0) {
514 // Cast to intptrty in case a truncation occurs. If an extension is needed,
515 // we don't need to bother extending: the extension won't affect where the
516 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000517 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000518 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000519 }
Chris Lattner2188e402010-01-04 07:37:31 +0000520 return VariableIdx;
521 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000522
Chris Lattner2188e402010-01-04 07:37:31 +0000523 // Otherwise, there is an index. The computation we will do will be modulo
Nikita Popov36e03ac2018-12-12 23:19:03 +0000524 // the pointer size.
525 Offset = SignExtend64(Offset, IntPtrWidth);
526 VariableScale = SignExtend64(VariableScale, IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000527
Chris Lattner2188e402010-01-04 07:37:31 +0000528 // To do this transformation, any constant index must be a multiple of the
529 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
530 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
531 // multiple of the variable scale.
532 int64_t NewOffs = Offset / (int64_t)VariableScale;
533 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000534 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000535
Chris Lattner2188e402010-01-04 07:37:31 +0000536 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000537 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000538 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000539 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000540 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000541 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000542}
543
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000544/// Returns true if we can rewrite Start as a GEP with pointer Base
545/// and some integer offset. The nodes that need to be re-written
546/// for this transformation will be added to Explored.
547static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
548 const DataLayout &DL,
549 SetVector<Value *> &Explored) {
550 SmallVector<Value *, 16> WorkList(1, Start);
551 Explored.insert(Base);
552
553 // The following traversal gives us an order which can be used
554 // when doing the final transformation. Since in the final
555 // transformation we create the PHI replacement instructions first,
556 // we don't have to get them in any particular order.
557 //
558 // However, for other instructions we will have to traverse the
559 // operands of an instruction first, which means that we have to
560 // do a post-order traversal.
561 while (!WorkList.empty()) {
562 SetVector<PHINode *> PHIs;
563
564 while (!WorkList.empty()) {
565 if (Explored.size() >= 100)
566 return false;
567
568 Value *V = WorkList.back();
569
570 if (Explored.count(V) != 0) {
571 WorkList.pop_back();
572 continue;
573 }
574
575 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000576 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000577 // We've found some value that we can't explore which is different from
578 // the base. Therefore we can't do this transformation.
579 return false;
580
581 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
582 auto *CI = dyn_cast<CastInst>(V);
583 if (!CI->isNoopCast(DL))
584 return false;
585
586 if (Explored.count(CI->getOperand(0)) == 0)
587 WorkList.push_back(CI->getOperand(0));
588 }
589
590 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
591 // We're limiting the GEP to having one index. This will preserve
592 // the original pointer type. We could handle more cases in the
593 // future.
594 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
595 GEP->getType() != Start->getType())
596 return false;
597
598 if (Explored.count(GEP->getOperand(0)) == 0)
599 WorkList.push_back(GEP->getOperand(0));
600 }
601
602 if (WorkList.back() == V) {
603 WorkList.pop_back();
604 // We've finished visiting this node, mark it as such.
605 Explored.insert(V);
606 }
607
608 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000609 // We cannot transform PHIs on unsplittable basic blocks.
610 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
611 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000612 Explored.insert(PN);
613 PHIs.insert(PN);
614 }
615 }
616
617 // Explore the PHI nodes further.
618 for (auto *PN : PHIs)
619 for (Value *Op : PN->incoming_values())
620 if (Explored.count(Op) == 0)
621 WorkList.push_back(Op);
622 }
623
624 // Make sure that we can do this. Since we can't insert GEPs in a basic
625 // block before a PHI node, we can't easily do this transformation if
626 // we have PHI node users of transformed instructions.
627 for (Value *Val : Explored) {
628 for (Value *Use : Val->uses()) {
629
630 auto *PHI = dyn_cast<PHINode>(Use);
631 auto *Inst = dyn_cast<Instruction>(Val);
632
633 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
634 Explored.count(PHI) == 0)
635 continue;
636
637 if (PHI->getParent() == Inst->getParent())
638 return false;
639 }
640 }
641 return true;
642}
643
644// Sets the appropriate insert point on Builder where we can add
645// a replacement Instruction for V (if that is possible).
646static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
647 bool Before = true) {
648 if (auto *PHI = dyn_cast<PHINode>(V)) {
649 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
650 return;
651 }
652 if (auto *I = dyn_cast<Instruction>(V)) {
653 if (!Before)
654 I = &*std::next(I->getIterator());
655 Builder.SetInsertPoint(I);
656 return;
657 }
658 if (auto *A = dyn_cast<Argument>(V)) {
659 // Set the insertion point in the entry block.
660 BasicBlock &Entry = A->getParent()->getEntryBlock();
661 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
662 return;
663 }
664 // Otherwise, this is a constant and we don't need to set a new
665 // insertion point.
666 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
667}
668
669/// Returns a re-written value of Start as an indexed GEP using Base as a
670/// pointer.
671static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
672 const DataLayout &DL,
673 SetVector<Value *> &Explored) {
674 // Perform all the substitutions. This is a bit tricky because we can
675 // have cycles in our use-def chains.
676 // 1. Create the PHI nodes without any incoming values.
677 // 2. Create all the other values.
678 // 3. Add the edges for the PHI nodes.
679 // 4. Emit GEPs to get the original pointers.
680 // 5. Remove the original instructions.
681 Type *IndexType = IntegerType::get(
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000682 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000683
684 DenseMap<Value *, Value *> NewInsts;
685 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
686
687 // Create the new PHI nodes, without adding any incoming values.
688 for (Value *Val : Explored) {
689 if (Val == Base)
690 continue;
691 // Create empty phi nodes. This avoids cyclic dependencies when creating
692 // the remaining instructions.
693 if (auto *PHI = dyn_cast<PHINode>(Val))
694 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
695 PHI->getName() + ".idx", PHI);
696 }
697 IRBuilder<> Builder(Base->getContext());
698
699 // Create all the other instructions.
700 for (Value *Val : Explored) {
701
702 if (NewInsts.find(Val) != NewInsts.end())
703 continue;
704
705 if (auto *CI = dyn_cast<CastInst>(Val)) {
Martin Storsjo0fe645c2019-05-30 20:53:21 +0000706 // Don't get rid of the intermediate variable here; the store can grow
707 // the map which will invalidate the reference to the input value.
708 Value *V = NewInsts[CI->getOperand(0)];
709 NewInsts[CI] = V;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000710 continue;
711 }
712 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
713 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
714 : GEP->getOperand(1);
715 setInsertionPoint(Builder, GEP);
716 // Indices might need to be sign extended. GEPs will magically do
717 // this, but we need to do it ourselves here.
718 if (Index->getType()->getScalarSizeInBits() !=
719 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
720 Index = Builder.CreateSExtOrTrunc(
721 Index, NewInsts[GEP->getOperand(0)]->getType(),
722 GEP->getOperand(0)->getName() + ".sext");
723 }
724
725 auto *Op = NewInsts[GEP->getOperand(0)];
Craig Topper781aa182018-05-05 01:57:00 +0000726 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero())
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000727 NewInsts[GEP] = Index;
728 else
729 NewInsts[GEP] = Builder.CreateNSWAdd(
730 Op, Index, GEP->getOperand(0)->getName() + ".add");
731 continue;
732 }
733 if (isa<PHINode>(Val))
734 continue;
735
736 llvm_unreachable("Unexpected instruction type");
737 }
738
739 // Add the incoming values to the PHI nodes.
740 for (Value *Val : Explored) {
741 if (Val == Base)
742 continue;
743 // All the instructions have been created, we can now add edges to the
744 // phi nodes.
745 if (auto *PHI = dyn_cast<PHINode>(Val)) {
746 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
747 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
748 Value *NewIncoming = PHI->getIncomingValue(I);
749
750 if (NewInsts.find(NewIncoming) != NewInsts.end())
751 NewIncoming = NewInsts[NewIncoming];
752
753 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
754 }
755 }
756 }
757
758 for (Value *Val : Explored) {
759 if (Val == Base)
760 continue;
761
762 // Depending on the type, for external users we have to emit
763 // a GEP or a GEP + ptrtoint.
764 setInsertionPoint(Builder, Val, false);
765
766 // If required, create an inttoptr instruction for Base.
767 Value *NewBase = Base;
768 if (!Base->getType()->isPointerTy())
769 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
770 Start->getName() + "to.ptr");
771
772 Value *GEP = Builder.CreateInBoundsGEP(
773 Start->getType()->getPointerElementType(), NewBase,
774 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
775
776 if (!Val->getType()->isPointerTy()) {
777 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
778 Val->getName() + ".conv");
779 GEP = Cast;
780 }
781 Val->replaceAllUsesWith(GEP);
782 }
783
784 return NewInsts[Start];
785}
786
787/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
788/// the input Value as a constant indexed GEP. Returns a pair containing
789/// the GEPs Pointer and Index.
790static std::pair<Value *, Value *>
791getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
792 Type *IndexType = IntegerType::get(V->getContext(),
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000793 DL.getIndexTypeSizeInBits(V->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000794
795 Constant *Index = ConstantInt::getNullValue(IndexType);
796 while (true) {
797 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
798 // We accept only inbouds GEPs here to exclude the possibility of
799 // overflow.
800 if (!GEP->isInBounds())
801 break;
802 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
803 GEP->getType() == V->getType()) {
804 V = GEP->getOperand(0);
805 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
806 Index = ConstantExpr::getAdd(
807 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
808 continue;
809 }
810 break;
811 }
812 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
813 if (!CI->isNoopCast(DL))
814 break;
815 V = CI->getOperand(0);
816 continue;
817 }
818 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
819 if (!CI->isNoopCast(DL))
820 break;
821 V = CI->getOperand(0);
822 continue;
823 }
824 break;
825 }
826 return {V, Index};
827}
828
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000829/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
830/// We can look through PHIs, GEPs and casts in order to determine a common base
831/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000832static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
833 ICmpInst::Predicate Cond,
834 const DataLayout &DL) {
835 if (!GEPLHS->hasAllConstantIndices())
836 return nullptr;
837
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000838 // Make sure the pointers have the same type.
839 if (GEPLHS->getType() != RHS->getType())
840 return nullptr;
841
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000842 Value *PtrBase, *Index;
843 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
844
845 // The set of nodes that will take part in this transformation.
846 SetVector<Value *> Nodes;
847
848 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
849 return nullptr;
850
851 // We know we can re-write this as
852 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
853 // Since we've only looked through inbouds GEPs we know that we
854 // can't have overflow on either side. We can therefore re-write
855 // this as:
856 // OFFSET1 cmp OFFSET2
857 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
858
859 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
860 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
861 // offset. Since Index is the offset of LHS to the base pointer, we will now
862 // compare the offsets instead of comparing the pointers.
863 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
864}
865
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000866/// Fold comparisons between a GEP instruction and something else. At this point
867/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000868Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000869 ICmpInst::Predicate Cond,
870 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000871 // Don't transform signed compares of GEPs into index compares. Even if the
872 // GEP is inbounds, the final add of the base pointer can have signed overflow
873 // and would change the result of the icmp.
874 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000875 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000876 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000877 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000878
Matt Arsenault44f60d02014-06-09 19:20:29 +0000879 // Look through bitcasts and addrspacecasts. We do not however want to remove
880 // 0 GEPs.
881 if (!isa<GetElementPtrInst>(RHS))
882 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000883
884 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000885 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000886 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
887 // This transformation (ignoring the base and scales) is valid because we
888 // know pointers can't overflow since the gep is inbounds. See if we can
889 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000890 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000891
Chris Lattner2188e402010-01-04 07:37:31 +0000892 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000893 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000894 Offset = EmitGEPOffset(GEPLHS);
895 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
896 Constant::getNullValue(Offset->getType()));
Philip Reames5b02cfa2019-08-23 17:58:58 +0000897 } else if (GEPLHS->isInBounds() && ICmpInst::isEquality(Cond) &&
898 GEPLHS->getType()->isPointerTy() && // TODO: extend to vector geps
899 isa<Constant>(RHS) && cast<Constant>(RHS)->isNullValue() &&
900 !NullPointerIsDefined(I.getFunction(),
901 RHS->getType()->getPointerAddressSpace())) {
902 // For most address spaces, an allocation can't be placed at null, but null
903 // itself is treated as a 0 size allocation in the in bounds rules. Thus,
904 // the only valid inbounds address derived from null, is null itself.
905 // Thus, we have four cases to consider:
906 // 1) Base == nullptr, Offset == 0 -> inbounds, null
907 // 2) Base == nullptr, Offset != 0 -> poison as the result is out of bounds
908 // 3) Base != nullptr, Offset == (-base) -> poison (crossing allocations)
909 // 4) Base != nullptr, Offset != (-base) -> nonnull (and possibly poison)
910 //
911 // (Note if we're indexing a type of size 0, that simply collapses into one
912 // of the buckets above.)
913 //
914 // In general, we're allowed to make values less poison (i.e. remove
915 // sources of full UB), so in this case, we just select between the two
916 // non-poison cases (1 and 4 above).
Philip Reames9cb059f2019-08-23 18:27:57 +0000917 auto *Base = GEPLHS->getPointerOperand();
918 return new ICmpInst(Cond, Base,
919 ConstantExpr::getBitCast(cast<Constant>(RHS),
920 Base->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +0000921 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
922 // If the base pointers are different, but the indices are the same, just
923 // compare the base pointer.
924 if (PtrBase != GEPRHS->getOperand(0)) {
925 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
926 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
927 GEPRHS->getOperand(0)->getType();
928 if (IndicesTheSame)
929 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
930 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
931 IndicesTheSame = false;
932 break;
933 }
934
935 // If all indices are the same, just compare the base pointers.
Jesper Antonssonc954b862018-10-01 14:59:25 +0000936 Type *BaseType = GEPLHS->getOperand(0)->getType();
937 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType())
David Majnemer5953d372013-06-29 10:28:04 +0000938 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000939
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000940 // If we're comparing GEPs with two base pointers that only differ in type
941 // and both GEPs have only constant indices or just one use, then fold
942 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000943 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000944 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
945 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
946 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000947 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000948 Value *LOffset = EmitGEPOffset(GEPLHS);
949 Value *ROffset = EmitGEPOffset(GEPRHS);
950
951 // If we looked through an addrspacecast between different sized address
952 // spaces, the LHS and RHS pointers are different sized
953 // integers. Truncate to the smaller one.
954 Type *LHSIndexTy = LOffset->getType();
955 Type *RHSIndexTy = ROffset->getType();
956 if (LHSIndexTy != RHSIndexTy) {
957 if (LHSIndexTy->getPrimitiveSizeInBits() <
958 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000959 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000960 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000961 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000962 }
963
Craig Topperbb4069e2017-07-07 23:16:26 +0000964 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
965 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000966 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000967 }
968
Chris Lattner2188e402010-01-04 07:37:31 +0000969 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000970 // different. Try convert this to an indexed compare by looking through
971 // PHIs/casts.
972 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000973 }
974
975 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000976 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000977 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +0000978 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +0000979
980 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000981 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000982 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +0000983
Stuart Hastings66a82b92011-05-14 05:55:10 +0000984 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +0000985 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
986 // If the GEPs only differ by one index, compare it.
987 unsigned NumDifferences = 0; // Keep track of # differences.
988 unsigned DiffOperand = 0; // The operand that differs.
989 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
990 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
991 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
992 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
993 // Irreconcilable differences.
994 NumDifferences = 2;
995 break;
996 } else {
997 if (NumDifferences++) break;
998 DiffOperand = i;
999 }
1000 }
1001
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +00001002 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +00001003 return replaceInstUsesWith(I, // No comparison is needed here.
Jesper Antonsson719fa052018-09-20 13:37:28 +00001004 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +00001005
Stuart Hastings66a82b92011-05-14 05:55:10 +00001006 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +00001007 Value *LHSV = GEPLHS->getOperand(DiffOperand);
1008 Value *RHSV = GEPRHS->getOperand(DiffOperand);
1009 // Make sure we do a signed comparison here.
1010 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
1011 }
1012 }
1013
1014 // Only lower this if the icmp is the only user of the GEP or if we expect
1015 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001016 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +00001017 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
1018 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
1019 Value *L = EmitGEPOffset(GEPLHS);
1020 Value *R = EmitGEPOffset(GEPRHS);
1021 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
1022 }
1023 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001024
1025 // Try convert this to an indexed compare by looking through PHIs/casts as a
1026 // last resort.
1027 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001028}
1029
Pete Cooper980a9352016-08-12 17:13:28 +00001030Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1031 const AllocaInst *Alloca,
1032 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001033 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1034
1035 // It would be tempting to fold away comparisons between allocas and any
1036 // pointer not based on that alloca (e.g. an argument). However, even
1037 // though such pointers cannot alias, they can still compare equal.
1038 //
1039 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1040 // doesn't escape we can argue that it's impossible to guess its value, and we
1041 // can therefore act as if any such guesses are wrong.
1042 //
1043 // The code below checks that the alloca doesn't escape, and that it's only
1044 // used in a comparison once (the current instruction). The
1045 // single-comparison-use condition ensures that we're trivially folding all
1046 // comparisons against the alloca consistently, and avoids the risk of
1047 // erroneously folding a comparison of the pointer with itself.
1048
1049 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1050
Pete Cooper980a9352016-08-12 17:13:28 +00001051 SmallVector<const Use *, 32> Worklist;
1052 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001053 if (Worklist.size() >= MaxIter)
1054 return nullptr;
1055 Worklist.push_back(&U);
1056 }
1057
1058 unsigned NumCmps = 0;
1059 while (!Worklist.empty()) {
1060 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001061 const Use *U = Worklist.pop_back_val();
1062 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001063 --MaxIter;
1064
1065 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1066 isa<SelectInst>(V)) {
1067 // Track the uses.
1068 } else if (isa<LoadInst>(V)) {
1069 // Loading from the pointer doesn't escape it.
1070 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001071 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001072 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1073 if (SI->getValueOperand() == U->get())
1074 return nullptr;
1075 continue;
1076 } else if (isa<ICmpInst>(V)) {
1077 if (NumCmps++)
1078 return nullptr; // Found more than one cmp.
1079 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001080 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001081 switch (Intrin->getIntrinsicID()) {
1082 // These intrinsics don't escape or compare the pointer. Memset is safe
1083 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1084 // we don't allow stores, so src cannot point to V.
1085 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001086 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1087 continue;
1088 default:
1089 return nullptr;
1090 }
1091 } else {
1092 return nullptr;
1093 }
Pete Cooper980a9352016-08-12 17:13:28 +00001094 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001095 if (Worklist.size() >= MaxIter)
1096 return nullptr;
1097 Worklist.push_back(&U);
1098 }
1099 }
1100
1101 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001102 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001103 ICI,
1104 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1105}
1106
Craig Topperbee74792018-08-20 23:04:25 +00001107/// Fold "icmp pred (X+C), X".
1108Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C,
Sanjay Patel43395062016-07-21 18:07:40 +00001109 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001110 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001111 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001112 // operators.
Craig Topperbee74792018-08-20 23:04:25 +00001113 assert(!!C && "C should not be zero!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00001114
Chris Lattner8c92b572010-01-08 17:48:19 +00001115 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001116 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1117 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1118 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Craig Topperbee74792018-08-20 23:04:25 +00001119 Constant *R = ConstantInt::get(X->getType(),
1120 APInt::getMaxValue(C.getBitWidth()) - C);
Chris Lattner2188e402010-01-04 07:37:31 +00001121 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1122 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001123
Chris Lattner2188e402010-01-04 07:37:31 +00001124 // (X+1) >u X --> X <u (0-1) --> X != 255
1125 // (X+2) >u X --> X <u (0-2) --> X <u 254
1126 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001127 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Craig Topperbee74792018-08-20 23:04:25 +00001128 return new ICmpInst(ICmpInst::ICMP_ULT, X,
1129 ConstantInt::get(X->getType(), -C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001130
Craig Topperbee74792018-08-20 23:04:25 +00001131 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth());
Chris Lattner2188e402010-01-04 07:37:31 +00001132
1133 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1134 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1135 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1136 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1137 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1138 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001139 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Craig Topperbee74792018-08-20 23:04:25 +00001140 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1141 ConstantInt::get(X->getType(), SMax - C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001142
Chris Lattner2188e402010-01-04 07:37:31 +00001143 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1144 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1145 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1146 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1147 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1148 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001149
Chris Lattner2188e402010-01-04 07:37:31 +00001150 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbee74792018-08-20 23:04:25 +00001151 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1152 ConstantInt::get(X->getType(), SMax - (C - 1)));
Chris Lattner2188e402010-01-04 07:37:31 +00001153}
1154
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001155/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1156/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1157/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1158Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1159 const APInt &AP1,
1160 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001161 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1162
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001163 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1164 if (I.getPredicate() == I.ICMP_NE)
1165 Pred = CmpInst::getInversePredicate(Pred);
1166 return new ICmpInst(Pred, LHS, RHS);
1167 };
1168
David Majnemer2abb8182014-10-25 07:13:13 +00001169 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001170 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001171 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001172
1173 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001174 if (IsAShr) {
1175 if (AP2.isAllOnesValue())
1176 return nullptr;
1177 if (AP2.isNegative() != AP1.isNegative())
1178 return nullptr;
1179 if (AP2.sgt(AP1))
1180 return nullptr;
1181 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001182
David Majnemerd2056022014-10-21 19:51:55 +00001183 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001184 // 'A' must be large enough to shift out the highest set bit.
1185 return getICmp(I.ICMP_UGT, A,
1186 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001187
David Majnemerd2056022014-10-21 19:51:55 +00001188 if (AP1 == AP2)
1189 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001190
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001191 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001192 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001193 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001194 else
David Majnemere5977eb2015-09-19 00:48:26 +00001195 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001196
David Majnemerd2056022014-10-21 19:51:55 +00001197 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001198 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1199 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001200 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001201 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1202 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001203 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001204 } else if (AP1 == AP2.lshr(Shift)) {
1205 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1206 }
David Majnemerd2056022014-10-21 19:51:55 +00001207 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001208
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001209 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001210 // FIXME: This should always be handled by InstSimplify?
1211 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1212 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001213}
Chris Lattner2188e402010-01-04 07:37:31 +00001214
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001215/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1216/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1217Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1218 const APInt &AP1,
1219 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001220 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1221
David Majnemer59939ac2014-10-19 08:23:08 +00001222 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1223 if (I.getPredicate() == I.ICMP_NE)
1224 Pred = CmpInst::getInversePredicate(Pred);
1225 return new ICmpInst(Pred, LHS, RHS);
1226 };
1227
David Majnemer2abb8182014-10-25 07:13:13 +00001228 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001229 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001230 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001231
1232 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1233
1234 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001235 return getICmp(
1236 I.ICMP_UGE, A,
1237 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001238
1239 if (AP1 == AP2)
1240 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1241
1242 // Get the distance between the lowest bits that are set.
1243 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1244
1245 if (Shift > 0 && AP2.shl(Shift) == AP1)
1246 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1247
1248 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001249 // FIXME: This should always be handled by InstSimplify?
1250 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1251 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001252}
1253
Sanjay Patel06b127a2016-09-15 14:37:50 +00001254/// The caller has matched a pattern of the form:
1255/// I = icmp ugt (add (add A, B), CI2), CI1
1256/// If this is of the form:
1257/// sum = a + b
1258/// if (sum+128 >u 255)
1259/// Then replace it with llvm.sadd.with.overflow.i8.
1260///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001261static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001262 ConstantInt *CI2, ConstantInt *CI1,
1263 InstCombiner &IC) {
1264 // The transformation we're trying to do here is to transform this into an
1265 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1266 // with a narrower add, and discard the add-with-constant that is part of the
1267 // range check (if we can't eliminate it, this isn't profitable).
1268
1269 // In order to eliminate the add-with-constant, the compare can be its only
1270 // use.
1271 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1272 if (!AddWithCst->hasOneUse())
1273 return nullptr;
1274
1275 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1276 if (!CI2->getValue().isPowerOf2())
1277 return nullptr;
1278 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1279 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1280 return nullptr;
1281
1282 // The width of the new add formed is 1 more than the bias.
1283 ++NewWidth;
1284
1285 // Check to see that CI1 is an all-ones value with NewWidth bits.
1286 if (CI1->getBitWidth() == NewWidth ||
1287 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1288 return nullptr;
1289
1290 // This is only really a signed overflow check if the inputs have been
1291 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1292 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1293 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1294 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1295 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1296 return nullptr;
1297
1298 // In order to replace the original add with a narrower
1299 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1300 // and truncates that discard the high bits of the add. Verify that this is
1301 // the case.
1302 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1303 for (User *U : OrigAdd->users()) {
1304 if (U == AddWithCst)
1305 continue;
1306
1307 // Only accept truncates for now. We would really like a nice recursive
1308 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1309 // chain to see which bits of a value are actually demanded. If the
1310 // original add had another add which was then immediately truncated, we
1311 // could still do the transformation.
1312 TruncInst *TI = dyn_cast<TruncInst>(U);
1313 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1314 return nullptr;
1315 }
1316
1317 // If the pattern matches, truncate the inputs to the narrower type and
1318 // use the sadd_with_overflow intrinsic to efficiently compute both the
1319 // result and the overflow bit.
1320 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
James Y Knight7976eb52019-02-01 20:43:25 +00001321 Function *F = Intrinsic::getDeclaration(
1322 I.getModule(), Intrinsic::sadd_with_overflow, NewType);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001323
Craig Topperbb4069e2017-07-07 23:16:26 +00001324 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001325
1326 // Put the new code above the original add, in case there are any uses of the
1327 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001328 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001329
Craig Topperbb4069e2017-07-07 23:16:26 +00001330 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1331 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1332 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1333 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1334 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001335
1336 // The inner add was the result of the narrow add, zero extended to the
1337 // wider type. Replace it with the result computed by the intrinsic.
1338 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1339
1340 // The original icmp gets replaced with the overflow value.
1341 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1342}
1343
Roman Lebedevbe612ea2019-07-30 15:28:22 +00001344/// If we have:
1345/// icmp eq/ne (urem/srem %x, %y), 0
1346/// iff %y is a power-of-two, we can replace this with a bit test:
1347/// icmp eq/ne (and %x, (add %y, -1)), 0
1348Instruction *InstCombiner::foldIRemByPowerOfTwoToBitTest(ICmpInst &I) {
1349 // This fold is only valid for equality predicates.
1350 if (!I.isEquality())
1351 return nullptr;
1352 ICmpInst::Predicate Pred;
1353 Value *X, *Y, *Zero;
1354 if (!match(&I, m_ICmp(Pred, m_OneUse(m_IRem(m_Value(X), m_Value(Y))),
1355 m_CombineAnd(m_Zero(), m_Value(Zero)))))
1356 return nullptr;
1357 if (!isKnownToBeAPowerOfTwo(Y, /*OrZero*/ true, 0, &I))
1358 return nullptr;
1359 // This may increase instruction count, we don't enforce that Y is a constant.
1360 Value *Mask = Builder.CreateAdd(Y, Constant::getAllOnesValue(Y->getType()));
1361 Value *Masked = Builder.CreateAnd(X, Mask);
1362 return ICmpInst::Create(Instruction::ICmp, Pred, Masked, Zero);
1363}
1364
Roman Lebedevf55818e2019-07-01 09:41:43 +00001365// Handle icmp pred X, 0
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001366Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) {
1367 CmpInst::Predicate Pred = Cmp.getPredicate();
Roman Lebedevf55818e2019-07-01 09:41:43 +00001368 if (!match(Cmp.getOperand(1), m_Zero()))
1369 return nullptr;
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001370
Roman Lebedevf55818e2019-07-01 09:41:43 +00001371 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
1372 if (Pred == ICmpInst::ICMP_SGT) {
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001373 Value *A, *B;
Roman Lebedevf55818e2019-07-01 09:41:43 +00001374 SelectPatternResult SPR = matchSelectPattern(Cmp.getOperand(0), A, B);
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001375 if (SPR.Flavor == SPF_SMIN) {
1376 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
1377 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1378 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
1379 return new ICmpInst(Pred, A, Cmp.getOperand(1));
1380 }
1381 }
Roman Lebedevf55818e2019-07-01 09:41:43 +00001382
Roman Lebedevbe612ea2019-07-30 15:28:22 +00001383 if (Instruction *New = foldIRemByPowerOfTwoToBitTest(Cmp))
1384 return New;
1385
Roman Lebedevf55818e2019-07-01 09:41:43 +00001386 // Given:
1387 // icmp eq/ne (urem %x, %y), 0
1388 // Iff %x has 0 or 1 bits set, and %y has at least 2 bits set, omit 'urem':
1389 // icmp eq/ne %x, 0
1390 Value *X, *Y;
1391 if (match(Cmp.getOperand(0), m_URem(m_Value(X), m_Value(Y))) &&
1392 ICmpInst::isEquality(Pred)) {
1393 KnownBits XKnown = computeKnownBits(X, 0, &Cmp);
1394 KnownBits YKnown = computeKnownBits(Y, 0, &Cmp);
1395 if (XKnown.countMaxPopulation() == 1 && YKnown.countMinPopulation() >= 2)
1396 return new ICmpInst(Pred, X, Cmp.getOperand(1));
1397 }
1398
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001399 return nullptr;
1400}
1401
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001402/// Fold icmp Pred X, C.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001403/// TODO: This code structure does not make sense. The saturating add fold
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001404/// should be moved to some other helper and extended as noted below (it is also
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001405/// possible that code has been made unnecessary - do we canonicalize IR to
1406/// overflow/saturating intrinsics or not?).
Sanjay Patel97459832016-09-15 15:11:12 +00001407Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
Sanjay Patel97459832016-09-15 15:11:12 +00001408 // Match the following pattern, which is a common idiom when writing
1409 // overflow-safe integer arithmetic functions. The source performs an addition
1410 // in wider type and explicitly checks for overflow using comparisons against
1411 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1412 //
1413 // TODO: This could probably be generalized to handle other overflow-safe
1414 // operations if we worked out the formulas to compute the appropriate magic
1415 // constants.
1416 //
1417 // sum = a + b
1418 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001419 CmpInst::Predicate Pred = Cmp.getPredicate();
1420 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1);
1421 Value *A, *B;
1422 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1423 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) &&
1424 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
1425 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this))
1426 return Res;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001427
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001428 return nullptr;
1429}
1430
1431/// Canonicalize icmp instructions based on dominating conditions.
1432Instruction *InstCombiner::foldICmpWithDominatingICmp(ICmpInst &Cmp) {
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001433 // This is a cheap/incomplete check for dominance - just match a single
1434 // predecessor with a conditional branch.
1435 BasicBlock *CmpBB = Cmp.getParent();
1436 BasicBlock *DomBB = CmpBB->getSinglePredecessor();
1437 if (!DomBB)
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001438 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001439
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001440 Value *DomCond;
Sanjay Patel97459832016-09-15 15:11:12 +00001441 BasicBlock *TrueBB, *FalseBB;
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001442 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB)))
1443 return nullptr;
1444
1445 assert((TrueBB == CmpBB || FalseBB == CmpBB) &&
1446 "Predecessor block does not point to successor?");
1447
1448 // The branch should get simplified. Don't bother simplifying this condition.
1449 if (TrueBB == FalseBB)
1450 return nullptr;
1451
Sanjay Patelbaffae92018-12-05 15:04:00 +00001452 // Try to simplify this compare to T/F based on the dominating condition.
1453 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB);
1454 if (Imp)
1455 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp));
1456
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001457 CmpInst::Predicate Pred = Cmp.getPredicate();
1458 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1);
1459 ICmpInst::Predicate DomPred;
1460 const APInt *C, *DomC;
1461 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) &&
1462 match(Y, m_APInt(C))) {
1463 // We have 2 compares of a variable with constants. Calculate the constant
1464 // ranges of those compares to see if we can transform the 2nd compare:
1465 // DomBB:
1466 // DomCond = icmp DomPred X, DomC
1467 // br DomCond, CmpBB, FalseBB
1468 // CmpBB:
1469 // Cmp = icmp Pred X, C
1470 ConstantRange CR = ConstantRange::makeAllowedICmpRegion(Pred, *C);
Sanjay Patel97459832016-09-15 15:11:12 +00001471 ConstantRange DominatingCR =
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001472 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC)
1473 : ConstantRange::makeExactICmpRegion(
1474 CmpInst::getInversePredicate(DomPred), *DomC);
Sanjay Patel97459832016-09-15 15:11:12 +00001475 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1476 ConstantRange Difference = DominatingCR.difference(CR);
1477 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001478 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001479 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001480 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001481
Sanjay Patel97459832016-09-15 15:11:12 +00001482 // Canonicalizing a sign bit comparison that gets used in a branch,
1483 // pessimizes codegen by generating branch on zero instruction instead
1484 // of a test and branch. So we avoid canonicalizing in such situations
1485 // because test and branch instruction has better branch displacement
1486 // than compare and branch instruction.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001487 bool UnusedBit;
1488 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit);
Eric Christophera95aac32017-06-30 01:57:48 +00001489 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1490 return nullptr;
1491
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001492 if (const APInt *EqC = Intersection.getSingleElement())
1493 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC));
1494 if (const APInt *NeC = Difference.getSingleElement())
1495 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001496 }
1497
1498 return nullptr;
1499}
1500
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001501/// Fold icmp (trunc X, Y), C.
1502Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001503 TruncInst *Trunc,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001504 const APInt &C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001505 ICmpInst::Predicate Pred = Cmp.getPredicate();
1506 Value *X = Trunc->getOperand(0);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001507 if (C.isOneValue() && C.getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001508 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1509 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001510 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001511 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1512 ConstantInt::get(V->getType(), 1));
1513 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001514
1515 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001516 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1517 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001518 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1519 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001520 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001521
1522 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001523 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001524 // Pull in the high bits from known-ones set.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001525 APInt NewRHS = C.zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001526 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001527 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001528 }
1529 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001530
Sanjay Patela3f4f082016-08-16 17:54:36 +00001531 return nullptr;
1532}
1533
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001534/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001535Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1536 BinaryOperator *Xor,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001537 const APInt &C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001538 Value *X = Xor->getOperand(0);
1539 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001540 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001541 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001542 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001543
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001544 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1545 // fold the xor.
1546 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topperdf63b962017-10-03 19:14:23 +00001547 bool TrueIfSigned = false;
1548 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001549
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001550 // If the sign bit of the XorCst is not set, there is no change to
1551 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001552 if (!XorC->isNegative()) {
1553 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001554 Worklist.Add(Xor);
1555 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001556 }
1557
Craig Topperdf63b962017-10-03 19:14:23 +00001558 // Emit the opposite comparison.
1559 if (TrueIfSigned)
1560 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1561 ConstantInt::getAllOnesValue(X->getType()));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001562 else
Craig Topperdf63b962017-10-03 19:14:23 +00001563 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1564 ConstantInt::getNullValue(X->getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001565 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001566
1567 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001568 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1569 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001570 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1571 : Cmp.getSignedPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001572 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001573 }
1574
Craig Topperbcfd2d12017-04-20 16:56:25 +00001575 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001576 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1577 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1578 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001579 Pred = Cmp.getSwappedPredicate(Pred);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001580 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001581 }
1582 }
1583
Sanjay Patel26725bd2018-09-11 22:00:15 +00001584 // Mask constant magic can eliminate an 'xor' with unsigned compares.
1585 if (Pred == ICmpInst::ICMP_UGT) {
1586 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2)
1587 if (*XorC == ~C && (C + 1).isPowerOf2())
1588 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
1589 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2)
1590 if (*XorC == C && (C + 1).isPowerOf2())
1591 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
1592 }
1593 if (Pred == ICmpInst::ICMP_ULT) {
1594 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2)
1595 if (*XorC == -C && C.isPowerOf2())
1596 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1597 ConstantInt::get(X->getType(), ~C));
1598 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2)
1599 if (*XorC == C && (-C).isPowerOf2())
1600 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1601 ConstantInt::get(X->getType(), ~C));
1602 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001603 return nullptr;
1604}
1605
Sanjay Patel14e0e182016-08-26 18:28:46 +00001606/// Fold icmp (and (sh X, Y), C2), C1.
1607Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001608 const APInt &C1, const APInt &C2) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001609 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1610 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001611 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001612
Sanjay Patelda9c5622016-08-26 17:15:22 +00001613 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1614 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1615 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001616 // This seemingly simple opportunity to fold away a shift turns out to be
1617 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001618 unsigned ShiftOpcode = Shift->getOpcode();
1619 bool IsShl = ShiftOpcode == Instruction::Shl;
1620 const APInt *C3;
1621 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001622 bool CanFold = false;
Craig Topper7a930922017-10-04 23:06:13 +00001623 if (ShiftOpcode == Instruction::Shl) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001624 // For a left shift, we can fold if the comparison is not signed. We can
1625 // also fold a signed comparison if the mask value and comparison value
1626 // are not negative. These constraints may not be obvious, but we can
1627 // prove that they are correct using an SMT solver.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001628 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001629 CanFold = true;
Craig Topper7a930922017-10-04 23:06:13 +00001630 } else {
1631 bool IsAshr = ShiftOpcode == Instruction::AShr;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001632 // For a logical right shift, we can fold if the comparison is not signed.
1633 // We can also fold a signed comparison if the shifted mask value and the
1634 // shifted comparison value are not negative. These constraints may not be
1635 // obvious, but we can prove that they are correct using an SMT solver.
Craig Topper7a930922017-10-04 23:06:13 +00001636 // For an arithmetic shift right we can do the same, if we ensure
1637 // the And doesn't use any bits being shifted in. Normally these would
1638 // be turned into lshr by SimplifyDemandedBits, but not if there is an
1639 // additional user.
1640 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) {
1641 if (!Cmp.isSigned() ||
1642 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative()))
1643 CanFold = true;
1644 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001645 }
1646
Sanjay Patelda9c5622016-08-26 17:15:22 +00001647 if (CanFold) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001648 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001649 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001650 // Check to see if we are shifting out any of the bits being compared.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001651 if (SameAsC1 != C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001652 // If we shifted bits out, the fold is not going to work out. As a
1653 // special case, check to see if this means that the result is always
1654 // true or false now.
1655 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001656 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001657 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001658 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001659 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001660 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
Craig Topper8ed1aa92017-10-03 05:31:07 +00001661 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001662 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001663 And->setOperand(0, Shift->getOperand(0));
1664 Worklist.Add(Shift); // Shift is dead.
1665 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001666 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001667 }
1668 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001669
Sanjay Patelda9c5622016-08-26 17:15:22 +00001670 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1671 // preferable because it allows the C2 << Y expression to be hoisted out of a
1672 // loop if Y is invariant and X is not.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001673 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001674 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1675 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001676 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001677 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1678 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001679
Sanjay Patelda9c5622016-08-26 17:15:22 +00001680 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001681 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001682 Cmp.setOperand(0, NewAnd);
1683 return &Cmp;
1684 }
1685
Sanjay Patel14e0e182016-08-26 18:28:46 +00001686 return nullptr;
1687}
1688
1689/// Fold icmp (and X, C2), C1.
1690Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1691 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001692 const APInt &C1) {
Huihui Zhang670778c2019-06-19 17:31:39 +00001693 bool isICMP_NE = Cmp.getPredicate() == ICmpInst::ICMP_NE;
1694
Sanjay Patel05aadf82018-10-10 20:47:46 +00001695 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1
1696 // TODO: We canonicalize to the longer form for scalars because we have
1697 // better analysis/folds for icmp, and codegen may be better with icmp.
Huihui Zhang670778c2019-06-19 17:31:39 +00001698 if (isICMP_NE && Cmp.getType()->isVectorTy() && C1.isNullValue() &&
1699 match(And->getOperand(1), m_One()))
Sanjay Patel05aadf82018-10-10 20:47:46 +00001700 return new TruncInst(And->getOperand(0), Cmp.getType());
1701
Sanjay Patel6b490972016-09-04 14:32:15 +00001702 const APInt *C2;
Huihui Zhang670778c2019-06-19 17:31:39 +00001703 Value *X;
1704 if (!match(And, m_And(m_Value(X), m_APInt(C2))))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001705 return nullptr;
1706
Huihui Zhang670778c2019-06-19 17:31:39 +00001707 // Don't perform the following transforms if the AND has multiple uses
Craig Topper8bf62212017-09-26 18:47:25 +00001708 if (!And->hasOneUse())
Sanjay Patel14e0e182016-08-26 18:28:46 +00001709 return nullptr;
1710
Huihui Zhang670778c2019-06-19 17:31:39 +00001711 if (Cmp.isEquality() && C1.isNullValue()) {
1712 // Restrict this fold to single-use 'and' (PR10267).
1713 // Replace (and X, (1 << size(X)-1) != 0) with X s< 0
1714 if (C2->isSignMask()) {
1715 Constant *Zero = Constant::getNullValue(X->getType());
1716 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
1717 return new ICmpInst(NewPred, X, Zero);
1718 }
Huihui Zhang46266132019-06-25 00:09:10 +00001719
1720 // Restrict this fold only for single-use 'and' (PR10267).
1721 // ((%x & C) == 0) --> %x u< (-C) iff (-C) is power of two.
1722 if ((~(*C2) + 1).isPowerOf2()) {
1723 Constant *NegBOC =
1724 ConstantExpr::getNeg(cast<Constant>(And->getOperand(1)));
1725 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
1726 return new ICmpInst(NewPred, X, NegBOC);
1727 }
Huihui Zhang670778c2019-06-19 17:31:39 +00001728 }
1729
Sanjay Patel6b490972016-09-04 14:32:15 +00001730 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1731 // the input width without changing the value produced, eliminate the cast:
1732 //
1733 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1734 //
1735 // We can do this transformation if the constants do not have their sign bits
1736 // set or if it is an equality comparison. Extending a relational comparison
1737 // when we're checking the sign bit would not work.
1738 Value *W;
Craig Topper8bf62212017-09-26 18:47:25 +00001739 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001740 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001741 // TODO: Is this a good transform for vectors? Wider types may reduce
1742 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001743 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001744 if (!Cmp.getType()->isVectorTy()) {
1745 Type *WideType = W->getType();
1746 unsigned WideScalarBits = WideType->getScalarSizeInBits();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001747 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits));
Sanjay Patel6b490972016-09-04 14:32:15 +00001748 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001749 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001750 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001751 }
1752 }
1753
Craig Topper8ed1aa92017-10-03 05:31:07 +00001754 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001755 return I;
1756
Sanjay Patelda9c5622016-08-26 17:15:22 +00001757 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001758 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001759 //
1760 // iff pred isn't signed
Craig Topper8ed1aa92017-10-03 05:31:07 +00001761 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() &&
Craig Topper73ba1c82017-06-07 07:40:37 +00001762 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001763 Constant *One = cast<Constant>(And->getOperand(1));
1764 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001765 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001766 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1767 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1768 unsigned UsesRemoved = 0;
1769 if (And->hasOneUse())
1770 ++UsesRemoved;
1771 if (Or->hasOneUse())
1772 ++UsesRemoved;
1773 if (LShr->hasOneUse())
1774 ++UsesRemoved;
1775
1776 // Compute A & ((1 << B) | 1)
1777 Value *NewOr = nullptr;
1778 if (auto *C = dyn_cast<Constant>(B)) {
1779 if (UsesRemoved >= 1)
1780 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1781 } else {
1782 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001783 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1784 /*HasNUW=*/true),
1785 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001786 }
1787 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001788 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001789 Cmp.setOperand(0, NewAnd);
1790 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001791 }
1792 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001793 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001794
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001795 return nullptr;
1796}
1797
1798/// Fold icmp (and X, Y), C.
1799Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1800 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001801 const APInt &C) {
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001802 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1803 return I;
1804
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001805 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001806
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001807 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1808 Value *X = And->getOperand(0);
1809 Value *Y = And->getOperand(1);
1810 if (auto *LI = dyn_cast<LoadInst>(X))
1811 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1812 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001813 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001814 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1815 ConstantInt *C2 = cast<ConstantInt>(Y);
1816 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001817 return Res;
1818 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001819
1820 if (!Cmp.isEquality())
1821 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001822
1823 // X & -C == -C -> X > u ~C
1824 // X & -C != -C -> X <= u ~C
1825 // iff C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001826 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001827 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1828 : CmpInst::ICMP_ULE;
1829 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1830 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001831
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001832 // (X & C2) == 0 -> (trunc X) >= 0
1833 // (X & C2) != 0 -> (trunc X) < 0
1834 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1835 const APInt *C2;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001836 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001837 int32_t ExactLogBase2 = C2->exactLogBase2();
1838 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1839 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1840 if (And->getType()->isVectorTy())
1841 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001842 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001843 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1844 : CmpInst::ICMP_SLT;
1845 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001846 }
1847 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001848
Sanjay Patela3f4f082016-08-16 17:54:36 +00001849 return nullptr;
1850}
1851
Sanjay Patel943e92e2016-08-17 16:30:43 +00001852/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001853Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001854 const APInt &C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001855 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001856 if (C.isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001857 // icmp slt signum(V) 1 --> icmp slt V, 1
1858 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001859 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001860 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1861 ConstantInt::get(V->getType(), 1));
1862 }
1863
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001864 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1);
1865 if (Cmp.isEquality() && Cmp.getOperand(1) == OrOp1) {
1866 // X | C == C --> X <=u C
1867 // X | C != C --> X >u C
1868 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1869 if ((C + 1).isPowerOf2()) {
1870 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1871 return new ICmpInst(Pred, OrOp0, OrOp1);
1872 }
1873 // More general: are all bits outside of a mask constant set or not set?
1874 // X | C == C --> (X & ~C) == 0
1875 // X | C != C --> (X & ~C) != 0
1876 if (Or->hasOneUse()) {
1877 Value *A = Builder.CreateAnd(OrOp0, ~C);
1878 return new ICmpInst(Pred, A, ConstantInt::getNullValue(OrOp0->getType()));
1879 }
Sanjay Patel50c82c42017-04-05 17:57:05 +00001880 }
1881
Craig Topper8ed1aa92017-10-03 05:31:07 +00001882 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001883 return nullptr;
1884
1885 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001886 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001887 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1888 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001889 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001890 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001891 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001892 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001893 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1894 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1895 }
1896
1897 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1898 // a shorter form that has more potential to be folded even further.
1899 Value *X1, *X2, *X3, *X4;
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001900 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1901 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001902 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1903 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1904 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1905 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1906 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1907 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001908 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001909
Sanjay Patela3f4f082016-08-16 17:54:36 +00001910 return nullptr;
1911}
1912
Sanjay Patel63478072016-08-18 15:44:44 +00001913/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001914Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1915 BinaryOperator *Mul,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001916 const APInt &C) {
Sanjay Patel63478072016-08-18 15:44:44 +00001917 const APInt *MulC;
1918 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001919 return nullptr;
1920
Sanjay Patel63478072016-08-18 15:44:44 +00001921 // If this is a test of the sign bit and the multiply is sign-preserving with
1922 // a constant operand, use the multiply LHS operand instead.
1923 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001924 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001925 if (MulC->isNegative())
1926 Pred = ICmpInst::getSwappedPredicate(Pred);
1927 return new ICmpInst(Pred, Mul->getOperand(0),
1928 Constant::getNullValue(Mul->getType()));
1929 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001930
1931 return nullptr;
1932}
1933
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001934/// Fold icmp (shl 1, Y), C.
1935static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001936 const APInt &C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001937 Value *Y;
1938 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1939 return nullptr;
1940
1941 Type *ShiftType = Shl->getType();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001942 unsigned TypeBits = C.getBitWidth();
1943 bool CIsPowerOf2 = C.isPowerOf2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001944 ICmpInst::Predicate Pred = Cmp.getPredicate();
1945 if (Cmp.isUnsigned()) {
1946 // (1 << Y) pred C -> Y pred Log2(C)
1947 if (!CIsPowerOf2) {
1948 // (1 << Y) < 30 -> Y <= 4
1949 // (1 << Y) <= 30 -> Y <= 4
1950 // (1 << Y) >= 30 -> Y > 4
1951 // (1 << Y) > 30 -> Y > 4
1952 if (Pred == ICmpInst::ICMP_ULT)
1953 Pred = ICmpInst::ICMP_ULE;
1954 else if (Pred == ICmpInst::ICMP_UGE)
1955 Pred = ICmpInst::ICMP_UGT;
1956 }
1957
1958 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1959 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
Craig Topper8ed1aa92017-10-03 05:31:07 +00001960 unsigned CLog2 = C.logBase2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001961 if (CLog2 == TypeBits - 1) {
1962 if (Pred == ICmpInst::ICMP_UGE)
1963 Pred = ICmpInst::ICMP_EQ;
1964 else if (Pred == ICmpInst::ICMP_ULT)
1965 Pred = ICmpInst::ICMP_NE;
1966 }
1967 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1968 } else if (Cmp.isSigned()) {
1969 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001970 if (C.isAllOnesValue()) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001971 // (1 << Y) <= -1 -> Y == 31
1972 if (Pred == ICmpInst::ICMP_SLE)
1973 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1974
1975 // (1 << Y) > -1 -> Y != 31
1976 if (Pred == ICmpInst::ICMP_SGT)
1977 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001978 } else if (!C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001979 // (1 << Y) < 0 -> Y == 31
1980 // (1 << Y) <= 0 -> Y == 31
1981 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1982 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1983
1984 // (1 << Y) >= 0 -> Y != 31
1985 // (1 << Y) > 0 -> Y != 31
1986 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1987 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1988 }
1989 } else if (Cmp.isEquality() && CIsPowerOf2) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001990 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2()));
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001991 }
1992
1993 return nullptr;
1994}
1995
Sanjay Patel38b75062016-08-19 17:20:37 +00001996/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001997Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1998 BinaryOperator *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001999 const APInt &C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002000 const APInt *ShiftVal;
2001 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002002 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002003
Sanjay Patelfa7de602016-08-19 22:33:26 +00002004 const APInt *ShiftAmt;
2005 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00002006 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00002007
Sanjay Patel38b75062016-08-19 17:20:37 +00002008 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00002009 // shifts. When the shift is visited, it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002010 unsigned TypeBits = C.getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00002011 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002012 return nullptr;
2013
Sanjay Patele38e79c2016-08-19 17:34:05 +00002014 ICmpInst::Predicate Pred = Cmp.getPredicate();
2015 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00002016 Type *ShType = Shl->getType();
2017
Sanjay Patel291c3d82017-01-19 16:12:10 +00002018 // NSW guarantees that we are only shifting out sign bits from the high bits,
2019 // so we can ASHR the compare constant without needing a mask and eliminate
2020 // the shift.
2021 if (Shl->hasNoSignedWrap()) {
2022 if (Pred == ICmpInst::ICMP_SGT) {
2023 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002024 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00002025 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2026 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00002027 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
2028 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002029 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00002030 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2031 }
2032 if (Pred == ICmpInst::ICMP_SLT) {
2033 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
2034 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
2035 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
2036 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
Craig Topper8ed1aa92017-10-03 05:31:07 +00002037 assert(!C.isMinSignedValue() && "Unexpected icmp slt");
2038 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1;
Sanjay Patel291c3d82017-01-19 16:12:10 +00002039 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2040 }
2041 // If this is a signed comparison to 0 and the shift is sign preserving,
2042 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
2043 // do that if we're sure to not continue on in this function.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002044 if (isSignTest(Pred, C))
Sanjay Patel291c3d82017-01-19 16:12:10 +00002045 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
2046 }
Sanjay Patel14715b32017-01-17 21:25:16 +00002047
Sanjay Patel291c3d82017-01-19 16:12:10 +00002048 // NUW guarantees that we are only shifting out zero bits from the high bits,
2049 // so we can LSHR the compare constant without needing a mask and eliminate
2050 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00002051 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00002052 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00002053 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002054 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002055 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2056 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00002057 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
2058 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002059 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patelae23d652017-01-18 21:16:12 +00002060 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2061 }
Sanjay Patel14715b32017-01-17 21:25:16 +00002062 if (Pred == ICmpInst::ICMP_ULT) {
2063 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
2064 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
2065 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
2066 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
Craig Topper8ed1aa92017-10-03 05:31:07 +00002067 assert(C.ugt(0) && "ult 0 should have been eliminated");
2068 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1;
Sanjay Patel14715b32017-01-17 21:25:16 +00002069 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2070 }
2071 }
2072
Sanjay Patel291c3d82017-01-19 16:12:10 +00002073 if (Cmp.isEquality() && Shl->hasOneUse()) {
2074 // Strength-reduce the shift into an 'and'.
2075 Constant *Mask = ConstantInt::get(
2076 ShType,
2077 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00002078 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Craig Topper8ed1aa92017-10-03 05:31:07 +00002079 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00002080 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002081 }
2082
Sanjay Patela3f4f082016-08-16 17:54:36 +00002083 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
2084 bool TrueIfSigned = false;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002085 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00002086 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00002087 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00002088 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00002089 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002090 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00002091 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00002092 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00002093 }
2094
Huihui Zhangb90cb572019-06-25 20:44:52 +00002095 // Simplify 'shl' inequality test into 'and' equality test.
2096 if (Cmp.isUnsigned() && Shl->hasOneUse()) {
2097 // (X l<< C2) u<=/u> C1 iff C1+1 is power of two -> X & (~C1 l>> C2) ==/!= 0
2098 if ((C + 1).isPowerOf2() &&
2099 (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT)) {
2100 Value *And = Builder.CreateAnd(X, (~C).lshr(ShiftAmt->getZExtValue()));
2101 return new ICmpInst(Pred == ICmpInst::ICMP_ULE ? ICmpInst::ICMP_EQ
2102 : ICmpInst::ICMP_NE,
2103 And, Constant::getNullValue(ShType));
2104 }
2105 // (X l<< C2) u</u>= C1 iff C1 is power of two -> X & (-C1 l>> C2) ==/!= 0
2106 if (C.isPowerOf2() &&
2107 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) {
2108 Value *And =
2109 Builder.CreateAnd(X, (~(C - 1)).lshr(ShiftAmt->getZExtValue()));
2110 return new ICmpInst(Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_EQ
2111 : ICmpInst::ICMP_NE,
2112 And, Constant::getNullValue(ShType));
2113 }
2114 }
2115
Sanjay Patel643d21a2016-08-21 17:10:07 +00002116 // Transform (icmp pred iM (shl iM %v, N), C)
2117 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
2118 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00002119 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00002120 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00002121 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00002122 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002123 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt &&
Sanjay Patelf3dda132016-10-25 20:11:47 +00002124 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00002125 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002126 if (ShType->isVectorTy())
2127 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00002128 Constant *NewC =
Craig Topper8ed1aa92017-10-03 05:31:07 +00002129 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00002130 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002131 }
2132
2133 return nullptr;
2134}
2135
Sanjay Patela3920492016-08-22 20:45:06 +00002136/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002137Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
2138 BinaryOperator *Shr,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002139 const APInt &C) {
Sanjay Patela3920492016-08-22 20:45:06 +00002140 // An exact shr only shifts out zero bits, so:
2141 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00002142 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00002143 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00002144 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00002145 C.isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00002146 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00002147
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002148 const APInt *ShiftVal;
2149 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002150 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002151
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002152 const APInt *ShiftAmt;
2153 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002154 return nullptr;
2155
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002156 // Check that the shift amount is in range. If not, don't perform undefined
2157 // shifts. When the shift is visited it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002158 unsigned TypeBits = C.getBitWidth();
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002159 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002160 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2161 return nullptr;
2162
Sanjay Pateld64e9882016-08-23 22:05:55 +00002163 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002164 bool IsExact = Shr->isExact();
2165 Type *ShrTy = Shr->getType();
2166 // TODO: If we could guarantee that InstSimplify would handle all of the
2167 // constant-value-based preconditions in the folds below, then we could assert
2168 // those conditions rather than checking them. This is difficult because of
2169 // undef/poison (PR34838).
2170 if (IsAShr) {
2171 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) {
2172 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC)
2173 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC)
2174 APInt ShiftedC = C.shl(ShAmtVal);
2175 if (ShiftedC.ashr(ShAmtVal) == C)
2176 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2177 }
2178 if (Pred == CmpInst::ICMP_SGT) {
2179 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1
2180 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2181 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() &&
2182 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1))
2183 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2184 }
2185 } else {
2186 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) {
2187 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC)
2188 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC)
2189 APInt ShiftedC = C.shl(ShAmtVal);
2190 if (ShiftedC.lshr(ShAmtVal) == C)
2191 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2192 }
2193 if (Pred == CmpInst::ICMP_UGT) {
2194 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1
2195 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2196 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1))
2197 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2198 }
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002199 }
2200
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002201 if (!Cmp.isEquality())
2202 return nullptr;
2203
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002204 // Handle equality comparisons of shift-by-constant.
2205
Sanjay Patel8e297742016-08-24 13:55:55 +00002206 // If the comparison constant changes with the shift, the comparison cannot
2207 // succeed (bits of the comparison constant cannot match the shifted value).
2208 // This should be known by InstSimplify and already be folded to true/false.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002209 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) ||
2210 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) &&
Sanjay Patel8e297742016-08-24 13:55:55 +00002211 "Expected icmp+shr simplify did not occur.");
2212
Sanjay Patel934738a2017-10-15 15:39:15 +00002213 // If the bits shifted out are known zero, compare the unshifted value:
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002214 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Patel934738a2017-10-15 15:39:15 +00002215 if (Shr->isExact())
Sanjay Patel42135be2017-10-16 14:47:24 +00002216 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Patelf11b5b42017-10-05 14:26:15 +00002217
Sanjay Patel934738a2017-10-15 15:39:15 +00002218 if (Shr->hasOneUse()) {
2219 // Canonicalize the shift into an 'and':
2220 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt)
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002221 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002222 Constant *Mask = ConstantInt::get(ShrTy, Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002223 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Patel42135be2017-10-16 14:47:24 +00002224 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002225 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002226
2227 return nullptr;
2228}
2229
Sanjay Patel12a41052016-08-18 17:37:26 +00002230/// Fold icmp (udiv X, Y), C.
2231Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002232 BinaryOperator *UDiv,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002233 const APInt &C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002234 const APInt *C2;
2235 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2236 return nullptr;
2237
Craig Topper29c282e2017-06-07 07:40:29 +00002238 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002239
2240 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2241 Value *Y = UDiv->getOperand(1);
2242 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002243 assert(!C.isMaxValue() &&
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002244 "icmp ugt X, UINT_MAX should have been simplified already.");
2245 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002246 ConstantInt::get(Y->getType(), C2->udiv(C + 1)));
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002247 }
2248
2249 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2250 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002251 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002252 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002253 ConstantInt::get(Y->getType(), C2->udiv(C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002254 }
2255
2256 return nullptr;
2257}
2258
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002259/// Fold icmp ({su}div X, Y), C.
2260Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2261 BinaryOperator *Div,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002262 const APInt &C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002263 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002264 // Fold this div into the comparison, producing a range check.
2265 // Determine, based on the divide type, what the range is being
2266 // checked. If there is an overflow on the low or high side, remember
2267 // it, otherwise compute the range [low, hi) bounding the new value.
2268 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002269 const APInt *C2;
2270 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002271 return nullptr;
2272
Sanjay Patel16554142016-08-24 23:03:36 +00002273 // FIXME: If the operand types don't match the type of the divide
2274 // then don't attempt this transform. The code below doesn't have the
2275 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002276 // vice versa). This is because (x /s C2) <s C produces different
2277 // results than (x /s C2) <u C or (x /u C2) <s C or even
2278 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002279 // work. :( The if statement below tests that condition and bails
2280 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002281 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2282 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002283 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002284
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002285 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2286 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2287 // division-by-constant cases should be present, we can not assert that they
2288 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002289 if (C2->isNullValue() || C2->isOneValue() ||
2290 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002291 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002292
Craig Topper6e025a32017-10-01 23:53:54 +00002293 // Compute Prod = C * C2. We are essentially solving an equation of
2294 // form X / C2 = C. We solve for X by multiplying C2 and C.
Sanjay Patel541aef42016-08-31 21:57:21 +00002295 // By solving for X, we can turn this into a range check instead of computing
2296 // a divide.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002297 APInt Prod = C * *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002298
Sanjay Patel541aef42016-08-31 21:57:21 +00002299 // Determine if the product overflows by seeing if the product is not equal to
2300 // the divide. Make sure we do the same kind of divide as in the LHS
2301 // instruction that we're folding.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002302 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C;
Sanjay Patel16554142016-08-24 23:03:36 +00002303
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002304 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002305
2306 // If the division is known to be exact, then there is no remainder from the
2307 // divide, so the covered range size is unit, otherwise it is the divisor.
Craig Topper6e025a32017-10-01 23:53:54 +00002308 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002309
2310 // Figure out the interval that is being checked. For example, a comparison
2311 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2312 // Compute this interval based on the constants involved and the signedness of
2313 // the compare/divide. This computes a half-open interval, keeping track of
2314 // whether either value in the interval overflows. After analysis each
2315 // overflow variable is set to 0 if it's corresponding bound variable is valid
2316 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2317 int LoOverflow = 0, HiOverflow = 0;
Craig Topper6e025a32017-10-01 23:53:54 +00002318 APInt LoBound, HiBound;
Sanjay Patel16554142016-08-24 23:03:36 +00002319
2320 if (!DivIsSigned) { // udiv
2321 // e.g. X/5 op 3 --> [15, 20)
2322 LoBound = Prod;
2323 HiOverflow = LoOverflow = ProdOV;
2324 if (!HiOverflow) {
2325 // If this is not an exact divide, then many values in the range collapse
2326 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002327 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002328 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002329 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002330 if (C.isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002331 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
Craig Topper6e025a32017-10-01 23:53:54 +00002332 LoBound = -(RangeSize - 1);
Sanjay Patel16554142016-08-24 23:03:36 +00002333 HiBound = RangeSize;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002334 } else if (C.isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002335 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2336 HiOverflow = LoOverflow = ProdOV;
2337 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002338 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002339 } else { // (X / pos) op neg
2340 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002341 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002342 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2343 if (!LoOverflow) {
Craig Topper6e025a32017-10-01 23:53:54 +00002344 APInt DivNeg = -RangeSize;
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002345 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002346 }
2347 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002348 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002349 if (Div->isExact())
Craig Topper6e025a32017-10-01 23:53:54 +00002350 RangeSize.negate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00002351 if (C.isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002352 // e.g. X/-5 op 0 --> [-4, 5)
Craig Topper6e025a32017-10-01 23:53:54 +00002353 LoBound = RangeSize + 1;
2354 HiBound = -RangeSize;
2355 if (HiBound == *C2) { // -INTMIN = INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002356 HiOverflow = 1; // [INTMIN+1, overflow)
Craig Topper6e025a32017-10-01 23:53:54 +00002357 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002358 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002359 } else if (C.isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002360 // e.g. X/-5 op 3 --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002361 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002362 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2363 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002364 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002365 } else { // (X / neg) op neg
2366 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2367 LoOverflow = HiOverflow = ProdOV;
2368 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002369 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002370 }
2371
2372 // Dividing by a negative swaps the condition. LT <-> GT
2373 Pred = ICmpInst::getSwappedPredicate(Pred);
2374 }
2375
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002376 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002377 switch (Pred) {
2378 default: llvm_unreachable("Unhandled icmp opcode!");
2379 case ICmpInst::ICMP_EQ:
2380 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002381 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002382 if (HiOverflow)
2383 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002384 ICmpInst::ICMP_UGE, X,
2385 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002386 if (LoOverflow)
2387 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002388 ICmpInst::ICMP_ULT, X,
2389 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel85d79742016-08-31 19:49:56 +00002390 return replaceInstUsesWith(
Craig Topper6e025a32017-10-01 23:53:54 +00002391 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002392 case ICmpInst::ICMP_NE:
2393 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002394 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002395 if (HiOverflow)
2396 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002397 ICmpInst::ICMP_ULT, X,
2398 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002399 if (LoOverflow)
2400 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002401 ICmpInst::ICMP_UGE, X,
2402 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel541aef42016-08-31 21:57:21 +00002403 return replaceInstUsesWith(Cmp,
Craig Topper6e025a32017-10-01 23:53:54 +00002404 insertRangeTest(X, LoBound, HiBound,
Sanjay Patel541aef42016-08-31 21:57:21 +00002405 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002406 case ICmpInst::ICMP_ULT:
2407 case ICmpInst::ICMP_SLT:
2408 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002409 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002410 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002411 return replaceInstUsesWith(Cmp, Builder.getFalse());
Craig Topper6e025a32017-10-01 23:53:54 +00002412 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002413 case ICmpInst::ICMP_UGT:
2414 case ICmpInst::ICMP_SGT:
2415 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002416 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002417 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002418 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002419 if (Pred == ICmpInst::ICMP_UGT)
Craig Topper6e025a32017-10-01 23:53:54 +00002420 return new ICmpInst(ICmpInst::ICMP_UGE, X,
2421 ConstantInt::get(Div->getType(), HiBound));
2422 return new ICmpInst(ICmpInst::ICMP_SGE, X,
2423 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002424 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002425
2426 return nullptr;
2427}
2428
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002429/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002430Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2431 BinaryOperator *Sub,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002432 const APInt &C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002433 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2434 ICmpInst::Predicate Pred = Cmp.getPredicate();
Luqman Aden8911c5b2019-04-04 07:08:30 +00002435 const APInt *C2;
2436 APInt SubResult;
2437
Philip Reames764b0fd2019-08-21 15:51:57 +00002438 // icmp eq/ne (sub C, Y), C -> icmp eq/ne Y, 0
2439 if (match(X, m_APInt(C2)) && *C2 == C && Cmp.isEquality())
2440 return new ICmpInst(Cmp.getPredicate(), Y,
2441 ConstantInt::get(Y->getType(), 0));
2442
Luqman Aden8911c5b2019-04-04 07:08:30 +00002443 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C)
2444 if (match(X, m_APInt(C2)) &&
2445 ((Cmp.isUnsigned() && Sub->hasNoUnsignedWrap()) ||
2446 (Cmp.isSigned() && Sub->hasNoSignedWrap())) &&
2447 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned()))
2448 return new ICmpInst(Cmp.getSwappedPredicate(), Y,
2449 ConstantInt::get(Y->getType(), SubResult));
Sanjay Patel886a5422016-09-15 18:05:17 +00002450
2451 // The following transforms are only worth it if the only user of the subtract
2452 // is the icmp.
2453 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002454 return nullptr;
2455
Sanjay Patel886a5422016-09-15 18:05:17 +00002456 if (Sub->hasNoSignedWrap()) {
2457 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002458 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002459 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002460
Sanjay Patel886a5422016-09-15 18:05:17 +00002461 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002462 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002463 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2464
2465 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002466 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002467 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2468
2469 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002470 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002471 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2472 }
2473
Sanjay Patel886a5422016-09-15 18:05:17 +00002474 if (!match(X, m_APInt(C2)))
2475 return nullptr;
2476
2477 // C2 - Y <u C -> (Y | (C - 1)) == C2
2478 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002479 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() &&
2480 (*C2 & (C - 1)) == (C - 1))
2481 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002482
2483 // C2 - Y >u C -> (Y | C) != C2
2484 // iff C2 & C == C and C + 1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002485 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C)
2486 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002487
2488 return nullptr;
2489}
2490
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002491/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002492Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2493 BinaryOperator *Add,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002494 const APInt &C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002495 Value *Y = Add->getOperand(1);
2496 const APInt *C2;
2497 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002498 return nullptr;
2499
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002500 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002501 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002502 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002503 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002504
Tim Northover12c1f762018-09-10 14:26:44 +00002505 if (!Add->hasOneUse())
2506 return nullptr;
2507
Sanjay Patel45b7e692017-02-12 16:40:30 +00002508 // If the add does not wrap, we can always adjust the compare by subtracting
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002509 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE
2510 // are canonicalized to SGT/SLT/UGT/ULT.
2511 if ((Add->hasNoSignedWrap() &&
2512 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) ||
2513 (Add->hasNoUnsignedWrap() &&
2514 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) {
Sanjay Patel45b7e692017-02-12 16:40:30 +00002515 bool Overflow;
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002516 APInt NewC =
2517 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow);
Sanjay Patel45b7e692017-02-12 16:40:30 +00002518 // If there is overflow, the result must be true or false.
2519 // TODO: Can we assert there is no overflow because InstSimplify always
2520 // handles those cases?
2521 if (!Overflow)
2522 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2523 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2524 }
2525
Craig Topper8ed1aa92017-10-03 05:31:07 +00002526 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002527 const APInt &Upper = CR.getUpper();
2528 const APInt &Lower = CR.getLower();
2529 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002530 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002531 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002532 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002533 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002534 } else {
2535 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002536 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002537 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002538 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002539 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002540
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002541 // X+C <u C2 -> (X & -C2) == C
2542 // iff C & (C2-1) == 0
2543 // C2 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002544 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0)
2545 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002546 ConstantExpr::getNeg(cast<Constant>(Y)));
2547
2548 // X+C >u C2 -> (X & ~C2) != C
2549 // iff C & C2 == 0
2550 // C2+1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002551 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0)
2552 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002553 ConstantExpr::getNeg(cast<Constant>(Y)));
2554
Sanjay Patela3f4f082016-08-16 17:54:36 +00002555 return nullptr;
2556}
2557
Anna Thomasd67165c2017-06-23 13:41:45 +00002558bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2559 Value *&RHS, ConstantInt *&Less,
2560 ConstantInt *&Equal,
2561 ConstantInt *&Greater) {
2562 // TODO: Generalize this to work with other comparison idioms or ensure
2563 // they get canonicalized into this form.
2564
Roman Lebedevde19f742019-08-24 06:49:36 +00002565 // select i1 (a == b),
2566 // i32 Equal,
2567 // i32 (select i1 (a < b), i32 Less, i32 Greater)
2568 // where Equal, Less and Greater are placeholders for any three constants.
2569 ICmpInst::Predicate PredA;
2570 if (!match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) ||
2571 !ICmpInst::isEquality(PredA))
2572 return false;
2573 Value *EqualVal = SI->getTrueValue();
2574 Value *UnequalVal = SI->getFalseValue();
2575 // We still can get non-canonical predicate here, so canonicalize.
2576 if (PredA == ICmpInst::ICMP_NE)
2577 std::swap(EqualVal, UnequalVal);
2578 if (!match(EqualVal, m_ConstantInt(Equal)))
2579 return false;
2580 ICmpInst::Predicate PredB;
2581 Value *LHS2, *RHS2;
2582 if (!match(UnequalVal, m_Select(m_ICmp(PredB, m_Value(LHS2), m_Value(RHS2)),
2583 m_ConstantInt(Less), m_ConstantInt(Greater))))
2584 return false;
2585 // We can get predicate mismatch here, so canonicalize if possible:
2586 // First, ensure that 'LHS' match.
2587 if (LHS2 != LHS) {
2588 // x sgt y <--> y slt x
2589 std::swap(LHS2, RHS2);
2590 PredB = ICmpInst::getSwappedPredicate(PredB);
Anna Thomasd67165c2017-06-23 13:41:45 +00002591 }
Roman Lebedevde19f742019-08-24 06:49:36 +00002592 if (LHS2 != LHS)
2593 return false;
2594 // We also need to canonicalize 'RHS'.
2595 if (PredB == ICmpInst::ICMP_SGT && isa<Constant>(RHS2)) {
2596 // x sgt C-1 <--> x sge C <--> not(x slt C)
2597 auto FlippedStrictness =
2598 getFlippedStrictnessPredicateAndConstant(PredB, cast<Constant>(RHS2));
2599 if (!FlippedStrictness)
2600 return false;
2601 assert(FlippedStrictness->first == ICmpInst::ICMP_SGE && "Sanity check");
2602 RHS2 = FlippedStrictness->second;
2603 // And kind-of perform the result swap.
2604 std::swap(Less, Greater);
2605 PredB = ICmpInst::ICMP_SLT;
2606 }
2607 return PredB == ICmpInst::ICMP_SLT && RHS == RHS2;
Anna Thomasd67165c2017-06-23 13:41:45 +00002608}
2609
2610Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002611 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002612 ConstantInt *C) {
2613
2614 assert(C && "Cmp RHS should be a constant int!");
2615 // If we're testing a constant value against the result of a three way
2616 // comparison, the result can be expressed directly in terms of the
2617 // original values being compared. Note: We could possibly be more
2618 // aggressive here and remove the hasOneUse test. The original select is
2619 // really likely to simplify or sink when we remove a test of the result.
2620 Value *OrigLHS, *OrigRHS;
2621 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2622 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002623 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2624 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002625 assert(C1LessThan && C2Equal && C3GreaterThan);
2626
2627 bool TrueWhenLessThan =
2628 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2629 ->isAllOnesValue();
2630 bool TrueWhenEqual =
2631 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2632 ->isAllOnesValue();
2633 bool TrueWhenGreaterThan =
2634 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2635 ->isAllOnesValue();
2636
2637 // This generates the new instruction that will replace the original Cmp
2638 // Instruction. Instead of enumerating the various combinations when
2639 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2640 // false, we rely on chaining of ORs and future passes of InstCombine to
2641 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2642
2643 // When none of the three constants satisfy the predicate for the RHS (C),
2644 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002645 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002646 if (TrueWhenLessThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002647 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT,
2648 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002649 if (TrueWhenEqual)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002650 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ,
2651 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002652 if (TrueWhenGreaterThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002653 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT,
2654 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002655
2656 return replaceInstUsesWith(Cmp, Cond);
2657 }
2658 return nullptr;
2659}
2660
Sanjay Patele7f46c32019-02-07 20:54:09 +00002661static Instruction *foldICmpBitCast(ICmpInst &Cmp,
2662 InstCombiner::BuilderTy &Builder) {
2663 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0));
2664 if (!Bitcast)
2665 return nullptr;
2666
Sanjay Patele7f46c32019-02-07 20:54:09 +00002667 ICmpInst::Predicate Pred = Cmp.getPredicate();
2668 Value *Op1 = Cmp.getOperand(1);
2669 Value *BCSrcOp = Bitcast->getOperand(0);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002670
Sanjay Patel781d8832019-02-07 21:12:01 +00002671 // Make sure the bitcast doesn't change the number of vector elements.
2672 if (Bitcast->getSrcTy()->getScalarSizeInBits() ==
2673 Bitcast->getDestTy()->getScalarSizeInBits()) {
2674 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast.
2675 Value *X;
2676 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) {
2677 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0
2678 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0
2679 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0
2680 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0
2681 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT ||
2682 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) &&
2683 match(Op1, m_Zero()))
2684 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002685
Sanjay Patel781d8832019-02-07 21:12:01 +00002686 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1
2687 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One()))
2688 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1));
2689
2690 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1
2691 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes()))
2692 return new ICmpInst(Pred, X,
2693 ConstantInt::getAllOnesValue(X->getType()));
2694 }
2695
2696 // Zero-equality checks are preserved through unsigned floating-point casts:
2697 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0
2698 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0
2699 if (match(BCSrcOp, m_UIToFP(m_Value(X))))
2700 if (Cmp.isEquality() && match(Op1, m_Zero()))
2701 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002702 }
2703
Sanjay Patele7f46c32019-02-07 20:54:09 +00002704 // Test to see if the operands of the icmp are casted versions of other
2705 // values. If the ptr->ptr cast can be stripped off both arguments, do so.
2706 if (Bitcast->getType()->isPointerTy() &&
2707 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
2708 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
2709 // so eliminate it as well.
2710 if (auto *BC2 = dyn_cast<BitCastInst>(Op1))
2711 Op1 = BC2->getOperand(0);
2712
2713 Op1 = Builder.CreateBitCast(Op1, BCSrcOp->getType());
2714 return new ICmpInst(Pred, BCSrcOp, Op1);
2715 }
2716
Daniel Neilson901acfa2018-04-03 17:26:20 +00002717 // Folding: icmp <pred> iN X, C
2718 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN
2719 // and C is a splat of a K-bit pattern
2720 // and SC is a constant vector = <C', C', C', ..., C'>
2721 // Into:
2722 // %E = extractelement <M x iK> %vec, i32 C'
2723 // icmp <pred> iK %E, trunc(C)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002724 const APInt *C;
2725 if (!match(Cmp.getOperand(1), m_APInt(C)) ||
2726 !Bitcast->getType()->isIntegerTy() ||
Daniel Neilson901acfa2018-04-03 17:26:20 +00002727 !Bitcast->getSrcTy()->isIntOrIntVectorTy())
2728 return nullptr;
2729
Sanjay Patele7f46c32019-02-07 20:54:09 +00002730 Value *Vec;
2731 Constant *Mask;
2732 if (match(BCSrcOp,
Daniel Neilson901acfa2018-04-03 17:26:20 +00002733 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) {
2734 // Check whether every element of Mask is the same constant
2735 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) {
Sanjay Patele7f46c32019-02-07 20:54:09 +00002736 auto *VecTy = cast<VectorType>(BCSrcOp->getType());
Daniel Neilson901acfa2018-04-03 17:26:20 +00002737 auto *EltTy = cast<IntegerType>(VecTy->getElementType());
Sanjay Patele7f46c32019-02-07 20:54:09 +00002738 if (C->isSplat(EltTy->getBitWidth())) {
Daniel Neilson901acfa2018-04-03 17:26:20 +00002739 // Fold the icmp based on the value of C
2740 // If C is M copies of an iK sized bit pattern,
2741 // then:
2742 // => %E = extractelement <N x iK> %vec, i32 Elem
2743 // icmp <pred> iK %SplatVal, <pattern>
2744 Value *Extract = Builder.CreateExtractElement(Vec, Elem);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002745 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth()));
Daniel Neilson901acfa2018-04-03 17:26:20 +00002746 return new ICmpInst(Pred, Extract, NewC);
2747 }
2748 }
2749 }
2750 return nullptr;
2751}
2752
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002753/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2754/// where X is some kind of instruction.
2755Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002756 const APInt *C;
2757 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002758 return nullptr;
2759
Craig Toppera94069f2017-08-23 05:46:08 +00002760 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002761 switch (BO->getOpcode()) {
2762 case Instruction::Xor:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002763 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002764 return I;
2765 break;
2766 case Instruction::And:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002767 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002768 return I;
2769 break;
2770 case Instruction::Or:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002771 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002772 return I;
2773 break;
2774 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002775 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002776 return I;
2777 break;
2778 case Instruction::Shl:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002779 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002780 return I;
2781 break;
2782 case Instruction::LShr:
2783 case Instruction::AShr:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002784 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002785 return I;
2786 break;
2787 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002788 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002789 return I;
2790 LLVM_FALLTHROUGH;
2791 case Instruction::SDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002792 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002793 return I;
2794 break;
2795 case Instruction::Sub:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002796 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002797 return I;
2798 break;
2799 case Instruction::Add:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002800 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002801 return I;
2802 break;
2803 default:
2804 break;
2805 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002806 // TODO: These folds could be refactored to be part of the above calls.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002807 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002808 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002809 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002810
Anna Thomasd67165c2017-06-23 13:41:45 +00002811 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002812
2813 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2814 // For now, we only support constant integers while folding the
2815 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2816 // similar to the cases handled by binary ops above.
2817 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2818 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002819 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002820 }
2821
2822 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002823 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C))
Craig Topper524c44f2017-08-23 05:46:07 +00002824 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002825 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002826
Nikita Popov6515db22019-01-19 09:56:01 +00002827 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0)))
2828 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C))
2829 return I;
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002830
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002831 return nullptr;
2832}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002833
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002834/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2835/// icmp eq/ne BO, C.
2836Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2837 BinaryOperator *BO,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002838 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002839 // TODO: Some of these folds could work with arbitrary constants, but this
2840 // function is limited to scalar and vector splat constants.
2841 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002842 return nullptr;
2843
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002844 ICmpInst::Predicate Pred = Cmp.getPredicate();
2845 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2846 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002847 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002848
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002849 switch (BO->getOpcode()) {
2850 case Instruction::SRem:
2851 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002852 if (C.isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002853 const APInt *BOC;
2854 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002855 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002856 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002857 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002858 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002859 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002860 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002861 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002862 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002863 const APInt *BOC;
2864 if (match(BOp1, m_APInt(BOC))) {
2865 if (BO->hasOneUse()) {
2866 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002867 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002868 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002869 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002870 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2871 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002872 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002873 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002874 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002875 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002876 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002877 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002878 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002879 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002880 }
2881 }
2882 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002883 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002884 case Instruction::Xor:
2885 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002886 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002887 // For the xor case, we can xor two constants together, eliminating
2888 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002889 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002890 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002891 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002892 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002893 }
2894 }
2895 break;
2896 case Instruction::Sub:
2897 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002898 const APInt *BOC;
2899 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002900 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002901 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002902 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002903 } else if (C.isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002904 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002905 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002906 }
2907 }
2908 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002909 case Instruction::Or: {
2910 const APInt *BOC;
2911 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002912 // Comparing if all bits outside of a constant mask are set?
2913 // Replace (X | C) == -1 with (X & ~C) == ~C.
2914 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002915 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002916 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002917 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002918 }
2919 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002920 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002921 case Instruction::And: {
2922 const APInt *BOC;
2923 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002924 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Craig Topper8ed1aa92017-10-03 05:31:07 +00002925 if (C == *BOC && C.isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002926 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002927 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002928 }
2929 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002930 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002931 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002932 if (C.isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002933 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002934 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002935 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002936 // General case : (mul X, C) != 0 iff X != 0
2937 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002938 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002939 }
2940 }
2941 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002942 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002943 if (C.isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002944 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002945 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2946 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002947 }
2948 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002949 default:
2950 break;
2951 }
2952 return nullptr;
2953}
2954
Nikita Popov6515db22019-01-19 09:56:01 +00002955/// Fold an equality icmp with LLVM intrinsic and constant operand.
2956Instruction *InstCombiner::foldICmpEqIntrinsicWithConstant(ICmpInst &Cmp,
2957 IntrinsicInst *II,
2958 const APInt &C) {
Sanjay Patelb51e0722017-07-02 16:05:11 +00002959 Type *Ty = II->getType();
Nikita Popov20853a72018-12-18 19:59:50 +00002960 unsigned BitWidth = C.getBitWidth();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002961 switch (II->getIntrinsicID()) {
2962 case Intrinsic::bswap:
2963 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002964 Cmp.setOperand(0, II->getArgOperand(0));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002965 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002966 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002967
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002968 case Intrinsic::ctlz:
Nikita Popov20853a72018-12-18 19:59:50 +00002969 case Intrinsic::cttz: {
Amaury Sechet6bea6742016-08-04 05:27:20 +00002970 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Nikita Popov20853a72018-12-18 19:59:50 +00002971 if (C == BitWidth) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002972 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002973 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002974 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002975 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002976 }
Nikita Popov20853a72018-12-18 19:59:50 +00002977
2978 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set
2979 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits.
2980 // Limit to one use to ensure we don't increase instruction count.
2981 unsigned Num = C.getLimitedValue(BitWidth);
2982 if (Num != BitWidth && II->hasOneUse()) {
2983 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz;
2984 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1)
2985 : APInt::getHighBitsSet(BitWidth, Num + 1);
2986 APInt Mask2 = IsTrailing
2987 ? APInt::getOneBitSet(BitWidth, Num)
2988 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
2989 Cmp.setOperand(0, Builder.CreateAnd(II->getArgOperand(0), Mask1));
2990 Cmp.setOperand(1, ConstantInt::get(Ty, Mask2));
2991 Worklist.Add(II);
2992 return &Cmp;
2993 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002994 break;
Nikita Popov20853a72018-12-18 19:59:50 +00002995 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002996
Amaury Sechet6bea6742016-08-04 05:27:20 +00002997 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002998 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002999 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00003000 bool IsZero = C.isNullValue();
Nikita Popov20853a72018-12-18 19:59:50 +00003001 if (IsZero || C == BitWidth) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003002 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003003 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00003004 auto *NewOp =
3005 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003006 Cmp.setOperand(1, NewOp);
3007 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00003008 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003009 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003010 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003011 default:
3012 break;
Chris Lattner2188e402010-01-04 07:37:31 +00003013 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00003014
Craig Topperf40110f2014-04-25 05:29:35 +00003015 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003016}
3017
Nikita Popov6515db22019-01-19 09:56:01 +00003018/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
3019Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
3020 IntrinsicInst *II,
3021 const APInt &C) {
3022 if (Cmp.isEquality())
3023 return foldICmpEqIntrinsicWithConstant(Cmp, II, C);
3024
3025 Type *Ty = II->getType();
3026 unsigned BitWidth = C.getBitWidth();
3027 switch (II->getIntrinsicID()) {
3028 case Intrinsic::ctlz: {
3029 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000
3030 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
3031 unsigned Num = C.getLimitedValue();
3032 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
3033 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT,
3034 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
3035 }
3036
3037 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111
3038 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
3039 C.uge(1) && C.ule(BitWidth)) {
3040 unsigned Num = C.getLimitedValue();
3041 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num);
3042 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT,
3043 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
3044 }
3045 break;
3046 }
3047 case Intrinsic::cttz: {
3048 // Limit to one use to ensure we don't increase instruction count.
3049 if (!II->hasOneUse())
3050 return nullptr;
3051
3052 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0
3053 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
3054 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1);
3055 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ,
3056 Builder.CreateAnd(II->getArgOperand(0), Mask),
3057 ConstantInt::getNullValue(Ty));
3058 }
3059
3060 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0
3061 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
3062 C.uge(1) && C.ule(BitWidth)) {
3063 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue());
3064 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE,
3065 Builder.CreateAnd(II->getArgOperand(0), Mask),
3066 ConstantInt::getNullValue(Ty));
3067 }
3068 break;
3069 }
3070 default:
3071 break;
3072 }
3073
3074 return nullptr;
3075}
3076
Sanjay Patel10494b22016-09-16 16:10:22 +00003077/// Handle icmp with constant (but not simple integer constant) RHS.
3078Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
3079 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3080 Constant *RHSC = dyn_cast<Constant>(Op1);
3081 Instruction *LHSI = dyn_cast<Instruction>(Op0);
3082 if (!RHSC || !LHSI)
3083 return nullptr;
3084
3085 switch (LHSI->getOpcode()) {
3086 case Instruction::GetElementPtr:
3087 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
3088 if (RHSC->isNullValue() &&
3089 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
3090 return new ICmpInst(
3091 I.getPredicate(), LHSI->getOperand(0),
3092 Constant::getNullValue(LHSI->getOperand(0)->getType()));
3093 break;
3094 case Instruction::PHI:
3095 // Only fold icmp into the PHI if the phi and icmp are in the same
3096 // block. If in the same block, we're encouraging jump threading. If
3097 // not, we are just pessimizing the code by making an i1 phi.
3098 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00003099 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00003100 return NV;
3101 break;
3102 case Instruction::Select: {
3103 // If either operand of the select is a constant, we can fold the
3104 // comparison into the select arms, which will cause one to be
3105 // constant folded and the select turned into a bitwise or.
3106 Value *Op1 = nullptr, *Op2 = nullptr;
3107 ConstantInt *CI = nullptr;
3108 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
3109 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
3110 CI = dyn_cast<ConstantInt>(Op1);
3111 }
3112 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
3113 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
3114 CI = dyn_cast<ConstantInt>(Op2);
3115 }
3116
3117 // We only want to perform this transformation if it will not lead to
3118 // additional code. This is true if either both sides of the select
3119 // fold to a constant (in which case the icmp is replaced with a select
3120 // which will usually simplify) or this is the only user of the
3121 // select (in which case we are trading a select+icmp for a simpler
3122 // select+icmp) or all uses of the select can be replaced based on
3123 // dominance information ("Global cases").
3124 bool Transform = false;
3125 if (Op1 && Op2)
3126 Transform = true;
3127 else if (Op1 || Op2) {
3128 // Local case
3129 if (LHSI->hasOneUse())
3130 Transform = true;
3131 // Global cases
3132 else if (CI && !CI->isZero())
3133 // When Op1 is constant try replacing select with second operand.
3134 // Otherwise Op2 is constant and try replacing select with first
3135 // operand.
3136 Transform =
3137 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
3138 }
3139 if (Transform) {
3140 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00003141 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
3142 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003143 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00003144 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
3145 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003146 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
3147 }
3148 break;
3149 }
3150 case Instruction::IntToPtr:
3151 // icmp pred inttoptr(X), null -> icmp pred X, 0
3152 if (RHSC->isNullValue() &&
3153 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
3154 return new ICmpInst(
3155 I.getPredicate(), LHSI->getOperand(0),
3156 Constant::getNullValue(LHSI->getOperand(0)->getType()));
3157 break;
3158
3159 case Instruction::Load:
3160 // Try to optimize things like "A[i] > 4" to index computations.
3161 if (GetElementPtrInst *GEP =
3162 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
3163 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
3164 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
3165 !cast<LoadInst>(LHSI)->isVolatile())
3166 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
3167 return Res;
3168 }
3169 break;
3170 }
3171
3172 return nullptr;
3173}
3174
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003175/// Some comparisons can be simplified.
3176/// In this case, we are looking for comparisons that look like
3177/// a check for a lossy truncation.
3178/// Folds:
Roman Lebedev183a4652018-09-19 13:35:27 +00003179/// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask
3180/// Where Mask is some pattern that produces all-ones in low bits:
3181/// (-1 >> y)
Roman Lebedevf50023d2018-09-19 13:35:46 +00003182/// ((-1 << y) >> y) <- non-canonical, has extra uses
Roman Lebedev183a4652018-09-19 13:35:27 +00003183/// ~(-1 << y)
Roman Lebedevca2bdb02018-09-19 13:35:40 +00003184/// ((1 << y) + (-1)) <- non-canonical, has extra uses
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003185/// The Mask can be a constant, too.
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003186/// For some predicates, the operands are commutative.
3187/// For others, x can only be on a specific side.
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003188static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I,
3189 InstCombiner::BuilderTy &Builder) {
3190 ICmpInst::Predicate SrcPred;
Roman Lebedevf50023d2018-09-19 13:35:46 +00003191 Value *X, *M, *Y;
3192 auto m_VariableMask = m_CombineOr(
3193 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())),
3194 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())),
3195 m_CombineOr(m_LShr(m_AllOnes(), m_Value()),
3196 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y))));
Roman Lebedev183a4652018-09-19 13:35:27 +00003197 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask());
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003198 if (!match(&I, m_c_ICmp(SrcPred,
3199 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)),
3200 m_Deferred(X))))
3201 return nullptr;
3202
3203 ICmpInst::Predicate DstPred;
3204 switch (SrcPred) {
3205 case ICmpInst::Predicate::ICMP_EQ:
3206 // x & (-1 >> y) == x -> x u<= (-1 >> y)
3207 DstPred = ICmpInst::Predicate::ICMP_ULE;
3208 break;
Roman Lebedev74f899f2018-07-12 14:56:12 +00003209 case ICmpInst::Predicate::ICMP_NE:
3210 // x & (-1 >> y) != x -> x u> (-1 >> y)
3211 DstPred = ICmpInst::Predicate::ICMP_UGT;
3212 break;
Roman Lebedev74f611a2018-07-14 16:44:43 +00003213 case ICmpInst::Predicate::ICMP_UGT:
3214 // x u> x & (-1 >> y) -> x u> (-1 >> y)
3215 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3216 DstPred = ICmpInst::Predicate::ICMP_UGT;
3217 break;
Roman Lebedevfac48472018-07-14 12:20:06 +00003218 case ICmpInst::Predicate::ICMP_UGE:
3219 // x & (-1 >> y) u>= x -> x u<= (-1 >> y)
3220 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3221 DstPred = ICmpInst::Predicate::ICMP_ULE;
3222 break;
Roman Lebedeve3dc5872018-07-14 12:20:16 +00003223 case ICmpInst::Predicate::ICMP_ULT:
3224 // x & (-1 >> y) u< x -> x u> (-1 >> y)
3225 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3226 DstPred = ICmpInst::Predicate::ICMP_UGT;
3227 break;
Roman Lebedev0f5ec892018-07-14 16:44:54 +00003228 case ICmpInst::Predicate::ICMP_ULE:
3229 // x u<= x & (-1 >> y) -> x u<= (-1 >> y)
3230 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3231 DstPred = ICmpInst::Predicate::ICMP_ULE;
3232 break;
Roman Lebedev859e14a2018-07-14 20:08:16 +00003233 case ICmpInst::Predicate::ICMP_SGT:
3234 // x s> x & (-1 >> y) -> x s> (-1 >> y)
3235 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3236 return nullptr; // Ignore the other case.
Roman Lebedevd6697582019-06-09 16:30:42 +00003237 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3238 return nullptr;
3239 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3240 return nullptr;
Roman Lebedev859e14a2018-07-14 20:08:16 +00003241 DstPred = ICmpInst::Predicate::ICMP_SGT;
3242 break;
Roman Lebedevf1442612018-07-14 20:08:37 +00003243 case ICmpInst::Predicate::ICMP_SGE:
3244 // x & (-1 >> y) s>= x -> x s<= (-1 >> y)
3245 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3246 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003247 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3248 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003249 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3250 return nullptr;
Roman Lebedevf1442612018-07-14 20:08:37 +00003251 DstPred = ICmpInst::Predicate::ICMP_SLE;
3252 break;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003253 case ICmpInst::Predicate::ICMP_SLT:
3254 // x & (-1 >> y) s< x -> x s> (-1 >> y)
3255 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3256 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003257 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3258 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003259 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3260 return nullptr;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003261 DstPred = ICmpInst::Predicate::ICMP_SGT;
3262 break;
Roman Lebedev1e61e352018-07-14 20:08:26 +00003263 case ICmpInst::Predicate::ICMP_SLE:
3264 // x s<= x & (-1 >> y) -> x s<= (-1 >> y)
3265 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3266 return nullptr; // Ignore the other case.
Roman Lebedevd6697582019-06-09 16:30:42 +00003267 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3268 return nullptr;
3269 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3270 return nullptr;
Roman Lebedev1e61e352018-07-14 20:08:26 +00003271 DstPred = ICmpInst::Predicate::ICMP_SLE;
3272 break;
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003273 default:
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003274 llvm_unreachable("All possible folds are handled.");
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003275 }
3276
3277 return Builder.CreateICmp(DstPred, X, M);
3278}
3279
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003280/// Some comparisons can be simplified.
3281/// In this case, we are looking for comparisons that look like
3282/// a check for a lossy signed truncation.
3283/// Folds: (MaskedBits is a constant.)
3284/// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x
3285/// Into:
3286/// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits)
3287/// Where KeptBits = bitwidth(%x) - MaskedBits
3288static Value *
3289foldICmpWithTruncSignExtendedVal(ICmpInst &I,
3290 InstCombiner::BuilderTy &Builder) {
3291 ICmpInst::Predicate SrcPred;
3292 Value *X;
3293 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef.
3294 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use.
3295 if (!match(&I, m_c_ICmp(SrcPred,
3296 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)),
3297 m_APInt(C1))),
3298 m_Deferred(X))))
3299 return nullptr;
3300
3301 // Potential handling of non-splats: for each element:
3302 // * if both are undef, replace with constant 0.
3303 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0.
3304 // * if both are not undef, and are different, bailout.
3305 // * else, only one is undef, then pick the non-undef one.
3306
3307 // The shift amount must be equal.
3308 if (*C0 != *C1)
3309 return nullptr;
3310 const APInt &MaskedBits = *C0;
3311 assert(MaskedBits != 0 && "shift by zero should be folded away already.");
3312
3313 ICmpInst::Predicate DstPred;
3314 switch (SrcPred) {
3315 case ICmpInst::Predicate::ICMP_EQ:
3316 // ((%x << MaskedBits) a>> MaskedBits) == %x
3317 // =>
3318 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits)
3319 DstPred = ICmpInst::Predicate::ICMP_ULT;
3320 break;
3321 case ICmpInst::Predicate::ICMP_NE:
3322 // ((%x << MaskedBits) a>> MaskedBits) != %x
3323 // =>
3324 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits)
3325 DstPred = ICmpInst::Predicate::ICMP_UGE;
3326 break;
3327 // FIXME: are more folds possible?
3328 default:
3329 return nullptr;
3330 }
3331
3332 auto *XType = X->getType();
3333 const unsigned XBitWidth = XType->getScalarSizeInBits();
3334 const APInt BitWidth = APInt(XBitWidth, XBitWidth);
3335 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched");
3336
3337 // KeptBits = bitwidth(%x) - MaskedBits
3338 const APInt KeptBits = BitWidth - MaskedBits;
3339 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable");
3340 // ICmpCst = (1 << KeptBits)
3341 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits);
3342 assert(ICmpCst.isPowerOf2());
3343 // AddCst = (1 << (KeptBits-1))
3344 const APInt AddCst = ICmpCst.lshr(1);
3345 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2());
3346
3347 // T0 = add %x, AddCst
3348 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst));
3349 // T1 = T0 DstPred ICmpCst
3350 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst));
3351
3352 return T1;
3353}
3354
Roman Lebedev72b8d412019-07-01 15:55:15 +00003355// Given pattern:
3356// icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0
3357// we should move shifts to the same hand of 'and', i.e. rewrite as
3358// icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x)
3359// We are only interested in opposite logical shifts here.
Roman Lebedev16244fc2019-08-16 15:10:41 +00003360// One of the shifts can be truncated. For now, it can only be 'shl'.
Roman Lebedev72b8d412019-07-01 15:55:15 +00003361// If we can, we want to end up creating 'lshr' shift.
3362static Value *
3363foldShiftIntoShiftInAnotherHandOfAndInICmp(ICmpInst &I, const SimplifyQuery SQ,
3364 InstCombiner::BuilderTy &Builder) {
3365 if (!I.isEquality() || !match(I.getOperand(1), m_Zero()) ||
3366 !I.getOperand(0)->hasOneUse())
3367 return nullptr;
3368
3369 auto m_AnyLogicalShift = m_LogicalShift(m_Value(), m_Value());
Roman Lebedev72b8d412019-07-01 15:55:15 +00003370
Roman Lebedev16244fc2019-08-16 15:10:41 +00003371 // Look for an 'and' of two logical shifts, one of which may be truncated.
3372 // We use m_TruncOrSelf() on the RHS to correctly handle commutative case.
3373 Instruction *XShift, *MaybeTruncation, *YShift;
3374 if (!match(
3375 I.getOperand(0),
3376 m_c_And(m_CombineAnd(m_AnyLogicalShift, m_Instruction(XShift)),
3377 m_CombineAnd(m_TruncOrSelf(m_CombineAnd(
3378 m_AnyLogicalShift, m_Instruction(YShift))),
3379 m_Instruction(MaybeTruncation)))))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003380 return nullptr;
3381
Roman Lebedev16244fc2019-08-16 15:10:41 +00003382 // We potentially looked past 'trunc', but only when matching YShift,
3383 // therefore YShift must have the widest type.
Roman Lebedev9b957d32019-08-18 12:26:33 +00003384 Instruction *WidestShift = YShift;
3385 // Therefore XShift must have the shallowest type.
3386 // Or they both have identical types if there was no truncation.
3387 Instruction *NarrowestShift = XShift;
3388
3389 Type *WidestTy = WidestShift->getType();
3390 assert(NarrowestShift->getType() == I.getOperand(0)->getType() &&
Roman Lebedev16244fc2019-08-16 15:10:41 +00003391 "We did not look past any shifts while matching XShift though.");
3392 bool HadTrunc = WidestTy != I.getOperand(0)->getType();
3393
3394 if (HadTrunc) {
3395 // We did indeed have a truncation. For now, let's only proceed if the 'shl'
3396 // was truncated, since that does not require any extra legality checks.
3397 // FIXME: trunc-of-lshr.
3398 if (!match(YShift, m_Shl(m_Value(), m_Value())))
3399 return nullptr;
3400 }
3401
Roman Lebedev64fe8062019-08-10 19:28:44 +00003402 // If YShift is a 'lshr', swap the shifts around.
Roman Lebedev16244fc2019-08-16 15:10:41 +00003403 if (match(YShift, m_LShr(m_Value(), m_Value())))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003404 std::swap(XShift, YShift);
3405
3406 // The shifts must be in opposite directions.
Roman Lebedevccdad6e2019-08-12 11:28:02 +00003407 auto XShiftOpcode = XShift->getOpcode();
3408 if (XShiftOpcode == YShift->getOpcode())
Roman Lebedev72b8d412019-07-01 15:55:15 +00003409 return nullptr; // Do not care about same-direction shifts here.
3410
3411 Value *X, *XShAmt, *Y, *YShAmt;
Roman Lebedev16244fc2019-08-16 15:10:41 +00003412 match(XShift, m_BinOp(m_Value(X), m_ZExtOrSelf(m_Value(XShAmt))));
3413 match(YShift, m_BinOp(m_Value(Y), m_ZExtOrSelf(m_Value(YShAmt))));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003414
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003415 // If one of the values being shifted is a constant, then we will end with
Roman Lebedev16244fc2019-08-16 15:10:41 +00003416 // and+icmp, and [zext+]shift instrs will be constant-folded. If they are not,
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003417 // however, we will need to ensure that we won't increase instruction count.
3418 if (!isa<Constant>(X) && !isa<Constant>(Y)) {
3419 // At least one of the hands of the 'and' should be one-use shift.
3420 if (!match(I.getOperand(0),
3421 m_c_And(m_OneUse(m_AnyLogicalShift), m_Value())))
3422 return nullptr;
Roman Lebedev16244fc2019-08-16 15:10:41 +00003423 if (HadTrunc) {
3424 // Due to the 'trunc', we will need to widen X. For that either the old
3425 // 'trunc' or the shift amt in the non-truncated shift should be one-use.
3426 if (!MaybeTruncation->hasOneUse() &&
Roman Lebedev9b957d32019-08-18 12:26:33 +00003427 !NarrowestShift->getOperand(1)->hasOneUse())
Roman Lebedev16244fc2019-08-16 15:10:41 +00003428 return nullptr;
3429 }
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003430 }
3431
Roman Lebedev16244fc2019-08-16 15:10:41 +00003432 // We have two shift amounts from two different shifts. The types of those
3433 // shift amounts may not match. If that's the case let's bailout now.
3434 if (XShAmt->getType() != YShAmt->getType())
3435 return nullptr;
3436
Roman Lebedev72b8d412019-07-01 15:55:15 +00003437 // Can we fold (XShAmt+YShAmt) ?
Roman Lebedev16244fc2019-08-16 15:10:41 +00003438 auto *NewShAmt = dyn_cast_or_null<Constant>(
3439 SimplifyAddInst(XShAmt, YShAmt, /*isNSW=*/false,
3440 /*isNUW=*/false, SQ.getWithInstruction(&I)));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003441 if (!NewShAmt)
3442 return nullptr;
3443 // Is the new shift amount smaller than the bit width?
3444 // FIXME: could also rely on ConstantRange.
Roman Lebedev16244fc2019-08-16 15:10:41 +00003445 if (!match(NewShAmt, m_SpecificInt_ICMP(
3446 ICmpInst::Predicate::ICMP_ULT,
3447 APInt(NewShAmt->getType()->getScalarSizeInBits(),
3448 WidestTy->getScalarSizeInBits()))))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003449 return nullptr;
Roman Lebedev16244fc2019-08-16 15:10:41 +00003450 // All good, we can do this fold.
3451 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, WidestTy);
3452 X = Builder.CreateZExt(X, WidestTy);
3453 // The shift is the same that was for X.
Roman Lebedev72b8d412019-07-01 15:55:15 +00003454 Value *T0 = XShiftOpcode == Instruction::BinaryOps::LShr
3455 ? Builder.CreateLShr(X, NewShAmt)
3456 : Builder.CreateShl(X, NewShAmt);
3457 Value *T1 = Builder.CreateAnd(T0, Y);
3458 return Builder.CreateICmp(I.getPredicate(), T1,
Roman Lebedev16244fc2019-08-16 15:10:41 +00003459 Constant::getNullValue(WidestTy));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003460}
3461
Sanjay Patel10494b22016-09-16 16:10:22 +00003462/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00003463/// TODO: A large part of this logic is duplicated in InstSimplify's
3464/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
3465/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00003466Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
3467 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3468
3469 // Special logic for binary operators.
3470 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
3471 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
3472 if (!BO0 && !BO1)
3473 return nullptr;
3474
Sanjay Patel2a062632017-05-08 16:33:42 +00003475 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel1cf07342018-09-11 22:40:20 +00003476 Value *X;
3477
3478 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare.
3479 // (Op1 + X) <u Op1 --> ~Op1 <u X
3480 // Op0 >u (Op0 + X) --> X >u ~Op0
3481 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) &&
3482 Pred == ICmpInst::ICMP_ULT)
3483 return new ICmpInst(Pred, Builder.CreateNot(Op1), X);
3484 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) &&
3485 Pred == ICmpInst::ICMP_UGT)
3486 return new ICmpInst(Pred, X, Builder.CreateNot(Op0));
3487
Sanjay Patel10494b22016-09-16 16:10:22 +00003488 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
3489 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
3490 NoOp0WrapProblem =
3491 ICmpInst::isEquality(Pred) ||
3492 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
3493 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
3494 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
3495 NoOp1WrapProblem =
3496 ICmpInst::isEquality(Pred) ||
3497 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
3498 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
3499
3500 // Analyze the case when either Op0 or Op1 is an add instruction.
3501 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
3502 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
3503 if (BO0 && BO0->getOpcode() == Instruction::Add) {
3504 A = BO0->getOperand(0);
3505 B = BO0->getOperand(1);
3506 }
3507 if (BO1 && BO1->getOpcode() == Instruction::Add) {
3508 C = BO1->getOperand(0);
3509 D = BO1->getOperand(1);
3510 }
3511
Sanjay Patel10494b22016-09-16 16:10:22 +00003512 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
3513 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
3514 return new ICmpInst(Pred, A == Op1 ? B : A,
3515 Constant::getNullValue(Op1->getType()));
3516
3517 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
3518 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
3519 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
3520 C == Op0 ? D : C);
3521
3522 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
3523 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
3524 NoOp1WrapProblem &&
3525 // Try not to increase register pressure.
3526 BO0->hasOneUse() && BO1->hasOneUse()) {
3527 // Determine Y and Z in the form icmp (X+Y), (X+Z).
3528 Value *Y, *Z;
3529 if (A == C) {
3530 // C + B == C + D -> B == D
3531 Y = B;
3532 Z = D;
3533 } else if (A == D) {
3534 // D + B == C + D -> B == C
3535 Y = B;
3536 Z = C;
3537 } else if (B == C) {
3538 // A + C == C + D -> A == D
3539 Y = A;
3540 Z = D;
3541 } else {
3542 assert(B == D);
3543 // A + D == C + D -> A == C
3544 Y = A;
3545 Z = C;
3546 }
3547 return new ICmpInst(Pred, Y, Z);
3548 }
3549
3550 // icmp slt (X + -1), Y -> icmp sle X, Y
3551 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
3552 match(B, m_AllOnes()))
3553 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
3554
3555 // icmp sge (X + -1), Y -> icmp sgt X, Y
3556 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
3557 match(B, m_AllOnes()))
3558 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
3559
3560 // icmp sle (X + 1), Y -> icmp slt X, Y
3561 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
3562 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
3563
3564 // icmp sgt (X + 1), Y -> icmp sge X, Y
3565 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
3566 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
3567
3568 // icmp sgt X, (Y + -1) -> icmp sge X, Y
3569 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
3570 match(D, m_AllOnes()))
3571 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
3572
3573 // icmp sle X, (Y + -1) -> icmp slt X, Y
3574 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
3575 match(D, m_AllOnes()))
3576 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
3577
3578 // icmp sge X, (Y + 1) -> icmp sgt X, Y
3579 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
3580 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
3581
3582 // icmp slt X, (Y + 1) -> icmp sle X, Y
3583 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
3584 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
3585
Sanjay Patel40f40172017-01-13 23:25:46 +00003586 // TODO: The subtraction-related identities shown below also hold, but
3587 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
3588 // wouldn't happen even if they were implemented.
3589 //
3590 // icmp ult (X - 1), Y -> icmp ule X, Y
3591 // icmp uge (X - 1), Y -> icmp ugt X, Y
3592 // icmp ugt X, (Y - 1) -> icmp uge X, Y
3593 // icmp ule X, (Y - 1) -> icmp ult X, Y
3594
3595 // icmp ule (X + 1), Y -> icmp ult X, Y
3596 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
3597 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
3598
3599 // icmp ugt (X + 1), Y -> icmp uge X, Y
3600 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
3601 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
3602
3603 // icmp uge X, (Y + 1) -> icmp ugt X, Y
3604 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
3605 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
3606
3607 // icmp ult X, (Y + 1) -> icmp ule X, Y
3608 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
3609 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
3610
Sanjay Patel10494b22016-09-16 16:10:22 +00003611 // if C1 has greater magnitude than C2:
3612 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
3613 // s.t. C3 = C1 - C2
3614 //
3615 // if C2 has greater magnitude than C1:
3616 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
3617 // s.t. C3 = C2 - C1
3618 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
3619 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
3620 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
3621 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
3622 const APInt &AP1 = C1->getValue();
3623 const APInt &AP2 = C2->getValue();
3624 if (AP1.isNegative() == AP2.isNegative()) {
3625 APInt AP1Abs = C1->getValue().abs();
3626 APInt AP2Abs = C2->getValue().abs();
3627 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003628 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
3629 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003630 return new ICmpInst(Pred, NewAdd, C);
3631 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00003632 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
3633 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003634 return new ICmpInst(Pred, A, NewAdd);
3635 }
3636 }
3637 }
3638
3639 // Analyze the case when either Op0 or Op1 is a sub instruction.
3640 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
3641 A = nullptr;
3642 B = nullptr;
3643 C = nullptr;
3644 D = nullptr;
3645 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
3646 A = BO0->getOperand(0);
3647 B = BO0->getOperand(1);
3648 }
3649 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
3650 C = BO1->getOperand(0);
3651 D = BO1->getOperand(1);
3652 }
3653
3654 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
3655 if (A == Op1 && NoOp0WrapProblem)
3656 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
Sanjay Patel10494b22016-09-16 16:10:22 +00003657 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
3658 if (C == Op0 && NoOp1WrapProblem)
3659 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3660
Sanjay Patelcbb04502018-04-02 20:37:40 +00003661 // (A - B) >u A --> A <u B
3662 if (A == Op1 && Pred == ICmpInst::ICMP_UGT)
3663 return new ICmpInst(ICmpInst::ICMP_ULT, A, B);
3664 // C <u (C - D) --> C <u D
3665 if (C == Op0 && Pred == ICmpInst::ICMP_ULT)
3666 return new ICmpInst(ICmpInst::ICMP_ULT, C, D);
3667
Sanjay Patel10494b22016-09-16 16:10:22 +00003668 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
3669 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
3670 // Try not to increase register pressure.
3671 BO0->hasOneUse() && BO1->hasOneUse())
3672 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003673 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
3674 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
3675 // Try not to increase register pressure.
3676 BO0->hasOneUse() && BO1->hasOneUse())
3677 return new ICmpInst(Pred, D, B);
3678
3679 // icmp (0-X) < cst --> x > -cst
3680 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3681 Value *X;
3682 if (match(BO0, m_Neg(m_Value(X))))
Chen Zhengb9722732018-07-16 00:51:40 +00003683 if (Constant *RHSC = dyn_cast<Constant>(Op1))
3684 if (RHSC->isNotMinSignedValue())
Sanjay Patel10494b22016-09-16 16:10:22 +00003685 return new ICmpInst(I.getSwappedPredicate(), X,
3686 ConstantExpr::getNeg(RHSC));
3687 }
3688
3689 BinaryOperator *SRem = nullptr;
3690 // icmp (srem X, Y), Y
3691 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3692 SRem = BO0;
3693 // icmp Y, (srem X, Y)
3694 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3695 Op0 == BO1->getOperand(1))
3696 SRem = BO1;
3697 if (SRem) {
3698 // We don't check hasOneUse to avoid increasing register pressure because
3699 // the value we use is the same value this instruction was already using.
3700 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3701 default:
3702 break;
3703 case ICmpInst::ICMP_EQ:
3704 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3705 case ICmpInst::ICMP_NE:
3706 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3707 case ICmpInst::ICMP_SGT:
3708 case ICmpInst::ICMP_SGE:
3709 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3710 Constant::getAllOnesValue(SRem->getType()));
3711 case ICmpInst::ICMP_SLT:
3712 case ICmpInst::ICMP_SLE:
3713 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3714 Constant::getNullValue(SRem->getType()));
3715 }
3716 }
3717
3718 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3719 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3720 switch (BO0->getOpcode()) {
3721 default:
3722 break;
3723 case Instruction::Add:
3724 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003725 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003726 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003727 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003728
3729 const APInt *C;
3730 if (match(BO0->getOperand(1), m_APInt(C))) {
3731 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3732 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003733 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003734 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003735 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003736 }
3737
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003738 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3739 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003740 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003741 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003742 NewPred = I.getSwappedPredicate(NewPred);
3743 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003744 }
3745 }
3746 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003747 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003748 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003749 if (!I.isEquality())
3750 break;
3751
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003752 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003753 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3754 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003755 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3756 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003757 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003758 Constant *Mask = ConstantInt::get(
3759 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003760 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003761 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3762 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003763 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003764 }
Sanjay Patel51506122017-05-25 14:13:57 +00003765 // If there are no trailing zeros in the multiplier, just eliminate
3766 // the multiplies (no masking is needed):
3767 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3768 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003769 }
3770 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003771 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003772 case Instruction::UDiv:
3773 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003774 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003775 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003776 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3777
Sanjay Patel10494b22016-09-16 16:10:22 +00003778 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003779 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3780 break;
3781 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3782
Sanjay Patel10494b22016-09-16 16:10:22 +00003783 case Instruction::AShr:
3784 if (!BO0->isExact() || !BO1->isExact())
3785 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003786 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003787
Sanjay Patel10494b22016-09-16 16:10:22 +00003788 case Instruction::Shl: {
3789 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3790 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3791 if (!NUW && !NSW)
3792 break;
3793 if (!NSW && I.isSigned())
3794 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003795 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003796 }
3797 }
3798 }
3799
3800 if (BO0) {
3801 // Transform A & (L - 1) `ult` L --> L != 0
3802 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003803 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003804
Sanjay Patel2a062632017-05-08 16:33:42 +00003805 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003806 auto *Zero = Constant::getNullValue(BO0->getType());
3807 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3808 }
3809 }
3810
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003811 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder))
3812 return replaceInstUsesWith(I, V);
3813
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003814 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder))
3815 return replaceInstUsesWith(I, V);
3816
Roman Lebedev72b8d412019-07-01 15:55:15 +00003817 if (Value *V = foldShiftIntoShiftInAnotherHandOfAndInICmp(I, SQ, Builder))
3818 return replaceInstUsesWith(I, V);
3819
Sanjay Patel10494b22016-09-16 16:10:22 +00003820 return nullptr;
3821}
3822
Sanjay Pateldd46b522016-12-19 17:32:37 +00003823/// Fold icmp Pred min|max(X, Y), X.
3824static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003825 ICmpInst::Predicate Pred = Cmp.getPredicate();
3826 Value *Op0 = Cmp.getOperand(0);
3827 Value *X = Cmp.getOperand(1);
3828
Sanjay Pateldd46b522016-12-19 17:32:37 +00003829 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003830 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003831 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3832 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3833 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003834 std::swap(Op0, X);
3835 Pred = Cmp.getSwappedPredicate();
3836 }
3837
3838 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003839 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003840 // smin(X, Y) == X --> X s<= Y
3841 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003842 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3843 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3844
Sanjay Pateldd46b522016-12-19 17:32:37 +00003845 // smin(X, Y) != X --> X s> Y
3846 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003847 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3848 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3849
3850 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003851 // smin(X, Y) s<= X --> true
3852 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003853 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003854 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003855
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003856 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003857 // smax(X, Y) == X --> X s>= Y
3858 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003859 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3860 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003861
Sanjay Pateldd46b522016-12-19 17:32:37 +00003862 // smax(X, Y) != X --> X s< Y
3863 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003864 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3865 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003866
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003867 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003868 // smax(X, Y) s>= X --> true
3869 // smax(X, Y) s< X --> false
3870 return nullptr;
3871 }
3872
3873 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3874 // umin(X, Y) == X --> X u<= Y
3875 // umin(X, Y) u>= X --> X u<= Y
3876 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3877 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3878
3879 // umin(X, Y) != X --> X u> Y
3880 // umin(X, Y) u< X --> X u> Y
3881 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3882 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3883
3884 // These cases should be handled in InstSimplify:
3885 // umin(X, Y) u<= X --> true
3886 // umin(X, Y) u> X --> false
3887 return nullptr;
3888 }
3889
3890 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3891 // umax(X, Y) == X --> X u>= Y
3892 // umax(X, Y) u<= X --> X u>= Y
3893 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3894 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3895
3896 // umax(X, Y) != X --> X u< Y
3897 // umax(X, Y) u> X --> X u< Y
3898 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3899 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3900
3901 // These cases should be handled in InstSimplify:
3902 // umax(X, Y) u>= X --> true
3903 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003904 return nullptr;
3905 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003906
Sanjay Pateld6406412016-12-15 19:13:37 +00003907 return nullptr;
3908}
3909
Sanjay Patel10494b22016-09-16 16:10:22 +00003910Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3911 if (!I.isEquality())
3912 return nullptr;
3913
3914 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003915 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00003916 Value *A, *B, *C, *D;
3917 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3918 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3919 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003920 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003921 }
3922
3923 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3924 // A^c1 == C^c2 --> A == C^(c1^c2)
3925 ConstantInt *C1, *C2;
3926 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3927 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003928 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
3929 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003930 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00003931 }
3932
3933 // A^B == A^D -> B == D
3934 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003935 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003936 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003937 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003938 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003939 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003940 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003941 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003942 }
3943 }
3944
3945 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3946 // A == (A^B) -> B == 0
3947 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003948 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003949 }
3950
3951 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3952 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3953 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3954 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3955
3956 if (A == C) {
3957 X = B;
3958 Y = D;
3959 Z = A;
3960 } else if (A == D) {
3961 X = B;
3962 Y = C;
3963 Z = A;
3964 } else if (B == C) {
3965 X = A;
3966 Y = D;
3967 Z = B;
3968 } else if (B == D) {
3969 X = A;
3970 Y = C;
3971 Z = B;
3972 }
3973
3974 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00003975 Op1 = Builder.CreateXor(X, Y);
3976 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00003977 I.setOperand(0, Op1);
3978 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3979 return &I;
3980 }
3981 }
3982
3983 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3984 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3985 ConstantInt *Cst1;
3986 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3987 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3988 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3989 match(Op1, m_ZExt(m_Value(A))))) {
3990 APInt Pow2 = Cst1->getValue() + 1;
3991 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3992 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00003993 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003994 }
3995
3996 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3997 // For lshr and ashr pairs.
3998 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3999 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
4000 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
4001 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
4002 unsigned TypeBits = Cst1->getBitWidth();
4003 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
4004 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00004005 ICmpInst::Predicate NewPred =
4006 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00004007 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00004008 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00004009 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00004010 }
4011 }
4012
4013 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
4014 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
4015 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
4016 unsigned TypeBits = Cst1->getBitWidth();
4017 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
4018 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004019 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00004020 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00004021 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00004022 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00004023 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00004024 }
4025 }
4026
4027 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
4028 // "icmp (and X, mask), cst"
4029 uint64_t ShAmt = 0;
4030 if (Op0->hasOneUse() &&
4031 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
4032 match(Op1, m_ConstantInt(Cst1)) &&
4033 // Only do this when A has multiple uses. This is most important to do
4034 // when it exposes other optimizations.
4035 !A->hasOneUse()) {
4036 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
4037
4038 if (ShAmt < ASize) {
4039 APInt MaskV =
4040 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
4041 MaskV <<= ShAmt;
4042
4043 APInt CmpV = Cst1->getValue().zext(ASize);
4044 CmpV <<= ShAmt;
4045
Craig Topperbb4069e2017-07-07 23:16:26 +00004046 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
4047 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00004048 }
4049 }
4050
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00004051 // If both operands are byte-swapped or bit-reversed, just compare the
4052 // original values.
4053 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
4054 // and handle more intrinsics.
4055 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00004056 (match(Op0, m_BitReverse(m_Value(A))) &&
4057 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00004058 return new ICmpInst(Pred, A, B);
4059
Sanjay Patel63311bf2019-06-20 17:41:15 +00004060 // Canonicalize checking for a power-of-2-or-zero value:
Sanjay Patelddc1b402019-07-01 22:00:00 +00004061 // (A & (A-1)) == 0 --> ctpop(A) < 2 (two commuted variants)
4062 // ((A-1) & A) != 0 --> ctpop(A) > 1 (two commuted variants)
4063 if (!match(Op0, m_OneUse(m_c_And(m_Add(m_Value(A), m_AllOnes()),
4064 m_Deferred(A)))) ||
4065 !match(Op1, m_ZeroInt()))
4066 A = nullptr;
4067
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004068 // (A & -A) == A --> ctpop(A) < 2 (four commuted variants)
4069 // (-A & A) != A --> ctpop(A) > 1 (four commuted variants)
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004070 if (match(Op0, m_OneUse(m_c_And(m_Neg(m_Specific(Op1)), m_Specific(Op1)))))
Sanjay Patel63311bf2019-06-20 17:41:15 +00004071 A = Op1;
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004072 else if (match(Op1,
4073 m_OneUse(m_c_And(m_Neg(m_Specific(Op0)), m_Specific(Op0)))))
Sanjay Patel63311bf2019-06-20 17:41:15 +00004074 A = Op0;
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004075
Sanjay Patel63311bf2019-06-20 17:41:15 +00004076 if (A) {
4077 Type *Ty = A->getType();
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004078 CallInst *CtPop = Builder.CreateUnaryIntrinsic(Intrinsic::ctpop, A);
4079 return Pred == ICmpInst::ICMP_EQ
4080 ? new ICmpInst(ICmpInst::ICMP_ULT, CtPop, ConstantInt::get(Ty, 2))
4081 : new ICmpInst(ICmpInst::ICMP_UGT, CtPop, ConstantInt::get(Ty, 1));
Sanjay Patel63311bf2019-06-20 17:41:15 +00004082 }
4083
Sanjay Patel10494b22016-09-16 16:10:22 +00004084 return nullptr;
4085}
4086
Sanjay Patele7282592019-08-21 11:56:08 +00004087static Instruction *foldICmpWithZextOrSext(ICmpInst &ICmp,
4088 InstCombiner::BuilderTy &Builder) {
Sanjay Patel292b1082019-08-20 18:15:17 +00004089 assert(isa<CastInst>(ICmp.getOperand(0)) && "Expected cast for operand 0");
4090 auto *CastOp0 = cast<CastInst>(ICmp.getOperand(0));
4091 Value *X;
4092 if (!match(CastOp0, m_ZExtOrSExt(m_Value(X))))
4093 return nullptr;
4094
4095 bool IsSignedExt = CastOp0->getOpcode() == Instruction::SExt;
4096 bool IsSignedCmp = ICmp.isSigned();
4097 if (auto *CastOp1 = dyn_cast<CastInst>(ICmp.getOperand(1))) {
4098 // If the signedness of the two casts doesn't agree (i.e. one is a sext
4099 // and the other is a zext), then we can't handle this.
Sanjay Patele7282592019-08-21 11:56:08 +00004100 // TODO: This is too strict. We can handle some predicates (equality?).
Sanjay Patel292b1082019-08-20 18:15:17 +00004101 if (CastOp0->getOpcode() != CastOp1->getOpcode())
4102 return nullptr;
4103
4104 // Not an extension from the same type?
Sanjay Patel292b1082019-08-20 18:15:17 +00004105 Value *Y = CastOp1->getOperand(0);
Sanjay Patele7282592019-08-21 11:56:08 +00004106 Type *XTy = X->getType(), *YTy = Y->getType();
4107 if (XTy != YTy) {
4108 // One of the casts must have one use because we are creating a new cast.
4109 if (!CastOp0->hasOneUse() && !CastOp1->hasOneUse())
4110 return nullptr;
4111 // Extend the narrower operand to the type of the wider operand.
4112 if (XTy->getScalarSizeInBits() < YTy->getScalarSizeInBits())
4113 X = Builder.CreateCast(CastOp0->getOpcode(), X, YTy);
4114 else if (YTy->getScalarSizeInBits() < XTy->getScalarSizeInBits())
4115 Y = Builder.CreateCast(CastOp0->getOpcode(), Y, XTy);
4116 else
4117 return nullptr;
4118 }
Sanjay Patel292b1082019-08-20 18:15:17 +00004119
4120 // (zext X) == (zext Y) --> X == Y
4121 // (sext X) == (sext Y) --> X == Y
4122 if (ICmp.isEquality())
4123 return new ICmpInst(ICmp.getPredicate(), X, Y);
4124
4125 // A signed comparison of sign extended values simplifies into a
4126 // signed comparison.
4127 if (IsSignedCmp && IsSignedExt)
4128 return new ICmpInst(ICmp.getPredicate(), X, Y);
4129
4130 // The other three cases all fold into an unsigned comparison.
4131 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Y);
4132 }
4133
4134 // Below here, we are only folding a compare with constant.
4135 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
4136 if (!C)
4137 return nullptr;
4138
4139 // Compute the constant that would happen if we truncated to SrcTy then
4140 // re-extended to DestTy.
4141 Type *SrcTy = CastOp0->getSrcTy();
4142 Type *DestTy = CastOp0->getDestTy();
4143 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
4144 Constant *Res2 = ConstantExpr::getCast(CastOp0->getOpcode(), Res1, DestTy);
4145
4146 // If the re-extended constant didn't change...
4147 if (Res2 == C) {
4148 if (ICmp.isEquality())
4149 return new ICmpInst(ICmp.getPredicate(), X, Res1);
4150
4151 // A signed comparison of sign extended values simplifies into a
4152 // signed comparison.
4153 if (IsSignedExt && IsSignedCmp)
4154 return new ICmpInst(ICmp.getPredicate(), X, Res1);
4155
4156 // The other three cases all fold into an unsigned comparison.
4157 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Res1);
4158 }
4159
4160 // The re-extended constant changed, partly changed (in the case of a vector),
4161 // or could not be determined to be equal (in the case of a constant
4162 // expression), so the constant cannot be represented in the shorter type.
4163 // All the cases that fold to true or false will have already been handled
4164 // by SimplifyICmpInst, so only deal with the tricky case.
4165 if (IsSignedCmp || !IsSignedExt || !isa<ConstantInt>(C))
4166 return nullptr;
4167
4168 // Is source op positive?
4169 // icmp ult (sext X), C --> icmp sgt X, -1
4170 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
4171 return new ICmpInst(CmpInst::ICMP_SGT, X, Constant::getAllOnesValue(SrcTy));
4172
4173 // Is source op negative?
4174 // icmp ugt (sext X), C --> icmp slt X, 0
4175 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
4176 return new ICmpInst(CmpInst::ICMP_SLT, X, Constant::getNullValue(SrcTy));
4177}
4178
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004179/// Handle icmp (cast x), (cast or constant).
4180Instruction *InstCombiner::foldICmpWithCastOp(ICmpInst &ICmp) {
4181 auto *CastOp0 = dyn_cast<CastInst>(ICmp.getOperand(0));
4182 if (!CastOp0)
4183 return nullptr;
4184 if (!isa<Constant>(ICmp.getOperand(1)) && !isa<CastInst>(ICmp.getOperand(1)))
4185 return nullptr;
4186
4187 Value *Op0Src = CastOp0->getOperand(0);
4188 Type *SrcTy = CastOp0->getSrcTy();
4189 Type *DestTy = CastOp0->getDestTy();
Chris Lattner2188e402010-01-04 07:37:31 +00004190
Jim Grosbach129c52a2011-09-30 18:09:53 +00004191 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00004192 // integer type is the same size as the pointer type.
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004193 auto CompatibleSizes = [&](Type *SrcTy, Type *DestTy) {
Daniel Neilsonbdda1152018-03-05 18:05:51 +00004194 if (isa<VectorType>(SrcTy)) {
4195 SrcTy = cast<VectorType>(SrcTy)->getElementType();
4196 DestTy = cast<VectorType>(DestTy)->getElementType();
4197 }
4198 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth();
4199 };
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004200 if (CastOp0->getOpcode() == Instruction::PtrToInt &&
Daniel Neilsonbdda1152018-03-05 18:05:51 +00004201 CompatibleSizes(SrcTy, DestTy)) {
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004202 Value *NewOp1 = nullptr;
4203 if (auto *PtrToIntOp1 = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
4204 Value *PtrSrc = PtrToIntOp1->getOperand(0);
4205 if (PtrSrc->getType()->getPointerAddressSpace() ==
4206 Op0Src->getType()->getPointerAddressSpace()) {
4207 NewOp1 = PtrToIntOp1->getOperand(0);
Michael Liaod266b922015-02-13 04:51:26 +00004208 // If the pointer types don't match, insert a bitcast.
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004209 if (Op0Src->getType() != NewOp1->getType())
4210 NewOp1 = Builder.CreateBitCast(NewOp1, Op0Src->getType());
Michael Liaod266b922015-02-13 04:51:26 +00004211 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004212 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004213 NewOp1 = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004214 }
Chris Lattner2188e402010-01-04 07:37:31 +00004215
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004216 if (NewOp1)
4217 return new ICmpInst(ICmp.getPredicate(), Op0Src, NewOp1);
Chris Lattner2188e402010-01-04 07:37:31 +00004218 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004219
Sanjay Patele7282592019-08-21 11:56:08 +00004220 return foldICmpWithZextOrSext(ICmp, Builder);
Chris Lattner2188e402010-01-04 07:37:31 +00004221}
4222
Nikita Popov39f2beb2019-05-26 11:43:37 +00004223static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) {
4224 switch (BinaryOp) {
4225 default:
4226 llvm_unreachable("Unsupported binary op");
4227 case Instruction::Add:
4228 case Instruction::Sub:
4229 return match(RHS, m_Zero());
4230 case Instruction::Mul:
4231 return match(RHS, m_One());
4232 }
4233}
4234
4235OverflowResult InstCombiner::computeOverflow(
4236 Instruction::BinaryOps BinaryOp, bool IsSigned,
4237 Value *LHS, Value *RHS, Instruction *CxtI) const {
4238 switch (BinaryOp) {
4239 default:
4240 llvm_unreachable("Unsupported binary op");
4241 case Instruction::Add:
4242 if (IsSigned)
4243 return computeOverflowForSignedAdd(LHS, RHS, CxtI);
4244 else
4245 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI);
4246 case Instruction::Sub:
4247 if (IsSigned)
4248 return computeOverflowForSignedSub(LHS, RHS, CxtI);
4249 else
4250 return computeOverflowForUnsignedSub(LHS, RHS, CxtI);
4251 case Instruction::Mul:
4252 if (IsSigned)
4253 return computeOverflowForSignedMul(LHS, RHS, CxtI);
4254 else
4255 return computeOverflowForUnsignedMul(LHS, RHS, CxtI);
4256 }
4257}
4258
Nikita Popov352f5982019-05-26 11:43:31 +00004259bool InstCombiner::OptimizeOverflowCheck(
4260 Instruction::BinaryOps BinaryOp, bool IsSigned, Value *LHS, Value *RHS,
4261 Instruction &OrigI, Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00004262 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
4263 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00004264
Sanjoy Das6f5dca72015-08-28 19:09:31 +00004265 // If the overflow check was an add followed by a compare, the insertion point
4266 // may be pointing to the compare. We want to insert the new instructions
4267 // before the add in case there are uses of the add between the add and the
4268 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00004269 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00004270
Nikita Popov39f2beb2019-05-26 11:43:37 +00004271 if (isNeutralValue(BinaryOp, RHS)) {
4272 Result = LHS;
4273 Overflow = Builder.getFalse();
4274 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00004275 }
4276
Nikita Popov39f2beb2019-05-26 11:43:37 +00004277 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) {
4278 case OverflowResult::MayOverflow:
4279 return false;
Nikita Popov332c1002019-05-28 18:08:31 +00004280 case OverflowResult::AlwaysOverflowsLow:
4281 case OverflowResult::AlwaysOverflowsHigh:
Nikita Popov39f2beb2019-05-26 11:43:37 +00004282 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4283 Result->takeName(&OrigI);
4284 Overflow = Builder.getTrue();
4285 return true;
4286 case OverflowResult::NeverOverflows:
4287 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4288 Result->takeName(&OrigI);
4289 Overflow = Builder.getFalse();
4290 if (auto *Inst = dyn_cast<Instruction>(Result)) {
4291 if (IsSigned)
4292 Inst->setHasNoSignedWrap();
4293 else
4294 Inst->setHasNoUnsignedWrap();
4295 }
4296 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00004297 }
4298
Nikita Popov39f2beb2019-05-26 11:43:37 +00004299 llvm_unreachable("Unexpected overflow result");
Sanjoy Dasb0984472015-04-08 04:27:22 +00004300}
4301
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004302/// Recognize and process idiom involving test for multiplication
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004303/// overflow.
4304///
4305/// The caller has matched a pattern of the form:
4306/// I = cmp u (mul(zext A, zext B), V
4307/// The function checks if this is a test for overflow and if so replaces
4308/// multiplication with call to 'mul.with.overflow' intrinsic.
4309///
4310/// \param I Compare instruction.
4311/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
4312/// the compare instruction. Must be of integer type.
4313/// \param OtherVal The other argument of compare instruction.
4314/// \returns Instruction which must replace the compare instruction, NULL if no
4315/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004316static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004317 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00004318 // Don't bother doing this transformation for pointers, don't do it for
4319 // vectors.
4320 if (!isa<IntegerType>(MulVal->getType()))
4321 return nullptr;
4322
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004323 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
4324 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00004325 auto *MulInstr = dyn_cast<Instruction>(MulVal);
4326 if (!MulInstr)
4327 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004328 assert(MulInstr->getOpcode() == Instruction::Mul);
4329
David Majnemer634ca232014-11-01 23:46:05 +00004330 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
4331 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004332 assert(LHS->getOpcode() == Instruction::ZExt);
4333 assert(RHS->getOpcode() == Instruction::ZExt);
4334 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
4335
4336 // Calculate type and width of the result produced by mul.with.overflow.
4337 Type *TyA = A->getType(), *TyB = B->getType();
4338 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
4339 WidthB = TyB->getPrimitiveSizeInBits();
4340 unsigned MulWidth;
4341 Type *MulType;
4342 if (WidthB > WidthA) {
4343 MulWidth = WidthB;
4344 MulType = TyB;
4345 } else {
4346 MulWidth = WidthA;
4347 MulType = TyA;
4348 }
4349
4350 // In order to replace the original mul with a narrower mul.with.overflow,
4351 // all uses must ignore upper bits of the product. The number of used low
4352 // bits must be not greater than the width of mul.with.overflow.
4353 if (MulVal->hasNUsesOrMore(2))
4354 for (User *U : MulVal->users()) {
4355 if (U == &I)
4356 continue;
4357 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4358 // Check if truncation ignores bits above MulWidth.
4359 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
4360 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004361 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004362 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4363 // Check if AND ignores bits above MulWidth.
4364 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00004365 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004366 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
4367 const APInt &CVal = CI->getValue();
4368 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004369 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00004370 } else {
4371 // In this case we could have the operand of the binary operation
4372 // being defined in another block, and performing the replacement
4373 // could break the dominance relation.
4374 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004375 }
4376 } else {
4377 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00004378 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004379 }
4380 }
4381
4382 // Recognize patterns
4383 switch (I.getPredicate()) {
4384 case ICmpInst::ICMP_EQ:
4385 case ICmpInst::ICMP_NE:
4386 // Recognize pattern:
4387 // mulval = mul(zext A, zext B)
4388 // cmp eq/neq mulval, zext trunc mulval
4389 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
4390 if (Zext->hasOneUse()) {
4391 Value *ZextArg = Zext->getOperand(0);
4392 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
4393 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
4394 break; //Recognized
4395 }
4396
4397 // Recognize pattern:
4398 // mulval = mul(zext A, zext B)
4399 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
4400 ConstantInt *CI;
4401 Value *ValToMask;
4402 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
4403 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00004404 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004405 const APInt &CVal = CI->getValue() + 1;
4406 if (CVal.isPowerOf2()) {
4407 unsigned MaskWidth = CVal.logBase2();
4408 if (MaskWidth == MulWidth)
4409 break; // Recognized
4410 }
4411 }
Craig Topperf40110f2014-04-25 05:29:35 +00004412 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004413
4414 case ICmpInst::ICMP_UGT:
4415 // Recognize pattern:
4416 // mulval = mul(zext A, zext B)
4417 // cmp ugt mulval, max
4418 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4419 APInt MaxVal = APInt::getMaxValue(MulWidth);
4420 MaxVal = MaxVal.zext(CI->getBitWidth());
4421 if (MaxVal.eq(CI->getValue()))
4422 break; // Recognized
4423 }
Craig Topperf40110f2014-04-25 05:29:35 +00004424 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004425
4426 case ICmpInst::ICMP_UGE:
4427 // Recognize pattern:
4428 // mulval = mul(zext A, zext B)
4429 // cmp uge mulval, max+1
4430 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4431 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
4432 if (MaxVal.eq(CI->getValue()))
4433 break; // Recognized
4434 }
Craig Topperf40110f2014-04-25 05:29:35 +00004435 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004436
4437 case ICmpInst::ICMP_ULE:
4438 // Recognize pattern:
4439 // mulval = mul(zext A, zext B)
4440 // cmp ule mulval, max
4441 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4442 APInt MaxVal = APInt::getMaxValue(MulWidth);
4443 MaxVal = MaxVal.zext(CI->getBitWidth());
4444 if (MaxVal.eq(CI->getValue()))
4445 break; // Recognized
4446 }
Craig Topperf40110f2014-04-25 05:29:35 +00004447 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004448
4449 case ICmpInst::ICMP_ULT:
4450 // Recognize pattern:
4451 // mulval = mul(zext A, zext B)
4452 // cmp ule mulval, max + 1
4453 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004454 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004455 if (MaxVal.eq(CI->getValue()))
4456 break; // Recognized
4457 }
Craig Topperf40110f2014-04-25 05:29:35 +00004458 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004459
4460 default:
Craig Topperf40110f2014-04-25 05:29:35 +00004461 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004462 }
4463
Craig Topperbb4069e2017-07-07 23:16:26 +00004464 InstCombiner::BuilderTy &Builder = IC.Builder;
4465 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004466
4467 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
4468 Value *MulA = A, *MulB = B;
4469 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004470 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004471 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004472 MulB = Builder.CreateZExt(B, MulType);
James Y Knight7976eb52019-02-01 20:43:25 +00004473 Function *F = Intrinsic::getDeclaration(
4474 I.getModule(), Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00004475 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004476 IC.Worklist.Add(MulInstr);
4477
4478 // If there are uses of mul result other than the comparison, we know that
4479 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004480 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004481 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004482 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Joseph Tremoulet6f406d42018-06-15 16:52:40 +00004483 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) {
4484 User *U = *UI++;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004485 if (U == &I || U == OtherVal)
4486 continue;
4487 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4488 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00004489 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004490 else
4491 TI->setOperand(0, Mul);
4492 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4493 assert(BO->getOpcode() == Instruction::And);
4494 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00004495 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
4496 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00004497 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00004498 Instruction *Zext =
4499 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
4500 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00004501 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004502 } else {
4503 llvm_unreachable("Unexpected Binary operation");
4504 }
Davide Italiano579064e2017-07-16 18:56:30 +00004505 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004506 }
4507 }
4508 if (isa<Instruction>(OtherVal))
4509 IC.Worklist.Add(cast<Instruction>(OtherVal));
4510
4511 // The original icmp gets replaced with the overflow value, maybe inverted
4512 // depending on predicate.
4513 bool Inverse = false;
4514 switch (I.getPredicate()) {
4515 case ICmpInst::ICMP_NE:
4516 break;
4517 case ICmpInst::ICMP_EQ:
4518 Inverse = true;
4519 break;
4520 case ICmpInst::ICMP_UGT:
4521 case ICmpInst::ICMP_UGE:
4522 if (I.getOperand(0) == MulVal)
4523 break;
4524 Inverse = true;
4525 break;
4526 case ICmpInst::ICMP_ULT:
4527 case ICmpInst::ICMP_ULE:
4528 if (I.getOperand(1) == MulVal)
4529 break;
4530 Inverse = true;
4531 break;
4532 default:
4533 llvm_unreachable("Unexpected predicate");
4534 }
4535 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004536 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004537 return BinaryOperator::CreateNot(Res);
4538 }
4539
4540 return ExtractValueInst::Create(Call, 1);
4541}
4542
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004543/// When performing a comparison against a constant, it is possible that not all
4544/// the bits in the LHS are demanded. This helper method computes the mask that
4545/// IS demanded.
Craig Topper3edda872017-09-22 18:57:23 +00004546static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) {
Craig Topper18887bf2017-09-20 23:48:58 +00004547 const APInt *RHS;
4548 if (!match(I.getOperand(1), m_APInt(RHS)))
4549 return APInt::getAllOnesValue(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004550
Craig Topper3edda872017-09-22 18:57:23 +00004551 // If this is a normal comparison, it demands all bits. If it is a sign bit
4552 // comparison, it only demands the sign bit.
4553 bool UnusedBit;
4554 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit))
4555 return APInt::getSignMask(BitWidth);
4556
Owen Andersond490c2d2011-01-11 00:36:45 +00004557 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004558 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00004559 // correspond to the trailing ones of the comparand. The value of these
4560 // bits doesn't impact the outcome of the comparison, because any value
4561 // greater than the RHS must differ in a bit higher than these due to carry.
Craig Topper18887bf2017-09-20 23:48:58 +00004562 case ICmpInst::ICMP_UGT:
4563 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004564
Owen Andersond490c2d2011-01-11 00:36:45 +00004565 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
4566 // Any value less than the RHS must differ in a higher bit because of carries.
Craig Topper18887bf2017-09-20 23:48:58 +00004567 case ICmpInst::ICMP_ULT:
4568 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004569
Owen Andersond490c2d2011-01-11 00:36:45 +00004570 default:
4571 return APInt::getAllOnesValue(BitWidth);
4572 }
Owen Andersond490c2d2011-01-11 00:36:45 +00004573}
Chris Lattner2188e402010-01-04 07:37:31 +00004574
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004575/// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst
Quentin Colombet5ab55552013-09-09 20:56:48 +00004576/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00004577/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00004578/// as subtract operands and their positions in those instructions.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004579/// The rationale is that several architectures use the same instruction for
4580/// both subtract and cmp. Thus, it is better if the order of those operands
Quentin Colombet5ab55552013-09-09 20:56:48 +00004581/// match.
4582/// \return true if Op0 and Op1 should be swapped.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004583static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) {
4584 // Filter out pointer values as those cannot appear directly in subtract.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004585 // FIXME: we may want to go through inttoptrs or bitcasts.
4586 if (Op0->getType()->isPointerTy())
4587 return false;
Sanjay Patel1ea86972018-02-02 19:08:12 +00004588 // If a subtract already has the same operands as a compare, swapping would be
4589 // bad. If a subtract has the same operands as a compare but in reverse order,
4590 // then swapping is good.
4591 int GoodToSwap = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00004592 for (const User *U : Op0->users()) {
Sanjay Patel1ea86972018-02-02 19:08:12 +00004593 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0))))
4594 GoodToSwap++;
4595 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1))))
4596 GoodToSwap--;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004597 }
Sanjay Patel1ea86972018-02-02 19:08:12 +00004598 return GoodToSwap > 0;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004599}
4600
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004601/// Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00004602/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004603///
4604/// \param DI Definition
4605/// \param UI Use
4606/// \param DB Block that must dominate all uses of \p DI outside
4607/// the parent block
4608/// \return true when \p UI is the only use of \p DI in the parent block
4609/// and all other uses of \p DI are in blocks dominated by \p DB.
4610///
4611bool InstCombiner::dominatesAllUses(const Instruction *DI,
4612 const Instruction *UI,
4613 const BasicBlock *DB) const {
4614 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00004615 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004616 if (!DI->getParent())
4617 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004618 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004619 if (DI->getParent() != UI->getParent())
4620 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004621 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004622 if (DI->getParent() == DB)
4623 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004624 for (const User *U : DI->users()) {
4625 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00004626 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004627 return false;
4628 }
4629 return true;
4630}
4631
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004632/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004633static bool isChainSelectCmpBranch(const SelectInst *SI) {
4634 const BasicBlock *BB = SI->getParent();
4635 if (!BB)
4636 return false;
4637 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
4638 if (!BI || BI->getNumSuccessors() != 2)
4639 return false;
4640 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
4641 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
4642 return false;
4643 return true;
4644}
4645
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004646/// True when a select result is replaced by one of its operands
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004647/// in select-icmp sequence. This will eventually result in the elimination
4648/// of the select.
4649///
4650/// \param SI Select instruction
4651/// \param Icmp Compare instruction
4652/// \param SIOpd Operand that replaces the select
4653///
4654/// Notes:
4655/// - The replacement is global and requires dominator information
4656/// - The caller is responsible for the actual replacement
4657///
4658/// Example:
4659///
4660/// entry:
4661/// %4 = select i1 %3, %C* %0, %C* null
4662/// %5 = icmp eq %C* %4, null
4663/// br i1 %5, label %9, label %7
4664/// ...
4665/// ; <label>:7 ; preds = %entry
4666/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
4667/// ...
4668///
4669/// can be transformed to
4670///
4671/// %5 = icmp eq %C* %0, null
4672/// %6 = select i1 %3, i1 %5, i1 true
4673/// br i1 %6, label %9, label %7
4674/// ...
4675/// ; <label>:7 ; preds = %entry
4676/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4677///
4678/// Similar when the first operand of the select is a constant or/and
4679/// the compare is for not equal rather than equal.
4680///
4681/// NOTE: The function is only called when the select and compare constants
4682/// are equal, the optimization can work only for EQ predicates. This is not a
4683/// major restriction since a NE compare should be 'normalized' to an equal
4684/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004685/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004686bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4687 const ICmpInst *Icmp,
4688 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004689 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004690 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4691 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004692 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004693 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004694 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4695 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4696 // replaced can be reached on either path. So the uniqueness check
4697 // guarantees that the path all uses of SI (outside SI's parent) are on
4698 // is disjoint from all other paths out of SI. But that information
4699 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004700 // of compile-time. It should also be noticed that we check for a single
4701 // predecessor and not only uniqueness. This to handle the situation when
4702 // Succ and Succ1 points to the same basic block.
4703 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004704 NumSel++;
4705 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4706 return true;
4707 }
4708 }
4709 return false;
4710}
4711
Sanjay Patel3151dec2016-09-12 15:24:31 +00004712/// Try to fold the comparison based on range information we can get by checking
4713/// whether bits are known to be zero or one in the inputs.
4714Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4715 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4716 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004717 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004718
4719 // Get scalar or pointer size.
4720 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4721 ? Ty->getScalarSizeInBits()
Elena Demikhovsky945b7e52018-02-14 06:58:08 +00004722 : DL.getIndexTypeSizeInBits(Ty->getScalarType());
Sanjay Patel3151dec2016-09-12 15:24:31 +00004723
4724 if (!BitWidth)
4725 return nullptr;
4726
Craig Topperb45eabc2017-04-26 16:39:58 +00004727 KnownBits Op0Known(BitWidth);
4728 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004729
Craig Topper47596dd2017-03-25 06:52:52 +00004730 if (SimplifyDemandedBits(&I, 0,
Craig Topper3edda872017-09-22 18:57:23 +00004731 getDemandedBitsLHSMask(I, BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004732 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004733 return &I;
4734
Craig Topper47596dd2017-03-25 06:52:52 +00004735 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004736 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004737 return &I;
4738
4739 // Given the known and unknown bits, compute a range that the LHS could be
4740 // in. Compute the Min, Max and RHS values based on the known bits. For the
4741 // EQ and NE we use unsigned values.
4742 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4743 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4744 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004745 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4746 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004747 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004748 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4749 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004750 }
4751
Sanjay Patelc63f9012018-01-04 14:31:56 +00004752 // If Min and Max are known to be the same, then SimplifyDemandedBits figured
4753 // out that the LHS or RHS is a constant. Constant fold this now, so that
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004754 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004755 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004756 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004757 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004758 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004759
4760 // Based on the range information we know about the LHS, see if we can
4761 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004762 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004763 default:
4764 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004765 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004766 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004767 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4768 return Pred == CmpInst::ICMP_EQ
4769 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4770 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4771 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004772
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004773 // If all bits are known zero except for one, then we know at most one bit
4774 // is set. If the comparison is against zero, then this is a check to see if
4775 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004776 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004777 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004778 // If the LHS is an AND with the same constant, look through it.
4779 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004780 const APInt *LHSC;
4781 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4782 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004783 LHS = Op0;
4784
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004785 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004786 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4787 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004788 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004789 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004790 // ((1 << X) & 8) == 0 -> X != 3
4791 // ((1 << X) & 8) != 0 -> X == 3
4792 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4793 auto NewPred = ICmpInst::getInversePredicate(Pred);
4794 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004795 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004796 // ((1 << X) & 7) == 0 -> X >= 3
4797 // ((1 << X) & 7) != 0 -> X < 3
4798 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4799 auto NewPred =
4800 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4801 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004802 }
4803 }
4804
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004805 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004806 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004807 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004808 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4809 // ((8 >>u X) & 1) == 0 -> X != 3
4810 // ((8 >>u X) & 1) != 0 -> X == 3
4811 unsigned CmpVal = CI->countTrailingZeros();
4812 auto NewPred = ICmpInst::getInversePredicate(Pred);
4813 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4814 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004815 }
4816 break;
4817 }
4818 case ICmpInst::ICMP_ULT: {
4819 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4820 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4821 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4822 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4823 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4824 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4825
Craig Topper0cd25942017-09-27 22:57:18 +00004826 const APInt *CmpC;
4827 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004828 // A <u C -> A == C-1 if min(A)+1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004829 if (*CmpC == Op0Min + 1)
Craig Topper2c9b7d72017-09-22 18:57:20 +00004830 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004831 ConstantInt::get(Op1->getType(), *CmpC - 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004832 // X <u C --> X == 0, if the number of zero bits in the bottom of X
4833 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004834 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2())
Craig Topper30dc9792017-09-25 21:15:00 +00004835 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4836 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004837 }
4838 break;
4839 }
4840 case ICmpInst::ICMP_UGT: {
4841 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4842 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004843 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4844 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004845 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4846 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4847
Craig Topper0cd25942017-09-27 22:57:18 +00004848 const APInt *CmpC;
4849 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004850 // A >u C -> A == C+1 if max(a)-1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004851 if (*CmpC == Op0Max - 1)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004852 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004853 ConstantInt::get(Op1->getType(), *CmpC + 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004854 // X >u C --> X != 0, if the number of zero bits in the bottom of X
4855 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004856 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits())
Craig Topper30dc9792017-09-25 21:15:00 +00004857 return new ICmpInst(ICmpInst::ICMP_NE, Op0,
4858 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004859 }
4860 break;
4861 }
Craig Topper0cd25942017-09-27 22:57:18 +00004862 case ICmpInst::ICMP_SLT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004863 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4864 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4865 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4866 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4867 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4868 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004869 const APInt *CmpC;
4870 if (match(Op1, m_APInt(CmpC))) {
4871 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004872 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004873 ConstantInt::get(Op1->getType(), *CmpC - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004874 }
4875 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004876 }
4877 case ICmpInst::ICMP_SGT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004878 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4879 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4880 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4881 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004882 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4883 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004884 const APInt *CmpC;
4885 if (match(Op1, m_APInt(CmpC))) {
4886 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004887 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004888 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004889 }
4890 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004891 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004892 case ICmpInst::ICMP_SGE:
4893 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4894 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4895 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4896 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4897 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004898 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B)
4899 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004900 break;
4901 case ICmpInst::ICMP_SLE:
4902 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4903 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4904 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4905 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4906 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004907 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B)
4908 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004909 break;
4910 case ICmpInst::ICMP_UGE:
4911 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4912 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4913 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4914 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4915 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004916 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B)
4917 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004918 break;
4919 case ICmpInst::ICMP_ULE:
4920 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4921 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4922 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4923 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4924 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004925 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B)
4926 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004927 break;
4928 }
4929
4930 // Turn a signed comparison into an unsigned one if both operands are known to
4931 // have the same sign.
4932 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004933 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4934 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004935 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4936
4937 return nullptr;
4938}
4939
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004940llvm::Optional<std::pair<CmpInst::Predicate, Constant *>>
4941llvm::getFlippedStrictnessPredicateAndConstant(CmpInst::Predicate Pred,
4942 Constant *C) {
4943 assert(ICmpInst::isRelational(Pred) && ICmpInst::isIntPredicate(Pred) &&
Roman Lebedev2c75fe72019-08-24 06:49:25 +00004944 "Only for relational integer predicates.");
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004945
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004946 Type *Type = C->getType();
4947 bool IsSigned = ICmpInst::isSigned(Pred);
Roman Lebedev2c75fe72019-08-24 06:49:25 +00004948
4949 CmpInst::Predicate UnsignedPred = ICmpInst::getUnsignedPredicate(Pred);
4950 bool WillIncrement =
4951 UnsignedPred == ICmpInst::ICMP_ULE || UnsignedPred == ICmpInst::ICMP_UGT;
4952
4953 // Check if the constant operand can be safely incremented/decremented
4954 // without overflowing/underflowing.
4955 auto ConstantIsOk = [WillIncrement, IsSigned](ConstantInt *C) {
4956 return WillIncrement ? !C->isMaxValue(IsSigned) : !C->isMinValue(IsSigned);
4957 };
4958
4959 // For scalars, SimplifyICmpInst should have already handled
4960 // the edge cases for us, so we just assert on them.
4961 // For vectors, we must handle the edge cases.
4962 if (auto *CI = dyn_cast<ConstantInt>(C)) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004963 // A <= MAX -> TRUE ; A >= MIN -> TRUE
Roman Lebedev2c75fe72019-08-24 06:49:25 +00004964 assert(ConstantIsOk(CI));
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004965 } else if (Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004966 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004967 // are for scalar, we could remove the min/max checks. However, to do that,
4968 // we would have to use insertelement/shufflevector to replace edge values.
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004969 unsigned NumElts = Type->getVectorNumElements();
Sanjay Patele9b2c322016-05-17 00:57:57 +00004970 for (unsigned i = 0; i != NumElts; ++i) {
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004971 Constant *Elt = C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004972 if (!Elt)
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004973 return llvm::None;
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004974
Sanjay Patele9b2c322016-05-17 00:57:57 +00004975 if (isa<UndefValue>(Elt))
4976 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004977
Sanjay Patele9b2c322016-05-17 00:57:57 +00004978 // Bail out if we can't determine if this constant is min/max or if we
4979 // know that this constant is min/max.
4980 auto *CI = dyn_cast<ConstantInt>(Elt);
Roman Lebedev2c75fe72019-08-24 06:49:25 +00004981 if (!CI || !ConstantIsOk(CI))
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004982 return llvm::None;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004983 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004984 } else {
4985 // ConstantExpr?
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004986 return llvm::None;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004987 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004988
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004989 CmpInst::Predicate NewPred = CmpInst::getFlippedStrictnessPredicate(Pred);
4990
4991 // Increment or decrement the constant.
Roman Lebedev2c75fe72019-08-24 06:49:25 +00004992 Constant *OneOrNegOne = ConstantInt::get(Type, WillIncrement ? 1 : -1, true);
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00004993 Constant *NewC = ConstantExpr::getAdd(C, OneOrNegOne);
4994
4995 return std::make_pair(NewPred, NewC);
4996}
4997
4998/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4999/// it into the appropriate icmp lt or icmp gt instruction. This transform
5000/// allows them to be folded in visitICmpInst.
5001static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
5002 ICmpInst::Predicate Pred = I.getPredicate();
5003 if (ICmpInst::isEquality(Pred) || !ICmpInst::isIntPredicate(Pred) ||
5004 isCanonicalPredicate(Pred))
5005 return nullptr;
5006
5007 Value *Op0 = I.getOperand(0);
5008 Value *Op1 = I.getOperand(1);
5009 auto *Op1C = dyn_cast<Constant>(Op1);
5010 if (!Op1C)
5011 return nullptr;
5012
5013 auto FlippedStrictness = getFlippedStrictnessPredicateAndConstant(Pred, Op1C);
5014 if (!FlippedStrictness)
5015 return nullptr;
5016
5017 return new ICmpInst(FlippedStrictness->first, Op0, FlippedStrictness->second);
Sanjay Pateld5b0e542016-04-29 16:22:25 +00005018}
5019
Sanjay Patele5747e32017-05-17 22:15:07 +00005020/// Integer compare with boolean values can always be turned into bitwise ops.
5021static Instruction *canonicalizeICmpBool(ICmpInst &I,
5022 InstCombiner::BuilderTy &Builder) {
5023 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00005024 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00005025
Sanjay Patelba212c22017-05-17 22:29:40 +00005026 // A boolean compared to true/false can be simplified to Op0/true/false in
5027 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
5028 // Cases not handled by InstSimplify are always 'not' of Op0.
5029 if (match(B, m_Zero())) {
5030 switch (I.getPredicate()) {
5031 case CmpInst::ICMP_EQ: // A == 0 -> !A
5032 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
5033 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
5034 return BinaryOperator::CreateNot(A);
5035 default:
5036 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
5037 }
5038 } else if (match(B, m_One())) {
5039 switch (I.getPredicate()) {
5040 case CmpInst::ICMP_NE: // A != 1 -> !A
5041 case CmpInst::ICMP_ULT: // A <u 1 -> !A
5042 case CmpInst::ICMP_SGT: // A >s -1 -> !A
5043 return BinaryOperator::CreateNot(A);
5044 default:
5045 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
5046 }
5047 }
5048
Sanjay Patele5747e32017-05-17 22:15:07 +00005049 switch (I.getPredicate()) {
5050 default:
5051 llvm_unreachable("Invalid icmp instruction!");
5052 case ICmpInst::ICMP_EQ:
5053 // icmp eq i1 A, B -> ~(A ^ B)
5054 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
5055
5056 case ICmpInst::ICMP_NE:
5057 // icmp ne i1 A, B -> A ^ B
5058 return BinaryOperator::CreateXor(A, B);
5059
5060 case ICmpInst::ICMP_UGT:
5061 // icmp ugt -> icmp ult
5062 std::swap(A, B);
5063 LLVM_FALLTHROUGH;
5064 case ICmpInst::ICMP_ULT:
5065 // icmp ult i1 A, B -> ~A & B
5066 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
5067
5068 case ICmpInst::ICMP_SGT:
5069 // icmp sgt -> icmp slt
5070 std::swap(A, B);
5071 LLVM_FALLTHROUGH;
5072 case ICmpInst::ICMP_SLT:
5073 // icmp slt i1 A, B -> A & ~B
5074 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
5075
5076 case ICmpInst::ICMP_UGE:
5077 // icmp uge -> icmp ule
5078 std::swap(A, B);
5079 LLVM_FALLTHROUGH;
5080 case ICmpInst::ICMP_ULE:
5081 // icmp ule i1 A, B -> ~A | B
5082 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
5083
5084 case ICmpInst::ICMP_SGE:
5085 // icmp sge -> icmp sle
5086 std::swap(A, B);
5087 LLVM_FALLTHROUGH;
5088 case ICmpInst::ICMP_SLE:
5089 // icmp sle i1 A, B -> A | ~B
5090 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
5091 }
5092}
5093
Roman Lebedev75404fb2018-09-12 18:19:43 +00005094// Transform pattern like:
Roman Lebedev1b7fc872018-09-15 12:04:13 +00005095// (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X
5096// (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X
Roman Lebedev75404fb2018-09-12 18:19:43 +00005097// Into:
5098// (X l>> Y) != 0
5099// (X l>> Y) == 0
5100static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp,
5101 InstCombiner::BuilderTy &Builder) {
Roman Lebedev6dc87002018-09-13 20:33:12 +00005102 ICmpInst::Predicate Pred, NewPred;
Roman Lebedev75404fb2018-09-12 18:19:43 +00005103 Value *X, *Y;
Roman Lebedev6dc87002018-09-13 20:33:12 +00005104 if (match(&Cmp,
5105 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) {
5106 // We want X to be the icmp's second operand, so swap predicate if it isn't.
5107 if (Cmp.getOperand(0) == X)
5108 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00005109
Roman Lebedev6dc87002018-09-13 20:33:12 +00005110 switch (Pred) {
5111 case ICmpInst::ICMP_ULE:
5112 NewPred = ICmpInst::ICMP_NE;
5113 break;
5114 case ICmpInst::ICMP_UGT:
5115 NewPred = ICmpInst::ICMP_EQ;
5116 break;
5117 default:
5118 return nullptr;
5119 }
Roman Lebedev1b7fc872018-09-15 12:04:13 +00005120 } else if (match(&Cmp, m_c_ICmp(Pred,
5121 m_OneUse(m_CombineOr(
5122 m_Not(m_Shl(m_AllOnes(), m_Value(Y))),
5123 m_Add(m_Shl(m_One(), m_Value(Y)),
5124 m_AllOnes()))),
5125 m_Value(X)))) {
5126 // The variant with 'add' is not canonical, (the variant with 'not' is)
5127 // we only get it because it has extra uses, and can't be canonicalized,
5128
Roman Lebedev6dc87002018-09-13 20:33:12 +00005129 // We want X to be the icmp's second operand, so swap predicate if it isn't.
5130 if (Cmp.getOperand(0) == X)
5131 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00005132
Roman Lebedev6dc87002018-09-13 20:33:12 +00005133 switch (Pred) {
5134 case ICmpInst::ICMP_ULT:
5135 NewPred = ICmpInst::ICMP_NE;
5136 break;
5137 case ICmpInst::ICMP_UGE:
5138 NewPred = ICmpInst::ICMP_EQ;
5139 break;
5140 default:
5141 return nullptr;
5142 }
5143 } else
Roman Lebedev75404fb2018-09-12 18:19:43 +00005144 return nullptr;
Roman Lebedev75404fb2018-09-12 18:19:43 +00005145
5146 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits");
5147 Constant *Zero = Constant::getNullValue(NewX->getType());
5148 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero);
5149}
5150
Sanjay Patel039f5562018-08-16 12:52:17 +00005151static Instruction *foldVectorCmp(CmpInst &Cmp,
5152 InstCombiner::BuilderTy &Builder) {
5153 // If both arguments of the cmp are shuffles that use the same mask and
5154 // shuffle within a single vector, move the shuffle after the cmp.
5155 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1);
5156 Value *V1, *V2;
5157 Constant *M;
5158 if (match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Constant(M))) &&
5159 match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_Specific(M))) &&
5160 V1->getType() == V2->getType() &&
5161 (LHS->hasOneUse() || RHS->hasOneUse())) {
5162 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M
5163 CmpInst::Predicate P = Cmp.getPredicate();
5164 Value *NewCmp = isa<ICmpInst>(Cmp) ? Builder.CreateICmp(P, V1, V2)
5165 : Builder.CreateFCmp(P, V1, V2);
5166 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M);
5167 }
5168 return nullptr;
5169}
5170
Chris Lattner2188e402010-01-04 07:37:31 +00005171Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
5172 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00005173 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00005174 unsigned Op0Cplxity = getComplexity(Op0);
5175 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005176
Chris Lattner2188e402010-01-04 07:37:31 +00005177 /// Orders the operands of the compare so that they are listed from most
5178 /// complex to least complex. This puts constants before unary operators,
5179 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00005180 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00005181 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00005182 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00005183 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00005184 Changed = true;
5185 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005186
Daniel Berlin2c75c632017-04-26 20:56:07 +00005187 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
5188 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005189 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005190
Uriel Korach18972232017-09-10 08:31:22 +00005191 // Comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00005192 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00005193 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00005194 Value *Cond, *SelectTrue, *SelectFalse;
5195 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00005196 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00005197 if (Value *V = dyn_castNegVal(SelectTrue)) {
5198 if (V == SelectFalse)
5199 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
5200 }
5201 else if (Value *V = dyn_castNegVal(SelectFalse)) {
5202 if (V == SelectTrue)
5203 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00005204 }
5205 }
5206 }
5207
Craig Topperfde47232017-07-09 07:04:03 +00005208 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00005209 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00005210 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005211
Sanjay Patele9b2c322016-05-17 00:57:57 +00005212 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00005213 return NewICmp;
5214
Sanjay Patel06b127a2016-09-15 14:37:50 +00005215 if (Instruction *Res = foldICmpWithConstant(I))
5216 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005217
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00005218 if (Instruction *Res = foldICmpWithDominatingICmp(I))
5219 return Res;
5220
Max Kazantsev20da7e42018-07-06 04:04:13 +00005221 if (Instruction *Res = foldICmpUsingKnownBits(I))
5222 return Res;
5223
Chris Lattner2188e402010-01-04 07:37:31 +00005224 // Test if the ICmpInst instruction is used exclusively by a select as
5225 // part of a minimum or maximum operation. If so, refrain from doing
5226 // any other folding. This helps out other analyses which understand
5227 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5228 // and CodeGen. And in this case, at least one of the comparison
5229 // operands has at least one user besides the compare (the select),
5230 // which would often largely negate the benefit of folding anyway.
Craig Topperd3e57812017-11-12 02:28:21 +00005231 //
5232 // Do the same for the other patterns recognized by matchSelectPattern.
Chris Lattner2188e402010-01-04 07:37:31 +00005233 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005234 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5235 Value *A, *B;
5236 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5237 if (SPR.Flavor != SPF_UNKNOWN)
Craig Topperf40110f2014-04-25 05:29:35 +00005238 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005239 }
Chris Lattner2188e402010-01-04 07:37:31 +00005240
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00005241 // Do this after checking for min/max to prevent infinite looping.
5242 if (Instruction *Res = foldICmpWithZero(I))
5243 return Res;
5244
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00005245 // FIXME: We only do this after checking for min/max to prevent infinite
5246 // looping caused by a reverse canonicalization of these patterns for min/max.
5247 // FIXME: The organization of folds is a mess. These would naturally go into
5248 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
5249 // down here after the min/max restriction.
5250 ICmpInst::Predicate Pred = I.getPredicate();
5251 const APInt *C;
5252 if (match(Op1, m_APInt(C))) {
5253 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
5254 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
5255 Constant *Zero = Constant::getNullValue(Op0->getType());
5256 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
5257 }
5258
5259 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
5260 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
5261 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
5262 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
5263 }
5264 }
5265
Sanjay Patelf58f68c2016-09-10 15:03:44 +00005266 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00005267 return Res;
5268
Sanjay Patel10494b22016-09-16 16:10:22 +00005269 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
5270 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005271
5272 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
5273 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00005274 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00005275 return NI;
5276 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00005277 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00005278 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
5279 return NI;
5280
Hans Wennborgf1f36512015-10-07 00:20:07 +00005281 // Try to optimize equality comparisons against alloca-based pointers.
5282 if (Op0->getType()->isPointerTy() && I.isEquality()) {
5283 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
5284 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00005285 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00005286 return New;
5287 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00005288 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00005289 return New;
5290 }
5291
Sanjay Patele7f46c32019-02-07 20:54:09 +00005292 if (Instruction *Res = foldICmpBitCast(I, Builder))
5293 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005294
Sanjay Patela90ee0e2019-08-20 14:56:44 +00005295 if (Instruction *R = foldICmpWithCastOp(I))
5296 return R;
Chris Lattner2188e402010-01-04 07:37:31 +00005297
Sanjay Patel10494b22016-09-16 16:10:22 +00005298 if (Instruction *Res = foldICmpBinOp(I))
5299 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00005300
Sanjay Pateldd46b522016-12-19 17:32:37 +00005301 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00005302 return Res;
5303
Sanjay Patel10494b22016-09-16 16:10:22 +00005304 {
5305 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00005306 // Transform (A & ~B) == 0 --> (A & B) != 0
5307 // and (A & ~B) != 0 --> (A & B) == 0
5308 // if A is a power of 2.
5309 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00005310 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00005311 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00005312 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00005313 Op1);
5314
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005315 // ~X < ~Y --> Y < X
5316 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005317 if (match(Op0, m_Not(m_Value(A)))) {
5318 if (match(Op1, m_Not(m_Value(B))))
5319 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005320
Sanjay Patelce241f42017-06-02 16:29:41 +00005321 const APInt *C;
5322 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005323 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00005324 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005325 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00005326
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005327 Instruction *AddI = nullptr;
5328 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
5329 m_Instruction(AddI))) &&
5330 isa<IntegerType>(A->getType())) {
5331 Value *Result;
5332 Constant *Overflow;
Nikita Popov352f5982019-05-26 11:43:31 +00005333 if (OptimizeOverflowCheck(Instruction::Add, /*Signed*/false, A, B,
5334 *AddI, Result, Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00005335 replaceInstUsesWith(*AddI, Result);
5336 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005337 }
5338 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005339
5340 // (zext a) * (zext b) --> llvm.umul.with.overflow.
5341 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005342 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005343 return R;
5344 }
5345 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005346 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005347 return R;
5348 }
Chris Lattner2188e402010-01-04 07:37:31 +00005349 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005350
Sanjay Patel10494b22016-09-16 16:10:22 +00005351 if (Instruction *Res = foldICmpEquality(I))
5352 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005353
David Majnemerc1eca5a2014-11-06 23:23:30 +00005354 // The 'cmpxchg' instruction returns an aggregate containing the old value and
5355 // an i1 which indicates whether or not we successfully did the swap.
5356 //
5357 // Replace comparisons between the old value and the expected value with the
5358 // indicator that 'cmpxchg' returns.
5359 //
5360 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
5361 // spuriously fail. In those cases, the old value may equal the expected
5362 // value but it is possible for the swap to not occur.
5363 if (I.getPredicate() == ICmpInst::ICMP_EQ)
5364 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
5365 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
5366 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
5367 !ACXI->isWeak())
5368 return ExtractValueInst::Create(ACXI, 1);
5369
Chris Lattner2188e402010-01-04 07:37:31 +00005370 {
Craig Topperbee74792018-08-20 23:04:25 +00005371 Value *X;
5372 const APInt *C;
Chris Lattner2188e402010-01-04 07:37:31 +00005373 // icmp X+Cst, X
Craig Topperbee74792018-08-20 23:04:25 +00005374 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X)
5375 return foldICmpAddOpConst(X, *C, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005376
5377 // icmp X, X+Cst
Craig Topperbee74792018-08-20 23:04:25 +00005378 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X)
5379 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005380 }
Roman Lebedev68d54cf2018-07-11 19:05:04 +00005381
Roman Lebedev75404fb2018-09-12 18:19:43 +00005382 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder))
5383 return Res;
5384
Sanjay Patel039f5562018-08-16 12:52:17 +00005385 if (I.getType()->isVectorTy())
5386 if (Instruction *Res = foldVectorCmp(I, Builder))
5387 return Res;
5388
Craig Topperf40110f2014-04-25 05:29:35 +00005389 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005390}
5391
Sanjay Patel5f0217f2016-06-05 16:46:18 +00005392/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00005393Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00005394 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00005395 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005396 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005397
Chris Lattner2188e402010-01-04 07:37:31 +00005398 // Get the width of the mantissa. We don't want to hack on conversions that
5399 // might lose information from the integer, e.g. "i64 -> float"
5400 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00005401 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005402
Matt Arsenault55e73122015-01-06 15:50:59 +00005403 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
5404
Chris Lattner2188e402010-01-04 07:37:31 +00005405 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005406
Matt Arsenault55e73122015-01-06 15:50:59 +00005407 if (I.isEquality()) {
5408 FCmpInst::Predicate P = I.getPredicate();
5409 bool IsExact = false;
5410 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
5411 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
5412
5413 // If the floating point constant isn't an integer value, we know if we will
5414 // ever compare equal / not equal to it.
5415 if (!IsExact) {
5416 // TODO: Can never be -0.0 and other non-representable values
5417 APFloat RHSRoundInt(RHS);
5418 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
5419 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
5420 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00005421 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00005422
5423 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00005424 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00005425 }
5426 }
5427
5428 // TODO: If the constant is exactly representable, is it always OK to do
5429 // equality compares as integer?
5430 }
5431
Arch D. Robison8ed08542015-09-15 17:51:59 +00005432 // Check to see that the input is converted from an integer type that is small
5433 // enough that preserves all bits. TODO: check here for "known" sign bits.
5434 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
5435 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00005436
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005437 // Following test does NOT adjust InputSize downwards for signed inputs,
5438 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00005439 // to distinguish it from one less than that value.
5440 if ((int)InputSize > MantissaWidth) {
5441 // Conversion would lose accuracy. Check if loss can impact comparison.
5442 int Exp = ilogb(RHS);
5443 if (Exp == APFloat::IEK_Inf) {
5444 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005445 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005446 // Conversion could create infinity.
5447 return nullptr;
5448 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005449 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00005450 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005451 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005452 // Conversion could affect comparison.
5453 return nullptr;
5454 }
5455 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005456
Chris Lattner2188e402010-01-04 07:37:31 +00005457 // Otherwise, we can potentially simplify the comparison. We know that it
5458 // will always come through as an integer value and we know the constant is
5459 // not a NAN (it would have been previously simplified).
5460 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00005461
Chris Lattner2188e402010-01-04 07:37:31 +00005462 ICmpInst::Predicate Pred;
5463 switch (I.getPredicate()) {
5464 default: llvm_unreachable("Unexpected predicate!");
5465 case FCmpInst::FCMP_UEQ:
5466 case FCmpInst::FCMP_OEQ:
5467 Pred = ICmpInst::ICMP_EQ;
5468 break;
5469 case FCmpInst::FCMP_UGT:
5470 case FCmpInst::FCMP_OGT:
5471 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
5472 break;
5473 case FCmpInst::FCMP_UGE:
5474 case FCmpInst::FCMP_OGE:
5475 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
5476 break;
5477 case FCmpInst::FCMP_ULT:
5478 case FCmpInst::FCMP_OLT:
5479 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
5480 break;
5481 case FCmpInst::FCMP_ULE:
5482 case FCmpInst::FCMP_OLE:
5483 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
5484 break;
5485 case FCmpInst::FCMP_UNE:
5486 case FCmpInst::FCMP_ONE:
5487 Pred = ICmpInst::ICMP_NE;
5488 break;
5489 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00005490 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005491 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00005492 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005493 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005494
Chris Lattner2188e402010-01-04 07:37:31 +00005495 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005496
Chris Lattner2188e402010-01-04 07:37:31 +00005497 // See if the FP constant is too large for the integer. For example,
5498 // comparing an i8 to 300.0.
5499 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005500
Chris Lattner2188e402010-01-04 07:37:31 +00005501 if (!LHSUnsigned) {
5502 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
5503 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005504 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005505 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
5506 APFloat::rmNearestTiesToEven);
5507 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
5508 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
5509 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005510 return replaceInstUsesWith(I, Builder.getTrue());
5511 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005512 }
5513 } else {
5514 // If the RHS value is > UnsignedMax, fold the comparison. This handles
5515 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005516 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005517 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
5518 APFloat::rmNearestTiesToEven);
5519 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
5520 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
5521 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005522 return replaceInstUsesWith(I, Builder.getTrue());
5523 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005524 }
5525 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005526
Chris Lattner2188e402010-01-04 07:37:31 +00005527 if (!LHSUnsigned) {
5528 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005529 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005530 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
5531 APFloat::rmNearestTiesToEven);
5532 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
5533 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
5534 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005535 return replaceInstUsesWith(I, Builder.getTrue());
5536 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005537 }
Devang Patel698452b2012-02-13 23:05:18 +00005538 } else {
5539 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005540 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00005541 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
5542 APFloat::rmNearestTiesToEven);
5543 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
5544 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
5545 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005546 return replaceInstUsesWith(I, Builder.getTrue());
5547 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00005548 }
Chris Lattner2188e402010-01-04 07:37:31 +00005549 }
5550
5551 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
5552 // [0, UMAX], but it may still be fractional. See if it is fractional by
5553 // casting the FP value to the integer value and back, checking for equality.
5554 // Don't do this for zero, because -0.0 is not fractional.
5555 Constant *RHSInt = LHSUnsigned
5556 ? ConstantExpr::getFPToUI(RHSC, IntTy)
5557 : ConstantExpr::getFPToSI(RHSC, IntTy);
5558 if (!RHS.isZero()) {
5559 bool Equal = LHSUnsigned
5560 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
5561 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
5562 if (!Equal) {
5563 // If we had a comparison against a fractional value, we have to adjust
5564 // the compare predicate and sometimes the value. RHSC is rounded towards
5565 // zero at this point.
5566 switch (Pred) {
5567 default: llvm_unreachable("Unexpected integer comparison!");
5568 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00005569 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005570 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00005571 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005572 case ICmpInst::ICMP_ULE:
5573 // (float)int <= 4.4 --> int <= 4
5574 // (float)int <= -4.4 --> false
5575 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005576 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005577 break;
5578 case ICmpInst::ICMP_SLE:
5579 // (float)int <= 4.4 --> int <= 4
5580 // (float)int <= -4.4 --> int < -4
5581 if (RHS.isNegative())
5582 Pred = ICmpInst::ICMP_SLT;
5583 break;
5584 case ICmpInst::ICMP_ULT:
5585 // (float)int < -4.4 --> false
5586 // (float)int < 4.4 --> int <= 4
5587 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005588 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005589 Pred = ICmpInst::ICMP_ULE;
5590 break;
5591 case ICmpInst::ICMP_SLT:
5592 // (float)int < -4.4 --> int < -4
5593 // (float)int < 4.4 --> int <= 4
5594 if (!RHS.isNegative())
5595 Pred = ICmpInst::ICMP_SLE;
5596 break;
5597 case ICmpInst::ICMP_UGT:
5598 // (float)int > 4.4 --> int > 4
5599 // (float)int > -4.4 --> true
5600 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005601 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005602 break;
5603 case ICmpInst::ICMP_SGT:
5604 // (float)int > 4.4 --> int > 4
5605 // (float)int > -4.4 --> int >= -4
5606 if (RHS.isNegative())
5607 Pred = ICmpInst::ICMP_SGE;
5608 break;
5609 case ICmpInst::ICMP_UGE:
5610 // (float)int >= -4.4 --> true
5611 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00005612 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005613 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005614 Pred = ICmpInst::ICMP_UGT;
5615 break;
5616 case ICmpInst::ICMP_SGE:
5617 // (float)int >= -4.4 --> int >= -4
5618 // (float)int >= 4.4 --> int > 4
5619 if (!RHS.isNegative())
5620 Pred = ICmpInst::ICMP_SGT;
5621 break;
5622 }
5623 }
5624 }
5625
5626 // Lower this FP comparison into an appropriate integer version of the
5627 // comparison.
5628 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
5629}
5630
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005631/// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary.
5632static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI,
5633 Constant *RHSC) {
5634 // When C is not 0.0 and infinities are not allowed:
5635 // (C / X) < 0.0 is a sign-bit test of X
5636 // (C / X) < 0.0 --> X < 0.0 (if C is positive)
5637 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate)
5638 //
5639 // Proof:
5640 // Multiply (C / X) < 0.0 by X * X / C.
5641 // - X is non zero, if it is the flag 'ninf' is violated.
5642 // - C defines the sign of X * X * C. Thus it also defines whether to swap
5643 // the predicate. C is also non zero by definition.
5644 //
5645 // Thus X * X / C is non zero and the transformation is valid. [qed]
5646
5647 FCmpInst::Predicate Pred = I.getPredicate();
5648
5649 // Check that predicates are valid.
5650 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) &&
5651 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE))
5652 return nullptr;
5653
5654 // Check that RHS operand is zero.
5655 if (!match(RHSC, m_AnyZeroFP()))
5656 return nullptr;
5657
5658 // Check fastmath flags ('ninf').
5659 if (!LHSI->hasNoInfs() || !I.hasNoInfs())
5660 return nullptr;
5661
5662 // Check the properties of the dividend. It must not be zero to avoid a
5663 // division by zero (see Proof).
5664 const APFloat *C;
5665 if (!match(LHSI->getOperand(0), m_APFloat(C)))
5666 return nullptr;
5667
5668 if (C->isZero())
5669 return nullptr;
5670
5671 // Get swapped predicate if necessary.
5672 if (C->isNegative())
5673 Pred = I.getSwappedPredicate();
5674
Sanjay Pateld1172a02018-11-07 00:00:42 +00005675 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I);
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005676}
5677
Sanjay Patel1c254c62018-10-31 16:34:43 +00005678/// Optimize fabs(X) compared with zero.
5679static Instruction *foldFabsWithFcmpZero(FCmpInst &I) {
5680 Value *X;
5681 if (!match(I.getOperand(0), m_Intrinsic<Intrinsic::fabs>(m_Value(X))) ||
5682 !match(I.getOperand(1), m_PosZeroFP()))
5683 return nullptr;
5684
Sanjay Patel57a08b32018-11-07 16:15:01 +00005685 auto replacePredAndOp0 = [](FCmpInst *I, FCmpInst::Predicate P, Value *X) {
5686 I->setPredicate(P);
5687 I->setOperand(0, X);
5688 return I;
5689 };
5690
Sanjay Patel1c254c62018-10-31 16:34:43 +00005691 switch (I.getPredicate()) {
5692 case FCmpInst::FCMP_UGE:
5693 case FCmpInst::FCMP_OLT:
5694 // fabs(X) >= 0.0 --> true
5695 // fabs(X) < 0.0 --> false
5696 llvm_unreachable("fcmp should have simplified");
5697
5698 case FCmpInst::FCMP_OGT:
5699 // fabs(X) > 0.0 --> X != 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005700 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005701
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005702 case FCmpInst::FCMP_UGT:
5703 // fabs(X) u> 0.0 --> X u!= 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005704 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005705
Sanjay Patel1c254c62018-10-31 16:34:43 +00005706 case FCmpInst::FCMP_OLE:
5707 // fabs(X) <= 0.0 --> X == 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005708 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005709
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005710 case FCmpInst::FCMP_ULE:
5711 // fabs(X) u<= 0.0 --> X u== 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005712 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005713
Sanjay Patel1c254c62018-10-31 16:34:43 +00005714 case FCmpInst::FCMP_OGE:
5715 // fabs(X) >= 0.0 --> !isnan(X)
5716 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005717 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005718
Sanjay Patel76faf512018-11-07 15:11:32 +00005719 case FCmpInst::FCMP_ULT:
5720 // fabs(X) u< 0.0 --> isnan(X)
5721 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005722 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X);
Sanjay Patel76faf512018-11-07 15:11:32 +00005723
Sanjay Patel1c254c62018-10-31 16:34:43 +00005724 case FCmpInst::FCMP_OEQ:
5725 case FCmpInst::FCMP_UEQ:
5726 case FCmpInst::FCMP_ONE:
5727 case FCmpInst::FCMP_UNE:
Sanjay Patelbb521e62018-11-07 15:44:26 +00005728 case FCmpInst::FCMP_ORD:
5729 case FCmpInst::FCMP_UNO:
5730 // Look through the fabs() because it doesn't change anything but the sign.
5731 // fabs(X) == 0.0 --> X == 0.0,
Sanjay Patel1c254c62018-10-31 16:34:43 +00005732 // fabs(X) != 0.0 --> X != 0.0
Sanjay Patelbb521e62018-11-07 15:44:26 +00005733 // isnan(fabs(X)) --> isnan(X)
5734 // !isnan(fabs(X) --> !isnan(X)
Sanjay Patel57a08b32018-11-07 16:15:01 +00005735 return replacePredAndOp0(&I, I.getPredicate(), X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005736
5737 default:
5738 return nullptr;
5739 }
5740}
5741
Chris Lattner2188e402010-01-04 07:37:31 +00005742Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
5743 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005744
Chris Lattner2188e402010-01-04 07:37:31 +00005745 /// Orders the operands of the compare so that they are listed from most
5746 /// complex to least complex. This puts constants before unary operators,
5747 /// before binary operators.
5748 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
5749 I.swapOperands();
5750 Changed = true;
5751 }
5752
Sanjay Patel6b139462017-09-02 15:11:55 +00005753 const CmpInst::Predicate Pred = I.getPredicate();
Chris Lattner2188e402010-01-04 07:37:31 +00005754 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel6b139462017-09-02 15:11:55 +00005755 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(),
5756 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005757 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00005758
5759 // Simplify 'fcmp pred X, X'
Sanjay Patela706b9a2019-04-29 19:23:44 +00005760 Type *OpType = Op0->getType();
5761 assert(OpType == Op1->getType() && "fcmp with different-typed operands?");
Chris Lattner2188e402010-01-04 07:37:31 +00005762 if (Op0 == Op1) {
Sanjay Patel6b139462017-09-02 15:11:55 +00005763 switch (Pred) {
5764 default: break;
Chris Lattner2188e402010-01-04 07:37:31 +00005765 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
5766 case FCmpInst::FCMP_ULT: // True if unordered or less than
5767 case FCmpInst::FCMP_UGT: // True if unordered or greater than
5768 case FCmpInst::FCMP_UNE: // True if unordered or not equal
5769 // Canonicalize these to be 'fcmp uno %X, 0.0'.
5770 I.setPredicate(FCmpInst::FCMP_UNO);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005771 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005772 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005773
Chris Lattner2188e402010-01-04 07:37:31 +00005774 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
5775 case FCmpInst::FCMP_OEQ: // True if ordered and equal
5776 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
5777 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
5778 // Canonicalize these to be 'fcmp ord %X, 0.0'.
5779 I.setPredicate(FCmpInst::FCMP_ORD);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005780 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005781 return &I;
5782 }
5783 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005784
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005785 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand,
5786 // then canonicalize the operand to 0.0.
5787 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) {
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005788 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005789 I.setOperand(0, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005790 return &I;
5791 }
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005792 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005793 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005794 return &I;
5795 }
5796 }
5797
Sanjay Patel6a281a72019-05-07 18:58:07 +00005798 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y
5799 Value *X, *Y;
5800 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
5801 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I);
5802
James Molloy2b21a7c2015-05-20 18:41:25 +00005803 // Test if the FCmpInst instruction is used exclusively by a select as
5804 // part of a minimum or maximum operation. If so, refrain from doing
5805 // any other folding. This helps out other analyses which understand
5806 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5807 // and CodeGen. And in this case, at least one of the comparison
5808 // operands has at least one user besides the compare (the select),
5809 // which would often largely negate the benefit of folding anyway.
5810 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005811 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5812 Value *A, *B;
5813 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5814 if (SPR.Flavor != SPF_UNKNOWN)
James Molloy2b21a7c2015-05-20 18:41:25 +00005815 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005816 }
James Molloy2b21a7c2015-05-20 18:41:25 +00005817
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005818 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0:
5819 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0
5820 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005821 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005822 return &I;
5823 }
5824
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005825 // Handle fcmp with instruction LHS and constant RHS.
5826 Instruction *LHSI;
5827 Constant *RHSC;
5828 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) {
5829 switch (LHSI->getOpcode()) {
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005830 case Instruction::PHI:
5831 // Only fold fcmp into the PHI if the phi and fcmp are in the same
5832 // block. If in the same block, we're encouraging jump threading. If
5833 // not, we are just pessimizing the code by making an i1 phi.
5834 if (LHSI->getParent() == I.getParent())
5835 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00005836 return NV;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005837 break;
5838 case Instruction::SIToFP:
5839 case Instruction::UIToFP:
5840 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
5841 return NV;
5842 break;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00005843 case Instruction::FDiv:
5844 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC))
5845 return NV;
5846 break;
5847 case Instruction::Load:
5848 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0)))
5849 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
5850 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
5851 !cast<LoadInst>(LHSI)->isVolatile())
5852 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
5853 return Res;
5854 break;
Sanjay Patel1c254c62018-10-31 16:34:43 +00005855 }
Chris Lattner2188e402010-01-04 07:37:31 +00005856 }
5857
Sanjay Pateld1172a02018-11-07 00:00:42 +00005858 if (Instruction *R = foldFabsWithFcmpZero(I))
5859 return R;
5860
Sanjay Patel70282a02018-11-06 15:49:45 +00005861 if (match(Op0, m_FNeg(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005862 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C
Sanjay Patel70282a02018-11-06 15:49:45 +00005863 Constant *C;
5864 if (match(Op1, m_Constant(C))) {
Sanjay Patel70282a02018-11-06 15:49:45 +00005865 Constant *NegC = ConstantExpr::getFNeg(C);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005866 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I);
Sanjay Patel70282a02018-11-06 15:49:45 +00005867 }
5868 }
Benjamin Kramerd159d942011-03-31 10:12:22 +00005869
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005870 if (match(Op0, m_FPExt(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00005871 // fcmp (fpext X), (fpext Y) -> fcmp X, Y
5872 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType())
5873 return new FCmpInst(Pred, X, Y, "", &I);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005874
Sanjay Pateld1172a02018-11-07 00:00:42 +00005875 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless
Sanjay Patel724014a2018-11-06 17:20:20 +00005876 const APFloat *C;
5877 if (match(Op1, m_APFloat(C))) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005878 const fltSemantics &FPSem =
5879 X->getType()->getScalarType()->getFltSemantics();
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005880 bool Lossy;
Sanjay Patel724014a2018-11-06 17:20:20 +00005881 APFloat TruncC = *C;
5882 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005883
5884 // Avoid lossy conversions and denormals.
5885 // Zero is a special case that's OK to convert.
Sanjay Patel724014a2018-11-06 17:20:20 +00005886 APFloat Fabs = TruncC;
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005887 Fabs.clearSign();
5888 if (!Lossy &&
5889 ((Fabs.compare(APFloat::getSmallestNormalized(FPSem)) !=
Sanjay Patel46bf3922018-11-06 16:45:27 +00005890 APFloat::cmpLessThan) || Fabs.isZero())) {
Sanjay Patel724014a2018-11-06 17:20:20 +00005891 Constant *NewC = ConstantFP::get(X->getType(), TruncC);
Sanjay Pateld1172a02018-11-07 00:00:42 +00005892 return new FCmpInst(Pred, X, NewC, "", &I);
Sanjay Patel46bf3922018-11-06 16:45:27 +00005893 }
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00005894 }
Sanjay Patel1b85f0022018-11-06 16:23:03 +00005895 }
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005896
Sanjay Patel039f5562018-08-16 12:52:17 +00005897 if (I.getType()->isVectorTy())
5898 if (Instruction *Res = foldVectorCmp(I, Builder))
5899 return Res;
5900
Craig Topperf40110f2014-04-25 05:29:35 +00005901 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005902}