blob: 00feb01de400eff7ecd9eea7f98ad8c8c1ce40a0 [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements the visitICmp and visitFCmp functions.
11//
12//===----------------------------------------------------------------------===//
13
Chandler Carrutha9174582015-01-22 05:25:13 +000014#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000015#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000016#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000017#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000018#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000019#include "llvm/Analysis/InstructionSimplify.h"
20#include "llvm/Analysis/MemoryBuiltins.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000021#include "llvm/Analysis/TargetLibraryInfo.h"
22#include "llvm/Analysis/VectorUtils.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000023#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000024#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000025#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000026#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000027#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000028#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000029#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000030
Chris Lattner2188e402010-01-04 07:37:31 +000031using namespace llvm;
32using namespace PatternMatch;
33
Chandler Carruth964daaa2014-04-22 02:55:47 +000034#define DEBUG_TYPE "instcombine"
35
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000036// How many times is a select replaced by one of its operands?
37STATISTIC(NumSel, "Number of select opts");
38
Chris Lattner98457102011-02-10 05:23:05 +000039
Sanjay Patel5f0217f2016-06-05 16:46:18 +000040/// Compute Result = In1+In2, returning true if the result overflowed for this
41/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000042static bool addWithOverflow(APInt &Result, const APInt &In1,
43 const APInt &In2, bool IsSigned = false) {
44 bool Overflow;
45 if (IsSigned)
46 Result = In1.sadd_ov(In2, Overflow);
47 else
48 Result = In1.uadd_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000049
Craig Topper6e025a32017-10-01 23:53:54 +000050 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000051}
52
Sanjay Patel5f0217f2016-06-05 16:46:18 +000053/// Compute Result = In1-In2, returning true if the result overflowed for this
54/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000055static bool subWithOverflow(APInt &Result, const APInt &In1,
56 const APInt &In2, bool IsSigned = false) {
57 bool Overflow;
58 if (IsSigned)
59 Result = In1.ssub_ov(In2, Overflow);
60 else
61 Result = In1.usub_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000062
Craig Topper6e025a32017-10-01 23:53:54 +000063 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000064}
65
Balaram Makam569eaec2016-05-04 21:32:14 +000066/// Given an icmp instruction, return true if any use of this comparison is a
67/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +000068static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +000069 for (auto *U : I.users())
70 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +000071 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +000072 return false;
73}
74
Sanjay Patel5f0217f2016-06-05 16:46:18 +000075/// Given an exploded icmp instruction, return true if the comparison only
76/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
77/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +000078static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +000079 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +000080 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +000081 case ICmpInst::ICMP_SLT: // True if LHS s< 0
82 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +000083 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +000084 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
85 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000086 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000087 case ICmpInst::ICMP_SGT: // True if LHS s> -1
88 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +000089 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000090 case ICmpInst::ICMP_UGT:
91 // True if LHS u> RHS and RHS == high-bit-mask - 1
92 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000093 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +000094 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +000095 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
96 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +000097 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +000098 default:
99 return false;
100 }
101}
102
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000103/// Returns true if the exploded icmp can be expressed as a signed comparison
104/// to zero and updates the predicate accordingly.
105/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000106/// TODO: Refactor with decomposeBitTestICmp()?
107static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000108 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000109 return false;
110
Craig Topper73ba1c82017-06-07 07:40:37 +0000111 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000112 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000113
Craig Topper73ba1c82017-06-07 07:40:37 +0000114 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000115 if (Pred == ICmpInst::ICMP_SLT) {
116 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000117 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000118 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000119 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000120 if (Pred == ICmpInst::ICMP_SGT) {
121 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000122 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000123 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000124 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000125
126 return false;
127}
128
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000129/// Given a signed integer type and a set of known zero and one bits, compute
130/// the maximum and minimum values that could have the specified known zero and
131/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000132/// TODO: Move to method on KnownBits struct?
133static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000134 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000135 assert(Known.getBitWidth() == Min.getBitWidth() &&
136 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000137 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000138 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000139
140 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
141 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000142 Min = Known.One;
143 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000144
Chris Lattner2188e402010-01-04 07:37:31 +0000145 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000146 Min.setSignBit();
147 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000148 }
149}
150
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000151/// Given an unsigned integer type and a set of known zero and one bits, compute
152/// the maximum and minimum values that could have the specified known zero and
153/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000154/// TODO: Move to method on KnownBits struct?
155static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000156 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000157 assert(Known.getBitWidth() == Min.getBitWidth() &&
158 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000159 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000160 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000161
Chris Lattner2188e402010-01-04 07:37:31 +0000162 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000163 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000164 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000165 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000166}
167
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000168/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000169/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000170/// where GV is a global variable with a constant initializer. Try to simplify
171/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000172/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
173///
174/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000175/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000176Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
177 GlobalVariable *GV,
178 CmpInst &ICI,
179 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000180 Constant *Init = GV->getInitializer();
181 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000182 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000183
Chris Lattnerfe741762012-01-31 02:55:06 +0000184 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000185 // Don't blow up on huge arrays.
186 if (ArrayElementCount > MaxArraySizeForCombine)
187 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000188
Chris Lattner2188e402010-01-04 07:37:31 +0000189 // There are many forms of this optimization we can handle, for now, just do
190 // the simple index into a single-dimensional array.
191 //
192 // Require: GEP GV, 0, i {{, constant indices}}
193 if (GEP->getNumOperands() < 3 ||
194 !isa<ConstantInt>(GEP->getOperand(1)) ||
195 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
196 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000197 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000198
199 // Check that indices after the variable are constants and in-range for the
200 // type they index. Collect the indices. This is typically for arrays of
201 // structs.
202 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000203
Chris Lattnerfe741762012-01-31 02:55:06 +0000204 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000205 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
206 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000207 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000208
Chris Lattner2188e402010-01-04 07:37:31 +0000209 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000210 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000211
Chris Lattner229907c2011-07-18 04:54:35 +0000212 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000213 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000214 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000215 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000216 EltTy = ATy->getElementType();
217 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000218 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000219 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000220
Chris Lattner2188e402010-01-04 07:37:31 +0000221 LaterIndices.push_back(IdxVal);
222 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000223
Chris Lattner2188e402010-01-04 07:37:31 +0000224 enum { Overdefined = -3, Undefined = -2 };
225
226 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000227
Chris Lattner2188e402010-01-04 07:37:31 +0000228 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
229 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
230 // and 87 is the second (and last) index. FirstTrueElement is -2 when
231 // undefined, otherwise set to the first true element. SecondTrueElement is
232 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
233 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
234
235 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
236 // form "i != 47 & i != 87". Same state transitions as for true elements.
237 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000238
Chris Lattner2188e402010-01-04 07:37:31 +0000239 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
240 /// define a state machine that triggers for ranges of values that the index
241 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
242 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
243 /// index in the range (inclusive). We use -2 for undefined here because we
244 /// use relative comparisons and don't want 0-1 to match -1.
245 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000246
Chris Lattner2188e402010-01-04 07:37:31 +0000247 // MagicBitvector - This is a magic bitvector where we set a bit if the
248 // comparison is true for element 'i'. If there are 64 elements or less in
249 // the array, this will fully represent all the comparison results.
250 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000251
Chris Lattner2188e402010-01-04 07:37:31 +0000252 // Scan the array and see if one of our patterns matches.
253 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000254 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
255 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000256 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000257
Chris Lattner2188e402010-01-04 07:37:31 +0000258 // If this is indexing an array of structures, get the structure element.
259 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000260 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000261
Chris Lattner2188e402010-01-04 07:37:31 +0000262 // If the element is masked, handle it.
263 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000264
Chris Lattner2188e402010-01-04 07:37:31 +0000265 // Find out if the comparison would be true or false for the i'th element.
266 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000267 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000268 // If the result is undef for this element, ignore it.
269 if (isa<UndefValue>(C)) {
270 // Extend range state machines to cover this element in case there is an
271 // undef in the middle of the range.
272 if (TrueRangeEnd == (int)i-1)
273 TrueRangeEnd = i;
274 if (FalseRangeEnd == (int)i-1)
275 FalseRangeEnd = i;
276 continue;
277 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000278
Chris Lattner2188e402010-01-04 07:37:31 +0000279 // If we can't compute the result for any of the elements, we have to give
280 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000281 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000282
Chris Lattner2188e402010-01-04 07:37:31 +0000283 // Otherwise, we know if the comparison is true or false for this element,
284 // update our state machines.
285 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000286
Chris Lattner2188e402010-01-04 07:37:31 +0000287 // State machine for single/double/range index comparison.
288 if (IsTrueForElt) {
289 // Update the TrueElement state machine.
290 if (FirstTrueElement == Undefined)
291 FirstTrueElement = TrueRangeEnd = i; // First true element.
292 else {
293 // Update double-compare state machine.
294 if (SecondTrueElement == Undefined)
295 SecondTrueElement = i;
296 else
297 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000298
Chris Lattner2188e402010-01-04 07:37:31 +0000299 // Update range state machine.
300 if (TrueRangeEnd == (int)i-1)
301 TrueRangeEnd = i;
302 else
303 TrueRangeEnd = Overdefined;
304 }
305 } else {
306 // Update the FalseElement state machine.
307 if (FirstFalseElement == Undefined)
308 FirstFalseElement = FalseRangeEnd = i; // First false element.
309 else {
310 // Update double-compare state machine.
311 if (SecondFalseElement == Undefined)
312 SecondFalseElement = i;
313 else
314 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000315
Chris Lattner2188e402010-01-04 07:37:31 +0000316 // Update range state machine.
317 if (FalseRangeEnd == (int)i-1)
318 FalseRangeEnd = i;
319 else
320 FalseRangeEnd = Overdefined;
321 }
322 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000323
Chris Lattner2188e402010-01-04 07:37:31 +0000324 // If this element is in range, update our magic bitvector.
325 if (i < 64 && IsTrueForElt)
326 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000327
Chris Lattner2188e402010-01-04 07:37:31 +0000328 // If all of our states become overdefined, bail out early. Since the
329 // predicate is expensive, only check it every 8 elements. This is only
330 // really useful for really huge arrays.
331 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
332 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
333 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000334 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000335 }
336
337 // Now that we've scanned the entire array, emit our new comparison(s). We
338 // order the state machines in complexity of the generated code.
339 Value *Idx = GEP->getOperand(2);
340
Matt Arsenault5aeae182013-08-19 21:40:31 +0000341 // If the index is larger than the pointer size of the target, truncate the
342 // index down like the GEP would do implicitly. We don't have to do this for
343 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000344 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000345 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000346 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
347 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000348 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000349 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000350
Chris Lattner2188e402010-01-04 07:37:31 +0000351 // If the comparison is only true for one or two elements, emit direct
352 // comparisons.
353 if (SecondTrueElement != Overdefined) {
354 // None true -> false.
355 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000356 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000357
Chris Lattner2188e402010-01-04 07:37:31 +0000358 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000359
Chris Lattner2188e402010-01-04 07:37:31 +0000360 // True for one element -> 'i == 47'.
361 if (SecondTrueElement == Undefined)
362 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000363
Chris Lattner2188e402010-01-04 07:37:31 +0000364 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000365 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000366 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000367 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000368 return BinaryOperator::CreateOr(C1, C2);
369 }
370
371 // If the comparison is only false for one or two elements, emit direct
372 // comparisons.
373 if (SecondFalseElement != Overdefined) {
374 // None false -> true.
375 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000376 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000377
Chris Lattner2188e402010-01-04 07:37:31 +0000378 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
379
380 // False for one element -> 'i != 47'.
381 if (SecondFalseElement == Undefined)
382 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000383
Chris Lattner2188e402010-01-04 07:37:31 +0000384 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000385 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000386 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000387 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000388 return BinaryOperator::CreateAnd(C1, C2);
389 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000390
Chris Lattner2188e402010-01-04 07:37:31 +0000391 // If the comparison can be replaced with a range comparison for the elements
392 // where it is true, emit the range check.
393 if (TrueRangeEnd != Overdefined) {
394 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000395
Chris Lattner2188e402010-01-04 07:37:31 +0000396 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
397 if (FirstTrueElement) {
398 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000399 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000400 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000401
Chris Lattner2188e402010-01-04 07:37:31 +0000402 Value *End = ConstantInt::get(Idx->getType(),
403 TrueRangeEnd-FirstTrueElement+1);
404 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
405 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000406
Chris Lattner2188e402010-01-04 07:37:31 +0000407 // False range check.
408 if (FalseRangeEnd != Overdefined) {
409 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
410 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
411 if (FirstFalseElement) {
412 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000413 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000414 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000415
Chris Lattner2188e402010-01-04 07:37:31 +0000416 Value *End = ConstantInt::get(Idx->getType(),
417 FalseRangeEnd-FirstFalseElement);
418 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
419 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000420
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000421 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000422 // of this load, replace it with computation that does:
423 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000424 {
Craig Topperf40110f2014-04-25 05:29:35 +0000425 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000426
427 // Look for an appropriate type:
428 // - The type of Idx if the magic fits
429 // - The smallest fitting legal type if we have a DataLayout
430 // - Default to i32
431 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
432 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000433 else
434 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000435
Craig Topperf40110f2014-04-25 05:29:35 +0000436 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000437 Value *V = Builder.CreateIntCast(Idx, Ty, false);
438 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
439 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000440 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
441 }
Chris Lattner2188e402010-01-04 07:37:31 +0000442 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000443
Craig Topperf40110f2014-04-25 05:29:35 +0000444 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000445}
446
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000447/// Return a value that can be used to compare the *offset* implied by a GEP to
448/// zero. For example, if we have &A[i], we want to return 'i' for
449/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
450/// are involved. The above expression would also be legal to codegen as
451/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
452/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000453/// to generate the first by knowing that pointer arithmetic doesn't overflow.
454///
455/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000456///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000457static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000458 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000459 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000460
Chris Lattner2188e402010-01-04 07:37:31 +0000461 // Check to see if this gep only has a single variable index. If so, and if
462 // any constant indices are a multiple of its scale, then we can compute this
463 // in terms of the scale of the variable index. For example, if the GEP
464 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
465 // because the expression will cross zero at the same point.
466 unsigned i, e = GEP->getNumOperands();
467 int64_t Offset = 0;
468 for (i = 1; i != e; ++i, ++GTI) {
469 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
470 // Compute the aggregate offset of constant indices.
471 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000472
Chris Lattner2188e402010-01-04 07:37:31 +0000473 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000474 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000475 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000476 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000477 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000478 Offset += Size*CI->getSExtValue();
479 }
480 } else {
481 // Found our variable index.
482 break;
483 }
484 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000485
Chris Lattner2188e402010-01-04 07:37:31 +0000486 // If there are no variable indices, we must have a constant offset, just
487 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000488 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000489
Chris Lattner2188e402010-01-04 07:37:31 +0000490 Value *VariableIdx = GEP->getOperand(i);
491 // Determine the scale factor of the variable element. For example, this is
492 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000493 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000494
Chris Lattner2188e402010-01-04 07:37:31 +0000495 // Verify that there are no other variable indices. If so, emit the hard way.
496 for (++i, ++GTI; i != e; ++i, ++GTI) {
497 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000498 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000499
Chris Lattner2188e402010-01-04 07:37:31 +0000500 // Compute the aggregate offset of constant indices.
501 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000502
Chris Lattner2188e402010-01-04 07:37:31 +0000503 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000504 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000505 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000506 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000507 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000508 Offset += Size*CI->getSExtValue();
509 }
510 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000511
Chris Lattner2188e402010-01-04 07:37:31 +0000512 // Okay, we know we have a single variable index, which must be a
513 // pointer/array/vector index. If there is no offset, life is simple, return
514 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000515 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000516 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000517 if (Offset == 0) {
518 // Cast to intptrty in case a truncation occurs. If an extension is needed,
519 // we don't need to bother extending: the extension won't affect where the
520 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000521 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000522 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000523 }
Chris Lattner2188e402010-01-04 07:37:31 +0000524 return VariableIdx;
525 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000526
Chris Lattner2188e402010-01-04 07:37:31 +0000527 // Otherwise, there is an index. The computation we will do will be modulo
528 // the pointer size, so get it.
529 uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000530
Chris Lattner2188e402010-01-04 07:37:31 +0000531 Offset &= PtrSizeMask;
532 VariableScale &= PtrSizeMask;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000533
Chris Lattner2188e402010-01-04 07:37:31 +0000534 // To do this transformation, any constant index must be a multiple of the
535 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
536 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
537 // multiple of the variable scale.
538 int64_t NewOffs = Offset / (int64_t)VariableScale;
539 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000540 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000541
Chris Lattner2188e402010-01-04 07:37:31 +0000542 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000543 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000544 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000545 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000546 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000547 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000548}
549
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000550/// Returns true if we can rewrite Start as a GEP with pointer Base
551/// and some integer offset. The nodes that need to be re-written
552/// for this transformation will be added to Explored.
553static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
554 const DataLayout &DL,
555 SetVector<Value *> &Explored) {
556 SmallVector<Value *, 16> WorkList(1, Start);
557 Explored.insert(Base);
558
559 // The following traversal gives us an order which can be used
560 // when doing the final transformation. Since in the final
561 // transformation we create the PHI replacement instructions first,
562 // we don't have to get them in any particular order.
563 //
564 // However, for other instructions we will have to traverse the
565 // operands of an instruction first, which means that we have to
566 // do a post-order traversal.
567 while (!WorkList.empty()) {
568 SetVector<PHINode *> PHIs;
569
570 while (!WorkList.empty()) {
571 if (Explored.size() >= 100)
572 return false;
573
574 Value *V = WorkList.back();
575
576 if (Explored.count(V) != 0) {
577 WorkList.pop_back();
578 continue;
579 }
580
581 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000582 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000583 // We've found some value that we can't explore which is different from
584 // the base. Therefore we can't do this transformation.
585 return false;
586
587 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
588 auto *CI = dyn_cast<CastInst>(V);
589 if (!CI->isNoopCast(DL))
590 return false;
591
592 if (Explored.count(CI->getOperand(0)) == 0)
593 WorkList.push_back(CI->getOperand(0));
594 }
595
596 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
597 // We're limiting the GEP to having one index. This will preserve
598 // the original pointer type. We could handle more cases in the
599 // future.
600 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
601 GEP->getType() != Start->getType())
602 return false;
603
604 if (Explored.count(GEP->getOperand(0)) == 0)
605 WorkList.push_back(GEP->getOperand(0));
606 }
607
608 if (WorkList.back() == V) {
609 WorkList.pop_back();
610 // We've finished visiting this node, mark it as such.
611 Explored.insert(V);
612 }
613
614 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000615 // We cannot transform PHIs on unsplittable basic blocks.
616 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
617 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000618 Explored.insert(PN);
619 PHIs.insert(PN);
620 }
621 }
622
623 // Explore the PHI nodes further.
624 for (auto *PN : PHIs)
625 for (Value *Op : PN->incoming_values())
626 if (Explored.count(Op) == 0)
627 WorkList.push_back(Op);
628 }
629
630 // Make sure that we can do this. Since we can't insert GEPs in a basic
631 // block before a PHI node, we can't easily do this transformation if
632 // we have PHI node users of transformed instructions.
633 for (Value *Val : Explored) {
634 for (Value *Use : Val->uses()) {
635
636 auto *PHI = dyn_cast<PHINode>(Use);
637 auto *Inst = dyn_cast<Instruction>(Val);
638
639 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
640 Explored.count(PHI) == 0)
641 continue;
642
643 if (PHI->getParent() == Inst->getParent())
644 return false;
645 }
646 }
647 return true;
648}
649
650// Sets the appropriate insert point on Builder where we can add
651// a replacement Instruction for V (if that is possible).
652static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
653 bool Before = true) {
654 if (auto *PHI = dyn_cast<PHINode>(V)) {
655 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
656 return;
657 }
658 if (auto *I = dyn_cast<Instruction>(V)) {
659 if (!Before)
660 I = &*std::next(I->getIterator());
661 Builder.SetInsertPoint(I);
662 return;
663 }
664 if (auto *A = dyn_cast<Argument>(V)) {
665 // Set the insertion point in the entry block.
666 BasicBlock &Entry = A->getParent()->getEntryBlock();
667 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
668 return;
669 }
670 // Otherwise, this is a constant and we don't need to set a new
671 // insertion point.
672 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
673}
674
675/// Returns a re-written value of Start as an indexed GEP using Base as a
676/// pointer.
677static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
678 const DataLayout &DL,
679 SetVector<Value *> &Explored) {
680 // Perform all the substitutions. This is a bit tricky because we can
681 // have cycles in our use-def chains.
682 // 1. Create the PHI nodes without any incoming values.
683 // 2. Create all the other values.
684 // 3. Add the edges for the PHI nodes.
685 // 4. Emit GEPs to get the original pointers.
686 // 5. Remove the original instructions.
687 Type *IndexType = IntegerType::get(
688 Base->getContext(), DL.getPointerTypeSizeInBits(Start->getType()));
689
690 DenseMap<Value *, Value *> NewInsts;
691 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
692
693 // Create the new PHI nodes, without adding any incoming values.
694 for (Value *Val : Explored) {
695 if (Val == Base)
696 continue;
697 // Create empty phi nodes. This avoids cyclic dependencies when creating
698 // the remaining instructions.
699 if (auto *PHI = dyn_cast<PHINode>(Val))
700 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
701 PHI->getName() + ".idx", PHI);
702 }
703 IRBuilder<> Builder(Base->getContext());
704
705 // Create all the other instructions.
706 for (Value *Val : Explored) {
707
708 if (NewInsts.find(Val) != NewInsts.end())
709 continue;
710
711 if (auto *CI = dyn_cast<CastInst>(Val)) {
712 NewInsts[CI] = NewInsts[CI->getOperand(0)];
713 continue;
714 }
715 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
716 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
717 : GEP->getOperand(1);
718 setInsertionPoint(Builder, GEP);
719 // Indices might need to be sign extended. GEPs will magically do
720 // this, but we need to do it ourselves here.
721 if (Index->getType()->getScalarSizeInBits() !=
722 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
723 Index = Builder.CreateSExtOrTrunc(
724 Index, NewInsts[GEP->getOperand(0)]->getType(),
725 GEP->getOperand(0)->getName() + ".sext");
726 }
727
728 auto *Op = NewInsts[GEP->getOperand(0)];
729 if (isa<ConstantInt>(Op) && dyn_cast<ConstantInt>(Op)->isZero())
730 NewInsts[GEP] = Index;
731 else
732 NewInsts[GEP] = Builder.CreateNSWAdd(
733 Op, Index, GEP->getOperand(0)->getName() + ".add");
734 continue;
735 }
736 if (isa<PHINode>(Val))
737 continue;
738
739 llvm_unreachable("Unexpected instruction type");
740 }
741
742 // Add the incoming values to the PHI nodes.
743 for (Value *Val : Explored) {
744 if (Val == Base)
745 continue;
746 // All the instructions have been created, we can now add edges to the
747 // phi nodes.
748 if (auto *PHI = dyn_cast<PHINode>(Val)) {
749 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
750 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
751 Value *NewIncoming = PHI->getIncomingValue(I);
752
753 if (NewInsts.find(NewIncoming) != NewInsts.end())
754 NewIncoming = NewInsts[NewIncoming];
755
756 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
757 }
758 }
759 }
760
761 for (Value *Val : Explored) {
762 if (Val == Base)
763 continue;
764
765 // Depending on the type, for external users we have to emit
766 // a GEP or a GEP + ptrtoint.
767 setInsertionPoint(Builder, Val, false);
768
769 // If required, create an inttoptr instruction for Base.
770 Value *NewBase = Base;
771 if (!Base->getType()->isPointerTy())
772 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
773 Start->getName() + "to.ptr");
774
775 Value *GEP = Builder.CreateInBoundsGEP(
776 Start->getType()->getPointerElementType(), NewBase,
777 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
778
779 if (!Val->getType()->isPointerTy()) {
780 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
781 Val->getName() + ".conv");
782 GEP = Cast;
783 }
784 Val->replaceAllUsesWith(GEP);
785 }
786
787 return NewInsts[Start];
788}
789
790/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
791/// the input Value as a constant indexed GEP. Returns a pair containing
792/// the GEPs Pointer and Index.
793static std::pair<Value *, Value *>
794getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
795 Type *IndexType = IntegerType::get(V->getContext(),
796 DL.getPointerTypeSizeInBits(V->getType()));
797
798 Constant *Index = ConstantInt::getNullValue(IndexType);
799 while (true) {
800 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
801 // We accept only inbouds GEPs here to exclude the possibility of
802 // overflow.
803 if (!GEP->isInBounds())
804 break;
805 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
806 GEP->getType() == V->getType()) {
807 V = GEP->getOperand(0);
808 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
809 Index = ConstantExpr::getAdd(
810 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
811 continue;
812 }
813 break;
814 }
815 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
816 if (!CI->isNoopCast(DL))
817 break;
818 V = CI->getOperand(0);
819 continue;
820 }
821 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
822 if (!CI->isNoopCast(DL))
823 break;
824 V = CI->getOperand(0);
825 continue;
826 }
827 break;
828 }
829 return {V, Index};
830}
831
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000832/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
833/// We can look through PHIs, GEPs and casts in order to determine a common base
834/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000835static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
836 ICmpInst::Predicate Cond,
837 const DataLayout &DL) {
838 if (!GEPLHS->hasAllConstantIndices())
839 return nullptr;
840
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000841 // Make sure the pointers have the same type.
842 if (GEPLHS->getType() != RHS->getType())
843 return nullptr;
844
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000845 Value *PtrBase, *Index;
846 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
847
848 // The set of nodes that will take part in this transformation.
849 SetVector<Value *> Nodes;
850
851 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
852 return nullptr;
853
854 // We know we can re-write this as
855 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
856 // Since we've only looked through inbouds GEPs we know that we
857 // can't have overflow on either side. We can therefore re-write
858 // this as:
859 // OFFSET1 cmp OFFSET2
860 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
861
862 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
863 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
864 // offset. Since Index is the offset of LHS to the base pointer, we will now
865 // compare the offsets instead of comparing the pointers.
866 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
867}
868
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000869/// Fold comparisons between a GEP instruction and something else. At this point
870/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000871Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000872 ICmpInst::Predicate Cond,
873 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000874 // Don't transform signed compares of GEPs into index compares. Even if the
875 // GEP is inbounds, the final add of the base pointer can have signed overflow
876 // and would change the result of the icmp.
877 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000878 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000879 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000880 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000881
Matt Arsenault44f60d02014-06-09 19:20:29 +0000882 // Look through bitcasts and addrspacecasts. We do not however want to remove
883 // 0 GEPs.
884 if (!isa<GetElementPtrInst>(RHS))
885 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000886
887 Value *PtrBase = GEPLHS->getOperand(0);
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000888 if (PtrBase == RHS && GEPLHS->isInBounds()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000889 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
890 // This transformation (ignoring the base and scales) is valid because we
891 // know pointers can't overflow since the gep is inbounds. See if we can
892 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000893 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000894
Chris Lattner2188e402010-01-04 07:37:31 +0000895 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000896 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000897 Offset = EmitGEPOffset(GEPLHS);
898 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
899 Constant::getNullValue(Offset->getType()));
900 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
901 // If the base pointers are different, but the indices are the same, just
902 // compare the base pointer.
903 if (PtrBase != GEPRHS->getOperand(0)) {
904 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
905 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
906 GEPRHS->getOperand(0)->getType();
907 if (IndicesTheSame)
908 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
909 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
910 IndicesTheSame = false;
911 break;
912 }
913
914 // If all indices are the same, just compare the base pointers.
915 if (IndicesTheSame)
David Majnemer5953d372013-06-29 10:28:04 +0000916 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000917
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000918 // If we're comparing GEPs with two base pointers that only differ in type
919 // and both GEPs have only constant indices or just one use, then fold
920 // the compare with the adjusted indices.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000921 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000922 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
923 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
924 PtrBase->stripPointerCasts() ==
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000925 GEPRHS->getOperand(0)->stripPointerCasts()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000926 Value *LOffset = EmitGEPOffset(GEPLHS);
927 Value *ROffset = EmitGEPOffset(GEPRHS);
928
929 // If we looked through an addrspacecast between different sized address
930 // spaces, the LHS and RHS pointers are different sized
931 // integers. Truncate to the smaller one.
932 Type *LHSIndexTy = LOffset->getType();
933 Type *RHSIndexTy = ROffset->getType();
934 if (LHSIndexTy != RHSIndexTy) {
935 if (LHSIndexTy->getPrimitiveSizeInBits() <
936 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000937 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000938 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000939 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000940 }
941
Craig Topperbb4069e2017-07-07 23:16:26 +0000942 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
943 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000944 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000945 }
946
Chris Lattner2188e402010-01-04 07:37:31 +0000947 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000948 // different. Try convert this to an indexed compare by looking through
949 // PHIs/casts.
950 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000951 }
952
953 // If one of the GEPs has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000954 if (GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000955 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +0000956 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +0000957
958 // If the other GEP has all zero indices, recurse.
Benjamin Kramerd0993e02014-07-07 11:01:16 +0000959 if (GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000960 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +0000961
Stuart Hastings66a82b92011-05-14 05:55:10 +0000962 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +0000963 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
964 // If the GEPs only differ by one index, compare it.
965 unsigned NumDifferences = 0; // Keep track of # differences.
966 unsigned DiffOperand = 0; // The operand that differs.
967 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
968 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
969 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() !=
970 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) {
971 // Irreconcilable differences.
972 NumDifferences = 2;
973 break;
974 } else {
975 if (NumDifferences++) break;
976 DiffOperand = i;
977 }
978 }
979
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +0000980 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +0000981 return replaceInstUsesWith(I, // No comparison is needed here.
Craig Topperbb4069e2017-07-07 23:16:26 +0000982 Builder.getInt1(ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +0000983
Stuart Hastings66a82b92011-05-14 05:55:10 +0000984 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +0000985 Value *LHSV = GEPLHS->getOperand(DiffOperand);
986 Value *RHSV = GEPRHS->getOperand(DiffOperand);
987 // Make sure we do a signed comparison here.
988 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
989 }
990 }
991
992 // Only lower this if the icmp is the only user of the GEP or if we expect
993 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000994 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +0000995 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
996 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
997 Value *L = EmitGEPOffset(GEPLHS);
998 Value *R = EmitGEPOffset(GEPRHS);
999 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
1000 }
1001 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001002
1003 // Try convert this to an indexed compare by looking through PHIs/casts as a
1004 // last resort.
1005 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001006}
1007
Pete Cooper980a9352016-08-12 17:13:28 +00001008Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1009 const AllocaInst *Alloca,
1010 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001011 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1012
1013 // It would be tempting to fold away comparisons between allocas and any
1014 // pointer not based on that alloca (e.g. an argument). However, even
1015 // though such pointers cannot alias, they can still compare equal.
1016 //
1017 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1018 // doesn't escape we can argue that it's impossible to guess its value, and we
1019 // can therefore act as if any such guesses are wrong.
1020 //
1021 // The code below checks that the alloca doesn't escape, and that it's only
1022 // used in a comparison once (the current instruction). The
1023 // single-comparison-use condition ensures that we're trivially folding all
1024 // comparisons against the alloca consistently, and avoids the risk of
1025 // erroneously folding a comparison of the pointer with itself.
1026
1027 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1028
Pete Cooper980a9352016-08-12 17:13:28 +00001029 SmallVector<const Use *, 32> Worklist;
1030 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001031 if (Worklist.size() >= MaxIter)
1032 return nullptr;
1033 Worklist.push_back(&U);
1034 }
1035
1036 unsigned NumCmps = 0;
1037 while (!Worklist.empty()) {
1038 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001039 const Use *U = Worklist.pop_back_val();
1040 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001041 --MaxIter;
1042
1043 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1044 isa<SelectInst>(V)) {
1045 // Track the uses.
1046 } else if (isa<LoadInst>(V)) {
1047 // Loading from the pointer doesn't escape it.
1048 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001049 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001050 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1051 if (SI->getValueOperand() == U->get())
1052 return nullptr;
1053 continue;
1054 } else if (isa<ICmpInst>(V)) {
1055 if (NumCmps++)
1056 return nullptr; // Found more than one cmp.
1057 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001058 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001059 switch (Intrin->getIntrinsicID()) {
1060 // These intrinsics don't escape or compare the pointer. Memset is safe
1061 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1062 // we don't allow stores, so src cannot point to V.
1063 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001064 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1065 continue;
1066 default:
1067 return nullptr;
1068 }
1069 } else {
1070 return nullptr;
1071 }
Pete Cooper980a9352016-08-12 17:13:28 +00001072 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001073 if (Worklist.size() >= MaxIter)
1074 return nullptr;
1075 Worklist.push_back(&U);
1076 }
1077 }
1078
1079 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001080 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001081 ICI,
1082 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1083}
1084
Sanjay Patel5f0217f2016-06-05 16:46:18 +00001085/// Fold "icmp pred (X+CI), X".
Craig Toppera85f8622017-08-23 05:46:09 +00001086Instruction *InstCombiner::foldICmpAddOpConst(Value *X, ConstantInt *CI,
Sanjay Patel43395062016-07-21 18:07:40 +00001087 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001088 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001089 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001090 // operators.
Jim Grosbach129c52a2011-09-30 18:09:53 +00001091
Chris Lattner8c92b572010-01-08 17:48:19 +00001092 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001093 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1094 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1095 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00001096 Value *R =
Chris Lattner8c92b572010-01-08 17:48:19 +00001097 ConstantExpr::getSub(ConstantInt::getAllOnesValue(CI->getType()), CI);
Chris Lattner2188e402010-01-04 07:37:31 +00001098 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1099 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001100
Chris Lattner2188e402010-01-04 07:37:31 +00001101 // (X+1) >u X --> X <u (0-1) --> X != 255
1102 // (X+2) >u X --> X <u (0-2) --> X <u 254
1103 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001104 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Chris Lattner2188e402010-01-04 07:37:31 +00001105 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantExpr::getNeg(CI));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001106
Chris Lattner2188e402010-01-04 07:37:31 +00001107 unsigned BitWidth = CI->getType()->getPrimitiveSizeInBits();
1108 ConstantInt *SMax = ConstantInt::get(X->getContext(),
1109 APInt::getSignedMaxValue(BitWidth));
1110
1111 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1112 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1113 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1114 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1115 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1116 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001117 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Chris Lattner2188e402010-01-04 07:37:31 +00001118 return new ICmpInst(ICmpInst::ICMP_SGT, X, ConstantExpr::getSub(SMax, CI));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001119
Chris Lattner2188e402010-01-04 07:37:31 +00001120 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1121 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1122 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1123 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1124 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1125 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001126
Chris Lattner2188e402010-01-04 07:37:31 +00001127 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbb4069e2017-07-07 23:16:26 +00001128 Constant *C = Builder.getInt(CI->getValue() - 1);
Chris Lattner2188e402010-01-04 07:37:31 +00001129 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantExpr::getSub(SMax, C));
1130}
1131
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001132/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1133/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1134/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1135Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1136 const APInt &AP1,
1137 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001138 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1139
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001140 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1141 if (I.getPredicate() == I.ICMP_NE)
1142 Pred = CmpInst::getInversePredicate(Pred);
1143 return new ICmpInst(Pred, LHS, RHS);
1144 };
1145
David Majnemer2abb8182014-10-25 07:13:13 +00001146 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001147 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001148 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001149
1150 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001151 if (IsAShr) {
1152 if (AP2.isAllOnesValue())
1153 return nullptr;
1154 if (AP2.isNegative() != AP1.isNegative())
1155 return nullptr;
1156 if (AP2.sgt(AP1))
1157 return nullptr;
1158 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001159
David Majnemerd2056022014-10-21 19:51:55 +00001160 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001161 // 'A' must be large enough to shift out the highest set bit.
1162 return getICmp(I.ICMP_UGT, A,
1163 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001164
David Majnemerd2056022014-10-21 19:51:55 +00001165 if (AP1 == AP2)
1166 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001167
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001168 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001169 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001170 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001171 else
David Majnemere5977eb2015-09-19 00:48:26 +00001172 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001173
David Majnemerd2056022014-10-21 19:51:55 +00001174 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001175 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1176 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001177 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001178 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1179 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001180 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001181 } else if (AP1 == AP2.lshr(Shift)) {
1182 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1183 }
David Majnemerd2056022014-10-21 19:51:55 +00001184 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001185
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001186 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001187 // FIXME: This should always be handled by InstSimplify?
1188 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1189 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001190}
Chris Lattner2188e402010-01-04 07:37:31 +00001191
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001192/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1193/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1194Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1195 const APInt &AP1,
1196 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001197 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1198
David Majnemer59939ac2014-10-19 08:23:08 +00001199 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1200 if (I.getPredicate() == I.ICMP_NE)
1201 Pred = CmpInst::getInversePredicate(Pred);
1202 return new ICmpInst(Pred, LHS, RHS);
1203 };
1204
David Majnemer2abb8182014-10-25 07:13:13 +00001205 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001206 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001207 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001208
1209 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1210
1211 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001212 return getICmp(
1213 I.ICMP_UGE, A,
1214 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001215
1216 if (AP1 == AP2)
1217 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1218
1219 // Get the distance between the lowest bits that are set.
1220 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1221
1222 if (Shift > 0 && AP2.shl(Shift) == AP1)
1223 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1224
1225 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001226 // FIXME: This should always be handled by InstSimplify?
1227 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1228 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001229}
1230
Sanjay Patel06b127a2016-09-15 14:37:50 +00001231/// The caller has matched a pattern of the form:
1232/// I = icmp ugt (add (add A, B), CI2), CI1
1233/// If this is of the form:
1234/// sum = a + b
1235/// if (sum+128 >u 255)
1236/// Then replace it with llvm.sadd.with.overflow.i8.
1237///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001238static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001239 ConstantInt *CI2, ConstantInt *CI1,
1240 InstCombiner &IC) {
1241 // The transformation we're trying to do here is to transform this into an
1242 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1243 // with a narrower add, and discard the add-with-constant that is part of the
1244 // range check (if we can't eliminate it, this isn't profitable).
1245
1246 // In order to eliminate the add-with-constant, the compare can be its only
1247 // use.
1248 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1249 if (!AddWithCst->hasOneUse())
1250 return nullptr;
1251
1252 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1253 if (!CI2->getValue().isPowerOf2())
1254 return nullptr;
1255 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1256 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1257 return nullptr;
1258
1259 // The width of the new add formed is 1 more than the bias.
1260 ++NewWidth;
1261
1262 // Check to see that CI1 is an all-ones value with NewWidth bits.
1263 if (CI1->getBitWidth() == NewWidth ||
1264 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1265 return nullptr;
1266
1267 // This is only really a signed overflow check if the inputs have been
1268 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1269 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1270 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1271 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1272 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1273 return nullptr;
1274
1275 // In order to replace the original add with a narrower
1276 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1277 // and truncates that discard the high bits of the add. Verify that this is
1278 // the case.
1279 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1280 for (User *U : OrigAdd->users()) {
1281 if (U == AddWithCst)
1282 continue;
1283
1284 // Only accept truncates for now. We would really like a nice recursive
1285 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1286 // chain to see which bits of a value are actually demanded. If the
1287 // original add had another add which was then immediately truncated, we
1288 // could still do the transformation.
1289 TruncInst *TI = dyn_cast<TruncInst>(U);
1290 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1291 return nullptr;
1292 }
1293
1294 // If the pattern matches, truncate the inputs to the narrower type and
1295 // use the sadd_with_overflow intrinsic to efficiently compute both the
1296 // result and the overflow bit.
1297 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
1298 Value *F = Intrinsic::getDeclaration(I.getModule(),
1299 Intrinsic::sadd_with_overflow, NewType);
1300
Craig Topperbb4069e2017-07-07 23:16:26 +00001301 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001302
1303 // Put the new code above the original add, in case there are any uses of the
1304 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001305 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001306
Craig Topperbb4069e2017-07-07 23:16:26 +00001307 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1308 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1309 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1310 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1311 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001312
1313 // The inner add was the result of the narrow add, zero extended to the
1314 // wider type. Replace it with the result computed by the intrinsic.
1315 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1316
1317 // The original icmp gets replaced with the overflow value.
1318 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1319}
1320
1321// Fold icmp Pred X, C.
Sanjay Patel97459832016-09-15 15:11:12 +00001322Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
1323 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001324 Value *X = Cmp.getOperand(0);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001325
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001326 const APInt *C;
1327 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel97459832016-09-15 15:11:12 +00001328 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001329
Sanjay Patel97459832016-09-15 15:11:12 +00001330 Value *A = nullptr, *B = nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001331
Sanjay Patel97459832016-09-15 15:11:12 +00001332 // Match the following pattern, which is a common idiom when writing
1333 // overflow-safe integer arithmetic functions. The source performs an addition
1334 // in wider type and explicitly checks for overflow using comparisons against
1335 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1336 //
1337 // TODO: This could probably be generalized to handle other overflow-safe
1338 // operations if we worked out the formulas to compute the appropriate magic
1339 // constants.
1340 //
1341 // sum = a + b
1342 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
1343 {
1344 ConstantInt *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1345 if (Pred == ICmpInst::ICMP_UGT &&
1346 match(X, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001347 if (Instruction *Res = processUGT_ADDCST_ADD(
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001348 Cmp, A, B, CI2, cast<ConstantInt>(Cmp.getOperand(1)), *this))
Sanjay Patel97459832016-09-15 15:11:12 +00001349 return Res;
1350 }
Sanjay Patel06b127a2016-09-15 14:37:50 +00001351
Sanjay Patel97459832016-09-15 15:11:12 +00001352 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
Craig Topper73ba1c82017-06-07 07:40:37 +00001353 if (C->isNullValue() && Pred == ICmpInst::ICMP_SGT) {
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001354 SelectPatternResult SPR = matchSelectPattern(X, A, B);
1355 if (SPR.Flavor == SPF_SMIN) {
Craig Topperd45185f2017-05-26 18:23:57 +00001356 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001357 return new ICmpInst(Pred, B, Cmp.getOperand(1));
Craig Topperd45185f2017-05-26 18:23:57 +00001358 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001359 return new ICmpInst(Pred, A, Cmp.getOperand(1));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001360 }
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001361 }
1362
1363 // FIXME: Use m_APInt to allow folds for splat constants.
1364 ConstantInt *CI = dyn_cast<ConstantInt>(Cmp.getOperand(1));
1365 if (!CI)
1366 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001367
Sanjay Patel97459832016-09-15 15:11:12 +00001368 // Canonicalize icmp instructions based on dominating conditions.
1369 BasicBlock *Parent = Cmp.getParent();
1370 BasicBlock *Dom = Parent->getSinglePredecessor();
1371 auto *BI = Dom ? dyn_cast<BranchInst>(Dom->getTerminator()) : nullptr;
1372 ICmpInst::Predicate Pred2;
1373 BasicBlock *TrueBB, *FalseBB;
1374 ConstantInt *CI2;
1375 if (BI && match(BI, m_Br(m_ICmp(Pred2, m_Specific(X), m_ConstantInt(CI2)),
1376 TrueBB, FalseBB)) &&
1377 TrueBB != FalseBB) {
1378 ConstantRange CR =
1379 ConstantRange::makeAllowedICmpRegion(Pred, CI->getValue());
1380 ConstantRange DominatingCR =
1381 (Parent == TrueBB)
1382 ? ConstantRange::makeExactICmpRegion(Pred2, CI2->getValue())
1383 : ConstantRange::makeExactICmpRegion(
1384 CmpInst::getInversePredicate(Pred2), CI2->getValue());
1385 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1386 ConstantRange Difference = DominatingCR.difference(CR);
1387 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001388 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001389 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001390 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001391
Sanjay Patel97459832016-09-15 15:11:12 +00001392 // If this is a normal comparison, it demands all bits. If it is a sign
1393 // bit comparison, it only demands the sign bit.
1394 bool UnusedBit;
1395 bool IsSignBit = isSignBitCheck(Pred, CI->getValue(), UnusedBit);
1396
1397 // Canonicalizing a sign bit comparison that gets used in a branch,
1398 // pessimizes codegen by generating branch on zero instruction instead
1399 // of a test and branch. So we avoid canonicalizing in such situations
1400 // because test and branch instruction has better branch displacement
1401 // than compare and branch instruction.
Eric Christophera95aac32017-06-30 01:57:48 +00001402 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1403 return nullptr;
1404
1405 if (auto *AI = Intersection.getSingleElement())
Craig Topperbb4069e2017-07-07 23:16:26 +00001406 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*AI));
Eric Christophera95aac32017-06-30 01:57:48 +00001407 if (auto *AD = Difference.getSingleElement())
Craig Topperbb4069e2017-07-07 23:16:26 +00001408 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*AD));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001409 }
1410
1411 return nullptr;
1412}
1413
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001414/// Fold icmp (trunc X, Y), C.
1415Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001416 TruncInst *Trunc,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001417 const APInt &C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001418 ICmpInst::Predicate Pred = Cmp.getPredicate();
1419 Value *X = Trunc->getOperand(0);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001420 if (C.isOneValue() && C.getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001421 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1422 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001423 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001424 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1425 ConstantInt::get(V->getType(), 1));
1426 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001427
1428 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001429 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1430 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001431 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1432 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001433 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001434
1435 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001436 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001437 // Pull in the high bits from known-ones set.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001438 APInt NewRHS = C.zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001439 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001440 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001441 }
1442 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001443
Sanjay Patela3f4f082016-08-16 17:54:36 +00001444 return nullptr;
1445}
1446
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001447/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001448Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1449 BinaryOperator *Xor,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001450 const APInt &C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001451 Value *X = Xor->getOperand(0);
1452 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001453 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001454 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001455 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001456
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001457 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1458 // fold the xor.
1459 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topperdf63b962017-10-03 19:14:23 +00001460 bool TrueIfSigned = false;
1461 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001462
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001463 // If the sign bit of the XorCst is not set, there is no change to
1464 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001465 if (!XorC->isNegative()) {
1466 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001467 Worklist.Add(Xor);
1468 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001469 }
1470
Craig Topperdf63b962017-10-03 19:14:23 +00001471 // Emit the opposite comparison.
1472 if (TrueIfSigned)
1473 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1474 ConstantInt::getAllOnesValue(X->getType()));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001475 else
Craig Topperdf63b962017-10-03 19:14:23 +00001476 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1477 ConstantInt::getNullValue(X->getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001478 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001479
1480 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001481 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1482 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001483 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1484 : Cmp.getSignedPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001485 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001486 }
1487
Craig Topperbcfd2d12017-04-20 16:56:25 +00001488 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001489 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1490 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1491 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001492 Pred = Cmp.getSwappedPredicate(Pred);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001493 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001494 }
1495 }
1496
1497 // (icmp ugt (xor X, C), ~C) -> (icmp ult X, C)
1498 // iff -C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001499 if (Pred == ICmpInst::ICMP_UGT && *XorC == ~C && (C + 1).isPowerOf2())
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001500 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001501
1502 // (icmp ult (xor X, C), -C) -> (icmp uge X, C)
1503 // iff -C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001504 if (Pred == ICmpInst::ICMP_ULT && *XorC == -C && C.isPowerOf2())
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001505 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001506
Sanjay Patela3f4f082016-08-16 17:54:36 +00001507 return nullptr;
1508}
1509
Sanjay Patel14e0e182016-08-26 18:28:46 +00001510/// Fold icmp (and (sh X, Y), C2), C1.
1511Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001512 const APInt &C1, const APInt &C2) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001513 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1514 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001515 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001516
Sanjay Patelda9c5622016-08-26 17:15:22 +00001517 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1518 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1519 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001520 // This seemingly simple opportunity to fold away a shift turns out to be
1521 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001522 unsigned ShiftOpcode = Shift->getOpcode();
1523 bool IsShl = ShiftOpcode == Instruction::Shl;
1524 const APInt *C3;
1525 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001526 bool CanFold = false;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001527 if (ShiftOpcode == Instruction::AShr) {
1528 // There may be some constraints that make this possible, but nothing
1529 // simple has been discovered yet.
1530 CanFold = false;
1531 } else if (ShiftOpcode == Instruction::Shl) {
1532 // For a left shift, we can fold if the comparison is not signed. We can
1533 // also fold a signed comparison if the mask value and comparison value
1534 // are not negative. These constraints may not be obvious, but we can
1535 // prove that they are correct using an SMT solver.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001536 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001537 CanFold = true;
1538 } else if (ShiftOpcode == Instruction::LShr) {
1539 // For a logical right shift, we can fold if the comparison is not signed.
1540 // We can also fold a signed comparison if the shifted mask value and the
1541 // shifted comparison value are not negative. These constraints may not be
1542 // obvious, but we can prove that they are correct using an SMT solver.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001543 if (!Cmp.isSigned() ||
Craig Topper8ed1aa92017-10-03 05:31:07 +00001544 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001545 CanFold = true;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001546 }
1547
Sanjay Patelda9c5622016-08-26 17:15:22 +00001548 if (CanFold) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001549 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001550 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001551 // Check to see if we are shifting out any of the bits being compared.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001552 if (SameAsC1 != C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001553 // If we shifted bits out, the fold is not going to work out. As a
1554 // special case, check to see if this means that the result is always
1555 // true or false now.
1556 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001557 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001558 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001559 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001560 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001561 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
Craig Topper8ed1aa92017-10-03 05:31:07 +00001562 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001563 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001564 And->setOperand(0, Shift->getOperand(0));
1565 Worklist.Add(Shift); // Shift is dead.
1566 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001567 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001568 }
1569 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001570
Sanjay Patelda9c5622016-08-26 17:15:22 +00001571 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1572 // preferable because it allows the C2 << Y expression to be hoisted out of a
1573 // loop if Y is invariant and X is not.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001574 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001575 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1576 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001577 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001578 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1579 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001580
Sanjay Patelda9c5622016-08-26 17:15:22 +00001581 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001582 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001583 Cmp.setOperand(0, NewAnd);
1584 return &Cmp;
1585 }
1586
Sanjay Patel14e0e182016-08-26 18:28:46 +00001587 return nullptr;
1588}
1589
1590/// Fold icmp (and X, C2), C1.
1591Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1592 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001593 const APInt &C1) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001594 const APInt *C2;
1595 if (!match(And->getOperand(1), m_APInt(C2)))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001596 return nullptr;
1597
Craig Topper8bf62212017-09-26 18:47:25 +00001598 if (!And->hasOneUse())
Sanjay Patel14e0e182016-08-26 18:28:46 +00001599 return nullptr;
1600
Sanjay Patel6b490972016-09-04 14:32:15 +00001601 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1602 // the input width without changing the value produced, eliminate the cast:
1603 //
1604 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1605 //
1606 // We can do this transformation if the constants do not have their sign bits
1607 // set or if it is an equality comparison. Extending a relational comparison
1608 // when we're checking the sign bit would not work.
1609 Value *W;
Craig Topper8bf62212017-09-26 18:47:25 +00001610 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001611 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001612 // TODO: Is this a good transform for vectors? Wider types may reduce
1613 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001614 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001615 if (!Cmp.getType()->isVectorTy()) {
1616 Type *WideType = W->getType();
1617 unsigned WideScalarBits = WideType->getScalarSizeInBits();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001618 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits));
Sanjay Patel6b490972016-09-04 14:32:15 +00001619 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001620 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001621 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001622 }
1623 }
1624
Craig Topper8ed1aa92017-10-03 05:31:07 +00001625 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001626 return I;
1627
Sanjay Patelda9c5622016-08-26 17:15:22 +00001628 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001629 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001630 //
1631 // iff pred isn't signed
Craig Topper8ed1aa92017-10-03 05:31:07 +00001632 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() &&
Craig Topper73ba1c82017-06-07 07:40:37 +00001633 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001634 Constant *One = cast<Constant>(And->getOperand(1));
1635 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001636 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001637 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1638 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1639 unsigned UsesRemoved = 0;
1640 if (And->hasOneUse())
1641 ++UsesRemoved;
1642 if (Or->hasOneUse())
1643 ++UsesRemoved;
1644 if (LShr->hasOneUse())
1645 ++UsesRemoved;
1646
1647 // Compute A & ((1 << B) | 1)
1648 Value *NewOr = nullptr;
1649 if (auto *C = dyn_cast<Constant>(B)) {
1650 if (UsesRemoved >= 1)
1651 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1652 } else {
1653 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001654 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1655 /*HasNUW=*/true),
1656 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001657 }
1658 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001659 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001660 Cmp.setOperand(0, NewAnd);
1661 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001662 }
1663 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001664 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001665
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001666 return nullptr;
1667}
1668
1669/// Fold icmp (and X, Y), C.
1670Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1671 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001672 const APInt &C) {
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001673 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1674 return I;
1675
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001676 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001677
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001678 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1679 Value *X = And->getOperand(0);
1680 Value *Y = And->getOperand(1);
1681 if (auto *LI = dyn_cast<LoadInst>(X))
1682 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1683 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001684 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001685 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1686 ConstantInt *C2 = cast<ConstantInt>(Y);
1687 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001688 return Res;
1689 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001690
1691 if (!Cmp.isEquality())
1692 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001693
1694 // X & -C == -C -> X > u ~C
1695 // X & -C != -C -> X <= u ~C
1696 // iff C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001697 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001698 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1699 : CmpInst::ICMP_ULE;
1700 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1701 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001702
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001703 // (X & C2) == 0 -> (trunc X) >= 0
1704 // (X & C2) != 0 -> (trunc X) < 0
1705 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1706 const APInt *C2;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001707 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001708 int32_t ExactLogBase2 = C2->exactLogBase2();
1709 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1710 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1711 if (And->getType()->isVectorTy())
1712 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001713 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001714 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1715 : CmpInst::ICMP_SLT;
1716 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001717 }
1718 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001719
Sanjay Patela3f4f082016-08-16 17:54:36 +00001720 return nullptr;
1721}
1722
Sanjay Patel943e92e2016-08-17 16:30:43 +00001723/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001724Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001725 const APInt &C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001726 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001727 if (C.isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001728 // icmp slt signum(V) 1 --> icmp slt V, 1
1729 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001730 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001731 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1732 ConstantInt::get(V->getType(), 1));
1733 }
1734
Sanjay Patel50c82c42017-04-05 17:57:05 +00001735 // X | C == C --> X <=u C
1736 // X | C != C --> X >u C
1737 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1738 if (Cmp.isEquality() && Cmp.getOperand(1) == Or->getOperand(1) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001739 (C + 1).isPowerOf2()) {
Sanjay Patel50c82c42017-04-05 17:57:05 +00001740 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1741 return new ICmpInst(Pred, Or->getOperand(0), Or->getOperand(1));
1742 }
1743
Craig Topper8ed1aa92017-10-03 05:31:07 +00001744 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001745 return nullptr;
1746
1747 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001748 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001749 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1750 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001751 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001752 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001753 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001754 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001755 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1756 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1757 }
1758
1759 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1760 // a shorter form that has more potential to be folded even further.
1761 Value *X1, *X2, *X3, *X4;
1762 if (match(Or->getOperand(0), m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1763 match(Or->getOperand(1), m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
1764 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1765 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1766 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1767 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1768 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1769 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001770 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001771
Sanjay Patela3f4f082016-08-16 17:54:36 +00001772 return nullptr;
1773}
1774
Sanjay Patel63478072016-08-18 15:44:44 +00001775/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001776Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1777 BinaryOperator *Mul,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001778 const APInt &C) {
Sanjay Patel63478072016-08-18 15:44:44 +00001779 const APInt *MulC;
1780 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001781 return nullptr;
1782
Sanjay Patel63478072016-08-18 15:44:44 +00001783 // If this is a test of the sign bit and the multiply is sign-preserving with
1784 // a constant operand, use the multiply LHS operand instead.
1785 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001786 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001787 if (MulC->isNegative())
1788 Pred = ICmpInst::getSwappedPredicate(Pred);
1789 return new ICmpInst(Pred, Mul->getOperand(0),
1790 Constant::getNullValue(Mul->getType()));
1791 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001792
1793 return nullptr;
1794}
1795
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001796/// Fold icmp (shl 1, Y), C.
1797static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001798 const APInt &C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001799 Value *Y;
1800 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1801 return nullptr;
1802
1803 Type *ShiftType = Shl->getType();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001804 unsigned TypeBits = C.getBitWidth();
1805 bool CIsPowerOf2 = C.isPowerOf2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001806 ICmpInst::Predicate Pred = Cmp.getPredicate();
1807 if (Cmp.isUnsigned()) {
1808 // (1 << Y) pred C -> Y pred Log2(C)
1809 if (!CIsPowerOf2) {
1810 // (1 << Y) < 30 -> Y <= 4
1811 // (1 << Y) <= 30 -> Y <= 4
1812 // (1 << Y) >= 30 -> Y > 4
1813 // (1 << Y) > 30 -> Y > 4
1814 if (Pred == ICmpInst::ICMP_ULT)
1815 Pred = ICmpInst::ICMP_ULE;
1816 else if (Pred == ICmpInst::ICMP_UGE)
1817 Pred = ICmpInst::ICMP_UGT;
1818 }
1819
1820 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1821 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
Craig Topper8ed1aa92017-10-03 05:31:07 +00001822 unsigned CLog2 = C.logBase2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001823 if (CLog2 == TypeBits - 1) {
1824 if (Pred == ICmpInst::ICMP_UGE)
1825 Pred = ICmpInst::ICMP_EQ;
1826 else if (Pred == ICmpInst::ICMP_ULT)
1827 Pred = ICmpInst::ICMP_NE;
1828 }
1829 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1830 } else if (Cmp.isSigned()) {
1831 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001832 if (C.isAllOnesValue()) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001833 // (1 << Y) <= -1 -> Y == 31
1834 if (Pred == ICmpInst::ICMP_SLE)
1835 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1836
1837 // (1 << Y) > -1 -> Y != 31
1838 if (Pred == ICmpInst::ICMP_SGT)
1839 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001840 } else if (!C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001841 // (1 << Y) < 0 -> Y == 31
1842 // (1 << Y) <= 0 -> Y == 31
1843 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
1844 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1845
1846 // (1 << Y) >= 0 -> Y != 31
1847 // (1 << Y) > 0 -> Y != 31
1848 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
1849 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
1850 }
1851 } else if (Cmp.isEquality() && CIsPowerOf2) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001852 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2()));
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001853 }
1854
1855 return nullptr;
1856}
1857
Sanjay Patel38b75062016-08-19 17:20:37 +00001858/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001859Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
1860 BinaryOperator *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001861 const APInt &C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001862 const APInt *ShiftVal;
1863 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00001864 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001865
Sanjay Patelfa7de602016-08-19 22:33:26 +00001866 const APInt *ShiftAmt;
1867 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00001868 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00001869
Sanjay Patel38b75062016-08-19 17:20:37 +00001870 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00001871 // shifts. When the shift is visited, it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001872 unsigned TypeBits = C.getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00001873 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001874 return nullptr;
1875
Sanjay Patele38e79c2016-08-19 17:34:05 +00001876 ICmpInst::Predicate Pred = Cmp.getPredicate();
1877 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00001878 Type *ShType = Shl->getType();
1879
Sanjay Patel291c3d82017-01-19 16:12:10 +00001880 // NSW guarantees that we are only shifting out sign bits from the high bits,
1881 // so we can ASHR the compare constant without needing a mask and eliminate
1882 // the shift.
1883 if (Shl->hasNoSignedWrap()) {
1884 if (Pred == ICmpInst::ICMP_SGT) {
1885 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001886 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001887 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1888 }
1889 if (Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) {
1890 // This is the same code as the SGT case, but assert the pre-condition
1891 // that is needed for this to work with equality predicates.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001892 assert(C.ashr(*ShiftAmt).shl(*ShiftAmt) == C &&
Sanjay Patel291c3d82017-01-19 16:12:10 +00001893 "Compare known true or false was not folded");
Craig Topper8ed1aa92017-10-03 05:31:07 +00001894 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00001895 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1896 }
1897 if (Pred == ICmpInst::ICMP_SLT) {
1898 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
1899 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
1900 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
1901 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
Craig Topper8ed1aa92017-10-03 05:31:07 +00001902 assert(!C.isMinSignedValue() && "Unexpected icmp slt");
1903 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1;
Sanjay Patel291c3d82017-01-19 16:12:10 +00001904 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1905 }
1906 // If this is a signed comparison to 0 and the shift is sign preserving,
1907 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
1908 // do that if we're sure to not continue on in this function.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001909 if (isSignTest(Pred, C))
Sanjay Patel291c3d82017-01-19 16:12:10 +00001910 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
1911 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001912
Sanjay Patel291c3d82017-01-19 16:12:10 +00001913 // NUW guarantees that we are only shifting out zero bits from the high bits,
1914 // so we can LSHR the compare constant without needing a mask and eliminate
1915 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00001916 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00001917 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00001918 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00001919 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patel14715b32017-01-17 21:25:16 +00001920 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1921 }
Sanjay Patelae23d652017-01-18 21:16:12 +00001922 if (Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) {
1923 // This is the same code as the UGT case, but assert the pre-condition
1924 // that is needed for this to work with equality predicates.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001925 assert(C.lshr(*ShiftAmt).shl(*ShiftAmt) == C &&
Sanjay Patelae23d652017-01-18 21:16:12 +00001926 "Compare known true or false was not folded");
Craig Topper8ed1aa92017-10-03 05:31:07 +00001927 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patelae23d652017-01-18 21:16:12 +00001928 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1929 }
Sanjay Patel14715b32017-01-17 21:25:16 +00001930 if (Pred == ICmpInst::ICMP_ULT) {
1931 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
1932 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
1933 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
1934 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
Craig Topper8ed1aa92017-10-03 05:31:07 +00001935 assert(C.ugt(0) && "ult 0 should have been eliminated");
1936 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1;
Sanjay Patel14715b32017-01-17 21:25:16 +00001937 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
1938 }
1939 }
1940
Sanjay Patel291c3d82017-01-19 16:12:10 +00001941 if (Cmp.isEquality() && Shl->hasOneUse()) {
1942 // Strength-reduce the shift into an 'and'.
1943 Constant *Mask = ConstantInt::get(
1944 ShType,
1945 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00001946 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Craig Topper8ed1aa92017-10-03 05:31:07 +00001947 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00001948 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001949 }
1950
Sanjay Patela3f4f082016-08-16 17:54:36 +00001951 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
1952 bool TrueIfSigned = false;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001953 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00001954 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00001955 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00001956 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00001957 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00001958 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00001959 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00001960 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00001961 }
1962
Sanjay Patel643d21a2016-08-21 17:10:07 +00001963 // Transform (icmp pred iM (shl iM %v, N), C)
1964 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
1965 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00001966 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00001967 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00001968 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00001969 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001970 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt &&
Sanjay Patelf3dda132016-10-25 20:11:47 +00001971 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00001972 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00001973 if (ShType->isVectorTy())
1974 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00001975 Constant *NewC =
Craig Topper8ed1aa92017-10-03 05:31:07 +00001976 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00001977 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001978 }
1979
1980 return nullptr;
1981}
1982
Sanjay Patela3920492016-08-22 20:45:06 +00001983/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001984Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
1985 BinaryOperator *Shr,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001986 const APInt &C) {
Sanjay Patela3920492016-08-22 20:45:06 +00001987 // An exact shr only shifts out zero bits, so:
1988 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00001989 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00001990 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00001991 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001992 C.isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00001993 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00001994
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001995 const APInt *ShiftVal;
1996 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00001997 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001998
Sanjay Pateld398d4a2016-08-24 22:22:06 +00001999 const APInt *ShiftAmt;
2000 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002001 return nullptr;
2002
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002003 // Check that the shift amount is in range. If not, don't perform undefined
2004 // shifts. When the shift is visited it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002005 unsigned TypeBits = C.getBitWidth();
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002006 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002007 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2008 return nullptr;
2009
Sanjay Pateld64e9882016-08-23 22:05:55 +00002010 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002011 if (!Cmp.isEquality()) {
2012 // If we have an unsigned comparison and an ashr, we can't simplify this.
2013 // Similarly for signed comparisons with lshr.
Sanjay Pateld64e9882016-08-23 22:05:55 +00002014 if (Cmp.isSigned() != IsAShr)
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002015 return nullptr;
2016
2017 // Otherwise, all lshr and most exact ashr's are equivalent to a udiv/sdiv
2018 // by a power of 2. Since we already have logic to simplify these,
2019 // transform to div and then simplify the resultant comparison.
Sanjay Pateld64e9882016-08-23 22:05:55 +00002020 if (IsAShr && (!Shr->isExact() || ShAmtVal == TypeBits - 1))
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002021 return nullptr;
2022
2023 // Revisit the shift (to delete it).
2024 Worklist.Add(Shr);
2025
2026 Constant *DivCst = ConstantInt::get(
2027 Shr->getType(), APInt::getOneBitSet(TypeBits, ShAmtVal));
2028
Craig Topperbb4069e2017-07-07 23:16:26 +00002029 Value *Tmp = IsAShr ? Builder.CreateSDiv(X, DivCst, "", Shr->isExact())
2030 : Builder.CreateUDiv(X, DivCst, "", Shr->isExact());
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002031
2032 Cmp.setOperand(0, Tmp);
2033
2034 // If the builder folded the binop, just return it.
2035 BinaryOperator *TheDiv = dyn_cast<BinaryOperator>(Tmp);
2036 if (!TheDiv)
2037 return &Cmp;
2038
2039 // Otherwise, fold this div/compare.
2040 assert(TheDiv->getOpcode() == Instruction::SDiv ||
2041 TheDiv->getOpcode() == Instruction::UDiv);
2042
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002043 Instruction *Res = foldICmpDivConstant(Cmp, TheDiv, C);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002044 assert(Res && "This div/cst should have folded!");
Sanjay Patela3920492016-08-22 20:45:06 +00002045 return Res;
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002046 }
2047
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002048 // Handle equality comparisons of shift-by-constant.
2049
Sanjay Patel8e297742016-08-24 13:55:55 +00002050 // If the comparison constant changes with the shift, the comparison cannot
2051 // succeed (bits of the comparison constant cannot match the shifted value).
2052 // This should be known by InstSimplify and already be folded to true/false.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002053 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) ||
2054 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) &&
Sanjay Patel8e297742016-08-24 13:55:55 +00002055 "Expected icmp+shr simplify did not occur.");
2056
Sanjay Patel6e17c002017-10-02 18:26:44 +00002057 // If the bits shifted out are known zero, compare the unshifted value:
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002058 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002059 Constant *ShiftedCmpRHS = ConstantInt::get(Shr->getType(), C << ShAmtVal);
Sanjay Patel6e17c002017-10-02 18:26:44 +00002060 if (Shr->isExact())
2061 return new ICmpInst(Pred, X, ShiftedCmpRHS);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002062
Sanjay Patel6e17c002017-10-02 18:26:44 +00002063 if (Shr->hasOneUse()) {
2064 // Canonicalize the shift into an 'and':
2065 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt)
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002066 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
2067 Constant *Mask = ConstantInt::get(Shr->getType(), Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002068 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002069 return new ICmpInst(Pred, And, ShiftedCmpRHS);
2070 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002071
2072 return nullptr;
2073}
2074
Sanjay Patel12a41052016-08-18 17:37:26 +00002075/// Fold icmp (udiv X, Y), C.
2076Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002077 BinaryOperator *UDiv,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002078 const APInt &C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002079 const APInt *C2;
2080 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2081 return nullptr;
2082
Craig Topper29c282e2017-06-07 07:40:29 +00002083 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002084
2085 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2086 Value *Y = UDiv->getOperand(1);
2087 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002088 assert(!C.isMaxValue() &&
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002089 "icmp ugt X, UINT_MAX should have been simplified already.");
2090 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002091 ConstantInt::get(Y->getType(), C2->udiv(C + 1)));
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002092 }
2093
2094 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2095 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002096 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002097 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002098 ConstantInt::get(Y->getType(), C2->udiv(C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002099 }
2100
2101 return nullptr;
2102}
2103
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002104/// Fold icmp ({su}div X, Y), C.
2105Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2106 BinaryOperator *Div,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002107 const APInt &C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002108 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002109 // Fold this div into the comparison, producing a range check.
2110 // Determine, based on the divide type, what the range is being
2111 // checked. If there is an overflow on the low or high side, remember
2112 // it, otherwise compute the range [low, hi) bounding the new value.
2113 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002114 const APInt *C2;
2115 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002116 return nullptr;
2117
Sanjay Patel16554142016-08-24 23:03:36 +00002118 // FIXME: If the operand types don't match the type of the divide
2119 // then don't attempt this transform. The code below doesn't have the
2120 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002121 // vice versa). This is because (x /s C2) <s C produces different
2122 // results than (x /s C2) <u C or (x /u C2) <s C or even
2123 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002124 // work. :( The if statement below tests that condition and bails
2125 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002126 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2127 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002128 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002129
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002130 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2131 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2132 // division-by-constant cases should be present, we can not assert that they
2133 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002134 if (C2->isNullValue() || C2->isOneValue() ||
2135 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002136 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002137
Craig Topper6e025a32017-10-01 23:53:54 +00002138 // Compute Prod = C * C2. We are essentially solving an equation of
2139 // form X / C2 = C. We solve for X by multiplying C2 and C.
Sanjay Patel541aef42016-08-31 21:57:21 +00002140 // By solving for X, we can turn this into a range check instead of computing
2141 // a divide.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002142 APInt Prod = C * *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002143
Sanjay Patel541aef42016-08-31 21:57:21 +00002144 // Determine if the product overflows by seeing if the product is not equal to
2145 // the divide. Make sure we do the same kind of divide as in the LHS
2146 // instruction that we're folding.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002147 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C;
Sanjay Patel16554142016-08-24 23:03:36 +00002148
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002149 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002150
2151 // If the division is known to be exact, then there is no remainder from the
2152 // divide, so the covered range size is unit, otherwise it is the divisor.
Craig Topper6e025a32017-10-01 23:53:54 +00002153 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002154
2155 // Figure out the interval that is being checked. For example, a comparison
2156 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2157 // Compute this interval based on the constants involved and the signedness of
2158 // the compare/divide. This computes a half-open interval, keeping track of
2159 // whether either value in the interval overflows. After analysis each
2160 // overflow variable is set to 0 if it's corresponding bound variable is valid
2161 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2162 int LoOverflow = 0, HiOverflow = 0;
Craig Topper6e025a32017-10-01 23:53:54 +00002163 APInt LoBound, HiBound;
Sanjay Patel16554142016-08-24 23:03:36 +00002164
2165 if (!DivIsSigned) { // udiv
2166 // e.g. X/5 op 3 --> [15, 20)
2167 LoBound = Prod;
2168 HiOverflow = LoOverflow = ProdOV;
2169 if (!HiOverflow) {
2170 // If this is not an exact divide, then many values in the range collapse
2171 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002172 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002173 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002174 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002175 if (C.isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002176 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
Craig Topper6e025a32017-10-01 23:53:54 +00002177 LoBound = -(RangeSize - 1);
Sanjay Patel16554142016-08-24 23:03:36 +00002178 HiBound = RangeSize;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002179 } else if (C.isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002180 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2181 HiOverflow = LoOverflow = ProdOV;
2182 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002183 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002184 } else { // (X / pos) op neg
2185 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002186 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002187 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2188 if (!LoOverflow) {
Craig Topper6e025a32017-10-01 23:53:54 +00002189 APInt DivNeg = -RangeSize;
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002190 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002191 }
2192 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002193 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002194 if (Div->isExact())
Craig Topper6e025a32017-10-01 23:53:54 +00002195 RangeSize.negate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00002196 if (C.isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002197 // e.g. X/-5 op 0 --> [-4, 5)
Craig Topper6e025a32017-10-01 23:53:54 +00002198 LoBound = RangeSize + 1;
2199 HiBound = -RangeSize;
2200 if (HiBound == *C2) { // -INTMIN = INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002201 HiOverflow = 1; // [INTMIN+1, overflow)
Craig Topper6e025a32017-10-01 23:53:54 +00002202 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002203 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002204 } else if (C.isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002205 // e.g. X/-5 op 3 --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002206 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002207 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2208 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002209 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002210 } else { // (X / neg) op neg
2211 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2212 LoOverflow = HiOverflow = ProdOV;
2213 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002214 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002215 }
2216
2217 // Dividing by a negative swaps the condition. LT <-> GT
2218 Pred = ICmpInst::getSwappedPredicate(Pred);
2219 }
2220
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002221 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002222 switch (Pred) {
2223 default: llvm_unreachable("Unhandled icmp opcode!");
2224 case ICmpInst::ICMP_EQ:
2225 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002226 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002227 if (HiOverflow)
2228 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002229 ICmpInst::ICMP_UGE, X,
2230 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002231 if (LoOverflow)
2232 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002233 ICmpInst::ICMP_ULT, X,
2234 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel85d79742016-08-31 19:49:56 +00002235 return replaceInstUsesWith(
Craig Topper6e025a32017-10-01 23:53:54 +00002236 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002237 case ICmpInst::ICMP_NE:
2238 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002239 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002240 if (HiOverflow)
2241 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002242 ICmpInst::ICMP_ULT, X,
2243 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002244 if (LoOverflow)
2245 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002246 ICmpInst::ICMP_UGE, X,
2247 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel541aef42016-08-31 21:57:21 +00002248 return replaceInstUsesWith(Cmp,
Craig Topper6e025a32017-10-01 23:53:54 +00002249 insertRangeTest(X, LoBound, HiBound,
Sanjay Patel541aef42016-08-31 21:57:21 +00002250 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002251 case ICmpInst::ICMP_ULT:
2252 case ICmpInst::ICMP_SLT:
2253 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002254 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002255 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002256 return replaceInstUsesWith(Cmp, Builder.getFalse());
Craig Topper6e025a32017-10-01 23:53:54 +00002257 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002258 case ICmpInst::ICMP_UGT:
2259 case ICmpInst::ICMP_SGT:
2260 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002261 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002262 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002263 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002264 if (Pred == ICmpInst::ICMP_UGT)
Craig Topper6e025a32017-10-01 23:53:54 +00002265 return new ICmpInst(ICmpInst::ICMP_UGE, X,
2266 ConstantInt::get(Div->getType(), HiBound));
2267 return new ICmpInst(ICmpInst::ICMP_SGE, X,
2268 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002269 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002270
2271 return nullptr;
2272}
2273
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002274/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002275Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2276 BinaryOperator *Sub,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002277 const APInt &C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002278 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2279 ICmpInst::Predicate Pred = Cmp.getPredicate();
2280
2281 // The following transforms are only worth it if the only user of the subtract
2282 // is the icmp.
2283 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002284 return nullptr;
2285
Sanjay Patel886a5422016-09-15 18:05:17 +00002286 if (Sub->hasNoSignedWrap()) {
2287 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002288 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002289 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002290
Sanjay Patel886a5422016-09-15 18:05:17 +00002291 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002292 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002293 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2294
2295 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002296 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002297 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2298
2299 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002300 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002301 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2302 }
2303
2304 const APInt *C2;
2305 if (!match(X, m_APInt(C2)))
2306 return nullptr;
2307
2308 // C2 - Y <u C -> (Y | (C - 1)) == C2
2309 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002310 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() &&
2311 (*C2 & (C - 1)) == (C - 1))
2312 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002313
2314 // C2 - Y >u C -> (Y | C) != C2
2315 // iff C2 & C == C and C + 1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002316 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C)
2317 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002318
2319 return nullptr;
2320}
2321
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002322/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002323Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2324 BinaryOperator *Add,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002325 const APInt &C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002326 Value *Y = Add->getOperand(1);
2327 const APInt *C2;
2328 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002329 return nullptr;
2330
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002331 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002332 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002333 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002334 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002335
2336 // If the add does not wrap, we can always adjust the compare by subtracting
2337 // the constants. Equality comparisons are handled elsewhere. SGE/SLE are
2338 // canonicalized to SGT/SLT.
2339 if (Add->hasNoSignedWrap() &&
2340 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) {
2341 bool Overflow;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002342 APInt NewC = C.ssub_ov(*C2, Overflow);
Sanjay Patel45b7e692017-02-12 16:40:30 +00002343 // If there is overflow, the result must be true or false.
2344 // TODO: Can we assert there is no overflow because InstSimplify always
2345 // handles those cases?
2346 if (!Overflow)
2347 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2348 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2349 }
2350
Craig Topper8ed1aa92017-10-03 05:31:07 +00002351 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002352 const APInt &Upper = CR.getUpper();
2353 const APInt &Lower = CR.getLower();
2354 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002355 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002356 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002357 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002358 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002359 } else {
2360 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002361 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002362 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002363 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002364 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002365
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002366 if (!Add->hasOneUse())
2367 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00002368
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002369 // X+C <u C2 -> (X & -C2) == C
2370 // iff C & (C2-1) == 0
2371 // C2 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002372 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0)
2373 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002374 ConstantExpr::getNeg(cast<Constant>(Y)));
2375
2376 // X+C >u C2 -> (X & ~C2) != C
2377 // iff C & C2 == 0
2378 // C2+1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002379 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0)
2380 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002381 ConstantExpr::getNeg(cast<Constant>(Y)));
2382
Sanjay Patela3f4f082016-08-16 17:54:36 +00002383 return nullptr;
2384}
2385
Anna Thomasd67165c2017-06-23 13:41:45 +00002386bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2387 Value *&RHS, ConstantInt *&Less,
2388 ConstantInt *&Equal,
2389 ConstantInt *&Greater) {
2390 // TODO: Generalize this to work with other comparison idioms or ensure
2391 // they get canonicalized into this form.
2392
2393 // select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32
2394 // Greater), where Equal, Less and Greater are placeholders for any three
2395 // constants.
2396 ICmpInst::Predicate PredA, PredB;
2397 if (match(SI->getTrueValue(), m_ConstantInt(Equal)) &&
2398 match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) &&
2399 PredA == ICmpInst::ICMP_EQ &&
2400 match(SI->getFalseValue(),
2401 m_Select(m_ICmp(PredB, m_Specific(LHS), m_Specific(RHS)),
2402 m_ConstantInt(Less), m_ConstantInt(Greater))) &&
2403 PredB == ICmpInst::ICMP_SLT) {
2404 return true;
2405 }
2406 return false;
2407}
2408
2409Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002410 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002411 ConstantInt *C) {
2412
2413 assert(C && "Cmp RHS should be a constant int!");
2414 // If we're testing a constant value against the result of a three way
2415 // comparison, the result can be expressed directly in terms of the
2416 // original values being compared. Note: We could possibly be more
2417 // aggressive here and remove the hasOneUse test. The original select is
2418 // really likely to simplify or sink when we remove a test of the result.
2419 Value *OrigLHS, *OrigRHS;
2420 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2421 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002422 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2423 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002424 assert(C1LessThan && C2Equal && C3GreaterThan);
2425
2426 bool TrueWhenLessThan =
2427 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2428 ->isAllOnesValue();
2429 bool TrueWhenEqual =
2430 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2431 ->isAllOnesValue();
2432 bool TrueWhenGreaterThan =
2433 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2434 ->isAllOnesValue();
2435
2436 // This generates the new instruction that will replace the original Cmp
2437 // Instruction. Instead of enumerating the various combinations when
2438 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2439 // false, we rely on chaining of ORs and future passes of InstCombine to
2440 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2441
2442 // When none of the three constants satisfy the predicate for the RHS (C),
2443 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002444 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002445 if (TrueWhenLessThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002446 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002447 if (TrueWhenEqual)
Craig Topperbb4069e2017-07-07 23:16:26 +00002448 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002449 if (TrueWhenGreaterThan)
Craig Topperbb4069e2017-07-07 23:16:26 +00002450 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002451
2452 return replaceInstUsesWith(Cmp, Cond);
2453 }
2454 return nullptr;
2455}
2456
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002457/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2458/// where X is some kind of instruction.
2459Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002460 const APInt *C;
2461 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002462 return nullptr;
2463
Craig Toppera94069f2017-08-23 05:46:08 +00002464 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002465 switch (BO->getOpcode()) {
2466 case Instruction::Xor:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002467 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002468 return I;
2469 break;
2470 case Instruction::And:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002471 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002472 return I;
2473 break;
2474 case Instruction::Or:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002475 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002476 return I;
2477 break;
2478 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002479 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002480 return I;
2481 break;
2482 case Instruction::Shl:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002483 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002484 return I;
2485 break;
2486 case Instruction::LShr:
2487 case Instruction::AShr:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002488 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002489 return I;
2490 break;
2491 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002492 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002493 return I;
2494 LLVM_FALLTHROUGH;
2495 case Instruction::SDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002496 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002497 return I;
2498 break;
2499 case Instruction::Sub:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002500 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002501 return I;
2502 break;
2503 case Instruction::Add:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002504 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002505 return I;
2506 break;
2507 default:
2508 break;
2509 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002510 // TODO: These folds could be refactored to be part of the above calls.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002511 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002512 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002513 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002514
Anna Thomasd67165c2017-06-23 13:41:45 +00002515 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002516
2517 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2518 // For now, we only support constant integers while folding the
2519 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2520 // similar to the cases handled by binary ops above.
2521 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2522 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002523 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002524 }
2525
2526 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002527 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C))
Craig Topper524c44f2017-08-23 05:46:07 +00002528 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002529 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002530
Craig Topper8ed1aa92017-10-03 05:31:07 +00002531 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002532 return I;
2533
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002534 return nullptr;
2535}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002536
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002537/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2538/// icmp eq/ne BO, C.
2539Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2540 BinaryOperator *BO,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002541 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002542 // TODO: Some of these folds could work with arbitrary constants, but this
2543 // function is limited to scalar and vector splat constants.
2544 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002545 return nullptr;
2546
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002547 ICmpInst::Predicate Pred = Cmp.getPredicate();
2548 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2549 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002550 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002551
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002552 switch (BO->getOpcode()) {
2553 case Instruction::SRem:
2554 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002555 if (C.isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002556 const APInt *BOC;
2557 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002558 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002559 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002560 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002561 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002562 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002563 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002564 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002565 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002566 const APInt *BOC;
2567 if (match(BOp1, m_APInt(BOC))) {
2568 if (BO->hasOneUse()) {
2569 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002570 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002571 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002572 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002573 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2574 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002575 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002576 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002577 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002578 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002579 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002580 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002581 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002582 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002583 }
2584 }
2585 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002586 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002587 case Instruction::Xor:
2588 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002589 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002590 // For the xor case, we can xor two constants together, eliminating
2591 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002592 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002593 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002594 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002595 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002596 }
2597 }
2598 break;
2599 case Instruction::Sub:
2600 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002601 const APInt *BOC;
2602 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002603 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002604 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002605 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002606 } else if (C.isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002607 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002608 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002609 }
2610 }
2611 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002612 case Instruction::Or: {
2613 const APInt *BOC;
2614 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002615 // Comparing if all bits outside of a constant mask are set?
2616 // Replace (X | C) == -1 with (X & ~C) == ~C.
2617 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002618 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002619 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002620 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002621 }
2622 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002623 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002624 case Instruction::And: {
2625 const APInt *BOC;
2626 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002627 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Craig Topper8ed1aa92017-10-03 05:31:07 +00002628 if (C == *BOC && C.isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002629 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002630 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002631
2632 // Don't perform the following transforms if the AND has multiple uses
2633 if (!BO->hasOneUse())
2634 break;
2635
2636 // Replace (and X, (1 << size(X)-1) != 0) with x s< 0
Craig Topperbcfd2d12017-04-20 16:56:25 +00002637 if (BOC->isSignMask()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002638 Constant *Zero = Constant::getNullValue(BOp0->getType());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002639 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
2640 return new ICmpInst(NewPred, BOp0, Zero);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002641 }
2642
2643 // ((X & ~7) == 0) --> X < 8
Craig Topper8ed1aa92017-10-03 05:31:07 +00002644 if (C.isNullValue() && (~(*BOC) + 1).isPowerOf2()) {
Sanjay Pateld938e882016-08-04 20:05:02 +00002645 Constant *NegBOC = ConstantExpr::getNeg(cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002646 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
2647 return new ICmpInst(NewPred, BOp0, NegBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002648 }
2649 }
2650 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002651 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002652 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002653 if (C.isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002654 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002655 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002656 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002657 // General case : (mul X, C) != 0 iff X != 0
2658 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002659 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002660 }
2661 }
2662 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002663 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002664 if (C.isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002665 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002666 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
2667 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00002668 }
2669 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002670 default:
2671 break;
2672 }
2673 return nullptr;
2674}
2675
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002676/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
2677Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002678 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002679 IntrinsicInst *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0));
2680 if (!II || !Cmp.isEquality())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002681 return nullptr;
2682
Sanjay Patelb51e0722017-07-02 16:05:11 +00002683 // Handle icmp {eq|ne} <intrinsic>, Constant.
2684 Type *Ty = II->getType();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002685 switch (II->getIntrinsicID()) {
2686 case Intrinsic::bswap:
2687 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002688 Cmp.setOperand(0, II->getArgOperand(0));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002689 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002690 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002691
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002692 case Intrinsic::ctlz:
2693 case Intrinsic::cttz:
Amaury Sechet6bea6742016-08-04 05:27:20 +00002694 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002695 if (C == C.getBitWidth()) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002696 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002697 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002698 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002699 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00002700 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002701 break;
Sanjay Patelb51e0722017-07-02 16:05:11 +00002702
Amaury Sechet6bea6742016-08-04 05:27:20 +00002703 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002704 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00002705 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00002706 bool IsZero = C.isNullValue();
2707 if (IsZero || C == C.getBitWidth()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002708 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002709 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00002710 auto *NewOp =
2711 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002712 Cmp.setOperand(1, NewOp);
2713 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00002714 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002715 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002716 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002717 default:
2718 break;
Chris Lattner2188e402010-01-04 07:37:31 +00002719 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00002720
Craig Topperf40110f2014-04-25 05:29:35 +00002721 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00002722}
2723
Sanjay Patel10494b22016-09-16 16:10:22 +00002724/// Handle icmp with constant (but not simple integer constant) RHS.
2725Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
2726 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2727 Constant *RHSC = dyn_cast<Constant>(Op1);
2728 Instruction *LHSI = dyn_cast<Instruction>(Op0);
2729 if (!RHSC || !LHSI)
2730 return nullptr;
2731
2732 switch (LHSI->getOpcode()) {
2733 case Instruction::GetElementPtr:
2734 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
2735 if (RHSC->isNullValue() &&
2736 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
2737 return new ICmpInst(
2738 I.getPredicate(), LHSI->getOperand(0),
2739 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2740 break;
2741 case Instruction::PHI:
2742 // Only fold icmp into the PHI if the phi and icmp are in the same
2743 // block. If in the same block, we're encouraging jump threading. If
2744 // not, we are just pessimizing the code by making an i1 phi.
2745 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00002746 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00002747 return NV;
2748 break;
2749 case Instruction::Select: {
2750 // If either operand of the select is a constant, we can fold the
2751 // comparison into the select arms, which will cause one to be
2752 // constant folded and the select turned into a bitwise or.
2753 Value *Op1 = nullptr, *Op2 = nullptr;
2754 ConstantInt *CI = nullptr;
2755 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
2756 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2757 CI = dyn_cast<ConstantInt>(Op1);
2758 }
2759 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
2760 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
2761 CI = dyn_cast<ConstantInt>(Op2);
2762 }
2763
2764 // We only want to perform this transformation if it will not lead to
2765 // additional code. This is true if either both sides of the select
2766 // fold to a constant (in which case the icmp is replaced with a select
2767 // which will usually simplify) or this is the only user of the
2768 // select (in which case we are trading a select+icmp for a simpler
2769 // select+icmp) or all uses of the select can be replaced based on
2770 // dominance information ("Global cases").
2771 bool Transform = false;
2772 if (Op1 && Op2)
2773 Transform = true;
2774 else if (Op1 || Op2) {
2775 // Local case
2776 if (LHSI->hasOneUse())
2777 Transform = true;
2778 // Global cases
2779 else if (CI && !CI->isZero())
2780 // When Op1 is constant try replacing select with second operand.
2781 // Otherwise Op2 is constant and try replacing select with first
2782 // operand.
2783 Transform =
2784 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
2785 }
2786 if (Transform) {
2787 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00002788 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
2789 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002790 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00002791 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
2792 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00002793 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
2794 }
2795 break;
2796 }
2797 case Instruction::IntToPtr:
2798 // icmp pred inttoptr(X), null -> icmp pred X, 0
2799 if (RHSC->isNullValue() &&
2800 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
2801 return new ICmpInst(
2802 I.getPredicate(), LHSI->getOperand(0),
2803 Constant::getNullValue(LHSI->getOperand(0)->getType()));
2804 break;
2805
2806 case Instruction::Load:
2807 // Try to optimize things like "A[i] > 4" to index computations.
2808 if (GetElementPtrInst *GEP =
2809 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
2810 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
2811 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
2812 !cast<LoadInst>(LHSI)->isVolatile())
2813 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
2814 return Res;
2815 }
2816 break;
2817 }
2818
2819 return nullptr;
2820}
2821
2822/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00002823/// TODO: A large part of this logic is duplicated in InstSimplify's
2824/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
2825/// duplication.
Sanjay Patel10494b22016-09-16 16:10:22 +00002826Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) {
2827 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
2828
2829 // Special logic for binary operators.
2830 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
2831 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
2832 if (!BO0 && !BO1)
2833 return nullptr;
2834
Sanjay Patel2a062632017-05-08 16:33:42 +00002835 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00002836 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
2837 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
2838 NoOp0WrapProblem =
2839 ICmpInst::isEquality(Pred) ||
2840 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
2841 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
2842 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
2843 NoOp1WrapProblem =
2844 ICmpInst::isEquality(Pred) ||
2845 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
2846 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
2847
2848 // Analyze the case when either Op0 or Op1 is an add instruction.
2849 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
2850 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
2851 if (BO0 && BO0->getOpcode() == Instruction::Add) {
2852 A = BO0->getOperand(0);
2853 B = BO0->getOperand(1);
2854 }
2855 if (BO1 && BO1->getOpcode() == Instruction::Add) {
2856 C = BO1->getOperand(0);
2857 D = BO1->getOperand(1);
2858 }
2859
Sanjay Patel10494b22016-09-16 16:10:22 +00002860 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow.
2861 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
2862 return new ICmpInst(Pred, A == Op1 ? B : A,
2863 Constant::getNullValue(Op1->getType()));
2864
2865 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow.
2866 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
2867 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
2868 C == Op0 ? D : C);
2869
2870 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow.
2871 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
2872 NoOp1WrapProblem &&
2873 // Try not to increase register pressure.
2874 BO0->hasOneUse() && BO1->hasOneUse()) {
2875 // Determine Y and Z in the form icmp (X+Y), (X+Z).
2876 Value *Y, *Z;
2877 if (A == C) {
2878 // C + B == C + D -> B == D
2879 Y = B;
2880 Z = D;
2881 } else if (A == D) {
2882 // D + B == C + D -> B == C
2883 Y = B;
2884 Z = C;
2885 } else if (B == C) {
2886 // A + C == C + D -> A == D
2887 Y = A;
2888 Z = D;
2889 } else {
2890 assert(B == D);
2891 // A + D == C + D -> A == C
2892 Y = A;
2893 Z = C;
2894 }
2895 return new ICmpInst(Pred, Y, Z);
2896 }
2897
2898 // icmp slt (X + -1), Y -> icmp sle X, Y
2899 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
2900 match(B, m_AllOnes()))
2901 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
2902
2903 // icmp sge (X + -1), Y -> icmp sgt X, Y
2904 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
2905 match(B, m_AllOnes()))
2906 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
2907
2908 // icmp sle (X + 1), Y -> icmp slt X, Y
2909 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
2910 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
2911
2912 // icmp sgt (X + 1), Y -> icmp sge X, Y
2913 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
2914 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
2915
2916 // icmp sgt X, (Y + -1) -> icmp sge X, Y
2917 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
2918 match(D, m_AllOnes()))
2919 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
2920
2921 // icmp sle X, (Y + -1) -> icmp slt X, Y
2922 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
2923 match(D, m_AllOnes()))
2924 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
2925
2926 // icmp sge X, (Y + 1) -> icmp sgt X, Y
2927 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
2928 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
2929
2930 // icmp slt X, (Y + 1) -> icmp sle X, Y
2931 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
2932 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
2933
Sanjay Patel40f40172017-01-13 23:25:46 +00002934 // TODO: The subtraction-related identities shown below also hold, but
2935 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
2936 // wouldn't happen even if they were implemented.
2937 //
2938 // icmp ult (X - 1), Y -> icmp ule X, Y
2939 // icmp uge (X - 1), Y -> icmp ugt X, Y
2940 // icmp ugt X, (Y - 1) -> icmp uge X, Y
2941 // icmp ule X, (Y - 1) -> icmp ult X, Y
2942
2943 // icmp ule (X + 1), Y -> icmp ult X, Y
2944 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
2945 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
2946
2947 // icmp ugt (X + 1), Y -> icmp uge X, Y
2948 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
2949 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
2950
2951 // icmp uge X, (Y + 1) -> icmp ugt X, Y
2952 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
2953 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
2954
2955 // icmp ult X, (Y + 1) -> icmp ule X, Y
2956 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
2957 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
2958
Sanjay Patel10494b22016-09-16 16:10:22 +00002959 // if C1 has greater magnitude than C2:
2960 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y
2961 // s.t. C3 = C1 - C2
2962 //
2963 // if C2 has greater magnitude than C1:
2964 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3)
2965 // s.t. C3 = C2 - C1
2966 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
2967 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
2968 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
2969 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
2970 const APInt &AP1 = C1->getValue();
2971 const APInt &AP2 = C2->getValue();
2972 if (AP1.isNegative() == AP2.isNegative()) {
2973 APInt AP1Abs = C1->getValue().abs();
2974 APInt AP2Abs = C2->getValue().abs();
2975 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002976 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
2977 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00002978 return new ICmpInst(Pred, NewAdd, C);
2979 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00002980 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
2981 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00002982 return new ICmpInst(Pred, A, NewAdd);
2983 }
2984 }
2985 }
2986
2987 // Analyze the case when either Op0 or Op1 is a sub instruction.
2988 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
2989 A = nullptr;
2990 B = nullptr;
2991 C = nullptr;
2992 D = nullptr;
2993 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
2994 A = BO0->getOperand(0);
2995 B = BO0->getOperand(1);
2996 }
2997 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
2998 C = BO1->getOperand(0);
2999 D = BO1->getOperand(1);
3000 }
3001
3002 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow.
3003 if (A == Op1 && NoOp0WrapProblem)
3004 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
3005
3006 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow.
3007 if (C == Op0 && NoOp1WrapProblem)
3008 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3009
3010 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow.
3011 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem &&
3012 // Try not to increase register pressure.
3013 BO0->hasOneUse() && BO1->hasOneUse())
3014 return new ICmpInst(Pred, A, C);
3015
3016 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow.
3017 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem &&
3018 // Try not to increase register pressure.
3019 BO0->hasOneUse() && BO1->hasOneUse())
3020 return new ICmpInst(Pred, D, B);
3021
3022 // icmp (0-X) < cst --> x > -cst
3023 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3024 Value *X;
3025 if (match(BO0, m_Neg(m_Value(X))))
3026 if (ConstantInt *RHSC = dyn_cast<ConstantInt>(Op1))
3027 if (!RHSC->isMinValue(/*isSigned=*/true))
3028 return new ICmpInst(I.getSwappedPredicate(), X,
3029 ConstantExpr::getNeg(RHSC));
3030 }
3031
3032 BinaryOperator *SRem = nullptr;
3033 // icmp (srem X, Y), Y
3034 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3035 SRem = BO0;
3036 // icmp Y, (srem X, Y)
3037 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3038 Op0 == BO1->getOperand(1))
3039 SRem = BO1;
3040 if (SRem) {
3041 // We don't check hasOneUse to avoid increasing register pressure because
3042 // the value we use is the same value this instruction was already using.
3043 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3044 default:
3045 break;
3046 case ICmpInst::ICMP_EQ:
3047 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3048 case ICmpInst::ICMP_NE:
3049 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3050 case ICmpInst::ICMP_SGT:
3051 case ICmpInst::ICMP_SGE:
3052 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3053 Constant::getAllOnesValue(SRem->getType()));
3054 case ICmpInst::ICMP_SLT:
3055 case ICmpInst::ICMP_SLE:
3056 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3057 Constant::getNullValue(SRem->getType()));
3058 }
3059 }
3060
3061 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3062 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3063 switch (BO0->getOpcode()) {
3064 default:
3065 break;
3066 case Instruction::Add:
3067 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003068 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003069 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003070 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003071
3072 const APInt *C;
3073 if (match(BO0->getOperand(1), m_APInt(C))) {
3074 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3075 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003076 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003077 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003078 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003079 }
3080
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003081 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3082 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003083 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003084 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003085 NewPred = I.getSwappedPredicate(NewPred);
3086 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003087 }
3088 }
3089 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003090 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003091 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003092 if (!I.isEquality())
3093 break;
3094
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003095 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003096 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3097 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003098 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3099 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003100 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003101 Constant *Mask = ConstantInt::get(
3102 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003103 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003104 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3105 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003106 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003107 }
Sanjay Patel51506122017-05-25 14:13:57 +00003108 // If there are no trailing zeros in the multiplier, just eliminate
3109 // the multiplies (no masking is needed):
3110 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3111 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003112 }
3113 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003114 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003115 case Instruction::UDiv:
3116 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003117 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003118 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003119 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3120
Sanjay Patel10494b22016-09-16 16:10:22 +00003121 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003122 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3123 break;
3124 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3125
Sanjay Patel10494b22016-09-16 16:10:22 +00003126 case Instruction::AShr:
3127 if (!BO0->isExact() || !BO1->isExact())
3128 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003129 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003130
Sanjay Patel10494b22016-09-16 16:10:22 +00003131 case Instruction::Shl: {
3132 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3133 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3134 if (!NUW && !NSW)
3135 break;
3136 if (!NSW && I.isSigned())
3137 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003138 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003139 }
3140 }
3141 }
3142
3143 if (BO0) {
3144 // Transform A & (L - 1) `ult` L --> L != 0
3145 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003146 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003147
Sanjay Patel2a062632017-05-08 16:33:42 +00003148 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003149 auto *Zero = Constant::getNullValue(BO0->getType());
3150 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3151 }
3152 }
3153
3154 return nullptr;
3155}
3156
Sanjay Pateldd46b522016-12-19 17:32:37 +00003157/// Fold icmp Pred min|max(X, Y), X.
3158static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003159 ICmpInst::Predicate Pred = Cmp.getPredicate();
3160 Value *Op0 = Cmp.getOperand(0);
3161 Value *X = Cmp.getOperand(1);
3162
Sanjay Pateldd46b522016-12-19 17:32:37 +00003163 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003164 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00003165 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
3166 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
3167 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00003168 std::swap(Op0, X);
3169 Pred = Cmp.getSwappedPredicate();
3170 }
3171
3172 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003173 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003174 // smin(X, Y) == X --> X s<= Y
3175 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003176 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
3177 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
3178
Sanjay Pateldd46b522016-12-19 17:32:37 +00003179 // smin(X, Y) != X --> X s> Y
3180 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003181 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
3182 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
3183
3184 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003185 // smin(X, Y) s<= X --> true
3186 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00003187 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003188 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00003189
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003190 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00003191 // smax(X, Y) == X --> X s>= Y
3192 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003193 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
3194 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003195
Sanjay Pateldd46b522016-12-19 17:32:37 +00003196 // smax(X, Y) != X --> X s< Y
3197 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003198 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
3199 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00003200
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003201 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00003202 // smax(X, Y) s>= X --> true
3203 // smax(X, Y) s< X --> false
3204 return nullptr;
3205 }
3206
3207 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
3208 // umin(X, Y) == X --> X u<= Y
3209 // umin(X, Y) u>= X --> X u<= Y
3210 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
3211 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
3212
3213 // umin(X, Y) != X --> X u> Y
3214 // umin(X, Y) u< X --> X u> Y
3215 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
3216 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
3217
3218 // These cases should be handled in InstSimplify:
3219 // umin(X, Y) u<= X --> true
3220 // umin(X, Y) u> X --> false
3221 return nullptr;
3222 }
3223
3224 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
3225 // umax(X, Y) == X --> X u>= Y
3226 // umax(X, Y) u<= X --> X u>= Y
3227 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
3228 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
3229
3230 // umax(X, Y) != X --> X u< Y
3231 // umax(X, Y) u> X --> X u< Y
3232 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
3233 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
3234
3235 // These cases should be handled in InstSimplify:
3236 // umax(X, Y) u>= X --> true
3237 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00003238 return nullptr;
3239 }
Sanjay Pateld6406412016-12-15 19:13:37 +00003240
Sanjay Pateld6406412016-12-15 19:13:37 +00003241 return nullptr;
3242}
3243
Sanjay Patel10494b22016-09-16 16:10:22 +00003244Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
3245 if (!I.isEquality())
3246 return nullptr;
3247
3248 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003249 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00003250 Value *A, *B, *C, *D;
3251 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
3252 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
3253 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003254 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003255 }
3256
3257 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
3258 // A^c1 == C^c2 --> A == C^(c1^c2)
3259 ConstantInt *C1, *C2;
3260 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
3261 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003262 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
3263 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00003264 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00003265 }
3266
3267 // A^B == A^D -> B == D
3268 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003269 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003270 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003271 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003272 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003273 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00003274 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00003275 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00003276 }
3277 }
3278
3279 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
3280 // A == (A^B) -> B == 0
3281 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00003282 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003283 }
3284
3285 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
3286 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
3287 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
3288 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
3289
3290 if (A == C) {
3291 X = B;
3292 Y = D;
3293 Z = A;
3294 } else if (A == D) {
3295 X = B;
3296 Y = C;
3297 Z = A;
3298 } else if (B == C) {
3299 X = A;
3300 Y = D;
3301 Z = B;
3302 } else if (B == D) {
3303 X = A;
3304 Y = C;
3305 Z = B;
3306 }
3307
3308 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00003309 Op1 = Builder.CreateXor(X, Y);
3310 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00003311 I.setOperand(0, Op1);
3312 I.setOperand(1, Constant::getNullValue(Op1->getType()));
3313 return &I;
3314 }
3315 }
3316
3317 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
3318 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
3319 ConstantInt *Cst1;
3320 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
3321 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
3322 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
3323 match(Op1, m_ZExt(m_Value(A))))) {
3324 APInt Pow2 = Cst1->getValue() + 1;
3325 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
3326 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00003327 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003328 }
3329
3330 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
3331 // For lshr and ashr pairs.
3332 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3333 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
3334 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
3335 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
3336 unsigned TypeBits = Cst1->getBitWidth();
3337 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3338 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00003339 ICmpInst::Predicate NewPred =
3340 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00003341 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003342 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003343 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00003344 }
3345 }
3346
3347 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
3348 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
3349 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
3350 unsigned TypeBits = Cst1->getBitWidth();
3351 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
3352 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003353 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00003354 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00003355 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00003356 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00003357 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00003358 }
3359 }
3360
3361 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
3362 // "icmp (and X, mask), cst"
3363 uint64_t ShAmt = 0;
3364 if (Op0->hasOneUse() &&
3365 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
3366 match(Op1, m_ConstantInt(Cst1)) &&
3367 // Only do this when A has multiple uses. This is most important to do
3368 // when it exposes other optimizations.
3369 !A->hasOneUse()) {
3370 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
3371
3372 if (ShAmt < ASize) {
3373 APInt MaskV =
3374 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
3375 MaskV <<= ShAmt;
3376
3377 APInt CmpV = Cst1->getValue().zext(ASize);
3378 CmpV <<= ShAmt;
3379
Craig Topperbb4069e2017-07-07 23:16:26 +00003380 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
3381 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00003382 }
3383 }
3384
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003385 // If both operands are byte-swapped or bit-reversed, just compare the
3386 // original values.
3387 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
3388 // and handle more intrinsics.
3389 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00003390 (match(Op0, m_BitReverse(m_Value(A))) &&
3391 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00003392 return new ICmpInst(Pred, A, B);
3393
Sanjay Patel10494b22016-09-16 16:10:22 +00003394 return nullptr;
3395}
3396
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003397/// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so
3398/// far.
Sanjay Patel43395062016-07-21 18:07:40 +00003399Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) {
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003400 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +00003401 Value *LHSCIOp = LHSCI->getOperand(0);
Chris Lattner229907c2011-07-18 04:54:35 +00003402 Type *SrcTy = LHSCIOp->getType();
3403 Type *DestTy = LHSCI->getType();
Chris Lattner2188e402010-01-04 07:37:31 +00003404 Value *RHSCIOp;
3405
Jim Grosbach129c52a2011-09-30 18:09:53 +00003406 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00003407 // integer type is the same size as the pointer type.
Mehdi Aminia28d91d2015-03-10 02:37:25 +00003408 if (LHSCI->getOpcode() == Instruction::PtrToInt &&
3409 DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth()) {
Craig Topperf40110f2014-04-25 05:29:35 +00003410 Value *RHSOp = nullptr;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003411 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
Michael Liaod266b922015-02-13 04:51:26 +00003412 Value *RHSCIOp = RHSC->getOperand(0);
3413 if (RHSCIOp->getType()->getPointerAddressSpace() ==
3414 LHSCIOp->getType()->getPointerAddressSpace()) {
3415 RHSOp = RHSC->getOperand(0);
3416 // If the pointer types don't match, insert a bitcast.
3417 if (LHSCIOp->getType() != RHSOp->getType())
Craig Topperbb4069e2017-07-07 23:16:26 +00003418 RHSOp = Builder.CreateBitCast(RHSOp, LHSCIOp->getType());
Michael Liaod266b922015-02-13 04:51:26 +00003419 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003420 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003421 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003422 }
Chris Lattner2188e402010-01-04 07:37:31 +00003423
3424 if (RHSOp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003425 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003426 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00003427
Chris Lattner2188e402010-01-04 07:37:31 +00003428 // The code below only handles extension cast instructions, so far.
3429 // Enforce this.
3430 if (LHSCI->getOpcode() != Instruction::ZExt &&
3431 LHSCI->getOpcode() != Instruction::SExt)
Craig Topperf40110f2014-04-25 05:29:35 +00003432 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003433
3434 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt;
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003435 bool isSignedCmp = ICmp.isSigned();
Chris Lattner2188e402010-01-04 07:37:31 +00003436
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003437 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00003438 // Not an extension from the same type?
3439 RHSCIOp = CI->getOperand(0);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003440 if (RHSCIOp->getType() != LHSCIOp->getType())
Craig Topperf40110f2014-04-25 05:29:35 +00003441 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +00003442
Chris Lattner2188e402010-01-04 07:37:31 +00003443 // If the signedness of the two casts doesn't agree (i.e. one is a sext
3444 // and the other is a zext), then we can't handle this.
3445 if (CI->getOpcode() != LHSCI->getOpcode())
Craig Topperf40110f2014-04-25 05:29:35 +00003446 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003447
3448 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003449 if (ICmp.isEquality())
3450 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003451
3452 // A signed comparison of sign extended values simplifies into a
3453 // signed comparison.
3454 if (isSignedCmp && isSignedExt)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003455 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003456
3457 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003458 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp);
Chris Lattner2188e402010-01-04 07:37:31 +00003459 }
3460
Sanjay Patel4c204232016-06-04 20:39:22 +00003461 // If we aren't dealing with a constant on the RHS, exit early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003462 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
3463 if (!C)
Craig Topperf40110f2014-04-25 05:29:35 +00003464 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003465
3466 // Compute the constant that would happen if we truncated to SrcTy then
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003467 // re-extended to DestTy.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003468 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
Sanjay Patelc774f8c2016-06-04 21:20:44 +00003469 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy);
Chris Lattner2188e402010-01-04 07:37:31 +00003470
3471 // If the re-extended constant didn't change...
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003472 if (Res2 == C) {
Chris Lattner2188e402010-01-04 07:37:31 +00003473 // Deal with equality cases early.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003474 if (ICmp.isEquality())
3475 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003476
3477 // A signed comparison of sign extended values simplifies into a
3478 // signed comparison.
3479 if (isSignedExt && isSignedCmp)
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003480 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003481
3482 // The other three cases all fold into an unsigned comparison.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003483 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1);
Chris Lattner2188e402010-01-04 07:37:31 +00003484 }
3485
Sanjay Patel6a333c32016-06-06 16:56:57 +00003486 // The re-extended constant changed, partly changed (in the case of a vector),
3487 // or could not be determined to be equal (in the case of a constant
3488 // expression), so the constant cannot be represented in the shorter type.
3489 // Consequently, we cannot emit a simple comparison.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003490 // All the cases that fold to true or false will have already been handled
3491 // by SimplifyICmpInst, so only deal with the tricky case.
Chris Lattner2188e402010-01-04 07:37:31 +00003492
Sanjay Patel6a333c32016-06-06 16:56:57 +00003493 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C))
Craig Topperf40110f2014-04-25 05:29:35 +00003494 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003495
3496 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases
3497 // should have been folded away previously and not enter in here.
Duncan Sands8fb2c382011-01-20 13:21:55 +00003498
3499 // We're performing an unsigned comp with a sign extended value.
3500 // This is true if the input is >= 0. [aka >s -1]
3501 Constant *NegOne = Constant::getAllOnesValue(SrcTy);
Craig Topperbb4069e2017-07-07 23:16:26 +00003502 Value *Result = Builder.CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName());
Chris Lattner2188e402010-01-04 07:37:31 +00003503
3504 // Finally, return the value computed.
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003505 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
3506 return replaceInstUsesWith(ICmp, Result);
Chris Lattner2188e402010-01-04 07:37:31 +00003507
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00003508 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
Chris Lattner2188e402010-01-04 07:37:31 +00003509 return BinaryOperator::CreateNot(Result);
3510}
3511
Sanjoy Dasb0984472015-04-08 04:27:22 +00003512bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS,
3513 Value *RHS, Instruction &OrigI,
3514 Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00003515 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
3516 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003517
3518 auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) {
3519 Result = OpResult;
3520 Overflow = OverflowVal;
3521 if (ReuseName)
3522 Result->takeName(&OrigI);
3523 return true;
3524 };
3525
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003526 // If the overflow check was an add followed by a compare, the insertion point
3527 // may be pointing to the compare. We want to insert the new instructions
3528 // before the add in case there are uses of the add between the add and the
3529 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00003530 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00003531
Sanjoy Dasb0984472015-04-08 04:27:22 +00003532 switch (OCF) {
3533 case OCF_INVALID:
3534 llvm_unreachable("bad overflow check kind!");
3535
3536 case OCF_UNSIGNED_ADD: {
3537 OverflowResult OR = computeOverflowForUnsignedAdd(LHS, RHS, &OrigI);
3538 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003539 return SetResult(Builder.CreateNUWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003540 true);
3541
3542 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003543 return SetResult(Builder.CreateAdd(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003544
3545 // Fall through uadd into sadd
3546 LLVM_FALLTHROUGH;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003547 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003548 case OCF_SIGNED_ADD: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003549 // X + 0 -> {X, false}
3550 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003551 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003552
3553 // We can strength reduce this signed add into a regular add if we can prove
3554 // that it will never overflow.
3555 if (OCF == OCF_SIGNED_ADD)
Craig Topper2b1fc322017-05-22 06:25:31 +00003556 if (willNotOverflowSignedAdd(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003557 return SetResult(Builder.CreateNSWAdd(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003558 true);
Sanjoy Das72cb5e12015-06-05 18:04:42 +00003559 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003560 }
3561
3562 case OCF_UNSIGNED_SUB:
3563 case OCF_SIGNED_SUB: {
David Majnemer27e89ba2015-05-21 23:04:21 +00003564 // X - 0 -> {X, false}
3565 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003566 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003567
3568 if (OCF == OCF_SIGNED_SUB) {
Craig Topper2b1fc322017-05-22 06:25:31 +00003569 if (willNotOverflowSignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003570 return SetResult(Builder.CreateNSWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003571 true);
3572 } else {
Craig Topper2b1fc322017-05-22 06:25:31 +00003573 if (willNotOverflowUnsignedSub(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003574 return SetResult(Builder.CreateNUWSub(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003575 true);
3576 }
3577 break;
3578 }
3579
3580 case OCF_UNSIGNED_MUL: {
3581 OverflowResult OR = computeOverflowForUnsignedMul(LHS, RHS, &OrigI);
3582 if (OR == OverflowResult::NeverOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003583 return SetResult(Builder.CreateNUWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003584 true);
3585 if (OR == OverflowResult::AlwaysOverflows)
Craig Topperbb4069e2017-07-07 23:16:26 +00003586 return SetResult(Builder.CreateMul(LHS, RHS), Builder.getTrue(), true);
Justin Bognercd1d5aa2016-08-17 20:30:52 +00003587 LLVM_FALLTHROUGH;
3588 }
Sanjoy Dasb0984472015-04-08 04:27:22 +00003589 case OCF_SIGNED_MUL:
3590 // X * undef -> undef
3591 if (isa<UndefValue>(RHS))
Craig Topperbb4069e2017-07-07 23:16:26 +00003592 return SetResult(RHS, UndefValue::get(Builder.getInt1Ty()), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003593
David Majnemer27e89ba2015-05-21 23:04:21 +00003594 // X * 0 -> {0, false}
3595 if (match(RHS, m_Zero()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003596 return SetResult(RHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003597
David Majnemer27e89ba2015-05-21 23:04:21 +00003598 // X * 1 -> {X, false}
3599 if (match(RHS, m_One()))
Craig Topperbb4069e2017-07-07 23:16:26 +00003600 return SetResult(LHS, Builder.getFalse(), false);
Sanjoy Dasb0984472015-04-08 04:27:22 +00003601
3602 if (OCF == OCF_SIGNED_MUL)
Craig Topper2b1fc322017-05-22 06:25:31 +00003603 if (willNotOverflowSignedMul(LHS, RHS, OrigI))
Craig Topperbb4069e2017-07-07 23:16:26 +00003604 return SetResult(Builder.CreateNSWMul(LHS, RHS), Builder.getFalse(),
Sanjoy Dasb0984472015-04-08 04:27:22 +00003605 true);
Sanjoy Dasc80dad62015-06-05 18:04:46 +00003606 break;
Sanjoy Dasb0984472015-04-08 04:27:22 +00003607 }
3608
3609 return false;
3610}
3611
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003612/// \brief Recognize and process idiom involving test for multiplication
3613/// overflow.
3614///
3615/// The caller has matched a pattern of the form:
3616/// I = cmp u (mul(zext A, zext B), V
3617/// The function checks if this is a test for overflow and if so replaces
3618/// multiplication with call to 'mul.with.overflow' intrinsic.
3619///
3620/// \param I Compare instruction.
3621/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
3622/// the compare instruction. Must be of integer type.
3623/// \param OtherVal The other argument of compare instruction.
3624/// \returns Instruction which must replace the compare instruction, NULL if no
3625/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00003626static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003627 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00003628 // Don't bother doing this transformation for pointers, don't do it for
3629 // vectors.
3630 if (!isa<IntegerType>(MulVal->getType()))
3631 return nullptr;
3632
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003633 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
3634 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00003635 auto *MulInstr = dyn_cast<Instruction>(MulVal);
3636 if (!MulInstr)
3637 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003638 assert(MulInstr->getOpcode() == Instruction::Mul);
3639
David Majnemer634ca232014-11-01 23:46:05 +00003640 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
3641 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003642 assert(LHS->getOpcode() == Instruction::ZExt);
3643 assert(RHS->getOpcode() == Instruction::ZExt);
3644 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
3645
3646 // Calculate type and width of the result produced by mul.with.overflow.
3647 Type *TyA = A->getType(), *TyB = B->getType();
3648 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
3649 WidthB = TyB->getPrimitiveSizeInBits();
3650 unsigned MulWidth;
3651 Type *MulType;
3652 if (WidthB > WidthA) {
3653 MulWidth = WidthB;
3654 MulType = TyB;
3655 } else {
3656 MulWidth = WidthA;
3657 MulType = TyA;
3658 }
3659
3660 // In order to replace the original mul with a narrower mul.with.overflow,
3661 // all uses must ignore upper bits of the product. The number of used low
3662 // bits must be not greater than the width of mul.with.overflow.
3663 if (MulVal->hasNUsesOrMore(2))
3664 for (User *U : MulVal->users()) {
3665 if (U == &I)
3666 continue;
3667 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3668 // Check if truncation ignores bits above MulWidth.
3669 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
3670 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003671 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003672 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3673 // Check if AND ignores bits above MulWidth.
3674 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00003675 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003676 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
3677 const APInt &CVal = CI->getValue();
3678 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00003679 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00003680 } else {
3681 // In this case we could have the operand of the binary operation
3682 // being defined in another block, and performing the replacement
3683 // could break the dominance relation.
3684 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003685 }
3686 } else {
3687 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00003688 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003689 }
3690 }
3691
3692 // Recognize patterns
3693 switch (I.getPredicate()) {
3694 case ICmpInst::ICMP_EQ:
3695 case ICmpInst::ICMP_NE:
3696 // Recognize pattern:
3697 // mulval = mul(zext A, zext B)
3698 // cmp eq/neq mulval, zext trunc mulval
3699 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
3700 if (Zext->hasOneUse()) {
3701 Value *ZextArg = Zext->getOperand(0);
3702 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
3703 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
3704 break; //Recognized
3705 }
3706
3707 // Recognize pattern:
3708 // mulval = mul(zext A, zext B)
3709 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
3710 ConstantInt *CI;
3711 Value *ValToMask;
3712 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
3713 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00003714 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003715 const APInt &CVal = CI->getValue() + 1;
3716 if (CVal.isPowerOf2()) {
3717 unsigned MaskWidth = CVal.logBase2();
3718 if (MaskWidth == MulWidth)
3719 break; // Recognized
3720 }
3721 }
Craig Topperf40110f2014-04-25 05:29:35 +00003722 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003723
3724 case ICmpInst::ICMP_UGT:
3725 // Recognize pattern:
3726 // mulval = mul(zext A, zext B)
3727 // cmp ugt mulval, max
3728 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3729 APInt MaxVal = APInt::getMaxValue(MulWidth);
3730 MaxVal = MaxVal.zext(CI->getBitWidth());
3731 if (MaxVal.eq(CI->getValue()))
3732 break; // Recognized
3733 }
Craig Topperf40110f2014-04-25 05:29:35 +00003734 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003735
3736 case ICmpInst::ICMP_UGE:
3737 // Recognize pattern:
3738 // mulval = mul(zext A, zext B)
3739 // cmp uge mulval, max+1
3740 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3741 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
3742 if (MaxVal.eq(CI->getValue()))
3743 break; // Recognized
3744 }
Craig Topperf40110f2014-04-25 05:29:35 +00003745 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003746
3747 case ICmpInst::ICMP_ULE:
3748 // Recognize pattern:
3749 // mulval = mul(zext A, zext B)
3750 // cmp ule mulval, max
3751 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
3752 APInt MaxVal = APInt::getMaxValue(MulWidth);
3753 MaxVal = MaxVal.zext(CI->getBitWidth());
3754 if (MaxVal.eq(CI->getValue()))
3755 break; // Recognized
3756 }
Craig Topperf40110f2014-04-25 05:29:35 +00003757 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003758
3759 case ICmpInst::ICMP_ULT:
3760 // Recognize pattern:
3761 // mulval = mul(zext A, zext B)
3762 // cmp ule mulval, max + 1
3763 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00003764 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003765 if (MaxVal.eq(CI->getValue()))
3766 break; // Recognized
3767 }
Craig Topperf40110f2014-04-25 05:29:35 +00003768 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003769
3770 default:
Craig Topperf40110f2014-04-25 05:29:35 +00003771 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003772 }
3773
Craig Topperbb4069e2017-07-07 23:16:26 +00003774 InstCombiner::BuilderTy &Builder = IC.Builder;
3775 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003776
3777 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
3778 Value *MulA = A, *MulB = B;
3779 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00003780 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003781 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00003782 MulB = Builder.CreateZExt(B, MulType);
Sanjay Patelaf674fb2015-12-14 17:24:23 +00003783 Value *F = Intrinsic::getDeclaration(I.getModule(),
3784 Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00003785 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003786 IC.Worklist.Add(MulInstr);
3787
3788 // If there are uses of mul result other than the comparison, we know that
3789 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00003790 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003791 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003792 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003793 for (User *U : MulVal->users()) {
3794 if (U == &I || U == OtherVal)
3795 continue;
3796 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
3797 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00003798 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003799 else
3800 TI->setOperand(0, Mul);
3801 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
3802 assert(BO->getOpcode() == Instruction::And);
3803 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00003804 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
3805 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00003806 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00003807 Instruction *Zext =
3808 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
3809 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00003810 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003811 } else {
3812 llvm_unreachable("Unexpected Binary operation");
3813 }
Davide Italiano579064e2017-07-16 18:56:30 +00003814 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003815 }
3816 }
3817 if (isa<Instruction>(OtherVal))
3818 IC.Worklist.Add(cast<Instruction>(OtherVal));
3819
3820 // The original icmp gets replaced with the overflow value, maybe inverted
3821 // depending on predicate.
3822 bool Inverse = false;
3823 switch (I.getPredicate()) {
3824 case ICmpInst::ICMP_NE:
3825 break;
3826 case ICmpInst::ICMP_EQ:
3827 Inverse = true;
3828 break;
3829 case ICmpInst::ICMP_UGT:
3830 case ICmpInst::ICMP_UGE:
3831 if (I.getOperand(0) == MulVal)
3832 break;
3833 Inverse = true;
3834 break;
3835 case ICmpInst::ICMP_ULT:
3836 case ICmpInst::ICMP_ULE:
3837 if (I.getOperand(1) == MulVal)
3838 break;
3839 Inverse = true;
3840 break;
3841 default:
3842 llvm_unreachable("Unexpected predicate");
3843 }
3844 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003845 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00003846 return BinaryOperator::CreateNot(Res);
3847 }
3848
3849 return ExtractValueInst::Create(Call, 1);
3850}
3851
Sanjay Patel5f0217f2016-06-05 16:46:18 +00003852/// When performing a comparison against a constant, it is possible that not all
3853/// the bits in the LHS are demanded. This helper method computes the mask that
3854/// IS demanded.
Craig Topper3edda872017-09-22 18:57:23 +00003855static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) {
Craig Topper18887bf2017-09-20 23:48:58 +00003856 const APInt *RHS;
3857 if (!match(I.getOperand(1), m_APInt(RHS)))
3858 return APInt::getAllOnesValue(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00003859
Craig Topper3edda872017-09-22 18:57:23 +00003860 // If this is a normal comparison, it demands all bits. If it is a sign bit
3861 // comparison, it only demands the sign bit.
3862 bool UnusedBit;
3863 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit))
3864 return APInt::getSignMask(BitWidth);
3865
Owen Andersond490c2d2011-01-11 00:36:45 +00003866 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00003867 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00003868 // correspond to the trailing ones of the comparand. The value of these
3869 // bits doesn't impact the outcome of the comparison, because any value
3870 // greater than the RHS must differ in a bit higher than these due to carry.
Craig Topper18887bf2017-09-20 23:48:58 +00003871 case ICmpInst::ICMP_UGT:
3872 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes());
Jim Grosbach129c52a2011-09-30 18:09:53 +00003873
Owen Andersond490c2d2011-01-11 00:36:45 +00003874 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
3875 // Any value less than the RHS must differ in a higher bit because of carries.
Craig Topper18887bf2017-09-20 23:48:58 +00003876 case ICmpInst::ICMP_ULT:
3877 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros());
Jim Grosbach129c52a2011-09-30 18:09:53 +00003878
Owen Andersond490c2d2011-01-11 00:36:45 +00003879 default:
3880 return APInt::getAllOnesValue(BitWidth);
3881 }
Owen Andersond490c2d2011-01-11 00:36:45 +00003882}
Chris Lattner2188e402010-01-04 07:37:31 +00003883
Quentin Colombet5ab55552013-09-09 20:56:48 +00003884/// \brief Check if the order of \p Op0 and \p Op1 as operand in an ICmpInst
3885/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00003886/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00003887/// as subtract operands and their positions in those instructions.
3888/// The rational is that several architectures use the same instruction for
3889/// both subtract and cmp, thus it is better if the order of those operands
3890/// match.
3891/// \return true if Op0 and Op1 should be swapped.
3892static bool swapMayExposeCSEOpportunities(const Value * Op0,
3893 const Value * Op1) {
3894 // Filter out pointer value as those cannot appears directly in subtract.
3895 // FIXME: we may want to go through inttoptrs or bitcasts.
3896 if (Op0->getType()->isPointerTy())
3897 return false;
3898 // Count every uses of both Op0 and Op1 in a subtract.
3899 // Each time Op0 is the first operand, count -1: swapping is bad, the
3900 // subtract has already the same layout as the compare.
3901 // Each time Op0 is the second operand, count +1: swapping is good, the
Alp Tokercb402912014-01-24 17:20:08 +00003902 // subtract has a different layout as the compare.
Quentin Colombet5ab55552013-09-09 20:56:48 +00003903 // At the end, if the benefit is greater than 0, Op0 should come second to
3904 // expose more CSE opportunities.
3905 int GlobalSwapBenefits = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00003906 for (const User *U : Op0->users()) {
3907 const BinaryOperator *BinOp = dyn_cast<BinaryOperator>(U);
Quentin Colombet5ab55552013-09-09 20:56:48 +00003908 if (!BinOp || BinOp->getOpcode() != Instruction::Sub)
3909 continue;
3910 // If Op0 is the first argument, this is not beneficial to swap the
3911 // arguments.
3912 int LocalSwapBenefits = -1;
3913 unsigned Op1Idx = 1;
3914 if (BinOp->getOperand(Op1Idx) == Op0) {
3915 Op1Idx = 0;
3916 LocalSwapBenefits = 1;
3917 }
3918 if (BinOp->getOperand(Op1Idx) != Op1)
3919 continue;
3920 GlobalSwapBenefits += LocalSwapBenefits;
3921 }
3922 return GlobalSwapBenefits > 0;
3923}
3924
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003925/// \brief Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00003926/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003927///
3928/// \param DI Definition
3929/// \param UI Use
3930/// \param DB Block that must dominate all uses of \p DI outside
3931/// the parent block
3932/// \return true when \p UI is the only use of \p DI in the parent block
3933/// and all other uses of \p DI are in blocks dominated by \p DB.
3934///
3935bool InstCombiner::dominatesAllUses(const Instruction *DI,
3936 const Instruction *UI,
3937 const BasicBlock *DB) const {
3938 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00003939 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003940 if (!DI->getParent())
3941 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00003942 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003943 if (DI->getParent() != UI->getParent())
3944 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00003945 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003946 if (DI->getParent() == DB)
3947 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003948 for (const User *U : DI->users()) {
3949 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00003950 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003951 return false;
3952 }
3953 return true;
3954}
3955
Sanjay Patel5f0217f2016-06-05 16:46:18 +00003956/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003957static bool isChainSelectCmpBranch(const SelectInst *SI) {
3958 const BasicBlock *BB = SI->getParent();
3959 if (!BB)
3960 return false;
3961 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
3962 if (!BI || BI->getNumSuccessors() != 2)
3963 return false;
3964 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
3965 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
3966 return false;
3967 return true;
3968}
3969
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00003970/// \brief True when a select result is replaced by one of its operands
3971/// in select-icmp sequence. This will eventually result in the elimination
3972/// of the select.
3973///
3974/// \param SI Select instruction
3975/// \param Icmp Compare instruction
3976/// \param SIOpd Operand that replaces the select
3977///
3978/// Notes:
3979/// - The replacement is global and requires dominator information
3980/// - The caller is responsible for the actual replacement
3981///
3982/// Example:
3983///
3984/// entry:
3985/// %4 = select i1 %3, %C* %0, %C* null
3986/// %5 = icmp eq %C* %4, null
3987/// br i1 %5, label %9, label %7
3988/// ...
3989/// ; <label>:7 ; preds = %entry
3990/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
3991/// ...
3992///
3993/// can be transformed to
3994///
3995/// %5 = icmp eq %C* %0, null
3996/// %6 = select i1 %3, i1 %5, i1 true
3997/// br i1 %6, label %9, label %7
3998/// ...
3999/// ; <label>:7 ; preds = %entry
4000/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4001///
4002/// Similar when the first operand of the select is a constant or/and
4003/// the compare is for not equal rather than equal.
4004///
4005/// NOTE: The function is only called when the select and compare constants
4006/// are equal, the optimization can work only for EQ predicates. This is not a
4007/// major restriction since a NE compare should be 'normalized' to an equal
4008/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004009/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004010bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4011 const ICmpInst *Icmp,
4012 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004013 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004014 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4015 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004016 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004017 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004018 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4019 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4020 // replaced can be reached on either path. So the uniqueness check
4021 // guarantees that the path all uses of SI (outside SI's parent) are on
4022 // is disjoint from all other paths out of SI. But that information
4023 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004024 // of compile-time. It should also be noticed that we check for a single
4025 // predecessor and not only uniqueness. This to handle the situation when
4026 // Succ and Succ1 points to the same basic block.
4027 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004028 NumSel++;
4029 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4030 return true;
4031 }
4032 }
4033 return false;
4034}
4035
Sanjay Patel3151dec2016-09-12 15:24:31 +00004036/// Try to fold the comparison based on range information we can get by checking
4037/// whether bits are known to be zero or one in the inputs.
4038Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4039 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4040 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004041 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004042
4043 // Get scalar or pointer size.
4044 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4045 ? Ty->getScalarSizeInBits()
4046 : DL.getTypeSizeInBits(Ty->getScalarType());
4047
4048 if (!BitWidth)
4049 return nullptr;
4050
Craig Topperb45eabc2017-04-26 16:39:58 +00004051 KnownBits Op0Known(BitWidth);
4052 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004053
Craig Topper47596dd2017-03-25 06:52:52 +00004054 if (SimplifyDemandedBits(&I, 0,
Craig Topper3edda872017-09-22 18:57:23 +00004055 getDemandedBitsLHSMask(I, BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004056 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004057 return &I;
4058
Craig Topper47596dd2017-03-25 06:52:52 +00004059 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004060 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004061 return &I;
4062
4063 // Given the known and unknown bits, compute a range that the LHS could be
4064 // in. Compute the Min, Max and RHS values based on the known bits. For the
4065 // EQ and NE we use unsigned values.
4066 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4067 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4068 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004069 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4070 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004071 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004072 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4073 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004074 }
4075
4076 // If Min and Max are known to be the same, then SimplifyDemandedBits
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004077 // figured out that the LHS is a constant. Constant fold this now, so that
4078 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004079 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004080 return new ICmpInst(Pred, ConstantInt::get(Op0->getType(), Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004081 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004082 return new ICmpInst(Pred, Op0, ConstantInt::get(Op1->getType(), Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004083
4084 // Based on the range information we know about the LHS, see if we can
4085 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004086 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004087 default:
4088 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004089 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004090 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004091 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4092 return Pred == CmpInst::ICMP_EQ
4093 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4094 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4095 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004096
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004097 // If all bits are known zero except for one, then we know at most one bit
4098 // is set. If the comparison is against zero, then this is a check to see if
4099 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004100 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004101 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004102 // If the LHS is an AND with the same constant, look through it.
4103 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004104 const APInt *LHSC;
4105 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4106 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004107 LHS = Op0;
4108
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004109 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004110 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4111 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004112 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004113 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004114 // ((1 << X) & 8) == 0 -> X != 3
4115 // ((1 << X) & 8) != 0 -> X == 3
4116 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4117 auto NewPred = ICmpInst::getInversePredicate(Pred);
4118 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004119 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004120 // ((1 << X) & 7) == 0 -> X >= 3
4121 // ((1 << X) & 7) != 0 -> X < 3
4122 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4123 auto NewPred =
4124 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4125 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004126 }
4127 }
4128
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004129 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004130 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004131 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004132 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4133 // ((8 >>u X) & 1) == 0 -> X != 3
4134 // ((8 >>u X) & 1) != 0 -> X == 3
4135 unsigned CmpVal = CI->countTrailingZeros();
4136 auto NewPred = ICmpInst::getInversePredicate(Pred);
4137 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4138 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004139 }
4140 break;
4141 }
4142 case ICmpInst::ICMP_ULT: {
4143 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
4144 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4145 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
4146 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4147 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
4148 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4149
Craig Topper0cd25942017-09-27 22:57:18 +00004150 const APInt *CmpC;
4151 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004152 // A <u C -> A == C-1 if min(A)+1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004153 if (*CmpC == Op0Min + 1)
Craig Topper2c9b7d72017-09-22 18:57:20 +00004154 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004155 ConstantInt::get(Op1->getType(), *CmpC - 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004156 // X <u C --> X == 0, if the number of zero bits in the bottom of X
4157 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004158 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2())
Craig Topper30dc9792017-09-25 21:15:00 +00004159 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
4160 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004161 }
4162 break;
4163 }
4164 case ICmpInst::ICMP_UGT: {
4165 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
4166 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004167 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
4168 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004169 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
4170 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
4171
Craig Topper0cd25942017-09-27 22:57:18 +00004172 const APInt *CmpC;
4173 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004174 // A >u C -> A == C+1 if max(a)-1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00004175 if (*CmpC == Op0Max - 1)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004176 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004177 ConstantInt::get(Op1->getType(), *CmpC + 1));
Craig Topper30dc9792017-09-25 21:15:00 +00004178 // X >u C --> X != 0, if the number of zero bits in the bottom of X
4179 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00004180 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits())
Craig Topper30dc9792017-09-25 21:15:00 +00004181 return new ICmpInst(ICmpInst::ICMP_NE, Op0,
4182 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004183 }
4184 break;
4185 }
Craig Topper0cd25942017-09-27 22:57:18 +00004186 case ICmpInst::ICMP_SLT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004187 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
4188 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4189 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
4190 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
4191 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
4192 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004193 const APInt *CmpC;
4194 if (match(Op1, m_APInt(CmpC))) {
4195 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004196 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004197 ConstantInt::get(Op1->getType(), *CmpC - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004198 }
4199 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004200 }
4201 case ICmpInst::ICMP_SGT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004202 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
4203 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4204 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
4205 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004206 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
4207 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00004208 const APInt *CmpC;
4209 if (match(Op1, m_APInt(CmpC))) {
4210 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00004211 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00004212 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004213 }
4214 break;
Craig Topper0cd25942017-09-27 22:57:18 +00004215 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004216 case ICmpInst::ICMP_SGE:
4217 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
4218 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
4219 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4220 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
4221 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004222 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B)
4223 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004224 break;
4225 case ICmpInst::ICMP_SLE:
4226 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
4227 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
4228 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4229 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
4230 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004231 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B)
4232 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004233 break;
4234 case ICmpInst::ICMP_UGE:
4235 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
4236 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
4237 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4238 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
4239 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004240 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B)
4241 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004242 break;
4243 case ICmpInst::ICMP_ULE:
4244 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
4245 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
4246 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4247 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
4248 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00004249 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B)
4250 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004251 break;
4252 }
4253
4254 // Turn a signed comparison into an unsigned one if both operands are known to
4255 // have the same sign.
4256 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00004257 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
4258 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004259 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
4260
4261 return nullptr;
4262}
4263
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004264/// If we have an icmp le or icmp ge instruction with a constant operand, turn
4265/// it into the appropriate icmp lt or icmp gt instruction. This transform
4266/// allows them to be folded in visitICmpInst.
Sanjay Patele9b2c322016-05-17 00:57:57 +00004267static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
4268 ICmpInst::Predicate Pred = I.getPredicate();
4269 if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGE &&
4270 Pred != ICmpInst::ICMP_ULE && Pred != ICmpInst::ICMP_UGE)
4271 return nullptr;
4272
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004273 Value *Op0 = I.getOperand(0);
4274 Value *Op1 = I.getOperand(1);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004275 auto *Op1C = dyn_cast<Constant>(Op1);
4276 if (!Op1C)
4277 return nullptr;
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004278
Sanjay Patele9b2c322016-05-17 00:57:57 +00004279 // Check if the constant operand can be safely incremented/decremented without
4280 // overflowing/underflowing. For scalars, SimplifyICmpInst has already handled
4281 // the edge cases for us, so we just assert on them. For vectors, we must
4282 // handle the edge cases.
4283 Type *Op1Type = Op1->getType();
4284 bool IsSigned = I.isSigned();
4285 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE);
Sanjay Patel18254932016-05-17 01:12:31 +00004286 auto *CI = dyn_cast<ConstantInt>(Op1C);
4287 if (CI) {
Sanjay Patele9b2c322016-05-17 00:57:57 +00004288 // A <= MAX -> TRUE ; A >= MIN -> TRUE
4289 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned));
4290 } else if (Op1Type->isVectorTy()) {
Sanjay Patelb79ab272016-05-13 15:10:46 +00004291 // TODO? If the edge cases for vectors were guaranteed to be handled as they
Sanjay Patele9b2c322016-05-17 00:57:57 +00004292 // are for scalar, we could remove the min/max checks. However, to do that,
4293 // we would have to use insertelement/shufflevector to replace edge values.
4294 unsigned NumElts = Op1Type->getVectorNumElements();
4295 for (unsigned i = 0; i != NumElts; ++i) {
4296 Constant *Elt = Op1C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00004297 if (!Elt)
4298 return nullptr;
4299
Sanjay Patele9b2c322016-05-17 00:57:57 +00004300 if (isa<UndefValue>(Elt))
4301 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00004302
Sanjay Patele9b2c322016-05-17 00:57:57 +00004303 // Bail out if we can't determine if this constant is min/max or if we
4304 // know that this constant is min/max.
4305 auto *CI = dyn_cast<ConstantInt>(Elt);
4306 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned)))
4307 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004308 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00004309 } else {
4310 // ConstantExpr?
4311 return nullptr;
Sanjay Patelb79ab272016-05-13 15:10:46 +00004312 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004313
Sanjay Patele9b2c322016-05-17 00:57:57 +00004314 // Increment or decrement the constant and set the new comparison predicate:
4315 // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT
Sanjay Patel22b01fe2016-05-17 20:20:40 +00004316 Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true);
Sanjay Patele9b2c322016-05-17 00:57:57 +00004317 CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT;
4318 NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred;
4319 return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne));
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004320}
4321
Sanjay Patele5747e32017-05-17 22:15:07 +00004322/// Integer compare with boolean values can always be turned into bitwise ops.
4323static Instruction *canonicalizeICmpBool(ICmpInst &I,
4324 InstCombiner::BuilderTy &Builder) {
4325 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00004326 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00004327
Sanjay Patelba212c22017-05-17 22:29:40 +00004328 // A boolean compared to true/false can be simplified to Op0/true/false in
4329 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
4330 // Cases not handled by InstSimplify are always 'not' of Op0.
4331 if (match(B, m_Zero())) {
4332 switch (I.getPredicate()) {
4333 case CmpInst::ICMP_EQ: // A == 0 -> !A
4334 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
4335 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
4336 return BinaryOperator::CreateNot(A);
4337 default:
4338 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4339 }
4340 } else if (match(B, m_One())) {
4341 switch (I.getPredicate()) {
4342 case CmpInst::ICMP_NE: // A != 1 -> !A
4343 case CmpInst::ICMP_ULT: // A <u 1 -> !A
4344 case CmpInst::ICMP_SGT: // A >s -1 -> !A
4345 return BinaryOperator::CreateNot(A);
4346 default:
4347 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
4348 }
4349 }
4350
Sanjay Patele5747e32017-05-17 22:15:07 +00004351 switch (I.getPredicate()) {
4352 default:
4353 llvm_unreachable("Invalid icmp instruction!");
4354 case ICmpInst::ICMP_EQ:
4355 // icmp eq i1 A, B -> ~(A ^ B)
4356 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
4357
4358 case ICmpInst::ICMP_NE:
4359 // icmp ne i1 A, B -> A ^ B
4360 return BinaryOperator::CreateXor(A, B);
4361
4362 case ICmpInst::ICMP_UGT:
4363 // icmp ugt -> icmp ult
4364 std::swap(A, B);
4365 LLVM_FALLTHROUGH;
4366 case ICmpInst::ICMP_ULT:
4367 // icmp ult i1 A, B -> ~A & B
4368 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
4369
4370 case ICmpInst::ICMP_SGT:
4371 // icmp sgt -> icmp slt
4372 std::swap(A, B);
4373 LLVM_FALLTHROUGH;
4374 case ICmpInst::ICMP_SLT:
4375 // icmp slt i1 A, B -> A & ~B
4376 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
4377
4378 case ICmpInst::ICMP_UGE:
4379 // icmp uge -> icmp ule
4380 std::swap(A, B);
4381 LLVM_FALLTHROUGH;
4382 case ICmpInst::ICMP_ULE:
4383 // icmp ule i1 A, B -> ~A | B
4384 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
4385
4386 case ICmpInst::ICMP_SGE:
4387 // icmp sge -> icmp sle
4388 std::swap(A, B);
4389 LLVM_FALLTHROUGH;
4390 case ICmpInst::ICMP_SLE:
4391 // icmp sle i1 A, B -> A | ~B
4392 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
4393 }
4394}
4395
Chris Lattner2188e402010-01-04 07:37:31 +00004396Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
4397 bool Changed = false;
Chris Lattner9306ffa2010-02-01 19:54:45 +00004398 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00004399 unsigned Op0Cplxity = getComplexity(Op0);
4400 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004401
Chris Lattner2188e402010-01-04 07:37:31 +00004402 /// Orders the operands of the compare so that they are listed from most
4403 /// complex to least complex. This puts constants before unary operators,
4404 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004405 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00004406 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004407 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00004408 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00004409 Changed = true;
4410 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004411
Daniel Berlin2c75c632017-04-26 20:56:07 +00004412 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1,
4413 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004414 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004415
Uriel Korach18972232017-09-10 08:31:22 +00004416 // Comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00004417 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00004418 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004419 Value *Cond, *SelectTrue, *SelectFalse;
4420 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00004421 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00004422 if (Value *V = dyn_castNegVal(SelectTrue)) {
4423 if (V == SelectFalse)
4424 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
4425 }
4426 else if (Value *V = dyn_castNegVal(SelectFalse)) {
4427 if (V == SelectTrue)
4428 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00004429 }
4430 }
4431 }
4432
Craig Topperfde47232017-07-09 07:04:03 +00004433 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00004434 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00004435 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004436
Sanjay Patele9b2c322016-05-17 00:57:57 +00004437 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00004438 return NewICmp;
4439
Sanjay Patel06b127a2016-09-15 14:37:50 +00004440 if (Instruction *Res = foldICmpWithConstant(I))
4441 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004442
Sanjay Patel3151dec2016-09-12 15:24:31 +00004443 if (Instruction *Res = foldICmpUsingKnownBits(I))
4444 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004445
4446 // Test if the ICmpInst instruction is used exclusively by a select as
4447 // part of a minimum or maximum operation. If so, refrain from doing
4448 // any other folding. This helps out other analyses which understand
4449 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4450 // and CodeGen. And in this case, at least one of the comparison
4451 // operands has at least one user besides the compare (the select),
4452 // which would often largely negate the benefit of folding anyway.
4453 if (I.hasOneUse())
Chandler Carruthcdf47882014-03-09 03:16:01 +00004454 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin()))
Chris Lattner2188e402010-01-04 07:37:31 +00004455 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) ||
4456 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1))
Craig Topperf40110f2014-04-25 05:29:35 +00004457 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004458
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00004459 // FIXME: We only do this after checking for min/max to prevent infinite
4460 // looping caused by a reverse canonicalization of these patterns for min/max.
4461 // FIXME: The organization of folds is a mess. These would naturally go into
4462 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
4463 // down here after the min/max restriction.
4464 ICmpInst::Predicate Pred = I.getPredicate();
4465 const APInt *C;
4466 if (match(Op1, m_APInt(C))) {
4467 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
4468 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
4469 Constant *Zero = Constant::getNullValue(Op0->getType());
4470 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
4471 }
4472
4473 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
4474 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
4475 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
4476 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
4477 }
4478 }
4479
Sanjay Patelf58f68c2016-09-10 15:03:44 +00004480 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00004481 return Res;
4482
Sanjay Patel10494b22016-09-16 16:10:22 +00004483 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
4484 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00004485
4486 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
4487 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00004488 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00004489 return NI;
4490 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004491 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00004492 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
4493 return NI;
4494
Hans Wennborgf1f36512015-10-07 00:20:07 +00004495 // Try to optimize equality comparisons against alloca-based pointers.
4496 if (Op0->getType()->isPointerTy() && I.isEquality()) {
4497 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
4498 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004499 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004500 return New;
4501 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00004502 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00004503 return New;
4504 }
4505
Chris Lattner2188e402010-01-04 07:37:31 +00004506 // Test to see if the operands of the icmp are casted versions of other
4507 // values. If the ptr->ptr cast can be stripped off both arguments, we do so
4508 // now.
4509 if (BitCastInst *CI = dyn_cast<BitCastInst>(Op0)) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004510 if (Op0->getType()->isPointerTy() &&
4511 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00004512 // We keep moving the cast from the left operand over to the right
4513 // operand, where it can often be eliminated completely.
4514 Op0 = CI->getOperand(0);
4515
4516 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
4517 // so eliminate it as well.
4518 if (BitCastInst *CI2 = dyn_cast<BitCastInst>(Op1))
4519 Op1 = CI2->getOperand(0);
4520
4521 // If Op1 is a constant, we can fold the cast into the constant.
4522 if (Op0->getType() != Op1->getType()) {
4523 if (Constant *Op1C = dyn_cast<Constant>(Op1)) {
4524 Op1 = ConstantExpr::getBitCast(Op1C, Op0->getType());
4525 } else {
4526 // Otherwise, cast the RHS right before the icmp
Craig Topperbb4069e2017-07-07 23:16:26 +00004527 Op1 = Builder.CreateBitCast(Op1, Op0->getType());
Chris Lattner2188e402010-01-04 07:37:31 +00004528 }
4529 }
4530 return new ICmpInst(I.getPredicate(), Op0, Op1);
4531 }
4532 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004533
Chris Lattner2188e402010-01-04 07:37:31 +00004534 if (isa<CastInst>(Op0)) {
4535 // Handle the special case of: icmp (cast bool to X), <cst>
4536 // This comes up when you have code like
4537 // int X = A < B;
4538 // if (X) ...
4539 // For generality, we handle any zero-extension of any operand comparison
4540 // with a constant or another cast from the same type.
4541 if (isa<Constant>(Op1) || isa<CastInst>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00004542 if (Instruction *R = foldICmpWithCastAndCast(I))
Chris Lattner2188e402010-01-04 07:37:31 +00004543 return R;
4544 }
Chris Lattner2188e402010-01-04 07:37:31 +00004545
Sanjay Patel10494b22016-09-16 16:10:22 +00004546 if (Instruction *Res = foldICmpBinOp(I))
4547 return Res;
Duncan Sandse5220012011-02-17 07:46:37 +00004548
Sanjay Pateldd46b522016-12-19 17:32:37 +00004549 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00004550 return Res;
4551
Sanjay Patel10494b22016-09-16 16:10:22 +00004552 {
4553 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00004554 // Transform (A & ~B) == 0 --> (A & B) != 0
4555 // and (A & ~B) != 0 --> (A & B) == 0
4556 // if A is a power of 2.
4557 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00004558 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00004559 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00004560 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00004561 Op1);
4562
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004563 // ~X < ~Y --> Y < X
4564 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004565 if (match(Op0, m_Not(m_Value(A)))) {
4566 if (match(Op1, m_Not(m_Value(B))))
4567 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004568
Sanjay Patelce241f42017-06-02 16:29:41 +00004569 const APInt *C;
4570 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00004571 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00004572 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00004573 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00004574
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004575 Instruction *AddI = nullptr;
4576 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
4577 m_Instruction(AddI))) &&
4578 isa<IntegerType>(A->getType())) {
4579 Value *Result;
4580 Constant *Overflow;
4581 if (OptimizeOverflowCheck(OCF_UNSIGNED_ADD, A, B, *AddI, Result,
4582 Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00004583 replaceInstUsesWith(*AddI, Result);
4584 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00004585 }
4586 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004587
4588 // (zext a) * (zext b) --> llvm.umul.with.overflow.
4589 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004590 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004591 return R;
4592 }
4593 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004594 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004595 return R;
4596 }
Chris Lattner2188e402010-01-04 07:37:31 +00004597 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004598
Sanjay Patel10494b22016-09-16 16:10:22 +00004599 if (Instruction *Res = foldICmpEquality(I))
4600 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004601
David Majnemerc1eca5a2014-11-06 23:23:30 +00004602 // The 'cmpxchg' instruction returns an aggregate containing the old value and
4603 // an i1 which indicates whether or not we successfully did the swap.
4604 //
4605 // Replace comparisons between the old value and the expected value with the
4606 // indicator that 'cmpxchg' returns.
4607 //
4608 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
4609 // spuriously fail. In those cases, the old value may equal the expected
4610 // value but it is possible for the swap to not occur.
4611 if (I.getPredicate() == ICmpInst::ICMP_EQ)
4612 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
4613 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
4614 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
4615 !ACXI->isWeak())
4616 return ExtractValueInst::Create(ACXI, 1);
4617
Chris Lattner2188e402010-01-04 07:37:31 +00004618 {
4619 Value *X; ConstantInt *Cst;
4620 // icmp X+Cst, X
4621 if (match(Op0, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op1 == X)
Craig Toppera85f8622017-08-23 05:46:09 +00004622 return foldICmpAddOpConst(X, Cst, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004623
4624 // icmp X, X+Cst
4625 if (match(Op1, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op0 == X)
Craig Toppera85f8622017-08-23 05:46:09 +00004626 return foldICmpAddOpConst(X, Cst, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00004627 }
Craig Topperf40110f2014-04-25 05:29:35 +00004628 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004629}
4630
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004631/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00004632Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00004633 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00004634 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00004635 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00004636
Chris Lattner2188e402010-01-04 07:37:31 +00004637 // Get the width of the mantissa. We don't want to hack on conversions that
4638 // might lose information from the integer, e.g. "i64 -> float"
4639 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00004640 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00004641
Matt Arsenault55e73122015-01-06 15:50:59 +00004642 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
4643
Chris Lattner2188e402010-01-04 07:37:31 +00004644 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004645
Matt Arsenault55e73122015-01-06 15:50:59 +00004646 if (I.isEquality()) {
4647 FCmpInst::Predicate P = I.getPredicate();
4648 bool IsExact = false;
4649 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
4650 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
4651
4652 // If the floating point constant isn't an integer value, we know if we will
4653 // ever compare equal / not equal to it.
4654 if (!IsExact) {
4655 // TODO: Can never be -0.0 and other non-representable values
4656 APFloat RHSRoundInt(RHS);
4657 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
4658 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
4659 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00004660 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00004661
4662 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00004663 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00004664 }
4665 }
4666
4667 // TODO: If the constant is exactly representable, is it always OK to do
4668 // equality compares as integer?
4669 }
4670
Arch D. Robison8ed08542015-09-15 17:51:59 +00004671 // Check to see that the input is converted from an integer type that is small
4672 // enough that preserves all bits. TODO: check here for "known" sign bits.
4673 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
4674 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00004675
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004676 // Following test does NOT adjust InputSize downwards for signed inputs,
4677 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00004678 // to distinguish it from one less than that value.
4679 if ((int)InputSize > MantissaWidth) {
4680 // Conversion would lose accuracy. Check if loss can impact comparison.
4681 int Exp = ilogb(RHS);
4682 if (Exp == APFloat::IEK_Inf) {
4683 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004684 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00004685 // Conversion could create infinity.
4686 return nullptr;
4687 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004688 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00004689 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00004690 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00004691 // Conversion could affect comparison.
4692 return nullptr;
4693 }
4694 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004695
Chris Lattner2188e402010-01-04 07:37:31 +00004696 // Otherwise, we can potentially simplify the comparison. We know that it
4697 // will always come through as an integer value and we know the constant is
4698 // not a NAN (it would have been previously simplified).
4699 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00004700
Chris Lattner2188e402010-01-04 07:37:31 +00004701 ICmpInst::Predicate Pred;
4702 switch (I.getPredicate()) {
4703 default: llvm_unreachable("Unexpected predicate!");
4704 case FCmpInst::FCMP_UEQ:
4705 case FCmpInst::FCMP_OEQ:
4706 Pred = ICmpInst::ICMP_EQ;
4707 break;
4708 case FCmpInst::FCMP_UGT:
4709 case FCmpInst::FCMP_OGT:
4710 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
4711 break;
4712 case FCmpInst::FCMP_UGE:
4713 case FCmpInst::FCMP_OGE:
4714 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
4715 break;
4716 case FCmpInst::FCMP_ULT:
4717 case FCmpInst::FCMP_OLT:
4718 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
4719 break;
4720 case FCmpInst::FCMP_ULE:
4721 case FCmpInst::FCMP_OLE:
4722 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
4723 break;
4724 case FCmpInst::FCMP_UNE:
4725 case FCmpInst::FCMP_ONE:
4726 Pred = ICmpInst::ICMP_NE;
4727 break;
4728 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00004729 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004730 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00004731 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004732 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004733
Chris Lattner2188e402010-01-04 07:37:31 +00004734 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00004735
Chris Lattner2188e402010-01-04 07:37:31 +00004736 // See if the FP constant is too large for the integer. For example,
4737 // comparing an i8 to 300.0.
4738 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00004739
Chris Lattner2188e402010-01-04 07:37:31 +00004740 if (!LHSUnsigned) {
4741 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
4742 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00004743 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004744 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
4745 APFloat::rmNearestTiesToEven);
4746 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
4747 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
4748 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00004749 return replaceInstUsesWith(I, Builder.getTrue());
4750 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004751 }
4752 } else {
4753 // If the RHS value is > UnsignedMax, fold the comparison. This handles
4754 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00004755 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004756 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
4757 APFloat::rmNearestTiesToEven);
4758 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
4759 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
4760 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00004761 return replaceInstUsesWith(I, Builder.getTrue());
4762 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004763 }
4764 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004765
Chris Lattner2188e402010-01-04 07:37:31 +00004766 if (!LHSUnsigned) {
4767 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00004768 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00004769 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
4770 APFloat::rmNearestTiesToEven);
4771 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
4772 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
4773 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00004774 return replaceInstUsesWith(I, Builder.getTrue());
4775 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004776 }
Devang Patel698452b2012-02-13 23:05:18 +00004777 } else {
4778 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00004779 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00004780 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
4781 APFloat::rmNearestTiesToEven);
4782 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
4783 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
4784 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00004785 return replaceInstUsesWith(I, Builder.getTrue());
4786 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00004787 }
Chris Lattner2188e402010-01-04 07:37:31 +00004788 }
4789
4790 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
4791 // [0, UMAX], but it may still be fractional. See if it is fractional by
4792 // casting the FP value to the integer value and back, checking for equality.
4793 // Don't do this for zero, because -0.0 is not fractional.
4794 Constant *RHSInt = LHSUnsigned
4795 ? ConstantExpr::getFPToUI(RHSC, IntTy)
4796 : ConstantExpr::getFPToSI(RHSC, IntTy);
4797 if (!RHS.isZero()) {
4798 bool Equal = LHSUnsigned
4799 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
4800 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
4801 if (!Equal) {
4802 // If we had a comparison against a fractional value, we have to adjust
4803 // the compare predicate and sometimes the value. RHSC is rounded towards
4804 // zero at this point.
4805 switch (Pred) {
4806 default: llvm_unreachable("Unexpected integer comparison!");
4807 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00004808 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004809 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00004810 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004811 case ICmpInst::ICMP_ULE:
4812 // (float)int <= 4.4 --> int <= 4
4813 // (float)int <= -4.4 --> false
4814 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00004815 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004816 break;
4817 case ICmpInst::ICMP_SLE:
4818 // (float)int <= 4.4 --> int <= 4
4819 // (float)int <= -4.4 --> int < -4
4820 if (RHS.isNegative())
4821 Pred = ICmpInst::ICMP_SLT;
4822 break;
4823 case ICmpInst::ICMP_ULT:
4824 // (float)int < -4.4 --> false
4825 // (float)int < 4.4 --> int <= 4
4826 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00004827 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00004828 Pred = ICmpInst::ICMP_ULE;
4829 break;
4830 case ICmpInst::ICMP_SLT:
4831 // (float)int < -4.4 --> int < -4
4832 // (float)int < 4.4 --> int <= 4
4833 if (!RHS.isNegative())
4834 Pred = ICmpInst::ICMP_SLE;
4835 break;
4836 case ICmpInst::ICMP_UGT:
4837 // (float)int > 4.4 --> int > 4
4838 // (float)int > -4.4 --> true
4839 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00004840 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004841 break;
4842 case ICmpInst::ICMP_SGT:
4843 // (float)int > 4.4 --> int > 4
4844 // (float)int > -4.4 --> int >= -4
4845 if (RHS.isNegative())
4846 Pred = ICmpInst::ICMP_SGE;
4847 break;
4848 case ICmpInst::ICMP_UGE:
4849 // (float)int >= -4.4 --> true
4850 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00004851 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00004852 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00004853 Pred = ICmpInst::ICMP_UGT;
4854 break;
4855 case ICmpInst::ICMP_SGE:
4856 // (float)int >= -4.4 --> int >= -4
4857 // (float)int >= 4.4 --> int > 4
4858 if (!RHS.isNegative())
4859 Pred = ICmpInst::ICMP_SGT;
4860 break;
4861 }
4862 }
4863 }
4864
4865 // Lower this FP comparison into an appropriate integer version of the
4866 // comparison.
4867 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
4868}
4869
4870Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
4871 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004872
Chris Lattner2188e402010-01-04 07:37:31 +00004873 /// Orders the operands of the compare so that they are listed from most
4874 /// complex to least complex. This puts constants before unary operators,
4875 /// before binary operators.
4876 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
4877 I.swapOperands();
4878 Changed = true;
4879 }
4880
Sanjay Patel6b139462017-09-02 15:11:55 +00004881 const CmpInst::Predicate Pred = I.getPredicate();
Chris Lattner2188e402010-01-04 07:37:31 +00004882 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel6b139462017-09-02 15:11:55 +00004883 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(),
4884 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00004885 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00004886
4887 // Simplify 'fcmp pred X, X'
4888 if (Op0 == Op1) {
Sanjay Patel6b139462017-09-02 15:11:55 +00004889 switch (Pred) {
4890 default: break;
Chris Lattner2188e402010-01-04 07:37:31 +00004891 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
4892 case FCmpInst::FCMP_ULT: // True if unordered or less than
4893 case FCmpInst::FCMP_UGT: // True if unordered or greater than
4894 case FCmpInst::FCMP_UNE: // True if unordered or not equal
4895 // Canonicalize these to be 'fcmp uno %X, 0.0'.
4896 I.setPredicate(FCmpInst::FCMP_UNO);
4897 I.setOperand(1, Constant::getNullValue(Op0->getType()));
4898 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00004899
Chris Lattner2188e402010-01-04 07:37:31 +00004900 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
4901 case FCmpInst::FCMP_OEQ: // True if ordered and equal
4902 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
4903 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
4904 // Canonicalize these to be 'fcmp ord %X, 0.0'.
4905 I.setPredicate(FCmpInst::FCMP_ORD);
4906 I.setOperand(1, Constant::getNullValue(Op0->getType()));
4907 return &I;
4908 }
4909 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004910
Sanjay Patel6840c5f2017-09-05 23:13:13 +00004911 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand,
4912 // then canonicalize the operand to 0.0.
4913 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) {
4914 if (!match(Op0, m_Zero()) && isKnownNeverNaN(Op0)) {
4915 I.setOperand(0, ConstantFP::getNullValue(Op0->getType()));
4916 return &I;
4917 }
4918 if (!match(Op1, m_Zero()) && isKnownNeverNaN(Op1)) {
4919 I.setOperand(1, ConstantFP::getNullValue(Op0->getType()));
4920 return &I;
4921 }
4922 }
4923
James Molloy2b21a7c2015-05-20 18:41:25 +00004924 // Test if the FCmpInst instruction is used exclusively by a select as
4925 // part of a minimum or maximum operation. If so, refrain from doing
4926 // any other folding. This helps out other analyses which understand
4927 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
4928 // and CodeGen. And in this case, at least one of the comparison
4929 // operands has at least one user besides the compare (the select),
4930 // which would often largely negate the benefit of folding anyway.
4931 if (I.hasOneUse())
4932 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin()))
4933 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) ||
4934 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1))
4935 return nullptr;
4936
Chris Lattner2188e402010-01-04 07:37:31 +00004937 // Handle fcmp with constant RHS
4938 if (Constant *RHSC = dyn_cast<Constant>(Op1)) {
4939 if (Instruction *LHSI = dyn_cast<Instruction>(Op0))
4940 switch (LHSI->getOpcode()) {
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004941 case Instruction::FPExt: {
4942 // fcmp (fpext x), C -> fcmp x, (fptrunc C) if fptrunc is lossless
4943 FPExtInst *LHSExt = cast<FPExtInst>(LHSI);
4944 ConstantFP *RHSF = dyn_cast<ConstantFP>(RHSC);
4945 if (!RHSF)
4946 break;
4947
4948 const fltSemantics *Sem;
4949 // FIXME: This shouldn't be here.
Dan Gohman518cda42011-12-17 00:04:22 +00004950 if (LHSExt->getSrcTy()->isHalfTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004951 Sem = &APFloat::IEEEhalf();
Dan Gohman518cda42011-12-17 00:04:22 +00004952 else if (LHSExt->getSrcTy()->isFloatTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004953 Sem = &APFloat::IEEEsingle();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004954 else if (LHSExt->getSrcTy()->isDoubleTy())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004955 Sem = &APFloat::IEEEdouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004956 else if (LHSExt->getSrcTy()->isFP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004957 Sem = &APFloat::IEEEquad();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004958 else if (LHSExt->getSrcTy()->isX86_FP80Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004959 Sem = &APFloat::x87DoubleExtended();
Ulrich Weigand6a9bb512012-10-30 12:33:18 +00004960 else if (LHSExt->getSrcTy()->isPPC_FP128Ty())
Stephan Bergmann17c7f702016-12-14 11:57:17 +00004961 Sem = &APFloat::PPCDoubleDouble();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004962 else
4963 break;
4964
4965 bool Lossy;
4966 APFloat F = RHSF->getValueAPF();
4967 F.convert(*Sem, APFloat::rmNearestTiesToEven, &Lossy);
4968
Jim Grosbach24ff8342011-09-30 18:45:50 +00004969 // Avoid lossy conversions and denormals. Zero is a special case
4970 // that's OK to convert.
Jim Grosbach011dafb2011-09-30 19:58:46 +00004971 APFloat Fabs = F;
4972 Fabs.clearSign();
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004973 if (!Lossy &&
Jim Grosbach011dafb2011-09-30 19:58:46 +00004974 ((Fabs.compare(APFloat::getSmallestNormalized(*Sem)) !=
4975 APFloat::cmpLessThan) || Fabs.isZero()))
Jim Grosbach24ff8342011-09-30 18:45:50 +00004976
Sanjay Patel6b139462017-09-02 15:11:55 +00004977 return new FCmpInst(Pred, LHSExt->getOperand(0),
Benjamin Kramercbb18e92011-03-31 10:12:07 +00004978 ConstantFP::get(RHSC->getContext(), F));
4979 break;
4980 }
Chris Lattner2188e402010-01-04 07:37:31 +00004981 case Instruction::PHI:
4982 // Only fold fcmp into the PHI if the phi and fcmp are in the same
4983 // block. If in the same block, we're encouraging jump threading. If
4984 // not, we are just pessimizing the code by making an i1 phi.
4985 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00004986 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00004987 return NV;
4988 break;
4989 case Instruction::SIToFP:
4990 case Instruction::UIToFP:
Sanjay Patel43395062016-07-21 18:07:40 +00004991 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
Chris Lattner2188e402010-01-04 07:37:31 +00004992 return NV;
4993 break;
Benjamin Kramera8c5d082011-03-31 10:12:15 +00004994 case Instruction::FSub: {
4995 // fcmp pred (fneg x), C -> fcmp swap(pred) x, -C
4996 Value *Op;
4997 if (match(LHSI, m_FNeg(m_Value(Op))))
4998 return new FCmpInst(I.getSwappedPredicate(), Op,
4999 ConstantExpr::getFNeg(RHSC));
5000 break;
5001 }
Dan Gohman94732022010-02-24 06:46:09 +00005002 case Instruction::Load:
5003 if (GetElementPtrInst *GEP =
5004 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
5005 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
5006 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
5007 !cast<LoadInst>(LHSI)->isVolatile())
Sanjay Patel43395062016-07-21 18:07:40 +00005008 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
Dan Gohman94732022010-02-24 06:46:09 +00005009 return Res;
5010 }
5011 break;
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005012 case Instruction::Call: {
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00005013 if (!RHSC->isNullValue())
5014 break;
5015
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005016 CallInst *CI = cast<CallInst>(LHSI);
Justin Bogner99798402016-08-05 01:06:44 +00005017 Intrinsic::ID IID = getIntrinsicForCallSite(CI, &TLI);
David Majnemer2e02ba72016-04-15 17:21:03 +00005018 if (IID != Intrinsic::fabs)
Matt Arsenaultb935d9d2015-01-08 20:09:34 +00005019 break;
5020
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005021 // Various optimization for fabs compared with zero.
Sanjay Patel6b139462017-09-02 15:11:55 +00005022 switch (Pred) {
David Majnemer2e02ba72016-04-15 17:21:03 +00005023 default:
5024 break;
5025 // fabs(x) < 0 --> false
5026 case FCmpInst::FCMP_OLT:
5027 llvm_unreachable("handled by SimplifyFCmpInst");
5028 // fabs(x) > 0 --> x != 0
5029 case FCmpInst::FCMP_OGT:
5030 return new FCmpInst(FCmpInst::FCMP_ONE, CI->getArgOperand(0), RHSC);
5031 // fabs(x) <= 0 --> x == 0
5032 case FCmpInst::FCMP_OLE:
5033 return new FCmpInst(FCmpInst::FCMP_OEQ, CI->getArgOperand(0), RHSC);
5034 // fabs(x) >= 0 --> !isnan(x)
5035 case FCmpInst::FCMP_OGE:
5036 return new FCmpInst(FCmpInst::FCMP_ORD, CI->getArgOperand(0), RHSC);
5037 // fabs(x) == 0 --> x == 0
5038 // fabs(x) != 0 --> x != 0
5039 case FCmpInst::FCMP_OEQ:
5040 case FCmpInst::FCMP_UEQ:
5041 case FCmpInst::FCMP_ONE:
5042 case FCmpInst::FCMP_UNE:
Sanjay Patel6b139462017-09-02 15:11:55 +00005043 return new FCmpInst(Pred, CI->getArgOperand(0), RHSC);
Benjamin Kramer8c2a7332012-08-18 20:06:47 +00005044 }
5045 }
Chris Lattner2188e402010-01-04 07:37:31 +00005046 }
Chris Lattner2188e402010-01-04 07:37:31 +00005047 }
5048
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00005049 // fcmp pred (fneg x), (fneg y) -> fcmp swap(pred) x, y
Benjamin Kramerd159d942011-03-31 10:12:22 +00005050 Value *X, *Y;
5051 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
Benjamin Kramerbe209ab2011-03-31 10:46:03 +00005052 return new FCmpInst(I.getSwappedPredicate(), X, Y);
Benjamin Kramerd159d942011-03-31 10:12:22 +00005053
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005054 // fcmp (fpext x), (fpext y) -> fcmp x, y
5055 if (FPExtInst *LHSExt = dyn_cast<FPExtInst>(Op0))
5056 if (FPExtInst *RHSExt = dyn_cast<FPExtInst>(Op1))
5057 if (LHSExt->getSrcTy() == RHSExt->getSrcTy())
Sanjay Patel6b139462017-09-02 15:11:55 +00005058 return new FCmpInst(Pred, LHSExt->getOperand(0), RHSExt->getOperand(0));
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00005059
Craig Topperf40110f2014-04-25 05:29:35 +00005060 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005061}