blob: 13c036506c6fae2baa10d38714511525edb5fc9b [file] [log] [blame]
John Thompsond977c1e2013-03-27 18:34:38 +00001//===- extra/modularize/Modularize.cpp - Check modularized headers --------===//
John Thompson4f8ba652013-03-12 02:07:30 +00002//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements a tool that checks whether a set of headers provides
11// the consistent definitions required to use modules. For example, it detects
12// whether the same entity (say, a NULL macro or size_t typedef) is defined in
13// multiple headers or whether a header produces different definitions under
14// different circumstances. These conditions cause modules built from the
John Thompsonf5db45b2013-03-27 01:02:46 +000015// headers to behave poorly, and should be fixed before introducing a module
John Thompson4f8ba652013-03-12 02:07:30 +000016// map.
17//
18// Modularize takes as argument a file name for a file containing the
19// newline-separated list of headers to check with respect to each other.
John Thompsonf5db45b2013-03-27 01:02:46 +000020// Lines beginning with '#' and empty lines are ignored.
John Thompson7d0213c2013-09-04 20:46:24 +000021// Header file names followed by a colon and other space-separated
22// file names will include those extra files as dependencies.
23// The file names can be relative or full paths, but must be on the
24// same line.
25//
John Thompson4f8ba652013-03-12 02:07:30 +000026// Modularize also accepts regular front-end arguments.
27//
John Thompsonf5db45b2013-03-27 01:02:46 +000028// Usage: modularize [-prefix (optional header path prefix)]
John Thompsona2de1082013-03-26 01:17:48 +000029// (include-files_list) [(front-end-options) ...]
30//
John Thompsona44f85a2013-04-15 22:32:28 +000031// Note that unless a "-prefix (header path)" option is specified,
John Thompsona2de1082013-03-26 01:17:48 +000032// non-absolute file paths in the header list file will be relative
33// to the header list file directory. Use -prefix to specify a different
34// directory.
John Thompson4f8ba652013-03-12 02:07:30 +000035//
John Thompsonfd8ca382013-03-27 19:31:22 +000036// Note that by default, the underlying Clang front end assumes .h files
37// contain C source. If your .h files in the file list contain C++ source,
John Thompsonea6c8db2013-03-27 21:23:21 +000038// you should append the following to your command lines: -x c++
John Thompsonfd8ca382013-03-27 19:31:22 +000039//
John Thompson4f8ba652013-03-12 02:07:30 +000040// Modularize will do normal parsing, reporting normal errors and warnings,
41// but will also report special error messages like the following:
42//
John Thompson7c6e79f32013-07-29 19:07:00 +000043// error: '(symbol)' defined at multiple locations:
44// (file):(row):(column)
45// (file):(row):(column)
John Thompson4f8ba652013-03-12 02:07:30 +000046//
John Thompsondc118272013-07-29 21:59:41 +000047// error: header '(file)' has different contents depending on how it was
John Thompson7c6e79f32013-07-29 19:07:00 +000048// included
John Thompson4f8ba652013-03-12 02:07:30 +000049//
50// The latter might be followed by messages like the following:
51//
John Thompson7c6e79f32013-07-29 19:07:00 +000052// note: '(symbol)' in (file) at (row):(column) not always provided
John Thompson4f8ba652013-03-12 02:07:30 +000053//
John Thompson7c6e79f32013-07-29 19:07:00 +000054// Checks will also be performed for macro expansions, defined(macro)
55// expressions, and preprocessor conditional directives that evaluate
56// inconsistently, and can produce error messages like the following:
57//
Nico Weber8e20be22013-08-12 11:43:36 +000058// (...)/SubHeader.h:11:5:
59// #if SYMBOL == 1
60// ^
61// error: Macro instance 'SYMBOL' has different values in this header,
62// depending on how it was included.
63// 'SYMBOL' expanded to: '1' with respect to these inclusion paths:
64// (...)/Header1.h
65// (...)/SubHeader.h
66// (...)/SubHeader.h:3:9:
67// #define SYMBOL 1
68// ^
69// Macro defined here.
70// 'SYMBOL' expanded to: '2' with respect to these inclusion paths:
71// (...)/Header2.h
72// (...)/SubHeader.h
73// (...)/SubHeader.h:7:9:
74// #define SYMBOL 2
75// ^
76// Macro defined here.
77//
John Thompson74083922013-09-18 18:19:43 +000078// Checks will also be performed for '#include' directives that are
79// nested inside 'extern "C/C++" {}' or 'namespace (name) {}' blocks,
80// and can produce error message like the following:
81//
82// IncludeInExtern.h:2:3
83// #include "Empty.h"
84// ^
85// error: Include directive within extern "C" {}.
86// IncludeInExtern.h:1:1
87// extern "C" {
88// ^
89// The "extern "C" {}" block is here.
90//
John Thompson4fa9c2c2013-08-09 00:19:03 +000091// See PreprocessorTracker.cpp for additional details.
John Thompsoncc2e2912013-09-03 18:44:11 +000092//
John Thompson5ab4f112013-10-15 13:52:33 +000093// Modularize also has an option ("-module-map-path=module.map") that will
94// skip the checks, and instead act as a module.map generation assistant,
95// generating a module map file based on the header list. An optional
96// "-root-module=(rootName)" argument can specify a root module to be
97// created in the generated module.map file. Note that you will likely
98// need to edit this file to suit the needs of your headers.
99//
100// An example command line for generating a module.map file:
101//
102// modularize -module-map-path=module.map -root-module=myroot headerlist.txt
103//
104// Note that if the headers in the header list have partial paths, sub-modules
105// will be created for the subdirectires involved, assuming that the
106// subdirectories contain headers to be grouped into a module, but still with
107// individual modules for the headers in the subdirectory.
108//
109// See the ModuleAssistant.cpp file comments for additional details about the
110// implementation of the assistant mode.
111//
John Thompson74751802013-09-03 18:48:43 +0000112// Future directions:
113//
114// Basically, we want to add new checks for whatever we can check with respect
115// to checking headers for module'ability.
116//
117// Some ideas:
118//
John Thompson74083922013-09-18 18:19:43 +0000119// 1. Omit duplicate "not always provided" messages
John Thompson53a9d2d2013-09-04 18:29:36 +0000120//
John Thompson74083922013-09-18 18:19:43 +0000121// 2. Add options to disable any of the checks, in case
John Thompson74751802013-09-03 18:48:43 +0000122// there is some problem with them, or the messages get too verbose.
123//
John Thompson74083922013-09-18 18:19:43 +0000124// 3. Try to figure out the preprocessor conditional directives that
John Thompson74751802013-09-03 18:48:43 +0000125// contribute to problems and tie them to the inconsistent definitions.
126//
John Thompson74083922013-09-18 18:19:43 +0000127// 4. There are some legitimate uses of preprocessor macros that
Bob Wilsonf5999bd2013-09-04 16:48:28 +0000128// modularize will flag as errors, such as repeatedly #include'ing
129// a file and using interleaving defined/undefined macros
130// to change declarations in the included file. Is there a way
131// to address this? Maybe have modularize accept a list of macros
132// to ignore. Otherwise you can just exclude the file, after checking
133// for legitimate errors.
134//
John Thompson74083922013-09-18 18:19:43 +0000135// 5. What else?
John Thompsonce601e22013-03-14 01:41:29 +0000136//
137// General clean-up and refactoring:
138//
139// 1. The Location class seems to be something that we might
140// want to design to be applicable to a wider range of tools, and stick it
141// somewhere into Tooling/ in mainline
142//
John Thompson4f8ba652013-03-12 02:07:30 +0000143//===----------------------------------------------------------------------===//
John Thompsonf5db45b2013-03-27 01:02:46 +0000144
John Thompsond977c1e2013-03-27 18:34:38 +0000145#include "clang/AST/ASTConsumer.h"
146#include "clang/AST/ASTContext.h"
147#include "clang/AST/RecursiveASTVisitor.h"
148#include "clang/Basic/SourceManager.h"
John Thompson7d0213c2013-09-04 20:46:24 +0000149#include "clang/Driver/Options.h"
John Thompsond977c1e2013-03-27 18:34:38 +0000150#include "clang/Frontend/CompilerInstance.h"
151#include "clang/Frontend/FrontendActions.h"
152#include "clang/Lex/Preprocessor.h"
153#include "clang/Tooling/CompilationDatabase.h"
154#include "clang/Tooling/Tooling.h"
155#include "llvm/ADT/OwningPtr.h"
John Thompson4f8ba652013-03-12 02:07:30 +0000156#include "llvm/Config/config.h"
John Thompson7d0213c2013-09-04 20:46:24 +0000157#include "llvm/Option/Arg.h"
158#include "llvm/Option/ArgList.h"
159#include "llvm/Option/OptTable.h"
160#include "llvm/Option/Option.h"
John Thompsona2de1082013-03-26 01:17:48 +0000161#include "llvm/Support/CommandLine.h"
John Thompson4f8ba652013-03-12 02:07:30 +0000162#include "llvm/Support/FileSystem.h"
John Thompsonf5db45b2013-03-27 01:02:46 +0000163#include "llvm/Support/MemoryBuffer.h"
John Thompsona2de1082013-03-26 01:17:48 +0000164#include "llvm/Support/Path.h"
John Thompson4f8ba652013-03-12 02:07:30 +0000165#include <algorithm>
John Thompsond977c1e2013-03-27 18:34:38 +0000166#include <fstream>
John Thompson4f8ba652013-03-12 02:07:30 +0000167#include <iterator>
John Thompsond977c1e2013-03-27 18:34:38 +0000168#include <string>
169#include <vector>
John Thompson5ab4f112013-10-15 13:52:33 +0000170#include "Modularize.h"
John Thompson94faa4d2013-07-26 23:56:42 +0000171#include "PreprocessorTracker.h"
John Thompson4f8ba652013-03-12 02:07:30 +0000172
Bob Wilsonf5999bd2013-09-04 16:48:28 +0000173using namespace clang;
John Thompson7d0213c2013-09-04 20:46:24 +0000174using namespace clang::driver;
175using namespace clang::driver::options;
176using namespace clang::tooling;
John Thompsona2de1082013-03-26 01:17:48 +0000177using namespace llvm;
John Thompson7d0213c2013-09-04 20:46:24 +0000178using namespace llvm::opt;
John Thompson94faa4d2013-07-26 23:56:42 +0000179using namespace Modularize;
John Thompson4f8ba652013-03-12 02:07:30 +0000180
John Thompsonea6c8db2013-03-27 21:23:21 +0000181// Option to specify a file name for a list of header files to check.
John Thompsonb809dfc2013-07-19 14:19:31 +0000182cl::opt<std::string>
183ListFileName(cl::Positional,
184 cl::desc("<name of file containing list of headers to check>"));
John Thompsonea6c8db2013-03-27 21:23:21 +0000185
186// Collect all other arguments, which will be passed to the front end.
John Thompson161381e2013-06-27 18:52:23 +0000187cl::list<std::string>
John Thompsonb809dfc2013-07-19 14:19:31 +0000188CC1Arguments(cl::ConsumeAfter,
189 cl::desc("<arguments to be passed to front end>..."));
John Thompsonea6c8db2013-03-27 21:23:21 +0000190
191// Option to specify a prefix to be prepended to the header names.
192cl::opt<std::string> HeaderPrefix(
193 "prefix", cl::init(""),
194 cl::desc(
195 "Prepend header file paths with this prefix."
196 " If not specified,"
197 " the files are considered to be relative to the header list file."));
198
John Thompson5ab4f112013-10-15 13:52:33 +0000199// Option for assistant mode, telling modularize to output a module map
200// based on the headers list, and where to put it.
201cl::opt<std::string> ModuleMapPath(
202 "module-map-path", cl::init(""),
203 cl::desc("Turn on module map output and specify output path or file name."
204 " If no path is specified and if prefix option is specified,"
205 " use prefix for file path."));
206
207// Option for assistant mode, telling modularize to output a module map
208// based on the headers list, and where to put it.
209cl::opt<std::string>
210RootModule("root-module", cl::init(""),
211 cl::desc("Specify the name of the root module."));
212
213// Save the program name for error messages.
214const char *Argv0;
215// Save the command line for comments.
216std::string CommandLine;
Bob Wilsonf5999bd2013-09-04 16:48:28 +0000217
John Thompson7d0213c2013-09-04 20:46:24 +0000218// Read the header list file and collect the header file names and
219// optional dependencies.
220error_code getHeaderFileNames(SmallVectorImpl<std::string> &HeaderFileNames,
221 DependencyMap &Dependencies,
222 StringRef ListFileName, StringRef HeaderPrefix) {
John Thompsonea6c8db2013-03-27 21:23:21 +0000223 // By default, use the path component of the list file name.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000224 SmallString<256> HeaderDirectory(ListFileName);
225 sys::path::remove_filename(HeaderDirectory);
John Thompson7d0213c2013-09-04 20:46:24 +0000226 SmallString<256> CurrentDirectory;
227 sys::fs::current_path(CurrentDirectory);
John Thompsonea6c8db2013-03-27 21:23:21 +0000228
229 // Get the prefix if we have one.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000230 if (HeaderPrefix.size() != 0)
231 HeaderDirectory = HeaderPrefix;
John Thompsonea6c8db2013-03-27 21:23:21 +0000232
233 // Read the header list file into a buffer.
234 OwningPtr<MemoryBuffer> listBuffer;
John Thompsonbb0a3b02013-08-09 13:52:09 +0000235 if (error_code ec = MemoryBuffer::getFile(ListFileName, listBuffer)) {
John Thompsonea6c8db2013-03-27 21:23:21 +0000236 return ec;
237 }
238
239 // Parse the header list into strings.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000240 SmallVector<StringRef, 32> Strings;
241 listBuffer->getBuffer().split(Strings, "\n", -1, false);
John Thompsonea6c8db2013-03-27 21:23:21 +0000242
243 // Collect the header file names from the string list.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000244 for (SmallVectorImpl<StringRef>::iterator I = Strings.begin(),
245 E = Strings.end();
John Thompsonea6c8db2013-03-27 21:23:21 +0000246 I != E; ++I) {
John Thompson7d0213c2013-09-04 20:46:24 +0000247 StringRef Line = I->trim();
John Thompsonea6c8db2013-03-27 21:23:21 +0000248 // Ignore comments and empty lines.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000249 if (Line.empty() || (Line[0] == '#'))
John Thompsonea6c8db2013-03-27 21:23:21 +0000250 continue;
John Thompson7d0213c2013-09-04 20:46:24 +0000251 std::pair<StringRef, StringRef> TargetAndDependents = Line.split(':');
John Thompsonbb0a3b02013-08-09 13:52:09 +0000252 SmallString<256> HeaderFileName;
John Thompsonea6c8db2013-03-27 21:23:21 +0000253 // Prepend header file name prefix if it's not absolute.
John Thompson7d0213c2013-09-04 20:46:24 +0000254 if (sys::path::is_absolute(TargetAndDependents.first))
255 llvm::sys::path::native(TargetAndDependents.first, HeaderFileName);
John Thompsonea6c8db2013-03-27 21:23:21 +0000256 else {
John Thompson7d0213c2013-09-04 20:46:24 +0000257 if (HeaderDirectory.size() != 0)
258 HeaderFileName = HeaderDirectory;
259 else
260 HeaderFileName = CurrentDirectory;
261 sys::path::append(HeaderFileName, TargetAndDependents.first);
Benjamin Kramer3353a102013-09-11 10:45:25 +0000262 sys::path::native(HeaderFileName);
John Thompsonea6c8db2013-03-27 21:23:21 +0000263 }
John Thompson7d0213c2013-09-04 20:46:24 +0000264 // Handle optional dependencies.
265 DependentsVector Dependents;
266 SmallVector<StringRef, 4> DependentsList;
267 TargetAndDependents.second.split(DependentsList, " ", -1, false);
268 int Count = DependentsList.size();
269 for (int Index = 0; Index < Count; ++Index) {
270 SmallString<256> Dependent;
271 if (sys::path::is_absolute(DependentsList[Index]))
272 Dependent = DependentsList[Index];
273 else {
274 if (HeaderDirectory.size() != 0)
275 Dependent = HeaderDirectory;
276 else
277 Dependent = CurrentDirectory;
278 sys::path::append(Dependent, DependentsList[Index]);
279 }
Benjamin Kramer3353a102013-09-11 10:45:25 +0000280 sys::path::native(Dependent);
John Thompson7d0213c2013-09-04 20:46:24 +0000281 Dependents.push_back(Dependent.str());
282 }
283 // Save the resulting header file path and dependencies.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000284 HeaderFileNames.push_back(HeaderFileName.str());
John Thompson7d0213c2013-09-04 20:46:24 +0000285 Dependencies[HeaderFileName.str()] = Dependents;
John Thompsonea6c8db2013-03-27 21:23:21 +0000286 }
287
288 return error_code::success();
289}
290
John Thompson7d0213c2013-09-04 20:46:24 +0000291// Helper function for finding the input file in an arguments list.
292std::string findInputFile(const CommandLineArguments &CLArgs) {
293 OwningPtr<OptTable> Opts(createDriverOptTable());
294 const unsigned IncludedFlagsBitmask = options::CC1Option;
295 unsigned MissingArgIndex, MissingArgCount;
296 SmallVector<const char *, 256> Argv;
297 for (CommandLineArguments::const_iterator I = CLArgs.begin(),
298 E = CLArgs.end();
299 I != E; ++I)
300 Argv.push_back(I->c_str());
301 OwningPtr<InputArgList> Args(
302 Opts->ParseArgs(Argv.data(), Argv.data() + Argv.size(), MissingArgIndex,
303 MissingArgCount, IncludedFlagsBitmask));
304 std::vector<std::string> Inputs = Args->getAllArgValues(OPT_INPUT);
305 return Inputs.back();
306}
307
308// We provide this derivation to add in "-include (file)" arguments for header
309// dependencies.
310class AddDependenciesAdjuster : public ArgumentsAdjuster {
311public:
312 AddDependenciesAdjuster(DependencyMap &Dependencies)
313 : Dependencies(Dependencies) {}
314
315private:
316 // Callback for adjusting commandline arguments.
317 CommandLineArguments Adjust(const CommandLineArguments &Args) {
318 std::string InputFile = findInputFile(Args);
319 DependentsVector &FileDependents = Dependencies[InputFile];
320 int Count = FileDependents.size();
321 if (Count == 0)
322 return Args;
323 CommandLineArguments NewArgs(Args);
324 for (int Index = 0; Index < Count; ++Index) {
325 NewArgs.push_back("-include");
326 std::string File(std::string("\"") + FileDependents[Index] +
327 std::string("\""));
328 NewArgs.push_back(FileDependents[Index]);
329 }
330 return NewArgs;
331 }
332 DependencyMap &Dependencies;
333};
334
John Thompsonce601e22013-03-14 01:41:29 +0000335// FIXME: The Location class seems to be something that we might
336// want to design to be applicable to a wider range of tools, and stick it
337// somewhere into Tooling/ in mainline
John Thompson4f8ba652013-03-12 02:07:30 +0000338struct Location {
339 const FileEntry *File;
340 unsigned Line, Column;
John Thompsonf5db45b2013-03-27 01:02:46 +0000341
342 Location() : File(), Line(), Column() {}
343
John Thompson4f8ba652013-03-12 02:07:30 +0000344 Location(SourceManager &SM, SourceLocation Loc) : File(), Line(), Column() {
345 Loc = SM.getExpansionLoc(Loc);
346 if (Loc.isInvalid())
347 return;
John Thompsonf5db45b2013-03-27 01:02:46 +0000348
John Thompson4f8ba652013-03-12 02:07:30 +0000349 std::pair<FileID, unsigned> Decomposed = SM.getDecomposedLoc(Loc);
350 File = SM.getFileEntryForID(Decomposed.first);
351 if (!File)
352 return;
John Thompsonf5db45b2013-03-27 01:02:46 +0000353
John Thompson4f8ba652013-03-12 02:07:30 +0000354 Line = SM.getLineNumber(Decomposed.first, Decomposed.second);
355 Column = SM.getColumnNumber(Decomposed.first, Decomposed.second);
356 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000357
John Thompson4f8ba652013-03-12 02:07:30 +0000358 operator bool() const { return File != 0; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000359
John Thompson4f8ba652013-03-12 02:07:30 +0000360 friend bool operator==(const Location &X, const Location &Y) {
361 return X.File == Y.File && X.Line == Y.Line && X.Column == Y.Column;
362 }
363
364 friend bool operator!=(const Location &X, const Location &Y) {
365 return !(X == Y);
366 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000367
John Thompson4f8ba652013-03-12 02:07:30 +0000368 friend bool operator<(const Location &X, const Location &Y) {
369 if (X.File != Y.File)
370 return X.File < Y.File;
371 if (X.Line != Y.Line)
372 return X.Line < Y.Line;
373 return X.Column < Y.Column;
374 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000375 friend bool operator>(const Location &X, const Location &Y) { return Y < X; }
John Thompson4f8ba652013-03-12 02:07:30 +0000376 friend bool operator<=(const Location &X, const Location &Y) {
377 return !(Y < X);
378 }
379 friend bool operator>=(const Location &X, const Location &Y) {
380 return !(X < Y);
381 }
John Thompson4f8ba652013-03-12 02:07:30 +0000382};
383
John Thompson4f8ba652013-03-12 02:07:30 +0000384struct Entry {
John Thompson52d98862013-03-28 18:38:43 +0000385 enum EntryKind {
386 EK_Tag,
387 EK_Value,
388 EK_Macro,
389
390 EK_NumberOfKinds
John Thompson4f8ba652013-03-12 02:07:30 +0000391 } Kind;
John Thompsonf5db45b2013-03-27 01:02:46 +0000392
John Thompson4f8ba652013-03-12 02:07:30 +0000393 Location Loc;
John Thompson4e4d9b32013-03-28 01:20:19 +0000394
395 StringRef getKindName() { return getKindName(Kind); }
John Thompson52d98862013-03-28 18:38:43 +0000396 static StringRef getKindName(EntryKind kind);
John Thompson4f8ba652013-03-12 02:07:30 +0000397};
398
John Thompson4e4d9b32013-03-28 01:20:19 +0000399// Return a string representing the given kind.
John Thompson52d98862013-03-28 18:38:43 +0000400StringRef Entry::getKindName(Entry::EntryKind kind) {
John Thompson4e4d9b32013-03-28 01:20:19 +0000401 switch (kind) {
John Thompson52d98862013-03-28 18:38:43 +0000402 case EK_Tag:
John Thompson4e4d9b32013-03-28 01:20:19 +0000403 return "tag";
John Thompson52d98862013-03-28 18:38:43 +0000404 case EK_Value:
John Thompson4e4d9b32013-03-28 01:20:19 +0000405 return "value";
John Thompson52d98862013-03-28 18:38:43 +0000406 case EK_Macro:
John Thompson4e4d9b32013-03-28 01:20:19 +0000407 return "macro";
John Thompson52d98862013-03-28 18:38:43 +0000408 case EK_NumberOfKinds:
John Thompson4e4d9b32013-03-28 01:20:19 +0000409 break;
John Thompson4e4d9b32013-03-28 01:20:19 +0000410 }
David Blaikiec66c07d2013-03-28 02:30:37 +0000411 llvm_unreachable("invalid Entry kind");
John Thompson4e4d9b32013-03-28 01:20:19 +0000412}
413
John Thompson4f8ba652013-03-12 02:07:30 +0000414struct HeaderEntry {
415 std::string Name;
416 Location Loc;
John Thompsonf5db45b2013-03-27 01:02:46 +0000417
John Thompson4f8ba652013-03-12 02:07:30 +0000418 friend bool operator==(const HeaderEntry &X, const HeaderEntry &Y) {
419 return X.Loc == Y.Loc && X.Name == Y.Name;
420 }
421 friend bool operator!=(const HeaderEntry &X, const HeaderEntry &Y) {
422 return !(X == Y);
423 }
424 friend bool operator<(const HeaderEntry &X, const HeaderEntry &Y) {
425 return X.Loc < Y.Loc || (X.Loc == Y.Loc && X.Name < Y.Name);
426 }
427 friend bool operator>(const HeaderEntry &X, const HeaderEntry &Y) {
428 return Y < X;
429 }
430 friend bool operator<=(const HeaderEntry &X, const HeaderEntry &Y) {
431 return !(Y < X);
432 }
433 friend bool operator>=(const HeaderEntry &X, const HeaderEntry &Y) {
434 return !(X < Y);
435 }
436};
437
438typedef std::vector<HeaderEntry> HeaderContents;
439
John Thompsonf5db45b2013-03-27 01:02:46 +0000440class EntityMap : public StringMap<SmallVector<Entry, 2> > {
John Thompson4f8ba652013-03-12 02:07:30 +0000441public:
John Thompsonf5db45b2013-03-27 01:02:46 +0000442 DenseMap<const FileEntry *, HeaderContents> HeaderContentMismatches;
443
John Thompson52d98862013-03-28 18:38:43 +0000444 void add(const std::string &Name, enum Entry::EntryKind Kind, Location Loc) {
John Thompson4f8ba652013-03-12 02:07:30 +0000445 // Record this entity in its header.
446 HeaderEntry HE = { Name, Loc };
447 CurHeaderContents[Loc.File].push_back(HE);
John Thompsonf5db45b2013-03-27 01:02:46 +0000448
John Thompson4f8ba652013-03-12 02:07:30 +0000449 // Check whether we've seen this entry before.
John Thompsonf5db45b2013-03-27 01:02:46 +0000450 SmallVector<Entry, 2> &Entries = (*this)[Name];
John Thompson4f8ba652013-03-12 02:07:30 +0000451 for (unsigned I = 0, N = Entries.size(); I != N; ++I) {
452 if (Entries[I].Kind == Kind && Entries[I].Loc == Loc)
453 return;
454 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000455
John Thompson4f8ba652013-03-12 02:07:30 +0000456 // We have not seen this entry before; record it.
457 Entry E = { Kind, Loc };
458 Entries.push_back(E);
459 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000460
John Thompson4f8ba652013-03-12 02:07:30 +0000461 void mergeCurHeaderContents() {
John Thompsonf5db45b2013-03-27 01:02:46 +0000462 for (DenseMap<const FileEntry *, HeaderContents>::iterator
463 H = CurHeaderContents.begin(),
464 HEnd = CurHeaderContents.end();
John Thompson4f8ba652013-03-12 02:07:30 +0000465 H != HEnd; ++H) {
466 // Sort contents.
467 std::sort(H->second.begin(), H->second.end());
468
469 // Check whether we've seen this header before.
John Thompsonf5db45b2013-03-27 01:02:46 +0000470 DenseMap<const FileEntry *, HeaderContents>::iterator KnownH =
471 AllHeaderContents.find(H->first);
John Thompson4f8ba652013-03-12 02:07:30 +0000472 if (KnownH == AllHeaderContents.end()) {
473 // We haven't seen this header before; record its contents.
474 AllHeaderContents.insert(*H);
475 continue;
476 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000477
John Thompson4f8ba652013-03-12 02:07:30 +0000478 // If the header contents are the same, we're done.
479 if (H->second == KnownH->second)
480 continue;
John Thompsonf5db45b2013-03-27 01:02:46 +0000481
John Thompson4f8ba652013-03-12 02:07:30 +0000482 // Determine what changed.
John Thompsonf5db45b2013-03-27 01:02:46 +0000483 std::set_symmetric_difference(
484 H->second.begin(), H->second.end(), KnownH->second.begin(),
485 KnownH->second.end(),
486 std::back_inserter(HeaderContentMismatches[H->first]));
John Thompson4f8ba652013-03-12 02:07:30 +0000487 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000488
John Thompson4f8ba652013-03-12 02:07:30 +0000489 CurHeaderContents.clear();
490 }
John Thompson161381e2013-06-27 18:52:23 +0000491
John Thompson1f67ccb2013-03-12 18:51:47 +0000492private:
John Thompsonf5db45b2013-03-27 01:02:46 +0000493 DenseMap<const FileEntry *, HeaderContents> CurHeaderContents;
494 DenseMap<const FileEntry *, HeaderContents> AllHeaderContents;
John Thompson4f8ba652013-03-12 02:07:30 +0000495};
496
John Thompson161381e2013-06-27 18:52:23 +0000497class CollectEntitiesVisitor
498 : public RecursiveASTVisitor<CollectEntitiesVisitor> {
John Thompson4f8ba652013-03-12 02:07:30 +0000499public:
John Thompson74083922013-09-18 18:19:43 +0000500 CollectEntitiesVisitor(SourceManager &SM, EntityMap &Entities,
501 Preprocessor &PP, PreprocessorTracker &PPTracker,
502 int &HadErrors)
503 : SM(SM), Entities(Entities), PP(PP), PPTracker(PPTracker),
504 HadErrors(HadErrors) {}
John Thompsonf5db45b2013-03-27 01:02:46 +0000505
John Thompson4f8ba652013-03-12 02:07:30 +0000506 bool TraverseStmt(Stmt *S) { return true; }
507 bool TraverseType(QualType T) { return true; }
508 bool TraverseTypeLoc(TypeLoc TL) { return true; }
509 bool TraverseNestedNameSpecifier(NestedNameSpecifier *NNS) { return true; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000510 bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNS) {
511 return true;
512 }
513 bool TraverseDeclarationNameInfo(DeclarationNameInfo NameInfo) {
514 return true;
515 }
John Thompson4f8ba652013-03-12 02:07:30 +0000516 bool TraverseTemplateName(TemplateName Template) { return true; }
517 bool TraverseTemplateArgument(const TemplateArgument &Arg) { return true; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000518 bool TraverseTemplateArgumentLoc(const TemplateArgumentLoc &ArgLoc) {
519 return true;
520 }
John Thompson4f8ba652013-03-12 02:07:30 +0000521 bool TraverseTemplateArguments(const TemplateArgument *Args,
John Thompsonf5db45b2013-03-27 01:02:46 +0000522 unsigned NumArgs) {
523 return true;
524 }
John Thompson4f8ba652013-03-12 02:07:30 +0000525 bool TraverseConstructorInitializer(CXXCtorInitializer *Init) { return true; }
526 bool TraverseLambdaCapture(LambdaExpr::Capture C) { return true; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000527
John Thompson74083922013-09-18 18:19:43 +0000528 // Check 'extern "*" {}' block for #include directives.
529 bool VisitLinkageSpecDecl(LinkageSpecDecl *D) {
530 // Bail if not a block.
531 if (!D->hasBraces())
532 return true;
533 SourceRange BlockRange = D->getSourceRange();
534 const char *LinkageLabel;
535 switch (D->getLanguage()) {
536 case LinkageSpecDecl::lang_c:
537 LinkageLabel = "extern \"C\" {}";
538 break;
539 case LinkageSpecDecl::lang_cxx:
540 LinkageLabel = "extern \"C++\" {}";
541 break;
John Thompson74083922013-09-18 18:19:43 +0000542 }
543 if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, LinkageLabel,
544 errs()))
545 HadErrors = 1;
546 return true;
547 }
548
549 // Check 'namespace (name) {}' block for #include directives.
550 bool VisitNamespaceDecl(const NamespaceDecl *D) {
551 SourceRange BlockRange = D->getSourceRange();
552 std::string Label("namespace ");
553 Label += D->getName();
554 Label += " {}";
555 if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, Label.c_str(),
556 errs()))
557 HadErrors = 1;
558 return true;
559 }
560
561 // Collect definition entities.
John Thompson4f8ba652013-03-12 02:07:30 +0000562 bool VisitNamedDecl(NamedDecl *ND) {
563 // We only care about file-context variables.
564 if (!ND->getDeclContext()->isFileContext())
565 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000566
John Thompson4f8ba652013-03-12 02:07:30 +0000567 // Skip declarations that tend to be properly multiply-declared.
568 if (isa<NamespaceDecl>(ND) || isa<UsingDirectiveDecl>(ND) ||
John Thompsonf5db45b2013-03-27 01:02:46 +0000569 isa<NamespaceAliasDecl>(ND) ||
570 isa<ClassTemplateSpecializationDecl>(ND) || isa<UsingDecl>(ND) ||
John Thompson8e01c062013-08-26 15:17:23 +0000571 isa<ClassTemplateDecl>(ND) || isa<TemplateTypeParmDecl>(ND) ||
John Thompsoncc2e2912013-09-03 18:44:11 +0000572 isa<TypeAliasTemplateDecl>(ND) || isa<UsingShadowDecl>(ND) ||
573 isa<FunctionDecl>(ND) || isa<FunctionTemplateDecl>(ND) ||
John Thompson4f8ba652013-03-12 02:07:30 +0000574 (isa<TagDecl>(ND) &&
575 !cast<TagDecl>(ND)->isThisDeclarationADefinition()))
576 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000577
John Thompson8e01c062013-08-26 15:17:23 +0000578 // Skip anonymous declarations.
579 if (!ND->getDeclName())
580 return true;
581
582 // Get the qualified name.
John Thompsoncc2e2912013-09-03 18:44:11 +0000583 std::string Name;
584 llvm::raw_string_ostream OS(Name);
585 ND->printQualifiedName(OS);
586 OS.flush();
John Thompson4f8ba652013-03-12 02:07:30 +0000587 if (Name.empty())
588 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000589
John Thompson4f8ba652013-03-12 02:07:30 +0000590 Location Loc(SM, ND->getLocation());
591 if (!Loc)
592 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000593
John Thompson52d98862013-03-28 18:38:43 +0000594 Entities.add(Name, isa<TagDecl>(ND) ? Entry::EK_Tag : Entry::EK_Value, Loc);
John Thompson4f8ba652013-03-12 02:07:30 +0000595 return true;
596 }
John Thompson161381e2013-06-27 18:52:23 +0000597
John Thompson1f67ccb2013-03-12 18:51:47 +0000598private:
599 SourceManager &SM;
600 EntityMap &Entities;
John Thompson74083922013-09-18 18:19:43 +0000601 Preprocessor &PP;
602 PreprocessorTracker &PPTracker;
603 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000604};
605
606class CollectEntitiesConsumer : public ASTConsumer {
John Thompson4f8ba652013-03-12 02:07:30 +0000607public:
John Thompson94faa4d2013-07-26 23:56:42 +0000608 CollectEntitiesConsumer(EntityMap &Entities,
609 PreprocessorTracker &preprocessorTracker,
John Thompson74083922013-09-18 18:19:43 +0000610 Preprocessor &PP, StringRef InFile, int &HadErrors)
611 : Entities(Entities), PPTracker(preprocessorTracker), PP(PP),
612 HadErrors(HadErrors) {
John Thompson94faa4d2013-07-26 23:56:42 +0000613 PPTracker.handlePreprocessorEntry(PP, InFile);
614 }
615
616 ~CollectEntitiesConsumer() { PPTracker.handlePreprocessorExit(); }
John Thompsonf5db45b2013-03-27 01:02:46 +0000617
John Thompson4f8ba652013-03-12 02:07:30 +0000618 virtual void HandleTranslationUnit(ASTContext &Ctx) {
619 SourceManager &SM = Ctx.getSourceManager();
John Thompsonf5db45b2013-03-27 01:02:46 +0000620
John Thompson4f8ba652013-03-12 02:07:30 +0000621 // Collect declared entities.
John Thompson74083922013-09-18 18:19:43 +0000622 CollectEntitiesVisitor(SM, Entities, PP, PPTracker, HadErrors)
John Thompsonf5db45b2013-03-27 01:02:46 +0000623 .TraverseDecl(Ctx.getTranslationUnitDecl());
624
John Thompson4f8ba652013-03-12 02:07:30 +0000625 // Collect macro definitions.
626 for (Preprocessor::macro_iterator M = PP.macro_begin(),
John Thompsonf5db45b2013-03-27 01:02:46 +0000627 MEnd = PP.macro_end();
John Thompson4f8ba652013-03-12 02:07:30 +0000628 M != MEnd; ++M) {
629 Location Loc(SM, M->second->getLocation());
630 if (!Loc)
631 continue;
632
John Thompson52d98862013-03-28 18:38:43 +0000633 Entities.add(M->first->getName().str(), Entry::EK_Macro, Loc);
John Thompson4f8ba652013-03-12 02:07:30 +0000634 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000635
John Thompson4f8ba652013-03-12 02:07:30 +0000636 // Merge header contents.
637 Entities.mergeCurHeaderContents();
638 }
John Thompson161381e2013-06-27 18:52:23 +0000639
John Thompson1f67ccb2013-03-12 18:51:47 +0000640private:
641 EntityMap &Entities;
John Thompson94faa4d2013-07-26 23:56:42 +0000642 PreprocessorTracker &PPTracker;
John Thompson1f67ccb2013-03-12 18:51:47 +0000643 Preprocessor &PP;
John Thompson74083922013-09-18 18:19:43 +0000644 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000645};
646
647class CollectEntitiesAction : public SyntaxOnlyAction {
John Thompson1f67ccb2013-03-12 18:51:47 +0000648public:
John Thompson94faa4d2013-07-26 23:56:42 +0000649 CollectEntitiesAction(EntityMap &Entities,
John Thompson74083922013-09-18 18:19:43 +0000650 PreprocessorTracker &preprocessorTracker,
651 int &HadErrors)
652 : Entities(Entities), PPTracker(preprocessorTracker),
653 HadErrors(HadErrors) {}
John Thompson161381e2013-06-27 18:52:23 +0000654
John Thompson4f8ba652013-03-12 02:07:30 +0000655protected:
John Thompson161381e2013-06-27 18:52:23 +0000656 virtual clang::ASTConsumer *CreateASTConsumer(CompilerInstance &CI,
657 StringRef InFile) {
John Thompson94faa4d2013-07-26 23:56:42 +0000658 return new CollectEntitiesConsumer(Entities, PPTracker,
John Thompson74083922013-09-18 18:19:43 +0000659 CI.getPreprocessor(), InFile, HadErrors);
John Thompson4f8ba652013-03-12 02:07:30 +0000660 }
John Thompson161381e2013-06-27 18:52:23 +0000661
John Thompson1f67ccb2013-03-12 18:51:47 +0000662private:
John Thompsonf5db45b2013-03-27 01:02:46 +0000663 EntityMap &Entities;
John Thompson94faa4d2013-07-26 23:56:42 +0000664 PreprocessorTracker &PPTracker;
John Thompson74083922013-09-18 18:19:43 +0000665 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000666};
667
668class ModularizeFrontendActionFactory : public FrontendActionFactory {
John Thompson4f8ba652013-03-12 02:07:30 +0000669public:
John Thompson94faa4d2013-07-26 23:56:42 +0000670 ModularizeFrontendActionFactory(EntityMap &Entities,
John Thompson74083922013-09-18 18:19:43 +0000671 PreprocessorTracker &preprocessorTracker,
672 int &HadErrors)
673 : Entities(Entities), PPTracker(preprocessorTracker),
674 HadErrors(HadErrors) {}
John Thompson4f8ba652013-03-12 02:07:30 +0000675
676 virtual CollectEntitiesAction *create() {
John Thompson74083922013-09-18 18:19:43 +0000677 return new CollectEntitiesAction(Entities, PPTracker, HadErrors);
John Thompson4f8ba652013-03-12 02:07:30 +0000678 }
John Thompson161381e2013-06-27 18:52:23 +0000679
John Thompson1f67ccb2013-03-12 18:51:47 +0000680private:
John Thompsonf5db45b2013-03-27 01:02:46 +0000681 EntityMap &Entities;
John Thompson94faa4d2013-07-26 23:56:42 +0000682 PreprocessorTracker &PPTracker;
John Thompson74083922013-09-18 18:19:43 +0000683 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000684};
685
John Thompsonbb0a3b02013-08-09 13:52:09 +0000686int main(int Argc, const char **Argv) {
John Thompsona2de1082013-03-26 01:17:48 +0000687
John Thompson5ab4f112013-10-15 13:52:33 +0000688 // Save program name for error messages.
689 Argv0 = Argv[0];
690
691 // Save program arguments for use in module.map comment.
692 CommandLine = sys::path::stem(sys::path::filename(Argv0));
693 for (int ArgIndex = 1; ArgIndex < Argc; ArgIndex++) {
694 CommandLine.append(" ");
695 CommandLine.append(Argv[ArgIndex]);
696 }
697
John Thompsona2de1082013-03-26 01:17:48 +0000698 // This causes options to be parsed.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000699 cl::ParseCommandLineOptions(Argc, Argv, "modularize.\n");
John Thompsona2de1082013-03-26 01:17:48 +0000700
701 // No go if we have no header list file.
702 if (ListFileName.size() == 0) {
703 cl::PrintHelpMessage();
John Thompsonea6c8db2013-03-27 21:23:21 +0000704 return 1;
John Thompson4f8ba652013-03-12 02:07:30 +0000705 }
John Thompsona2de1082013-03-26 01:17:48 +0000706
John Thompson7d0213c2013-09-04 20:46:24 +0000707 // Get header file names and dependencies.
John Thompsonf5db45b2013-03-27 01:02:46 +0000708 SmallVector<std::string, 32> Headers;
John Thompson7d0213c2013-09-04 20:46:24 +0000709 DependencyMap Dependencies;
710 if (error_code EC = getHeaderFileNames(Headers, Dependencies, ListFileName,
711 HeaderPrefix)) {
John Thompsonbb0a3b02013-08-09 13:52:09 +0000712 errs() << Argv[0] << ": error: Unable to get header list '" << ListFileName
713 << "': " << EC.message() << '\n';
John Thompsonea6c8db2013-03-27 21:23:21 +0000714 return 1;
John Thompson4f8ba652013-03-12 02:07:30 +0000715 }
John Thompsona2de1082013-03-26 01:17:48 +0000716
John Thompson5ab4f112013-10-15 13:52:33 +0000717 // If we are in assistant mode, output the module map and quit.
John Thompsone744d2b2013-12-10 02:26:44 +0000718 if (ModuleMapPath.length() != 0) {
John Thompson5ab4f112013-10-15 13:52:33 +0000719 if (!createModuleMap(ModuleMapPath, Headers, Dependencies, HeaderPrefix,
720 RootModule))
721 return 1; // Failed.
722 return 0; // Success - Skip checks in assistant mode.
723 }
724
John Thompson4f8ba652013-03-12 02:07:30 +0000725 // Create the compilation database.
John Thompsona2de1082013-03-26 01:17:48 +0000726 SmallString<256> PathBuf;
John Thompsonf5db45b2013-03-27 01:02:46 +0000727 sys::fs::current_path(PathBuf);
728 OwningPtr<CompilationDatabase> Compilations;
729 Compilations.reset(
730 new FixedCompilationDatabase(Twine(PathBuf), CC1Arguments));
John Thompsona2de1082013-03-26 01:17:48 +0000731
John Thompson94faa4d2013-07-26 23:56:42 +0000732 // Create preprocessor tracker, to watch for macro and conditional problems.
733 OwningPtr<PreprocessorTracker> PPTracker(PreprocessorTracker::create());
734
John Thompson4f8ba652013-03-12 02:07:30 +0000735 // Parse all of the headers, detecting duplicates.
736 EntityMap Entities;
737 ClangTool Tool(*Compilations, Headers);
John Thompson7d0213c2013-09-04 20:46:24 +0000738 Tool.appendArgumentsAdjuster(new AddDependenciesAdjuster(Dependencies));
John Thompson74083922013-09-18 18:19:43 +0000739 int HadErrors = 0;
740 HadErrors |= Tool.run(
741 new ModularizeFrontendActionFactory(Entities, *PPTracker, HadErrors));
John Thompsonce601e22013-03-14 01:41:29 +0000742
John Thompson4e4d9b32013-03-28 01:20:19 +0000743 // Create a place to save duplicate entity locations, separate bins per kind.
744 typedef SmallVector<Location, 8> LocationArray;
John Thompson52d98862013-03-28 18:38:43 +0000745 typedef SmallVector<LocationArray, Entry::EK_NumberOfKinds> EntryBinArray;
John Thompson4e4d9b32013-03-28 01:20:19 +0000746 EntryBinArray EntryBins;
John Thompsonbb0a3b02013-08-09 13:52:09 +0000747 int KindIndex;
748 for (KindIndex = 0; KindIndex < Entry::EK_NumberOfKinds; ++KindIndex) {
749 LocationArray Array;
750 EntryBins.push_back(Array);
Michael Gottesman4b249212013-03-28 06:07:15 +0000751 }
John Thompson4e4d9b32013-03-28 01:20:19 +0000752
John Thompson4f8ba652013-03-12 02:07:30 +0000753 // Check for the same entity being defined in multiple places.
754 for (EntityMap::iterator E = Entities.begin(), EEnd = Entities.end();
755 E != EEnd; ++E) {
Alp Toker9a5134e2013-12-01 05:08:12 +0000756 // If only one occurrence, exit early.
John Thompson4e4d9b32013-03-28 01:20:19 +0000757 if (E->second.size() == 1)
758 continue;
759 // Clear entity locations.
760 for (EntryBinArray::iterator CI = EntryBins.begin(), CE = EntryBins.end();
761 CI != CE; ++CI) {
John Thompson52d98862013-03-28 18:38:43 +0000762 CI->clear();
John Thompson4e4d9b32013-03-28 01:20:19 +0000763 }
764 // Walk the entities of a single name, collecting the locations,
765 // separated into separate bins.
John Thompson4f8ba652013-03-12 02:07:30 +0000766 for (unsigned I = 0, N = E->second.size(); I != N; ++I) {
John Thompson52d98862013-03-28 18:38:43 +0000767 EntryBins[E->second[I].Kind].push_back(E->second[I].Loc);
John Thompson4e4d9b32013-03-28 01:20:19 +0000768 }
769 // Report any duplicate entity definition errors.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000770 int KindIndex = 0;
John Thompson4e4d9b32013-03-28 01:20:19 +0000771 for (EntryBinArray::iterator DI = EntryBins.begin(), DE = EntryBins.end();
John Thompsonbb0a3b02013-08-09 13:52:09 +0000772 DI != DE; ++DI, ++KindIndex) {
773 int ECount = DI->size();
John Thompsonabe79d92013-12-04 20:41:30 +0000774 // If only 1 occurrence of this entity, skip it, as we only report duplicates.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000775 if (ECount <= 1)
John Thompson4f8ba652013-03-12 02:07:30 +0000776 continue;
John Thompson52d98862013-03-28 18:38:43 +0000777 LocationArray::iterator FI = DI->begin();
John Thompsonbb0a3b02013-08-09 13:52:09 +0000778 StringRef kindName = Entry::getKindName((Entry::EntryKind)KindIndex);
John Thompson4e4d9b32013-03-28 01:20:19 +0000779 errs() << "error: " << kindName << " '" << E->first()
780 << "' defined at multiple locations:\n";
John Thompson52d98862013-03-28 18:38:43 +0000781 for (LocationArray::iterator FE = DI->end(); FI != FE; ++FI) {
John Thompson4e4d9b32013-03-28 01:20:19 +0000782 errs() << " " << FI->File->getName() << ":" << FI->Line << ":"
783 << FI->Column << "\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000784 }
John Thompson4f8ba652013-03-12 02:07:30 +0000785 HadErrors = 1;
786 }
787 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000788
John Thompson94faa4d2013-07-26 23:56:42 +0000789 // Complain about macro instance in header files that differ based on how
790 // they are included.
791 if (PPTracker->reportInconsistentMacros(errs()))
792 HadErrors = 1;
793
794 // Complain about preprocessor conditional directives in header files that
795 // differ based on how they are included.
796 if (PPTracker->reportInconsistentConditionals(errs()))
797 HadErrors = 1;
798
John Thompson4f8ba652013-03-12 02:07:30 +0000799 // Complain about any headers that have contents that differ based on how
800 // they are included.
John Thompsonce601e22013-03-14 01:41:29 +0000801 // FIXME: Could we provide information about which preprocessor conditionals
802 // are involved?
John Thompsonf5db45b2013-03-27 01:02:46 +0000803 for (DenseMap<const FileEntry *, HeaderContents>::iterator
804 H = Entities.HeaderContentMismatches.begin(),
805 HEnd = Entities.HeaderContentMismatches.end();
John Thompson4f8ba652013-03-12 02:07:30 +0000806 H != HEnd; ++H) {
807 if (H->second.empty()) {
John Thompsonf5db45b2013-03-27 01:02:46 +0000808 errs() << "internal error: phantom header content mismatch\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000809 continue;
810 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000811
John Thompson4f8ba652013-03-12 02:07:30 +0000812 HadErrors = 1;
John Thompsonf5db45b2013-03-27 01:02:46 +0000813 errs() << "error: header '" << H->first->getName()
John Thompson94faa4d2013-07-26 23:56:42 +0000814 << "' has different contents depending on how it was included.\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000815 for (unsigned I = 0, N = H->second.size(); I != N; ++I) {
John Thompson161381e2013-06-27 18:52:23 +0000816 errs() << "note: '" << H->second[I].Name << "' in "
817 << H->second[I].Loc.File->getName() << " at "
818 << H->second[I].Loc.Line << ":" << H->second[I].Loc.Column
819 << " not always provided\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000820 }
821 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000822
John Thompson4f8ba652013-03-12 02:07:30 +0000823 return HadErrors;
824}