blob: f2c15e5e5598482283435725ad5f4f5e0d28ad2d [file] [log] [blame]
Alexander Kornienkoe04dd252016-01-19 16:10:39 +00001#!/usr/bin/env python
Alexander Kornienko1de35e72014-06-25 14:09:52 +00002#
3#===- clang-tidy-diff.py - ClangTidy Diff Checker ------------*- python -*--===#
4#
5# The LLVM Compiler Infrastructure
6#
7# This file is distributed under the University of Illinois Open Source
8# License. See LICENSE.TXT for details.
9#
10#===------------------------------------------------------------------------===#
11
12r"""
13ClangTidy Diff Checker
14======================
15
16This script reads input from a unified diff, runs clang-tidy on all changed
17files and outputs clang-tidy warnings in changed lines only. This is useful to
18detect clang-tidy regressions in the lines touched by a specific patch.
19Example usage for git/svn users:
20
21 git diff -U0 HEAD^ | clang-tidy-diff.py -p1
22 svn diff --diff-cmd=diff -x-U0 | \
Alexander Kornienko13952532015-09-15 13:13:48 +000023 clang-tidy-diff.py -fix -checks=-*,modernize-use-override
Alexander Kornienko1de35e72014-06-25 14:09:52 +000024
25"""
26
27import argparse
28import json
29import re
30import subprocess
31import sys
32
33
34def main():
35 parser = argparse.ArgumentParser(description=
Alexander Kornienkofb90b512016-06-08 14:27:43 +000036 'Run clang-tidy against changed files, and '
37 'output diagnostics only for modified '
38 'lines.')
Alexander Kornienko1de35e72014-06-25 14:09:52 +000039 parser.add_argument('-clang-tidy-binary', metavar='PATH',
40 default='clang-tidy',
41 help='path to clang-tidy binary')
42 parser.add_argument('-p', metavar='NUM', default=0,
43 help='strip the smallest prefix containing P slashes')
44 parser.add_argument('-regex', metavar='PATTERN', default=None,
Alexander Kornienkofb90b512016-06-08 14:27:43 +000045 help='custom pattern selecting file paths to check '
Alexander Kornienko1de35e72014-06-25 14:09:52 +000046 '(case sensitive, overrides -iregex)')
47 parser.add_argument('-iregex', metavar='PATTERN', default=
48 r'.*\.(cpp|cc|c\+\+|cxx|c|cl|h|hpp|m|mm|inc)',
Alexander Kornienkofb90b512016-06-08 14:27:43 +000049 help='custom pattern selecting file paths to check '
Alexander Kornienko1de35e72014-06-25 14:09:52 +000050 '(case insensitive, overridden by -regex)')
51
52 parser.add_argument('-fix', action='store_true', default=False,
53 help='apply suggested fixes')
54 parser.add_argument('-checks',
55 help='checks filter, when not specified, use clang-tidy '
56 'default',
57 default='')
Ehsan Akhgarifae3ac32017-02-17 19:31:43 +000058 parser.add_argument('-path', dest='build_path',
59 help='Path used to read a compile command database.')
Ehsan Akhgari3bceebb2017-02-08 17:50:24 +000060 parser.add_argument('-extra-arg', dest='extra_arg',
61 action='append', default=[],
62 help='Additional argument to append to the compiler '
63 'command line.')
64 parser.add_argument('-extra-arg-before', dest='extra_arg_before',
65 action='append', default=[],
66 help='Additional argument to prepend to the compiler '
67 'command line.')
Ehsan Akhgarib7418d32017-02-09 18:32:02 +000068 parser.add_argument('-quiet', action='store_true', default=False,
69 help='Run clang-tidy in quiet mode')
Alexander Kornienko1de35e72014-06-25 14:09:52 +000070 clang_tidy_args = []
71 argv = sys.argv[1:]
72 if '--' in argv:
73 clang_tidy_args.extend(argv[argv.index('--'):])
74 argv = argv[:argv.index('--')]
75
76 args = parser.parse_args(argv)
77
78 # Extract changed lines for each file.
79 filename = None
80 lines_by_file = {}
81 for line in sys.stdin:
Yaron Keren95e6d9e2015-09-01 19:08:17 +000082 match = re.search('^\+\+\+\ \"?(.*?/){%s}([^ \t\n\"]*)' % args.p, line)
Alexander Kornienko1de35e72014-06-25 14:09:52 +000083 if match:
84 filename = match.group(2)
85 if filename == None:
86 continue
87
88 if args.regex is not None:
89 if not re.match('^%s$' % args.regex, filename):
90 continue
91 else:
92 if not re.match('^%s$' % args.iregex, filename, re.IGNORECASE):
93 continue
94
95 match = re.search('^@@.*\+(\d+)(,(\d+))?', line)
96 if match:
97 start_line = int(match.group(1))
98 line_count = 1
99 if match.group(3):
100 line_count = int(match.group(3))
101 if line_count == 0:
102 continue
103 end_line = start_line + line_count - 1;
104 lines_by_file.setdefault(filename, []).append([start_line, end_line])
105
106 if len(lines_by_file) == 0:
NAKAMURA Takumi360096e2014-06-27 01:10:18 +0000107 print("No relevant changes found.")
Alexander Kornienko1de35e72014-06-25 14:09:52 +0000108 sys.exit(0)
109
110 line_filter_json = json.dumps(
111 [{"name" : name, "lines" : lines_by_file[name]} for name in lines_by_file],
112 separators = (',', ':'))
113
NAKAMURA Takumiae6b3292015-08-20 15:04:46 +0000114 quote = "";
115 if sys.platform == 'win32':
116 line_filter_json=re.sub(r'"', r'"""', line_filter_json)
117 else:
118 quote = "'";
119
Alexander Kornienko1de35e72014-06-25 14:09:52 +0000120 # Run clang-tidy on files containing changes.
121 command = [args.clang_tidy_binary]
NAKAMURA Takumiae6b3292015-08-20 15:04:46 +0000122 command.append('-line-filter=' + quote + line_filter_json + quote)
Alexander Kornienko1de35e72014-06-25 14:09:52 +0000123 if args.fix:
124 command.append('-fix')
125 if args.checks != '':
NAKAMURA Takumiae6b3292015-08-20 15:04:46 +0000126 command.append('-checks=' + quote + args.checks + quote)
Ehsan Akhgarib7418d32017-02-09 18:32:02 +0000127 if args.quiet:
128 command.append('-quiet')
Ehsan Akhgarifae3ac32017-02-17 19:31:43 +0000129 if args.build_path is not None:
130 command.append('-p=%s' % args.build_path)
Alexander Kornienko1de35e72014-06-25 14:09:52 +0000131 command.extend(lines_by_file.keys())
Ehsan Akhgari3bceebb2017-02-08 17:50:24 +0000132 for arg in args.extra_arg:
133 command.append('-extra-arg=%s' % arg)
134 for arg in args.extra_arg_before:
135 command.append('-extra-arg-before=%s' % arg)
Alexander Kornienko1de35e72014-06-25 14:09:52 +0000136 command.extend(clang_tidy_args)
137
138 sys.exit(subprocess.call(' '.join(command), shell=True))
139
140if __name__ == '__main__':
141 main()