James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 1 | //===-- AArch64A57FPLoadBalancing.cpp - Balance FP ops statically on A57---===// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // For best-case performance on Cortex-A57, we should try to use a balanced |
| 10 | // mix of odd and even D-registers when performing a critical sequence of |
| 11 | // independent, non-quadword FP/ASIMD floating-point multiply or |
| 12 | // multiply-accumulate operations. |
| 13 | // |
| 14 | // This pass attempts to detect situations where the register allocation may |
| 15 | // adversely affect this load balancing and to change the registers used so as |
| 16 | // to better utilize the CPU. |
| 17 | // |
| 18 | // Ideally we'd just take each multiply or multiply-accumulate in turn and |
| 19 | // allocate it alternating even or odd registers. However, multiply-accumulates |
| 20 | // are most efficiently performed in the same functional unit as their |
| 21 | // accumulation operand. Therefore this pass tries to find maximal sequences |
| 22 | // ("Chains") of multiply-accumulates linked via their accumulation operand, |
| 23 | // and assign them all the same "color" (oddness/evenness). |
| 24 | // |
| 25 | // This optimization affects S-register and D-register floating point |
| 26 | // multiplies and FMADD/FMAs, as well as vector (floating point only) muls and |
| 27 | // FMADD/FMA. Q register instructions (and 128-bit vector instructions) are |
| 28 | // not affected. |
| 29 | //===----------------------------------------------------------------------===// |
| 30 | |
| 31 | #include "AArch64.h" |
| 32 | #include "AArch64InstrInfo.h" |
| 33 | #include "AArch64Subtarget.h" |
| 34 | #include "llvm/ADT/BitVector.h" |
| 35 | #include "llvm/ADT/EquivalenceClasses.h" |
| 36 | #include "llvm/CodeGen/MachineFunction.h" |
| 37 | #include "llvm/CodeGen/MachineFunctionPass.h" |
| 38 | #include "llvm/CodeGen/MachineInstr.h" |
| 39 | #include "llvm/CodeGen/MachineInstrBuilder.h" |
| 40 | #include "llvm/CodeGen/MachineRegisterInfo.h" |
| 41 | #include "llvm/CodeGen/RegisterScavenging.h" |
| 42 | #include "llvm/CodeGen/RegisterClassInfo.h" |
| 43 | #include "llvm/Support/CommandLine.h" |
| 44 | #include "llvm/Support/Debug.h" |
| 45 | #include "llvm/Support/raw_ostream.h" |
| 46 | #include <list> |
| 47 | using namespace llvm; |
| 48 | |
| 49 | #define DEBUG_TYPE "aarch64-a57-fp-load-balancing" |
| 50 | |
| 51 | // Enforce the algorithm to use the scavenged register even when the original |
| 52 | // destination register is the correct color. Used for testing. |
| 53 | static cl::opt<bool> |
| 54 | TransformAll("aarch64-a57-fp-load-balancing-force-all", |
| 55 | cl::desc("Always modify dest registers regardless of color"), |
| 56 | cl::init(false), cl::Hidden); |
| 57 | |
| 58 | // Never use the balance information obtained from chains - return a specific |
| 59 | // color always. Used for testing. |
| 60 | static cl::opt<unsigned> |
| 61 | OverrideBalance("aarch64-a57-fp-load-balancing-override", |
| 62 | cl::desc("Ignore balance information, always return " |
| 63 | "(1: Even, 2: Odd)."), |
| 64 | cl::init(0), cl::Hidden); |
| 65 | |
| 66 | //===----------------------------------------------------------------------===// |
| 67 | // Helper functions |
| 68 | |
| 69 | // Is the instruction a type of multiply on 64-bit (or 32-bit) FPRs? |
| 70 | static bool isMul(MachineInstr *MI) { |
| 71 | switch (MI->getOpcode()) { |
| 72 | case AArch64::FMULSrr: |
| 73 | case AArch64::FNMULSrr: |
| 74 | case AArch64::FMULDrr: |
| 75 | case AArch64::FNMULDrr: |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 76 | return true; |
| 77 | default: |
| 78 | return false; |
| 79 | } |
| 80 | } |
| 81 | |
| 82 | // Is the instruction a type of FP multiply-accumulate on 64-bit (or 32-bit) FPRs? |
| 83 | static bool isMla(MachineInstr *MI) { |
| 84 | switch (MI->getOpcode()) { |
| 85 | case AArch64::FMSUBSrrr: |
| 86 | case AArch64::FMADDSrrr: |
| 87 | case AArch64::FNMSUBSrrr: |
| 88 | case AArch64::FNMADDSrrr: |
| 89 | case AArch64::FMSUBDrrr: |
| 90 | case AArch64::FMADDDrrr: |
| 91 | case AArch64::FNMSUBDrrr: |
| 92 | case AArch64::FNMADDDrrr: |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 93 | return true; |
| 94 | default: |
| 95 | return false; |
| 96 | } |
| 97 | } |
| 98 | |
| 99 | //===----------------------------------------------------------------------===// |
| 100 | |
| 101 | namespace { |
| 102 | /// A "color", which is either even or odd. Yes, these aren't really colors |
| 103 | /// but the algorithm is conceptually doing two-color graph coloring. |
| 104 | enum class Color { Even, Odd }; |
NAKAMURA Takumi | 08e30fd | 2014-08-08 17:00:59 +0000 | [diff] [blame] | 105 | #ifndef NDEBUG |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 106 | static const char *ColorNames[2] = { "Even", "Odd" }; |
NAKAMURA Takumi | 08e30fd | 2014-08-08 17:00:59 +0000 | [diff] [blame] | 107 | #endif |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 108 | |
| 109 | class Chain; |
| 110 | |
| 111 | class AArch64A57FPLoadBalancing : public MachineFunctionPass { |
| 112 | const AArch64InstrInfo *TII; |
| 113 | MachineRegisterInfo *MRI; |
| 114 | const TargetRegisterInfo *TRI; |
| 115 | RegisterClassInfo RCI; |
| 116 | |
| 117 | public: |
| 118 | static char ID; |
| 119 | explicit AArch64A57FPLoadBalancing() : MachineFunctionPass(ID) {} |
| 120 | |
| 121 | bool runOnMachineFunction(MachineFunction &F) override; |
| 122 | |
| 123 | const char *getPassName() const override { |
| 124 | return "A57 FP Anti-dependency breaker"; |
| 125 | } |
| 126 | |
| 127 | void getAnalysisUsage(AnalysisUsage &AU) const override { |
| 128 | AU.setPreservesCFG(); |
| 129 | MachineFunctionPass::getAnalysisUsage(AU); |
| 130 | } |
| 131 | |
| 132 | private: |
| 133 | bool runOnBasicBlock(MachineBasicBlock &MBB); |
| 134 | bool colorChainSet(std::vector<Chain*> GV, MachineBasicBlock &MBB, |
| 135 | int &Balance); |
| 136 | bool colorChain(Chain *G, Color C, MachineBasicBlock &MBB); |
| 137 | int scavengeRegister(Chain *G, Color C, MachineBasicBlock &MBB); |
| 138 | void scanInstruction(MachineInstr *MI, unsigned Idx, |
James Molloy | f0de7e5 | 2014-09-12 14:35:17 +0000 | [diff] [blame] | 139 | std::map<unsigned, Chain*> &Active, |
| 140 | std::set<std::unique_ptr<Chain>> &AllChains); |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 141 | void maybeKillChain(MachineOperand &MO, unsigned Idx, |
| 142 | std::map<unsigned, Chain*> &RegChains); |
| 143 | Color getColor(unsigned Register); |
| 144 | Chain *getAndEraseNext(Color PreferredColor, std::vector<Chain*> &L); |
| 145 | }; |
| 146 | char AArch64A57FPLoadBalancing::ID = 0; |
| 147 | |
| 148 | /// A Chain is a sequence of instructions that are linked together by |
| 149 | /// an accumulation operand. For example: |
| 150 | /// |
| 151 | /// fmul d0<def>, ? |
| 152 | /// fmla d1<def>, ?, ?, d0<kill> |
| 153 | /// fmla d2<def>, ?, ?, d1<kill> |
| 154 | /// |
| 155 | /// There may be other instructions interleaved in the sequence that |
| 156 | /// do not belong to the chain. These other instructions must not use |
| 157 | /// the "chain" register at any point. |
| 158 | /// |
| 159 | /// We currently only support chains where the "chain" operand is killed |
| 160 | /// at each link in the chain for simplicity. |
| 161 | /// A chain has three important instructions - Start, Last and Kill. |
| 162 | /// * The start instruction is the first instruction in the chain. |
| 163 | /// * Last is the final instruction in the chain. |
| 164 | /// * Kill may or may not be defined. If defined, Kill is the instruction |
| 165 | /// where the outgoing value of the Last instruction is killed. |
| 166 | /// This information is important as if we know the outgoing value is |
| 167 | /// killed with no intervening uses, we can safely change its register. |
| 168 | /// |
| 169 | /// Without a kill instruction, we must assume the outgoing value escapes |
| 170 | /// beyond our model and either must not change its register or must |
| 171 | /// create a fixup FMOV to keep the old register value consistent. |
| 172 | /// |
| 173 | class Chain { |
| 174 | public: |
| 175 | /// The important (marker) instructions. |
| 176 | MachineInstr *StartInst, *LastInst, *KillInst; |
| 177 | /// The index, from the start of the basic block, that each marker |
| 178 | /// appears. These are stored so we can do quick interval tests. |
| 179 | unsigned StartInstIdx, LastInstIdx, KillInstIdx; |
| 180 | /// All instructions in the chain. |
| 181 | std::set<MachineInstr*> Insts; |
| 182 | /// True if KillInst cannot be modified. If this is true, |
| 183 | /// we cannot change LastInst's outgoing register. |
| 184 | /// This will be true for tied values and regmasks. |
| 185 | bool KillIsImmutable; |
| 186 | /// The "color" of LastInst. This will be the preferred chain color, |
| 187 | /// as changing intermediate nodes is easy but changing the last |
| 188 | /// instruction can be more tricky. |
| 189 | Color LastColor; |
| 190 | |
Arnaud A. de Grandmaison | 6afbf2a | 2014-08-29 09:54:11 +0000 | [diff] [blame] | 191 | Chain(MachineInstr *MI, unsigned Idx, Color C) |
| 192 | : StartInst(MI), LastInst(MI), KillInst(nullptr), |
| 193 | StartInstIdx(Idx), LastInstIdx(Idx), KillInstIdx(0), |
| 194 | LastColor(C) { |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 195 | Insts.insert(MI); |
| 196 | } |
| 197 | |
| 198 | /// Add a new instruction into the chain. The instruction's dest operand |
| 199 | /// has the given color. |
| 200 | void add(MachineInstr *MI, unsigned Idx, Color C) { |
| 201 | LastInst = MI; |
| 202 | LastInstIdx = Idx; |
| 203 | LastColor = C; |
Arnaud A. de Grandmaison | 6afbf2a | 2014-08-29 09:54:11 +0000 | [diff] [blame] | 204 | assert((KillInstIdx == 0 || LastInstIdx < KillInstIdx) && |
| 205 | "Chain: broken invariant. A Chain can only be killed after its last " |
| 206 | "def"); |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 207 | |
| 208 | Insts.insert(MI); |
| 209 | } |
| 210 | |
| 211 | /// Return true if MI is a member of the chain. |
| 212 | bool contains(MachineInstr *MI) { return Insts.count(MI) > 0; } |
| 213 | |
| 214 | /// Return the number of instructions in the chain. |
| 215 | unsigned size() const { |
| 216 | return Insts.size(); |
| 217 | } |
| 218 | |
| 219 | /// Inform the chain that its last active register (the dest register of |
| 220 | /// LastInst) is killed by MI with no intervening uses or defs. |
| 221 | void setKill(MachineInstr *MI, unsigned Idx, bool Immutable) { |
| 222 | KillInst = MI; |
| 223 | KillInstIdx = Idx; |
| 224 | KillIsImmutable = Immutable; |
Arnaud A. de Grandmaison | 6afbf2a | 2014-08-29 09:54:11 +0000 | [diff] [blame] | 225 | assert((KillInstIdx == 0 || LastInstIdx < KillInstIdx) && |
| 226 | "Chain: broken invariant. A Chain can only be killed after its last " |
| 227 | "def"); |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 228 | } |
| 229 | |
| 230 | /// Return the first instruction in the chain. |
| 231 | MachineInstr *getStart() const { return StartInst; } |
| 232 | /// Return the last instruction in the chain. |
| 233 | MachineInstr *getLast() const { return LastInst; } |
| 234 | /// Return the "kill" instruction (as set with setKill()) or NULL. |
| 235 | MachineInstr *getKill() const { return KillInst; } |
| 236 | /// Return an instruction that can be used as an iterator for the end |
| 237 | /// of the chain. This is the maximum of KillInst (if set) and LastInst. |
James Molloy | 36b8a88 | 2014-08-26 13:41:31 +0000 | [diff] [blame] | 238 | MachineBasicBlock::iterator getEnd() const { |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 239 | return ++MachineBasicBlock::iterator(KillInst ? KillInst : LastInst); |
| 240 | } |
| 241 | |
| 242 | /// Can the Kill instruction (assuming one exists) be modified? |
| 243 | bool isKillImmutable() const { return KillIsImmutable; } |
| 244 | |
| 245 | /// Return the preferred color of this chain. |
| 246 | Color getPreferredColor() { |
| 247 | if (OverrideBalance != 0) |
| 248 | return OverrideBalance == 1 ? Color::Even : Color::Odd; |
| 249 | return LastColor; |
| 250 | } |
| 251 | |
| 252 | /// Return true if this chain (StartInst..KillInst) overlaps with Other. |
James Molloy | f0de7e5 | 2014-09-12 14:35:17 +0000 | [diff] [blame] | 253 | bool rangeOverlapsWith(const Chain &Other) const { |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 254 | unsigned End = KillInst ? KillInstIdx : LastInstIdx; |
James Molloy | f0de7e5 | 2014-09-12 14:35:17 +0000 | [diff] [blame] | 255 | unsigned OtherEnd = Other.KillInst ? |
| 256 | Other.KillInstIdx : Other.LastInstIdx; |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 257 | |
James Molloy | f0de7e5 | 2014-09-12 14:35:17 +0000 | [diff] [blame] | 258 | return StartInstIdx <= OtherEnd && Other.StartInstIdx <= End; |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 259 | } |
| 260 | |
| 261 | /// Return true if this chain starts before Other. |
| 262 | bool startsBefore(Chain *Other) { |
| 263 | return StartInstIdx < Other->StartInstIdx; |
| 264 | } |
| 265 | |
| 266 | /// Return true if the group will require a fixup MOV at the end. |
| 267 | bool requiresFixup() const { |
| 268 | return (getKill() && isKillImmutable()) || !getKill(); |
| 269 | } |
| 270 | |
| 271 | /// Return a simple string representation of the chain. |
| 272 | std::string str() const { |
| 273 | std::string S; |
| 274 | raw_string_ostream OS(S); |
| 275 | |
| 276 | OS << "{"; |
| 277 | StartInst->print(OS, NULL, true); |
| 278 | OS << " -> "; |
| 279 | LastInst->print(OS, NULL, true); |
| 280 | if (KillInst) { |
| 281 | OS << " (kill @ "; |
| 282 | KillInst->print(OS, NULL, true); |
| 283 | OS << ")"; |
| 284 | } |
| 285 | OS << "}"; |
| 286 | |
| 287 | return OS.str(); |
| 288 | } |
| 289 | |
| 290 | }; |
| 291 | |
| 292 | } // end anonymous namespace |
| 293 | |
| 294 | //===----------------------------------------------------------------------===// |
| 295 | |
| 296 | bool AArch64A57FPLoadBalancing::runOnMachineFunction(MachineFunction &F) { |
| 297 | bool Changed = false; |
| 298 | DEBUG(dbgs() << "***** AArch64A57FPLoadBalancing *****\n"); |
| 299 | |
| 300 | const TargetMachine &TM = F.getTarget(); |
| 301 | MRI = &F.getRegInfo(); |
| 302 | TRI = F.getRegInfo().getTargetRegisterInfo(); |
| 303 | TII = TM.getSubtarget<AArch64Subtarget>().getInstrInfo(); |
| 304 | RCI.runOnMachineFunction(F); |
| 305 | |
| 306 | for (auto &MBB : F) { |
| 307 | Changed |= runOnBasicBlock(MBB); |
| 308 | } |
| 309 | |
| 310 | return Changed; |
| 311 | } |
| 312 | |
| 313 | bool AArch64A57FPLoadBalancing::runOnBasicBlock(MachineBasicBlock &MBB) { |
| 314 | bool Changed = false; |
| 315 | DEBUG(dbgs() << "Running on MBB: " << MBB << " - scanning instructions...\n"); |
| 316 | |
| 317 | // First, scan the basic block producing a set of chains. |
| 318 | |
| 319 | // The currently "active" chains - chains that can be added to and haven't |
| 320 | // been killed yet. This is keyed by register - all chains can only have one |
| 321 | // "link" register between each inst in the chain. |
| 322 | std::map<unsigned, Chain*> ActiveChains; |
James Molloy | f0de7e5 | 2014-09-12 14:35:17 +0000 | [diff] [blame] | 323 | std::set<std::unique_ptr<Chain>> AllChains; |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 324 | unsigned Idx = 0; |
| 325 | for (auto &MI : MBB) |
| 326 | scanInstruction(&MI, Idx++, ActiveChains, AllChains); |
| 327 | |
| 328 | DEBUG(dbgs() << "Scan complete, "<< AllChains.size() << " chains created.\n"); |
| 329 | |
| 330 | // Group the chains into disjoint sets based on their liveness range. This is |
| 331 | // a poor-man's version of graph coloring. Ideally we'd create an interference |
| 332 | // graph and perform full-on graph coloring on that, but; |
| 333 | // (a) That's rather heavyweight for only two colors. |
| 334 | // (b) We expect multiple disjoint interference regions - in practice the live |
| 335 | // range of chains is quite small and they are clustered between loads |
| 336 | // and stores. |
| 337 | EquivalenceClasses<Chain*> EC; |
James Molloy | f0de7e5 | 2014-09-12 14:35:17 +0000 | [diff] [blame] | 338 | for (auto &I : AllChains) |
| 339 | EC.insert(I.get()); |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 340 | |
James Molloy | f0de7e5 | 2014-09-12 14:35:17 +0000 | [diff] [blame] | 341 | for (auto &I : AllChains) |
| 342 | for (auto &J : AllChains) |
| 343 | if (I != J && I->rangeOverlapsWith(*J)) |
| 344 | EC.unionSets(I.get(), J.get()); |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 345 | DEBUG(dbgs() << "Created " << EC.getNumClasses() << " disjoint sets.\n"); |
| 346 | |
| 347 | // Now we assume that every member of an equivalence class interferes |
| 348 | // with every other member of that class, and with no members of other classes. |
| 349 | |
| 350 | // Convert the EquivalenceClasses to a simpler set of sets. |
| 351 | std::vector<std::vector<Chain*> > V; |
| 352 | for (auto I = EC.begin(), E = EC.end(); I != E; ++I) { |
| 353 | std::vector<Chain*> Cs(EC.member_begin(I), EC.member_end()); |
| 354 | if (Cs.empty()) continue; |
Benjamin Kramer | e12a6ba | 2014-10-03 18:33:16 +0000 | [diff] [blame] | 355 | V.push_back(std::move(Cs)); |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 356 | } |
| 357 | |
| 358 | // Now we have a set of sets, order them by start address so |
| 359 | // we can iterate over them sequentially. |
| 360 | std::sort(V.begin(), V.end(), |
| 361 | [](const std::vector<Chain*> &A, |
| 362 | const std::vector<Chain*> &B) { |
| 363 | return A.front()->startsBefore(B.front()); |
| 364 | }); |
| 365 | |
| 366 | // As we only have two colors, we can track the global (BB-level) balance of |
| 367 | // odds versus evens. We aim to keep this near zero to keep both execution |
| 368 | // units fed. |
| 369 | // Positive means we're even-heavy, negative we're odd-heavy. |
| 370 | // |
| 371 | // FIXME: If chains have interdependencies, for example: |
| 372 | // mul r0, r1, r2 |
| 373 | // mul r3, r0, r1 |
| 374 | // We do not model this and may color each one differently, assuming we'll |
| 375 | // get ILP when we obviously can't. This hasn't been seen to be a problem |
| 376 | // in practice so far, so we simplify the algorithm by ignoring it. |
| 377 | int Parity = 0; |
| 378 | |
| 379 | for (auto &I : V) |
Benjamin Kramer | e12a6ba | 2014-10-03 18:33:16 +0000 | [diff] [blame] | 380 | Changed |= colorChainSet(std::move(I), MBB, Parity); |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 381 | |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 382 | return Changed; |
| 383 | } |
| 384 | |
| 385 | Chain *AArch64A57FPLoadBalancing::getAndEraseNext(Color PreferredColor, |
| 386 | std::vector<Chain*> &L) { |
| 387 | if (L.empty()) |
| 388 | return nullptr; |
| 389 | |
| 390 | // We try and get the best candidate from L to color next, given that our |
| 391 | // preferred color is "PreferredColor". L is ordered from larger to smaller |
| 392 | // chains. It is beneficial to color the large chains before the small chains, |
| 393 | // but if we can't find a chain of the maximum length with the preferred color, |
| 394 | // we fuzz the size and look for slightly smaller chains before giving up and |
| 395 | // returning a chain that must be recolored. |
| 396 | |
| 397 | // FIXME: Does this need to be configurable? |
| 398 | const unsigned SizeFuzz = 1; |
| 399 | unsigned MinSize = L.front()->size() - SizeFuzz; |
| 400 | for (auto I = L.begin(), E = L.end(); I != E; ++I) { |
| 401 | if ((*I)->size() <= MinSize) { |
| 402 | // We've gone past the size limit. Return the previous item. |
| 403 | Chain *Ch = *--I; |
| 404 | L.erase(I); |
| 405 | return Ch; |
| 406 | } |
| 407 | |
| 408 | if ((*I)->getPreferredColor() == PreferredColor) { |
| 409 | Chain *Ch = *I; |
| 410 | L.erase(I); |
| 411 | return Ch; |
| 412 | } |
| 413 | } |
| 414 | |
| 415 | // Bailout case - just return the first item. |
| 416 | Chain *Ch = L.front(); |
| 417 | L.erase(L.begin()); |
| 418 | return Ch; |
| 419 | } |
| 420 | |
| 421 | bool AArch64A57FPLoadBalancing::colorChainSet(std::vector<Chain*> GV, |
| 422 | MachineBasicBlock &MBB, |
| 423 | int &Parity) { |
| 424 | bool Changed = false; |
| 425 | DEBUG(dbgs() << "colorChainSet(): #sets=" << GV.size() << "\n"); |
| 426 | |
| 427 | // Sort by descending size order so that we allocate the most important |
| 428 | // sets first. |
| 429 | // Tie-break equivalent sizes by sorting chains requiring fixups before |
| 430 | // those without fixups. The logic here is that we should look at the |
| 431 | // chains that we cannot change before we look at those we can, |
| 432 | // so the parity counter is updated and we know what color we should |
| 433 | // change them to! |
| 434 | std::sort(GV.begin(), GV.end(), [](const Chain *G1, const Chain *G2) { |
| 435 | if (G1->size() != G2->size()) |
| 436 | return G1->size() > G2->size(); |
| 437 | return G1->requiresFixup() > G2->requiresFixup(); |
| 438 | }); |
| 439 | |
| 440 | Color PreferredColor = Parity < 0 ? Color::Even : Color::Odd; |
| 441 | while (Chain *G = getAndEraseNext(PreferredColor, GV)) { |
| 442 | // Start off by assuming we'll color to our own preferred color. |
| 443 | Color C = PreferredColor; |
| 444 | if (Parity == 0) |
| 445 | // But if we really don't care, use the chain's preferred color. |
| 446 | C = G->getPreferredColor(); |
| 447 | |
| 448 | DEBUG(dbgs() << " - Parity=" << Parity << ", Color=" |
| 449 | << ColorNames[(int)C] << "\n"); |
| 450 | |
| 451 | // If we'll need a fixup FMOV, don't bother. Testing has shown that this |
| 452 | // happens infrequently and when it does it has at least a 50% chance of |
| 453 | // slowing code down instead of speeding it up. |
| 454 | if (G->requiresFixup() && C != G->getPreferredColor()) { |
| 455 | C = G->getPreferredColor(); |
| 456 | DEBUG(dbgs() << " - " << G->str() << " - not worthwhile changing; " |
| 457 | "color remains " << ColorNames[(int)C] << "\n"); |
| 458 | } |
| 459 | |
| 460 | Changed |= colorChain(G, C, MBB); |
| 461 | |
| 462 | Parity += (C == Color::Even) ? G->size() : -G->size(); |
| 463 | PreferredColor = Parity < 0 ? Color::Even : Color::Odd; |
| 464 | } |
| 465 | |
| 466 | return Changed; |
| 467 | } |
| 468 | |
| 469 | int AArch64A57FPLoadBalancing::scavengeRegister(Chain *G, Color C, |
| 470 | MachineBasicBlock &MBB) { |
| 471 | RegScavenger RS; |
| 472 | RS.enterBasicBlock(&MBB); |
| 473 | RS.forward(MachineBasicBlock::iterator(G->getStart())); |
| 474 | |
| 475 | // Can we find an appropriate register that is available throughout the life |
| 476 | // of the chain? |
| 477 | unsigned RegClassID = G->getStart()->getDesc().OpInfo[0].RegClass; |
| 478 | BitVector AvailableRegs = RS.getRegsAvailable(TRI->getRegClass(RegClassID)); |
| 479 | for (MachineBasicBlock::iterator I = G->getStart(), E = G->getEnd(); |
| 480 | I != E; ++I) { |
| 481 | RS.forward(I); |
| 482 | AvailableRegs &= RS.getRegsAvailable(TRI->getRegClass(RegClassID)); |
| 483 | |
| 484 | // Remove any registers clobbered by a regmask. |
| 485 | for (auto J : I->operands()) { |
| 486 | if (J.isRegMask()) |
| 487 | AvailableRegs.clearBitsNotInMask(J.getRegMask()); |
| 488 | } |
| 489 | } |
| 490 | |
| 491 | // Make sure we allocate in-order, to get the cheapest registers first. |
| 492 | auto Ord = RCI.getOrder(TRI->getRegClass(RegClassID)); |
| 493 | for (auto Reg : Ord) { |
| 494 | if (!AvailableRegs[Reg]) |
| 495 | continue; |
| 496 | if ((C == Color::Even && (Reg % 2) == 0) || |
| 497 | (C == Color::Odd && (Reg % 2) == 1)) |
| 498 | return Reg; |
| 499 | } |
| 500 | |
| 501 | return -1; |
| 502 | } |
| 503 | |
| 504 | bool AArch64A57FPLoadBalancing::colorChain(Chain *G, Color C, |
| 505 | MachineBasicBlock &MBB) { |
| 506 | bool Changed = false; |
| 507 | DEBUG(dbgs() << " - colorChain(" << G->str() << ", " |
| 508 | << ColorNames[(int)C] << ")\n"); |
| 509 | |
| 510 | // Try and obtain a free register of the right class. Without a register |
| 511 | // to play with we cannot continue. |
| 512 | int Reg = scavengeRegister(G, C, MBB); |
| 513 | if (Reg == -1) { |
| 514 | DEBUG(dbgs() << "Scavenging (thus coloring) failed!\n"); |
| 515 | return false; |
| 516 | } |
| 517 | DEBUG(dbgs() << " - Scavenged register: " << TRI->getName(Reg) << "\n"); |
| 518 | |
| 519 | std::map<unsigned, unsigned> Substs; |
| 520 | for (MachineBasicBlock::iterator I = G->getStart(), E = G->getEnd(); |
| 521 | I != E; ++I) { |
| 522 | if (!G->contains(I) && |
| 523 | (&*I != G->getKill() || G->isKillImmutable())) |
| 524 | continue; |
| 525 | |
| 526 | // I is a member of G, or I is a mutable instruction that kills G. |
| 527 | |
| 528 | std::vector<unsigned> ToErase; |
| 529 | for (auto &U : I->operands()) { |
| 530 | if (U.isReg() && U.isUse() && Substs.find(U.getReg()) != Substs.end()) { |
| 531 | unsigned OrigReg = U.getReg(); |
| 532 | U.setReg(Substs[OrigReg]); |
| 533 | if (U.isKill()) |
| 534 | // Don't erase straight away, because there may be other operands |
| 535 | // that also reference this substitution! |
| 536 | ToErase.push_back(OrigReg); |
| 537 | } else if (U.isRegMask()) { |
| 538 | for (auto J : Substs) { |
| 539 | if (U.clobbersPhysReg(J.first)) |
| 540 | ToErase.push_back(J.first); |
| 541 | } |
| 542 | } |
| 543 | } |
| 544 | // Now it's safe to remove the substs identified earlier. |
| 545 | for (auto J : ToErase) |
| 546 | Substs.erase(J); |
| 547 | |
| 548 | // Only change the def if this isn't the last instruction. |
| 549 | if (&*I != G->getKill()) { |
| 550 | MachineOperand &MO = I->getOperand(0); |
| 551 | |
| 552 | bool Change = TransformAll || getColor(MO.getReg()) != C; |
| 553 | if (G->requiresFixup() && &*I == G->getLast()) |
| 554 | Change = false; |
| 555 | |
| 556 | if (Change) { |
| 557 | Substs[MO.getReg()] = Reg; |
| 558 | MO.setReg(Reg); |
| 559 | MRI->setPhysRegUsed(Reg); |
| 560 | |
| 561 | Changed = true; |
| 562 | } |
| 563 | } |
| 564 | } |
| 565 | assert(Substs.size() == 0 && "No substitutions should be left active!"); |
| 566 | |
| 567 | if (G->getKill()) { |
| 568 | DEBUG(dbgs() << " - Kill instruction seen.\n"); |
| 569 | } else { |
| 570 | // We didn't have a kill instruction, but we didn't seem to need to change |
| 571 | // the destination register anyway. |
| 572 | DEBUG(dbgs() << " - Destination register not changed.\n"); |
| 573 | } |
| 574 | return Changed; |
| 575 | } |
| 576 | |
| 577 | void AArch64A57FPLoadBalancing:: |
| 578 | scanInstruction(MachineInstr *MI, unsigned Idx, |
| 579 | std::map<unsigned, Chain*> &ActiveChains, |
James Molloy | f0de7e5 | 2014-09-12 14:35:17 +0000 | [diff] [blame] | 580 | std::set<std::unique_ptr<Chain>> &AllChains) { |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 581 | // Inspect "MI", updating ActiveChains and AllChains. |
| 582 | |
| 583 | if (isMul(MI)) { |
| 584 | |
James Molloy | 05ce999 | 2014-09-14 18:24:26 +0000 | [diff] [blame] | 585 | for (auto &I : MI->uses()) |
| 586 | maybeKillChain(I, Idx, ActiveChains); |
| 587 | for (auto &I : MI->defs()) |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 588 | maybeKillChain(I, Idx, ActiveChains); |
| 589 | |
| 590 | // Create a new chain. Multiplies don't require forwarding so can go on any |
| 591 | // unit. |
| 592 | unsigned DestReg = MI->getOperand(0).getReg(); |
| 593 | |
| 594 | DEBUG(dbgs() << "New chain started for register " |
| 595 | << TRI->getName(DestReg) << " at " << *MI); |
| 596 | |
James Molloy | f0de7e5 | 2014-09-12 14:35:17 +0000 | [diff] [blame] | 597 | auto G = llvm::make_unique<Chain>(MI, Idx, getColor(DestReg)); |
| 598 | ActiveChains[DestReg] = G.get(); |
| 599 | AllChains.insert(std::move(G)); |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 600 | |
| 601 | } else if (isMla(MI)) { |
| 602 | |
| 603 | // It is beneficial to keep MLAs on the same functional unit as their |
| 604 | // accumulator operand. |
| 605 | unsigned DestReg = MI->getOperand(0).getReg(); |
| 606 | unsigned AccumReg = MI->getOperand(3).getReg(); |
| 607 | |
| 608 | maybeKillChain(MI->getOperand(1), Idx, ActiveChains); |
| 609 | maybeKillChain(MI->getOperand(2), Idx, ActiveChains); |
| 610 | if (DestReg != AccumReg) |
| 611 | maybeKillChain(MI->getOperand(0), Idx, ActiveChains); |
| 612 | |
| 613 | if (ActiveChains.find(AccumReg) != ActiveChains.end()) { |
| 614 | DEBUG(dbgs() << "Chain found for accumulator register " |
| 615 | << TRI->getName(AccumReg) << " in MI " << *MI); |
| 616 | |
| 617 | // For simplicity we only chain together sequences of MULs/MLAs where the |
| 618 | // accumulator register is killed on each instruction. This means we don't |
| 619 | // need to track other uses of the registers we want to rewrite. |
| 620 | // |
| 621 | // FIXME: We could extend to handle the non-kill cases for more coverage. |
| 622 | if (MI->getOperand(3).isKill()) { |
| 623 | // Add to chain. |
| 624 | DEBUG(dbgs() << "Instruction was successfully added to chain.\n"); |
| 625 | ActiveChains[AccumReg]->add(MI, Idx, getColor(DestReg)); |
| 626 | // Handle cases where the destination is not the same as the accumulator. |
Arnaud A. de Grandmaison | 6afbf2a | 2014-08-29 09:54:11 +0000 | [diff] [blame] | 627 | if (DestReg != AccumReg) { |
| 628 | ActiveChains[DestReg] = ActiveChains[AccumReg]; |
| 629 | ActiveChains.erase(AccumReg); |
| 630 | } |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 631 | return; |
| 632 | } |
| 633 | |
| 634 | DEBUG(dbgs() << "Cannot add to chain because accumulator operand wasn't " |
| 635 | << "marked <kill>!\n"); |
| 636 | maybeKillChain(MI->getOperand(3), Idx, ActiveChains); |
| 637 | } |
| 638 | |
| 639 | DEBUG(dbgs() << "Creating new chain for dest register " |
| 640 | << TRI->getName(DestReg) << "\n"); |
James Molloy | f0de7e5 | 2014-09-12 14:35:17 +0000 | [diff] [blame] | 641 | auto G = llvm::make_unique<Chain>(MI, Idx, getColor(DestReg)); |
| 642 | ActiveChains[DestReg] = G.get(); |
| 643 | AllChains.insert(std::move(G)); |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 644 | |
| 645 | } else { |
| 646 | |
| 647 | // Non-MUL or MLA instruction. Invalidate any chain in the uses or defs |
| 648 | // lists. |
James Molloy | 05ce999 | 2014-09-14 18:24:26 +0000 | [diff] [blame] | 649 | for (auto &I : MI->uses()) |
| 650 | maybeKillChain(I, Idx, ActiveChains); |
| 651 | for (auto &I : MI->defs()) |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 652 | maybeKillChain(I, Idx, ActiveChains); |
| 653 | |
| 654 | } |
| 655 | } |
| 656 | |
| 657 | void AArch64A57FPLoadBalancing:: |
| 658 | maybeKillChain(MachineOperand &MO, unsigned Idx, |
| 659 | std::map<unsigned, Chain*> &ActiveChains) { |
| 660 | // Given an operand and the set of active chains (keyed by register), |
| 661 | // determine if a chain should be ended and remove from ActiveChains. |
| 662 | MachineInstr *MI = MO.getParent(); |
| 663 | |
| 664 | if (MO.isReg()) { |
| 665 | |
| 666 | // If this is a KILL of a current chain, record it. |
| 667 | if (MO.isKill() && ActiveChains.find(MO.getReg()) != ActiveChains.end()) { |
| 668 | DEBUG(dbgs() << "Kill seen for chain " << TRI->getName(MO.getReg()) |
| 669 | << "\n"); |
| 670 | ActiveChains[MO.getReg()]->setKill(MI, Idx, /*Immutable=*/MO.isTied()); |
| 671 | } |
| 672 | ActiveChains.erase(MO.getReg()); |
| 673 | |
| 674 | } else if (MO.isRegMask()) { |
| 675 | |
| 676 | for (auto I = ActiveChains.begin(), E = ActiveChains.end(); |
Tim Northover | e42fac5 | 2014-08-08 17:31:52 +0000 | [diff] [blame] | 677 | I != E;) { |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 678 | if (MO.clobbersPhysReg(I->first)) { |
| 679 | DEBUG(dbgs() << "Kill (regmask) seen for chain " |
| 680 | << TRI->getName(I->first) << "\n"); |
| 681 | I->second->setKill(MI, Idx, /*Immutable=*/true); |
Tim Northover | e42fac5 | 2014-08-08 17:31:52 +0000 | [diff] [blame] | 682 | ActiveChains.erase(I++); |
| 683 | } else |
| 684 | ++I; |
James Molloy | 3feea9c | 2014-08-08 12:33:21 +0000 | [diff] [blame] | 685 | } |
| 686 | |
| 687 | } |
| 688 | } |
| 689 | |
| 690 | Color AArch64A57FPLoadBalancing::getColor(unsigned Reg) { |
| 691 | if ((TRI->getEncodingValue(Reg) % 2) == 0) |
| 692 | return Color::Even; |
| 693 | else |
| 694 | return Color::Odd; |
| 695 | } |
| 696 | |
| 697 | // Factory function used by AArch64TargetMachine to add the pass to the passmanager. |
| 698 | FunctionPass *llvm::createAArch64A57FPLoadBalancing() { |
| 699 | return new AArch64A57FPLoadBalancing(); |
| 700 | } |