blob: 3504b75560b014910dcd7864820262ea45b14dd9 [file] [log] [blame]
John Thompsond977c1e2013-03-27 18:34:38 +00001//===- extra/modularize/Modularize.cpp - Check modularized headers --------===//
John Thompson4f8ba652013-03-12 02:07:30 +00002//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements a tool that checks whether a set of headers provides
11// the consistent definitions required to use modules. For example, it detects
12// whether the same entity (say, a NULL macro or size_t typedef) is defined in
13// multiple headers or whether a header produces different definitions under
14// different circumstances. These conditions cause modules built from the
John Thompsonf5db45b2013-03-27 01:02:46 +000015// headers to behave poorly, and should be fixed before introducing a module
John Thompson4f8ba652013-03-12 02:07:30 +000016// map.
17//
18// Modularize takes as argument a file name for a file containing the
19// newline-separated list of headers to check with respect to each other.
John Thompsonf5db45b2013-03-27 01:02:46 +000020// Lines beginning with '#' and empty lines are ignored.
John Thompson7d0213c2013-09-04 20:46:24 +000021// Header file names followed by a colon and other space-separated
22// file names will include those extra files as dependencies.
23// The file names can be relative or full paths, but must be on the
24// same line.
25//
John Thompson4f8ba652013-03-12 02:07:30 +000026// Modularize also accepts regular front-end arguments.
27//
John Thompsonf5db45b2013-03-27 01:02:46 +000028// Usage: modularize [-prefix (optional header path prefix)]
John Thompsona2de1082013-03-26 01:17:48 +000029// (include-files_list) [(front-end-options) ...]
30//
John Thompsona44f85a2013-04-15 22:32:28 +000031// Note that unless a "-prefix (header path)" option is specified,
John Thompsona2de1082013-03-26 01:17:48 +000032// non-absolute file paths in the header list file will be relative
33// to the header list file directory. Use -prefix to specify a different
34// directory.
John Thompson4f8ba652013-03-12 02:07:30 +000035//
John Thompsonfd8ca382013-03-27 19:31:22 +000036// Note that by default, the underlying Clang front end assumes .h files
37// contain C source. If your .h files in the file list contain C++ source,
John Thompsonea6c8db2013-03-27 21:23:21 +000038// you should append the following to your command lines: -x c++
John Thompsonfd8ca382013-03-27 19:31:22 +000039//
John Thompson4f8ba652013-03-12 02:07:30 +000040// Modularize will do normal parsing, reporting normal errors and warnings,
41// but will also report special error messages like the following:
42//
John Thompson7c6e79f32013-07-29 19:07:00 +000043// error: '(symbol)' defined at multiple locations:
44// (file):(row):(column)
45// (file):(row):(column)
John Thompson4f8ba652013-03-12 02:07:30 +000046//
John Thompsondc118272013-07-29 21:59:41 +000047// error: header '(file)' has different contents depending on how it was
John Thompson7c6e79f32013-07-29 19:07:00 +000048// included
John Thompson4f8ba652013-03-12 02:07:30 +000049//
50// The latter might be followed by messages like the following:
51//
John Thompson7c6e79f32013-07-29 19:07:00 +000052// note: '(symbol)' in (file) at (row):(column) not always provided
John Thompson4f8ba652013-03-12 02:07:30 +000053//
John Thompson7c6e79f32013-07-29 19:07:00 +000054// Checks will also be performed for macro expansions, defined(macro)
55// expressions, and preprocessor conditional directives that evaluate
56// inconsistently, and can produce error messages like the following:
57//
Nico Weber8e20be22013-08-12 11:43:36 +000058// (...)/SubHeader.h:11:5:
59// #if SYMBOL == 1
60// ^
61// error: Macro instance 'SYMBOL' has different values in this header,
62// depending on how it was included.
63// 'SYMBOL' expanded to: '1' with respect to these inclusion paths:
64// (...)/Header1.h
65// (...)/SubHeader.h
66// (...)/SubHeader.h:3:9:
67// #define SYMBOL 1
68// ^
69// Macro defined here.
70// 'SYMBOL' expanded to: '2' with respect to these inclusion paths:
71// (...)/Header2.h
72// (...)/SubHeader.h
73// (...)/SubHeader.h:7:9:
74// #define SYMBOL 2
75// ^
76// Macro defined here.
77//
John Thompson74083922013-09-18 18:19:43 +000078// Checks will also be performed for '#include' directives that are
79// nested inside 'extern "C/C++" {}' or 'namespace (name) {}' blocks,
80// and can produce error message like the following:
81//
82// IncludeInExtern.h:2:3
83// #include "Empty.h"
84// ^
85// error: Include directive within extern "C" {}.
86// IncludeInExtern.h:1:1
87// extern "C" {
88// ^
89// The "extern "C" {}" block is here.
90//
John Thompson4fa9c2c2013-08-09 00:19:03 +000091// See PreprocessorTracker.cpp for additional details.
John Thompsoncc2e2912013-09-03 18:44:11 +000092//
John Thompson5d9862f2015-02-10 14:45:30 +000093// Modularize also has an option ("-module-map-path=module.modulemap") that will
94// skip the checks, and instead act as a module.modulemap generation assistant,
John Thompson5ab4f112013-10-15 13:52:33 +000095// generating a module map file based on the header list. An optional
96// "-root-module=(rootName)" argument can specify a root module to be
John Thompson5d9862f2015-02-10 14:45:30 +000097// created in the generated module.modulemap file. Note that you will likely
John Thompson5ab4f112013-10-15 13:52:33 +000098// need to edit this file to suit the needs of your headers.
99//
John Thompson5d9862f2015-02-10 14:45:30 +0000100// An example command line for generating a module.modulemap file:
John Thompson5ab4f112013-10-15 13:52:33 +0000101//
John Thompson5d9862f2015-02-10 14:45:30 +0000102// modularize -module-map-path=module.modulemap -root-module=myroot \
103// headerlist.txt
John Thompson5ab4f112013-10-15 13:52:33 +0000104//
105// Note that if the headers in the header list have partial paths, sub-modules
106// will be created for the subdirectires involved, assuming that the
107// subdirectories contain headers to be grouped into a module, but still with
108// individual modules for the headers in the subdirectory.
109//
110// See the ModuleAssistant.cpp file comments for additional details about the
111// implementation of the assistant mode.
112//
John Thompson74751802013-09-03 18:48:43 +0000113// Future directions:
114//
115// Basically, we want to add new checks for whatever we can check with respect
116// to checking headers for module'ability.
117//
118// Some ideas:
119//
John Thompson74083922013-09-18 18:19:43 +0000120// 1. Omit duplicate "not always provided" messages
John Thompson53a9d2d2013-09-04 18:29:36 +0000121//
John Thompson74083922013-09-18 18:19:43 +0000122// 2. Add options to disable any of the checks, in case
John Thompson74751802013-09-03 18:48:43 +0000123// there is some problem with them, or the messages get too verbose.
124//
John Thompson74083922013-09-18 18:19:43 +0000125// 3. Try to figure out the preprocessor conditional directives that
John Thompson74751802013-09-03 18:48:43 +0000126// contribute to problems and tie them to the inconsistent definitions.
127//
John Thompson74083922013-09-18 18:19:43 +0000128// 4. There are some legitimate uses of preprocessor macros that
Bob Wilsonf5999bd2013-09-04 16:48:28 +0000129// modularize will flag as errors, such as repeatedly #include'ing
130// a file and using interleaving defined/undefined macros
131// to change declarations in the included file. Is there a way
132// to address this? Maybe have modularize accept a list of macros
133// to ignore. Otherwise you can just exclude the file, after checking
134// for legitimate errors.
135//
John Thompson74083922013-09-18 18:19:43 +0000136// 5. What else?
John Thompsonce601e22013-03-14 01:41:29 +0000137//
138// General clean-up and refactoring:
139//
140// 1. The Location class seems to be something that we might
141// want to design to be applicable to a wider range of tools, and stick it
142// somewhere into Tooling/ in mainline
143//
John Thompson4f8ba652013-03-12 02:07:30 +0000144//===----------------------------------------------------------------------===//
John Thompsonf5db45b2013-03-27 01:02:46 +0000145
Chandler Carruth85e6e872014-01-07 20:05:01 +0000146#include "Modularize.h"
147#include "PreprocessorTracker.h"
Chandler Carruthf7e45c02014-01-07 22:15:39 +0000148#include "clang/AST/ASTConsumer.h"
John Thompsond977c1e2013-03-27 18:34:38 +0000149#include "clang/AST/ASTContext.h"
150#include "clang/AST/RecursiveASTVisitor.h"
151#include "clang/Basic/SourceManager.h"
John Thompson7d0213c2013-09-04 20:46:24 +0000152#include "clang/Driver/Options.h"
John Thompsond977c1e2013-03-27 18:34:38 +0000153#include "clang/Frontend/CompilerInstance.h"
154#include "clang/Frontend/FrontendActions.h"
155#include "clang/Lex/Preprocessor.h"
156#include "clang/Tooling/CompilationDatabase.h"
157#include "clang/Tooling/Tooling.h"
John Thompson7d0213c2013-09-04 20:46:24 +0000158#include "llvm/Option/Arg.h"
159#include "llvm/Option/ArgList.h"
160#include "llvm/Option/OptTable.h"
161#include "llvm/Option/Option.h"
John Thompsona2de1082013-03-26 01:17:48 +0000162#include "llvm/Support/CommandLine.h"
John Thompson4f8ba652013-03-12 02:07:30 +0000163#include "llvm/Support/FileSystem.h"
John Thompsonf5db45b2013-03-27 01:02:46 +0000164#include "llvm/Support/MemoryBuffer.h"
John Thompsona2de1082013-03-26 01:17:48 +0000165#include "llvm/Support/Path.h"
John Thompson4f8ba652013-03-12 02:07:30 +0000166#include <algorithm>
John Thompsond977c1e2013-03-27 18:34:38 +0000167#include <fstream>
John Thompson4f8ba652013-03-12 02:07:30 +0000168#include <iterator>
John Thompsond977c1e2013-03-27 18:34:38 +0000169#include <string>
170#include <vector>
John Thompson4f8ba652013-03-12 02:07:30 +0000171
Bob Wilsonf5999bd2013-09-04 16:48:28 +0000172using namespace clang;
John Thompson7d0213c2013-09-04 20:46:24 +0000173using namespace clang::driver;
174using namespace clang::driver::options;
175using namespace clang::tooling;
John Thompsona2de1082013-03-26 01:17:48 +0000176using namespace llvm;
John Thompson7d0213c2013-09-04 20:46:24 +0000177using namespace llvm::opt;
John Thompson94faa4d2013-07-26 23:56:42 +0000178using namespace Modularize;
John Thompson4f8ba652013-03-12 02:07:30 +0000179
John Thompsonea6c8db2013-03-27 21:23:21 +0000180// Option to specify a file name for a list of header files to check.
John Thompsonb809dfc2013-07-19 14:19:31 +0000181cl::opt<std::string>
182ListFileName(cl::Positional,
183 cl::desc("<name of file containing list of headers to check>"));
John Thompsonea6c8db2013-03-27 21:23:21 +0000184
185// Collect all other arguments, which will be passed to the front end.
John Thompson161381e2013-06-27 18:52:23 +0000186cl::list<std::string>
John Thompsonb809dfc2013-07-19 14:19:31 +0000187CC1Arguments(cl::ConsumeAfter,
188 cl::desc("<arguments to be passed to front end>..."));
John Thompsonea6c8db2013-03-27 21:23:21 +0000189
190// Option to specify a prefix to be prepended to the header names.
191cl::opt<std::string> HeaderPrefix(
192 "prefix", cl::init(""),
193 cl::desc(
194 "Prepend header file paths with this prefix."
195 " If not specified,"
196 " the files are considered to be relative to the header list file."));
197
John Thompson5ab4f112013-10-15 13:52:33 +0000198// Option for assistant mode, telling modularize to output a module map
199// based on the headers list, and where to put it.
200cl::opt<std::string> ModuleMapPath(
201 "module-map-path", cl::init(""),
202 cl::desc("Turn on module map output and specify output path or file name."
203 " If no path is specified and if prefix option is specified,"
204 " use prefix for file path."));
205
206// Option for assistant mode, telling modularize to output a module map
207// based on the headers list, and where to put it.
208cl::opt<std::string>
209RootModule("root-module", cl::init(""),
210 cl::desc("Specify the name of the root module."));
211
John Thompsonecd3b042015-02-11 16:58:36 +0000212// Option for limiting the #include-inside-extern-or-namespace-block
213// check to only those headers explicitly listed in the header list.
214// This is a work-around for private includes that purposefully get
215// included inside blocks.
216static cl::opt<bool>
217BlockCheckHeaderListOnly("block-check-header-list-only", cl::init(false),
218cl::desc("Only warn if #include directives are inside extern or namespace"
219 " blocks if the included header is in the header list."));
220
John Thompson5ab4f112013-10-15 13:52:33 +0000221// Save the program name for error messages.
222const char *Argv0;
223// Save the command line for comments.
224std::string CommandLine;
Bob Wilsonf5999bd2013-09-04 16:48:28 +0000225
John Thompson7d0213c2013-09-04 20:46:24 +0000226// Read the header list file and collect the header file names and
227// optional dependencies.
Rafael Espindolac7f0d232014-06-12 22:08:48 +0000228std::error_code
229getHeaderFileNames(SmallVectorImpl<std::string> &HeaderFileNames,
230 DependencyMap &Dependencies, StringRef ListFileName,
231 StringRef HeaderPrefix) {
John Thompsonea6c8db2013-03-27 21:23:21 +0000232 // By default, use the path component of the list file name.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000233 SmallString<256> HeaderDirectory(ListFileName);
234 sys::path::remove_filename(HeaderDirectory);
John Thompson7d0213c2013-09-04 20:46:24 +0000235 SmallString<256> CurrentDirectory;
236 sys::fs::current_path(CurrentDirectory);
John Thompsonea6c8db2013-03-27 21:23:21 +0000237
238 // Get the prefix if we have one.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000239 if (HeaderPrefix.size() != 0)
240 HeaderDirectory = HeaderPrefix;
John Thompsonea6c8db2013-03-27 21:23:21 +0000241
242 // Read the header list file into a buffer.
Rafael Espindola43f0aa62014-07-06 17:43:19 +0000243 ErrorOr<std::unique_ptr<MemoryBuffer>> listBuffer =
244 MemoryBuffer::getFile(ListFileName);
245 if (std::error_code EC = listBuffer.getError())
246 return EC;
John Thompsonea6c8db2013-03-27 21:23:21 +0000247
248 // Parse the header list into strings.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000249 SmallVector<StringRef, 32> Strings;
Rafael Espindola43f0aa62014-07-06 17:43:19 +0000250 listBuffer.get()->getBuffer().split(Strings, "\n", -1, false);
John Thompsonea6c8db2013-03-27 21:23:21 +0000251
252 // Collect the header file names from the string list.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000253 for (SmallVectorImpl<StringRef>::iterator I = Strings.begin(),
254 E = Strings.end();
John Thompsonea6c8db2013-03-27 21:23:21 +0000255 I != E; ++I) {
John Thompson7d0213c2013-09-04 20:46:24 +0000256 StringRef Line = I->trim();
John Thompsonea6c8db2013-03-27 21:23:21 +0000257 // Ignore comments and empty lines.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000258 if (Line.empty() || (Line[0] == '#'))
John Thompsonea6c8db2013-03-27 21:23:21 +0000259 continue;
John Thompson7d0213c2013-09-04 20:46:24 +0000260 std::pair<StringRef, StringRef> TargetAndDependents = Line.split(':');
John Thompsonbb0a3b02013-08-09 13:52:09 +0000261 SmallString<256> HeaderFileName;
John Thompsonea6c8db2013-03-27 21:23:21 +0000262 // Prepend header file name prefix if it's not absolute.
John Thompson7d0213c2013-09-04 20:46:24 +0000263 if (sys::path::is_absolute(TargetAndDependents.first))
264 llvm::sys::path::native(TargetAndDependents.first, HeaderFileName);
John Thompsonea6c8db2013-03-27 21:23:21 +0000265 else {
John Thompson7d0213c2013-09-04 20:46:24 +0000266 if (HeaderDirectory.size() != 0)
267 HeaderFileName = HeaderDirectory;
268 else
269 HeaderFileName = CurrentDirectory;
270 sys::path::append(HeaderFileName, TargetAndDependents.first);
Benjamin Kramer3353a102013-09-11 10:45:25 +0000271 sys::path::native(HeaderFileName);
John Thompsonea6c8db2013-03-27 21:23:21 +0000272 }
John Thompson7d0213c2013-09-04 20:46:24 +0000273 // Handle optional dependencies.
274 DependentsVector Dependents;
275 SmallVector<StringRef, 4> DependentsList;
276 TargetAndDependents.second.split(DependentsList, " ", -1, false);
277 int Count = DependentsList.size();
278 for (int Index = 0; Index < Count; ++Index) {
279 SmallString<256> Dependent;
280 if (sys::path::is_absolute(DependentsList[Index]))
281 Dependent = DependentsList[Index];
282 else {
283 if (HeaderDirectory.size() != 0)
284 Dependent = HeaderDirectory;
285 else
286 Dependent = CurrentDirectory;
287 sys::path::append(Dependent, DependentsList[Index]);
288 }
Benjamin Kramer3353a102013-09-11 10:45:25 +0000289 sys::path::native(Dependent);
John Thompson7d0213c2013-09-04 20:46:24 +0000290 Dependents.push_back(Dependent.str());
291 }
292 // Save the resulting header file path and dependencies.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000293 HeaderFileNames.push_back(HeaderFileName.str());
John Thompson7d0213c2013-09-04 20:46:24 +0000294 Dependencies[HeaderFileName.str()] = Dependents;
John Thompsonea6c8db2013-03-27 21:23:21 +0000295 }
296
Rafael Espindolac7f0d232014-06-12 22:08:48 +0000297 return std::error_code();
John Thompsonea6c8db2013-03-27 21:23:21 +0000298}
299
John Thompson7d0213c2013-09-04 20:46:24 +0000300// Helper function for finding the input file in an arguments list.
301std::string findInputFile(const CommandLineArguments &CLArgs) {
Ahmed Charles6a2dc5c2014-03-09 09:24:40 +0000302 std::unique_ptr<OptTable> Opts(createDriverOptTable());
John Thompson7d0213c2013-09-04 20:46:24 +0000303 const unsigned IncludedFlagsBitmask = options::CC1Option;
304 unsigned MissingArgIndex, MissingArgCount;
305 SmallVector<const char *, 256> Argv;
306 for (CommandLineArguments::const_iterator I = CLArgs.begin(),
307 E = CLArgs.end();
308 I != E; ++I)
309 Argv.push_back(I->c_str());
Ahmed Charles6a2dc5c2014-03-09 09:24:40 +0000310 std::unique_ptr<InputArgList> Args(
John Thompson7d0213c2013-09-04 20:46:24 +0000311 Opts->ParseArgs(Argv.data(), Argv.data() + Argv.size(), MissingArgIndex,
312 MissingArgCount, IncludedFlagsBitmask));
313 std::vector<std::string> Inputs = Args->getAllArgValues(OPT_INPUT);
314 return Inputs.back();
315}
316
Alexander Kornienkod3657312014-12-03 17:53:03 +0000317// This arguments adjuster inserts "-include (file)" arguments for header
John Thompson7d0213c2013-09-04 20:46:24 +0000318// dependencies.
Alexander Kornienkod3657312014-12-03 17:53:03 +0000319ArgumentsAdjuster getAddDependenciesAdjuster(DependencyMap &Dependencies) {
320 return [&Dependencies](const CommandLineArguments &Args) {
John Thompson7d0213c2013-09-04 20:46:24 +0000321 std::string InputFile = findInputFile(Args);
322 DependentsVector &FileDependents = Dependencies[InputFile];
John Thompson7d0213c2013-09-04 20:46:24 +0000323 CommandLineArguments NewArgs(Args);
Alexander Kornienkod3657312014-12-03 17:53:03 +0000324 if (int Count = FileDependents.size()) {
325 for (int Index = 0; Index < Count; ++Index) {
326 NewArgs.push_back("-include");
327 std::string File(std::string("\"") + FileDependents[Index] +
328 std::string("\""));
329 NewArgs.push_back(FileDependents[Index]);
330 }
John Thompson7d0213c2013-09-04 20:46:24 +0000331 }
332 return NewArgs;
Alexander Kornienkod3657312014-12-03 17:53:03 +0000333 };
334}
John Thompson7d0213c2013-09-04 20:46:24 +0000335
John Thompsonce601e22013-03-14 01:41:29 +0000336// FIXME: The Location class seems to be something that we might
337// want to design to be applicable to a wider range of tools, and stick it
338// somewhere into Tooling/ in mainline
John Thompson4f8ba652013-03-12 02:07:30 +0000339struct Location {
340 const FileEntry *File;
341 unsigned Line, Column;
John Thompsonf5db45b2013-03-27 01:02:46 +0000342
343 Location() : File(), Line(), Column() {}
344
John Thompson4f8ba652013-03-12 02:07:30 +0000345 Location(SourceManager &SM, SourceLocation Loc) : File(), Line(), Column() {
346 Loc = SM.getExpansionLoc(Loc);
347 if (Loc.isInvalid())
348 return;
John Thompsonf5db45b2013-03-27 01:02:46 +0000349
John Thompson4f8ba652013-03-12 02:07:30 +0000350 std::pair<FileID, unsigned> Decomposed = SM.getDecomposedLoc(Loc);
351 File = SM.getFileEntryForID(Decomposed.first);
352 if (!File)
353 return;
John Thompsonf5db45b2013-03-27 01:02:46 +0000354
John Thompson4f8ba652013-03-12 02:07:30 +0000355 Line = SM.getLineNumber(Decomposed.first, Decomposed.second);
356 Column = SM.getColumnNumber(Decomposed.first, Decomposed.second);
357 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000358
Craig Topperf61be9c2014-06-09 02:03:06 +0000359 operator bool() const { return File != nullptr; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000360
John Thompson4f8ba652013-03-12 02:07:30 +0000361 friend bool operator==(const Location &X, const Location &Y) {
362 return X.File == Y.File && X.Line == Y.Line && X.Column == Y.Column;
363 }
364
365 friend bool operator!=(const Location &X, const Location &Y) {
366 return !(X == Y);
367 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000368
John Thompson4f8ba652013-03-12 02:07:30 +0000369 friend bool operator<(const Location &X, const Location &Y) {
370 if (X.File != Y.File)
371 return X.File < Y.File;
372 if (X.Line != Y.Line)
373 return X.Line < Y.Line;
374 return X.Column < Y.Column;
375 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000376 friend bool operator>(const Location &X, const Location &Y) { return Y < X; }
John Thompson4f8ba652013-03-12 02:07:30 +0000377 friend bool operator<=(const Location &X, const Location &Y) {
378 return !(Y < X);
379 }
380 friend bool operator>=(const Location &X, const Location &Y) {
381 return !(X < Y);
382 }
John Thompson4f8ba652013-03-12 02:07:30 +0000383};
384
John Thompson4f8ba652013-03-12 02:07:30 +0000385struct Entry {
John Thompson52d98862013-03-28 18:38:43 +0000386 enum EntryKind {
387 EK_Tag,
388 EK_Value,
389 EK_Macro,
390
391 EK_NumberOfKinds
John Thompson4f8ba652013-03-12 02:07:30 +0000392 } Kind;
John Thompsonf5db45b2013-03-27 01:02:46 +0000393
John Thompson4f8ba652013-03-12 02:07:30 +0000394 Location Loc;
John Thompson4e4d9b32013-03-28 01:20:19 +0000395
396 StringRef getKindName() { return getKindName(Kind); }
John Thompson52d98862013-03-28 18:38:43 +0000397 static StringRef getKindName(EntryKind kind);
John Thompson4f8ba652013-03-12 02:07:30 +0000398};
399
John Thompson4e4d9b32013-03-28 01:20:19 +0000400// Return a string representing the given kind.
John Thompson52d98862013-03-28 18:38:43 +0000401StringRef Entry::getKindName(Entry::EntryKind kind) {
John Thompson4e4d9b32013-03-28 01:20:19 +0000402 switch (kind) {
John Thompson52d98862013-03-28 18:38:43 +0000403 case EK_Tag:
John Thompson4e4d9b32013-03-28 01:20:19 +0000404 return "tag";
John Thompson52d98862013-03-28 18:38:43 +0000405 case EK_Value:
John Thompson4e4d9b32013-03-28 01:20:19 +0000406 return "value";
John Thompson52d98862013-03-28 18:38:43 +0000407 case EK_Macro:
John Thompson4e4d9b32013-03-28 01:20:19 +0000408 return "macro";
John Thompson52d98862013-03-28 18:38:43 +0000409 case EK_NumberOfKinds:
John Thompson4e4d9b32013-03-28 01:20:19 +0000410 break;
John Thompson4e4d9b32013-03-28 01:20:19 +0000411 }
David Blaikiec66c07d2013-03-28 02:30:37 +0000412 llvm_unreachable("invalid Entry kind");
John Thompson4e4d9b32013-03-28 01:20:19 +0000413}
414
John Thompson4f8ba652013-03-12 02:07:30 +0000415struct HeaderEntry {
416 std::string Name;
417 Location Loc;
John Thompsonf5db45b2013-03-27 01:02:46 +0000418
John Thompson4f8ba652013-03-12 02:07:30 +0000419 friend bool operator==(const HeaderEntry &X, const HeaderEntry &Y) {
420 return X.Loc == Y.Loc && X.Name == Y.Name;
421 }
422 friend bool operator!=(const HeaderEntry &X, const HeaderEntry &Y) {
423 return !(X == Y);
424 }
425 friend bool operator<(const HeaderEntry &X, const HeaderEntry &Y) {
426 return X.Loc < Y.Loc || (X.Loc == Y.Loc && X.Name < Y.Name);
427 }
428 friend bool operator>(const HeaderEntry &X, const HeaderEntry &Y) {
429 return Y < X;
430 }
431 friend bool operator<=(const HeaderEntry &X, const HeaderEntry &Y) {
432 return !(Y < X);
433 }
434 friend bool operator>=(const HeaderEntry &X, const HeaderEntry &Y) {
435 return !(X < Y);
436 }
437};
438
439typedef std::vector<HeaderEntry> HeaderContents;
440
John Thompsonf5db45b2013-03-27 01:02:46 +0000441class EntityMap : public StringMap<SmallVector<Entry, 2> > {
John Thompson4f8ba652013-03-12 02:07:30 +0000442public:
John Thompsonf5db45b2013-03-27 01:02:46 +0000443 DenseMap<const FileEntry *, HeaderContents> HeaderContentMismatches;
444
John Thompson52d98862013-03-28 18:38:43 +0000445 void add(const std::string &Name, enum Entry::EntryKind Kind, Location Loc) {
John Thompson4f8ba652013-03-12 02:07:30 +0000446 // Record this entity in its header.
447 HeaderEntry HE = { Name, Loc };
448 CurHeaderContents[Loc.File].push_back(HE);
John Thompsonf5db45b2013-03-27 01:02:46 +0000449
John Thompson4f8ba652013-03-12 02:07:30 +0000450 // Check whether we've seen this entry before.
John Thompsonf5db45b2013-03-27 01:02:46 +0000451 SmallVector<Entry, 2> &Entries = (*this)[Name];
John Thompson4f8ba652013-03-12 02:07:30 +0000452 for (unsigned I = 0, N = Entries.size(); I != N; ++I) {
453 if (Entries[I].Kind == Kind && Entries[I].Loc == Loc)
454 return;
455 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000456
John Thompson4f8ba652013-03-12 02:07:30 +0000457 // We have not seen this entry before; record it.
458 Entry E = { Kind, Loc };
459 Entries.push_back(E);
460 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000461
John Thompson4f8ba652013-03-12 02:07:30 +0000462 void mergeCurHeaderContents() {
John Thompsonf5db45b2013-03-27 01:02:46 +0000463 for (DenseMap<const FileEntry *, HeaderContents>::iterator
464 H = CurHeaderContents.begin(),
465 HEnd = CurHeaderContents.end();
John Thompson4f8ba652013-03-12 02:07:30 +0000466 H != HEnd; ++H) {
467 // Sort contents.
468 std::sort(H->second.begin(), H->second.end());
469
470 // Check whether we've seen this header before.
John Thompsonf5db45b2013-03-27 01:02:46 +0000471 DenseMap<const FileEntry *, HeaderContents>::iterator KnownH =
472 AllHeaderContents.find(H->first);
John Thompson4f8ba652013-03-12 02:07:30 +0000473 if (KnownH == AllHeaderContents.end()) {
474 // We haven't seen this header before; record its contents.
475 AllHeaderContents.insert(*H);
476 continue;
477 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000478
John Thompson4f8ba652013-03-12 02:07:30 +0000479 // If the header contents are the same, we're done.
480 if (H->second == KnownH->second)
481 continue;
John Thompsonf5db45b2013-03-27 01:02:46 +0000482
John Thompson4f8ba652013-03-12 02:07:30 +0000483 // Determine what changed.
John Thompsonf5db45b2013-03-27 01:02:46 +0000484 std::set_symmetric_difference(
485 H->second.begin(), H->second.end(), KnownH->second.begin(),
486 KnownH->second.end(),
487 std::back_inserter(HeaderContentMismatches[H->first]));
John Thompson4f8ba652013-03-12 02:07:30 +0000488 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000489
John Thompson4f8ba652013-03-12 02:07:30 +0000490 CurHeaderContents.clear();
491 }
John Thompson161381e2013-06-27 18:52:23 +0000492
John Thompson1f67ccb2013-03-12 18:51:47 +0000493private:
John Thompsonf5db45b2013-03-27 01:02:46 +0000494 DenseMap<const FileEntry *, HeaderContents> CurHeaderContents;
495 DenseMap<const FileEntry *, HeaderContents> AllHeaderContents;
John Thompson4f8ba652013-03-12 02:07:30 +0000496};
497
John Thompson161381e2013-06-27 18:52:23 +0000498class CollectEntitiesVisitor
499 : public RecursiveASTVisitor<CollectEntitiesVisitor> {
John Thompson4f8ba652013-03-12 02:07:30 +0000500public:
John Thompson74083922013-09-18 18:19:43 +0000501 CollectEntitiesVisitor(SourceManager &SM, EntityMap &Entities,
502 Preprocessor &PP, PreprocessorTracker &PPTracker,
503 int &HadErrors)
504 : SM(SM), Entities(Entities), PP(PP), PPTracker(PPTracker),
505 HadErrors(HadErrors) {}
John Thompsonf5db45b2013-03-27 01:02:46 +0000506
John Thompson4f8ba652013-03-12 02:07:30 +0000507 bool TraverseStmt(Stmt *S) { return true; }
508 bool TraverseType(QualType T) { return true; }
509 bool TraverseTypeLoc(TypeLoc TL) { return true; }
510 bool TraverseNestedNameSpecifier(NestedNameSpecifier *NNS) { return true; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000511 bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNS) {
512 return true;
513 }
514 bool TraverseDeclarationNameInfo(DeclarationNameInfo NameInfo) {
515 return true;
516 }
John Thompson4f8ba652013-03-12 02:07:30 +0000517 bool TraverseTemplateName(TemplateName Template) { return true; }
518 bool TraverseTemplateArgument(const TemplateArgument &Arg) { return true; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000519 bool TraverseTemplateArgumentLoc(const TemplateArgumentLoc &ArgLoc) {
520 return true;
521 }
John Thompson4f8ba652013-03-12 02:07:30 +0000522 bool TraverseTemplateArguments(const TemplateArgument *Args,
John Thompsonf5db45b2013-03-27 01:02:46 +0000523 unsigned NumArgs) {
524 return true;
525 }
John Thompson4f8ba652013-03-12 02:07:30 +0000526 bool TraverseConstructorInitializer(CXXCtorInitializer *Init) { return true; }
Benjamin Kramer281f9d02014-05-10 16:32:07 +0000527 bool TraverseLambdaCapture(LambdaCapture C) { return true; }
John Thompsonf5db45b2013-03-27 01:02:46 +0000528
John Thompson74083922013-09-18 18:19:43 +0000529 // Check 'extern "*" {}' block for #include directives.
530 bool VisitLinkageSpecDecl(LinkageSpecDecl *D) {
531 // Bail if not a block.
532 if (!D->hasBraces())
533 return true;
534 SourceRange BlockRange = D->getSourceRange();
535 const char *LinkageLabel;
536 switch (D->getLanguage()) {
537 case LinkageSpecDecl::lang_c:
538 LinkageLabel = "extern \"C\" {}";
539 break;
540 case LinkageSpecDecl::lang_cxx:
541 LinkageLabel = "extern \"C++\" {}";
542 break;
John Thompson74083922013-09-18 18:19:43 +0000543 }
544 if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, LinkageLabel,
545 errs()))
546 HadErrors = 1;
547 return true;
548 }
549
550 // Check 'namespace (name) {}' block for #include directives.
551 bool VisitNamespaceDecl(const NamespaceDecl *D) {
552 SourceRange BlockRange = D->getSourceRange();
553 std::string Label("namespace ");
554 Label += D->getName();
555 Label += " {}";
556 if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, Label.c_str(),
557 errs()))
558 HadErrors = 1;
559 return true;
560 }
561
562 // Collect definition entities.
John Thompson4f8ba652013-03-12 02:07:30 +0000563 bool VisitNamedDecl(NamedDecl *ND) {
564 // We only care about file-context variables.
565 if (!ND->getDeclContext()->isFileContext())
566 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000567
John Thompson4f8ba652013-03-12 02:07:30 +0000568 // Skip declarations that tend to be properly multiply-declared.
569 if (isa<NamespaceDecl>(ND) || isa<UsingDirectiveDecl>(ND) ||
John Thompsonf5db45b2013-03-27 01:02:46 +0000570 isa<NamespaceAliasDecl>(ND) ||
571 isa<ClassTemplateSpecializationDecl>(ND) || isa<UsingDecl>(ND) ||
John Thompson8e01c062013-08-26 15:17:23 +0000572 isa<ClassTemplateDecl>(ND) || isa<TemplateTypeParmDecl>(ND) ||
John Thompsoncc2e2912013-09-03 18:44:11 +0000573 isa<TypeAliasTemplateDecl>(ND) || isa<UsingShadowDecl>(ND) ||
574 isa<FunctionDecl>(ND) || isa<FunctionTemplateDecl>(ND) ||
John Thompson4f8ba652013-03-12 02:07:30 +0000575 (isa<TagDecl>(ND) &&
576 !cast<TagDecl>(ND)->isThisDeclarationADefinition()))
577 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000578
John Thompson8e01c062013-08-26 15:17:23 +0000579 // Skip anonymous declarations.
580 if (!ND->getDeclName())
581 return true;
582
583 // Get the qualified name.
John Thompsoncc2e2912013-09-03 18:44:11 +0000584 std::string Name;
585 llvm::raw_string_ostream OS(Name);
586 ND->printQualifiedName(OS);
587 OS.flush();
John Thompson4f8ba652013-03-12 02:07:30 +0000588 if (Name.empty())
589 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000590
John Thompson4f8ba652013-03-12 02:07:30 +0000591 Location Loc(SM, ND->getLocation());
592 if (!Loc)
593 return true;
John Thompsonf5db45b2013-03-27 01:02:46 +0000594
John Thompson52d98862013-03-28 18:38:43 +0000595 Entities.add(Name, isa<TagDecl>(ND) ? Entry::EK_Tag : Entry::EK_Value, Loc);
John Thompson4f8ba652013-03-12 02:07:30 +0000596 return true;
597 }
John Thompson161381e2013-06-27 18:52:23 +0000598
John Thompson1f67ccb2013-03-12 18:51:47 +0000599private:
600 SourceManager &SM;
601 EntityMap &Entities;
John Thompson74083922013-09-18 18:19:43 +0000602 Preprocessor &PP;
603 PreprocessorTracker &PPTracker;
604 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000605};
606
607class CollectEntitiesConsumer : public ASTConsumer {
John Thompson4f8ba652013-03-12 02:07:30 +0000608public:
John Thompson94faa4d2013-07-26 23:56:42 +0000609 CollectEntitiesConsumer(EntityMap &Entities,
610 PreprocessorTracker &preprocessorTracker,
John Thompson74083922013-09-18 18:19:43 +0000611 Preprocessor &PP, StringRef InFile, int &HadErrors)
612 : Entities(Entities), PPTracker(preprocessorTracker), PP(PP),
613 HadErrors(HadErrors) {
John Thompson94faa4d2013-07-26 23:56:42 +0000614 PPTracker.handlePreprocessorEntry(PP, InFile);
615 }
616
617 ~CollectEntitiesConsumer() { PPTracker.handlePreprocessorExit(); }
John Thompsonf5db45b2013-03-27 01:02:46 +0000618
John Thompson4f8ba652013-03-12 02:07:30 +0000619 virtual void HandleTranslationUnit(ASTContext &Ctx) {
620 SourceManager &SM = Ctx.getSourceManager();
John Thompsonf5db45b2013-03-27 01:02:46 +0000621
John Thompson4f8ba652013-03-12 02:07:30 +0000622 // Collect declared entities.
John Thompson74083922013-09-18 18:19:43 +0000623 CollectEntitiesVisitor(SM, Entities, PP, PPTracker, HadErrors)
John Thompsonf5db45b2013-03-27 01:02:46 +0000624 .TraverseDecl(Ctx.getTranslationUnitDecl());
625
John Thompson4f8ba652013-03-12 02:07:30 +0000626 // Collect macro definitions.
627 for (Preprocessor::macro_iterator M = PP.macro_begin(),
John Thompsonf5db45b2013-03-27 01:02:46 +0000628 MEnd = PP.macro_end();
John Thompson4f8ba652013-03-12 02:07:30 +0000629 M != MEnd; ++M) {
630 Location Loc(SM, M->second->getLocation());
631 if (!Loc)
632 continue;
633
John Thompson52d98862013-03-28 18:38:43 +0000634 Entities.add(M->first->getName().str(), Entry::EK_Macro, Loc);
John Thompson4f8ba652013-03-12 02:07:30 +0000635 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000636
John Thompson4f8ba652013-03-12 02:07:30 +0000637 // Merge header contents.
638 Entities.mergeCurHeaderContents();
639 }
John Thompson161381e2013-06-27 18:52:23 +0000640
John Thompson1f67ccb2013-03-12 18:51:47 +0000641private:
642 EntityMap &Entities;
John Thompson94faa4d2013-07-26 23:56:42 +0000643 PreprocessorTracker &PPTracker;
John Thompson1f67ccb2013-03-12 18:51:47 +0000644 Preprocessor &PP;
John Thompson74083922013-09-18 18:19:43 +0000645 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000646};
647
648class CollectEntitiesAction : public SyntaxOnlyAction {
John Thompson1f67ccb2013-03-12 18:51:47 +0000649public:
John Thompson94faa4d2013-07-26 23:56:42 +0000650 CollectEntitiesAction(EntityMap &Entities,
John Thompson74083922013-09-18 18:19:43 +0000651 PreprocessorTracker &preprocessorTracker,
652 int &HadErrors)
653 : Entities(Entities), PPTracker(preprocessorTracker),
654 HadErrors(HadErrors) {}
John Thompson161381e2013-06-27 18:52:23 +0000655
John Thompson4f8ba652013-03-12 02:07:30 +0000656protected:
David Blaikie680c4c82014-08-10 19:56:59 +0000657 std::unique_ptr<clang::ASTConsumer>
658 CreateASTConsumer(CompilerInstance &CI, StringRef InFile) override {
659 return llvm::make_unique<CollectEntitiesConsumer>(
660 Entities, PPTracker, CI.getPreprocessor(), InFile, HadErrors);
John Thompson4f8ba652013-03-12 02:07:30 +0000661 }
John Thompson161381e2013-06-27 18:52:23 +0000662
John Thompson1f67ccb2013-03-12 18:51:47 +0000663private:
John Thompsonf5db45b2013-03-27 01:02:46 +0000664 EntityMap &Entities;
John Thompson94faa4d2013-07-26 23:56:42 +0000665 PreprocessorTracker &PPTracker;
John Thompson74083922013-09-18 18:19:43 +0000666 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000667};
668
669class ModularizeFrontendActionFactory : public FrontendActionFactory {
John Thompson4f8ba652013-03-12 02:07:30 +0000670public:
John Thompson94faa4d2013-07-26 23:56:42 +0000671 ModularizeFrontendActionFactory(EntityMap &Entities,
John Thompson74083922013-09-18 18:19:43 +0000672 PreprocessorTracker &preprocessorTracker,
673 int &HadErrors)
674 : Entities(Entities), PPTracker(preprocessorTracker),
675 HadErrors(HadErrors) {}
John Thompson4f8ba652013-03-12 02:07:30 +0000676
677 virtual CollectEntitiesAction *create() {
John Thompson74083922013-09-18 18:19:43 +0000678 return new CollectEntitiesAction(Entities, PPTracker, HadErrors);
John Thompson4f8ba652013-03-12 02:07:30 +0000679 }
John Thompson161381e2013-06-27 18:52:23 +0000680
John Thompson1f67ccb2013-03-12 18:51:47 +0000681private:
John Thompsonf5db45b2013-03-27 01:02:46 +0000682 EntityMap &Entities;
John Thompson94faa4d2013-07-26 23:56:42 +0000683 PreprocessorTracker &PPTracker;
John Thompson74083922013-09-18 18:19:43 +0000684 int &HadErrors;
John Thompson4f8ba652013-03-12 02:07:30 +0000685};
686
John Thompsonbb0a3b02013-08-09 13:52:09 +0000687int main(int Argc, const char **Argv) {
John Thompsona2de1082013-03-26 01:17:48 +0000688
John Thompson5ab4f112013-10-15 13:52:33 +0000689 // Save program name for error messages.
690 Argv0 = Argv[0];
691
John Thompson5d9862f2015-02-10 14:45:30 +0000692 // Save program arguments for use in module.modulemap comment.
John Thompson5ab4f112013-10-15 13:52:33 +0000693 CommandLine = sys::path::stem(sys::path::filename(Argv0));
694 for (int ArgIndex = 1; ArgIndex < Argc; ArgIndex++) {
695 CommandLine.append(" ");
696 CommandLine.append(Argv[ArgIndex]);
697 }
698
John Thompsona2de1082013-03-26 01:17:48 +0000699 // This causes options to be parsed.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000700 cl::ParseCommandLineOptions(Argc, Argv, "modularize.\n");
John Thompsona2de1082013-03-26 01:17:48 +0000701
702 // No go if we have no header list file.
703 if (ListFileName.size() == 0) {
704 cl::PrintHelpMessage();
John Thompsonea6c8db2013-03-27 21:23:21 +0000705 return 1;
John Thompson4f8ba652013-03-12 02:07:30 +0000706 }
John Thompsona2de1082013-03-26 01:17:48 +0000707
John Thompson7d0213c2013-09-04 20:46:24 +0000708 // Get header file names and dependencies.
John Thompsonf5db45b2013-03-27 01:02:46 +0000709 SmallVector<std::string, 32> Headers;
John Thompson7d0213c2013-09-04 20:46:24 +0000710 DependencyMap Dependencies;
Rafael Espindolac7f0d232014-06-12 22:08:48 +0000711 if (std::error_code EC = getHeaderFileNames(Headers, Dependencies,
712 ListFileName, HeaderPrefix)) {
John Thompsonbb0a3b02013-08-09 13:52:09 +0000713 errs() << Argv[0] << ": error: Unable to get header list '" << ListFileName
714 << "': " << EC.message() << '\n';
John Thompsonea6c8db2013-03-27 21:23:21 +0000715 return 1;
John Thompson4f8ba652013-03-12 02:07:30 +0000716 }
John Thompsona2de1082013-03-26 01:17:48 +0000717
John Thompson5ab4f112013-10-15 13:52:33 +0000718 // If we are in assistant mode, output the module map and quit.
John Thompsone744d2b2013-12-10 02:26:44 +0000719 if (ModuleMapPath.length() != 0) {
John Thompson5ab4f112013-10-15 13:52:33 +0000720 if (!createModuleMap(ModuleMapPath, Headers, Dependencies, HeaderPrefix,
721 RootModule))
722 return 1; // Failed.
723 return 0; // Success - Skip checks in assistant mode.
724 }
725
John Thompson4f8ba652013-03-12 02:07:30 +0000726 // Create the compilation database.
John Thompsona2de1082013-03-26 01:17:48 +0000727 SmallString<256> PathBuf;
John Thompsonf5db45b2013-03-27 01:02:46 +0000728 sys::fs::current_path(PathBuf);
Ahmed Charles6a2dc5c2014-03-09 09:24:40 +0000729 std::unique_ptr<CompilationDatabase> Compilations;
John Thompsonf5db45b2013-03-27 01:02:46 +0000730 Compilations.reset(
731 new FixedCompilationDatabase(Twine(PathBuf), CC1Arguments));
John Thompsona2de1082013-03-26 01:17:48 +0000732
John Thompson94faa4d2013-07-26 23:56:42 +0000733 // Create preprocessor tracker, to watch for macro and conditional problems.
John Thompsonecd3b042015-02-11 16:58:36 +0000734 std::unique_ptr<PreprocessorTracker> PPTracker(
735 PreprocessorTracker::create(Headers, BlockCheckHeaderListOnly));
John Thompson94faa4d2013-07-26 23:56:42 +0000736
John Thompson4f8ba652013-03-12 02:07:30 +0000737 // Parse all of the headers, detecting duplicates.
738 EntityMap Entities;
739 ClangTool Tool(*Compilations, Headers);
Alexander Kornienkod3657312014-12-03 17:53:03 +0000740 Tool.appendArgumentsAdjuster(getAddDependenciesAdjuster(Dependencies));
John Thompson74083922013-09-18 18:19:43 +0000741 int HadErrors = 0;
Benjamin Kramer6e914242014-07-24 10:23:33 +0000742 ModularizeFrontendActionFactory Factory(Entities, *PPTracker, HadErrors);
743 HadErrors |= Tool.run(&Factory);
John Thompsonce601e22013-03-14 01:41:29 +0000744
John Thompson4e4d9b32013-03-28 01:20:19 +0000745 // Create a place to save duplicate entity locations, separate bins per kind.
746 typedef SmallVector<Location, 8> LocationArray;
John Thompson52d98862013-03-28 18:38:43 +0000747 typedef SmallVector<LocationArray, Entry::EK_NumberOfKinds> EntryBinArray;
John Thompson4e4d9b32013-03-28 01:20:19 +0000748 EntryBinArray EntryBins;
John Thompsonbb0a3b02013-08-09 13:52:09 +0000749 int KindIndex;
750 for (KindIndex = 0; KindIndex < Entry::EK_NumberOfKinds; ++KindIndex) {
751 LocationArray Array;
752 EntryBins.push_back(Array);
Michael Gottesman4b249212013-03-28 06:07:15 +0000753 }
John Thompson4e4d9b32013-03-28 01:20:19 +0000754
John Thompson4f8ba652013-03-12 02:07:30 +0000755 // Check for the same entity being defined in multiple places.
756 for (EntityMap::iterator E = Entities.begin(), EEnd = Entities.end();
757 E != EEnd; ++E) {
Alp Toker9a5134e2013-12-01 05:08:12 +0000758 // If only one occurrence, exit early.
John Thompson4e4d9b32013-03-28 01:20:19 +0000759 if (E->second.size() == 1)
760 continue;
761 // Clear entity locations.
762 for (EntryBinArray::iterator CI = EntryBins.begin(), CE = EntryBins.end();
763 CI != CE; ++CI) {
John Thompson52d98862013-03-28 18:38:43 +0000764 CI->clear();
John Thompson4e4d9b32013-03-28 01:20:19 +0000765 }
766 // Walk the entities of a single name, collecting the locations,
767 // separated into separate bins.
John Thompson4f8ba652013-03-12 02:07:30 +0000768 for (unsigned I = 0, N = E->second.size(); I != N; ++I) {
John Thompson52d98862013-03-28 18:38:43 +0000769 EntryBins[E->second[I].Kind].push_back(E->second[I].Loc);
John Thompson4e4d9b32013-03-28 01:20:19 +0000770 }
771 // Report any duplicate entity definition errors.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000772 int KindIndex = 0;
John Thompson4e4d9b32013-03-28 01:20:19 +0000773 for (EntryBinArray::iterator DI = EntryBins.begin(), DE = EntryBins.end();
John Thompsonbb0a3b02013-08-09 13:52:09 +0000774 DI != DE; ++DI, ++KindIndex) {
775 int ECount = DI->size();
John Thompsonabe79d92013-12-04 20:41:30 +0000776 // If only 1 occurrence of this entity, skip it, as we only report duplicates.
John Thompsonbb0a3b02013-08-09 13:52:09 +0000777 if (ECount <= 1)
John Thompson4f8ba652013-03-12 02:07:30 +0000778 continue;
John Thompson52d98862013-03-28 18:38:43 +0000779 LocationArray::iterator FI = DI->begin();
John Thompsonbb0a3b02013-08-09 13:52:09 +0000780 StringRef kindName = Entry::getKindName((Entry::EntryKind)KindIndex);
John Thompson4e4d9b32013-03-28 01:20:19 +0000781 errs() << "error: " << kindName << " '" << E->first()
782 << "' defined at multiple locations:\n";
John Thompson52d98862013-03-28 18:38:43 +0000783 for (LocationArray::iterator FE = DI->end(); FI != FE; ++FI) {
John Thompson4e4d9b32013-03-28 01:20:19 +0000784 errs() << " " << FI->File->getName() << ":" << FI->Line << ":"
785 << FI->Column << "\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000786 }
John Thompson4f8ba652013-03-12 02:07:30 +0000787 HadErrors = 1;
788 }
789 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000790
John Thompson94faa4d2013-07-26 23:56:42 +0000791 // Complain about macro instance in header files that differ based on how
792 // they are included.
793 if (PPTracker->reportInconsistentMacros(errs()))
794 HadErrors = 1;
795
796 // Complain about preprocessor conditional directives in header files that
797 // differ based on how they are included.
798 if (PPTracker->reportInconsistentConditionals(errs()))
799 HadErrors = 1;
800
John Thompson4f8ba652013-03-12 02:07:30 +0000801 // Complain about any headers that have contents that differ based on how
802 // they are included.
John Thompsonce601e22013-03-14 01:41:29 +0000803 // FIXME: Could we provide information about which preprocessor conditionals
804 // are involved?
John Thompsonf5db45b2013-03-27 01:02:46 +0000805 for (DenseMap<const FileEntry *, HeaderContents>::iterator
806 H = Entities.HeaderContentMismatches.begin(),
807 HEnd = Entities.HeaderContentMismatches.end();
John Thompson4f8ba652013-03-12 02:07:30 +0000808 H != HEnd; ++H) {
809 if (H->second.empty()) {
John Thompsonf5db45b2013-03-27 01:02:46 +0000810 errs() << "internal error: phantom header content mismatch\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000811 continue;
812 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000813
John Thompson4f8ba652013-03-12 02:07:30 +0000814 HadErrors = 1;
John Thompsonf5db45b2013-03-27 01:02:46 +0000815 errs() << "error: header '" << H->first->getName()
John Thompson94faa4d2013-07-26 23:56:42 +0000816 << "' has different contents depending on how it was included.\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000817 for (unsigned I = 0, N = H->second.size(); I != N; ++I) {
John Thompson161381e2013-06-27 18:52:23 +0000818 errs() << "note: '" << H->second[I].Name << "' in "
819 << H->second[I].Loc.File->getName() << " at "
820 << H->second[I].Loc.Line << ":" << H->second[I].Loc.Column
821 << " not always provided\n";
John Thompson4f8ba652013-03-12 02:07:30 +0000822 }
823 }
John Thompsonf5db45b2013-03-27 01:02:46 +0000824
John Thompson4f8ba652013-03-12 02:07:30 +0000825 return HadErrors;
826}