blob: 8e13dde08542a039324b8a72d7fe1b52a60e72a9 [file] [log] [blame]
Chris Lattnera65e2f72010-01-05 05:57:49 +00001//===- InstCombineLoadStoreAlloca.cpp -------------------------------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file implements the visit functions for load, store and alloca.
11//
12//===----------------------------------------------------------------------===//
13
14#include "InstCombine.h"
Chandler Carruthed0881b2012-12-03 16:50:05 +000015#include "llvm/ADT/Statistic.h"
Dan Gohman826bdf82010-05-28 16:19:17 +000016#include "llvm/Analysis/Loads.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000017#include "llvm/IR/DataLayout.h"
Chandler Carruthbc6378d2014-10-19 10:46:46 +000018#include "llvm/IR/LLVMContext.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000019#include "llvm/IR/IntrinsicInst.h"
Chris Lattnera65e2f72010-01-05 05:57:49 +000020#include "llvm/Transforms/Utils/BasicBlockUtils.h"
21#include "llvm/Transforms/Utils/Local.h"
Chris Lattnera65e2f72010-01-05 05:57:49 +000022using namespace llvm;
23
Chandler Carruth964daaa2014-04-22 02:55:47 +000024#define DEBUG_TYPE "instcombine"
25
Chandler Carruthc908ca12012-08-21 08:39:44 +000026STATISTIC(NumDeadStore, "Number of dead stores eliminated");
27STATISTIC(NumGlobalCopies, "Number of allocas copied from constant global");
28
29/// pointsToConstantGlobal - Return true if V (possibly indirectly) points to
30/// some part of a constant global variable. This intentionally only accepts
31/// constant expressions because we can't rewrite arbitrary instructions.
32static bool pointsToConstantGlobal(Value *V) {
33 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(V))
34 return GV->isConstant();
Matt Arsenault607281772014-04-24 00:01:09 +000035
36 if (ConstantExpr *CE = dyn_cast<ConstantExpr>(V)) {
Chandler Carruthc908ca12012-08-21 08:39:44 +000037 if (CE->getOpcode() == Instruction::BitCast ||
Matt Arsenault607281772014-04-24 00:01:09 +000038 CE->getOpcode() == Instruction::AddrSpaceCast ||
Chandler Carruthc908ca12012-08-21 08:39:44 +000039 CE->getOpcode() == Instruction::GetElementPtr)
40 return pointsToConstantGlobal(CE->getOperand(0));
Matt Arsenault607281772014-04-24 00:01:09 +000041 }
Chandler Carruthc908ca12012-08-21 08:39:44 +000042 return false;
43}
44
45/// isOnlyCopiedFromConstantGlobal - Recursively walk the uses of a (derived)
46/// pointer to an alloca. Ignore any reads of the pointer, return false if we
47/// see any stores or other unknown uses. If we see pointer arithmetic, keep
48/// track of whether it moves the pointer (with IsOffset) but otherwise traverse
49/// the uses. If we see a memcpy/memmove that targets an unoffseted pointer to
50/// the alloca, and if the source pointer is a pointer to a constant global, we
51/// can optimize this.
52static bool
53isOnlyCopiedFromConstantGlobal(Value *V, MemTransferInst *&TheCopy,
Reid Kleckner813dab22014-07-01 21:36:20 +000054 SmallVectorImpl<Instruction *> &ToDelete) {
Chandler Carruthc908ca12012-08-21 08:39:44 +000055 // We track lifetime intrinsics as we encounter them. If we decide to go
56 // ahead and replace the value with the global, this lets the caller quickly
57 // eliminate the markers.
58
Reid Kleckner813dab22014-07-01 21:36:20 +000059 SmallVector<std::pair<Value *, bool>, 35> ValuesToInspect;
60 ValuesToInspect.push_back(std::make_pair(V, false));
61 while (!ValuesToInspect.empty()) {
62 auto ValuePair = ValuesToInspect.pop_back_val();
63 const bool IsOffset = ValuePair.second;
64 for (auto &U : ValuePair.first->uses()) {
65 Instruction *I = cast<Instruction>(U.getUser());
Chandler Carruthc908ca12012-08-21 08:39:44 +000066
Reid Kleckner813dab22014-07-01 21:36:20 +000067 if (LoadInst *LI = dyn_cast<LoadInst>(I)) {
68 // Ignore non-volatile loads, they are always ok.
69 if (!LI->isSimple()) return false;
Chandler Carruthc908ca12012-08-21 08:39:44 +000070 continue;
71 }
Reid Kleckner813dab22014-07-01 21:36:20 +000072
73 if (isa<BitCastInst>(I) || isa<AddrSpaceCastInst>(I)) {
74 // If uses of the bitcast are ok, we are ok.
75 ValuesToInspect.push_back(std::make_pair(I, IsOffset));
76 continue;
77 }
78 if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(I)) {
79 // If the GEP has all zero indices, it doesn't offset the pointer. If it
80 // doesn't, it does.
81 ValuesToInspect.push_back(
82 std::make_pair(I, IsOffset || !GEP->hasAllZeroIndices()));
83 continue;
84 }
85
86 if (CallSite CS = I) {
87 // If this is the function being called then we treat it like a load and
88 // ignore it.
89 if (CS.isCallee(&U))
90 continue;
91
92 // Inalloca arguments are clobbered by the call.
93 unsigned ArgNo = CS.getArgumentNo(&U);
94 if (CS.isInAllocaArgument(ArgNo))
95 return false;
96
97 // If this is a readonly/readnone call site, then we know it is just a
98 // load (but one that potentially returns the value itself), so we can
99 // ignore it if we know that the value isn't captured.
100 if (CS.onlyReadsMemory() &&
101 (CS.getInstruction()->use_empty() || CS.doesNotCapture(ArgNo)))
102 continue;
103
104 // If this is being passed as a byval argument, the caller is making a
105 // copy, so it is only a read of the alloca.
106 if (CS.isByValArgument(ArgNo))
107 continue;
108 }
109
110 // Lifetime intrinsics can be handled by the caller.
111 if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(I)) {
112 if (II->getIntrinsicID() == Intrinsic::lifetime_start ||
113 II->getIntrinsicID() == Intrinsic::lifetime_end) {
114 assert(II->use_empty() && "Lifetime markers have no result to use!");
115 ToDelete.push_back(II);
116 continue;
117 }
118 }
119
120 // If this is isn't our memcpy/memmove, reject it as something we can't
121 // handle.
122 MemTransferInst *MI = dyn_cast<MemTransferInst>(I);
123 if (!MI)
124 return false;
125
126 // If the transfer is using the alloca as a source of the transfer, then
127 // ignore it since it is a load (unless the transfer is volatile).
128 if (U.getOperandNo() == 1) {
129 if (MI->isVolatile()) return false;
130 continue;
131 }
132
133 // If we already have seen a copy, reject the second one.
134 if (TheCopy) return false;
135
136 // If the pointer has been offset from the start of the alloca, we can't
137 // safely handle this.
138 if (IsOffset) return false;
139
140 // If the memintrinsic isn't using the alloca as the dest, reject it.
141 if (U.getOperandNo() != 0) return false;
142
143 // If the source of the memcpy/move is not a constant global, reject it.
144 if (!pointsToConstantGlobal(MI->getSource()))
145 return false;
146
147 // Otherwise, the transform is safe. Remember the copy instruction.
148 TheCopy = MI;
Chandler Carruthc908ca12012-08-21 08:39:44 +0000149 }
Chandler Carruthc908ca12012-08-21 08:39:44 +0000150 }
151 return true;
152}
153
154/// isOnlyCopiedFromConstantGlobal - Return true if the specified alloca is only
155/// modified by a copy from a constant global. If we can prove this, we can
156/// replace any uses of the alloca with uses of the global directly.
157static MemTransferInst *
158isOnlyCopiedFromConstantGlobal(AllocaInst *AI,
159 SmallVectorImpl<Instruction *> &ToDelete) {
Craig Topperf40110f2014-04-25 05:29:35 +0000160 MemTransferInst *TheCopy = nullptr;
Chandler Carruthc908ca12012-08-21 08:39:44 +0000161 if (isOnlyCopiedFromConstantGlobal(AI, TheCopy, ToDelete))
162 return TheCopy;
Craig Topperf40110f2014-04-25 05:29:35 +0000163 return nullptr;
Chandler Carruthc908ca12012-08-21 08:39:44 +0000164}
165
Chris Lattnera65e2f72010-01-05 05:57:49 +0000166Instruction *InstCombiner::visitAllocaInst(AllocaInst &AI) {
Dan Gohmandf5d7dc2010-05-28 15:09:00 +0000167 // Ensure that the alloca array size argument has type intptr_t, so that
168 // any casting is exposed early.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000169 if (DL) {
170 Type *IntPtrTy = DL->getIntPtrType(AI.getType());
Dan Gohmandf5d7dc2010-05-28 15:09:00 +0000171 if (AI.getArraySize()->getType() != IntPtrTy) {
172 Value *V = Builder->CreateIntCast(AI.getArraySize(),
173 IntPtrTy, false);
174 AI.setOperand(0, V);
175 return &AI;
176 }
177 }
178
Chris Lattnera65e2f72010-01-05 05:57:49 +0000179 // Convert: alloca Ty, C - where C is a constant != 1 into: alloca [C x Ty], 1
180 if (AI.isArrayAllocation()) { // Check C != 1
181 if (const ConstantInt *C = dyn_cast<ConstantInt>(AI.getArraySize())) {
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000182 Type *NewTy =
Chris Lattnera65e2f72010-01-05 05:57:49 +0000183 ArrayType::get(AI.getAllocatedType(), C->getZExtValue());
Craig Topperf40110f2014-04-25 05:29:35 +0000184 AllocaInst *New = Builder->CreateAlloca(NewTy, nullptr, AI.getName());
Chris Lattnera65e2f72010-01-05 05:57:49 +0000185 New->setAlignment(AI.getAlignment());
186
187 // Scan to the end of the allocation instructions, to skip over a block of
188 // allocas if possible...also skip interleaved debug info
189 //
190 BasicBlock::iterator It = New;
191 while (isa<AllocaInst>(*It) || isa<DbgInfoIntrinsic>(*It)) ++It;
192
193 // Now that I is pointing to the first non-allocation-inst in the block,
194 // insert our getelementptr instruction...
195 //
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000196 Type *IdxTy = DL
197 ? DL->getIntPtrType(AI.getType())
Matt Arsenault9e3a6ca2013-08-14 00:24:38 +0000198 : Type::getInt64Ty(AI.getContext());
199 Value *NullIdx = Constant::getNullValue(IdxTy);
Matt Arsenault640ff9d2013-08-14 00:24:05 +0000200 Value *Idx[2] = { NullIdx, NullIdx };
Eli Friedman41e509a2011-05-18 23:58:37 +0000201 Instruction *GEP =
Matt Arsenault640ff9d2013-08-14 00:24:05 +0000202 GetElementPtrInst::CreateInBounds(New, Idx, New->getName() + ".sub");
Eli Friedman41e509a2011-05-18 23:58:37 +0000203 InsertNewInstBefore(GEP, *It);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000204
205 // Now make everything use the getelementptr instead of the original
206 // allocation.
Eli Friedman41e509a2011-05-18 23:58:37 +0000207 return ReplaceInstUsesWith(AI, GEP);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000208 } else if (isa<UndefValue>(AI.getArraySize())) {
209 return ReplaceInstUsesWith(AI, Constant::getNullValue(AI.getType()));
210 }
211 }
212
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000213 if (DL && AI.getAllocatedType()->isSized()) {
Chris Lattnera65e2f72010-01-05 05:57:49 +0000214 // If the alignment is 0 (unspecified), assign it the preferred alignment.
215 if (AI.getAlignment() == 0)
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000216 AI.setAlignment(DL->getPrefTypeAlignment(AI.getAllocatedType()));
Duncan Sands8bc764a2012-06-26 13:39:21 +0000217
218 // Move all alloca's of zero byte objects to the entry block and merge them
219 // together. Note that we only do this for alloca's, because malloc should
220 // allocate and return a unique pointer, even for a zero byte allocation.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000221 if (DL->getTypeAllocSize(AI.getAllocatedType()) == 0) {
Duncan Sands8bc764a2012-06-26 13:39:21 +0000222 // For a zero sized alloca there is no point in doing an array allocation.
223 // This is helpful if the array size is a complicated expression not used
224 // elsewhere.
225 if (AI.isArrayAllocation()) {
226 AI.setOperand(0, ConstantInt::get(AI.getArraySize()->getType(), 1));
227 return &AI;
228 }
229
230 // Get the first instruction in the entry block.
231 BasicBlock &EntryBlock = AI.getParent()->getParent()->getEntryBlock();
232 Instruction *FirstInst = EntryBlock.getFirstNonPHIOrDbg();
233 if (FirstInst != &AI) {
234 // If the entry block doesn't start with a zero-size alloca then move
235 // this one to the start of the entry block. There is no problem with
236 // dominance as the array size was forced to a constant earlier already.
237 AllocaInst *EntryAI = dyn_cast<AllocaInst>(FirstInst);
238 if (!EntryAI || !EntryAI->getAllocatedType()->isSized() ||
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000239 DL->getTypeAllocSize(EntryAI->getAllocatedType()) != 0) {
Duncan Sands8bc764a2012-06-26 13:39:21 +0000240 AI.moveBefore(FirstInst);
241 return &AI;
242 }
243
Richard Osborneb68053e2012-09-18 09:31:44 +0000244 // If the alignment of the entry block alloca is 0 (unspecified),
245 // assign it the preferred alignment.
246 if (EntryAI->getAlignment() == 0)
247 EntryAI->setAlignment(
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000248 DL->getPrefTypeAlignment(EntryAI->getAllocatedType()));
Duncan Sands8bc764a2012-06-26 13:39:21 +0000249 // Replace this zero-sized alloca with the one at the start of the entry
250 // block after ensuring that the address will be aligned enough for both
251 // types.
Richard Osborneb68053e2012-09-18 09:31:44 +0000252 unsigned MaxAlign = std::max(EntryAI->getAlignment(),
253 AI.getAlignment());
Duncan Sands8bc764a2012-06-26 13:39:21 +0000254 EntryAI->setAlignment(MaxAlign);
255 if (AI.getType() != EntryAI->getType())
256 return new BitCastInst(EntryAI, AI.getType());
257 return ReplaceInstUsesWith(AI, EntryAI);
258 }
259 }
Chris Lattnera65e2f72010-01-05 05:57:49 +0000260 }
261
Eli Friedmanb14873c2012-11-26 23:04:53 +0000262 if (AI.getAlignment()) {
Richard Osborne2fd29bf2012-09-24 17:10:03 +0000263 // Check to see if this allocation is only modified by a memcpy/memmove from
264 // a constant global whose alignment is equal to or exceeds that of the
265 // allocation. If this is the case, we can change all users to use
266 // the constant global instead. This is commonly produced by the CFE by
267 // constructs like "void foo() { int A[] = {1,2,3,4,5,6,7,8,9...}; }" if 'A'
268 // is only subsequently read.
269 SmallVector<Instruction *, 4> ToDelete;
270 if (MemTransferInst *Copy = isOnlyCopiedFromConstantGlobal(&AI, ToDelete)) {
Eli Friedmanb14873c2012-11-26 23:04:53 +0000271 unsigned SourceAlign = getOrEnforceKnownAlignment(Copy->getSource(),
Hal Finkel60db0582014-09-07 18:57:58 +0000272 AI.getAlignment(),
273 DL, AT, &AI, DT);
Eli Friedmanb14873c2012-11-26 23:04:53 +0000274 if (AI.getAlignment() <= SourceAlign) {
Richard Osborne2fd29bf2012-09-24 17:10:03 +0000275 DEBUG(dbgs() << "Found alloca equal to global: " << AI << '\n');
276 DEBUG(dbgs() << " memcpy = " << *Copy << '\n');
277 for (unsigned i = 0, e = ToDelete.size(); i != e; ++i)
278 EraseInstFromFunction(*ToDelete[i]);
279 Constant *TheSrc = cast<Constant>(Copy->getSource());
Matt Arsenaultbbf18c62013-12-07 02:58:45 +0000280 Constant *Cast
281 = ConstantExpr::getPointerBitCastOrAddrSpaceCast(TheSrc, AI.getType());
282 Instruction *NewI = ReplaceInstUsesWith(AI, Cast);
Richard Osborne2fd29bf2012-09-24 17:10:03 +0000283 EraseInstFromFunction(*Copy);
284 ++NumGlobalCopies;
285 return NewI;
286 }
Chandler Carruthc908ca12012-08-21 08:39:44 +0000287 }
288 }
289
Nuno Lopes95cc4f32012-07-09 18:38:20 +0000290 // At last, use the generic allocation site handler to aggressively remove
291 // unused allocas.
292 return visitAllocSite(AI);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000293}
294
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000295/// \brief Helper to combine a load to a new type.
296///
297/// This just does the work of combining a load to a new type. It handles
298/// metadata, etc., and returns the new instruction. The \c NewTy should be the
299/// loaded *value* type. This will convert it to a pointer, cast the operand to
300/// that pointer type, load it, etc.
301///
302/// Note that this will create all of the instructions with whatever insert
303/// point the \c InstCombiner currently is using.
304static LoadInst *combineLoadToNewType(InstCombiner &IC, LoadInst &LI, Type *NewTy) {
305 Value *Ptr = LI.getPointerOperand();
306 unsigned AS = LI.getPointerAddressSpace();
307 SmallVector<std::pair<unsigned, MDNode *>, 8> MD;
308 LI.getAllMetadata(MD);
309
310 LoadInst *NewLoad = IC.Builder->CreateAlignedLoad(
311 IC.Builder->CreateBitCast(Ptr, NewTy->getPointerTo(AS)),
312 LI.getAlignment(), LI.getName());
313 for (const auto &MDPair : MD) {
314 unsigned ID = MDPair.first;
315 MDNode *N = MDPair.second;
316 // Note, essentially every kind of metadata should be preserved here! This
317 // routine is supposed to clone a load instruction changing *only its type*.
318 // The only metadata it makes sense to drop is metadata which is invalidated
319 // when the pointer type changes. This should essentially never be the case
320 // in LLVM, but we explicitly switch over only known metadata to be
321 // conservatively correct. If you are adding metadata to LLVM which pertains
322 // to loads, you almost certainly want to add it here.
323 switch (ID) {
324 case LLVMContext::MD_dbg:
325 case LLVMContext::MD_tbaa:
326 case LLVMContext::MD_prof:
327 case LLVMContext::MD_fpmath:
328 case LLVMContext::MD_tbaa_struct:
329 case LLVMContext::MD_invariant_load:
330 case LLVMContext::MD_alias_scope:
331 case LLVMContext::MD_noalias:
332 // All of these directly apply.
333 NewLoad->setMetadata(ID, N);
334 break;
335
336 case LLVMContext::MD_range:
337 // FIXME: It would be nice to propagate this in some way, but the type
338 // conversions make it hard.
339 break;
340 }
341 }
342 // FIXME: These metadata nodes should really have enumerators and be handled
343 // above.
344 if (MDNode *N = LI.getMetadata("nontemporal"))
345 NewLoad->setMetadata("nontemporal", N);
346 if (MDNode *N = LI.getMetadata("llvm.mem.parallel_loop_access"))
347 NewLoad->setMetadata("llvm.mem.parallel_loop_access", N);
348 return NewLoad;
349}
350
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000351/// \brief Combine loads to match the type of value their uses after looking
352/// through intervening bitcasts.
353///
354/// The core idea here is that if the result of a load is used in an operation,
355/// we should load the type most conducive to that operation. For example, when
356/// loading an integer and converting that immediately to a pointer, we should
357/// instead directly load a pointer.
358///
359/// However, this routine must never change the width of a load or the number of
360/// loads as that would introduce a semantic change. This combine is expected to
361/// be a semantic no-op which just allows loads to more closely model the types
362/// of their consuming operations.
363///
364/// Currently, we also refuse to change the precise type used for an atomic load
365/// or a volatile load. This is debatable, and might be reasonable to change
366/// later. However, it is risky in case some backend or other part of LLVM is
367/// relying on the exact type loaded to select appropriate atomic operations.
368static Instruction *combineLoadToOperationType(InstCombiner &IC, LoadInst &LI) {
369 // FIXME: We could probably with some care handle both volatile and atomic
370 // loads here but it isn't clear that this is important.
371 if (!LI.isSimple())
372 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000373
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000374 if (LI.use_empty())
375 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000376
Chris Lattnera65e2f72010-01-05 05:57:49 +0000377
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000378 // Fold away bit casts of the loaded value by loading the desired type.
379 if (LI.hasOneUse())
380 if (auto *BC = dyn_cast<BitCastInst>(LI.user_back())) {
Chandler Carruthbc6378d2014-10-19 10:46:46 +0000381 LoadInst *NewLoad = combineLoadToNewType(IC, LI, BC->getDestTy());
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000382 BC->replaceAllUsesWith(NewLoad);
383 IC.EraseInstFromFunction(*BC);
384 return &LI;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000385 }
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000386
387 // FIXME: We should also canonicalize loads of vectors when their elements are
388 // cast to other types.
Craig Topperf40110f2014-04-25 05:29:35 +0000389 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000390}
391
392Instruction *InstCombiner::visitLoadInst(LoadInst &LI) {
393 Value *Op = LI.getOperand(0);
394
Chandler Carruth2f75fcf2014-10-18 06:36:22 +0000395 // Try to canonicalize the loaded type.
396 if (Instruction *Res = combineLoadToOperationType(*this, LI))
397 return Res;
398
Chris Lattnera65e2f72010-01-05 05:57:49 +0000399 // Attempt to improve the alignment.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000400 if (DL) {
Chris Lattnera65e2f72010-01-05 05:57:49 +0000401 unsigned KnownAlign =
Hal Finkel60db0582014-09-07 18:57:58 +0000402 getOrEnforceKnownAlignment(Op, DL->getPrefTypeAlignment(LI.getType()),
403 DL, AT, &LI, DT);
Dan Gohman36196602010-08-03 18:20:32 +0000404 unsigned LoadAlign = LI.getAlignment();
405 unsigned EffectiveLoadAlign = LoadAlign != 0 ? LoadAlign :
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000406 DL->getABITypeAlignment(LI.getType());
Dan Gohman36196602010-08-03 18:20:32 +0000407
408 if (KnownAlign > EffectiveLoadAlign)
Chris Lattnera65e2f72010-01-05 05:57:49 +0000409 LI.setAlignment(KnownAlign);
Dan Gohman36196602010-08-03 18:20:32 +0000410 else if (LoadAlign == 0)
411 LI.setAlignment(EffectiveLoadAlign);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000412 }
413
Eli Friedman8bc586e2011-08-15 22:09:40 +0000414 // None of the following transforms are legal for volatile/atomic loads.
415 // FIXME: Some of it is okay for atomic loads; needs refactoring.
Craig Topperf40110f2014-04-25 05:29:35 +0000416 if (!LI.isSimple()) return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000417
Chris Lattnera65e2f72010-01-05 05:57:49 +0000418 // Do really simple store-to-load forwarding and load CSE, to catch cases
Duncan Sands75b5d272011-02-15 09:23:02 +0000419 // where there are several consecutive memory accesses to the same location,
Chris Lattnera65e2f72010-01-05 05:57:49 +0000420 // separated by a few arithmetic operations.
421 BasicBlock::iterator BBI = &LI;
422 if (Value *AvailableVal = FindAvailableLoadedValue(Op, LI.getParent(), BBI,6))
423 return ReplaceInstUsesWith(LI, AvailableVal);
424
425 // load(gep null, ...) -> unreachable
426 if (GetElementPtrInst *GEPI = dyn_cast<GetElementPtrInst>(Op)) {
427 const Value *GEPI0 = GEPI->getOperand(0);
428 // TODO: Consider a target hook for valid address spaces for this xform.
429 if (isa<ConstantPointerNull>(GEPI0) && GEPI->getPointerAddressSpace() == 0){
430 // Insert a new store to null instruction before the load to indicate
431 // that this code is not reachable. We do this instead of inserting
432 // an unreachable instruction directly because we cannot modify the
433 // CFG.
434 new StoreInst(UndefValue::get(LI.getType()),
435 Constant::getNullValue(Op->getType()), &LI);
436 return ReplaceInstUsesWith(LI, UndefValue::get(LI.getType()));
437 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000438 }
Chris Lattnera65e2f72010-01-05 05:57:49 +0000439
440 // load null/undef -> unreachable
441 // TODO: Consider a target hook for valid address spaces for this xform.
442 if (isa<UndefValue>(Op) ||
443 (isa<ConstantPointerNull>(Op) && LI.getPointerAddressSpace() == 0)) {
444 // Insert a new store to null instruction before the load to indicate that
445 // this code is not reachable. We do this instead of inserting an
446 // unreachable instruction directly because we cannot modify the CFG.
447 new StoreInst(UndefValue::get(LI.getType()),
448 Constant::getNullValue(Op->getType()), &LI);
449 return ReplaceInstUsesWith(LI, UndefValue::get(LI.getType()));
450 }
451
Chris Lattnera65e2f72010-01-05 05:57:49 +0000452 if (Op->hasOneUse()) {
453 // Change select and PHI nodes to select values instead of addresses: this
454 // helps alias analysis out a lot, allows many others simplifications, and
455 // exposes redundancy in the code.
456 //
457 // Note that we cannot do the transformation unless we know that the
458 // introduced loads cannot trap! Something like this is valid as long as
459 // the condition is always false: load (select bool %C, int* null, int* %G),
460 // but it would not be valid if we transformed it to load from null
461 // unconditionally.
462 //
463 if (SelectInst *SI = dyn_cast<SelectInst>(Op)) {
464 // load (select (Cond, &V1, &V2)) --> select(Cond, load &V1, load &V2).
Bob Wilson56600a12010-01-30 04:42:39 +0000465 unsigned Align = LI.getAlignment();
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000466 if (isSafeToLoadUnconditionally(SI->getOperand(1), SI, Align, DL) &&
467 isSafeToLoadUnconditionally(SI->getOperand(2), SI, Align, DL)) {
Bob Wilson4b71b6c2010-01-30 00:41:10 +0000468 LoadInst *V1 = Builder->CreateLoad(SI->getOperand(1),
Bob Wilson56600a12010-01-30 04:42:39 +0000469 SI->getOperand(1)->getName()+".val");
Bob Wilson4b71b6c2010-01-30 00:41:10 +0000470 LoadInst *V2 = Builder->CreateLoad(SI->getOperand(2),
Bob Wilson56600a12010-01-30 04:42:39 +0000471 SI->getOperand(2)->getName()+".val");
472 V1->setAlignment(Align);
473 V2->setAlignment(Align);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000474 return SelectInst::Create(SI->getCondition(), V1, V2);
475 }
476
477 // load (select (cond, null, P)) -> load P
478 if (Constant *C = dyn_cast<Constant>(SI->getOperand(1)))
479 if (C->isNullValue()) {
480 LI.setOperand(0, SI->getOperand(2));
481 return &LI;
482 }
483
484 // load (select (cond, P, null)) -> load P
485 if (Constant *C = dyn_cast<Constant>(SI->getOperand(2)))
486 if (C->isNullValue()) {
487 LI.setOperand(0, SI->getOperand(1));
488 return &LI;
489 }
490 }
491 }
Craig Topperf40110f2014-04-25 05:29:35 +0000492 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000493}
494
495/// InstCombineStoreToCast - Fold store V, (cast P) -> store (cast V), P
496/// when possible. This makes it generally easy to do alias analysis and/or
497/// SROA/mem2reg of the memory object.
498static Instruction *InstCombineStoreToCast(InstCombiner &IC, StoreInst &SI) {
499 User *CI = cast<User>(SI.getOperand(1));
500 Value *CastOp = CI->getOperand(0);
501
Matt Arsenaultd0d6c0b2014-07-14 17:24:38 +0000502 Type *DestPTy = CI->getType()->getPointerElementType();
Chris Lattner229907c2011-07-18 04:54:35 +0000503 PointerType *SrcTy = dyn_cast<PointerType>(CastOp->getType());
Craig Topperf40110f2014-04-25 05:29:35 +0000504 if (!SrcTy) return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000505
Chris Lattner229907c2011-07-18 04:54:35 +0000506 Type *SrcPTy = SrcTy->getElementType();
Chris Lattnera65e2f72010-01-05 05:57:49 +0000507
Duncan Sands19d0b472010-02-16 11:11:14 +0000508 if (!DestPTy->isIntegerTy() && !DestPTy->isPointerTy())
Craig Topperf40110f2014-04-25 05:29:35 +0000509 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000510
Chris Lattnera65e2f72010-01-05 05:57:49 +0000511 /// NewGEPIndices - If SrcPTy is an aggregate type, we can emit a "noop gep"
512 /// to its first element. This allows us to handle things like:
513 /// store i32 xxx, (bitcast {foo*, float}* %P to i32*)
514 /// on 32-bit hosts.
515 SmallVector<Value*, 4> NewGEPIndices;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000516
Chris Lattnera65e2f72010-01-05 05:57:49 +0000517 // If the source is an array, the code below will not succeed. Check to
518 // see if a trivial 'gep P, 0, 0' will help matters. Only do this for
519 // constants.
Duncan Sands19d0b472010-02-16 11:11:14 +0000520 if (SrcPTy->isArrayTy() || SrcPTy->isStructTy()) {
Chris Lattnera65e2f72010-01-05 05:57:49 +0000521 // Index through pointer.
522 Constant *Zero = Constant::getNullValue(Type::getInt32Ty(SI.getContext()));
523 NewGEPIndices.push_back(Zero);
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000524
Chris Lattnera65e2f72010-01-05 05:57:49 +0000525 while (1) {
Chris Lattner229907c2011-07-18 04:54:35 +0000526 if (StructType *STy = dyn_cast<StructType>(SrcPTy)) {
Chris Lattnera65e2f72010-01-05 05:57:49 +0000527 if (!STy->getNumElements()) /* Struct can be empty {} */
528 break;
529 NewGEPIndices.push_back(Zero);
530 SrcPTy = STy->getElementType(0);
Chris Lattner229907c2011-07-18 04:54:35 +0000531 } else if (ArrayType *ATy = dyn_cast<ArrayType>(SrcPTy)) {
Chris Lattnera65e2f72010-01-05 05:57:49 +0000532 NewGEPIndices.push_back(Zero);
533 SrcPTy = ATy->getElementType();
534 } else {
535 break;
536 }
537 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000538
Chris Lattnera65e2f72010-01-05 05:57:49 +0000539 SrcTy = PointerType::get(SrcPTy, SrcTy->getAddressSpace());
540 }
541
Duncan Sands19d0b472010-02-16 11:11:14 +0000542 if (!SrcPTy->isIntegerTy() && !SrcPTy->isPointerTy())
Craig Topperf40110f2014-04-25 05:29:35 +0000543 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000544
Richard Osborne0af4aa92014-03-25 17:21:41 +0000545 // If the pointers point into different address spaces don't do the
546 // transformation.
Matt Arsenaultd0d6c0b2014-07-14 17:24:38 +0000547 if (SrcTy->getAddressSpace() != CI->getType()->getPointerAddressSpace())
Craig Topperf40110f2014-04-25 05:29:35 +0000548 return nullptr;
Richard Osborne0af4aa92014-03-25 17:21:41 +0000549
550 // If the pointers point to values of different sizes don't do the
551 // transformation.
Micah Villmowcdfe20b2012-10-08 16:38:25 +0000552 if (!IC.getDataLayout() ||
Micah Villmowcdfe20b2012-10-08 16:38:25 +0000553 IC.getDataLayout()->getTypeSizeInBits(SrcPTy) !=
554 IC.getDataLayout()->getTypeSizeInBits(DestPTy))
Craig Topperf40110f2014-04-25 05:29:35 +0000555 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000556
Richard Osborne0af4aa92014-03-25 17:21:41 +0000557 // If the pointers point to pointers to different address spaces don't do the
558 // transformation. It is not safe to introduce an addrspacecast instruction in
559 // this case since, depending on the target, addrspacecast may not be a no-op
560 // cast.
561 if (SrcPTy->isPointerTy() && DestPTy->isPointerTy() &&
562 SrcPTy->getPointerAddressSpace() != DestPTy->getPointerAddressSpace())
Craig Topperf40110f2014-04-25 05:29:35 +0000563 return nullptr;
Richard Osborne0af4aa92014-03-25 17:21:41 +0000564
Chris Lattnera65e2f72010-01-05 05:57:49 +0000565 // Okay, we are casting from one integer or pointer type to another of
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000566 // the same size. Instead of casting the pointer before
Chris Lattnera65e2f72010-01-05 05:57:49 +0000567 // the store, cast the value to be stored.
568 Value *NewCast;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000569 Instruction::CastOps opcode = Instruction::BitCast;
Richard Osborne9805ec42014-03-25 17:21:35 +0000570 Type* CastSrcTy = DestPTy;
Chris Lattner229907c2011-07-18 04:54:35 +0000571 Type* CastDstTy = SrcPTy;
Duncan Sands19d0b472010-02-16 11:11:14 +0000572 if (CastDstTy->isPointerTy()) {
Duncan Sands9dff9be2010-02-15 16:12:20 +0000573 if (CastSrcTy->isIntegerTy())
Chris Lattnera65e2f72010-01-05 05:57:49 +0000574 opcode = Instruction::IntToPtr;
Duncan Sands19d0b472010-02-16 11:11:14 +0000575 } else if (CastDstTy->isIntegerTy()) {
Richard Osborne9805ec42014-03-25 17:21:35 +0000576 if (CastSrcTy->isPointerTy())
Chris Lattnera65e2f72010-01-05 05:57:49 +0000577 opcode = Instruction::PtrToInt;
578 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000579
Chris Lattnera65e2f72010-01-05 05:57:49 +0000580 // SIOp0 is a pointer to aggregate and this is a store to the first field,
581 // emit a GEP to index into its first field.
582 if (!NewGEPIndices.empty())
Jay Foad040dd822011-07-22 08:16:57 +0000583 CastOp = IC.Builder->CreateInBoundsGEP(CastOp, NewGEPIndices);
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000584
Richard Osborne9805ec42014-03-25 17:21:35 +0000585 Value *SIOp0 = SI.getOperand(0);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000586 NewCast = IC.Builder->CreateCast(opcode, SIOp0, CastDstTy,
587 SIOp0->getName()+".c");
Dan Gohman2e20dfb2010-10-25 16:16:27 +0000588 SI.setOperand(0, NewCast);
589 SI.setOperand(1, CastOp);
590 return &SI;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000591}
592
593/// equivalentAddressValues - Test if A and B will obviously have the same
594/// value. This includes recognizing that %t0 and %t1 will have the same
595/// value in code like this:
596/// %t0 = getelementptr \@a, 0, 3
597/// store i32 0, i32* %t0
598/// %t1 = getelementptr \@a, 0, 3
599/// %t2 = load i32* %t1
600///
601static bool equivalentAddressValues(Value *A, Value *B) {
602 // Test if the values are trivially equivalent.
603 if (A == B) return true;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000604
Chris Lattnera65e2f72010-01-05 05:57:49 +0000605 // Test if the values come form identical arithmetic instructions.
606 // This uses isIdenticalToWhenDefined instead of isIdenticalTo because
607 // its only used to compare two uses within the same basic block, which
608 // means that they'll always either have the same value or one of them
609 // will have an undefined value.
610 if (isa<BinaryOperator>(A) ||
611 isa<CastInst>(A) ||
612 isa<PHINode>(A) ||
613 isa<GetElementPtrInst>(A))
614 if (Instruction *BI = dyn_cast<Instruction>(B))
615 if (cast<Instruction>(A)->isIdenticalToWhenDefined(BI))
616 return true;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000617
Chris Lattnera65e2f72010-01-05 05:57:49 +0000618 // Otherwise they may not be equivalent.
619 return false;
620}
621
Chris Lattnera65e2f72010-01-05 05:57:49 +0000622Instruction *InstCombiner::visitStoreInst(StoreInst &SI) {
623 Value *Val = SI.getOperand(0);
624 Value *Ptr = SI.getOperand(1);
625
Chris Lattnera65e2f72010-01-05 05:57:49 +0000626 // Attempt to improve the alignment.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000627 if (DL) {
Chris Lattnera65e2f72010-01-05 05:57:49 +0000628 unsigned KnownAlign =
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000629 getOrEnforceKnownAlignment(Ptr, DL->getPrefTypeAlignment(Val->getType()),
Hal Finkel60db0582014-09-07 18:57:58 +0000630 DL, AT, &SI, DT);
Dan Gohman36196602010-08-03 18:20:32 +0000631 unsigned StoreAlign = SI.getAlignment();
632 unsigned EffectiveStoreAlign = StoreAlign != 0 ? StoreAlign :
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000633 DL->getABITypeAlignment(Val->getType());
Dan Gohman36196602010-08-03 18:20:32 +0000634
Bill Wendling55b6b2b2012-03-16 18:20:54 +0000635 if (KnownAlign > EffectiveStoreAlign)
Chris Lattnera65e2f72010-01-05 05:57:49 +0000636 SI.setAlignment(KnownAlign);
Bill Wendling55b6b2b2012-03-16 18:20:54 +0000637 else if (StoreAlign == 0)
638 SI.setAlignment(EffectiveStoreAlign);
Chris Lattnera65e2f72010-01-05 05:57:49 +0000639 }
640
Eli Friedman8bc586e2011-08-15 22:09:40 +0000641 // Don't hack volatile/atomic stores.
642 // FIXME: Some bits are legal for atomic stores; needs refactoring.
Craig Topperf40110f2014-04-25 05:29:35 +0000643 if (!SI.isSimple()) return nullptr;
Eli Friedman8bc586e2011-08-15 22:09:40 +0000644
645 // If the RHS is an alloca with a single use, zapify the store, making the
646 // alloca dead.
647 if (Ptr->hasOneUse()) {
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000648 if (isa<AllocaInst>(Ptr))
Eli Friedman8bc586e2011-08-15 22:09:40 +0000649 return EraseInstFromFunction(SI);
650 if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(Ptr)) {
651 if (isa<AllocaInst>(GEP->getOperand(0))) {
652 if (GEP->getOperand(0)->hasOneUse())
653 return EraseInstFromFunction(SI);
654 }
655 }
656 }
657
Chris Lattnera65e2f72010-01-05 05:57:49 +0000658 // Do really simple DSE, to catch cases where there are several consecutive
659 // stores to the same location, separated by a few arithmetic operations. This
660 // situation often occurs with bitfield accesses.
661 BasicBlock::iterator BBI = &SI;
662 for (unsigned ScanInsts = 6; BBI != SI.getParent()->begin() && ScanInsts;
663 --ScanInsts) {
664 --BBI;
Victor Hernandez5f8c8c02010-01-22 19:05:05 +0000665 // Don't count debug info directives, lest they affect codegen,
666 // and we skip pointer-to-pointer bitcasts, which are NOPs.
667 if (isa<DbgInfoIntrinsic>(BBI) ||
Duncan Sands19d0b472010-02-16 11:11:14 +0000668 (isa<BitCastInst>(BBI) && BBI->getType()->isPointerTy())) {
Chris Lattnera65e2f72010-01-05 05:57:49 +0000669 ScanInsts++;
670 continue;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000671 }
672
Chris Lattnera65e2f72010-01-05 05:57:49 +0000673 if (StoreInst *PrevSI = dyn_cast<StoreInst>(BBI)) {
674 // Prev store isn't volatile, and stores to the same location?
Eli Friedman8bc586e2011-08-15 22:09:40 +0000675 if (PrevSI->isSimple() && equivalentAddressValues(PrevSI->getOperand(1),
676 SI.getOperand(1))) {
Chris Lattnera65e2f72010-01-05 05:57:49 +0000677 ++NumDeadStore;
678 ++BBI;
679 EraseInstFromFunction(*PrevSI);
680 continue;
681 }
682 break;
683 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000684
Chris Lattnera65e2f72010-01-05 05:57:49 +0000685 // If this is a load, we have to stop. However, if the loaded value is from
686 // the pointer we're loading and is producing the pointer we're storing,
687 // then *this* store is dead (X = load P; store X -> P).
688 if (LoadInst *LI = dyn_cast<LoadInst>(BBI)) {
Jin-Gu Kangb452db02011-03-14 01:21:00 +0000689 if (LI == Val && equivalentAddressValues(LI->getOperand(0), Ptr) &&
Eli Friedman8bc586e2011-08-15 22:09:40 +0000690 LI->isSimple())
Jin-Gu Kangb452db02011-03-14 01:21:00 +0000691 return EraseInstFromFunction(SI);
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000692
Chris Lattnera65e2f72010-01-05 05:57:49 +0000693 // Otherwise, this is a load from some other location. Stores before it
694 // may not be dead.
695 break;
696 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000697
Chris Lattnera65e2f72010-01-05 05:57:49 +0000698 // Don't skip over loads or things that can modify memory.
699 if (BBI->mayWriteToMemory() || BBI->mayReadFromMemory())
700 break;
701 }
Chris Lattnera65e2f72010-01-05 05:57:49 +0000702
703 // store X, null -> turns into 'unreachable' in SimplifyCFG
704 if (isa<ConstantPointerNull>(Ptr) && SI.getPointerAddressSpace() == 0) {
705 if (!isa<UndefValue>(Val)) {
706 SI.setOperand(0, UndefValue::get(Val->getType()));
707 if (Instruction *U = dyn_cast<Instruction>(Val))
708 Worklist.Add(U); // Dropped a use.
709 }
Craig Topperf40110f2014-04-25 05:29:35 +0000710 return nullptr; // Do not modify these!
Chris Lattnera65e2f72010-01-05 05:57:49 +0000711 }
712
713 // store undef, Ptr -> noop
714 if (isa<UndefValue>(Val))
715 return EraseInstFromFunction(SI);
716
717 // If the pointer destination is a cast, see if we can fold the cast into the
718 // source instead.
719 if (isa<CastInst>(Ptr))
720 if (Instruction *Res = InstCombineStoreToCast(*this, SI))
721 return Res;
722 if (ConstantExpr *CE = dyn_cast<ConstantExpr>(Ptr))
723 if (CE->isCast())
724 if (Instruction *Res = InstCombineStoreToCast(*this, SI))
725 return Res;
726
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000727
Chris Lattnera65e2f72010-01-05 05:57:49 +0000728 // If this store is the last instruction in the basic block (possibly
Victor Hernandez5f5abd52010-01-21 23:07:15 +0000729 // excepting debug info instructions), and if the block ends with an
730 // unconditional branch, try to move it to the successor block.
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000731 BBI = &SI;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000732 do {
733 ++BBI;
Victor Hernandez5f8c8c02010-01-22 19:05:05 +0000734 } while (isa<DbgInfoIntrinsic>(BBI) ||
Duncan Sands19d0b472010-02-16 11:11:14 +0000735 (isa<BitCastInst>(BBI) && BBI->getType()->isPointerTy()));
Chris Lattnera65e2f72010-01-05 05:57:49 +0000736 if (BranchInst *BI = dyn_cast<BranchInst>(BBI))
737 if (BI->isUnconditional())
738 if (SimplifyStoreAtEndOfBlock(SI))
Craig Topperf40110f2014-04-25 05:29:35 +0000739 return nullptr; // xform done!
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000740
Craig Topperf40110f2014-04-25 05:29:35 +0000741 return nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000742}
743
744/// SimplifyStoreAtEndOfBlock - Turn things like:
745/// if () { *P = v1; } else { *P = v2 }
746/// into a phi node with a store in the successor.
747///
748/// Simplify things like:
749/// *P = v1; if () { *P = v2; }
750/// into a phi node with a store in the successor.
751///
752bool InstCombiner::SimplifyStoreAtEndOfBlock(StoreInst &SI) {
753 BasicBlock *StoreBB = SI.getParent();
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000754
Chris Lattnera65e2f72010-01-05 05:57:49 +0000755 // Check to see if the successor block has exactly two incoming edges. If
756 // so, see if the other predecessor contains a store to the same location.
757 // if so, insert a PHI node (if needed) and move the stores down.
758 BasicBlock *DestBB = StoreBB->getTerminator()->getSuccessor(0);
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000759
Chris Lattnera65e2f72010-01-05 05:57:49 +0000760 // Determine whether Dest has exactly two predecessors and, if so, compute
761 // the other predecessor.
762 pred_iterator PI = pred_begin(DestBB);
Gabor Greif1b787df2010-07-12 15:48:26 +0000763 BasicBlock *P = *PI;
Craig Topperf40110f2014-04-25 05:29:35 +0000764 BasicBlock *OtherBB = nullptr;
Gabor Greif1b787df2010-07-12 15:48:26 +0000765
766 if (P != StoreBB)
767 OtherBB = P;
768
769 if (++PI == pred_end(DestBB))
Chris Lattnera65e2f72010-01-05 05:57:49 +0000770 return false;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000771
Gabor Greif1b787df2010-07-12 15:48:26 +0000772 P = *PI;
773 if (P != StoreBB) {
Chris Lattnera65e2f72010-01-05 05:57:49 +0000774 if (OtherBB)
775 return false;
Gabor Greif1b787df2010-07-12 15:48:26 +0000776 OtherBB = P;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000777 }
778 if (++PI != pred_end(DestBB))
779 return false;
780
781 // Bail out if all the relevant blocks aren't distinct (this can happen,
782 // for example, if SI is in an infinite loop)
783 if (StoreBB == DestBB || OtherBB == DestBB)
784 return false;
785
786 // Verify that the other block ends in a branch and is not otherwise empty.
787 BasicBlock::iterator BBI = OtherBB->getTerminator();
788 BranchInst *OtherBr = dyn_cast<BranchInst>(BBI);
789 if (!OtherBr || BBI == OtherBB->begin())
790 return false;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000791
Chris Lattnera65e2f72010-01-05 05:57:49 +0000792 // If the other block ends in an unconditional branch, check for the 'if then
793 // else' case. there is an instruction before the branch.
Craig Topperf40110f2014-04-25 05:29:35 +0000794 StoreInst *OtherStore = nullptr;
Chris Lattnera65e2f72010-01-05 05:57:49 +0000795 if (OtherBr->isUnconditional()) {
796 --BBI;
797 // Skip over debugging info.
Victor Hernandez5f8c8c02010-01-22 19:05:05 +0000798 while (isa<DbgInfoIntrinsic>(BBI) ||
Duncan Sands19d0b472010-02-16 11:11:14 +0000799 (isa<BitCastInst>(BBI) && BBI->getType()->isPointerTy())) {
Chris Lattnera65e2f72010-01-05 05:57:49 +0000800 if (BBI==OtherBB->begin())
801 return false;
802 --BBI;
803 }
Eli Friedman8bc586e2011-08-15 22:09:40 +0000804 // If this isn't a store, isn't a store to the same location, or is not the
805 // right kind of store, bail out.
Chris Lattnera65e2f72010-01-05 05:57:49 +0000806 OtherStore = dyn_cast<StoreInst>(BBI);
807 if (!OtherStore || OtherStore->getOperand(1) != SI.getOperand(1) ||
Eli Friedman8bc586e2011-08-15 22:09:40 +0000808 !SI.isSameOperationAs(OtherStore))
Chris Lattnera65e2f72010-01-05 05:57:49 +0000809 return false;
810 } else {
811 // Otherwise, the other block ended with a conditional branch. If one of the
812 // destinations is StoreBB, then we have the if/then case.
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000813 if (OtherBr->getSuccessor(0) != StoreBB &&
Chris Lattnera65e2f72010-01-05 05:57:49 +0000814 OtherBr->getSuccessor(1) != StoreBB)
815 return false;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000816
Chris Lattnera65e2f72010-01-05 05:57:49 +0000817 // Okay, we know that OtherBr now goes to Dest and StoreBB, so this is an
818 // if/then triangle. See if there is a store to the same ptr as SI that
819 // lives in OtherBB.
820 for (;; --BBI) {
821 // Check to see if we find the matching store.
822 if ((OtherStore = dyn_cast<StoreInst>(BBI))) {
823 if (OtherStore->getOperand(1) != SI.getOperand(1) ||
Eli Friedman8bc586e2011-08-15 22:09:40 +0000824 !SI.isSameOperationAs(OtherStore))
Chris Lattnera65e2f72010-01-05 05:57:49 +0000825 return false;
826 break;
827 }
828 // If we find something that may be using or overwriting the stored
829 // value, or if we run out of instructions, we can't do the xform.
830 if (BBI->mayReadFromMemory() || BBI->mayWriteToMemory() ||
831 BBI == OtherBB->begin())
832 return false;
833 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000834
Chris Lattnera65e2f72010-01-05 05:57:49 +0000835 // In order to eliminate the store in OtherBr, we have to
836 // make sure nothing reads or overwrites the stored value in
837 // StoreBB.
838 for (BasicBlock::iterator I = StoreBB->begin(); &*I != &SI; ++I) {
839 // FIXME: This should really be AA driven.
840 if (I->mayReadFromMemory() || I->mayWriteToMemory())
841 return false;
842 }
843 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000844
Chris Lattnera65e2f72010-01-05 05:57:49 +0000845 // Insert a PHI node now if we need it.
846 Value *MergedVal = OtherStore->getOperand(0);
847 if (MergedVal != SI.getOperand(0)) {
Jay Foad52131342011-03-30 11:28:46 +0000848 PHINode *PN = PHINode::Create(MergedVal->getType(), 2, "storemerge");
Chris Lattnera65e2f72010-01-05 05:57:49 +0000849 PN->addIncoming(SI.getOperand(0), SI.getParent());
850 PN->addIncoming(OtherStore->getOperand(0), OtherBB);
851 MergedVal = InsertNewInstBefore(PN, DestBB->front());
852 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000853
Chris Lattnera65e2f72010-01-05 05:57:49 +0000854 // Advance to a place where it is safe to insert the new store and
855 // insert it.
Bill Wendling8ddfc092011-08-16 20:45:24 +0000856 BBI = DestBB->getFirstInsertionPt();
Eli Friedman35211c62011-05-27 00:19:40 +0000857 StoreInst *NewSI = new StoreInst(MergedVal, SI.getOperand(1),
Eli Friedman8bc586e2011-08-15 22:09:40 +0000858 SI.isVolatile(),
859 SI.getAlignment(),
860 SI.getOrdering(),
861 SI.getSynchScope());
Eli Friedman35211c62011-05-27 00:19:40 +0000862 InsertNewInstBefore(NewSI, *BBI);
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000863 NewSI->setDebugLoc(OtherStore->getDebugLoc());
Eli Friedman35211c62011-05-27 00:19:40 +0000864
Hal Finkelcc39b672014-07-24 12:16:19 +0000865 // If the two stores had AA tags, merge them.
866 AAMDNodes AATags;
867 SI.getAAMetadata(AATags);
868 if (AATags) {
869 OtherStore->getAAMetadata(AATags, /* Merge = */ true);
870 NewSI->setAAMetadata(AATags);
871 }
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000872
Chris Lattnera65e2f72010-01-05 05:57:49 +0000873 // Nuke the old stores.
874 EraseInstFromFunction(SI);
875 EraseInstFromFunction(*OtherStore);
876 return true;
877}