blob: ddc7de39d8d2aaae9f781685d06e42110ef065dd [file] [log] [blame]
Chris Lattner2188e402010-01-04 07:37:31 +00001//===- InstCombineCompares.cpp --------------------------------------------===//
2//
Chandler Carruth2946cd72019-01-19 08:50:56 +00003// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4// See https://llvm.org/LICENSE.txt for license information.
5// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Chris Lattner2188e402010-01-04 07:37:31 +00006//
7//===----------------------------------------------------------------------===//
8//
9// This file implements the visitICmp and visitFCmp functions.
10//
11//===----------------------------------------------------------------------===//
12
Chandler Carrutha9174582015-01-22 05:25:13 +000013#include "InstCombineInternal.h"
Matt Arsenault55e73122015-01-06 15:50:59 +000014#include "llvm/ADT/APSInt.h"
Silviu Barangaf29dfd32016-01-15 15:52:05 +000015#include "llvm/ADT/SetVector.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000016#include "llvm/ADT/Statistic.h"
Eli Friedman911e12f2011-07-20 21:57:23 +000017#include "llvm/Analysis/ConstantFolding.h"
Chris Lattner2188e402010-01-04 07:37:31 +000018#include "llvm/Analysis/InstructionSimplify.h"
Mehdi Aminib550cb12016-04-18 09:17:29 +000019#include "llvm/Analysis/TargetLibraryInfo.h"
Chandler Carruth8cd041e2014-03-04 12:24:34 +000020#include "llvm/IR/ConstantRange.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000021#include "llvm/IR/DataLayout.h"
Chandler Carruth03eb0de2014-03-04 10:40:04 +000022#include "llvm/IR/GetElementPtrTypeIterator.h"
Chandler Carruth9fb823b2013-01-02 11:36:10 +000023#include "llvm/IR/IntrinsicInst.h"
Chandler Carruth820a9082014-03-04 11:08:18 +000024#include "llvm/IR/PatternMatch.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000025#include "llvm/Support/Debug.h"
Craig Topperb45eabc2017-04-26 16:39:58 +000026#include "llvm/Support/KnownBits.h"
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000027
Chris Lattner2188e402010-01-04 07:37:31 +000028using namespace llvm;
29using namespace PatternMatch;
30
Chandler Carruth964daaa2014-04-22 02:55:47 +000031#define DEBUG_TYPE "instcombine"
32
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +000033// How many times is a select replaced by one of its operands?
34STATISTIC(NumSel, "Number of select opts");
35
Chris Lattner98457102011-02-10 05:23:05 +000036
Sanjay Patel5f0217f2016-06-05 16:46:18 +000037/// Compute Result = In1+In2, returning true if the result overflowed for this
38/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000039static bool addWithOverflow(APInt &Result, const APInt &In1,
40 const APInt &In2, bool IsSigned = false) {
41 bool Overflow;
42 if (IsSigned)
43 Result = In1.sadd_ov(In2, Overflow);
44 else
45 Result = In1.uadd_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000046
Craig Topper6e025a32017-10-01 23:53:54 +000047 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000048}
49
Sanjay Patel5f0217f2016-06-05 16:46:18 +000050/// Compute Result = In1-In2, returning true if the result overflowed for this
51/// type.
Craig Topper6e025a32017-10-01 23:53:54 +000052static bool subWithOverflow(APInt &Result, const APInt &In1,
53 const APInt &In2, bool IsSigned = false) {
54 bool Overflow;
55 if (IsSigned)
56 Result = In1.ssub_ov(In2, Overflow);
57 else
58 Result = In1.usub_ov(In2, Overflow);
Chris Lattner2188e402010-01-04 07:37:31 +000059
Craig Topper6e025a32017-10-01 23:53:54 +000060 return Overflow;
Chris Lattner2188e402010-01-04 07:37:31 +000061}
62
Balaram Makam569eaec2016-05-04 21:32:14 +000063/// Given an icmp instruction, return true if any use of this comparison is a
64/// branch on sign bit comparison.
Eric Christopher710c1c82017-06-30 01:35:31 +000065static bool hasBranchUse(ICmpInst &I) {
Balaram Makam569eaec2016-05-04 21:32:14 +000066 for (auto *U : I.users())
67 if (isa<BranchInst>(U))
Eric Christopher710c1c82017-06-30 01:35:31 +000068 return true;
Balaram Makam569eaec2016-05-04 21:32:14 +000069 return false;
70}
71
Sanjay Patel5f0217f2016-06-05 16:46:18 +000072/// Given an exploded icmp instruction, return true if the comparison only
73/// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the
74/// result of the comparison is true when the input value is signed.
Sanjay Patel79263662016-08-21 15:07:45 +000075static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS,
Chris Lattner2188e402010-01-04 07:37:31 +000076 bool &TrueIfSigned) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +000077 switch (Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +000078 case ICmpInst::ICMP_SLT: // True if LHS s< 0
79 TrueIfSigned = true;
Craig Topper73ba1c82017-06-07 07:40:37 +000080 return RHS.isNullValue();
Chris Lattner2188e402010-01-04 07:37:31 +000081 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1
82 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000083 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000084 case ICmpInst::ICMP_SGT: // True if LHS s> -1
85 TrueIfSigned = false;
Sanjay Patel79263662016-08-21 15:07:45 +000086 return RHS.isAllOnesValue();
Chris Lattner2188e402010-01-04 07:37:31 +000087 case ICmpInst::ICMP_UGT:
88 // True if LHS u> RHS and RHS == high-bit-mask - 1
89 TrueIfSigned = true;
Sanjay Patel79263662016-08-21 15:07:45 +000090 return RHS.isMaxSignedValue();
Jim Grosbach129c52a2011-09-30 18:09:53 +000091 case ICmpInst::ICMP_UGE:
Chris Lattner2188e402010-01-04 07:37:31 +000092 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc)
93 TrueIfSigned = true;
Craig Topperbcfd2d12017-04-20 16:56:25 +000094 return RHS.isSignMask();
Chris Lattner2188e402010-01-04 07:37:31 +000095 default:
96 return false;
97 }
98}
99
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000100/// Returns true if the exploded icmp can be expressed as a signed comparison
101/// to zero and updates the predicate accordingly.
102/// The signedness of the comparison is preserved.
Sanjay Patel5b112842016-08-18 14:59:14 +0000103/// TODO: Refactor with decomposeBitTestICmp()?
104static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000105 if (!ICmpInst::isSigned(Pred))
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000106 return false;
107
Craig Topper73ba1c82017-06-07 07:40:37 +0000108 if (C.isNullValue())
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000109 return ICmpInst::isRelational(Pred);
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000110
Craig Topper73ba1c82017-06-07 07:40:37 +0000111 if (C.isOneValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000112 if (Pred == ICmpInst::ICMP_SLT) {
113 Pred = ICmpInst::ICMP_SLE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000114 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000115 }
Sanjay Patel5b112842016-08-18 14:59:14 +0000116 } else if (C.isAllOnesValue()) {
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000117 if (Pred == ICmpInst::ICMP_SGT) {
118 Pred = ICmpInst::ICMP_SGE;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000119 return true;
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000120 }
Arnaud A. de Grandmaison3ee88e82013-03-25 11:47:38 +0000121 }
Arnaud A. de Grandmaison9c383d62013-03-25 09:48:49 +0000122
123 return false;
124}
125
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000126/// Given a signed integer type and a set of known zero and one bits, compute
127/// the maximum and minimum values that could have the specified known zero and
128/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000129/// TODO: Move to method on KnownBits struct?
130static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000131 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000132 assert(Known.getBitWidth() == Min.getBitWidth() &&
133 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000134 "KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000135 APInt UnknownBits = ~(Known.Zero|Known.One);
Chris Lattner2188e402010-01-04 07:37:31 +0000136
137 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign
138 // bit if it is unknown.
Craig Topperb45eabc2017-04-26 16:39:58 +0000139 Min = Known.One;
140 Max = Known.One|UnknownBits;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000141
Chris Lattner2188e402010-01-04 07:37:31 +0000142 if (UnknownBits.isNegative()) { // Sign bit is unknown
Craig Topper24db6b82017-04-28 16:58:05 +0000143 Min.setSignBit();
144 Max.clearSignBit();
Chris Lattner2188e402010-01-04 07:37:31 +0000145 }
146}
147
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000148/// Given an unsigned integer type and a set of known zero and one bits, compute
149/// the maximum and minimum values that could have the specified known zero and
150/// known one bits, returning them in Min/Max.
Craig Topperb45eabc2017-04-26 16:39:58 +0000151/// TODO: Move to method on KnownBits struct?
152static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known,
Chris Lattner2188e402010-01-04 07:37:31 +0000153 APInt &Min, APInt &Max) {
Craig Topperb45eabc2017-04-26 16:39:58 +0000154 assert(Known.getBitWidth() == Min.getBitWidth() &&
155 Known.getBitWidth() == Max.getBitWidth() &&
Chris Lattner2188e402010-01-04 07:37:31 +0000156 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth.");
Craig Topperb45eabc2017-04-26 16:39:58 +0000157 APInt UnknownBits = ~(Known.Zero|Known.One);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000158
Chris Lattner2188e402010-01-04 07:37:31 +0000159 // The minimum value is when the unknown bits are all zeros.
Craig Topperb45eabc2017-04-26 16:39:58 +0000160 Min = Known.One;
Chris Lattner2188e402010-01-04 07:37:31 +0000161 // The maximum value is when the unknown bits are all ones.
Craig Topperb45eabc2017-04-26 16:39:58 +0000162 Max = Known.One|UnknownBits;
Chris Lattner2188e402010-01-04 07:37:31 +0000163}
164
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000165/// This is called when we see this pattern:
Chris Lattner2188e402010-01-04 07:37:31 +0000166/// cmp pred (load (gep GV, ...)), cmpcst
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000167/// where GV is a global variable with a constant initializer. Try to simplify
168/// this into some simple computation that does not need the load. For example
Chris Lattner2188e402010-01-04 07:37:31 +0000169/// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3".
170///
171/// If AndCst is non-null, then the loaded value is masked with that constant
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000172/// before doing the comparison. This handles cases like "A[i]&4 == 0".
Sanjay Patel43395062016-07-21 18:07:40 +0000173Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP,
174 GlobalVariable *GV,
175 CmpInst &ICI,
176 ConstantInt *AndCst) {
Chris Lattnerfe741762012-01-31 02:55:06 +0000177 Constant *Init = GV->getInitializer();
178 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init))
Craig Topperf40110f2014-04-25 05:29:35 +0000179 return nullptr;
Jim Grosbachbdbd7342013-04-05 21:20:12 +0000180
Chris Lattnerfe741762012-01-31 02:55:06 +0000181 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements();
Davide Italiano2133bf52017-02-07 17:56:50 +0000182 // Don't blow up on huge arrays.
183 if (ArrayElementCount > MaxArraySizeForCombine)
184 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000185
Chris Lattner2188e402010-01-04 07:37:31 +0000186 // There are many forms of this optimization we can handle, for now, just do
187 // the simple index into a single-dimensional array.
188 //
189 // Require: GEP GV, 0, i {{, constant indices}}
190 if (GEP->getNumOperands() < 3 ||
191 !isa<ConstantInt>(GEP->getOperand(1)) ||
192 !cast<ConstantInt>(GEP->getOperand(1))->isZero() ||
193 isa<Constant>(GEP->getOperand(2)))
Craig Topperf40110f2014-04-25 05:29:35 +0000194 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000195
196 // Check that indices after the variable are constants and in-range for the
197 // type they index. Collect the indices. This is typically for arrays of
198 // structs.
199 SmallVector<unsigned, 4> LaterIndices;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000200
Chris Lattnerfe741762012-01-31 02:55:06 +0000201 Type *EltTy = Init->getType()->getArrayElementType();
Chris Lattner2188e402010-01-04 07:37:31 +0000202 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) {
203 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000204 if (!Idx) return nullptr; // Variable index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000205
Chris Lattner2188e402010-01-04 07:37:31 +0000206 uint64_t IdxVal = Idx->getZExtValue();
Craig Topperf40110f2014-04-25 05:29:35 +0000207 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000208
Chris Lattner229907c2011-07-18 04:54:35 +0000209 if (StructType *STy = dyn_cast<StructType>(EltTy))
Chris Lattner2188e402010-01-04 07:37:31 +0000210 EltTy = STy->getElementType(IdxVal);
Chris Lattner229907c2011-07-18 04:54:35 +0000211 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) {
Craig Topperf40110f2014-04-25 05:29:35 +0000212 if (IdxVal >= ATy->getNumElements()) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000213 EltTy = ATy->getElementType();
214 } else {
Craig Topperf40110f2014-04-25 05:29:35 +0000215 return nullptr; // Unknown type.
Chris Lattner2188e402010-01-04 07:37:31 +0000216 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000217
Chris Lattner2188e402010-01-04 07:37:31 +0000218 LaterIndices.push_back(IdxVal);
219 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000220
Chris Lattner2188e402010-01-04 07:37:31 +0000221 enum { Overdefined = -3, Undefined = -2 };
222
223 // Variables for our state machines.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000224
Chris Lattner2188e402010-01-04 07:37:31 +0000225 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form
226 // "i == 47 | i == 87", where 47 is the first index the condition is true for,
227 // and 87 is the second (and last) index. FirstTrueElement is -2 when
228 // undefined, otherwise set to the first true element. SecondTrueElement is
229 // -2 when undefined, -3 when overdefined and >= 0 when that index is true.
230 int FirstTrueElement = Undefined, SecondTrueElement = Undefined;
231
232 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the
233 // form "i != 47 & i != 87". Same state transitions as for true elements.
234 int FirstFalseElement = Undefined, SecondFalseElement = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000235
Chris Lattner2188e402010-01-04 07:37:31 +0000236 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these
237 /// define a state machine that triggers for ranges of values that the index
238 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'.
239 /// This is -2 when undefined, -3 when overdefined, and otherwise the last
240 /// index in the range (inclusive). We use -2 for undefined here because we
241 /// use relative comparisons and don't want 0-1 to match -1.
242 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000243
Chris Lattner2188e402010-01-04 07:37:31 +0000244 // MagicBitvector - This is a magic bitvector where we set a bit if the
245 // comparison is true for element 'i'. If there are 64 elements or less in
246 // the array, this will fully represent all the comparison results.
247 uint64_t MagicBitvector = 0;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000248
Chris Lattner2188e402010-01-04 07:37:31 +0000249 // Scan the array and see if one of our patterns matches.
250 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1));
Chris Lattnerfe741762012-01-31 02:55:06 +0000251 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) {
252 Constant *Elt = Init->getAggregateElement(i);
Craig Topperf40110f2014-04-25 05:29:35 +0000253 if (!Elt) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000254
Chris Lattner2188e402010-01-04 07:37:31 +0000255 // If this is indexing an array of structures, get the structure element.
256 if (!LaterIndices.empty())
Jay Foad57aa6362011-07-13 10:26:04 +0000257 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000258
Chris Lattner2188e402010-01-04 07:37:31 +0000259 // If the element is masked, handle it.
260 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000261
Chris Lattner2188e402010-01-04 07:37:31 +0000262 // Find out if the comparison would be true or false for the i'th element.
263 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt,
Justin Bogner99798402016-08-05 01:06:44 +0000264 CompareRHS, DL, &TLI);
Chris Lattner2188e402010-01-04 07:37:31 +0000265 // If the result is undef for this element, ignore it.
266 if (isa<UndefValue>(C)) {
267 // Extend range state machines to cover this element in case there is an
268 // undef in the middle of the range.
269 if (TrueRangeEnd == (int)i-1)
270 TrueRangeEnd = i;
271 if (FalseRangeEnd == (int)i-1)
272 FalseRangeEnd = i;
273 continue;
274 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000275
Chris Lattner2188e402010-01-04 07:37:31 +0000276 // If we can't compute the result for any of the elements, we have to give
277 // up evaluating the entire conditional.
Craig Topperf40110f2014-04-25 05:29:35 +0000278 if (!isa<ConstantInt>(C)) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000279
Chris Lattner2188e402010-01-04 07:37:31 +0000280 // Otherwise, we know if the comparison is true or false for this element,
281 // update our state machines.
282 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero();
Jim Grosbach129c52a2011-09-30 18:09:53 +0000283
Chris Lattner2188e402010-01-04 07:37:31 +0000284 // State machine for single/double/range index comparison.
285 if (IsTrueForElt) {
286 // Update the TrueElement state machine.
287 if (FirstTrueElement == Undefined)
288 FirstTrueElement = TrueRangeEnd = i; // First true element.
289 else {
290 // Update double-compare state machine.
291 if (SecondTrueElement == Undefined)
292 SecondTrueElement = i;
293 else
294 SecondTrueElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000295
Chris Lattner2188e402010-01-04 07:37:31 +0000296 // Update range state machine.
297 if (TrueRangeEnd == (int)i-1)
298 TrueRangeEnd = i;
299 else
300 TrueRangeEnd = Overdefined;
301 }
302 } else {
303 // Update the FalseElement state machine.
304 if (FirstFalseElement == Undefined)
305 FirstFalseElement = FalseRangeEnd = i; // First false element.
306 else {
307 // Update double-compare state machine.
308 if (SecondFalseElement == Undefined)
309 SecondFalseElement = i;
310 else
311 SecondFalseElement = Overdefined;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000312
Chris Lattner2188e402010-01-04 07:37:31 +0000313 // Update range state machine.
314 if (FalseRangeEnd == (int)i-1)
315 FalseRangeEnd = i;
316 else
317 FalseRangeEnd = Overdefined;
318 }
319 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000320
Chris Lattner2188e402010-01-04 07:37:31 +0000321 // If this element is in range, update our magic bitvector.
322 if (i < 64 && IsTrueForElt)
323 MagicBitvector |= 1ULL << i;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000324
Chris Lattner2188e402010-01-04 07:37:31 +0000325 // If all of our states become overdefined, bail out early. Since the
326 // predicate is expensive, only check it every 8 elements. This is only
327 // really useful for really huge arrays.
328 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined &&
329 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined &&
330 FalseRangeEnd == Overdefined)
Craig Topperf40110f2014-04-25 05:29:35 +0000331 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000332 }
333
334 // Now that we've scanned the entire array, emit our new comparison(s). We
335 // order the state machines in complexity of the generated code.
336 Value *Idx = GEP->getOperand(2);
337
Matt Arsenault5aeae182013-08-19 21:40:31 +0000338 // If the index is larger than the pointer size of the target, truncate the
339 // index down like the GEP would do implicitly. We don't have to do this for
340 // an inbounds GEP because the index can't be out of range.
Matt Arsenault84680622013-09-30 21:11:01 +0000341 if (!GEP->isInBounds()) {
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000342 Type *IntPtrTy = DL.getIntPtrType(GEP->getType());
Matt Arsenault84680622013-09-30 21:11:01 +0000343 unsigned PtrSize = IntPtrTy->getIntegerBitWidth();
344 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize)
Craig Topperbb4069e2017-07-07 23:16:26 +0000345 Idx = Builder.CreateTrunc(Idx, IntPtrTy);
Matt Arsenault84680622013-09-30 21:11:01 +0000346 }
Matt Arsenault5aeae182013-08-19 21:40:31 +0000347
Chris Lattner2188e402010-01-04 07:37:31 +0000348 // If the comparison is only true for one or two elements, emit direct
349 // comparisons.
350 if (SecondTrueElement != Overdefined) {
351 // None true -> false.
352 if (FirstTrueElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000353 return replaceInstUsesWith(ICI, Builder.getFalse());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000354
Chris Lattner2188e402010-01-04 07:37:31 +0000355 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000356
Chris Lattner2188e402010-01-04 07:37:31 +0000357 // True for one element -> 'i == 47'.
358 if (SecondTrueElement == Undefined)
359 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000360
Chris Lattner2188e402010-01-04 07:37:31 +0000361 // True for two elements -> 'i == 47 | i == 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000362 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000363 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000364 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000365 return BinaryOperator::CreateOr(C1, C2);
366 }
367
368 // If the comparison is only false for one or two elements, emit direct
369 // comparisons.
370 if (SecondFalseElement != Overdefined) {
371 // None false -> true.
372 if (FirstFalseElement == Undefined)
Craig Topperbb4069e2017-07-07 23:16:26 +0000373 return replaceInstUsesWith(ICI, Builder.getTrue());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000374
Chris Lattner2188e402010-01-04 07:37:31 +0000375 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement);
376
377 // False for one element -> 'i != 47'.
378 if (SecondFalseElement == Undefined)
379 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000380
Chris Lattner2188e402010-01-04 07:37:31 +0000381 // False for two elements -> 'i != 47 & i != 72'.
Craig Topperbb4069e2017-07-07 23:16:26 +0000382 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000383 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000384 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx);
Chris Lattner2188e402010-01-04 07:37:31 +0000385 return BinaryOperator::CreateAnd(C1, C2);
386 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000387
Chris Lattner2188e402010-01-04 07:37:31 +0000388 // If the comparison can be replaced with a range comparison for the elements
389 // where it is true, emit the range check.
390 if (TrueRangeEnd != Overdefined) {
391 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare");
Jim Grosbach129c52a2011-09-30 18:09:53 +0000392
Chris Lattner2188e402010-01-04 07:37:31 +0000393 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1).
394 if (FirstTrueElement) {
395 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000396 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000397 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000398
Chris Lattner2188e402010-01-04 07:37:31 +0000399 Value *End = ConstantInt::get(Idx->getType(),
400 TrueRangeEnd-FirstTrueElement+1);
401 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End);
402 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000403
Chris Lattner2188e402010-01-04 07:37:31 +0000404 // False range check.
405 if (FalseRangeEnd != Overdefined) {
406 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare");
407 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse).
408 if (FirstFalseElement) {
409 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement);
Craig Topperbb4069e2017-07-07 23:16:26 +0000410 Idx = Builder.CreateAdd(Idx, Offs);
Chris Lattner2188e402010-01-04 07:37:31 +0000411 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000412
Chris Lattner2188e402010-01-04 07:37:31 +0000413 Value *End = ConstantInt::get(Idx->getType(),
414 FalseRangeEnd-FirstFalseElement);
415 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End);
416 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000417
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000418 // If a magic bitvector captures the entire comparison state
Chris Lattner2188e402010-01-04 07:37:31 +0000419 // of this load, replace it with computation that does:
420 // ((magic_cst >> i) & 1) != 0
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000421 {
Craig Topperf40110f2014-04-25 05:29:35 +0000422 Type *Ty = nullptr;
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000423
424 // Look for an appropriate type:
425 // - The type of Idx if the magic fits
Craig Topper386fc252017-11-07 17:37:32 +0000426 // - The smallest fitting legal type
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000427 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth())
428 Ty = Idx->getType();
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000429 else
430 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000431
Craig Topperf40110f2014-04-25 05:29:35 +0000432 if (Ty) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000433 Value *V = Builder.CreateIntCast(Idx, Ty, false);
434 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V);
435 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V);
Arnaud A. de Grandmaisonf364bc62013-03-22 08:25:01 +0000436 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0));
437 }
Chris Lattner2188e402010-01-04 07:37:31 +0000438 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000439
Craig Topperf40110f2014-04-25 05:29:35 +0000440 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +0000441}
442
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000443/// Return a value that can be used to compare the *offset* implied by a GEP to
444/// zero. For example, if we have &A[i], we want to return 'i' for
445/// "icmp ne i, 0". Note that, in general, indices can be complex, and scales
446/// are involved. The above expression would also be legal to codegen as
447/// "icmp ne (i*4), 0" (assuming A is a pointer to i32).
448/// This latter form is less amenable to optimization though, and we are allowed
Chris Lattner2188e402010-01-04 07:37:31 +0000449/// to generate the first by knowing that pointer arithmetic doesn't overflow.
450///
451/// If we can't emit an optimized form for this expression, this returns null.
Jim Grosbach129c52a2011-09-30 18:09:53 +0000452///
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000453static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC,
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000454 const DataLayout &DL) {
Chris Lattner2188e402010-01-04 07:37:31 +0000455 gep_type_iterator GTI = gep_type_begin(GEP);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000456
Chris Lattner2188e402010-01-04 07:37:31 +0000457 // Check to see if this gep only has a single variable index. If so, and if
458 // any constant indices are a multiple of its scale, then we can compute this
459 // in terms of the scale of the variable index. For example, if the GEP
460 // implies an offset of "12 + i*4", then we can codegen this as "3 + i",
461 // because the expression will cross zero at the same point.
462 unsigned i, e = GEP->getNumOperands();
463 int64_t Offset = 0;
464 for (i = 1; i != e; ++i, ++GTI) {
465 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) {
466 // Compute the aggregate offset of constant indices.
467 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000468
Chris Lattner2188e402010-01-04 07:37:31 +0000469 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000470 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000471 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000472 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000473 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000474 Offset += Size*CI->getSExtValue();
475 }
476 } else {
477 // Found our variable index.
478 break;
479 }
480 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000481
Chris Lattner2188e402010-01-04 07:37:31 +0000482 // If there are no variable indices, we must have a constant offset, just
483 // evaluate it the general way.
Craig Topperf40110f2014-04-25 05:29:35 +0000484 if (i == e) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000485
Chris Lattner2188e402010-01-04 07:37:31 +0000486 Value *VariableIdx = GEP->getOperand(i);
487 // Determine the scale factor of the variable element. For example, this is
488 // 4 if the variable index is into an array of i32.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000489 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType());
Jim Grosbach129c52a2011-09-30 18:09:53 +0000490
Chris Lattner2188e402010-01-04 07:37:31 +0000491 // Verify that there are no other variable indices. If so, emit the hard way.
492 for (++i, ++GTI; i != e; ++i, ++GTI) {
493 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i));
Craig Topperf40110f2014-04-25 05:29:35 +0000494 if (!CI) return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000495
Chris Lattner2188e402010-01-04 07:37:31 +0000496 // Compute the aggregate offset of constant indices.
497 if (CI->isZero()) continue;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000498
Chris Lattner2188e402010-01-04 07:37:31 +0000499 // Handle a struct index, which adds its field offset to the pointer.
Peter Collingbourneab85225b2016-12-02 02:24:42 +0000500 if (StructType *STy = GTI.getStructTypeOrNull()) {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000501 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue());
Chris Lattner2188e402010-01-04 07:37:31 +0000502 } else {
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000503 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType());
Chris Lattner2188e402010-01-04 07:37:31 +0000504 Offset += Size*CI->getSExtValue();
505 }
506 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000507
Chris Lattner2188e402010-01-04 07:37:31 +0000508 // Okay, we know we have a single variable index, which must be a
509 // pointer/array/vector index. If there is no offset, life is simple, return
510 // the index.
Rafael Espindola37dc9e12014-02-21 00:06:31 +0000511 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType());
Matt Arsenault745101d2013-08-21 19:53:10 +0000512 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth();
Chris Lattner2188e402010-01-04 07:37:31 +0000513 if (Offset == 0) {
514 // Cast to intptrty in case a truncation occurs. If an extension is needed,
515 // we don't need to bother extending: the extension won't affect where the
516 // computation crosses zero.
Eli Friedman1754a252011-05-18 23:11:30 +0000517 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000518 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy);
Eli Friedman1754a252011-05-18 23:11:30 +0000519 }
Chris Lattner2188e402010-01-04 07:37:31 +0000520 return VariableIdx;
521 }
Jim Grosbach129c52a2011-09-30 18:09:53 +0000522
Chris Lattner2188e402010-01-04 07:37:31 +0000523 // Otherwise, there is an index. The computation we will do will be modulo
Nikita Popov36e03ac2018-12-12 23:19:03 +0000524 // the pointer size.
525 Offset = SignExtend64(Offset, IntPtrWidth);
526 VariableScale = SignExtend64(VariableScale, IntPtrWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000527
Chris Lattner2188e402010-01-04 07:37:31 +0000528 // To do this transformation, any constant index must be a multiple of the
529 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i",
530 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a
531 // multiple of the variable scale.
532 int64_t NewOffs = Offset / (int64_t)VariableScale;
533 if (Offset != NewOffs*(int64_t)VariableScale)
Craig Topperf40110f2014-04-25 05:29:35 +0000534 return nullptr;
Jim Grosbach129c52a2011-09-30 18:09:53 +0000535
Chris Lattner2188e402010-01-04 07:37:31 +0000536 // Okay, we can do this evaluation. Start by converting the index to intptr.
Chris Lattner2188e402010-01-04 07:37:31 +0000537 if (VariableIdx->getType() != IntPtrTy)
Craig Topperbb4069e2017-07-07 23:16:26 +0000538 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy,
Eli Friedman1754a252011-05-18 23:11:30 +0000539 true /*Signed*/);
Chris Lattner2188e402010-01-04 07:37:31 +0000540 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs);
Craig Topperbb4069e2017-07-07 23:16:26 +0000541 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset");
Chris Lattner2188e402010-01-04 07:37:31 +0000542}
543
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000544/// Returns true if we can rewrite Start as a GEP with pointer Base
545/// and some integer offset. The nodes that need to be re-written
546/// for this transformation will be added to Explored.
547static bool canRewriteGEPAsOffset(Value *Start, Value *Base,
548 const DataLayout &DL,
549 SetVector<Value *> &Explored) {
550 SmallVector<Value *, 16> WorkList(1, Start);
551 Explored.insert(Base);
552
553 // The following traversal gives us an order which can be used
554 // when doing the final transformation. Since in the final
555 // transformation we create the PHI replacement instructions first,
556 // we don't have to get them in any particular order.
557 //
558 // However, for other instructions we will have to traverse the
559 // operands of an instruction first, which means that we have to
560 // do a post-order traversal.
561 while (!WorkList.empty()) {
562 SetVector<PHINode *> PHIs;
563
564 while (!WorkList.empty()) {
565 if (Explored.size() >= 100)
566 return false;
567
568 Value *V = WorkList.back();
569
570 if (Explored.count(V) != 0) {
571 WorkList.pop_back();
572 continue;
573 }
574
575 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) &&
David Majnemer8b16da82016-09-15 20:10:09 +0000576 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V))
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000577 // We've found some value that we can't explore which is different from
578 // the base. Therefore we can't do this transformation.
579 return false;
580
581 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) {
582 auto *CI = dyn_cast<CastInst>(V);
583 if (!CI->isNoopCast(DL))
584 return false;
585
586 if (Explored.count(CI->getOperand(0)) == 0)
587 WorkList.push_back(CI->getOperand(0));
588 }
589
590 if (auto *GEP = dyn_cast<GEPOperator>(V)) {
591 // We're limiting the GEP to having one index. This will preserve
592 // the original pointer type. We could handle more cases in the
593 // future.
594 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() ||
595 GEP->getType() != Start->getType())
596 return false;
597
598 if (Explored.count(GEP->getOperand(0)) == 0)
599 WorkList.push_back(GEP->getOperand(0));
600 }
601
602 if (WorkList.back() == V) {
603 WorkList.pop_back();
604 // We've finished visiting this node, mark it as such.
605 Explored.insert(V);
606 }
607
608 if (auto *PN = dyn_cast<PHINode>(V)) {
David Majnemercdf28732016-03-19 04:39:52 +0000609 // We cannot transform PHIs on unsplittable basic blocks.
610 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator()))
611 return false;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000612 Explored.insert(PN);
613 PHIs.insert(PN);
614 }
615 }
616
617 // Explore the PHI nodes further.
618 for (auto *PN : PHIs)
619 for (Value *Op : PN->incoming_values())
620 if (Explored.count(Op) == 0)
621 WorkList.push_back(Op);
622 }
623
624 // Make sure that we can do this. Since we can't insert GEPs in a basic
625 // block before a PHI node, we can't easily do this transformation if
626 // we have PHI node users of transformed instructions.
627 for (Value *Val : Explored) {
628 for (Value *Use : Val->uses()) {
629
630 auto *PHI = dyn_cast<PHINode>(Use);
631 auto *Inst = dyn_cast<Instruction>(Val);
632
633 if (Inst == Base || Inst == PHI || !Inst || !PHI ||
634 Explored.count(PHI) == 0)
635 continue;
636
637 if (PHI->getParent() == Inst->getParent())
638 return false;
639 }
640 }
641 return true;
642}
643
644// Sets the appropriate insert point on Builder where we can add
645// a replacement Instruction for V (if that is possible).
646static void setInsertionPoint(IRBuilder<> &Builder, Value *V,
647 bool Before = true) {
648 if (auto *PHI = dyn_cast<PHINode>(V)) {
649 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt());
650 return;
651 }
652 if (auto *I = dyn_cast<Instruction>(V)) {
653 if (!Before)
654 I = &*std::next(I->getIterator());
655 Builder.SetInsertPoint(I);
656 return;
657 }
658 if (auto *A = dyn_cast<Argument>(V)) {
659 // Set the insertion point in the entry block.
660 BasicBlock &Entry = A->getParent()->getEntryBlock();
661 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt());
662 return;
663 }
664 // Otherwise, this is a constant and we don't need to set a new
665 // insertion point.
666 assert(isa<Constant>(V) && "Setting insertion point for unknown value!");
667}
668
669/// Returns a re-written value of Start as an indexed GEP using Base as a
670/// pointer.
671static Value *rewriteGEPAsOffset(Value *Start, Value *Base,
672 const DataLayout &DL,
673 SetVector<Value *> &Explored) {
674 // Perform all the substitutions. This is a bit tricky because we can
675 // have cycles in our use-def chains.
676 // 1. Create the PHI nodes without any incoming values.
677 // 2. Create all the other values.
678 // 3. Add the edges for the PHI nodes.
679 // 4. Emit GEPs to get the original pointers.
680 // 5. Remove the original instructions.
681 Type *IndexType = IntegerType::get(
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000682 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000683
684 DenseMap<Value *, Value *> NewInsts;
685 NewInsts[Base] = ConstantInt::getNullValue(IndexType);
686
687 // Create the new PHI nodes, without adding any incoming values.
688 for (Value *Val : Explored) {
689 if (Val == Base)
690 continue;
691 // Create empty phi nodes. This avoids cyclic dependencies when creating
692 // the remaining instructions.
693 if (auto *PHI = dyn_cast<PHINode>(Val))
694 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(),
695 PHI->getName() + ".idx", PHI);
696 }
697 IRBuilder<> Builder(Base->getContext());
698
699 // Create all the other instructions.
700 for (Value *Val : Explored) {
701
702 if (NewInsts.find(Val) != NewInsts.end())
703 continue;
704
705 if (auto *CI = dyn_cast<CastInst>(Val)) {
Martin Storsjo0fe645c2019-05-30 20:53:21 +0000706 // Don't get rid of the intermediate variable here; the store can grow
707 // the map which will invalidate the reference to the input value.
708 Value *V = NewInsts[CI->getOperand(0)];
709 NewInsts[CI] = V;
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000710 continue;
711 }
712 if (auto *GEP = dyn_cast<GEPOperator>(Val)) {
713 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)]
714 : GEP->getOperand(1);
715 setInsertionPoint(Builder, GEP);
716 // Indices might need to be sign extended. GEPs will magically do
717 // this, but we need to do it ourselves here.
718 if (Index->getType()->getScalarSizeInBits() !=
719 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) {
720 Index = Builder.CreateSExtOrTrunc(
721 Index, NewInsts[GEP->getOperand(0)]->getType(),
722 GEP->getOperand(0)->getName() + ".sext");
723 }
724
725 auto *Op = NewInsts[GEP->getOperand(0)];
Craig Topper781aa182018-05-05 01:57:00 +0000726 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero())
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000727 NewInsts[GEP] = Index;
728 else
729 NewInsts[GEP] = Builder.CreateNSWAdd(
730 Op, Index, GEP->getOperand(0)->getName() + ".add");
731 continue;
732 }
733 if (isa<PHINode>(Val))
734 continue;
735
736 llvm_unreachable("Unexpected instruction type");
737 }
738
739 // Add the incoming values to the PHI nodes.
740 for (Value *Val : Explored) {
741 if (Val == Base)
742 continue;
743 // All the instructions have been created, we can now add edges to the
744 // phi nodes.
745 if (auto *PHI = dyn_cast<PHINode>(Val)) {
746 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]);
747 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) {
748 Value *NewIncoming = PHI->getIncomingValue(I);
749
750 if (NewInsts.find(NewIncoming) != NewInsts.end())
751 NewIncoming = NewInsts[NewIncoming];
752
753 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I));
754 }
755 }
756 }
757
758 for (Value *Val : Explored) {
759 if (Val == Base)
760 continue;
761
762 // Depending on the type, for external users we have to emit
763 // a GEP or a GEP + ptrtoint.
764 setInsertionPoint(Builder, Val, false);
765
766 // If required, create an inttoptr instruction for Base.
767 Value *NewBase = Base;
768 if (!Base->getType()->isPointerTy())
769 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(),
770 Start->getName() + "to.ptr");
771
772 Value *GEP = Builder.CreateInBoundsGEP(
773 Start->getType()->getPointerElementType(), NewBase,
774 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr");
775
776 if (!Val->getType()->isPointerTy()) {
777 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(),
778 Val->getName() + ".conv");
779 GEP = Cast;
780 }
781 Val->replaceAllUsesWith(GEP);
782 }
783
784 return NewInsts[Start];
785}
786
787/// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express
788/// the input Value as a constant indexed GEP. Returns a pair containing
789/// the GEPs Pointer and Index.
790static std::pair<Value *, Value *>
791getAsConstantIndexedAddress(Value *V, const DataLayout &DL) {
792 Type *IndexType = IntegerType::get(V->getContext(),
Elena Demikhovsky945b7e52018-02-14 06:58:08 +0000793 DL.getIndexTypeSizeInBits(V->getType()));
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000794
795 Constant *Index = ConstantInt::getNullValue(IndexType);
796 while (true) {
797 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) {
798 // We accept only inbouds GEPs here to exclude the possibility of
799 // overflow.
800 if (!GEP->isInBounds())
801 break;
802 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 &&
803 GEP->getType() == V->getType()) {
804 V = GEP->getOperand(0);
805 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1));
806 Index = ConstantExpr::getAdd(
807 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType));
808 continue;
809 }
810 break;
811 }
812 if (auto *CI = dyn_cast<IntToPtrInst>(V)) {
813 if (!CI->isNoopCast(DL))
814 break;
815 V = CI->getOperand(0);
816 continue;
817 }
818 if (auto *CI = dyn_cast<PtrToIntInst>(V)) {
819 if (!CI->isNoopCast(DL))
820 break;
821 V = CI->getOperand(0);
822 continue;
823 }
824 break;
825 }
826 return {V, Index};
827}
828
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000829/// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant.
830/// We can look through PHIs, GEPs and casts in order to determine a common base
831/// between GEPLHS and RHS.
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000832static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS,
833 ICmpInst::Predicate Cond,
834 const DataLayout &DL) {
Craig Topper5bbb6042019-08-27 21:38:56 +0000835 // FIXME: Support vector of pointers.
836 if (GEPLHS->getType()->isVectorTy())
837 return nullptr;
838
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000839 if (!GEPLHS->hasAllConstantIndices())
840 return nullptr;
841
Silviu Barangac6d21eb2017-01-31 14:04:15 +0000842 // Make sure the pointers have the same type.
843 if (GEPLHS->getType() != RHS->getType())
844 return nullptr;
845
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000846 Value *PtrBase, *Index;
847 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL);
848
849 // The set of nodes that will take part in this transformation.
850 SetVector<Value *> Nodes;
851
852 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes))
853 return nullptr;
854
855 // We know we can re-write this as
856 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2)
857 // Since we've only looked through inbouds GEPs we know that we
858 // can't have overflow on either side. We can therefore re-write
859 // this as:
860 // OFFSET1 cmp OFFSET2
861 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes);
862
863 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written
864 // GEP having PtrBase as the pointer base, and has returned in NewRHS the
865 // offset. Since Index is the offset of LHS to the base pointer, we will now
866 // compare the offsets instead of comparing the pointers.
867 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS);
868}
869
Sanjay Patel5f0217f2016-06-05 16:46:18 +0000870/// Fold comparisons between a GEP instruction and something else. At this point
871/// we know that the GEP is on the LHS of the comparison.
Sanjay Patel43395062016-07-21 18:07:40 +0000872Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS,
Chris Lattner2188e402010-01-04 07:37:31 +0000873 ICmpInst::Predicate Cond,
874 Instruction &I) {
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000875 // Don't transform signed compares of GEPs into index compares. Even if the
876 // GEP is inbounds, the final add of the base pointer can have signed overflow
877 // and would change the result of the icmp.
878 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be
Benjamin Kramerc7a22fe2012-02-21 13:40:06 +0000879 // the maximum signed value for the pointer type.
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000880 if (ICmpInst::isSigned(Cond))
Craig Topperf40110f2014-04-25 05:29:35 +0000881 return nullptr;
Benjamin Kramer6ee86902012-02-21 13:31:09 +0000882
Matt Arsenault44f60d02014-06-09 19:20:29 +0000883 // Look through bitcasts and addrspacecasts. We do not however want to remove
884 // 0 GEPs.
885 if (!isa<GetElementPtrInst>(RHS))
886 RHS = RHS->stripPointerCasts();
Chris Lattner2188e402010-01-04 07:37:31 +0000887
888 Value *PtrBase = GEPLHS->getOperand(0);
Craig Topper5bbb6042019-08-27 21:38:56 +0000889 // FIXME: Support vector pointer GEPs.
890 if (PtrBase == RHS && GEPLHS->isInBounds() &&
891 !GEPLHS->getType()->isVectorTy()) {
Chris Lattner2188e402010-01-04 07:37:31 +0000892 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0).
893 // This transformation (ignoring the base and scales) is valid because we
894 // know pointers can't overflow since the gep is inbounds. See if we can
895 // output an optimized form.
Sanjay Pateld93c4c02016-09-15 18:22:25 +0000896 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL);
Jim Grosbach129c52a2011-09-30 18:09:53 +0000897
Chris Lattner2188e402010-01-04 07:37:31 +0000898 // If not, synthesize the offset the hard way.
Craig Topperf40110f2014-04-25 05:29:35 +0000899 if (!Offset)
Chris Lattner2188e402010-01-04 07:37:31 +0000900 Offset = EmitGEPOffset(GEPLHS);
901 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset,
902 Constant::getNullValue(Offset->getType()));
Craig Topper5bbb6042019-08-27 21:38:56 +0000903 }
904
905 if (GEPLHS->isInBounds() && ICmpInst::isEquality(Cond) &&
906 isa<Constant>(RHS) && cast<Constant>(RHS)->isNullValue() &&
907 !NullPointerIsDefined(I.getFunction(),
908 RHS->getType()->getPointerAddressSpace())) {
Philip Reames5b02cfa2019-08-23 17:58:58 +0000909 // For most address spaces, an allocation can't be placed at null, but null
910 // itself is treated as a 0 size allocation in the in bounds rules. Thus,
911 // the only valid inbounds address derived from null, is null itself.
912 // Thus, we have four cases to consider:
913 // 1) Base == nullptr, Offset == 0 -> inbounds, null
914 // 2) Base == nullptr, Offset != 0 -> poison as the result is out of bounds
915 // 3) Base != nullptr, Offset == (-base) -> poison (crossing allocations)
916 // 4) Base != nullptr, Offset != (-base) -> nonnull (and possibly poison)
917 //
918 // (Note if we're indexing a type of size 0, that simply collapses into one
919 // of the buckets above.)
920 //
921 // In general, we're allowed to make values less poison (i.e. remove
922 // sources of full UB), so in this case, we just select between the two
923 // non-poison cases (1 and 4 above).
Philip Reamesb92c9712019-08-26 19:11:49 +0000924 //
925 // For vectors, we apply the same reasoning on a per-lane basis.
Philip Reames9cb059f2019-08-23 18:27:57 +0000926 auto *Base = GEPLHS->getPointerOperand();
Philip Reamesb92c9712019-08-26 19:11:49 +0000927 if (GEPLHS->getType()->isVectorTy() && Base->getType()->isPointerTy()) {
928 int NumElts = GEPLHS->getType()->getVectorNumElements();
929 Base = Builder.CreateVectorSplat(NumElts, Base);
930 }
Philip Reames9cb059f2019-08-23 18:27:57 +0000931 return new ICmpInst(Cond, Base,
Matt Arsenault524a9d52019-09-05 23:39:21 +0000932 ConstantExpr::getPointerBitCastOrAddrSpaceCast(
933 cast<Constant>(RHS), Base->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +0000934 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) {
935 // If the base pointers are different, but the indices are the same, just
936 // compare the base pointer.
937 if (PtrBase != GEPRHS->getOperand(0)) {
938 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands();
939 IndicesTheSame &= GEPLHS->getOperand(0)->getType() ==
940 GEPRHS->getOperand(0)->getType();
941 if (IndicesTheSame)
942 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i)
943 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
944 IndicesTheSame = false;
945 break;
946 }
947
948 // If all indices are the same, just compare the base pointers.
Jesper Antonssonc954b862018-10-01 14:59:25 +0000949 Type *BaseType = GEPLHS->getOperand(0)->getType();
950 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType())
David Majnemer5953d372013-06-29 10:28:04 +0000951 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0));
Chris Lattner2188e402010-01-04 07:37:31 +0000952
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000953 // If we're comparing GEPs with two base pointers that only differ in type
954 // and both GEPs have only constant indices or just one use, then fold
955 // the compare with the adjusted indices.
Craig Topper5bbb6042019-08-27 21:38:56 +0000956 // FIXME: Support vector of pointers.
Mehdi Aminia28d91d2015-03-10 02:37:25 +0000957 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() &&
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000958 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) &&
959 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) &&
960 PtrBase->stripPointerCasts() ==
Craig Topper5bbb6042019-08-27 21:38:56 +0000961 GEPRHS->getOperand(0)->stripPointerCasts() &&
962 !GEPLHS->getType()->isVectorTy()) {
Matt Arsenault44f60d02014-06-09 19:20:29 +0000963 Value *LOffset = EmitGEPOffset(GEPLHS);
964 Value *ROffset = EmitGEPOffset(GEPRHS);
965
966 // If we looked through an addrspacecast between different sized address
967 // spaces, the LHS and RHS pointers are different sized
968 // integers. Truncate to the smaller one.
969 Type *LHSIndexTy = LOffset->getType();
970 Type *RHSIndexTy = ROffset->getType();
971 if (LHSIndexTy != RHSIndexTy) {
972 if (LHSIndexTy->getPrimitiveSizeInBits() <
973 RHSIndexTy->getPrimitiveSizeInBits()) {
Craig Topperbb4069e2017-07-07 23:16:26 +0000974 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000975 } else
Craig Topperbb4069e2017-07-07 23:16:26 +0000976 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy);
Matt Arsenault44f60d02014-06-09 19:20:29 +0000977 }
978
Craig Topperbb4069e2017-07-07 23:16:26 +0000979 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond),
980 LOffset, ROffset);
Sanjay Patel4b198802016-02-01 22:23:39 +0000981 return replaceInstUsesWith(I, Cmp);
Benjamin Kramer7adb1892012-02-20 15:07:47 +0000982 }
983
Chris Lattner2188e402010-01-04 07:37:31 +0000984 // Otherwise, the base pointers are different and the indices are
Silviu Barangaf29dfd32016-01-15 15:52:05 +0000985 // different. Try convert this to an indexed compare by looking through
986 // PHIs/casts.
987 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +0000988 }
989
990 // If one of the GEPs has all zero indices, recurse.
Craig Topperf79d8a02019-08-28 15:40:34 +0000991 // FIXME: Handle vector of pointers.
992 if (!GEPLHS->getType()->isVectorTy() && GEPLHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000993 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0),
David Majnemer92a8a7d2013-06-29 09:45:35 +0000994 ICmpInst::getSwappedPredicate(Cond), I);
Chris Lattner2188e402010-01-04 07:37:31 +0000995
996 // If the other GEP has all zero indices, recurse.
Craig Topperf79d8a02019-08-28 15:40:34 +0000997 // FIXME: Handle vector of pointers.
998 if (!GEPRHS->getType()->isVectorTy() && GEPRHS->hasAllZeroIndices())
Sanjay Patel43395062016-07-21 18:07:40 +0000999 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I);
Chris Lattner2188e402010-01-04 07:37:31 +00001000
Stuart Hastings66a82b92011-05-14 05:55:10 +00001001 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds();
Chris Lattner2188e402010-01-04 07:37:31 +00001002 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) {
1003 // If the GEPs only differ by one index, compare it.
1004 unsigned NumDifferences = 0; // Keep track of # differences.
1005 unsigned DiffOperand = 0; // The operand that differs.
1006 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i)
1007 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) {
Craig Topper5bbb6042019-08-27 21:38:56 +00001008 Type *LHSType = GEPLHS->getOperand(i)->getType();
1009 Type *RHSType = GEPRHS->getOperand(i)->getType();
1010 // FIXME: Better support for vector of pointers.
1011 if (LHSType->getPrimitiveSizeInBits() !=
1012 RHSType->getPrimitiveSizeInBits() ||
1013 (GEPLHS->getType()->isVectorTy() &&
1014 (!LHSType->isVectorTy() || !RHSType->isVectorTy()))) {
Chris Lattner2188e402010-01-04 07:37:31 +00001015 // Irreconcilable differences.
1016 NumDifferences = 2;
1017 break;
Chris Lattner2188e402010-01-04 07:37:31 +00001018 }
Craig Topper5bbb6042019-08-27 21:38:56 +00001019
1020 if (NumDifferences++) break;
1021 DiffOperand = i;
Chris Lattner2188e402010-01-04 07:37:31 +00001022 }
1023
Rafael Espindolaa7bbc0b2013-06-06 17:03:05 +00001024 if (NumDifferences == 0) // SAME GEP?
Sanjay Patel4b198802016-02-01 22:23:39 +00001025 return replaceInstUsesWith(I, // No comparison is needed here.
Jesper Antonsson719fa052018-09-20 13:37:28 +00001026 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond)));
Chris Lattner2188e402010-01-04 07:37:31 +00001027
Stuart Hastings66a82b92011-05-14 05:55:10 +00001028 else if (NumDifferences == 1 && GEPsInBounds) {
Chris Lattner2188e402010-01-04 07:37:31 +00001029 Value *LHSV = GEPLHS->getOperand(DiffOperand);
1030 Value *RHSV = GEPRHS->getOperand(DiffOperand);
1031 // Make sure we do a signed comparison here.
1032 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV);
1033 }
1034 }
1035
1036 // Only lower this if the icmp is the only user of the GEP or if we expect
1037 // the result to fold to a constant!
Mehdi Aminia28d91d2015-03-10 02:37:25 +00001038 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) &&
Chris Lattner2188e402010-01-04 07:37:31 +00001039 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) {
1040 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2)
1041 Value *L = EmitGEPOffset(GEPLHS);
1042 Value *R = EmitGEPOffset(GEPRHS);
1043 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R);
1044 }
1045 }
Silviu Barangaf29dfd32016-01-15 15:52:05 +00001046
1047 // Try convert this to an indexed compare by looking through PHIs/casts as a
1048 // last resort.
1049 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL);
Chris Lattner2188e402010-01-04 07:37:31 +00001050}
1051
Pete Cooper980a9352016-08-12 17:13:28 +00001052Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI,
1053 const AllocaInst *Alloca,
1054 const Value *Other) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001055 assert(ICI.isEquality() && "Cannot fold non-equality comparison.");
1056
1057 // It would be tempting to fold away comparisons between allocas and any
1058 // pointer not based on that alloca (e.g. an argument). However, even
1059 // though such pointers cannot alias, they can still compare equal.
1060 //
1061 // But LLVM doesn't specify where allocas get their memory, so if the alloca
1062 // doesn't escape we can argue that it's impossible to guess its value, and we
1063 // can therefore act as if any such guesses are wrong.
1064 //
1065 // The code below checks that the alloca doesn't escape, and that it's only
1066 // used in a comparison once (the current instruction). The
1067 // single-comparison-use condition ensures that we're trivially folding all
1068 // comparisons against the alloca consistently, and avoids the risk of
1069 // erroneously folding a comparison of the pointer with itself.
1070
1071 unsigned MaxIter = 32; // Break cycles and bound to constant-time.
1072
Pete Cooper980a9352016-08-12 17:13:28 +00001073 SmallVector<const Use *, 32> Worklist;
1074 for (const Use &U : Alloca->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001075 if (Worklist.size() >= MaxIter)
1076 return nullptr;
1077 Worklist.push_back(&U);
1078 }
1079
1080 unsigned NumCmps = 0;
1081 while (!Worklist.empty()) {
1082 assert(Worklist.size() <= MaxIter);
Pete Cooper980a9352016-08-12 17:13:28 +00001083 const Use *U = Worklist.pop_back_val();
1084 const Value *V = U->getUser();
Hans Wennborgf1f36512015-10-07 00:20:07 +00001085 --MaxIter;
1086
1087 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) ||
1088 isa<SelectInst>(V)) {
1089 // Track the uses.
1090 } else if (isa<LoadInst>(V)) {
1091 // Loading from the pointer doesn't escape it.
1092 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001093 } else if (const auto *SI = dyn_cast<StoreInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001094 // Storing *to* the pointer is fine, but storing the pointer escapes it.
1095 if (SI->getValueOperand() == U->get())
1096 return nullptr;
1097 continue;
1098 } else if (isa<ICmpInst>(V)) {
1099 if (NumCmps++)
1100 return nullptr; // Found more than one cmp.
1101 continue;
Pete Cooper980a9352016-08-12 17:13:28 +00001102 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001103 switch (Intrin->getIntrinsicID()) {
1104 // These intrinsics don't escape or compare the pointer. Memset is safe
1105 // because we don't allow ptrtoint. Memcpy and memmove are safe because
1106 // we don't allow stores, so src cannot point to V.
1107 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end:
Hans Wennborgf1f36512015-10-07 00:20:07 +00001108 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset:
1109 continue;
1110 default:
1111 return nullptr;
1112 }
1113 } else {
1114 return nullptr;
1115 }
Pete Cooper980a9352016-08-12 17:13:28 +00001116 for (const Use &U : V->uses()) {
Hans Wennborgf1f36512015-10-07 00:20:07 +00001117 if (Worklist.size() >= MaxIter)
1118 return nullptr;
1119 Worklist.push_back(&U);
1120 }
1121 }
1122
1123 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType());
Sanjay Patel4b198802016-02-01 22:23:39 +00001124 return replaceInstUsesWith(
Hans Wennborgf1f36512015-10-07 00:20:07 +00001125 ICI,
1126 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate())));
1127}
1128
Craig Topperbee74792018-08-20 23:04:25 +00001129/// Fold "icmp pred (X+C), X".
1130Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C,
Sanjay Patel43395062016-07-21 18:07:40 +00001131 ICmpInst::Predicate Pred) {
Chris Lattner2188e402010-01-04 07:37:31 +00001132 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0,
Chris Lattner0ab5e2c2011-04-15 05:18:47 +00001133 // so the values can never be equal. Similarly for all other "or equals"
Chris Lattner2188e402010-01-04 07:37:31 +00001134 // operators.
Craig Topperbee74792018-08-20 23:04:25 +00001135 assert(!!C && "C should not be zero!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00001136
Chris Lattner8c92b572010-01-08 17:48:19 +00001137 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255
Chris Lattner2188e402010-01-04 07:37:31 +00001138 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253
1139 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0
1140 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) {
Craig Topperbee74792018-08-20 23:04:25 +00001141 Constant *R = ConstantInt::get(X->getType(),
1142 APInt::getMaxValue(C.getBitWidth()) - C);
Chris Lattner2188e402010-01-04 07:37:31 +00001143 return new ICmpInst(ICmpInst::ICMP_UGT, X, R);
1144 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00001145
Chris Lattner2188e402010-01-04 07:37:31 +00001146 // (X+1) >u X --> X <u (0-1) --> X != 255
1147 // (X+2) >u X --> X <u (0-2) --> X <u 254
1148 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0
Duncan Sandse5220012011-02-17 07:46:37 +00001149 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE)
Craig Topperbee74792018-08-20 23:04:25 +00001150 return new ICmpInst(ICmpInst::ICMP_ULT, X,
1151 ConstantInt::get(X->getType(), -C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001152
Craig Topperbee74792018-08-20 23:04:25 +00001153 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth());
Chris Lattner2188e402010-01-04 07:37:31 +00001154
1155 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127
1156 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125
1157 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0
1158 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1
1159 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126
1160 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127
Duncan Sandse5220012011-02-17 07:46:37 +00001161 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
Craig Topperbee74792018-08-20 23:04:25 +00001162 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1163 ConstantInt::get(X->getType(), SMax - C));
Jim Grosbach129c52a2011-09-30 18:09:53 +00001164
Chris Lattner2188e402010-01-04 07:37:31 +00001165 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127
1166 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126
1167 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1
1168 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2
1169 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126
1170 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128
Jim Grosbach129c52a2011-09-30 18:09:53 +00001171
Chris Lattner2188e402010-01-04 07:37:31 +00001172 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE);
Craig Topperbee74792018-08-20 23:04:25 +00001173 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1174 ConstantInt::get(X->getType(), SMax - (C - 1)));
Chris Lattner2188e402010-01-04 07:37:31 +00001175}
1176
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001177/// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" ->
1178/// (icmp eq/ne A, Log2(AP2/AP1)) ->
1179/// (icmp eq/ne A, Log2(AP2) - Log2(AP1)).
1180Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A,
1181 const APInt &AP1,
1182 const APInt &AP2) {
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001183 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1184
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001185 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1186 if (I.getPredicate() == I.ICMP_NE)
1187 Pred = CmpInst::getInversePredicate(Pred);
1188 return new ICmpInst(Pred, LHS, RHS);
1189 };
1190
David Majnemer2abb8182014-10-25 07:13:13 +00001191 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001192 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001193 return nullptr;
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001194
1195 bool IsAShr = isa<AShrOperator>(I.getOperand(0));
David Majnemer2abb8182014-10-25 07:13:13 +00001196 if (IsAShr) {
1197 if (AP2.isAllOnesValue())
1198 return nullptr;
1199 if (AP2.isNegative() != AP1.isNegative())
1200 return nullptr;
1201 if (AP2.sgt(AP1))
1202 return nullptr;
1203 }
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001204
David Majnemerd2056022014-10-21 19:51:55 +00001205 if (!AP1)
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001206 // 'A' must be large enough to shift out the highest set bit.
1207 return getICmp(I.ICMP_UGT, A,
1208 ConstantInt::get(A->getType(), AP2.logBase2()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001209
David Majnemerd2056022014-10-21 19:51:55 +00001210 if (AP1 == AP2)
1211 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001212
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001213 int Shift;
David Majnemerd2056022014-10-21 19:51:55 +00001214 if (IsAShr && AP1.isNegative())
David Majnemere5977eb2015-09-19 00:48:26 +00001215 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes();
Andrea Di Biagio5b92b492014-09-17 11:32:31 +00001216 else
David Majnemere5977eb2015-09-19 00:48:26 +00001217 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros();
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001218
David Majnemerd2056022014-10-21 19:51:55 +00001219 if (Shift > 0) {
David Majnemere5977eb2015-09-19 00:48:26 +00001220 if (IsAShr && AP1 == AP2.ashr(Shift)) {
1221 // There are multiple solutions if we are comparing against -1 and the LHS
David Majnemer47ce0b82015-09-19 00:48:31 +00001222 // of the ashr is not a power of two.
David Majnemere5977eb2015-09-19 00:48:26 +00001223 if (AP1.isAllOnesValue() && !AP2.isPowerOf2())
1224 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift));
David Majnemerd2056022014-10-21 19:51:55 +00001225 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
David Majnemere5977eb2015-09-19 00:48:26 +00001226 } else if (AP1 == AP2.lshr(Shift)) {
1227 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1228 }
David Majnemerd2056022014-10-21 19:51:55 +00001229 }
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001230
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001231 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001232 // FIXME: This should always be handled by InstSimplify?
1233 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1234 return replaceInstUsesWith(I, TorF);
Suyog Sarda3a8c2c12014-07-22 19:19:36 +00001235}
Chris Lattner2188e402010-01-04 07:37:31 +00001236
Sanjay Patel8da42cc2016-09-15 22:26:31 +00001237/// Handle "(icmp eq/ne (shl AP2, A), AP1)" ->
1238/// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)).
1239Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A,
1240 const APInt &AP1,
1241 const APInt &AP2) {
David Majnemer59939ac2014-10-19 08:23:08 +00001242 assert(I.isEquality() && "Cannot fold icmp gt/lt");
1243
David Majnemer59939ac2014-10-19 08:23:08 +00001244 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) {
1245 if (I.getPredicate() == I.ICMP_NE)
1246 Pred = CmpInst::getInversePredicate(Pred);
1247 return new ICmpInst(Pred, LHS, RHS);
1248 };
1249
David Majnemer2abb8182014-10-25 07:13:13 +00001250 // Don't bother doing any work for cases which InstSimplify handles.
Craig Topper73ba1c82017-06-07 07:40:37 +00001251 if (AP2.isNullValue())
David Majnemer2abb8182014-10-25 07:13:13 +00001252 return nullptr;
David Majnemer59939ac2014-10-19 08:23:08 +00001253
1254 unsigned AP2TrailingZeros = AP2.countTrailingZeros();
1255
1256 if (!AP1 && AP2TrailingZeros != 0)
Sanjay Patelaf91d1f2016-09-15 21:35:30 +00001257 return getICmp(
1258 I.ICMP_UGE, A,
1259 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros));
David Majnemer59939ac2014-10-19 08:23:08 +00001260
1261 if (AP1 == AP2)
1262 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType()));
1263
1264 // Get the distance between the lowest bits that are set.
1265 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros;
1266
1267 if (Shift > 0 && AP2.shl(Shift) == AP1)
1268 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift));
1269
1270 // Shifting const2 will never be equal to const1.
Sanjay Patel524fcdf2016-09-15 19:04:55 +00001271 // FIXME: This should always be handled by InstSimplify?
1272 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE);
1273 return replaceInstUsesWith(I, TorF);
David Majnemer59939ac2014-10-19 08:23:08 +00001274}
1275
Sanjay Patel06b127a2016-09-15 14:37:50 +00001276/// The caller has matched a pattern of the form:
1277/// I = icmp ugt (add (add A, B), CI2), CI1
1278/// If this is of the form:
1279/// sum = a + b
1280/// if (sum+128 >u 255)
1281/// Then replace it with llvm.sadd.with.overflow.i8.
1282///
Sanjay Pateld93c4c02016-09-15 18:22:25 +00001283static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B,
Sanjay Patel06b127a2016-09-15 14:37:50 +00001284 ConstantInt *CI2, ConstantInt *CI1,
1285 InstCombiner &IC) {
1286 // The transformation we're trying to do here is to transform this into an
1287 // llvm.sadd.with.overflow. To do this, we have to replace the original add
1288 // with a narrower add, and discard the add-with-constant that is part of the
1289 // range check (if we can't eliminate it, this isn't profitable).
1290
1291 // In order to eliminate the add-with-constant, the compare can be its only
1292 // use.
1293 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0));
1294 if (!AddWithCst->hasOneUse())
1295 return nullptr;
1296
1297 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow.
1298 if (!CI2->getValue().isPowerOf2())
1299 return nullptr;
1300 unsigned NewWidth = CI2->getValue().countTrailingZeros();
1301 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31)
1302 return nullptr;
1303
1304 // The width of the new add formed is 1 more than the bias.
1305 ++NewWidth;
1306
1307 // Check to see that CI1 is an all-ones value with NewWidth bits.
1308 if (CI1->getBitWidth() == NewWidth ||
1309 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth))
1310 return nullptr;
1311
1312 // This is only really a signed overflow check if the inputs have been
1313 // sign-extended; check for that condition. For example, if CI2 is 2^31 and
1314 // the operands of the add are 64 bits wide, we need at least 33 sign bits.
1315 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1;
1316 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits ||
1317 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits)
1318 return nullptr;
1319
1320 // In order to replace the original add with a narrower
1321 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant
1322 // and truncates that discard the high bits of the add. Verify that this is
1323 // the case.
1324 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0));
1325 for (User *U : OrigAdd->users()) {
1326 if (U == AddWithCst)
1327 continue;
1328
1329 // Only accept truncates for now. We would really like a nice recursive
1330 // predicate like SimplifyDemandedBits, but which goes downwards the use-def
1331 // chain to see which bits of a value are actually demanded. If the
1332 // original add had another add which was then immediately truncated, we
1333 // could still do the transformation.
1334 TruncInst *TI = dyn_cast<TruncInst>(U);
1335 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth)
1336 return nullptr;
1337 }
1338
1339 // If the pattern matches, truncate the inputs to the narrower type and
1340 // use the sadd_with_overflow intrinsic to efficiently compute both the
1341 // result and the overflow bit.
1342 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth);
James Y Knight7976eb52019-02-01 20:43:25 +00001343 Function *F = Intrinsic::getDeclaration(
1344 I.getModule(), Intrinsic::sadd_with_overflow, NewType);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001345
Craig Topperbb4069e2017-07-07 23:16:26 +00001346 InstCombiner::BuilderTy &Builder = IC.Builder;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001347
1348 // Put the new code above the original add, in case there are any uses of the
1349 // add between the add and the compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00001350 Builder.SetInsertPoint(OrigAdd);
Sanjay Patel06b127a2016-09-15 14:37:50 +00001351
Craig Topperbb4069e2017-07-07 23:16:26 +00001352 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc");
1353 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc");
1354 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd");
1355 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result");
1356 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001357
1358 // The inner add was the result of the narrow add, zero extended to the
1359 // wider type. Replace it with the result computed by the intrinsic.
1360 IC.replaceInstUsesWith(*OrigAdd, ZExt);
1361
1362 // The original icmp gets replaced with the overflow value.
1363 return ExtractValueInst::Create(Call, 1, "sadd.overflow");
1364}
1365
Roman Lebedevbe612ea2019-07-30 15:28:22 +00001366/// If we have:
1367/// icmp eq/ne (urem/srem %x, %y), 0
1368/// iff %y is a power-of-two, we can replace this with a bit test:
1369/// icmp eq/ne (and %x, (add %y, -1)), 0
1370Instruction *InstCombiner::foldIRemByPowerOfTwoToBitTest(ICmpInst &I) {
1371 // This fold is only valid for equality predicates.
1372 if (!I.isEquality())
1373 return nullptr;
1374 ICmpInst::Predicate Pred;
1375 Value *X, *Y, *Zero;
1376 if (!match(&I, m_ICmp(Pred, m_OneUse(m_IRem(m_Value(X), m_Value(Y))),
1377 m_CombineAnd(m_Zero(), m_Value(Zero)))))
1378 return nullptr;
1379 if (!isKnownToBeAPowerOfTwo(Y, /*OrZero*/ true, 0, &I))
1380 return nullptr;
1381 // This may increase instruction count, we don't enforce that Y is a constant.
1382 Value *Mask = Builder.CreateAdd(Y, Constant::getAllOnesValue(Y->getType()));
1383 Value *Masked = Builder.CreateAnd(X, Mask);
1384 return ICmpInst::Create(Instruction::ICmp, Pred, Masked, Zero);
1385}
1386
Roman Lebedevf55818e2019-07-01 09:41:43 +00001387// Handle icmp pred X, 0
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001388Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) {
1389 CmpInst::Predicate Pred = Cmp.getPredicate();
Roman Lebedevf55818e2019-07-01 09:41:43 +00001390 if (!match(Cmp.getOperand(1), m_Zero()))
1391 return nullptr;
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001392
Roman Lebedevf55818e2019-07-01 09:41:43 +00001393 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0)
1394 if (Pred == ICmpInst::ICMP_SGT) {
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001395 Value *A, *B;
Roman Lebedevf55818e2019-07-01 09:41:43 +00001396 SelectPatternResult SPR = matchSelectPattern(Cmp.getOperand(0), A, B);
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001397 if (SPR.Flavor == SPF_SMIN) {
1398 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT))
1399 return new ICmpInst(Pred, B, Cmp.getOperand(1));
1400 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT))
1401 return new ICmpInst(Pred, A, Cmp.getOperand(1));
1402 }
1403 }
Roman Lebedevf55818e2019-07-01 09:41:43 +00001404
Roman Lebedevbe612ea2019-07-30 15:28:22 +00001405 if (Instruction *New = foldIRemByPowerOfTwoToBitTest(Cmp))
1406 return New;
1407
Roman Lebedevf55818e2019-07-01 09:41:43 +00001408 // Given:
1409 // icmp eq/ne (urem %x, %y), 0
1410 // Iff %x has 0 or 1 bits set, and %y has at least 2 bits set, omit 'urem':
1411 // icmp eq/ne %x, 0
1412 Value *X, *Y;
1413 if (match(Cmp.getOperand(0), m_URem(m_Value(X), m_Value(Y))) &&
1414 ICmpInst::isEquality(Pred)) {
1415 KnownBits XKnown = computeKnownBits(X, 0, &Cmp);
1416 KnownBits YKnown = computeKnownBits(Y, 0, &Cmp);
1417 if (XKnown.countMaxPopulation() == 1 && YKnown.countMinPopulation() >= 2)
1418 return new ICmpInst(Pred, X, Cmp.getOperand(1));
1419 }
1420
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00001421 return nullptr;
1422}
1423
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001424/// Fold icmp Pred X, C.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001425/// TODO: This code structure does not make sense. The saturating add fold
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001426/// should be moved to some other helper and extended as noted below (it is also
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001427/// possible that code has been made unnecessary - do we canonicalize IR to
1428/// overflow/saturating intrinsics or not?).
Sanjay Patel97459832016-09-15 15:11:12 +00001429Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) {
Sanjay Patel97459832016-09-15 15:11:12 +00001430 // Match the following pattern, which is a common idiom when writing
1431 // overflow-safe integer arithmetic functions. The source performs an addition
1432 // in wider type and explicitly checks for overflow using comparisons against
1433 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic.
1434 //
1435 // TODO: This could probably be generalized to handle other overflow-safe
1436 // operations if we worked out the formulas to compute the appropriate magic
1437 // constants.
1438 //
1439 // sum = a + b
1440 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001441 CmpInst::Predicate Pred = Cmp.getPredicate();
1442 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1);
1443 Value *A, *B;
1444 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI
1445 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) &&
1446 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2))))
1447 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this))
1448 return Res;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001449
Sanjay Patela40bf9ff2018-12-04 15:35:17 +00001450 return nullptr;
1451}
1452
1453/// Canonicalize icmp instructions based on dominating conditions.
1454Instruction *InstCombiner::foldICmpWithDominatingICmp(ICmpInst &Cmp) {
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001455 // This is a cheap/incomplete check for dominance - just match a single
1456 // predecessor with a conditional branch.
1457 BasicBlock *CmpBB = Cmp.getParent();
1458 BasicBlock *DomBB = CmpBB->getSinglePredecessor();
1459 if (!DomBB)
Sanjay Patel40c53ea2016-09-15 16:23:20 +00001460 return nullptr;
Sanjay Patel06b127a2016-09-15 14:37:50 +00001461
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001462 Value *DomCond;
Sanjay Patel97459832016-09-15 15:11:12 +00001463 BasicBlock *TrueBB, *FalseBB;
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001464 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB)))
1465 return nullptr;
1466
1467 assert((TrueBB == CmpBB || FalseBB == CmpBB) &&
1468 "Predecessor block does not point to successor?");
1469
1470 // The branch should get simplified. Don't bother simplifying this condition.
1471 if (TrueBB == FalseBB)
1472 return nullptr;
1473
Sanjay Patelbaffae92018-12-05 15:04:00 +00001474 // Try to simplify this compare to T/F based on the dominating condition.
1475 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB);
1476 if (Imp)
1477 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp));
1478
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001479 CmpInst::Predicate Pred = Cmp.getPredicate();
1480 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1);
1481 ICmpInst::Predicate DomPred;
1482 const APInt *C, *DomC;
1483 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) &&
1484 match(Y, m_APInt(C))) {
1485 // We have 2 compares of a variable with constants. Calculate the constant
1486 // ranges of those compares to see if we can transform the 2nd compare:
1487 // DomBB:
1488 // DomCond = icmp DomPred X, DomC
1489 // br DomCond, CmpBB, FalseBB
1490 // CmpBB:
1491 // Cmp = icmp Pred X, C
1492 ConstantRange CR = ConstantRange::makeAllowedICmpRegion(Pred, *C);
Sanjay Patel97459832016-09-15 15:11:12 +00001493 ConstantRange DominatingCR =
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001494 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC)
1495 : ConstantRange::makeExactICmpRegion(
1496 CmpInst::getInversePredicate(DomPred), *DomC);
Sanjay Patel97459832016-09-15 15:11:12 +00001497 ConstantRange Intersection = DominatingCR.intersectWith(CR);
1498 ConstantRange Difference = DominatingCR.difference(CR);
1499 if (Intersection.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001500 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel97459832016-09-15 15:11:12 +00001501 if (Difference.isEmptySet())
Craig Topperbb4069e2017-07-07 23:16:26 +00001502 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel06b127a2016-09-15 14:37:50 +00001503
Sanjay Patel97459832016-09-15 15:11:12 +00001504 // Canonicalizing a sign bit comparison that gets used in a branch,
1505 // pessimizes codegen by generating branch on zero instruction instead
1506 // of a test and branch. So we avoid canonicalizing in such situations
1507 // because test and branch instruction has better branch displacement
1508 // than compare and branch instruction.
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001509 bool UnusedBit;
1510 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit);
Eric Christophera95aac32017-06-30 01:57:48 +00001511 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp)))
1512 return nullptr;
1513
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00001514 if (const APInt *EqC = Intersection.getSingleElement())
1515 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC));
1516 if (const APInt *NeC = Difference.getSingleElement())
1517 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC));
Sanjay Patel06b127a2016-09-15 14:37:50 +00001518 }
1519
1520 return nullptr;
1521}
1522
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001523/// Fold icmp (trunc X, Y), C.
1524Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00001525 TruncInst *Trunc,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001526 const APInt &C) {
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001527 ICmpInst::Predicate Pred = Cmp.getPredicate();
1528 Value *X = Trunc->getOperand(0);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001529 if (C.isOneValue() && C.getBitWidth() > 1) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001530 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1
1531 Value *V = nullptr;
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001532 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001533 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1534 ConstantInt::get(V->getType(), 1));
1535 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001536
1537 if (Cmp.isEquality() && Trunc->hasOneUse()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001538 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all
1539 // of the high bits truncated out of x are known.
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001540 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(),
1541 SrcBits = X->getType()->getScalarSizeInBits();
Craig Topper8205a1a2017-05-24 16:53:07 +00001542 KnownBits Known = computeKnownBits(X, 0, &Cmp);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001543
1544 // If all the high bits are known, we can do this xform.
Craig Topperb45eabc2017-04-26 16:39:58 +00001545 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001546 // Pull in the high bits from known-ones set.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001547 APInt NewRHS = C.zext(SrcBits);
Craig Topperb45eabc2017-04-26 16:39:58 +00001548 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits);
Sanjay Patel40e8ca42016-08-18 20:28:54 +00001549 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001550 }
1551 }
Sanjay Patel5f4ce4e2016-08-18 20:25:16 +00001552
Sanjay Patela3f4f082016-08-16 17:54:36 +00001553 return nullptr;
1554}
1555
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001556/// Fold icmp (xor X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001557Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp,
1558 BinaryOperator *Xor,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001559 const APInt &C) {
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001560 Value *X = Xor->getOperand(0);
1561 Value *Y = Xor->getOperand(1);
Sanjay Pateldaffec912016-08-17 19:45:18 +00001562 const APInt *XorC;
Sanjay Patel4c5e60d2016-08-18 14:10:48 +00001563 if (!match(Y, m_APInt(XorC)))
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001564 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001565
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001566 // If this is a comparison that tests the signbit (X < 0) or (x > -1),
1567 // fold the xor.
1568 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topperdf63b962017-10-03 19:14:23 +00001569 bool TrueIfSigned = false;
1570 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001571
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001572 // If the sign bit of the XorCst is not set, there is no change to
1573 // the operation, just stop using the Xor.
Sanjay Pateldaffec912016-08-17 19:45:18 +00001574 if (!XorC->isNegative()) {
1575 Cmp.setOperand(0, X);
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001576 Worklist.Add(Xor);
1577 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001578 }
1579
Craig Topperdf63b962017-10-03 19:14:23 +00001580 // Emit the opposite comparison.
1581 if (TrueIfSigned)
1582 return new ICmpInst(ICmpInst::ICMP_SGT, X,
1583 ConstantInt::getAllOnesValue(X->getType()));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001584 else
Craig Topperdf63b962017-10-03 19:14:23 +00001585 return new ICmpInst(ICmpInst::ICMP_SLT, X,
1586 ConstantInt::getNullValue(X->getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001587 }
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001588
1589 if (Xor->hasOneUse()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00001590 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask))
1591 if (!Cmp.isEquality() && XorC->isSignMask()) {
Sanjay Pateldaffec912016-08-17 19:45:18 +00001592 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1593 : Cmp.getSignedPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001594 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001595 }
1596
Craig Topperbcfd2d12017-04-20 16:56:25 +00001597 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask))
Sanjay Pateldaffec912016-08-17 19:45:18 +00001598 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) {
1599 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate()
1600 : Cmp.getSignedPredicate();
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001601 Pred = Cmp.getSwappedPredicate(Pred);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001602 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC));
Sanjay Patel6d5f4482016-08-17 19:23:42 +00001603 }
1604 }
1605
Sanjay Patel26725bd2018-09-11 22:00:15 +00001606 // Mask constant magic can eliminate an 'xor' with unsigned compares.
1607 if (Pred == ICmpInst::ICMP_UGT) {
1608 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2)
1609 if (*XorC == ~C && (C + 1).isPowerOf2())
1610 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
1611 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2)
1612 if (*XorC == C && (C + 1).isPowerOf2())
1613 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
1614 }
1615 if (Pred == ICmpInst::ICMP_ULT) {
1616 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2)
1617 if (*XorC == -C && C.isPowerOf2())
1618 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1619 ConstantInt::get(X->getType(), ~C));
1620 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2)
1621 if (*XorC == C && (-C).isPowerOf2())
1622 return new ICmpInst(ICmpInst::ICMP_UGT, X,
1623 ConstantInt::get(X->getType(), ~C));
1624 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001625 return nullptr;
1626}
1627
Sanjay Patel14e0e182016-08-26 18:28:46 +00001628/// Fold icmp (and (sh X, Y), C2), C1.
1629Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001630 const APInt &C1, const APInt &C2) {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001631 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0));
1632 if (!Shift || !Shift->isShift())
Sanjay Patelda9c5622016-08-26 17:15:22 +00001633 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001634
Sanjay Patelda9c5622016-08-26 17:15:22 +00001635 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could
1636 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in
1637 // code produced by the clang front-end, for bitfield access.
Sanjay Patelda9c5622016-08-26 17:15:22 +00001638 // This seemingly simple opportunity to fold away a shift turns out to be
1639 // rather complicated. See PR17827 for details.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001640 unsigned ShiftOpcode = Shift->getOpcode();
1641 bool IsShl = ShiftOpcode == Instruction::Shl;
1642 const APInt *C3;
1643 if (match(Shift->getOperand(1), m_APInt(C3))) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001644 bool CanFold = false;
Craig Topper7a930922017-10-04 23:06:13 +00001645 if (ShiftOpcode == Instruction::Shl) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001646 // For a left shift, we can fold if the comparison is not signed. We can
1647 // also fold a signed comparison if the mask value and comparison value
1648 // are not negative. These constraints may not be obvious, but we can
1649 // prove that they are correct using an SMT solver.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001650 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative()))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001651 CanFold = true;
Craig Topper7a930922017-10-04 23:06:13 +00001652 } else {
1653 bool IsAshr = ShiftOpcode == Instruction::AShr;
Sanjay Patelda9c5622016-08-26 17:15:22 +00001654 // For a logical right shift, we can fold if the comparison is not signed.
1655 // We can also fold a signed comparison if the shifted mask value and the
1656 // shifted comparison value are not negative. These constraints may not be
1657 // obvious, but we can prove that they are correct using an SMT solver.
Craig Topper7a930922017-10-04 23:06:13 +00001658 // For an arithmetic shift right we can do the same, if we ensure
1659 // the And doesn't use any bits being shifted in. Normally these would
1660 // be turned into lshr by SimplifyDemandedBits, but not if there is an
1661 // additional user.
1662 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) {
1663 if (!Cmp.isSigned() ||
1664 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative()))
1665 CanFold = true;
1666 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001667 }
1668
Sanjay Patelda9c5622016-08-26 17:15:22 +00001669 if (CanFold) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00001670 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001671 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001672 // Check to see if we are shifting out any of the bits being compared.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001673 if (SameAsC1 != C1) {
Sanjay Patelda9c5622016-08-26 17:15:22 +00001674 // If we shifted bits out, the fold is not going to work out. As a
1675 // special case, check to see if this means that the result is always
1676 // true or false now.
1677 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001678 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType()));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001679 if (Cmp.getPredicate() == ICmpInst::ICMP_NE)
Sanjay Patel1c608f42016-09-08 16:54:02 +00001680 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType()));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001681 } else {
Sanjay Patel9b40f982016-09-07 22:33:03 +00001682 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst));
Craig Topper8ed1aa92017-10-03 05:31:07 +00001683 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3);
Sanjay Patel9b40f982016-09-07 22:33:03 +00001684 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst));
Sanjay Patelda9c5622016-08-26 17:15:22 +00001685 And->setOperand(0, Shift->getOperand(0));
1686 Worklist.Add(Shift); // Shift is dead.
1687 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001688 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001689 }
1690 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001691
Sanjay Patelda9c5622016-08-26 17:15:22 +00001692 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is
1693 // preferable because it allows the C2 << Y expression to be hoisted out of a
1694 // loop if Y is invariant and X is not.
Craig Topper8ed1aa92017-10-03 05:31:07 +00001695 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() &&
Sanjay Patelda9c5622016-08-26 17:15:22 +00001696 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) {
1697 // Compute C2 << Y.
Sanjay Patel9b40f982016-09-07 22:33:03 +00001698 Value *NewShift =
Craig Topperbb4069e2017-07-07 23:16:26 +00001699 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1))
1700 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001701
Sanjay Patelda9c5622016-08-26 17:15:22 +00001702 // Compute X & (C2 << Y).
Craig Topperbb4069e2017-07-07 23:16:26 +00001703 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001704 Cmp.setOperand(0, NewAnd);
1705 return &Cmp;
1706 }
1707
Sanjay Patel14e0e182016-08-26 18:28:46 +00001708 return nullptr;
1709}
1710
1711/// Fold icmp (and X, C2), C1.
1712Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp,
1713 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001714 const APInt &C1) {
Huihui Zhang670778c2019-06-19 17:31:39 +00001715 bool isICMP_NE = Cmp.getPredicate() == ICmpInst::ICMP_NE;
1716
Sanjay Patel05aadf82018-10-10 20:47:46 +00001717 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1
1718 // TODO: We canonicalize to the longer form for scalars because we have
1719 // better analysis/folds for icmp, and codegen may be better with icmp.
Huihui Zhang670778c2019-06-19 17:31:39 +00001720 if (isICMP_NE && Cmp.getType()->isVectorTy() && C1.isNullValue() &&
1721 match(And->getOperand(1), m_One()))
Sanjay Patel05aadf82018-10-10 20:47:46 +00001722 return new TruncInst(And->getOperand(0), Cmp.getType());
1723
Sanjay Patel6b490972016-09-04 14:32:15 +00001724 const APInt *C2;
Huihui Zhang670778c2019-06-19 17:31:39 +00001725 Value *X;
1726 if (!match(And, m_And(m_Value(X), m_APInt(C2))))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001727 return nullptr;
1728
Huihui Zhang670778c2019-06-19 17:31:39 +00001729 // Don't perform the following transforms if the AND has multiple uses
Craig Topper8bf62212017-09-26 18:47:25 +00001730 if (!And->hasOneUse())
Sanjay Patel14e0e182016-08-26 18:28:46 +00001731 return nullptr;
1732
Huihui Zhang670778c2019-06-19 17:31:39 +00001733 if (Cmp.isEquality() && C1.isNullValue()) {
1734 // Restrict this fold to single-use 'and' (PR10267).
1735 // Replace (and X, (1 << size(X)-1) != 0) with X s< 0
1736 if (C2->isSignMask()) {
1737 Constant *Zero = Constant::getNullValue(X->getType());
1738 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE;
1739 return new ICmpInst(NewPred, X, Zero);
1740 }
Huihui Zhang46266132019-06-25 00:09:10 +00001741
1742 // Restrict this fold only for single-use 'and' (PR10267).
1743 // ((%x & C) == 0) --> %x u< (-C) iff (-C) is power of two.
1744 if ((~(*C2) + 1).isPowerOf2()) {
1745 Constant *NegBOC =
1746 ConstantExpr::getNeg(cast<Constant>(And->getOperand(1)));
1747 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
1748 return new ICmpInst(NewPred, X, NegBOC);
1749 }
Huihui Zhang670778c2019-06-19 17:31:39 +00001750 }
1751
Sanjay Patel6b490972016-09-04 14:32:15 +00001752 // If the LHS is an 'and' of a truncate and we can widen the and/compare to
1753 // the input width without changing the value produced, eliminate the cast:
1754 //
1755 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1'
1756 //
1757 // We can do this transformation if the constants do not have their sign bits
1758 // set or if it is an equality comparison. Extending a relational comparison
1759 // when we're checking the sign bit would not work.
1760 Value *W;
Craig Topper8bf62212017-09-26 18:47:25 +00001761 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00001762 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) {
Sanjay Patel6b490972016-09-04 14:32:15 +00001763 // TODO: Is this a good transform for vectors? Wider types may reduce
1764 // throughput. Should this transform be limited (even for scalars) by using
Sanjay Patel2217f752017-01-31 17:25:42 +00001765 // shouldChangeType()?
Sanjay Patel6b490972016-09-04 14:32:15 +00001766 if (!Cmp.getType()->isVectorTy()) {
1767 Type *WideType = W->getType();
1768 unsigned WideScalarBits = WideType->getScalarSizeInBits();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001769 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits));
Sanjay Patel6b490972016-09-04 14:32:15 +00001770 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits));
Craig Topperbb4069e2017-07-07 23:16:26 +00001771 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName());
Sanjay Patel6b490972016-09-04 14:32:15 +00001772 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1);
Sanjay Patel14e0e182016-08-26 18:28:46 +00001773 }
1774 }
1775
Craig Topper8ed1aa92017-10-03 05:31:07 +00001776 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2))
Sanjay Patel14e0e182016-08-26 18:28:46 +00001777 return I;
1778
Sanjay Patelda9c5622016-08-26 17:15:22 +00001779 // (icmp pred (and (or (lshr A, B), A), 1), 0) -->
Sanjay Patel6b490972016-09-04 14:32:15 +00001780 // (icmp pred (and A, (or (shl 1, B), 1), 0))
Sanjay Patelda9c5622016-08-26 17:15:22 +00001781 //
1782 // iff pred isn't signed
Craig Topper8ed1aa92017-10-03 05:31:07 +00001783 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() &&
Craig Topper73ba1c82017-06-07 07:40:37 +00001784 match(And->getOperand(1), m_One())) {
Sanjay Pateldef931e2016-09-07 20:50:44 +00001785 Constant *One = cast<Constant>(And->getOperand(1));
1786 Value *Or = And->getOperand(0);
Sanjay Patelda9c5622016-08-26 17:15:22 +00001787 Value *A, *B, *LShr;
Sanjay Pateldef931e2016-09-07 20:50:44 +00001788 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) &&
1789 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) {
1790 unsigned UsesRemoved = 0;
1791 if (And->hasOneUse())
1792 ++UsesRemoved;
1793 if (Or->hasOneUse())
1794 ++UsesRemoved;
1795 if (LShr->hasOneUse())
1796 ++UsesRemoved;
1797
1798 // Compute A & ((1 << B) | 1)
1799 Value *NewOr = nullptr;
1800 if (auto *C = dyn_cast<Constant>(B)) {
1801 if (UsesRemoved >= 1)
1802 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One);
1803 } else {
1804 if (UsesRemoved >= 3)
Craig Topperbb4069e2017-07-07 23:16:26 +00001805 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(),
1806 /*HasNUW=*/true),
1807 One, Or->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001808 }
1809 if (NewOr) {
Craig Topperbb4069e2017-07-07 23:16:26 +00001810 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName());
Sanjay Pateldef931e2016-09-07 20:50:44 +00001811 Cmp.setOperand(0, NewAnd);
1812 return &Cmp;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001813 }
1814 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001815 }
Sanjay Patelda9c5622016-08-26 17:15:22 +00001816
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001817 return nullptr;
1818}
1819
1820/// Fold icmp (and X, Y), C.
1821Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp,
1822 BinaryOperator *And,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001823 const APInt &C) {
Sanjay Pateld3c7bb282016-08-26 16:42:33 +00001824 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C))
1825 return I;
1826
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001827 // TODO: These all require that Y is constant too, so refactor with the above.
Sanjay Patela3f4f082016-08-16 17:54:36 +00001828
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001829 // Try to optimize things like "A[i] & 42 == 0" to index computations.
1830 Value *X = And->getOperand(0);
1831 Value *Y = And->getOperand(1);
1832 if (auto *LI = dyn_cast<LoadInst>(X))
1833 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0)))
1834 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001835 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001836 !LI->isVolatile() && isa<ConstantInt>(Y)) {
1837 ConstantInt *C2 = cast<ConstantInt>(Y);
1838 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001839 return Res;
1840 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001841
1842 if (!Cmp.isEquality())
1843 return nullptr;
Sanjay Patela3f4f082016-08-16 17:54:36 +00001844
1845 // X & -C == -C -> X > u ~C
1846 // X & -C != -C -> X <= u ~C
1847 // iff C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00001848 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001849 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT
1850 : CmpInst::ICMP_ULE;
1851 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1))));
1852 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001853
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001854 // (X & C2) == 0 -> (trunc X) >= 0
1855 // (X & C2) != 0 -> (trunc X) < 0
1856 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type.
1857 const APInt *C2;
Craig Topper8ed1aa92017-10-03 05:31:07 +00001858 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) {
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001859 int32_t ExactLogBase2 = C2->exactLogBase2();
1860 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) {
1861 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1);
1862 if (And->getType()->isVectorTy())
1863 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements());
Craig Topperbb4069e2017-07-07 23:16:26 +00001864 Value *Trunc = Builder.CreateTrunc(X, NTy);
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001865 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE
1866 : CmpInst::ICMP_SLT;
1867 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy));
Sanjay Patela3f4f082016-08-16 17:54:36 +00001868 }
1869 }
Sanjay Patel5c5311f2016-08-28 18:18:00 +00001870
Sanjay Patela3f4f082016-08-16 17:54:36 +00001871 return nullptr;
1872}
1873
Sanjay Patel943e92e2016-08-17 16:30:43 +00001874/// Fold icmp (or X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001875Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001876 const APInt &C) {
Sanjay Patel943e92e2016-08-17 16:30:43 +00001877 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001878 if (C.isOneValue()) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001879 // icmp slt signum(V) 1 --> icmp slt V, 1
1880 Value *V = nullptr;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001881 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V))))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001882 return new ICmpInst(ICmpInst::ICMP_SLT, V,
1883 ConstantInt::get(V->getType(), 1));
1884 }
1885
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001886 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1);
1887 if (Cmp.isEquality() && Cmp.getOperand(1) == OrOp1) {
1888 // X | C == C --> X <=u C
1889 // X | C != C --> X >u C
1890 // iff C+1 is a power of 2 (C is a bitmask of the low bits)
1891 if ((C + 1).isPowerOf2()) {
1892 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT;
1893 return new ICmpInst(Pred, OrOp0, OrOp1);
1894 }
1895 // More general: are all bits outside of a mask constant set or not set?
1896 // X | C == C --> (X & ~C) == 0
1897 // X | C != C --> (X & ~C) != 0
1898 if (Or->hasOneUse()) {
1899 Value *A = Builder.CreateAnd(OrOp0, ~C);
1900 return new ICmpInst(Pred, A, ConstantInt::getNullValue(OrOp0->getType()));
1901 }
Sanjay Patel50c82c42017-04-05 17:57:05 +00001902 }
1903
Craig Topper8ed1aa92017-10-03 05:31:07 +00001904 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00001905 return nullptr;
1906
1907 Value *P, *Q;
Sanjay Patel943e92e2016-08-17 16:30:43 +00001908 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) {
Sanjay Patela3f4f082016-08-16 17:54:36 +00001909 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0
1910 // -> and (icmp eq P, null), (icmp eq Q, null).
Reid Klecknera871d382016-08-19 16:53:18 +00001911 Value *CmpP =
Craig Topperbb4069e2017-07-07 23:16:26 +00001912 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType()));
Reid Klecknera871d382016-08-19 16:53:18 +00001913 Value *CmpQ =
Craig Topperbb4069e2017-07-07 23:16:26 +00001914 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType()));
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001915 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1916 return BinaryOperator::Create(BOpc, CmpP, CmpQ);
1917 }
1918
1919 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to
1920 // a shorter form that has more potential to be folded even further.
1921 Value *X1, *X2, *X3, *X4;
Sanjay Patel68bc5fb2019-02-06 16:43:54 +00001922 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) &&
1923 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) {
Sanjay Patel3f4db3e2017-07-14 15:09:49 +00001924 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4)
1925 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4)
1926 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2);
1927 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4);
1928 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or;
1929 return BinaryOperator::Create(BOpc, Cmp12, Cmp34);
Sanjay Patela3f4f082016-08-16 17:54:36 +00001930 }
Sanjay Patel943e92e2016-08-17 16:30:43 +00001931
Sanjay Patela3f4f082016-08-16 17:54:36 +00001932 return nullptr;
1933}
1934
Sanjay Patel63478072016-08-18 15:44:44 +00001935/// Fold icmp (mul X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00001936Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp,
1937 BinaryOperator *Mul,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001938 const APInt &C) {
Sanjay Patel63478072016-08-18 15:44:44 +00001939 const APInt *MulC;
1940 if (!match(Mul->getOperand(1), m_APInt(MulC)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00001941 return nullptr;
1942
Sanjay Patel63478072016-08-18 15:44:44 +00001943 // If this is a test of the sign bit and the multiply is sign-preserving with
1944 // a constant operand, use the multiply LHS operand instead.
1945 ICmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001946 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) {
Sanjay Patel63478072016-08-18 15:44:44 +00001947 if (MulC->isNegative())
1948 Pred = ICmpInst::getSwappedPredicate(Pred);
1949 return new ICmpInst(Pred, Mul->getOperand(0),
1950 Constant::getNullValue(Mul->getType()));
1951 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00001952
1953 return nullptr;
1954}
1955
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001956/// Fold icmp (shl 1, Y), C.
1957static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00001958 const APInt &C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001959 Value *Y;
1960 if (!match(Shl, m_Shl(m_One(), m_Value(Y))))
1961 return nullptr;
1962
1963 Type *ShiftType = Shl->getType();
Craig Topper8ed1aa92017-10-03 05:31:07 +00001964 unsigned TypeBits = C.getBitWidth();
1965 bool CIsPowerOf2 = C.isPowerOf2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001966 ICmpInst::Predicate Pred = Cmp.getPredicate();
1967 if (Cmp.isUnsigned()) {
1968 // (1 << Y) pred C -> Y pred Log2(C)
1969 if (!CIsPowerOf2) {
1970 // (1 << Y) < 30 -> Y <= 4
1971 // (1 << Y) <= 30 -> Y <= 4
1972 // (1 << Y) >= 30 -> Y > 4
1973 // (1 << Y) > 30 -> Y > 4
1974 if (Pred == ICmpInst::ICMP_ULT)
1975 Pred = ICmpInst::ICMP_ULE;
1976 else if (Pred == ICmpInst::ICMP_UGE)
1977 Pred = ICmpInst::ICMP_UGT;
1978 }
1979
1980 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31
1981 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31
Craig Topper8ed1aa92017-10-03 05:31:07 +00001982 unsigned CLog2 = C.logBase2();
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001983 if (CLog2 == TypeBits - 1) {
1984 if (Pred == ICmpInst::ICMP_UGE)
1985 Pred = ICmpInst::ICMP_EQ;
1986 else if (Pred == ICmpInst::ICMP_ULT)
1987 Pred = ICmpInst::ICMP_NE;
1988 }
1989 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2));
1990 } else if (Cmp.isSigned()) {
1991 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00001992 if (C.isAllOnesValue()) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00001993 // (1 << Y) <= -1 -> Y == 31
1994 if (Pred == ICmpInst::ICMP_SLE)
1995 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
1996
1997 // (1 << Y) > -1 -> Y != 31
1998 if (Pred == ICmpInst::ICMP_SGT)
1999 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002000 } else if (!C) {
Sanjay Patel98cd99d2016-08-18 21:28:30 +00002001 // (1 << Y) < 0 -> Y == 31
2002 // (1 << Y) <= 0 -> Y == 31
2003 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE)
2004 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne);
2005
2006 // (1 << Y) >= 0 -> Y != 31
2007 // (1 << Y) > 0 -> Y != 31
2008 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE)
2009 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne);
2010 }
2011 } else if (Cmp.isEquality() && CIsPowerOf2) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002012 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2()));
Sanjay Patel98cd99d2016-08-18 21:28:30 +00002013 }
2014
2015 return nullptr;
2016}
2017
Sanjay Patel38b75062016-08-19 17:20:37 +00002018/// Fold icmp (shl X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002019Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp,
2020 BinaryOperator *Shl,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002021 const APInt &C) {
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002022 const APInt *ShiftVal;
2023 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002024 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002025
Sanjay Patelfa7de602016-08-19 22:33:26 +00002026 const APInt *ShiftAmt;
2027 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patel38b75062016-08-19 17:20:37 +00002028 return foldICmpShlOne(Cmp, Shl, C);
Sanjay Patela867afe2016-08-19 16:12:16 +00002029
Sanjay Patel38b75062016-08-19 17:20:37 +00002030 // Check that the shift amount is in range. If not, don't perform undefined
Sanjay Patel940c0612017-01-09 16:27:56 +00002031 // shifts. When the shift is visited, it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002032 unsigned TypeBits = C.getBitWidth();
Sanjay Patelfa7de602016-08-19 22:33:26 +00002033 if (ShiftAmt->uge(TypeBits))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002034 return nullptr;
2035
Sanjay Patele38e79c2016-08-19 17:34:05 +00002036 ICmpInst::Predicate Pred = Cmp.getPredicate();
2037 Value *X = Shl->getOperand(0);
Sanjay Patel14715b32017-01-17 21:25:16 +00002038 Type *ShType = Shl->getType();
2039
Sanjay Patel291c3d82017-01-19 16:12:10 +00002040 // NSW guarantees that we are only shifting out sign bits from the high bits,
2041 // so we can ASHR the compare constant without needing a mask and eliminate
2042 // the shift.
2043 if (Shl->hasNoSignedWrap()) {
2044 if (Pred == ICmpInst::ICMP_SGT) {
2045 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002046 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00002047 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2048 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00002049 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
2050 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002051 APInt ShiftedC = C.ashr(*ShiftAmt);
Sanjay Patel291c3d82017-01-19 16:12:10 +00002052 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2053 }
2054 if (Pred == ICmpInst::ICMP_SLT) {
2055 // SLE is the same as above, but SLE is canonicalized to SLT, so convert:
2056 // (X << S) <=s C is equiv to X <=s (C >> S) for all C
2057 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX
2058 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN
Craig Topper8ed1aa92017-10-03 05:31:07 +00002059 assert(!C.isMinSignedValue() && "Unexpected icmp slt");
2060 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1;
Sanjay Patel291c3d82017-01-19 16:12:10 +00002061 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2062 }
2063 // If this is a signed comparison to 0 and the shift is sign preserving,
2064 // use the shift LHS operand instead; isSignTest may change 'Pred', so only
2065 // do that if we're sure to not continue on in this function.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002066 if (isSignTest(Pred, C))
Sanjay Patel291c3d82017-01-19 16:12:10 +00002067 return new ICmpInst(Pred, X, Constant::getNullValue(ShType));
2068 }
Sanjay Patel14715b32017-01-17 21:25:16 +00002069
Sanjay Patel291c3d82017-01-19 16:12:10 +00002070 // NUW guarantees that we are only shifting out zero bits from the high bits,
2071 // so we can LSHR the compare constant without needing a mask and eliminate
2072 // the shift.
Sanjay Patel14715b32017-01-17 21:25:16 +00002073 if (Shl->hasNoUnsignedWrap()) {
Sanjay Patelae23d652017-01-18 21:16:12 +00002074 if (Pred == ICmpInst::ICMP_UGT) {
Sanjay Patel14715b32017-01-17 21:25:16 +00002075 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002076 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002077 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2078 }
Sanjay Patel6fb13572018-01-09 18:56:03 +00002079 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) &&
2080 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002081 APInt ShiftedC = C.lshr(*ShiftAmt);
Sanjay Patelae23d652017-01-18 21:16:12 +00002082 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2083 }
Sanjay Patel14715b32017-01-17 21:25:16 +00002084 if (Pred == ICmpInst::ICMP_ULT) {
2085 // ULE is the same as above, but ULE is canonicalized to ULT, so convert:
2086 // (X << S) <=u C is equiv to X <=u (C >> S) for all C
2087 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u
2088 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0
Craig Topper8ed1aa92017-10-03 05:31:07 +00002089 assert(C.ugt(0) && "ult 0 should have been eliminated");
2090 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1;
Sanjay Patel14715b32017-01-17 21:25:16 +00002091 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC));
2092 }
2093 }
2094
Sanjay Patel291c3d82017-01-19 16:12:10 +00002095 if (Cmp.isEquality() && Shl->hasOneUse()) {
2096 // Strength-reduce the shift into an 'and'.
2097 Constant *Mask = ConstantInt::get(
2098 ShType,
2099 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue()));
Craig Topperbb4069e2017-07-07 23:16:26 +00002100 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Craig Topper8ed1aa92017-10-03 05:31:07 +00002101 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt));
Sanjay Patel291c3d82017-01-19 16:12:10 +00002102 return new ICmpInst(Pred, And, LShrC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002103 }
2104
Sanjay Patela3f4f082016-08-16 17:54:36 +00002105 // Otherwise, if this is a comparison of the sign bit, simplify to and/test.
2106 bool TrueIfSigned = false;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002107 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) {
Sanjay Patel7ffcde72016-08-21 16:35:34 +00002108 // (X << 31) <s 0 --> (X & 1) != 0
Sanjay Patela3f4f082016-08-16 17:54:36 +00002109 Constant *Mask = ConstantInt::get(
Sanjay Patel14715b32017-01-17 21:25:16 +00002110 ShType,
Sanjay Patelfa7de602016-08-19 22:33:26 +00002111 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002112 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask");
Sanjay Patela3f4f082016-08-16 17:54:36 +00002113 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ,
Sanjay Patel14715b32017-01-17 21:25:16 +00002114 And, Constant::getNullValue(ShType));
Sanjay Patelc0339c72016-11-01 19:19:29 +00002115 }
2116
Huihui Zhangb90cb572019-06-25 20:44:52 +00002117 // Simplify 'shl' inequality test into 'and' equality test.
2118 if (Cmp.isUnsigned() && Shl->hasOneUse()) {
2119 // (X l<< C2) u<=/u> C1 iff C1+1 is power of two -> X & (~C1 l>> C2) ==/!= 0
2120 if ((C + 1).isPowerOf2() &&
2121 (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT)) {
2122 Value *And = Builder.CreateAnd(X, (~C).lshr(ShiftAmt->getZExtValue()));
2123 return new ICmpInst(Pred == ICmpInst::ICMP_ULE ? ICmpInst::ICMP_EQ
2124 : ICmpInst::ICMP_NE,
2125 And, Constant::getNullValue(ShType));
2126 }
2127 // (X l<< C2) u</u>= C1 iff C1 is power of two -> X & (-C1 l>> C2) ==/!= 0
2128 if (C.isPowerOf2() &&
2129 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) {
2130 Value *And =
2131 Builder.CreateAnd(X, (~(C - 1)).lshr(ShiftAmt->getZExtValue()));
2132 return new ICmpInst(Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_EQ
2133 : ICmpInst::ICMP_NE,
2134 And, Constant::getNullValue(ShType));
2135 }
2136 }
2137
Sanjay Patel643d21a2016-08-21 17:10:07 +00002138 // Transform (icmp pred iM (shl iM %v, N), C)
2139 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N))
2140 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N.
Sanjay Patel940c0612017-01-09 16:27:56 +00002141 // This enables us to get rid of the shift in favor of a trunc that may be
Sanjay Patela3f4f082016-08-16 17:54:36 +00002142 // free on the target. It has the additional benefit of comparing to a
Sanjay Patel940c0612017-01-09 16:27:56 +00002143 // smaller constant that may be more target-friendly.
Sanjay Patelfa7de602016-08-19 22:33:26 +00002144 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002145 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt &&
Sanjay Patelf3dda132016-10-25 20:11:47 +00002146 DL.isLegalInteger(TypeBits - Amt)) {
Sanjay Patel643d21a2016-08-21 17:10:07 +00002147 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt);
Sanjay Patel14715b32017-01-17 21:25:16 +00002148 if (ShType->isVectorTy())
2149 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements());
Sanjay Patel643d21a2016-08-21 17:10:07 +00002150 Constant *NewC =
Craig Topper8ed1aa92017-10-03 05:31:07 +00002151 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt));
Craig Topperbb4069e2017-07-07 23:16:26 +00002152 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002153 }
2154
2155 return nullptr;
2156}
2157
Sanjay Patela3920492016-08-22 20:45:06 +00002158/// Fold icmp ({al}shr X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002159Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp,
2160 BinaryOperator *Shr,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002161 const APInt &C) {
Sanjay Patela3920492016-08-22 20:45:06 +00002162 // An exact shr only shifts out zero bits, so:
2163 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0
Sanjay Pateld64e9882016-08-23 22:05:55 +00002164 Value *X = Shr->getOperand(0);
Sanjay Patelc9196c42016-08-22 21:24:29 +00002165 CmpInst::Predicate Pred = Cmp.getPredicate();
Craig Topper73ba1c82017-06-07 07:40:37 +00002166 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() &&
Craig Topper8ed1aa92017-10-03 05:31:07 +00002167 C.isNullValue())
Sanjay Pateld64e9882016-08-23 22:05:55 +00002168 return new ICmpInst(Pred, X, Cmp.getOperand(1));
Sanjay Patela3920492016-08-22 20:45:06 +00002169
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002170 const APInt *ShiftVal;
2171 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal)))
Craig Topper8ed1aa92017-10-03 05:31:07 +00002172 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal);
Sanjay Patel8da42cc2016-09-15 22:26:31 +00002173
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002174 const APInt *ShiftAmt;
2175 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002176 return nullptr;
2177
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002178 // Check that the shift amount is in range. If not, don't perform undefined
2179 // shifts. When the shift is visited it will be simplified.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002180 unsigned TypeBits = C.getBitWidth();
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002181 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits);
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002182 if (ShAmtVal >= TypeBits || ShAmtVal == 0)
2183 return nullptr;
2184
Sanjay Pateld64e9882016-08-23 22:05:55 +00002185 bool IsAShr = Shr->getOpcode() == Instruction::AShr;
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002186 bool IsExact = Shr->isExact();
2187 Type *ShrTy = Shr->getType();
2188 // TODO: If we could guarantee that InstSimplify would handle all of the
2189 // constant-value-based preconditions in the folds below, then we could assert
2190 // those conditions rather than checking them. This is difficult because of
2191 // undef/poison (PR34838).
2192 if (IsAShr) {
2193 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) {
2194 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC)
2195 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC)
2196 APInt ShiftedC = C.shl(ShAmtVal);
2197 if (ShiftedC.ashr(ShAmtVal) == C)
2198 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2199 }
2200 if (Pred == CmpInst::ICMP_SGT) {
2201 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1
2202 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2203 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() &&
2204 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1))
2205 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2206 }
2207 } else {
2208 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) {
2209 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC)
2210 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC)
2211 APInt ShiftedC = C.shl(ShAmtVal);
2212 if (ShiftedC.lshr(ShAmtVal) == C)
2213 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2214 }
2215 if (Pred == CmpInst::ICMP_UGT) {
2216 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1
2217 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1;
2218 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1))
2219 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC));
2220 }
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002221 }
2222
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002223 if (!Cmp.isEquality())
2224 return nullptr;
2225
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002226 // Handle equality comparisons of shift-by-constant.
2227
Sanjay Patel8e297742016-08-24 13:55:55 +00002228 // If the comparison constant changes with the shift, the comparison cannot
2229 // succeed (bits of the comparison constant cannot match the shifted value).
2230 // This should be known by InstSimplify and already be folded to true/false.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002231 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) ||
2232 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) &&
Sanjay Patel8e297742016-08-24 13:55:55 +00002233 "Expected icmp+shr simplify did not occur.");
2234
Sanjay Patel934738a2017-10-15 15:39:15 +00002235 // If the bits shifted out are known zero, compare the unshifted value:
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002236 // (X & 4) >> 1 == 2 --> (X & 4) == 4.
Sanjay Patel934738a2017-10-15 15:39:15 +00002237 if (Shr->isExact())
Sanjay Patel42135be2017-10-16 14:47:24 +00002238 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Patelf11b5b42017-10-05 14:26:15 +00002239
Sanjay Patel934738a2017-10-15 15:39:15 +00002240 if (Shr->hasOneUse()) {
2241 // Canonicalize the shift into an 'and':
2242 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt)
Sanjay Pateld398d4a2016-08-24 22:22:06 +00002243 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal));
Sanjay Patel7ac2db62017-10-05 21:11:49 +00002244 Constant *Mask = ConstantInt::get(ShrTy, Val);
Craig Topperbb4069e2017-07-07 23:16:26 +00002245 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask");
Sanjay Patel42135be2017-10-16 14:47:24 +00002246 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal));
Sanjay Pateldcac0df2016-08-23 21:25:13 +00002247 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002248
2249 return nullptr;
2250}
2251
Sanjay Patel80bea342019-09-11 12:04:26 +00002252Instruction *InstCombiner::foldICmpSRemConstant(ICmpInst &Cmp,
2253 BinaryOperator *SRem,
2254 const APInt &C) {
2255 // Match an 'is positive' or 'is negative' comparison of remainder by a
2256 // constant power-of-2 value:
2257 // (X % pow2C) sgt/slt 0
2258 const ICmpInst::Predicate Pred = Cmp.getPredicate();
2259 if (Pred != ICmpInst::ICMP_SGT && Pred != ICmpInst::ICMP_SLT)
2260 return nullptr;
2261
2262 // TODO: The one-use check is standard because we do not typically want to
2263 // create longer instruction sequences, but this might be a special-case
2264 // because srem is not good for analysis or codegen.
2265 if (!SRem->hasOneUse())
2266 return nullptr;
2267
2268 const APInt *DivisorC;
2269 if (!C.isNullValue() || !match(SRem->getOperand(1), m_Power2(DivisorC)))
2270 return nullptr;
2271
2272 // Mask off the sign bit and the modulo bits (low-bits).
2273 Type *Ty = SRem->getType();
2274 APInt SignMask = APInt::getSignMask(Ty->getScalarSizeInBits());
2275 Constant *MaskC = ConstantInt::get(Ty, SignMask | (*DivisorC - 1));
2276 Value *And = Builder.CreateAnd(SRem->getOperand(0), MaskC);
2277
2278 // For 'is positive?' check that the sign-bit is clear and at least 1 masked
2279 // bit is set. Example:
2280 // (i8 X % 32) s> 0 --> (X & 159) s> 0
2281 if (Pred == ICmpInst::ICMP_SGT)
2282 return new ICmpInst(ICmpInst::ICMP_SGT, And, ConstantInt::getNullValue(Ty));
2283
2284 // For 'is negative?' check that the sign-bit is set and at least 1 masked
2285 // bit is set. Example:
2286 // (i16 X % 4) s< 0 --> (X & 32771) u> 32768
2287 return new ICmpInst(ICmpInst::ICMP_UGT, And, ConstantInt::get(Ty, SignMask));
2288}
2289
Sanjay Patel12a41052016-08-18 17:37:26 +00002290/// Fold icmp (udiv X, Y), C.
2291Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp,
Sanjay Patelc9196c42016-08-22 21:24:29 +00002292 BinaryOperator *UDiv,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002293 const APInt &C) {
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002294 const APInt *C2;
2295 if (!match(UDiv->getOperand(0), m_APInt(C2)))
2296 return nullptr;
2297
Craig Topper29c282e2017-06-07 07:40:29 +00002298 assert(*C2 != 0 && "udiv 0, X should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002299
2300 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1))
2301 Value *Y = UDiv->getOperand(1);
2302 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002303 assert(!C.isMaxValue() &&
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002304 "icmp ugt X, UINT_MAX should have been simplified already.");
2305 return new ICmpInst(ICmpInst::ICMP_ULE, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002306 ConstantInt::get(Y->getType(), C2->udiv(C + 1)));
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002307 }
2308
2309 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C)
2310 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002311 assert(C != 0 && "icmp ult X, 0 should have been simplified already.");
Sanjay Patelfa5ca2b2016-08-18 17:55:59 +00002312 return new ICmpInst(ICmpInst::ICMP_UGT, Y,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002313 ConstantInt::get(Y->getType(), C2->udiv(C)));
Sanjay Patela3f4f082016-08-16 17:54:36 +00002314 }
2315
2316 return nullptr;
2317}
2318
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002319/// Fold icmp ({su}div X, Y), C.
2320Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp,
2321 BinaryOperator *Div,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002322 const APInt &C) {
Sanjay Patela7cb4772016-08-30 17:10:49 +00002323 // Fold: icmp pred ([us]div X, C2), C -> range test
Sanjay Patela3f4f082016-08-16 17:54:36 +00002324 // Fold this div into the comparison, producing a range check.
2325 // Determine, based on the divide type, what the range is being
2326 // checked. If there is an overflow on the low or high side, remember
2327 // it, otherwise compute the range [low, hi) bounding the new value.
2328 // See: InsertRangeTest above for the kinds of replacements possible.
Sanjay Patela7cb4772016-08-30 17:10:49 +00002329 const APInt *C2;
2330 if (!match(Div->getOperand(1), m_APInt(C2)))
Sanjay Patel16554142016-08-24 23:03:36 +00002331 return nullptr;
2332
Sanjay Patel16554142016-08-24 23:03:36 +00002333 // FIXME: If the operand types don't match the type of the divide
2334 // then don't attempt this transform. The code below doesn't have the
2335 // logic to deal with a signed divide and an unsigned compare (and
Sanjay Patela7cb4772016-08-30 17:10:49 +00002336 // vice versa). This is because (x /s C2) <s C produces different
2337 // results than (x /s C2) <u C or (x /u C2) <s C or even
2338 // (x /u C2) <u C. Simply casting the operands and result won't
Sanjay Patel16554142016-08-24 23:03:36 +00002339 // work. :( The if statement below tests that condition and bails
2340 // if it finds it.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002341 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv;
2342 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned())
Sanjay Patel16554142016-08-24 23:03:36 +00002343 return nullptr;
Sanjay Patela7cb4772016-08-30 17:10:49 +00002344
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002345 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with
2346 // INT_MIN will also fail if the divisor is 1. Although folds of all these
2347 // division-by-constant cases should be present, we can not assert that they
2348 // have happened before we reach this icmp instruction.
Craig Topper73ba1c82017-06-07 07:40:37 +00002349 if (C2->isNullValue() || C2->isOneValue() ||
2350 (DivIsSigned && C2->isAllOnesValue()))
Sanjay Pateleea2ef72016-09-05 23:38:22 +00002351 return nullptr;
Sanjay Patelb3714572016-08-30 17:31:34 +00002352
Craig Topper6e025a32017-10-01 23:53:54 +00002353 // Compute Prod = C * C2. We are essentially solving an equation of
2354 // form X / C2 = C. We solve for X by multiplying C2 and C.
Sanjay Patel541aef42016-08-31 21:57:21 +00002355 // By solving for X, we can turn this into a range check instead of computing
2356 // a divide.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002357 APInt Prod = C * *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002358
Sanjay Patel541aef42016-08-31 21:57:21 +00002359 // Determine if the product overflows by seeing if the product is not equal to
2360 // the divide. Make sure we do the same kind of divide as in the LHS
2361 // instruction that we're folding.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002362 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C;
Sanjay Patel16554142016-08-24 23:03:36 +00002363
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002364 ICmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel16554142016-08-24 23:03:36 +00002365
2366 // If the division is known to be exact, then there is no remainder from the
2367 // divide, so the covered range size is unit, otherwise it is the divisor.
Craig Topper6e025a32017-10-01 23:53:54 +00002368 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2;
Sanjay Patel16554142016-08-24 23:03:36 +00002369
2370 // Figure out the interval that is being checked. For example, a comparison
2371 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5).
2372 // Compute this interval based on the constants involved and the signedness of
2373 // the compare/divide. This computes a half-open interval, keeping track of
2374 // whether either value in the interval overflows. After analysis each
2375 // overflow variable is set to 0 if it's corresponding bound variable is valid
2376 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end.
2377 int LoOverflow = 0, HiOverflow = 0;
Craig Topper6e025a32017-10-01 23:53:54 +00002378 APInt LoBound, HiBound;
Sanjay Patel16554142016-08-24 23:03:36 +00002379
2380 if (!DivIsSigned) { // udiv
2381 // e.g. X/5 op 3 --> [15, 20)
2382 LoBound = Prod;
2383 HiOverflow = LoOverflow = ProdOV;
2384 if (!HiOverflow) {
2385 // If this is not an exact divide, then many values in the range collapse
2386 // to the same result value.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002387 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false);
Sanjay Patel16554142016-08-24 23:03:36 +00002388 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002389 } else if (C2->isStrictlyPositive()) { // Divisor is > 0.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002390 if (C.isNullValue()) { // (X / pos) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002391 // Can't overflow. e.g. X/2 op 0 --> [-1, 2)
Craig Topper6e025a32017-10-01 23:53:54 +00002392 LoBound = -(RangeSize - 1);
Sanjay Patel16554142016-08-24 23:03:36 +00002393 HiBound = RangeSize;
Craig Topper8ed1aa92017-10-03 05:31:07 +00002394 } else if (C.isStrictlyPositive()) { // (X / pos) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002395 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20)
2396 HiOverflow = LoOverflow = ProdOV;
2397 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002398 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002399 } else { // (X / pos) op neg
2400 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002401 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002402 LoOverflow = HiOverflow = ProdOV ? -1 : 0;
2403 if (!LoOverflow) {
Craig Topper6e025a32017-10-01 23:53:54 +00002404 APInt DivNeg = -RangeSize;
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002405 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0;
Sanjay Patel16554142016-08-24 23:03:36 +00002406 }
2407 }
Sanjay Patel541aef42016-08-31 21:57:21 +00002408 } else if (C2->isNegative()) { // Divisor is < 0.
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002409 if (Div->isExact())
Craig Topper6e025a32017-10-01 23:53:54 +00002410 RangeSize.negate();
Craig Topper8ed1aa92017-10-03 05:31:07 +00002411 if (C.isNullValue()) { // (X / neg) op 0
Sanjay Patel16554142016-08-24 23:03:36 +00002412 // e.g. X/-5 op 0 --> [-4, 5)
Craig Topper6e025a32017-10-01 23:53:54 +00002413 LoBound = RangeSize + 1;
2414 HiBound = -RangeSize;
2415 if (HiBound == *C2) { // -INTMIN = INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002416 HiOverflow = 1; // [INTMIN+1, overflow)
Craig Topper6e025a32017-10-01 23:53:54 +00002417 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN
Sanjay Patel16554142016-08-24 23:03:36 +00002418 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002419 } else if (C.isStrictlyPositive()) { // (X / neg) op pos
Sanjay Patel16554142016-08-24 23:03:36 +00002420 // e.g. X/-5 op 3 --> [-19, -14)
Craig Topper6e025a32017-10-01 23:53:54 +00002421 HiBound = Prod + 1;
Sanjay Patel16554142016-08-24 23:03:36 +00002422 HiOverflow = LoOverflow = ProdOV ? -1 : 0;
2423 if (!LoOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002424 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0;
Sanjay Patel16554142016-08-24 23:03:36 +00002425 } else { // (X / neg) op neg
2426 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20)
2427 LoOverflow = HiOverflow = ProdOV;
2428 if (!HiOverflow)
Sanjay Pateld93c4c02016-09-15 18:22:25 +00002429 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true);
Sanjay Patel16554142016-08-24 23:03:36 +00002430 }
2431
2432 // Dividing by a negative swaps the condition. LT <-> GT
2433 Pred = ICmpInst::getSwappedPredicate(Pred);
2434 }
2435
Sanjay Patelf7ba0892016-08-26 15:53:01 +00002436 Value *X = Div->getOperand(0);
Sanjay Patel16554142016-08-24 23:03:36 +00002437 switch (Pred) {
2438 default: llvm_unreachable("Unhandled icmp opcode!");
2439 case ICmpInst::ICMP_EQ:
2440 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002441 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002442 if (HiOverflow)
2443 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002444 ICmpInst::ICMP_UGE, X,
2445 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002446 if (LoOverflow)
2447 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002448 ICmpInst::ICMP_ULT, X,
2449 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel85d79742016-08-31 19:49:56 +00002450 return replaceInstUsesWith(
Craig Topper6e025a32017-10-01 23:53:54 +00002451 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true));
Sanjay Patel16554142016-08-24 23:03:36 +00002452 case ICmpInst::ICMP_NE:
2453 if (LoOverflow && HiOverflow)
Craig Topperbb4069e2017-07-07 23:16:26 +00002454 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002455 if (HiOverflow)
2456 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT :
Craig Topper6e025a32017-10-01 23:53:54 +00002457 ICmpInst::ICMP_ULT, X,
2458 ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002459 if (LoOverflow)
2460 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE :
Craig Topper6e025a32017-10-01 23:53:54 +00002461 ICmpInst::ICMP_UGE, X,
2462 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel541aef42016-08-31 21:57:21 +00002463 return replaceInstUsesWith(Cmp,
Craig Topper6e025a32017-10-01 23:53:54 +00002464 insertRangeTest(X, LoBound, HiBound,
Sanjay Patel541aef42016-08-31 21:57:21 +00002465 DivIsSigned, false));
Sanjay Patel16554142016-08-24 23:03:36 +00002466 case ICmpInst::ICMP_ULT:
2467 case ICmpInst::ICMP_SLT:
2468 if (LoOverflow == +1) // Low bound is greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002469 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002470 if (LoOverflow == -1) // Low bound is less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002471 return replaceInstUsesWith(Cmp, Builder.getFalse());
Craig Topper6e025a32017-10-01 23:53:54 +00002472 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002473 case ICmpInst::ICMP_UGT:
2474 case ICmpInst::ICMP_SGT:
2475 if (HiOverflow == +1) // High bound greater than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002476 return replaceInstUsesWith(Cmp, Builder.getFalse());
Sanjay Patel16554142016-08-24 23:03:36 +00002477 if (HiOverflow == -1) // High bound less than input range.
Craig Topperbb4069e2017-07-07 23:16:26 +00002478 return replaceInstUsesWith(Cmp, Builder.getTrue());
Sanjay Patel16554142016-08-24 23:03:36 +00002479 if (Pred == ICmpInst::ICMP_UGT)
Craig Topper6e025a32017-10-01 23:53:54 +00002480 return new ICmpInst(ICmpInst::ICMP_UGE, X,
2481 ConstantInt::get(Div->getType(), HiBound));
2482 return new ICmpInst(ICmpInst::ICMP_SGE, X,
2483 ConstantInt::get(Div->getType(), HiBound));
Sanjay Patel16554142016-08-24 23:03:36 +00002484 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002485
2486 return nullptr;
2487}
2488
Sanjay Patelb9aa67b2016-08-16 21:26:10 +00002489/// Fold icmp (sub X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002490Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp,
2491 BinaryOperator *Sub,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002492 const APInt &C) {
Sanjay Patel886a5422016-09-15 18:05:17 +00002493 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1);
2494 ICmpInst::Predicate Pred = Cmp.getPredicate();
Luqman Aden8911c5b2019-04-04 07:08:30 +00002495 const APInt *C2;
2496 APInt SubResult;
2497
Philip Reames764b0fd2019-08-21 15:51:57 +00002498 // icmp eq/ne (sub C, Y), C -> icmp eq/ne Y, 0
2499 if (match(X, m_APInt(C2)) && *C2 == C && Cmp.isEquality())
2500 return new ICmpInst(Cmp.getPredicate(), Y,
2501 ConstantInt::get(Y->getType(), 0));
2502
Luqman Aden8911c5b2019-04-04 07:08:30 +00002503 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C)
2504 if (match(X, m_APInt(C2)) &&
2505 ((Cmp.isUnsigned() && Sub->hasNoUnsignedWrap()) ||
2506 (Cmp.isSigned() && Sub->hasNoSignedWrap())) &&
2507 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned()))
2508 return new ICmpInst(Cmp.getSwappedPredicate(), Y,
2509 ConstantInt::get(Y->getType(), SubResult));
Sanjay Patel886a5422016-09-15 18:05:17 +00002510
2511 // The following transforms are only worth it if the only user of the subtract
2512 // is the icmp.
2513 if (!Sub->hasOneUse())
Sanjay Patela3f4f082016-08-16 17:54:36 +00002514 return nullptr;
2515
Sanjay Patel886a5422016-09-15 18:05:17 +00002516 if (Sub->hasNoSignedWrap()) {
2517 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002518 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002519 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002520
Sanjay Patel886a5422016-09-15 18:05:17 +00002521 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002522 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002523 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
2524
2525 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002526 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002527 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
2528
2529 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y)
Craig Topper8ed1aa92017-10-03 05:31:07 +00002530 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue())
Sanjay Patel886a5422016-09-15 18:05:17 +00002531 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
2532 }
2533
Sanjay Patel886a5422016-09-15 18:05:17 +00002534 if (!match(X, m_APInt(C2)))
2535 return nullptr;
2536
2537 // C2 - Y <u C -> (Y | (C - 1)) == C2
2538 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002539 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() &&
2540 (*C2 & (C - 1)) == (C - 1))
2541 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X);
Sanjay Patel886a5422016-09-15 18:05:17 +00002542
2543 // C2 - Y >u C -> (Y | C) != C2
2544 // iff C2 & C == C and C + 1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002545 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C)
2546 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X);
Sanjay Patela3f4f082016-08-16 17:54:36 +00002547
2548 return nullptr;
2549}
2550
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002551/// Fold icmp (add X, Y), C.
Sanjay Patelc9196c42016-08-22 21:24:29 +00002552Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp,
2553 BinaryOperator *Add,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002554 const APInt &C) {
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002555 Value *Y = Add->getOperand(1);
2556 const APInt *C2;
2557 if (Cmp.isEquality() || !match(Y, m_APInt(C2)))
Sanjay Patela3f4f082016-08-16 17:54:36 +00002558 return nullptr;
2559
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002560 // Fold icmp pred (add X, C2), C.
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002561 Value *X = Add->getOperand(0);
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002562 Type *Ty = Add->getType();
Sanjay Patel6dd2eae2017-02-08 16:19:36 +00002563 CmpInst::Predicate Pred = Cmp.getPredicate();
Sanjay Patel45b7e692017-02-12 16:40:30 +00002564
Tim Northover12c1f762018-09-10 14:26:44 +00002565 if (!Add->hasOneUse())
2566 return nullptr;
2567
Sanjay Patel45b7e692017-02-12 16:40:30 +00002568 // If the add does not wrap, we can always adjust the compare by subtracting
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002569 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE
2570 // are canonicalized to SGT/SLT/UGT/ULT.
2571 if ((Add->hasNoSignedWrap() &&
2572 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) ||
2573 (Add->hasNoUnsignedWrap() &&
2574 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) {
Sanjay Patel45b7e692017-02-12 16:40:30 +00002575 bool Overflow;
Nicola Zaghen9588ad92018-09-04 10:29:48 +00002576 APInt NewC =
2577 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow);
Sanjay Patel45b7e692017-02-12 16:40:30 +00002578 // If there is overflow, the result must be true or false.
2579 // TODO: Can we assert there is no overflow because InstSimplify always
2580 // handles those cases?
2581 if (!Overflow)
2582 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2)
2583 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC));
2584 }
2585
Craig Topper8ed1aa92017-10-03 05:31:07 +00002586 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2);
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002587 const APInt &Upper = CR.getUpper();
2588 const APInt &Lower = CR.getLower();
2589 if (Cmp.isSigned()) {
Craig Topperbcfd2d12017-04-20 16:56:25 +00002590 if (Lower.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002591 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper));
Craig Topperbcfd2d12017-04-20 16:56:25 +00002592 if (Upper.isSignMask())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002593 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002594 } else {
2595 if (Lower.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002596 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002597 if (Upper.isMinValue())
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002598 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower));
Sanjay Patel60ea1b42016-08-16 22:34:42 +00002599 }
Sanjay Patela3f4f082016-08-16 17:54:36 +00002600
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002601 // X+C <u C2 -> (X & -C2) == C
2602 // iff C & (C2-1) == 0
2603 // C2 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002604 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0)
2605 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002606 ConstantExpr::getNeg(cast<Constant>(Y)));
2607
2608 // X+C >u C2 -> (X & ~C2) != C
2609 // iff C & C2 == 0
2610 // C2+1 is a power of 2
Craig Topper8ed1aa92017-10-03 05:31:07 +00002611 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0)
2612 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C),
Sanjay Patel4f7eb2a2016-08-17 15:24:30 +00002613 ConstantExpr::getNeg(cast<Constant>(Y)));
2614
Sanjay Patela3f4f082016-08-16 17:54:36 +00002615 return nullptr;
2616}
2617
Anna Thomasd67165c2017-06-23 13:41:45 +00002618bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS,
2619 Value *&RHS, ConstantInt *&Less,
2620 ConstantInt *&Equal,
2621 ConstantInt *&Greater) {
2622 // TODO: Generalize this to work with other comparison idioms or ensure
2623 // they get canonicalized into this form.
2624
Roman Lebedevde19f742019-08-24 06:49:36 +00002625 // select i1 (a == b),
2626 // i32 Equal,
2627 // i32 (select i1 (a < b), i32 Less, i32 Greater)
2628 // where Equal, Less and Greater are placeholders for any three constants.
2629 ICmpInst::Predicate PredA;
2630 if (!match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) ||
2631 !ICmpInst::isEquality(PredA))
2632 return false;
2633 Value *EqualVal = SI->getTrueValue();
2634 Value *UnequalVal = SI->getFalseValue();
2635 // We still can get non-canonical predicate here, so canonicalize.
2636 if (PredA == ICmpInst::ICMP_NE)
2637 std::swap(EqualVal, UnequalVal);
2638 if (!match(EqualVal, m_ConstantInt(Equal)))
2639 return false;
2640 ICmpInst::Predicate PredB;
2641 Value *LHS2, *RHS2;
2642 if (!match(UnequalVal, m_Select(m_ICmp(PredB, m_Value(LHS2), m_Value(RHS2)),
2643 m_ConstantInt(Less), m_ConstantInt(Greater))))
2644 return false;
2645 // We can get predicate mismatch here, so canonicalize if possible:
2646 // First, ensure that 'LHS' match.
2647 if (LHS2 != LHS) {
2648 // x sgt y <--> y slt x
2649 std::swap(LHS2, RHS2);
2650 PredB = ICmpInst::getSwappedPredicate(PredB);
Anna Thomasd67165c2017-06-23 13:41:45 +00002651 }
Roman Lebedevde19f742019-08-24 06:49:36 +00002652 if (LHS2 != LHS)
2653 return false;
2654 // We also need to canonicalize 'RHS'.
2655 if (PredB == ICmpInst::ICMP_SGT && isa<Constant>(RHS2)) {
2656 // x sgt C-1 <--> x sge C <--> not(x slt C)
2657 auto FlippedStrictness =
2658 getFlippedStrictnessPredicateAndConstant(PredB, cast<Constant>(RHS2));
2659 if (!FlippedStrictness)
2660 return false;
2661 assert(FlippedStrictness->first == ICmpInst::ICMP_SGE && "Sanity check");
2662 RHS2 = FlippedStrictness->second;
2663 // And kind-of perform the result swap.
2664 std::swap(Less, Greater);
2665 PredB = ICmpInst::ICMP_SLT;
2666 }
2667 return PredB == ICmpInst::ICMP_SLT && RHS == RHS2;
Anna Thomasd67165c2017-06-23 13:41:45 +00002668}
2669
2670Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp,
Craig Topper524c44f2017-08-23 05:46:07 +00002671 SelectInst *Select,
Anna Thomasd67165c2017-06-23 13:41:45 +00002672 ConstantInt *C) {
2673
2674 assert(C && "Cmp RHS should be a constant int!");
2675 // If we're testing a constant value against the result of a three way
2676 // comparison, the result can be expressed directly in terms of the
2677 // original values being compared. Note: We could possibly be more
2678 // aggressive here and remove the hasOneUse test. The original select is
2679 // really likely to simplify or sink when we remove a test of the result.
2680 Value *OrigLHS, *OrigRHS;
2681 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan;
2682 if (Cmp.hasOneUse() &&
Craig Topper524c44f2017-08-23 05:46:07 +00002683 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal,
2684 C3GreaterThan)) {
Anna Thomasd67165c2017-06-23 13:41:45 +00002685 assert(C1LessThan && C2Equal && C3GreaterThan);
2686
2687 bool TrueWhenLessThan =
2688 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C)
2689 ->isAllOnesValue();
2690 bool TrueWhenEqual =
2691 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C)
2692 ->isAllOnesValue();
2693 bool TrueWhenGreaterThan =
2694 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C)
2695 ->isAllOnesValue();
2696
2697 // This generates the new instruction that will replace the original Cmp
2698 // Instruction. Instead of enumerating the various combinations when
2699 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus
2700 // false, we rely on chaining of ORs and future passes of InstCombine to
2701 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b).
2702
2703 // When none of the three constants satisfy the predicate for the RHS (C),
2704 // the entire original Cmp can be simplified to a false.
Craig Topperbb4069e2017-07-07 23:16:26 +00002705 Value *Cond = Builder.getFalse();
Anna Thomasd67165c2017-06-23 13:41:45 +00002706 if (TrueWhenLessThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002707 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT,
2708 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002709 if (TrueWhenEqual)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002710 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ,
2711 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002712 if (TrueWhenGreaterThan)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002713 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT,
2714 OrigLHS, OrigRHS));
Anna Thomasd67165c2017-06-23 13:41:45 +00002715
2716 return replaceInstUsesWith(Cmp, Cond);
2717 }
2718 return nullptr;
2719}
2720
Sanjay Patele7f46c32019-02-07 20:54:09 +00002721static Instruction *foldICmpBitCast(ICmpInst &Cmp,
2722 InstCombiner::BuilderTy &Builder) {
2723 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0));
2724 if (!Bitcast)
2725 return nullptr;
2726
Sanjay Patele7f46c32019-02-07 20:54:09 +00002727 ICmpInst::Predicate Pred = Cmp.getPredicate();
2728 Value *Op1 = Cmp.getOperand(1);
2729 Value *BCSrcOp = Bitcast->getOperand(0);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002730
Sanjay Patel781d8832019-02-07 21:12:01 +00002731 // Make sure the bitcast doesn't change the number of vector elements.
2732 if (Bitcast->getSrcTy()->getScalarSizeInBits() ==
2733 Bitcast->getDestTy()->getScalarSizeInBits()) {
2734 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast.
2735 Value *X;
2736 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) {
2737 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0
2738 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0
2739 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0
2740 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0
2741 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT ||
2742 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) &&
2743 match(Op1, m_Zero()))
2744 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002745
Sanjay Patel781d8832019-02-07 21:12:01 +00002746 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1
2747 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One()))
2748 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1));
2749
2750 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1
2751 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes()))
2752 return new ICmpInst(Pred, X,
2753 ConstantInt::getAllOnesValue(X->getType()));
2754 }
2755
2756 // Zero-equality checks are preserved through unsigned floating-point casts:
2757 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0
2758 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0
2759 if (match(BCSrcOp, m_UIToFP(m_Value(X))))
2760 if (Cmp.isEquality() && match(Op1, m_Zero()))
2761 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType()));
Sanjay Patele7f46c32019-02-07 20:54:09 +00002762 }
2763
Sanjay Patele7f46c32019-02-07 20:54:09 +00002764 // Test to see if the operands of the icmp are casted versions of other
2765 // values. If the ptr->ptr cast can be stripped off both arguments, do so.
2766 if (Bitcast->getType()->isPointerTy() &&
2767 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) {
2768 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast
2769 // so eliminate it as well.
2770 if (auto *BC2 = dyn_cast<BitCastInst>(Op1))
2771 Op1 = BC2->getOperand(0);
2772
2773 Op1 = Builder.CreateBitCast(Op1, BCSrcOp->getType());
2774 return new ICmpInst(Pred, BCSrcOp, Op1);
2775 }
2776
Daniel Neilson901acfa2018-04-03 17:26:20 +00002777 // Folding: icmp <pred> iN X, C
2778 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN
2779 // and C is a splat of a K-bit pattern
2780 // and SC is a constant vector = <C', C', C', ..., C'>
2781 // Into:
2782 // %E = extractelement <M x iK> %vec, i32 C'
2783 // icmp <pred> iK %E, trunc(C)
Sanjay Patele7f46c32019-02-07 20:54:09 +00002784 const APInt *C;
2785 if (!match(Cmp.getOperand(1), m_APInt(C)) ||
2786 !Bitcast->getType()->isIntegerTy() ||
Daniel Neilson901acfa2018-04-03 17:26:20 +00002787 !Bitcast->getSrcTy()->isIntOrIntVectorTy())
2788 return nullptr;
2789
Sanjay Patele7f46c32019-02-07 20:54:09 +00002790 Value *Vec;
2791 Constant *Mask;
2792 if (match(BCSrcOp,
Daniel Neilson901acfa2018-04-03 17:26:20 +00002793 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) {
2794 // Check whether every element of Mask is the same constant
2795 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) {
Sanjay Patele7f46c32019-02-07 20:54:09 +00002796 auto *VecTy = cast<VectorType>(BCSrcOp->getType());
Daniel Neilson901acfa2018-04-03 17:26:20 +00002797 auto *EltTy = cast<IntegerType>(VecTy->getElementType());
Sanjay Patele7f46c32019-02-07 20:54:09 +00002798 if (C->isSplat(EltTy->getBitWidth())) {
Daniel Neilson901acfa2018-04-03 17:26:20 +00002799 // Fold the icmp based on the value of C
2800 // If C is M copies of an iK sized bit pattern,
2801 // then:
2802 // => %E = extractelement <N x iK> %vec, i32 Elem
2803 // icmp <pred> iK %SplatVal, <pattern>
2804 Value *Extract = Builder.CreateExtractElement(Vec, Elem);
Sanjay Patele7f46c32019-02-07 20:54:09 +00002805 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth()));
Daniel Neilson901acfa2018-04-03 17:26:20 +00002806 return new ICmpInst(Pred, Extract, NewC);
2807 }
2808 }
2809 }
2810 return nullptr;
2811}
2812
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002813/// Try to fold integer comparisons with a constant operand: icmp Pred X, C
2814/// where X is some kind of instruction.
2815Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002816 const APInt *C;
2817 if (!match(Cmp.getOperand(1), m_APInt(C)))
Sanjay Patel1e5b2d12016-08-16 16:08:11 +00002818 return nullptr;
2819
Craig Toppera94069f2017-08-23 05:46:08 +00002820 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) {
Sanjay Patelc9196c42016-08-22 21:24:29 +00002821 switch (BO->getOpcode()) {
2822 case Instruction::Xor:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002823 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002824 return I;
2825 break;
2826 case Instruction::And:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002827 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002828 return I;
2829 break;
2830 case Instruction::Or:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002831 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002832 return I;
2833 break;
2834 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002835 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002836 return I;
2837 break;
2838 case Instruction::Shl:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002839 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002840 return I;
2841 break;
2842 case Instruction::LShr:
2843 case Instruction::AShr:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002844 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002845 return I;
2846 break;
Sanjay Patel80bea342019-09-11 12:04:26 +00002847 case Instruction::SRem:
2848 if (Instruction *I = foldICmpSRemConstant(Cmp, BO, *C))
2849 return I;
2850 break;
Sanjay Patelc9196c42016-08-22 21:24:29 +00002851 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002852 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002853 return I;
2854 LLVM_FALLTHROUGH;
2855 case Instruction::SDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002856 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002857 return I;
2858 break;
2859 case Instruction::Sub:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002860 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002861 return I;
2862 break;
2863 case Instruction::Add:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002864 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C))
Sanjay Patelc9196c42016-08-22 21:24:29 +00002865 return I;
2866 break;
2867 default:
2868 break;
2869 }
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002870 // TODO: These folds could be refactored to be part of the above calls.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002871 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C))
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002872 return I;
Chris Lattner2188e402010-01-04 07:37:31 +00002873 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00002874
Anna Thomasd67165c2017-06-23 13:41:45 +00002875 // Match against CmpInst LHS being instructions other than binary operators.
Craig Topper524c44f2017-08-23 05:46:07 +00002876
2877 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) {
2878 // For now, we only support constant integers while folding the
2879 // ICMP(SELECT)) pattern. We can extend this to support vector of integers
2880 // similar to the cases handled by binary ops above.
2881 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1)))
2882 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS))
Anna Thomasd67165c2017-06-23 13:41:45 +00002883 return I;
Craig Topper524c44f2017-08-23 05:46:07 +00002884 }
2885
2886 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) {
Craig Topper8ed1aa92017-10-03 05:31:07 +00002887 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C))
Craig Topper524c44f2017-08-23 05:46:07 +00002888 return I;
Anna Thomasd67165c2017-06-23 13:41:45 +00002889 }
Sanjay Patelc9196c42016-08-22 21:24:29 +00002890
Nikita Popov6515db22019-01-19 09:56:01 +00002891 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0)))
2892 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C))
2893 return I;
Sanjay Patelf58f68c2016-09-10 15:03:44 +00002894
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002895 return nullptr;
2896}
Jim Grosbach129c52a2011-09-30 18:09:53 +00002897
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002898/// Fold an icmp equality instruction with binary operator LHS and constant RHS:
2899/// icmp eq/ne BO, C.
2900Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp,
2901 BinaryOperator *BO,
Craig Topper8ed1aa92017-10-03 05:31:07 +00002902 const APInt &C) {
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002903 // TODO: Some of these folds could work with arbitrary constants, but this
2904 // function is limited to scalar and vector splat constants.
2905 if (!Cmp.isEquality())
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002906 return nullptr;
2907
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002908 ICmpInst::Predicate Pred = Cmp.getPredicate();
2909 bool isICMP_NE = Pred == ICmpInst::ICMP_NE;
2910 Constant *RHS = cast<Constant>(Cmp.getOperand(1));
Sanjay Patel51a767c2016-08-03 17:23:08 +00002911 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1);
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002912
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002913 switch (BO->getOpcode()) {
2914 case Instruction::SRem:
2915 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one.
Craig Topper8ed1aa92017-10-03 05:31:07 +00002916 if (C.isNullValue() && BO->hasOneUse()) {
Sanjay Patel2e9675f2016-08-03 19:48:40 +00002917 const APInt *BOC;
2918 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002919 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName());
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002920 return new ICmpInst(Pred, NewRem,
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002921 Constant::getNullValue(BO->getType()));
Chris Lattner2188e402010-01-04 07:37:31 +00002922 }
Sanjay Patel1710e7c2016-07-21 17:15:49 +00002923 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002924 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002925 case Instruction::Add: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002926 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants.
Sanjay Patel00a324e2016-08-03 22:08:44 +00002927 const APInt *BOC;
2928 if (match(BOp1, m_APInt(BOC))) {
2929 if (BO->hasOneUse()) {
2930 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002931 return new ICmpInst(Pred, BOp0, SubC);
Sanjay Patel00a324e2016-08-03 22:08:44 +00002932 }
Craig Topper8ed1aa92017-10-03 05:31:07 +00002933 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002934 // Replace ((add A, B) != 0) with (A != -B) if A or B is
2935 // efficiently invertible, or if the add has just this one use.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002936 if (Value *NegVal = dyn_castNegVal(BOp1))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002937 return new ICmpInst(Pred, BOp0, NegVal);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002938 if (Value *NegVal = dyn_castNegVal(BOp0))
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002939 return new ICmpInst(Pred, NegVal, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002940 if (BO->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00002941 Value *Neg = Builder.CreateNeg(BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002942 Neg->takeName(BO);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002943 return new ICmpInst(Pred, BOp0, Neg);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002944 }
2945 }
2946 break;
Sanjay Patel00a324e2016-08-03 22:08:44 +00002947 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002948 case Instruction::Xor:
2949 if (BO->hasOneUse()) {
Sanjay Patel51a767c2016-08-03 17:23:08 +00002950 if (Constant *BOC = dyn_cast<Constant>(BOp1)) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002951 // For the xor case, we can xor two constants together, eliminating
2952 // the explicit xor.
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002953 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC));
Craig Topper8ed1aa92017-10-03 05:31:07 +00002954 } else if (C.isNullValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002955 // Replace ((xor A, B) != 0) with (A != B)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002956 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002957 }
2958 }
2959 break;
2960 case Instruction::Sub:
2961 if (BO->hasOneUse()) {
Sanjay Patel9d591d12016-08-04 15:19:25 +00002962 const APInt *BOC;
2963 if (match(BOp0, m_APInt(BOC))) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002964 // Replace ((sub BOC, B) != C) with (B != BOC-C).
Sanjay Patel9d591d12016-08-04 15:19:25 +00002965 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002966 return new ICmpInst(Pred, BOp1, SubC);
Craig Topper8ed1aa92017-10-03 05:31:07 +00002967 } else if (C.isNullValue()) {
Sanjay Patel362ff5c2016-09-15 17:01:17 +00002968 // Replace ((sub A, B) != 0) with (A != B).
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002969 return new ICmpInst(Pred, BOp0, BOp1);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002970 }
2971 }
2972 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002973 case Instruction::Or: {
2974 const APInt *BOC;
2975 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002976 // Comparing if all bits outside of a constant mask are set?
2977 // Replace (X | C) == -1 with (X & ~C) == ~C.
2978 // This removes the -1 constant.
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002979 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1));
Craig Topperbb4069e2017-07-07 23:16:26 +00002980 Value *And = Builder.CreateAnd(BOp0, NotBOC);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00002981 return new ICmpInst(Pred, And, NotBOC);
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002982 }
2983 break;
Sanjay Patelb3de75d2016-08-04 19:12:12 +00002984 }
Sanjay Pateld938e882016-08-04 20:05:02 +00002985 case Instruction::And: {
2986 const APInt *BOC;
2987 if (match(BOp1, m_APInt(BOC))) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002988 // If we have ((X & C) == C), turn it into ((X & C) != 0).
Craig Topper8ed1aa92017-10-03 05:31:07 +00002989 if (C == *BOC && C.isPowerOf2())
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002990 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE,
Sanjay Patelab50a932016-08-02 22:38:33 +00002991 BO, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002992 }
2993 break;
Sanjay Pateld938e882016-08-04 20:05:02 +00002994 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00002995 case Instruction::Mul:
Craig Topper8ed1aa92017-10-03 05:31:07 +00002996 if (C.isNullValue() && BO->hasNoSignedWrap()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002997 const APInt *BOC;
Craig Topper73ba1c82017-06-07 07:40:37 +00002998 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) {
Sanjay Patel3bade132016-08-04 22:19:27 +00002999 // The trivial case (mul X, 0) is handled by InstSimplify.
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003000 // General case : (mul X, C) != 0 iff X != 0
3001 // (mul X, C) == 0 iff X == 0
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003002 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType()));
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003003 }
3004 }
3005 break;
Sanjay Patel6ebd5852016-07-23 00:28:39 +00003006 case Instruction::UDiv:
Craig Topper8ed1aa92017-10-03 05:31:07 +00003007 if (C.isNullValue()) {
Sanjay Patel6ebd5852016-07-23 00:28:39 +00003008 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A)
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003009 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT;
3010 return new ICmpInst(NewPred, BOp1, BOp0);
Sanjay Patel6ebd5852016-07-23 00:28:39 +00003011 }
3012 break;
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003013 default:
3014 break;
3015 }
3016 return nullptr;
3017}
3018
Nikita Popov6515db22019-01-19 09:56:01 +00003019/// Fold an equality icmp with LLVM intrinsic and constant operand.
3020Instruction *InstCombiner::foldICmpEqIntrinsicWithConstant(ICmpInst &Cmp,
3021 IntrinsicInst *II,
3022 const APInt &C) {
Sanjay Patelb51e0722017-07-02 16:05:11 +00003023 Type *Ty = II->getType();
Nikita Popov20853a72018-12-18 19:59:50 +00003024 unsigned BitWidth = C.getBitWidth();
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003025 switch (II->getIntrinsicID()) {
3026 case Intrinsic::bswap:
3027 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003028 Cmp.setOperand(0, II->getArgOperand(0));
Craig Topper8ed1aa92017-10-03 05:31:07 +00003029 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap()));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003030 return &Cmp;
Sanjay Patelb51e0722017-07-02 16:05:11 +00003031
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003032 case Intrinsic::ctlz:
Nikita Popov20853a72018-12-18 19:59:50 +00003033 case Intrinsic::cttz: {
Amaury Sechet6bea6742016-08-04 05:27:20 +00003034 // ctz(A) == bitwidth(A) -> A == 0 and likewise for !=
Nikita Popov20853a72018-12-18 19:59:50 +00003035 if (C == BitWidth) {
Sanjay Patel1710e7c2016-07-21 17:15:49 +00003036 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003037 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00003038 Cmp.setOperand(1, ConstantInt::getNullValue(Ty));
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003039 return &Cmp;
Chris Lattner2188e402010-01-04 07:37:31 +00003040 }
Nikita Popov20853a72018-12-18 19:59:50 +00003041
3042 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set
3043 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits.
3044 // Limit to one use to ensure we don't increase instruction count.
3045 unsigned Num = C.getLimitedValue(BitWidth);
3046 if (Num != BitWidth && II->hasOneUse()) {
3047 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz;
3048 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1)
3049 : APInt::getHighBitsSet(BitWidth, Num + 1);
3050 APInt Mask2 = IsTrailing
3051 ? APInt::getOneBitSet(BitWidth, Num)
3052 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
3053 Cmp.setOperand(0, Builder.CreateAnd(II->getArgOperand(0), Mask1));
3054 Cmp.setOperand(1, ConstantInt::get(Ty, Mask2));
3055 Worklist.Add(II);
3056 return &Cmp;
3057 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003058 break;
Nikita Popov20853a72018-12-18 19:59:50 +00003059 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00003060
Amaury Sechet6bea6742016-08-04 05:27:20 +00003061 case Intrinsic::ctpop: {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003062 // popcount(A) == 0 -> A == 0 and likewise for !=
Amaury Sechet6bea6742016-08-04 05:27:20 +00003063 // popcount(A) == bitwidth(A) -> A == -1 and likewise for !=
Craig Topper8ed1aa92017-10-03 05:31:07 +00003064 bool IsZero = C.isNullValue();
Nikita Popov20853a72018-12-18 19:59:50 +00003065 if (IsZero || C == BitWidth) {
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003066 Worklist.Add(II);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003067 Cmp.setOperand(0, II->getArgOperand(0));
Sanjay Patelb51e0722017-07-02 16:05:11 +00003068 auto *NewOp =
3069 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty);
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003070 Cmp.setOperand(1, NewOp);
3071 return &Cmp;
Amaury Sechet6bea6742016-08-04 05:27:20 +00003072 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003073 break;
Sanjay Patel0a3d72b2016-09-10 15:33:39 +00003074 }
Sanjay Patel18fa9d32016-07-21 23:27:36 +00003075 default:
3076 break;
Chris Lattner2188e402010-01-04 07:37:31 +00003077 }
Sanjay Patelb51e0722017-07-02 16:05:11 +00003078
Craig Topperf40110f2014-04-25 05:29:35 +00003079 return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00003080}
3081
Nikita Popov6515db22019-01-19 09:56:01 +00003082/// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C.
3083Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp,
3084 IntrinsicInst *II,
3085 const APInt &C) {
3086 if (Cmp.isEquality())
3087 return foldICmpEqIntrinsicWithConstant(Cmp, II, C);
3088
3089 Type *Ty = II->getType();
3090 unsigned BitWidth = C.getBitWidth();
3091 switch (II->getIntrinsicID()) {
3092 case Intrinsic::ctlz: {
3093 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000
3094 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
3095 unsigned Num = C.getLimitedValue();
3096 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1);
3097 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT,
3098 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
3099 }
3100
3101 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111
3102 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
3103 C.uge(1) && C.ule(BitWidth)) {
3104 unsigned Num = C.getLimitedValue();
3105 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num);
3106 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT,
3107 II->getArgOperand(0), ConstantInt::get(Ty, Limit));
3108 }
3109 break;
3110 }
3111 case Intrinsic::cttz: {
3112 // Limit to one use to ensure we don't increase instruction count.
3113 if (!II->hasOneUse())
3114 return nullptr;
3115
3116 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0
3117 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) {
3118 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1);
3119 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ,
3120 Builder.CreateAnd(II->getArgOperand(0), Mask),
3121 ConstantInt::getNullValue(Ty));
3122 }
3123
3124 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0
3125 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT &&
3126 C.uge(1) && C.ule(BitWidth)) {
3127 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue());
3128 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE,
3129 Builder.CreateAnd(II->getArgOperand(0), Mask),
3130 ConstantInt::getNullValue(Ty));
3131 }
3132 break;
3133 }
3134 default:
3135 break;
3136 }
3137
3138 return nullptr;
3139}
3140
Sanjay Patel10494b22016-09-16 16:10:22 +00003141/// Handle icmp with constant (but not simple integer constant) RHS.
3142Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) {
3143 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3144 Constant *RHSC = dyn_cast<Constant>(Op1);
3145 Instruction *LHSI = dyn_cast<Instruction>(Op0);
3146 if (!RHSC || !LHSI)
3147 return nullptr;
3148
3149 switch (LHSI->getOpcode()) {
3150 case Instruction::GetElementPtr:
3151 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null
3152 if (RHSC->isNullValue() &&
3153 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices())
3154 return new ICmpInst(
3155 I.getPredicate(), LHSI->getOperand(0),
3156 Constant::getNullValue(LHSI->getOperand(0)->getType()));
3157 break;
3158 case Instruction::PHI:
3159 // Only fold icmp into the PHI if the phi and icmp are in the same
3160 // block. If in the same block, we're encouraging jump threading. If
3161 // not, we are just pessimizing the code by making an i1 phi.
3162 if (LHSI->getParent() == I.getParent())
Craig Topperfb71b7d2017-04-14 19:20:12 +00003163 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Sanjay Patel10494b22016-09-16 16:10:22 +00003164 return NV;
3165 break;
3166 case Instruction::Select: {
3167 // If either operand of the select is a constant, we can fold the
3168 // comparison into the select arms, which will cause one to be
3169 // constant folded and the select turned into a bitwise or.
3170 Value *Op1 = nullptr, *Op2 = nullptr;
3171 ConstantInt *CI = nullptr;
3172 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) {
3173 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
3174 CI = dyn_cast<ConstantInt>(Op1);
3175 }
3176 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) {
3177 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC);
3178 CI = dyn_cast<ConstantInt>(Op2);
3179 }
3180
3181 // We only want to perform this transformation if it will not lead to
3182 // additional code. This is true if either both sides of the select
3183 // fold to a constant (in which case the icmp is replaced with a select
3184 // which will usually simplify) or this is the only user of the
3185 // select (in which case we are trading a select+icmp for a simpler
3186 // select+icmp) or all uses of the select can be replaced based on
3187 // dominance information ("Global cases").
3188 bool Transform = false;
3189 if (Op1 && Op2)
3190 Transform = true;
3191 else if (Op1 || Op2) {
3192 // Local case
3193 if (LHSI->hasOneUse())
3194 Transform = true;
3195 // Global cases
3196 else if (CI && !CI->isZero())
3197 // When Op1 is constant try replacing select with second operand.
3198 // Otherwise Op2 is constant and try replacing select with first
3199 // operand.
3200 Transform =
3201 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1);
3202 }
3203 if (Transform) {
3204 if (!Op1)
Craig Topperbb4069e2017-07-07 23:16:26 +00003205 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC,
3206 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003207 if (!Op2)
Craig Topperbb4069e2017-07-07 23:16:26 +00003208 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC,
3209 I.getName());
Sanjay Patel10494b22016-09-16 16:10:22 +00003210 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2);
3211 }
3212 break;
3213 }
3214 case Instruction::IntToPtr:
3215 // icmp pred inttoptr(X), null -> icmp pred X, 0
3216 if (RHSC->isNullValue() &&
3217 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType())
3218 return new ICmpInst(
3219 I.getPredicate(), LHSI->getOperand(0),
3220 Constant::getNullValue(LHSI->getOperand(0)->getType()));
3221 break;
3222
3223 case Instruction::Load:
3224 // Try to optimize things like "A[i] > 4" to index computations.
3225 if (GetElementPtrInst *GEP =
3226 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) {
3227 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
3228 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
3229 !cast<LoadInst>(LHSI)->isVolatile())
3230 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
3231 return Res;
3232 }
3233 break;
3234 }
3235
3236 return nullptr;
3237}
3238
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003239/// Some comparisons can be simplified.
3240/// In this case, we are looking for comparisons that look like
3241/// a check for a lossy truncation.
3242/// Folds:
Roman Lebedev183a4652018-09-19 13:35:27 +00003243/// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask
3244/// Where Mask is some pattern that produces all-ones in low bits:
3245/// (-1 >> y)
Roman Lebedevf50023d2018-09-19 13:35:46 +00003246/// ((-1 << y) >> y) <- non-canonical, has extra uses
Roman Lebedev183a4652018-09-19 13:35:27 +00003247/// ~(-1 << y)
Roman Lebedevca2bdb02018-09-19 13:35:40 +00003248/// ((1 << y) + (-1)) <- non-canonical, has extra uses
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003249/// The Mask can be a constant, too.
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003250/// For some predicates, the operands are commutative.
3251/// For others, x can only be on a specific side.
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003252static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I,
3253 InstCombiner::BuilderTy &Builder) {
3254 ICmpInst::Predicate SrcPred;
Roman Lebedevf50023d2018-09-19 13:35:46 +00003255 Value *X, *M, *Y;
3256 auto m_VariableMask = m_CombineOr(
3257 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())),
3258 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())),
3259 m_CombineOr(m_LShr(m_AllOnes(), m_Value()),
3260 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y))));
Roman Lebedev183a4652018-09-19 13:35:27 +00003261 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask());
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003262 if (!match(&I, m_c_ICmp(SrcPred,
3263 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)),
3264 m_Deferred(X))))
3265 return nullptr;
3266
3267 ICmpInst::Predicate DstPred;
3268 switch (SrcPred) {
3269 case ICmpInst::Predicate::ICMP_EQ:
3270 // x & (-1 >> y) == x -> x u<= (-1 >> y)
3271 DstPred = ICmpInst::Predicate::ICMP_ULE;
3272 break;
Roman Lebedev74f899f2018-07-12 14:56:12 +00003273 case ICmpInst::Predicate::ICMP_NE:
3274 // x & (-1 >> y) != x -> x u> (-1 >> y)
3275 DstPred = ICmpInst::Predicate::ICMP_UGT;
3276 break;
Roman Lebedev74f611a2018-07-14 16:44:43 +00003277 case ICmpInst::Predicate::ICMP_UGT:
3278 // x u> x & (-1 >> y) -> x u> (-1 >> y)
3279 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3280 DstPred = ICmpInst::Predicate::ICMP_UGT;
3281 break;
Roman Lebedevfac48472018-07-14 12:20:06 +00003282 case ICmpInst::Predicate::ICMP_UGE:
3283 // x & (-1 >> y) u>= x -> x u<= (-1 >> y)
3284 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3285 DstPred = ICmpInst::Predicate::ICMP_ULE;
3286 break;
Roman Lebedeve3dc5872018-07-14 12:20:16 +00003287 case ICmpInst::Predicate::ICMP_ULT:
3288 // x & (-1 >> y) u< x -> x u> (-1 >> y)
3289 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant");
3290 DstPred = ICmpInst::Predicate::ICMP_UGT;
3291 break;
Roman Lebedev0f5ec892018-07-14 16:44:54 +00003292 case ICmpInst::Predicate::ICMP_ULE:
3293 // x u<= x & (-1 >> y) -> x u<= (-1 >> y)
3294 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant");
3295 DstPred = ICmpInst::Predicate::ICMP_ULE;
3296 break;
Roman Lebedev859e14a2018-07-14 20:08:16 +00003297 case ICmpInst::Predicate::ICMP_SGT:
3298 // x s> x & (-1 >> y) -> x s> (-1 >> y)
3299 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3300 return nullptr; // Ignore the other case.
Roman Lebedevd6697582019-06-09 16:30:42 +00003301 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3302 return nullptr;
3303 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3304 return nullptr;
Roman Lebedev859e14a2018-07-14 20:08:16 +00003305 DstPred = ICmpInst::Predicate::ICMP_SGT;
3306 break;
Roman Lebedevf1442612018-07-14 20:08:37 +00003307 case ICmpInst::Predicate::ICMP_SGE:
3308 // x & (-1 >> y) s>= x -> x s<= (-1 >> y)
3309 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3310 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003311 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3312 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003313 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3314 return nullptr;
Roman Lebedevf1442612018-07-14 20:08:37 +00003315 DstPred = ICmpInst::Predicate::ICMP_SLE;
3316 break;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003317 case ICmpInst::Predicate::ICMP_SLT:
3318 // x & (-1 >> y) s< x -> x s> (-1 >> y)
3319 if (X != I.getOperand(1)) // X must be on RHS of comparison!
3320 return nullptr; // Ignore the other case.
Roman Lebedev7bf2fed2018-12-03 20:07:58 +00003321 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3322 return nullptr;
Roman Lebedev98cb1212018-12-06 08:14:24 +00003323 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3324 return nullptr;
Roman Lebedevb972fc32018-07-14 20:08:47 +00003325 DstPred = ICmpInst::Predicate::ICMP_SGT;
3326 break;
Roman Lebedev1e61e352018-07-14 20:08:26 +00003327 case ICmpInst::Predicate::ICMP_SLE:
3328 // x s<= x & (-1 >> y) -> x s<= (-1 >> y)
3329 if (X != I.getOperand(0)) // X must be on LHS of comparison!
3330 return nullptr; // Ignore the other case.
Roman Lebedevd6697582019-06-09 16:30:42 +00003331 if (!match(M, m_Constant())) // Can not do this fold with non-constant.
3332 return nullptr;
3333 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements.
3334 return nullptr;
Roman Lebedev1e61e352018-07-14 20:08:26 +00003335 DstPred = ICmpInst::Predicate::ICMP_SLE;
3336 break;
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003337 default:
Roman Lebedevc7bc4c02018-07-14 20:08:52 +00003338 llvm_unreachable("All possible folds are handled.");
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003339 }
3340
3341 return Builder.CreateICmp(DstPred, X, M);
3342}
3343
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003344/// Some comparisons can be simplified.
3345/// In this case, we are looking for comparisons that look like
3346/// a check for a lossy signed truncation.
3347/// Folds: (MaskedBits is a constant.)
3348/// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x
3349/// Into:
3350/// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits)
3351/// Where KeptBits = bitwidth(%x) - MaskedBits
3352static Value *
3353foldICmpWithTruncSignExtendedVal(ICmpInst &I,
3354 InstCombiner::BuilderTy &Builder) {
3355 ICmpInst::Predicate SrcPred;
3356 Value *X;
3357 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef.
3358 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use.
3359 if (!match(&I, m_c_ICmp(SrcPred,
3360 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)),
3361 m_APInt(C1))),
3362 m_Deferred(X))))
3363 return nullptr;
3364
3365 // Potential handling of non-splats: for each element:
3366 // * if both are undef, replace with constant 0.
3367 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0.
3368 // * if both are not undef, and are different, bailout.
3369 // * else, only one is undef, then pick the non-undef one.
3370
3371 // The shift amount must be equal.
3372 if (*C0 != *C1)
3373 return nullptr;
3374 const APInt &MaskedBits = *C0;
3375 assert(MaskedBits != 0 && "shift by zero should be folded away already.");
3376
3377 ICmpInst::Predicate DstPred;
3378 switch (SrcPred) {
3379 case ICmpInst::Predicate::ICMP_EQ:
3380 // ((%x << MaskedBits) a>> MaskedBits) == %x
3381 // =>
3382 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits)
3383 DstPred = ICmpInst::Predicate::ICMP_ULT;
3384 break;
3385 case ICmpInst::Predicate::ICMP_NE:
3386 // ((%x << MaskedBits) a>> MaskedBits) != %x
3387 // =>
3388 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits)
3389 DstPred = ICmpInst::Predicate::ICMP_UGE;
3390 break;
3391 // FIXME: are more folds possible?
3392 default:
3393 return nullptr;
3394 }
3395
3396 auto *XType = X->getType();
3397 const unsigned XBitWidth = XType->getScalarSizeInBits();
3398 const APInt BitWidth = APInt(XBitWidth, XBitWidth);
3399 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched");
3400
3401 // KeptBits = bitwidth(%x) - MaskedBits
3402 const APInt KeptBits = BitWidth - MaskedBits;
3403 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable");
3404 // ICmpCst = (1 << KeptBits)
3405 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits);
3406 assert(ICmpCst.isPowerOf2());
3407 // AddCst = (1 << (KeptBits-1))
3408 const APInt AddCst = ICmpCst.lshr(1);
3409 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2());
3410
3411 // T0 = add %x, AddCst
3412 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst));
3413 // T1 = T0 DstPred ICmpCst
3414 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst));
3415
3416 return T1;
3417}
3418
Roman Lebedev72b8d412019-07-01 15:55:15 +00003419// Given pattern:
3420// icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0
3421// we should move shifts to the same hand of 'and', i.e. rewrite as
3422// icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x)
3423// We are only interested in opposite logical shifts here.
Roman Lebedevf13b0e32019-08-29 10:26:23 +00003424// One of the shifts can be truncated.
Roman Lebedev72b8d412019-07-01 15:55:15 +00003425// If we can, we want to end up creating 'lshr' shift.
3426static Value *
3427foldShiftIntoShiftInAnotherHandOfAndInICmp(ICmpInst &I, const SimplifyQuery SQ,
3428 InstCombiner::BuilderTy &Builder) {
3429 if (!I.isEquality() || !match(I.getOperand(1), m_Zero()) ||
3430 !I.getOperand(0)->hasOneUse())
3431 return nullptr;
3432
3433 auto m_AnyLogicalShift = m_LogicalShift(m_Value(), m_Value());
Roman Lebedev72b8d412019-07-01 15:55:15 +00003434
Roman Lebedev16244fc2019-08-16 15:10:41 +00003435 // Look for an 'and' of two logical shifts, one of which may be truncated.
3436 // We use m_TruncOrSelf() on the RHS to correctly handle commutative case.
3437 Instruction *XShift, *MaybeTruncation, *YShift;
3438 if (!match(
3439 I.getOperand(0),
3440 m_c_And(m_CombineAnd(m_AnyLogicalShift, m_Instruction(XShift)),
3441 m_CombineAnd(m_TruncOrSelf(m_CombineAnd(
3442 m_AnyLogicalShift, m_Instruction(YShift))),
3443 m_Instruction(MaybeTruncation)))))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003444 return nullptr;
3445
Roman Lebedev16244fc2019-08-16 15:10:41 +00003446 // We potentially looked past 'trunc', but only when matching YShift,
3447 // therefore YShift must have the widest type.
Roman Lebedev9b957d32019-08-18 12:26:33 +00003448 Instruction *WidestShift = YShift;
3449 // Therefore XShift must have the shallowest type.
3450 // Or they both have identical types if there was no truncation.
3451 Instruction *NarrowestShift = XShift;
3452
3453 Type *WidestTy = WidestShift->getType();
3454 assert(NarrowestShift->getType() == I.getOperand(0)->getType() &&
Roman Lebedev16244fc2019-08-16 15:10:41 +00003455 "We did not look past any shifts while matching XShift though.");
3456 bool HadTrunc = WidestTy != I.getOperand(0)->getType();
3457
Roman Lebedev64fe8062019-08-10 19:28:44 +00003458 // If YShift is a 'lshr', swap the shifts around.
Roman Lebedev16244fc2019-08-16 15:10:41 +00003459 if (match(YShift, m_LShr(m_Value(), m_Value())))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003460 std::swap(XShift, YShift);
3461
3462 // The shifts must be in opposite directions.
Roman Lebedevccdad6e2019-08-12 11:28:02 +00003463 auto XShiftOpcode = XShift->getOpcode();
3464 if (XShiftOpcode == YShift->getOpcode())
Roman Lebedev72b8d412019-07-01 15:55:15 +00003465 return nullptr; // Do not care about same-direction shifts here.
3466
3467 Value *X, *XShAmt, *Y, *YShAmt;
Roman Lebedev16244fc2019-08-16 15:10:41 +00003468 match(XShift, m_BinOp(m_Value(X), m_ZExtOrSelf(m_Value(XShAmt))));
3469 match(YShift, m_BinOp(m_Value(Y), m_ZExtOrSelf(m_Value(YShAmt))));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003470
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003471 // If one of the values being shifted is a constant, then we will end with
Roman Lebedev16244fc2019-08-16 15:10:41 +00003472 // and+icmp, and [zext+]shift instrs will be constant-folded. If they are not,
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003473 // however, we will need to ensure that we won't increase instruction count.
3474 if (!isa<Constant>(X) && !isa<Constant>(Y)) {
3475 // At least one of the hands of the 'and' should be one-use shift.
3476 if (!match(I.getOperand(0),
3477 m_c_And(m_OneUse(m_AnyLogicalShift), m_Value())))
3478 return nullptr;
Roman Lebedev16244fc2019-08-16 15:10:41 +00003479 if (HadTrunc) {
3480 // Due to the 'trunc', we will need to widen X. For that either the old
3481 // 'trunc' or the shift amt in the non-truncated shift should be one-use.
3482 if (!MaybeTruncation->hasOneUse() &&
Roman Lebedev9b957d32019-08-18 12:26:33 +00003483 !NarrowestShift->getOperand(1)->hasOneUse())
Roman Lebedev16244fc2019-08-16 15:10:41 +00003484 return nullptr;
3485 }
Roman Lebedeva8d20b42019-08-10 19:28:54 +00003486 }
3487
Roman Lebedev16244fc2019-08-16 15:10:41 +00003488 // We have two shift amounts from two different shifts. The types of those
3489 // shift amounts may not match. If that's the case let's bailout now.
3490 if (XShAmt->getType() != YShAmt->getType())
3491 return nullptr;
3492
Roman Lebedev72b8d412019-07-01 15:55:15 +00003493 // Can we fold (XShAmt+YShAmt) ?
Roman Lebedev16244fc2019-08-16 15:10:41 +00003494 auto *NewShAmt = dyn_cast_or_null<Constant>(
3495 SimplifyAddInst(XShAmt, YShAmt, /*isNSW=*/false,
3496 /*isNUW=*/false, SQ.getWithInstruction(&I)));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003497 if (!NewShAmt)
3498 return nullptr;
Roman Lebedevf13b0e32019-08-29 10:26:23 +00003499 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, WidestTy);
3500 unsigned WidestBitWidth = WidestTy->getScalarSizeInBits();
3501
Roman Lebedev72b8d412019-07-01 15:55:15 +00003502 // Is the new shift amount smaller than the bit width?
3503 // FIXME: could also rely on ConstantRange.
Roman Lebedevf13b0e32019-08-29 10:26:23 +00003504 if (!match(NewShAmt,
3505 m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_ULT,
3506 APInt(WidestBitWidth, WidestBitWidth))))
Roman Lebedev72b8d412019-07-01 15:55:15 +00003507 return nullptr;
Roman Lebedevf13b0e32019-08-29 10:26:23 +00003508
3509 // An extra legality check is needed if we had trunc-of-lshr.
3510 if (HadTrunc && match(WidestShift, m_LShr(m_Value(), m_Value()))) {
3511 auto CanFold = [NewShAmt, WidestBitWidth, NarrowestShift, SQ,
3512 WidestShift]() {
3513 // It isn't obvious whether it's worth it to analyze non-constants here.
3514 // Also, let's basically give up on non-splat cases, pessimizing vectors.
3515 // If *any* of these preconditions matches we can perform the fold.
3516 Constant *NewShAmtSplat = NewShAmt->getType()->isVectorTy()
3517 ? NewShAmt->getSplatValue()
3518 : NewShAmt;
3519 // If it's edge-case shift (by 0 or by WidestBitWidth-1) we can fold.
3520 if (NewShAmtSplat &&
3521 (NewShAmtSplat->isNullValue() ||
3522 NewShAmtSplat->getUniqueInteger() == WidestBitWidth - 1))
3523 return true;
3524 // We consider *min* leading zeros so a single outlier
3525 // blocks the transform as opposed to allowing it.
3526 if (auto *C = dyn_cast<Constant>(NarrowestShift->getOperand(0))) {
3527 KnownBits Known = computeKnownBits(C, SQ.DL);
3528 unsigned MinLeadZero = Known.countMinLeadingZeros();
3529 // If the value being shifted has at most lowest bit set we can fold.
3530 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero;
3531 if (MaxActiveBits <= 1)
3532 return true;
3533 // Precondition: NewShAmt u<= countLeadingZeros(C)
3534 if (NewShAmtSplat && NewShAmtSplat->getUniqueInteger().ule(MinLeadZero))
3535 return true;
3536 }
3537 if (auto *C = dyn_cast<Constant>(WidestShift->getOperand(0))) {
3538 KnownBits Known = computeKnownBits(C, SQ.DL);
3539 unsigned MinLeadZero = Known.countMinLeadingZeros();
3540 // If the value being shifted has at most lowest bit set we can fold.
3541 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero;
3542 if (MaxActiveBits <= 1)
3543 return true;
3544 // Precondition: ((WidestBitWidth-1)-NewShAmt) u<= countLeadingZeros(C)
3545 if (NewShAmtSplat) {
3546 APInt AdjNewShAmt =
3547 (WidestBitWidth - 1) - NewShAmtSplat->getUniqueInteger();
3548 if (AdjNewShAmt.ule(MinLeadZero))
3549 return true;
3550 }
3551 }
3552 return false; // Can't tell if it's ok.
3553 };
3554 if (!CanFold())
3555 return nullptr;
3556 }
3557
Roman Lebedev16244fc2019-08-16 15:10:41 +00003558 // All good, we can do this fold.
Roman Lebedev16244fc2019-08-16 15:10:41 +00003559 X = Builder.CreateZExt(X, WidestTy);
Roman Lebedevf13b0e32019-08-29 10:26:23 +00003560 Y = Builder.CreateZExt(Y, WidestTy);
Roman Lebedev16244fc2019-08-16 15:10:41 +00003561 // The shift is the same that was for X.
Roman Lebedev72b8d412019-07-01 15:55:15 +00003562 Value *T0 = XShiftOpcode == Instruction::BinaryOps::LShr
3563 ? Builder.CreateLShr(X, NewShAmt)
3564 : Builder.CreateShl(X, NewShAmt);
3565 Value *T1 = Builder.CreateAnd(T0, Y);
3566 return Builder.CreateICmp(I.getPredicate(), T1,
Roman Lebedev16244fc2019-08-16 15:10:41 +00003567 Constant::getNullValue(WidestTy));
Roman Lebedev72b8d412019-07-01 15:55:15 +00003568}
3569
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003570/// Fold
3571/// (-1 u/ x) u< y
Roman Lebedev473a0632019-08-29 12:47:20 +00003572/// ((x * y) u/ x) != y
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003573/// to
3574/// @llvm.umul.with.overflow(x, y) plus extraction of overflow bit
Roman Lebedev473a0632019-08-29 12:47:20 +00003575/// Note that the comparison is commutative, while inverted (u>=, ==) predicate
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003576/// will mean that we are looking for the opposite answer.
Roman Lebedev473a0632019-08-29 12:47:20 +00003577Value *InstCombiner::foldUnsignedMultiplicationOverflowCheck(ICmpInst &I) {
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003578 ICmpInst::Predicate Pred;
3579 Value *X, *Y;
Roman Lebedev473a0632019-08-29 12:47:20 +00003580 Instruction *Mul;
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003581 bool NeedNegation;
3582 // Look for: (-1 u/ x) u</u>= y
3583 if (!I.isEquality() &&
3584 match(&I, m_c_ICmp(Pred, m_OneUse(m_UDiv(m_AllOnes(), m_Value(X))),
3585 m_Value(Y)))) {
Roman Lebedev473a0632019-08-29 12:47:20 +00003586 Mul = nullptr;
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003587 // Canonicalize as-if y was on RHS.
3588 if (I.getOperand(1) != Y)
3589 Pred = I.getSwappedPredicate();
3590
3591 // Are we checking that overflow does not happen, or does happen?
3592 switch (Pred) {
3593 case ICmpInst::Predicate::ICMP_ULT:
3594 NeedNegation = false;
3595 break; // OK
3596 case ICmpInst::Predicate::ICMP_UGE:
3597 NeedNegation = true;
3598 break; // OK
3599 default:
3600 return nullptr; // Wrong predicate.
3601 }
Roman Lebedev473a0632019-08-29 12:47:20 +00003602 } else // Look for: ((x * y) u/ x) !=/== y
3603 if (I.isEquality() &&
3604 match(&I, m_c_ICmp(Pred, m_Value(Y),
3605 m_OneUse(m_UDiv(m_CombineAnd(m_c_Mul(m_Deferred(Y),
3606 m_Value(X)),
3607 m_Instruction(Mul)),
3608 m_Deferred(X)))))) {
3609 NeedNegation = Pred == ICmpInst::Predicate::ICMP_EQ;
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003610 } else
3611 return nullptr;
3612
Roman Lebedev473a0632019-08-29 12:47:20 +00003613 BuilderTy::InsertPointGuard Guard(Builder);
3614 // If the pattern included (x * y), we'll want to insert new instructions
3615 // right before that original multiplication so that we can replace it.
3616 bool MulHadOtherUses = Mul && !Mul->hasOneUse();
3617 if (MulHadOtherUses)
3618 Builder.SetInsertPoint(Mul);
3619
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003620 Function *F = Intrinsic::getDeclaration(
3621 I.getModule(), Intrinsic::umul_with_overflow, X->getType());
3622 CallInst *Call = Builder.CreateCall(F, {X, Y}, "umul");
Roman Lebedev473a0632019-08-29 12:47:20 +00003623
3624 // If the multiplication was used elsewhere, to ensure that we don't leave
3625 // "duplicate" instructions, replace uses of that original multiplication
3626 // with the multiplication result from the with.overflow intrinsic.
3627 if (MulHadOtherUses)
3628 replaceInstUsesWith(*Mul, Builder.CreateExtractValue(Call, 0, "umul.val"));
3629
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003630 Value *Res = Builder.CreateExtractValue(Call, 1, "umul.ov");
3631 if (NeedNegation) // This technically increases instruction count.
3632 Res = Builder.CreateNot(Res, "umul.not.ov");
3633
3634 return Res;
3635}
3636
Sanjay Patel10494b22016-09-16 16:10:22 +00003637/// Try to fold icmp (binop), X or icmp X, (binop).
Sanjay Patel2df38a82017-05-08 16:21:55 +00003638/// TODO: A large part of this logic is duplicated in InstSimplify's
3639/// simplifyICmpWithBinOp(). We should be able to share that and avoid the code
3640/// duplication.
Roman Lebedev23646952019-09-25 19:06:40 +00003641Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I, const SimplifyQuery &SQ) {
3642 const SimplifyQuery Q = SQ.getWithInstruction(&I);
Sanjay Patel10494b22016-09-16 16:10:22 +00003643 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
3644
3645 // Special logic for binary operators.
3646 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0);
3647 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1);
3648 if (!BO0 && !BO1)
3649 return nullptr;
3650
Sanjay Patel2a062632017-05-08 16:33:42 +00003651 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel1cf07342018-09-11 22:40:20 +00003652 Value *X;
3653
3654 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare.
Roman Lebedevecb7ea12019-09-05 17:40:49 +00003655 // (Op1 + X) u</u>= Op1 --> ~Op1 u</u>= X
Sanjay Patel1cf07342018-09-11 22:40:20 +00003656 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) &&
Roman Lebedevecb7ea12019-09-05 17:40:49 +00003657 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE))
Sanjay Patel1cf07342018-09-11 22:40:20 +00003658 return new ICmpInst(Pred, Builder.CreateNot(Op1), X);
Roman Lebedevecb7ea12019-09-05 17:40:49 +00003659 // Op0 u>/u<= (Op0 + X) --> X u>/u<= ~Op0
Sanjay Patel1cf07342018-09-11 22:40:20 +00003660 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) &&
Roman Lebedevecb7ea12019-09-05 17:40:49 +00003661 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE))
Sanjay Patel1cf07342018-09-11 22:40:20 +00003662 return new ICmpInst(Pred, X, Builder.CreateNot(Op0));
3663
Sanjay Patel10494b22016-09-16 16:10:22 +00003664 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false;
3665 if (BO0 && isa<OverflowingBinaryOperator>(BO0))
3666 NoOp0WrapProblem =
3667 ICmpInst::isEquality(Pred) ||
3668 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) ||
3669 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap());
3670 if (BO1 && isa<OverflowingBinaryOperator>(BO1))
3671 NoOp1WrapProblem =
3672 ICmpInst::isEquality(Pred) ||
3673 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) ||
3674 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap());
3675
3676 // Analyze the case when either Op0 or Op1 is an add instruction.
3677 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null).
3678 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr;
3679 if (BO0 && BO0->getOpcode() == Instruction::Add) {
3680 A = BO0->getOperand(0);
3681 B = BO0->getOperand(1);
3682 }
3683 if (BO1 && BO1->getOpcode() == Instruction::Add) {
3684 C = BO1->getOperand(0);
3685 D = BO1->getOperand(1);
3686 }
3687
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003688 // icmp (A+B), A -> icmp B, 0 for equalities or if there is no overflow.
3689 // icmp (A+B), B -> icmp A, 0 for equalities or if there is no overflow.
Sanjay Patel10494b22016-09-16 16:10:22 +00003690 if ((A == Op1 || B == Op1) && NoOp0WrapProblem)
3691 return new ICmpInst(Pred, A == Op1 ? B : A,
3692 Constant::getNullValue(Op1->getType()));
3693
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003694 // icmp C, (C+D) -> icmp 0, D for equalities or if there is no overflow.
3695 // icmp D, (C+D) -> icmp 0, C for equalities or if there is no overflow.
Sanjay Patel10494b22016-09-16 16:10:22 +00003696 if ((C == Op0 || D == Op0) && NoOp1WrapProblem)
3697 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()),
3698 C == Op0 ? D : C);
3699
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003700 // icmp (A+B), (A+D) -> icmp B, D for equalities or if there is no overflow.
Sanjay Patel10494b22016-09-16 16:10:22 +00003701 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem &&
Sanjay Patel3961a142019-09-16 16:15:25 +00003702 NoOp1WrapProblem) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003703 // Determine Y and Z in the form icmp (X+Y), (X+Z).
3704 Value *Y, *Z;
3705 if (A == C) {
3706 // C + B == C + D -> B == D
3707 Y = B;
3708 Z = D;
3709 } else if (A == D) {
3710 // D + B == C + D -> B == C
3711 Y = B;
3712 Z = C;
3713 } else if (B == C) {
3714 // A + C == C + D -> A == D
3715 Y = A;
3716 Z = D;
3717 } else {
3718 assert(B == D);
3719 // A + D == C + D -> A == C
3720 Y = A;
3721 Z = C;
3722 }
3723 return new ICmpInst(Pred, Y, Z);
3724 }
3725
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003726 // icmp slt (A + -1), Op1 -> icmp sle A, Op1
Sanjay Patel10494b22016-09-16 16:10:22 +00003727 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT &&
3728 match(B, m_AllOnes()))
3729 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1);
3730
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003731 // icmp sge (A + -1), Op1 -> icmp sgt A, Op1
Sanjay Patel10494b22016-09-16 16:10:22 +00003732 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE &&
3733 match(B, m_AllOnes()))
3734 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1);
3735
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003736 // icmp sle (A + 1), Op1 -> icmp slt A, Op1
Sanjay Patel10494b22016-09-16 16:10:22 +00003737 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One()))
3738 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1);
3739
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003740 // icmp sgt (A + 1), Op1 -> icmp sge A, Op1
Sanjay Patel10494b22016-09-16 16:10:22 +00003741 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One()))
3742 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1);
3743
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003744 // icmp sgt Op0, (C + -1) -> icmp sge Op0, C
Sanjay Patel10494b22016-09-16 16:10:22 +00003745 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT &&
3746 match(D, m_AllOnes()))
3747 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C);
3748
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003749 // icmp sle Op0, (C + -1) -> icmp slt Op0, C
Sanjay Patel10494b22016-09-16 16:10:22 +00003750 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE &&
3751 match(D, m_AllOnes()))
3752 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C);
3753
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003754 // icmp sge Op0, (C + 1) -> icmp sgt Op0, C
Sanjay Patel10494b22016-09-16 16:10:22 +00003755 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One()))
3756 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C);
3757
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003758 // icmp slt Op0, (C + 1) -> icmp sle Op0, C
Sanjay Patel10494b22016-09-16 16:10:22 +00003759 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One()))
3760 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C);
3761
Sanjay Patel40f40172017-01-13 23:25:46 +00003762 // TODO: The subtraction-related identities shown below also hold, but
3763 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations
3764 // wouldn't happen even if they were implemented.
3765 //
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003766 // icmp ult (A - 1), Op1 -> icmp ule A, Op1
3767 // icmp uge (A - 1), Op1 -> icmp ugt A, Op1
3768 // icmp ugt Op0, (C - 1) -> icmp uge Op0, C
3769 // icmp ule Op0, (C - 1) -> icmp ult Op0, C
Sanjay Patel40f40172017-01-13 23:25:46 +00003770
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003771 // icmp ule (A + 1), Op0 -> icmp ult A, Op1
Sanjay Patel40f40172017-01-13 23:25:46 +00003772 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One()))
3773 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1);
3774
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003775 // icmp ugt (A + 1), Op0 -> icmp uge A, Op1
Sanjay Patel40f40172017-01-13 23:25:46 +00003776 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One()))
3777 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1);
3778
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003779 // icmp uge Op0, (C + 1) -> icmp ugt Op0, C
Sanjay Patel40f40172017-01-13 23:25:46 +00003780 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One()))
3781 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C);
3782
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003783 // icmp ult Op0, (C + 1) -> icmp ule Op0, C
Sanjay Patel40f40172017-01-13 23:25:46 +00003784 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One()))
3785 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C);
3786
Sanjay Patel10494b22016-09-16 16:10:22 +00003787 // if C1 has greater magnitude than C2:
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003788 // icmp (A + C1), (C + C2) -> icmp (A + C3), C
Sanjay Patel10494b22016-09-16 16:10:22 +00003789 // s.t. C3 = C1 - C2
3790 //
3791 // if C2 has greater magnitude than C1:
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003792 // icmp (A + C1), (C + C2) -> icmp A, (C + C3)
Sanjay Patel10494b22016-09-16 16:10:22 +00003793 // s.t. C3 = C2 - C1
3794 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem &&
3795 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned())
3796 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B))
3797 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) {
3798 const APInt &AP1 = C1->getValue();
3799 const APInt &AP2 = C2->getValue();
3800 if (AP1.isNegative() == AP2.isNegative()) {
3801 APInt AP1Abs = C1->getValue().abs();
3802 APInt AP2Abs = C2->getValue().abs();
3803 if (AP1Abs.uge(AP2Abs)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00003804 ConstantInt *C3 = Builder.getInt(AP1 - AP2);
3805 Value *NewAdd = Builder.CreateNSWAdd(A, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003806 return new ICmpInst(Pred, NewAdd, C);
3807 } else {
Craig Topperbb4069e2017-07-07 23:16:26 +00003808 ConstantInt *C3 = Builder.getInt(AP2 - AP1);
3809 Value *NewAdd = Builder.CreateNSWAdd(C, C3);
Sanjay Patel10494b22016-09-16 16:10:22 +00003810 return new ICmpInst(Pred, A, NewAdd);
3811 }
3812 }
3813 }
3814
3815 // Analyze the case when either Op0 or Op1 is a sub instruction.
3816 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null).
3817 A = nullptr;
3818 B = nullptr;
3819 C = nullptr;
3820 D = nullptr;
3821 if (BO0 && BO0->getOpcode() == Instruction::Sub) {
3822 A = BO0->getOperand(0);
3823 B = BO0->getOperand(1);
3824 }
3825 if (BO1 && BO1->getOpcode() == Instruction::Sub) {
3826 C = BO1->getOperand(0);
3827 D = BO1->getOperand(1);
3828 }
3829
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003830 // icmp (A-B), A -> icmp 0, B for equalities or if there is no overflow.
Sanjay Patel10494b22016-09-16 16:10:22 +00003831 if (A == Op1 && NoOp0WrapProblem)
3832 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B);
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003833 // icmp C, (C-D) -> icmp D, 0 for equalities or if there is no overflow.
Sanjay Patel10494b22016-09-16 16:10:22 +00003834 if (C == Op0 && NoOp1WrapProblem)
3835 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType()));
3836
Roman Lebedev8360c422019-09-05 17:41:02 +00003837 // Convert sub-with-unsigned-overflow comparisons into a comparison of args.
3838 // (A - B) u>/u<= A --> B u>/u<= A
3839 if (A == Op1 && (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE))
3840 return new ICmpInst(Pred, B, A);
3841 // C u</u>= (C - D) --> C u</u>= D
3842 if (C == Op0 && (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE))
3843 return new ICmpInst(Pred, C, D);
Roman Lebedev23646952019-09-25 19:06:40 +00003844 // (A - B) u>=/u< A --> B u>/u<= A iff B != 0
3845 if (A == Op1 && (Pred == ICmpInst::ICMP_UGE || Pred == ICmpInst::ICMP_ULT) &&
3846 isKnownNonZero(B, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT))
3847 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), B, A);
3848 // C u<=/u> (C - D) --> C u</u>= D iff B != 0
3849 if (C == Op0 && (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT) &&
3850 isKnownNonZero(D, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT))
3851 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), C, D);
Sanjay Patelcbb04502018-04-02 20:37:40 +00003852
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003853 // icmp (A-B), (C-B) -> icmp A, C for equalities or if there is no overflow.
Sanjay Patel3daf1682019-09-15 20:56:34 +00003854 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem)
Sanjay Patel10494b22016-09-16 16:10:22 +00003855 return new ICmpInst(Pred, A, C);
Sanjay Patel3daf1682019-09-15 20:56:34 +00003856
Sanjay Patel91c2cd02019-09-16 12:12:05 +00003857 // icmp (A-B), (A-D) -> icmp D, B for equalities or if there is no overflow.
Sanjay Patelc5cd8082019-09-16 12:54:34 +00003858 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem)
Sanjay Patel10494b22016-09-16 16:10:22 +00003859 return new ICmpInst(Pred, D, B);
3860
3861 // icmp (0-X) < cst --> x > -cst
3862 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) {
3863 Value *X;
3864 if (match(BO0, m_Neg(m_Value(X))))
Chen Zhengb9722732018-07-16 00:51:40 +00003865 if (Constant *RHSC = dyn_cast<Constant>(Op1))
3866 if (RHSC->isNotMinSignedValue())
Sanjay Patel10494b22016-09-16 16:10:22 +00003867 return new ICmpInst(I.getSwappedPredicate(), X,
3868 ConstantExpr::getNeg(RHSC));
3869 }
3870
3871 BinaryOperator *SRem = nullptr;
3872 // icmp (srem X, Y), Y
3873 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1))
3874 SRem = BO0;
3875 // icmp Y, (srem X, Y)
3876 else if (BO1 && BO1->getOpcode() == Instruction::SRem &&
3877 Op0 == BO1->getOperand(1))
3878 SRem = BO1;
3879 if (SRem) {
3880 // We don't check hasOneUse to avoid increasing register pressure because
3881 // the value we use is the same value this instruction was already using.
3882 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) {
3883 default:
3884 break;
3885 case ICmpInst::ICMP_EQ:
3886 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
3887 case ICmpInst::ICMP_NE:
3888 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
3889 case ICmpInst::ICMP_SGT:
3890 case ICmpInst::ICMP_SGE:
3891 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1),
3892 Constant::getAllOnesValue(SRem->getType()));
3893 case ICmpInst::ICMP_SLT:
3894 case ICmpInst::ICMP_SLE:
3895 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1),
3896 Constant::getNullValue(SRem->getType()));
3897 }
3898 }
3899
3900 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() &&
3901 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) {
3902 switch (BO0->getOpcode()) {
3903 default:
3904 break;
3905 case Instruction::Add:
3906 case Instruction::Sub:
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003907 case Instruction::Xor: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003908 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b
Sanjay Patel2a062632017-05-08 16:33:42 +00003909 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003910
3911 const APInt *C;
3912 if (match(BO0->getOperand(1), m_APInt(C))) {
3913 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b
3914 if (C->isSignMask()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003915 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003916 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003917 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003918 }
3919
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003920 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b
3921 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) {
Sanjay Patel2a062632017-05-08 16:33:42 +00003922 ICmpInst::Predicate NewPred =
Sanjay Patel10494b22016-09-16 16:10:22 +00003923 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate();
Sanjay Patel2a062632017-05-08 16:33:42 +00003924 NewPred = I.getSwappedPredicate(NewPred);
3925 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003926 }
3927 }
3928 break;
Sanjay Pateld3106ad2017-05-23 17:29:58 +00003929 }
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003930 case Instruction::Mul: {
Sanjay Patel10494b22016-09-16 16:10:22 +00003931 if (!I.isEquality())
3932 break;
3933
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003934 const APInt *C;
Craig Topper73ba1c82017-06-07 07:40:37 +00003935 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() &&
3936 !C->isOneValue()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003937 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask)
3938 // Mask = -1 >> count-trailing-zeros(C).
Sanjay Patel51506122017-05-25 14:13:57 +00003939 if (unsigned TZs = C->countTrailingZeros()) {
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003940 Constant *Mask = ConstantInt::get(
3941 BO0->getType(),
Sanjay Patel51506122017-05-25 14:13:57 +00003942 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs));
Craig Topperbb4069e2017-07-07 23:16:26 +00003943 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask);
3944 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask);
Sanjay Patel2a062632017-05-08 16:33:42 +00003945 return new ICmpInst(Pred, And1, And2);
Sanjay Patel10494b22016-09-16 16:10:22 +00003946 }
Sanjay Patel51506122017-05-25 14:13:57 +00003947 // If there are no trailing zeros in the multiplier, just eliminate
3948 // the multiplies (no masking is needed):
3949 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y
3950 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003951 }
3952 break;
Sanjay Patel07b1ba52017-05-24 22:58:17 +00003953 }
Sanjay Patel10494b22016-09-16 16:10:22 +00003954 case Instruction::UDiv:
3955 case Instruction::LShr:
Sanjay Patel878715f2017-05-15 19:27:53 +00003956 if (I.isSigned() || !BO0->isExact() || !BO1->isExact())
Sanjay Patel10494b22016-09-16 16:10:22 +00003957 break;
Sanjay Patel878715f2017-05-15 19:27:53 +00003958 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3959
Sanjay Patel10494b22016-09-16 16:10:22 +00003960 case Instruction::SDiv:
Sanjay Patel878715f2017-05-15 19:27:53 +00003961 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact())
3962 break;
3963 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
3964
Sanjay Patel10494b22016-09-16 16:10:22 +00003965 case Instruction::AShr:
3966 if (!BO0->isExact() || !BO1->isExact())
3967 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003968 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel878715f2017-05-15 19:27:53 +00003969
Sanjay Patel10494b22016-09-16 16:10:22 +00003970 case Instruction::Shl: {
3971 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap();
3972 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap();
3973 if (!NUW && !NSW)
3974 break;
3975 if (!NSW && I.isSigned())
3976 break;
Sanjay Patel2a062632017-05-08 16:33:42 +00003977 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0));
Sanjay Patel10494b22016-09-16 16:10:22 +00003978 }
3979 }
3980 }
3981
3982 if (BO0) {
3983 // Transform A & (L - 1) `ult` L --> L != 0
3984 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes());
Craig Topper72ee6942017-06-24 06:24:01 +00003985 auto BitwiseAnd = m_c_And(m_Value(), LSubOne);
Sanjay Patel10494b22016-09-16 16:10:22 +00003986
Sanjay Patel2a062632017-05-08 16:33:42 +00003987 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) {
Sanjay Patel10494b22016-09-16 16:10:22 +00003988 auto *Zero = Constant::getNullValue(BO0->getType());
3989 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero);
3990 }
3991 }
3992
Roman Lebedev473a0632019-08-29 12:47:20 +00003993 if (Value *V = foldUnsignedMultiplicationOverflowCheck(I))
Roman Lebedevfb38b7a2019-08-29 12:47:08 +00003994 return replaceInstUsesWith(I, V);
3995
Roman Lebedev68d54cf2018-07-11 19:05:04 +00003996 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder))
3997 return replaceInstUsesWith(I, V);
3998
Roman Lebedev3cb87e92018-07-18 10:55:17 +00003999 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder))
4000 return replaceInstUsesWith(I, V);
4001
Roman Lebedev72b8d412019-07-01 15:55:15 +00004002 if (Value *V = foldShiftIntoShiftInAnotherHandOfAndInICmp(I, SQ, Builder))
4003 return replaceInstUsesWith(I, V);
4004
Sanjay Patel10494b22016-09-16 16:10:22 +00004005 return nullptr;
4006}
4007
Sanjay Pateldd46b522016-12-19 17:32:37 +00004008/// Fold icmp Pred min|max(X, Y), X.
4009static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) {
Sanjay Pateld6406412016-12-15 19:13:37 +00004010 ICmpInst::Predicate Pred = Cmp.getPredicate();
4011 Value *Op0 = Cmp.getOperand(0);
4012 Value *X = Cmp.getOperand(1);
4013
Sanjay Pateldd46b522016-12-19 17:32:37 +00004014 // Canonicalize minimum or maximum operand to LHS of the icmp.
Sanjay Patel8296c6c2016-12-19 16:28:53 +00004015 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) ||
Sanjay Pateldd46b522016-12-19 17:32:37 +00004016 match(X, m_c_SMax(m_Specific(Op0), m_Value())) ||
4017 match(X, m_c_UMin(m_Specific(Op0), m_Value())) ||
4018 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) {
Sanjay Pateld6406412016-12-15 19:13:37 +00004019 std::swap(Op0, X);
4020 Pred = Cmp.getSwappedPredicate();
4021 }
4022
4023 Value *Y;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00004024 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00004025 // smin(X, Y) == X --> X s<= Y
4026 // smin(X, Y) s>= X --> X s<= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00004027 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE)
4028 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y);
4029
Sanjay Pateldd46b522016-12-19 17:32:37 +00004030 // smin(X, Y) != X --> X s> Y
4031 // smin(X, Y) s< X --> X s> Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00004032 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT)
4033 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y);
4034
4035 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00004036 // smin(X, Y) s<= X --> true
4037 // smin(X, Y) s> X --> false
Sanjay Pateld6406412016-12-15 19:13:37 +00004038 return nullptr;
Sanjay Patel8296c6c2016-12-19 16:28:53 +00004039 }
Sanjay Pateldd46b522016-12-19 17:32:37 +00004040
Sanjay Patel8296c6c2016-12-19 16:28:53 +00004041 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) {
Sanjay Pateldd46b522016-12-19 17:32:37 +00004042 // smax(X, Y) == X --> X s>= Y
4043 // smax(X, Y) s<= X --> X s>= Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00004044 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE)
4045 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00004046
Sanjay Pateldd46b522016-12-19 17:32:37 +00004047 // smax(X, Y) != X --> X s< Y
4048 // smax(X, Y) s> X --> X s< Y
Sanjay Patel8296c6c2016-12-19 16:28:53 +00004049 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT)
4050 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y);
Sanjay Pateld6406412016-12-15 19:13:37 +00004051
Sanjay Patel8296c6c2016-12-19 16:28:53 +00004052 // These cases should be handled in InstSimplify:
Sanjay Pateldd46b522016-12-19 17:32:37 +00004053 // smax(X, Y) s>= X --> true
4054 // smax(X, Y) s< X --> false
4055 return nullptr;
4056 }
4057
4058 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) {
4059 // umin(X, Y) == X --> X u<= Y
4060 // umin(X, Y) u>= X --> X u<= Y
4061 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE)
4062 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y);
4063
4064 // umin(X, Y) != X --> X u> Y
4065 // umin(X, Y) u< X --> X u> Y
4066 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT)
4067 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y);
4068
4069 // These cases should be handled in InstSimplify:
4070 // umin(X, Y) u<= X --> true
4071 // umin(X, Y) u> X --> false
4072 return nullptr;
4073 }
4074
4075 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) {
4076 // umax(X, Y) == X --> X u>= Y
4077 // umax(X, Y) u<= X --> X u>= Y
4078 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE)
4079 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y);
4080
4081 // umax(X, Y) != X --> X u< Y
4082 // umax(X, Y) u> X --> X u< Y
4083 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT)
4084 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y);
4085
4086 // These cases should be handled in InstSimplify:
4087 // umax(X, Y) u>= X --> true
4088 // umax(X, Y) u< X --> false
Sanjay Patel8296c6c2016-12-19 16:28:53 +00004089 return nullptr;
4090 }
Sanjay Pateld6406412016-12-15 19:13:37 +00004091
Sanjay Pateld6406412016-12-15 19:13:37 +00004092 return nullptr;
4093}
4094
Sanjay Patel10494b22016-09-16 16:10:22 +00004095Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) {
4096 if (!I.isEquality())
4097 return nullptr;
4098
4099 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel4e96f192017-06-28 16:39:06 +00004100 const CmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel10494b22016-09-16 16:10:22 +00004101 Value *A, *B, *C, *D;
4102 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) {
4103 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0
4104 Value *OtherVal = A == Op1 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00004105 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00004106 }
4107
4108 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) {
4109 // A^c1 == C^c2 --> A == C^(c1^c2)
4110 ConstantInt *C1, *C2;
4111 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) &&
4112 Op1->hasOneUse()) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004113 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue());
4114 Value *Xor = Builder.CreateXor(C, NC);
Sanjay Patel4e96f192017-06-28 16:39:06 +00004115 return new ICmpInst(Pred, A, Xor);
Sanjay Patel10494b22016-09-16 16:10:22 +00004116 }
4117
4118 // A^B == A^D -> B == D
4119 if (A == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00004120 return new ICmpInst(Pred, B, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00004121 if (A == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00004122 return new ICmpInst(Pred, B, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00004123 if (B == C)
Sanjay Patel4e96f192017-06-28 16:39:06 +00004124 return new ICmpInst(Pred, A, D);
Sanjay Patel10494b22016-09-16 16:10:22 +00004125 if (B == D)
Sanjay Patel4e96f192017-06-28 16:39:06 +00004126 return new ICmpInst(Pred, A, C);
Sanjay Patel10494b22016-09-16 16:10:22 +00004127 }
4128 }
4129
4130 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) {
4131 // A == (A^B) -> B == 0
4132 Value *OtherVal = A == Op0 ? B : A;
Sanjay Patel4e96f192017-06-28 16:39:06 +00004133 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00004134 }
4135
4136 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0
4137 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) &&
4138 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) {
4139 Value *X = nullptr, *Y = nullptr, *Z = nullptr;
4140
4141 if (A == C) {
4142 X = B;
4143 Y = D;
4144 Z = A;
4145 } else if (A == D) {
4146 X = B;
4147 Y = C;
4148 Z = A;
4149 } else if (B == C) {
4150 X = A;
4151 Y = D;
4152 Z = B;
4153 } else if (B == D) {
4154 X = A;
4155 Y = C;
4156 Z = B;
4157 }
4158
4159 if (X) { // Build (X^Y) & Z
Craig Topperbb4069e2017-07-07 23:16:26 +00004160 Op1 = Builder.CreateXor(X, Y);
4161 Op1 = Builder.CreateAnd(Op1, Z);
Sanjay Patel10494b22016-09-16 16:10:22 +00004162 I.setOperand(0, Op1);
4163 I.setOperand(1, Constant::getNullValue(Op1->getType()));
4164 return &I;
4165 }
4166 }
4167
4168 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B)
4169 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B)
4170 ConstantInt *Cst1;
4171 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) &&
4172 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) ||
4173 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) &&
4174 match(Op1, m_ZExt(m_Value(A))))) {
4175 APInt Pow2 = Cst1->getValue() + 1;
4176 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) &&
4177 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth())
Craig Topperbb4069e2017-07-07 23:16:26 +00004178 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00004179 }
4180
4181 // (A >> C) == (B >> C) --> (A^B) u< (1 << C)
4182 // For lshr and ashr pairs.
4183 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) &&
4184 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) ||
4185 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) &&
4186 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) {
4187 unsigned TypeBits = Cst1->getBitWidth();
4188 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
4189 if (ShAmt < TypeBits && ShAmt != 0) {
Sanjay Patel4e96f192017-06-28 16:39:06 +00004190 ICmpInst::Predicate NewPred =
4191 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT;
Craig Topperbb4069e2017-07-07 23:16:26 +00004192 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00004193 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00004194 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal));
Sanjay Patel10494b22016-09-16 16:10:22 +00004195 }
4196 }
4197
4198 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0
4199 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) &&
4200 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) {
4201 unsigned TypeBits = Cst1->getBitWidth();
4202 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits);
4203 if (ShAmt < TypeBits && ShAmt != 0) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004204 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted");
Sanjay Patel10494b22016-09-16 16:10:22 +00004205 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt);
Craig Topperbb4069e2017-07-07 23:16:26 +00004206 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal),
Sanjay Patel10494b22016-09-16 16:10:22 +00004207 I.getName() + ".mask");
Sanjay Patel4e96f192017-06-28 16:39:06 +00004208 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType()));
Sanjay Patel10494b22016-09-16 16:10:22 +00004209 }
4210 }
4211
4212 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to
4213 // "icmp (and X, mask), cst"
4214 uint64_t ShAmt = 0;
4215 if (Op0->hasOneUse() &&
4216 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) &&
4217 match(Op1, m_ConstantInt(Cst1)) &&
4218 // Only do this when A has multiple uses. This is most important to do
4219 // when it exposes other optimizations.
4220 !A->hasOneUse()) {
4221 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits();
4222
4223 if (ShAmt < ASize) {
4224 APInt MaskV =
4225 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits());
4226 MaskV <<= ShAmt;
4227
4228 APInt CmpV = Cst1->getValue().zext(ASize);
4229 CmpV <<= ShAmt;
4230
Craig Topperbb4069e2017-07-07 23:16:26 +00004231 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV));
4232 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV));
Sanjay Patel10494b22016-09-16 16:10:22 +00004233 }
4234 }
4235
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00004236 // If both operands are byte-swapped or bit-reversed, just compare the
4237 // original values.
4238 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant()
4239 // and handle more intrinsics.
4240 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) ||
Simon Pilgrimdf2657a2017-07-02 16:31:16 +00004241 (match(Op0, m_BitReverse(m_Value(A))) &&
4242 match(Op1, m_BitReverse(m_Value(B)))))
Sanjay Patelc3d5cf02017-07-02 14:34:50 +00004243 return new ICmpInst(Pred, A, B);
4244
Sanjay Patel63311bf2019-06-20 17:41:15 +00004245 // Canonicalize checking for a power-of-2-or-zero value:
Sanjay Patelddc1b402019-07-01 22:00:00 +00004246 // (A & (A-1)) == 0 --> ctpop(A) < 2 (two commuted variants)
4247 // ((A-1) & A) != 0 --> ctpop(A) > 1 (two commuted variants)
4248 if (!match(Op0, m_OneUse(m_c_And(m_Add(m_Value(A), m_AllOnes()),
4249 m_Deferred(A)))) ||
4250 !match(Op1, m_ZeroInt()))
4251 A = nullptr;
4252
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004253 // (A & -A) == A --> ctpop(A) < 2 (four commuted variants)
4254 // (-A & A) != A --> ctpop(A) > 1 (four commuted variants)
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004255 if (match(Op0, m_OneUse(m_c_And(m_Neg(m_Specific(Op1)), m_Specific(Op1)))))
Sanjay Patel63311bf2019-06-20 17:41:15 +00004256 A = Op1;
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004257 else if (match(Op1,
4258 m_OneUse(m_c_And(m_Neg(m_Specific(Op0)), m_Specific(Op0)))))
Sanjay Patel63311bf2019-06-20 17:41:15 +00004259 A = Op0;
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004260
Sanjay Patel63311bf2019-06-20 17:41:15 +00004261 if (A) {
4262 Type *Ty = A->getType();
Sanjay Patelfcfa0562019-06-25 18:51:44 +00004263 CallInst *CtPop = Builder.CreateUnaryIntrinsic(Intrinsic::ctpop, A);
4264 return Pred == ICmpInst::ICMP_EQ
4265 ? new ICmpInst(ICmpInst::ICMP_ULT, CtPop, ConstantInt::get(Ty, 2))
4266 : new ICmpInst(ICmpInst::ICMP_UGT, CtPop, ConstantInt::get(Ty, 1));
Sanjay Patel63311bf2019-06-20 17:41:15 +00004267 }
4268
Sanjay Patel10494b22016-09-16 16:10:22 +00004269 return nullptr;
4270}
4271
Sanjay Patele7282592019-08-21 11:56:08 +00004272static Instruction *foldICmpWithZextOrSext(ICmpInst &ICmp,
4273 InstCombiner::BuilderTy &Builder) {
Sanjay Patel292b1082019-08-20 18:15:17 +00004274 assert(isa<CastInst>(ICmp.getOperand(0)) && "Expected cast for operand 0");
4275 auto *CastOp0 = cast<CastInst>(ICmp.getOperand(0));
4276 Value *X;
4277 if (!match(CastOp0, m_ZExtOrSExt(m_Value(X))))
4278 return nullptr;
4279
4280 bool IsSignedExt = CastOp0->getOpcode() == Instruction::SExt;
4281 bool IsSignedCmp = ICmp.isSigned();
4282 if (auto *CastOp1 = dyn_cast<CastInst>(ICmp.getOperand(1))) {
4283 // If the signedness of the two casts doesn't agree (i.e. one is a sext
4284 // and the other is a zext), then we can't handle this.
Sanjay Patele7282592019-08-21 11:56:08 +00004285 // TODO: This is too strict. We can handle some predicates (equality?).
Sanjay Patel292b1082019-08-20 18:15:17 +00004286 if (CastOp0->getOpcode() != CastOp1->getOpcode())
4287 return nullptr;
4288
4289 // Not an extension from the same type?
Sanjay Patel292b1082019-08-20 18:15:17 +00004290 Value *Y = CastOp1->getOperand(0);
Sanjay Patele7282592019-08-21 11:56:08 +00004291 Type *XTy = X->getType(), *YTy = Y->getType();
4292 if (XTy != YTy) {
4293 // One of the casts must have one use because we are creating a new cast.
4294 if (!CastOp0->hasOneUse() && !CastOp1->hasOneUse())
4295 return nullptr;
4296 // Extend the narrower operand to the type of the wider operand.
4297 if (XTy->getScalarSizeInBits() < YTy->getScalarSizeInBits())
4298 X = Builder.CreateCast(CastOp0->getOpcode(), X, YTy);
4299 else if (YTy->getScalarSizeInBits() < XTy->getScalarSizeInBits())
4300 Y = Builder.CreateCast(CastOp0->getOpcode(), Y, XTy);
4301 else
4302 return nullptr;
4303 }
Sanjay Patel292b1082019-08-20 18:15:17 +00004304
4305 // (zext X) == (zext Y) --> X == Y
4306 // (sext X) == (sext Y) --> X == Y
4307 if (ICmp.isEquality())
4308 return new ICmpInst(ICmp.getPredicate(), X, Y);
4309
4310 // A signed comparison of sign extended values simplifies into a
4311 // signed comparison.
4312 if (IsSignedCmp && IsSignedExt)
4313 return new ICmpInst(ICmp.getPredicate(), X, Y);
4314
4315 // The other three cases all fold into an unsigned comparison.
4316 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Y);
4317 }
4318
4319 // Below here, we are only folding a compare with constant.
4320 auto *C = dyn_cast<Constant>(ICmp.getOperand(1));
4321 if (!C)
4322 return nullptr;
4323
4324 // Compute the constant that would happen if we truncated to SrcTy then
4325 // re-extended to DestTy.
4326 Type *SrcTy = CastOp0->getSrcTy();
4327 Type *DestTy = CastOp0->getDestTy();
4328 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy);
4329 Constant *Res2 = ConstantExpr::getCast(CastOp0->getOpcode(), Res1, DestTy);
4330
4331 // If the re-extended constant didn't change...
4332 if (Res2 == C) {
4333 if (ICmp.isEquality())
4334 return new ICmpInst(ICmp.getPredicate(), X, Res1);
4335
4336 // A signed comparison of sign extended values simplifies into a
4337 // signed comparison.
4338 if (IsSignedExt && IsSignedCmp)
4339 return new ICmpInst(ICmp.getPredicate(), X, Res1);
4340
4341 // The other three cases all fold into an unsigned comparison.
4342 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Res1);
4343 }
4344
4345 // The re-extended constant changed, partly changed (in the case of a vector),
4346 // or could not be determined to be equal (in the case of a constant
4347 // expression), so the constant cannot be represented in the shorter type.
4348 // All the cases that fold to true or false will have already been handled
4349 // by SimplifyICmpInst, so only deal with the tricky case.
4350 if (IsSignedCmp || !IsSignedExt || !isa<ConstantInt>(C))
4351 return nullptr;
4352
4353 // Is source op positive?
4354 // icmp ult (sext X), C --> icmp sgt X, -1
4355 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT)
4356 return new ICmpInst(CmpInst::ICMP_SGT, X, Constant::getAllOnesValue(SrcTy));
4357
4358 // Is source op negative?
4359 // icmp ugt (sext X), C --> icmp slt X, 0
4360 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!");
4361 return new ICmpInst(CmpInst::ICMP_SLT, X, Constant::getNullValue(SrcTy));
4362}
4363
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004364/// Handle icmp (cast x), (cast or constant).
4365Instruction *InstCombiner::foldICmpWithCastOp(ICmpInst &ICmp) {
4366 auto *CastOp0 = dyn_cast<CastInst>(ICmp.getOperand(0));
4367 if (!CastOp0)
4368 return nullptr;
4369 if (!isa<Constant>(ICmp.getOperand(1)) && !isa<CastInst>(ICmp.getOperand(1)))
4370 return nullptr;
4371
4372 Value *Op0Src = CastOp0->getOperand(0);
4373 Type *SrcTy = CastOp0->getSrcTy();
4374 Type *DestTy = CastOp0->getDestTy();
Chris Lattner2188e402010-01-04 07:37:31 +00004375
Jim Grosbach129c52a2011-09-30 18:09:53 +00004376 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the
Chris Lattner2188e402010-01-04 07:37:31 +00004377 // integer type is the same size as the pointer type.
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004378 auto CompatibleSizes = [&](Type *SrcTy, Type *DestTy) {
Daniel Neilsonbdda1152018-03-05 18:05:51 +00004379 if (isa<VectorType>(SrcTy)) {
4380 SrcTy = cast<VectorType>(SrcTy)->getElementType();
4381 DestTy = cast<VectorType>(DestTy)->getElementType();
4382 }
4383 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth();
4384 };
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004385 if (CastOp0->getOpcode() == Instruction::PtrToInt &&
Daniel Neilsonbdda1152018-03-05 18:05:51 +00004386 CompatibleSizes(SrcTy, DestTy)) {
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004387 Value *NewOp1 = nullptr;
4388 if (auto *PtrToIntOp1 = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) {
4389 Value *PtrSrc = PtrToIntOp1->getOperand(0);
4390 if (PtrSrc->getType()->getPointerAddressSpace() ==
4391 Op0Src->getType()->getPointerAddressSpace()) {
4392 NewOp1 = PtrToIntOp1->getOperand(0);
Michael Liaod266b922015-02-13 04:51:26 +00004393 // If the pointer types don't match, insert a bitcast.
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004394 if (Op0Src->getType() != NewOp1->getType())
4395 NewOp1 = Builder.CreateBitCast(NewOp1, Op0Src->getType());
Michael Liaod266b922015-02-13 04:51:26 +00004396 }
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004397 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) {
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004398 NewOp1 = ConstantExpr::getIntToPtr(RHSC, SrcTy);
Sanjay Patel6f8f47b2016-06-05 00:12:32 +00004399 }
Chris Lattner2188e402010-01-04 07:37:31 +00004400
Sanjay Patela90ee0e2019-08-20 14:56:44 +00004401 if (NewOp1)
4402 return new ICmpInst(ICmp.getPredicate(), Op0Src, NewOp1);
Chris Lattner2188e402010-01-04 07:37:31 +00004403 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00004404
Sanjay Patele7282592019-08-21 11:56:08 +00004405 return foldICmpWithZextOrSext(ICmp, Builder);
Chris Lattner2188e402010-01-04 07:37:31 +00004406}
4407
Nikita Popov39f2beb2019-05-26 11:43:37 +00004408static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) {
4409 switch (BinaryOp) {
4410 default:
4411 llvm_unreachable("Unsupported binary op");
4412 case Instruction::Add:
4413 case Instruction::Sub:
4414 return match(RHS, m_Zero());
4415 case Instruction::Mul:
4416 return match(RHS, m_One());
4417 }
4418}
4419
4420OverflowResult InstCombiner::computeOverflow(
4421 Instruction::BinaryOps BinaryOp, bool IsSigned,
4422 Value *LHS, Value *RHS, Instruction *CxtI) const {
4423 switch (BinaryOp) {
4424 default:
4425 llvm_unreachable("Unsupported binary op");
4426 case Instruction::Add:
4427 if (IsSigned)
4428 return computeOverflowForSignedAdd(LHS, RHS, CxtI);
4429 else
4430 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI);
4431 case Instruction::Sub:
4432 if (IsSigned)
4433 return computeOverflowForSignedSub(LHS, RHS, CxtI);
4434 else
4435 return computeOverflowForUnsignedSub(LHS, RHS, CxtI);
4436 case Instruction::Mul:
4437 if (IsSigned)
4438 return computeOverflowForSignedMul(LHS, RHS, CxtI);
4439 else
4440 return computeOverflowForUnsignedMul(LHS, RHS, CxtI);
4441 }
4442}
4443
Nikita Popov352f5982019-05-26 11:43:31 +00004444bool InstCombiner::OptimizeOverflowCheck(
4445 Instruction::BinaryOps BinaryOp, bool IsSigned, Value *LHS, Value *RHS,
4446 Instruction &OrigI, Value *&Result, Constant *&Overflow) {
Sanjoy Das827529e2015-08-11 21:33:55 +00004447 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS))
4448 std::swap(LHS, RHS);
Sanjoy Dasb0984472015-04-08 04:27:22 +00004449
Sanjoy Das6f5dca72015-08-28 19:09:31 +00004450 // If the overflow check was an add followed by a compare, the insertion point
4451 // may be pointing to the compare. We want to insert the new instructions
4452 // before the add in case there are uses of the add between the add and the
4453 // compare.
Craig Topperbb4069e2017-07-07 23:16:26 +00004454 Builder.SetInsertPoint(&OrigI);
Sanjoy Das6f5dca72015-08-28 19:09:31 +00004455
Nikita Popov39f2beb2019-05-26 11:43:37 +00004456 if (isNeutralValue(BinaryOp, RHS)) {
4457 Result = LHS;
4458 Overflow = Builder.getFalse();
4459 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00004460 }
4461
Nikita Popov39f2beb2019-05-26 11:43:37 +00004462 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) {
4463 case OverflowResult::MayOverflow:
4464 return false;
Nikita Popov332c1002019-05-28 18:08:31 +00004465 case OverflowResult::AlwaysOverflowsLow:
4466 case OverflowResult::AlwaysOverflowsHigh:
Nikita Popov39f2beb2019-05-26 11:43:37 +00004467 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4468 Result->takeName(&OrigI);
4469 Overflow = Builder.getTrue();
4470 return true;
4471 case OverflowResult::NeverOverflows:
4472 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS);
4473 Result->takeName(&OrigI);
4474 Overflow = Builder.getFalse();
4475 if (auto *Inst = dyn_cast<Instruction>(Result)) {
4476 if (IsSigned)
4477 Inst->setHasNoSignedWrap();
4478 else
4479 Inst->setHasNoUnsignedWrap();
4480 }
4481 return true;
Sanjoy Dasb0984472015-04-08 04:27:22 +00004482 }
4483
Nikita Popov39f2beb2019-05-26 11:43:37 +00004484 llvm_unreachable("Unexpected overflow result");
Sanjoy Dasb0984472015-04-08 04:27:22 +00004485}
4486
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004487/// Recognize and process idiom involving test for multiplication
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004488/// overflow.
4489///
4490/// The caller has matched a pattern of the form:
4491/// I = cmp u (mul(zext A, zext B), V
4492/// The function checks if this is a test for overflow and if so replaces
4493/// multiplication with call to 'mul.with.overflow' intrinsic.
4494///
4495/// \param I Compare instruction.
4496/// \param MulVal Result of 'mult' instruction. It is one of the arguments of
4497/// the compare instruction. Must be of integer type.
4498/// \param OtherVal The other argument of compare instruction.
4499/// \returns Instruction which must replace the compare instruction, NULL if no
4500/// replacement required.
Sanjay Pateld93c4c02016-09-15 18:22:25 +00004501static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal,
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004502 Value *OtherVal, InstCombiner &IC) {
Benjamin Kramerc96a7f82014-06-24 10:47:52 +00004503 // Don't bother doing this transformation for pointers, don't do it for
4504 // vectors.
4505 if (!isa<IntegerType>(MulVal->getType()))
4506 return nullptr;
4507
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004508 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal);
4509 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal);
David Majnemerdaa24b92015-09-05 20:44:56 +00004510 auto *MulInstr = dyn_cast<Instruction>(MulVal);
4511 if (!MulInstr)
4512 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004513 assert(MulInstr->getOpcode() == Instruction::Mul);
4514
David Majnemer634ca232014-11-01 23:46:05 +00004515 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)),
4516 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004517 assert(LHS->getOpcode() == Instruction::ZExt);
4518 assert(RHS->getOpcode() == Instruction::ZExt);
4519 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0);
4520
4521 // Calculate type and width of the result produced by mul.with.overflow.
4522 Type *TyA = A->getType(), *TyB = B->getType();
4523 unsigned WidthA = TyA->getPrimitiveSizeInBits(),
4524 WidthB = TyB->getPrimitiveSizeInBits();
4525 unsigned MulWidth;
4526 Type *MulType;
4527 if (WidthB > WidthA) {
4528 MulWidth = WidthB;
4529 MulType = TyB;
4530 } else {
4531 MulWidth = WidthA;
4532 MulType = TyA;
4533 }
4534
4535 // In order to replace the original mul with a narrower mul.with.overflow,
4536 // all uses must ignore upper bits of the product. The number of used low
4537 // bits must be not greater than the width of mul.with.overflow.
4538 if (MulVal->hasNUsesOrMore(2))
4539 for (User *U : MulVal->users()) {
4540 if (U == &I)
4541 continue;
4542 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4543 // Check if truncation ignores bits above MulWidth.
4544 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits();
4545 if (TruncWidth > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004546 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004547 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4548 // Check if AND ignores bits above MulWidth.
4549 if (BO->getOpcode() != Instruction::And)
Craig Topperf40110f2014-04-25 05:29:35 +00004550 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004551 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) {
4552 const APInt &CVal = CI->getValue();
4553 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth)
Craig Topperf40110f2014-04-25 05:29:35 +00004554 return nullptr;
Davide Italiano579064e2017-07-16 18:56:30 +00004555 } else {
4556 // In this case we could have the operand of the binary operation
4557 // being defined in another block, and performing the replacement
4558 // could break the dominance relation.
4559 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004560 }
4561 } else {
4562 // Other uses prohibit this transformation.
Craig Topperf40110f2014-04-25 05:29:35 +00004563 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004564 }
4565 }
4566
4567 // Recognize patterns
4568 switch (I.getPredicate()) {
4569 case ICmpInst::ICMP_EQ:
4570 case ICmpInst::ICMP_NE:
4571 // Recognize pattern:
4572 // mulval = mul(zext A, zext B)
4573 // cmp eq/neq mulval, zext trunc mulval
4574 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal))
4575 if (Zext->hasOneUse()) {
4576 Value *ZextArg = Zext->getOperand(0);
4577 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg))
4578 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth)
4579 break; //Recognized
4580 }
4581
4582 // Recognize pattern:
4583 // mulval = mul(zext A, zext B)
4584 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits.
4585 ConstantInt *CI;
4586 Value *ValToMask;
4587 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) {
4588 if (ValToMask != MulVal)
Craig Topperf40110f2014-04-25 05:29:35 +00004589 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004590 const APInt &CVal = CI->getValue() + 1;
4591 if (CVal.isPowerOf2()) {
4592 unsigned MaskWidth = CVal.logBase2();
4593 if (MaskWidth == MulWidth)
4594 break; // Recognized
4595 }
4596 }
Craig Topperf40110f2014-04-25 05:29:35 +00004597 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004598
4599 case ICmpInst::ICMP_UGT:
4600 // Recognize pattern:
4601 // mulval = mul(zext A, zext B)
4602 // cmp ugt mulval, max
4603 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4604 APInt MaxVal = APInt::getMaxValue(MulWidth);
4605 MaxVal = MaxVal.zext(CI->getBitWidth());
4606 if (MaxVal.eq(CI->getValue()))
4607 break; // Recognized
4608 }
Craig Topperf40110f2014-04-25 05:29:35 +00004609 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004610
4611 case ICmpInst::ICMP_UGE:
4612 // Recognize pattern:
4613 // mulval = mul(zext A, zext B)
4614 // cmp uge mulval, max+1
4615 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4616 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
4617 if (MaxVal.eq(CI->getValue()))
4618 break; // Recognized
4619 }
Craig Topperf40110f2014-04-25 05:29:35 +00004620 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004621
4622 case ICmpInst::ICMP_ULE:
4623 // Recognize pattern:
4624 // mulval = mul(zext A, zext B)
4625 // cmp ule mulval, max
4626 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
4627 APInt MaxVal = APInt::getMaxValue(MulWidth);
4628 MaxVal = MaxVal.zext(CI->getBitWidth());
4629 if (MaxVal.eq(CI->getValue()))
4630 break; // Recognized
4631 }
Craig Topperf40110f2014-04-25 05:29:35 +00004632 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004633
4634 case ICmpInst::ICMP_ULT:
4635 // Recognize pattern:
4636 // mulval = mul(zext A, zext B)
4637 // cmp ule mulval, max + 1
4638 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) {
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004639 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004640 if (MaxVal.eq(CI->getValue()))
4641 break; // Recognized
4642 }
Craig Topperf40110f2014-04-25 05:29:35 +00004643 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004644
4645 default:
Craig Topperf40110f2014-04-25 05:29:35 +00004646 return nullptr;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004647 }
4648
Craig Topperbb4069e2017-07-07 23:16:26 +00004649 InstCombiner::BuilderTy &Builder = IC.Builder;
4650 Builder.SetInsertPoint(MulInstr);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004651
4652 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B)
4653 Value *MulA = A, *MulB = B;
4654 if (WidthA < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004655 MulA = Builder.CreateZExt(A, MulType);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004656 if (WidthB < MulWidth)
Craig Topperbb4069e2017-07-07 23:16:26 +00004657 MulB = Builder.CreateZExt(B, MulType);
James Y Knight7976eb52019-02-01 20:43:25 +00004658 Function *F = Intrinsic::getDeclaration(
4659 I.getModule(), Intrinsic::umul_with_overflow, MulType);
Craig Topperbb4069e2017-07-07 23:16:26 +00004660 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul");
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004661 IC.Worklist.Add(MulInstr);
4662
4663 // If there are uses of mul result other than the comparison, we know that
4664 // they are truncation or binary AND. Change them to use result of
Serge Pavlovb5f3ddc2014-04-14 02:20:19 +00004665 // mul.with.overflow and adjust properly mask/size.
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004666 if (MulVal->hasNUsesOrMore(2)) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004667 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value");
Joseph Tremoulet6f406d42018-06-15 16:52:40 +00004668 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) {
4669 User *U = *UI++;
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004670 if (U == &I || U == OtherVal)
4671 continue;
4672 if (TruncInst *TI = dyn_cast<TruncInst>(U)) {
4673 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth)
Sanjay Patel4b198802016-02-01 22:23:39 +00004674 IC.replaceInstUsesWith(*TI, Mul);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004675 else
4676 TI->setOperand(0, Mul);
4677 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) {
4678 assert(BO->getOpcode() == Instruction::And);
4679 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask)
Davide Italiano579064e2017-07-16 18:56:30 +00004680 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1));
4681 APInt ShortMask = CI->getValue().trunc(MulWidth);
Craig Topperbb4069e2017-07-07 23:16:26 +00004682 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask);
Davide Italiano579064e2017-07-16 18:56:30 +00004683 Instruction *Zext =
4684 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType()));
4685 IC.Worklist.Add(Zext);
Sanjay Patel4b198802016-02-01 22:23:39 +00004686 IC.replaceInstUsesWith(*BO, Zext);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004687 } else {
4688 llvm_unreachable("Unexpected Binary operation");
4689 }
Davide Italiano579064e2017-07-16 18:56:30 +00004690 IC.Worklist.Add(cast<Instruction>(U));
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004691 }
4692 }
4693 if (isa<Instruction>(OtherVal))
4694 IC.Worklist.Add(cast<Instruction>(OtherVal));
4695
4696 // The original icmp gets replaced with the overflow value, maybe inverted
4697 // depending on predicate.
4698 bool Inverse = false;
4699 switch (I.getPredicate()) {
4700 case ICmpInst::ICMP_NE:
4701 break;
4702 case ICmpInst::ICMP_EQ:
4703 Inverse = true;
4704 break;
4705 case ICmpInst::ICMP_UGT:
4706 case ICmpInst::ICMP_UGE:
4707 if (I.getOperand(0) == MulVal)
4708 break;
4709 Inverse = true;
4710 break;
4711 case ICmpInst::ICMP_ULT:
4712 case ICmpInst::ICMP_ULE:
4713 if (I.getOperand(1) == MulVal)
4714 break;
4715 Inverse = true;
4716 break;
4717 default:
4718 llvm_unreachable("Unexpected predicate");
4719 }
4720 if (Inverse) {
Craig Topperbb4069e2017-07-07 23:16:26 +00004721 Value *Res = Builder.CreateExtractValue(Call, 1);
Serge Pavlov4bb54d52014-04-13 18:23:41 +00004722 return BinaryOperator::CreateNot(Res);
4723 }
4724
4725 return ExtractValueInst::Create(Call, 1);
4726}
4727
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004728/// When performing a comparison against a constant, it is possible that not all
4729/// the bits in the LHS are demanded. This helper method computes the mask that
4730/// IS demanded.
Craig Topper3edda872017-09-22 18:57:23 +00004731static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) {
Craig Topper18887bf2017-09-20 23:48:58 +00004732 const APInt *RHS;
4733 if (!match(I.getOperand(1), m_APInt(RHS)))
4734 return APInt::getAllOnesValue(BitWidth);
Jim Grosbach129c52a2011-09-30 18:09:53 +00004735
Craig Topper3edda872017-09-22 18:57:23 +00004736 // If this is a normal comparison, it demands all bits. If it is a sign bit
4737 // comparison, it only demands the sign bit.
4738 bool UnusedBit;
4739 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit))
4740 return APInt::getSignMask(BitWidth);
4741
Owen Andersond490c2d2011-01-11 00:36:45 +00004742 switch (I.getPredicate()) {
Jim Grosbach129c52a2011-09-30 18:09:53 +00004743 // For a UGT comparison, we don't care about any bits that
Owen Andersond490c2d2011-01-11 00:36:45 +00004744 // correspond to the trailing ones of the comparand. The value of these
4745 // bits doesn't impact the outcome of the comparison, because any value
4746 // greater than the RHS must differ in a bit higher than these due to carry.
Craig Topper18887bf2017-09-20 23:48:58 +00004747 case ICmpInst::ICMP_UGT:
4748 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004749
Owen Andersond490c2d2011-01-11 00:36:45 +00004750 // Similarly, for a ULT comparison, we don't care about the trailing zeros.
4751 // Any value less than the RHS must differ in a higher bit because of carries.
Craig Topper18887bf2017-09-20 23:48:58 +00004752 case ICmpInst::ICMP_ULT:
4753 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros());
Jim Grosbach129c52a2011-09-30 18:09:53 +00004754
Owen Andersond490c2d2011-01-11 00:36:45 +00004755 default:
4756 return APInt::getAllOnesValue(BitWidth);
4757 }
Owen Andersond490c2d2011-01-11 00:36:45 +00004758}
Chris Lattner2188e402010-01-04 07:37:31 +00004759
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004760/// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst
Quentin Colombet5ab55552013-09-09 20:56:48 +00004761/// should be swapped.
Alp Tokercb402912014-01-24 17:20:08 +00004762/// The decision is based on how many times these two operands are reused
Quentin Colombet5ab55552013-09-09 20:56:48 +00004763/// as subtract operands and their positions in those instructions.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004764/// The rationale is that several architectures use the same instruction for
4765/// both subtract and cmp. Thus, it is better if the order of those operands
Quentin Colombet5ab55552013-09-09 20:56:48 +00004766/// match.
4767/// \return true if Op0 and Op1 should be swapped.
Sanjay Patel4ccae1c2018-02-02 18:39:05 +00004768static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) {
4769 // Filter out pointer values as those cannot appear directly in subtract.
Quentin Colombet5ab55552013-09-09 20:56:48 +00004770 // FIXME: we may want to go through inttoptrs or bitcasts.
4771 if (Op0->getType()->isPointerTy())
4772 return false;
Sanjay Patel1ea86972018-02-02 19:08:12 +00004773 // If a subtract already has the same operands as a compare, swapping would be
4774 // bad. If a subtract has the same operands as a compare but in reverse order,
4775 // then swapping is good.
4776 int GoodToSwap = 0;
Chandler Carruthcdf47882014-03-09 03:16:01 +00004777 for (const User *U : Op0->users()) {
Sanjay Patel1ea86972018-02-02 19:08:12 +00004778 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0))))
4779 GoodToSwap++;
4780 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1))))
4781 GoodToSwap--;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004782 }
Sanjay Patel1ea86972018-02-02 19:08:12 +00004783 return GoodToSwap > 0;
Quentin Colombet5ab55552013-09-09 20:56:48 +00004784}
4785
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004786/// Check that one use is in the same block as the definition and all
Sanjay Patel53523312016-09-12 14:25:46 +00004787/// other uses are in blocks dominated by a given block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004788///
4789/// \param DI Definition
4790/// \param UI Use
4791/// \param DB Block that must dominate all uses of \p DI outside
4792/// the parent block
4793/// \return true when \p UI is the only use of \p DI in the parent block
4794/// and all other uses of \p DI are in blocks dominated by \p DB.
4795///
4796bool InstCombiner::dominatesAllUses(const Instruction *DI,
4797 const Instruction *UI,
4798 const BasicBlock *DB) const {
4799 assert(DI && UI && "Instruction not defined\n");
Sanjay Patel53523312016-09-12 14:25:46 +00004800 // Ignore incomplete definitions.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004801 if (!DI->getParent())
4802 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004803 // DI and UI must be in the same block.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004804 if (DI->getParent() != UI->getParent())
4805 return false;
Sanjay Patel53523312016-09-12 14:25:46 +00004806 // Protect from self-referencing blocks.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004807 if (DI->getParent() == DB)
4808 return false;
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004809 for (const User *U : DI->users()) {
4810 auto *Usr = cast<Instruction>(U);
Justin Bogner99798402016-08-05 01:06:44 +00004811 if (Usr != UI && !DT.dominates(DB, Usr->getParent()))
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004812 return false;
4813 }
4814 return true;
4815}
4816
Sanjay Patel5f0217f2016-06-05 16:46:18 +00004817/// Return true when the instruction sequence within a block is select-cmp-br.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004818static bool isChainSelectCmpBranch(const SelectInst *SI) {
4819 const BasicBlock *BB = SI->getParent();
4820 if (!BB)
4821 return false;
4822 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator());
4823 if (!BI || BI->getNumSuccessors() != 2)
4824 return false;
4825 auto *IC = dyn_cast<ICmpInst>(BI->getCondition());
4826 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI))
4827 return false;
4828 return true;
4829}
4830
Adrian Prantl5f8f34e42018-05-01 15:54:18 +00004831/// True when a select result is replaced by one of its operands
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004832/// in select-icmp sequence. This will eventually result in the elimination
4833/// of the select.
4834///
4835/// \param SI Select instruction
4836/// \param Icmp Compare instruction
4837/// \param SIOpd Operand that replaces the select
4838///
4839/// Notes:
4840/// - The replacement is global and requires dominator information
4841/// - The caller is responsible for the actual replacement
4842///
4843/// Example:
4844///
4845/// entry:
4846/// %4 = select i1 %3, %C* %0, %C* null
4847/// %5 = icmp eq %C* %4, null
4848/// br i1 %5, label %9, label %7
4849/// ...
4850/// ; <label>:7 ; preds = %entry
4851/// %8 = getelementptr inbounds %C* %4, i64 0, i32 0
4852/// ...
4853///
4854/// can be transformed to
4855///
4856/// %5 = icmp eq %C* %0, null
4857/// %6 = select i1 %3, i1 %5, i1 true
4858/// br i1 %6, label %9, label %7
4859/// ...
4860/// ; <label>:7 ; preds = %entry
4861/// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0!
4862///
4863/// Similar when the first operand of the select is a constant or/and
4864/// the compare is for not equal rather than equal.
4865///
4866/// NOTE: The function is only called when the select and compare constants
4867/// are equal, the optimization can work only for EQ predicates. This is not a
4868/// major restriction since a NE compare should be 'normalized' to an equal
4869/// compare, which usually happens in the combiner and test case
Sanjay Patel53523312016-09-12 14:25:46 +00004870/// select-cmp-br.ll checks for it.
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004871bool InstCombiner::replacedSelectWithOperand(SelectInst *SI,
4872 const ICmpInst *Icmp,
4873 const unsigned SIOpd) {
David Majnemer83484fd2014-11-22 06:09:28 +00004874 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!");
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004875 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) {
4876 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1);
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004877 // The check for the single predecessor is not the best that can be
Sanjay Patel53523312016-09-12 14:25:46 +00004878 // done. But it protects efficiently against cases like when SI's
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004879 // home block has two successors, Succ and Succ1, and Succ1 predecessor
4880 // of Succ. Then SI can't be replaced by SIOpd because the use that gets
4881 // replaced can be reached on either path. So the uniqueness check
4882 // guarantees that the path all uses of SI (outside SI's parent) are on
4883 // is disjoint from all other paths out of SI. But that information
4884 // is more expensive to compute, and the trade-off here is in favor
Bjorn Petterssone5027cf2017-03-02 15:18:58 +00004885 // of compile-time. It should also be noticed that we check for a single
4886 // predecessor and not only uniqueness. This to handle the situation when
4887 // Succ and Succ1 points to the same basic block.
4888 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) {
Gerolf Hoflehnerec6217c2014-11-21 23:36:44 +00004889 NumSel++;
4890 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent());
4891 return true;
4892 }
4893 }
4894 return false;
4895}
4896
Sanjay Patel3151dec2016-09-12 15:24:31 +00004897/// Try to fold the comparison based on range information we can get by checking
4898/// whether bits are known to be zero or one in the inputs.
4899Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) {
4900 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
4901 Type *Ty = Op0->getType();
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004902 ICmpInst::Predicate Pred = I.getPredicate();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004903
4904 // Get scalar or pointer size.
4905 unsigned BitWidth = Ty->isIntOrIntVectorTy()
4906 ? Ty->getScalarSizeInBits()
Elena Demikhovsky945b7e52018-02-14 06:58:08 +00004907 : DL.getIndexTypeSizeInBits(Ty->getScalarType());
Sanjay Patel3151dec2016-09-12 15:24:31 +00004908
4909 if (!BitWidth)
4910 return nullptr;
4911
Craig Topperb45eabc2017-04-26 16:39:58 +00004912 KnownBits Op0Known(BitWidth);
4913 KnownBits Op1Known(BitWidth);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004914
Craig Topper47596dd2017-03-25 06:52:52 +00004915 if (SimplifyDemandedBits(&I, 0,
Craig Topper3edda872017-09-22 18:57:23 +00004916 getDemandedBitsLHSMask(I, BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004917 Op0Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004918 return &I;
4919
Craig Topper47596dd2017-03-25 06:52:52 +00004920 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth),
Craig Topperb45eabc2017-04-26 16:39:58 +00004921 Op1Known, 0))
Sanjay Patel3151dec2016-09-12 15:24:31 +00004922 return &I;
4923
4924 // Given the known and unknown bits, compute a range that the LHS could be
4925 // in. Compute the Min, Max and RHS values based on the known bits. For the
4926 // EQ and NE we use unsigned values.
4927 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0);
4928 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0);
4929 if (I.isSigned()) {
Craig Topperb45eabc2017-04-26 16:39:58 +00004930 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4931 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004932 } else {
Craig Topperb45eabc2017-04-26 16:39:58 +00004933 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max);
4934 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004935 }
4936
Sanjay Patelc63f9012018-01-04 14:31:56 +00004937 // If Min and Max are known to be the same, then SimplifyDemandedBits figured
4938 // out that the LHS or RHS is a constant. Constant fold this now, so that
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004939 // code below can assume that Min != Max.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004940 if (!isa<Constant>(Op0) && Op0Min == Op0Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004941 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004942 if (!isa<Constant>(Op1) && Op1Min == Op1Max)
Sanjay Patelc63f9012018-01-04 14:31:56 +00004943 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min));
Sanjay Patel3151dec2016-09-12 15:24:31 +00004944
4945 // Based on the range information we know about the LHS, see if we can
4946 // simplify this comparison. For example, (x&4) < 8 is always true.
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004947 switch (Pred) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004948 default:
4949 llvm_unreachable("Unknown icmp opcode!");
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004950 case ICmpInst::ICMP_EQ:
Sanjay Patel3151dec2016-09-12 15:24:31 +00004951 case ICmpInst::ICMP_NE: {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004952 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) {
4953 return Pred == CmpInst::ICMP_EQ
4954 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()))
4955 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
4956 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00004957
Sanjay Patel0531f0a2016-09-12 15:52:28 +00004958 // If all bits are known zero except for one, then we know at most one bit
4959 // is set. If the comparison is against zero, then this is a check to see if
4960 // *that* bit is set.
Craig Topperb45eabc2017-04-26 16:39:58 +00004961 APInt Op0KnownZeroInverted = ~Op0Known.Zero;
Craig Topperf0aeee02017-05-05 17:36:09 +00004962 if (Op1Known.isZero()) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00004963 // If the LHS is an AND with the same constant, look through it.
4964 Value *LHS = nullptr;
Sanjay Patel7577a3d2016-09-15 14:15:47 +00004965 const APInt *LHSC;
4966 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) ||
4967 *LHSC != Op0KnownZeroInverted)
Sanjay Patel3151dec2016-09-12 15:24:31 +00004968 LHS = Op0;
4969
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004970 Value *X;
Sanjay Patel3151dec2016-09-12 15:24:31 +00004971 if (match(LHS, m_Shl(m_One(), m_Value(X)))) {
4972 APInt ValToCheck = Op0KnownZeroInverted;
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004973 Type *XTy = X->getType();
Sanjay Patel3151dec2016-09-12 15:24:31 +00004974 if (ValToCheck.isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004975 // ((1 << X) & 8) == 0 -> X != 3
4976 // ((1 << X) & 8) != 0 -> X == 3
4977 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4978 auto NewPred = ICmpInst::getInversePredicate(Pred);
4979 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004980 } else if ((++ValToCheck).isPowerOf2()) {
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004981 // ((1 << X) & 7) == 0 -> X >= 3
4982 // ((1 << X) & 7) != 0 -> X < 3
4983 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros());
4984 auto NewPred =
4985 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT;
4986 return new ICmpInst(NewPred, X, CmpC);
Sanjay Patel3151dec2016-09-12 15:24:31 +00004987 }
4988 }
4989
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004990 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1.
Sanjay Patel3151dec2016-09-12 15:24:31 +00004991 const APInt *CI;
Craig Topper73ba1c82017-06-07 07:40:37 +00004992 if (Op0KnownZeroInverted.isOneValue() &&
Sanjay Patel9efb1bd2016-09-14 23:38:56 +00004993 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) {
4994 // ((8 >>u X) & 1) == 0 -> X != 3
4995 // ((8 >>u X) & 1) != 0 -> X == 3
4996 unsigned CmpVal = CI->countTrailingZeros();
4997 auto NewPred = ICmpInst::getInversePredicate(Pred);
4998 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal));
4999 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00005000 }
5001 break;
5002 }
5003 case ICmpInst::ICMP_ULT: {
5004 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B)
5005 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
5006 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B)
5007 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
5008 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B)
5009 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
5010
Craig Topper0cd25942017-09-27 22:57:18 +00005011 const APInt *CmpC;
5012 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00005013 // A <u C -> A == C-1 if min(A)+1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00005014 if (*CmpC == Op0Min + 1)
Craig Topper2c9b7d72017-09-22 18:57:20 +00005015 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00005016 ConstantInt::get(Op1->getType(), *CmpC - 1));
Craig Topper30dc9792017-09-25 21:15:00 +00005017 // X <u C --> X == 0, if the number of zero bits in the bottom of X
5018 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00005019 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2())
Craig Topper30dc9792017-09-25 21:15:00 +00005020 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
5021 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00005022 }
5023 break;
5024 }
5025 case ICmpInst::ICMP_UGT: {
5026 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B)
5027 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00005028 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B)
5029 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00005030 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B)
5031 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
5032
Craig Topper0cd25942017-09-27 22:57:18 +00005033 const APInt *CmpC;
5034 if (match(Op1, m_APInt(CmpC))) {
Sanjay Patel3151dec2016-09-12 15:24:31 +00005035 // A >u C -> A == C+1 if max(a)-1 == C
Craig Topper0cd25942017-09-27 22:57:18 +00005036 if (*CmpC == Op0Max - 1)
Sanjay Patel3151dec2016-09-12 15:24:31 +00005037 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00005038 ConstantInt::get(Op1->getType(), *CmpC + 1));
Craig Topper30dc9792017-09-25 21:15:00 +00005039 // X >u C --> X != 0, if the number of zero bits in the bottom of X
5040 // exceeds the log2 of C.
Craig Topper0cd25942017-09-27 22:57:18 +00005041 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits())
Craig Topper30dc9792017-09-25 21:15:00 +00005042 return new ICmpInst(ICmpInst::ICMP_NE, Op0,
5043 Constant::getNullValue(Op1->getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00005044 }
5045 break;
5046 }
Craig Topper0cd25942017-09-27 22:57:18 +00005047 case ICmpInst::ICMP_SLT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00005048 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C)
5049 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
5050 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C)
5051 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
5052 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B)
5053 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00005054 const APInt *CmpC;
5055 if (match(Op1, m_APInt(CmpC))) {
5056 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00005057 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00005058 ConstantInt::get(Op1->getType(), *CmpC - 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00005059 }
5060 break;
Craig Topper0cd25942017-09-27 22:57:18 +00005061 }
5062 case ICmpInst::ICMP_SGT: {
Sanjay Patel3151dec2016-09-12 15:24:31 +00005063 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B)
5064 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
5065 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B)
5066 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Sanjay Patel3151dec2016-09-12 15:24:31 +00005067 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B)
5068 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1);
Craig Topper0cd25942017-09-27 22:57:18 +00005069 const APInt *CmpC;
5070 if (match(Op1, m_APInt(CmpC))) {
5071 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C
Sanjay Patel3151dec2016-09-12 15:24:31 +00005072 return new ICmpInst(ICmpInst::ICMP_EQ, Op0,
Craig Topper0cd25942017-09-27 22:57:18 +00005073 ConstantInt::get(Op1->getType(), *CmpC + 1));
Sanjay Patel3151dec2016-09-12 15:24:31 +00005074 }
5075 break;
Craig Topper0cd25942017-09-27 22:57:18 +00005076 }
Sanjay Patel3151dec2016-09-12 15:24:31 +00005077 case ICmpInst::ICMP_SGE:
5078 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!");
5079 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B)
5080 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
5081 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B)
5082 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00005083 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B)
5084 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00005085 break;
5086 case ICmpInst::ICMP_SLE:
5087 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!");
5088 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B)
5089 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
5090 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B)
5091 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00005092 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B)
5093 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00005094 break;
5095 case ICmpInst::ICMP_UGE:
5096 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!");
5097 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B)
5098 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
5099 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B)
5100 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00005101 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B)
5102 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00005103 break;
5104 case ICmpInst::ICMP_ULE:
5105 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!");
5106 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B)
5107 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType()));
5108 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B)
5109 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType()));
Craig Topperea927ba2017-09-22 21:47:22 +00005110 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B)
5111 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1);
Sanjay Patel3151dec2016-09-12 15:24:31 +00005112 break;
5113 }
5114
5115 // Turn a signed comparison into an unsigned one if both operands are known to
5116 // have the same sign.
5117 if (I.isSigned() &&
Craig Topperb45eabc2017-04-26 16:39:58 +00005118 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) ||
5119 (Op0Known.One.isNegative() && Op1Known.One.isNegative())))
Sanjay Patel3151dec2016-09-12 15:24:31 +00005120 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1);
5121
5122 return nullptr;
5123}
5124
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005125llvm::Optional<std::pair<CmpInst::Predicate, Constant *>>
5126llvm::getFlippedStrictnessPredicateAndConstant(CmpInst::Predicate Pred,
5127 Constant *C) {
5128 assert(ICmpInst::isRelational(Pred) && ICmpInst::isIntPredicate(Pred) &&
Roman Lebedev2c75fe72019-08-24 06:49:25 +00005129 "Only for relational integer predicates.");
Sanjay Pateld5b0e542016-04-29 16:22:25 +00005130
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005131 Type *Type = C->getType();
5132 bool IsSigned = ICmpInst::isSigned(Pred);
Roman Lebedev2c75fe72019-08-24 06:49:25 +00005133
5134 CmpInst::Predicate UnsignedPred = ICmpInst::getUnsignedPredicate(Pred);
5135 bool WillIncrement =
5136 UnsignedPred == ICmpInst::ICMP_ULE || UnsignedPred == ICmpInst::ICMP_UGT;
5137
5138 // Check if the constant operand can be safely incremented/decremented
5139 // without overflowing/underflowing.
5140 auto ConstantIsOk = [WillIncrement, IsSigned](ConstantInt *C) {
5141 return WillIncrement ? !C->isMaxValue(IsSigned) : !C->isMinValue(IsSigned);
5142 };
5143
Bjorn Pettersson163c54d2019-09-26 12:16:01 +00005144 if (auto *CI = dyn_cast<ConstantInt>(C)) {
5145 // Bail out if the constant can't be safely incremented/decremented.
5146 if (!ConstantIsOk(CI))
5147 return llvm::None;
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005148 } else if (Type->isVectorTy()) {
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005149 unsigned NumElts = Type->getVectorNumElements();
Sanjay Patele9b2c322016-05-17 00:57:57 +00005150 for (unsigned i = 0; i != NumElts; ++i) {
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005151 Constant *Elt = C->getAggregateElement(i);
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00005152 if (!Elt)
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005153 return llvm::None;
Benjamin Kramerca9a0fe2016-05-17 12:08:55 +00005154
Sanjay Patele9b2c322016-05-17 00:57:57 +00005155 if (isa<UndefValue>(Elt))
5156 continue;
Sanjay Patel06b127a2016-09-15 14:37:50 +00005157
Sanjay Patele9b2c322016-05-17 00:57:57 +00005158 // Bail out if we can't determine if this constant is min/max or if we
5159 // know that this constant is min/max.
5160 auto *CI = dyn_cast<ConstantInt>(Elt);
Roman Lebedev2c75fe72019-08-24 06:49:25 +00005161 if (!CI || !ConstantIsOk(CI))
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005162 return llvm::None;
Sanjay Patelb79ab272016-05-13 15:10:46 +00005163 }
Sanjay Patele9b2c322016-05-17 00:57:57 +00005164 } else {
5165 // ConstantExpr?
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005166 return llvm::None;
Sanjay Patelb79ab272016-05-13 15:10:46 +00005167 }
Sanjay Pateld5b0e542016-04-29 16:22:25 +00005168
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005169 CmpInst::Predicate NewPred = CmpInst::getFlippedStrictnessPredicate(Pred);
5170
5171 // Increment or decrement the constant.
Roman Lebedev2c75fe72019-08-24 06:49:25 +00005172 Constant *OneOrNegOne = ConstantInt::get(Type, WillIncrement ? 1 : -1, true);
Roman Lebedev32f1e1a2019-08-14 09:57:20 +00005173 Constant *NewC = ConstantExpr::getAdd(C, OneOrNegOne);
5174
5175 return std::make_pair(NewPred, NewC);
5176}
5177
5178/// If we have an icmp le or icmp ge instruction with a constant operand, turn
5179/// it into the appropriate icmp lt or icmp gt instruction. This transform
5180/// allows them to be folded in visitICmpInst.
5181static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) {
5182 ICmpInst::Predicate Pred = I.getPredicate();
5183 if (ICmpInst::isEquality(Pred) || !ICmpInst::isIntPredicate(Pred) ||
5184 isCanonicalPredicate(Pred))
5185 return nullptr;
5186
5187 Value *Op0 = I.getOperand(0);
5188 Value *Op1 = I.getOperand(1);
5189 auto *Op1C = dyn_cast<Constant>(Op1);
5190 if (!Op1C)
5191 return nullptr;
5192
5193 auto FlippedStrictness = getFlippedStrictnessPredicateAndConstant(Pred, Op1C);
5194 if (!FlippedStrictness)
5195 return nullptr;
5196
5197 return new ICmpInst(FlippedStrictness->first, Op0, FlippedStrictness->second);
Sanjay Pateld5b0e542016-04-29 16:22:25 +00005198}
5199
Sanjay Patele5747e32017-05-17 22:15:07 +00005200/// Integer compare with boolean values can always be turned into bitwise ops.
5201static Instruction *canonicalizeICmpBool(ICmpInst &I,
5202 InstCombiner::BuilderTy &Builder) {
5203 Value *A = I.getOperand(0), *B = I.getOperand(1);
Craig Topperfde47232017-07-09 07:04:03 +00005204 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only");
Sanjay Patele5747e32017-05-17 22:15:07 +00005205
Sanjay Patelba212c22017-05-17 22:29:40 +00005206 // A boolean compared to true/false can be simplified to Op0/true/false in
5207 // 14 out of the 20 (10 predicates * 2 constants) possible combinations.
5208 // Cases not handled by InstSimplify are always 'not' of Op0.
5209 if (match(B, m_Zero())) {
5210 switch (I.getPredicate()) {
5211 case CmpInst::ICMP_EQ: // A == 0 -> !A
5212 case CmpInst::ICMP_ULE: // A <=u 0 -> !A
5213 case CmpInst::ICMP_SGE: // A >=s 0 -> !A
5214 return BinaryOperator::CreateNot(A);
5215 default:
5216 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
5217 }
5218 } else if (match(B, m_One())) {
5219 switch (I.getPredicate()) {
5220 case CmpInst::ICMP_NE: // A != 1 -> !A
5221 case CmpInst::ICMP_ULT: // A <u 1 -> !A
5222 case CmpInst::ICMP_SGT: // A >s -1 -> !A
5223 return BinaryOperator::CreateNot(A);
5224 default:
5225 llvm_unreachable("ICmp i1 X, C not simplified as expected.");
5226 }
5227 }
5228
Sanjay Patele5747e32017-05-17 22:15:07 +00005229 switch (I.getPredicate()) {
5230 default:
5231 llvm_unreachable("Invalid icmp instruction!");
5232 case ICmpInst::ICMP_EQ:
5233 // icmp eq i1 A, B -> ~(A ^ B)
5234 return BinaryOperator::CreateNot(Builder.CreateXor(A, B));
5235
5236 case ICmpInst::ICMP_NE:
5237 // icmp ne i1 A, B -> A ^ B
5238 return BinaryOperator::CreateXor(A, B);
5239
5240 case ICmpInst::ICMP_UGT:
5241 // icmp ugt -> icmp ult
5242 std::swap(A, B);
5243 LLVM_FALLTHROUGH;
5244 case ICmpInst::ICMP_ULT:
5245 // icmp ult i1 A, B -> ~A & B
5246 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B);
5247
5248 case ICmpInst::ICMP_SGT:
5249 // icmp sgt -> icmp slt
5250 std::swap(A, B);
5251 LLVM_FALLTHROUGH;
5252 case ICmpInst::ICMP_SLT:
5253 // icmp slt i1 A, B -> A & ~B
5254 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A);
5255
5256 case ICmpInst::ICMP_UGE:
5257 // icmp uge -> icmp ule
5258 std::swap(A, B);
5259 LLVM_FALLTHROUGH;
5260 case ICmpInst::ICMP_ULE:
5261 // icmp ule i1 A, B -> ~A | B
5262 return BinaryOperator::CreateOr(Builder.CreateNot(A), B);
5263
5264 case ICmpInst::ICMP_SGE:
5265 // icmp sge -> icmp sle
5266 std::swap(A, B);
5267 LLVM_FALLTHROUGH;
5268 case ICmpInst::ICMP_SLE:
5269 // icmp sle i1 A, B -> A | ~B
5270 return BinaryOperator::CreateOr(Builder.CreateNot(B), A);
5271 }
5272}
5273
Roman Lebedev75404fb2018-09-12 18:19:43 +00005274// Transform pattern like:
Roman Lebedev1b7fc872018-09-15 12:04:13 +00005275// (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X
5276// (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X
Roman Lebedev75404fb2018-09-12 18:19:43 +00005277// Into:
5278// (X l>> Y) != 0
5279// (X l>> Y) == 0
5280static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp,
5281 InstCombiner::BuilderTy &Builder) {
Roman Lebedev6dc87002018-09-13 20:33:12 +00005282 ICmpInst::Predicate Pred, NewPred;
Roman Lebedev75404fb2018-09-12 18:19:43 +00005283 Value *X, *Y;
Roman Lebedev6dc87002018-09-13 20:33:12 +00005284 if (match(&Cmp,
5285 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) {
5286 // We want X to be the icmp's second operand, so swap predicate if it isn't.
5287 if (Cmp.getOperand(0) == X)
5288 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00005289
Roman Lebedev6dc87002018-09-13 20:33:12 +00005290 switch (Pred) {
5291 case ICmpInst::ICMP_ULE:
5292 NewPred = ICmpInst::ICMP_NE;
5293 break;
5294 case ICmpInst::ICMP_UGT:
5295 NewPred = ICmpInst::ICMP_EQ;
5296 break;
5297 default:
5298 return nullptr;
5299 }
Roman Lebedev1b7fc872018-09-15 12:04:13 +00005300 } else if (match(&Cmp, m_c_ICmp(Pred,
5301 m_OneUse(m_CombineOr(
5302 m_Not(m_Shl(m_AllOnes(), m_Value(Y))),
5303 m_Add(m_Shl(m_One(), m_Value(Y)),
5304 m_AllOnes()))),
5305 m_Value(X)))) {
5306 // The variant with 'add' is not canonical, (the variant with 'not' is)
5307 // we only get it because it has extra uses, and can't be canonicalized,
5308
Roman Lebedev6dc87002018-09-13 20:33:12 +00005309 // We want X to be the icmp's second operand, so swap predicate if it isn't.
5310 if (Cmp.getOperand(0) == X)
5311 Pred = Cmp.getSwappedPredicate();
Roman Lebedev75404fb2018-09-12 18:19:43 +00005312
Roman Lebedev6dc87002018-09-13 20:33:12 +00005313 switch (Pred) {
5314 case ICmpInst::ICMP_ULT:
5315 NewPred = ICmpInst::ICMP_NE;
5316 break;
5317 case ICmpInst::ICMP_UGE:
5318 NewPred = ICmpInst::ICMP_EQ;
5319 break;
5320 default:
5321 return nullptr;
5322 }
5323 } else
Roman Lebedev75404fb2018-09-12 18:19:43 +00005324 return nullptr;
Roman Lebedev75404fb2018-09-12 18:19:43 +00005325
5326 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits");
5327 Constant *Zero = Constant::getNullValue(NewX->getType());
5328 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero);
5329}
5330
Sanjay Patel039f5562018-08-16 12:52:17 +00005331static Instruction *foldVectorCmp(CmpInst &Cmp,
5332 InstCombiner::BuilderTy &Builder) {
5333 // If both arguments of the cmp are shuffles that use the same mask and
5334 // shuffle within a single vector, move the shuffle after the cmp.
5335 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1);
5336 Value *V1, *V2;
5337 Constant *M;
5338 if (match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Constant(M))) &&
5339 match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_Specific(M))) &&
5340 V1->getType() == V2->getType() &&
5341 (LHS->hasOneUse() || RHS->hasOneUse())) {
5342 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M
5343 CmpInst::Predicate P = Cmp.getPredicate();
5344 Value *NewCmp = isa<ICmpInst>(Cmp) ? Builder.CreateICmp(P, V1, V2)
5345 : Builder.CreateFCmp(P, V1, V2);
5346 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M);
5347 }
5348 return nullptr;
5349}
5350
Chris Lattner2188e402010-01-04 07:37:31 +00005351Instruction *InstCombiner::visitICmpInst(ICmpInst &I) {
5352 bool Changed = false;
Roman Lebedev23646952019-09-25 19:06:40 +00005353 const SimplifyQuery Q = SQ.getWithInstruction(&I);
Chris Lattner9306ffa2010-02-01 19:54:45 +00005354 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Quentin Colombet5ab55552013-09-09 20:56:48 +00005355 unsigned Op0Cplxity = getComplexity(Op0);
5356 unsigned Op1Cplxity = getComplexity(Op1);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005357
Chris Lattner2188e402010-01-04 07:37:31 +00005358 /// Orders the operands of the compare so that they are listed from most
5359 /// complex to least complex. This puts constants before unary operators,
5360 /// before binary operators.
Quentin Colombet5ab55552013-09-09 20:56:48 +00005361 if (Op0Cplxity < Op1Cplxity ||
Sanjay Patel4c204232016-06-04 20:39:22 +00005362 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) {
Chris Lattner2188e402010-01-04 07:37:31 +00005363 I.swapOperands();
Chris Lattner9306ffa2010-02-01 19:54:45 +00005364 std::swap(Op0, Op1);
Chris Lattner2188e402010-01-04 07:37:31 +00005365 Changed = true;
5366 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005367
Roman Lebedev23646952019-09-25 19:06:40 +00005368 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1, Q))
Sanjay Patel4b198802016-02-01 22:23:39 +00005369 return replaceInstUsesWith(I, V);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005370
Uriel Korach18972232017-09-10 08:31:22 +00005371 // Comparing -val or val with non-zero is the same as just comparing val
Pete Cooperfdddc272011-12-01 19:13:26 +00005372 // ie, abs(val) != 0 -> val != 0
Sanjay Patel4c204232016-06-04 20:39:22 +00005373 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) {
Pete Cooperfdddc272011-12-01 19:13:26 +00005374 Value *Cond, *SelectTrue, *SelectFalse;
5375 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue),
Pete Cooperbc5c5242011-12-01 03:58:40 +00005376 m_Value(SelectFalse)))) {
Pete Cooperfdddc272011-12-01 19:13:26 +00005377 if (Value *V = dyn_castNegVal(SelectTrue)) {
5378 if (V == SelectFalse)
5379 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
5380 }
5381 else if (Value *V = dyn_castNegVal(SelectFalse)) {
5382 if (V == SelectTrue)
5383 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1);
Pete Cooperbc5c5242011-12-01 03:58:40 +00005384 }
5385 }
5386 }
5387
Craig Topperfde47232017-07-09 07:04:03 +00005388 if (Op0->getType()->isIntOrIntVectorTy(1))
Craig Topperbb4069e2017-07-07 23:16:26 +00005389 if (Instruction *Res = canonicalizeICmpBool(I, Builder))
Sanjay Patele5747e32017-05-17 22:15:07 +00005390 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005391
Sanjay Patele9b2c322016-05-17 00:57:57 +00005392 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I))
Sanjay Pateld5b0e542016-04-29 16:22:25 +00005393 return NewICmp;
5394
Sanjay Patel06b127a2016-09-15 14:37:50 +00005395 if (Instruction *Res = foldICmpWithConstant(I))
5396 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005397
Sanjay Pateld23b5ed2018-12-04 17:44:24 +00005398 if (Instruction *Res = foldICmpWithDominatingICmp(I))
5399 return Res;
5400
Roman Lebedev23646952019-09-25 19:06:40 +00005401 if (Instruction *Res = foldICmpBinOp(I, Q))
Sanjay Pateleb8d39e2019-09-22 14:31:53 +00005402 return Res;
5403
Max Kazantsev20da7e42018-07-06 04:04:13 +00005404 if (Instruction *Res = foldICmpUsingKnownBits(I))
5405 return Res;
5406
Chris Lattner2188e402010-01-04 07:37:31 +00005407 // Test if the ICmpInst instruction is used exclusively by a select as
5408 // part of a minimum or maximum operation. If so, refrain from doing
5409 // any other folding. This helps out other analyses which understand
5410 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5411 // and CodeGen. And in this case, at least one of the comparison
5412 // operands has at least one user besides the compare (the select),
5413 // which would often largely negate the benefit of folding anyway.
Craig Topperd3e57812017-11-12 02:28:21 +00005414 //
5415 // Do the same for the other patterns recognized by matchSelectPattern.
Chris Lattner2188e402010-01-04 07:37:31 +00005416 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005417 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5418 Value *A, *B;
5419 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5420 if (SPR.Flavor != SPF_UNKNOWN)
Craig Topperf40110f2014-04-25 05:29:35 +00005421 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005422 }
Chris Lattner2188e402010-01-04 07:37:31 +00005423
Nikolai Bozhenov0e7ebbc2017-10-16 09:19:21 +00005424 // Do this after checking for min/max to prevent infinite looping.
5425 if (Instruction *Res = foldICmpWithZero(I))
5426 return Res;
5427
Sanjay Patelfebcb9c2017-01-27 23:26:27 +00005428 // FIXME: We only do this after checking for min/max to prevent infinite
5429 // looping caused by a reverse canonicalization of these patterns for min/max.
5430 // FIXME: The organization of folds is a mess. These would naturally go into
5431 // canonicalizeCmpWithConstant(), but we can't move all of the above folds
5432 // down here after the min/max restriction.
5433 ICmpInst::Predicate Pred = I.getPredicate();
5434 const APInt *C;
5435 if (match(Op1, m_APInt(C))) {
5436 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set
5437 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) {
5438 Constant *Zero = Constant::getNullValue(Op0->getType());
5439 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero);
5440 }
5441
5442 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear
5443 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) {
5444 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType());
5445 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes);
5446 }
5447 }
5448
Sanjay Patelf58f68c2016-09-10 15:03:44 +00005449 if (Instruction *Res = foldICmpInstWithConstant(I))
Sanjay Patel1271bf92016-07-23 13:06:49 +00005450 return Res;
5451
Sanjay Patel10494b22016-09-16 16:10:22 +00005452 if (Instruction *Res = foldICmpInstWithConstantNotInt(I))
5453 return Res;
Chris Lattner2188e402010-01-04 07:37:31 +00005454
5455 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now.
5456 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0))
Sanjay Patel43395062016-07-21 18:07:40 +00005457 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I))
Chris Lattner2188e402010-01-04 07:37:31 +00005458 return NI;
5459 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1))
Sanjay Patel43395062016-07-21 18:07:40 +00005460 if (Instruction *NI = foldGEPICmp(GEP, Op0,
Chris Lattner2188e402010-01-04 07:37:31 +00005461 ICmpInst::getSwappedPredicate(I.getPredicate()), I))
5462 return NI;
5463
Hans Wennborgf1f36512015-10-07 00:20:07 +00005464 // Try to optimize equality comparisons against alloca-based pointers.
5465 if (Op0->getType()->isPointerTy() && I.isEquality()) {
5466 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?");
5467 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00005468 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1))
Hans Wennborgf1f36512015-10-07 00:20:07 +00005469 return New;
5470 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL)))
Sanjay Patel43395062016-07-21 18:07:40 +00005471 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0))
Hans Wennborgf1f36512015-10-07 00:20:07 +00005472 return New;
5473 }
5474
Sanjay Patele7f46c32019-02-07 20:54:09 +00005475 if (Instruction *Res = foldICmpBitCast(I, Builder))
5476 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005477
Sanjay Patela90ee0e2019-08-20 14:56:44 +00005478 if (Instruction *R = foldICmpWithCastOp(I))
5479 return R;
Chris Lattner2188e402010-01-04 07:37:31 +00005480
Sanjay Pateldd46b522016-12-19 17:32:37 +00005481 if (Instruction *Res = foldICmpWithMinMax(I))
Sanjay Pateld6406412016-12-15 19:13:37 +00005482 return Res;
5483
Sanjay Patel10494b22016-09-16 16:10:22 +00005484 {
5485 Value *A, *B;
David Majnemer1a08acc2013-04-12 17:25:07 +00005486 // Transform (A & ~B) == 0 --> (A & B) != 0
5487 // and (A & ~B) != 0 --> (A & B) == 0
5488 // if A is a power of 2.
5489 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) &&
Chandler Carruth66b31302015-01-04 12:03:27 +00005490 match(Op1, m_Zero()) &&
Craig Topperd4039f72017-05-25 21:51:12 +00005491 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality())
Craig Topperbb4069e2017-07-07 23:16:26 +00005492 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B),
David Majnemer1a08acc2013-04-12 17:25:07 +00005493 Op1);
5494
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005495 // ~X < ~Y --> Y < X
5496 // ~X < C --> X > ~C
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005497 if (match(Op0, m_Not(m_Value(A)))) {
5498 if (match(Op1, m_Not(m_Value(B))))
5499 return new ICmpInst(I.getPredicate(), B, A);
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005500
Sanjay Patelce241f42017-06-02 16:29:41 +00005501 const APInt *C;
5502 if (match(Op1, m_APInt(C)))
Sanjay Patel4dc85eb2017-06-02 16:11:14 +00005503 return new ICmpInst(I.getSwappedPredicate(), A,
Sanjay Patelce241f42017-06-02 16:29:41 +00005504 ConstantInt::get(Op1->getType(), ~(*C)));
Chris Lattnerf3c4eef2011-01-15 05:41:33 +00005505 }
Chris Lattner5e0c0c72010-12-19 19:37:52 +00005506
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005507 Instruction *AddI = nullptr;
5508 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B),
5509 m_Instruction(AddI))) &&
5510 isa<IntegerType>(A->getType())) {
5511 Value *Result;
5512 Constant *Overflow;
Nikita Popov352f5982019-05-26 11:43:31 +00005513 if (OptimizeOverflowCheck(Instruction::Add, /*Signed*/false, A, B,
5514 *AddI, Result, Overflow)) {
Sanjay Patel4b198802016-02-01 22:23:39 +00005515 replaceInstUsesWith(*AddI, Result);
5516 return replaceInstUsesWith(I, Overflow);
Sanjoy Dasb6c59142015-04-10 21:07:09 +00005517 }
5518 }
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005519
5520 // (zext a) * (zext b) --> llvm.umul.with.overflow.
5521 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005522 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005523 return R;
5524 }
5525 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) {
Sanjay Pateld93c4c02016-09-15 18:22:25 +00005526 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this))
Serge Pavlov4bb54d52014-04-13 18:23:41 +00005527 return R;
5528 }
Chris Lattner2188e402010-01-04 07:37:31 +00005529 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005530
Sanjay Patel10494b22016-09-16 16:10:22 +00005531 if (Instruction *Res = foldICmpEquality(I))
5532 return Res;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005533
David Majnemerc1eca5a2014-11-06 23:23:30 +00005534 // The 'cmpxchg' instruction returns an aggregate containing the old value and
5535 // an i1 which indicates whether or not we successfully did the swap.
5536 //
5537 // Replace comparisons between the old value and the expected value with the
5538 // indicator that 'cmpxchg' returns.
5539 //
5540 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to
5541 // spuriously fail. In those cases, the old value may equal the expected
5542 // value but it is possible for the swap to not occur.
5543 if (I.getPredicate() == ICmpInst::ICMP_EQ)
5544 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0))
5545 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand()))
5546 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 &&
5547 !ACXI->isWeak())
5548 return ExtractValueInst::Create(ACXI, 1);
5549
Chris Lattner2188e402010-01-04 07:37:31 +00005550 {
Craig Topperbee74792018-08-20 23:04:25 +00005551 Value *X;
5552 const APInt *C;
Chris Lattner2188e402010-01-04 07:37:31 +00005553 // icmp X+Cst, X
Craig Topperbee74792018-08-20 23:04:25 +00005554 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X)
5555 return foldICmpAddOpConst(X, *C, I.getPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005556
5557 // icmp X, X+Cst
Craig Topperbee74792018-08-20 23:04:25 +00005558 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X)
5559 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate());
Chris Lattner2188e402010-01-04 07:37:31 +00005560 }
Roman Lebedev68d54cf2018-07-11 19:05:04 +00005561
Roman Lebedev75404fb2018-09-12 18:19:43 +00005562 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder))
5563 return Res;
5564
Sanjay Patel039f5562018-08-16 12:52:17 +00005565 if (I.getType()->isVectorTy())
5566 if (Instruction *Res = foldVectorCmp(I, Builder))
5567 return Res;
5568
Craig Topperf40110f2014-04-25 05:29:35 +00005569 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005570}
5571
Sanjay Patel5f0217f2016-06-05 16:46:18 +00005572/// Fold fcmp ([us]itofp x, cst) if possible.
Sanjay Patel43395062016-07-21 18:07:40 +00005573Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI,
Chris Lattner2188e402010-01-04 07:37:31 +00005574 Constant *RHSC) {
Craig Topperf40110f2014-04-25 05:29:35 +00005575 if (!isa<ConstantFP>(RHSC)) return nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00005576 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005577
Chris Lattner2188e402010-01-04 07:37:31 +00005578 // Get the width of the mantissa. We don't want to hack on conversions that
5579 // might lose information from the integer, e.g. "i64 -> float"
5580 int MantissaWidth = LHSI->getType()->getFPMantissaWidth();
Craig Topperf40110f2014-04-25 05:29:35 +00005581 if (MantissaWidth == -1) return nullptr; // Unknown.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005582
Matt Arsenault55e73122015-01-06 15:50:59 +00005583 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType());
5584
Chris Lattner2188e402010-01-04 07:37:31 +00005585 bool LHSUnsigned = isa<UIToFPInst>(LHSI);
Jim Grosbach129c52a2011-09-30 18:09:53 +00005586
Matt Arsenault55e73122015-01-06 15:50:59 +00005587 if (I.isEquality()) {
5588 FCmpInst::Predicate P = I.getPredicate();
5589 bool IsExact = false;
5590 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned);
5591 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact);
5592
5593 // If the floating point constant isn't an integer value, we know if we will
5594 // ever compare equal / not equal to it.
5595 if (!IsExact) {
5596 // TODO: Can never be -0.0 and other non-representable values
5597 APFloat RHSRoundInt(RHS);
5598 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven);
5599 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) {
5600 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ)
Craig Topperbb4069e2017-07-07 23:16:26 +00005601 return replaceInstUsesWith(I, Builder.getFalse());
Matt Arsenault55e73122015-01-06 15:50:59 +00005602
5603 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE);
Craig Topperbb4069e2017-07-07 23:16:26 +00005604 return replaceInstUsesWith(I, Builder.getTrue());
Matt Arsenault55e73122015-01-06 15:50:59 +00005605 }
5606 }
5607
5608 // TODO: If the constant is exactly representable, is it always OK to do
5609 // equality compares as integer?
5610 }
5611
Arch D. Robison8ed08542015-09-15 17:51:59 +00005612 // Check to see that the input is converted from an integer type that is small
5613 // enough that preserves all bits. TODO: check here for "known" sign bits.
5614 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e.
5615 unsigned InputSize = IntTy->getScalarSizeInBits();
Matt Arsenault55e73122015-01-06 15:50:59 +00005616
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005617 // Following test does NOT adjust InputSize downwards for signed inputs,
5618 // because the most negative value still requires all the mantissa bits
Arch D. Robison8ed08542015-09-15 17:51:59 +00005619 // to distinguish it from one less than that value.
5620 if ((int)InputSize > MantissaWidth) {
5621 // Conversion would lose accuracy. Check if loss can impact comparison.
5622 int Exp = ilogb(RHS);
5623 if (Exp == APFloat::IEK_Inf) {
5624 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics()));
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005625 if (MaxExponent < (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005626 // Conversion could create infinity.
5627 return nullptr;
5628 } else {
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005629 // Note that if RHS is zero or NaN, then Exp is negative
Arch D. Robison8ed08542015-09-15 17:51:59 +00005630 // and first condition is trivially false.
Justin Bognerc7e4fbe2016-08-05 01:09:48 +00005631 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned)
Arch D. Robison8ed08542015-09-15 17:51:59 +00005632 // Conversion could affect comparison.
5633 return nullptr;
5634 }
5635 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005636
Chris Lattner2188e402010-01-04 07:37:31 +00005637 // Otherwise, we can potentially simplify the comparison. We know that it
5638 // will always come through as an integer value and we know the constant is
5639 // not a NAN (it would have been previously simplified).
5640 assert(!RHS.isNaN() && "NaN comparison not already folded!");
Jim Grosbach129c52a2011-09-30 18:09:53 +00005641
Chris Lattner2188e402010-01-04 07:37:31 +00005642 ICmpInst::Predicate Pred;
5643 switch (I.getPredicate()) {
5644 default: llvm_unreachable("Unexpected predicate!");
5645 case FCmpInst::FCMP_UEQ:
5646 case FCmpInst::FCMP_OEQ:
5647 Pred = ICmpInst::ICMP_EQ;
5648 break;
5649 case FCmpInst::FCMP_UGT:
5650 case FCmpInst::FCMP_OGT:
5651 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT;
5652 break;
5653 case FCmpInst::FCMP_UGE:
5654 case FCmpInst::FCMP_OGE:
5655 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE;
5656 break;
5657 case FCmpInst::FCMP_ULT:
5658 case FCmpInst::FCMP_OLT:
5659 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT;
5660 break;
5661 case FCmpInst::FCMP_ULE:
5662 case FCmpInst::FCMP_OLE:
5663 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE;
5664 break;
5665 case FCmpInst::FCMP_UNE:
5666 case FCmpInst::FCMP_ONE:
5667 Pred = ICmpInst::ICMP_NE;
5668 break;
5669 case FCmpInst::FCMP_ORD:
Craig Topperbb4069e2017-07-07 23:16:26 +00005670 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005671 case FCmpInst::FCMP_UNO:
Craig Topperbb4069e2017-07-07 23:16:26 +00005672 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005673 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005674
Chris Lattner2188e402010-01-04 07:37:31 +00005675 // Now we know that the APFloat is a normal number, zero or inf.
Jim Grosbach129c52a2011-09-30 18:09:53 +00005676
Chris Lattner2188e402010-01-04 07:37:31 +00005677 // See if the FP constant is too large for the integer. For example,
5678 // comparing an i8 to 300.0.
5679 unsigned IntWidth = IntTy->getScalarSizeInBits();
Jim Grosbach129c52a2011-09-30 18:09:53 +00005680
Chris Lattner2188e402010-01-04 07:37:31 +00005681 if (!LHSUnsigned) {
5682 // If the RHS value is > SignedMax, fold the comparison. This handles +INF
5683 // and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005684 APFloat SMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005685 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true,
5686 APFloat::rmNearestTiesToEven);
5687 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0
5688 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT ||
5689 Pred == ICmpInst::ICMP_SLE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005690 return replaceInstUsesWith(I, Builder.getTrue());
5691 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005692 }
5693 } else {
5694 // If the RHS value is > UnsignedMax, fold the comparison. This handles
5695 // +INF and large values.
Michael Gottesman79b09672013-06-27 21:58:19 +00005696 APFloat UMax(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005697 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false,
5698 APFloat::rmNearestTiesToEven);
5699 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0
5700 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT ||
5701 Pred == ICmpInst::ICMP_ULE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005702 return replaceInstUsesWith(I, Builder.getTrue());
5703 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005704 }
5705 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005706
Chris Lattner2188e402010-01-04 07:37:31 +00005707 if (!LHSUnsigned) {
5708 // See if the RHS value is < SignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005709 APFloat SMin(RHS.getSemantics());
Chris Lattner2188e402010-01-04 07:37:31 +00005710 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true,
5711 APFloat::rmNearestTiesToEven);
5712 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0
5713 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT ||
5714 Pred == ICmpInst::ICMP_SGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005715 return replaceInstUsesWith(I, Builder.getTrue());
5716 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005717 }
Devang Patel698452b2012-02-13 23:05:18 +00005718 } else {
5719 // See if the RHS value is < UnsignedMin.
Michael Gottesman79b09672013-06-27 21:58:19 +00005720 APFloat SMin(RHS.getSemantics());
Devang Patel698452b2012-02-13 23:05:18 +00005721 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true,
5722 APFloat::rmNearestTiesToEven);
5723 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0
5724 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT ||
5725 Pred == ICmpInst::ICMP_UGE)
Craig Topperbb4069e2017-07-07 23:16:26 +00005726 return replaceInstUsesWith(I, Builder.getTrue());
5727 return replaceInstUsesWith(I, Builder.getFalse());
Devang Patel698452b2012-02-13 23:05:18 +00005728 }
Chris Lattner2188e402010-01-04 07:37:31 +00005729 }
5730
5731 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or
5732 // [0, UMAX], but it may still be fractional. See if it is fractional by
5733 // casting the FP value to the integer value and back, checking for equality.
5734 // Don't do this for zero, because -0.0 is not fractional.
5735 Constant *RHSInt = LHSUnsigned
5736 ? ConstantExpr::getFPToUI(RHSC, IntTy)
5737 : ConstantExpr::getFPToSI(RHSC, IntTy);
5738 if (!RHS.isZero()) {
5739 bool Equal = LHSUnsigned
5740 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC
5741 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC;
5742 if (!Equal) {
5743 // If we had a comparison against a fractional value, we have to adjust
5744 // the compare predicate and sometimes the value. RHSC is rounded towards
5745 // zero at this point.
5746 switch (Pred) {
5747 default: llvm_unreachable("Unexpected integer comparison!");
5748 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true
Craig Topperbb4069e2017-07-07 23:16:26 +00005749 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005750 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false
Craig Topperbb4069e2017-07-07 23:16:26 +00005751 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005752 case ICmpInst::ICMP_ULE:
5753 // (float)int <= 4.4 --> int <= 4
5754 // (float)int <= -4.4 --> false
5755 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005756 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005757 break;
5758 case ICmpInst::ICMP_SLE:
5759 // (float)int <= 4.4 --> int <= 4
5760 // (float)int <= -4.4 --> int < -4
5761 if (RHS.isNegative())
5762 Pred = ICmpInst::ICMP_SLT;
5763 break;
5764 case ICmpInst::ICMP_ULT:
5765 // (float)int < -4.4 --> false
5766 // (float)int < 4.4 --> int <= 4
5767 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005768 return replaceInstUsesWith(I, Builder.getFalse());
Chris Lattner2188e402010-01-04 07:37:31 +00005769 Pred = ICmpInst::ICMP_ULE;
5770 break;
5771 case ICmpInst::ICMP_SLT:
5772 // (float)int < -4.4 --> int < -4
5773 // (float)int < 4.4 --> int <= 4
5774 if (!RHS.isNegative())
5775 Pred = ICmpInst::ICMP_SLE;
5776 break;
5777 case ICmpInst::ICMP_UGT:
5778 // (float)int > 4.4 --> int > 4
5779 // (float)int > -4.4 --> true
5780 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005781 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005782 break;
5783 case ICmpInst::ICMP_SGT:
5784 // (float)int > 4.4 --> int > 4
5785 // (float)int > -4.4 --> int >= -4
5786 if (RHS.isNegative())
5787 Pred = ICmpInst::ICMP_SGE;
5788 break;
5789 case ICmpInst::ICMP_UGE:
5790 // (float)int >= -4.4 --> true
5791 // (float)int >= 4.4 --> int > 4
Bob Wilson61f3ad52012-08-07 22:35:16 +00005792 if (RHS.isNegative())
Craig Topperbb4069e2017-07-07 23:16:26 +00005793 return replaceInstUsesWith(I, Builder.getTrue());
Chris Lattner2188e402010-01-04 07:37:31 +00005794 Pred = ICmpInst::ICMP_UGT;
5795 break;
5796 case ICmpInst::ICMP_SGE:
5797 // (float)int >= -4.4 --> int >= -4
5798 // (float)int >= 4.4 --> int > 4
5799 if (!RHS.isNegative())
5800 Pred = ICmpInst::ICMP_SGT;
5801 break;
5802 }
5803 }
5804 }
5805
5806 // Lower this FP comparison into an appropriate integer version of the
5807 // comparison.
5808 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt);
5809}
5810
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005811/// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary.
5812static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI,
5813 Constant *RHSC) {
5814 // When C is not 0.0 and infinities are not allowed:
5815 // (C / X) < 0.0 is a sign-bit test of X
5816 // (C / X) < 0.0 --> X < 0.0 (if C is positive)
5817 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate)
5818 //
5819 // Proof:
5820 // Multiply (C / X) < 0.0 by X * X / C.
5821 // - X is non zero, if it is the flag 'ninf' is violated.
5822 // - C defines the sign of X * X * C. Thus it also defines whether to swap
5823 // the predicate. C is also non zero by definition.
5824 //
5825 // Thus X * X / C is non zero and the transformation is valid. [qed]
5826
5827 FCmpInst::Predicate Pred = I.getPredicate();
5828
5829 // Check that predicates are valid.
5830 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) &&
5831 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE))
5832 return nullptr;
5833
5834 // Check that RHS operand is zero.
5835 if (!match(RHSC, m_AnyZeroFP()))
5836 return nullptr;
5837
5838 // Check fastmath flags ('ninf').
5839 if (!LHSI->hasNoInfs() || !I.hasNoInfs())
5840 return nullptr;
5841
5842 // Check the properties of the dividend. It must not be zero to avoid a
5843 // division by zero (see Proof).
5844 const APFloat *C;
5845 if (!match(LHSI->getOperand(0), m_APFloat(C)))
5846 return nullptr;
5847
5848 if (C->isZero())
5849 return nullptr;
5850
5851 // Get swapped predicate if necessary.
5852 if (C->isNegative())
5853 Pred = I.getSwappedPredicate();
5854
Sanjay Pateld1172a02018-11-07 00:00:42 +00005855 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I);
Sanjay Patelc3f50ff2018-09-27 15:59:24 +00005856}
5857
Sanjay Patel1c254c62018-10-31 16:34:43 +00005858/// Optimize fabs(X) compared with zero.
5859static Instruction *foldFabsWithFcmpZero(FCmpInst &I) {
5860 Value *X;
5861 if (!match(I.getOperand(0), m_Intrinsic<Intrinsic::fabs>(m_Value(X))) ||
5862 !match(I.getOperand(1), m_PosZeroFP()))
5863 return nullptr;
5864
Sanjay Patel57a08b32018-11-07 16:15:01 +00005865 auto replacePredAndOp0 = [](FCmpInst *I, FCmpInst::Predicate P, Value *X) {
5866 I->setPredicate(P);
5867 I->setOperand(0, X);
5868 return I;
5869 };
5870
Sanjay Patel1c254c62018-10-31 16:34:43 +00005871 switch (I.getPredicate()) {
5872 case FCmpInst::FCMP_UGE:
5873 case FCmpInst::FCMP_OLT:
5874 // fabs(X) >= 0.0 --> true
5875 // fabs(X) < 0.0 --> false
5876 llvm_unreachable("fcmp should have simplified");
5877
5878 case FCmpInst::FCMP_OGT:
5879 // fabs(X) > 0.0 --> X != 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005880 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005881
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005882 case FCmpInst::FCMP_UGT:
5883 // fabs(X) u> 0.0 --> X u!= 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005884 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005885
Sanjay Patel1c254c62018-10-31 16:34:43 +00005886 case FCmpInst::FCMP_OLE:
5887 // fabs(X) <= 0.0 --> X == 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005888 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005889
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005890 case FCmpInst::FCMP_ULE:
5891 // fabs(X) u<= 0.0 --> X u== 0.0
Sanjay Patel57a08b32018-11-07 16:15:01 +00005892 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X);
Sanjay Patelfa5f1462018-11-07 15:33:03 +00005893
Sanjay Patel1c254c62018-10-31 16:34:43 +00005894 case FCmpInst::FCMP_OGE:
5895 // fabs(X) >= 0.0 --> !isnan(X)
5896 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005897 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005898
Sanjay Patel76faf512018-11-07 15:11:32 +00005899 case FCmpInst::FCMP_ULT:
5900 // fabs(X) u< 0.0 --> isnan(X)
5901 assert(!I.hasNoNaNs() && "fcmp should have simplified");
Sanjay Patel57a08b32018-11-07 16:15:01 +00005902 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X);
Sanjay Patel76faf512018-11-07 15:11:32 +00005903
Sanjay Patel1c254c62018-10-31 16:34:43 +00005904 case FCmpInst::FCMP_OEQ:
5905 case FCmpInst::FCMP_UEQ:
5906 case FCmpInst::FCMP_ONE:
5907 case FCmpInst::FCMP_UNE:
Sanjay Patelbb521e62018-11-07 15:44:26 +00005908 case FCmpInst::FCMP_ORD:
5909 case FCmpInst::FCMP_UNO:
5910 // Look through the fabs() because it doesn't change anything but the sign.
5911 // fabs(X) == 0.0 --> X == 0.0,
Sanjay Patel1c254c62018-10-31 16:34:43 +00005912 // fabs(X) != 0.0 --> X != 0.0
Sanjay Patelbb521e62018-11-07 15:44:26 +00005913 // isnan(fabs(X)) --> isnan(X)
5914 // !isnan(fabs(X) --> !isnan(X)
Sanjay Patel57a08b32018-11-07 16:15:01 +00005915 return replacePredAndOp0(&I, I.getPredicate(), X);
Sanjay Patel1c254c62018-10-31 16:34:43 +00005916
5917 default:
5918 return nullptr;
5919 }
5920}
5921
Chris Lattner2188e402010-01-04 07:37:31 +00005922Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) {
5923 bool Changed = false;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005924
Chris Lattner2188e402010-01-04 07:37:31 +00005925 /// Orders the operands of the compare so that they are listed from most
5926 /// complex to least complex. This puts constants before unary operators,
5927 /// before binary operators.
5928 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) {
5929 I.swapOperands();
5930 Changed = true;
5931 }
5932
Sanjay Patel6b139462017-09-02 15:11:55 +00005933 const CmpInst::Predicate Pred = I.getPredicate();
Chris Lattner2188e402010-01-04 07:37:31 +00005934 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1);
Sanjay Patel6b139462017-09-02 15:11:55 +00005935 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(),
5936 SQ.getWithInstruction(&I)))
Sanjay Patel4b198802016-02-01 22:23:39 +00005937 return replaceInstUsesWith(I, V);
Chris Lattner2188e402010-01-04 07:37:31 +00005938
5939 // Simplify 'fcmp pred X, X'
Sanjay Patela706b9a2019-04-29 19:23:44 +00005940 Type *OpType = Op0->getType();
5941 assert(OpType == Op1->getType() && "fcmp with different-typed operands?");
Chris Lattner2188e402010-01-04 07:37:31 +00005942 if (Op0 == Op1) {
Sanjay Patel6b139462017-09-02 15:11:55 +00005943 switch (Pred) {
5944 default: break;
Chris Lattner2188e402010-01-04 07:37:31 +00005945 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y)
5946 case FCmpInst::FCMP_ULT: // True if unordered or less than
5947 case FCmpInst::FCMP_UGT: // True if unordered or greater than
5948 case FCmpInst::FCMP_UNE: // True if unordered or not equal
5949 // Canonicalize these to be 'fcmp uno %X, 0.0'.
5950 I.setPredicate(FCmpInst::FCMP_UNO);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005951 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005952 return &I;
Jim Grosbach129c52a2011-09-30 18:09:53 +00005953
Chris Lattner2188e402010-01-04 07:37:31 +00005954 case FCmpInst::FCMP_ORD: // True if ordered (no nans)
5955 case FCmpInst::FCMP_OEQ: // True if ordered and equal
5956 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal
5957 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal
5958 // Canonicalize these to be 'fcmp ord %X, 0.0'.
5959 I.setPredicate(FCmpInst::FCMP_ORD);
Sanjay Patela706b9a2019-04-29 19:23:44 +00005960 I.setOperand(1, Constant::getNullValue(OpType));
Chris Lattner2188e402010-01-04 07:37:31 +00005961 return &I;
5962 }
5963 }
Jim Grosbach129c52a2011-09-30 18:09:53 +00005964
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005965 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand,
5966 // then canonicalize the operand to 0.0.
5967 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) {
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005968 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005969 I.setOperand(0, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005970 return &I;
5971 }
Matt Arsenaultd54b7f02018-08-09 22:40:08 +00005972 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00005973 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patel6840c5f2017-09-05 23:13:13 +00005974 return &I;
5975 }
5976 }
5977
Sanjay Patel6a281a72019-05-07 18:58:07 +00005978 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y
5979 Value *X, *Y;
5980 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y))))
5981 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I);
5982
James Molloy2b21a7c2015-05-20 18:41:25 +00005983 // Test if the FCmpInst instruction is used exclusively by a select as
5984 // part of a minimum or maximum operation. If so, refrain from doing
5985 // any other folding. This helps out other analyses which understand
5986 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution
5987 // and CodeGen. And in this case, at least one of the comparison
5988 // operands has at least one user besides the compare (the select),
5989 // which would often largely negate the benefit of folding anyway.
5990 if (I.hasOneUse())
Craig Topperd3e57812017-11-12 02:28:21 +00005991 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) {
5992 Value *A, *B;
5993 SelectPatternResult SPR = matchSelectPattern(SI, A, B);
5994 if (SPR.Flavor != SPF_UNKNOWN)
James Molloy2b21a7c2015-05-20 18:41:25 +00005995 return nullptr;
Craig Topperd3e57812017-11-12 02:28:21 +00005996 }
James Molloy2b21a7c2015-05-20 18:41:25 +00005997
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00005998 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0:
5999 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0
6000 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) {
Sanjay Patela706b9a2019-04-29 19:23:44 +00006001 I.setOperand(1, ConstantFP::getNullValue(OpType));
Sanjay Patelc26fd1e2018-11-05 17:26:42 +00006002 return &I;
6003 }
6004
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00006005 // Handle fcmp with instruction LHS and constant RHS.
6006 Instruction *LHSI;
6007 Constant *RHSC;
6008 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) {
6009 switch (LHSI->getOpcode()) {
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00006010 case Instruction::PHI:
6011 // Only fold fcmp into the PHI if the phi and fcmp are in the same
6012 // block. If in the same block, we're encouraging jump threading. If
6013 // not, we are just pessimizing the code by making an i1 phi.
6014 if (LHSI->getParent() == I.getParent())
6015 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI)))
Chris Lattner2188e402010-01-04 07:37:31 +00006016 return NV;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00006017 break;
6018 case Instruction::SIToFP:
6019 case Instruction::UIToFP:
6020 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC))
6021 return NV;
6022 break;
Sanjay Patel4c39dfc2018-10-30 20:52:25 +00006023 case Instruction::FDiv:
6024 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC))
6025 return NV;
6026 break;
6027 case Instruction::Load:
6028 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0)))
6029 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0)))
6030 if (GV->isConstant() && GV->hasDefinitiveInitializer() &&
6031 !cast<LoadInst>(LHSI)->isVolatile())
6032 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I))
6033 return Res;
6034 break;
Sanjay Patel1c254c62018-10-31 16:34:43 +00006035 }
Chris Lattner2188e402010-01-04 07:37:31 +00006036 }
6037
Sanjay Pateld1172a02018-11-07 00:00:42 +00006038 if (Instruction *R = foldFabsWithFcmpZero(I))
6039 return R;
6040
Sanjay Patel70282a02018-11-06 15:49:45 +00006041 if (match(Op0, m_FNeg(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00006042 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C
Sanjay Patel70282a02018-11-06 15:49:45 +00006043 Constant *C;
6044 if (match(Op1, m_Constant(C))) {
Sanjay Patel70282a02018-11-06 15:49:45 +00006045 Constant *NegC = ConstantExpr::getFNeg(C);
Sanjay Pateld1172a02018-11-07 00:00:42 +00006046 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I);
Sanjay Patel70282a02018-11-06 15:49:45 +00006047 }
6048 }
Benjamin Kramerd159d942011-03-31 10:12:22 +00006049
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00006050 if (match(Op0, m_FPExt(m_Value(X)))) {
Sanjay Pateld1172a02018-11-07 00:00:42 +00006051 // fcmp (fpext X), (fpext Y) -> fcmp X, Y
6052 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType())
6053 return new FCmpInst(Pred, X, Y, "", &I);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00006054
Sanjay Pateld1172a02018-11-07 00:00:42 +00006055 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless
Sanjay Patel724014a2018-11-06 17:20:20 +00006056 const APFloat *C;
6057 if (match(Op1, m_APFloat(C))) {
Sanjay Patel724014a2018-11-06 17:20:20 +00006058 const fltSemantics &FPSem =
6059 X->getType()->getScalarType()->getFltSemantics();
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00006060 bool Lossy;
Sanjay Patel724014a2018-11-06 17:20:20 +00006061 APFloat TruncC = *C;
6062 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy);
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00006063
6064 // Avoid lossy conversions and denormals.
6065 // Zero is a special case that's OK to convert.
Sanjay Patel724014a2018-11-06 17:20:20 +00006066 APFloat Fabs = TruncC;
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00006067 Fabs.clearSign();
6068 if (!Lossy &&
6069 ((Fabs.compare(APFloat::getSmallestNormalized(FPSem)) !=
Sanjay Patel46bf3922018-11-06 16:45:27 +00006070 APFloat::cmpLessThan) || Fabs.isZero())) {
Sanjay Patel724014a2018-11-06 17:20:20 +00006071 Constant *NewC = ConstantFP::get(X->getType(), TruncC);
Sanjay Pateld1172a02018-11-07 00:00:42 +00006072 return new FCmpInst(Pred, X, NewC, "", &I);
Sanjay Patel46bf3922018-11-06 16:45:27 +00006073 }
Sanjay Patel7c3ee4d2018-11-06 16:37:35 +00006074 }
Sanjay Patel1b85f0022018-11-06 16:23:03 +00006075 }
Benjamin Kramer2ccfbc82011-03-31 10:11:58 +00006076
Sanjay Patel039f5562018-08-16 12:52:17 +00006077 if (I.getType()->isVectorTy())
6078 if (Instruction *Res = foldVectorCmp(I, Builder))
6079 return Res;
6080
Craig Topperf40110f2014-04-25 05:29:35 +00006081 return Changed ? &I : nullptr;
Chris Lattner2188e402010-01-04 07:37:31 +00006082}