blob: d80cccdc4679a467222aff11802f3ea9d86e7a7b [file] [log] [blame]
Daniel Jasperc58c70e2014-09-15 11:21:46 +00001//===- unittest/Format/FormatTestJava.cpp - Formatting tests for Java -----===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9
10#include "FormatTestUtils.h"
11#include "clang/Format/Format.h"
12#include "llvm/Support/Debug.h"
13#include "gtest/gtest.h"
14
15#define DEBUG_TYPE "format-test"
16
17namespace clang {
18namespace format {
19
20class FormatTestJava : public ::testing::Test {
21protected:
22 static std::string format(llvm::StringRef Code, unsigned Offset,
23 unsigned Length, const FormatStyle &Style) {
24 DEBUG(llvm::errs() << "---\n");
25 DEBUG(llvm::errs() << Code << "\n\n");
26 std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length));
27 tooling::Replacements Replaces = reformat(Style, Code, Ranges);
28 std::string Result = applyAllReplacements(Code, Replaces);
29 EXPECT_NE("", Result);
30 DEBUG(llvm::errs() << "\n" << Result << "\n\n");
31 return Result;
32 }
33
34 static std::string format(
35 llvm::StringRef Code,
36 const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_Java)) {
37 return format(Code, 0, Code.size(), Style);
38 }
39
Daniel Jasper50b4bd72014-11-02 19:16:41 +000040 static FormatStyle getStyleWithColumns(unsigned ColumnLimit) {
41 FormatStyle Style = getGoogleStyle(FormatStyle::LK_Java);
42 Style.ColumnLimit = ColumnLimit;
43 return Style;
44 }
45
Daniel Jasperc58c70e2014-09-15 11:21:46 +000046 static void verifyFormat(
47 llvm::StringRef Code,
48 const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_Java)) {
49 EXPECT_EQ(Code.str(), format(test::messUp(Code), Style));
50 }
51};
52
Daniel Jasper30a24062014-11-14 09:02:28 +000053TEST_F(FormatTestJava, NoAlternativeOperatorNames) {
54 verifyFormat("someObject.and();");
55}
56
Daniel Jasper4f56b0b2014-11-26 12:23:10 +000057TEST_F(FormatTestJava, UnderstandsCasts) {
58 verifyFormat("a[b >> 1] = (byte) (c() << 4);");
59}
60
Daniel Jaspera98b7b02014-11-25 10:05:17 +000061TEST_F(FormatTestJava, FormatsInstanceOfLikeOperators) {
62 FormatStyle Style = getStyleWithColumns(50);
63 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
64 " instanceof bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;",
65 Style);
66 Style.BreakBeforeBinaryOperators = FormatStyle::BOS_None;
67 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaa instanceof\n"
68 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;",
69 Style);
70}
71
Nico Weber450425c2014-11-26 16:43:18 +000072TEST_F(FormatTestJava, Chromium) {
73 verifyFormat("class SomeClass {\n"
74 " void f() {}\n"
75 " int g() {\n"
76 " return 0;\n"
77 " }\n"
78 " void h() {\n"
79 " while (true) f();\n"
80 " for (;;) f();\n"
81 " if (true) f();\n"
82 " }\n"
83 "}",
84 getChromiumStyle(FormatStyle::LK_Java));
85}
86
Daniel Jasper83791072014-12-03 13:20:49 +000087TEST_F(FormatTestJava, QualifiedNames) {
88 verifyFormat("public some.package.Type someFunction( // comment\n"
89 " int parameter) {}");
90}
91
Daniel Jaspere5d74862014-11-26 08:17:08 +000092TEST_F(FormatTestJava, ClassKeyword) {
93 verifyFormat("SomeClass.class.getName();");
94 verifyFormat("Class c = SomeClass.class;");
95}
96
Daniel Jasperc58c70e2014-09-15 11:21:46 +000097TEST_F(FormatTestJava, ClassDeclarations) {
98 verifyFormat("public class SomeClass {\n"
99 " private int a;\n"
100 " private int b;\n"
101 "}");
102 verifyFormat("public class A {\n"
103 " class B {\n"
104 " int i;\n"
105 " }\n"
106 " class C {\n"
107 " int j;\n"
108 " }\n"
109 "}");
Daniel Jasper4bf9d472014-10-21 09:31:29 +0000110 verifyFormat("public class A extends B.C {}");
Daniel Jasper50b4bd72014-11-02 19:16:41 +0000111
Daniel Jasper734d52b2014-11-14 10:15:56 +0000112 verifyFormat("abstract class SomeClass\n"
113 " extends SomeOtherClass implements SomeInterface {}",
114 getStyleWithColumns(60));
Daniel Jasper50b4bd72014-11-02 19:16:41 +0000115 verifyFormat("abstract class SomeClass extends SomeOtherClass\n"
Daniel Jasper734d52b2014-11-14 10:15:56 +0000116 " implements SomeInterfaceeeeeeeeeeeee {}",
Daniel Jasper50b4bd72014-11-02 19:16:41 +0000117 getStyleWithColumns(60));
118 verifyFormat("abstract class SomeClass\n"
119 " extends SomeOtherClass\n"
120 " implements SomeInterface {}",
121 getStyleWithColumns(40));
122 verifyFormat("abstract class SomeClass\n"
123 " extends SomeOtherClass\n"
124 " implements SomeInterface,\n"
125 " AnotherInterface {}",
126 getStyleWithColumns(40));
Daniel Jasper734d52b2014-11-14 10:15:56 +0000127 verifyFormat("abstract class SomeClass\n"
128 " implements SomeInterface, AnotherInterface {}",
129 getStyleWithColumns(60));
Daniel Jasper39af6cd2014-11-03 02:27:28 +0000130 verifyFormat("@SomeAnnotation()\n"
Daniel Jasper734d52b2014-11-14 10:15:56 +0000131 "abstract class aaaaaaaaaaaa\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000132 " extends bbbbbbbbbbbbbbb implements cccccccccccc {}",
Daniel Jasper39af6cd2014-11-03 02:27:28 +0000133 getStyleWithColumns(76));
Daniel Jasper58fcf6d2014-11-04 10:53:14 +0000134 verifyFormat("@SomeAnnotation()\n"
Daniel Jasper734d52b2014-11-14 10:15:56 +0000135 "abstract class aaaaaaaaa<a>\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000136 " extends bbbbbbbbbbbb<b> implements cccccccccccc {}",
Daniel Jasper58fcf6d2014-11-04 10:53:14 +0000137 getStyleWithColumns(76));
Nico Webera644d7f2014-11-10 16:30:02 +0000138 verifyFormat("interface SomeInterface<A> extends Foo, Bar {\n"
139 " void doStuff(int theStuff);\n"
140 " void doMoreStuff(int moreStuff);\n"
141 "}");
142 verifyFormat("public interface SomeInterface {\n"
143 " void doStuff(int theStuff);\n"
144 " void doMoreStuff(int moreStuff);\n"
145 "}");
146 verifyFormat("@interface SomeInterface {\n"
147 " void doStuff(int theStuff);\n"
148 " void doMoreStuff(int moreStuff);\n"
149 "}");
150 verifyFormat("public @interface SomeInterface {\n"
151 " void doStuff(int theStuff);\n"
152 " void doMoreStuff(int moreStuff);\n"
153 "}");
Daniel Jasperc58c70e2014-09-15 11:21:46 +0000154}
155
Daniel Jasperdf2ff002014-11-02 22:31:39 +0000156TEST_F(FormatTestJava, EnumDeclarations) {
157 verifyFormat("enum SomeThing { ABC, CDE }");
158 verifyFormat("enum SomeThing {\n"
159 " ABC,\n"
160 " CDE,\n"
161 "}");
162 verifyFormat("public class SomeClass {\n"
163 " enum SomeThing { ABC, CDE }\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000164 " void f() {}\n"
Daniel Jasperdf2ff002014-11-02 22:31:39 +0000165 "}");
Daniel Jasper6be0f552014-11-13 15:56:28 +0000166 verifyFormat("public class SomeClass implements SomeInterface {\n"
167 " enum SomeThing { ABC, CDE }\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000168 " void f() {}\n"
Daniel Jasper6be0f552014-11-13 15:56:28 +0000169 "}");
170 verifyFormat("enum SomeThing {\n"
171 " ABC,\n"
172 " CDE;\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000173 " void f() {}\n"
Daniel Jasper6be0f552014-11-13 15:56:28 +0000174 "}");
175 verifyFormat("enum SomeThing {\n"
176 " ABC(1, \"ABC\"),\n"
177 " CDE(2, \"CDE\");\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000178 " Something(int i, String s) {}\n"
Daniel Jasper6be0f552014-11-13 15:56:28 +0000179 "}");
180 verifyFormat("enum SomeThing {\n"
Daniel Jaspera0143fa2014-11-23 20:54:37 +0000181 " ABC(new int[] {1, 2}),\n"
182 " CDE(new int[] {2, 3});\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000183 " Something(int[] i) {}\n"
Daniel Jasper6be0f552014-11-13 15:56:28 +0000184 "}");
185 verifyFormat("public enum SomeThing {\n"
186 " ABC {\n"
187 " public String toString() {\n"
188 " return \"ABC\";\n"
189 " }\n"
190 " },\n"
191 " CDE {\n"
192 " @Override\n"
193 " public String toString() {\n"
194 " return \"CDE\";\n"
195 " }\n"
196 " };\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000197 " public void f() {}\n"
Daniel Jasper6be0f552014-11-13 15:56:28 +0000198 "}");
Daniel Jasperccb68b42014-11-19 22:38:18 +0000199 verifyFormat("private enum SomeEnum implements Foo<?, B> {\n"
200 " ABC {\n"
201 " @Override\n"
202 " public String toString() {\n"
203 " return \"ABC\";\n"
204 " }\n"
205 " },\n"
206 " CDE {\n"
207 " @Override\n"
208 " public String toString() {\n"
209 " return \"CDE\";\n"
210 " }\n"
211 " };\n"
212 "}");
Daniel Jasperdf2ff002014-11-02 22:31:39 +0000213}
214
Daniel Jaspera0143fa2014-11-23 20:54:37 +0000215TEST_F(FormatTestJava, ArrayInitializers) {
216 verifyFormat("new int[] {1, 2, 3, 4};");
217 verifyFormat("new int[] {\n"
218 " 1, 2, 3, 4,\n"
219 "};");
Daniel Jasper13404da2014-11-27 14:40:48 +0000220
221 FormatStyle Style = getStyleWithColumns(65);
222 Style.Cpp11BracedListStyle = false;
223 verifyFormat(
224 "expected = new int[] { 10, 10, 10, 10, 10, 10, 10, 10, 10, 10,\n"
225 " 100, 100, 100, 100, 100, 100, 100, 100, 100, 100 };",
226 Style);
Daniel Jaspera0143fa2014-11-23 20:54:37 +0000227}
228
Daniel Jasperf26c7552014-10-17 13:36:14 +0000229TEST_F(FormatTestJava, ThrowsDeclarations) {
230 verifyFormat("public void doSooooooooooooooooooooooooooomething()\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000231 " throws LooooooooooooooooooooooooooooongException {}");
Daniel Jasper375815d2014-11-26 12:31:19 +0000232 verifyFormat("public void doSooooooooooooooooooooooooooomething()\n"
233 " throws LoooooooooongException, LooooooooooongException {}");
Daniel Jasperf26c7552014-10-17 13:36:14 +0000234}
235
Daniel Jasperfab69ff2014-10-21 08:24:18 +0000236TEST_F(FormatTestJava, Annotations) {
237 verifyFormat("@Override\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000238 "public String toString() {}");
Daniel Jasperfab69ff2014-10-21 08:24:18 +0000239 verifyFormat("@Override\n"
240 "@Nullable\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000241 "public String getNameIfPresent() {}");
Daniel Jasper07013a42014-11-26 11:20:43 +0000242 verifyFormat("@Override // comment\n"
243 "@Nullable\n"
244 "public String getNameIfPresent() {}");
Daniel Jasperf1f0c352014-10-21 09:25:39 +0000245
246 verifyFormat("@SuppressWarnings(value = \"unchecked\")\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000247 "public void doSomething() {}");
Daniel Jasperd78c4222014-10-21 11:17:56 +0000248 verifyFormat("@SuppressWarnings(value = \"unchecked\")\n"
249 "@Author(name = \"abc\")\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000250 "public void doSomething() {}");
Daniel Jasperf1f0c352014-10-21 09:25:39 +0000251
Daniel Jasperc7d024a2014-10-21 10:02:03 +0000252 verifyFormat("DoSomething(new A() {\n"
253 " @Override\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000254 " public String toString() {}\n"
Daniel Jasperc7d024a2014-10-21 10:02:03 +0000255 "});");
256
Daniel Jasper9e709352014-11-26 10:43:58 +0000257 verifyFormat("void SomeFunction(@Nullable String something) {}");
Daniel Jaspere9ab42d2014-10-31 18:23:49 +0000258
Daniel Jasperfab69ff2014-10-21 08:24:18 +0000259 verifyFormat("@Partial @Mock DataLoader loader;");
Daniel Jasperfd681912014-10-21 10:58:14 +0000260 verifyFormat("@SuppressWarnings(value = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\")\n"
261 "public static int iiiiiiiiiiiiiiiiiiiiiiii;");
Daniel Jaspere9ab42d2014-10-31 18:23:49 +0000262
263 verifyFormat("@SomeAnnotation(\"With some really looooooooooooooong text\")\n"
264 "private static final long something = 0L;");
Daniel Jasper211e1322014-12-08 20:08:04 +0000265 verifyFormat("@Mock\n"
266 "DataLoader loooooooooooooooooooooooader =\n"
267 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;",
268 getStyleWithColumns(60));
Daniel Jasperfab69ff2014-10-21 08:24:18 +0000269}
270
Daniel Jasper16b107e2014-10-21 09:57:09 +0000271TEST_F(FormatTestJava, Generics) {
272 verifyFormat("Iterable<?> a;");
273 verifyFormat("Iterable<?> a;");
274 verifyFormat("Iterable<? extends SomeObject> a;");
Daniel Jasper5ffcb7f2014-10-21 11:13:31 +0000275
276 verifyFormat("A.<B>doSomething();");
Daniel Jasper7bd618f2014-11-02 21:52:57 +0000277
278 verifyFormat("@Override\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000279 "public Map<String, ?> getAll() {}");
Daniel Jasperdb9a7a22014-11-03 02:35:14 +0000280
Daniel Jasper9e709352014-11-26 10:43:58 +0000281 verifyFormat("public <R> ArrayList<R> get() {}");
282 verifyFormat("protected <R> ArrayList<R> get() {}");
283 verifyFormat("private <R> ArrayList<R> get() {}");
284 verifyFormat("public static <R> ArrayList<R> get() {}");
285 verifyFormat("public final <X> Foo foo() {}");
Daniel Jasper82c92752014-11-21 12:19:07 +0000286 verifyFormat("public abstract <X> Foo foo();");
Daniel Jasperf056f452014-11-03 02:45:58 +0000287 verifyFormat("<T extends B> T getInstance(Class<T> type);");
Daniel Jasper61d81972014-11-14 08:22:46 +0000288 verifyFormat("Function<F, ? extends T> function;");
Daniel Jasper6761b422014-11-18 23:48:01 +0000289
290 verifyFormat("private Foo<X, Y>[] foos;");
291 verifyFormat("Foo<X, Y>[] foos = this.foos;");
Daniel Jaspercaf86852014-11-20 09:48:11 +0000292
293 verifyFormat(
294 "SomeLoooooooooooooooooooooongType name =\n"
295 " SomeType.foo(someArgument)\n"
296 " .<X>method()\n"
297 " .aaaaaaaaaaaaaaaaaaa()\n"
298 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();");
Daniel Jasper16b107e2014-10-21 09:57:09 +0000299}
300
Daniel Jasperc0126862014-10-21 11:34:53 +0000301TEST_F(FormatTestJava, StringConcatenation) {
302 verifyFormat("String someString = \"abc\"\n"
Daniel Jasper3219e432014-12-02 13:24:51 +0000303 " + \"cde\";");
Daniel Jasperc0126862014-10-21 11:34:53 +0000304}
305
Daniel Jaspera3ddf862014-11-02 19:21:48 +0000306TEST_F(FormatTestJava, TryCatchFinally) {
307 verifyFormat("try {\n"
308 " Something();\n"
309 "} catch (SomeException e) {\n"
310 " HandleException(e);\n"
311 "}");
312 verifyFormat("try {\n"
313 " Something();\n"
314 "} finally {\n"
315 " AlwaysDoThis();\n"
316 "}");
317 verifyFormat("try {\n"
318 " Something();\n"
319 "} catch (SomeException e) {\n"
320 " HandleException(e);\n"
321 "} finally {\n"
322 " AlwaysDoThis();\n"
323 "}");
324
325 verifyFormat("try {\n"
326 " Something();\n"
327 "} catch (SomeException | OtherException e) {\n"
328 " HandleException(e);\n"
329 "}");
330}
331
Daniel Jasperb9d3db62014-11-02 22:00:57 +0000332TEST_F(FormatTestJava, SynchronizedKeyword) {
333 verifyFormat("synchronized (mData) {\n"
334 " // ...\n"
335 "}");
336}
337
Daniel Jasper9b9e0762014-11-26 18:03:42 +0000338TEST_F(FormatTestJava, PackageDeclarations) {
339 verifyFormat("package some.really.loooooooooooooooooooooong.package;",
340 getStyleWithColumns(50));
341}
342
Daniel Jasper5e7be1d2014-11-02 22:13:03 +0000343TEST_F(FormatTestJava, ImportDeclarations) {
344 verifyFormat("import some.really.loooooooooooooooooooooong.imported.Class;",
345 getStyleWithColumns(50));
346}
347
Daniel Jasper3aa9a6a2014-11-18 23:55:27 +0000348TEST_F(FormatTestJava, MethodDeclarations) {
349 verifyFormat("void methodName(Object arg1,\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000350 " Object arg2, Object arg3) {}",
Daniel Jasper3aa9a6a2014-11-18 23:55:27 +0000351 getStyleWithColumns(40));
352 verifyFormat("void methodName(\n"
Daniel Jasper9e709352014-11-26 10:43:58 +0000353 " Object arg1, Object arg2) {}",
Daniel Jasper3aa9a6a2014-11-18 23:55:27 +0000354 getStyleWithColumns(40));
355}
356
Daniel Jasperfe2cf662014-11-19 14:11:11 +0000357TEST_F(FormatTestJava, CppKeywords) {
358 verifyFormat("public void union(Type a, Type b);");
359 verifyFormat("public void struct(Object o);");
360 verifyFormat("public void delete(Object o);");
361}
362
Daniel Jasper6cab6782014-11-20 09:54:49 +0000363TEST_F(FormatTestJava, NeverAlignAfterReturn) {
364 verifyFormat("return aaaaaaaaaaaaaaaaaaa\n"
365 " && bbbbbbbbbbbbbbbbbbb\n"
366 " && ccccccccccccccccccc;",
367 getStyleWithColumns(40));
368 verifyFormat("return (result == null)\n"
369 " ? aaaaaaaaaaaaaaaaa\n"
370 " : bbbbbbbbbbbbbbbbb;",
371 getStyleWithColumns(40));
372 verifyFormat("return aaaaaaaaaaaaaaaaaaa()\n"
373 " .bbbbbbbbbbbbbbbbbbb()\n"
374 " .ccccccccccccccccccc();",
375 getStyleWithColumns(40));
Daniel Jaspera536df42014-12-08 21:28:31 +0000376 verifyFormat("return aaaaaaaaaaaaaaaaaaa()\n"
377 " .bbbbbbbbbbbbbbbbbbb(\n"
378 " ccccccccccccccc)\n"
379 " .ccccccccccccccccccc();",
380 getStyleWithColumns(40));
Daniel Jasper6cab6782014-11-20 09:54:49 +0000381}
382
Daniel Jasper4b444492014-11-21 13:38:53 +0000383TEST_F(FormatTestJava, FormatsInnerBlocks) {
384 verifyFormat("someObject.someFunction(new Runnable() {\n"
385 " @Override\n"
386 " public void run() {\n"
387 " System.out.println(42);\n"
388 " }\n"
389 "}, someOtherParameter);");
390 verifyFormat("someObject.someFunction(\n"
391 " new Runnable() {\n"
392 " @Override\n"
393 " public void run() {\n"
394 " System.out.println(42);\n"
395 " }\n"
396 " },\n"
397 " new Runnable() {\n"
398 " @Override\n"
399 " public void run() {\n"
400 " System.out.println(43);\n"
401 " }\n"
402 " },\n"
403 " someOtherParameter);");
404}
405
Daniel Jasper8354ea82014-11-21 12:14:12 +0000406TEST_F(FormatTestJava, FormatsLambdas) {
407 verifyFormat("(aaaaaaaaaa, bbbbbbbbbb) -> aaaaaaaaaa + bbbbbbbbbb;");
408 verifyFormat("(aaaaaaaaaa, bbbbbbbbbb)\n"
409 " -> aaaaaaaaaa + bbbbbbbbbb;",
410 getStyleWithColumns(40));
411 verifyFormat("Runnable someLambda = () -> DoSomething();");
412 verifyFormat("Runnable someLambda = () -> {\n"
413 " DoSomething();\n"
414 "}");
415
416 verifyFormat("Runnable someLambda =\n"
417 " (int aaaaa) -> DoSomething(aaaaa);",
418 getStyleWithColumns(40));
419}
420
Alexander Kornienkoff2437f2014-12-12 13:03:22 +0000421TEST_F(FormatTestJava, BreaksStringLiterals) {
422 // FIXME: String literal breaking is currently disabled for Java and JS, as it
423 // requires strings to be merged using "+" which we don't support.
424 EXPECT_EQ("\"some text other\";",
425 format("\"some text other\";", getStyleWithColumns(14)));
426}
427
Daniel Jasperc58c70e2014-09-15 11:21:46 +0000428} // end namespace tooling
429} // end namespace clang