msm: clock-a7: Fix race condition between enable and set_rate
The parent field is not modified when switching to the safe_parent, so
refering to this in the enable op can get a stale value. Use the src_sel
field instead, which is modified with the appropriate lock held when
switching to the safe parent.
CRs-fixed: 618986
Change-Id: Ic6b5a19137ad723e72ae68e9266ca70e31a51c49
Signed-off-by: Patrick Daly <pdaly@codeaurora.org>
diff --git a/arch/arm/mach-msm/clock-a7.c b/arch/arm/mach-msm/clock-a7.c
index d09e4b6..a610a23 100644
--- a/arch/arm/mach-msm/clock-a7.c
+++ b/arch/arm/mach-msm/clock-a7.c
@@ -97,9 +97,7 @@
static int cortex_enable(struct mux_div_clk *md)
{
- u32 src_sel = parent_to_src_sel(md->parents, md->num_parents,
- md->c.parent);
- return cortex_set_config(md, src_sel, md->data.div);
+ return cortex_set_config(md, md->src_sel, md->data.div);
}
static void cortex_disable(struct mux_div_clk *md)