blob: 5c4790a7133e86d2888ca9cf2aa223bda55a7893 [file] [log] [blame]
buzbee311ca162013-02-28 15:56:43 -08001/*
2 * Copyright (C) 2011 The Android Open Source Project
3 *
4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at
7 *
8 * http://www.apache.org/licenses/LICENSE-2.0
9 *
10 * Unless required by applicable law or agreed to in writing, software
11 * distributed under the License is distributed on an "AS IS" BASIS,
12 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13 * See the License for the specific language governing permissions and
14 * limitations under the License.
15 */
16
Ian Rogerse77493c2014-08-20 15:08:45 -070017#include "base/bit_vector-inl.h"
buzbee311ca162013-02-28 15:56:43 -080018#include "compiler_internals.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070019#include "dataflow_iterator-inl.h"
Vladimir Marko95a05972014-05-30 10:01:32 +010020#include "global_value_numbering.h"
buzbee311ca162013-02-28 15:56:43 -080021#include "local_value_numbering.h"
Vladimir Markoaf6925b2014-10-31 16:37:32 +000022#include "mir_field_info.h"
Ian Rogers6a3c1fc2014-10-31 00:33:20 -070023#include "quick/dex_file_method_inliner.h"
24#include "quick/dex_file_to_method_inliner_map.h"
Andreas Gampe53c913b2014-08-12 23:19:23 -070025#include "stack.h"
Vladimir Marko69f08ba2014-04-11 12:28:11 +010026#include "utils/scoped_arena_containers.h"
buzbee311ca162013-02-28 15:56:43 -080027
28namespace art {
29
Brian Carlstrom2ce745c2013-07-17 17:44:30 -070030static unsigned int Predecessors(BasicBlock* bb) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +010031 return bb->predecessors.size();
buzbee311ca162013-02-28 15:56:43 -080032}
33
34/* Setup a constant value for opcodes thare have the DF_SETS_CONST attribute */
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070035void MIRGraph::SetConstant(int32_t ssa_reg, int32_t value) {
buzbee862a7602013-04-05 10:58:54 -070036 is_constant_v_->SetBit(ssa_reg);
buzbee311ca162013-02-28 15:56:43 -080037 constant_values_[ssa_reg] = value;
38}
39
Razvan A Lupusorud04d3092014-08-04 12:30:20 -070040void MIRGraph::SetConstantWide(int32_t ssa_reg, int64_t value) {
buzbee862a7602013-04-05 10:58:54 -070041 is_constant_v_->SetBit(ssa_reg);
Serguei Katkov597da1f2014-07-15 17:25:46 +070042 is_constant_v_->SetBit(ssa_reg + 1);
buzbee311ca162013-02-28 15:56:43 -080043 constant_values_[ssa_reg] = Low32Bits(value);
44 constant_values_[ssa_reg + 1] = High32Bits(value);
45}
46
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -080047void MIRGraph::DoConstantPropagation(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -080048 MIR* mir;
buzbee311ca162013-02-28 15:56:43 -080049
50 for (mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070051 // Skip pass if BB has MIR without SSA representation.
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070052 if (mir->ssa_rep == nullptr) {
Alexei Zavjalov9d894662014-04-21 20:45:24 +070053 return;
54 }
55
Jean Christophe Beylercc794c32014-05-02 09:34:13 -070056 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -080057
Ian Rogers29a26482014-05-02 15:27:29 -070058 MIR::DecodedInstruction* d_insn = &mir->dalvikInsn;
buzbee311ca162013-02-28 15:56:43 -080059
60 if (!(df_attributes & DF_HAS_DEFS)) continue;
61
62 /* Handle instructions that set up constants directly */
63 if (df_attributes & DF_SETS_CONST) {
64 if (df_attributes & DF_DA) {
65 int32_t vB = static_cast<int32_t>(d_insn->vB);
66 switch (d_insn->opcode) {
67 case Instruction::CONST_4:
68 case Instruction::CONST_16:
69 case Instruction::CONST:
70 SetConstant(mir->ssa_rep->defs[0], vB);
71 break;
72 case Instruction::CONST_HIGH16:
73 SetConstant(mir->ssa_rep->defs[0], vB << 16);
74 break;
75 case Instruction::CONST_WIDE_16:
76 case Instruction::CONST_WIDE_32:
77 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB));
78 break;
79 case Instruction::CONST_WIDE:
Brian Carlstromb1eba212013-07-17 18:07:19 -070080 SetConstantWide(mir->ssa_rep->defs[0], d_insn->vB_wide);
buzbee311ca162013-02-28 15:56:43 -080081 break;
82 case Instruction::CONST_WIDE_HIGH16:
83 SetConstantWide(mir->ssa_rep->defs[0], static_cast<int64_t>(vB) << 48);
84 break;
85 default:
86 break;
87 }
88 }
89 /* Handle instructions that set up constants directly */
90 } else if (df_attributes & DF_IS_MOVE) {
91 int i;
92
93 for (i = 0; i < mir->ssa_rep->num_uses; i++) {
buzbee862a7602013-04-05 10:58:54 -070094 if (!is_constant_v_->IsBitSet(mir->ssa_rep->uses[i])) break;
buzbee311ca162013-02-28 15:56:43 -080095 }
96 /* Move a register holding a constant to another register */
97 if (i == mir->ssa_rep->num_uses) {
98 SetConstant(mir->ssa_rep->defs[0], constant_values_[mir->ssa_rep->uses[0]]);
99 if (df_attributes & DF_A_WIDE) {
100 SetConstant(mir->ssa_rep->defs[1], constant_values_[mir->ssa_rep->uses[1]]);
101 }
102 }
103 }
104 }
105 /* TODO: implement code to handle arithmetic operations */
buzbee311ca162013-02-28 15:56:43 -0800106}
107
buzbee311ca162013-02-28 15:56:43 -0800108/* Advance to next strictly dominated MIR node in an extended basic block */
buzbee0d829482013-10-11 15:24:55 -0700109MIR* MIRGraph::AdvanceMIR(BasicBlock** p_bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800110 BasicBlock* bb = *p_bb;
111 if (mir != NULL) {
112 mir = mir->next;
113 if (mir == NULL) {
buzbee0d829482013-10-11 15:24:55 -0700114 bb = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800115 if ((bb == NULL) || Predecessors(bb) != 1) {
116 mir = NULL;
117 } else {
118 *p_bb = bb;
119 mir = bb->first_mir_insn;
120 }
121 }
122 }
123 return mir;
124}
125
126/*
127 * To be used at an invoke mir. If the logically next mir node represents
128 * a move-result, return it. Else, return NULL. If a move-result exists,
129 * it is required to immediately follow the invoke with no intervening
130 * opcodes or incoming arcs. However, if the result of the invoke is not
131 * used, a move-result may not be present.
132 */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700133MIR* MIRGraph::FindMoveResult(BasicBlock* bb, MIR* mir) {
buzbee311ca162013-02-28 15:56:43 -0800134 BasicBlock* tbb = bb;
135 mir = AdvanceMIR(&tbb, mir);
136 while (mir != NULL) {
buzbee311ca162013-02-28 15:56:43 -0800137 if ((mir->dalvikInsn.opcode == Instruction::MOVE_RESULT) ||
138 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_OBJECT) ||
139 (mir->dalvikInsn.opcode == Instruction::MOVE_RESULT_WIDE)) {
140 break;
141 }
142 // Keep going if pseudo op, otherwise terminate
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -0700143 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee311ca162013-02-28 15:56:43 -0800144 mir = AdvanceMIR(&tbb, mir);
buzbee35ba7f32014-05-31 08:59:01 -0700145 } else {
146 mir = NULL;
buzbee311ca162013-02-28 15:56:43 -0800147 }
148 }
149 return mir;
150}
151
buzbee0d829482013-10-11 15:24:55 -0700152BasicBlock* MIRGraph::NextDominatedBlock(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800153 if (bb->block_type == kDead) {
154 return NULL;
155 }
156 DCHECK((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
157 || (bb->block_type == kExitBlock));
buzbee0d829482013-10-11 15:24:55 -0700158 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
159 BasicBlock* bb_fall_through = GetBasicBlock(bb->fall_through);
buzbee1da1e2f2013-11-15 13:37:01 -0800160 if (((bb_fall_through == NULL) && (bb_taken != NULL)) &&
buzbee0d829482013-10-11 15:24:55 -0700161 ((bb_taken->block_type == kDalvikByteCode) || (bb_taken->block_type == kExitBlock))) {
buzbeecbcfaf32013-08-19 07:37:40 -0700162 // Follow simple unconditional branches.
buzbee0d829482013-10-11 15:24:55 -0700163 bb = bb_taken;
buzbeecbcfaf32013-08-19 07:37:40 -0700164 } else {
165 // Follow simple fallthrough
buzbee0d829482013-10-11 15:24:55 -0700166 bb = (bb_taken != NULL) ? NULL : bb_fall_through;
buzbeecbcfaf32013-08-19 07:37:40 -0700167 }
buzbee311ca162013-02-28 15:56:43 -0800168 if (bb == NULL || (Predecessors(bb) != 1)) {
169 return NULL;
170 }
171 DCHECK((bb->block_type == kDalvikByteCode) || (bb->block_type == kExitBlock));
172 return bb;
173}
174
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700175static MIR* FindPhi(BasicBlock* bb, int ssa_name) {
buzbee311ca162013-02-28 15:56:43 -0800176 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
177 if (static_cast<int>(mir->dalvikInsn.opcode) == kMirOpPhi) {
178 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
179 if (mir->ssa_rep->uses[i] == ssa_name) {
180 return mir;
181 }
182 }
183 }
184 }
185 return NULL;
186}
187
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700188static SelectInstructionKind SelectKind(MIR* mir) {
Chao-ying Fu8ac41af2014-10-01 16:53:04 -0700189 // Work with the case when mir is nullptr.
190 if (mir == nullptr) {
191 return kSelectNone;
192 }
buzbee311ca162013-02-28 15:56:43 -0800193 switch (mir->dalvikInsn.opcode) {
194 case Instruction::MOVE:
195 case Instruction::MOVE_OBJECT:
196 case Instruction::MOVE_16:
197 case Instruction::MOVE_OBJECT_16:
198 case Instruction::MOVE_FROM16:
199 case Instruction::MOVE_OBJECT_FROM16:
200 return kSelectMove;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700201 case Instruction::CONST:
202 case Instruction::CONST_4:
203 case Instruction::CONST_16:
buzbee311ca162013-02-28 15:56:43 -0800204 return kSelectConst;
Brian Carlstrom6f485c62013-07-18 15:35:35 -0700205 case Instruction::GOTO:
206 case Instruction::GOTO_16:
207 case Instruction::GOTO_32:
buzbee311ca162013-02-28 15:56:43 -0800208 return kSelectGoto;
Brian Carlstrom02c8cc62013-07-18 15:54:44 -0700209 default:
210 return kSelectNone;
buzbee311ca162013-02-28 15:56:43 -0800211 }
buzbee311ca162013-02-28 15:56:43 -0800212}
213
Vladimir Markoa1a70742014-03-03 10:28:05 +0000214static constexpr ConditionCode kIfCcZConditionCodes[] = {
215 kCondEq, kCondNe, kCondLt, kCondGe, kCondGt, kCondLe
216};
217
Andreas Gampe785d2f22014-11-03 22:57:30 -0800218static_assert(arraysize(kIfCcZConditionCodes) == Instruction::IF_LEZ - Instruction::IF_EQZ + 1,
219 "if_ccz_ccodes_size1");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000220
Vladimir Markoa1a70742014-03-03 10:28:05 +0000221static constexpr ConditionCode ConditionCodeForIfCcZ(Instruction::Code opcode) {
222 return kIfCcZConditionCodes[opcode - Instruction::IF_EQZ];
223}
224
Andreas Gampe785d2f22014-11-03 22:57:30 -0800225static_assert(ConditionCodeForIfCcZ(Instruction::IF_EQZ) == kCondEq, "if_eqz ccode");
226static_assert(ConditionCodeForIfCcZ(Instruction::IF_NEZ) == kCondNe, "if_nez ccode");
227static_assert(ConditionCodeForIfCcZ(Instruction::IF_LTZ) == kCondLt, "if_ltz ccode");
228static_assert(ConditionCodeForIfCcZ(Instruction::IF_GEZ) == kCondGe, "if_gez ccode");
229static_assert(ConditionCodeForIfCcZ(Instruction::IF_GTZ) == kCondGt, "if_gtz ccode");
230static_assert(ConditionCodeForIfCcZ(Instruction::IF_LEZ) == kCondLe, "if_lez ccode");
Vladimir Markoa1a70742014-03-03 10:28:05 +0000231
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700232int MIRGraph::GetSSAUseCount(int s_reg) {
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100233 DCHECK_LT(static_cast<size_t>(s_reg), ssa_subscripts_.size());
234 return raw_use_counts_[s_reg];
buzbee311ca162013-02-28 15:56:43 -0800235}
236
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700237size_t MIRGraph::GetNumBytesForSpecialTemps() const {
238 // This logic is written with assumption that Method* is only special temp.
239 DCHECK_EQ(max_available_special_compiler_temps_, 1u);
240 return sizeof(StackReference<mirror::ArtMethod>);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800241}
242
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700243size_t MIRGraph::GetNumAvailableVRTemps() {
244 // First take into account all temps reserved for backend.
245 if (max_available_non_special_compiler_temps_ < reserved_temps_for_backend_) {
246 return 0;
247 }
248
249 // Calculate remaining ME temps available.
250 size_t remaining_me_temps = max_available_non_special_compiler_temps_ - reserved_temps_for_backend_;
251
252 if (num_non_special_compiler_temps_ >= remaining_me_temps) {
253 return 0;
254 } else {
255 return remaining_me_temps - num_non_special_compiler_temps_;
256 }
257}
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000258
259// FIXME - will probably need to revisit all uses of this, as type not defined.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800260static const RegLocation temp_loc = {kLocCompilerTemp,
buzbee091cc402014-03-31 10:14:40 -0700261 0, 1 /*defined*/, 0, 0, 0, 0, 0, 1 /*home*/,
Bill Buzbee00e1ec62014-02-27 23:44:13 +0000262 RegStorage(), INVALID_SREG, INVALID_SREG};
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800263
264CompilerTemp* MIRGraph::GetNewCompilerTemp(CompilerTempType ct_type, bool wide) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700265 // Once the compiler temps have been committed, new ones cannot be requested anymore.
266 DCHECK_EQ(compiler_temps_committed_, false);
267 // Make sure that reserved for BE set is sane.
268 DCHECK_LE(reserved_temps_for_backend_, max_available_non_special_compiler_temps_);
269
270 bool verbose = cu_->verbose;
271 const char* ct_type_str = nullptr;
272
273 if (verbose) {
274 switch (ct_type) {
275 case kCompilerTempBackend:
276 ct_type_str = "backend";
277 break;
278 case kCompilerTempSpecialMethodPtr:
279 ct_type_str = "method*";
280 break;
281 case kCompilerTempVR:
282 ct_type_str = "VR";
283 break;
284 default:
285 ct_type_str = "unknown";
286 break;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800287 }
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700288 LOG(INFO) << "CompilerTemps: A compiler temp of type " << ct_type_str << " that is "
289 << (wide ? "wide is being requested." : "not wide is being requested.");
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800290 }
291
292 CompilerTemp *compiler_temp = static_cast<CompilerTemp *>(arena_->Alloc(sizeof(CompilerTemp),
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000293 kArenaAllocRegAlloc));
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800294
295 // Create the type of temp requested. Special temps need special handling because
296 // they have a specific virtual register assignment.
297 if (ct_type == kCompilerTempSpecialMethodPtr) {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700298 // This has a special location on stack which is 32-bit or 64-bit depending
299 // on mode. However, we don't want to overlap with non-special section
300 // and thus even for 64-bit, we allow only a non-wide temp to be requested.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800301 DCHECK_EQ(wide, false);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800302
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700303 // The vreg is always the first special temp for method ptr.
304 compiler_temp->v_reg = GetFirstSpecialTempVR();
305
306 } else if (ct_type == kCompilerTempBackend) {
307 requested_backend_temp_ = true;
308
309 // Make sure that we are not exceeding temps reserved for BE.
310 // Since VR temps cannot be requested once the BE temps are requested, we
311 // allow reservation of VR temps as well for BE. We
312 size_t available_temps = reserved_temps_for_backend_ + GetNumAvailableVRTemps();
313 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
314 if (verbose) {
315 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
316 }
317 return nullptr;
318 }
319
320 // Update the remaining reserved temps since we have now used them.
321 // Note that the code below is actually subtracting to remove them from reserve
322 // once they have been claimed. It is careful to not go below zero.
323 if (reserved_temps_for_backend_ >= 1) {
324 reserved_temps_for_backend_--;
325 }
326 if (wide && reserved_temps_for_backend_ >= 1) {
327 reserved_temps_for_backend_--;
328 }
329
330 // The new non-special compiler temp must receive a unique v_reg.
331 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
332 num_non_special_compiler_temps_++;
333 } else if (ct_type == kCompilerTempVR) {
334 // Once we start giving out BE temps, we don't allow anymore ME temps to be requested.
335 // This is done in order to prevent problems with ssa since these structures are allocated
336 // and managed by the ME.
337 DCHECK_EQ(requested_backend_temp_, false);
338
339 // There is a limit to the number of non-special temps so check to make sure it wasn't exceeded.
340 size_t available_temps = GetNumAvailableVRTemps();
341 if (available_temps <= 0 || (available_temps <= 1 && wide)) {
342 if (verbose) {
343 LOG(INFO) << "CompilerTemps: Not enough temp(s) of type " << ct_type_str << " are available.";
344 }
345 return nullptr;
346 }
347
348 // The new non-special compiler temp must receive a unique v_reg.
349 compiler_temp->v_reg = GetFirstNonSpecialTempVR() + num_non_special_compiler_temps_;
350 num_non_special_compiler_temps_++;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800351 } else {
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700352 UNIMPLEMENTED(FATAL) << "No handling for compiler temp type " << ct_type_str << ".";
353 }
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800354
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700355 // We allocate an sreg as well to make developer life easier.
356 // However, if this is requested from an ME pass that will recalculate ssa afterwards,
357 // this sreg is no longer valid. The caller should be aware of this.
358 compiler_temp->s_reg_low = AddNewSReg(compiler_temp->v_reg);
359
360 if (verbose) {
361 LOG(INFO) << "CompilerTemps: New temp of type " << ct_type_str << " with v" << compiler_temp->v_reg
362 << " and s" << compiler_temp->s_reg_low << " has been created.";
363 }
364
365 if (wide) {
366 // Only non-special temps are handled as wide for now.
367 // Note that the number of non special temps is incremented below.
368 DCHECK(ct_type == kCompilerTempBackend || ct_type == kCompilerTempVR);
369
370 // Ensure that the two registers are consecutive.
371 int ssa_reg_low = compiler_temp->s_reg_low;
372 int ssa_reg_high = AddNewSReg(compiler_temp->v_reg + 1);
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800373 num_non_special_compiler_temps_++;
374
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700375 if (verbose) {
376 LOG(INFO) << "CompilerTemps: The wide part of temp of type " << ct_type_str << " is v"
377 << compiler_temp->v_reg + 1 << " and s" << ssa_reg_high << ".";
378 }
Chao-ying Fu54d36b62014-05-22 17:25:02 -0700379
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700380 if (reg_location_ != nullptr) {
381 reg_location_[ssa_reg_high] = temp_loc;
382 reg_location_[ssa_reg_high].high_word = true;
383 reg_location_[ssa_reg_high].s_reg_low = ssa_reg_low;
384 reg_location_[ssa_reg_high].wide = true;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800385 }
386 }
387
Razvan A Lupusoru8d0d03e2014-06-06 17:04:52 -0700388 // If the register locations have already been allocated, add the information
389 // about the temp. We will not overflow because they have been initialized
390 // to support the maximum number of temps. For ME temps that have multiple
391 // ssa versions, the structures below will be expanded on the post pass cleanup.
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800392 if (reg_location_ != nullptr) {
393 int ssa_reg_low = compiler_temp->s_reg_low;
394 reg_location_[ssa_reg_low] = temp_loc;
395 reg_location_[ssa_reg_low].s_reg_low = ssa_reg_low;
396 reg_location_[ssa_reg_low].wide = wide;
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800397 }
398
Razvan A Lupusoruda7a69b2014-01-08 15:09:50 -0800399 return compiler_temp;
400}
buzbee311ca162013-02-28 15:56:43 -0800401
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000402static bool EvaluateBranch(Instruction::Code opcode, int32_t src1, int32_t src2) {
403 bool is_taken;
404 switch (opcode) {
405 case Instruction::IF_EQ: is_taken = (src1 == src2); break;
406 case Instruction::IF_NE: is_taken = (src1 != src2); break;
407 case Instruction::IF_LT: is_taken = (src1 < src2); break;
408 case Instruction::IF_GE: is_taken = (src1 >= src2); break;
409 case Instruction::IF_GT: is_taken = (src1 > src2); break;
410 case Instruction::IF_LE: is_taken = (src1 <= src2); break;
411 case Instruction::IF_EQZ: is_taken = (src1 == 0); break;
412 case Instruction::IF_NEZ: is_taken = (src1 != 0); break;
413 case Instruction::IF_LTZ: is_taken = (src1 < 0); break;
414 case Instruction::IF_GEZ: is_taken = (src1 >= 0); break;
415 case Instruction::IF_GTZ: is_taken = (src1 > 0); break;
416 case Instruction::IF_LEZ: is_taken = (src1 <= 0); break;
417 default:
418 LOG(FATAL) << "Unexpected opcode " << opcode;
419 UNREACHABLE();
420 }
421 return is_taken;
422}
423
buzbee311ca162013-02-28 15:56:43 -0800424/* Do some MIR-level extended basic block optimizations */
Brian Carlstrom2ce745c2013-07-17 17:44:30 -0700425bool MIRGraph::BasicBlockOpt(BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800426 if (bb->block_type == kDead) {
427 return true;
428 }
Vladimir Marko415ac882014-09-30 18:09:14 +0100429 bool use_lvn = bb->use_lvn && (cu_->disable_opt & (1u << kLocalValueNumbering)) == 0u;
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100430 std::unique_ptr<ScopedArenaAllocator> allocator;
Vladimir Marko95a05972014-05-30 10:01:32 +0100431 std::unique_ptr<GlobalValueNumbering> global_valnum;
Ian Rogers700a4022014-05-19 16:49:03 -0700432 std::unique_ptr<LocalValueNumbering> local_valnum;
buzbee1da1e2f2013-11-15 13:37:01 -0800433 if (use_lvn) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100434 allocator.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Marko415ac882014-09-30 18:09:14 +0100435 global_valnum.reset(new (allocator.get()) GlobalValueNumbering(cu_, allocator.get(),
436 GlobalValueNumbering::kModeLvn));
Vladimir Markob19955d2014-07-29 12:04:10 +0100437 local_valnum.reset(new (allocator.get()) LocalValueNumbering(global_valnum.get(), bb->id,
438 allocator.get()));
buzbee1da1e2f2013-11-15 13:37:01 -0800439 }
buzbee311ca162013-02-28 15:56:43 -0800440 while (bb != NULL) {
441 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
442 // TUNING: use the returned value number for CSE.
buzbee1da1e2f2013-11-15 13:37:01 -0800443 if (use_lvn) {
444 local_valnum->GetValueNumber(mir);
445 }
buzbee311ca162013-02-28 15:56:43 -0800446 // Look for interesting opcodes, skip otherwise
447 Instruction::Code opcode = mir->dalvikInsn.opcode;
448 switch (opcode) {
Vladimir Marko7ab2fce2014-11-28 13:38:28 +0000449 case Instruction::IF_EQ:
450 case Instruction::IF_NE:
451 case Instruction::IF_LT:
452 case Instruction::IF_GE:
453 case Instruction::IF_GT:
454 case Instruction::IF_LE:
455 if (!IsConst(mir->ssa_rep->uses[1])) {
456 break;
457 }
458 FALLTHROUGH_INTENDED;
459 case Instruction::IF_EQZ:
460 case Instruction::IF_NEZ:
461 case Instruction::IF_LTZ:
462 case Instruction::IF_GEZ:
463 case Instruction::IF_GTZ:
464 case Instruction::IF_LEZ:
465 // Result known at compile time?
466 if (IsConst(mir->ssa_rep->uses[0])) {
467 int32_t rhs = (mir->ssa_rep->num_uses == 2) ? ConstantValue(mir->ssa_rep->uses[1]) : 0;
468 bool is_taken = EvaluateBranch(opcode, ConstantValue(mir->ssa_rep->uses[0]), rhs);
469 BasicBlockId edge_to_kill = is_taken ? bb->fall_through : bb->taken;
470 if (is_taken) {
471 // Replace with GOTO.
472 bb->fall_through = NullBasicBlockId;
473 mir->dalvikInsn.opcode = Instruction::GOTO;
474 mir->dalvikInsn.vA =
475 IsInstructionIfCc(opcode) ? mir->dalvikInsn.vC : mir->dalvikInsn.vB;
476 } else {
477 // Make NOP.
478 bb->taken = NullBasicBlockId;
479 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
480 }
481 mir->ssa_rep->num_uses = 0;
482 BasicBlock* successor_to_unlink = GetBasicBlock(edge_to_kill);
483 successor_to_unlink->ErasePredecessor(bb->id);
484 if (successor_to_unlink->predecessors.empty()) {
485 successor_to_unlink->KillUnreachable(this);
486 }
487 }
488 break;
buzbee311ca162013-02-28 15:56:43 -0800489 case Instruction::CMPL_FLOAT:
490 case Instruction::CMPL_DOUBLE:
491 case Instruction::CMPG_FLOAT:
492 case Instruction::CMPG_DOUBLE:
493 case Instruction::CMP_LONG:
buzbee1fd33462013-03-25 13:40:45 -0700494 if ((cu_->disable_opt & (1 << kBranchFusing)) != 0) {
buzbee311ca162013-02-28 15:56:43 -0800495 // Bitcode doesn't allow this optimization.
496 break;
497 }
498 if (mir->next != NULL) {
499 MIR* mir_next = mir->next;
buzbee311ca162013-02-28 15:56:43 -0800500 // Make sure result of cmp is used by next insn and nowhere else
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700501 if (IsInstructionIfCcZ(mir_next->dalvikInsn.opcode) &&
buzbee311ca162013-02-28 15:56:43 -0800502 (mir->ssa_rep->defs[0] == mir_next->ssa_rep->uses[0]) &&
503 (GetSSAUseCount(mir->ssa_rep->defs[0]) == 1)) {
Vladimir Markoa1a70742014-03-03 10:28:05 +0000504 mir_next->meta.ccode = ConditionCodeForIfCcZ(mir_next->dalvikInsn.opcode);
Brian Carlstromdf629502013-07-17 22:39:56 -0700505 switch (opcode) {
buzbee311ca162013-02-28 15:56:43 -0800506 case Instruction::CMPL_FLOAT:
507 mir_next->dalvikInsn.opcode =
508 static_cast<Instruction::Code>(kMirOpFusedCmplFloat);
509 break;
510 case Instruction::CMPL_DOUBLE:
511 mir_next->dalvikInsn.opcode =
512 static_cast<Instruction::Code>(kMirOpFusedCmplDouble);
513 break;
514 case Instruction::CMPG_FLOAT:
515 mir_next->dalvikInsn.opcode =
516 static_cast<Instruction::Code>(kMirOpFusedCmpgFloat);
517 break;
518 case Instruction::CMPG_DOUBLE:
519 mir_next->dalvikInsn.opcode =
520 static_cast<Instruction::Code>(kMirOpFusedCmpgDouble);
521 break;
522 case Instruction::CMP_LONG:
523 mir_next->dalvikInsn.opcode =
524 static_cast<Instruction::Code>(kMirOpFusedCmpLong);
525 break;
526 default: LOG(ERROR) << "Unexpected opcode: " << opcode;
527 }
528 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700529 // Copy the SSA information that is relevant.
buzbee311ca162013-02-28 15:56:43 -0800530 mir_next->ssa_rep->num_uses = mir->ssa_rep->num_uses;
531 mir_next->ssa_rep->uses = mir->ssa_rep->uses;
532 mir_next->ssa_rep->fp_use = mir->ssa_rep->fp_use;
533 mir_next->ssa_rep->num_defs = 0;
534 mir->ssa_rep->num_uses = 0;
535 mir->ssa_rep->num_defs = 0;
Jean Christophe Beylerc26efa82014-06-01 11:39:39 -0700536 // Copy in the decoded instruction information for potential SSA re-creation.
537 mir_next->dalvikInsn.vA = mir->dalvikInsn.vB;
538 mir_next->dalvikInsn.vB = mir->dalvikInsn.vC;
buzbee311ca162013-02-28 15:56:43 -0800539 }
540 }
541 break;
buzbee311ca162013-02-28 15:56:43 -0800542 default:
543 break;
544 }
545 // Is this the select pattern?
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800546 // TODO: flesh out support for Mips. NOTE: llvm's select op doesn't quite work here.
buzbee311ca162013-02-28 15:56:43 -0800547 // TUNING: expand to support IF_xx compare & branches
Nicolas Geoffrayb34f69a2014-03-07 15:28:39 +0000548 if (!cu_->compiler->IsPortable() &&
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100549 (cu_->instruction_set == kArm64 || cu_->instruction_set == kThumb2 ||
550 cu_->instruction_set == kX86 || cu_->instruction_set == kX86_64) &&
Vladimir Markoa1a70742014-03-03 10:28:05 +0000551 IsInstructionIfCcZ(mir->dalvikInsn.opcode)) {
buzbee0d829482013-10-11 15:24:55 -0700552 BasicBlock* ft = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800553 DCHECK(ft != NULL);
buzbee0d829482013-10-11 15:24:55 -0700554 BasicBlock* ft_ft = GetBasicBlock(ft->fall_through);
555 BasicBlock* ft_tk = GetBasicBlock(ft->taken);
buzbee311ca162013-02-28 15:56:43 -0800556
buzbee0d829482013-10-11 15:24:55 -0700557 BasicBlock* tk = GetBasicBlock(bb->taken);
buzbee311ca162013-02-28 15:56:43 -0800558 DCHECK(tk != NULL);
buzbee0d829482013-10-11 15:24:55 -0700559 BasicBlock* tk_ft = GetBasicBlock(tk->fall_through);
560 BasicBlock* tk_tk = GetBasicBlock(tk->taken);
buzbee311ca162013-02-28 15:56:43 -0800561
562 /*
563 * In the select pattern, the taken edge goes to a block that unconditionally
564 * transfers to the rejoin block and the fall_though edge goes to a block that
565 * unconditionally falls through to the rejoin block.
566 */
567 if ((tk_ft == NULL) && (ft_tk == NULL) && (tk_tk == ft_ft) &&
568 (Predecessors(tk) == 1) && (Predecessors(ft) == 1)) {
569 /*
Vladimir Marko8b858e12014-11-27 14:52:37 +0000570 * Okay - we have the basic diamond shape.
buzbee311ca162013-02-28 15:56:43 -0800571 */
Serban Constantinescu05e27ff2014-05-28 13:21:45 +0100572
573 // TODO: Add logic for LONG.
buzbee311ca162013-02-28 15:56:43 -0800574 // Are the block bodies something we can handle?
575 if ((ft->first_mir_insn == ft->last_mir_insn) &&
576 (tk->first_mir_insn != tk->last_mir_insn) &&
577 (tk->first_mir_insn->next == tk->last_mir_insn) &&
578 ((SelectKind(ft->first_mir_insn) == kSelectMove) ||
579 (SelectKind(ft->first_mir_insn) == kSelectConst)) &&
580 (SelectKind(ft->first_mir_insn) == SelectKind(tk->first_mir_insn)) &&
581 (SelectKind(tk->last_mir_insn) == kSelectGoto)) {
582 // Almost there. Are the instructions targeting the same vreg?
583 MIR* if_true = tk->first_mir_insn;
584 MIR* if_false = ft->first_mir_insn;
585 // It's possible that the target of the select isn't used - skip those (rare) cases.
586 MIR* phi = FindPhi(tk_tk, if_true->ssa_rep->defs[0]);
587 if ((phi != NULL) && (if_true->dalvikInsn.vA == if_false->dalvikInsn.vA)) {
588 /*
589 * We'll convert the IF_EQZ/IF_NEZ to a SELECT. We need to find the
590 * Phi node in the merge block and delete it (while using the SSA name
591 * of the merge as the target of the SELECT. Delete both taken and
592 * fallthrough blocks, and set fallthrough to merge block.
593 * NOTE: not updating other dataflow info (no longer used at this point).
594 * If this changes, need to update i_dom, etc. here (and in CombineBlocks).
595 */
Vladimir Markoa1a70742014-03-03 10:28:05 +0000596 mir->meta.ccode = ConditionCodeForIfCcZ(mir->dalvikInsn.opcode);
buzbee311ca162013-02-28 15:56:43 -0800597 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpSelect);
598 bool const_form = (SelectKind(if_true) == kSelectConst);
599 if ((SelectKind(if_true) == kSelectMove)) {
600 if (IsConst(if_true->ssa_rep->uses[0]) &&
601 IsConst(if_false->ssa_rep->uses[0])) {
602 const_form = true;
603 if_true->dalvikInsn.vB = ConstantValue(if_true->ssa_rep->uses[0]);
604 if_false->dalvikInsn.vB = ConstantValue(if_false->ssa_rep->uses[0]);
605 }
606 }
607 if (const_form) {
Razvan A Lupusorue27b3bf2014-01-23 09:41:45 -0800608 /*
609 * TODO: If both constants are the same value, then instead of generating
610 * a select, we should simply generate a const bytecode. This should be
611 * considered after inlining which can lead to CFG of this form.
612 */
buzbee311ca162013-02-28 15:56:43 -0800613 // "true" set val in vB
614 mir->dalvikInsn.vB = if_true->dalvikInsn.vB;
615 // "false" set val in vC
616 mir->dalvikInsn.vC = if_false->dalvikInsn.vB;
617 } else {
618 DCHECK_EQ(SelectKind(if_true), kSelectMove);
619 DCHECK_EQ(SelectKind(if_false), kSelectMove);
buzbee862a7602013-04-05 10:58:54 -0700620 int* src_ssa =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000621 static_cast<int*>(arena_->Alloc(sizeof(int) * 3, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800622 src_ssa[0] = mir->ssa_rep->uses[0];
623 src_ssa[1] = if_true->ssa_rep->uses[0];
624 src_ssa[2] = if_false->ssa_rep->uses[0];
625 mir->ssa_rep->uses = src_ssa;
626 mir->ssa_rep->num_uses = 3;
627 }
628 mir->ssa_rep->num_defs = 1;
buzbee862a7602013-04-05 10:58:54 -0700629 mir->ssa_rep->defs =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000630 static_cast<int*>(arena_->Alloc(sizeof(int) * 1, kArenaAllocDFInfo));
buzbee862a7602013-04-05 10:58:54 -0700631 mir->ssa_rep->fp_def =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000632 static_cast<bool*>(arena_->Alloc(sizeof(bool) * 1, kArenaAllocDFInfo));
buzbee311ca162013-02-28 15:56:43 -0800633 mir->ssa_rep->fp_def[0] = if_true->ssa_rep->fp_def[0];
buzbee817e45a2013-05-30 18:59:12 -0700634 // Match type of uses to def.
635 mir->ssa_rep->fp_use =
Mathieu Chartierf6c4b3b2013-08-24 16:11:37 -0700636 static_cast<bool*>(arena_->Alloc(sizeof(bool) * mir->ssa_rep->num_uses,
Vladimir Marko83cc7ae2014-02-12 18:02:05 +0000637 kArenaAllocDFInfo));
buzbee817e45a2013-05-30 18:59:12 -0700638 for (int i = 0; i < mir->ssa_rep->num_uses; i++) {
639 mir->ssa_rep->fp_use[i] = mir->ssa_rep->fp_def[0];
640 }
buzbee311ca162013-02-28 15:56:43 -0800641 /*
642 * There is usually a Phi node in the join block for our two cases. If the
643 * Phi node only contains our two cases as input, we will use the result
644 * SSA name of the Phi node as our select result and delete the Phi. If
645 * the Phi node has more than two operands, we will arbitrarily use the SSA
646 * name of the "true" path, delete the SSA name of the "false" path from the
647 * Phi node (and fix up the incoming arc list).
648 */
649 if (phi->ssa_rep->num_uses == 2) {
650 mir->ssa_rep->defs[0] = phi->ssa_rep->defs[0];
651 phi->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
652 } else {
653 int dead_def = if_false->ssa_rep->defs[0];
654 int live_def = if_true->ssa_rep->defs[0];
655 mir->ssa_rep->defs[0] = live_def;
buzbee0d829482013-10-11 15:24:55 -0700656 BasicBlockId* incoming = phi->meta.phi_incoming;
buzbee311ca162013-02-28 15:56:43 -0800657 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
658 if (phi->ssa_rep->uses[i] == live_def) {
659 incoming[i] = bb->id;
660 }
661 }
662 for (int i = 0; i < phi->ssa_rep->num_uses; i++) {
663 if (phi->ssa_rep->uses[i] == dead_def) {
664 int last_slot = phi->ssa_rep->num_uses - 1;
665 phi->ssa_rep->uses[i] = phi->ssa_rep->uses[last_slot];
666 incoming[i] = incoming[last_slot];
667 }
668 }
669 }
670 phi->ssa_rep->num_uses--;
buzbee0d829482013-10-11 15:24:55 -0700671 bb->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800672 tk->block_type = kDead;
673 for (MIR* tmir = ft->first_mir_insn; tmir != NULL; tmir = tmir->next) {
674 tmir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
675 }
676 }
677 }
678 }
679 }
680 }
buzbee1da1e2f2013-11-15 13:37:01 -0800681 bb = ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) ? NextDominatedBlock(bb) : NULL;
buzbee311ca162013-02-28 15:56:43 -0800682 }
Vladimir Marko95a05972014-05-30 10:01:32 +0100683 if (use_lvn && UNLIKELY(!global_valnum->Good())) {
Vladimir Marko2ac01fc2014-05-22 12:09:08 +0100684 LOG(WARNING) << "LVN overflow in " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
685 }
buzbee311ca162013-02-28 15:56:43 -0800686
buzbee311ca162013-02-28 15:56:43 -0800687 return true;
688}
689
buzbee311ca162013-02-28 15:56:43 -0800690/* Collect stats on number of checks removed */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700691void MIRGraph::CountChecks(class BasicBlock* bb) {
buzbee862a7602013-04-05 10:58:54 -0700692 if (bb->data_flow_info != NULL) {
693 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
694 if (mir->ssa_rep == NULL) {
695 continue;
buzbee311ca162013-02-28 15:56:43 -0800696 }
Jean Christophe Beylercc794c32014-05-02 09:34:13 -0700697 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee862a7602013-04-05 10:58:54 -0700698 if (df_attributes & DF_HAS_NULL_CHKS) {
699 checkstats_->null_checks++;
700 if (mir->optimization_flags & MIR_IGNORE_NULL_CHECK) {
701 checkstats_->null_checks_eliminated++;
702 }
703 }
704 if (df_attributes & DF_HAS_RANGE_CHKS) {
705 checkstats_->range_checks++;
706 if (mir->optimization_flags & MIR_IGNORE_RANGE_CHECK) {
707 checkstats_->range_checks_eliminated++;
708 }
buzbee311ca162013-02-28 15:56:43 -0800709 }
710 }
711 }
buzbee311ca162013-02-28 15:56:43 -0800712}
713
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700714/* Try to make common case the fallthrough path. */
buzbee0d829482013-10-11 15:24:55 -0700715bool MIRGraph::LayoutBlocks(BasicBlock* bb) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700716 // TODO: For now, just looking for direct throws. Consider generalizing for profile feedback.
buzbee311ca162013-02-28 15:56:43 -0800717 if (!bb->explicit_throw) {
718 return false;
719 }
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700720
721 // If we visited it, we are done.
722 if (bb->visited) {
723 return false;
724 }
725 bb->visited = true;
726
buzbee311ca162013-02-28 15:56:43 -0800727 BasicBlock* walker = bb;
728 while (true) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700729 // Check termination conditions.
buzbee311ca162013-02-28 15:56:43 -0800730 if ((walker->block_type == kEntryBlock) || (Predecessors(walker) != 1)) {
731 break;
732 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100733 DCHECK(!walker->predecessors.empty());
734 BasicBlock* prev = GetBasicBlock(walker->predecessors[0]);
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700735
736 // If we visited the predecessor, we are done.
737 if (prev->visited) {
738 return false;
739 }
740 prev->visited = true;
741
buzbee311ca162013-02-28 15:56:43 -0800742 if (prev->conditional_branch) {
buzbee0d829482013-10-11 15:24:55 -0700743 if (GetBasicBlock(prev->fall_through) == walker) {
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700744 // Already done - return.
buzbee311ca162013-02-28 15:56:43 -0800745 break;
746 }
buzbee0d829482013-10-11 15:24:55 -0700747 DCHECK_EQ(walker, GetBasicBlock(prev->taken));
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700748 // Got one. Flip it and exit.
buzbee311ca162013-02-28 15:56:43 -0800749 Instruction::Code opcode = prev->last_mir_insn->dalvikInsn.opcode;
750 switch (opcode) {
751 case Instruction::IF_EQ: opcode = Instruction::IF_NE; break;
752 case Instruction::IF_NE: opcode = Instruction::IF_EQ; break;
753 case Instruction::IF_LT: opcode = Instruction::IF_GE; break;
754 case Instruction::IF_GE: opcode = Instruction::IF_LT; break;
755 case Instruction::IF_GT: opcode = Instruction::IF_LE; break;
756 case Instruction::IF_LE: opcode = Instruction::IF_GT; break;
757 case Instruction::IF_EQZ: opcode = Instruction::IF_NEZ; break;
758 case Instruction::IF_NEZ: opcode = Instruction::IF_EQZ; break;
759 case Instruction::IF_LTZ: opcode = Instruction::IF_GEZ; break;
760 case Instruction::IF_GEZ: opcode = Instruction::IF_LTZ; break;
761 case Instruction::IF_GTZ: opcode = Instruction::IF_LEZ; break;
762 case Instruction::IF_LEZ: opcode = Instruction::IF_GTZ; break;
763 default: LOG(FATAL) << "Unexpected opcode " << opcode;
764 }
765 prev->last_mir_insn->dalvikInsn.opcode = opcode;
buzbee0d829482013-10-11 15:24:55 -0700766 BasicBlockId t_bb = prev->taken;
buzbee311ca162013-02-28 15:56:43 -0800767 prev->taken = prev->fall_through;
768 prev->fall_through = t_bb;
769 break;
770 }
771 walker = prev;
Jean Christophe Beyler75bcc372014-09-04 08:15:11 -0700772
773 if (walker->visited) {
774 break;
775 }
buzbee311ca162013-02-28 15:56:43 -0800776 }
777 return false;
778}
779
780/* Combine any basic blocks terminated by instructions that we now know can't throw */
Ian Rogers6a3c1fc2014-10-31 00:33:20 -0700781void MIRGraph::CombineBlocks(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -0800782 // Loop here to allow combining a sequence of blocks
Vladimir Marko312eb252014-10-07 15:01:57 +0100783 while ((bb->block_type == kDalvikByteCode) &&
784 (bb->last_mir_insn != nullptr) &&
785 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) == kMirOpCheck)) {
786 MIR* mir = bb->last_mir_insn;
787 DCHECK(bb->first_mir_insn != nullptr);
788
789 // Grab the attributes from the paired opcode.
790 MIR* throw_insn = mir->meta.throw_insn;
791 uint64_t df_attributes = GetDataFlowAttributes(throw_insn);
792
793 // Don't combine if the throw_insn can still throw NPE.
794 if ((df_attributes & DF_HAS_NULL_CHKS) != 0 &&
795 (throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK) == 0) {
796 break;
797 }
798 // Now whitelist specific instructions.
799 bool ok = false;
800 if ((df_attributes & DF_IFIELD) != 0) {
801 // Combine only if fast, otherwise weird things can happen.
802 const MirIFieldLoweringInfo& field_info = GetIFieldLoweringInfo(throw_insn);
Serguei Katkov08794a92014-11-06 13:56:13 +0600803 ok = (df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut();
Vladimir Marko312eb252014-10-07 15:01:57 +0100804 } else if ((df_attributes & DF_SFIELD) != 0) {
805 // Combine only if fast, otherwise weird things can happen.
806 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(throw_insn);
Serguei Katkov08794a92014-11-06 13:56:13 +0600807 bool fast = ((df_attributes & DF_DA) ? field_info.FastGet() : field_info.FastPut());
Vladimir Marko312eb252014-10-07 15:01:57 +0100808 // Don't combine if the SGET/SPUT can call <clinit>().
Vladimir Marko66c6d7b2014-10-16 15:41:48 +0100809 bool clinit = !field_info.IsClassInitialized() &&
810 (throw_insn->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0;
Vladimir Marko312eb252014-10-07 15:01:57 +0100811 ok = fast && !clinit;
812 } else if ((df_attributes & DF_HAS_RANGE_CHKS) != 0) {
813 // Only AGET/APUT have range checks. We have processed the AGET/APUT null check above.
814 DCHECK_NE(throw_insn->optimization_flags & MIR_IGNORE_NULL_CHECK, 0);
815 ok = ((throw_insn->optimization_flags & MIR_IGNORE_RANGE_CHECK) != 0);
816 } else if ((throw_insn->dalvikInsn.FlagsOf() & Instruction::kThrow) == 0) {
817 // We can encounter a non-throwing insn here thanks to inlining or other optimizations.
818 ok = true;
819 } else if (throw_insn->dalvikInsn.opcode == Instruction::ARRAY_LENGTH ||
820 throw_insn->dalvikInsn.opcode == Instruction::FILL_ARRAY_DATA ||
821 static_cast<int>(throw_insn->dalvikInsn.opcode) == kMirOpNullCheck) {
822 // No more checks for these (null check was processed above).
823 ok = true;
824 }
825 if (!ok) {
buzbee311ca162013-02-28 15:56:43 -0800826 break;
827 }
828
buzbee311ca162013-02-28 15:56:43 -0800829 // OK - got one. Combine
buzbee0d829482013-10-11 15:24:55 -0700830 BasicBlock* bb_next = GetBasicBlock(bb->fall_through);
buzbee311ca162013-02-28 15:56:43 -0800831 DCHECK(!bb_next->catch_entry);
Vladimir Marko312eb252014-10-07 15:01:57 +0100832 DCHECK_EQ(bb_next->predecessors.size(), 1u);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700833
834 // Now move instructions from bb_next to bb. Start off with doing a sanity check
835 // that kMirOpCheck's throw instruction is first one in the bb_next.
buzbee311ca162013-02-28 15:56:43 -0800836 DCHECK_EQ(bb_next->first_mir_insn, throw_insn);
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700837 // Now move all instructions (throw instruction to last one) from bb_next to bb.
838 MIR* last_to_move = bb_next->last_mir_insn;
839 bb_next->RemoveMIRList(throw_insn, last_to_move);
840 bb->InsertMIRListAfter(bb->last_mir_insn, throw_insn, last_to_move);
841 // The kMirOpCheck instruction is not needed anymore.
842 mir->dalvikInsn.opcode = static_cast<Instruction::Code>(kMirOpNop);
843 bb->RemoveMIR(mir);
844
Vladimir Marko312eb252014-10-07 15:01:57 +0100845 // Before we overwrite successors, remove their predecessor links to bb.
846 bb_next->ErasePredecessor(bb->id);
847 if (bb->taken != NullBasicBlockId) {
848 DCHECK_EQ(bb->successor_block_list_type, kNotUsed);
849 BasicBlock* bb_taken = GetBasicBlock(bb->taken);
850 // bb->taken will be overwritten below.
851 DCHECK_EQ(bb_taken->block_type, kExceptionHandling);
852 DCHECK_EQ(bb_taken->predecessors.size(), 1u);
853 DCHECK_EQ(bb_taken->predecessors[0], bb->id);
854 bb_taken->predecessors.clear();
855 bb_taken->block_type = kDead;
856 DCHECK(bb_taken->data_flow_info == nullptr);
857 } else {
858 DCHECK_EQ(bb->successor_block_list_type, kCatch);
859 for (SuccessorBlockInfo* succ_info : bb->successor_blocks) {
860 if (succ_info->block != NullBasicBlockId) {
861 BasicBlock* succ_bb = GetBasicBlock(succ_info->block);
862 DCHECK(succ_bb->catch_entry);
863 succ_bb->ErasePredecessor(bb->id);
864 if (succ_bb->predecessors.empty()) {
865 succ_bb->KillUnreachable(this);
866 }
867 }
868 }
869 }
buzbee311ca162013-02-28 15:56:43 -0800870 // Use the successor info from the next block
buzbee0d829482013-10-11 15:24:55 -0700871 bb->successor_block_list_type = bb_next->successor_block_list_type;
Vladimir Markoe39c54e2014-09-22 14:50:02 +0100872 bb->successor_blocks.swap(bb_next->successor_blocks); // Swap instead of copying.
Vladimir Marko312eb252014-10-07 15:01:57 +0100873 bb_next->successor_block_list_type = kNotUsed;
buzbee311ca162013-02-28 15:56:43 -0800874 // Use the ending block linkage from the next block
875 bb->fall_through = bb_next->fall_through;
Vladimir Marko312eb252014-10-07 15:01:57 +0100876 bb_next->fall_through = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800877 bb->taken = bb_next->taken;
Vladimir Marko312eb252014-10-07 15:01:57 +0100878 bb_next->taken = NullBasicBlockId;
buzbee311ca162013-02-28 15:56:43 -0800879 /*
Junmo Parkf1770fd2014-08-12 09:34:54 +0900880 * If lower-half of pair of blocks to combine contained
881 * a return or a conditional branch or an explicit throw,
882 * move the flag to the newly combined block.
buzbee311ca162013-02-28 15:56:43 -0800883 */
884 bb->terminated_by_return = bb_next->terminated_by_return;
Junmo Parkf1770fd2014-08-12 09:34:54 +0900885 bb->conditional_branch = bb_next->conditional_branch;
886 bb->explicit_throw = bb_next->explicit_throw;
Vladimir Marko312eb252014-10-07 15:01:57 +0100887 // Merge the use_lvn flag.
888 bb->use_lvn |= bb_next->use_lvn;
889
890 // Kill the unused block.
891 bb_next->data_flow_info = nullptr;
buzbee311ca162013-02-28 15:56:43 -0800892
893 /*
894 * NOTE: we aren't updating all dataflow info here. Should either make sure this pass
895 * happens after uses of i_dominated, dom_frontier or update the dataflow info here.
Vladimir Marko312eb252014-10-07 15:01:57 +0100896 * NOTE: GVN uses bb->data_flow_info->live_in_v which is unaffected by the block merge.
buzbee311ca162013-02-28 15:56:43 -0800897 */
898
Vladimir Marko312eb252014-10-07 15:01:57 +0100899 // Kill bb_next and remap now-dead id to parent.
buzbee311ca162013-02-28 15:56:43 -0800900 bb_next->block_type = kDead;
Vladimir Marko312eb252014-10-07 15:01:57 +0100901 bb_next->data_flow_info = nullptr; // Must be null for dead blocks. (Relied on by the GVN.)
buzbee1fd33462013-03-25 13:40:45 -0700902 block_id_map_.Overwrite(bb_next->id, bb->id);
Vladimir Marko312eb252014-10-07 15:01:57 +0100903 // Update predecessors in children.
904 ChildBlockIterator iter(bb, this);
905 for (BasicBlock* child = iter.Next(); child != nullptr; child = iter.Next()) {
906 child->UpdatePredecessor(bb_next->id, bb->id);
907 }
908
909 // DFS orders are not up to date anymore.
910 dfs_orders_up_to_date_ = false;
buzbee311ca162013-02-28 15:56:43 -0800911
912 // Now, loop back and see if we can keep going
913 }
buzbee311ca162013-02-28 15:56:43 -0800914}
915
Vladimir Marko67c72b82014-10-09 12:26:10 +0100916bool MIRGraph::EliminateNullChecksGate() {
917 if ((cu_->disable_opt & (1 << kNullCheckElimination)) != 0 ||
918 (merged_df_flags_ & DF_HAS_NULL_CHKS) == 0) {
919 return false;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000920 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100921
Vladimir Marko67c72b82014-10-09 12:26:10 +0100922 DCHECK(temp_scoped_alloc_.get() == nullptr);
923 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -0700924 temp_.nce.num_vregs = GetNumOfCodeAndTempVRs();
Vladimir Markof585e542014-11-21 13:41:32 +0000925 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
926 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
927 temp_.nce.ending_vregs_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +0100928 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +0000929 std::fill_n(temp_.nce.ending_vregs_to_check_matrix, GetNumBlocks(), nullptr);
Yevgeny Rouban423b1372014-10-15 17:32:25 +0700930
931 // reset MIR_MARK
932 AllNodesIterator iter(this);
933 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
934 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
935 mir->optimization_flags &= ~MIR_MARK;
936 }
937 }
938
Vladimir Marko67c72b82014-10-09 12:26:10 +0100939 return true;
Vladimir Markobfea9c22014-01-17 17:49:33 +0000940}
941
buzbee1da1e2f2013-11-15 13:37:01 -0800942/*
Vladimir Marko67c72b82014-10-09 12:26:10 +0100943 * Eliminate unnecessary null checks for a basic block.
buzbee1da1e2f2013-11-15 13:37:01 -0800944 */
Vladimir Marko67c72b82014-10-09 12:26:10 +0100945bool MIRGraph::EliminateNullChecks(BasicBlock* bb) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100946 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
947 // Ignore the kExitBlock as well.
948 DCHECK(bb->first_mir_insn == nullptr);
949 return false;
950 }
buzbee311ca162013-02-28 15:56:43 -0800951
Vladimir Markof585e542014-11-21 13:41:32 +0000952 ArenaBitVector* vregs_to_check = temp_.nce.work_vregs_to_check;
Vladimir Marko67c72b82014-10-09 12:26:10 +0100953 /*
954 * Set initial state. Catch blocks don't need any special treatment.
955 */
956 if (bb->block_type == kEntryBlock) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100957 vregs_to_check->ClearAllBits();
Vladimir Marko67c72b82014-10-09 12:26:10 +0100958 // Assume all ins are objects.
959 for (uint16_t in_reg = GetFirstInVR();
960 in_reg < GetNumOfCodeVRs(); in_reg++) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100961 vregs_to_check->SetBit(in_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100962 }
963 if ((cu_->access_flags & kAccStatic) == 0) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100964 // If non-static method, mark "this" as non-null.
Vladimir Marko67c72b82014-10-09 12:26:10 +0100965 int this_reg = GetFirstInVR();
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100966 vregs_to_check->ClearBit(this_reg);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100967 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100968 } else {
969 DCHECK_EQ(bb->block_type, kDalvikByteCode);
970 // Starting state is union of all incoming arcs.
971 bool copied_first = false;
972 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +0000973 if (temp_.nce.ending_vregs_to_check_matrix[pred_id] == nullptr) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100974 continue;
975 }
976 BasicBlock* pred_bb = GetBasicBlock(pred_id);
977 DCHECK(pred_bb != nullptr);
978 MIR* null_check_insn = nullptr;
979 if (pred_bb->block_type == kDalvikByteCode) {
980 // Check to see if predecessor had an explicit null-check.
981 MIR* last_insn = pred_bb->last_mir_insn;
982 if (last_insn != nullptr) {
983 Instruction::Code last_opcode = last_insn->dalvikInsn.opcode;
984 if ((last_opcode == Instruction::IF_EQZ && pred_bb->fall_through == bb->id) ||
985 (last_opcode == Instruction::IF_NEZ && pred_bb->taken == bb->id)) {
986 // Remember the null check insn if there's no other predecessor requiring null check.
987 if (!copied_first || !vregs_to_check->IsBitSet(last_insn->dalvikInsn.vA)) {
988 null_check_insn = last_insn;
989 }
buzbee1da1e2f2013-11-15 13:37:01 -0800990 }
Ian Rogers22fd6a02013-06-13 15:06:54 -0700991 }
992 }
Vladimir Marko67c72b82014-10-09 12:26:10 +0100993 if (!copied_first) {
994 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +0000995 vregs_to_check->Copy(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko67c72b82014-10-09 12:26:10 +0100996 } else {
Vladimir Markof585e542014-11-21 13:41:32 +0000997 vregs_to_check->Union(temp_.nce.ending_vregs_to_check_matrix[pred_id]);
Vladimir Marko7baa6f82014-10-09 18:01:24 +0100998 }
999 if (null_check_insn != nullptr) {
1000 vregs_to_check->ClearBit(null_check_insn->dalvikInsn.vA);
Vladimir Marko67c72b82014-10-09 12:26:10 +01001001 }
1002 }
1003 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
buzbee311ca162013-02-28 15:56:43 -08001004 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001005 // At this point, vregs_to_check shows which sregs have an object definition with
Vladimir Marko67c72b82014-10-09 12:26:10 +01001006 // no intervening uses.
buzbee311ca162013-02-28 15:56:43 -08001007
1008 // Walk through the instruction in the block, updating as necessary
1009 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beylercc794c32014-05-02 09:34:13 -07001010 uint64_t df_attributes = GetDataFlowAttributes(mir);
buzbee311ca162013-02-28 15:56:43 -08001011
Razvan A Lupusoruc7a77bf2014-10-29 18:42:27 -07001012 if ((df_attributes & DF_NULL_TRANSFER_N) != 0u) {
1013 // The algorithm was written in a phi agnostic way.
1014 continue;
1015 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001016
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001017 // Might need a null check?
1018 if (df_attributes & DF_HAS_NULL_CHKS) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001019 int src_vreg;
1020 if (df_attributes & DF_NULL_CHK_OUT0) {
1021 DCHECK_NE(df_attributes & DF_IS_INVOKE, 0u);
1022 src_vreg = mir->dalvikInsn.vC;
1023 } else if (df_attributes & DF_NULL_CHK_B) {
1024 DCHECK_NE(df_attributes & DF_REF_B, 0u);
1025 src_vreg = mir->dalvikInsn.vB;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001026 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001027 DCHECK_NE(df_attributes & DF_NULL_CHK_A, 0u);
1028 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1029 src_vreg = mir->dalvikInsn.vA;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001030 }
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001031 if (!vregs_to_check->IsBitSet(src_vreg)) {
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001032 // Eliminate the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001033 mir->optimization_flags |= MIR_MARK;
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001034 } else {
1035 // Do the null check.
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001036 mir->optimization_flags &= ~MIR_MARK;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001037 // Mark src_vreg as null-checked.
1038 vregs_to_check->ClearBit(src_vreg);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001039 }
1040 }
1041
1042 if ((df_attributes & DF_A_WIDE) ||
1043 (df_attributes & (DF_REF_A | DF_SETS_CONST | DF_NULL_TRANSFER)) == 0) {
1044 continue;
1045 }
1046
1047 /*
1048 * First, mark all object definitions as requiring null check.
1049 * Note: we can't tell if a CONST definition might be used as an object, so treat
1050 * them all as object definitions.
1051 */
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001052 if ((df_attributes & (DF_DA | DF_REF_A)) == (DF_DA | DF_REF_A) ||
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001053 (df_attributes & DF_SETS_CONST)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001054 vregs_to_check->SetBit(mir->dalvikInsn.vA);
buzbee4db179d2013-10-23 12:16:39 -07001055 }
1056
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001057 // Then, remove mark from all object definitions we know are non-null.
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001058 if (df_attributes & DF_NON_NULL_DST) {
1059 // Mark target of NEW* as non-null
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001060 DCHECK_NE(df_attributes & DF_REF_A, 0u);
1061 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001062 }
1063
buzbee311ca162013-02-28 15:56:43 -08001064 // Mark non-null returns from invoke-style NEW*
1065 if (df_attributes & DF_NON_NULL_RET) {
1066 MIR* next_mir = mir->next;
1067 // Next should be an MOVE_RESULT_OBJECT
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001068 if (UNLIKELY(next_mir == nullptr)) {
1069 // The MethodVerifier makes sure there's no MOVE_RESULT at the catch entry or branch
1070 // target, so the MOVE_RESULT cannot be broken away into another block.
1071 LOG(WARNING) << "Unexpected end of block following new";
1072 } else if (UNLIKELY(next_mir->dalvikInsn.opcode != Instruction::MOVE_RESULT_OBJECT)) {
1073 LOG(WARNING) << "Unexpected opcode following new: " << next_mir->dalvikInsn.opcode;
buzbee311ca162013-02-28 15:56:43 -08001074 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001075 // Mark as null checked.
1076 vregs_to_check->ClearBit(next_mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001077 }
1078 }
1079
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001080 // Propagate null check state on register copies.
1081 if (df_attributes & DF_NULL_TRANSFER_0) {
1082 DCHECK_EQ(df_attributes | ~(DF_DA | DF_REF_A | DF_UB | DF_REF_B), static_cast<uint64_t>(-1));
1083 if (vregs_to_check->IsBitSet(mir->dalvikInsn.vB)) {
1084 vregs_to_check->SetBit(mir->dalvikInsn.vA);
Bill Buzbee0b1191c2013-10-28 22:11:59 +00001085 } else {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001086 vregs_to_check->ClearBit(mir->dalvikInsn.vA);
buzbee311ca162013-02-28 15:56:43 -08001087 }
1088 }
buzbee311ca162013-02-28 15:56:43 -08001089 }
1090
1091 // Did anything change?
Vladimir Markobfea9c22014-01-17 17:49:33 +00001092 bool nce_changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001093 ArenaBitVector* old_ending_ssa_regs_to_check = temp_.nce.ending_vregs_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001094 if (old_ending_ssa_regs_to_check == nullptr) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001095 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001096 nce_changed = vregs_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001097 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001098 // Create a new vregs_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001099 temp_.nce.work_vregs_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1100 temp_scoped_alloc_.get(), temp_.nce.num_vregs, false, kBitMapNullCheck);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001101 } else if (!vregs_to_check->SameBitsSet(old_ending_ssa_regs_to_check)) {
Vladimir Marko67c72b82014-10-09 12:26:10 +01001102 nce_changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001103 temp_.nce.ending_vregs_to_check_matrix[bb->id] = vregs_to_check;
1104 temp_.nce.work_vregs_to_check = old_ending_ssa_regs_to_check; // Reuse for next BB.
buzbee311ca162013-02-28 15:56:43 -08001105 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001106 return nce_changed;
buzbee311ca162013-02-28 15:56:43 -08001107}
1108
Vladimir Marko67c72b82014-10-09 12:26:10 +01001109void MIRGraph::EliminateNullChecksEnd() {
1110 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001111 temp_.nce.num_vregs = 0u;
1112 temp_.nce.work_vregs_to_check = nullptr;
1113 temp_.nce.ending_vregs_to_check_matrix = nullptr;
Vladimir Marko67c72b82014-10-09 12:26:10 +01001114 DCHECK(temp_scoped_alloc_.get() != nullptr);
1115 temp_scoped_alloc_.reset();
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001116
1117 // converge MIR_MARK with MIR_IGNORE_NULL_CHECK
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001118 AllNodesIterator iter(this);
1119 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1120 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001121 constexpr int kMarkToIgnoreNullCheckShift = kMIRMark - kMIRIgnoreNullCheck;
Andreas Gampe785d2f22014-11-03 22:57:30 -08001122 static_assert(kMarkToIgnoreNullCheckShift > 0, "Not a valid right-shift");
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001123 uint16_t mirMarkAdjustedToIgnoreNullCheck =
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001124 (mir->optimization_flags & MIR_MARK) >> kMarkToIgnoreNullCheckShift;
Yevgeny Rouban423b1372014-10-15 17:32:25 +07001125 mir->optimization_flags |= mirMarkAdjustedToIgnoreNullCheck;
1126 }
1127 }
Vladimir Marko67c72b82014-10-09 12:26:10 +01001128}
1129
1130/*
1131 * Perform type and size inference for a basic block.
1132 */
1133bool MIRGraph::InferTypes(BasicBlock* bb) {
1134 if (bb->data_flow_info == nullptr) return false;
1135
1136 bool infer_changed = false;
1137 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
1138 if (mir->ssa_rep == NULL) {
1139 continue;
1140 }
1141
1142 // Propagate type info.
1143 infer_changed = InferTypeAndSize(bb, mir, infer_changed);
1144 }
1145
1146 return infer_changed;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001147}
1148
1149bool MIRGraph::EliminateClassInitChecksGate() {
1150 if ((cu_->disable_opt & (1 << kClassInitCheckElimination)) != 0 ||
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001151 (merged_df_flags_ & DF_CLINIT) == 0) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001152 return false;
1153 }
1154
Vladimir Markobfea9c22014-01-17 17:49:33 +00001155 DCHECK(temp_scoped_alloc_.get() == nullptr);
1156 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1157
1158 // Each insn we use here has at least 2 code units, offset/2 will be a unique index.
Razvan A Lupusoru75035972014-09-11 15:24:59 -07001159 const size_t end = (GetNumDalvikInsns() + 1u) / 2u;
Vladimir Markof585e542014-11-21 13:41:32 +00001160 temp_.cice.indexes = static_cast<uint16_t*>(
1161 temp_scoped_alloc_->Alloc(end * sizeof(*temp_.cice.indexes), kArenaAllocGrowableArray));
1162 std::fill_n(temp_.cice.indexes, end, 0xffffu);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001163
1164 uint32_t unique_class_count = 0u;
1165 {
1166 // Get unique_class_count and store indexes in temp_insn_data_ using a map on a nested
1167 // ScopedArenaAllocator.
1168
1169 // Embed the map value in the entry to save space.
1170 struct MapEntry {
1171 // Map key: the class identified by the declaring dex file and type index.
1172 const DexFile* declaring_dex_file;
1173 uint16_t declaring_class_idx;
1174 // Map value: index into bit vectors of classes requiring initialization checks.
1175 uint16_t index;
1176 };
1177 struct MapEntryComparator {
1178 bool operator()(const MapEntry& lhs, const MapEntry& rhs) const {
1179 if (lhs.declaring_class_idx != rhs.declaring_class_idx) {
1180 return lhs.declaring_class_idx < rhs.declaring_class_idx;
1181 }
1182 return lhs.declaring_dex_file < rhs.declaring_dex_file;
1183 }
1184 };
1185
Vladimir Markobfea9c22014-01-17 17:49:33 +00001186 ScopedArenaAllocator allocator(&cu_->arena_stack);
Vladimir Marko69f08ba2014-04-11 12:28:11 +01001187 ScopedArenaSet<MapEntry, MapEntryComparator> class_to_index_map(MapEntryComparator(),
1188 allocator.Adapter());
Vladimir Markobfea9c22014-01-17 17:49:33 +00001189
1190 // First, find all SGET/SPUTs that may need class initialization checks, record INVOKE_STATICs.
1191 AllNodesIterator iter(this);
1192 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001193 if (bb->block_type == kDalvikByteCode) {
1194 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001195 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001196 const MirSFieldLoweringInfo& field_info = GetSFieldLoweringInfo(mir);
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001197 if (!field_info.IsReferrersClass()) {
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001198 DCHECK_LT(class_to_index_map.size(), 0xffffu);
1199 MapEntry entry = {
1200 // Treat unresolved fields as if each had its own class.
1201 field_info.IsResolved() ? field_info.DeclaringDexFile()
1202 : nullptr,
1203 field_info.IsResolved() ? field_info.DeclaringClassIndex()
1204 : field_info.FieldIndex(),
1205 static_cast<uint16_t>(class_to_index_map.size())
1206 };
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001207 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001208 // Using offset/2 for index into temp_.cice.indexes.
1209 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001210 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001211 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001212 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1213 DCHECK(method_info.IsStatic());
1214 if (method_info.FastPath() && !method_info.IsReferrersClass()) {
1215 MapEntry entry = {
1216 method_info.DeclaringDexFile(),
1217 method_info.DeclaringClassIndex(),
1218 static_cast<uint16_t>(class_to_index_map.size())
1219 };
1220 uint16_t index = class_to_index_map.insert(entry).first->index;
Vladimir Markof585e542014-11-21 13:41:32 +00001221 // Using offset/2 for index into temp_.cice.indexes.
1222 temp_.cice.indexes[mir->offset / 2u] = index;
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001223 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001224 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001225 }
1226 }
1227 }
1228 unique_class_count = static_cast<uint32_t>(class_to_index_map.size());
1229 }
1230
1231 if (unique_class_count == 0u) {
1232 // All SGET/SPUTs refer to initialized classes. Nothing to do.
Vladimir Markof585e542014-11-21 13:41:32 +00001233 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001234 temp_scoped_alloc_.reset();
1235 return false;
1236 }
1237
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001238 // 2 bits for each class: is class initialized, is class in dex cache.
Vladimir Markof585e542014-11-21 13:41:32 +00001239 temp_.cice.num_class_bits = 2u * unique_class_count;
1240 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1241 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
1242 temp_.cice.ending_classes_to_check_matrix = static_cast<ArenaBitVector**>(
Vladimir Marko5229cf12014-10-09 14:57:59 +01001243 temp_scoped_alloc_->Alloc(sizeof(ArenaBitVector*) * GetNumBlocks(), kArenaAllocMisc));
Vladimir Markof585e542014-11-21 13:41:32 +00001244 std::fill_n(temp_.cice.ending_classes_to_check_matrix, GetNumBlocks(), nullptr);
1245 DCHECK_GT(temp_.cice.num_class_bits, 0u);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001246 return true;
1247}
1248
1249/*
1250 * Eliminate unnecessary class initialization checks for a basic block.
1251 */
1252bool MIRGraph::EliminateClassInitChecks(BasicBlock* bb) {
1253 DCHECK_EQ((cu_->disable_opt & (1 << kClassInitCheckElimination)), 0u);
Vladimir Marko7baa6f82014-10-09 18:01:24 +01001254 if (bb->block_type != kDalvikByteCode && bb->block_type != kEntryBlock) {
1255 // Ignore the kExitBlock as well.
1256 DCHECK(bb->first_mir_insn == nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001257 return false;
1258 }
1259
1260 /*
Vladimir Marko0a810d22014-07-11 14:44:36 +01001261 * Set initial state. Catch blocks don't need any special treatment.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001262 */
Vladimir Markof585e542014-11-21 13:41:32 +00001263 ArenaBitVector* classes_to_check = temp_.cice.work_classes_to_check;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001264 DCHECK(classes_to_check != nullptr);
Vladimir Marko0a810d22014-07-11 14:44:36 +01001265 if (bb->block_type == kEntryBlock) {
Vladimir Markof585e542014-11-21 13:41:32 +00001266 classes_to_check->SetInitialBits(temp_.cice.num_class_bits);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001267 } else {
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001268 // Starting state is union of all incoming arcs.
1269 bool copied_first = false;
1270 for (BasicBlockId pred_id : bb->predecessors) {
Vladimir Markof585e542014-11-21 13:41:32 +00001271 if (temp_.cice.ending_classes_to_check_matrix[pred_id] == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001272 continue;
1273 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001274 if (!copied_first) {
1275 copied_first = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001276 classes_to_check->Copy(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001277 } else {
Vladimir Markof585e542014-11-21 13:41:32 +00001278 classes_to_check->Union(temp_.cice.ending_classes_to_check_matrix[pred_id]);
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001279 }
Vladimir Markobfea9c22014-01-17 17:49:33 +00001280 }
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001281 DCHECK(copied_first); // At least one predecessor must have been processed before this bb.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001282 }
1283 // At this point, classes_to_check shows which classes need clinit checks.
1284
1285 // Walk through the instruction in the block, updating as necessary
1286 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
Vladimir Markof585e542014-11-21 13:41:32 +00001287 uint16_t index = temp_.cice.indexes[mir->offset / 2u];
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001288 if (index != 0xffffu) {
1289 bool check_initialization = false;
1290 bool check_dex_cache = false;
1291
1292 // NOTE: index != 0xffff does not guarantee that this is an SGET/SPUT/INVOKE_STATIC.
1293 // Dex instructions with width 1 can have the same offset/2.
1294
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001295 if (IsInstructionSGetOrSPut(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001296 check_initialization = true;
1297 check_dex_cache = true;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001298 } else if (IsInstructionInvokeStatic(mir->dalvikInsn.opcode)) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001299 check_initialization = true;
1300 // NOTE: INVOKE_STATIC doesn't guarantee that the type will be in the dex cache.
1301 }
1302
1303 if (check_dex_cache) {
1304 uint32_t check_dex_cache_index = 2u * index + 1u;
1305 if (!classes_to_check->IsBitSet(check_dex_cache_index)) {
1306 // Eliminate the class init check.
1307 mir->optimization_flags |= MIR_CLASS_IS_IN_DEX_CACHE;
1308 } else {
1309 // Do the class init check.
1310 mir->optimization_flags &= ~MIR_CLASS_IS_IN_DEX_CACHE;
1311 }
1312 classes_to_check->ClearBit(check_dex_cache_index);
1313 }
1314 if (check_initialization) {
1315 uint32_t check_clinit_index = 2u * index;
1316 if (!classes_to_check->IsBitSet(check_clinit_index)) {
1317 // Eliminate the class init check.
1318 mir->optimization_flags |= MIR_CLASS_IS_INITIALIZED;
1319 } else {
1320 // Do the class init check.
1321 mir->optimization_flags &= ~MIR_CLASS_IS_INITIALIZED;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001322 }
1323 // Mark the class as initialized.
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001324 classes_to_check->ClearBit(check_clinit_index);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001325 }
1326 }
1327 }
1328
1329 // Did anything change?
1330 bool changed = false;
Vladimir Markof585e542014-11-21 13:41:32 +00001331 ArenaBitVector* old_ending_classes_to_check = temp_.cice.ending_classes_to_check_matrix[bb->id];
Vladimir Marko5229cf12014-10-09 14:57:59 +01001332 if (old_ending_classes_to_check == nullptr) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001333 DCHECK(temp_scoped_alloc_.get() != nullptr);
Vladimir Markobfea9c22014-01-17 17:49:33 +00001334 changed = classes_to_check->GetHighestBitSet() != -1;
Vladimir Markof585e542014-11-21 13:41:32 +00001335 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
Vladimir Marko5229cf12014-10-09 14:57:59 +01001336 // Create a new classes_to_check for next BB.
Vladimir Markof585e542014-11-21 13:41:32 +00001337 temp_.cice.work_classes_to_check = new (temp_scoped_alloc_.get()) ArenaBitVector(
1338 temp_scoped_alloc_.get(), temp_.cice.num_class_bits, false, kBitMapClInitCheck);
Vladimir Marko5229cf12014-10-09 14:57:59 +01001339 } else if (!classes_to_check->Equal(old_ending_classes_to_check)) {
Vladimir Markobfea9c22014-01-17 17:49:33 +00001340 changed = true;
Vladimir Markof585e542014-11-21 13:41:32 +00001341 temp_.cice.ending_classes_to_check_matrix[bb->id] = classes_to_check;
1342 temp_.cice.work_classes_to_check = old_ending_classes_to_check; // Reuse for next BB.
Vladimir Markobfea9c22014-01-17 17:49:33 +00001343 }
1344 return changed;
1345}
1346
1347void MIRGraph::EliminateClassInitChecksEnd() {
1348 // Clean up temporaries.
Vladimir Markof585e542014-11-21 13:41:32 +00001349 temp_.cice.num_class_bits = 0u;
1350 temp_.cice.work_classes_to_check = nullptr;
1351 temp_.cice.ending_classes_to_check_matrix = nullptr;
1352 DCHECK(temp_.cice.indexes != nullptr);
1353 temp_.cice.indexes = nullptr;
Vladimir Markobfea9c22014-01-17 17:49:33 +00001354 DCHECK(temp_scoped_alloc_.get() != nullptr);
1355 temp_scoped_alloc_.reset();
1356}
1357
Vladimir Marko95a05972014-05-30 10:01:32 +01001358bool MIRGraph::ApplyGlobalValueNumberingGate() {
Vladimir Marko415ac882014-09-30 18:09:14 +01001359 if (GlobalValueNumbering::Skip(cu_)) {
Vladimir Marko95a05972014-05-30 10:01:32 +01001360 return false;
1361 }
1362
1363 DCHECK(temp_scoped_alloc_ == nullptr);
1364 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001365 temp_.gvn.ifield_ids_ =
1366 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1367 temp_.gvn.sfield_ids_ =
1368 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
Vladimir Markof585e542014-11-21 13:41:32 +00001369 DCHECK(temp_.gvn.gvn == nullptr);
1370 temp_.gvn.gvn = new (temp_scoped_alloc_.get()) GlobalValueNumbering(
1371 cu_, temp_scoped_alloc_.get(), GlobalValueNumbering::kModeGvn);
Vladimir Marko95a05972014-05-30 10:01:32 +01001372 return true;
1373}
1374
1375bool MIRGraph::ApplyGlobalValueNumbering(BasicBlock* bb) {
Vladimir Markof585e542014-11-21 13:41:32 +00001376 DCHECK(temp_.gvn.gvn != nullptr);
1377 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001378 if (lvn != nullptr) {
1379 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1380 lvn->GetValueNumber(mir);
1381 }
1382 }
Vladimir Markof585e542014-11-21 13:41:32 +00001383 bool change = (lvn != nullptr) && temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko95a05972014-05-30 10:01:32 +01001384 return change;
1385}
1386
1387void MIRGraph::ApplyGlobalValueNumberingEnd() {
1388 // Perform modifications.
Vladimir Markof585e542014-11-21 13:41:32 +00001389 DCHECK(temp_.gvn.gvn != nullptr);
1390 if (temp_.gvn.gvn->Good()) {
Vladimir Marko415ac882014-09-30 18:09:14 +01001391 if (max_nested_loops_ != 0u) {
Vladimir Markof585e542014-11-21 13:41:32 +00001392 temp_.gvn.gvn->StartPostProcessing();
Vladimir Marko415ac882014-09-30 18:09:14 +01001393 TopologicalSortIterator iter(this);
1394 for (BasicBlock* bb = iter.Next(); bb != nullptr; bb = iter.Next()) {
1395 ScopedArenaAllocator allocator(&cu_->arena_stack); // Reclaim memory after each LVN.
Vladimir Markof585e542014-11-21 13:41:32 +00001396 LocalValueNumbering* lvn = temp_.gvn.gvn->PrepareBasicBlock(bb, &allocator);
Vladimir Marko415ac882014-09-30 18:09:14 +01001397 if (lvn != nullptr) {
1398 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1399 lvn->GetValueNumber(mir);
1400 }
Vladimir Markof585e542014-11-21 13:41:32 +00001401 bool change = temp_.gvn.gvn->FinishBasicBlock(bb);
Vladimir Marko415ac882014-09-30 18:09:14 +01001402 DCHECK(!change) << PrettyMethod(cu_->method_idx, *cu_->dex_file);
Vladimir Marko95a05972014-05-30 10:01:32 +01001403 }
Vladimir Marko95a05972014-05-30 10:01:32 +01001404 }
1405 }
Vladimir Marko415ac882014-09-30 18:09:14 +01001406 // GVN was successful, running the LVN would be useless.
1407 cu_->disable_opt |= (1u << kLocalValueNumbering);
Vladimir Marko95a05972014-05-30 10:01:32 +01001408 } else {
1409 LOG(WARNING) << "GVN failed for " << PrettyMethod(cu_->method_idx, *cu_->dex_file);
1410 }
1411
Vladimir Markof585e542014-11-21 13:41:32 +00001412 delete temp_.gvn.gvn;
1413 temp_.gvn.gvn = nullptr;
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001414 temp_.gvn.ifield_ids_ = nullptr;
1415 temp_.gvn.sfield_ids_ = nullptr;
Vladimir Marko95a05972014-05-30 10:01:32 +01001416 DCHECK(temp_scoped_alloc_ != nullptr);
1417 temp_scoped_alloc_.reset();
1418}
1419
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001420void MIRGraph::ComputeInlineIFieldLoweringInfo(uint16_t field_idx, MIR* invoke, MIR* iget_or_iput) {
1421 uint32_t method_index = invoke->meta.method_lowering_info;
Vladimir Markof585e542014-11-21 13:41:32 +00001422 if (temp_.smi.processed_indexes->IsBitSet(method_index)) {
1423 iget_or_iput->meta.ifield_lowering_info = temp_.smi.lowering_infos[method_index];
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001424 DCHECK_EQ(field_idx, GetIFieldLoweringInfo(iget_or_iput).FieldIndex());
1425 return;
1426 }
1427
1428 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(invoke);
1429 MethodReference target = method_info.GetTargetMethod();
1430 DexCompilationUnit inlined_unit(
1431 cu_, cu_->class_loader, cu_->class_linker, *target.dex_file,
1432 nullptr /* code_item not used */, 0u /* class_def_idx not used */, target.dex_method_index,
1433 0u /* access_flags not used */, nullptr /* verified_method not used */);
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001434 DexMemAccessType type = IGetOrIPutMemAccessType(iget_or_iput->dalvikInsn.opcode);
1435 MirIFieldLoweringInfo inlined_field_info(field_idx, type);
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001436 MirIFieldLoweringInfo::Resolve(cu_->compiler_driver, &inlined_unit, &inlined_field_info, 1u);
1437 DCHECK(inlined_field_info.IsResolved());
1438
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001439 uint32_t field_info_index = ifield_lowering_infos_.size();
1440 ifield_lowering_infos_.push_back(inlined_field_info);
Vladimir Markof585e542014-11-21 13:41:32 +00001441 temp_.smi.processed_indexes->SetBit(method_index);
1442 temp_.smi.lowering_infos[method_index] = field_info_index;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001443 iget_or_iput->meta.ifield_lowering_info = field_info_index;
1444}
1445
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001446bool MIRGraph::InlineSpecialMethodsGate() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001447 if ((cu_->disable_opt & (1 << kSuppressMethodInlining)) != 0 ||
Vladimir Markoe39c54e2014-09-22 14:50:02 +01001448 method_lowering_infos_.size() == 0u) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001449 return false;
1450 }
1451 if (cu_->compiler_driver->GetMethodInlinerMap() == nullptr) {
1452 // This isn't the Quick compiler.
1453 return false;
1454 }
1455 return true;
1456}
1457
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001458void MIRGraph::InlineSpecialMethodsStart() {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001459 // Prepare for inlining getters/setters. Since we're inlining at most 1 IGET/IPUT from
1460 // each INVOKE, we can index the data by the MIR::meta::method_lowering_info index.
1461
1462 DCHECK(temp_scoped_alloc_.get() == nullptr);
1463 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
Vladimir Markof585e542014-11-21 13:41:32 +00001464 temp_.smi.num_indexes = method_lowering_infos_.size();
1465 temp_.smi.processed_indexes = new (temp_scoped_alloc_.get()) ArenaBitVector(
1466 temp_scoped_alloc_.get(), temp_.smi.num_indexes, false, kBitMapMisc);
1467 temp_.smi.processed_indexes->ClearAllBits();
1468 temp_.smi.lowering_infos = static_cast<uint16_t*>(temp_scoped_alloc_->Alloc(
1469 temp_.smi.num_indexes * sizeof(*temp_.smi.lowering_infos), kArenaAllocGrowableArray));
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001470}
1471
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001472void MIRGraph::InlineSpecialMethods(BasicBlock* bb) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001473 if (bb->block_type != kDalvikByteCode) {
1474 return;
1475 }
1476 for (MIR* mir = bb->first_mir_insn; mir != NULL; mir = mir->next) {
Jean Christophe Beyler2ab40eb2014-06-02 09:03:14 -07001477 if (MIR::DecodedInstruction::IsPseudoMirOp(mir->dalvikInsn.opcode)) {
buzbee35ba7f32014-05-31 08:59:01 -07001478 continue;
1479 }
Jean Christophe Beylerfb0ea2d2014-07-29 13:20:42 -07001480 if (!(mir->dalvikInsn.FlagsOf() & Instruction::kInvoke)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001481 continue;
1482 }
1483 const MirMethodLoweringInfo& method_info = GetMethodLoweringInfo(mir);
1484 if (!method_info.FastPath()) {
1485 continue;
1486 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001487
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001488 InvokeType sharp_type = method_info.GetSharpType();
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001489 if ((sharp_type != kDirect) && (sharp_type != kStatic)) {
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001490 continue;
1491 }
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001492
1493 if (sharp_type == kStatic) {
Vladimir Marko66c6d7b2014-10-16 15:41:48 +01001494 bool needs_clinit = !method_info.IsClassInitialized() &&
1495 ((mir->optimization_flags & MIR_CLASS_IS_INITIALIZED) == 0);
Razvan A Lupusoruc80605d2014-09-11 14:12:17 -07001496 if (needs_clinit) {
1497 continue;
1498 }
1499 }
1500
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001501 DCHECK(cu_->compiler_driver->GetMethodInlinerMap() != nullptr);
1502 MethodReference target = method_info.GetTargetMethod();
1503 if (cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(target.dex_file)
1504 ->GenInline(this, bb, mir, target.dex_method_index)) {
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001505 if (cu_->verbose || cu_->print_pass) {
1506 LOG(INFO) << "SpecialMethodInliner: Inlined " << method_info.GetInvokeType() << " ("
1507 << sharp_type << ") call to \"" << PrettyMethod(target.dex_method_index, *target.dex_file)
1508 << "\" from \"" << PrettyMethod(cu_->method_idx, *cu_->dex_file)
1509 << "\" @0x" << std::hex << mir->offset;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001510 }
1511 }
1512 }
1513}
1514
Razvan A Lupusorucb804742014-07-09 16:42:19 -07001515void MIRGraph::InlineSpecialMethodsEnd() {
Vladimir Markof585e542014-11-21 13:41:32 +00001516 // Clean up temporaries.
1517 DCHECK(temp_.smi.lowering_infos != nullptr);
1518 temp_.smi.lowering_infos = nullptr;
1519 temp_.smi.num_indexes = 0u;
1520 DCHECK(temp_.smi.processed_indexes != nullptr);
1521 temp_.smi.processed_indexes = nullptr;
Vladimir Marko9820b7c2014-01-02 16:40:37 +00001522 DCHECK(temp_scoped_alloc_.get() != nullptr);
1523 temp_scoped_alloc_.reset();
1524}
1525
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001526void MIRGraph::DumpCheckStats() {
buzbee311ca162013-02-28 15:56:43 -08001527 Checkstats* stats =
Vladimir Marko83cc7ae2014-02-12 18:02:05 +00001528 static_cast<Checkstats*>(arena_->Alloc(sizeof(Checkstats), kArenaAllocDFInfo));
buzbee1fd33462013-03-25 13:40:45 -07001529 checkstats_ = stats;
buzbee56c71782013-09-05 17:13:19 -07001530 AllNodesIterator iter(this);
buzbee311ca162013-02-28 15:56:43 -08001531 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1532 CountChecks(bb);
1533 }
1534 if (stats->null_checks > 0) {
1535 float eliminated = static_cast<float>(stats->null_checks_eliminated);
1536 float checks = static_cast<float>(stats->null_checks);
1537 LOG(INFO) << "Null Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1538 << stats->null_checks_eliminated << " of " << stats->null_checks << " -> "
1539 << (eliminated/checks) * 100.0 << "%";
1540 }
1541 if (stats->range_checks > 0) {
1542 float eliminated = static_cast<float>(stats->range_checks_eliminated);
1543 float checks = static_cast<float>(stats->range_checks);
1544 LOG(INFO) << "Range Checks: " << PrettyMethod(cu_->method_idx, *cu_->dex_file) << " "
1545 << stats->range_checks_eliminated << " of " << stats->range_checks << " -> "
1546 << (eliminated/checks) * 100.0 << "%";
1547 }
1548}
1549
Ian Rogers6a3c1fc2014-10-31 00:33:20 -07001550bool MIRGraph::BuildExtendedBBList(class BasicBlock* bb) {
buzbee311ca162013-02-28 15:56:43 -08001551 if (bb->visited) return false;
1552 if (!((bb->block_type == kEntryBlock) || (bb->block_type == kDalvikByteCode)
1553 || (bb->block_type == kExitBlock))) {
1554 // Ignore special blocks
1555 bb->visited = true;
1556 return false;
1557 }
1558 // Must be head of extended basic block.
1559 BasicBlock* start_bb = bb;
buzbee0d829482013-10-11 15:24:55 -07001560 extended_basic_blocks_.push_back(bb->id);
buzbee311ca162013-02-28 15:56:43 -08001561 bool terminated_by_return = false;
buzbee1da1e2f2013-11-15 13:37:01 -08001562 bool do_local_value_numbering = false;
buzbee311ca162013-02-28 15:56:43 -08001563 // Visit blocks strictly dominated by this head.
1564 while (bb != NULL) {
1565 bb->visited = true;
1566 terminated_by_return |= bb->terminated_by_return;
buzbee1da1e2f2013-11-15 13:37:01 -08001567 do_local_value_numbering |= bb->use_lvn;
buzbee311ca162013-02-28 15:56:43 -08001568 bb = NextDominatedBlock(bb);
1569 }
buzbee1da1e2f2013-11-15 13:37:01 -08001570 if (terminated_by_return || do_local_value_numbering) {
1571 // Do lvn for all blocks in this extended set.
buzbee311ca162013-02-28 15:56:43 -08001572 bb = start_bb;
1573 while (bb != NULL) {
buzbee1da1e2f2013-11-15 13:37:01 -08001574 bb->use_lvn = do_local_value_numbering;
1575 bb->dominates_return = terminated_by_return;
buzbee311ca162013-02-28 15:56:43 -08001576 bb = NextDominatedBlock(bb);
1577 }
1578 }
Brian Carlstrom7934ac22013-07-26 10:54:15 -07001579 return false; // Not iterative - return value will be ignored
buzbee311ca162013-02-28 15:56:43 -08001580}
1581
Brian Carlstrom2ce745c2013-07-17 17:44:30 -07001582void MIRGraph::BasicBlockOptimization() {
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001583 if ((cu_->disable_opt & (1 << kLocalValueNumbering)) == 0) {
1584 temp_scoped_alloc_.reset(ScopedArenaAllocator::Create(&cu_->arena_stack));
1585 temp_.gvn.ifield_ids_ =
1586 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), ifield_lowering_infos_);
1587 temp_.gvn.sfield_ids_ =
1588 GlobalValueNumbering::PrepareGvnFieldIds(temp_scoped_alloc_.get(), sfield_lowering_infos_);
1589 }
1590
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001591 if ((cu_->disable_opt & (1 << kSuppressExceptionEdges)) != 0) {
1592 ClearAllVisitedFlags();
1593 PreOrderDfsIterator iter2(this);
1594 for (BasicBlock* bb = iter2.Next(); bb != NULL; bb = iter2.Next()) {
1595 BuildExtendedBBList(bb);
buzbee311ca162013-02-28 15:56:43 -08001596 }
Jean Christophe Beyler4e97c532014-01-07 10:07:18 -08001597 // Perform extended basic block optimizations.
1598 for (unsigned int i = 0; i < extended_basic_blocks_.size(); i++) {
1599 BasicBlockOpt(GetBasicBlock(extended_basic_blocks_[i]));
1600 }
1601 } else {
1602 PreOrderDfsIterator iter(this);
1603 for (BasicBlock* bb = iter.Next(); bb != NULL; bb = iter.Next()) {
1604 BasicBlockOpt(bb);
1605 }
buzbee311ca162013-02-28 15:56:43 -08001606 }
Vladimir Markoaf6925b2014-10-31 16:37:32 +00001607
1608 // Clean up after LVN.
1609 temp_.gvn.ifield_ids_ = nullptr;
1610 temp_.gvn.sfield_ids_ = nullptr;
1611 temp_scoped_alloc_.reset();
buzbee311ca162013-02-28 15:56:43 -08001612}
1613
Vladimir Marko8b858e12014-11-27 14:52:37 +00001614bool MIRGraph::EliminateSuspendChecksGate() {
1615 if ((cu_->disable_opt & (1 << kSuspendCheckElimination)) != 0 || // Disabled.
1616 GetMaxNestedLoops() == 0u || // Nothing to do.
1617 GetMaxNestedLoops() >= 32u || // Only 32 bits in suspend_checks_in_loops_[.].
1618 // Exclude 32 as well to keep bit shifts well-defined.
1619 !HasInvokes()) { // No invokes to actually eliminate any suspend checks.
1620 return false;
1621 }
1622 if (cu_->compiler_driver != nullptr && cu_->compiler_driver->GetMethodInlinerMap() != nullptr) {
1623 temp_.sce.inliner =
1624 cu_->compiler_driver->GetMethodInlinerMap()->GetMethodInliner(cu_->dex_file);
1625 }
1626 suspend_checks_in_loops_ = static_cast<uint32_t*>(
1627 arena_->Alloc(GetNumBlocks() * sizeof(*suspend_checks_in_loops_), kArenaAllocMisc));
1628 return true;
1629}
1630
1631bool MIRGraph::EliminateSuspendChecks(BasicBlock* bb) {
1632 if (bb->block_type != kDalvikByteCode) {
1633 return false;
1634 }
1635 DCHECK_EQ(GetTopologicalSortOrderLoopHeadStack()->size(), bb->nesting_depth);
1636 if (bb->nesting_depth == 0u) {
1637 // Out of loops.
1638 DCHECK_EQ(suspend_checks_in_loops_[bb->id], 0u); // The array was zero-initialized.
1639 return false;
1640 }
1641 uint32_t suspend_checks_in_loops = (1u << bb->nesting_depth) - 1u; // Start with all loop heads.
1642 bool found_invoke = false;
1643 for (MIR* mir = bb->first_mir_insn; mir != nullptr; mir = mir->next) {
1644 if (IsInstructionInvoke(mir->dalvikInsn.opcode) &&
1645 (temp_.sce.inliner == nullptr ||
1646 !temp_.sce.inliner->IsIntrinsic(mir->dalvikInsn.vB, nullptr))) {
1647 // Non-intrinsic invoke, rely on a suspend point in the invoked method.
1648 found_invoke = true;
1649 break;
1650 }
1651 }
1652 if (!found_invoke) {
1653 // Intersect suspend checks from predecessors.
1654 uint16_t bb_topo_idx = topological_order_indexes_[bb->id];
1655 uint32_t pred_mask_union = 0u;
1656 for (BasicBlockId pred_id : bb->predecessors) {
1657 uint16_t pred_topo_idx = topological_order_indexes_[pred_id];
1658 if (pred_topo_idx < bb_topo_idx) {
1659 // Determine the loop depth of the predecessors relative to this block.
1660 size_t pred_loop_depth = topological_order_loop_head_stack_.size();
1661 while (pred_loop_depth != 0u &&
1662 pred_topo_idx < topological_order_loop_head_stack_[pred_loop_depth - 1].first) {
1663 --pred_loop_depth;
1664 }
1665 DCHECK_LE(pred_loop_depth, GetBasicBlock(pred_id)->nesting_depth);
1666 uint32_t pred_mask = (1u << pred_loop_depth) - 1u;
1667 // Intersect pred_mask bits in suspend_checks_in_loops with
1668 // suspend_checks_in_loops_[pred_id].
1669 uint32_t pred_loops_without_checks = pred_mask & ~suspend_checks_in_loops_[pred_id];
1670 suspend_checks_in_loops = suspend_checks_in_loops & ~pred_loops_without_checks;
1671 pred_mask_union |= pred_mask;
1672 }
1673 }
1674 DCHECK_EQ(((1u << (IsLoopHead(bb->id) ? bb->nesting_depth - 1u: bb->nesting_depth)) - 1u),
1675 pred_mask_union);
1676 suspend_checks_in_loops &= pred_mask_union;
1677 }
1678 suspend_checks_in_loops_[bb->id] = suspend_checks_in_loops;
1679 if (suspend_checks_in_loops == 0u) {
1680 return false;
1681 }
1682 // Apply MIR_IGNORE_SUSPEND_CHECK if appropriate.
1683 if (bb->taken != NullBasicBlockId) {
1684 DCHECK(bb->last_mir_insn != nullptr);
1685 DCHECK(IsInstructionIfCc(bb->last_mir_insn->dalvikInsn.opcode) ||
1686 IsInstructionIfCcZ(bb->last_mir_insn->dalvikInsn.opcode) ||
1687 IsInstructionGoto(bb->last_mir_insn->dalvikInsn.opcode) ||
1688 (static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) >= kMirOpFusedCmplFloat &&
1689 static_cast<int>(bb->last_mir_insn->dalvikInsn.opcode) <= kMirOpFusedCmpLong));
1690 if (!IsSuspendCheckEdge(bb, bb->taken) &&
1691 (bb->fall_through == NullBasicBlockId || !IsSuspendCheckEdge(bb, bb->fall_through))) {
1692 bb->last_mir_insn->optimization_flags |= MIR_IGNORE_SUSPEND_CHECK;
1693 }
1694 } else if (bb->fall_through != NullBasicBlockId && IsSuspendCheckEdge(bb, bb->fall_through)) {
1695 // We've got a fall-through suspend edge. Add an artificial GOTO to force suspend check.
1696 MIR* mir = NewMIR();
1697 mir->dalvikInsn.opcode = Instruction::GOTO;
1698 mir->dalvikInsn.vA = 0; // Branch offset.
1699 mir->offset = GetBasicBlock(bb->fall_through)->start_offset;
1700 mir->m_unit_index = current_method_;
1701 mir->ssa_rep = reinterpret_cast<SSARepresentation*>(
1702 arena_->Alloc(sizeof(SSARepresentation), kArenaAllocDFInfo)); // Zero-initialized.
1703 bb->AppendMIR(mir);
1704 std::swap(bb->fall_through, bb->taken); // The fall-through has become taken.
1705 }
1706 return true;
1707}
1708
1709void MIRGraph::EliminateSuspendChecksEnd() {
1710 temp_.sce.inliner = nullptr;
1711}
1712
buzbee311ca162013-02-28 15:56:43 -08001713} // namespace art