blob: ebf509cda90da15fa2c95fa67759fddd5ee26a18 [file] [log] [blame]
Jordy Roseccbf7ee2010-07-06 23:11:01 +00001//= CStringChecker.h - Checks calls to C string functions ----------*- C++ -*-//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This defines CStringChecker, which is an assortment of checks on calls
11// to functions in <string.h>.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidisa0decc92011-02-15 21:25:03 +000015#include "ClangSACheckers.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000016#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis695fb502011-02-17 21:39:17 +000017#include "clang/StaticAnalyzer/Core/CheckerManager.h"
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000018#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000019#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000020#include "clang/StaticAnalyzer/Core/PathSensitive/GRStateTrait.h"
Jordy Roseccbf7ee2010-07-06 23:11:01 +000021#include "llvm/ADT/StringSwitch.h"
22
23using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000024using namespace ento;
Jordy Roseccbf7ee2010-07-06 23:11:01 +000025
26namespace {
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000027class CStringChecker : public Checker< eval::Call,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000028 check::PreStmt<DeclStmt>,
29 check::LiveSymbols,
30 check::DeadSymbols,
31 check::RegionChanges
32 > {
33 mutable llvm::OwningPtr<BugType> BT_Null, BT_Bounds, BT_BoundsWrite,
34 BT_Overlap, BT_NotCString;
Jordy Roseccbf7ee2010-07-06 23:11:01 +000035public:
Jordy Roseccbf7ee2010-07-06 23:11:01 +000036 static void *getTag() { static int tag; return &tag; }
37
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000038 bool evalCall(const CallExpr *CE, CheckerContext &C) const;
39 void checkPreStmt(const DeclStmt *DS, CheckerContext &C) const;
40 void checkLiveSymbols(const GRState *state, SymbolReaper &SR) const;
41 void checkDeadSymbols(SymbolReaper &SR, CheckerContext &C) const;
42 bool wantsRegionChangeUpdate(const GRState *state) const;
Jordy Rosea5261542010-08-14 21:02:52 +000043
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000044 const GRState *checkRegionChanges(const GRState *state,
Ted Kremenek35bdbf42011-05-02 19:42:42 +000045 const StoreManager::InvalidatedSymbols *,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000046 const MemRegion * const *Begin,
47 const MemRegion * const *End) const;
Jordy Roseccbf7ee2010-07-06 23:11:01 +000048
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000049 typedef void (CStringChecker::*FnCheck)(CheckerContext &,
50 const CallExpr *) const;
Jordy Roseccbf7ee2010-07-06 23:11:01 +000051
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000052 void evalMemcpy(CheckerContext &C, const CallExpr *CE) const;
Lenny Maioranib8b875b2011-03-31 21:36:53 +000053 void evalMempcpy(CheckerContext &C, const CallExpr *CE) const;
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000054 void evalMemmove(CheckerContext &C, const CallExpr *CE) const;
55 void evalBcopy(CheckerContext &C, const CallExpr *CE) const;
Lenny Maioranib8b875b2011-03-31 21:36:53 +000056 void evalCopyCommon(CheckerContext &C, const CallExpr *CE,
57 const GRState *state,
Jordy Rosed325ffb2010-07-08 23:57:29 +000058 const Expr *Size, const Expr *Source, const Expr *Dest,
Lenny Maioranib8b875b2011-03-31 21:36:53 +000059 bool Restricted = false,
60 bool IsMempcpy = false) const;
Jordy Rosed325ffb2010-07-08 23:57:29 +000061
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000062 void evalMemcmp(CheckerContext &C, const CallExpr *CE) const;
Jordy Roseccbf7ee2010-07-06 23:11:01 +000063
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000064 void evalstrLength(CheckerContext &C, const CallExpr *CE) const;
65 void evalstrnLength(CheckerContext &C, const CallExpr *CE) const;
Ted Kremenekbe4242c2011-02-22 04:55:05 +000066 void evalstrLengthCommon(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000067 bool IsStrnlen = false) const;
Jordy Rose19c5dd12010-07-27 01:37:31 +000068
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000069 void evalStrcpy(CheckerContext &C, const CallExpr *CE) const;
70 void evalStrncpy(CheckerContext &C, const CallExpr *CE) const;
71 void evalStpcpy(CheckerContext &C, const CallExpr *CE) const;
Ted Kremenek0ef473f2011-02-22 04:58:34 +000072 void evalStrcpyCommon(CheckerContext &C, const CallExpr *CE, bool returnEnd,
Lenny Maiorani067bbd02011-04-09 15:12:58 +000073 bool isBounded, bool isAppending) const;
74
75 void evalStrcat(CheckerContext &C, const CallExpr *CE) const;
76 void evalStrncat(CheckerContext &C, const CallExpr *CE) const;
Jordy Rosee64f3112010-08-16 07:51:42 +000077
Lenny Maiorani318dd922011-04-12 17:08:43 +000078 void evalStrcmp(CheckerContext &C, const CallExpr *CE) const;
Lenny Maiorani357f6ee2011-04-25 22:21:00 +000079 void evalStrncmp(CheckerContext &C, const CallExpr *CE) const;
Lenny Maioranibd1d16a2011-04-28 15:09:11 +000080 void evalStrcasecmp(CheckerContext &C, const CallExpr *CE) const;
Lenny Maiorani454fd2d2011-05-02 19:05:49 +000081 void evalStrncasecmp(CheckerContext &C, const CallExpr *CE) const;
Lenny Maiorani357f6ee2011-04-25 22:21:00 +000082 void evalStrcmpCommon(CheckerContext &C, const CallExpr *CE,
Lenny Maioranibd1d16a2011-04-28 15:09:11 +000083 bool isBounded = false, bool ignoreCase = false) const;
Lenny Maiorani318dd922011-04-12 17:08:43 +000084
Jordy Roseccbf7ee2010-07-06 23:11:01 +000085 // Utility methods
Jordy Rosed325ffb2010-07-08 23:57:29 +000086 std::pair<const GRState*, const GRState*>
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000087 static assumeZero(CheckerContext &C,
88 const GRState *state, SVal V, QualType Ty);
Jordy Rosed325ffb2010-07-08 23:57:29 +000089
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000090 static const GRState *setCStringLength(const GRState *state,
91 const MemRegion *MR, SVal strLength);
92 static SVal getCStringLengthForRegion(CheckerContext &C,
93 const GRState *&state,
94 const Expr *Ex, const MemRegion *MR);
Ted Kremenekc8413fd2010-12-02 07:49:45 +000095 SVal getCStringLength(CheckerContext &C, const GRState *&state,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +000096 const Expr *Ex, SVal Buf) const;
Jordy Rose19c5dd12010-07-27 01:37:31 +000097
Lenny Maiorani318dd922011-04-12 17:08:43 +000098 const StringLiteral *getCStringLiteral(CheckerContext &C,
99 const GRState *&state,
100 const Expr *expr,
101 SVal val) const;
102
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000103 static const GRState *InvalidateBuffer(CheckerContext &C,
104 const GRState *state,
105 const Expr *Ex, SVal V);
Jordy Rosee64f3112010-08-16 07:51:42 +0000106
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000107 static bool SummarizeRegion(llvm::raw_ostream& os, ASTContext& Ctx,
108 const MemRegion *MR);
Jordy Rose19c5dd12010-07-27 01:37:31 +0000109
110 // Re-usable checks
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000111 const GRState *checkNonNull(CheckerContext &C, const GRState *state,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000112 const Expr *S, SVal l) const;
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000113 const GRState *CheckLocation(CheckerContext &C, const GRState *state,
Jordy Rosee64f3112010-08-16 07:51:42 +0000114 const Expr *S, SVal l,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000115 bool IsDestination = false) const;
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000116 const GRState *CheckBufferAccess(CheckerContext &C, const GRState *state,
117 const Expr *Size,
118 const Expr *FirstBuf,
Jordy Rosee64f3112010-08-16 07:51:42 +0000119 const Expr *SecondBuf = NULL,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000120 bool FirstIsDestination = false) const;
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000121 const GRState *CheckOverlap(CheckerContext &C, const GRState *state,
Jordy Rosed325ffb2010-07-08 23:57:29 +0000122 const Expr *Size, const Expr *First,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000123 const Expr *Second) const;
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000124 void emitOverlapBug(CheckerContext &C, const GRState *state,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000125 const Stmt *First, const Stmt *Second) const;
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000126};
Jordy Rosea5261542010-08-14 21:02:52 +0000127
128class CStringLength {
129public:
130 typedef llvm::ImmutableMap<const MemRegion *, SVal> EntryMap;
131};
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000132} //end anonymous namespace
133
Jordy Rosea5261542010-08-14 21:02:52 +0000134namespace clang {
Ted Kremenek9ef65372010-12-23 07:20:52 +0000135namespace ento {
Jordy Rosea5261542010-08-14 21:02:52 +0000136 template <>
137 struct GRStateTrait<CStringLength>
138 : public GRStatePartialTrait<CStringLength::EntryMap> {
139 static void *GDMIndex() { return CStringChecker::getTag(); }
140 };
141}
Argyrios Kyrtzidis5a4f98f2010-12-22 18:53:20 +0000142}
Jordy Rosea5261542010-08-14 21:02:52 +0000143
Jordy Rosed325ffb2010-07-08 23:57:29 +0000144//===----------------------------------------------------------------------===//
145// Individual checks and utility methods.
146//===----------------------------------------------------------------------===//
147
148std::pair<const GRState*, const GRState*>
Ted Kremenek28f47b92010-12-01 22:16:56 +0000149CStringChecker::assumeZero(CheckerContext &C, const GRState *state, SVal V,
Jordy Rosed325ffb2010-07-08 23:57:29 +0000150 QualType Ty) {
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000151 DefinedSVal *val = dyn_cast<DefinedSVal>(&V);
152 if (!val)
Jordy Rosed325ffb2010-07-08 23:57:29 +0000153 return std::pair<const GRState*, const GRState *>(state, state);
Jordy Rosea6b808c2010-07-07 07:48:06 +0000154
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000155 SValBuilder &svalBuilder = C.getSValBuilder();
156 DefinedOrUnknownSVal zero = svalBuilder.makeZeroVal(Ty);
157 return state->assume(svalBuilder.evalEQ(state, *val, zero));
Jordy Rosed325ffb2010-07-08 23:57:29 +0000158}
Jordy Rosea6b808c2010-07-07 07:48:06 +0000159
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000160const GRState *CStringChecker::checkNonNull(CheckerContext &C,
Jordy Rosed325ffb2010-07-08 23:57:29 +0000161 const GRState *state,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000162 const Expr *S, SVal l) const {
Jordy Rosed325ffb2010-07-08 23:57:29 +0000163 // If a previous check has failed, propagate the failure.
164 if (!state)
165 return NULL;
166
167 const GRState *stateNull, *stateNonNull;
Ted Kremenek28f47b92010-12-01 22:16:56 +0000168 llvm::tie(stateNull, stateNonNull) = assumeZero(C, state, l, S->getType());
Jordy Rosed325ffb2010-07-08 23:57:29 +0000169
170 if (stateNull && !stateNonNull) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000171 ExplodedNode *N = C.generateSink(stateNull);
Jordy Rosea6b808c2010-07-07 07:48:06 +0000172 if (!N)
173 return NULL;
174
Jordy Rosed325ffb2010-07-08 23:57:29 +0000175 if (!BT_Null)
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000176 BT_Null.reset(new BuiltinBug("API",
177 "Null pointer argument in call to byte string function"));
Jordy Rosea6b808c2010-07-07 07:48:06 +0000178
179 // Generate a report for this bug.
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000180 BuiltinBug *BT = static_cast<BuiltinBug*>(BT_Null.get());
Jordy Rosea6b808c2010-07-07 07:48:06 +0000181 EnhancedBugReport *report = new EnhancedBugReport(*BT,
182 BT->getDescription(), N);
183
184 report->addRange(S->getSourceRange());
185 report->addVisitorCreator(bugreporter::registerTrackNullOrUndefValue, S);
186 C.EmitReport(report);
187 return NULL;
188 }
189
190 // From here on, assume that the value is non-null.
Jordy Rosed325ffb2010-07-08 23:57:29 +0000191 assert(stateNonNull);
192 return stateNonNull;
Jordy Rosea6b808c2010-07-07 07:48:06 +0000193}
194
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000195// FIXME: This was originally copied from ArrayBoundChecker.cpp. Refactor?
196const GRState *CStringChecker::CheckLocation(CheckerContext &C,
197 const GRState *state,
Jordy Rosee64f3112010-08-16 07:51:42 +0000198 const Expr *S, SVal l,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000199 bool IsDestination) const {
Jordy Rosed325ffb2010-07-08 23:57:29 +0000200 // If a previous check has failed, propagate the failure.
201 if (!state)
202 return NULL;
203
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000204 // Check for out of bound array element access.
205 const MemRegion *R = l.getAsRegion();
206 if (!R)
207 return state;
208
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000209 const ElementRegion *ER = dyn_cast<ElementRegion>(R);
210 if (!ER)
211 return state;
212
Zhongxing Xu018220c2010-08-11 06:10:55 +0000213 assert(ER->getValueType() == C.getASTContext().CharTy &&
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000214 "CheckLocation should only be called with char* ElementRegions");
215
216 // Get the size of the array.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000217 const SubRegion *superReg = cast<SubRegion>(ER->getSuperRegion());
218 SValBuilder &svalBuilder = C.getSValBuilder();
219 SVal Extent = svalBuilder.convertToArrayIndex(superReg->getExtent(svalBuilder));
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000220 DefinedOrUnknownSVal Size = cast<DefinedOrUnknownSVal>(Extent);
221
222 // Get the index of the accessed element.
Gabor Greif89b06582010-09-09 10:51:37 +0000223 DefinedOrUnknownSVal Idx = cast<DefinedOrUnknownSVal>(ER->getIndex());
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000224
Ted Kremenek28f47b92010-12-01 22:16:56 +0000225 const GRState *StInBound = state->assumeInBound(Idx, Size, true);
226 const GRState *StOutBound = state->assumeInBound(Idx, Size, false);
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000227 if (StOutBound && !StInBound) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000228 ExplodedNode *N = C.generateSink(StOutBound);
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000229 if (!N)
230 return NULL;
231
Jordy Rosee64f3112010-08-16 07:51:42 +0000232 BuiltinBug *BT;
233 if (IsDestination) {
234 if (!BT_BoundsWrite) {
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000235 BT_BoundsWrite.reset(new BuiltinBug("Out-of-bound array access",
236 "Byte string function overflows destination buffer"));
Jordy Rosee64f3112010-08-16 07:51:42 +0000237 }
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000238 BT = static_cast<BuiltinBug*>(BT_BoundsWrite.get());
Jordy Rosee64f3112010-08-16 07:51:42 +0000239 } else {
240 if (!BT_Bounds) {
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000241 BT_Bounds.reset(new BuiltinBug("Out-of-bound array access",
242 "Byte string function accesses out-of-bound array element"));
Jordy Rosee64f3112010-08-16 07:51:42 +0000243 }
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000244 BT = static_cast<BuiltinBug*>(BT_Bounds.get());
Jordy Rosee64f3112010-08-16 07:51:42 +0000245 }
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000246
247 // FIXME: It would be nice to eventually make this diagnostic more clear,
248 // e.g., by referencing the original declaration or by saying *why* this
249 // reference is outside the range.
250
251 // Generate a report for this bug.
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000252 RangedBugReport *report = new RangedBugReport(*BT, BT->getDescription(), N);
253
254 report->addRange(S->getSourceRange());
255 C.EmitReport(report);
256 return NULL;
257 }
258
259 // Array bound check succeeded. From this point forward the array bound
260 // should always succeed.
261 return StInBound;
262}
263
264const GRState *CStringChecker::CheckBufferAccess(CheckerContext &C,
265 const GRState *state,
266 const Expr *Size,
267 const Expr *FirstBuf,
Jordy Rosee64f3112010-08-16 07:51:42 +0000268 const Expr *SecondBuf,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000269 bool FirstIsDestination) const {
Jordy Rosed325ffb2010-07-08 23:57:29 +0000270 // If a previous check has failed, propagate the failure.
271 if (!state)
272 return NULL;
273
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000274 SValBuilder &svalBuilder = C.getSValBuilder();
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000275 ASTContext &Ctx = C.getASTContext();
276
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000277 QualType sizeTy = Size->getType();
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000278 QualType PtrTy = Ctx.getPointerType(Ctx.CharTy);
279
Jordy Rosea6b808c2010-07-07 07:48:06 +0000280 // Check that the first buffer is non-null.
281 SVal BufVal = state->getSVal(FirstBuf);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000282 state = checkNonNull(C, state, FirstBuf, BufVal);
Jordy Rosea6b808c2010-07-07 07:48:06 +0000283 if (!state)
284 return NULL;
285
Jordy Rosed325ffb2010-07-08 23:57:29 +0000286 // Get the access length and make sure it is known.
287 SVal LengthVal = state->getSVal(Size);
288 NonLoc *Length = dyn_cast<NonLoc>(&LengthVal);
289 if (!Length)
290 return state;
291
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000292 // Compute the offset of the last element to be accessed: size-1.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000293 NonLoc One = cast<NonLoc>(svalBuilder.makeIntVal(1, sizeTy));
294 NonLoc LastOffset = cast<NonLoc>(svalBuilder.evalBinOpNN(state, BO_Sub,
295 *Length, One, sizeTy));
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000296
Chris Lattnerfc8f0e12011-04-15 05:22:18 +0000297 // Check that the first buffer is sufficiently long.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000298 SVal BufStart = svalBuilder.evalCast(BufVal, PtrTy, FirstBuf->getType());
Jordy Roseb6a40262010-08-05 23:11:30 +0000299 if (Loc *BufLoc = dyn_cast<Loc>(&BufStart)) {
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000300 SVal BufEnd = svalBuilder.evalBinOpLN(state, BO_Add, *BufLoc,
301 LastOffset, PtrTy);
Jordy Rosee64f3112010-08-16 07:51:42 +0000302 state = CheckLocation(C, state, FirstBuf, BufEnd, FirstIsDestination);
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000303
Jordy Roseb6a40262010-08-05 23:11:30 +0000304 // If the buffer isn't large enough, abort.
305 if (!state)
306 return NULL;
307 }
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000308
309 // If there's a second buffer, check it as well.
310 if (SecondBuf) {
311 BufVal = state->getSVal(SecondBuf);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000312 state = checkNonNull(C, state, SecondBuf, BufVal);
Jordy Rosea6b808c2010-07-07 07:48:06 +0000313 if (!state)
314 return NULL;
315
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000316 BufStart = svalBuilder.evalCast(BufVal, PtrTy, SecondBuf->getType());
Jordy Roseb6a40262010-08-05 23:11:30 +0000317 if (Loc *BufLoc = dyn_cast<Loc>(&BufStart)) {
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000318 SVal BufEnd = svalBuilder.evalBinOpLN(state, BO_Add, *BufLoc,
319 LastOffset, PtrTy);
Jordy Roseb6a40262010-08-05 23:11:30 +0000320 state = CheckLocation(C, state, SecondBuf, BufEnd);
321 }
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000322 }
323
324 // Large enough or not, return this state!
325 return state;
326}
327
328const GRState *CStringChecker::CheckOverlap(CheckerContext &C,
329 const GRState *state,
Jordy Rosed325ffb2010-07-08 23:57:29 +0000330 const Expr *Size,
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000331 const Expr *First,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000332 const Expr *Second) const {
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000333 // Do a simple check for overlap: if the two arguments are from the same
334 // buffer, see if the end of the first is greater than the start of the second
335 // or vice versa.
336
Jordy Rosed325ffb2010-07-08 23:57:29 +0000337 // If a previous check has failed, propagate the failure.
338 if (!state)
339 return NULL;
340
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000341 const GRState *stateTrue, *stateFalse;
342
343 // Get the buffer values and make sure they're known locations.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000344 SVal firstVal = state->getSVal(First);
345 SVal secondVal = state->getSVal(Second);
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000346
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000347 Loc *firstLoc = dyn_cast<Loc>(&firstVal);
348 if (!firstLoc)
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000349 return state;
350
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000351 Loc *secondLoc = dyn_cast<Loc>(&secondVal);
352 if (!secondLoc)
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000353 return state;
354
355 // Are the two values the same?
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000356 SValBuilder &svalBuilder = C.getSValBuilder();
357 llvm::tie(stateTrue, stateFalse) =
358 state->assume(svalBuilder.evalEQ(state, *firstLoc, *secondLoc));
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000359
360 if (stateTrue && !stateFalse) {
361 // If the values are known to be equal, that's automatically an overlap.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000362 emitOverlapBug(C, stateTrue, First, Second);
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000363 return NULL;
364 }
365
Ted Kremenek28f47b92010-12-01 22:16:56 +0000366 // assume the two expressions are not equal.
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000367 assert(stateFalse);
368 state = stateFalse;
369
370 // Which value comes first?
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000371 ASTContext &Ctx = svalBuilder.getContext();
372 QualType cmpTy = Ctx.IntTy;
373 SVal reverse = svalBuilder.evalBinOpLL(state, BO_GT,
374 *firstLoc, *secondLoc, cmpTy);
375 DefinedOrUnknownSVal *reverseTest = dyn_cast<DefinedOrUnknownSVal>(&reverse);
376 if (!reverseTest)
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000377 return state;
378
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000379 llvm::tie(stateTrue, stateFalse) = state->assume(*reverseTest);
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000380 if (stateTrue) {
381 if (stateFalse) {
382 // If we don't know which one comes first, we can't perform this test.
383 return state;
384 } else {
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000385 // Switch the values so that firstVal is before secondVal.
386 Loc *tmpLoc = firstLoc;
387 firstLoc = secondLoc;
388 secondLoc = tmpLoc;
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000389
390 // Switch the Exprs as well, so that they still correspond.
391 const Expr *tmpExpr = First;
392 First = Second;
393 Second = tmpExpr;
394 }
395 }
396
397 // Get the length, and make sure it too is known.
398 SVal LengthVal = state->getSVal(Size);
399 NonLoc *Length = dyn_cast<NonLoc>(&LengthVal);
400 if (!Length)
401 return state;
402
403 // Convert the first buffer's start address to char*.
404 // Bail out if the cast fails.
405 QualType CharPtrTy = Ctx.getPointerType(Ctx.CharTy);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000406 SVal FirstStart = svalBuilder.evalCast(*firstLoc, CharPtrTy, First->getType());
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000407 Loc *FirstStartLoc = dyn_cast<Loc>(&FirstStart);
408 if (!FirstStartLoc)
409 return state;
410
411 // Compute the end of the first buffer. Bail out if THAT fails.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000412 SVal FirstEnd = svalBuilder.evalBinOpLN(state, BO_Add,
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000413 *FirstStartLoc, *Length, CharPtrTy);
414 Loc *FirstEndLoc = dyn_cast<Loc>(&FirstEnd);
415 if (!FirstEndLoc)
416 return state;
417
418 // Is the end of the first buffer past the start of the second buffer?
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000419 SVal Overlap = svalBuilder.evalBinOpLL(state, BO_GT,
420 *FirstEndLoc, *secondLoc, cmpTy);
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000421 DefinedOrUnknownSVal *OverlapTest = dyn_cast<DefinedOrUnknownSVal>(&Overlap);
422 if (!OverlapTest)
423 return state;
424
Ted Kremenek28f47b92010-12-01 22:16:56 +0000425 llvm::tie(stateTrue, stateFalse) = state->assume(*OverlapTest);
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000426
427 if (stateTrue && !stateFalse) {
428 // Overlap!
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000429 emitOverlapBug(C, stateTrue, First, Second);
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000430 return NULL;
431 }
432
Ted Kremenek28f47b92010-12-01 22:16:56 +0000433 // assume the two expressions don't overlap.
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000434 assert(stateFalse);
435 return stateFalse;
436}
437
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000438void CStringChecker::emitOverlapBug(CheckerContext &C, const GRState *state,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000439 const Stmt *First, const Stmt *Second) const {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000440 ExplodedNode *N = C.generateSink(state);
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000441 if (!N)
442 return;
443
444 if (!BT_Overlap)
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000445 BT_Overlap.reset(new BugType("Unix API", "Improper arguments"));
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000446
447 // Generate a report for this bug.
448 RangedBugReport *report =
449 new RangedBugReport(*BT_Overlap,
450 "Arguments must not be overlapping buffers", N);
451 report->addRange(First->getSourceRange());
452 report->addRange(Second->getSourceRange());
453
454 C.EmitReport(report);
455}
456
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000457const GRState *CStringChecker::setCStringLength(const GRState *state,
Jordy Rosee64f3112010-08-16 07:51:42 +0000458 const MemRegion *MR,
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000459 SVal strLength) {
460 assert(!strLength.isUndef() && "Attempt to set an undefined string length");
Jordy Rosee64f3112010-08-16 07:51:42 +0000461
462 MR = MR->StripCasts();
463
464 switch (MR->getKind()) {
465 case MemRegion::StringRegionKind:
466 // FIXME: This can happen if we strcpy() into a string region. This is
467 // undefined [C99 6.4.5p6], but we should still warn about it.
468 return state;
469
470 case MemRegion::SymbolicRegionKind:
471 case MemRegion::AllocaRegionKind:
472 case MemRegion::VarRegionKind:
473 case MemRegion::FieldRegionKind:
474 case MemRegion::ObjCIvarRegionKind:
Jordy Rose210c05b2011-06-15 05:14:03 +0000475 // These are the types we can currently track string lengths for.
476 break;
Jordy Rosee64f3112010-08-16 07:51:42 +0000477
478 case MemRegion::ElementRegionKind:
479 // FIXME: Handle element regions by upper-bounding the parent region's
480 // string length.
481 return state;
482
483 default:
484 // Other regions (mostly non-data) can't have a reliable C string length.
485 // For now, just ignore the change.
486 // FIXME: These are rare but not impossible. We should output some kind of
487 // warning for things like strcpy((char[]){'a', 0}, "b");
488 return state;
489 }
Jordy Rose210c05b2011-06-15 05:14:03 +0000490
491 if (strLength.isUnknown())
492 return state->remove<CStringLength>(MR);
493
494 return state->set<CStringLength>(MR, strLength);
Jordy Rosee64f3112010-08-16 07:51:42 +0000495}
496
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000497SVal CStringChecker::getCStringLengthForRegion(CheckerContext &C,
Jordy Rosea5261542010-08-14 21:02:52 +0000498 const GRState *&state,
499 const Expr *Ex,
500 const MemRegion *MR) {
501 // If there's a recorded length, go ahead and return it.
502 const SVal *Recorded = state->get<CStringLength>(MR);
503 if (Recorded)
504 return *Recorded;
505
506 // Otherwise, get a new symbol and update the state.
507 unsigned Count = C.getNodeBuilder().getCurrentBlockCount();
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000508 SValBuilder &svalBuilder = C.getSValBuilder();
509 QualType sizeTy = svalBuilder.getContext().getSizeType();
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000510 SVal strLength = svalBuilder.getMetadataSymbolVal(CStringChecker::getTag(),
511 MR, Ex, sizeTy, Count);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000512 state = state->set<CStringLength>(MR, strLength);
513 return strLength;
Jordy Rosea5261542010-08-14 21:02:52 +0000514}
515
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000516SVal CStringChecker::getCStringLength(CheckerContext &C, const GRState *&state,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000517 const Expr *Ex, SVal Buf) const {
Jordy Rose19c5dd12010-07-27 01:37:31 +0000518 const MemRegion *MR = Buf.getAsRegion();
519 if (!MR) {
520 // If we can't get a region, see if it's something we /know/ isn't a
521 // C string. In the context of locations, the only time we can issue such
522 // a warning is for labels.
523 if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&Buf)) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000524 if (ExplodedNode *N = C.generateNode(state)) {
Jordy Rose19c5dd12010-07-27 01:37:31 +0000525 if (!BT_NotCString)
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000526 BT_NotCString.reset(new BuiltinBug("API",
527 "Argument is not a null-terminated string."));
Jordy Rose19c5dd12010-07-27 01:37:31 +0000528
529 llvm::SmallString<120> buf;
530 llvm::raw_svector_ostream os(buf);
531 os << "Argument to byte string function is the address of the label '"
Chris Lattner68106302011-02-17 05:38:27 +0000532 << Label->getLabel()->getName()
Jordy Rose19c5dd12010-07-27 01:37:31 +0000533 << "', which is not a null-terminated string";
534
535 // Generate a report for this bug.
536 EnhancedBugReport *report = new EnhancedBugReport(*BT_NotCString,
537 os.str(), N);
538
539 report->addRange(Ex->getSourceRange());
540 C.EmitReport(report);
541 }
542
543 return UndefinedVal();
544 }
545
Jordy Rosea5261542010-08-14 21:02:52 +0000546 // If it's not a region and not a label, give up.
547 return UnknownVal();
Jordy Rose19c5dd12010-07-27 01:37:31 +0000548 }
549
Jordy Rosea5261542010-08-14 21:02:52 +0000550 // If we have a region, strip casts from it and see if we can figure out
551 // its length. For anything we can't figure out, just return UnknownVal.
552 MR = MR->StripCasts();
553
554 switch (MR->getKind()) {
555 case MemRegion::StringRegionKind: {
556 // Modifying the contents of string regions is undefined [C99 6.4.5p6],
557 // so we can assume that the byte length is the correct C string length.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000558 SValBuilder &svalBuilder = C.getSValBuilder();
559 QualType sizeTy = svalBuilder.getContext().getSizeType();
560 const StringLiteral *strLit = cast<StringRegion>(MR)->getStringLiteral();
561 return svalBuilder.makeIntVal(strLit->getByteLength(), sizeTy);
Jordy Rosea5261542010-08-14 21:02:52 +0000562 }
563 case MemRegion::SymbolicRegionKind:
564 case MemRegion::AllocaRegionKind:
565 case MemRegion::VarRegionKind:
566 case MemRegion::FieldRegionKind:
567 case MemRegion::ObjCIvarRegionKind:
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000568 return getCStringLengthForRegion(C, state, Ex, MR);
Jordy Rosea5261542010-08-14 21:02:52 +0000569 case MemRegion::CompoundLiteralRegionKind:
570 // FIXME: Can we track this? Is it necessary?
571 return UnknownVal();
572 case MemRegion::ElementRegionKind:
573 // FIXME: How can we handle this? It's not good enough to subtract the
574 // offset from the base string length; consider "123\x00567" and &a[5].
575 return UnknownVal();
576 default:
577 // Other regions (mostly non-data) can't have a reliable C string length.
578 // In this case, an error is emitted and UndefinedVal is returned.
579 // The caller should always be prepared to handle this case.
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000580 if (ExplodedNode *N = C.generateNode(state)) {
Jordy Rosea5261542010-08-14 21:02:52 +0000581 if (!BT_NotCString)
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000582 BT_NotCString.reset(new BuiltinBug("API",
583 "Argument is not a null-terminated string."));
Jordy Rosea5261542010-08-14 21:02:52 +0000584
585 llvm::SmallString<120> buf;
586 llvm::raw_svector_ostream os(buf);
587
588 os << "Argument to byte string function is ";
589
590 if (SummarizeRegion(os, C.getASTContext(), MR))
591 os << ", which is not a null-terminated string";
592 else
593 os << "not a null-terminated string";
594
595 // Generate a report for this bug.
596 EnhancedBugReport *report = new EnhancedBugReport(*BT_NotCString,
597 os.str(), N);
598
599 report->addRange(Ex->getSourceRange());
600 C.EmitReport(report);
601 }
602
603 return UndefinedVal();
604 }
Jordy Rose19c5dd12010-07-27 01:37:31 +0000605}
606
Lenny Maiorani318dd922011-04-12 17:08:43 +0000607const StringLiteral *CStringChecker::getCStringLiteral(CheckerContext &C,
608 const GRState *&state, const Expr *expr, SVal val) const {
609
610 // Get the memory region pointed to by the val.
611 const MemRegion *bufRegion = val.getAsRegion();
612 if (!bufRegion)
613 return NULL;
614
615 // Strip casts off the memory region.
616 bufRegion = bufRegion->StripCasts();
617
618 // Cast the memory region to a string region.
619 const StringRegion *strRegion= dyn_cast<StringRegion>(bufRegion);
620 if (!strRegion)
621 return NULL;
622
623 // Return the actual string in the string region.
624 return strRegion->getStringLiteral();
625}
626
Jordy Rosee64f3112010-08-16 07:51:42 +0000627const GRState *CStringChecker::InvalidateBuffer(CheckerContext &C,
628 const GRState *state,
629 const Expr *E, SVal V) {
630 Loc *L = dyn_cast<Loc>(&V);
631 if (!L)
632 return state;
633
634 // FIXME: This is a simplified version of what's in CFRefCount.cpp -- it makes
635 // some assumptions about the value that CFRefCount can't. Even so, it should
636 // probably be refactored.
637 if (loc::MemRegionVal* MR = dyn_cast<loc::MemRegionVal>(L)) {
638 const MemRegion *R = MR->getRegion()->StripCasts();
639
640 // Are we dealing with an ElementRegion? If so, we should be invalidating
641 // the super-region.
642 if (const ElementRegion *ER = dyn_cast<ElementRegion>(R)) {
643 R = ER->getSuperRegion();
644 // FIXME: What about layers of ElementRegions?
645 }
646
647 // Invalidate this region.
648 unsigned Count = C.getNodeBuilder().getCurrentBlockCount();
Ted Kremenek25345282011-02-11 19:48:15 +0000649 return state->invalidateRegion(R, E, Count, NULL);
Jordy Rosee64f3112010-08-16 07:51:42 +0000650 }
651
652 // If we have a non-region value by chance, just remove the binding.
653 // FIXME: is this necessary or correct? This handles the non-Region
654 // cases. Is it ever valid to store to these?
655 return state->unbindLoc(*L);
656}
657
Jordy Rose19c5dd12010-07-27 01:37:31 +0000658bool CStringChecker::SummarizeRegion(llvm::raw_ostream& os, ASTContext& Ctx,
659 const MemRegion *MR) {
660 const TypedRegion *TR = dyn_cast<TypedRegion>(MR);
661 if (!TR)
662 return false;
663
664 switch (TR->getKind()) {
665 case MemRegion::FunctionTextRegionKind: {
666 const FunctionDecl *FD = cast<FunctionTextRegion>(TR)->getDecl();
667 if (FD)
668 os << "the address of the function '" << FD << "'";
669 else
670 os << "the address of a function";
671 return true;
672 }
673 case MemRegion::BlockTextRegionKind:
674 os << "block text";
675 return true;
676 case MemRegion::BlockDataRegionKind:
677 os << "a block";
678 return true;
679 case MemRegion::CXXThisRegionKind:
Zhongxing Xu02fe28c2010-11-26 08:52:48 +0000680 case MemRegion::CXXTempObjectRegionKind:
681 os << "a C++ temp object of type " << TR->getValueType().getAsString();
Jordy Rose19c5dd12010-07-27 01:37:31 +0000682 return true;
683 case MemRegion::VarRegionKind:
Zhongxing Xu018220c2010-08-11 06:10:55 +0000684 os << "a variable of type" << TR->getValueType().getAsString();
Jordy Rose19c5dd12010-07-27 01:37:31 +0000685 return true;
686 case MemRegion::FieldRegionKind:
Zhongxing Xu018220c2010-08-11 06:10:55 +0000687 os << "a field of type " << TR->getValueType().getAsString();
Jordy Rose19c5dd12010-07-27 01:37:31 +0000688 return true;
689 case MemRegion::ObjCIvarRegionKind:
Zhongxing Xu018220c2010-08-11 06:10:55 +0000690 os << "an instance variable of type " << TR->getValueType().getAsString();
Jordy Rose19c5dd12010-07-27 01:37:31 +0000691 return true;
692 default:
693 return false;
694 }
695}
696
Jordy Rosed325ffb2010-07-08 23:57:29 +0000697//===----------------------------------------------------------------------===//
Ted Kremenek9c149532010-12-01 21:57:22 +0000698// evaluation of individual function calls.
Jordy Rosed325ffb2010-07-08 23:57:29 +0000699//===----------------------------------------------------------------------===//
700
Lenny Maioranib8b875b2011-03-31 21:36:53 +0000701void CStringChecker::evalCopyCommon(CheckerContext &C,
702 const CallExpr *CE,
703 const GRState *state,
Jordy Rosed325ffb2010-07-08 23:57:29 +0000704 const Expr *Size, const Expr *Dest,
Lenny Maioranib8b875b2011-03-31 21:36:53 +0000705 const Expr *Source, bool Restricted,
706 bool IsMempcpy) const {
Jordy Rosed325ffb2010-07-08 23:57:29 +0000707 // See if the size argument is zero.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000708 SVal sizeVal = state->getSVal(Size);
709 QualType sizeTy = Size->getType();
Jordy Rosed325ffb2010-07-08 23:57:29 +0000710
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000711 const GRState *stateZeroSize, *stateNonZeroSize;
712 llvm::tie(stateZeroSize, stateNonZeroSize) = assumeZero(C, state, sizeVal, sizeTy);
Jordy Rosed325ffb2010-07-08 23:57:29 +0000713
Lenny Maioranib8b875b2011-03-31 21:36:53 +0000714 // Get the value of the Dest.
715 SVal destVal = state->getSVal(Dest);
716
717 // If the size is zero, there won't be any actual memory access, so
718 // just bind the return value to the destination buffer and return.
719 if (stateZeroSize) {
Jordy Rose22d27172011-06-04 00:04:22 +0000720 stateZeroSize = stateZeroSize->BindExpr(CE, destVal);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000721 C.addTransition(stateZeroSize);
Lenny Maioranib8b875b2011-03-31 21:36:53 +0000722 }
Jordy Rosed325ffb2010-07-08 23:57:29 +0000723
724 // If the size can be nonzero, we have to check the other arguments.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000725 if (stateNonZeroSize) {
Jordy Rose22d27172011-06-04 00:04:22 +0000726 state = stateNonZeroSize;
Lenny Maioranib8b875b2011-03-31 21:36:53 +0000727
728 // Ensure the destination is not null. If it is NULL there will be a
729 // NULL pointer dereference.
730 state = checkNonNull(C, state, Dest, destVal);
731 if (!state)
732 return;
733
734 // Get the value of the Src.
735 SVal srcVal = state->getSVal(Source);
736
737 // Ensure the source is not null. If it is NULL there will be a
738 // NULL pointer dereference.
739 state = checkNonNull(C, state, Source, srcVal);
740 if (!state)
741 return;
742
Jordy Rose7182b962011-06-04 01:50:25 +0000743 // Ensure the accesses are valid and that the buffers do not overlap.
Jordy Rosee64f3112010-08-16 07:51:42 +0000744 state = CheckBufferAccess(C, state, Size, Dest, Source,
745 /* FirstIsDst = */ true);
Jordy Rosed325ffb2010-07-08 23:57:29 +0000746 if (Restricted)
747 state = CheckOverlap(C, state, Size, Dest, Source);
Jordy Rosee64f3112010-08-16 07:51:42 +0000748
Jordy Rose7182b962011-06-04 01:50:25 +0000749 if (!state)
750 return;
Lenny Maioranib8b875b2011-03-31 21:36:53 +0000751
Jordy Rose7182b962011-06-04 01:50:25 +0000752 // If this is mempcpy, get the byte after the last byte copied and
753 // bind the expr.
754 if (IsMempcpy) {
755 loc::MemRegionVal *destRegVal = dyn_cast<loc::MemRegionVal>(&destVal);
756 assert(destRegVal && "Destination should be a known MemRegionVal here");
757
758 // Get the length to copy.
759 NonLoc *lenValNonLoc = dyn_cast<NonLoc>(&sizeVal);
760
761 if (lenValNonLoc) {
762 // Get the byte after the last byte copied.
763 SVal lastElement = C.getSValBuilder().evalBinOpLN(state, BO_Add,
764 *destRegVal,
765 *lenValNonLoc,
766 Dest->getType());
767
768 // The byte after the last byte copied is the return value.
769 state = state->BindExpr(CE, lastElement);
Jordy Rose3f8bb2f2011-06-04 01:47:27 +0000770 } else {
Jordy Rose7182b962011-06-04 01:50:25 +0000771 // If we don't know how much we copied, we can at least
772 // conjure a return value for later.
773 unsigned Count = C.getNodeBuilder().getCurrentBlockCount();
774 SVal result =
775 C.getSValBuilder().getConjuredSymbolVal(NULL, CE, Count);
776 state = state->BindExpr(CE, result);
Lenny Maioranib8b875b2011-03-31 21:36:53 +0000777 }
778
Jordy Rose7182b962011-06-04 01:50:25 +0000779 } else {
780 // All other copies return the destination buffer.
781 // (Well, bcopy() has a void return type, but this won't hurt.)
782 state = state->BindExpr(CE, destVal);
Jordy Rosee64f3112010-08-16 07:51:42 +0000783 }
Jordy Rose7182b962011-06-04 01:50:25 +0000784
785 // Invalidate the destination.
786 // FIXME: Even if we can't perfectly model the copy, we should see if we
787 // can use LazyCompoundVals to copy the source values into the destination.
788 // This would probably remove any existing bindings past the end of the
789 // copied region, but that's still an improvement over blank invalidation.
790 state = InvalidateBuffer(C, state, Dest, state->getSVal(Dest));
791 C.addTransition(state);
Jordy Rosed325ffb2010-07-08 23:57:29 +0000792 }
793}
794
795
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000796void CStringChecker::evalMemcpy(CheckerContext &C, const CallExpr *CE) const {
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000797 // void *memcpy(void *restrict dst, const void *restrict src, size_t n);
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000798 // The return value is the address of the destination buffer.
Jordy Rosed325ffb2010-07-08 23:57:29 +0000799 const Expr *Dest = CE->getArg(0);
800 const GRState *state = C.getState();
Jordy Rose3f8bb2f2011-06-04 01:47:27 +0000801
Lenny Maioranib8b875b2011-03-31 21:36:53 +0000802 evalCopyCommon(C, CE, state, CE->getArg(2), Dest, CE->getArg(1), true);
803}
804
805void CStringChecker::evalMempcpy(CheckerContext &C, const CallExpr *CE) const {
806 // void *mempcpy(void *restrict dst, const void *restrict src, size_t n);
807 // The return value is a pointer to the byte following the last written byte.
808 const Expr *Dest = CE->getArg(0);
809 const GRState *state = C.getState();
810
811 evalCopyCommon(C, CE, state, CE->getArg(2), Dest, CE->getArg(1), true, true);
Jordy Roseccbf7ee2010-07-06 23:11:01 +0000812}
813
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000814void CStringChecker::evalMemmove(CheckerContext &C, const CallExpr *CE) const {
Jordy Rosed325ffb2010-07-08 23:57:29 +0000815 // void *memmove(void *dst, const void *src, size_t n);
816 // The return value is the address of the destination buffer.
817 const Expr *Dest = CE->getArg(0);
818 const GRState *state = C.getState();
Jordy Rose3f8bb2f2011-06-04 01:47:27 +0000819
Lenny Maioranib8b875b2011-03-31 21:36:53 +0000820 evalCopyCommon(C, CE, state, CE->getArg(2), Dest, CE->getArg(1));
Jordy Rosed325ffb2010-07-08 23:57:29 +0000821}
822
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000823void CStringChecker::evalBcopy(CheckerContext &C, const CallExpr *CE) const {
Jordy Rosed325ffb2010-07-08 23:57:29 +0000824 // void bcopy(const void *src, void *dst, size_t n);
Lenny Maioranib8b875b2011-03-31 21:36:53 +0000825 evalCopyCommon(C, CE, C.getState(),
826 CE->getArg(2), CE->getArg(1), CE->getArg(0));
Jordy Rosed325ffb2010-07-08 23:57:29 +0000827}
828
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000829void CStringChecker::evalMemcmp(CheckerContext &C, const CallExpr *CE) const {
Jordy Rosebc56d1f2010-07-07 08:15:01 +0000830 // int memcmp(const void *s1, const void *s2, size_t n);
831 const Expr *Left = CE->getArg(0);
832 const Expr *Right = CE->getArg(1);
833 const Expr *Size = CE->getArg(2);
834
835 const GRState *state = C.getState();
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000836 SValBuilder &svalBuilder = C.getSValBuilder();
Jordy Rosebc56d1f2010-07-07 08:15:01 +0000837
Jordy Rosed325ffb2010-07-08 23:57:29 +0000838 // See if the size argument is zero.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000839 SVal sizeVal = state->getSVal(Size);
840 QualType sizeTy = Size->getType();
Jordy Rosebc56d1f2010-07-07 08:15:01 +0000841
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000842 const GRState *stateZeroSize, *stateNonZeroSize;
843 llvm::tie(stateZeroSize, stateNonZeroSize) =
844 assumeZero(C, state, sizeVal, sizeTy);
Jordy Rosebc56d1f2010-07-07 08:15:01 +0000845
Jordy Rosed325ffb2010-07-08 23:57:29 +0000846 // If the size can be zero, the result will be 0 in that case, and we don't
847 // have to check either of the buffers.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000848 if (stateZeroSize) {
849 state = stateZeroSize;
850 state = state->BindExpr(CE, svalBuilder.makeZeroVal(CE->getType()));
Jordy Rosed325ffb2010-07-08 23:57:29 +0000851 C.addTransition(state);
Jordy Rosebc56d1f2010-07-07 08:15:01 +0000852 }
853
Jordy Rosed325ffb2010-07-08 23:57:29 +0000854 // If the size can be nonzero, we have to check the other arguments.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000855 if (stateNonZeroSize) {
856 state = stateNonZeroSize;
Jordy Rosed325ffb2010-07-08 23:57:29 +0000857 // If we know the two buffers are the same, we know the result is 0.
858 // First, get the two buffers' addresses. Another checker will have already
859 // made sure they're not undefined.
860 DefinedOrUnknownSVal LV = cast<DefinedOrUnknownSVal>(state->getSVal(Left));
861 DefinedOrUnknownSVal RV = cast<DefinedOrUnknownSVal>(state->getSVal(Right));
Jordy Rosebc56d1f2010-07-07 08:15:01 +0000862
Jordy Rosed325ffb2010-07-08 23:57:29 +0000863 // See if they are the same.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000864 DefinedOrUnknownSVal SameBuf = svalBuilder.evalEQ(state, LV, RV);
Jordy Rosed325ffb2010-07-08 23:57:29 +0000865 const GRState *StSameBuf, *StNotSameBuf;
Ted Kremenek28f47b92010-12-01 22:16:56 +0000866 llvm::tie(StSameBuf, StNotSameBuf) = state->assume(SameBuf);
Jordy Rosed325ffb2010-07-08 23:57:29 +0000867
868 // If the two arguments might be the same buffer, we know the result is zero,
869 // and we only need to check one size.
870 if (StSameBuf) {
871 state = StSameBuf;
872 state = CheckBufferAccess(C, state, Size, Left);
873 if (state) {
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000874 state = StSameBuf->BindExpr(CE, svalBuilder.makeZeroVal(CE->getType()));
Jordy Rosed325ffb2010-07-08 23:57:29 +0000875 C.addTransition(state);
876 }
877 }
878
879 // If the two arguments might be different buffers, we have to check the
880 // size of both of them.
881 if (StNotSameBuf) {
882 state = StNotSameBuf;
883 state = CheckBufferAccess(C, state, Size, Left, Right);
884 if (state) {
885 // The return value is the comparison result, which we don't know.
886 unsigned Count = C.getNodeBuilder().getCurrentBlockCount();
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000887 SVal CmpV = svalBuilder.getConjuredSymbolVal(NULL, CE, Count);
Jordy Rosed325ffb2010-07-08 23:57:29 +0000888 state = state->BindExpr(CE, CmpV);
889 C.addTransition(state);
890 }
891 }
892 }
Jordy Rosebc56d1f2010-07-07 08:15:01 +0000893}
894
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000895void CStringChecker::evalstrLength(CheckerContext &C,
896 const CallExpr *CE) const {
Jordy Rose19c5dd12010-07-27 01:37:31 +0000897 // size_t strlen(const char *s);
Ted Kremenekbe4242c2011-02-22 04:55:05 +0000898 evalstrLengthCommon(C, CE, /* IsStrnlen = */ false);
899}
900
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000901void CStringChecker::evalstrnLength(CheckerContext &C,
902 const CallExpr *CE) const {
Ted Kremenekbe4242c2011-02-22 04:55:05 +0000903 // size_t strnlen(const char *s, size_t maxlen);
904 evalstrLengthCommon(C, CE, /* IsStrnlen = */ true);
905}
906
907void CStringChecker::evalstrLengthCommon(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +0000908 bool IsStrnlen) const {
Jordy Rose19c5dd12010-07-27 01:37:31 +0000909 const GRState *state = C.getState();
Jordy Rose793bff32011-06-14 01:15:31 +0000910
911 if (IsStrnlen) {
912 const Expr *maxlenExpr = CE->getArg(1);
913 SVal maxlenVal = state->getSVal(maxlenExpr);
914
915 const GRState *stateZeroSize, *stateNonZeroSize;
916 llvm::tie(stateZeroSize, stateNonZeroSize) =
917 assumeZero(C, state, maxlenVal, maxlenExpr->getType());
918
919 // If the size can be zero, the result will be 0 in that case, and we don't
920 // have to check the string itself.
921 if (stateZeroSize) {
922 SVal zero = C.getSValBuilder().makeZeroVal(CE->getType());
923 stateZeroSize = stateZeroSize->BindExpr(CE, zero);
924 C.addTransition(stateZeroSize);
925 }
926
927 // If the size is GUARANTEED to be zero, we're done!
928 if (!stateNonZeroSize)
929 return;
930
931 // Otherwise, record the assumption that the size is nonzero.
932 state = stateNonZeroSize;
933 }
934
935 // Check that the string argument is non-null.
Jordy Rose19c5dd12010-07-27 01:37:31 +0000936 const Expr *Arg = CE->getArg(0);
937 SVal ArgVal = state->getSVal(Arg);
938
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000939 state = checkNonNull(C, state, Arg, ArgVal);
Jordy Rose19c5dd12010-07-27 01:37:31 +0000940
Jordy Rosebd32bee2011-06-14 01:26:48 +0000941 if (!state)
942 return;
Jordy Rosea5261542010-08-14 21:02:52 +0000943
Jordy Rosebd32bee2011-06-14 01:26:48 +0000944 SVal strLength = getCStringLength(C, state, Arg, ArgVal);
Jordy Rosea5261542010-08-14 21:02:52 +0000945
Jordy Rosebd32bee2011-06-14 01:26:48 +0000946 // If the argument isn't a valid C string, there's no valid state to
947 // transition to.
948 if (strLength.isUndef())
949 return;
Jordy Rose793bff32011-06-14 01:15:31 +0000950
Jordy Rosebd32bee2011-06-14 01:26:48 +0000951 DefinedOrUnknownSVal result = UnknownVal();
Jordy Rose793bff32011-06-14 01:15:31 +0000952
Jordy Rosebd32bee2011-06-14 01:26:48 +0000953 // If the check is for strnlen() then bind the return value to no more than
954 // the maxlen value.
955 if (IsStrnlen) {
956 QualType cmpTy = C.getSValBuilder().getContext().IntTy;
Jordy Rose793bff32011-06-14 01:15:31 +0000957
Jordy Rosebd32bee2011-06-14 01:26:48 +0000958 // It's a little unfortunate to be getting this again,
959 // but it's not that expensive...
960 const Expr *maxlenExpr = CE->getArg(1);
961 SVal maxlenVal = state->getSVal(maxlenExpr);
Ted Kremenekbe4242c2011-02-22 04:55:05 +0000962
Jordy Rosebd32bee2011-06-14 01:26:48 +0000963 NonLoc *strLengthNL = dyn_cast<NonLoc>(&strLength);
964 NonLoc *maxlenValNL = dyn_cast<NonLoc>(&maxlenVal);
Ted Kremenekbe4242c2011-02-22 04:55:05 +0000965
Jordy Rosebd32bee2011-06-14 01:26:48 +0000966 if (strLengthNL && maxlenValNL) {
967 const GRState *stateStringTooLong, *stateStringNotTooLong;
Jordy Rose793bff32011-06-14 01:15:31 +0000968
Jordy Rosebd32bee2011-06-14 01:26:48 +0000969 // Check if the strLength is greater than the maxlen.
970 llvm::tie(stateStringTooLong, stateStringNotTooLong) =
971 state->assume(cast<DefinedOrUnknownSVal>
972 (C.getSValBuilder().evalBinOpNN(state, BO_GT,
973 *strLengthNL,
974 *maxlenValNL,
975 cmpTy)));
Jordy Rose793bff32011-06-14 01:15:31 +0000976
Jordy Rosebd32bee2011-06-14 01:26:48 +0000977 if (stateStringTooLong && !stateStringNotTooLong) {
978 // If the string is longer than maxlen, return maxlen.
979 result = *maxlenValNL;
980 } else if (stateStringNotTooLong && !stateStringTooLong) {
981 // If the string is shorter than maxlen, return its length.
982 result = *strLengthNL;
Ted Kremenekbe4242c2011-02-22 04:55:05 +0000983 }
984 }
985
Jordy Rosebd32bee2011-06-14 01:26:48 +0000986 if (result.isUnknown()) {
987 // If we don't have enough information for a comparison, there's
988 // no guarantee the full string length will actually be returned.
989 // All we know is the return value is the min of the string length
990 // and the limit. This is better than nothing.
991 unsigned Count = C.getNodeBuilder().getCurrentBlockCount();
992 result = C.getSValBuilder().getConjuredSymbolVal(NULL, CE, Count);
993 NonLoc *resultNL = cast<NonLoc>(&result);
994
995 if (strLengthNL) {
996 state = state->assume(cast<DefinedOrUnknownSVal>
997 (C.getSValBuilder().evalBinOpNN(state, BO_LE,
998 *resultNL,
999 *strLengthNL,
1000 cmpTy)), true);
1001 }
1002
1003 if (maxlenValNL) {
1004 state = state->assume(cast<DefinedOrUnknownSVal>
1005 (C.getSValBuilder().evalBinOpNN(state, BO_LE,
1006 *resultNL,
1007 *maxlenValNL,
1008 cmpTy)), true);
1009 }
1010 }
1011
1012 } else {
1013 // This is a plain strlen(), not strnlen().
1014 result = cast<DefinedOrUnknownSVal>(strLength);
1015
1016 // If we don't know the length of the string, conjure a return
1017 // value, so it can be used in constraints, at least.
1018 if (result.isUnknown()) {
1019 unsigned Count = C.getNodeBuilder().getCurrentBlockCount();
1020 result = C.getSValBuilder().getConjuredSymbolVal(NULL, CE, Count);
1021 }
Jordy Rose19c5dd12010-07-27 01:37:31 +00001022 }
Jordy Rosebd32bee2011-06-14 01:26:48 +00001023
1024 // Bind the return value.
1025 assert(!result.isUnknown() && "Should have conjured a value by now");
1026 state = state->BindExpr(CE, result);
1027 C.addTransition(state);
Jordy Rose19c5dd12010-07-27 01:37:31 +00001028}
1029
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +00001030void CStringChecker::evalStrcpy(CheckerContext &C, const CallExpr *CE) const {
Jordy Rosee64f3112010-08-16 07:51:42 +00001031 // char *strcpy(char *restrict dst, const char *restrict src);
Lenny Maiorani067bbd02011-04-09 15:12:58 +00001032 evalStrcpyCommon(C, CE,
1033 /* returnEnd = */ false,
1034 /* isBounded = */ false,
1035 /* isAppending = */ false);
Ted Kremenek0ef473f2011-02-22 04:58:34 +00001036}
1037
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +00001038void CStringChecker::evalStrncpy(CheckerContext &C, const CallExpr *CE) const {
Jordy Rosec1525862011-06-04 00:05:23 +00001039 // char *strncpy(char *restrict dst, const char *restrict src, size_t n);
Lenny Maiorani067bbd02011-04-09 15:12:58 +00001040 evalStrcpyCommon(C, CE,
1041 /* returnEnd = */ false,
1042 /* isBounded = */ true,
1043 /* isAppending = */ false);
Jordy Rosee64f3112010-08-16 07:51:42 +00001044}
1045
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +00001046void CStringChecker::evalStpcpy(CheckerContext &C, const CallExpr *CE) const {
Jordy Rosee64f3112010-08-16 07:51:42 +00001047 // char *stpcpy(char *restrict dst, const char *restrict src);
Lenny Maiorani067bbd02011-04-09 15:12:58 +00001048 evalStrcpyCommon(C, CE,
1049 /* returnEnd = */ true,
1050 /* isBounded = */ false,
1051 /* isAppending = */ false);
1052}
1053
1054void CStringChecker::evalStrcat(CheckerContext &C, const CallExpr *CE) const {
1055 //char *strcat(char *restrict s1, const char *restrict s2);
1056 evalStrcpyCommon(C, CE,
1057 /* returnEnd = */ false,
1058 /* isBounded = */ false,
1059 /* isAppending = */ true);
1060}
1061
1062void CStringChecker::evalStrncat(CheckerContext &C, const CallExpr *CE) const {
1063 //char *strncat(char *restrict s1, const char *restrict s2, size_t n);
1064 evalStrcpyCommon(C, CE,
1065 /* returnEnd = */ false,
1066 /* isBounded = */ true,
1067 /* isAppending = */ true);
Jordy Rosee64f3112010-08-16 07:51:42 +00001068}
1069
Ted Kremenek9c149532010-12-01 21:57:22 +00001070void CStringChecker::evalStrcpyCommon(CheckerContext &C, const CallExpr *CE,
Lenny Maiorani067bbd02011-04-09 15:12:58 +00001071 bool returnEnd, bool isBounded,
1072 bool isAppending) const {
Jordy Rosee64f3112010-08-16 07:51:42 +00001073 const GRState *state = C.getState();
1074
Lenny Maiorani067bbd02011-04-09 15:12:58 +00001075 // Check that the destination is non-null.
Jordy Rosee64f3112010-08-16 07:51:42 +00001076 const Expr *Dst = CE->getArg(0);
1077 SVal DstVal = state->getSVal(Dst);
1078
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001079 state = checkNonNull(C, state, Dst, DstVal);
Jordy Rosee64f3112010-08-16 07:51:42 +00001080 if (!state)
1081 return;
1082
1083 // Check that the source is non-null.
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001084 const Expr *srcExpr = CE->getArg(1);
1085 SVal srcVal = state->getSVal(srcExpr);
1086 state = checkNonNull(C, state, srcExpr, srcVal);
Jordy Rosee64f3112010-08-16 07:51:42 +00001087 if (!state)
1088 return;
1089
1090 // Get the string length of the source.
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001091 SVal strLength = getCStringLength(C, state, srcExpr, srcVal);
Jordy Rosee64f3112010-08-16 07:51:42 +00001092
1093 // If the source isn't a valid C string, give up.
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001094 if (strLength.isUndef())
Jordy Rosee64f3112010-08-16 07:51:42 +00001095 return;
1096
Lenny Maiorani067bbd02011-04-09 15:12:58 +00001097 // If the function is strncpy, strncat, etc... it is bounded.
1098 if (isBounded) {
1099 // Get the max number of characters to copy.
Ted Kremenek0ef473f2011-02-22 04:58:34 +00001100 const Expr *lenExpr = CE->getArg(2);
1101 SVal lenVal = state->getSVal(lenExpr);
1102
Lenny Maiorani508c6272011-04-28 18:59:43 +00001103 // Cast the length to a NonLoc SVal. If it is not a NonLoc then give up.
Ted Kremenek0ef473f2011-02-22 04:58:34 +00001104 NonLoc *strLengthNL = dyn_cast<NonLoc>(&strLength);
Lenny Maiorani508c6272011-04-28 18:59:43 +00001105 if (!strLengthNL)
1106 return;
1107
1108 // Cast the max length to a NonLoc SVal. If it is not a NonLoc then give up.
Ted Kremenek0ef473f2011-02-22 04:58:34 +00001109 NonLoc *lenValNL = dyn_cast<NonLoc>(&lenVal);
Lenny Maiorani508c6272011-04-28 18:59:43 +00001110 if (!lenValNL)
1111 return;
Ted Kremenek0ef473f2011-02-22 04:58:34 +00001112
1113 QualType cmpTy = C.getSValBuilder().getContext().IntTy;
1114 const GRState *stateTrue, *stateFalse;
1115
Lenny Maiorani067bbd02011-04-09 15:12:58 +00001116 // Check if the max number to copy is less than the length of the src.
Ted Kremenek0ef473f2011-02-22 04:58:34 +00001117 llvm::tie(stateTrue, stateFalse) =
1118 state->assume(cast<DefinedOrUnknownSVal>
1119 (C.getSValBuilder().evalBinOpNN(state, BO_GT,
1120 *strLengthNL, *lenValNL,
1121 cmpTy)));
1122
1123 if (stateTrue) {
1124 // Max number to copy is less than the length of the src, so the actual
1125 // strLength copied is the max number arg.
1126 strLength = lenVal;
1127 }
1128 }
1129
Lenny Maiorani067bbd02011-04-09 15:12:58 +00001130 // If this is an appending function (strcat, strncat...) then set the
1131 // string length to strlen(src) + strlen(dst) since the buffer will
1132 // ultimately contain both.
1133 if (isAppending) {
1134 // Get the string length of the destination, or give up.
1135 SVal dstStrLength = getCStringLength(C, state, Dst, DstVal);
1136 if (dstStrLength.isUndef())
1137 return;
1138
1139 NonLoc *srcStrLengthNL = dyn_cast<NonLoc>(&strLength);
1140 NonLoc *dstStrLengthNL = dyn_cast<NonLoc>(&dstStrLength);
1141
1142 // If src or dst cast to NonLoc is NULL, give up.
1143 if ((!srcStrLengthNL) || (!dstStrLengthNL))
1144 return;
1145
1146 QualType addTy = C.getSValBuilder().getContext().getSizeType();
1147
1148 strLength = C.getSValBuilder().evalBinOpNN(state, BO_Add,
1149 *srcStrLengthNL, *dstStrLengthNL,
1150 addTy);
1151 }
1152
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001153 SVal Result = (returnEnd ? UnknownVal() : DstVal);
Jordy Rosee64f3112010-08-16 07:51:42 +00001154
1155 // If the destination is a MemRegion, try to check for a buffer overflow and
1156 // record the new string length.
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001157 if (loc::MemRegionVal *dstRegVal = dyn_cast<loc::MemRegionVal>(&DstVal)) {
Jordy Rosee64f3112010-08-16 07:51:42 +00001158 // If the length is known, we can check for an overflow.
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001159 if (NonLoc *knownStrLength = dyn_cast<NonLoc>(&strLength)) {
1160 SVal lastElement =
1161 C.getSValBuilder().evalBinOpLN(state, BO_Add, *dstRegVal,
1162 *knownStrLength, Dst->getType());
Jordy Rosee64f3112010-08-16 07:51:42 +00001163
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001164 state = CheckLocation(C, state, Dst, lastElement, /* IsDst = */ true);
Jordy Rosee64f3112010-08-16 07:51:42 +00001165 if (!state)
1166 return;
1167
1168 // If this is a stpcpy-style copy, the last element is the return value.
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001169 if (returnEnd)
1170 Result = lastElement;
Jordy Rosee64f3112010-08-16 07:51:42 +00001171 }
1172
1173 // Invalidate the destination. This must happen before we set the C string
1174 // length because invalidation will clear the length.
1175 // FIXME: Even if we can't perfectly model the copy, we should see if we
1176 // can use LazyCompoundVals to copy the source values into the destination.
1177 // This would probably remove any existing bindings past the end of the
1178 // string, but that's still an improvement over blank invalidation.
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001179 state = InvalidateBuffer(C, state, Dst, *dstRegVal);
Jordy Rosee64f3112010-08-16 07:51:42 +00001180
1181 // Set the C string length of the destination.
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001182 state = setCStringLength(state, dstRegVal->getRegion(), strLength);
Jordy Rosee64f3112010-08-16 07:51:42 +00001183 }
1184
1185 // If this is a stpcpy-style copy, but we were unable to check for a buffer
1186 // overflow, we still need a result. Conjure a return value.
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001187 if (returnEnd && Result.isUnknown()) {
1188 SValBuilder &svalBuilder = C.getSValBuilder();
Jordy Rosee64f3112010-08-16 07:51:42 +00001189 unsigned Count = C.getNodeBuilder().getCurrentBlockCount();
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001190 strLength = svalBuilder.getConjuredSymbolVal(NULL, CE, Count);
Jordy Rosee64f3112010-08-16 07:51:42 +00001191 }
1192
1193 // Set the return value.
1194 state = state->BindExpr(CE, Result);
1195 C.addTransition(state);
1196}
1197
Lenny Maiorani318dd922011-04-12 17:08:43 +00001198void CStringChecker::evalStrcmp(CheckerContext &C, const CallExpr *CE) const {
1199 //int strcmp(const char *restrict s1, const char *restrict s2);
Lenny Maioranibd1d16a2011-04-28 15:09:11 +00001200 evalStrcmpCommon(C, CE, /* isBounded = */ false, /* ignoreCase = */ false);
Lenny Maiorani357f6ee2011-04-25 22:21:00 +00001201}
Lenny Maiorani318dd922011-04-12 17:08:43 +00001202
Lenny Maiorani357f6ee2011-04-25 22:21:00 +00001203void CStringChecker::evalStrncmp(CheckerContext &C, const CallExpr *CE) const {
1204 //int strncmp(const char *restrict s1, const char *restrict s2, size_t n);
Lenny Maioranibd1d16a2011-04-28 15:09:11 +00001205 evalStrcmpCommon(C, CE, /* isBounded = */ true, /* ignoreCase = */ false);
1206}
1207
1208void CStringChecker::evalStrcasecmp(CheckerContext &C,
1209 const CallExpr *CE) const {
1210 //int strcasecmp(const char *restrict s1, const char *restrict s2);
1211 evalStrcmpCommon(C, CE, /* isBounded = */ false, /* ignoreCase = */ true);
Lenny Maiorani357f6ee2011-04-25 22:21:00 +00001212}
1213
Lenny Maiorani454fd2d2011-05-02 19:05:49 +00001214void CStringChecker::evalStrncasecmp(CheckerContext &C,
1215 const CallExpr *CE) const {
1216 //int strncasecmp(const char *restrict s1, const char *restrict s2, size_t n);
1217 evalStrcmpCommon(C, CE, /* isBounded = */ true, /* ignoreCase = */ true);
1218}
1219
Lenny Maiorani357f6ee2011-04-25 22:21:00 +00001220void CStringChecker::evalStrcmpCommon(CheckerContext &C, const CallExpr *CE,
Lenny Maioranibd1d16a2011-04-28 15:09:11 +00001221 bool isBounded, bool ignoreCase) const {
Lenny Maiorani318dd922011-04-12 17:08:43 +00001222 const GRState *state = C.getState();
1223
1224 // Check that the first string is non-null
1225 const Expr *s1 = CE->getArg(0);
1226 SVal s1Val = state->getSVal(s1);
1227 state = checkNonNull(C, state, s1, s1Val);
1228 if (!state)
1229 return;
1230
1231 // Check that the second string is non-null.
1232 const Expr *s2 = CE->getArg(1);
1233 SVal s2Val = state->getSVal(s2);
1234 state = checkNonNull(C, state, s2, s2Val);
1235 if (!state)
1236 return;
1237
1238 // Get the string length of the first string or give up.
1239 SVal s1Length = getCStringLength(C, state, s1, s1Val);
1240 if (s1Length.isUndef())
1241 return;
1242
1243 // Get the string length of the second string or give up.
1244 SVal s2Length = getCStringLength(C, state, s2, s2Val);
1245 if (s2Length.isUndef())
1246 return;
1247
1248 // Get the string literal of the first string.
1249 const StringLiteral *s1StrLiteral = getCStringLiteral(C, state, s1, s1Val);
1250 if (!s1StrLiteral)
1251 return;
1252 llvm::StringRef s1StrRef = s1StrLiteral->getString();
1253
1254 // Get the string literal of the second string.
1255 const StringLiteral *s2StrLiteral = getCStringLiteral(C, state, s2, s2Val);
1256 if (!s2StrLiteral)
1257 return;
1258 llvm::StringRef s2StrRef = s2StrLiteral->getString();
1259
Lenny Maiorani357f6ee2011-04-25 22:21:00 +00001260 int result;
1261 if (isBounded) {
1262 // Get the max number of characters to compare.
1263 const Expr *lenExpr = CE->getArg(2);
1264 SVal lenVal = state->getSVal(lenExpr);
1265
1266 // Dynamically cast the length to a ConcreteInt. If it is not a ConcreteInt
1267 // then give up, otherwise get the value and use it as the bounds.
1268 nonloc::ConcreteInt *CI = dyn_cast<nonloc::ConcreteInt>(&lenVal);
1269 if (!CI)
1270 return;
1271 llvm::APSInt lenInt(CI->getValue());
1272
Lenny Maiorani454fd2d2011-05-02 19:05:49 +00001273 // Create substrings of each to compare the prefix.
1274 s1StrRef = s1StrRef.substr(0, (size_t)lenInt.getLimitedValue());
1275 s2StrRef = s2StrRef.substr(0, (size_t)lenInt.getLimitedValue());
1276 }
Lenny Maioranibd1d16a2011-04-28 15:09:11 +00001277
Lenny Maiorani454fd2d2011-05-02 19:05:49 +00001278 if (ignoreCase) {
1279 // Compare string 1 to string 2 the same way strcasecmp() does.
1280 result = s1StrRef.compare_lower(s2StrRef);
Lenny Maiorani357f6ee2011-04-25 22:21:00 +00001281 } else {
1282 // Compare string 1 to string 2 the same way strcmp() does.
Lenny Maiorani454fd2d2011-05-02 19:05:49 +00001283 result = s1StrRef.compare(s2StrRef);
Lenny Maiorani357f6ee2011-04-25 22:21:00 +00001284 }
Lenny Maiorani318dd922011-04-12 17:08:43 +00001285
1286 // Build the SVal of the comparison to bind the return value.
1287 SValBuilder &svalBuilder = C.getSValBuilder();
1288 QualType intTy = svalBuilder.getContext().IntTy;
1289 SVal resultVal = svalBuilder.makeIntVal(result, intTy);
1290
1291 // Bind the return value of the expression.
1292 // Set the return value.
1293 state = state->BindExpr(CE, resultVal);
1294 C.addTransition(state);
1295}
1296
Jordy Rosed325ffb2010-07-08 23:57:29 +00001297//===----------------------------------------------------------------------===//
Jordy Rosea5261542010-08-14 21:02:52 +00001298// The driver method, and other Checker callbacks.
Jordy Rosed325ffb2010-07-08 23:57:29 +00001299//===----------------------------------------------------------------------===//
Jordy Roseccbf7ee2010-07-06 23:11:01 +00001300
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +00001301bool CStringChecker::evalCall(const CallExpr *CE, CheckerContext &C) const {
Jordy Roseccbf7ee2010-07-06 23:11:01 +00001302 // Get the callee. All the functions we care about are C functions
1303 // with simple identifiers.
1304 const GRState *state = C.getState();
1305 const Expr *Callee = CE->getCallee();
1306 const FunctionDecl *FD = state->getSVal(Callee).getAsFunctionDecl();
1307
1308 if (!FD)
1309 return false;
1310
1311 // Get the name of the callee. If it's a builtin, strip off the prefix.
Douglas Gregor90d26a42010-11-01 23:16:05 +00001312 IdentifierInfo *II = FD->getIdentifier();
1313 if (!II) // if no identifier, not a simple C function
1314 return false;
1315 llvm::StringRef Name = II->getName();
Jordy Roseccbf7ee2010-07-06 23:11:01 +00001316 if (Name.startswith("__builtin_"))
1317 Name = Name.substr(10);
1318
Ted Kremenek9c149532010-12-01 21:57:22 +00001319 FnCheck evalFunction = llvm::StringSwitch<FnCheck>(Name)
1320 .Cases("memcpy", "__memcpy_chk", &CStringChecker::evalMemcpy)
Jordy Rosebe460d82011-06-03 23:42:56 +00001321 .Cases("mempcpy", "__mempcpy_chk", &CStringChecker::evalMempcpy)
Ted Kremenek9c149532010-12-01 21:57:22 +00001322 .Cases("memcmp", "bcmp", &CStringChecker::evalMemcmp)
1323 .Cases("memmove", "__memmove_chk", &CStringChecker::evalMemmove)
1324 .Cases("strcpy", "__strcpy_chk", &CStringChecker::evalStrcpy)
Lenny Maiorani094ea0a2011-05-03 16:34:26 +00001325 //.Cases("strncpy", "__strncpy_chk", &CStringChecker::evalStrncpy)
Ted Kremenek9c149532010-12-01 21:57:22 +00001326 .Cases("stpcpy", "__stpcpy_chk", &CStringChecker::evalStpcpy)
Lenny Maiorani067bbd02011-04-09 15:12:58 +00001327 .Cases("strcat", "__strcat_chk", &CStringChecker::evalStrcat)
1328 .Cases("strncat", "__strncat_chk", &CStringChecker::evalStrncat)
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001329 .Case("strlen", &CStringChecker::evalstrLength)
Ted Kremenekbe4242c2011-02-22 04:55:05 +00001330 .Case("strnlen", &CStringChecker::evalstrnLength)
Lenny Maiorani318dd922011-04-12 17:08:43 +00001331 .Case("strcmp", &CStringChecker::evalStrcmp)
Lenny Maiorani357f6ee2011-04-25 22:21:00 +00001332 .Case("strncmp", &CStringChecker::evalStrncmp)
Lenny Maioranibd1d16a2011-04-28 15:09:11 +00001333 .Case("strcasecmp", &CStringChecker::evalStrcasecmp)
Lenny Maiorani454fd2d2011-05-02 19:05:49 +00001334 .Case("strncasecmp", &CStringChecker::evalStrncasecmp)
Ted Kremenek9c149532010-12-01 21:57:22 +00001335 .Case("bcopy", &CStringChecker::evalBcopy)
Jordy Roseccbf7ee2010-07-06 23:11:01 +00001336 .Default(NULL);
1337
Jordy Rosed325ffb2010-07-08 23:57:29 +00001338 // If the callee isn't a string function, let another checker handle it.
Ted Kremenek9c149532010-12-01 21:57:22 +00001339 if (!evalFunction)
Jordy Roseccbf7ee2010-07-06 23:11:01 +00001340 return false;
1341
Jordy Rosed325ffb2010-07-08 23:57:29 +00001342 // Check and evaluate the call.
Ted Kremenek9c149532010-12-01 21:57:22 +00001343 (this->*evalFunction)(C, CE);
Jordy Roseccbf7ee2010-07-06 23:11:01 +00001344 return true;
1345}
Jordy Rosea5261542010-08-14 21:02:52 +00001346
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +00001347void CStringChecker::checkPreStmt(const DeclStmt *DS, CheckerContext &C) const {
Jordy Rosea5261542010-08-14 21:02:52 +00001348 // Record string length for char a[] = "abc";
1349 const GRState *state = C.getState();
1350
1351 for (DeclStmt::const_decl_iterator I = DS->decl_begin(), E = DS->decl_end();
1352 I != E; ++I) {
1353 const VarDecl *D = dyn_cast<VarDecl>(*I);
1354 if (!D)
1355 continue;
1356
1357 // FIXME: Handle array fields of structs.
1358 if (!D->getType()->isArrayType())
1359 continue;
1360
1361 const Expr *Init = D->getInit();
1362 if (!Init)
1363 continue;
1364 if (!isa<StringLiteral>(Init))
1365 continue;
1366
1367 Loc VarLoc = state->getLValue(D, C.getPredecessor()->getLocationContext());
1368 const MemRegion *MR = VarLoc.getAsRegion();
1369 if (!MR)
1370 continue;
1371
1372 SVal StrVal = state->getSVal(Init);
1373 assert(StrVal.isValid() && "Initializer string is unknown or undefined");
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001374 DefinedOrUnknownSVal strLength
1375 = cast<DefinedOrUnknownSVal>(getCStringLength(C, state, Init, StrVal));
Jordy Rosea5261542010-08-14 21:02:52 +00001376
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001377 state = state->set<CStringLength>(MR, strLength);
Jordy Rosea5261542010-08-14 21:02:52 +00001378 }
1379
1380 C.addTransition(state);
1381}
1382
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +00001383bool CStringChecker::wantsRegionChangeUpdate(const GRState *state) const {
Jordy Rosea5261542010-08-14 21:02:52 +00001384 CStringLength::EntryMap Entries = state->get<CStringLength>();
1385 return !Entries.isEmpty();
1386}
1387
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +00001388const GRState *
1389CStringChecker::checkRegionChanges(const GRState *state,
Ted Kremenek35bdbf42011-05-02 19:42:42 +00001390 const StoreManager::InvalidatedSymbols *,
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +00001391 const MemRegion * const *Begin,
1392 const MemRegion * const *End) const {
Jordy Rosea5261542010-08-14 21:02:52 +00001393 CStringLength::EntryMap Entries = state->get<CStringLength>();
1394 if (Entries.isEmpty())
1395 return state;
1396
1397 llvm::SmallPtrSet<const MemRegion *, 8> Invalidated;
1398 llvm::SmallPtrSet<const MemRegion *, 32> SuperRegions;
1399
1400 // First build sets for the changed regions and their super-regions.
1401 for ( ; Begin != End; ++Begin) {
1402 const MemRegion *MR = *Begin;
1403 Invalidated.insert(MR);
1404
1405 SuperRegions.insert(MR);
1406 while (const SubRegion *SR = dyn_cast<SubRegion>(MR)) {
1407 MR = SR->getSuperRegion();
1408 SuperRegions.insert(MR);
1409 }
1410 }
1411
1412 CStringLength::EntryMap::Factory &F = state->get_context<CStringLength>();
1413
1414 // Then loop over the entries in the current state.
1415 for (CStringLength::EntryMap::iterator I = Entries.begin(),
1416 E = Entries.end(); I != E; ++I) {
1417 const MemRegion *MR = I.getKey();
1418
1419 // Is this entry for a super-region of a changed region?
1420 if (SuperRegions.count(MR)) {
Ted Kremenek3baf6722010-11-24 00:54:37 +00001421 Entries = F.remove(Entries, MR);
Jordy Rosea5261542010-08-14 21:02:52 +00001422 continue;
1423 }
1424
1425 // Is this entry for a sub-region of a changed region?
1426 const MemRegion *Super = MR;
1427 while (const SubRegion *SR = dyn_cast<SubRegion>(Super)) {
1428 Super = SR->getSuperRegion();
1429 if (Invalidated.count(Super)) {
Ted Kremenek3baf6722010-11-24 00:54:37 +00001430 Entries = F.remove(Entries, MR);
Jordy Rosea5261542010-08-14 21:02:52 +00001431 break;
1432 }
1433 }
1434 }
1435
1436 return state->set<CStringLength>(Entries);
1437}
1438
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +00001439void CStringChecker::checkLiveSymbols(const GRState *state,
1440 SymbolReaper &SR) const {
Jordy Rosea5261542010-08-14 21:02:52 +00001441 // Mark all symbols in our string length map as valid.
1442 CStringLength::EntryMap Entries = state->get<CStringLength>();
1443
1444 for (CStringLength::EntryMap::iterator I = Entries.begin(), E = Entries.end();
1445 I != E; ++I) {
1446 SVal Len = I.getData();
1447 if (SymbolRef Sym = Len.getAsSymbol())
1448 SR.markInUse(Sym);
1449 }
1450}
1451
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +00001452void CStringChecker::checkDeadSymbols(SymbolReaper &SR,
1453 CheckerContext &C) const {
Jordy Rosea5261542010-08-14 21:02:52 +00001454 if (!SR.hasDeadSymbols())
1455 return;
1456
1457 const GRState *state = C.getState();
1458 CStringLength::EntryMap Entries = state->get<CStringLength>();
1459 if (Entries.isEmpty())
1460 return;
1461
1462 CStringLength::EntryMap::Factory &F = state->get_context<CStringLength>();
1463 for (CStringLength::EntryMap::iterator I = Entries.begin(), E = Entries.end();
1464 I != E; ++I) {
1465 SVal Len = I.getData();
1466 if (SymbolRef Sym = Len.getAsSymbol()) {
1467 if (SR.isDead(Sym))
Ted Kremenek3baf6722010-11-24 00:54:37 +00001468 Entries = F.remove(Entries, I.getKey());
Jordy Rosea5261542010-08-14 21:02:52 +00001469 }
1470 }
1471
1472 state = state->set<CStringLength>(Entries);
Ted Kremenekd048c6e2010-12-20 21:19:09 +00001473 C.generateNode(state);
Jordy Rosea5261542010-08-14 21:02:52 +00001474}
Argyrios Kyrtzidis183ff982011-02-24 01:05:30 +00001475
1476void ento::registerCStringChecker(CheckerManager &mgr) {
1477 mgr.registerChecker<CStringChecker>();
1478}