Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 1 | //=- NSErrorChecker.cpp - Coding conventions for uses of NSError -*- C++ -*-==// |
Ted Kremenek | f45d18c | 2008-09-18 06:33:41 +0000 | [diff] [blame] | 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
| 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
| 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This file defines a CheckNSError, a flow-insenstive check |
| 11 | // that determines if an Objective-C class interface correctly returns |
| 12 | // a non-void return type. |
| 13 | // |
| 14 | // File under feature request PR 2600. |
| 15 | // |
| 16 | //===----------------------------------------------------------------------===// |
| 17 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 18 | #include "ClangSACheckers.h" |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 19 | #include "clang/StaticAnalyzer/Core/Checker.h" |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 20 | #include "clang/StaticAnalyzer/Core/CheckerManager.h" |
| 21 | #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 22 | #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" |
Ted Kremenek | 9b66371 | 2011-02-10 01:03:03 +0000 | [diff] [blame] | 23 | #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" |
Ted Kremenek | f45d18c | 2008-09-18 06:33:41 +0000 | [diff] [blame] | 24 | #include "clang/AST/DeclObjC.h" |
Ted Kremenek | cfdf9b4 | 2008-09-18 21:25:13 +0000 | [diff] [blame] | 25 | #include "clang/AST/Decl.h" |
| 26 | #include "llvm/ADT/SmallVector.h" |
Ted Kremenek | f45d18c | 2008-09-18 06:33:41 +0000 | [diff] [blame] | 27 | |
| 28 | using namespace clang; |
Ted Kremenek | 9ef6537 | 2010-12-23 07:20:52 +0000 | [diff] [blame] | 29 | using namespace ento; |
Ted Kremenek | f45d18c | 2008-09-18 06:33:41 +0000 | [diff] [blame] | 30 | |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 31 | static bool IsNSError(QualType T, IdentifierInfo *II); |
| 32 | static bool IsCFError(QualType T, IdentifierInfo *II); |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 33 | |
| 34 | //===----------------------------------------------------------------------===// |
| 35 | // NSErrorMethodChecker |
| 36 | //===----------------------------------------------------------------------===// |
| 37 | |
Ted Kremenek | cfdf9b4 | 2008-09-18 21:25:13 +0000 | [diff] [blame] | 38 | namespace { |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 39 | class NSErrorMethodChecker |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 40 | : public Checker< check::ASTDecl<ObjCMethodDecl> > { |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 41 | mutable IdentifierInfo *II; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 42 | |
Ted Kremenek | cfdf9b4 | 2008-09-18 21:25:13 +0000 | [diff] [blame] | 43 | public: |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 44 | NSErrorMethodChecker() : II(0) { } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 45 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 46 | void checkASTDecl(const ObjCMethodDecl *D, |
| 47 | AnalysisManager &mgr, BugReporter &BR) const; |
| 48 | }; |
| 49 | } |
| 50 | |
| 51 | void NSErrorMethodChecker::checkASTDecl(const ObjCMethodDecl *D, |
| 52 | AnalysisManager &mgr, |
| 53 | BugReporter &BR) const { |
| 54 | if (!D->isThisDeclarationADefinition()) |
| 55 | return; |
| 56 | if (!D->getResultType()->isVoidType()) |
| 57 | return; |
| 58 | |
| 59 | if (!II) |
| 60 | II = &D->getASTContext().Idents.get("NSError"); |
| 61 | |
| 62 | bool hasNSError = false; |
Argyrios Kyrtzidis | 491306a | 2011-10-03 06:37:04 +0000 | [diff] [blame] | 63 | for (ObjCMethodDecl::param_const_iterator |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 64 | I = D->param_begin(), E = D->param_end(); I != E; ++I) { |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 65 | if (IsNSError((*I)->getType(), II)) { |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 66 | hasNSError = true; |
| 67 | break; |
| 68 | } |
| 69 | } |
| 70 | |
| 71 | if (hasNSError) { |
| 72 | const char *err = "Method accepting NSError** " |
| 73 | "should have a non-void return value to indicate whether or not an " |
| 74 | "error occurred"; |
Anna Zaks | 590dd8e | 2011-09-20 21:38:35 +0000 | [diff] [blame] | 75 | PathDiagnosticLocation L = |
| 76 | PathDiagnosticLocation::create(D, BR.getSourceManager()); |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 77 | BR.EmitBasicReport("Bad return type when passing NSError**", |
Anna Zaks | 590dd8e | 2011-09-20 21:38:35 +0000 | [diff] [blame] | 78 | "Coding conventions (Apple)", err, L); |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 79 | } |
| 80 | } |
| 81 | |
| 82 | //===----------------------------------------------------------------------===// |
| 83 | // CFErrorFunctionChecker |
| 84 | //===----------------------------------------------------------------------===// |
| 85 | |
| 86 | namespace { |
| 87 | class CFErrorFunctionChecker |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 88 | : public Checker< check::ASTDecl<FunctionDecl> > { |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 89 | mutable IdentifierInfo *II; |
| 90 | |
| 91 | public: |
| 92 | CFErrorFunctionChecker() : II(0) { } |
| 93 | |
| 94 | void checkASTDecl(const FunctionDecl *D, |
| 95 | AnalysisManager &mgr, BugReporter &BR) const; |
| 96 | }; |
| 97 | } |
| 98 | |
| 99 | void CFErrorFunctionChecker::checkASTDecl(const FunctionDecl *D, |
| 100 | AnalysisManager &mgr, |
| 101 | BugReporter &BR) const { |
Sean Hunt | 10620eb | 2011-05-06 20:44:56 +0000 | [diff] [blame] | 102 | if (!D->doesThisDeclarationHaveABody()) |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 103 | return; |
| 104 | if (!D->getResultType()->isVoidType()) |
| 105 | return; |
| 106 | |
| 107 | if (!II) |
| 108 | II = &D->getASTContext().Idents.get("CFErrorRef"); |
| 109 | |
| 110 | bool hasCFError = false; |
| 111 | for (FunctionDecl::param_const_iterator |
| 112 | I = D->param_begin(), E = D->param_end(); I != E; ++I) { |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 113 | if (IsCFError((*I)->getType(), II)) { |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 114 | hasCFError = true; |
| 115 | break; |
| 116 | } |
| 117 | } |
| 118 | |
| 119 | if (hasCFError) { |
| 120 | const char *err = "Function accepting CFErrorRef* " |
| 121 | "should have a non-void return value to indicate whether or not an " |
| 122 | "error occurred"; |
Anna Zaks | 590dd8e | 2011-09-20 21:38:35 +0000 | [diff] [blame] | 123 | PathDiagnosticLocation L = |
| 124 | PathDiagnosticLocation::create(D, BR.getSourceManager()); |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 125 | BR.EmitBasicReport("Bad return type when passing CFErrorRef*", |
Anna Zaks | 590dd8e | 2011-09-20 21:38:35 +0000 | [diff] [blame] | 126 | "Coding conventions (Apple)", err, L); |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 127 | } |
| 128 | } |
| 129 | |
| 130 | //===----------------------------------------------------------------------===// |
| 131 | // NSOrCFErrorDerefChecker |
| 132 | //===----------------------------------------------------------------------===// |
| 133 | |
| 134 | namespace { |
| 135 | |
| 136 | class NSErrorDerefBug : public BugType { |
| 137 | public: |
| 138 | NSErrorDerefBug() : BugType("NSError** null dereference", |
| 139 | "Coding conventions (Apple)") {} |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 140 | }; |
| 141 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 142 | class CFErrorDerefBug : public BugType { |
| 143 | public: |
| 144 | CFErrorDerefBug() : BugType("CFErrorRef* null dereference", |
| 145 | "Coding conventions (Apple)") {} |
| 146 | }; |
Ted Kremenek | cfdf9b4 | 2008-09-18 21:25:13 +0000 | [diff] [blame] | 147 | |
Ted Kremenek | cfdf9b4 | 2008-09-18 21:25:13 +0000 | [diff] [blame] | 148 | } |
| 149 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 150 | namespace { |
| 151 | class NSOrCFErrorDerefChecker |
Argyrios Kyrtzidis | ec8605f | 2011-03-01 01:16:21 +0000 | [diff] [blame] | 152 | : public Checker< check::Location, |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 153 | check::Event<ImplicitNullDerefEvent> > { |
| 154 | mutable IdentifierInfo *NSErrorII, *CFErrorII; |
| 155 | public: |
| 156 | bool ShouldCheckNSError, ShouldCheckCFError; |
| 157 | NSOrCFErrorDerefChecker() : NSErrorII(0), CFErrorII(0), |
| 158 | ShouldCheckNSError(0), ShouldCheckCFError(0) { } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 159 | |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 160 | void checkLocation(SVal loc, bool isLoad, const Stmt *S, |
| 161 | CheckerContext &C) const; |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 162 | void checkEvent(ImplicitNullDerefEvent event) const; |
| 163 | }; |
| 164 | } |
Ted Kremenek | cfdf9b4 | 2008-09-18 21:25:13 +0000 | [diff] [blame] | 165 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 166 | namespace { struct NSErrorOut {}; } |
| 167 | namespace { struct CFErrorOut {}; } |
Ted Kremenek | cc9ac41 | 2008-10-01 23:24:09 +0000 | [diff] [blame] | 168 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 169 | typedef llvm::ImmutableMap<SymbolRef, unsigned> ErrorOutFlag; |
| 170 | |
| 171 | namespace clang { |
| 172 | namespace ento { |
| 173 | template <> |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 174 | struct ProgramStateTrait<NSErrorOut> : public ProgramStatePartialTrait<ErrorOutFlag> { |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 175 | static void *GDMIndex() { static int index = 0; return &index; } |
| 176 | }; |
| 177 | template <> |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 178 | struct ProgramStateTrait<CFErrorOut> : public ProgramStatePartialTrait<ErrorOutFlag> { |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 179 | static void *GDMIndex() { static int index = 0; return &index; } |
| 180 | }; |
| 181 | } |
| 182 | } |
| 183 | |
| 184 | template <typename T> |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 185 | static bool hasFlag(SVal val, const ProgramState *state) { |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 186 | if (SymbolRef sym = val.getAsSymbol()) |
| 187 | if (const unsigned *attachedFlags = state->get<T>(sym)) |
| 188 | return *attachedFlags; |
| 189 | return false; |
| 190 | } |
| 191 | |
| 192 | template <typename T> |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 193 | static void setFlag(const ProgramState *state, SVal val, CheckerContext &C) { |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 194 | // We tag the symbol that the SVal wraps. |
| 195 | if (SymbolRef sym = val.getAsSymbol()) |
Anna Zaks | 0bd6b11 | 2011-10-26 21:06:34 +0000 | [diff] [blame] | 196 | C.addTransition(state->set<T>(sym, true)); |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 197 | } |
| 198 | |
Argyrios Kyrtzidis | 4ba48c4 | 2011-03-01 01:59:41 +0000 | [diff] [blame] | 199 | static QualType parameterTypeFromSVal(SVal val, CheckerContext &C) { |
| 200 | const StackFrameContext * |
Anna Zaks | 39ac187 | 2011-10-26 21:06:44 +0000 | [diff] [blame^] | 201 | SFC = C.getLocationContext()->getCurrentStackFrame(); |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 202 | if (const loc::MemRegionVal* X = dyn_cast<loc::MemRegionVal>(&val)) { |
| 203 | const MemRegion* R = X->getRegion(); |
| 204 | if (const VarRegion *VR = R->getAs<VarRegion>()) |
Argyrios Kyrtzidis | 4ba48c4 | 2011-03-01 01:59:41 +0000 | [diff] [blame] | 205 | if (const StackArgumentsSpaceRegion * |
| 206 | stackReg = dyn_cast<StackArgumentsSpaceRegion>(VR->getMemorySpace())) |
| 207 | if (stackReg->getStackFrame() == SFC) |
| 208 | return VR->getValueType(); |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 209 | } |
| 210 | |
| 211 | return QualType(); |
| 212 | } |
| 213 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 214 | void NSOrCFErrorDerefChecker::checkLocation(SVal loc, bool isLoad, |
Anna Zaks | 390909c | 2011-10-06 00:43:15 +0000 | [diff] [blame] | 215 | const Stmt *S, |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 216 | CheckerContext &C) const { |
| 217 | if (!isLoad) |
| 218 | return; |
| 219 | if (loc.isUndef() || !isa<Loc>(loc)) |
Ted Kremenek | cfdf9b4 | 2008-09-18 21:25:13 +0000 | [diff] [blame] | 220 | return; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 221 | |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 222 | ASTContext &Ctx = C.getASTContext(); |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 223 | const ProgramState *state = C.getState(); |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 224 | |
| 225 | // If we are loading from NSError**/CFErrorRef* parameter, mark the resulting |
| 226 | // SVal so that we can later check it when handling the |
| 227 | // ImplicitNullDerefEvent event. |
| 228 | // FIXME: Cumbersome! Maybe add hook at construction of SVals at start of |
| 229 | // function ? |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 230 | |
Argyrios Kyrtzidis | 4ba48c4 | 2011-03-01 01:59:41 +0000 | [diff] [blame] | 231 | QualType parmT = parameterTypeFromSVal(loc, C); |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 232 | if (parmT.isNull()) |
| 233 | return; |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 234 | |
| 235 | if (!NSErrorII) |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 236 | NSErrorII = &Ctx.Idents.get("NSError"); |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 237 | if (!CFErrorII) |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 238 | CFErrorII = &Ctx.Idents.get("CFErrorRef"); |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 239 | |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 240 | if (ShouldCheckNSError && IsNSError(parmT, NSErrorII)) { |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 241 | setFlag<NSErrorOut>(state, state->getSVal(cast<Loc>(loc)), C); |
| 242 | return; |
| 243 | } |
| 244 | |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 245 | if (ShouldCheckCFError && IsCFError(parmT, CFErrorII)) { |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 246 | setFlag<CFErrorOut>(state, state->getSVal(cast<Loc>(loc)), C); |
| 247 | return; |
| 248 | } |
| 249 | } |
| 250 | |
| 251 | void NSOrCFErrorDerefChecker::checkEvent(ImplicitNullDerefEvent event) const { |
| 252 | if (event.IsLoad) |
Ted Kremenek | cc9ac41 | 2008-10-01 23:24:09 +0000 | [diff] [blame] | 253 | return; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 254 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 255 | SVal loc = event.Location; |
Ted Kremenek | 18c66fd | 2011-08-15 22:09:50 +0000 | [diff] [blame] | 256 | const ProgramState *state = event.SinkNode->getState(); |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 257 | BugReporter &BR = *event.BR; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 258 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 259 | bool isNSError = hasFlag<NSErrorOut>(loc, state); |
| 260 | bool isCFError = false; |
| 261 | if (!isNSError) |
| 262 | isCFError = hasFlag<CFErrorOut>(loc, state); |
Ted Kremenek | cfdf9b4 | 2008-09-18 21:25:13 +0000 | [diff] [blame] | 263 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 264 | if (!(isNSError || isCFError)) |
| 265 | return; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 266 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 267 | // Storing to possible null NSError/CFErrorRef out parameter. |
| 268 | |
| 269 | // Emit an error. |
| 270 | std::string err; |
| 271 | llvm::raw_string_ostream os(err); |
| 272 | os << "Potential null dereference. According to coding standards "; |
| 273 | |
| 274 | if (isNSError) |
| 275 | os << "in 'Creating and Returning NSError Objects' the parameter '"; |
Ted Kremenek | cc9ac41 | 2008-10-01 23:24:09 +0000 | [diff] [blame] | 276 | else |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 277 | os << "documented in CoreFoundation/CFError.h the parameter '"; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 278 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 279 | os << "' may be null."; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 280 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 281 | BugType *bug = 0; |
| 282 | if (isNSError) |
| 283 | bug = new NSErrorDerefBug(); |
| 284 | else |
| 285 | bug = new CFErrorDerefBug(); |
Anna Zaks | e172e8b | 2011-08-17 23:00:25 +0000 | [diff] [blame] | 286 | BugReport *report = new BugReport(*bug, os.str(), |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 287 | event.SinkNode); |
| 288 | BR.EmitReport(report); |
Ted Kremenek | cc9ac41 | 2008-10-01 23:24:09 +0000 | [diff] [blame] | 289 | } |
| 290 | |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 291 | static bool IsNSError(QualType T, IdentifierInfo *II) { |
Ted Kremenek | cfdf9b4 | 2008-09-18 21:25:13 +0000 | [diff] [blame] | 292 | |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 293 | const PointerType* PPT = T->getAs<PointerType>(); |
Steve Naroff | 14108da | 2009-07-10 23:34:53 +0000 | [diff] [blame] | 294 | if (!PPT) |
| 295 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 296 | |
Steve Naroff | 14108da | 2009-07-10 23:34:53 +0000 | [diff] [blame] | 297 | const ObjCObjectPointerType* PT = |
John McCall | 183700f | 2009-09-21 23:43:11 +0000 | [diff] [blame] | 298 | PPT->getPointeeType()->getAs<ObjCObjectPointerType>(); |
Steve Naroff | 14108da | 2009-07-10 23:34:53 +0000 | [diff] [blame] | 299 | |
| 300 | if (!PT) |
| 301 | return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 302 | |
Steve Naroff | 14108da | 2009-07-10 23:34:53 +0000 | [diff] [blame] | 303 | const ObjCInterfaceDecl *ID = PT->getInterfaceDecl(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 304 | |
Steve Naroff | 14108da | 2009-07-10 23:34:53 +0000 | [diff] [blame] | 305 | // FIXME: Can ID ever be NULL? |
| 306 | if (ID) |
| 307 | return II == ID->getIdentifier(); |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 308 | |
Steve Naroff | 14108da | 2009-07-10 23:34:53 +0000 | [diff] [blame] | 309 | return false; |
Ted Kremenek | cfdf9b4 | 2008-09-18 21:25:13 +0000 | [diff] [blame] | 310 | } |
Ted Kremenek | 7360fda | 2008-09-18 23:09:54 +0000 | [diff] [blame] | 311 | |
Argyrios Kyrtzidis | 25a792b | 2011-03-01 01:47:48 +0000 | [diff] [blame] | 312 | static bool IsCFError(QualType T, IdentifierInfo *II) { |
| 313 | const PointerType* PPT = T->getAs<PointerType>(); |
Ted Kremenek | cc9ac41 | 2008-10-01 23:24:09 +0000 | [diff] [blame] | 314 | if (!PPT) return false; |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 315 | |
John McCall | 183700f | 2009-09-21 23:43:11 +0000 | [diff] [blame] | 316 | const TypedefType* TT = PPT->getPointeeType()->getAs<TypedefType>(); |
Ted Kremenek | cc9ac41 | 2008-10-01 23:24:09 +0000 | [diff] [blame] | 317 | if (!TT) return false; |
| 318 | |
Ted Kremenek | cf118d4 | 2009-02-04 23:49:09 +0000 | [diff] [blame] | 319 | return TT->getDecl()->getIdentifier() == II; |
Ted Kremenek | cc9ac41 | 2008-10-01 23:24:09 +0000 | [diff] [blame] | 320 | } |
| 321 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 322 | void ento::registerNSErrorChecker(CheckerManager &mgr) { |
| 323 | mgr.registerChecker<NSErrorMethodChecker>(); |
| 324 | NSOrCFErrorDerefChecker * |
| 325 | checker = mgr.registerChecker<NSOrCFErrorDerefChecker>(); |
| 326 | checker->ShouldCheckNSError = true; |
| 327 | } |
Mike Stump | 1eb4433 | 2009-09-09 15:08:12 +0000 | [diff] [blame] | 328 | |
Argyrios Kyrtzidis | b3d74da | 2011-02-28 17:36:18 +0000 | [diff] [blame] | 329 | void ento::registerCFErrorChecker(CheckerManager &mgr) { |
| 330 | mgr.registerChecker<CFErrorFunctionChecker>(); |
| 331 | NSOrCFErrorDerefChecker * |
| 332 | checker = mgr.registerChecker<NSOrCFErrorDerefChecker>(); |
| 333 | checker->ShouldCheckCFError = true; |
Ted Kremenek | 7360fda | 2008-09-18 23:09:54 +0000 | [diff] [blame] | 334 | } |