blob: 0d3059e01a77fb8a00f57d33be275ecc7c6e9d38 [file] [log] [blame]
Ted Kremenekf5d2ef42011-02-25 22:00:43 +00001//=== StackAddrEscapeChecker.cpp ----------------------------------*- C++ -*--//
Zhongxing Xu1622a542010-06-08 10:00:00 +00002//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines stack address leak checker, which checks if an invalid
11// stack address is stored into a global or heap location. See CERT DCL30-C.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis027a6ab2011-02-15 07:42:33 +000015#include "ClangSACheckers.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000016#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis695fb502011-02-17 21:39:17 +000017#include "clang/StaticAnalyzer/Core/CheckerManager.h"
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000018#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000019#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000020#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
Zhongxing Xu9b146832010-06-09 06:08:24 +000021#include "clang/Basic/SourceManager.h"
22#include "llvm/ADT/SmallString.h"
Zhongxing Xu1622a542010-06-08 10:00:00 +000023using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000024using namespace ento;
Zhongxing Xu1622a542010-06-08 10:00:00 +000025
26namespace {
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000027class StackAddrEscapeChecker : public Checker< check::PreStmt<ReturnStmt>,
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000028 check::EndPath > {
29 mutable llvm::OwningPtr<BuiltinBug> BT_stackleak;
30 mutable llvm::OwningPtr<BuiltinBug> BT_returnstack;
Zhongxing Xu1622a542010-06-08 10:00:00 +000031
32public:
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000033 void checkPreStmt(const ReturnStmt *RS, CheckerContext &C) const;
Anna Zaksaf498a22011-10-25 19:56:48 +000034 void checkEndPath(CheckerContext &Ctx) const;
Zhongxing Xu9b146832010-06-09 06:08:24 +000035private:
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000036 void EmitStackError(CheckerContext &C, const MemRegion *R,
37 const Expr *RetE) const;
Chris Lattner5f9e2722011-07-23 10:55:15 +000038 static SourceRange GenName(raw_ostream &os, const MemRegion *R,
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000039 SourceManager &SM);
Zhongxing Xu1622a542010-06-08 10:00:00 +000040};
41}
42
Chris Lattner5f9e2722011-07-23 10:55:15 +000043SourceRange StackAddrEscapeChecker::GenName(raw_ostream &os,
Ted Kremeneka8166152010-06-17 04:21:37 +000044 const MemRegion *R,
45 SourceManager &SM) {
46 // Get the base region, stripping away fields and elements.
47 R = R->getBaseRegion();
48 SourceRange range;
49 os << "Address of ";
50
51 // Check if the region is a compound literal.
52 if (const CompoundLiteralRegion* CR = dyn_cast<CompoundLiteralRegion>(R)) {
Ted Kremenek9c378f72011-08-12 23:37:29 +000053 const CompoundLiteralExpr *CL = CR->getLiteralExpr();
Ted Kremeneka8166152010-06-17 04:21:37 +000054 os << "stack memory associated with a compound literal "
55 "declared on line "
Chandler Carruth64211622011-07-25 21:09:52 +000056 << SM.getExpansionLineNumber(CL->getLocStart())
Ted Kremeneka8166152010-06-17 04:21:37 +000057 << " returned to caller";
58 range = CL->getSourceRange();
59 }
60 else if (const AllocaRegion* AR = dyn_cast<AllocaRegion>(R)) {
Ted Kremenek9c378f72011-08-12 23:37:29 +000061 const Expr *ARE = AR->getExpr();
Ted Kremeneka8166152010-06-17 04:21:37 +000062 SourceLocation L = ARE->getLocStart();
63 range = ARE->getSourceRange();
64 os << "stack memory allocated by call to alloca() on line "
Chandler Carruth64211622011-07-25 21:09:52 +000065 << SM.getExpansionLineNumber(L);
Ted Kremeneka8166152010-06-17 04:21:37 +000066 }
67 else if (const BlockDataRegion *BR = dyn_cast<BlockDataRegion>(R)) {
68 const BlockDecl *BD = BR->getCodeRegion()->getDecl();
69 SourceLocation L = BD->getLocStart();
70 range = BD->getSourceRange();
71 os << "stack-allocated block declared on line "
Chandler Carruth64211622011-07-25 21:09:52 +000072 << SM.getExpansionLineNumber(L);
Ted Kremeneka8166152010-06-17 04:21:37 +000073 }
74 else if (const VarRegion *VR = dyn_cast<VarRegion>(R)) {
75 os << "stack memory associated with local variable '"
76 << VR->getString() << '\'';
77 range = VR->getDecl()->getSourceRange();
78 }
Jeffrey Yasskin782f63e2011-08-26 00:41:31 +000079 else if (const CXXTempObjectRegion *TOR = dyn_cast<CXXTempObjectRegion>(R)) {
80 os << "stack memory associated with temporary object of type '"
81 << TOR->getValueType().getAsString() << '\'';
82 range = TOR->getExpr()->getSourceRange();
83 }
Ted Kremeneka8166152010-06-17 04:21:37 +000084 else {
David Blaikieb219cfc2011-09-23 05:06:16 +000085 llvm_unreachable("Invalid region in ReturnStackAddressChecker.");
Ted Kremeneka8166152010-06-17 04:21:37 +000086 }
87
88 return range;
89}
90
Ted Kremenekf5d2ef42011-02-25 22:00:43 +000091void StackAddrEscapeChecker::EmitStackError(CheckerContext &C, const MemRegion *R,
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000092 const Expr *RetE) const {
Ted Kremenekd048c6e2010-12-20 21:19:09 +000093 ExplodedNode *N = C.generateSink();
Zhongxing Xu9b146832010-06-09 06:08:24 +000094
95 if (!N)
96 return;
97
98 if (!BT_returnstack)
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +000099 BT_returnstack.reset(
100 new BuiltinBug("Return of address to stack-allocated memory"));
Zhongxing Xu9b146832010-06-09 06:08:24 +0000101
102 // Generate a report for this bug.
103 llvm::SmallString<512> buf;
104 llvm::raw_svector_ostream os(buf);
Ted Kremeneka8166152010-06-17 04:21:37 +0000105 SourceRange range = GenName(os, R, C.getSourceManager());
106 os << " returned to caller";
Anna Zakse172e8b2011-08-17 23:00:25 +0000107 BugReport *report = new BugReport(*BT_returnstack, os.str(), N);
Zhongxing Xu9b146832010-06-09 06:08:24 +0000108 report->addRange(RetE->getSourceRange());
109 if (range.isValid())
110 report->addRange(range);
111
112 C.EmitReport(report);
Eli Friedmana7e68452010-08-22 01:00:03 +0000113}
Zhongxing Xu9b146832010-06-09 06:08:24 +0000114
Ted Kremenekf5d2ef42011-02-25 22:00:43 +0000115void StackAddrEscapeChecker::checkPreStmt(const ReturnStmt *RS,
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000116 CheckerContext &C) const {
Zhongxing Xu9b146832010-06-09 06:08:24 +0000117
118 const Expr *RetE = RS->getRetValue();
119 if (!RetE)
120 return;
121
122 SVal V = C.getState()->getSVal(RetE);
123 const MemRegion *R = V.getAsRegion();
124
125 if (!R || !R->hasStackStorage())
126 return;
127
128 if (R->hasStackStorage()) {
John McCallf85e1932011-06-15 23:02:42 +0000129 // Automatic reference counting automatically copies blocks.
130 if (C.getASTContext().getLangOptions().ObjCAutoRefCount &&
131 isa<BlockDataRegion>(R))
132 return;
133
Zhongxing Xu9b146832010-06-09 06:08:24 +0000134 EmitStackError(C, R, RetE);
135 return;
136 }
137}
Zhongxing Xu1622a542010-06-08 10:00:00 +0000138
Anna Zaksaf498a22011-10-25 19:56:48 +0000139void StackAddrEscapeChecker::checkEndPath(CheckerContext &Ctx) const {
140 const ProgramState *state = Ctx.getState();
Zhongxing Xu1622a542010-06-08 10:00:00 +0000141
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000142 // Iterate over all bindings to global variables and see if it contains
143 // a memory region in the stack space.
144 class CallBack : public StoreManager::BindingsHandler {
145 private:
Anna Zaksaf498a22011-10-25 19:56:48 +0000146 CheckerContext &Ctx;
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000147 const StackFrameContext *CurSFC;
148 public:
Chris Lattner5f9e2722011-07-23 10:55:15 +0000149 SmallVector<std::pair<const MemRegion*, const MemRegion*>, 10> V;
Zhongxing Xu1622a542010-06-08 10:00:00 +0000150
Anna Zaksaf498a22011-10-25 19:56:48 +0000151 CallBack(CheckerContext &CC) :
152 Ctx(CC),
Anna Zaks39ac1872011-10-26 21:06:44 +0000153 CurSFC(CC.getLocationContext()->getCurrentStackFrame())
Anna Zaksaf498a22011-10-25 19:56:48 +0000154 {}
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000155
156 bool HandleBinding(StoreManager &SMgr, Store store,
157 const MemRegion *region, SVal val) {
158
159 if (!isa<GlobalsSpaceRegion>(region->getMemorySpace()))
160 return true;
161
162 const MemRegion *vR = val.getAsRegion();
163 if (!vR)
164 return true;
John McCallf85e1932011-06-15 23:02:42 +0000165
166 // Under automated retain release, it is okay to assign a block
167 // directly to a global variable.
Anna Zaksaf498a22011-10-25 19:56:48 +0000168 if (Ctx.getASTContext().getLangOptions().ObjCAutoRefCount &&
John McCallf85e1932011-06-15 23:02:42 +0000169 isa<BlockDataRegion>(vR))
170 return true;
171
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000172 if (const StackSpaceRegion *SSR =
173 dyn_cast<StackSpaceRegion>(vR->getMemorySpace())) {
174 // If the global variable holds a location in the current stack frame,
175 // record the binding to emit a warning.
Ted Kremeneka8166152010-06-17 04:21:37 +0000176 if (SSR->getStackFrame() == CurSFC)
177 V.push_back(std::make_pair(region, vR));
Zhongxing Xu1622a542010-06-08 10:00:00 +0000178 }
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000179
180 return true;
Zhongxing Xu1622a542010-06-08 10:00:00 +0000181 }
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000182 };
183
Anna Zaksaf498a22011-10-25 19:56:48 +0000184 CallBack cb(Ctx);
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000185 state->getStateManager().getStoreManager().iterBindings(state->getStore(),cb);
Ted Kremeneka8166152010-06-17 04:21:37 +0000186
187 if (cb.V.empty())
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000188 return;
189
190 // Generate an error node.
Anna Zaks0bd6b112011-10-26 21:06:34 +0000191 ExplodedNode *N = Ctx.addTransition(state);
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000192 if (!N)
193 return;
Ted Kremenek551bd1f2010-06-17 00:24:44 +0000194
Ted Kremeneka8166152010-06-17 04:21:37 +0000195 if (!BT_stackleak)
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000196 BT_stackleak.reset(
Ted Kremeneka8166152010-06-17 04:21:37 +0000197 new BuiltinBug("Stack address stored into global variable",
198 "Stack address was saved into a global variable. "
199 "This is dangerous because the address will become "
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000200 "invalid after returning from the function"));
Ted Kremeneka8166152010-06-17 04:21:37 +0000201
202 for (unsigned i = 0, e = cb.V.size(); i != e; ++i) {
203 // Generate a report for this bug.
204 llvm::SmallString<512> buf;
205 llvm::raw_svector_ostream os(buf);
206 SourceRange range = GenName(os, cb.V[i].second,
Anna Zaksaf498a22011-10-25 19:56:48 +0000207 Ctx.getSourceManager());
Ted Kremeneka8166152010-06-17 04:21:37 +0000208 os << " is still referred to by the global variable '";
209 const VarRegion *VR = cast<VarRegion>(cb.V[i].first->getBaseRegion());
Benjamin Kramerb8989f22011-10-14 18:45:37 +0000210 os << *VR->getDecl()
Ted Kremeneka8166152010-06-17 04:21:37 +0000211 << "' upon returning to the caller. This will be a dangling reference";
Anna Zakse172e8b2011-08-17 23:00:25 +0000212 BugReport *report = new BugReport(*BT_stackleak, os.str(), N);
Ted Kremeneka8166152010-06-17 04:21:37 +0000213 if (range.isValid())
214 report->addRange(range);
215
Anna Zaksaf498a22011-10-25 19:56:48 +0000216 Ctx.EmitReport(report);
Ted Kremeneka8166152010-06-17 04:21:37 +0000217 }
Zhongxing Xu1622a542010-06-08 10:00:00 +0000218}
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000219
Ted Kremenekf5d2ef42011-02-25 22:00:43 +0000220void ento::registerStackAddrEscapeChecker(CheckerManager &mgr) {
221 mgr.registerChecker<StackAddrEscapeChecker>();
Argyrios Kyrtzidisaf5800a2011-02-23 21:04:54 +0000222}