blob: ac18b5d6e739775efadb1cbb16311658c2257ae9 [file] [log] [blame]
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +00001//===--- TransUnbridgedCasts.cpp - Tranformations to ARC mode -------------===//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// rewriteUnbridgedCasts:
11//
12// A cast of non-objc pointer to an objc one is checked. If the non-objc pointer
13// is from a file-level variable, __bridge cast is used to convert it.
14// For the result of a function call that we know is +1/+0,
Argyrios Kyrtzidis684190b2012-06-01 00:10:47 +000015// __bridge/CFBridgingRelease is used.
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +000016//
17// NSString *str = (NSString *)kUTTypePlainText;
18// str = b ? kUTTypeRTF : kUTTypePlainText;
19// NSString *_uuidString = (NSString *)CFUUIDCreateString(kCFAllocatorDefault,
20// _uuid);
21// ---->
22// NSString *str = (__bridge NSString *)kUTTypePlainText;
23// str = (__bridge NSString *)(b ? kUTTypeRTF : kUTTypePlainText);
Argyrios Kyrtzidis684190b2012-06-01 00:10:47 +000024// NSString *_uuidString = (NSString *)
25// CFBridgingRelease(CFUUIDCreateString(kCFAllocatorDefault, _uuid));
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +000026//
27// For a C pointer to ObjC, for casting 'self', __bridge is used.
28//
29// CFStringRef str = (CFStringRef)self;
30// ---->
31// CFStringRef str = (__bridge CFStringRef)self;
32//
33//===----------------------------------------------------------------------===//
34
35#include "Transforms.h"
36#include "Internals.h"
37#include "clang/Analysis/DomainSpecific/CocoaConventions.h"
Benjamin Kramer471c8b42012-07-04 20:19:54 +000038#include "clang/AST/ASTContext.h"
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +000039#include "clang/AST/ParentMap.h"
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +000040#include "clang/Basic/SourceManager.h"
Benjamin Kramer471c8b42012-07-04 20:19:54 +000041#include "clang/Lex/Lexer.h"
42#include "clang/Sema/SemaDiagnostic.h"
Benjamin Kramer8fe83e12012-02-04 13:45:25 +000043#include "llvm/ADT/SmallString.h"
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +000044
45using namespace clang;
46using namespace arcmt;
47using namespace trans;
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +000048
49namespace {
50
51class UnbridgedCastRewriter : public RecursiveASTVisitor<UnbridgedCastRewriter>{
52 MigrationPass &Pass;
53 IdentifierInfo *SelfII;
Dylan Noblesmith6f42b622012-02-05 02:12:40 +000054 OwningPtr<ParentMap> StmtMap;
Argyrios Kyrtzidis76a52452012-06-07 00:44:06 +000055 Decl *ParentD;
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +000056
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +000057public:
Argyrios Kyrtzidis76a52452012-06-07 00:44:06 +000058 UnbridgedCastRewriter(MigrationPass &pass) : Pass(pass), ParentD(0) {
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +000059 SelfII = &Pass.Ctx.Idents.get("self");
60 }
61
Argyrios Kyrtzidis76a52452012-06-07 00:44:06 +000062 void transformBody(Stmt *body, Decl *ParentD) {
63 this->ParentD = ParentD;
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +000064 StmtMap.reset(new ParentMap(body));
65 TraverseStmt(body);
66 }
67
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +000068 bool VisitCastExpr(CastExpr *E) {
John McCall1d9b3b22011-09-09 05:25:32 +000069 if (E->getCastKind() != CK_CPointerToObjCPointerCast
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +000070 && E->getCastKind() != CK_BitCast)
71 return true;
72
73 QualType castType = E->getType();
74 Expr *castExpr = E->getSubExpr();
75 QualType castExprType = castExpr->getType();
76
77 if (castType->isObjCObjectPointerType() &&
78 castExprType->isObjCObjectPointerType())
79 return true;
80 if (!castType->isObjCObjectPointerType() &&
81 !castExprType->isObjCObjectPointerType())
82 return true;
83
84 bool exprRetainable = castExprType->isObjCIndirectLifetimeType();
85 bool castRetainable = castType->isObjCIndirectLifetimeType();
86 if (exprRetainable == castRetainable) return true;
87
88 if (castExpr->isNullPointerConstant(Pass.Ctx,
89 Expr::NPC_ValueDependentIsNull))
90 return true;
91
92 SourceLocation loc = castExpr->getExprLoc();
93 if (loc.isValid() && Pass.Ctx.getSourceManager().isInSystemHeader(loc))
94 return true;
95
96 if (castType->isObjCObjectPointerType())
97 transformNonObjCToObjCCast(E);
98 else
99 transformObjCToNonObjCCast(E);
100
101 return true;
102 }
103
104private:
105 void transformNonObjCToObjCCast(CastExpr *E) {
106 if (!E) return;
107
108 // Global vars are assumed that are cast as unretained.
109 if (isGlobalVar(E))
110 if (E->getSubExpr()->getType()->isPointerType()) {
111 castToObjCObject(E, /*retained=*/false);
112 return;
113 }
114
115 // If the cast is directly over the result of a Core Foundation function
116 // try to figure out whether it should be cast as retained or unretained.
117 Expr *inner = E->IgnoreParenCasts();
118 if (CallExpr *callE = dyn_cast<CallExpr>(inner)) {
119 if (FunctionDecl *FD = callE->getDirectCallee()) {
120 if (FD->getAttr<CFReturnsRetainedAttr>()) {
121 castToObjCObject(E, /*retained=*/true);
122 return;
123 }
124 if (FD->getAttr<CFReturnsNotRetainedAttr>()) {
125 castToObjCObject(E, /*retained=*/false);
126 return;
127 }
128 if (FD->isGlobal() &&
129 FD->getIdentifier() &&
130 ento::cocoa::isRefType(E->getSubExpr()->getType(), "CF",
131 FD->getIdentifier()->getName())) {
132 StringRef fname = FD->getIdentifier()->getName();
133 if (fname.endswith("Retain") ||
134 fname.find("Create") != StringRef::npos ||
135 fname.find("Copy") != StringRef::npos) {
Fariborz Jahanian2908ffb2012-01-31 21:58:23 +0000136 // Do not migrate to couple of bridge transfer casts which
137 // cancel each other out. Leave it unchanged so error gets user
138 // attention instead.
139 if (FD->getName() == "CFRetain" &&
140 FD->getNumParams() == 1 &&
141 FD->getParent()->isTranslationUnit() &&
142 FD->getLinkage() == ExternalLinkage) {
143 Expr *Arg = callE->getArg(0);
Fariborz Jahanian9c7aed32012-01-31 22:09:44 +0000144 if (const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(Arg)) {
Fariborz Jahanian2908ffb2012-01-31 21:58:23 +0000145 const Expr *sub = ICE->getSubExpr();
146 QualType T = sub->getType();
147 if (T->isObjCObjectPointerType())
148 return;
149 }
150 }
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000151 castToObjCObject(E, /*retained=*/true);
152 return;
153 }
154
155 if (fname.find("Get") != StringRef::npos) {
156 castToObjCObject(E, /*retained=*/false);
157 return;
158 }
159 }
160 }
161 }
Argyrios Kyrtzidis76a52452012-06-07 00:44:06 +0000162
163 // If returning an ivar or a member of an ivar from a +0 method, use
164 // a __bridge cast.
165 Expr *base = inner->IgnoreParenImpCasts();
166 while (isa<MemberExpr>(base))
167 base = cast<MemberExpr>(base)->getBase()->IgnoreParenImpCasts();
168 if (isa<ObjCIvarRefExpr>(base) &&
169 isa<ReturnStmt>(StmtMap->getParentIgnoreParenCasts(E))) {
170 if (ObjCMethodDecl *method = dyn_cast_or_null<ObjCMethodDecl>(ParentD)) {
171 if (!method->hasAttr<NSReturnsRetainedAttr>()) {
172 castToObjCObject(E, /*retained=*/false);
173 return;
174 }
175 }
176 }
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000177 }
178
179 void castToObjCObject(CastExpr *E, bool retained) {
180 rewriteToBridgedCast(E, retained ? OBC_BridgeTransfer : OBC_Bridge);
181 }
182
183 void rewriteToBridgedCast(CastExpr *E, ObjCBridgeCastKind Kind) {
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +0000184 Transaction Trans(Pass.TA);
185 rewriteToBridgedCast(E, Kind, Trans);
186 }
187
188 void rewriteToBridgedCast(CastExpr *E, ObjCBridgeCastKind Kind,
189 Transaction &Trans) {
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000190 TransformActions &TA = Pass.TA;
191
192 // We will remove the compiler diagnostic.
193 if (!TA.hasDiagnostic(diag::err_arc_mismatched_cast,
194 diag::err_arc_cast_requires_bridge,
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +0000195 E->getLocStart())) {
196 Trans.abort();
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000197 return;
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +0000198 }
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000199
200 StringRef bridge;
201 switch(Kind) {
202 case OBC_Bridge:
203 bridge = "__bridge "; break;
204 case OBC_BridgeTransfer:
205 bridge = "__bridge_transfer "; break;
206 case OBC_BridgeRetained:
207 bridge = "__bridge_retained "; break;
208 }
209
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000210 TA.clearDiagnostic(diag::err_arc_mismatched_cast,
211 diag::err_arc_cast_requires_bridge,
212 E->getLocStart());
Argyrios Kyrtzidis684190b2012-06-01 00:10:47 +0000213 if (Kind == OBC_Bridge || !Pass.CFBridgingFunctionsDefined()) {
214 if (CStyleCastExpr *CCE = dyn_cast<CStyleCastExpr>(E)) {
215 TA.insertAfterToken(CCE->getLParenLoc(), bridge);
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000216 } else {
Argyrios Kyrtzidis684190b2012-06-01 00:10:47 +0000217 SourceLocation insertLoc = E->getSubExpr()->getLocStart();
218 SmallString<128> newCast;
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000219 newCast += '(';
Argyrios Kyrtzidis684190b2012-06-01 00:10:47 +0000220 newCast += bridge;
221 newCast += E->getType().getAsString(Pass.Ctx.getPrintingPolicy());
222 newCast += ')';
223
224 if (isa<ParenExpr>(E->getSubExpr())) {
225 TA.insert(insertLoc, newCast.str());
226 } else {
227 newCast += '(';
228 TA.insert(insertLoc, newCast.str());
229 TA.insertAfterToken(E->getLocEnd(), ")");
230 }
231 }
232 } else {
233 assert(Kind == OBC_BridgeTransfer || Kind == OBC_BridgeRetained);
Jordan Rosed880b3a2012-06-07 01:10:31 +0000234 SmallString<32> BridgeCall;
Argyrios Kyrtzidis684190b2012-06-01 00:10:47 +0000235
236 Expr *WrapE = E->getSubExpr();
Jordan Rosed880b3a2012-06-07 01:10:31 +0000237 SourceLocation InsertLoc = WrapE->getLocStart();
238
239 SourceManager &SM = Pass.Ctx.getSourceManager();
240 char PrevChar = *SM.getCharacterData(InsertLoc.getLocWithOffset(-1));
241 if (Lexer::isIdentifierBodyChar(PrevChar, Pass.Ctx.getLangOpts()))
242 BridgeCall += ' ';
243
244 if (Kind == OBC_BridgeTransfer)
245 BridgeCall += "CFBridgingRelease";
246 else
247 BridgeCall += "CFBridgingRetain";
248
Argyrios Kyrtzidis684190b2012-06-01 00:10:47 +0000249 if (isa<ParenExpr>(WrapE)) {
Jordan Rosed880b3a2012-06-07 01:10:31 +0000250 TA.insert(InsertLoc, BridgeCall);
Argyrios Kyrtzidis684190b2012-06-01 00:10:47 +0000251 } else {
Jordan Rosed880b3a2012-06-07 01:10:31 +0000252 BridgeCall += '(';
253 TA.insert(InsertLoc, BridgeCall);
Argyrios Kyrtzidis684190b2012-06-01 00:10:47 +0000254 TA.insertAfterToken(WrapE->getLocEnd(), ")");
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000255 }
256 }
257 }
258
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +0000259 void rewriteCastForCFRetain(CastExpr *castE, CallExpr *callE) {
260 Transaction Trans(Pass.TA);
261 Pass.TA.replace(callE->getSourceRange(), callE->getArg(0)->getSourceRange());
262 rewriteToBridgedCast(castE, OBC_BridgeRetained, Trans);
263 }
264
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000265 void transformObjCToNonObjCCast(CastExpr *E) {
266 if (isSelf(E->getSubExpr()))
267 return rewriteToBridgedCast(E, OBC_Bridge);
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +0000268
269 CallExpr *callE;
270 if (isPassedToCFRetain(E, callE))
271 return rewriteCastForCFRetain(E, callE);
272
273 ObjCMethodFamily family = getFamilyOfMessage(E->getSubExpr());
274 if (family == OMF_retain)
275 return rewriteToBridgedCast(E, OBC_BridgeRetained);
276
277 if (family == OMF_autorelease || family == OMF_release) {
278 std::string err = "it is not safe to cast to '";
Douglas Gregor30c42402011-09-27 22:38:19 +0000279 err += E->getType().getAsString(Pass.Ctx.getPrintingPolicy());
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +0000280 err += "' the result of '";
281 err += family == OMF_autorelease ? "autorelease" : "release";
282 err += "' message; a __bridge cast may result in a pointer to a "
283 "destroyed object and a __bridge_retained may leak the object";
284 Pass.TA.reportError(err, E->getLocStart(),
285 E->getSubExpr()->getSourceRange());
286 Stmt *parent = E;
287 do {
288 parent = StmtMap->getParentIgnoreParenImpCasts(parent);
289 } while (parent && isa<ExprWithCleanups>(parent));
290
291 if (ReturnStmt *retS = dyn_cast_or_null<ReturnStmt>(parent)) {
292 std::string note = "remove the cast and change return type of function "
293 "to '";
Douglas Gregor30c42402011-09-27 22:38:19 +0000294 note += E->getSubExpr()->getType().getAsString(Pass.Ctx.getPrintingPolicy());
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +0000295 note += "' to have the object automatically autoreleased";
296 Pass.TA.reportNote(note, retS->getLocStart());
297 }
298 }
299
John McCall4b9c2d22011-11-06 09:01:30 +0000300 Expr *subExpr = E->getSubExpr();
301
302 // Look through pseudo-object expressions.
303 if (PseudoObjectExpr *pseudo = dyn_cast<PseudoObjectExpr>(subExpr)) {
304 subExpr = pseudo->getResultExpr();
305 assert(subExpr && "no result for pseudo-object of non-void type?");
306 }
307
308 if (ImplicitCastExpr *implCE = dyn_cast<ImplicitCastExpr>(subExpr)) {
John McCall33e56f32011-09-10 06:18:15 +0000309 if (implCE->getCastKind() == CK_ARCConsumeObject)
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +0000310 return rewriteToBridgedCast(E, OBC_BridgeRetained);
John McCall33e56f32011-09-10 06:18:15 +0000311 if (implCE->getCastKind() == CK_ARCReclaimReturnedObject)
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +0000312 return rewriteToBridgedCast(E, OBC_Bridge);
313 }
Argyrios Kyrtzidis4532b552011-09-14 18:17:09 +0000314
315 bool isConsumed = false;
316 if (isPassedToCParamWithKnownOwnership(E, isConsumed))
317 return rewriteToBridgedCast(E, isConsumed ? OBC_BridgeRetained
318 : OBC_Bridge);
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000319 }
320
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +0000321 static ObjCMethodFamily getFamilyOfMessage(Expr *E) {
322 E = E->IgnoreParenCasts();
323 if (ObjCMessageExpr *ME = dyn_cast<ObjCMessageExpr>(E))
324 return ME->getMethodFamily();
325
326 return OMF_None;
327 }
328
329 bool isPassedToCFRetain(Expr *E, CallExpr *&callE) const {
330 if ((callE = dyn_cast_or_null<CallExpr>(
331 StmtMap->getParentIgnoreParenImpCasts(E))))
332 if (FunctionDecl *
333 FD = dyn_cast_or_null<FunctionDecl>(callE->getCalleeDecl()))
334 if (FD->getName() == "CFRetain" && FD->getNumParams() == 1 &&
335 FD->getParent()->isTranslationUnit() &&
336 FD->getLinkage() == ExternalLinkage)
337 return true;
338
339 return false;
340 }
341
Argyrios Kyrtzidis4532b552011-09-14 18:17:09 +0000342 bool isPassedToCParamWithKnownOwnership(Expr *E, bool &isConsumed) const {
343 if (CallExpr *callE = dyn_cast_or_null<CallExpr>(
344 StmtMap->getParentIgnoreParenImpCasts(E)))
345 if (FunctionDecl *
346 FD = dyn_cast_or_null<FunctionDecl>(callE->getCalleeDecl())) {
347 unsigned i = 0;
348 for (unsigned e = callE->getNumArgs(); i != e; ++i) {
349 Expr *arg = callE->getArg(i);
350 if (arg == E || arg->IgnoreParenImpCasts() == E)
351 break;
352 }
353 if (i < callE->getNumArgs()) {
354 ParmVarDecl *PD = FD->getParamDecl(i);
355 if (PD->getAttr<CFConsumedAttr>()) {
356 isConsumed = true;
357 return true;
358 }
359 }
360 }
361
362 return false;
363 }
364
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +0000365 bool isSelf(Expr *E) const {
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000366 E = E->IgnoreParenLValueCasts();
367 if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(E))
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +0000368 if (ImplicitParamDecl *IPD = dyn_cast<ImplicitParamDecl>(DRE->getDecl()))
369 if (IPD->getIdentifier() == SelfII)
370 return true;
371
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000372 return false;
373 }
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000374};
375
376} // end anonymous namespace
377
378void trans::rewriteUnbridgedCasts(MigrationPass &pass) {
Argyrios Kyrtzidis18fd0c62011-07-27 05:28:18 +0000379 BodyTransform<UnbridgedCastRewriter> trans(pass);
Argyrios Kyrtzidis7196d062011-06-21 20:20:39 +0000380 trans.TraverseDecl(pass.Ctx.getTranslationUnitDecl());
381}