blob: 0e13ddcd7e6f195902e3081e7a7433c02558f5f9 [file] [log] [blame]
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001//=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines malloc/free checker, which checks for potential memory
11// leaks, double free, and use-after-free problems.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000015#include "ClangSACheckers.h"
Anna Zaksf0dfc9c2012-02-17 22:35:31 +000016#include "InterCheckerAPI.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000017#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000018#include "clang/StaticAnalyzer/Core/CheckerManager.h"
19#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000020#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Jordan Rose740d4902012-07-02 19:27:35 +000021#include "clang/StaticAnalyzer/Core/PathSensitive/Calls.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
23#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
Anna Zaks15d0ae12012-02-11 23:46:36 +000025#include "clang/Basic/SourceManager.h"
Zhongxing Xu589c0f22009-11-12 08:38:56 +000026#include "llvm/ADT/ImmutableMap.h"
Benjamin Kramer8fe83e12012-02-04 13:45:25 +000027#include "llvm/ADT/SmallString.h"
Benjamin Kramer00bd44d2012-02-04 12:31:12 +000028#include "llvm/ADT/STLExtras.h"
Anna Zaks60a1fa42012-02-22 03:14:20 +000029#include <climits>
30
Zhongxing Xu589c0f22009-11-12 08:38:56 +000031using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000032using namespace ento;
Zhongxing Xu589c0f22009-11-12 08:38:56 +000033
34namespace {
35
Zhongxing Xu7fb14642009-12-11 00:55:44 +000036class RefState {
Anna Zaks050cdd72012-06-20 20:57:46 +000037 enum Kind { // Reference to allocated memory.
38 Allocated,
39 // Reference to released/freed memory.
40 Released,
41 // Reference to escaped memory - no assumptions can be made of
42 // the state after the reference escapes.
43 Escaped,
44 // The responsibility for freeing resources has transfered from
45 // this reference. A relinquished symbol should not be freed.
Ted Kremenekdde201b2010-08-06 21:12:55 +000046 Relinquished } K;
Zhongxing Xu243fde92009-11-17 07:54:15 +000047 const Stmt *S;
48
Zhongxing Xu7fb14642009-12-11 00:55:44 +000049public:
Zhongxing Xu243fde92009-11-17 07:54:15 +000050 RefState(Kind k, const Stmt *s) : K(k), S(s) {}
51
Anna Zaks050cdd72012-06-20 20:57:46 +000052 bool isAllocated() const { return K == Allocated; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000053 bool isReleased() const { return K == Released; }
Anna Zaks050cdd72012-06-20 20:57:46 +000054 bool isRelinquished() const { return K == Relinquished; }
Anna Zaksca23eb22012-02-29 18:42:47 +000055
Anna Zaksc8bb3be2012-02-13 18:05:39 +000056 const Stmt *getStmt() const { return S; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000057
58 bool operator==(const RefState &X) const {
59 return K == X.K && S == X.S;
60 }
61
Anna Zaks050cdd72012-06-20 20:57:46 +000062 static RefState getAllocated(const Stmt *s) {
63 return RefState(Allocated, s);
Zhongxing Xub94b81a2009-12-31 06:13:07 +000064 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000065 static RefState getReleased(const Stmt *s) { return RefState(Released, s); }
66 static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); }
Ted Kremenekdde201b2010-08-06 21:12:55 +000067 static RefState getRelinquished(const Stmt *s) {
68 return RefState(Relinquished, s);
69 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000070
71 void Profile(llvm::FoldingSetNodeID &ID) const {
72 ID.AddInteger(K);
73 ID.AddPointer(S);
74 }
Zhongxing Xu589c0f22009-11-12 08:38:56 +000075};
76
Anna Zaks40add292012-02-15 00:11:25 +000077struct ReallocPair {
78 SymbolRef ReallocatedSym;
79 bool IsFreeOnFailure;
80 ReallocPair(SymbolRef S, bool F) : ReallocatedSym(S), IsFreeOnFailure(F) {}
81 void Profile(llvm::FoldingSetNodeID &ID) const {
82 ID.AddInteger(IsFreeOnFailure);
83 ID.AddPointer(ReallocatedSym);
84 }
85 bool operator==(const ReallocPair &X) const {
86 return ReallocatedSym == X.ReallocatedSym &&
87 IsFreeOnFailure == X.IsFreeOnFailure;
88 }
89};
90
Anna Zaks3d7c44e2012-03-21 19:45:08 +000091typedef std::pair<const Stmt*, const MemRegion*> LeakInfo;
92
Anna Zaksb319e022012-02-08 20:13:28 +000093class MallocChecker : public Checker<check::DeadSymbols,
Ted Kremeneke3659a72012-01-04 23:48:37 +000094 check::EndPath,
95 check::PreStmt<ReturnStmt>,
Anna Zaks66c40402012-02-14 21:55:24 +000096 check::PreStmt<CallExpr>,
Anna Zaksb319e022012-02-08 20:13:28 +000097 check::PostStmt<CallExpr>,
Anna Zaksf5aa3f52012-03-22 00:57:20 +000098 check::PostStmt<BlockExpr>,
Anna Zaks5b7aa342012-06-22 02:04:31 +000099 check::PreObjCMessage,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000100 check::Location,
101 check::Bind,
Anna Zaks4fb54872012-02-11 21:02:35 +0000102 eval::Assume,
103 check::RegionChanges>
Ted Kremeneke3659a72012-01-04 23:48:37 +0000104{
Anna Zaksfebdc322012-02-16 22:26:12 +0000105 mutable OwningPtr<BugType> BT_DoubleFree;
106 mutable OwningPtr<BugType> BT_Leak;
107 mutable OwningPtr<BugType> BT_UseFree;
108 mutable OwningPtr<BugType> BT_BadFree;
Anna Zaksb16ce452012-02-15 00:11:22 +0000109 mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc,
Anna Zaks60a1fa42012-02-22 03:14:20 +0000110 *II_valloc, *II_reallocf, *II_strndup, *II_strdup;
111
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000112public:
Anna Zaksb16ce452012-02-15 00:11:22 +0000113 MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0),
Anna Zaks60a1fa42012-02-22 03:14:20 +0000114 II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {}
Anna Zaks231361a2012-02-08 23:16:52 +0000115
116 /// In pessimistic mode, the checker assumes that it does not know which
117 /// functions might free the memory.
118 struct ChecksFilter {
119 DefaultBool CMallocPessimistic;
120 DefaultBool CMallocOptimistic;
121 };
122
123 ChecksFilter Filter;
124
Anna Zaks66c40402012-02-14 21:55:24 +0000125 void checkPreStmt(const CallExpr *S, CheckerContext &C) const;
Anna Zaksb319e022012-02-08 20:13:28 +0000126 void checkPostStmt(const CallExpr *CE, CheckerContext &C) const;
Anna Zaks5b7aa342012-06-22 02:04:31 +0000127 void checkPreObjCMessage(const ObjCMessage &Msg, CheckerContext &C) const;
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000128 void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000129 void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
Anna Zaksaf498a22011-10-25 19:56:48 +0000130 void checkEndPath(CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000131 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000132 ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000133 bool Assumption) const;
Anna Zaks390909c2011-10-06 00:43:15 +0000134 void checkLocation(SVal l, bool isLoad, const Stmt *S,
135 CheckerContext &C) const;
136 void checkBind(SVal location, SVal val, const Stmt*S,
137 CheckerContext &C) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000138 ProgramStateRef
139 checkRegionChanges(ProgramStateRef state,
140 const StoreManager::InvalidatedSymbols *invalidated,
141 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +0000142 ArrayRef<const MemRegion *> Regions,
Jordan Rose740d4902012-07-02 19:27:35 +0000143 const CallEvent *Call) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000144 bool wantsRegionChangeUpdate(ProgramStateRef state) const {
145 return true;
146 }
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000147
Anna Zaks93c5a242012-05-02 00:05:20 +0000148 void printState(raw_ostream &Out, ProgramStateRef State,
149 const char *NL, const char *Sep) const;
150
Zhongxing Xu7b760962009-11-13 07:25:27 +0000151private:
Anna Zaks66c40402012-02-14 21:55:24 +0000152 void initIdentifierInfo(ASTContext &C) const;
153
154 /// Check if this is one of the functions which can allocate/reallocate memory
155 /// pointed to by one of its arguments.
156 bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks14345182012-05-18 01:16:10 +0000157 bool isFreeFunction(const FunctionDecl *FD, ASTContext &C) const;
158 bool isAllocationFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000159
Anna Zaks87cb5be2012-02-22 19:24:52 +0000160 static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C,
161 const CallExpr *CE,
162 const OwnershipAttr* Att);
Ted Kremenek8bef8232012-01-26 21:29:00 +0000163 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000164 const Expr *SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000165 ProgramStateRef state) {
Ted Kremenek5eca4822012-01-06 22:09:28 +0000166 return MallocMemAux(C, CE,
167 state->getSVal(SizeEx, C.getLocationContext()),
168 Init, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000169 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000170
Ted Kremenek8bef8232012-01-26 21:29:00 +0000171 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000172 SVal SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000173 ProgramStateRef state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000174
Anna Zaks87cb5be2012-02-22 19:24:52 +0000175 /// Update the RefState to reflect the new memory allocation.
176 static ProgramStateRef MallocUpdateRefState(CheckerContext &C,
177 const CallExpr *CE,
178 ProgramStateRef state);
179
180 ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE,
181 const OwnershipAttr* Att) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000182 ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000183 ProgramStateRef state, unsigned Num,
184 bool Hold) const;
185 ProgramStateRef FreeMemAux(CheckerContext &C, const Expr *Arg,
186 const Expr *ParentExpr,
187 ProgramStateRef state,
188 bool Hold) const;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000189
Anna Zaks87cb5be2012-02-22 19:24:52 +0000190 ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE,
191 bool FreesMemOnFailure) const;
192 static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE);
Jordy Rose43859f62010-06-07 19:32:37 +0000193
Anna Zaks14345182012-05-18 01:16:10 +0000194 ///\brief Check if the memory associated with this symbol was released.
195 bool isReleased(SymbolRef Sym, CheckerContext &C) const;
196
Anna Zaks91c2a112012-02-08 23:16:56 +0000197 bool checkEscape(SymbolRef Sym, const Stmt *S, CheckerContext &C) const;
198 bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
199 const Stmt *S = 0) const;
200
Anna Zaks66c40402012-02-14 21:55:24 +0000201 /// Check if the function is not known to us. So, for example, we could
202 /// conservatively assume it can free/reallocate it's pointer arguments.
Jordan Rose740d4902012-07-02 19:27:35 +0000203 bool doesNotFreeMemory(const CallEvent *Call,
Anna Zaks3cd89ad2012-02-24 23:56:53 +0000204 ProgramStateRef State) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000205
Ted Kremenek9c378f72011-08-12 23:37:29 +0000206 static bool SummarizeValue(raw_ostream &os, SVal V);
207 static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR);
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000208 void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const;
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000209
Anna Zaksca8e36e2012-02-23 21:38:21 +0000210 /// Find the location of the allocation for Sym on the path leading to the
211 /// exploded node N.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000212 LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
213 CheckerContext &C) const;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000214
Anna Zaksda046772012-02-11 21:02:40 +0000215 void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const;
216
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000217 /// The bug visitor which allows us to print extra diagnostics along the
218 /// BugReport path. For example, showing the allocation site of the leaked
219 /// region.
Jordy Rose01153492012-03-24 02:45:35 +0000220 class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000221 protected:
Anna Zaksfe571602012-02-16 22:26:07 +0000222 enum NotificationMode {
223 Normal,
Anna Zaksfe571602012-02-16 22:26:07 +0000224 ReallocationFailed
225 };
226
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000227 // The allocated region symbol tracked by the main analysis.
228 SymbolRef Sym;
229
Anna Zaks88feba02012-05-10 01:37:40 +0000230 // The mode we are in, i.e. what kind of diagnostics will be emitted.
231 NotificationMode Mode;
Jordy Roseb000fb52012-03-24 03:15:09 +0000232
Anna Zaks88feba02012-05-10 01:37:40 +0000233 // A symbol from when the primary region should have been reallocated.
234 SymbolRef FailedReallocSymbol;
Jordy Roseb000fb52012-03-24 03:15:09 +0000235
Anna Zaks88feba02012-05-10 01:37:40 +0000236 bool IsLeak;
237
238 public:
239 MallocBugVisitor(SymbolRef S, bool isLeak = false)
240 : Sym(S), Mode(Normal), FailedReallocSymbol(0), IsLeak(isLeak) {}
Jordy Roseb000fb52012-03-24 03:15:09 +0000241
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000242 virtual ~MallocBugVisitor() {}
243
244 void Profile(llvm::FoldingSetNodeID &ID) const {
245 static int X = 0;
246 ID.AddPointer(&X);
247 ID.AddPointer(Sym);
248 }
249
Anna Zaksfe571602012-02-16 22:26:07 +0000250 inline bool isAllocated(const RefState *S, const RefState *SPrev,
251 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000252 // Did not track -> allocated. Other state (released) -> allocated.
Anna Zaksfe571602012-02-16 22:26:07 +0000253 return (Stmt && isa<CallExpr>(Stmt) &&
254 (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000255 }
256
Anna Zaksfe571602012-02-16 22:26:07 +0000257 inline bool isReleased(const RefState *S, const RefState *SPrev,
258 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000259 // Did not track -> released. Other state (allocated) -> released.
Anna Zaksfe571602012-02-16 22:26:07 +0000260 return (Stmt && isa<CallExpr>(Stmt) &&
261 (S && S->isReleased()) && (!SPrev || !SPrev->isReleased()));
262 }
263
Anna Zaks5b7aa342012-06-22 02:04:31 +0000264 inline bool isRelinquished(const RefState *S, const RefState *SPrev,
265 const Stmt *Stmt) {
266 // Did not track -> relinquished. Other state (allocated) -> relinquished.
267 return (Stmt && (isa<CallExpr>(Stmt) || isa<ObjCMessageExpr>(Stmt) ||
268 isa<ObjCPropertyRefExpr>(Stmt)) &&
269 (S && S->isRelinquished()) &&
270 (!SPrev || !SPrev->isRelinquished()));
271 }
272
Anna Zaksfe571602012-02-16 22:26:07 +0000273 inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev,
274 const Stmt *Stmt) {
275 // If the expression is not a call, and the state change is
276 // released -> allocated, it must be the realloc return value
277 // check. If we have to handle more cases here, it might be cleaner just
278 // to track this extra bit in the state itself.
279 return ((!Stmt || !isa<CallExpr>(Stmt)) &&
280 (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000281 }
282
283 PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
284 const ExplodedNode *PrevN,
285 BugReporterContext &BRC,
286 BugReport &BR);
Anna Zaks88feba02012-05-10 01:37:40 +0000287
288 PathDiagnosticPiece* getEndPath(BugReporterContext &BRC,
289 const ExplodedNode *EndPathNode,
290 BugReport &BR) {
291 if (!IsLeak)
292 return 0;
293
294 PathDiagnosticLocation L =
295 PathDiagnosticLocation::createEndOfPath(EndPathNode,
296 BRC.getSourceManager());
297 // Do not add the statement itself as a range in case of leak.
298 return new PathDiagnosticEventPiece(L, BR.getDescription(), false);
299 }
300
Anna Zaks56a938f2012-03-16 23:24:20 +0000301 private:
302 class StackHintGeneratorForReallocationFailed
303 : public StackHintGeneratorForSymbol {
304 public:
305 StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M)
306 : StackHintGeneratorForSymbol(S, M) {}
307
308 virtual std::string getMessageForArg(const Expr *ArgE, unsigned ArgIndex) {
309 SmallString<200> buf;
310 llvm::raw_svector_ostream os(buf);
311
Anna Zaksfbd58742012-03-16 23:44:28 +0000312 os << "Reallocation of ";
Anna Zaks56a938f2012-03-16 23:24:20 +0000313 // Printed parameters start at 1, not 0.
314 printOrdinal(++ArgIndex, os);
315 os << " parameter failed";
316
317 return os.str();
318 }
319
320 virtual std::string getMessageForReturn(const CallExpr *CallExpr) {
Anna Zaksfbd58742012-03-16 23:44:28 +0000321 return "Reallocation of returned value failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000322 }
323 };
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000324 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000325};
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000326} // end anonymous namespace
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000327
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000328typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy;
Anna Zaks40add292012-02-15 00:11:25 +0000329typedef llvm::ImmutableMap<SymbolRef, ReallocPair > ReallocMap;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000330class RegionState {};
331class ReallocPairs {};
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000332namespace clang {
Ted Kremenek9ef65372010-12-23 07:20:52 +0000333namespace ento {
Zhongxing Xu243fde92009-11-17 07:54:15 +0000334 template <>
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000335 struct ProgramStateTrait<RegionState>
336 : public ProgramStatePartialTrait<RegionStateTy> {
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000337 static void *GDMIndex() { static int x; return &x; }
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000338 };
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000339
340 template <>
341 struct ProgramStateTrait<ReallocPairs>
Anna Zaks40add292012-02-15 00:11:25 +0000342 : public ProgramStatePartialTrait<ReallocMap> {
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000343 static void *GDMIndex() { static int x; return &x; }
344 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000345}
Argyrios Kyrtzidis5a4f98f2010-12-22 18:53:20 +0000346}
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000347
Anna Zaks4fb54872012-02-11 21:02:35 +0000348namespace {
349class StopTrackingCallback : public SymbolVisitor {
350 ProgramStateRef state;
351public:
352 StopTrackingCallback(ProgramStateRef st) : state(st) {}
353 ProgramStateRef getState() const { return state; }
354
355 bool VisitSymbol(SymbolRef sym) {
356 state = state->remove<RegionState>(sym);
357 return true;
358 }
359};
360} // end anonymous namespace
361
Anna Zaks66c40402012-02-14 21:55:24 +0000362void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const {
Anna Zaksa38cb2c2012-05-18 22:47:40 +0000363 if (II_malloc)
364 return;
365 II_malloc = &Ctx.Idents.get("malloc");
366 II_free = &Ctx.Idents.get("free");
367 II_realloc = &Ctx.Idents.get("realloc");
368 II_reallocf = &Ctx.Idents.get("reallocf");
369 II_calloc = &Ctx.Idents.get("calloc");
370 II_valloc = &Ctx.Idents.get("valloc");
371 II_strdup = &Ctx.Idents.get("strdup");
372 II_strndup = &Ctx.Idents.get("strndup");
Anna Zaksb319e022012-02-08 20:13:28 +0000373}
374
Anna Zaks66c40402012-02-14 21:55:24 +0000375bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +0000376 if (isFreeFunction(FD, C))
377 return true;
378
379 if (isAllocationFunction(FD, C))
380 return true;
381
382 return false;
383}
384
385bool MallocChecker::isAllocationFunction(const FunctionDecl *FD,
386 ASTContext &C) const {
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000387 if (!FD)
388 return false;
Anna Zaks14345182012-05-18 01:16:10 +0000389
Anna Zaks66c40402012-02-14 21:55:24 +0000390 IdentifierInfo *FunI = FD->getIdentifier();
391 if (!FunI)
392 return false;
393
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000394 initIdentifierInfo(C);
395
Anna Zaks14345182012-05-18 01:16:10 +0000396 if (FunI == II_malloc || FunI == II_realloc ||
Anna Zaks60a1fa42012-02-22 03:14:20 +0000397 FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc ||
398 FunI == II_strdup || FunI == II_strndup)
Anna Zaks66c40402012-02-14 21:55:24 +0000399 return true;
400
Anna Zaks14345182012-05-18 01:16:10 +0000401 if (Filter.CMallocOptimistic && FD->hasAttrs())
402 for (specific_attr_iterator<OwnershipAttr>
403 i = FD->specific_attr_begin<OwnershipAttr>(),
404 e = FD->specific_attr_end<OwnershipAttr>();
405 i != e; ++i)
406 if ((*i)->getOwnKind() == OwnershipAttr::Returns)
407 return true;
408 return false;
409}
410
411bool MallocChecker::isFreeFunction(const FunctionDecl *FD, ASTContext &C) const {
412 if (!FD)
413 return false;
414
415 IdentifierInfo *FunI = FD->getIdentifier();
416 if (!FunI)
417 return false;
418
419 initIdentifierInfo(C);
420
421 if (FunI == II_free || FunI == II_realloc || FunI == II_reallocf)
Anna Zaks66c40402012-02-14 21:55:24 +0000422 return true;
423
Anna Zaks14345182012-05-18 01:16:10 +0000424 if (Filter.CMallocOptimistic && FD->hasAttrs())
425 for (specific_attr_iterator<OwnershipAttr>
426 i = FD->specific_attr_begin<OwnershipAttr>(),
427 e = FD->specific_attr_end<OwnershipAttr>();
428 i != e; ++i)
429 if ((*i)->getOwnKind() == OwnershipAttr::Takes ||
430 (*i)->getOwnKind() == OwnershipAttr::Holds)
431 return true;
Anna Zaks66c40402012-02-14 21:55:24 +0000432 return false;
433}
434
Anna Zaksb319e022012-02-08 20:13:28 +0000435void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const {
436 const FunctionDecl *FD = C.getCalleeDecl(CE);
437 if (!FD)
438 return;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000439
Anna Zaksb16ce452012-02-15 00:11:22 +0000440 initIdentifierInfo(C.getASTContext());
441 IdentifierInfo *FunI = FD->getIdentifier();
442 if (!FunI)
443 return;
444
Anna Zaks87cb5be2012-02-22 19:24:52 +0000445 ProgramStateRef State = C.getState();
Anna Zaksb16ce452012-02-15 00:11:22 +0000446 if (FunI == II_malloc || FunI == II_valloc) {
Anna Zaks259052d2012-04-10 23:41:11 +0000447 if (CE->getNumArgs() < 1)
448 return;
Anna Zaks87cb5be2012-02-22 19:24:52 +0000449 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
Anna Zaksb16ce452012-02-15 00:11:22 +0000450 } else if (FunI == II_realloc) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000451 State = ReallocMem(C, CE, false);
Anna Zaks40add292012-02-15 00:11:25 +0000452 } else if (FunI == II_reallocf) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000453 State = ReallocMem(C, CE, true);
Anna Zaksb16ce452012-02-15 00:11:22 +0000454 } else if (FunI == II_calloc) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000455 State = CallocMem(C, CE);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000456 } else if (FunI == II_free) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000457 State = FreeMemAux(C, CE, C.getState(), 0, false);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000458 } else if (FunI == II_strdup) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000459 State = MallocUpdateRefState(C, CE, State);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000460 } else if (FunI == II_strndup) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000461 State = MallocUpdateRefState(C, CE, State);
462 } else if (Filter.CMallocOptimistic) {
463 // Check all the attributes, if there are any.
464 // There can be multiple of these attributes.
465 if (FD->hasAttrs())
466 for (specific_attr_iterator<OwnershipAttr>
467 i = FD->specific_attr_begin<OwnershipAttr>(),
468 e = FD->specific_attr_end<OwnershipAttr>();
469 i != e; ++i) {
470 switch ((*i)->getOwnKind()) {
471 case OwnershipAttr::Returns:
472 State = MallocMemReturnsAttr(C, CE, *i);
473 break;
474 case OwnershipAttr::Takes:
475 case OwnershipAttr::Holds:
476 State = FreeMemAttr(C, CE, *i);
477 break;
478 }
479 }
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000480 }
Anna Zaks60a1fa42012-02-22 03:14:20 +0000481 C.addTransition(State);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000482}
483
Jordan Rose740d4902012-07-02 19:27:35 +0000484static bool isFreeWhenDoneSetToZero(const ObjCMessageInvocation &Call,
485 Selector &S) {
Anna Zaks3e4f65d2012-06-22 22:08:09 +0000486 for (unsigned i = 1; i < S.getNumArgs(); ++i)
Anna Zaks5b7aa342012-06-22 02:04:31 +0000487 if (S.getNameForSlot(i).equals("freeWhenDone"))
488 if (Call.getArgSVal(i).isConstant(0))
489 return true;
490
491 return false;
492}
493
494void MallocChecker::checkPreObjCMessage(const ObjCMessage &Msg,
Jordan Rose740d4902012-07-02 19:27:35 +0000495 CheckerContext &C) const {
Anna Zaks5b7aa342012-06-22 02:04:31 +0000496 const ObjCMethodDecl *MD = Msg.getMethodDecl();
497 if (!MD)
498 return;
499
Jordan Rose740d4902012-07-02 19:27:35 +0000500 ObjCMessageInvocation Call(Msg, C.getState(), C.getLocationContext());
Anna Zaks5b7aa342012-06-22 02:04:31 +0000501 Selector S = Msg.getSelector();
502
503 // If the first selector is dataWithBytesNoCopy, assume that the memory will
504 // be released with 'free' by the new object.
505 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
506 // Unless 'freeWhenDone' param set to 0.
507 // TODO: Check that the memory was allocated with malloc.
Anna Zaks7186dc62012-06-22 22:42:30 +0000508 if ((S.getNameForSlot(0) == "dataWithBytesNoCopy" ||
509 S.getNameForSlot(0) == "initWithBytesNoCopy" ||
510 S.getNameForSlot(0) == "initWithCharactersNoCopy") &&
Anna Zaks5b7aa342012-06-22 02:04:31 +0000511 !isFreeWhenDoneSetToZero(Call, S)){
512 unsigned int argIdx = 0;
Jordan Rose740d4902012-07-02 19:27:35 +0000513 C.addTransition(FreeMemAux(C, Call.getArgExpr(argIdx),
Anna Zaks5b7aa342012-06-22 02:04:31 +0000514 Msg.getMessageExpr(), C.getState(), true));
515 }
516}
517
Anna Zaks87cb5be2012-02-22 19:24:52 +0000518ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C,
519 const CallExpr *CE,
520 const OwnershipAttr* Att) {
Sean Huntcf807c42010-08-18 23:23:40 +0000521 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000522 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000523
Sean Huntcf807c42010-08-18 23:23:40 +0000524 OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000525 if (I != E) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000526 return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000527 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000528 return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000529}
530
Anna Zaksb319e022012-02-08 20:13:28 +0000531ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000532 const CallExpr *CE,
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000533 SVal Size, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000534 ProgramStateRef state) {
Anna Zakse17fdb22012-06-07 03:57:32 +0000535
536 // Bind the return value to the symbolic value from the heap region.
537 // TODO: We could rewrite post visit to eval call; 'malloc' does not have
538 // side effects other than what we model here.
539 unsigned Count = C.getCurrentBlockCount();
540 SValBuilder &svalBuilder = C.getSValBuilder();
541 const LocationContext *LCtx = C.getPredecessor()->getLocationContext();
542 DefinedSVal RetVal =
543 cast<DefinedSVal>(svalBuilder.getConjuredHeapSymbolVal(CE, LCtx, Count));
544 state = state->BindExpr(CE, C.getLocationContext(), RetVal);
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000545
Anna Zaksb16ce452012-02-15 00:11:22 +0000546 // We expect the malloc functions to return a pointer.
Anna Zakse17fdb22012-06-07 03:57:32 +0000547 if (!isa<Loc>(RetVal))
Anna Zaksb16ce452012-02-15 00:11:22 +0000548 return 0;
549
Jordy Rose32f26562010-07-04 00:00:41 +0000550 // Fill the region with the initialization value.
Anna Zakse17fdb22012-06-07 03:57:32 +0000551 state = state->bindDefault(RetVal, Init);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000552
Jordy Rose32f26562010-07-04 00:00:41 +0000553 // Set the region's extent equal to the Size parameter.
Anna Zakse9ef5622012-02-10 01:11:00 +0000554 const SymbolicRegion *R =
Anna Zakse17fdb22012-06-07 03:57:32 +0000555 dyn_cast_or_null<SymbolicRegion>(RetVal.getAsRegion());
Anna Zaks60a1fa42012-02-22 03:14:20 +0000556 if (!R)
Anna Zakse9ef5622012-02-10 01:11:00 +0000557 return 0;
Anna Zaks60a1fa42012-02-22 03:14:20 +0000558 if (isa<DefinedOrUnknownSVal>(Size)) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000559 SValBuilder &svalBuilder = C.getSValBuilder();
Anna Zaks60a1fa42012-02-22 03:14:20 +0000560 DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder);
561 DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size);
562 DefinedOrUnknownSVal extentMatchesSize =
563 svalBuilder.evalEQ(state, Extent, DefinedSize);
Anna Zakse9ef5622012-02-10 01:11:00 +0000564
Anna Zaks60a1fa42012-02-22 03:14:20 +0000565 state = state->assume(extentMatchesSize, true);
566 assert(state);
567 }
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000568
Anna Zaks87cb5be2012-02-22 19:24:52 +0000569 return MallocUpdateRefState(C, CE, state);
570}
571
572ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C,
573 const CallExpr *CE,
574 ProgramStateRef state) {
575 // Get the return value.
576 SVal retVal = state->getSVal(CE, C.getLocationContext());
577
578 // We expect the malloc functions to return a pointer.
579 if (!isa<Loc>(retVal))
580 return 0;
581
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000582 SymbolRef Sym = retVal.getAsLocSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000583 assert(Sym);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000584
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000585 // Set the symbol's state to Allocated.
Anna Zaks050cdd72012-06-20 20:57:46 +0000586 return state->set<RegionState>(Sym, RefState::getAllocated(CE));
Anna Zaks87cb5be2012-02-22 19:24:52 +0000587
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000588}
589
Anna Zaks87cb5be2012-02-22 19:24:52 +0000590ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C,
591 const CallExpr *CE,
592 const OwnershipAttr* Att) const {
Sean Huntcf807c42010-08-18 23:23:40 +0000593 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000594 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000595
Anna Zaksb3d72752012-03-01 22:06:06 +0000596 ProgramStateRef State = C.getState();
597
Sean Huntcf807c42010-08-18 23:23:40 +0000598 for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
599 I != E; ++I) {
Anna Zaksb3d72752012-03-01 22:06:06 +0000600 ProgramStateRef StateI = FreeMemAux(C, CE, State, *I,
601 Att->getOwnKind() == OwnershipAttr::Holds);
602 if (StateI)
603 State = StateI;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000604 }
Anna Zaksb3d72752012-03-01 22:06:06 +0000605 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000606}
607
Ted Kremenek8bef8232012-01-26 21:29:00 +0000608ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
Anna Zakse9ef5622012-02-10 01:11:00 +0000609 const CallExpr *CE,
610 ProgramStateRef state,
611 unsigned Num,
612 bool Hold) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000613 if (CE->getNumArgs() < (Num + 1))
614 return 0;
615
Anna Zaks5b7aa342012-06-22 02:04:31 +0000616 return FreeMemAux(C, CE->getArg(Num), CE, state, Hold);
617}
618
619ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
620 const Expr *ArgExpr,
621 const Expr *ParentExpr,
622 ProgramStateRef state,
623 bool Hold) const {
624
Ted Kremenek5eca4822012-01-06 22:09:28 +0000625 SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext());
Anna Zakse9ef5622012-02-10 01:11:00 +0000626 if (!isa<DefinedOrUnknownSVal>(ArgVal))
627 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000628 DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal);
629
630 // Check for null dereferences.
631 if (!isa<Loc>(location))
Anna Zaksb319e022012-02-08 20:13:28 +0000632 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000633
Anna Zaksb276bd92012-02-14 00:26:13 +0000634 // The explicit NULL case, no operation is performed.
Ted Kremenek8bef8232012-01-26 21:29:00 +0000635 ProgramStateRef notNullState, nullState;
Ted Kremenek28f47b92010-12-01 22:16:56 +0000636 llvm::tie(notNullState, nullState) = state->assume(location);
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000637 if (nullState && !notNullState)
Anna Zaksb319e022012-02-08 20:13:28 +0000638 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000639
Jordy Rose43859f62010-06-07 19:32:37 +0000640 // Unknown values could easily be okay
641 // Undefined values are handled elsewhere
642 if (ArgVal.isUnknownOrUndef())
Anna Zaksb319e022012-02-08 20:13:28 +0000643 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000644
Jordy Rose43859f62010-06-07 19:32:37 +0000645 const MemRegion *R = ArgVal.getAsRegion();
646
647 // Nonlocs can't be freed, of course.
648 // Non-region locations (labels and fixed addresses) also shouldn't be freed.
649 if (!R) {
650 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000651 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000652 }
653
654 R = R->StripCasts();
655
656 // Blocks might show up as heap data, but should not be free()d
657 if (isa<BlockDataRegion>(R)) {
658 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000659 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000660 }
661
662 const MemSpaceRegion *MS = R->getMemorySpace();
663
664 // Parameters, locals, statics, and globals shouldn't be freed.
665 if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) {
666 // FIXME: at the time this code was written, malloc() regions were
667 // represented by conjured symbols, which are all in UnknownSpaceRegion.
668 // This means that there isn't actually anything from HeapSpaceRegion
669 // that should be freed, even though we allow it here.
670 // Of course, free() can work on memory allocated outside the current
671 // function, so UnknownSpaceRegion is always a possibility.
672 // False negatives are better than false positives.
673
674 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000675 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000676 }
677
678 const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R);
679 // Various cases could lead to non-symbol values here.
680 // For now, ignore them.
681 if (!SR)
Anna Zaksb319e022012-02-08 20:13:28 +0000682 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000683
684 SymbolRef Sym = SR->getSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000685 const RefState *RS = state->get<RegionState>(Sym);
Zhongxing Xu7e3cda92010-01-18 03:27:34 +0000686
687 // If the symbol has not been tracked, return. This is possible when free() is
688 // called on a pointer that does not get its pointee directly from malloc().
689 // Full support of this requires inter-procedural analysis.
690 if (!RS)
Anna Zaksb319e022012-02-08 20:13:28 +0000691 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000692
693 // Check double free.
Anna Zaks050cdd72012-06-20 20:57:46 +0000694 if (RS->isReleased() || RS->isRelinquished()) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000695 if (ExplodedNode *N = C.generateSink()) {
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000696 if (!BT_DoubleFree)
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000697 BT_DoubleFree.reset(
Anna Zaksfebdc322012-02-16 22:26:12 +0000698 new BugType("Double free", "Memory Error"));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000699 BugReport *R = new BugReport(*BT_DoubleFree,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000700 (RS->isReleased() ? "Attempt to free released memory" :
701 "Attempt to free non-owned memory"), N);
Anna Zaksfe571602012-02-16 22:26:07 +0000702 R->addRange(ArgExpr->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +0000703 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000704 R->addVisitor(new MallocBugVisitor(Sym));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000705 C.EmitReport(R);
706 }
Anna Zaksb319e022012-02-08 20:13:28 +0000707 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000708 }
709
710 // Normal free.
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000711 if (Hold)
Anna Zaks5b7aa342012-06-22 02:04:31 +0000712 return state->set<RegionState>(Sym, RefState::getRelinquished(ParentExpr));
713 return state->set<RegionState>(Sym, RefState::getReleased(ParentExpr));
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000714}
715
Ted Kremenek9c378f72011-08-12 23:37:29 +0000716bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {
Jordy Rose43859f62010-06-07 19:32:37 +0000717 if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V))
718 os << "an integer (" << IntVal->getValue() << ")";
719 else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V))
720 os << "a constant address (" << ConstAddr->getValue() << ")";
721 else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V))
Chris Lattner68106302011-02-17 05:38:27 +0000722 os << "the address of the label '" << Label->getLabel()->getName() << "'";
Jordy Rose43859f62010-06-07 19:32:37 +0000723 else
724 return false;
725
726 return true;
727}
728
Ted Kremenek9c378f72011-08-12 23:37:29 +0000729bool MallocChecker::SummarizeRegion(raw_ostream &os,
Jordy Rose43859f62010-06-07 19:32:37 +0000730 const MemRegion *MR) {
731 switch (MR->getKind()) {
732 case MemRegion::FunctionTextRegionKind: {
733 const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl();
734 if (FD)
Benjamin Kramerb8989f22011-10-14 18:45:37 +0000735 os << "the address of the function '" << *FD << '\'';
Jordy Rose43859f62010-06-07 19:32:37 +0000736 else
737 os << "the address of a function";
738 return true;
739 }
740 case MemRegion::BlockTextRegionKind:
741 os << "block text";
742 return true;
743 case MemRegion::BlockDataRegionKind:
744 // FIXME: where the block came from?
745 os << "a block";
746 return true;
747 default: {
748 const MemSpaceRegion *MS = MR->getMemorySpace();
749
Anna Zakseb31a762012-01-04 23:54:01 +0000750 if (isa<StackLocalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000751 const VarRegion *VR = dyn_cast<VarRegion>(MR);
752 const VarDecl *VD;
753 if (VR)
754 VD = VR->getDecl();
755 else
756 VD = NULL;
757
758 if (VD)
759 os << "the address of the local variable '" << VD->getName() << "'";
760 else
761 os << "the address of a local stack variable";
762 return true;
763 }
Anna Zakseb31a762012-01-04 23:54:01 +0000764
765 if (isa<StackArgumentsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000766 const VarRegion *VR = dyn_cast<VarRegion>(MR);
767 const VarDecl *VD;
768 if (VR)
769 VD = VR->getDecl();
770 else
771 VD = NULL;
772
773 if (VD)
774 os << "the address of the parameter '" << VD->getName() << "'";
775 else
776 os << "the address of a parameter";
777 return true;
778 }
Anna Zakseb31a762012-01-04 23:54:01 +0000779
780 if (isa<GlobalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000781 const VarRegion *VR = dyn_cast<VarRegion>(MR);
782 const VarDecl *VD;
783 if (VR)
784 VD = VR->getDecl();
785 else
786 VD = NULL;
787
788 if (VD) {
789 if (VD->isStaticLocal())
790 os << "the address of the static variable '" << VD->getName() << "'";
791 else
792 os << "the address of the global variable '" << VD->getName() << "'";
793 } else
794 os << "the address of a global variable";
795 return true;
796 }
Anna Zakseb31a762012-01-04 23:54:01 +0000797
798 return false;
Jordy Rose43859f62010-06-07 19:32:37 +0000799 }
800 }
801}
802
803void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000804 SourceRange range) const {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000805 if (ExplodedNode *N = C.generateSink()) {
Jordy Rose43859f62010-06-07 19:32:37 +0000806 if (!BT_BadFree)
Anna Zaksfebdc322012-02-16 22:26:12 +0000807 BT_BadFree.reset(new BugType("Bad free", "Memory Error"));
Jordy Rose43859f62010-06-07 19:32:37 +0000808
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000809 SmallString<100> buf;
Jordy Rose43859f62010-06-07 19:32:37 +0000810 llvm::raw_svector_ostream os(buf);
811
812 const MemRegion *MR = ArgVal.getAsRegion();
813 if (MR) {
814 while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR))
815 MR = ER->getSuperRegion();
816
817 // Special case for alloca()
818 if (isa<AllocaRegion>(MR))
819 os << "Argument to free() was allocated by alloca(), not malloc()";
820 else {
821 os << "Argument to free() is ";
822 if (SummarizeRegion(os, MR))
823 os << ", which is not memory allocated by malloc()";
824 else
825 os << "not memory allocated by malloc()";
826 }
827 } else {
828 os << "Argument to free() is ";
829 if (SummarizeValue(os, ArgVal))
830 os << ", which is not memory allocated by malloc()";
831 else
832 os << "not memory allocated by malloc()";
833 }
834
Anna Zakse172e8b2011-08-17 23:00:25 +0000835 BugReport *R = new BugReport(*BT_BadFree, os.str(), N);
Ted Kremenek76aadc32012-03-09 01:13:14 +0000836 R->markInteresting(MR);
Jordy Rose43859f62010-06-07 19:32:37 +0000837 R->addRange(range);
838 C.EmitReport(R);
839 }
840}
841
Anna Zaks87cb5be2012-02-22 19:24:52 +0000842ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C,
843 const CallExpr *CE,
844 bool FreesOnFail) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000845 if (CE->getNumArgs() < 2)
846 return 0;
847
Ted Kremenek8bef8232012-01-26 21:29:00 +0000848 ProgramStateRef state = C.getState();
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000849 const Expr *arg0Expr = CE->getArg(0);
Ted Kremenek5eca4822012-01-06 22:09:28 +0000850 const LocationContext *LCtx = C.getLocationContext();
Anna Zakse9ef5622012-02-10 01:11:00 +0000851 SVal Arg0Val = state->getSVal(arg0Expr, LCtx);
852 if (!isa<DefinedOrUnknownSVal>(Arg0Val))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000853 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000854 DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000855
Ted Kremenek846eabd2010-12-01 21:28:31 +0000856 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000857
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000858 DefinedOrUnknownSVal PtrEQ =
859 svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull());
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000860
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000861 // Get the size argument. If there is no size arg then give up.
862 const Expr *Arg1 = CE->getArg(1);
863 if (!Arg1)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000864 return 0;
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000865
866 // Get the value of the size argument.
Anna Zakse9ef5622012-02-10 01:11:00 +0000867 SVal Arg1ValG = state->getSVal(Arg1, LCtx);
868 if (!isa<DefinedOrUnknownSVal>(Arg1ValG))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000869 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000870 DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG);
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000871
872 // Compare the size argument to 0.
873 DefinedOrUnknownSVal SizeZero =
874 svalBuilder.evalEQ(state, Arg1Val,
875 svalBuilder.makeIntValWithPtrWidth(0, false));
876
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000877 ProgramStateRef StatePtrIsNull, StatePtrNotNull;
878 llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ);
879 ProgramStateRef StateSizeIsZero, StateSizeNotZero;
880 llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero);
881 // We only assume exceptional states if they are definitely true; if the
882 // state is under-constrained, assume regular realloc behavior.
883 bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull;
884 bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero;
885
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000886 // If the ptr is NULL and the size is not 0, the call is equivalent to
887 // malloc(size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000888 if ( PrtIsNull && !SizeIsZero) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000889 ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1),
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000890 UndefinedVal(), StatePtrIsNull);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000891 return stateMalloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000892 }
893
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000894 if (PrtIsNull && SizeIsZero)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000895 return 0;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000896
Anna Zaks30838b92012-02-13 20:57:07 +0000897 // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000898 assert(!PrtIsNull);
Anna Zaks30838b92012-02-13 20:57:07 +0000899 SymbolRef FromPtr = arg0Val.getAsSymbol();
900 SVal RetVal = state->getSVal(CE, LCtx);
901 SymbolRef ToPtr = RetVal.getAsSymbol();
902 if (!FromPtr || !ToPtr)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000903 return 0;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000904
905 // If the size is 0, free the memory.
906 if (SizeIsZero)
907 if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero,0,false)){
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000908 // The semantics of the return value are:
909 // If size was equal to 0, either NULL or a pointer suitable to be passed
910 // to free() is returned.
Anna Zaks40add292012-02-15 00:11:25 +0000911 stateFree = stateFree->set<ReallocPairs>(ToPtr,
912 ReallocPair(FromPtr, FreesOnFail));
Anna Zaksb276bd92012-02-14 00:26:13 +0000913 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000914 return stateFree;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000915 }
916
917 // Default behavior.
918 if (ProgramStateRef stateFree = FreeMemAux(C, CE, state, 0, false)) {
919 // FIXME: We should copy the content of the original buffer.
920 ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1),
921 UnknownVal(), stateFree);
Anna Zaks30838b92012-02-13 20:57:07 +0000922 if (!stateRealloc)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000923 return 0;
Anna Zaks40add292012-02-15 00:11:25 +0000924 stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr,
925 ReallocPair(FromPtr, FreesOnFail));
Anna Zaksb276bd92012-02-14 00:26:13 +0000926 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000927 return stateRealloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000928 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000929 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000930}
Zhongxing Xu7b760962009-11-13 07:25:27 +0000931
Anna Zaks87cb5be2012-02-22 19:24:52 +0000932ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){
Anna Zaks259052d2012-04-10 23:41:11 +0000933 if (CE->getNumArgs() < 2)
934 return 0;
935
Ted Kremenek8bef8232012-01-26 21:29:00 +0000936 ProgramStateRef state = C.getState();
Ted Kremenek846eabd2010-12-01 21:28:31 +0000937 SValBuilder &svalBuilder = C.getSValBuilder();
Ted Kremenek5eca4822012-01-06 22:09:28 +0000938 const LocationContext *LCtx = C.getLocationContext();
939 SVal count = state->getSVal(CE->getArg(0), LCtx);
940 SVal elementSize = state->getSVal(CE->getArg(1), LCtx);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000941 SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize,
942 svalBuilder.getContext().getSizeType());
943 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000944
Anna Zaks87cb5be2012-02-22 19:24:52 +0000945 return MallocMemAux(C, CE, TotalSize, zeroVal, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000946}
947
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000948LeakInfo
Anna Zaksca8e36e2012-02-23 21:38:21 +0000949MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
950 CheckerContext &C) const {
Anna Zaks7752d292012-02-27 23:40:55 +0000951 const LocationContext *LeakContext = N->getLocationContext();
Anna Zaksca8e36e2012-02-23 21:38:21 +0000952 // Walk the ExplodedGraph backwards and find the first node that referred to
953 // the tracked symbol.
954 const ExplodedNode *AllocNode = N;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000955 const MemRegion *ReferenceRegion = 0;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000956
957 while (N) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000958 ProgramStateRef State = N->getState();
959 if (!State->get<RegionState>(Sym))
Anna Zaksca8e36e2012-02-23 21:38:21 +0000960 break;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000961
962 // Find the most recent expression bound to the symbol in the current
963 // context.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000964 if (!ReferenceRegion) {
Benjamin Kramer850f1b12012-03-21 21:03:48 +0000965 if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) {
966 SVal Val = State->getSVal(MR);
967 if (Val.getAsLocSymbol() == Sym)
968 ReferenceRegion = MR;
969 }
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000970 }
971
Anna Zaks7752d292012-02-27 23:40:55 +0000972 // Allocation node, is the last node in the current context in which the
973 // symbol was tracked.
974 if (N->getLocationContext() == LeakContext)
975 AllocNode = N;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000976 N = N->pred_empty() ? NULL : *(N->pred_begin());
977 }
978
979 ProgramPoint P = AllocNode->getLocation();
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000980 const Stmt *AllocationStmt = 0;
981 if (isa<StmtPoint>(P))
982 AllocationStmt = cast<StmtPoint>(P).getStmt();
Anna Zaks7752d292012-02-27 23:40:55 +0000983
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000984 return LeakInfo(AllocationStmt, ReferenceRegion);
Anna Zaksca8e36e2012-02-23 21:38:21 +0000985}
986
Anna Zaksda046772012-02-11 21:02:40 +0000987void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N,
988 CheckerContext &C) const {
989 assert(N);
990 if (!BT_Leak) {
Anna Zaksfebdc322012-02-16 22:26:12 +0000991 BT_Leak.reset(new BugType("Memory leak", "Memory Error"));
Anna Zaksda046772012-02-11 21:02:40 +0000992 // Leaks should not be reported if they are post-dominated by a sink:
993 // (1) Sinks are higher importance bugs.
994 // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending
995 // with __noreturn functions such as assert() or exit(). We choose not
996 // to report leaks on such paths.
997 BT_Leak->setSuppressOnSink(true);
998 }
999
Anna Zaksca8e36e2012-02-23 21:38:21 +00001000 // Most bug reports are cached at the location where they occurred.
1001 // With leaks, we want to unique them by the location where they were
1002 // allocated, and only report a single path.
Anna Zaks7752d292012-02-27 23:40:55 +00001003 PathDiagnosticLocation LocUsedForUniqueing;
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001004 const Stmt *AllocStmt = 0;
1005 const MemRegion *Region = 0;
1006 llvm::tie(AllocStmt, Region) = getAllocationSite(N, Sym, C);
1007 if (AllocStmt)
Anna Zaks7752d292012-02-27 23:40:55 +00001008 LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocStmt,
1009 C.getSourceManager(), N->getLocationContext());
Anna Zaksca8e36e2012-02-23 21:38:21 +00001010
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001011 SmallString<200> buf;
1012 llvm::raw_svector_ostream os(buf);
1013 os << "Memory is never released; potential leak";
1014 if (Region) {
1015 os << " of memory pointed to by '";
1016 Region->dumpPretty(os);
1017 os <<'\'';
1018 }
1019
1020 BugReport *R = new BugReport(*BT_Leak, os.str(), N, LocUsedForUniqueing);
Ted Kremenek76aadc32012-03-09 01:13:14 +00001021 R->markInteresting(Sym);
Anna Zaks88feba02012-05-10 01:37:40 +00001022 R->addVisitor(new MallocBugVisitor(Sym, true));
Anna Zaksda046772012-02-11 21:02:40 +00001023 C.EmitReport(R);
1024}
1025
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001026void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper,
1027 CheckerContext &C) const
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001028{
Zhongxing Xu173ff562010-08-15 08:19:57 +00001029 if (!SymReaper.hasDeadSymbols())
1030 return;
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001031
Ted Kremenek8bef8232012-01-26 21:29:00 +00001032 ProgramStateRef state = C.getState();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001033 RegionStateTy RS = state->get<RegionState>();
Jordy Rose90760142010-08-18 04:33:47 +00001034 RegionStateTy::Factory &F = state->get_context<RegionState>();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001035
Ted Kremenek217470e2011-07-28 23:07:51 +00001036 bool generateReport = false;
Anna Zaksf8c17b72012-02-09 06:48:19 +00001037 llvm::SmallVector<SymbolRef, 2> Errors;
Zhongxing Xu173ff562010-08-15 08:19:57 +00001038 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
1039 if (SymReaper.isDead(I->first)) {
Anna Zaksf8c17b72012-02-09 06:48:19 +00001040 if (I->second.isAllocated()) {
Ted Kremenek217470e2011-07-28 23:07:51 +00001041 generateReport = true;
Anna Zaksf8c17b72012-02-09 06:48:19 +00001042 Errors.push_back(I->first);
1043 }
Jordy Rose90760142010-08-18 04:33:47 +00001044 // Remove the dead symbol from the map.
Ted Kremenek3baf6722010-11-24 00:54:37 +00001045 RS = F.remove(RS, I->first);
Ted Kremenek217470e2011-07-28 23:07:51 +00001046
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001047 }
1048 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001049
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001050 // Cleanup the Realloc Pairs Map.
Anna Zaks40add292012-02-15 00:11:25 +00001051 ReallocMap RP = state->get<ReallocPairs>();
1052 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
1053 if (SymReaper.isDead(I->first) ||
1054 SymReaper.isDead(I->second.ReallocatedSym)) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001055 state = state->remove<ReallocPairs>(I->first);
1056 }
1057 }
1058
Anna Zaksca8e36e2012-02-23 21:38:21 +00001059 // Generate leak node.
1060 static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak");
1061 ExplodedNode *N = C.addTransition(C.getState(), C.getPredecessor(), &Tag);
Ted Kremenek217470e2011-07-28 23:07:51 +00001062
Anna Zaksca8e36e2012-02-23 21:38:21 +00001063 if (generateReport) {
Anna Zaksf8c17b72012-02-09 06:48:19 +00001064 for (llvm::SmallVector<SymbolRef, 2>::iterator
Anna Zaksda046772012-02-11 21:02:40 +00001065 I = Errors.begin(), E = Errors.end(); I != E; ++I) {
1066 reportLeak(*I, N, C);
Anna Zaksf8c17b72012-02-09 06:48:19 +00001067 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001068 }
Anna Zaksca8e36e2012-02-23 21:38:21 +00001069 C.addTransition(state->set<RegionState>(RS), N);
Zhongxing Xu7b760962009-11-13 07:25:27 +00001070}
Zhongxing Xu243fde92009-11-17 07:54:15 +00001071
Anna Zaksda046772012-02-11 21:02:40 +00001072void MallocChecker::checkEndPath(CheckerContext &C) const {
1073 ProgramStateRef state = C.getState();
Jordy Rose09cef092010-08-18 04:26:59 +00001074 RegionStateTy M = state->get<RegionState>();
Zhongxing Xu243fde92009-11-17 07:54:15 +00001075
Anna Zaksa19581a2012-02-20 22:25:23 +00001076 // If inside inlined call, skip it.
1077 if (C.getLocationContext()->getParent() != 0)
1078 return;
1079
Jordy Rose09cef092010-08-18 04:26:59 +00001080 for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) {
Zhongxing Xu243fde92009-11-17 07:54:15 +00001081 RefState RS = I->second;
1082 if (RS.isAllocated()) {
Anna Zaksda046772012-02-11 21:02:40 +00001083 ExplodedNode *N = C.addTransition(state);
1084 if (N)
1085 reportLeak(I->first, N, C);
Zhongxing Xu243fde92009-11-17 07:54:15 +00001086 }
1087 }
1088}
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001089
Anna Zaks91c2a112012-02-08 23:16:56 +00001090bool MallocChecker::checkEscape(SymbolRef Sym, const Stmt *S,
1091 CheckerContext &C) const {
Ted Kremenek8bef8232012-01-26 21:29:00 +00001092 ProgramStateRef state = C.getState();
Anna Zaks91c2a112012-02-08 23:16:56 +00001093 const RefState *RS = state->get<RegionState>(Sym);
1094 if (!RS)
1095 return false;
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001096
Anna Zaks91c2a112012-02-08 23:16:56 +00001097 if (RS->isAllocated()) {
1098 state = state->set<RegionState>(Sym, RefState::getEscaped(S));
1099 C.addTransition(state);
1100 return true;
1101 }
1102 return false;
1103}
1104
Anna Zaks66c40402012-02-14 21:55:24 +00001105void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +00001106 // We will check for double free in the post visit.
1107 if (isFreeFunction(C.getCalleeDecl(CE), C.getASTContext()))
Anna Zaks66c40402012-02-14 21:55:24 +00001108 return;
1109
1110 // Check use after free, when a freed pointer is passed to a call.
1111 ProgramStateRef State = C.getState();
1112 for (CallExpr::const_arg_iterator I = CE->arg_begin(),
1113 E = CE->arg_end(); I != E; ++I) {
1114 const Expr *A = *I;
1115 if (A->getType().getTypePtr()->isAnyPointerType()) {
1116 SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol();
1117 if (!Sym)
1118 continue;
1119 if (checkUseAfterFree(Sym, C, A))
1120 return;
1121 }
1122 }
1123}
1124
Anna Zaks91c2a112012-02-08 23:16:56 +00001125void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const {
1126 const Expr *E = S->getRetValue();
1127 if (!E)
1128 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001129
1130 // Check if we are returning a symbol.
Anna Zaksd9ab7bb2012-02-22 02:36:01 +00001131 SVal RetVal = C.getState()->getSVal(E, C.getLocationContext());
1132 SymbolRef Sym = RetVal.getAsSymbol();
1133 if (!Sym)
1134 // If we are returning a field of the allocated struct or an array element,
1135 // the callee could still free the memory.
1136 // TODO: This logic should be a part of generic symbol escape callback.
1137 if (const MemRegion *MR = RetVal.getAsRegion())
1138 if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR))
1139 if (const SymbolicRegion *BMR =
1140 dyn_cast<SymbolicRegion>(MR->getBaseRegion()))
1141 Sym = BMR->getSymbol();
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001142 if (!Sym)
1143 return;
1144
Anna Zaks0860cd02012-02-11 21:44:39 +00001145 // Check if we are returning freed memory.
Anna Zaksfe571602012-02-16 22:26:07 +00001146 if (checkUseAfterFree(Sym, C, E))
Anna Zaks15d0ae12012-02-11 23:46:36 +00001147 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001148
Anna Zaksa19581a2012-02-20 22:25:23 +00001149 // If this function body is not inlined, check if the symbol is escaping.
1150 if (C.getLocationContext()->getParent() == 0)
1151 checkEscape(Sym, E, C);
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001152}
Zhongxing Xub94b81a2009-12-31 06:13:07 +00001153
Anna Zaksf5aa3f52012-03-22 00:57:20 +00001154// TODO: Blocks should be either inlined or should call invalidate regions
1155// upon invocation. After that's in place, special casing here will not be
1156// needed.
1157void MallocChecker::checkPostStmt(const BlockExpr *BE,
1158 CheckerContext &C) const {
1159
1160 // Scan the BlockDecRefExprs for any object the retain count checker
1161 // may be tracking.
1162 if (!BE->getBlockDecl()->hasCaptures())
1163 return;
1164
1165 ProgramStateRef state = C.getState();
1166 const BlockDataRegion *R =
1167 cast<BlockDataRegion>(state->getSVal(BE,
1168 C.getLocationContext()).getAsRegion());
1169
1170 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
1171 E = R->referenced_vars_end();
1172
1173 if (I == E)
1174 return;
1175
1176 SmallVector<const MemRegion*, 10> Regions;
1177 const LocationContext *LC = C.getLocationContext();
1178 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
1179
1180 for ( ; I != E; ++I) {
1181 const VarRegion *VR = *I;
1182 if (VR->getSuperRegion() == R) {
1183 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
1184 }
1185 Regions.push_back(VR);
1186 }
1187
1188 state =
1189 state->scanReachableSymbols<StopTrackingCallback>(Regions.data(),
1190 Regions.data() + Regions.size()).getState();
1191 C.addTransition(state);
1192}
1193
Anna Zaks14345182012-05-18 01:16:10 +00001194bool MallocChecker::isReleased(SymbolRef Sym, CheckerContext &C) const {
Anna Zaks91c2a112012-02-08 23:16:56 +00001195 assert(Sym);
1196 const RefState *RS = C.getState()->get<RegionState>(Sym);
Anna Zaks14345182012-05-18 01:16:10 +00001197 return (RS && RS->isReleased());
1198}
1199
1200bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
1201 const Stmt *S) const {
1202 if (isReleased(Sym, C)) {
Anna Zaks15d0ae12012-02-11 23:46:36 +00001203 if (ExplodedNode *N = C.generateSink()) {
Anna Zaks91c2a112012-02-08 23:16:56 +00001204 if (!BT_UseFree)
Anna Zaksfebdc322012-02-16 22:26:12 +00001205 BT_UseFree.reset(new BugType("Use-after-free", "Memory Error"));
Anna Zaks91c2a112012-02-08 23:16:56 +00001206
Anna Zaksfebdc322012-02-16 22:26:12 +00001207 BugReport *R = new BugReport(*BT_UseFree,
1208 "Use of memory after it is freed",N);
Anna Zaks91c2a112012-02-08 23:16:56 +00001209 if (S)
1210 R->addRange(S->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +00001211 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001212 R->addVisitor(new MallocBugVisitor(Sym));
Anna Zaks91c2a112012-02-08 23:16:56 +00001213 C.EmitReport(R);
1214 return true;
1215 }
1216 }
1217 return false;
1218}
1219
Zhongxing Xuc8023782010-03-10 04:58:55 +00001220// Check if the location is a freed symbolic region.
Anna Zaks390909c2011-10-06 00:43:15 +00001221void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S,
1222 CheckerContext &C) const {
Zhongxing Xuc8023782010-03-10 04:58:55 +00001223 SymbolRef Sym = l.getLocSymbolInBase();
Anna Zaks91c2a112012-02-08 23:16:56 +00001224 if (Sym)
Anna Zaks14345182012-05-18 01:16:10 +00001225 checkUseAfterFree(Sym, C, S);
Zhongxing Xuc8023782010-03-10 04:58:55 +00001226}
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001227
Anna Zaks4fb54872012-02-11 21:02:35 +00001228//===----------------------------------------------------------------------===//
1229// Check various ways a symbol can be invalidated.
1230// TODO: This logic (the next 3 functions) is copied/similar to the
1231// RetainRelease checker. We might want to factor this out.
1232//===----------------------------------------------------------------------===//
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001233
Anna Zaks4fb54872012-02-11 21:02:35 +00001234// Stop tracking symbols when a value escapes as a result of checkBind.
1235// A value escapes in three possible cases:
1236// (1) we are binding to something that is not a memory region.
1237// (2) we are binding to a memregion that does not have stack storage
1238// (3) we are binding to a memregion with stack storage that the store
1239// does not understand.
1240void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S,
1241 CheckerContext &C) const {
1242 // Are we storing to something that causes the value to "escape"?
1243 bool escapes = true;
Ted Kremenek8bef8232012-01-26 21:29:00 +00001244 ProgramStateRef state = C.getState();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001245
Anna Zaks4fb54872012-02-11 21:02:35 +00001246 if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) {
1247 escapes = !regionLoc->getRegion()->hasStackStorage();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001248
Anna Zaks4fb54872012-02-11 21:02:35 +00001249 if (!escapes) {
1250 // To test (3), generate a new state with the binding added. If it is
1251 // the same state, then it escapes (since the store cannot represent
1252 // the binding).
Anna Zaks93c5a242012-05-02 00:05:20 +00001253 // Do this only if we know that the store is not supposed to generate the
1254 // same state.
1255 SVal StoredVal = state->getSVal(regionLoc->getRegion());
1256 if (StoredVal != val)
1257 escapes = (state == (state->bindLoc(*regionLoc, val)));
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001258 }
Anna Zaksac593002012-02-16 03:40:57 +00001259 if (!escapes) {
1260 // Case 4: We do not currently model what happens when a symbol is
1261 // assigned to a struct field, so be conservative here and let the symbol
1262 // go. TODO: This could definitely be improved upon.
1263 escapes = !isa<VarRegion>(regionLoc->getRegion());
1264 }
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001265 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001266
1267 // If our store can represent the binding and we aren't storing to something
1268 // that doesn't have local storage then just return and have the simulation
1269 // state continue as is.
1270 if (!escapes)
1271 return;
1272
1273 // Otherwise, find all symbols referenced by 'val' that we are tracking
1274 // and stop tracking them.
1275 state = state->scanReachableSymbols<StopTrackingCallback>(val).getState();
1276 C.addTransition(state);
1277}
1278
1279// If a symbolic region is assumed to NULL (or another constant), stop tracking
1280// it - assuming that allocation failed on this path.
1281ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state,
1282 SVal Cond,
1283 bool Assumption) const {
1284 RegionStateTy RS = state->get<RegionState>();
Anna Zaks4fb54872012-02-11 21:02:35 +00001285 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
1286 // If the symbol is assumed to NULL or another constant, this will
1287 // return an APSInt*.
1288 if (state->getSymVal(I.getKey()))
1289 state = state->remove<RegionState>(I.getKey());
1290 }
1291
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001292 // Realloc returns 0 when reallocation fails, which means that we should
1293 // restore the state of the pointer being reallocated.
Anna Zaks40add292012-02-15 00:11:25 +00001294 ReallocMap RP = state->get<ReallocPairs>();
1295 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001296 // If the symbol is assumed to NULL or another constant, this will
1297 // return an APSInt*.
1298 if (state->getSymVal(I.getKey())) {
Anna Zaks40add292012-02-15 00:11:25 +00001299 SymbolRef ReallocSym = I.getData().ReallocatedSym;
1300 const RefState *RS = state->get<RegionState>(ReallocSym);
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001301 if (RS) {
Anna Zaks40add292012-02-15 00:11:25 +00001302 if (RS->isReleased() && ! I.getData().IsFreeOnFailure)
1303 state = state->set<RegionState>(ReallocSym,
Anna Zaks050cdd72012-06-20 20:57:46 +00001304 RefState::getAllocated(RS->getStmt()));
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001305 }
1306 state = state->remove<ReallocPairs>(I.getKey());
1307 }
1308 }
1309
Anna Zaks4fb54872012-02-11 21:02:35 +00001310 return state;
1311}
1312
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001313// Check if the function is known to us. So, for example, we could
Jordan Rose740d4902012-07-02 19:27:35 +00001314// conservatively assume it can free/reallocate its pointer arguments.
Anna Zaks66c40402012-02-14 21:55:24 +00001315// (We assume that the pointers cannot escape through calls to system
1316// functions not handled by this checker.)
Jordan Rose740d4902012-07-02 19:27:35 +00001317bool MallocChecker::doesNotFreeMemory(const CallEvent *Call,
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001318 ProgramStateRef State) const {
1319 if (!Call)
1320 return false;
1321
1322 // For now, assume that any C++ call can free memory.
1323 // TODO: If we want to be more optimistic here, we'll need to make sure that
1324 // regions escape to C++ containers. They seem to do that even now, but for
1325 // mysterious reasons.
Jordan Rose740d4902012-07-02 19:27:35 +00001326 if (!(isa<FunctionCall>(Call) || isa<ObjCMessageInvocation>(Call)))
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001327 return false;
1328
Jordan Rose740d4902012-07-02 19:27:35 +00001329 // If the call has a callback as an argument, assume the memory
1330 // can be freed.
1331 if (Call->hasNonZeroCallbackArg())
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001332 return false;
1333
Jordan Rose740d4902012-07-02 19:27:35 +00001334 // Check Objective-C messages by selector name.
1335 if (const ObjCMessageInvocation *Msg = dyn_cast<ObjCMessageInvocation>(Call)){
1336 // If it's not a framework call, assume it frees memory.
1337 if (!Call->isInSystemHeader())
Anna Zaks07d39a42012-02-28 01:54:22 +00001338 return false;
1339
Jordan Rose740d4902012-07-02 19:27:35 +00001340 Selector S = Msg->getSelector();
Anna Zaks52a04812012-06-20 23:35:57 +00001341
Jordan Rose740d4902012-07-02 19:27:35 +00001342 // Whitelist the ObjC methods which do free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001343 // - Anything containing 'freeWhenDone' param set to 1.
1344 // Ex: dataWithBytesNoCopy:length:freeWhenDone.
Anna Zaks3e4f65d2012-06-22 22:08:09 +00001345 for (unsigned i = 1; i < S.getNumArgs(); ++i) {
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001346 if (S.getNameForSlot(i).equals("freeWhenDone")) {
1347 if (Call->getArgSVal(i).isConstant(1))
1348 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001349 else
1350 return true;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001351 }
1352 }
1353
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001354 // If the first selector ends with NoCopy, assume that the ownership is
Benjamin Kramer48d798c2012-06-02 10:20:41 +00001355 // transferred as well.
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001356 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
Jordan Rose740d4902012-07-02 19:27:35 +00001357 StringRef FirstSlot = S.getNameForSlot(0);
1358 if (FirstSlot.endswith("NoCopy"))
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001359 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001360
Anna Zaks5f757682012-06-19 05:10:32 +00001361 // If the first selector starts with addPointer, insertPointer,
1362 // or replacePointer, assume we are dealing with NSPointerArray or similar.
1363 // This is similar to C++ containers (vector); we still might want to check
Jordan Rose740d4902012-07-02 19:27:35 +00001364 // that the pointers get freed by following the container itself.
1365 if (FirstSlot.startswith("addPointer") ||
1366 FirstSlot.startswith("insertPointer") ||
1367 FirstSlot.startswith("replacePointer")) {
Anna Zaks5f757682012-06-19 05:10:32 +00001368 return false;
1369 }
1370
Jordan Rose740d4902012-07-02 19:27:35 +00001371 // Otherwise, assume that the method does not free memory.
1372 // Most framework methods do not free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001373 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001374 }
1375
Jordan Rose740d4902012-07-02 19:27:35 +00001376 // At this point the only thing left to handle is straight function calls.
1377 const FunctionDecl *FD = cast<FunctionCall>(Call)->getDecl();
1378 if (!FD)
1379 return false;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001380
Jordan Rose740d4902012-07-02 19:27:35 +00001381 ASTContext &ASTC = State->getStateManager().getContext();
1382
1383 // If it's one of the allocation functions we can reason about, we model
1384 // its behavior explicitly.
1385 if (isMemFunction(FD, ASTC))
1386 return true;
1387
1388 // If it's not a system call, assume it frees memory.
1389 if (!Call->isInSystemHeader())
1390 return false;
1391
1392 // White list the system functions whose arguments escape.
1393 const IdentifierInfo *II = FD->getIdentifier();
1394 if (!II)
1395 return false;
1396 StringRef FName = II->getName();
1397
1398 // White list thread local storage.
1399 if (FName.equals("pthread_setspecific"))
1400 return false;
1401 if (FName.equals("xpc_connection_set_context"))
1402 return false;
1403
1404 // White list the 'XXXNoCopy' CoreFoundation functions.
1405 if (FName.endswith("NoCopy")) {
1406 // Look for the deallocator argument. We know that the memory ownership
1407 // is not transferred only if the deallocator argument is
1408 // 'kCFAllocatorNull'.
1409 for (unsigned i = 1; i < Call->getNumArgs(); ++i) {
1410 const Expr *ArgE = Call->getArgExpr(i)->IgnoreParenCasts();
1411 if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) {
1412 StringRef DeallocatorName = DE->getFoundDecl()->getName();
1413 if (DeallocatorName == "kCFAllocatorNull")
1414 return true;
1415 }
1416 }
1417 return false;
1418 }
1419
1420 // PR12101
1421 // Many CoreFoundation and CoreGraphics might allow a tracked object
1422 // to escape.
1423 if (CallOrObjCMessage::isCFCGAllowingEscape(FName))
1424 return false;
1425
1426 // Associating streams with malloced buffers. The pointer can escape if
1427 // 'closefn' is specified (and if that function does free memory).
1428 // Currently, we do not inspect the 'closefn' function (PR12101).
1429 if (FName == "funopen")
1430 if (Call->getNumArgs() >= 4 && !Call->getArgSVal(4).isConstant(0))
1431 return false;
1432
1433 // Do not warn on pointers passed to 'setbuf' when used with std streams,
1434 // these leaks might be intentional when setting the buffer for stdio.
1435 // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer
1436 if (FName == "setbuf" || FName =="setbuffer" ||
1437 FName == "setlinebuf" || FName == "setvbuf") {
1438 if (Call->getNumArgs() >= 1) {
1439 const Expr *ArgE = Call->getArgExpr(0)->IgnoreParenCasts();
1440 if (const DeclRefExpr *ArgDRE = dyn_cast<DeclRefExpr>(ArgE))
1441 if (const VarDecl *D = dyn_cast<VarDecl>(ArgDRE->getDecl()))
1442 if (D->getCanonicalDecl()->getName().find("std") != StringRef::npos)
1443 return false;
1444 }
1445 }
1446
1447 // A bunch of other functions which either take ownership of a pointer or
1448 // wrap the result up in a struct or object, meaning it can be freed later.
1449 // (See RetainCountChecker.) Not all the parameters here are invalidated,
1450 // but the Malloc checker cannot differentiate between them. The right way
1451 // of doing this would be to implement a pointer escapes callback.
1452 if (FName == "CGBitmapContextCreate" ||
1453 FName == "CGBitmapContextCreateWithData" ||
1454 FName == "CVPixelBufferCreateWithBytes" ||
1455 FName == "CVPixelBufferCreateWithPlanarBytes" ||
1456 FName == "OSAtomicEnqueue") {
1457 return false;
1458 }
1459
1460 // Whitelist NSXXInsertXX, for example NSMapInsertIfAbsent, since they can
1461 // be deallocated by NSMapRemove.
1462 if (FName.startswith("NS") && (FName.find("Insert") != StringRef::npos))
1463 return false;
1464
1465 // Otherwise, assume that the function does not free memory.
1466 // Most system calls do not free the memory.
1467 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001468}
1469
Anna Zaks4fb54872012-02-11 21:02:35 +00001470// If the symbol we are tracking is invalidated, but not explicitly (ex: the &p
1471// escapes, when we are tracking p), do not track the symbol as we cannot reason
1472// about it anymore.
1473ProgramStateRef
Anna Zaks66c40402012-02-14 21:55:24 +00001474MallocChecker::checkRegionChanges(ProgramStateRef State,
Anna Zaks4fb54872012-02-11 21:02:35 +00001475 const StoreManager::InvalidatedSymbols *invalidated,
1476 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +00001477 ArrayRef<const MemRegion *> Regions,
Jordan Rose740d4902012-07-02 19:27:35 +00001478 const CallEvent *Call) const {
Anna Zaks0d389b82012-02-23 01:05:27 +00001479 if (!invalidated || invalidated->empty())
Anna Zaks66c40402012-02-14 21:55:24 +00001480 return State;
Anna Zaks4fb54872012-02-11 21:02:35 +00001481 llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols;
Anna Zaks66c40402012-02-14 21:55:24 +00001482
Anna Zaks66c40402012-02-14 21:55:24 +00001483 // If it's a call which might free or reallocate memory, we assume that all
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001484 // regions (explicit and implicit) escaped.
1485
1486 // Otherwise, whitelist explicit pointers; we still can track them.
1487 if (!Call || doesNotFreeMemory(Call, State)) {
Anna Zaks66c40402012-02-14 21:55:24 +00001488 for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(),
1489 E = ExplicitRegions.end(); I != E; ++I) {
1490 if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>())
1491 WhitelistedSymbols.insert(R->getSymbol());
1492 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001493 }
1494
1495 for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(),
1496 E = invalidated->end(); I!=E; ++I) {
1497 SymbolRef sym = *I;
1498 if (WhitelistedSymbols.count(sym))
1499 continue;
Anna Zaks5b7aa342012-06-22 02:04:31 +00001500 // The symbol escaped. Note, we assume that if the symbol is released,
1501 // passing it out will result in a use after free. We also keep tracking
1502 // relinquished symbols.
1503 if (const RefState *RS = State->get<RegionState>(sym)) {
1504 if (RS->isAllocated())
1505 State = State->set<RegionState>(sym,
1506 RefState::getEscaped(RS->getStmt()));
1507 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001508 }
Anna Zaks66c40402012-02-14 21:55:24 +00001509 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001510}
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001511
Jordy Rose393f98b2012-03-18 07:43:35 +00001512static SymbolRef findFailedReallocSymbol(ProgramStateRef currState,
1513 ProgramStateRef prevState) {
1514 ReallocMap currMap = currState->get<ReallocPairs>();
1515 ReallocMap prevMap = prevState->get<ReallocPairs>();
1516
1517 for (ReallocMap::iterator I = prevMap.begin(), E = prevMap.end();
1518 I != E; ++I) {
1519 SymbolRef sym = I.getKey();
1520 if (!currMap.lookup(sym))
1521 return sym;
1522 }
1523
1524 return NULL;
1525}
1526
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001527PathDiagnosticPiece *
1528MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N,
1529 const ExplodedNode *PrevN,
1530 BugReporterContext &BRC,
1531 BugReport &BR) {
Jordy Rose393f98b2012-03-18 07:43:35 +00001532 ProgramStateRef state = N->getState();
1533 ProgramStateRef statePrev = PrevN->getState();
1534
1535 const RefState *RS = state->get<RegionState>(Sym);
1536 const RefState *RSPrev = statePrev->get<RegionState>(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001537 if (!RS && !RSPrev)
1538 return 0;
1539
Anna Zaksfe571602012-02-16 22:26:07 +00001540 const Stmt *S = 0;
1541 const char *Msg = 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001542 StackHintGeneratorForSymbol *StackHint = 0;
Anna Zaksfe571602012-02-16 22:26:07 +00001543
1544 // Retrieve the associated statement.
1545 ProgramPoint ProgLoc = N->getLocation();
1546 if (isa<StmtPoint>(ProgLoc))
1547 S = cast<StmtPoint>(ProgLoc).getStmt();
1548 // If an assumption was made on a branch, it should be caught
1549 // here by looking at the state transition.
1550 if (isa<BlockEdge>(ProgLoc)) {
1551 const CFGBlock *srcBlk = cast<BlockEdge>(ProgLoc).getSrc();
1552 S = srcBlk->getTerminator();
1553 }
1554 if (!S)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001555 return 0;
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001556
1557 // Find out if this is an interesting point and what is the kind.
Anna Zaksfe571602012-02-16 22:26:07 +00001558 if (Mode == Normal) {
Anna Zaks368a0d52012-03-15 21:13:02 +00001559 if (isAllocated(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001560 Msg = "Memory is allocated";
Anna Zaksfbd58742012-03-16 23:44:28 +00001561 StackHint = new StackHintGeneratorForSymbol(Sym,
1562 "Returned allocated memory");
Anna Zaks368a0d52012-03-15 21:13:02 +00001563 } else if (isReleased(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001564 Msg = "Memory is released";
Anna Zaksfbd58742012-03-16 23:44:28 +00001565 StackHint = new StackHintGeneratorForSymbol(Sym,
1566 "Returned released memory");
Anna Zaks5b7aa342012-06-22 02:04:31 +00001567 } else if (isRelinquished(RS, RSPrev, S)) {
1568 Msg = "Memory ownership is transfered";
1569 StackHint = new StackHintGeneratorForSymbol(Sym, "");
Anna Zaks368a0d52012-03-15 21:13:02 +00001570 } else if (isReallocFailedCheck(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001571 Mode = ReallocationFailed;
1572 Msg = "Reallocation failed";
Anna Zaks56a938f2012-03-16 23:24:20 +00001573 StackHint = new StackHintGeneratorForReallocationFailed(Sym,
Anna Zaksfbd58742012-03-16 23:44:28 +00001574 "Reallocation failed");
Jordy Rose393f98b2012-03-18 07:43:35 +00001575
Jordy Roseb000fb52012-03-24 03:15:09 +00001576 if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) {
1577 // Is it possible to fail two reallocs WITHOUT testing in between?
1578 assert((!FailedReallocSymbol || FailedReallocSymbol == sym) &&
1579 "We only support one failed realloc at a time.");
Jordy Rose393f98b2012-03-18 07:43:35 +00001580 BR.markInteresting(sym);
Jordy Roseb000fb52012-03-24 03:15:09 +00001581 FailedReallocSymbol = sym;
1582 }
Anna Zaksfe571602012-02-16 22:26:07 +00001583 }
1584
1585 // We are in a special mode if a reallocation failed later in the path.
1586 } else if (Mode == ReallocationFailed) {
Jordy Roseb000fb52012-03-24 03:15:09 +00001587 assert(FailedReallocSymbol && "No symbol to look for.");
Anna Zaksfe571602012-02-16 22:26:07 +00001588
Jordy Roseb000fb52012-03-24 03:15:09 +00001589 // Is this is the first appearance of the reallocated symbol?
1590 if (!statePrev->get<RegionState>(FailedReallocSymbol)) {
1591 // If we ever hit this assert, that means BugReporter has decided to skip
1592 // node pairs or visit them out of order.
1593 assert(state->get<RegionState>(FailedReallocSymbol) &&
1594 "Missed the reallocation point");
1595
1596 // We're at the reallocation point.
1597 Msg = "Attempt to reallocate memory";
1598 StackHint = new StackHintGeneratorForSymbol(Sym,
1599 "Returned reallocated memory");
1600 FailedReallocSymbol = NULL;
1601 Mode = Normal;
1602 }
Anna Zaksfe571602012-02-16 22:26:07 +00001603 }
1604
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001605 if (!Msg)
1606 return 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001607 assert(StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001608
1609 // Generate the extra diagnostic.
Anna Zaksfe571602012-02-16 22:26:07 +00001610 PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001611 N->getLocationContext());
Anna Zaks56a938f2012-03-16 23:24:20 +00001612 return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001613}
1614
Anna Zaks93c5a242012-05-02 00:05:20 +00001615void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State,
1616 const char *NL, const char *Sep) const {
1617
1618 RegionStateTy RS = State->get<RegionState>();
1619
1620 if (!RS.isEmpty())
1621 Out << "Has Malloc data" << NL;
1622}
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001623
Anna Zaks231361a2012-02-08 23:16:52 +00001624#define REGISTER_CHECKER(name) \
1625void ento::register##name(CheckerManager &mgr) {\
Anna Zaksf0dfc9c2012-02-17 22:35:31 +00001626 registerCStringCheckerBasic(mgr); \
Anna Zaks231361a2012-02-08 23:16:52 +00001627 mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001628}
Anna Zaks231361a2012-02-08 23:16:52 +00001629
1630REGISTER_CHECKER(MallocPessimistic)
1631REGISTER_CHECKER(MallocOptimistic)