blob: 50d4273e48c0a1dae4a33f3e297ee0090c130f22 [file] [log] [blame]
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001//=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines malloc/free checker, which checks for potential memory
11// leaks, double free, and use-after-free problems.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000015#include "ClangSACheckers.h"
Anna Zaksf0dfc9c2012-02-17 22:35:31 +000016#include "InterCheckerAPI.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000017#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000018#include "clang/StaticAnalyzer/Core/CheckerManager.h"
19#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000020#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Anna Zaks66c40402012-02-14 21:55:24 +000021#include "clang/StaticAnalyzer/Core/PathSensitive/ObjCMessage.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
23#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
Anna Zaks15d0ae12012-02-11 23:46:36 +000025#include "clang/Basic/SourceManager.h"
Zhongxing Xu589c0f22009-11-12 08:38:56 +000026#include "llvm/ADT/ImmutableMap.h"
Benjamin Kramer8fe83e12012-02-04 13:45:25 +000027#include "llvm/ADT/SmallString.h"
Benjamin Kramer00bd44d2012-02-04 12:31:12 +000028#include "llvm/ADT/STLExtras.h"
Anna Zaks60a1fa42012-02-22 03:14:20 +000029#include <climits>
30
Zhongxing Xu589c0f22009-11-12 08:38:56 +000031using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000032using namespace ento;
Zhongxing Xu589c0f22009-11-12 08:38:56 +000033
34namespace {
35
Zhongxing Xu7fb14642009-12-11 00:55:44 +000036class RefState {
Anna Zaks050cdd72012-06-20 20:57:46 +000037 enum Kind { // Reference to allocated memory.
38 Allocated,
39 // Reference to released/freed memory.
40 Released,
41 // Reference to escaped memory - no assumptions can be made of
42 // the state after the reference escapes.
43 Escaped,
44 // The responsibility for freeing resources has transfered from
45 // this reference. A relinquished symbol should not be freed.
Ted Kremenekdde201b2010-08-06 21:12:55 +000046 Relinquished } K;
Zhongxing Xu243fde92009-11-17 07:54:15 +000047 const Stmt *S;
48
Zhongxing Xu7fb14642009-12-11 00:55:44 +000049public:
Zhongxing Xu243fde92009-11-17 07:54:15 +000050 RefState(Kind k, const Stmt *s) : K(k), S(s) {}
51
Anna Zaks050cdd72012-06-20 20:57:46 +000052 bool isAllocated() const { return K == Allocated; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000053 bool isReleased() const { return K == Released; }
Anna Zaks050cdd72012-06-20 20:57:46 +000054 bool isRelinquished() const { return K == Relinquished; }
Anna Zaksca23eb22012-02-29 18:42:47 +000055
Anna Zaksc8bb3be2012-02-13 18:05:39 +000056 const Stmt *getStmt() const { return S; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000057
58 bool operator==(const RefState &X) const {
59 return K == X.K && S == X.S;
60 }
61
Anna Zaks050cdd72012-06-20 20:57:46 +000062 static RefState getAllocated(const Stmt *s) {
63 return RefState(Allocated, s);
Zhongxing Xub94b81a2009-12-31 06:13:07 +000064 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000065 static RefState getReleased(const Stmt *s) { return RefState(Released, s); }
66 static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); }
Ted Kremenekdde201b2010-08-06 21:12:55 +000067 static RefState getRelinquished(const Stmt *s) {
68 return RefState(Relinquished, s);
69 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000070
71 void Profile(llvm::FoldingSetNodeID &ID) const {
72 ID.AddInteger(K);
73 ID.AddPointer(S);
74 }
Zhongxing Xu589c0f22009-11-12 08:38:56 +000075};
76
Anna Zaks40add292012-02-15 00:11:25 +000077struct ReallocPair {
78 SymbolRef ReallocatedSym;
79 bool IsFreeOnFailure;
80 ReallocPair(SymbolRef S, bool F) : ReallocatedSym(S), IsFreeOnFailure(F) {}
81 void Profile(llvm::FoldingSetNodeID &ID) const {
82 ID.AddInteger(IsFreeOnFailure);
83 ID.AddPointer(ReallocatedSym);
84 }
85 bool operator==(const ReallocPair &X) const {
86 return ReallocatedSym == X.ReallocatedSym &&
87 IsFreeOnFailure == X.IsFreeOnFailure;
88 }
89};
90
Anna Zaks3d7c44e2012-03-21 19:45:08 +000091typedef std::pair<const Stmt*, const MemRegion*> LeakInfo;
92
Anna Zaksb319e022012-02-08 20:13:28 +000093class MallocChecker : public Checker<check::DeadSymbols,
Ted Kremeneke3659a72012-01-04 23:48:37 +000094 check::EndPath,
95 check::PreStmt<ReturnStmt>,
Anna Zaks66c40402012-02-14 21:55:24 +000096 check::PreStmt<CallExpr>,
Anna Zaksb319e022012-02-08 20:13:28 +000097 check::PostStmt<CallExpr>,
Anna Zaksf5aa3f52012-03-22 00:57:20 +000098 check::PostStmt<BlockExpr>,
Anna Zaks5b7aa342012-06-22 02:04:31 +000099 check::PreObjCMessage,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000100 check::Location,
101 check::Bind,
Anna Zaks4fb54872012-02-11 21:02:35 +0000102 eval::Assume,
103 check::RegionChanges>
Ted Kremeneke3659a72012-01-04 23:48:37 +0000104{
Anna Zaksfebdc322012-02-16 22:26:12 +0000105 mutable OwningPtr<BugType> BT_DoubleFree;
106 mutable OwningPtr<BugType> BT_Leak;
107 mutable OwningPtr<BugType> BT_UseFree;
108 mutable OwningPtr<BugType> BT_BadFree;
Anna Zaksb16ce452012-02-15 00:11:22 +0000109 mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc,
Anna Zaks60a1fa42012-02-22 03:14:20 +0000110 *II_valloc, *II_reallocf, *II_strndup, *II_strdup;
111
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000112public:
Anna Zaksb16ce452012-02-15 00:11:22 +0000113 MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0),
Anna Zaks60a1fa42012-02-22 03:14:20 +0000114 II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {}
Anna Zaks231361a2012-02-08 23:16:52 +0000115
116 /// In pessimistic mode, the checker assumes that it does not know which
117 /// functions might free the memory.
118 struct ChecksFilter {
119 DefaultBool CMallocPessimistic;
120 DefaultBool CMallocOptimistic;
121 };
122
123 ChecksFilter Filter;
124
Anna Zaks66c40402012-02-14 21:55:24 +0000125 void checkPreStmt(const CallExpr *S, CheckerContext &C) const;
Anna Zaksb319e022012-02-08 20:13:28 +0000126 void checkPostStmt(const CallExpr *CE, CheckerContext &C) const;
Anna Zaks5b7aa342012-06-22 02:04:31 +0000127 void checkPreObjCMessage(const ObjCMessage &Msg, CheckerContext &C) const;
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000128 void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000129 void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
Anna Zaksaf498a22011-10-25 19:56:48 +0000130 void checkEndPath(CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000131 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000132 ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000133 bool Assumption) const;
Anna Zaks390909c2011-10-06 00:43:15 +0000134 void checkLocation(SVal l, bool isLoad, const Stmt *S,
135 CheckerContext &C) const;
136 void checkBind(SVal location, SVal val, const Stmt*S,
137 CheckerContext &C) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000138 ProgramStateRef
139 checkRegionChanges(ProgramStateRef state,
140 const StoreManager::InvalidatedSymbols *invalidated,
141 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +0000142 ArrayRef<const MemRegion *> Regions,
143 const CallOrObjCMessage *Call) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000144 bool wantsRegionChangeUpdate(ProgramStateRef state) const {
145 return true;
146 }
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000147
Anna Zaks93c5a242012-05-02 00:05:20 +0000148 void printState(raw_ostream &Out, ProgramStateRef State,
149 const char *NL, const char *Sep) const;
150
Zhongxing Xu7b760962009-11-13 07:25:27 +0000151private:
Anna Zaks66c40402012-02-14 21:55:24 +0000152 void initIdentifierInfo(ASTContext &C) const;
153
154 /// Check if this is one of the functions which can allocate/reallocate memory
155 /// pointed to by one of its arguments.
156 bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks14345182012-05-18 01:16:10 +0000157 bool isFreeFunction(const FunctionDecl *FD, ASTContext &C) const;
158 bool isAllocationFunction(const FunctionDecl *FD, ASTContext &C) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000159
Anna Zaks87cb5be2012-02-22 19:24:52 +0000160 static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C,
161 const CallExpr *CE,
162 const OwnershipAttr* Att);
Ted Kremenek8bef8232012-01-26 21:29:00 +0000163 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000164 const Expr *SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000165 ProgramStateRef state) {
Ted Kremenek5eca4822012-01-06 22:09:28 +0000166 return MallocMemAux(C, CE,
167 state->getSVal(SizeEx, C.getLocationContext()),
168 Init, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000169 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000170
Ted Kremenek8bef8232012-01-26 21:29:00 +0000171 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000172 SVal SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000173 ProgramStateRef state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000174
Anna Zaks87cb5be2012-02-22 19:24:52 +0000175 /// Update the RefState to reflect the new memory allocation.
176 static ProgramStateRef MallocUpdateRefState(CheckerContext &C,
177 const CallExpr *CE,
178 ProgramStateRef state);
179
180 ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE,
181 const OwnershipAttr* Att) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000182 ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000183 ProgramStateRef state, unsigned Num,
184 bool Hold) const;
185 ProgramStateRef FreeMemAux(CheckerContext &C, const Expr *Arg,
186 const Expr *ParentExpr,
187 ProgramStateRef state,
188 bool Hold) const;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000189
Anna Zaks87cb5be2012-02-22 19:24:52 +0000190 ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE,
191 bool FreesMemOnFailure) const;
192 static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE);
Jordy Rose43859f62010-06-07 19:32:37 +0000193
Anna Zaks14345182012-05-18 01:16:10 +0000194 ///\brief Check if the memory associated with this symbol was released.
195 bool isReleased(SymbolRef Sym, CheckerContext &C) const;
196
Anna Zaks91c2a112012-02-08 23:16:56 +0000197 bool checkEscape(SymbolRef Sym, const Stmt *S, CheckerContext &C) const;
198 bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
199 const Stmt *S = 0) const;
200
Anna Zaks66c40402012-02-14 21:55:24 +0000201 /// Check if the function is not known to us. So, for example, we could
202 /// conservatively assume it can free/reallocate it's pointer arguments.
Anna Zaks3cd89ad2012-02-24 23:56:53 +0000203 bool doesNotFreeMemory(const CallOrObjCMessage *Call,
204 ProgramStateRef State) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000205
Ted Kremenek9c378f72011-08-12 23:37:29 +0000206 static bool SummarizeValue(raw_ostream &os, SVal V);
207 static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR);
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000208 void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const;
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000209
Anna Zaksca8e36e2012-02-23 21:38:21 +0000210 /// Find the location of the allocation for Sym on the path leading to the
211 /// exploded node N.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000212 LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
213 CheckerContext &C) const;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000214
Anna Zaksda046772012-02-11 21:02:40 +0000215 void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const;
216
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000217 /// The bug visitor which allows us to print extra diagnostics along the
218 /// BugReport path. For example, showing the allocation site of the leaked
219 /// region.
Jordy Rose01153492012-03-24 02:45:35 +0000220 class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000221 protected:
Anna Zaksfe571602012-02-16 22:26:07 +0000222 enum NotificationMode {
223 Normal,
Anna Zaksfe571602012-02-16 22:26:07 +0000224 ReallocationFailed
225 };
226
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000227 // The allocated region symbol tracked by the main analysis.
228 SymbolRef Sym;
229
Anna Zaks88feba02012-05-10 01:37:40 +0000230 // The mode we are in, i.e. what kind of diagnostics will be emitted.
231 NotificationMode Mode;
Jordy Roseb000fb52012-03-24 03:15:09 +0000232
Anna Zaks88feba02012-05-10 01:37:40 +0000233 // A symbol from when the primary region should have been reallocated.
234 SymbolRef FailedReallocSymbol;
Jordy Roseb000fb52012-03-24 03:15:09 +0000235
Anna Zaks88feba02012-05-10 01:37:40 +0000236 bool IsLeak;
237
238 public:
239 MallocBugVisitor(SymbolRef S, bool isLeak = false)
240 : Sym(S), Mode(Normal), FailedReallocSymbol(0), IsLeak(isLeak) {}
Jordy Roseb000fb52012-03-24 03:15:09 +0000241
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000242 virtual ~MallocBugVisitor() {}
243
244 void Profile(llvm::FoldingSetNodeID &ID) const {
245 static int X = 0;
246 ID.AddPointer(&X);
247 ID.AddPointer(Sym);
248 }
249
Anna Zaksfe571602012-02-16 22:26:07 +0000250 inline bool isAllocated(const RefState *S, const RefState *SPrev,
251 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000252 // Did not track -> allocated. Other state (released) -> allocated.
Anna Zaksfe571602012-02-16 22:26:07 +0000253 return (Stmt && isa<CallExpr>(Stmt) &&
254 (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000255 }
256
Anna Zaksfe571602012-02-16 22:26:07 +0000257 inline bool isReleased(const RefState *S, const RefState *SPrev,
258 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000259 // Did not track -> released. Other state (allocated) -> released.
Anna Zaksfe571602012-02-16 22:26:07 +0000260 return (Stmt && isa<CallExpr>(Stmt) &&
261 (S && S->isReleased()) && (!SPrev || !SPrev->isReleased()));
262 }
263
Anna Zaks5b7aa342012-06-22 02:04:31 +0000264 inline bool isRelinquished(const RefState *S, const RefState *SPrev,
265 const Stmt *Stmt) {
266 // Did not track -> relinquished. Other state (allocated) -> relinquished.
267 return (Stmt && (isa<CallExpr>(Stmt) || isa<ObjCMessageExpr>(Stmt) ||
268 isa<ObjCPropertyRefExpr>(Stmt)) &&
269 (S && S->isRelinquished()) &&
270 (!SPrev || !SPrev->isRelinquished()));
271 }
272
Anna Zaksfe571602012-02-16 22:26:07 +0000273 inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev,
274 const Stmt *Stmt) {
275 // If the expression is not a call, and the state change is
276 // released -> allocated, it must be the realloc return value
277 // check. If we have to handle more cases here, it might be cleaner just
278 // to track this extra bit in the state itself.
279 return ((!Stmt || !isa<CallExpr>(Stmt)) &&
280 (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000281 }
282
283 PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
284 const ExplodedNode *PrevN,
285 BugReporterContext &BRC,
286 BugReport &BR);
Anna Zaks88feba02012-05-10 01:37:40 +0000287
288 PathDiagnosticPiece* getEndPath(BugReporterContext &BRC,
289 const ExplodedNode *EndPathNode,
290 BugReport &BR) {
291 if (!IsLeak)
292 return 0;
293
294 PathDiagnosticLocation L =
295 PathDiagnosticLocation::createEndOfPath(EndPathNode,
296 BRC.getSourceManager());
297 // Do not add the statement itself as a range in case of leak.
298 return new PathDiagnosticEventPiece(L, BR.getDescription(), false);
299 }
300
Anna Zaks56a938f2012-03-16 23:24:20 +0000301 private:
302 class StackHintGeneratorForReallocationFailed
303 : public StackHintGeneratorForSymbol {
304 public:
305 StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M)
306 : StackHintGeneratorForSymbol(S, M) {}
307
308 virtual std::string getMessageForArg(const Expr *ArgE, unsigned ArgIndex) {
309 SmallString<200> buf;
310 llvm::raw_svector_ostream os(buf);
311
Anna Zaksfbd58742012-03-16 23:44:28 +0000312 os << "Reallocation of ";
Anna Zaks56a938f2012-03-16 23:24:20 +0000313 // Printed parameters start at 1, not 0.
314 printOrdinal(++ArgIndex, os);
315 os << " parameter failed";
316
317 return os.str();
318 }
319
320 virtual std::string getMessageForReturn(const CallExpr *CallExpr) {
Anna Zaksfbd58742012-03-16 23:44:28 +0000321 return "Reallocation of returned value failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000322 }
323 };
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000324 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000325};
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000326} // end anonymous namespace
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000327
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000328typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy;
Anna Zaks40add292012-02-15 00:11:25 +0000329typedef llvm::ImmutableMap<SymbolRef, ReallocPair > ReallocMap;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000330class RegionState {};
331class ReallocPairs {};
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000332namespace clang {
Ted Kremenek9ef65372010-12-23 07:20:52 +0000333namespace ento {
Zhongxing Xu243fde92009-11-17 07:54:15 +0000334 template <>
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000335 struct ProgramStateTrait<RegionState>
336 : public ProgramStatePartialTrait<RegionStateTy> {
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000337 static void *GDMIndex() { static int x; return &x; }
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000338 };
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000339
340 template <>
341 struct ProgramStateTrait<ReallocPairs>
Anna Zaks40add292012-02-15 00:11:25 +0000342 : public ProgramStatePartialTrait<ReallocMap> {
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000343 static void *GDMIndex() { static int x; return &x; }
344 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000345}
Argyrios Kyrtzidis5a4f98f2010-12-22 18:53:20 +0000346}
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000347
Anna Zaks4fb54872012-02-11 21:02:35 +0000348namespace {
349class StopTrackingCallback : public SymbolVisitor {
350 ProgramStateRef state;
351public:
352 StopTrackingCallback(ProgramStateRef st) : state(st) {}
353 ProgramStateRef getState() const { return state; }
354
355 bool VisitSymbol(SymbolRef sym) {
356 state = state->remove<RegionState>(sym);
357 return true;
358 }
359};
360} // end anonymous namespace
361
Anna Zaks66c40402012-02-14 21:55:24 +0000362void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const {
Anna Zaksa38cb2c2012-05-18 22:47:40 +0000363 if (II_malloc)
364 return;
365 II_malloc = &Ctx.Idents.get("malloc");
366 II_free = &Ctx.Idents.get("free");
367 II_realloc = &Ctx.Idents.get("realloc");
368 II_reallocf = &Ctx.Idents.get("reallocf");
369 II_calloc = &Ctx.Idents.get("calloc");
370 II_valloc = &Ctx.Idents.get("valloc");
371 II_strdup = &Ctx.Idents.get("strdup");
372 II_strndup = &Ctx.Idents.get("strndup");
Anna Zaksb319e022012-02-08 20:13:28 +0000373}
374
Anna Zaks66c40402012-02-14 21:55:24 +0000375bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +0000376 if (isFreeFunction(FD, C))
377 return true;
378
379 if (isAllocationFunction(FD, C))
380 return true;
381
382 return false;
383}
384
385bool MallocChecker::isAllocationFunction(const FunctionDecl *FD,
386 ASTContext &C) const {
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000387 if (!FD)
388 return false;
Anna Zaks14345182012-05-18 01:16:10 +0000389
Anna Zaks66c40402012-02-14 21:55:24 +0000390 IdentifierInfo *FunI = FD->getIdentifier();
391 if (!FunI)
392 return false;
393
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000394 initIdentifierInfo(C);
395
Anna Zaks14345182012-05-18 01:16:10 +0000396 if (FunI == II_malloc || FunI == II_realloc ||
Anna Zaks60a1fa42012-02-22 03:14:20 +0000397 FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc ||
398 FunI == II_strdup || FunI == II_strndup)
Anna Zaks66c40402012-02-14 21:55:24 +0000399 return true;
400
Anna Zaks14345182012-05-18 01:16:10 +0000401 if (Filter.CMallocOptimistic && FD->hasAttrs())
402 for (specific_attr_iterator<OwnershipAttr>
403 i = FD->specific_attr_begin<OwnershipAttr>(),
404 e = FD->specific_attr_end<OwnershipAttr>();
405 i != e; ++i)
406 if ((*i)->getOwnKind() == OwnershipAttr::Returns)
407 return true;
408 return false;
409}
410
411bool MallocChecker::isFreeFunction(const FunctionDecl *FD, ASTContext &C) const {
412 if (!FD)
413 return false;
414
415 IdentifierInfo *FunI = FD->getIdentifier();
416 if (!FunI)
417 return false;
418
419 initIdentifierInfo(C);
420
421 if (FunI == II_free || FunI == II_realloc || FunI == II_reallocf)
Anna Zaks66c40402012-02-14 21:55:24 +0000422 return true;
423
Anna Zaks14345182012-05-18 01:16:10 +0000424 if (Filter.CMallocOptimistic && FD->hasAttrs())
425 for (specific_attr_iterator<OwnershipAttr>
426 i = FD->specific_attr_begin<OwnershipAttr>(),
427 e = FD->specific_attr_end<OwnershipAttr>();
428 i != e; ++i)
429 if ((*i)->getOwnKind() == OwnershipAttr::Takes ||
430 (*i)->getOwnKind() == OwnershipAttr::Holds)
431 return true;
Anna Zaks66c40402012-02-14 21:55:24 +0000432 return false;
433}
434
Anna Zaksb319e022012-02-08 20:13:28 +0000435void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const {
436 const FunctionDecl *FD = C.getCalleeDecl(CE);
437 if (!FD)
438 return;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000439
Anna Zaksb16ce452012-02-15 00:11:22 +0000440 initIdentifierInfo(C.getASTContext());
441 IdentifierInfo *FunI = FD->getIdentifier();
442 if (!FunI)
443 return;
444
Anna Zaks87cb5be2012-02-22 19:24:52 +0000445 ProgramStateRef State = C.getState();
Anna Zaksb16ce452012-02-15 00:11:22 +0000446 if (FunI == II_malloc || FunI == II_valloc) {
Anna Zaks259052d2012-04-10 23:41:11 +0000447 if (CE->getNumArgs() < 1)
448 return;
Anna Zaks87cb5be2012-02-22 19:24:52 +0000449 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
Anna Zaksb16ce452012-02-15 00:11:22 +0000450 } else if (FunI == II_realloc) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000451 State = ReallocMem(C, CE, false);
Anna Zaks40add292012-02-15 00:11:25 +0000452 } else if (FunI == II_reallocf) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000453 State = ReallocMem(C, CE, true);
Anna Zaksb16ce452012-02-15 00:11:22 +0000454 } else if (FunI == II_calloc) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000455 State = CallocMem(C, CE);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000456 } else if (FunI == II_free) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000457 State = FreeMemAux(C, CE, C.getState(), 0, false);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000458 } else if (FunI == II_strdup) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000459 State = MallocUpdateRefState(C, CE, State);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000460 } else if (FunI == II_strndup) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000461 State = MallocUpdateRefState(C, CE, State);
462 } else if (Filter.CMallocOptimistic) {
463 // Check all the attributes, if there are any.
464 // There can be multiple of these attributes.
465 if (FD->hasAttrs())
466 for (specific_attr_iterator<OwnershipAttr>
467 i = FD->specific_attr_begin<OwnershipAttr>(),
468 e = FD->specific_attr_end<OwnershipAttr>();
469 i != e; ++i) {
470 switch ((*i)->getOwnKind()) {
471 case OwnershipAttr::Returns:
472 State = MallocMemReturnsAttr(C, CE, *i);
473 break;
474 case OwnershipAttr::Takes:
475 case OwnershipAttr::Holds:
476 State = FreeMemAttr(C, CE, *i);
477 break;
478 }
479 }
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000480 }
Anna Zaks60a1fa42012-02-22 03:14:20 +0000481 C.addTransition(State);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000482}
483
Anna Zaks5b7aa342012-06-22 02:04:31 +0000484static bool isFreeWhenDoneSetToZero(CallOrObjCMessage Call, Selector &S) {
Anna Zaks3e4f65d2012-06-22 22:08:09 +0000485 for (unsigned i = 1; i < S.getNumArgs(); ++i)
Anna Zaks5b7aa342012-06-22 02:04:31 +0000486 if (S.getNameForSlot(i).equals("freeWhenDone"))
487 if (Call.getArgSVal(i).isConstant(0))
488 return true;
489
490 return false;
491}
492
493void MallocChecker::checkPreObjCMessage(const ObjCMessage &Msg,
494 CheckerContext &C) const {
495 const ObjCMethodDecl *MD = Msg.getMethodDecl();
496 if (!MD)
497 return;
498
499 CallOrObjCMessage Call(Msg, C.getState(), C.getLocationContext());
500 Selector S = Msg.getSelector();
501
502 // If the first selector is dataWithBytesNoCopy, assume that the memory will
503 // be released with 'free' by the new object.
504 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
505 // Unless 'freeWhenDone' param set to 0.
506 // TODO: Check that the memory was allocated with malloc.
Anna Zaks7186dc62012-06-22 22:42:30 +0000507 if ((S.getNameForSlot(0) == "dataWithBytesNoCopy" ||
508 S.getNameForSlot(0) == "initWithBytesNoCopy" ||
509 S.getNameForSlot(0) == "initWithCharactersNoCopy") &&
Anna Zaks5b7aa342012-06-22 02:04:31 +0000510 !isFreeWhenDoneSetToZero(Call, S)){
511 unsigned int argIdx = 0;
512 C.addTransition(FreeMemAux(C, Call.getArg(argIdx),
513 Msg.getMessageExpr(), C.getState(), true));
514 }
515}
516
Anna Zaks87cb5be2012-02-22 19:24:52 +0000517ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C,
518 const CallExpr *CE,
519 const OwnershipAttr* Att) {
Sean Huntcf807c42010-08-18 23:23:40 +0000520 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000521 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000522
Sean Huntcf807c42010-08-18 23:23:40 +0000523 OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000524 if (I != E) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000525 return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000526 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000527 return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000528}
529
Anna Zaksb319e022012-02-08 20:13:28 +0000530ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000531 const CallExpr *CE,
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000532 SVal Size, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000533 ProgramStateRef state) {
Anna Zakse17fdb22012-06-07 03:57:32 +0000534
535 // Bind the return value to the symbolic value from the heap region.
536 // TODO: We could rewrite post visit to eval call; 'malloc' does not have
537 // side effects other than what we model here.
538 unsigned Count = C.getCurrentBlockCount();
539 SValBuilder &svalBuilder = C.getSValBuilder();
540 const LocationContext *LCtx = C.getPredecessor()->getLocationContext();
541 DefinedSVal RetVal =
542 cast<DefinedSVal>(svalBuilder.getConjuredHeapSymbolVal(CE, LCtx, Count));
543 state = state->BindExpr(CE, C.getLocationContext(), RetVal);
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000544
Anna Zaksb16ce452012-02-15 00:11:22 +0000545 // We expect the malloc functions to return a pointer.
Anna Zakse17fdb22012-06-07 03:57:32 +0000546 if (!isa<Loc>(RetVal))
Anna Zaksb16ce452012-02-15 00:11:22 +0000547 return 0;
548
Jordy Rose32f26562010-07-04 00:00:41 +0000549 // Fill the region with the initialization value.
Anna Zakse17fdb22012-06-07 03:57:32 +0000550 state = state->bindDefault(RetVal, Init);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000551
Jordy Rose32f26562010-07-04 00:00:41 +0000552 // Set the region's extent equal to the Size parameter.
Anna Zakse9ef5622012-02-10 01:11:00 +0000553 const SymbolicRegion *R =
Anna Zakse17fdb22012-06-07 03:57:32 +0000554 dyn_cast_or_null<SymbolicRegion>(RetVal.getAsRegion());
Anna Zaks60a1fa42012-02-22 03:14:20 +0000555 if (!R)
Anna Zakse9ef5622012-02-10 01:11:00 +0000556 return 0;
Anna Zaks60a1fa42012-02-22 03:14:20 +0000557 if (isa<DefinedOrUnknownSVal>(Size)) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000558 SValBuilder &svalBuilder = C.getSValBuilder();
Anna Zaks60a1fa42012-02-22 03:14:20 +0000559 DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder);
560 DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size);
561 DefinedOrUnknownSVal extentMatchesSize =
562 svalBuilder.evalEQ(state, Extent, DefinedSize);
Anna Zakse9ef5622012-02-10 01:11:00 +0000563
Anna Zaks60a1fa42012-02-22 03:14:20 +0000564 state = state->assume(extentMatchesSize, true);
565 assert(state);
566 }
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000567
Anna Zaks87cb5be2012-02-22 19:24:52 +0000568 return MallocUpdateRefState(C, CE, state);
569}
570
571ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C,
572 const CallExpr *CE,
573 ProgramStateRef state) {
574 // Get the return value.
575 SVal retVal = state->getSVal(CE, C.getLocationContext());
576
577 // We expect the malloc functions to return a pointer.
578 if (!isa<Loc>(retVal))
579 return 0;
580
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000581 SymbolRef Sym = retVal.getAsLocSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000582 assert(Sym);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000583
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000584 // Set the symbol's state to Allocated.
Anna Zaks050cdd72012-06-20 20:57:46 +0000585 return state->set<RegionState>(Sym, RefState::getAllocated(CE));
Anna Zaks87cb5be2012-02-22 19:24:52 +0000586
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000587}
588
Anna Zaks87cb5be2012-02-22 19:24:52 +0000589ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C,
590 const CallExpr *CE,
591 const OwnershipAttr* Att) const {
Sean Huntcf807c42010-08-18 23:23:40 +0000592 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000593 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000594
Anna Zaksb3d72752012-03-01 22:06:06 +0000595 ProgramStateRef State = C.getState();
596
Sean Huntcf807c42010-08-18 23:23:40 +0000597 for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
598 I != E; ++I) {
Anna Zaksb3d72752012-03-01 22:06:06 +0000599 ProgramStateRef StateI = FreeMemAux(C, CE, State, *I,
600 Att->getOwnKind() == OwnershipAttr::Holds);
601 if (StateI)
602 State = StateI;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000603 }
Anna Zaksb3d72752012-03-01 22:06:06 +0000604 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000605}
606
Ted Kremenek8bef8232012-01-26 21:29:00 +0000607ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
Anna Zakse9ef5622012-02-10 01:11:00 +0000608 const CallExpr *CE,
609 ProgramStateRef state,
610 unsigned Num,
611 bool Hold) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000612 if (CE->getNumArgs() < (Num + 1))
613 return 0;
614
Anna Zaks5b7aa342012-06-22 02:04:31 +0000615 return FreeMemAux(C, CE->getArg(Num), CE, state, Hold);
616}
617
618ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
619 const Expr *ArgExpr,
620 const Expr *ParentExpr,
621 ProgramStateRef state,
622 bool Hold) const {
623
Ted Kremenek5eca4822012-01-06 22:09:28 +0000624 SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext());
Anna Zakse9ef5622012-02-10 01:11:00 +0000625 if (!isa<DefinedOrUnknownSVal>(ArgVal))
626 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000627 DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal);
628
629 // Check for null dereferences.
630 if (!isa<Loc>(location))
Anna Zaksb319e022012-02-08 20:13:28 +0000631 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000632
Anna Zaksb276bd92012-02-14 00:26:13 +0000633 // The explicit NULL case, no operation is performed.
Ted Kremenek8bef8232012-01-26 21:29:00 +0000634 ProgramStateRef notNullState, nullState;
Ted Kremenek28f47b92010-12-01 22:16:56 +0000635 llvm::tie(notNullState, nullState) = state->assume(location);
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000636 if (nullState && !notNullState)
Anna Zaksb319e022012-02-08 20:13:28 +0000637 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000638
Jordy Rose43859f62010-06-07 19:32:37 +0000639 // Unknown values could easily be okay
640 // Undefined values are handled elsewhere
641 if (ArgVal.isUnknownOrUndef())
Anna Zaksb319e022012-02-08 20:13:28 +0000642 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000643
Jordy Rose43859f62010-06-07 19:32:37 +0000644 const MemRegion *R = ArgVal.getAsRegion();
645
646 // Nonlocs can't be freed, of course.
647 // Non-region locations (labels and fixed addresses) also shouldn't be freed.
648 if (!R) {
649 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000650 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000651 }
652
653 R = R->StripCasts();
654
655 // Blocks might show up as heap data, but should not be free()d
656 if (isa<BlockDataRegion>(R)) {
657 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000658 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000659 }
660
661 const MemSpaceRegion *MS = R->getMemorySpace();
662
663 // Parameters, locals, statics, and globals shouldn't be freed.
664 if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) {
665 // FIXME: at the time this code was written, malloc() regions were
666 // represented by conjured symbols, which are all in UnknownSpaceRegion.
667 // This means that there isn't actually anything from HeapSpaceRegion
668 // that should be freed, even though we allow it here.
669 // Of course, free() can work on memory allocated outside the current
670 // function, so UnknownSpaceRegion is always a possibility.
671 // False negatives are better than false positives.
672
673 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000674 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000675 }
676
677 const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R);
678 // Various cases could lead to non-symbol values here.
679 // For now, ignore them.
680 if (!SR)
Anna Zaksb319e022012-02-08 20:13:28 +0000681 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000682
683 SymbolRef Sym = SR->getSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000684 const RefState *RS = state->get<RegionState>(Sym);
Zhongxing Xu7e3cda92010-01-18 03:27:34 +0000685
686 // If the symbol has not been tracked, return. This is possible when free() is
687 // called on a pointer that does not get its pointee directly from malloc().
688 // Full support of this requires inter-procedural analysis.
689 if (!RS)
Anna Zaksb319e022012-02-08 20:13:28 +0000690 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000691
692 // Check double free.
Anna Zaks050cdd72012-06-20 20:57:46 +0000693 if (RS->isReleased() || RS->isRelinquished()) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000694 if (ExplodedNode *N = C.generateSink()) {
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000695 if (!BT_DoubleFree)
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000696 BT_DoubleFree.reset(
Anna Zaksfebdc322012-02-16 22:26:12 +0000697 new BugType("Double free", "Memory Error"));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000698 BugReport *R = new BugReport(*BT_DoubleFree,
Anna Zaks5b7aa342012-06-22 02:04:31 +0000699 (RS->isReleased() ? "Attempt to free released memory" :
700 "Attempt to free non-owned memory"), N);
Anna Zaksfe571602012-02-16 22:26:07 +0000701 R->addRange(ArgExpr->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +0000702 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000703 R->addVisitor(new MallocBugVisitor(Sym));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000704 C.EmitReport(R);
705 }
Anna Zaksb319e022012-02-08 20:13:28 +0000706 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000707 }
708
709 // Normal free.
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000710 if (Hold)
Anna Zaks5b7aa342012-06-22 02:04:31 +0000711 return state->set<RegionState>(Sym, RefState::getRelinquished(ParentExpr));
712 return state->set<RegionState>(Sym, RefState::getReleased(ParentExpr));
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000713}
714
Ted Kremenek9c378f72011-08-12 23:37:29 +0000715bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {
Jordy Rose43859f62010-06-07 19:32:37 +0000716 if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V))
717 os << "an integer (" << IntVal->getValue() << ")";
718 else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V))
719 os << "a constant address (" << ConstAddr->getValue() << ")";
720 else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V))
Chris Lattner68106302011-02-17 05:38:27 +0000721 os << "the address of the label '" << Label->getLabel()->getName() << "'";
Jordy Rose43859f62010-06-07 19:32:37 +0000722 else
723 return false;
724
725 return true;
726}
727
Ted Kremenek9c378f72011-08-12 23:37:29 +0000728bool MallocChecker::SummarizeRegion(raw_ostream &os,
Jordy Rose43859f62010-06-07 19:32:37 +0000729 const MemRegion *MR) {
730 switch (MR->getKind()) {
731 case MemRegion::FunctionTextRegionKind: {
732 const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl();
733 if (FD)
Benjamin Kramerb8989f22011-10-14 18:45:37 +0000734 os << "the address of the function '" << *FD << '\'';
Jordy Rose43859f62010-06-07 19:32:37 +0000735 else
736 os << "the address of a function";
737 return true;
738 }
739 case MemRegion::BlockTextRegionKind:
740 os << "block text";
741 return true;
742 case MemRegion::BlockDataRegionKind:
743 // FIXME: where the block came from?
744 os << "a block";
745 return true;
746 default: {
747 const MemSpaceRegion *MS = MR->getMemorySpace();
748
Anna Zakseb31a762012-01-04 23:54:01 +0000749 if (isa<StackLocalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000750 const VarRegion *VR = dyn_cast<VarRegion>(MR);
751 const VarDecl *VD;
752 if (VR)
753 VD = VR->getDecl();
754 else
755 VD = NULL;
756
757 if (VD)
758 os << "the address of the local variable '" << VD->getName() << "'";
759 else
760 os << "the address of a local stack variable";
761 return true;
762 }
Anna Zakseb31a762012-01-04 23:54:01 +0000763
764 if (isa<StackArgumentsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000765 const VarRegion *VR = dyn_cast<VarRegion>(MR);
766 const VarDecl *VD;
767 if (VR)
768 VD = VR->getDecl();
769 else
770 VD = NULL;
771
772 if (VD)
773 os << "the address of the parameter '" << VD->getName() << "'";
774 else
775 os << "the address of a parameter";
776 return true;
777 }
Anna Zakseb31a762012-01-04 23:54:01 +0000778
779 if (isa<GlobalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000780 const VarRegion *VR = dyn_cast<VarRegion>(MR);
781 const VarDecl *VD;
782 if (VR)
783 VD = VR->getDecl();
784 else
785 VD = NULL;
786
787 if (VD) {
788 if (VD->isStaticLocal())
789 os << "the address of the static variable '" << VD->getName() << "'";
790 else
791 os << "the address of the global variable '" << VD->getName() << "'";
792 } else
793 os << "the address of a global variable";
794 return true;
795 }
Anna Zakseb31a762012-01-04 23:54:01 +0000796
797 return false;
Jordy Rose43859f62010-06-07 19:32:37 +0000798 }
799 }
800}
801
802void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000803 SourceRange range) const {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000804 if (ExplodedNode *N = C.generateSink()) {
Jordy Rose43859f62010-06-07 19:32:37 +0000805 if (!BT_BadFree)
Anna Zaksfebdc322012-02-16 22:26:12 +0000806 BT_BadFree.reset(new BugType("Bad free", "Memory Error"));
Jordy Rose43859f62010-06-07 19:32:37 +0000807
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000808 SmallString<100> buf;
Jordy Rose43859f62010-06-07 19:32:37 +0000809 llvm::raw_svector_ostream os(buf);
810
811 const MemRegion *MR = ArgVal.getAsRegion();
812 if (MR) {
813 while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR))
814 MR = ER->getSuperRegion();
815
816 // Special case for alloca()
817 if (isa<AllocaRegion>(MR))
818 os << "Argument to free() was allocated by alloca(), not malloc()";
819 else {
820 os << "Argument to free() is ";
821 if (SummarizeRegion(os, MR))
822 os << ", which is not memory allocated by malloc()";
823 else
824 os << "not memory allocated by malloc()";
825 }
826 } else {
827 os << "Argument to free() is ";
828 if (SummarizeValue(os, ArgVal))
829 os << ", which is not memory allocated by malloc()";
830 else
831 os << "not memory allocated by malloc()";
832 }
833
Anna Zakse172e8b2011-08-17 23:00:25 +0000834 BugReport *R = new BugReport(*BT_BadFree, os.str(), N);
Ted Kremenek76aadc32012-03-09 01:13:14 +0000835 R->markInteresting(MR);
Jordy Rose43859f62010-06-07 19:32:37 +0000836 R->addRange(range);
837 C.EmitReport(R);
838 }
839}
840
Anna Zaks87cb5be2012-02-22 19:24:52 +0000841ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C,
842 const CallExpr *CE,
843 bool FreesOnFail) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000844 if (CE->getNumArgs() < 2)
845 return 0;
846
Ted Kremenek8bef8232012-01-26 21:29:00 +0000847 ProgramStateRef state = C.getState();
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000848 const Expr *arg0Expr = CE->getArg(0);
Ted Kremenek5eca4822012-01-06 22:09:28 +0000849 const LocationContext *LCtx = C.getLocationContext();
Anna Zakse9ef5622012-02-10 01:11:00 +0000850 SVal Arg0Val = state->getSVal(arg0Expr, LCtx);
851 if (!isa<DefinedOrUnknownSVal>(Arg0Val))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000852 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000853 DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000854
Ted Kremenek846eabd2010-12-01 21:28:31 +0000855 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000856
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000857 DefinedOrUnknownSVal PtrEQ =
858 svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull());
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000859
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000860 // Get the size argument. If there is no size arg then give up.
861 const Expr *Arg1 = CE->getArg(1);
862 if (!Arg1)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000863 return 0;
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000864
865 // Get the value of the size argument.
Anna Zakse9ef5622012-02-10 01:11:00 +0000866 SVal Arg1ValG = state->getSVal(Arg1, LCtx);
867 if (!isa<DefinedOrUnknownSVal>(Arg1ValG))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000868 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000869 DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG);
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000870
871 // Compare the size argument to 0.
872 DefinedOrUnknownSVal SizeZero =
873 svalBuilder.evalEQ(state, Arg1Val,
874 svalBuilder.makeIntValWithPtrWidth(0, false));
875
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000876 ProgramStateRef StatePtrIsNull, StatePtrNotNull;
877 llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ);
878 ProgramStateRef StateSizeIsZero, StateSizeNotZero;
879 llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero);
880 // We only assume exceptional states if they are definitely true; if the
881 // state is under-constrained, assume regular realloc behavior.
882 bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull;
883 bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero;
884
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000885 // If the ptr is NULL and the size is not 0, the call is equivalent to
886 // malloc(size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000887 if ( PrtIsNull && !SizeIsZero) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000888 ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1),
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000889 UndefinedVal(), StatePtrIsNull);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000890 return stateMalloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000891 }
892
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000893 if (PrtIsNull && SizeIsZero)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000894 return 0;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000895
Anna Zaks30838b92012-02-13 20:57:07 +0000896 // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000897 assert(!PrtIsNull);
Anna Zaks30838b92012-02-13 20:57:07 +0000898 SymbolRef FromPtr = arg0Val.getAsSymbol();
899 SVal RetVal = state->getSVal(CE, LCtx);
900 SymbolRef ToPtr = RetVal.getAsSymbol();
901 if (!FromPtr || !ToPtr)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000902 return 0;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000903
904 // If the size is 0, free the memory.
905 if (SizeIsZero)
906 if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero,0,false)){
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000907 // The semantics of the return value are:
908 // If size was equal to 0, either NULL or a pointer suitable to be passed
909 // to free() is returned.
Anna Zaks40add292012-02-15 00:11:25 +0000910 stateFree = stateFree->set<ReallocPairs>(ToPtr,
911 ReallocPair(FromPtr, FreesOnFail));
Anna Zaksb276bd92012-02-14 00:26:13 +0000912 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000913 return stateFree;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000914 }
915
916 // Default behavior.
917 if (ProgramStateRef stateFree = FreeMemAux(C, CE, state, 0, false)) {
918 // FIXME: We should copy the content of the original buffer.
919 ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1),
920 UnknownVal(), stateFree);
Anna Zaks30838b92012-02-13 20:57:07 +0000921 if (!stateRealloc)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000922 return 0;
Anna Zaks40add292012-02-15 00:11:25 +0000923 stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr,
924 ReallocPair(FromPtr, FreesOnFail));
Anna Zaksb276bd92012-02-14 00:26:13 +0000925 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000926 return stateRealloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000927 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000928 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000929}
Zhongxing Xu7b760962009-11-13 07:25:27 +0000930
Anna Zaks87cb5be2012-02-22 19:24:52 +0000931ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){
Anna Zaks259052d2012-04-10 23:41:11 +0000932 if (CE->getNumArgs() < 2)
933 return 0;
934
Ted Kremenek8bef8232012-01-26 21:29:00 +0000935 ProgramStateRef state = C.getState();
Ted Kremenek846eabd2010-12-01 21:28:31 +0000936 SValBuilder &svalBuilder = C.getSValBuilder();
Ted Kremenek5eca4822012-01-06 22:09:28 +0000937 const LocationContext *LCtx = C.getLocationContext();
938 SVal count = state->getSVal(CE->getArg(0), LCtx);
939 SVal elementSize = state->getSVal(CE->getArg(1), LCtx);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000940 SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize,
941 svalBuilder.getContext().getSizeType());
942 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000943
Anna Zaks87cb5be2012-02-22 19:24:52 +0000944 return MallocMemAux(C, CE, TotalSize, zeroVal, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000945}
946
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000947LeakInfo
Anna Zaksca8e36e2012-02-23 21:38:21 +0000948MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
949 CheckerContext &C) const {
Anna Zaks7752d292012-02-27 23:40:55 +0000950 const LocationContext *LeakContext = N->getLocationContext();
Anna Zaksca8e36e2012-02-23 21:38:21 +0000951 // Walk the ExplodedGraph backwards and find the first node that referred to
952 // the tracked symbol.
953 const ExplodedNode *AllocNode = N;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000954 const MemRegion *ReferenceRegion = 0;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000955
956 while (N) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000957 ProgramStateRef State = N->getState();
958 if (!State->get<RegionState>(Sym))
Anna Zaksca8e36e2012-02-23 21:38:21 +0000959 break;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000960
961 // Find the most recent expression bound to the symbol in the current
962 // context.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000963 if (!ReferenceRegion) {
Benjamin Kramer850f1b12012-03-21 21:03:48 +0000964 if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) {
965 SVal Val = State->getSVal(MR);
966 if (Val.getAsLocSymbol() == Sym)
967 ReferenceRegion = MR;
968 }
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000969 }
970
Anna Zaks7752d292012-02-27 23:40:55 +0000971 // Allocation node, is the last node in the current context in which the
972 // symbol was tracked.
973 if (N->getLocationContext() == LeakContext)
974 AllocNode = N;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000975 N = N->pred_empty() ? NULL : *(N->pred_begin());
976 }
977
978 ProgramPoint P = AllocNode->getLocation();
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000979 const Stmt *AllocationStmt = 0;
980 if (isa<StmtPoint>(P))
981 AllocationStmt = cast<StmtPoint>(P).getStmt();
Anna Zaks7752d292012-02-27 23:40:55 +0000982
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000983 return LeakInfo(AllocationStmt, ReferenceRegion);
Anna Zaksca8e36e2012-02-23 21:38:21 +0000984}
985
Anna Zaksda046772012-02-11 21:02:40 +0000986void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N,
987 CheckerContext &C) const {
988 assert(N);
989 if (!BT_Leak) {
Anna Zaksfebdc322012-02-16 22:26:12 +0000990 BT_Leak.reset(new BugType("Memory leak", "Memory Error"));
Anna Zaksda046772012-02-11 21:02:40 +0000991 // Leaks should not be reported if they are post-dominated by a sink:
992 // (1) Sinks are higher importance bugs.
993 // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending
994 // with __noreturn functions such as assert() or exit(). We choose not
995 // to report leaks on such paths.
996 BT_Leak->setSuppressOnSink(true);
997 }
998
Anna Zaksca8e36e2012-02-23 21:38:21 +0000999 // Most bug reports are cached at the location where they occurred.
1000 // With leaks, we want to unique them by the location where they were
1001 // allocated, and only report a single path.
Anna Zaks7752d292012-02-27 23:40:55 +00001002 PathDiagnosticLocation LocUsedForUniqueing;
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001003 const Stmt *AllocStmt = 0;
1004 const MemRegion *Region = 0;
1005 llvm::tie(AllocStmt, Region) = getAllocationSite(N, Sym, C);
1006 if (AllocStmt)
Anna Zaks7752d292012-02-27 23:40:55 +00001007 LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocStmt,
1008 C.getSourceManager(), N->getLocationContext());
Anna Zaksca8e36e2012-02-23 21:38:21 +00001009
Anna Zaks3d7c44e2012-03-21 19:45:08 +00001010 SmallString<200> buf;
1011 llvm::raw_svector_ostream os(buf);
1012 os << "Memory is never released; potential leak";
1013 if (Region) {
1014 os << " of memory pointed to by '";
1015 Region->dumpPretty(os);
1016 os <<'\'';
1017 }
1018
1019 BugReport *R = new BugReport(*BT_Leak, os.str(), N, LocUsedForUniqueing);
Ted Kremenek76aadc32012-03-09 01:13:14 +00001020 R->markInteresting(Sym);
Anna Zaks88feba02012-05-10 01:37:40 +00001021 R->addVisitor(new MallocBugVisitor(Sym, true));
Anna Zaksda046772012-02-11 21:02:40 +00001022 C.EmitReport(R);
1023}
1024
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001025void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper,
1026 CheckerContext &C) const
Ted Kremenekc8413fd2010-12-02 07:49:45 +00001027{
Zhongxing Xu173ff562010-08-15 08:19:57 +00001028 if (!SymReaper.hasDeadSymbols())
1029 return;
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001030
Ted Kremenek8bef8232012-01-26 21:29:00 +00001031 ProgramStateRef state = C.getState();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001032 RegionStateTy RS = state->get<RegionState>();
Jordy Rose90760142010-08-18 04:33:47 +00001033 RegionStateTy::Factory &F = state->get_context<RegionState>();
Zhongxing Xu173ff562010-08-15 08:19:57 +00001034
Ted Kremenek217470e2011-07-28 23:07:51 +00001035 bool generateReport = false;
Anna Zaksf8c17b72012-02-09 06:48:19 +00001036 llvm::SmallVector<SymbolRef, 2> Errors;
Zhongxing Xu173ff562010-08-15 08:19:57 +00001037 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
1038 if (SymReaper.isDead(I->first)) {
Anna Zaksf8c17b72012-02-09 06:48:19 +00001039 if (I->second.isAllocated()) {
Ted Kremenek217470e2011-07-28 23:07:51 +00001040 generateReport = true;
Anna Zaksf8c17b72012-02-09 06:48:19 +00001041 Errors.push_back(I->first);
1042 }
Jordy Rose90760142010-08-18 04:33:47 +00001043 // Remove the dead symbol from the map.
Ted Kremenek3baf6722010-11-24 00:54:37 +00001044 RS = F.remove(RS, I->first);
Ted Kremenek217470e2011-07-28 23:07:51 +00001045
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +00001046 }
1047 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001048
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001049 // Cleanup the Realloc Pairs Map.
Anna Zaks40add292012-02-15 00:11:25 +00001050 ReallocMap RP = state->get<ReallocPairs>();
1051 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
1052 if (SymReaper.isDead(I->first) ||
1053 SymReaper.isDead(I->second.ReallocatedSym)) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001054 state = state->remove<ReallocPairs>(I->first);
1055 }
1056 }
1057
Anna Zaksca8e36e2012-02-23 21:38:21 +00001058 // Generate leak node.
1059 static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak");
1060 ExplodedNode *N = C.addTransition(C.getState(), C.getPredecessor(), &Tag);
Ted Kremenek217470e2011-07-28 23:07:51 +00001061
Anna Zaksca8e36e2012-02-23 21:38:21 +00001062 if (generateReport) {
Anna Zaksf8c17b72012-02-09 06:48:19 +00001063 for (llvm::SmallVector<SymbolRef, 2>::iterator
Anna Zaksda046772012-02-11 21:02:40 +00001064 I = Errors.begin(), E = Errors.end(); I != E; ++I) {
1065 reportLeak(*I, N, C);
Anna Zaksf8c17b72012-02-09 06:48:19 +00001066 }
Ted Kremenek217470e2011-07-28 23:07:51 +00001067 }
Anna Zaksca8e36e2012-02-23 21:38:21 +00001068 C.addTransition(state->set<RegionState>(RS), N);
Zhongxing Xu7b760962009-11-13 07:25:27 +00001069}
Zhongxing Xu243fde92009-11-17 07:54:15 +00001070
Anna Zaksda046772012-02-11 21:02:40 +00001071void MallocChecker::checkEndPath(CheckerContext &C) const {
1072 ProgramStateRef state = C.getState();
Jordy Rose09cef092010-08-18 04:26:59 +00001073 RegionStateTy M = state->get<RegionState>();
Zhongxing Xu243fde92009-11-17 07:54:15 +00001074
Anna Zaksa19581a2012-02-20 22:25:23 +00001075 // If inside inlined call, skip it.
1076 if (C.getLocationContext()->getParent() != 0)
1077 return;
1078
Jordy Rose09cef092010-08-18 04:26:59 +00001079 for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) {
Zhongxing Xu243fde92009-11-17 07:54:15 +00001080 RefState RS = I->second;
1081 if (RS.isAllocated()) {
Anna Zaksda046772012-02-11 21:02:40 +00001082 ExplodedNode *N = C.addTransition(state);
1083 if (N)
1084 reportLeak(I->first, N, C);
Zhongxing Xu243fde92009-11-17 07:54:15 +00001085 }
1086 }
1087}
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001088
Anna Zaks91c2a112012-02-08 23:16:56 +00001089bool MallocChecker::checkEscape(SymbolRef Sym, const Stmt *S,
1090 CheckerContext &C) const {
Ted Kremenek8bef8232012-01-26 21:29:00 +00001091 ProgramStateRef state = C.getState();
Anna Zaks91c2a112012-02-08 23:16:56 +00001092 const RefState *RS = state->get<RegionState>(Sym);
1093 if (!RS)
1094 return false;
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001095
Anna Zaks91c2a112012-02-08 23:16:56 +00001096 if (RS->isAllocated()) {
1097 state = state->set<RegionState>(Sym, RefState::getEscaped(S));
1098 C.addTransition(state);
1099 return true;
1100 }
1101 return false;
1102}
1103
Anna Zaks66c40402012-02-14 21:55:24 +00001104void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const {
Anna Zaks14345182012-05-18 01:16:10 +00001105 // We will check for double free in the post visit.
1106 if (isFreeFunction(C.getCalleeDecl(CE), C.getASTContext()))
Anna Zaks66c40402012-02-14 21:55:24 +00001107 return;
1108
1109 // Check use after free, when a freed pointer is passed to a call.
1110 ProgramStateRef State = C.getState();
1111 for (CallExpr::const_arg_iterator I = CE->arg_begin(),
1112 E = CE->arg_end(); I != E; ++I) {
1113 const Expr *A = *I;
1114 if (A->getType().getTypePtr()->isAnyPointerType()) {
1115 SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol();
1116 if (!Sym)
1117 continue;
1118 if (checkUseAfterFree(Sym, C, A))
1119 return;
1120 }
1121 }
1122}
1123
Anna Zaks91c2a112012-02-08 23:16:56 +00001124void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const {
1125 const Expr *E = S->getRetValue();
1126 if (!E)
1127 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001128
1129 // Check if we are returning a symbol.
Anna Zaksd9ab7bb2012-02-22 02:36:01 +00001130 SVal RetVal = C.getState()->getSVal(E, C.getLocationContext());
1131 SymbolRef Sym = RetVal.getAsSymbol();
1132 if (!Sym)
1133 // If we are returning a field of the allocated struct or an array element,
1134 // the callee could still free the memory.
1135 // TODO: This logic should be a part of generic symbol escape callback.
1136 if (const MemRegion *MR = RetVal.getAsRegion())
1137 if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR))
1138 if (const SymbolicRegion *BMR =
1139 dyn_cast<SymbolicRegion>(MR->getBaseRegion()))
1140 Sym = BMR->getSymbol();
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001141 if (!Sym)
1142 return;
1143
Anna Zaks0860cd02012-02-11 21:44:39 +00001144 // Check if we are returning freed memory.
Anna Zaksfe571602012-02-16 22:26:07 +00001145 if (checkUseAfterFree(Sym, C, E))
Anna Zaks15d0ae12012-02-11 23:46:36 +00001146 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001147
Anna Zaksa19581a2012-02-20 22:25:23 +00001148 // If this function body is not inlined, check if the symbol is escaping.
1149 if (C.getLocationContext()->getParent() == 0)
1150 checkEscape(Sym, E, C);
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001151}
Zhongxing Xub94b81a2009-12-31 06:13:07 +00001152
Anna Zaksf5aa3f52012-03-22 00:57:20 +00001153// TODO: Blocks should be either inlined or should call invalidate regions
1154// upon invocation. After that's in place, special casing here will not be
1155// needed.
1156void MallocChecker::checkPostStmt(const BlockExpr *BE,
1157 CheckerContext &C) const {
1158
1159 // Scan the BlockDecRefExprs for any object the retain count checker
1160 // may be tracking.
1161 if (!BE->getBlockDecl()->hasCaptures())
1162 return;
1163
1164 ProgramStateRef state = C.getState();
1165 const BlockDataRegion *R =
1166 cast<BlockDataRegion>(state->getSVal(BE,
1167 C.getLocationContext()).getAsRegion());
1168
1169 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
1170 E = R->referenced_vars_end();
1171
1172 if (I == E)
1173 return;
1174
1175 SmallVector<const MemRegion*, 10> Regions;
1176 const LocationContext *LC = C.getLocationContext();
1177 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
1178
1179 for ( ; I != E; ++I) {
1180 const VarRegion *VR = *I;
1181 if (VR->getSuperRegion() == R) {
1182 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
1183 }
1184 Regions.push_back(VR);
1185 }
1186
1187 state =
1188 state->scanReachableSymbols<StopTrackingCallback>(Regions.data(),
1189 Regions.data() + Regions.size()).getState();
1190 C.addTransition(state);
1191}
1192
Anna Zaks14345182012-05-18 01:16:10 +00001193bool MallocChecker::isReleased(SymbolRef Sym, CheckerContext &C) const {
Anna Zaks91c2a112012-02-08 23:16:56 +00001194 assert(Sym);
1195 const RefState *RS = C.getState()->get<RegionState>(Sym);
Anna Zaks14345182012-05-18 01:16:10 +00001196 return (RS && RS->isReleased());
1197}
1198
1199bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
1200 const Stmt *S) const {
1201 if (isReleased(Sym, C)) {
Anna Zaks15d0ae12012-02-11 23:46:36 +00001202 if (ExplodedNode *N = C.generateSink()) {
Anna Zaks91c2a112012-02-08 23:16:56 +00001203 if (!BT_UseFree)
Anna Zaksfebdc322012-02-16 22:26:12 +00001204 BT_UseFree.reset(new BugType("Use-after-free", "Memory Error"));
Anna Zaks91c2a112012-02-08 23:16:56 +00001205
Anna Zaksfebdc322012-02-16 22:26:12 +00001206 BugReport *R = new BugReport(*BT_UseFree,
1207 "Use of memory after it is freed",N);
Anna Zaks91c2a112012-02-08 23:16:56 +00001208 if (S)
1209 R->addRange(S->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +00001210 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001211 R->addVisitor(new MallocBugVisitor(Sym));
Anna Zaks91c2a112012-02-08 23:16:56 +00001212 C.EmitReport(R);
1213 return true;
1214 }
1215 }
1216 return false;
1217}
1218
Zhongxing Xuc8023782010-03-10 04:58:55 +00001219// Check if the location is a freed symbolic region.
Anna Zaks390909c2011-10-06 00:43:15 +00001220void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S,
1221 CheckerContext &C) const {
Zhongxing Xuc8023782010-03-10 04:58:55 +00001222 SymbolRef Sym = l.getLocSymbolInBase();
Anna Zaks91c2a112012-02-08 23:16:56 +00001223 if (Sym)
Anna Zaks14345182012-05-18 01:16:10 +00001224 checkUseAfterFree(Sym, C, S);
Zhongxing Xuc8023782010-03-10 04:58:55 +00001225}
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001226
Anna Zaks4fb54872012-02-11 21:02:35 +00001227//===----------------------------------------------------------------------===//
1228// Check various ways a symbol can be invalidated.
1229// TODO: This logic (the next 3 functions) is copied/similar to the
1230// RetainRelease checker. We might want to factor this out.
1231//===----------------------------------------------------------------------===//
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001232
Anna Zaks4fb54872012-02-11 21:02:35 +00001233// Stop tracking symbols when a value escapes as a result of checkBind.
1234// A value escapes in three possible cases:
1235// (1) we are binding to something that is not a memory region.
1236// (2) we are binding to a memregion that does not have stack storage
1237// (3) we are binding to a memregion with stack storage that the store
1238// does not understand.
1239void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S,
1240 CheckerContext &C) const {
1241 // Are we storing to something that causes the value to "escape"?
1242 bool escapes = true;
Ted Kremenek8bef8232012-01-26 21:29:00 +00001243 ProgramStateRef state = C.getState();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001244
Anna Zaks4fb54872012-02-11 21:02:35 +00001245 if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) {
1246 escapes = !regionLoc->getRegion()->hasStackStorage();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001247
Anna Zaks4fb54872012-02-11 21:02:35 +00001248 if (!escapes) {
1249 // To test (3), generate a new state with the binding added. If it is
1250 // the same state, then it escapes (since the store cannot represent
1251 // the binding).
Anna Zaks93c5a242012-05-02 00:05:20 +00001252 // Do this only if we know that the store is not supposed to generate the
1253 // same state.
1254 SVal StoredVal = state->getSVal(regionLoc->getRegion());
1255 if (StoredVal != val)
1256 escapes = (state == (state->bindLoc(*regionLoc, val)));
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001257 }
Anna Zaksac593002012-02-16 03:40:57 +00001258 if (!escapes) {
1259 // Case 4: We do not currently model what happens when a symbol is
1260 // assigned to a struct field, so be conservative here and let the symbol
1261 // go. TODO: This could definitely be improved upon.
1262 escapes = !isa<VarRegion>(regionLoc->getRegion());
1263 }
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001264 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001265
1266 // If our store can represent the binding and we aren't storing to something
1267 // that doesn't have local storage then just return and have the simulation
1268 // state continue as is.
1269 if (!escapes)
1270 return;
1271
1272 // Otherwise, find all symbols referenced by 'val' that we are tracking
1273 // and stop tracking them.
1274 state = state->scanReachableSymbols<StopTrackingCallback>(val).getState();
1275 C.addTransition(state);
1276}
1277
1278// If a symbolic region is assumed to NULL (or another constant), stop tracking
1279// it - assuming that allocation failed on this path.
1280ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state,
1281 SVal Cond,
1282 bool Assumption) const {
1283 RegionStateTy RS = state->get<RegionState>();
Anna Zaks4fb54872012-02-11 21:02:35 +00001284 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
1285 // If the symbol is assumed to NULL or another constant, this will
1286 // return an APSInt*.
1287 if (state->getSymVal(I.getKey()))
1288 state = state->remove<RegionState>(I.getKey());
1289 }
1290
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001291 // Realloc returns 0 when reallocation fails, which means that we should
1292 // restore the state of the pointer being reallocated.
Anna Zaks40add292012-02-15 00:11:25 +00001293 ReallocMap RP = state->get<ReallocPairs>();
1294 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001295 // If the symbol is assumed to NULL or another constant, this will
1296 // return an APSInt*.
1297 if (state->getSymVal(I.getKey())) {
Anna Zaks40add292012-02-15 00:11:25 +00001298 SymbolRef ReallocSym = I.getData().ReallocatedSym;
1299 const RefState *RS = state->get<RegionState>(ReallocSym);
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001300 if (RS) {
Anna Zaks40add292012-02-15 00:11:25 +00001301 if (RS->isReleased() && ! I.getData().IsFreeOnFailure)
1302 state = state->set<RegionState>(ReallocSym,
Anna Zaks050cdd72012-06-20 20:57:46 +00001303 RefState::getAllocated(RS->getStmt()));
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001304 }
1305 state = state->remove<ReallocPairs>(I.getKey());
1306 }
1307 }
1308
Anna Zaks4fb54872012-02-11 21:02:35 +00001309 return state;
1310}
1311
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001312// Check if the function is known to us. So, for example, we could
Anna Zaks66c40402012-02-14 21:55:24 +00001313// conservatively assume it can free/reallocate it's pointer arguments.
1314// (We assume that the pointers cannot escape through calls to system
1315// functions not handled by this checker.)
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001316bool MallocChecker::doesNotFreeMemory(const CallOrObjCMessage *Call,
1317 ProgramStateRef State) const {
1318 if (!Call)
1319 return false;
1320
1321 // For now, assume that any C++ call can free memory.
1322 // TODO: If we want to be more optimistic here, we'll need to make sure that
1323 // regions escape to C++ containers. They seem to do that even now, but for
1324 // mysterious reasons.
1325 if (Call->isCXXCall())
1326 return false;
1327
1328 const Decl *D = Call->getDecl();
1329 if (!D)
1330 return false;
1331
Anna Zaks66c40402012-02-14 21:55:24 +00001332 ASTContext &ASTC = State->getStateManager().getContext();
1333
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001334 // If it's one of the allocation functions we can reason about, we model
Jordy Rose257c60f2012-03-06 00:28:20 +00001335 // its behavior explicitly.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001336 if (isa<FunctionDecl>(D) && isMemFunction(cast<FunctionDecl>(D), ASTC)) {
1337 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001338 }
1339
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001340 // If it's not a system call, assume it frees memory.
Anna Zaks66c40402012-02-14 21:55:24 +00001341 SourceManager &SM = ASTC.getSourceManager();
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001342 if (!SM.isInSystemHeader(D->getLocation()))
1343 return false;
Anna Zaks0d389b82012-02-23 01:05:27 +00001344
Anna Zaks07d39a42012-02-28 01:54:22 +00001345 // Process C/ObjC functions.
Jordy Rose257c60f2012-03-06 00:28:20 +00001346 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
Anna Zaks0d389b82012-02-23 01:05:27 +00001347 // White list the system functions whose arguments escape.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001348 const IdentifierInfo *II = FD->getIdentifier();
Anna Zaks07d39a42012-02-28 01:54:22 +00001349 if (!II)
1350 return true;
1351 StringRef FName = II->getName();
1352
1353 // White list thread local storage.
1354 if (FName.equals("pthread_setspecific"))
1355 return false;
1356
Anna Zaks52a04812012-06-20 23:35:57 +00001357 // White list xpc connection context.
1358 // TODO: Ensure that the deallocation actually happens, need to reason
1359 // about "xpc_connection_set_finalizer_f".
1360 if (FName.equals("xpc_connection_set_context"))
1361 return false;
1362
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001363 // White list the 'XXXNoCopy' ObjC functions.
Anna Zaks07d39a42012-02-28 01:54:22 +00001364 if (FName.endswith("NoCopy")) {
1365 // Look for the deallocator argument. We know that the memory ownership
Benjamin Kramer48d798c2012-06-02 10:20:41 +00001366 // is not transferred only if the deallocator argument is
Anna Zaks07d39a42012-02-28 01:54:22 +00001367 // 'kCFAllocatorNull'.
1368 for (unsigned i = 1; i < Call->getNumArgs(); ++i) {
1369 const Expr *ArgE = Call->getArg(i)->IgnoreParenCasts();
1370 if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) {
1371 StringRef DeallocatorName = DE->getFoundDecl()->getName();
1372 if (DeallocatorName == "kCFAllocatorNull")
1373 return true;
1374 }
1375 }
1376 return false;
Anna Zaks0d389b82012-02-23 01:05:27 +00001377 }
1378
Anna Zaksca23eb22012-02-29 18:42:47 +00001379 // PR12101
1380 // Many CoreFoundation and CoreGraphics might allow a tracked object
1381 // to escape.
1382 if (Call->isCFCGAllowingEscape(FName))
1383 return false;
1384
1385 // Associating streams with malloced buffers. The pointer can escape if
1386 // 'closefn' is specified (and if that function does free memory).
1387 // Currently, we do not inspect the 'closefn' function (PR12101).
1388 if (FName == "funopen")
1389 if (Call->getNumArgs() >= 4 && !Call->getArgSVal(4).isConstant(0))
1390 return false;
1391
1392 // Do not warn on pointers passed to 'setbuf' when used with std streams,
1393 // these leaks might be intentional when setting the buffer for stdio.
1394 // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer
1395 if (FName == "setbuf" || FName =="setbuffer" ||
1396 FName == "setlinebuf" || FName == "setvbuf") {
1397 if (Call->getNumArgs() >= 1)
1398 if (const DeclRefExpr *Arg =
1399 dyn_cast<DeclRefExpr>(Call->getArg(0)->IgnoreParenCasts()))
1400 if (const VarDecl *D = dyn_cast<VarDecl>(Arg->getDecl()))
1401 if (D->getCanonicalDecl()->getName().find("std")
1402 != StringRef::npos)
1403 return false;
1404 }
1405
Jordan Rose1bf908d2012-06-16 00:09:20 +00001406 // A bunch of other functions which either take ownership of a pointer or
1407 // wrap the result up in a struct or object, meaning it can be freed later.
1408 // (See RetainCountChecker.) Not all the parameters here are invalidated,
1409 // but the Malloc checker cannot differentiate between them. The right way
1410 // of doing this would be to implement a pointer escapes callback.
1411 if (FName == "CGBitmapContextCreate" ||
Anna Zaksca23eb22012-02-29 18:42:47 +00001412 FName == "CGBitmapContextCreateWithData" ||
Jordan Rose1bf908d2012-06-16 00:09:20 +00001413 FName == "CVPixelBufferCreateWithBytes" ||
Anna Zaks4cd7edf2012-03-26 18:18:39 +00001414 FName == "CVPixelBufferCreateWithPlanarBytes" ||
1415 FName == "OSAtomicEnqueue") {
Anna Zaksca23eb22012-02-29 18:42:47 +00001416 return false;
1417 }
1418
Anna Zaks62a5c342012-03-30 05:48:16 +00001419 // Whitelist NSXXInsertXX, for example NSMapInsertIfAbsent, since they can
1420 // be deallocated by NSMapRemove.
1421 if (FName.startswith("NS") && (FName.find("Insert") != StringRef::npos))
1422 return false;
1423
Anna Zaksaca0ac52012-05-03 23:50:28 +00001424 // If the call has a callback as an argument, assume the memory
1425 // can be freed.
1426 if (Call->hasNonZeroCallbackArg())
1427 return false;
1428
Anna Zaks0d389b82012-02-23 01:05:27 +00001429 // Otherwise, assume that the function does not free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001430 // Most system calls, do not free the memory.
1431 return true;
1432
1433 // Process ObjC functions.
1434 } else if (const ObjCMethodDecl * ObjCD = dyn_cast<ObjCMethodDecl>(D)) {
1435 Selector S = ObjCD->getSelector();
1436
1437 // White list the ObjC functions which do free memory.
1438 // - Anything containing 'freeWhenDone' param set to 1.
1439 // Ex: dataWithBytesNoCopy:length:freeWhenDone.
Anna Zaks3e4f65d2012-06-22 22:08:09 +00001440 for (unsigned i = 1; i < S.getNumArgs(); ++i) {
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001441 if (S.getNameForSlot(i).equals("freeWhenDone")) {
1442 if (Call->getArgSVal(i).isConstant(1))
1443 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001444 else
1445 return true;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001446 }
1447 }
1448
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001449 // If the first selector ends with NoCopy, assume that the ownership is
Benjamin Kramer48d798c2012-06-02 10:20:41 +00001450 // transferred as well.
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001451 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
1452 if (S.getNameForSlot(0).endswith("NoCopy")) {
1453 return false;
1454 }
1455
Anna Zaks5f757682012-06-19 05:10:32 +00001456 // If the first selector starts with addPointer, insertPointer,
1457 // or replacePointer, assume we are dealing with NSPointerArray or similar.
1458 // This is similar to C++ containers (vector); we still might want to check
1459 // that the pointers get freed, by following the container itself.
1460 if (S.getNameForSlot(0).startswith("addPointer") ||
1461 S.getNameForSlot(0).startswith("insertPointer") ||
1462 S.getNameForSlot(0).startswith("replacePointer")) {
1463 return false;
1464 }
1465
Anna Zaksaca0ac52012-05-03 23:50:28 +00001466 // If the call has a callback as an argument, assume the memory
1467 // can be freed.
1468 if (Call->hasNonZeroCallbackArg())
1469 return false;
1470
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001471 // Otherwise, assume that the function does not free memory.
1472 // Most system calls, do not free the memory.
1473 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001474 }
1475
1476 // Otherwise, assume that the function can free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001477 return false;
1478
Anna Zaks66c40402012-02-14 21:55:24 +00001479}
1480
Anna Zaks4fb54872012-02-11 21:02:35 +00001481// If the symbol we are tracking is invalidated, but not explicitly (ex: the &p
1482// escapes, when we are tracking p), do not track the symbol as we cannot reason
1483// about it anymore.
1484ProgramStateRef
Anna Zaks66c40402012-02-14 21:55:24 +00001485MallocChecker::checkRegionChanges(ProgramStateRef State,
Anna Zaks4fb54872012-02-11 21:02:35 +00001486 const StoreManager::InvalidatedSymbols *invalidated,
1487 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +00001488 ArrayRef<const MemRegion *> Regions,
1489 const CallOrObjCMessage *Call) const {
Anna Zaks0d389b82012-02-23 01:05:27 +00001490 if (!invalidated || invalidated->empty())
Anna Zaks66c40402012-02-14 21:55:24 +00001491 return State;
Anna Zaks4fb54872012-02-11 21:02:35 +00001492 llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols;
Anna Zaks66c40402012-02-14 21:55:24 +00001493
Anna Zaks66c40402012-02-14 21:55:24 +00001494 // If it's a call which might free or reallocate memory, we assume that all
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001495 // regions (explicit and implicit) escaped.
1496
1497 // Otherwise, whitelist explicit pointers; we still can track them.
1498 if (!Call || doesNotFreeMemory(Call, State)) {
Anna Zaks66c40402012-02-14 21:55:24 +00001499 for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(),
1500 E = ExplicitRegions.end(); I != E; ++I) {
1501 if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>())
1502 WhitelistedSymbols.insert(R->getSymbol());
1503 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001504 }
1505
1506 for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(),
1507 E = invalidated->end(); I!=E; ++I) {
1508 SymbolRef sym = *I;
1509 if (WhitelistedSymbols.count(sym))
1510 continue;
Anna Zaks5b7aa342012-06-22 02:04:31 +00001511 // The symbol escaped. Note, we assume that if the symbol is released,
1512 // passing it out will result in a use after free. We also keep tracking
1513 // relinquished symbols.
1514 if (const RefState *RS = State->get<RegionState>(sym)) {
1515 if (RS->isAllocated())
1516 State = State->set<RegionState>(sym,
1517 RefState::getEscaped(RS->getStmt()));
1518 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001519 }
Anna Zaks66c40402012-02-14 21:55:24 +00001520 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001521}
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001522
Jordy Rose393f98b2012-03-18 07:43:35 +00001523static SymbolRef findFailedReallocSymbol(ProgramStateRef currState,
1524 ProgramStateRef prevState) {
1525 ReallocMap currMap = currState->get<ReallocPairs>();
1526 ReallocMap prevMap = prevState->get<ReallocPairs>();
1527
1528 for (ReallocMap::iterator I = prevMap.begin(), E = prevMap.end();
1529 I != E; ++I) {
1530 SymbolRef sym = I.getKey();
1531 if (!currMap.lookup(sym))
1532 return sym;
1533 }
1534
1535 return NULL;
1536}
1537
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001538PathDiagnosticPiece *
1539MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N,
1540 const ExplodedNode *PrevN,
1541 BugReporterContext &BRC,
1542 BugReport &BR) {
Jordy Rose393f98b2012-03-18 07:43:35 +00001543 ProgramStateRef state = N->getState();
1544 ProgramStateRef statePrev = PrevN->getState();
1545
1546 const RefState *RS = state->get<RegionState>(Sym);
1547 const RefState *RSPrev = statePrev->get<RegionState>(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001548 if (!RS && !RSPrev)
1549 return 0;
1550
Anna Zaksfe571602012-02-16 22:26:07 +00001551 const Stmt *S = 0;
1552 const char *Msg = 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001553 StackHintGeneratorForSymbol *StackHint = 0;
Anna Zaksfe571602012-02-16 22:26:07 +00001554
1555 // Retrieve the associated statement.
1556 ProgramPoint ProgLoc = N->getLocation();
1557 if (isa<StmtPoint>(ProgLoc))
1558 S = cast<StmtPoint>(ProgLoc).getStmt();
1559 // If an assumption was made on a branch, it should be caught
1560 // here by looking at the state transition.
1561 if (isa<BlockEdge>(ProgLoc)) {
1562 const CFGBlock *srcBlk = cast<BlockEdge>(ProgLoc).getSrc();
1563 S = srcBlk->getTerminator();
1564 }
1565 if (!S)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001566 return 0;
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001567
1568 // Find out if this is an interesting point and what is the kind.
Anna Zaksfe571602012-02-16 22:26:07 +00001569 if (Mode == Normal) {
Anna Zaks368a0d52012-03-15 21:13:02 +00001570 if (isAllocated(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001571 Msg = "Memory is allocated";
Anna Zaksfbd58742012-03-16 23:44:28 +00001572 StackHint = new StackHintGeneratorForSymbol(Sym,
1573 "Returned allocated memory");
Anna Zaks368a0d52012-03-15 21:13:02 +00001574 } else if (isReleased(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001575 Msg = "Memory is released";
Anna Zaksfbd58742012-03-16 23:44:28 +00001576 StackHint = new StackHintGeneratorForSymbol(Sym,
1577 "Returned released memory");
Anna Zaks5b7aa342012-06-22 02:04:31 +00001578 } else if (isRelinquished(RS, RSPrev, S)) {
1579 Msg = "Memory ownership is transfered";
1580 StackHint = new StackHintGeneratorForSymbol(Sym, "");
Anna Zaks368a0d52012-03-15 21:13:02 +00001581 } else if (isReallocFailedCheck(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001582 Mode = ReallocationFailed;
1583 Msg = "Reallocation failed";
Anna Zaks56a938f2012-03-16 23:24:20 +00001584 StackHint = new StackHintGeneratorForReallocationFailed(Sym,
Anna Zaksfbd58742012-03-16 23:44:28 +00001585 "Reallocation failed");
Jordy Rose393f98b2012-03-18 07:43:35 +00001586
Jordy Roseb000fb52012-03-24 03:15:09 +00001587 if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) {
1588 // Is it possible to fail two reallocs WITHOUT testing in between?
1589 assert((!FailedReallocSymbol || FailedReallocSymbol == sym) &&
1590 "We only support one failed realloc at a time.");
Jordy Rose393f98b2012-03-18 07:43:35 +00001591 BR.markInteresting(sym);
Jordy Roseb000fb52012-03-24 03:15:09 +00001592 FailedReallocSymbol = sym;
1593 }
Anna Zaksfe571602012-02-16 22:26:07 +00001594 }
1595
1596 // We are in a special mode if a reallocation failed later in the path.
1597 } else if (Mode == ReallocationFailed) {
Jordy Roseb000fb52012-03-24 03:15:09 +00001598 assert(FailedReallocSymbol && "No symbol to look for.");
Anna Zaksfe571602012-02-16 22:26:07 +00001599
Jordy Roseb000fb52012-03-24 03:15:09 +00001600 // Is this is the first appearance of the reallocated symbol?
1601 if (!statePrev->get<RegionState>(FailedReallocSymbol)) {
1602 // If we ever hit this assert, that means BugReporter has decided to skip
1603 // node pairs or visit them out of order.
1604 assert(state->get<RegionState>(FailedReallocSymbol) &&
1605 "Missed the reallocation point");
1606
1607 // We're at the reallocation point.
1608 Msg = "Attempt to reallocate memory";
1609 StackHint = new StackHintGeneratorForSymbol(Sym,
1610 "Returned reallocated memory");
1611 FailedReallocSymbol = NULL;
1612 Mode = Normal;
1613 }
Anna Zaksfe571602012-02-16 22:26:07 +00001614 }
1615
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001616 if (!Msg)
1617 return 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001618 assert(StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001619
1620 // Generate the extra diagnostic.
Anna Zaksfe571602012-02-16 22:26:07 +00001621 PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001622 N->getLocationContext());
Anna Zaks56a938f2012-03-16 23:24:20 +00001623 return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001624}
1625
Anna Zaks93c5a242012-05-02 00:05:20 +00001626void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State,
1627 const char *NL, const char *Sep) const {
1628
1629 RegionStateTy RS = State->get<RegionState>();
1630
1631 if (!RS.isEmpty())
1632 Out << "Has Malloc data" << NL;
1633}
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001634
Anna Zaks231361a2012-02-08 23:16:52 +00001635#define REGISTER_CHECKER(name) \
1636void ento::register##name(CheckerManager &mgr) {\
Anna Zaksf0dfc9c2012-02-17 22:35:31 +00001637 registerCStringCheckerBasic(mgr); \
Anna Zaks231361a2012-02-08 23:16:52 +00001638 mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001639}
Anna Zaks231361a2012-02-08 23:16:52 +00001640
1641REGISTER_CHECKER(MallocPessimistic)
1642REGISTER_CHECKER(MallocOptimistic)