blob: e6ce6e3c4ab8e103ea7803b2037dc3b1a6c6394e [file] [log] [blame]
Ted Kremenek1ad35be2011-07-14 17:05:32 +00001// RUN: %clang_cc1 -fsyntax-only -verify -Wformat-nonliteral %s
Chris Lattner59907c42007-08-10 20:18:51 +00002
Chris Lattner59907c42007-08-10 20:18:51 +00003#include <stdarg.h>
Daniel Dunbar23afaad2009-11-17 08:57:36 +00004typedef __typeof(sizeof(int)) size_t;
5typedef struct _FILE FILE;
6int fprintf(FILE *, const char *restrict, ...);
Douglas Gregora41a8c52010-04-22 00:20:18 +00007int printf(const char *restrict, ...); // expected-note{{passing argument to parameter here}}
Daniel Dunbar23afaad2009-11-17 08:57:36 +00008int snprintf(char *restrict, size_t, const char *restrict, ...);
9int sprintf(char *restrict, const char *restrict, ...);
10int vasprintf(char **, const char *, va_list);
Chris Lattnere0303582010-01-09 20:43:19 +000011int asprintf(char **, const char *, ...);
Daniel Dunbar23afaad2009-11-17 08:57:36 +000012int vfprintf(FILE *, const char *restrict, va_list);
13int vprintf(const char *restrict, va_list);
14int vsnprintf(char *, size_t, const char *, va_list);
Douglas Gregora41a8c52010-04-22 00:20:18 +000015int vsprintf(char *restrict, const char *restrict, va_list); // expected-note{{passing argument to parameter here}}
Chris Lattner59907c42007-08-10 20:18:51 +000016
Ted Kremenek4a336462007-12-17 19:03:13 +000017char * global_fmt;
18
Chris Lattner59907c42007-08-10 20:18:51 +000019void check_string_literal( FILE* fp, const char* s, char *buf, ... ) {
20
21 char * b;
22 va_list ap;
23 va_start(ap,buf);
24
25 printf(s); // expected-warning {{format string is not a string literal}}
Ted Kremenek4a336462007-12-17 19:03:13 +000026 vprintf(s,ap); // // no-warning
Chris Lattner59907c42007-08-10 20:18:51 +000027 fprintf(fp,s); // expected-warning {{format string is not a string literal}}
Ted Kremenek4a336462007-12-17 19:03:13 +000028 vfprintf(fp,s,ap); // no-warning
Chris Lattner59907c42007-08-10 20:18:51 +000029 asprintf(&b,s); // expected-warning {{format string is not a string lit}}
Ted Kremenek4a336462007-12-17 19:03:13 +000030 vasprintf(&b,s,ap); // no-warning
Chris Lattner59907c42007-08-10 20:18:51 +000031 sprintf(buf,s); // expected-warning {{format string is not a string literal}}
32 snprintf(buf,2,s); // expected-warning {{format string is not a string lit}}
Daniel Dunbarde454282008-10-02 18:44:07 +000033 __builtin___sprintf_chk(buf,0,-1,s); // expected-warning {{format string is not a string literal}}
34 __builtin___snprintf_chk(buf,2,0,-1,s); // expected-warning {{format string is not a string lit}}
Ted Kremenek4a336462007-12-17 19:03:13 +000035 vsprintf(buf,s,ap); // no-warning
36 vsnprintf(buf,2,s,ap); // no-warning
37 vsnprintf(buf,2,global_fmt,ap); // expected-warning {{format string is not a string literal}}
Daniel Dunbarde454282008-10-02 18:44:07 +000038 __builtin___vsnprintf_chk(buf,2,0,-1,s,ap); // no-warning
39 __builtin___vsnprintf_chk(buf,2,0,-1,global_fmt,ap); // expected-warning {{format string is not a string literal}}
Chris Lattner07f192e2009-02-18 18:25:31 +000040
Chris Lattnerd0d082f2009-02-18 18:34:12 +000041 // rdar://6079877
42 printf("abc"
Ted Kremenek31f8e322010-01-29 23:32:22 +000043 "%*d", 1, 1); // no-warning
Chris Lattnerd0d082f2009-02-18 18:34:12 +000044 printf("abc\
45def"
Ted Kremenek31f8e322010-01-29 23:32:22 +000046 "%*d", 1, 1); // no-warning
47
48 // <rdar://problem/6079850>, allow 'unsigned' (instead of 'int') to be used for both
49 // the field width and precision. This deviates from C99, but is reasonably safe
50 // and is also accepted by GCC.
51 printf("%*d", (unsigned) 1, 1); // no-warning
Chris Lattner59907c42007-08-10 20:18:51 +000052}
53
Ted Kremenekd30ef872009-01-12 23:09:09 +000054void check_conditional_literal(const char* s, int i) {
55 printf(i == 1 ? "yes" : "no"); // no-warning
56 printf(i == 0 ? (i == 1 ? "yes" : "no") : "dont know"); // no-warning
Ted Kremenek0fdea462009-01-12 23:09:55 +000057 printf(i == 0 ? (i == 1 ? s : "no") : "dont know"); // expected-warning{{format string is not a string literal}}
Ted Kremenek7f70dc82010-02-26 19:18:41 +000058 printf("yes" ?: "no %d", 1); // expected-warning{{data argument not used by format string}}
Ted Kremenekd30ef872009-01-12 23:09:09 +000059}
60
Ted Kremenek71895b92007-08-14 17:39:48 +000061void check_writeback_specifier()
62{
63 int x;
64 char *b;
65
66 printf("%n",&x); // expected-warning {{'%n' in format string discouraged}}
67 sprintf(b,"%d%%%n",1, &x); // expected-warning {{'%n' in format string dis}}
68}
69
70void check_invalid_specifier(FILE* fp, char *buf)
71{
Ted Kremenekf88c8e02010-01-29 20:55:36 +000072 printf("%s%lb%d","unix",10,20); // expected-warning {{invalid conversion specifier 'b'}}
73 fprintf(fp,"%%%l"); // expected-warning {{incomplete format specifier}}
Ted Kremenekce506ae2012-01-20 21:52:58 +000074 sprintf(buf,"%%%%%ld%d%d", 1, 2, 3); // expected-warning{{format specifies type 'long' but the argument has type 'int'}}
75 snprintf(buf, 2, "%%%%%ld%;%d", 1, 2, 3); // expected-warning{{format specifies type 'long' but the argument has type 'int'}} expected-warning {{invalid conversion specifier ';'}}
Ted Kremenek71895b92007-08-14 17:39:48 +000076}
77
78void check_null_char_string(char* b)
79{
80 printf("\0this is bogus%d",1); // expected-warning {{string contains '\0'}}
81 snprintf(b,10,"%%%%%d\0%d",1,2); // expected-warning {{string contains '\0'}}
82 printf("%\0d",1); // expected-warning {{string contains '\0'}}
83}
84
Anders Carlsson6eda8c92007-10-12 17:48:41 +000085void check_empty_format_string(char* buf, ...)
Ted Kremenek71895b92007-08-14 17:39:48 +000086{
87 va_list ap;
88 va_start(ap,buf);
89 vprintf("",ap); // expected-warning {{format string is empty}}
Ted Kremenek4cd57912011-09-29 05:52:16 +000090 sprintf(buf, "", 1); // expected-warning {{format string is empty}}
91
92 // Don't warn about empty format strings when there are no data arguments.
93 // This can arise from macro expansions and non-standard format string
94 // functions.
95 sprintf(buf, ""); // no-warning
Ted Kremenek71895b92007-08-14 17:39:48 +000096}
97
Anders Carlsson6eda8c92007-10-12 17:48:41 +000098void check_wide_string(char* b, ...)
Ted Kremenek71895b92007-08-14 17:39:48 +000099{
Ted Kremenek71895b92007-08-14 17:39:48 +0000100 va_list ap;
101 va_start(ap,b);
102
Daniel Dunbar4489fe12008-08-05 00:07:51 +0000103 printf(L"foo %d",2); // expected-warning {{incompatible pointer types}}, expected-warning {{should not be a wide string}}
John Thompsonaddb0f62009-10-29 00:10:42 +0000104 vsprintf(b,L"bar %d",ap); // expected-warning {{incompatible pointer types}}, expected-warning {{should not be a wide string}}
Ted Kremenek71895b92007-08-14 17:39:48 +0000105}
Ted Kremenek580b6642007-10-12 20:51:52 +0000106
107void check_asterisk_precision_width(int x) {
108 printf("%*d"); // expected-warning {{'*' specified field width is missing a matching 'int' argument}}
109 printf("%.*d"); // expected-warning {{'.*' specified field precision is missing a matching 'int' argument}}
110 printf("%*d",12,x); // no-warning
111 printf("%*d","foo",x); // expected-warning {{field width should have type 'int', but argument has type 'char *'}}
112 printf("%.*d","foo",x); // expected-warning {{field precision should have type 'int', but argument has type 'char *'}}
Daniel Dunbar4489fe12008-08-05 00:07:51 +0000113}
Douglas Gregor3c385e52009-02-14 18:57:46 +0000114
115void __attribute__((format(printf,1,3))) myprintf(const char*, int blah, ...);
116
117void test_myprintf() {
118 myprintf("%d", 17, 18); // okay
119}
Ted Kremenek082d9362009-03-20 21:35:28 +0000120
121void test_constant_bindings(void) {
122 const char * const s1 = "hello";
123 const char s2[] = "hello";
124 const char *s3 = "hello";
125 char * const s4 = "hello";
126 extern const char s5[];
127
128 printf(s1); // no-warning
129 printf(s2); // no-warning
130 printf(s3); // expected-warning{{not a string literal}}
131 printf(s4); // expected-warning{{not a string literal}}
132 printf(s5); // expected-warning{{not a string literal}}
133}
Chris Lattner655f1412009-04-29 04:59:47 +0000134
135
136// Test what happens when -Wformat-security only.
137#pragma GCC diagnostic ignored "-Wformat-nonliteral"
138#pragma GCC diagnostic warning "-Wformat-security"
139
140void test9(char *P) {
141 int x;
142 printf(P); // expected-warning {{format string is not a string literal (potentially insecure)}}
143 printf(P, 42);
144 printf("%n", &x); // expected-warning {{use of '%n' in format string discouraged }}
145}
Ted Kremenek42ae3e82009-05-13 16:06:05 +0000146
147void torture(va_list v8) {
148 vprintf ("%*.*d", v8); // no-warning
Ted Kremenek31f8e322010-01-29 23:32:22 +0000149
Ted Kremenek42ae3e82009-05-13 16:06:05 +0000150}
151
Daniel Dunbar01aefc62010-01-30 15:49:20 +0000152void test10(int x, float f, int i, long long lli) {
Ted Kremeneke3fc5472010-02-27 08:34:51 +0000153 printf("%s"); // expected-warning{{more '%' conversions than data arguments}}
Ted Kremenekf88c8e02010-01-29 20:55:36 +0000154 printf("%@", 12); // expected-warning{{invalid conversion specifier '@'}}
155 printf("\0"); // expected-warning{{format string contains '\0' within the string body}}
156 printf("xs\0"); // expected-warning{{format string contains '\0' within the string body}}
157 printf("%*d\n"); // expected-warning{{'*' specified field width is missing a matching 'int' argument}}
158 printf("%*.*d\n", x); // expected-warning{{'.*' specified field precision is missing a matching 'int' argument}}
159 printf("%*d\n", f, x); // expected-warning{{field width should have type 'int', but argument has type 'double'}}
160 printf("%*.*d\n", x, f, x); // expected-warning{{field precision should have type 'int', but argument has type 'double'}}
161 printf("%**\n"); // expected-warning{{invalid conversion specifier '*'}}
162 printf("%n", &i); // expected-warning{{use of '%n' in format string discouraged (potentially insecure)}}
163 printf("%d%d\n", x); // expected-warning{{more '%' conversions than data arguments}}
Ted Kremenek7f70dc82010-02-26 19:18:41 +0000164 printf("%d\n", x, x); // expected-warning{{data argument not used by format string}}
Ted Kremenekf88c8e02010-01-29 20:55:36 +0000165 printf("%W%d%Z\n", x, x, x); // expected-warning{{invalid conversion specifier 'W'}} expected-warning{{invalid conversion specifier 'Z'}}
166 printf("%"); // expected-warning{{incomplete format specifier}}
167 printf("%.d", x); // no-warning
168 printf("%.", x); // expected-warning{{incomplete format specifier}}
Ted Kremenekce506ae2012-01-20 21:52:58 +0000169 printf("%f", 4); // expected-warning{{format specifies type 'double' but the argument has type 'int'}}
Hans Wennborg32addd52012-02-16 16:34:54 +0000170 printf("%qd", lli); // no-warning
171 printf("%qd", x); // expected-warning{{format specifies type 'long long' but the argument has type 'int'}}
172 printf("%qp", (void *)0); // expected-warning{{length modifier 'q' results in undefined behavior or no effect with 'p' conversion specifier}}
Ted Kremenek180f2842010-02-01 19:28:15 +0000173 printf("hhX %hhX", (unsigned char)10); // no-warning
174 printf("llX %llX", (long long) 10); // no-warning
175 // This is fine, because there is an implicit conversion to an int.
176 printf("%d", (unsigned char) 10); // no-warning
Ted Kremenekce506ae2012-01-20 21:52:58 +0000177 printf("%d", (long long) 10); // expected-warning{{format specifies type 'int' but the argument has type 'long long'}}
Ted Kremenekf911eba2010-02-01 23:23:50 +0000178 printf("%Lf\n", (long double) 1.0); // no-warning
Ted Kremenekce506ae2012-01-20 21:52:58 +0000179 printf("%f\n", (long double) 1.0); // expected-warning{{format specifies type 'double' but the argument has type 'long double'}}
Ted Kremenekd49d8772010-03-01 19:22:33 +0000180 // The man page says that a zero precision is okay.
181 printf("%.0Lf", (long double) 1.0); // no-warning
Ted Kremenekce506ae2012-01-20 21:52:58 +0000182 printf("%c\n", "x"); // expected-warning{{format specifies type 'int' but the argument has type 'char *'}}
183 printf("%c\n", 1.23); // expected-warning{{format specifies type 'int' but the argument has type 'double'}}
Ted Kremenek79662972010-12-02 20:57:51 +0000184 printf("Format %d, is %! %f", 1, 2, 4.4); // expected-warning{{invalid conversion specifier '!'}}
Ted Kremenek4d8ae4d2010-10-21 04:00:58 +0000185}
186
187typedef unsigned char uint8_t;
188
189void should_understand_small_integers() {
Ted Kremenekce506ae2012-01-20 21:52:58 +0000190 printf("%hhu", (short) 10); // expected-warning{{format specifies type 'unsigned char' but the argument has type 'short'}}
191 printf("%hu\n", (unsigned char) 1); // expected-warning{{format specifies type 'unsigned short' but the argument has type 'unsigned char'}}
192 printf("%hu\n", (uint8_t)1); // expected-warning{{format specifies type 'unsigned short' but the argument has type 'uint8_t'}}
Ted Kremenek4d8ae4d2010-10-21 04:00:58 +0000193}
Ted Kremenekf88c8e02010-01-29 20:55:36 +0000194
Ted Kremenek5c41ee82010-02-11 09:27:41 +0000195void test11(void *p, char *s) {
196 printf("%p", p); // no-warning
Ted Kremenekce506ae2012-01-20 21:52:58 +0000197 printf("%p", 123); // expected-warning{{format specifies type 'void *' but the argument has type 'int'}}
Tom Caree4ee9662010-06-17 19:00:27 +0000198 printf("%.4p", p); // expected-warning{{precision used with 'p' conversion specifier, resulting in undefined behavior}}
199 printf("%+p", p); // expected-warning{{flag '+' results in undefined behavior with 'p' conversion specifier}}
200 printf("% p", p); // expected-warning{{flag ' ' results in undefined behavior with 'p' conversion specifier}}
201 printf("%0p", p); // expected-warning{{flag '0' results in undefined behavior with 'p' conversion specifier}}
Ted Kremenek5c41ee82010-02-11 09:27:41 +0000202 printf("%s", s); // no-warning
Tom Caree4ee9662010-06-17 19:00:27 +0000203 printf("%+s", p); // expected-warning{{flag '+' results in undefined behavior with 's' conversion specifier}}
204 printf("% s", p); // expected-warning{{flag ' ' results in undefined behavior with 's' conversion specifier}}
205 printf("%0s", p); // expected-warning{{flag '0' results in undefined behavior with 's' conversion specifier}}
Ted Kremenek5c41ee82010-02-11 09:27:41 +0000206}
207
Ted Kremenek0da9e952010-02-16 02:14:24 +0000208void test12(char *b) {
Ted Kremenek4e4b30e2010-02-16 01:46:59 +0000209 unsigned char buf[4];
210 printf ("%.4s\n", buf); // no-warning
Ted Kremenekce506ae2012-01-20 21:52:58 +0000211 printf ("%.4s\n", &buf); // expected-warning{{format specifies type 'char *' but the argument has type 'unsigned char (*)[4]'}}
Ted Kremenek0da9e952010-02-16 02:14:24 +0000212
213 // Verify that we are checking asprintf
Ted Kremenekce506ae2012-01-20 21:52:58 +0000214 asprintf(&b, "%d", "asprintf"); // expected-warning{{format specifies type 'int' but the argument has type 'char *'}}
Ted Kremenek4e4b30e2010-02-16 01:46:59 +0000215}
216
Ted Kremenek6ca4a9a2011-10-25 04:20:41 +0000217void test13(short x) {
218 char bel = 007;
219 printf("bel: '0%hhd'\n", bel); // no-warning
Ted Kremenekce506ae2012-01-20 21:52:58 +0000220 printf("x: '0%hhd'\n", x); // expected-warning {{format specifies type 'char' but the argument has type 'short'}}
Ted Kremenek6ca4a9a2011-10-25 04:20:41 +0000221}
222
Ted Kremenekd635c5f2010-01-30 00:49:51 +0000223typedef struct __aslclient *aslclient;
224typedef struct __aslmsg *aslmsg;
225int asl_log(aslclient asl, aslmsg msg, int level, const char *format, ...) __attribute__((__format__ (__printf__, 4, 5)));
226void test_asl(aslclient asl) {
227 // Test case from <rdar://problem/7341605>.
228 asl_log(asl, 0, 3, "Error: %m"); // no-warning
229 asl_log(asl, 0, 3, "Error: %W"); // expected-warning{{invalid conversion specifier 'W'}}
230}
Douglas Gregoraa74a1e2010-02-02 20:10:50 +0000231
232// <rdar://problem/7595366>
233typedef enum { A } int_t;
234void f0(int_t x) { printf("%d\n", x); }
Ted Kremenek87260c72010-02-24 00:05:54 +0000235
236// Unicode test cases. These are possibly specific to Mac OS X. If so, they should
237// eventually be moved into a separate test.
238typedef __WCHAR_TYPE__ wchar_t;
239
240void test_unicode_conversions(wchar_t *s) {
241 printf("%S", s); // no-warning
Ted Kremenekce506ae2012-01-20 21:52:58 +0000242 printf("%s", s); // expected-warning{{format specifies type 'char *' but the argument has type 'wchar_t *'}}
Ted Kremenek87260c72010-02-24 00:05:54 +0000243 printf("%C", s[0]); // no-warning
244 printf("%c", s[0]);
Ted Kremenek78c97fb2010-02-24 02:28:29 +0000245 // FIXME: This test reports inconsistent results. On Windows, '%C' expects
246 // 'unsigned short'.
247 // printf("%C", 10);
Ted Kremenek87260c72010-02-24 00:05:54 +0000248 // FIXME: we report the expected type as 'int*' instead of 'wchar_t*'
249 printf("%S", "hello"); // expected-warning{{but the argument has type 'char *'}}
250}
251
Ted Kremenekefaff192010-02-27 01:41:03 +0000252// Mac OS X supports positional arguments in format strings.
253// This is an IEEE extension (IEEE Std 1003.1).
254// FIXME: This is probably not portable everywhere.
255void test_positional_arguments() {
256 printf("%0$", (int)2); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}}
Ted Kremenekd49d8772010-03-01 19:22:33 +0000257 printf("%1$*0$d", (int) 2); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}}
Ted Kremenekefaff192010-02-27 01:41:03 +0000258 printf("%1$d", (int) 2); // no-warning
259 printf("%1$d", (int) 2, 2); // expected-warning{{data argument not used by format string}}
Ted Kremenekce506ae2012-01-20 21:52:58 +0000260 printf("%1$d%1$f", (int) 2); // expected-warning{{format specifies type 'double' but the argument has type 'int'}}
Ted Kremenekefaff192010-02-27 01:41:03 +0000261 printf("%1$2.2d", (int) 2); // no-warning
262 printf("%2$*1$.2d", (int) 2, (int) 3); // no-warning
263 printf("%2$*8$d", (int) 2, (int) 3); // expected-warning{{specified field width is missing a matching 'int' argument}}
Ted Kremenekbaa40062010-07-19 22:01:06 +0000264 printf("%%%1$d", (int) 2); // no-warning
265 printf("%1$d%%", (int) 2); // no-warning
Ted Kremenekefaff192010-02-27 01:41:03 +0000266}
267
Ted Kremenek6ee76532010-03-25 03:59:12 +0000268// PR 6697 - Handle format strings where the data argument is not adjacent to the format string
269void myprintf_PR_6697(const char *format, int x, ...) __attribute__((__format__(printf,1, 3)));
270void test_pr_6697() {
271 myprintf_PR_6697("%s\n", 1, "foo"); // no-warning
Ted Kremenekce506ae2012-01-20 21:52:58 +0000272 myprintf_PR_6697("%s\n", 1, (int)0); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}
Ted Kremenek6ee76532010-03-25 03:59:12 +0000273 // FIXME: Not everything should clearly support positional arguments,
274 // but we need a way to identify those cases.
275 myprintf_PR_6697("%1$s\n", 1, "foo"); // no-warning
276 myprintf_PR_6697("%2$s\n", 1, "foo"); // expected-warning{{data argument position '2' exceeds the number of data arguments (1)}}
277 myprintf_PR_6697("%18$s\n", 1, "foo"); // expected-warning{{data argument position '18' exceeds the number of data arguments (1)}}
Ted Kremenekce506ae2012-01-20 21:52:58 +0000278 myprintf_PR_6697("%1$s\n", 1, (int) 0); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}
Ted Kremenek6ee76532010-03-25 03:59:12 +0000279}
280
Douglas Gregorb90f4b32010-05-26 05:35:51 +0000281void rdar8026030(FILE *fp) {
282 fprintf(fp, "\%"); // expected-warning{{incomplete format specifier}}
283}
Tom Caree4ee9662010-06-17 19:00:27 +0000284
285void bug7377_bad_length_mod_usage() {
286 // Bad length modifiers
287 printf("%hhs", "foo"); // expected-warning{{length modifier 'hh' results in undefined behavior or no effect with 's' conversion specifier}}
288 printf("%1$zp", (void *)0); // expected-warning{{length modifier 'z' results in undefined behavior or no effect with 'p' conversion specifier}}
289 printf("%ls", L"foo"); // no-warning
290 printf("%#.2Lf", (long double)1.234); // no-warning
291
292 // Bad flag usage
293 printf("%#p", (void *) 0); // expected-warning{{flag '#' results in undefined behavior with 'p' conversion specifier}}
294 printf("%0d", -1); // no-warning
295 printf("%#n", (void *) 0); // expected-warning{{flag '#' results in undefined behavior with 'n' conversion specifier}} expected-warning{{use of '%n' in format string discouraged (potentially insecure)}}
296 printf("%-n", (void *) 0); // expected-warning{{flag '-' results in undefined behavior with 'n' conversion specifier}} expected-warning{{use of '%n' in format string discouraged (potentially insecure)}}
297 printf("%-p", (void *) 0); // no-warning
298
299 // Bad optional amount use
300 printf("%.2c", 'a'); // expected-warning{{precision used with 'c' conversion specifier, resulting in undefined behavior}}
Tom Care45f9b7e2010-06-21 21:21:01 +0000301 printf("%1n", (void *) 0); // expected-warning{{field width used with 'n' conversion specifier, resulting in undefined behavior}} expected-warning{{use of '%n' in format string discouraged (potentially insecure)}}
302 printf("%.9n", (void *) 0); // expected-warning{{precision used with 'n' conversion specifier, resulting in undefined behavior}} expected-warning{{use of '%n' in format string discouraged (potentially insecure)}}
Tom Caree4ee9662010-06-17 19:00:27 +0000303
304 // Ignored flags
305 printf("% +f", 1.23); // expected-warning{{flag ' ' is ignored when flag '+' is present}}
306 printf("%+ f", 1.23); // expected-warning{{flag ' ' is ignored when flag '+' is present}}
307 printf("%0-f", 1.23); // expected-warning{{flag '0' is ignored when flag '-' is present}}
308 printf("%-0f", 1.23); // expected-warning{{flag '0' is ignored when flag '-' is present}}
309 printf("%-+f", 1.23); // no-warning
310}
Ted Kremenek9325eaf2010-08-24 22:24:51 +0000311
312// PR 7981 - handle '%lc' (wint_t)
313#ifndef wint_t
314typedef int __darwin_wint_t;
315typedef __darwin_wint_t wint_t;
316#endif
317
318void pr7981(wint_t c, wchar_t c2) {
319 printf("%lc", c); // no-warning
320 printf("%lc", 1.0); // expected-warning{{the argument has type 'double'}}
321 printf("%lc", (char) 1); // no-warning
322 printf("%lc", &c); // expected-warning{{the argument has type 'wint_t *' (aka 'int *')}}
323 printf("%lc", c2); // no-warning
324}
325
Ted Kremenek95355bb2010-09-09 03:51:42 +0000326// <rdar://problem/8269537> -Wformat-security says NULL is not a string literal
Ted Kremenekc82faca2010-09-09 04:33:05 +0000327void rdar8269537() {
Ted Kremenek95355bb2010-09-09 03:51:42 +0000328 // This is likely to crash in most cases, but -Wformat-nonliteral technically
329 // doesn't warn in this case.
330 printf(0); // no-warning
331}
332
Ted Kremenekc82faca2010-09-09 04:33:05 +0000333// Handle functions with multiple format attributes.
334extern void rdar8332221_vprintf_scanf(const char *, va_list, const char *, ...)
335 __attribute__((__format__(__printf__, 1, 0)))
336 __attribute__((__format__(__scanf__, 3, 4)));
337
338void rdar8332221(va_list ap, int *x, long *y) {
339 rdar8332221_vprintf_scanf("%", ap, "%d", x); // expected-warning{{incomplete format specifier}}
340}
341
Anders Carlsson2e6c19a2010-11-21 18:34:21 +0000342// PR8641
343void pr8641() {
344 printf("%#x\n", 10);
345 printf("%#X\n", 10);
346}
Ted Kremenekbd18d452011-01-08 05:28:38 +0000347
348void posix_extensions() {
349 // Test %'d, "thousands grouping".
350 // <rdar://problem/8816343>
351 printf("%'d\n", 123456789); // no-warning
Ted Kremenek65197b42011-01-08 05:28:46 +0000352 printf("%'i\n", 123456789); // no-warning
353 printf("%'f\n", (float) 1.0); // no-warning
354 printf("%'p\n", (void*) 0); // expected-warning{{results in undefined behavior with 'p' conversion specifier}}
Ted Kremenekbd18d452011-01-08 05:28:38 +0000355}
Chandler Carruth75196992011-02-21 00:07:51 +0000356
357// PR8486
358//
359// Test what happens when -Wformat is on, but -Wformat-security is off.
360#pragma GCC diagnostic warning "-Wformat"
361#pragma GCC diagnostic ignored "-Wformat-security"
362
363void pr8486() {
Ted Kremenekce506ae2012-01-20 21:52:58 +0000364 printf("%s", 1); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}
Chandler Carruth75196992011-02-21 00:07:51 +0000365}
Ted Kremenekb43e8ad2011-02-24 23:03:04 +0000366
367// PR9314
368// Don't warn about string literals that are PreDefinedExprs, e.g. __func__.
369void pr9314() {
370 printf(__PRETTY_FUNCTION__); // no-warning
371 printf(__func__); // no-warning
372}
373
Douglas Gregorb30cd4a2011-06-15 05:45:11 +0000374int printf(const char * restrict, ...) __attribute__((__format__ (__printf__, 1, 2)));
375
376void rdar9612060(void) {
Ted Kremenekce506ae2012-01-20 21:52:58 +0000377 printf("%s", 2); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}
Douglas Gregorb30cd4a2011-06-15 05:45:11 +0000378}
Ted Kremenek45eb7022011-07-13 17:25:47 +0000379
380void check_char(unsigned char x, signed char y) {
381 printf("%c", y); // no-warning
382 printf("%hhu", x); // no-warning
383 printf("%hhi", y); // no-warning
Ted Kremenekdc00d812011-07-13 17:35:14 +0000384 printf("%hhi", x); // no-warning
Ted Kremenek45eb7022011-07-13 17:25:47 +0000385 printf("%c", x); // no-warning
Ted Kremenekdc00d812011-07-13 17:35:14 +0000386 printf("%hhu", y); // no-warning
Ted Kremenek45eb7022011-07-13 17:25:47 +0000387}
Ted Kremenek62088e32011-08-27 00:16:45 +0000388
389// Test suppression of individual warnings.
390
391void test_suppress_invalid_specifier() {
392#pragma clang diagnostic push
393#pragma clang diagnostic ignored "-Wformat-invalid-specifier"
394 printf("%@", 12); // no-warning
395#pragma clang diagnostic pop
396}
397
Richard Trieu55733de2011-10-28 00:41:25 +0000398// Make sure warnings are on for next test.
399#pragma GCC diagnostic warning "-Wformat"
400#pragma GCC diagnostic warning "-Wformat-security"
401
402// Test that the printf call site is where the warning is attached. If the
403// format string is somewhere else, point to it in a note.
404void pr9751() {
405 const char kFormat1[] = "%d %d \n"; // expected-note{{format string is defined here}}}
406 printf(kFormat1, 0); // expected-warning{{more '%' conversions than data arguments}}
407 printf("%d %s\n", 0); // expected-warning{{more '%' conversions than data arguments}}
408
409 const char kFormat2[] = "%18$s\n"; // expected-note{{format string is defined here}}
410 printf(kFormat2, 1, "foo"); // expected-warning{{data argument position '18' exceeds the number of data arguments (2)}}
411 printf("%18$s\n", 1, "foo"); // expected-warning{{data argument position '18' exceeds the number of data arguments (2)}}
412
413 const char kFormat3[] = "%n"; // expected-note{{format string is defined here}}
414 printf(kFormat3, "as"); // expected-warning{{use of '%n' in format string discouraged}}
415 printf("%n", "as"); // expected-warning{{use of '%n' in format string discouraged}}
416
417 const char kFormat4[] = "%y"; // expected-note{{format string is defined here}}
418 printf(kFormat4, 5); // expected-warning{{invalid conversion specifier 'y'}}
419 printf("%y", 5); // expected-warning{{invalid conversion specifier 'y'}}
420
421 const char kFormat5[] = "%."; // expected-note{{format string is defined here}}
422 printf(kFormat5, 5); // expected-warning{{incomplete format specifier}}
423 printf("%.", 5); // expected-warning{{incomplete format specifier}}
424
425 const char kFormat6[] = "%s"; // expected-note{{format string is defined here}}
Ted Kremenekce506ae2012-01-20 21:52:58 +0000426 printf(kFormat6, 5); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}
427 printf("%s", 5); // expected-warning{{format specifies type 'char *' but the argument has type 'int'}}
Richard Trieu55733de2011-10-28 00:41:25 +0000428
429 const char kFormat7[] = "%0$"; // expected-note{{format string is defined here}}
430 printf(kFormat7, 5); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}}
431 printf("%0$", 5); // expected-warning{{position arguments in format strings start counting at 1 (not 0)}}
432
433 const char kFormat8[] = "%1$d %d"; // expected-note{{format string is defined here}}
434 printf(kFormat8, 4, 4); // expected-warning{{cannot mix positional and non-positional arguments in format string}}
435 printf("%1$d %d", 4, 4); // expected-warning{{cannot mix positional and non-positional arguments in format string}}
436
437 const char kFormat9[] = ""; // expected-note{{format string is defined here}}
438 printf(kFormat9, 4, 4); // expected-warning{{format string is empty}}
439 printf("", 4, 4); // expected-warning{{format string is empty}}
440
441 const char kFormat10[] = "\0%d"; // expected-note{{format string is defined here}}
442 printf(kFormat10, 4); // expected-warning{{format string contains '\0' within the string body}}
443 printf("\0%d", 4); // expected-warning{{format string contains '\0' within the string body}}
444
445 const char kFormat11[] = "%*d"; // expected-note{{format string is defined here}}
446 printf(kFormat11); // expected-warning{{'*' specified field width is missing a matching 'int' argument}}
447 printf("%*d"); // expected-warning{{'*' specified field width is missing a matching 'int' argument}}
448
449 const char kFormat12[] = "%*d"; // expected-note{{format string is defined here}}
450 printf(kFormat12, 4.4); // expected-warning{{field width should have type 'int', but argument has type 'double'}}
451 printf("%*d", 4.4); // expected-warning{{field width should have type 'int', but argument has type 'double'}}
452
453 const char kFormat13[] = "%.3p"; // expected-note{{format string is defined here}}
454 void *p;
455 printf(kFormat13, p); // expected-warning{{precision used with 'p' conversion specifier, resulting in undefined behavior}}
456 printf("%.3p", p); // expected-warning{{precision used with 'p' conversion specifier, resulting in undefined behavior}}
457
458 const char kFormat14[] = "%0s"; // expected-note{{format string is defined here}}
459 printf(kFormat14, "a"); // expected-warning{{flag '0' results in undefined behavior with 's' conversion specifier}}
460 printf("%0s", "a"); // expected-warning{{flag '0' results in undefined behavior with 's' conversion specifier}}
461
462 const char kFormat15[] = "%hhs"; // expected-note{{format string is defined here}}
463 printf(kFormat15, "a"); // expected-warning{{length modifier 'hh' results in undefined behavior or no effect with 's' conversion specifier}}
464 printf("%hhs", "a"); // expected-warning{{length modifier 'hh' results in undefined behavior or no effect with 's' conversion specifier}}
465
466 const char kFormat16[] = "%-0d"; // expected-note{{format string is defined here}}
467 printf(kFormat16, 5); // expected-warning{{flag '0' is ignored when flag '-' is present}}
468 printf("%-0d", 5); // expected-warning{{flag '0' is ignored when flag '-' is present}}
469
470 // Make sure that the "format string is defined here" note is not emitted
471 // when the original string is within the argument expression.
472 printf(1 ? "yes %d" : "no %d"); // expected-warning 2{{more '%' conversions than data arguments}}
Jean-Daniel Dupas220947b2012-01-31 18:12:08 +0000473
474 const char kFormat17[] = "%hu"; // expected-note{{format string is defined here}}}
475 printf(kFormat17, (int[]){0}); // expected-warning{{format specifies type 'unsigned short' but the argument}}
Hans Wennborg4ee01ef2012-02-13 10:32:27 +0000476
477 printf("%a", (long double)0); // expected-warning{{format specifies type 'double' but the argument has type 'long double'}}
Richard Trieu55733de2011-10-28 00:41:25 +0000478}
Ted Kremenek9d24c2c2012-01-24 21:29:54 +0000479
480// PR 9466: clang: doesn't know about %Lu, %Ld, and %Lx
481void printf_longlong(long long x, unsigned long long y) {
482 printf("%Ld", y); // no-warning
483 printf("%Lu", y); // no-warning
484 printf("%Lx", y); // no-warning
485 printf("%Ld", x); // no-warning
486 printf("%Lu", x); // no-warning
487 printf("%Lx", x); // no-warning
488 printf("%Ls", "hello"); // expected-warning {{length modifier 'L' results in undefined behavior or no effect with 's' conversion specifier}}
489}
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +0000490
491void __attribute__((format(strfmon,1,2))) monformat(const char *fmt, ...);
492void __attribute__((format(strftime,1,0))) dateformat(const char *fmt);
493
494// Other formats
495void test_other_formats() {
496 char *str = "";
497 monformat("", 1); // expected-warning{{format string is empty}}
Jean-Daniel Dupas2837a2f2012-02-07 23:10:53 +0000498 monformat(str); // expected-warning{{format string is not a string literal (potentially insecure)}}
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +0000499 dateformat(""); // expected-warning{{format string is empty}}
Jean-Daniel Dupas2837a2f2012-02-07 23:10:53 +0000500 dateformat(str); // no-warning (using strftime non literal is not unsafe)
Jean-Daniel Dupas34269df2012-01-30 08:46:47 +0000501}