blob: 141518403344df3225d27489ad01d3d06cac6fba [file] [log] [blame]
Zhongxing Xu589c0f22009-11-12 08:38:56 +00001//=== MallocChecker.cpp - A malloc/free checker -------------------*- C++ -*--//
2//
3// The LLVM Compiler Infrastructure
4//
5// This file is distributed under the University of Illinois Open Source
6// License. See LICENSE.TXT for details.
7//
8//===----------------------------------------------------------------------===//
9//
10// This file defines malloc/free checker, which checks for potential memory
11// leaks, double free, and use-after-free problems.
12//
13//===----------------------------------------------------------------------===//
14
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000015#include "ClangSACheckers.h"
Anna Zaksf0dfc9c2012-02-17 22:35:31 +000016#include "InterCheckerAPI.h"
Argyrios Kyrtzidisec8605f2011-03-01 01:16:21 +000017#include "clang/StaticAnalyzer/Core/Checker.h"
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +000018#include "clang/StaticAnalyzer/Core/CheckerManager.h"
19#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000020#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
Anna Zaks66c40402012-02-14 21:55:24 +000021#include "clang/StaticAnalyzer/Core/PathSensitive/ObjCMessage.h"
Ted Kremenek18c66fd2011-08-15 22:09:50 +000022#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
23#include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h"
Ted Kremenek9b663712011-02-10 01:03:03 +000024#include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h"
Anna Zaks15d0ae12012-02-11 23:46:36 +000025#include "clang/Basic/SourceManager.h"
Zhongxing Xu589c0f22009-11-12 08:38:56 +000026#include "llvm/ADT/ImmutableMap.h"
Benjamin Kramer8fe83e12012-02-04 13:45:25 +000027#include "llvm/ADT/SmallString.h"
Benjamin Kramer00bd44d2012-02-04 12:31:12 +000028#include "llvm/ADT/STLExtras.h"
Anna Zaks60a1fa42012-02-22 03:14:20 +000029#include <climits>
30
Zhongxing Xu589c0f22009-11-12 08:38:56 +000031using namespace clang;
Ted Kremenek9ef65372010-12-23 07:20:52 +000032using namespace ento;
Zhongxing Xu589c0f22009-11-12 08:38:56 +000033
34namespace {
35
Zhongxing Xu7fb14642009-12-11 00:55:44 +000036class RefState {
Ted Kremenekdde201b2010-08-06 21:12:55 +000037 enum Kind { AllocateUnchecked, AllocateFailed, Released, Escaped,
38 Relinquished } K;
Zhongxing Xu243fde92009-11-17 07:54:15 +000039 const Stmt *S;
40
Zhongxing Xu7fb14642009-12-11 00:55:44 +000041public:
Zhongxing Xu243fde92009-11-17 07:54:15 +000042 RefState(Kind k, const Stmt *s) : K(k), S(s) {}
43
Zhongxing Xub94b81a2009-12-31 06:13:07 +000044 bool isAllocated() const { return K == AllocateUnchecked; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000045 bool isReleased() const { return K == Released; }
Anna Zaksca23eb22012-02-29 18:42:47 +000046
Anna Zaksc8bb3be2012-02-13 18:05:39 +000047 const Stmt *getStmt() const { return S; }
Zhongxing Xu243fde92009-11-17 07:54:15 +000048
49 bool operator==(const RefState &X) const {
50 return K == X.K && S == X.S;
51 }
52
Zhongxing Xub94b81a2009-12-31 06:13:07 +000053 static RefState getAllocateUnchecked(const Stmt *s) {
54 return RefState(AllocateUnchecked, s);
55 }
56 static RefState getAllocateFailed() {
57 return RefState(AllocateFailed, 0);
58 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000059 static RefState getReleased(const Stmt *s) { return RefState(Released, s); }
60 static RefState getEscaped(const Stmt *s) { return RefState(Escaped, s); }
Ted Kremenekdde201b2010-08-06 21:12:55 +000061 static RefState getRelinquished(const Stmt *s) {
62 return RefState(Relinquished, s);
63 }
Zhongxing Xu243fde92009-11-17 07:54:15 +000064
65 void Profile(llvm::FoldingSetNodeID &ID) const {
66 ID.AddInteger(K);
67 ID.AddPointer(S);
68 }
Zhongxing Xu589c0f22009-11-12 08:38:56 +000069};
70
Anna Zaks40add292012-02-15 00:11:25 +000071struct ReallocPair {
72 SymbolRef ReallocatedSym;
73 bool IsFreeOnFailure;
74 ReallocPair(SymbolRef S, bool F) : ReallocatedSym(S), IsFreeOnFailure(F) {}
75 void Profile(llvm::FoldingSetNodeID &ID) const {
76 ID.AddInteger(IsFreeOnFailure);
77 ID.AddPointer(ReallocatedSym);
78 }
79 bool operator==(const ReallocPair &X) const {
80 return ReallocatedSym == X.ReallocatedSym &&
81 IsFreeOnFailure == X.IsFreeOnFailure;
82 }
83};
84
Anna Zaks3d7c44e2012-03-21 19:45:08 +000085typedef std::pair<const Stmt*, const MemRegion*> LeakInfo;
86
Anna Zaksb319e022012-02-08 20:13:28 +000087class MallocChecker : public Checker<check::DeadSymbols,
Ted Kremeneke3659a72012-01-04 23:48:37 +000088 check::EndPath,
89 check::PreStmt<ReturnStmt>,
Anna Zaks66c40402012-02-14 21:55:24 +000090 check::PreStmt<CallExpr>,
Anna Zaksb319e022012-02-08 20:13:28 +000091 check::PostStmt<CallExpr>,
Anna Zaksf5aa3f52012-03-22 00:57:20 +000092 check::PostStmt<BlockExpr>,
Ted Kremeneke3659a72012-01-04 23:48:37 +000093 check::Location,
94 check::Bind,
Anna Zaks4fb54872012-02-11 21:02:35 +000095 eval::Assume,
96 check::RegionChanges>
Ted Kremeneke3659a72012-01-04 23:48:37 +000097{
Anna Zaksfebdc322012-02-16 22:26:12 +000098 mutable OwningPtr<BugType> BT_DoubleFree;
99 mutable OwningPtr<BugType> BT_Leak;
100 mutable OwningPtr<BugType> BT_UseFree;
101 mutable OwningPtr<BugType> BT_BadFree;
Anna Zaksb16ce452012-02-15 00:11:22 +0000102 mutable IdentifierInfo *II_malloc, *II_free, *II_realloc, *II_calloc,
Anna Zaks60a1fa42012-02-22 03:14:20 +0000103 *II_valloc, *II_reallocf, *II_strndup, *II_strdup;
104
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000105public:
Anna Zaksb16ce452012-02-15 00:11:22 +0000106 MallocChecker() : II_malloc(0), II_free(0), II_realloc(0), II_calloc(0),
Anna Zaks60a1fa42012-02-22 03:14:20 +0000107 II_valloc(0), II_reallocf(0), II_strndup(0), II_strdup(0) {}
Anna Zaks231361a2012-02-08 23:16:52 +0000108
109 /// In pessimistic mode, the checker assumes that it does not know which
110 /// functions might free the memory.
111 struct ChecksFilter {
112 DefaultBool CMallocPessimistic;
113 DefaultBool CMallocOptimistic;
114 };
115
116 ChecksFilter Filter;
117
Anna Zaks66c40402012-02-14 21:55:24 +0000118 void checkPreStmt(const CallExpr *S, CheckerContext &C) const;
Anna Zaksb319e022012-02-08 20:13:28 +0000119 void checkPostStmt(const CallExpr *CE, CheckerContext &C) const;
Anna Zaksf5aa3f52012-03-22 00:57:20 +0000120 void checkPostStmt(const BlockExpr *BE, CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000121 void checkDeadSymbols(SymbolReaper &SymReaper, CheckerContext &C) const;
Anna Zaksaf498a22011-10-25 19:56:48 +0000122 void checkEndPath(CheckerContext &C) const;
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000123 void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000124 ProgramStateRef evalAssume(ProgramStateRef state, SVal Cond,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000125 bool Assumption) const;
Anna Zaks390909c2011-10-06 00:43:15 +0000126 void checkLocation(SVal l, bool isLoad, const Stmt *S,
127 CheckerContext &C) const;
128 void checkBind(SVal location, SVal val, const Stmt*S,
129 CheckerContext &C) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000130 ProgramStateRef
131 checkRegionChanges(ProgramStateRef state,
132 const StoreManager::InvalidatedSymbols *invalidated,
133 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +0000134 ArrayRef<const MemRegion *> Regions,
135 const CallOrObjCMessage *Call) const;
Anna Zaks4fb54872012-02-11 21:02:35 +0000136 bool wantsRegionChangeUpdate(ProgramStateRef state) const {
137 return true;
138 }
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000139
Anna Zaks93c5a242012-05-02 00:05:20 +0000140 void printState(raw_ostream &Out, ProgramStateRef State,
141 const char *NL, const char *Sep) const;
142
Zhongxing Xu7b760962009-11-13 07:25:27 +0000143private:
Anna Zaks66c40402012-02-14 21:55:24 +0000144 void initIdentifierInfo(ASTContext &C) const;
145
146 /// Check if this is one of the functions which can allocate/reallocate memory
147 /// pointed to by one of its arguments.
148 bool isMemFunction(const FunctionDecl *FD, ASTContext &C) const;
149
Anna Zaks87cb5be2012-02-22 19:24:52 +0000150 static ProgramStateRef MallocMemReturnsAttr(CheckerContext &C,
151 const CallExpr *CE,
152 const OwnershipAttr* Att);
Ted Kremenek8bef8232012-01-26 21:29:00 +0000153 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000154 const Expr *SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000155 ProgramStateRef state) {
Ted Kremenek5eca4822012-01-06 22:09:28 +0000156 return MallocMemAux(C, CE,
157 state->getSVal(SizeEx, C.getLocationContext()),
158 Init, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000159 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000160
Ted Kremenek8bef8232012-01-26 21:29:00 +0000161 static ProgramStateRef MallocMemAux(CheckerContext &C, const CallExpr *CE,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000162 SVal SizeEx, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000163 ProgramStateRef state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000164
Anna Zaks87cb5be2012-02-22 19:24:52 +0000165 /// Update the RefState to reflect the new memory allocation.
166 static ProgramStateRef MallocUpdateRefState(CheckerContext &C,
167 const CallExpr *CE,
168 ProgramStateRef state);
169
170 ProgramStateRef FreeMemAttr(CheckerContext &C, const CallExpr *CE,
171 const OwnershipAttr* Att) const;
Ted Kremenek8bef8232012-01-26 21:29:00 +0000172 ProgramStateRef FreeMemAux(CheckerContext &C, const CallExpr *CE,
173 ProgramStateRef state, unsigned Num,
Ted Kremeneke3659a72012-01-04 23:48:37 +0000174 bool Hold) const;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000175
Anna Zaks87cb5be2012-02-22 19:24:52 +0000176 ProgramStateRef ReallocMem(CheckerContext &C, const CallExpr *CE,
177 bool FreesMemOnFailure) const;
178 static ProgramStateRef CallocMem(CheckerContext &C, const CallExpr *CE);
Jordy Rose43859f62010-06-07 19:32:37 +0000179
Anna Zaks91c2a112012-02-08 23:16:56 +0000180 bool checkEscape(SymbolRef Sym, const Stmt *S, CheckerContext &C) const;
181 bool checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
182 const Stmt *S = 0) const;
183
Anna Zaks66c40402012-02-14 21:55:24 +0000184 /// Check if the function is not known to us. So, for example, we could
185 /// conservatively assume it can free/reallocate it's pointer arguments.
Anna Zaks3cd89ad2012-02-24 23:56:53 +0000186 bool doesNotFreeMemory(const CallOrObjCMessage *Call,
187 ProgramStateRef State) const;
Anna Zaks66c40402012-02-14 21:55:24 +0000188
Ted Kremenek9c378f72011-08-12 23:37:29 +0000189 static bool SummarizeValue(raw_ostream &os, SVal V);
190 static bool SummarizeRegion(raw_ostream &os, const MemRegion *MR);
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000191 void ReportBadFree(CheckerContext &C, SVal ArgVal, SourceRange range) const;
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000192
Anna Zaksca8e36e2012-02-23 21:38:21 +0000193 /// Find the location of the allocation for Sym on the path leading to the
194 /// exploded node N.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000195 LeakInfo getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
196 CheckerContext &C) const;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000197
Anna Zaksda046772012-02-11 21:02:40 +0000198 void reportLeak(SymbolRef Sym, ExplodedNode *N, CheckerContext &C) const;
199
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000200 /// The bug visitor which allows us to print extra diagnostics along the
201 /// BugReport path. For example, showing the allocation site of the leaked
202 /// region.
Jordy Rose01153492012-03-24 02:45:35 +0000203 class MallocBugVisitor : public BugReporterVisitorImpl<MallocBugVisitor> {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000204 protected:
Anna Zaksfe571602012-02-16 22:26:07 +0000205 enum NotificationMode {
206 Normal,
Anna Zaksfe571602012-02-16 22:26:07 +0000207 ReallocationFailed
208 };
209
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000210 // The allocated region symbol tracked by the main analysis.
211 SymbolRef Sym;
212
Jordy Roseb000fb52012-03-24 03:15:09 +0000213 // The mode we are in, i.e. what kind of diagnostics will be emitted.
214 NotificationMode Mode;
215
216 // A symbol from when the primary region should have been reallocated.
217 SymbolRef FailedReallocSymbol;
218
219 public:
220 MallocBugVisitor(SymbolRef S)
221 : Sym(S), Mode(Normal), FailedReallocSymbol(0) {}
222
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000223 virtual ~MallocBugVisitor() {}
224
225 void Profile(llvm::FoldingSetNodeID &ID) const {
226 static int X = 0;
227 ID.AddPointer(&X);
228 ID.AddPointer(Sym);
229 }
230
Anna Zaksfe571602012-02-16 22:26:07 +0000231 inline bool isAllocated(const RefState *S, const RefState *SPrev,
232 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000233 // Did not track -> allocated. Other state (released) -> allocated.
Anna Zaksfe571602012-02-16 22:26:07 +0000234 return (Stmt && isa<CallExpr>(Stmt) &&
235 (S && S->isAllocated()) && (!SPrev || !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000236 }
237
Anna Zaksfe571602012-02-16 22:26:07 +0000238 inline bool isReleased(const RefState *S, const RefState *SPrev,
239 const Stmt *Stmt) {
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000240 // Did not track -> released. Other state (allocated) -> released.
Anna Zaksfe571602012-02-16 22:26:07 +0000241 return (Stmt && isa<CallExpr>(Stmt) &&
242 (S && S->isReleased()) && (!SPrev || !SPrev->isReleased()));
243 }
244
245 inline bool isReallocFailedCheck(const RefState *S, const RefState *SPrev,
246 const Stmt *Stmt) {
247 // If the expression is not a call, and the state change is
248 // released -> allocated, it must be the realloc return value
249 // check. If we have to handle more cases here, it might be cleaner just
250 // to track this extra bit in the state itself.
251 return ((!Stmt || !isa<CallExpr>(Stmt)) &&
252 (S && S->isAllocated()) && (SPrev && !SPrev->isAllocated()));
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000253 }
254
255 PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
256 const ExplodedNode *PrevN,
257 BugReporterContext &BRC,
258 BugReport &BR);
Anna Zaks56a938f2012-03-16 23:24:20 +0000259 private:
260 class StackHintGeneratorForReallocationFailed
261 : public StackHintGeneratorForSymbol {
262 public:
263 StackHintGeneratorForReallocationFailed(SymbolRef S, StringRef M)
264 : StackHintGeneratorForSymbol(S, M) {}
265
266 virtual std::string getMessageForArg(const Expr *ArgE, unsigned ArgIndex) {
267 SmallString<200> buf;
268 llvm::raw_svector_ostream os(buf);
269
Anna Zaksfbd58742012-03-16 23:44:28 +0000270 os << "Reallocation of ";
Anna Zaks56a938f2012-03-16 23:24:20 +0000271 // Printed parameters start at 1, not 0.
272 printOrdinal(++ArgIndex, os);
273 os << " parameter failed";
274
275 return os.str();
276 }
277
278 virtual std::string getMessageForReturn(const CallExpr *CallExpr) {
Anna Zaksfbd58742012-03-16 23:44:28 +0000279 return "Reallocation of returned value failed";
Anna Zaks56a938f2012-03-16 23:24:20 +0000280 }
281 };
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000282 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000283};
Kovarththanan Rajaratnamba5fb5a2009-11-28 06:07:30 +0000284} // end anonymous namespace
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000285
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000286typedef llvm::ImmutableMap<SymbolRef, RefState> RegionStateTy;
Anna Zaks40add292012-02-15 00:11:25 +0000287typedef llvm::ImmutableMap<SymbolRef, ReallocPair > ReallocMap;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000288class RegionState {};
289class ReallocPairs {};
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000290namespace clang {
Ted Kremenek9ef65372010-12-23 07:20:52 +0000291namespace ento {
Zhongxing Xu243fde92009-11-17 07:54:15 +0000292 template <>
Ted Kremenek18c66fd2011-08-15 22:09:50 +0000293 struct ProgramStateTrait<RegionState>
294 : public ProgramStatePartialTrait<RegionStateTy> {
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000295 static void *GDMIndex() { static int x; return &x; }
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000296 };
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000297
298 template <>
299 struct ProgramStateTrait<ReallocPairs>
Anna Zaks40add292012-02-15 00:11:25 +0000300 : public ProgramStatePartialTrait<ReallocMap> {
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000301 static void *GDMIndex() { static int x; return &x; }
302 };
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000303}
Argyrios Kyrtzidis5a4f98f2010-12-22 18:53:20 +0000304}
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000305
Anna Zaks4fb54872012-02-11 21:02:35 +0000306namespace {
307class StopTrackingCallback : public SymbolVisitor {
308 ProgramStateRef state;
309public:
310 StopTrackingCallback(ProgramStateRef st) : state(st) {}
311 ProgramStateRef getState() const { return state; }
312
313 bool VisitSymbol(SymbolRef sym) {
314 state = state->remove<RegionState>(sym);
315 return true;
316 }
317};
318} // end anonymous namespace
319
Anna Zaks66c40402012-02-14 21:55:24 +0000320void MallocChecker::initIdentifierInfo(ASTContext &Ctx) const {
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000321 if (!II_malloc)
322 II_malloc = &Ctx.Idents.get("malloc");
323 if (!II_free)
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +0000324 II_free = &Ctx.Idents.get("free");
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000325 if (!II_realloc)
326 II_realloc = &Ctx.Idents.get("realloc");
Anna Zaks40add292012-02-15 00:11:25 +0000327 if (!II_reallocf)
328 II_reallocf = &Ctx.Idents.get("reallocf");
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000329 if (!II_calloc)
330 II_calloc = &Ctx.Idents.get("calloc");
Anna Zaksb16ce452012-02-15 00:11:22 +0000331 if (!II_valloc)
332 II_valloc = &Ctx.Idents.get("valloc");
Anna Zaks60a1fa42012-02-22 03:14:20 +0000333 if (!II_strdup)
334 II_strdup = &Ctx.Idents.get("strdup");
335 if (!II_strndup)
336 II_strndup = &Ctx.Idents.get("strndup");
Anna Zaksb319e022012-02-08 20:13:28 +0000337}
338
Anna Zaks66c40402012-02-14 21:55:24 +0000339bool MallocChecker::isMemFunction(const FunctionDecl *FD, ASTContext &C) const {
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000340 if (!FD)
341 return false;
Anna Zaks66c40402012-02-14 21:55:24 +0000342 IdentifierInfo *FunI = FD->getIdentifier();
343 if (!FunI)
344 return false;
345
Anna Zaks1d6cc6a2012-02-15 02:12:00 +0000346 initIdentifierInfo(C);
347
Anna Zaks40add292012-02-15 00:11:25 +0000348 if (FunI == II_malloc || FunI == II_free || FunI == II_realloc ||
Anna Zaks60a1fa42012-02-22 03:14:20 +0000349 FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc ||
350 FunI == II_strdup || FunI == II_strndup)
Anna Zaks66c40402012-02-14 21:55:24 +0000351 return true;
352
353 if (Filter.CMallocOptimistic && FD->hasAttrs() &&
354 FD->specific_attr_begin<OwnershipAttr>() !=
355 FD->specific_attr_end<OwnershipAttr>())
356 return true;
357
358
359 return false;
360}
361
Anna Zaksb319e022012-02-08 20:13:28 +0000362void MallocChecker::checkPostStmt(const CallExpr *CE, CheckerContext &C) const {
363 const FunctionDecl *FD = C.getCalleeDecl(CE);
364 if (!FD)
365 return;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000366
Anna Zaksb16ce452012-02-15 00:11:22 +0000367 initIdentifierInfo(C.getASTContext());
368 IdentifierInfo *FunI = FD->getIdentifier();
369 if (!FunI)
370 return;
371
Anna Zaks87cb5be2012-02-22 19:24:52 +0000372 ProgramStateRef State = C.getState();
Anna Zaksb16ce452012-02-15 00:11:22 +0000373 if (FunI == II_malloc || FunI == II_valloc) {
Anna Zaks259052d2012-04-10 23:41:11 +0000374 if (CE->getNumArgs() < 1)
375 return;
Anna Zaks87cb5be2012-02-22 19:24:52 +0000376 State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
Anna Zaksb16ce452012-02-15 00:11:22 +0000377 } else if (FunI == II_realloc) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000378 State = ReallocMem(C, CE, false);
Anna Zaks40add292012-02-15 00:11:25 +0000379 } else if (FunI == II_reallocf) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000380 State = ReallocMem(C, CE, true);
Anna Zaksb16ce452012-02-15 00:11:22 +0000381 } else if (FunI == II_calloc) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000382 State = CallocMem(C, CE);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000383 } else if (FunI == II_free) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000384 State = FreeMemAux(C, CE, C.getState(), 0, false);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000385 } else if (FunI == II_strdup) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000386 State = MallocUpdateRefState(C, CE, State);
Anna Zaks60a1fa42012-02-22 03:14:20 +0000387 } else if (FunI == II_strndup) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000388 State = MallocUpdateRefState(C, CE, State);
389 } else if (Filter.CMallocOptimistic) {
390 // Check all the attributes, if there are any.
391 // There can be multiple of these attributes.
392 if (FD->hasAttrs())
393 for (specific_attr_iterator<OwnershipAttr>
394 i = FD->specific_attr_begin<OwnershipAttr>(),
395 e = FD->specific_attr_end<OwnershipAttr>();
396 i != e; ++i) {
397 switch ((*i)->getOwnKind()) {
398 case OwnershipAttr::Returns:
399 State = MallocMemReturnsAttr(C, CE, *i);
400 break;
401 case OwnershipAttr::Takes:
402 case OwnershipAttr::Holds:
403 State = FreeMemAttr(C, CE, *i);
404 break;
405 }
406 }
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000407 }
Anna Zaks60a1fa42012-02-22 03:14:20 +0000408 C.addTransition(State);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000409}
410
Anna Zaks87cb5be2012-02-22 19:24:52 +0000411ProgramStateRef MallocChecker::MallocMemReturnsAttr(CheckerContext &C,
412 const CallExpr *CE,
413 const OwnershipAttr* Att) {
Sean Huntcf807c42010-08-18 23:23:40 +0000414 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000415 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000416
Sean Huntcf807c42010-08-18 23:23:40 +0000417 OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000418 if (I != E) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000419 return MallocMemAux(C, CE, CE->getArg(*I), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000420 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000421 return MallocMemAux(C, CE, UnknownVal(), UndefinedVal(), C.getState());
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000422}
423
Anna Zaksb319e022012-02-08 20:13:28 +0000424ProgramStateRef MallocChecker::MallocMemAux(CheckerContext &C,
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000425 const CallExpr *CE,
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000426 SVal Size, SVal Init,
Ted Kremenek8bef8232012-01-26 21:29:00 +0000427 ProgramStateRef state) {
Anna Zaksb319e022012-02-08 20:13:28 +0000428 // Get the return value.
429 SVal retVal = state->getSVal(CE, C.getLocationContext());
Zhongxing Xua49c6b72009-12-11 03:09:01 +0000430
Anna Zaksb16ce452012-02-15 00:11:22 +0000431 // We expect the malloc functions to return a pointer.
432 if (!isa<Loc>(retVal))
433 return 0;
434
Jordy Rose32f26562010-07-04 00:00:41 +0000435 // Fill the region with the initialization value.
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000436 state = state->bindDefault(retVal, Init);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000437
Jordy Rose32f26562010-07-04 00:00:41 +0000438 // Set the region's extent equal to the Size parameter.
Anna Zakse9ef5622012-02-10 01:11:00 +0000439 const SymbolicRegion *R =
440 dyn_cast_or_null<SymbolicRegion>(retVal.getAsRegion());
Anna Zaks60a1fa42012-02-22 03:14:20 +0000441 if (!R)
Anna Zakse9ef5622012-02-10 01:11:00 +0000442 return 0;
Anna Zaks60a1fa42012-02-22 03:14:20 +0000443 if (isa<DefinedOrUnknownSVal>(Size)) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000444 SValBuilder &svalBuilder = C.getSValBuilder();
Anna Zaks60a1fa42012-02-22 03:14:20 +0000445 DefinedOrUnknownSVal Extent = R->getExtent(svalBuilder);
446 DefinedOrUnknownSVal DefinedSize = cast<DefinedOrUnknownSVal>(Size);
447 DefinedOrUnknownSVal extentMatchesSize =
448 svalBuilder.evalEQ(state, Extent, DefinedSize);
Anna Zakse9ef5622012-02-10 01:11:00 +0000449
Anna Zaks60a1fa42012-02-22 03:14:20 +0000450 state = state->assume(extentMatchesSize, true);
451 assert(state);
452 }
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000453
Anna Zaks87cb5be2012-02-22 19:24:52 +0000454 return MallocUpdateRefState(C, CE, state);
455}
456
457ProgramStateRef MallocChecker::MallocUpdateRefState(CheckerContext &C,
458 const CallExpr *CE,
459 ProgramStateRef state) {
460 // Get the return value.
461 SVal retVal = state->getSVal(CE, C.getLocationContext());
462
463 // We expect the malloc functions to return a pointer.
464 if (!isa<Loc>(retVal))
465 return 0;
466
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000467 SymbolRef Sym = retVal.getAsLocSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000468 assert(Sym);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000469
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000470 // Set the symbol's state to Allocated.
Zhongxing Xub94b81a2009-12-31 06:13:07 +0000471 return state->set<RegionState>(Sym, RefState::getAllocateUnchecked(CE));
Anna Zaks87cb5be2012-02-22 19:24:52 +0000472
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000473}
474
Anna Zaks87cb5be2012-02-22 19:24:52 +0000475ProgramStateRef MallocChecker::FreeMemAttr(CheckerContext &C,
476 const CallExpr *CE,
477 const OwnershipAttr* Att) const {
Sean Huntcf807c42010-08-18 23:23:40 +0000478 if (Att->getModule() != "malloc")
Anna Zaks87cb5be2012-02-22 19:24:52 +0000479 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000480
Anna Zaksb3d72752012-03-01 22:06:06 +0000481 ProgramStateRef State = C.getState();
482
Sean Huntcf807c42010-08-18 23:23:40 +0000483 for (OwnershipAttr::args_iterator I = Att->args_begin(), E = Att->args_end();
484 I != E; ++I) {
Anna Zaksb3d72752012-03-01 22:06:06 +0000485 ProgramStateRef StateI = FreeMemAux(C, CE, State, *I,
486 Att->getOwnKind() == OwnershipAttr::Holds);
487 if (StateI)
488 State = StateI;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000489 }
Anna Zaksb3d72752012-03-01 22:06:06 +0000490 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000491}
492
Ted Kremenek8bef8232012-01-26 21:29:00 +0000493ProgramStateRef MallocChecker::FreeMemAux(CheckerContext &C,
Anna Zakse9ef5622012-02-10 01:11:00 +0000494 const CallExpr *CE,
495 ProgramStateRef state,
496 unsigned Num,
497 bool Hold) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000498 if (CE->getNumArgs() < (Num + 1))
499 return 0;
500
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000501 const Expr *ArgExpr = CE->getArg(Num);
Ted Kremenek5eca4822012-01-06 22:09:28 +0000502 SVal ArgVal = state->getSVal(ArgExpr, C.getLocationContext());
Anna Zakse9ef5622012-02-10 01:11:00 +0000503 if (!isa<DefinedOrUnknownSVal>(ArgVal))
504 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000505 DefinedOrUnknownSVal location = cast<DefinedOrUnknownSVal>(ArgVal);
506
507 // Check for null dereferences.
508 if (!isa<Loc>(location))
Anna Zaksb319e022012-02-08 20:13:28 +0000509 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000510
Anna Zaksb276bd92012-02-14 00:26:13 +0000511 // The explicit NULL case, no operation is performed.
Ted Kremenek8bef8232012-01-26 21:29:00 +0000512 ProgramStateRef notNullState, nullState;
Ted Kremenek28f47b92010-12-01 22:16:56 +0000513 llvm::tie(notNullState, nullState) = state->assume(location);
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000514 if (nullState && !notNullState)
Anna Zaksb319e022012-02-08 20:13:28 +0000515 return 0;
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000516
Jordy Rose43859f62010-06-07 19:32:37 +0000517 // Unknown values could easily be okay
518 // Undefined values are handled elsewhere
519 if (ArgVal.isUnknownOrUndef())
Anna Zaksb319e022012-02-08 20:13:28 +0000520 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000521
Jordy Rose43859f62010-06-07 19:32:37 +0000522 const MemRegion *R = ArgVal.getAsRegion();
523
524 // Nonlocs can't be freed, of course.
525 // Non-region locations (labels and fixed addresses) also shouldn't be freed.
526 if (!R) {
527 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000528 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000529 }
530
531 R = R->StripCasts();
532
533 // Blocks might show up as heap data, but should not be free()d
534 if (isa<BlockDataRegion>(R)) {
535 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000536 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000537 }
538
539 const MemSpaceRegion *MS = R->getMemorySpace();
540
541 // Parameters, locals, statics, and globals shouldn't be freed.
542 if (!(isa<UnknownSpaceRegion>(MS) || isa<HeapSpaceRegion>(MS))) {
543 // FIXME: at the time this code was written, malloc() regions were
544 // represented by conjured symbols, which are all in UnknownSpaceRegion.
545 // This means that there isn't actually anything from HeapSpaceRegion
546 // that should be freed, even though we allow it here.
547 // Of course, free() can work on memory allocated outside the current
548 // function, so UnknownSpaceRegion is always a possibility.
549 // False negatives are better than false positives.
550
551 ReportBadFree(C, ArgVal, ArgExpr->getSourceRange());
Anna Zaksb319e022012-02-08 20:13:28 +0000552 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000553 }
554
555 const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R);
556 // Various cases could lead to non-symbol values here.
557 // For now, ignore them.
558 if (!SR)
Anna Zaksb319e022012-02-08 20:13:28 +0000559 return 0;
Jordy Rose43859f62010-06-07 19:32:37 +0000560
561 SymbolRef Sym = SR->getSymbol();
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000562 const RefState *RS = state->get<RegionState>(Sym);
Zhongxing Xu7e3cda92010-01-18 03:27:34 +0000563
564 // If the symbol has not been tracked, return. This is possible when free() is
565 // called on a pointer that does not get its pointee directly from malloc().
566 // Full support of this requires inter-procedural analysis.
567 if (!RS)
Anna Zaksb319e022012-02-08 20:13:28 +0000568 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000569
570 // Check double free.
Zhongxing Xu243fde92009-11-17 07:54:15 +0000571 if (RS->isReleased()) {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000572 if (ExplodedNode *N = C.generateSink()) {
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000573 if (!BT_DoubleFree)
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000574 BT_DoubleFree.reset(
Anna Zaksfebdc322012-02-16 22:26:12 +0000575 new BugType("Double free", "Memory Error"));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000576 BugReport *R = new BugReport(*BT_DoubleFree,
Anna Zaksfebdc322012-02-16 22:26:12 +0000577 "Attempt to free released memory", N);
Anna Zaksfe571602012-02-16 22:26:07 +0000578 R->addRange(ArgExpr->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +0000579 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +0000580 R->addVisitor(new MallocBugVisitor(Sym));
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000581 C.EmitReport(R);
582 }
Anna Zaksb319e022012-02-08 20:13:28 +0000583 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000584 }
585
586 // Normal free.
Ted Kremenekdd0e4902010-07-31 01:52:11 +0000587 if (Hold)
Anna Zaksb276bd92012-02-14 00:26:13 +0000588 return state->set<RegionState>(Sym, RefState::getRelinquished(CE));
589 return state->set<RegionState>(Sym, RefState::getReleased(CE));
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000590}
591
Ted Kremenek9c378f72011-08-12 23:37:29 +0000592bool MallocChecker::SummarizeValue(raw_ostream &os, SVal V) {
Jordy Rose43859f62010-06-07 19:32:37 +0000593 if (nonloc::ConcreteInt *IntVal = dyn_cast<nonloc::ConcreteInt>(&V))
594 os << "an integer (" << IntVal->getValue() << ")";
595 else if (loc::ConcreteInt *ConstAddr = dyn_cast<loc::ConcreteInt>(&V))
596 os << "a constant address (" << ConstAddr->getValue() << ")";
597 else if (loc::GotoLabel *Label = dyn_cast<loc::GotoLabel>(&V))
Chris Lattner68106302011-02-17 05:38:27 +0000598 os << "the address of the label '" << Label->getLabel()->getName() << "'";
Jordy Rose43859f62010-06-07 19:32:37 +0000599 else
600 return false;
601
602 return true;
603}
604
Ted Kremenek9c378f72011-08-12 23:37:29 +0000605bool MallocChecker::SummarizeRegion(raw_ostream &os,
Jordy Rose43859f62010-06-07 19:32:37 +0000606 const MemRegion *MR) {
607 switch (MR->getKind()) {
608 case MemRegion::FunctionTextRegionKind: {
609 const FunctionDecl *FD = cast<FunctionTextRegion>(MR)->getDecl();
610 if (FD)
Benjamin Kramerb8989f22011-10-14 18:45:37 +0000611 os << "the address of the function '" << *FD << '\'';
Jordy Rose43859f62010-06-07 19:32:37 +0000612 else
613 os << "the address of a function";
614 return true;
615 }
616 case MemRegion::BlockTextRegionKind:
617 os << "block text";
618 return true;
619 case MemRegion::BlockDataRegionKind:
620 // FIXME: where the block came from?
621 os << "a block";
622 return true;
623 default: {
624 const MemSpaceRegion *MS = MR->getMemorySpace();
625
Anna Zakseb31a762012-01-04 23:54:01 +0000626 if (isa<StackLocalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000627 const VarRegion *VR = dyn_cast<VarRegion>(MR);
628 const VarDecl *VD;
629 if (VR)
630 VD = VR->getDecl();
631 else
632 VD = NULL;
633
634 if (VD)
635 os << "the address of the local variable '" << VD->getName() << "'";
636 else
637 os << "the address of a local stack variable";
638 return true;
639 }
Anna Zakseb31a762012-01-04 23:54:01 +0000640
641 if (isa<StackArgumentsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000642 const VarRegion *VR = dyn_cast<VarRegion>(MR);
643 const VarDecl *VD;
644 if (VR)
645 VD = VR->getDecl();
646 else
647 VD = NULL;
648
649 if (VD)
650 os << "the address of the parameter '" << VD->getName() << "'";
651 else
652 os << "the address of a parameter";
653 return true;
654 }
Anna Zakseb31a762012-01-04 23:54:01 +0000655
656 if (isa<GlobalsSpaceRegion>(MS)) {
Jordy Rose43859f62010-06-07 19:32:37 +0000657 const VarRegion *VR = dyn_cast<VarRegion>(MR);
658 const VarDecl *VD;
659 if (VR)
660 VD = VR->getDecl();
661 else
662 VD = NULL;
663
664 if (VD) {
665 if (VD->isStaticLocal())
666 os << "the address of the static variable '" << VD->getName() << "'";
667 else
668 os << "the address of the global variable '" << VD->getName() << "'";
669 } else
670 os << "the address of a global variable";
671 return true;
672 }
Anna Zakseb31a762012-01-04 23:54:01 +0000673
674 return false;
Jordy Rose43859f62010-06-07 19:32:37 +0000675 }
676 }
677}
678
679void MallocChecker::ReportBadFree(CheckerContext &C, SVal ArgVal,
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000680 SourceRange range) const {
Ted Kremenekd048c6e2010-12-20 21:19:09 +0000681 if (ExplodedNode *N = C.generateSink()) {
Jordy Rose43859f62010-06-07 19:32:37 +0000682 if (!BT_BadFree)
Anna Zaksfebdc322012-02-16 22:26:12 +0000683 BT_BadFree.reset(new BugType("Bad free", "Memory Error"));
Jordy Rose43859f62010-06-07 19:32:37 +0000684
Dylan Noblesmithf7ccbad2012-02-05 02:13:05 +0000685 SmallString<100> buf;
Jordy Rose43859f62010-06-07 19:32:37 +0000686 llvm::raw_svector_ostream os(buf);
687
688 const MemRegion *MR = ArgVal.getAsRegion();
689 if (MR) {
690 while (const ElementRegion *ER = dyn_cast<ElementRegion>(MR))
691 MR = ER->getSuperRegion();
692
693 // Special case for alloca()
694 if (isa<AllocaRegion>(MR))
695 os << "Argument to free() was allocated by alloca(), not malloc()";
696 else {
697 os << "Argument to free() is ";
698 if (SummarizeRegion(os, MR))
699 os << ", which is not memory allocated by malloc()";
700 else
701 os << "not memory allocated by malloc()";
702 }
703 } else {
704 os << "Argument to free() is ";
705 if (SummarizeValue(os, ArgVal))
706 os << ", which is not memory allocated by malloc()";
707 else
708 os << "not memory allocated by malloc()";
709 }
710
Anna Zakse172e8b2011-08-17 23:00:25 +0000711 BugReport *R = new BugReport(*BT_BadFree, os.str(), N);
Ted Kremenek76aadc32012-03-09 01:13:14 +0000712 R->markInteresting(MR);
Jordy Rose43859f62010-06-07 19:32:37 +0000713 R->addRange(range);
714 C.EmitReport(R);
715 }
716}
717
Anna Zaks87cb5be2012-02-22 19:24:52 +0000718ProgramStateRef MallocChecker::ReallocMem(CheckerContext &C,
719 const CallExpr *CE,
720 bool FreesOnFail) const {
Anna Zaks259052d2012-04-10 23:41:11 +0000721 if (CE->getNumArgs() < 2)
722 return 0;
723
Ted Kremenek8bef8232012-01-26 21:29:00 +0000724 ProgramStateRef state = C.getState();
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000725 const Expr *arg0Expr = CE->getArg(0);
Ted Kremenek5eca4822012-01-06 22:09:28 +0000726 const LocationContext *LCtx = C.getLocationContext();
Anna Zakse9ef5622012-02-10 01:11:00 +0000727 SVal Arg0Val = state->getSVal(arg0Expr, LCtx);
728 if (!isa<DefinedOrUnknownSVal>(Arg0Val))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000729 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000730 DefinedOrUnknownSVal arg0Val = cast<DefinedOrUnknownSVal>(Arg0Val);
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000731
Ted Kremenek846eabd2010-12-01 21:28:31 +0000732 SValBuilder &svalBuilder = C.getSValBuilder();
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000733
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000734 DefinedOrUnknownSVal PtrEQ =
735 svalBuilder.evalEQ(state, arg0Val, svalBuilder.makeNull());
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000736
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000737 // Get the size argument. If there is no size arg then give up.
738 const Expr *Arg1 = CE->getArg(1);
739 if (!Arg1)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000740 return 0;
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000741
742 // Get the value of the size argument.
Anna Zakse9ef5622012-02-10 01:11:00 +0000743 SVal Arg1ValG = state->getSVal(Arg1, LCtx);
744 if (!isa<DefinedOrUnknownSVal>(Arg1ValG))
Anna Zaks87cb5be2012-02-22 19:24:52 +0000745 return 0;
Anna Zakse9ef5622012-02-10 01:11:00 +0000746 DefinedOrUnknownSVal Arg1Val = cast<DefinedOrUnknownSVal>(Arg1ValG);
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000747
748 // Compare the size argument to 0.
749 DefinedOrUnknownSVal SizeZero =
750 svalBuilder.evalEQ(state, Arg1Val,
751 svalBuilder.makeIntValWithPtrWidth(0, false));
752
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000753 ProgramStateRef StatePtrIsNull, StatePtrNotNull;
754 llvm::tie(StatePtrIsNull, StatePtrNotNull) = state->assume(PtrEQ);
755 ProgramStateRef StateSizeIsZero, StateSizeNotZero;
756 llvm::tie(StateSizeIsZero, StateSizeNotZero) = state->assume(SizeZero);
757 // We only assume exceptional states if they are definitely true; if the
758 // state is under-constrained, assume regular realloc behavior.
759 bool PrtIsNull = StatePtrIsNull && !StatePtrNotNull;
760 bool SizeIsZero = StateSizeIsZero && !StateSizeNotZero;
761
Lenny Maiorani4d8d8032011-04-27 14:49:29 +0000762 // If the ptr is NULL and the size is not 0, the call is equivalent to
763 // malloc(size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000764 if ( PrtIsNull && !SizeIsZero) {
Anna Zaks87cb5be2012-02-22 19:24:52 +0000765 ProgramStateRef stateMalloc = MallocMemAux(C, CE, CE->getArg(1),
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000766 UndefinedVal(), StatePtrIsNull);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000767 return stateMalloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000768 }
769
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000770 if (PrtIsNull && SizeIsZero)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000771 return 0;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000772
Anna Zaks30838b92012-02-13 20:57:07 +0000773 // Get the from and to pointer symbols as in toPtr = realloc(fromPtr, size).
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000774 assert(!PrtIsNull);
Anna Zaks30838b92012-02-13 20:57:07 +0000775 SymbolRef FromPtr = arg0Val.getAsSymbol();
776 SVal RetVal = state->getSVal(CE, LCtx);
777 SymbolRef ToPtr = RetVal.getAsSymbol();
778 if (!FromPtr || !ToPtr)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000779 return 0;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000780
781 // If the size is 0, free the memory.
782 if (SizeIsZero)
783 if (ProgramStateRef stateFree = FreeMemAux(C, CE, StateSizeIsZero,0,false)){
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000784 // The semantics of the return value are:
785 // If size was equal to 0, either NULL or a pointer suitable to be passed
786 // to free() is returned.
Anna Zaks40add292012-02-15 00:11:25 +0000787 stateFree = stateFree->set<ReallocPairs>(ToPtr,
788 ReallocPair(FromPtr, FreesOnFail));
Anna Zaksb276bd92012-02-14 00:26:13 +0000789 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000790 return stateFree;
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000791 }
792
793 // Default behavior.
794 if (ProgramStateRef stateFree = FreeMemAux(C, CE, state, 0, false)) {
795 // FIXME: We should copy the content of the original buffer.
796 ProgramStateRef stateRealloc = MallocMemAux(C, CE, CE->getArg(1),
797 UnknownVal(), stateFree);
Anna Zaks30838b92012-02-13 20:57:07 +0000798 if (!stateRealloc)
Anna Zaks87cb5be2012-02-22 19:24:52 +0000799 return 0;
Anna Zaks40add292012-02-15 00:11:25 +0000800 stateRealloc = stateRealloc->set<ReallocPairs>(ToPtr,
801 ReallocPair(FromPtr, FreesOnFail));
Anna Zaksb276bd92012-02-14 00:26:13 +0000802 C.getSymbolManager().addSymbolDependency(ToPtr, FromPtr);
Anna Zaks87cb5be2012-02-22 19:24:52 +0000803 return stateRealloc;
Zhongxing Xud9c84c82009-12-12 12:29:38 +0000804 }
Anna Zaks87cb5be2012-02-22 19:24:52 +0000805 return 0;
Zhongxing Xu589c0f22009-11-12 08:38:56 +0000806}
Zhongxing Xu7b760962009-11-13 07:25:27 +0000807
Anna Zaks87cb5be2012-02-22 19:24:52 +0000808ProgramStateRef MallocChecker::CallocMem(CheckerContext &C, const CallExpr *CE){
Anna Zaks259052d2012-04-10 23:41:11 +0000809 if (CE->getNumArgs() < 2)
810 return 0;
811
Ted Kremenek8bef8232012-01-26 21:29:00 +0000812 ProgramStateRef state = C.getState();
Ted Kremenek846eabd2010-12-01 21:28:31 +0000813 SValBuilder &svalBuilder = C.getSValBuilder();
Ted Kremenek5eca4822012-01-06 22:09:28 +0000814 const LocationContext *LCtx = C.getLocationContext();
815 SVal count = state->getSVal(CE->getArg(0), LCtx);
816 SVal elementSize = state->getSVal(CE->getArg(1), LCtx);
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000817 SVal TotalSize = svalBuilder.evalBinOp(state, BO_Mul, count, elementSize,
818 svalBuilder.getContext().getSizeType());
819 SVal zeroVal = svalBuilder.makeZeroVal(svalBuilder.getContext().CharTy);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000820
Anna Zaks87cb5be2012-02-22 19:24:52 +0000821 return MallocMemAux(C, CE, TotalSize, zeroVal, state);
Zhongxing Xua5ce9662010-06-01 03:01:33 +0000822}
823
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000824LeakInfo
Anna Zaksca8e36e2012-02-23 21:38:21 +0000825MallocChecker::getAllocationSite(const ExplodedNode *N, SymbolRef Sym,
826 CheckerContext &C) const {
Anna Zaks7752d292012-02-27 23:40:55 +0000827 const LocationContext *LeakContext = N->getLocationContext();
Anna Zaksca8e36e2012-02-23 21:38:21 +0000828 // Walk the ExplodedGraph backwards and find the first node that referred to
829 // the tracked symbol.
830 const ExplodedNode *AllocNode = N;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000831 const MemRegion *ReferenceRegion = 0;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000832
833 while (N) {
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000834 ProgramStateRef State = N->getState();
835 if (!State->get<RegionState>(Sym))
Anna Zaksca8e36e2012-02-23 21:38:21 +0000836 break;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000837
838 // Find the most recent expression bound to the symbol in the current
839 // context.
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000840 if (!ReferenceRegion) {
Benjamin Kramer850f1b12012-03-21 21:03:48 +0000841 if (const MemRegion *MR = C.getLocationRegionIfPostStore(N)) {
842 SVal Val = State->getSVal(MR);
843 if (Val.getAsLocSymbol() == Sym)
844 ReferenceRegion = MR;
845 }
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000846 }
847
Anna Zaks7752d292012-02-27 23:40:55 +0000848 // Allocation node, is the last node in the current context in which the
849 // symbol was tracked.
850 if (N->getLocationContext() == LeakContext)
851 AllocNode = N;
Anna Zaksca8e36e2012-02-23 21:38:21 +0000852 N = N->pred_empty() ? NULL : *(N->pred_begin());
853 }
854
855 ProgramPoint P = AllocNode->getLocation();
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000856 const Stmt *AllocationStmt = 0;
857 if (isa<StmtPoint>(P))
858 AllocationStmt = cast<StmtPoint>(P).getStmt();
Anna Zaks7752d292012-02-27 23:40:55 +0000859
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000860 return LeakInfo(AllocationStmt, ReferenceRegion);
Anna Zaksca8e36e2012-02-23 21:38:21 +0000861}
862
Anna Zaksda046772012-02-11 21:02:40 +0000863void MallocChecker::reportLeak(SymbolRef Sym, ExplodedNode *N,
864 CheckerContext &C) const {
865 assert(N);
866 if (!BT_Leak) {
Anna Zaksfebdc322012-02-16 22:26:12 +0000867 BT_Leak.reset(new BugType("Memory leak", "Memory Error"));
Anna Zaksda046772012-02-11 21:02:40 +0000868 // Leaks should not be reported if they are post-dominated by a sink:
869 // (1) Sinks are higher importance bugs.
870 // (2) NoReturnFunctionChecker uses sink nodes to represent paths ending
871 // with __noreturn functions such as assert() or exit(). We choose not
872 // to report leaks on such paths.
873 BT_Leak->setSuppressOnSink(true);
874 }
875
Anna Zaksca8e36e2012-02-23 21:38:21 +0000876 // Most bug reports are cached at the location where they occurred.
877 // With leaks, we want to unique them by the location where they were
878 // allocated, and only report a single path.
Anna Zaks7752d292012-02-27 23:40:55 +0000879 PathDiagnosticLocation LocUsedForUniqueing;
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000880 const Stmt *AllocStmt = 0;
881 const MemRegion *Region = 0;
882 llvm::tie(AllocStmt, Region) = getAllocationSite(N, Sym, C);
883 if (AllocStmt)
Anna Zaks7752d292012-02-27 23:40:55 +0000884 LocUsedForUniqueing = PathDiagnosticLocation::createBegin(AllocStmt,
885 C.getSourceManager(), N->getLocationContext());
Anna Zaksca8e36e2012-02-23 21:38:21 +0000886
Anna Zaks3d7c44e2012-03-21 19:45:08 +0000887 SmallString<200> buf;
888 llvm::raw_svector_ostream os(buf);
889 os << "Memory is never released; potential leak";
890 if (Region) {
891 os << " of memory pointed to by '";
892 Region->dumpPretty(os);
893 os <<'\'';
894 }
895
896 BugReport *R = new BugReport(*BT_Leak, os.str(), N, LocUsedForUniqueing);
Ted Kremenek76aadc32012-03-09 01:13:14 +0000897 R->markInteresting(Sym);
Anna Zaksda046772012-02-11 21:02:40 +0000898 R->addVisitor(new MallocBugVisitor(Sym));
899 C.EmitReport(R);
900}
901
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +0000902void MallocChecker::checkDeadSymbols(SymbolReaper &SymReaper,
903 CheckerContext &C) const
Ted Kremenekc8413fd2010-12-02 07:49:45 +0000904{
Zhongxing Xu173ff562010-08-15 08:19:57 +0000905 if (!SymReaper.hasDeadSymbols())
906 return;
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +0000907
Ted Kremenek8bef8232012-01-26 21:29:00 +0000908 ProgramStateRef state = C.getState();
Zhongxing Xu173ff562010-08-15 08:19:57 +0000909 RegionStateTy RS = state->get<RegionState>();
Jordy Rose90760142010-08-18 04:33:47 +0000910 RegionStateTy::Factory &F = state->get_context<RegionState>();
Zhongxing Xu173ff562010-08-15 08:19:57 +0000911
Ted Kremenek217470e2011-07-28 23:07:51 +0000912 bool generateReport = false;
Anna Zaksf8c17b72012-02-09 06:48:19 +0000913 llvm::SmallVector<SymbolRef, 2> Errors;
Zhongxing Xu173ff562010-08-15 08:19:57 +0000914 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
915 if (SymReaper.isDead(I->first)) {
Anna Zaksf8c17b72012-02-09 06:48:19 +0000916 if (I->second.isAllocated()) {
Ted Kremenek217470e2011-07-28 23:07:51 +0000917 generateReport = true;
Anna Zaksf8c17b72012-02-09 06:48:19 +0000918 Errors.push_back(I->first);
919 }
Jordy Rose90760142010-08-18 04:33:47 +0000920 // Remove the dead symbol from the map.
Ted Kremenek3baf6722010-11-24 00:54:37 +0000921 RS = F.remove(RS, I->first);
Ted Kremenek217470e2011-07-28 23:07:51 +0000922
Zhongxing Xufc7ac8f2009-11-13 07:48:11 +0000923 }
924 }
Ted Kremenek217470e2011-07-28 23:07:51 +0000925
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000926 // Cleanup the Realloc Pairs Map.
Anna Zaks40add292012-02-15 00:11:25 +0000927 ReallocMap RP = state->get<ReallocPairs>();
928 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
929 if (SymReaper.isDead(I->first) ||
930 SymReaper.isDead(I->second.ReallocatedSym)) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +0000931 state = state->remove<ReallocPairs>(I->first);
932 }
933 }
934
Anna Zaksca8e36e2012-02-23 21:38:21 +0000935 // Generate leak node.
936 static SimpleProgramPointTag Tag("MallocChecker : DeadSymbolsLeak");
937 ExplodedNode *N = C.addTransition(C.getState(), C.getPredecessor(), &Tag);
Ted Kremenek217470e2011-07-28 23:07:51 +0000938
Anna Zaksca8e36e2012-02-23 21:38:21 +0000939 if (generateReport) {
Anna Zaksf8c17b72012-02-09 06:48:19 +0000940 for (llvm::SmallVector<SymbolRef, 2>::iterator
Anna Zaksda046772012-02-11 21:02:40 +0000941 I = Errors.begin(), E = Errors.end(); I != E; ++I) {
942 reportLeak(*I, N, C);
Anna Zaksf8c17b72012-02-09 06:48:19 +0000943 }
Ted Kremenek217470e2011-07-28 23:07:51 +0000944 }
Anna Zaksca8e36e2012-02-23 21:38:21 +0000945 C.addTransition(state->set<RegionState>(RS), N);
Zhongxing Xu7b760962009-11-13 07:25:27 +0000946}
Zhongxing Xu243fde92009-11-17 07:54:15 +0000947
Anna Zaksda046772012-02-11 21:02:40 +0000948void MallocChecker::checkEndPath(CheckerContext &C) const {
949 ProgramStateRef state = C.getState();
Jordy Rose09cef092010-08-18 04:26:59 +0000950 RegionStateTy M = state->get<RegionState>();
Zhongxing Xu243fde92009-11-17 07:54:15 +0000951
Anna Zaksa19581a2012-02-20 22:25:23 +0000952 // If inside inlined call, skip it.
953 if (C.getLocationContext()->getParent() != 0)
954 return;
955
Jordy Rose09cef092010-08-18 04:26:59 +0000956 for (RegionStateTy::iterator I = M.begin(), E = M.end(); I != E; ++I) {
Zhongxing Xu243fde92009-11-17 07:54:15 +0000957 RefState RS = I->second;
958 if (RS.isAllocated()) {
Anna Zaksda046772012-02-11 21:02:40 +0000959 ExplodedNode *N = C.addTransition(state);
960 if (N)
961 reportLeak(I->first, N, C);
Zhongxing Xu243fde92009-11-17 07:54:15 +0000962 }
963 }
964}
Zhongxing Xu4985e3e2009-11-17 08:58:18 +0000965
Anna Zaks91c2a112012-02-08 23:16:56 +0000966bool MallocChecker::checkEscape(SymbolRef Sym, const Stmt *S,
967 CheckerContext &C) const {
Ted Kremenek8bef8232012-01-26 21:29:00 +0000968 ProgramStateRef state = C.getState();
Anna Zaks91c2a112012-02-08 23:16:56 +0000969 const RefState *RS = state->get<RegionState>(Sym);
970 if (!RS)
971 return false;
Zhongxing Xu4985e3e2009-11-17 08:58:18 +0000972
Anna Zaks91c2a112012-02-08 23:16:56 +0000973 if (RS->isAllocated()) {
974 state = state->set<RegionState>(Sym, RefState::getEscaped(S));
975 C.addTransition(state);
976 return true;
977 }
978 return false;
979}
980
Anna Zaks66c40402012-02-14 21:55:24 +0000981void MallocChecker::checkPreStmt(const CallExpr *CE, CheckerContext &C) const {
982 if (isMemFunction(C.getCalleeDecl(CE), C.getASTContext()))
983 return;
984
985 // Check use after free, when a freed pointer is passed to a call.
986 ProgramStateRef State = C.getState();
987 for (CallExpr::const_arg_iterator I = CE->arg_begin(),
988 E = CE->arg_end(); I != E; ++I) {
989 const Expr *A = *I;
990 if (A->getType().getTypePtr()->isAnyPointerType()) {
991 SymbolRef Sym = State->getSVal(A, C.getLocationContext()).getAsSymbol();
992 if (!Sym)
993 continue;
994 if (checkUseAfterFree(Sym, C, A))
995 return;
996 }
997 }
998}
999
Anna Zaks91c2a112012-02-08 23:16:56 +00001000void MallocChecker::checkPreStmt(const ReturnStmt *S, CheckerContext &C) const {
1001 const Expr *E = S->getRetValue();
1002 if (!E)
1003 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001004
1005 // Check if we are returning a symbol.
Anna Zaksd9ab7bb2012-02-22 02:36:01 +00001006 SVal RetVal = C.getState()->getSVal(E, C.getLocationContext());
1007 SymbolRef Sym = RetVal.getAsSymbol();
1008 if (!Sym)
1009 // If we are returning a field of the allocated struct or an array element,
1010 // the callee could still free the memory.
1011 // TODO: This logic should be a part of generic symbol escape callback.
1012 if (const MemRegion *MR = RetVal.getAsRegion())
1013 if (isa<FieldRegion>(MR) || isa<ElementRegion>(MR))
1014 if (const SymbolicRegion *BMR =
1015 dyn_cast<SymbolicRegion>(MR->getBaseRegion()))
1016 Sym = BMR->getSymbol();
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001017 if (!Sym)
1018 return;
1019
Anna Zaks0860cd02012-02-11 21:44:39 +00001020 // Check if we are returning freed memory.
Anna Zaksfe571602012-02-16 22:26:07 +00001021 if (checkUseAfterFree(Sym, C, E))
Anna Zaks15d0ae12012-02-11 23:46:36 +00001022 return;
Anna Zaks0860cd02012-02-11 21:44:39 +00001023
Anna Zaksa19581a2012-02-20 22:25:23 +00001024 // If this function body is not inlined, check if the symbol is escaping.
1025 if (C.getLocationContext()->getParent() == 0)
1026 checkEscape(Sym, E, C);
Zhongxing Xu4985e3e2009-11-17 08:58:18 +00001027}
Zhongxing Xub94b81a2009-12-31 06:13:07 +00001028
Anna Zaksf5aa3f52012-03-22 00:57:20 +00001029// TODO: Blocks should be either inlined or should call invalidate regions
1030// upon invocation. After that's in place, special casing here will not be
1031// needed.
1032void MallocChecker::checkPostStmt(const BlockExpr *BE,
1033 CheckerContext &C) const {
1034
1035 // Scan the BlockDecRefExprs for any object the retain count checker
1036 // may be tracking.
1037 if (!BE->getBlockDecl()->hasCaptures())
1038 return;
1039
1040 ProgramStateRef state = C.getState();
1041 const BlockDataRegion *R =
1042 cast<BlockDataRegion>(state->getSVal(BE,
1043 C.getLocationContext()).getAsRegion());
1044
1045 BlockDataRegion::referenced_vars_iterator I = R->referenced_vars_begin(),
1046 E = R->referenced_vars_end();
1047
1048 if (I == E)
1049 return;
1050
1051 SmallVector<const MemRegion*, 10> Regions;
1052 const LocationContext *LC = C.getLocationContext();
1053 MemRegionManager &MemMgr = C.getSValBuilder().getRegionManager();
1054
1055 for ( ; I != E; ++I) {
1056 const VarRegion *VR = *I;
1057 if (VR->getSuperRegion() == R) {
1058 VR = MemMgr.getVarRegion(VR->getDecl(), LC);
1059 }
1060 Regions.push_back(VR);
1061 }
1062
1063 state =
1064 state->scanReachableSymbols<StopTrackingCallback>(Regions.data(),
1065 Regions.data() + Regions.size()).getState();
1066 C.addTransition(state);
1067}
1068
Anna Zaks91c2a112012-02-08 23:16:56 +00001069bool MallocChecker::checkUseAfterFree(SymbolRef Sym, CheckerContext &C,
1070 const Stmt *S) const {
1071 assert(Sym);
1072 const RefState *RS = C.getState()->get<RegionState>(Sym);
1073 if (RS && RS->isReleased()) {
Anna Zaks15d0ae12012-02-11 23:46:36 +00001074 if (ExplodedNode *N = C.generateSink()) {
Anna Zaks91c2a112012-02-08 23:16:56 +00001075 if (!BT_UseFree)
Anna Zaksfebdc322012-02-16 22:26:12 +00001076 BT_UseFree.reset(new BugType("Use-after-free", "Memory Error"));
Anna Zaks91c2a112012-02-08 23:16:56 +00001077
Anna Zaksfebdc322012-02-16 22:26:12 +00001078 BugReport *R = new BugReport(*BT_UseFree,
1079 "Use of memory after it is freed",N);
Anna Zaks91c2a112012-02-08 23:16:56 +00001080 if (S)
1081 R->addRange(S->getSourceRange());
Ted Kremenek76aadc32012-03-09 01:13:14 +00001082 R->markInteresting(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001083 R->addVisitor(new MallocBugVisitor(Sym));
Anna Zaks91c2a112012-02-08 23:16:56 +00001084 C.EmitReport(R);
1085 return true;
1086 }
1087 }
1088 return false;
1089}
1090
Zhongxing Xuc8023782010-03-10 04:58:55 +00001091// Check if the location is a freed symbolic region.
Anna Zaks390909c2011-10-06 00:43:15 +00001092void MallocChecker::checkLocation(SVal l, bool isLoad, const Stmt *S,
1093 CheckerContext &C) const {
Zhongxing Xuc8023782010-03-10 04:58:55 +00001094 SymbolRef Sym = l.getLocSymbolInBase();
Anna Zaks91c2a112012-02-08 23:16:56 +00001095 if (Sym)
1096 checkUseAfterFree(Sym, C);
Zhongxing Xuc8023782010-03-10 04:58:55 +00001097}
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001098
Anna Zaks4fb54872012-02-11 21:02:35 +00001099//===----------------------------------------------------------------------===//
1100// Check various ways a symbol can be invalidated.
1101// TODO: This logic (the next 3 functions) is copied/similar to the
1102// RetainRelease checker. We might want to factor this out.
1103//===----------------------------------------------------------------------===//
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001104
Anna Zaks4fb54872012-02-11 21:02:35 +00001105// Stop tracking symbols when a value escapes as a result of checkBind.
1106// A value escapes in three possible cases:
1107// (1) we are binding to something that is not a memory region.
1108// (2) we are binding to a memregion that does not have stack storage
1109// (3) we are binding to a memregion with stack storage that the store
1110// does not understand.
1111void MallocChecker::checkBind(SVal loc, SVal val, const Stmt *S,
1112 CheckerContext &C) const {
1113 // Are we storing to something that causes the value to "escape"?
1114 bool escapes = true;
Ted Kremenek8bef8232012-01-26 21:29:00 +00001115 ProgramStateRef state = C.getState();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001116
Anna Zaks4fb54872012-02-11 21:02:35 +00001117 if (loc::MemRegionVal *regionLoc = dyn_cast<loc::MemRegionVal>(&loc)) {
1118 escapes = !regionLoc->getRegion()->hasStackStorage();
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001119
Anna Zaks4fb54872012-02-11 21:02:35 +00001120 if (!escapes) {
1121 // To test (3), generate a new state with the binding added. If it is
1122 // the same state, then it escapes (since the store cannot represent
1123 // the binding).
Anna Zaks93c5a242012-05-02 00:05:20 +00001124 // Do this only if we know that the store is not supposed to generate the
1125 // same state.
1126 SVal StoredVal = state->getSVal(regionLoc->getRegion());
1127 if (StoredVal != val)
1128 escapes = (state == (state->bindLoc(*regionLoc, val)));
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001129 }
Anna Zaksac593002012-02-16 03:40:57 +00001130 if (!escapes) {
1131 // Case 4: We do not currently model what happens when a symbol is
1132 // assigned to a struct field, so be conservative here and let the symbol
1133 // go. TODO: This could definitely be improved upon.
1134 escapes = !isa<VarRegion>(regionLoc->getRegion());
1135 }
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001136 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001137
1138 // If our store can represent the binding and we aren't storing to something
1139 // that doesn't have local storage then just return and have the simulation
1140 // state continue as is.
1141 if (!escapes)
1142 return;
1143
1144 // Otherwise, find all symbols referenced by 'val' that we are tracking
1145 // and stop tracking them.
1146 state = state->scanReachableSymbols<StopTrackingCallback>(val).getState();
1147 C.addTransition(state);
1148}
1149
1150// If a symbolic region is assumed to NULL (or another constant), stop tracking
1151// it - assuming that allocation failed on this path.
1152ProgramStateRef MallocChecker::evalAssume(ProgramStateRef state,
1153 SVal Cond,
1154 bool Assumption) const {
1155 RegionStateTy RS = state->get<RegionState>();
Anna Zaks4fb54872012-02-11 21:02:35 +00001156 for (RegionStateTy::iterator I = RS.begin(), E = RS.end(); I != E; ++I) {
1157 // If the symbol is assumed to NULL or another constant, this will
1158 // return an APSInt*.
1159 if (state->getSymVal(I.getKey()))
1160 state = state->remove<RegionState>(I.getKey());
1161 }
1162
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001163 // Realloc returns 0 when reallocation fails, which means that we should
1164 // restore the state of the pointer being reallocated.
Anna Zaks40add292012-02-15 00:11:25 +00001165 ReallocMap RP = state->get<ReallocPairs>();
1166 for (ReallocMap::iterator I = RP.begin(), E = RP.end(); I != E; ++I) {
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001167 // If the symbol is assumed to NULL or another constant, this will
1168 // return an APSInt*.
1169 if (state->getSymVal(I.getKey())) {
Anna Zaks40add292012-02-15 00:11:25 +00001170 SymbolRef ReallocSym = I.getData().ReallocatedSym;
1171 const RefState *RS = state->get<RegionState>(ReallocSym);
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001172 if (RS) {
Anna Zaks40add292012-02-15 00:11:25 +00001173 if (RS->isReleased() && ! I.getData().IsFreeOnFailure)
1174 state = state->set<RegionState>(ReallocSym,
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001175 RefState::getAllocateUnchecked(RS->getStmt()));
Anna Zaksc8bb3be2012-02-13 18:05:39 +00001176 }
1177 state = state->remove<ReallocPairs>(I.getKey());
1178 }
1179 }
1180
Anna Zaks4fb54872012-02-11 21:02:35 +00001181 return state;
1182}
1183
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001184// Check if the function is known to us. So, for example, we could
Anna Zaks66c40402012-02-14 21:55:24 +00001185// conservatively assume it can free/reallocate it's pointer arguments.
1186// (We assume that the pointers cannot escape through calls to system
1187// functions not handled by this checker.)
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001188bool MallocChecker::doesNotFreeMemory(const CallOrObjCMessage *Call,
1189 ProgramStateRef State) const {
1190 if (!Call)
1191 return false;
1192
1193 // For now, assume that any C++ call can free memory.
1194 // TODO: If we want to be more optimistic here, we'll need to make sure that
1195 // regions escape to C++ containers. They seem to do that even now, but for
1196 // mysterious reasons.
1197 if (Call->isCXXCall())
1198 return false;
1199
1200 const Decl *D = Call->getDecl();
1201 if (!D)
1202 return false;
1203
Anna Zaks66c40402012-02-14 21:55:24 +00001204 ASTContext &ASTC = State->getStateManager().getContext();
1205
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001206 // If it's one of the allocation functions we can reason about, we model
Jordy Rose257c60f2012-03-06 00:28:20 +00001207 // its behavior explicitly.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001208 if (isa<FunctionDecl>(D) && isMemFunction(cast<FunctionDecl>(D), ASTC)) {
1209 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001210 }
1211
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001212 // If it's not a system call, assume it frees memory.
Anna Zaks66c40402012-02-14 21:55:24 +00001213 SourceManager &SM = ASTC.getSourceManager();
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001214 if (!SM.isInSystemHeader(D->getLocation()))
1215 return false;
Anna Zaks0d389b82012-02-23 01:05:27 +00001216
Anna Zaks07d39a42012-02-28 01:54:22 +00001217 // Process C/ObjC functions.
Jordy Rose257c60f2012-03-06 00:28:20 +00001218 if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
Anna Zaks0d389b82012-02-23 01:05:27 +00001219 // White list the system functions whose arguments escape.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001220 const IdentifierInfo *II = FD->getIdentifier();
Anna Zaks07d39a42012-02-28 01:54:22 +00001221 if (!II)
1222 return true;
1223 StringRef FName = II->getName();
1224
1225 // White list thread local storage.
1226 if (FName.equals("pthread_setspecific"))
1227 return false;
1228
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001229 // White list the 'XXXNoCopy' ObjC functions.
Anna Zaks07d39a42012-02-28 01:54:22 +00001230 if (FName.endswith("NoCopy")) {
1231 // Look for the deallocator argument. We know that the memory ownership
1232 // is not transfered only if the deallocator argument is
1233 // 'kCFAllocatorNull'.
1234 for (unsigned i = 1; i < Call->getNumArgs(); ++i) {
1235 const Expr *ArgE = Call->getArg(i)->IgnoreParenCasts();
1236 if (const DeclRefExpr *DE = dyn_cast<DeclRefExpr>(ArgE)) {
1237 StringRef DeallocatorName = DE->getFoundDecl()->getName();
1238 if (DeallocatorName == "kCFAllocatorNull")
1239 return true;
1240 }
1241 }
1242 return false;
Anna Zaks0d389b82012-02-23 01:05:27 +00001243 }
1244
Anna Zaksca23eb22012-02-29 18:42:47 +00001245 // PR12101
1246 // Many CoreFoundation and CoreGraphics might allow a tracked object
1247 // to escape.
1248 if (Call->isCFCGAllowingEscape(FName))
1249 return false;
1250
1251 // Associating streams with malloced buffers. The pointer can escape if
1252 // 'closefn' is specified (and if that function does free memory).
1253 // Currently, we do not inspect the 'closefn' function (PR12101).
1254 if (FName == "funopen")
1255 if (Call->getNumArgs() >= 4 && !Call->getArgSVal(4).isConstant(0))
1256 return false;
1257
1258 // Do not warn on pointers passed to 'setbuf' when used with std streams,
1259 // these leaks might be intentional when setting the buffer for stdio.
1260 // http://stackoverflow.com/questions/2671151/who-frees-setvbuf-buffer
1261 if (FName == "setbuf" || FName =="setbuffer" ||
1262 FName == "setlinebuf" || FName == "setvbuf") {
1263 if (Call->getNumArgs() >= 1)
1264 if (const DeclRefExpr *Arg =
1265 dyn_cast<DeclRefExpr>(Call->getArg(0)->IgnoreParenCasts()))
1266 if (const VarDecl *D = dyn_cast<VarDecl>(Arg->getDecl()))
1267 if (D->getCanonicalDecl()->getName().find("std")
1268 != StringRef::npos)
1269 return false;
1270 }
1271
1272 // A bunch of other functions, which take ownership of a pointer (See retain
1273 // release checker). Not all the parameters here are invalidated, but the
1274 // Malloc checker cannot differentiate between them. The right way of doing
1275 // this would be to implement a pointer escapes callback.
1276 if (FName == "CVPixelBufferCreateWithBytes" ||
1277 FName == "CGBitmapContextCreateWithData" ||
Anna Zaks4cd7edf2012-03-26 18:18:39 +00001278 FName == "CVPixelBufferCreateWithPlanarBytes" ||
1279 FName == "OSAtomicEnqueue") {
Anna Zaksca23eb22012-02-29 18:42:47 +00001280 return false;
1281 }
1282
Anna Zaks62a5c342012-03-30 05:48:16 +00001283 // Whitelist NSXXInsertXX, for example NSMapInsertIfAbsent, since they can
1284 // be deallocated by NSMapRemove.
1285 if (FName.startswith("NS") && (FName.find("Insert") != StringRef::npos))
1286 return false;
1287
Anna Zaksaca0ac52012-05-03 23:50:28 +00001288 // If the call has a callback as an argument, assume the memory
1289 // can be freed.
1290 if (Call->hasNonZeroCallbackArg())
1291 return false;
1292
Anna Zaks0d389b82012-02-23 01:05:27 +00001293 // Otherwise, assume that the function does not free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001294 // Most system calls, do not free the memory.
1295 return true;
1296
1297 // Process ObjC functions.
1298 } else if (const ObjCMethodDecl * ObjCD = dyn_cast<ObjCMethodDecl>(D)) {
1299 Selector S = ObjCD->getSelector();
1300
1301 // White list the ObjC functions which do free memory.
1302 // - Anything containing 'freeWhenDone' param set to 1.
1303 // Ex: dataWithBytesNoCopy:length:freeWhenDone.
1304 for (unsigned i = 1; i < S.getNumArgs(); ++i) {
1305 if (S.getNameForSlot(i).equals("freeWhenDone")) {
1306 if (Call->getArgSVal(i).isConstant(1))
1307 return false;
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001308 else
1309 return true;
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001310 }
1311 }
1312
Anna Zaksfb7f76f2012-03-05 17:42:10 +00001313 // If the first selector ends with NoCopy, assume that the ownership is
1314 // transfered as well.
1315 // Ex: [NSData dataWithBytesNoCopy:bytes length:10];
1316 if (S.getNameForSlot(0).endswith("NoCopy")) {
1317 return false;
1318 }
1319
Anna Zaksaca0ac52012-05-03 23:50:28 +00001320 // If the call has a callback as an argument, assume the memory
1321 // can be freed.
1322 if (Call->hasNonZeroCallbackArg())
1323 return false;
1324
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001325 // Otherwise, assume that the function does not free memory.
1326 // Most system calls, do not free the memory.
1327 return true;
Anna Zaks66c40402012-02-14 21:55:24 +00001328 }
1329
1330 // Otherwise, assume that the function can free memory.
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001331 return false;
1332
Anna Zaks66c40402012-02-14 21:55:24 +00001333}
1334
Anna Zaks4fb54872012-02-11 21:02:35 +00001335// If the symbol we are tracking is invalidated, but not explicitly (ex: the &p
1336// escapes, when we are tracking p), do not track the symbol as we cannot reason
1337// about it anymore.
1338ProgramStateRef
Anna Zaks66c40402012-02-14 21:55:24 +00001339MallocChecker::checkRegionChanges(ProgramStateRef State,
Anna Zaks4fb54872012-02-11 21:02:35 +00001340 const StoreManager::InvalidatedSymbols *invalidated,
1341 ArrayRef<const MemRegion *> ExplicitRegions,
Anna Zaks66c40402012-02-14 21:55:24 +00001342 ArrayRef<const MemRegion *> Regions,
1343 const CallOrObjCMessage *Call) const {
Anna Zaks0d389b82012-02-23 01:05:27 +00001344 if (!invalidated || invalidated->empty())
Anna Zaks66c40402012-02-14 21:55:24 +00001345 return State;
Anna Zaks4fb54872012-02-11 21:02:35 +00001346 llvm::SmallPtrSet<SymbolRef, 8> WhitelistedSymbols;
Anna Zaks66c40402012-02-14 21:55:24 +00001347
Anna Zaks66c40402012-02-14 21:55:24 +00001348 // If it's a call which might free or reallocate memory, we assume that all
Anna Zaks3cd89ad2012-02-24 23:56:53 +00001349 // regions (explicit and implicit) escaped.
1350
1351 // Otherwise, whitelist explicit pointers; we still can track them.
1352 if (!Call || doesNotFreeMemory(Call, State)) {
Anna Zaks66c40402012-02-14 21:55:24 +00001353 for (ArrayRef<const MemRegion *>::iterator I = ExplicitRegions.begin(),
1354 E = ExplicitRegions.end(); I != E; ++I) {
1355 if (const SymbolicRegion *R = (*I)->StripCasts()->getAs<SymbolicRegion>())
1356 WhitelistedSymbols.insert(R->getSymbol());
1357 }
Anna Zaks4fb54872012-02-11 21:02:35 +00001358 }
1359
1360 for (StoreManager::InvalidatedSymbols::const_iterator I=invalidated->begin(),
1361 E = invalidated->end(); I!=E; ++I) {
1362 SymbolRef sym = *I;
1363 if (WhitelistedSymbols.count(sym))
1364 continue;
Anna Zaks66c40402012-02-14 21:55:24 +00001365 // The symbol escaped.
1366 if (const RefState *RS = State->get<RegionState>(sym))
1367 State = State->set<RegionState>(sym, RefState::getEscaped(RS->getStmt()));
Anna Zaks4fb54872012-02-11 21:02:35 +00001368 }
Anna Zaks66c40402012-02-14 21:55:24 +00001369 return State;
Ted Kremenekdd0e4902010-07-31 01:52:11 +00001370}
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001371
Jordy Rose393f98b2012-03-18 07:43:35 +00001372static SymbolRef findFailedReallocSymbol(ProgramStateRef currState,
1373 ProgramStateRef prevState) {
1374 ReallocMap currMap = currState->get<ReallocPairs>();
1375 ReallocMap prevMap = prevState->get<ReallocPairs>();
1376
1377 for (ReallocMap::iterator I = prevMap.begin(), E = prevMap.end();
1378 I != E; ++I) {
1379 SymbolRef sym = I.getKey();
1380 if (!currMap.lookup(sym))
1381 return sym;
1382 }
1383
1384 return NULL;
1385}
1386
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001387PathDiagnosticPiece *
1388MallocChecker::MallocBugVisitor::VisitNode(const ExplodedNode *N,
1389 const ExplodedNode *PrevN,
1390 BugReporterContext &BRC,
1391 BugReport &BR) {
Jordy Rose393f98b2012-03-18 07:43:35 +00001392 ProgramStateRef state = N->getState();
1393 ProgramStateRef statePrev = PrevN->getState();
1394
1395 const RefState *RS = state->get<RegionState>(Sym);
1396 const RefState *RSPrev = statePrev->get<RegionState>(Sym);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001397 if (!RS && !RSPrev)
1398 return 0;
1399
Anna Zaksfe571602012-02-16 22:26:07 +00001400 const Stmt *S = 0;
1401 const char *Msg = 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001402 StackHintGeneratorForSymbol *StackHint = 0;
Anna Zaksfe571602012-02-16 22:26:07 +00001403
1404 // Retrieve the associated statement.
1405 ProgramPoint ProgLoc = N->getLocation();
1406 if (isa<StmtPoint>(ProgLoc))
1407 S = cast<StmtPoint>(ProgLoc).getStmt();
1408 // If an assumption was made on a branch, it should be caught
1409 // here by looking at the state transition.
1410 if (isa<BlockEdge>(ProgLoc)) {
1411 const CFGBlock *srcBlk = cast<BlockEdge>(ProgLoc).getSrc();
1412 S = srcBlk->getTerminator();
1413 }
1414 if (!S)
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001415 return 0;
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001416
1417 // Find out if this is an interesting point and what is the kind.
Anna Zaksfe571602012-02-16 22:26:07 +00001418 if (Mode == Normal) {
Anna Zaks368a0d52012-03-15 21:13:02 +00001419 if (isAllocated(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001420 Msg = "Memory is allocated";
Anna Zaksfbd58742012-03-16 23:44:28 +00001421 StackHint = new StackHintGeneratorForSymbol(Sym,
1422 "Returned allocated memory");
Anna Zaks368a0d52012-03-15 21:13:02 +00001423 } else if (isReleased(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001424 Msg = "Memory is released";
Anna Zaksfbd58742012-03-16 23:44:28 +00001425 StackHint = new StackHintGeneratorForSymbol(Sym,
1426 "Returned released memory");
Anna Zaks368a0d52012-03-15 21:13:02 +00001427 } else if (isReallocFailedCheck(RS, RSPrev, S)) {
Anna Zaksfe571602012-02-16 22:26:07 +00001428 Mode = ReallocationFailed;
1429 Msg = "Reallocation failed";
Anna Zaks56a938f2012-03-16 23:24:20 +00001430 StackHint = new StackHintGeneratorForReallocationFailed(Sym,
Anna Zaksfbd58742012-03-16 23:44:28 +00001431 "Reallocation failed");
Jordy Rose393f98b2012-03-18 07:43:35 +00001432
Jordy Roseb000fb52012-03-24 03:15:09 +00001433 if (SymbolRef sym = findFailedReallocSymbol(state, statePrev)) {
1434 // Is it possible to fail two reallocs WITHOUT testing in between?
1435 assert((!FailedReallocSymbol || FailedReallocSymbol == sym) &&
1436 "We only support one failed realloc at a time.");
Jordy Rose393f98b2012-03-18 07:43:35 +00001437 BR.markInteresting(sym);
Jordy Roseb000fb52012-03-24 03:15:09 +00001438 FailedReallocSymbol = sym;
1439 }
Anna Zaksfe571602012-02-16 22:26:07 +00001440 }
1441
1442 // We are in a special mode if a reallocation failed later in the path.
1443 } else if (Mode == ReallocationFailed) {
Jordy Roseb000fb52012-03-24 03:15:09 +00001444 assert(FailedReallocSymbol && "No symbol to look for.");
Anna Zaksfe571602012-02-16 22:26:07 +00001445
Jordy Roseb000fb52012-03-24 03:15:09 +00001446 // Is this is the first appearance of the reallocated symbol?
1447 if (!statePrev->get<RegionState>(FailedReallocSymbol)) {
1448 // If we ever hit this assert, that means BugReporter has decided to skip
1449 // node pairs or visit them out of order.
1450 assert(state->get<RegionState>(FailedReallocSymbol) &&
1451 "Missed the reallocation point");
1452
1453 // We're at the reallocation point.
1454 Msg = "Attempt to reallocate memory";
1455 StackHint = new StackHintGeneratorForSymbol(Sym,
1456 "Returned reallocated memory");
1457 FailedReallocSymbol = NULL;
1458 Mode = Normal;
1459 }
Anna Zaksfe571602012-02-16 22:26:07 +00001460 }
1461
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001462 if (!Msg)
1463 return 0;
Anna Zaks56a938f2012-03-16 23:24:20 +00001464 assert(StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001465
1466 // Generate the extra diagnostic.
Anna Zaksfe571602012-02-16 22:26:07 +00001467 PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001468 N->getLocationContext());
Anna Zaks56a938f2012-03-16 23:24:20 +00001469 return new PathDiagnosticEventPiece(Pos, Msg, true, StackHint);
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001470}
1471
Anna Zaks93c5a242012-05-02 00:05:20 +00001472void MallocChecker::printState(raw_ostream &Out, ProgramStateRef State,
1473 const char *NL, const char *Sep) const {
1474
1475 RegionStateTy RS = State->get<RegionState>();
1476
1477 if (!RS.isEmpty())
1478 Out << "Has Malloc data" << NL;
1479}
Anna Zaksff3b9fd2012-02-09 06:25:51 +00001480
Anna Zaks231361a2012-02-08 23:16:52 +00001481#define REGISTER_CHECKER(name) \
1482void ento::register##name(CheckerManager &mgr) {\
Anna Zaksf0dfc9c2012-02-17 22:35:31 +00001483 registerCStringCheckerBasic(mgr); \
Anna Zaks231361a2012-02-08 23:16:52 +00001484 mgr.registerChecker<MallocChecker>()->Filter.C##name = true;\
Argyrios Kyrtzidis312dbec2011-02-28 01:26:35 +00001485}
Anna Zaks231361a2012-02-08 23:16:52 +00001486
1487REGISTER_CHECKER(MallocPessimistic)
1488REGISTER_CHECKER(MallocOptimistic)