Stephen Hines | 176edba | 2014-12-01 14:53:08 -0800 | [diff] [blame] | 1 | // RUN: %clang_cc1 -Wcstring-format-directive -verify -fsyntax-only %s |
| 2 | // rdar://18182443 |
| 3 | |
| 4 | typedef __builtin_va_list __darwin_va_list; |
| 5 | typedef __builtin_va_list va_list; |
| 6 | |
| 7 | @interface NSString |
| 8 | @end |
| 9 | |
| 10 | va_list argList; |
| 11 | |
| 12 | @interface NSString (NSStringExtensionMethods) |
| 13 | - (NSString *)stringByAppendingFormat:(NSString *)format, ... __attribute__((format(__NSString__, 1, 2))); |
| 14 | - (instancetype)initWithFormat:(NSString *)format, ... __attribute__((format(__NSString__, 1, 2))); // expected-note 2 {{method 'initWithFormat:' declared here}} |
| 15 | - (instancetype)initWithFormat:(NSString *)format arguments:(va_list)argList __attribute__((format(__NSString__, 1, 0))); |
| 16 | - (instancetype)initWithFormat:(NSString *)format locale:(id)locale, ... __attribute__((format(__NSString__, 1, 3))); |
| 17 | - (instancetype)initWithFormat:(NSString *)format locale:(id)locale arguments:(va_list)argList __attribute__((format(__NSString__, 1, 0))); |
| 18 | + (instancetype)stringWithFormat:(NSString *)format, ... __attribute__((format(__NSString__, 1, 2))); // expected-note {{method 'stringWithFormat:' declared here}} |
| 19 | + (instancetype)localizedStringWithFormat:(NSString *)format, ... __attribute__((format(__NSString__, 1, 2))); // expected-note {{method 'localizedStringWithFormat:' declared here}} |
| 20 | - (void)MyRandomMethod:(NSString *)format locale:(id)locale arguments:(va_list)argList __attribute__((format(__NSString__, 1, 0))); // expected-note {{method 'MyRandomMethod:locale:arguments:' declared here}} |
| 21 | @end |
| 22 | |
| 23 | @interface NSMutableString : NSString |
| 24 | @end |
| 25 | |
| 26 | @interface NSMutableString (NSMutableStringExtensionMethods) |
| 27 | |
| 28 | - (void)appendFormat:(NSString *)format, ... __attribute__((format(__NSString__, 1, 2))); |
| 29 | |
| 30 | @end |
| 31 | |
| 32 | NSString *ns(NSString *pns) { |
| 33 | [pns initWithFormat: @"Number %d length %c name %s", 1, 'a', "something"]; // expected-warning {{using %s directive in NSString which is being passed as a formatting argument to the formatting method}} |
| 34 | [NSString localizedStringWithFormat : @"Hello%s", " There"]; // expected-warning {{using %s directive in NSString which is being passed as a formatting argument to the formatting method}} |
| 35 | [pns initWithFormat : @"Hello%s %d %d", "Hello", 1, 2]; // expected-warning {{using %s directive in NSString which is being passed as a formatting argument to the formatting method}} |
| 36 | [pns MyRandomMethod : @"Hello%s %d %d" locale:0 arguments: argList]; // expected-warning {{using %s directive in NSString which is being passed as a formatting argument to the formatting method}} |
| 37 | return [NSString stringWithFormat : @"Hello%s", " There"]; // expected-warning {{using %s directive in NSString which is being passed as a formatting argument to the formatting method}} |
| 38 | } |
| 39 | |
| 40 | |
| 41 | typedef const struct __CFString * CFStringRef; |
| 42 | typedef struct __CFString * CFMutableStringRef; |
| 43 | typedef const struct __CFAllocator * CFAllocatorRef; |
| 44 | |
| 45 | |
| 46 | typedef const struct __CFDictionary * CFDictionaryRef; |
| 47 | |
| 48 | |
| 49 | extern |
| 50 | CFStringRef CFStringCreateWithFormat(CFAllocatorRef alloc, CFDictionaryRef formatOptions, CFStringRef format, ...) __attribute__((format(CFString, 3, 4))); |
| 51 | |
| 52 | extern |
| 53 | CFStringRef CFStringCreateWithFormatAndArguments(CFAllocatorRef alloc, CFDictionaryRef formatOptions, CFStringRef format, va_list arguments) __attribute__((format(CFString, 3, 0))); // expected-note {{'CFStringCreateWithFormatAndArguments' declared here}} |
| 54 | |
| 55 | extern |
| 56 | void CFStringAppendFormat(CFMutableStringRef theString, CFDictionaryRef formatOptions, CFStringRef format, ...) __attribute__((format(CFString, 3, 4))); |
| 57 | |
| 58 | extern |
| 59 | void CFStringAppendFormatAndArguments(CFMutableStringRef theString, CFDictionaryRef formatOptions, CFStringRef format, va_list arguments) __attribute__((format(CFString, 3, 0))); // expected-note {{'CFStringAppendFormatAndArguments' declared here}} |
| 60 | |
| 61 | void Test1(va_list argList) { |
| 62 | CFAllocatorRef alloc; |
| 63 | CFStringCreateWithFormatAndArguments (alloc, 0, (CFStringRef)@"%s\n", argList); // expected-warning {{using %s directive in CFString which is being passed as a formatting argument to the formatting CFfunction}} |
| 64 | CFStringAppendFormatAndArguments ((CFMutableStringRef)@"AAAA", 0, (CFStringRef)"Hello %s there %d\n", argList); // expected-warning {{using %s directive in CFString which is being passed as a formatting argument to the formatting CFfunction}} |
| 65 | CFStringCreateWithFormatAndArguments (alloc, 0, (CFStringRef)@"%c\n", argList); |
| 66 | CFStringAppendFormatAndArguments ((CFMutableStringRef)@"AAAA", 0, (CFStringRef)"%d\n", argList); |
| 67 | } |
| 68 | |
| 69 | extern void MyNSLog(NSString *format, ...) __attribute__((format(__NSString__, 1, 2))); // expected-note {{'MyNSLog' declared here}} |
| 70 | extern void MyCFStringCreateWithFormat(CFStringRef format, ...) __attribute__((format(__CFString__, 1, 2))); // expected-note {{'MyCFStringCreateWithFormat' declared here}} |
| 71 | extern void XMyNSLog(int, NSString *format, ...) __attribute__((format(__NSString__, 2, 3))); // expected-note {{'XMyNSLog' declared here}} |
| 72 | |
| 73 | void Test2() { |
| 74 | MyNSLog(@"%s\n", "Hello"); // expected-warning {{using %s directive in CFString which is being passed as a formatting argument to the formatting CFfunction}} |
| 75 | |
| 76 | MyCFStringCreateWithFormat((CFStringRef)@"%s", "Hello"); // expected-warning {{using %s directive in CFString which is being passed as a formatting argument to the formatting CFfunction}} |
| 77 | XMyNSLog(4, @"%s\n", "Hello"); // expected-warning {{using %s directive in CFString which is being passed as a formatting argument to the formatting CFfunction}} |
| 78 | } |
| 79 | |