Don't scramble buffers if compression is enabled
For the other buffer settings (like patterns, or whether always
to refill or not), we don't do the slight header scramble if
they are enabled. Do they same for compression settings, otherwise
we can skew the compression results.
Signed-off-by: Jens Axboe <axboe@fb.com>
diff --git a/init.c b/init.c
index 73ec9eb..0a872c0 100644
--- a/init.c
+++ b/init.c
@@ -856,6 +856,11 @@
return 0;
}
+static int compression_enabled(struct thread_options *o)
+{
+ return o->compress_percentage || o->compress_chunk;
+}
+
static void init_flags(struct thread_data *td)
{
struct thread_options *o = &td->o;
@@ -868,8 +873,14 @@
td->flags |= TD_F_READ_IOLOG;
if (o->refill_buffers)
td->flags |= TD_F_REFILL_BUFFERS;
- if (o->scramble_buffers)
+
+ /*
+ * Don't scramble buffers if we set any of the compression
+ * settings
+ */
+ if (o->scramble_buffers && !compression_enabled(o))
td->flags |= TD_F_SCRAMBLE_BUFFERS;
+
if (o->verify != VERIFY_NONE)
td->flags |= TD_F_VER_NONE;
}