| Harald Welte | c271df7 | 2005-02-12 21:02:26 +0000 | [diff] [blame] | 1 | A quick list of rules for committing stuff into netfilter svn: |
| Harald Welte | 710e7eb | 2003-04-13 11:29:28 +0000 | [diff] [blame] | 2 | |
| Harald Welte | c271df7 | 2005-02-12 21:02:26 +0000 | [diff] [blame] | 3 | - Always include the Name of the Author/Contributor in the SVN comment |
| Harald Welte | 710e7eb | 2003-04-13 11:29:28 +0000 | [diff] [blame] | 4 | like 'fix for foo (Au Thor)' |
| 5 | |
| 6 | - make sure that you have set the executable bits on an 'extensions/.*-test' |
| Harald Welte | c271df7 | 2005-02-12 21:02:26 +0000 | [diff] [blame] | 7 | script before adding/committing it to SVN |
| Harald Welte | 710e7eb | 2003-04-13 11:29:28 +0000 | [diff] [blame] | 8 | |
| 9 | - If the commit fixes a bugzilla bug, please include '(Closes: #bugnr)' in |
| 10 | the commit message |
| 11 | |
| Harald Welte | c271df7 | 2005-02-12 21:02:26 +0000 | [diff] [blame] | 12 | - Make sure you don't commit to svn while a feature freeze is announced |
| Harald Welte | 710e7eb | 2003-04-13 11:29:28 +0000 | [diff] [blame] | 13 | |
| 14 | - For new extensions, there are two possible cases: |
| 15 | 1) header files are just in patch-o-matic patch, you need an |
| 16 | 'extensions/.*-test' script to have a conditional build |
| 17 | 2) header files are in patch-o-matic patch, and copied to |
| 18 | 'netfilter/include/linux/netfilter_xxx'. This way the extension |
| 19 | can be built _unconditionally_, and thus be included in |
| 20 | 'extensions/Makefile'. Make sure to keep the headers in sync! |
| 21 | |
| 22 | Usually '1)' is used, but in case something is expected to show up in the |
| 23 | kernel soon, we should already make userspace support unconditionally. |
| 24 | |