Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 1 | //===- StrongPhiElimination.cpp - Eliminate PHI nodes by inserting copies -===// |
| 2 | // |
| 3 | // The LLVM Compiler Infrastructure |
| 4 | // |
Chris Lattner | 4ee451d | 2007-12-29 20:36:04 +0000 | [diff] [blame] | 5 | // This file is distributed under the University of Illinois Open Source |
| 6 | // License. See LICENSE.TXT for details. |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 7 | // |
| 8 | //===----------------------------------------------------------------------===// |
| 9 | // |
| 10 | // This pass eliminates machine instruction PHI nodes by inserting copy |
| 11 | // instructions, using an intelligent copy-folding technique based on |
| 12 | // dominator information. This is technique is derived from: |
| 13 | // |
| 14 | // Budimlic, et al. Fast copy coalescing and live-range identification. |
| 15 | // In Proceedings of the ACM SIGPLAN 2002 Conference on Programming Language |
| 16 | // Design and Implementation (Berlin, Germany, June 17 - 19, 2002). |
| 17 | // PLDI '02. ACM, New York, NY, 25-32. |
| 18 | // DOI= http://doi.acm.org/10.1145/512529.512534 |
| 19 | // |
| 20 | //===----------------------------------------------------------------------===// |
| 21 | |
| 22 | #define DEBUG_TYPE "strongphielim" |
| 23 | #include "llvm/CodeGen/Passes.h" |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 24 | #include "llvm/CodeGen/LiveIntervalAnalysis.h" |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 25 | #include "llvm/CodeGen/MachineDominators.h" |
| 26 | #include "llvm/CodeGen/MachineFunctionPass.h" |
| 27 | #include "llvm/CodeGen/MachineInstr.h" |
Owen Anderson | 755ebab | 2008-03-17 06:08:26 +0000 | [diff] [blame] | 28 | #include "llvm/CodeGen/MachineLoopInfo.h" |
Owen Anderson | 0d893b4 | 2008-01-08 05:16:15 +0000 | [diff] [blame] | 29 | #include "llvm/CodeGen/MachineRegisterInfo.h" |
Owen Anderson | 3947e4d | 2008-05-30 18:38:26 +0000 | [diff] [blame] | 30 | #include "llvm/CodeGen/RegisterCoalescer.h" |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 31 | #include "llvm/Target/TargetInstrInfo.h" |
| 32 | #include "llvm/Target/TargetMachine.h" |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 33 | #include "llvm/ADT/DepthFirstIterator.h" |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 34 | #include "llvm/ADT/Statistic.h" |
| 35 | #include "llvm/Support/Compiler.h" |
Owen Anderson | e04cec0 | 2008-09-22 21:58:58 +0000 | [diff] [blame] | 36 | #include "llvm/Support/Debug.h" |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 37 | using namespace llvm; |
| 38 | |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 39 | namespace { |
| 40 | struct VISIBILITY_HIDDEN StrongPHIElimination : public MachineFunctionPass { |
| 41 | static char ID; // Pass identification, replacement for typeid |
Dan Gohman | ae73dc1 | 2008-09-04 17:05:41 +0000 | [diff] [blame] | 42 | StrongPHIElimination() : MachineFunctionPass(&ID) {} |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 43 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 44 | // Waiting stores, for each MBB, the set of copies that need to |
| 45 | // be inserted into that MBB |
Owen Anderson | afc6de0 | 2007-12-10 08:07:09 +0000 | [diff] [blame] | 46 | DenseMap<MachineBasicBlock*, |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 47 | std::multimap<unsigned, unsigned> > Waiting; |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 48 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 49 | // Stacks holds the renaming stack for each register |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 50 | std::map<unsigned, std::vector<unsigned> > Stacks; |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 51 | |
| 52 | // Registers in UsedByAnother are PHI nodes that are themselves |
| 53 | // used as operands to another another PHI node |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 54 | std::set<unsigned> UsedByAnother; |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 55 | |
Owen Anderson | a9efb26 | 2008-06-05 17:22:53 +0000 | [diff] [blame] | 56 | // RenameSets are the is a map from a PHI-defined register |
Owen Anderson | c12417e | 2008-07-24 17:12:16 +0000 | [diff] [blame] | 57 | // to the input registers to be coalesced along with the |
| 58 | // predecessor block for those input registers. |
| 59 | std::map<unsigned, std::map<unsigned, MachineBasicBlock*> > RenameSets; |
Owen Anderson | dfd07ea | 2008-03-12 04:22:57 +0000 | [diff] [blame] | 60 | |
| 61 | // PhiValueNumber holds the ID numbers of the VNs for each phi that we're |
| 62 | // eliminating, indexed by the register defined by that phi. |
| 63 | std::map<unsigned, unsigned> PhiValueNumber; |
Owen Anderson | afc6de0 | 2007-12-10 08:07:09 +0000 | [diff] [blame] | 64 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 65 | // Store the DFS-in number of each block |
| 66 | DenseMap<MachineBasicBlock*, unsigned> preorder; |
| 67 | |
| 68 | // Store the DFS-out number of each block |
| 69 | DenseMap<MachineBasicBlock*, unsigned> maxpreorder; |
| 70 | |
Owen Anderson | a4ad2e7 | 2007-11-06 04:49:43 +0000 | [diff] [blame] | 71 | bool runOnMachineFunction(MachineFunction &Fn); |
| 72 | |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 73 | virtual void getAnalysisUsage(AnalysisUsage &AU) const { |
Dan Gohman | 845012e | 2009-07-31 23:37:33 +0000 | [diff] [blame^] | 74 | AU.setPreservesCFG(); |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 75 | AU.addRequired<MachineDominatorTree>(); |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 76 | AU.addRequired<LiveIntervals>(); |
| 77 | |
| 78 | // TODO: Actually make this true. |
| 79 | AU.addPreserved<LiveIntervals>(); |
Owen Anderson | 3947e4d | 2008-05-30 18:38:26 +0000 | [diff] [blame] | 80 | AU.addPreserved<RegisterCoalescer>(); |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 81 | MachineFunctionPass::getAnalysisUsage(AU); |
| 82 | } |
| 83 | |
| 84 | virtual void releaseMemory() { |
| 85 | preorder.clear(); |
| 86 | maxpreorder.clear(); |
Owen Anderson | a4ad2e7 | 2007-11-06 04:49:43 +0000 | [diff] [blame] | 87 | |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 88 | Waiting.clear(); |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 89 | Stacks.clear(); |
| 90 | UsedByAnother.clear(); |
| 91 | RenameSets.clear(); |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 92 | } |
| 93 | |
| 94 | private: |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 95 | |
| 96 | /// DomForestNode - Represents a node in the "dominator forest". This is |
| 97 | /// a forest in which the nodes represent registers and the edges |
| 98 | /// represent a dominance relation in the block defining those registers. |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 99 | struct DomForestNode { |
| 100 | private: |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 101 | // Store references to our children |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 102 | std::vector<DomForestNode*> children; |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 103 | // The register we represent |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 104 | unsigned reg; |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 105 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 106 | // Add another node as our child |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 107 | void addChild(DomForestNode* DFN) { children.push_back(DFN); } |
| 108 | |
| 109 | public: |
| 110 | typedef std::vector<DomForestNode*>::iterator iterator; |
| 111 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 112 | // Create a DomForestNode by providing the register it represents, and |
| 113 | // the node to be its parent. The virtual root node has register 0 |
| 114 | // and a null parent. |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 115 | DomForestNode(unsigned r, DomForestNode* parent) : reg(r) { |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 116 | if (parent) |
| 117 | parent->addChild(this); |
| 118 | } |
| 119 | |
Owen Anderson | a4ad2e7 | 2007-11-06 04:49:43 +0000 | [diff] [blame] | 120 | ~DomForestNode() { |
| 121 | for (iterator I = begin(), E = end(); I != E; ++I) |
| 122 | delete *I; |
| 123 | } |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 124 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 125 | /// getReg - Return the regiser that this node represents |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 126 | inline unsigned getReg() { return reg; } |
Owen Anderson | a4ad2e7 | 2007-11-06 04:49:43 +0000 | [diff] [blame] | 127 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 128 | // Provide iterator access to our children |
Owen Anderson | a4ad2e7 | 2007-11-06 04:49:43 +0000 | [diff] [blame] | 129 | inline DomForestNode::iterator begin() { return children.begin(); } |
| 130 | inline DomForestNode::iterator end() { return children.end(); } |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 131 | }; |
| 132 | |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 133 | void computeDFS(MachineFunction& MF); |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 134 | void processBlock(MachineBasicBlock* MBB); |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 135 | |
Owen Anderson | c12417e | 2008-07-24 17:12:16 +0000 | [diff] [blame] | 136 | std::vector<DomForestNode*> computeDomForest( |
| 137 | std::map<unsigned, MachineBasicBlock*>& instrs, |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 138 | MachineRegisterInfo& MRI); |
Owen Anderson | d525f66 | 2007-12-11 20:12:11 +0000 | [diff] [blame] | 139 | void processPHIUnion(MachineInstr* Inst, |
Owen Anderson | c12417e | 2008-07-24 17:12:16 +0000 | [diff] [blame] | 140 | std::map<unsigned, MachineBasicBlock*>& PHIUnion, |
Owen Anderson | 62d67dd | 2007-12-13 05:53:03 +0000 | [diff] [blame] | 141 | std::vector<StrongPHIElimination::DomForestNode*>& DF, |
| 142 | std::vector<std::pair<unsigned, unsigned> >& locals); |
Owen Anderson | f1519e8 | 2007-12-24 22:12:23 +0000 | [diff] [blame] | 143 | void ScheduleCopies(MachineBasicBlock* MBB, std::set<unsigned>& pushed); |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 144 | void InsertCopies(MachineDomTreeNode* MBB, |
Owen Anderson | e46611e | 2008-03-24 04:11:27 +0000 | [diff] [blame] | 145 | SmallPtrSet<MachineBasicBlock*, 16>& v); |
Owen Anderson | fae86ed | 2008-09-23 04:37:10 +0000 | [diff] [blame] | 146 | bool mergeLiveIntervals(unsigned primary, unsigned secondary); |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 147 | }; |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 148 | } |
| 149 | |
Dan Gohman | 844731a | 2008-05-13 00:00:25 +0000 | [diff] [blame] | 150 | char StrongPHIElimination::ID = 0; |
| 151 | static RegisterPass<StrongPHIElimination> |
| 152 | X("strong-phi-node-elimination", |
| 153 | "Eliminate PHI nodes for register allocation, intelligently"); |
| 154 | |
Dan Gohman | 6ddba2b | 2008-05-13 02:05:11 +0000 | [diff] [blame] | 155 | const PassInfo *const llvm::StrongPHIEliminationID = &X; |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 156 | |
| 157 | /// computeDFS - Computes the DFS-in and DFS-out numbers of the dominator tree |
| 158 | /// of the given MachineFunction. These numbers are then used in other parts |
| 159 | /// of the PHI elimination process. |
| 160 | void StrongPHIElimination::computeDFS(MachineFunction& MF) { |
| 161 | SmallPtrSet<MachineDomTreeNode*, 8> frontier; |
| 162 | SmallPtrSet<MachineDomTreeNode*, 8> visited; |
| 163 | |
| 164 | unsigned time = 0; |
| 165 | |
| 166 | MachineDominatorTree& DT = getAnalysis<MachineDominatorTree>(); |
| 167 | |
| 168 | MachineDomTreeNode* node = DT.getRootNode(); |
| 169 | |
| 170 | std::vector<MachineDomTreeNode*> worklist; |
| 171 | worklist.push_back(node); |
| 172 | |
| 173 | while (!worklist.empty()) { |
| 174 | MachineDomTreeNode* currNode = worklist.back(); |
| 175 | |
| 176 | if (!frontier.count(currNode)) { |
| 177 | frontier.insert(currNode); |
| 178 | ++time; |
| 179 | preorder.insert(std::make_pair(currNode->getBlock(), time)); |
| 180 | } |
| 181 | |
| 182 | bool inserted = false; |
Owen Anderson | bc91bd3 | 2008-03-31 01:39:20 +0000 | [diff] [blame] | 183 | for (MachineDomTreeNode::iterator I = currNode->begin(), E = currNode->end(); |
Owen Anderson | 0bda0e8 | 2007-10-31 03:37:57 +0000 | [diff] [blame] | 184 | I != E; ++I) |
| 185 | if (!frontier.count(*I) && !visited.count(*I)) { |
| 186 | worklist.push_back(*I); |
| 187 | inserted = true; |
| 188 | break; |
| 189 | } |
| 190 | |
| 191 | if (!inserted) { |
| 192 | frontier.erase(currNode); |
| 193 | visited.insert(currNode); |
| 194 | maxpreorder.insert(std::make_pair(currNode->getBlock(), time)); |
| 195 | |
| 196 | worklist.pop_back(); |
| 197 | } |
| 198 | } |
Duncan Sands | 1bd3271 | 2007-10-31 08:49:24 +0000 | [diff] [blame] | 199 | } |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 200 | |
Dan Gohman | 844731a | 2008-05-13 00:00:25 +0000 | [diff] [blame] | 201 | namespace { |
| 202 | |
Owen Anderson | 8b96b9f | 2007-11-06 05:26:02 +0000 | [diff] [blame] | 203 | /// PreorderSorter - a helper class that is used to sort registers |
| 204 | /// according to the preorder number of their defining blocks |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 205 | class PreorderSorter { |
| 206 | private: |
| 207 | DenseMap<MachineBasicBlock*, unsigned>& preorder; |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 208 | MachineRegisterInfo& MRI; |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 209 | |
| 210 | public: |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 211 | PreorderSorter(DenseMap<MachineBasicBlock*, unsigned>& p, |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 212 | MachineRegisterInfo& M) : preorder(p), MRI(M) { } |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 213 | |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 214 | bool operator()(unsigned A, unsigned B) { |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 215 | if (A == B) |
| 216 | return false; |
| 217 | |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 218 | MachineBasicBlock* ABlock = MRI.getVRegDef(A)->getParent(); |
| 219 | MachineBasicBlock* BBlock = MRI.getVRegDef(B)->getParent(); |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 220 | |
| 221 | if (preorder[ABlock] < preorder[BBlock]) |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 222 | return true; |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 223 | else if (preorder[ABlock] > preorder[BBlock]) |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 224 | return false; |
| 225 | |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 226 | return false; |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 227 | } |
| 228 | }; |
| 229 | |
Dan Gohman | 844731a | 2008-05-13 00:00:25 +0000 | [diff] [blame] | 230 | } |
| 231 | |
Owen Anderson | 8b96b9f | 2007-11-06 05:26:02 +0000 | [diff] [blame] | 232 | /// computeDomForest - compute the subforest of the DomTree corresponding |
| 233 | /// to the defining blocks of the registers in question |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 234 | std::vector<StrongPHIElimination::DomForestNode*> |
Owen Anderson | c12417e | 2008-07-24 17:12:16 +0000 | [diff] [blame] | 235 | StrongPHIElimination::computeDomForest( |
| 236 | std::map<unsigned, MachineBasicBlock*>& regs, |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 237 | MachineRegisterInfo& MRI) { |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 238 | // Begin by creating a virtual root node, since the actual results |
| 239 | // may well be a forest. Assume this node has maximum DFS-out number. |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 240 | DomForestNode* VirtualRoot = new DomForestNode(0, 0); |
| 241 | maxpreorder.insert(std::make_pair((MachineBasicBlock*)0, ~0UL)); |
| 242 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 243 | // Populate a worklist with the registers |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 244 | std::vector<unsigned> worklist; |
| 245 | worklist.reserve(regs.size()); |
Owen Anderson | c12417e | 2008-07-24 17:12:16 +0000 | [diff] [blame] | 246 | for (std::map<unsigned, MachineBasicBlock*>::iterator I = regs.begin(), |
| 247 | E = regs.end(); I != E; ++I) |
Owen Anderson | 0031671 | 2008-03-12 03:13:29 +0000 | [diff] [blame] | 248 | worklist.push_back(I->first); |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 249 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 250 | // Sort the registers by the DFS-in number of their defining block |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 251 | PreorderSorter PS(preorder, MRI); |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 252 | std::sort(worklist.begin(), worklist.end(), PS); |
| 253 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 254 | // Create a "current parent" stack, and put the virtual root on top of it |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 255 | DomForestNode* CurrentParent = VirtualRoot; |
| 256 | std::vector<DomForestNode*> stack; |
| 257 | stack.push_back(VirtualRoot); |
| 258 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 259 | // Iterate over all the registers in the previously computed order |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 260 | for (std::vector<unsigned>::iterator I = worklist.begin(), E = worklist.end(); |
| 261 | I != E; ++I) { |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 262 | unsigned pre = preorder[MRI.getVRegDef(*I)->getParent()]; |
Owen Anderson | cb7d949 | 2008-01-09 06:19:05 +0000 | [diff] [blame] | 263 | MachineBasicBlock* parentBlock = CurrentParent->getReg() ? |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 264 | MRI.getVRegDef(CurrentParent->getReg())->getParent() : |
Owen Anderson | cb7d949 | 2008-01-09 06:19:05 +0000 | [diff] [blame] | 265 | 0; |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 266 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 267 | // If the DFS-in number of the register is greater than the DFS-out number |
| 268 | // of the current parent, repeatedly pop the parent stack until it isn't. |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 269 | while (pre > maxpreorder[parentBlock]) { |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 270 | stack.pop_back(); |
| 271 | CurrentParent = stack.back(); |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 272 | |
Owen Anderson | 864e3a3 | 2008-01-09 10:41:39 +0000 | [diff] [blame] | 273 | parentBlock = CurrentParent->getReg() ? |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 274 | MRI.getVRegDef(CurrentParent->getReg())->getParent() : |
Owen Anderson | 864e3a3 | 2008-01-09 10:41:39 +0000 | [diff] [blame] | 275 | 0; |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 276 | } |
| 277 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 278 | // Now that we've found the appropriate parent, create a DomForestNode for |
| 279 | // this register and attach it to the forest |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 280 | DomForestNode* child = new DomForestNode(*I, CurrentParent); |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 281 | |
| 282 | // Push this new node on the "current parent" stack |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 283 | stack.push_back(child); |
| 284 | CurrentParent = child; |
| 285 | } |
| 286 | |
Owen Anderson | ec1213f | 2008-01-09 22:40:54 +0000 | [diff] [blame] | 287 | // Return a vector containing the children of the virtual root node |
Owen Anderson | 83430bc | 2007-11-04 22:33:26 +0000 | [diff] [blame] | 288 | std::vector<DomForestNode*> ret; |
| 289 | ret.insert(ret.end(), VirtualRoot->begin(), VirtualRoot->end()); |
| 290 | return ret; |
| 291 | } |
Owen Anderson | a4ad2e7 | 2007-11-06 04:49:43 +0000 | [diff] [blame] | 292 | |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 293 | /// isLiveIn - helper method that determines, from a regno, if a register |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 294 | /// is live into a block |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 295 | static bool isLiveIn(unsigned r, MachineBasicBlock* MBB, |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 296 | LiveIntervals& LI) { |
| 297 | LiveInterval& I = LI.getOrCreateInterval(r); |
| 298 | unsigned idx = LI.getMBBStartIdx(MBB); |
Owen Anderson | d55fccd | 2008-10-12 20:39:30 +0000 | [diff] [blame] | 299 | return I.liveAt(idx); |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 300 | } |
| 301 | |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 302 | /// isLiveOut - help method that determines, from a regno, if a register is |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 303 | /// live out of a block. |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 304 | static bool isLiveOut(unsigned r, MachineBasicBlock* MBB, |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 305 | LiveIntervals& LI) { |
| 306 | for (MachineBasicBlock::succ_iterator PI = MBB->succ_begin(), |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 307 | E = MBB->succ_end(); PI != E; ++PI) |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 308 | if (isLiveIn(r, *PI, LI)) |
| 309 | return true; |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 310 | |
| 311 | return false; |
| 312 | } |
| 313 | |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 314 | /// interferes - checks for local interferences by scanning a block. The only |
| 315 | /// trick parameter is 'mode' which tells it the relationship of the two |
| 316 | /// registers. 0 - defined in the same block, 1 - first properly dominates |
| 317 | /// second, 2 - second properly dominates first |
Owen Anderson | b199cbe | 2008-01-10 00:33:11 +0000 | [diff] [blame] | 318 | static bool interferes(unsigned a, unsigned b, MachineBasicBlock* scan, |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 319 | LiveIntervals& LV, unsigned mode) { |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 320 | MachineInstr* def = 0; |
| 321 | MachineInstr* kill = 0; |
| 322 | |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 323 | // The code is still in SSA form at this point, so there is only one |
| 324 | // definition per VReg. Thus we can safely use MRI->getVRegDef(). |
| 325 | const MachineRegisterInfo* MRI = &scan->getParent()->getRegInfo(); |
Owen Anderson | b199cbe | 2008-01-10 00:33:11 +0000 | [diff] [blame] | 326 | |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 327 | bool interference = false; |
| 328 | |
| 329 | // Wallk the block, checking for interferences |
| 330 | for (MachineBasicBlock::iterator MBI = scan->begin(), MBE = scan->end(); |
| 331 | MBI != MBE; ++MBI) { |
| 332 | MachineInstr* curr = MBI; |
| 333 | |
| 334 | // Same defining block... |
| 335 | if (mode == 0) { |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 336 | if (curr == MRI->getVRegDef(a)) { |
| 337 | // If we find our first definition, save it |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 338 | if (!def) { |
| 339 | def = curr; |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 340 | // If there's already an unkilled definition, then |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 341 | // this is an interference |
| 342 | } else if (!kill) { |
| 343 | interference = true; |
| 344 | break; |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 345 | // If there's a definition followed by a KillInst, then |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 346 | // they can't interfere |
| 347 | } else { |
| 348 | interference = false; |
| 349 | break; |
| 350 | } |
| 351 | // Symmetric with the above |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 352 | } else if (curr == MRI->getVRegDef(b)) { |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 353 | if (!def) { |
| 354 | def = curr; |
| 355 | } else if (!kill) { |
| 356 | interference = true; |
| 357 | break; |
| 358 | } else { |
| 359 | interference = false; |
| 360 | break; |
| 361 | } |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 362 | // Store KillInsts if they match up with the definition |
Evan Cheng | 6130f66 | 2008-03-05 00:59:57 +0000 | [diff] [blame] | 363 | } else if (curr->killsRegister(a)) { |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 364 | if (def == MRI->getVRegDef(a)) { |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 365 | kill = curr; |
Evan Cheng | 6130f66 | 2008-03-05 00:59:57 +0000 | [diff] [blame] | 366 | } else if (curr->killsRegister(b)) { |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 367 | if (def == MRI->getVRegDef(b)) { |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 368 | kill = curr; |
| 369 | } |
| 370 | } |
| 371 | } |
| 372 | // First properly dominates second... |
| 373 | } else if (mode == 1) { |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 374 | if (curr == MRI->getVRegDef(b)) { |
| 375 | // Definition of second without kill of first is an interference |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 376 | if (!kill) { |
| 377 | interference = true; |
| 378 | break; |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 379 | // Definition after a kill is a non-interference |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 380 | } else { |
| 381 | interference = false; |
| 382 | break; |
| 383 | } |
| 384 | // Save KillInsts of First |
Evan Cheng | 6130f66 | 2008-03-05 00:59:57 +0000 | [diff] [blame] | 385 | } else if (curr->killsRegister(a)) { |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 386 | kill = curr; |
| 387 | } |
| 388 | // Symmetric with the above |
| 389 | } else if (mode == 2) { |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 390 | if (curr == MRI->getVRegDef(a)) { |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 391 | if (!kill) { |
| 392 | interference = true; |
| 393 | break; |
| 394 | } else { |
| 395 | interference = false; |
| 396 | break; |
| 397 | } |
Evan Cheng | 6130f66 | 2008-03-05 00:59:57 +0000 | [diff] [blame] | 398 | } else if (curr->killsRegister(b)) { |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 399 | kill = curr; |
| 400 | } |
| 401 | } |
| 402 | } |
| 403 | |
| 404 | return interference; |
| 405 | } |
| 406 | |
Owen Anderson | dc4d655 | 2008-01-10 00:47:01 +0000 | [diff] [blame] | 407 | /// processBlock - Determine how to break up PHIs in the current block. Each |
| 408 | /// PHI is broken up by some combination of renaming its operands and inserting |
| 409 | /// copies. This method is responsible for determining which operands receive |
| 410 | /// which treatment. |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 411 | void StrongPHIElimination::processBlock(MachineBasicBlock* MBB) { |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 412 | LiveIntervals& LI = getAnalysis<LiveIntervals>(); |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 413 | MachineRegisterInfo& MRI = MBB->getParent()->getRegInfo(); |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 414 | |
| 415 | // Holds names that have been added to a set in any PHI within this block |
| 416 | // before the current one. |
| 417 | std::set<unsigned> ProcessedNames; |
| 418 | |
Owen Anderson | dc4d655 | 2008-01-10 00:47:01 +0000 | [diff] [blame] | 419 | // Iterate over all the PHI nodes in this block |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 420 | MachineBasicBlock::iterator P = MBB->begin(); |
Owen Anderson | 78216bc | 2008-04-01 18:05:08 +0000 | [diff] [blame] | 421 | while (P != MBB->end() && P->getOpcode() == TargetInstrInfo::PHI) { |
Owen Anderson | afc6de0 | 2007-12-10 08:07:09 +0000 | [diff] [blame] | 422 | unsigned DestReg = P->getOperand(0).getReg(); |
Owen Anderson | 9860b71 | 2008-08-06 20:29:20 +0000 | [diff] [blame] | 423 | |
Owen Anderson | d382f8a | 2008-03-26 03:03:23 +0000 | [diff] [blame] | 424 | // Don't both doing PHI elimination for dead PHI's. |
| 425 | if (P->registerDefIsDead(DestReg)) { |
| 426 | ++P; |
| 427 | continue; |
| 428 | } |
| 429 | |
Owen Anderson | dfd07ea | 2008-03-12 04:22:57 +0000 | [diff] [blame] | 430 | LiveInterval& PI = LI.getOrCreateInterval(DestReg); |
Owen Anderson | c7c0036 | 2008-03-29 01:58:47 +0000 | [diff] [blame] | 431 | unsigned pIdx = LI.getDefIndex(LI.getInstructionIndex(P)); |
Owen Anderson | dfd07ea | 2008-03-12 04:22:57 +0000 | [diff] [blame] | 432 | VNInfo* PVN = PI.getLiveRangeContaining(pIdx)->valno; |
| 433 | PhiValueNumber.insert(std::make_pair(DestReg, PVN->id)); |
| 434 | |
Owen Anderson | dc4d655 | 2008-01-10 00:47:01 +0000 | [diff] [blame] | 435 | // PHIUnion is the set of incoming registers to the PHI node that |
| 436 | // are going to be renames rather than having copies inserted. This set |
| 437 | // is refinded over the course of this function. UnionedBlocks is the set |
| 438 | // of corresponding MBBs. |
Owen Anderson | c12417e | 2008-07-24 17:12:16 +0000 | [diff] [blame] | 439 | std::map<unsigned, MachineBasicBlock*> PHIUnion; |
Owen Anderson | e46611e | 2008-03-24 04:11:27 +0000 | [diff] [blame] | 440 | SmallPtrSet<MachineBasicBlock*, 8> UnionedBlocks; |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 441 | |
Owen Anderson | dc4d655 | 2008-01-10 00:47:01 +0000 | [diff] [blame] | 442 | // Iterate over the operands of the PHI node |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 443 | for (int i = P->getNumOperands() - 1; i >= 2; i-=2) { |
| 444 | unsigned SrcReg = P->getOperand(i-1).getReg(); |
Owen Anderson | 9860b71 | 2008-08-06 20:29:20 +0000 | [diff] [blame] | 445 | |
| 446 | // Don't need to try to coalesce a register with itself. |
| 447 | if (SrcReg == DestReg) { |
| 448 | ProcessedNames.insert(SrcReg); |
| 449 | continue; |
| 450 | } |
Owen Anderson | 082d351 | 2008-09-26 18:50:46 +0000 | [diff] [blame] | 451 | |
| 452 | // We don't need to insert copies for implicit_defs. |
| 453 | MachineInstr* DefMI = MRI.getVRegDef(SrcReg); |
| 454 | if (DefMI->getOpcode() == TargetInstrInfo::IMPLICIT_DEF) |
| 455 | ProcessedNames.insert(SrcReg); |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 456 | |
Owen Anderson | dc4d655 | 2008-01-10 00:47:01 +0000 | [diff] [blame] | 457 | // Check for trivial interferences via liveness information, allowing us |
| 458 | // to avoid extra work later. Any registers that interfere cannot both |
| 459 | // be in the renaming set, so choose one and add copies for it instead. |
| 460 | // The conditions are: |
| 461 | // 1) if the operand is live into the PHI node's block OR |
| 462 | // 2) if the PHI node is live out of the operand's defining block OR |
| 463 | // 3) if the operand is itself a PHI node and the original PHI is |
| 464 | // live into the operand's defining block OR |
| 465 | // 4) if the operand is already being renamed for another PHI node |
| 466 | // in this block OR |
| 467 | // 5) if any two operands are defined in the same block, insert copies |
| 468 | // for one of them |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 469 | if (isLiveIn(SrcReg, P->getParent(), LI) || |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 470 | isLiveOut(P->getOperand(0).getReg(), |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 471 | MRI.getVRegDef(SrcReg)->getParent(), LI) || |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 472 | ( MRI.getVRegDef(SrcReg)->getOpcode() == TargetInstrInfo::PHI && |
| 473 | isLiveIn(P->getOperand(0).getReg(), |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 474 | MRI.getVRegDef(SrcReg)->getParent(), LI) ) || |
Owen Anderson | afc6de0 | 2007-12-10 08:07:09 +0000 | [diff] [blame] | 475 | ProcessedNames.count(SrcReg) || |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 476 | UnionedBlocks.count(MRI.getVRegDef(SrcReg)->getParent())) { |
Owen Anderson | afc6de0 | 2007-12-10 08:07:09 +0000 | [diff] [blame] | 477 | |
Owen Anderson | dc4d655 | 2008-01-10 00:47:01 +0000 | [diff] [blame] | 478 | // Add a copy for the selected register |
Chris Lattner | 8aa797a | 2007-12-30 23:10:15 +0000 | [diff] [blame] | 479 | MachineBasicBlock* From = P->getOperand(i).getMBB(); |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 480 | Waiting[From].insert(std::make_pair(SrcReg, DestReg)); |
| 481 | UsedByAnother.insert(SrcReg); |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 482 | } else { |
Owen Anderson | dc4d655 | 2008-01-10 00:47:01 +0000 | [diff] [blame] | 483 | // Otherwise, add it to the renaming set |
Owen Anderson | c12417e | 2008-07-24 17:12:16 +0000 | [diff] [blame] | 484 | PHIUnion.insert(std::make_pair(SrcReg,P->getOperand(i).getMBB())); |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 485 | UnionedBlocks.insert(MRI.getVRegDef(SrcReg)->getParent()); |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 486 | } |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 487 | } |
| 488 | |
Owen Anderson | dc4d655 | 2008-01-10 00:47:01 +0000 | [diff] [blame] | 489 | // Compute the dominator forest for the renaming set. This is a forest |
| 490 | // where the nodes are the registers and the edges represent dominance |
| 491 | // relations between the defining blocks of the registers |
Owen Anderson | 42f9e96 | 2007-11-13 20:13:24 +0000 | [diff] [blame] | 492 | std::vector<StrongPHIElimination::DomForestNode*> DF = |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 493 | computeDomForest(PHIUnion, MRI); |
Owen Anderson | 42f9e96 | 2007-11-13 20:13:24 +0000 | [diff] [blame] | 494 | |
Owen Anderson | dc4d655 | 2008-01-10 00:47:01 +0000 | [diff] [blame] | 495 | // Walk DomForest to resolve interferences at an inter-block level. This |
| 496 | // will remove registers from the renaming set (and insert copies for them) |
| 497 | // if interferences are found. |
Owen Anderson | 62d67dd | 2007-12-13 05:53:03 +0000 | [diff] [blame] | 498 | std::vector<std::pair<unsigned, unsigned> > localInterferences; |
| 499 | processPHIUnion(P, PHIUnion, DF, localInterferences); |
| 500 | |
Owen Anderson | 52b1733 | 2008-04-02 03:00:13 +0000 | [diff] [blame] | 501 | // If one of the inputs is defined in the same block as the current PHI |
| 502 | // then we need to check for a local interference between that input and |
| 503 | // the PHI. |
Owen Anderson | c12417e | 2008-07-24 17:12:16 +0000 | [diff] [blame] | 504 | for (std::map<unsigned, MachineBasicBlock*>::iterator I = PHIUnion.begin(), |
Owen Anderson | 52b1733 | 2008-04-02 03:00:13 +0000 | [diff] [blame] | 505 | E = PHIUnion.end(); I != E; ++I) |
| 506 | if (MRI.getVRegDef(I->first)->getParent() == P->getParent()) |
| 507 | localInterferences.push_back(std::make_pair(I->first, |
| 508 | P->getOperand(0).getReg())); |
| 509 | |
Owen Anderson | dc4d655 | 2008-01-10 00:47:01 +0000 | [diff] [blame] | 510 | // The dominator forest walk may have returned some register pairs whose |
Owen Anderson | 52b1733 | 2008-04-02 03:00:13 +0000 | [diff] [blame] | 511 | // interference cannot be determined from dominator analysis. We now |
Owen Anderson | dc4d655 | 2008-01-10 00:47:01 +0000 | [diff] [blame] | 512 | // examine these pairs for local interferences. |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 513 | for (std::vector<std::pair<unsigned, unsigned> >::iterator I = |
| 514 | localInterferences.begin(), E = localInterferences.end(); I != E; ++I) { |
| 515 | std::pair<unsigned, unsigned> p = *I; |
| 516 | |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 517 | MachineDominatorTree& MDT = getAnalysis<MachineDominatorTree>(); |
| 518 | |
| 519 | // Determine the block we need to scan and the relationship between |
| 520 | // the two registers |
| 521 | MachineBasicBlock* scan = 0; |
| 522 | unsigned mode = 0; |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 523 | if (MRI.getVRegDef(p.first)->getParent() == |
| 524 | MRI.getVRegDef(p.second)->getParent()) { |
| 525 | scan = MRI.getVRegDef(p.first)->getParent(); |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 526 | mode = 0; // Same block |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 527 | } else if (MDT.dominates(MRI.getVRegDef(p.first)->getParent(), |
| 528 | MRI.getVRegDef(p.second)->getParent())) { |
| 529 | scan = MRI.getVRegDef(p.second)->getParent(); |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 530 | mode = 1; // First dominates second |
| 531 | } else { |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 532 | scan = MRI.getVRegDef(p.first)->getParent(); |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 533 | mode = 2; // Second dominates first |
| 534 | } |
| 535 | |
| 536 | // If there's an interference, we need to insert copies |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 537 | if (interferes(p.first, p.second, scan, LI, mode)) { |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 538 | // Insert copies for First |
| 539 | for (int i = P->getNumOperands() - 1; i >= 2; i-=2) { |
| 540 | if (P->getOperand(i-1).getReg() == p.first) { |
| 541 | unsigned SrcReg = p.first; |
| 542 | MachineBasicBlock* From = P->getOperand(i).getMBB(); |
| 543 | |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 544 | Waiting[From].insert(std::make_pair(SrcReg, |
| 545 | P->getOperand(0).getReg())); |
| 546 | UsedByAnother.insert(SrcReg); |
| 547 | |
Owen Anderson | 87a702b | 2007-12-16 05:44:27 +0000 | [diff] [blame] | 548 | PHIUnion.erase(SrcReg); |
| 549 | } |
| 550 | } |
| 551 | } |
| 552 | } |
Owen Anderson | 42f9e96 | 2007-11-13 20:13:24 +0000 | [diff] [blame] | 553 | |
Owen Anderson | 52b1733 | 2008-04-02 03:00:13 +0000 | [diff] [blame] | 554 | // Add the renaming set for this PHI node to our overall renaming information |
Owen Anderson | e04cec0 | 2008-09-22 21:58:58 +0000 | [diff] [blame] | 555 | for (std::map<unsigned, MachineBasicBlock*>::iterator QI = PHIUnion.begin(), |
| 556 | QE = PHIUnion.end(); QI != QE; ++QI) { |
| 557 | DOUT << "Adding Renaming: " << QI->first << " -> " |
| 558 | << P->getOperand(0).getReg() << "\n"; |
| 559 | } |
| 560 | |
Owen Anderson | 0c5714b | 2008-01-08 21:54:52 +0000 | [diff] [blame] | 561 | RenameSets.insert(std::make_pair(P->getOperand(0).getReg(), PHIUnion)); |
Owen Anderson | cae8d8d | 2007-12-22 04:59:10 +0000 | [diff] [blame] | 562 | |
Owen Anderson | dc4d655 | 2008-01-10 00:47:01 +0000 | [diff] [blame] | 563 | // Remember which registers are already renamed, so that we don't try to |
| 564 | // rename them for another PHI node in this block |
Owen Anderson | c12417e | 2008-07-24 17:12:16 +0000 | [diff] [blame] | 565 | for (std::map<unsigned, MachineBasicBlock*>::iterator I = PHIUnion.begin(), |
Owen Anderson | 0031671 | 2008-03-12 03:13:29 +0000 | [diff] [blame] | 566 | E = PHIUnion.end(); I != E; ++I) |
| 567 | ProcessedNames.insert(I->first); |
Owen Anderson | dc4d655 | 2008-01-10 00:47:01 +0000 | [diff] [blame] | 568 | |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 569 | ++P; |
| 570 | } |
Owen Anderson | ee49b53 | 2007-11-06 05:22:43 +0000 | [diff] [blame] | 571 | } |
| 572 | |
Gabor Greif | 2cf36e0 | 2008-03-06 10:51:21 +0000 | [diff] [blame] | 573 | /// processPHIUnion - Take a set of candidate registers to be coalesced when |
Owen Anderson | 965b467 | 2007-12-16 04:07:23 +0000 | [diff] [blame] | 574 | /// decomposing the PHI instruction. Use the DominanceForest to remove the ones |
| 575 | /// that are known to interfere, and flag others that need to be checked for |
| 576 | /// local interferences. |
Owen Anderson | d525f66 | 2007-12-11 20:12:11 +0000 | [diff] [blame] | 577 | void StrongPHIElimination::processPHIUnion(MachineInstr* Inst, |
Owen Anderson | c12417e | 2008-07-24 17:12:16 +0000 | [diff] [blame] | 578 | std::map<unsigned, MachineBasicBlock*>& PHIUnion, |
Owen Anderson | 62d67dd | 2007-12-13 05:53:03 +0000 | [diff] [blame] | 579 | std::vector<StrongPHIElimination::DomForestNode*>& DF, |
| 580 | std::vector<std::pair<unsigned, unsigned> >& locals) { |
Owen Anderson | d525f66 | 2007-12-11 20:12:11 +0000 | [diff] [blame] | 581 | |
| 582 | std::vector<DomForestNode*> worklist(DF.begin(), DF.end()); |
| 583 | SmallPtrSet<DomForestNode*, 4> visited; |
| 584 | |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 585 | // Code is still in SSA form, so we can use MRI::getVRegDef() |
| 586 | MachineRegisterInfo& MRI = Inst->getParent()->getParent()->getRegInfo(); |
| 587 | |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 588 | LiveIntervals& LI = getAnalysis<LiveIntervals>(); |
Owen Anderson | d525f66 | 2007-12-11 20:12:11 +0000 | [diff] [blame] | 589 | unsigned DestReg = Inst->getOperand(0).getReg(); |
| 590 | |
Owen Anderson | 965b467 | 2007-12-16 04:07:23 +0000 | [diff] [blame] | 591 | // DF walk on the DomForest |
Owen Anderson | d525f66 | 2007-12-11 20:12:11 +0000 | [diff] [blame] | 592 | while (!worklist.empty()) { |
| 593 | DomForestNode* DFNode = worklist.back(); |
| 594 | |
Owen Anderson | d525f66 | 2007-12-11 20:12:11 +0000 | [diff] [blame] | 595 | visited.insert(DFNode); |
| 596 | |
| 597 | bool inserted = false; |
Owen Anderson | d525f66 | 2007-12-11 20:12:11 +0000 | [diff] [blame] | 598 | for (DomForestNode::iterator CI = DFNode->begin(), CE = DFNode->end(); |
| 599 | CI != CE; ++CI) { |
| 600 | DomForestNode* child = *CI; |
Owen Anderson | 3b48952 | 2008-01-21 22:01:01 +0000 | [diff] [blame] | 601 | |
| 602 | // If the current node is live-out of the defining block of one of its |
Owen Anderson | a6b1926 | 2008-01-21 22:03:00 +0000 | [diff] [blame] | 603 | // children, insert a copy for it. NOTE: The paper actually calls for |
| 604 | // a more elaborate heuristic for determining whether to insert copies |
| 605 | // for the child or the parent. In the interest of simplicity, we're |
| 606 | // just always choosing the parent. |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 607 | if (isLiveOut(DFNode->getReg(), |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 608 | MRI.getVRegDef(child->getReg())->getParent(), LI)) { |
Owen Anderson | d525f66 | 2007-12-11 20:12:11 +0000 | [diff] [blame] | 609 | // Insert copies for parent |
| 610 | for (int i = Inst->getNumOperands() - 1; i >= 2; i-=2) { |
| 611 | if (Inst->getOperand(i-1).getReg() == DFNode->getReg()) { |
Owen Anderson | ed2ffa2 | 2007-12-12 01:25:08 +0000 | [diff] [blame] | 612 | unsigned SrcReg = DFNode->getReg(); |
Owen Anderson | d525f66 | 2007-12-11 20:12:11 +0000 | [diff] [blame] | 613 | MachineBasicBlock* From = Inst->getOperand(i).getMBB(); |
| 614 | |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 615 | Waiting[From].insert(std::make_pair(SrcReg, DestReg)); |
| 616 | UsedByAnother.insert(SrcReg); |
| 617 | |
Owen Anderson | ed2ffa2 | 2007-12-12 01:25:08 +0000 | [diff] [blame] | 618 | PHIUnion.erase(SrcReg); |
Owen Anderson | d525f66 | 2007-12-11 20:12:11 +0000 | [diff] [blame] | 619 | } |
| 620 | } |
Owen Anderson | 3b48952 | 2008-01-21 22:01:01 +0000 | [diff] [blame] | 621 | |
| 622 | // If a node is live-in to the defining block of one of its children, but |
| 623 | // not live-out, then we need to scan that block for local interferences. |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 624 | } else if (isLiveIn(DFNode->getReg(), |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 625 | MRI.getVRegDef(child->getReg())->getParent(), LI) || |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 626 | MRI.getVRegDef(DFNode->getReg())->getParent() == |
| 627 | MRI.getVRegDef(child->getReg())->getParent()) { |
Owen Anderson | 62d67dd | 2007-12-13 05:53:03 +0000 | [diff] [blame] | 628 | // Add (p, c) to possible local interferences |
| 629 | locals.push_back(std::make_pair(DFNode->getReg(), child->getReg())); |
Owen Anderson | d525f66 | 2007-12-11 20:12:11 +0000 | [diff] [blame] | 630 | } |
Owen Anderson | 965b467 | 2007-12-16 04:07:23 +0000 | [diff] [blame] | 631 | |
Owen Anderson | 4ba08ec | 2007-12-13 05:43:37 +0000 | [diff] [blame] | 632 | if (!visited.count(child)) { |
| 633 | worklist.push_back(child); |
| 634 | inserted = true; |
Owen Anderson | d525f66 | 2007-12-11 20:12:11 +0000 | [diff] [blame] | 635 | } |
| 636 | } |
| 637 | |
| 638 | if (!inserted) worklist.pop_back(); |
| 639 | } |
| 640 | } |
| 641 | |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 642 | /// ScheduleCopies - Insert copies into predecessor blocks, scheduling |
| 643 | /// them properly so as to avoid the 'lost copy' and the 'virtual swap' |
| 644 | /// problems. |
| 645 | /// |
| 646 | /// Based on "Practical Improvements to the Construction and Destruction |
| 647 | /// of Static Single Assignment Form" by Briggs, et al. |
Owen Anderson | f1519e8 | 2007-12-24 22:12:23 +0000 | [diff] [blame] | 648 | void StrongPHIElimination::ScheduleCopies(MachineBasicBlock* MBB, |
| 649 | std::set<unsigned>& pushed) { |
Owen Anderson | 38b4250 | 2008-06-04 17:55:58 +0000 | [diff] [blame] | 650 | // FIXME: This function needs to update LiveIntervals |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 651 | std::multimap<unsigned, unsigned>& copy_set= Waiting[MBB]; |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 652 | |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 653 | std::multimap<unsigned, unsigned> worklist; |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 654 | std::map<unsigned, unsigned> map; |
| 655 | |
| 656 | // Setup worklist of initial copies |
Argyrios Kyrtzidis | 0304b87 | 2008-10-04 08:11:49 +0000 | [diff] [blame] | 657 | for (std::multimap<unsigned, unsigned>::iterator I = copy_set.begin(), |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 658 | E = copy_set.end(); I != E; ) { |
| 659 | map.insert(std::make_pair(I->first, I->first)); |
| 660 | map.insert(std::make_pair(I->second, I->second)); |
| 661 | |
Owen Anderson | c7c0036 | 2008-03-29 01:58:47 +0000 | [diff] [blame] | 662 | if (!UsedByAnother.count(I->second)) { |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 663 | worklist.insert(*I); |
| 664 | |
| 665 | // Avoid iterator invalidation |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 666 | std::multimap<unsigned, unsigned>::iterator OI = I; |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 667 | ++I; |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 668 | copy_set.erase(OI); |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 669 | } else { |
| 670 | ++I; |
| 671 | } |
| 672 | } |
| 673 | |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 674 | LiveIntervals& LI = getAnalysis<LiveIntervals>(); |
Owen Anderson | 0d893b4 | 2008-01-08 05:16:15 +0000 | [diff] [blame] | 675 | MachineFunction* MF = MBB->getParent(); |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 676 | MachineRegisterInfo& MRI = MF->getRegInfo(); |
Owen Anderson | 0d893b4 | 2008-01-08 05:16:15 +0000 | [diff] [blame] | 677 | const TargetInstrInfo *TII = MF->getTarget().getInstrInfo(); |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 678 | |
Owen Anderson | 38b4250 | 2008-06-04 17:55:58 +0000 | [diff] [blame] | 679 | SmallVector<std::pair<unsigned, MachineInstr*>, 4> InsertedPHIDests; |
| 680 | |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 681 | // Iterate over the worklist, inserting copies |
| 682 | while (!worklist.empty() || !copy_set.empty()) { |
| 683 | while (!worklist.empty()) { |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 684 | std::multimap<unsigned, unsigned>::iterator WI = worklist.begin(); |
| 685 | std::pair<unsigned, unsigned> curr = *WI; |
| 686 | worklist.erase(WI); |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 687 | |
Owen Anderson | 0d893b4 | 2008-01-08 05:16:15 +0000 | [diff] [blame] | 688 | const TargetRegisterClass *RC = MF->getRegInfo().getRegClass(curr.first); |
| 689 | |
Owen Anderson | eb37ecc | 2008-03-10 07:22:36 +0000 | [diff] [blame] | 690 | if (isLiveOut(curr.second, MBB, LI)) { |
Owen Anderson | 0d893b4 | 2008-01-08 05:16:15 +0000 | [diff] [blame] | 691 | // Create a temporary |
| 692 | unsigned t = MF->getRegInfo().createVirtualRegister(RC); |
| 693 | |
| 694 | // Insert copy from curr.second to a temporary at |
| 695 | // the Phi defining curr.second |
Owen Anderson | ddd060f | 2008-01-10 01:36:43 +0000 | [diff] [blame] | 696 | MachineBasicBlock::iterator PI = MRI.getVRegDef(curr.second); |
| 697 | TII->copyRegToReg(*PI->getParent(), PI, t, |
Owen Anderson | 0d893b4 | 2008-01-08 05:16:15 +0000 | [diff] [blame] | 698 | curr.second, RC, RC); |
| 699 | |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 700 | DOUT << "Inserted copy from " << curr.second << " to " << t << "\n"; |
| 701 | |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 702 | // Push temporary on Stacks |
Owen Anderson | 0d893b4 | 2008-01-08 05:16:15 +0000 | [diff] [blame] | 703 | Stacks[curr.second].push_back(t); |
| 704 | |
| 705 | // Insert curr.second in pushed |
| 706 | pushed.insert(curr.second); |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 707 | |
| 708 | // Create a live interval for this temporary |
| 709 | InsertedPHIDests.push_back(std::make_pair(t, --PI)); |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 710 | } |
| 711 | |
| 712 | // Insert copy from map[curr.first] to curr.second |
Owen Anderson | 9c2efa8 | 2008-01-10 00:01:41 +0000 | [diff] [blame] | 713 | TII->copyRegToReg(*MBB, MBB->getFirstTerminator(), curr.second, |
Owen Anderson | 0d893b4 | 2008-01-08 05:16:15 +0000 | [diff] [blame] | 714 | map[curr.first], RC, RC); |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 715 | map[curr.first] = curr.second; |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 716 | DOUT << "Inserted copy from " << curr.first << " to " |
| 717 | << curr.second << "\n"; |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 718 | |
Owen Anderson | 38b4250 | 2008-06-04 17:55:58 +0000 | [diff] [blame] | 719 | // Push this copy onto InsertedPHICopies so we can |
| 720 | // update LiveIntervals with it. |
| 721 | MachineBasicBlock::iterator MI = MBB->getFirstTerminator(); |
| 722 | InsertedPHIDests.push_back(std::make_pair(curr.second, --MI)); |
| 723 | |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 724 | // If curr.first is a destination in copy_set... |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 725 | for (std::multimap<unsigned, unsigned>::iterator I = copy_set.begin(), |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 726 | E = copy_set.end(); I != E; ) |
| 727 | if (curr.first == I->second) { |
| 728 | std::pair<unsigned, unsigned> temp = *I; |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 729 | worklist.insert(temp); |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 730 | |
| 731 | // Avoid iterator invalidation |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 732 | std::multimap<unsigned, unsigned>::iterator OI = I; |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 733 | ++I; |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 734 | copy_set.erase(OI); |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 735 | |
| 736 | break; |
| 737 | } else { |
| 738 | ++I; |
| 739 | } |
| 740 | } |
| 741 | |
| 742 | if (!copy_set.empty()) { |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 743 | std::multimap<unsigned, unsigned>::iterator CI = copy_set.begin(); |
| 744 | std::pair<unsigned, unsigned> curr = *CI; |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 745 | worklist.insert(curr); |
Owen Anderson | 8481ee7 | 2008-10-02 19:40:33 +0000 | [diff] [blame] | 746 | copy_set.erase(CI); |
Owen Anderson | 27d6681 | 2008-08-13 17:25:42 +0000 | [diff] [blame] | 747 | |
| 748 | LiveInterval& I = LI.getInterval(curr.second); |
| 749 | MachineBasicBlock::iterator term = MBB->getFirstTerminator(); |
| 750 | unsigned endIdx = 0; |
| 751 | if (term != MBB->end()) |
| 752 | endIdx = LI.getInstructionIndex(term); |
| 753 | else |
| 754 | endIdx = LI.getMBBEndIdx(MBB); |
| 755 | |
| 756 | if (I.liveAt(endIdx)) { |
| 757 | const TargetRegisterClass *RC = |
| 758 | MF->getRegInfo().getRegClass(curr.first); |
| 759 | |
| 760 | // Insert a copy from dest to a new temporary t at the end of b |
| 761 | unsigned t = MF->getRegInfo().createVirtualRegister(RC); |
| 762 | TII->copyRegToReg(*MBB, MBB->getFirstTerminator(), t, |
| 763 | curr.second, RC, RC); |
| 764 | map[curr.second] = t; |
| 765 | |
| 766 | MachineBasicBlock::iterator TI = MBB->getFirstTerminator(); |
| 767 | InsertedPHIDests.push_back(std::make_pair(t, --TI)); |
| 768 | } |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 769 | } |
| 770 | } |
Owen Anderson | 38b4250 | 2008-06-04 17:55:58 +0000 | [diff] [blame] | 771 | |
| 772 | // Renumber the instructions so that we can perform the index computations |
| 773 | // needed to create new live intervals. |
| 774 | LI.computeNumbering(); |
| 775 | |
| 776 | // For copies that we inserted at the ends of predecessors, we construct |
| 777 | // live intervals. This is pretty easy, since we know that the destination |
| 778 | // register cannot have be in live at that point previously. We just have |
| 779 | // to make sure that, for registers that serve as inputs to more than one |
| 780 | // PHI, we don't create multiple overlapping live intervals. |
| 781 | std::set<unsigned> RegHandled; |
| 782 | for (SmallVector<std::pair<unsigned, MachineInstr*>, 4>::iterator I = |
Owen Anderson | 27d6681 | 2008-08-13 17:25:42 +0000 | [diff] [blame] | 783 | InsertedPHIDests.begin(), E = InsertedPHIDests.end(); I != E; ++I) { |
Owen Anderson | e04cec0 | 2008-09-22 21:58:58 +0000 | [diff] [blame] | 784 | if (RegHandled.insert(I->first).second) { |
| 785 | LiveInterval& Int = LI.getOrCreateInterval(I->first); |
| 786 | unsigned instrIdx = LI.getInstructionIndex(I->second); |
| 787 | if (Int.liveAt(LiveIntervals::getDefIndex(instrIdx))) |
| 788 | Int.removeRange(LiveIntervals::getDefIndex(instrIdx), |
| 789 | LI.getMBBEndIdx(I->second->getParent())+1, |
| 790 | true); |
| 791 | |
| 792 | LiveRange R = LI.addLiveRangeToEndOfBlock(I->first, I->second); |
| 793 | R.valno->copy = I->second; |
| 794 | R.valno->def = |
| 795 | LiveIntervals::getDefIndex(LI.getInstructionIndex(I->second)); |
| 796 | } |
Owen Anderson | 27d6681 | 2008-08-13 17:25:42 +0000 | [diff] [blame] | 797 | } |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 798 | } |
| 799 | |
Owen Anderson | f1519e8 | 2007-12-24 22:12:23 +0000 | [diff] [blame] | 800 | /// InsertCopies - insert copies into MBB and all of its successors |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 801 | void StrongPHIElimination::InsertCopies(MachineDomTreeNode* MDTN, |
Owen Anderson | e46611e | 2008-03-24 04:11:27 +0000 | [diff] [blame] | 802 | SmallPtrSet<MachineBasicBlock*, 16>& visited) { |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 803 | MachineBasicBlock* MBB = MDTN->getBlock(); |
Owen Anderson | 719fef6 | 2008-01-09 10:32:30 +0000 | [diff] [blame] | 804 | visited.insert(MBB); |
| 805 | |
Owen Anderson | f1519e8 | 2007-12-24 22:12:23 +0000 | [diff] [blame] | 806 | std::set<unsigned> pushed; |
| 807 | |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 808 | LiveIntervals& LI = getAnalysis<LiveIntervals>(); |
Owen Anderson | f1519e8 | 2007-12-24 22:12:23 +0000 | [diff] [blame] | 809 | // Rewrite register uses from Stacks |
| 810 | for (MachineBasicBlock::iterator I = MBB->begin(), E = MBB->end(); |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 811 | I != E; ++I) { |
| 812 | if (I->getOpcode() == TargetInstrInfo::PHI) |
| 813 | continue; |
| 814 | |
Owen Anderson | f1519e8 | 2007-12-24 22:12:23 +0000 | [diff] [blame] | 815 | for (unsigned i = 0; i < I->getNumOperands(); ++i) |
Dan Gohman | d735b80 | 2008-10-03 15:45:36 +0000 | [diff] [blame] | 816 | if (I->getOperand(i).isReg() && |
Owen Anderson | f1519e8 | 2007-12-24 22:12:23 +0000 | [diff] [blame] | 817 | Stacks[I->getOperand(i).getReg()].size()) { |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 818 | // Remove the live range for the old vreg. |
| 819 | LiveInterval& OldInt = LI.getInterval(I->getOperand(i).getReg()); |
| 820 | LiveInterval::iterator OldLR = OldInt.FindLiveRangeContaining( |
| 821 | LiveIntervals::getUseIndex(LI.getInstructionIndex(I))); |
| 822 | if (OldLR != OldInt.end()) |
| 823 | OldInt.removeRange(*OldLR, true); |
| 824 | |
| 825 | // Change the register |
Owen Anderson | f1519e8 | 2007-12-24 22:12:23 +0000 | [diff] [blame] | 826 | I->getOperand(i).setReg(Stacks[I->getOperand(i).getReg()].back()); |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 827 | |
| 828 | // Add a live range for the new vreg |
| 829 | LiveInterval& Int = LI.getInterval(I->getOperand(i).getReg()); |
| 830 | VNInfo* FirstVN = *Int.vni_begin(); |
Lang Hames | 857c4e0 | 2009-06-17 21:01:20 +0000 | [diff] [blame] | 831 | FirstVN->setHasPHIKill(false); |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 832 | if (I->getOperand(i).isKill()) |
Lang Hames | ffd1326 | 2009-07-09 03:57:02 +0000 | [diff] [blame] | 833 | Int.addKill(FirstVN, |
| 834 | LiveIntervals::getUseIndex(LI.getInstructionIndex(I)), false); |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 835 | |
| 836 | LiveRange LR (LI.getMBBStartIdx(I->getParent()), |
Owen Anderson | f835f84 | 2008-09-24 21:30:38 +0000 | [diff] [blame] | 837 | LiveIntervals::getUseIndex(LI.getInstructionIndex(I))+1, |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 838 | FirstVN); |
| 839 | |
| 840 | Int.addRange(LR); |
Owen Anderson | f1519e8 | 2007-12-24 22:12:23 +0000 | [diff] [blame] | 841 | } |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 842 | } |
Owen Anderson | f1519e8 | 2007-12-24 22:12:23 +0000 | [diff] [blame] | 843 | |
| 844 | // Schedule the copies for this block |
| 845 | ScheduleCopies(MBB, pushed); |
| 846 | |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 847 | // Recur down the dominator tree. |
| 848 | for (MachineDomTreeNode::iterator I = MDTN->begin(), |
| 849 | E = MDTN->end(); I != E; ++I) |
| 850 | if (!visited.count((*I)->getBlock())) |
Owen Anderson | 719fef6 | 2008-01-09 10:32:30 +0000 | [diff] [blame] | 851 | InsertCopies(*I, visited); |
Owen Anderson | f1519e8 | 2007-12-24 22:12:23 +0000 | [diff] [blame] | 852 | |
| 853 | // As we exit this block, pop the names we pushed while processing it |
| 854 | for (std::set<unsigned>::iterator I = pushed.begin(), |
| 855 | E = pushed.end(); I != E; ++I) |
| 856 | Stacks[*I].pop_back(); |
| 857 | } |
| 858 | |
Owen Anderson | fae86ed | 2008-09-23 04:37:10 +0000 | [diff] [blame] | 859 | bool StrongPHIElimination::mergeLiveIntervals(unsigned primary, |
Owen Anderson | 27d6681 | 2008-08-13 17:25:42 +0000 | [diff] [blame] | 860 | unsigned secondary) { |
Owen Anderson | 755ebab | 2008-03-17 06:08:26 +0000 | [diff] [blame] | 861 | |
| 862 | LiveIntervals& LI = getAnalysis<LiveIntervals>(); |
| 863 | LiveInterval& LHS = LI.getOrCreateInterval(primary); |
| 864 | LiveInterval& RHS = LI.getOrCreateInterval(secondary); |
| 865 | |
Owen Anderson | a9efb26 | 2008-06-05 17:22:53 +0000 | [diff] [blame] | 866 | LI.computeNumbering(); |
Owen Anderson | e04cec0 | 2008-09-22 21:58:58 +0000 | [diff] [blame] | 867 | |
Owen Anderson | b9fb8d1 | 2008-07-30 00:21:16 +0000 | [diff] [blame] | 868 | DenseMap<VNInfo*, VNInfo*> VNMap; |
Owen Anderson | e04cec0 | 2008-09-22 21:58:58 +0000 | [diff] [blame] | 869 | for (LiveInterval::iterator I = RHS.begin(), E = RHS.end(); I != E; ++I) { |
| 870 | LiveRange R = *I; |
| 871 | |
| 872 | unsigned Start = R.start; |
| 873 | unsigned End = R.end; |
Owen Anderson | fae86ed | 2008-09-23 04:37:10 +0000 | [diff] [blame] | 874 | if (LHS.getLiveRangeContaining(Start)) |
| 875 | return false; |
Owen Anderson | e04cec0 | 2008-09-22 21:58:58 +0000 | [diff] [blame] | 876 | |
Owen Anderson | fae86ed | 2008-09-23 04:37:10 +0000 | [diff] [blame] | 877 | if (LHS.getLiveRangeContaining(End)) |
| 878 | return false; |
Owen Anderson | e04cec0 | 2008-09-22 21:58:58 +0000 | [diff] [blame] | 879 | |
| 880 | LiveInterval::iterator RI = std::upper_bound(LHS.begin(), LHS.end(), R); |
| 881 | if (RI != LHS.end() && RI->start < End) |
Owen Anderson | fae86ed | 2008-09-23 04:37:10 +0000 | [diff] [blame] | 882 | return false; |
| 883 | } |
| 884 | |
| 885 | for (LiveInterval::iterator I = RHS.begin(), E = RHS.end(); I != E; ++I) { |
| 886 | LiveRange R = *I; |
| 887 | VNInfo* OldVN = R.valno; |
| 888 | VNInfo*& NewVN = VNMap[OldVN]; |
| 889 | if (!NewVN) { |
Lang Hames | 857c4e0 | 2009-06-17 21:01:20 +0000 | [diff] [blame] | 890 | NewVN = LHS.createValueCopy(OldVN, LI.getVNInfoAllocator()); |
Owen Anderson | e04cec0 | 2008-09-22 21:58:58 +0000 | [diff] [blame] | 891 | } |
Owen Anderson | fae86ed | 2008-09-23 04:37:10 +0000 | [diff] [blame] | 892 | |
| 893 | LiveRange LR (R.start, R.end, NewVN); |
| 894 | LHS.addRange(LR); |
Owen Anderson | b9fb8d1 | 2008-07-30 00:21:16 +0000 | [diff] [blame] | 895 | } |
Owen Anderson | 55c6435 | 2008-07-25 21:08:41 +0000 | [diff] [blame] | 896 | |
Owen Anderson | e04cec0 | 2008-09-22 21:58:58 +0000 | [diff] [blame] | 897 | LI.removeInterval(RHS.reg); |
Owen Anderson | fae86ed | 2008-09-23 04:37:10 +0000 | [diff] [blame] | 898 | |
| 899 | return true; |
Owen Anderson | 0031671 | 2008-03-12 03:13:29 +0000 | [diff] [blame] | 900 | } |
| 901 | |
Owen Anderson | a4ad2e7 | 2007-11-06 04:49:43 +0000 | [diff] [blame] | 902 | bool StrongPHIElimination::runOnMachineFunction(MachineFunction &Fn) { |
Owen Anderson | c7c0036 | 2008-03-29 01:58:47 +0000 | [diff] [blame] | 903 | LiveIntervals& LI = getAnalysis<LiveIntervals>(); |
| 904 | |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 905 | // Compute DFS numbers of each block |
Owen Anderson | a4ad2e7 | 2007-11-06 04:49:43 +0000 | [diff] [blame] | 906 | computeDFS(Fn); |
| 907 | |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 908 | // Determine which phi node operands need copies |
Owen Anderson | 60a877d | 2007-11-07 05:17:15 +0000 | [diff] [blame] | 909 | for (MachineFunction::iterator I = Fn.begin(), E = Fn.end(); I != E; ++I) |
| 910 | if (!I->empty() && |
| 911 | I->begin()->getOpcode() == TargetInstrInfo::PHI) |
| 912 | processBlock(I); |
Owen Anderson | a4ad2e7 | 2007-11-06 04:49:43 +0000 | [diff] [blame] | 913 | |
Owen Anderson | 883771f | 2008-08-06 22:08:58 +0000 | [diff] [blame] | 914 | // Break interferences where two different phis want to coalesce |
| 915 | // in the same register. |
| 916 | std::set<unsigned> seen; |
| 917 | typedef std::map<unsigned, std::map<unsigned, MachineBasicBlock*> > |
| 918 | RenameSetType; |
| 919 | for (RenameSetType::iterator I = RenameSets.begin(), E = RenameSets.end(); |
| 920 | I != E; ++I) { |
| 921 | for (std::map<unsigned, MachineBasicBlock*>::iterator |
| 922 | OI = I->second.begin(), OE = I->second.end(); OI != OE; ) { |
| 923 | if (!seen.count(OI->first)) { |
| 924 | seen.insert(OI->first); |
| 925 | ++OI; |
| 926 | } else { |
| 927 | Waiting[OI->second].insert(std::make_pair(OI->first, I->first)); |
| 928 | unsigned reg = OI->first; |
| 929 | ++OI; |
| 930 | I->second.erase(reg); |
Owen Anderson | e04cec0 | 2008-09-22 21:58:58 +0000 | [diff] [blame] | 931 | DOUT << "Removing Renaming: " << reg << " -> " << I->first << "\n"; |
Owen Anderson | 883771f | 2008-08-06 22:08:58 +0000 | [diff] [blame] | 932 | } |
| 933 | } |
| 934 | } |
| 935 | |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 936 | // Insert copies |
Owen Anderson | a9efb26 | 2008-06-05 17:22:53 +0000 | [diff] [blame] | 937 | // FIXME: This process should probably preserve LiveIntervals |
Owen Anderson | e46611e | 2008-03-24 04:11:27 +0000 | [diff] [blame] | 938 | SmallPtrSet<MachineBasicBlock*, 16> visited; |
Owen Anderson | 724acf1 | 2008-08-07 18:28:07 +0000 | [diff] [blame] | 939 | MachineDominatorTree& MDT = getAnalysis<MachineDominatorTree>(); |
| 940 | InsertCopies(MDT.getRootNode(), visited); |
Owen Anderson | efbcebc | 2007-12-23 15:37:26 +0000 | [diff] [blame] | 941 | |
Owen Anderson | 0c5714b | 2008-01-08 21:54:52 +0000 | [diff] [blame] | 942 | // Perform renaming |
Owen Anderson | 0c5714b | 2008-01-08 21:54:52 +0000 | [diff] [blame] | 943 | for (RenameSetType::iterator I = RenameSets.begin(), E = RenameSets.end(); |
| 944 | I != E; ++I) |
Owen Anderson | 883771f | 2008-08-06 22:08:58 +0000 | [diff] [blame] | 945 | while (I->second.size()) { |
| 946 | std::map<unsigned, MachineBasicBlock*>::iterator SI = I->second.begin(); |
| 947 | |
Owen Anderson | e04cec0 | 2008-09-22 21:58:58 +0000 | [diff] [blame] | 948 | DOUT << "Renaming: " << SI->first << " -> " << I->first << "\n"; |
| 949 | |
Owen Anderson | 883771f | 2008-08-06 22:08:58 +0000 | [diff] [blame] | 950 | if (SI->first != I->first) { |
Owen Anderson | fae86ed | 2008-09-23 04:37:10 +0000 | [diff] [blame] | 951 | if (mergeLiveIntervals(I->first, SI->first)) { |
| 952 | Fn.getRegInfo().replaceRegWith(SI->first, I->first); |
Owen Anderson | 883771f | 2008-08-06 22:08:58 +0000 | [diff] [blame] | 953 | |
Owen Anderson | fae86ed | 2008-09-23 04:37:10 +0000 | [diff] [blame] | 954 | if (RenameSets.count(SI->first)) { |
| 955 | I->second.insert(RenameSets[SI->first].begin(), |
| 956 | RenameSets[SI->first].end()); |
| 957 | RenameSets.erase(SI->first); |
| 958 | } |
| 959 | } else { |
| 960 | // Insert a last-minute copy if a conflict was detected. |
| 961 | const TargetInstrInfo *TII = Fn.getTarget().getInstrInfo(); |
| 962 | const TargetRegisterClass *RC = Fn.getRegInfo().getRegClass(I->first); |
| 963 | TII->copyRegToReg(*SI->second, SI->second->getFirstTerminator(), |
| 964 | I->first, SI->first, RC, RC); |
| 965 | |
| 966 | LI.computeNumbering(); |
| 967 | |
| 968 | LiveInterval& Int = LI.getOrCreateInterval(I->first); |
| 969 | unsigned instrIdx = |
| 970 | LI.getInstructionIndex(--SI->second->getFirstTerminator()); |
| 971 | if (Int.liveAt(LiveIntervals::getDefIndex(instrIdx))) |
| 972 | Int.removeRange(LiveIntervals::getDefIndex(instrIdx), |
| 973 | LI.getMBBEndIdx(SI->second)+1, true); |
| 974 | |
| 975 | LiveRange R = LI.addLiveRangeToEndOfBlock(I->first, |
| 976 | --SI->second->getFirstTerminator()); |
| 977 | R.valno->copy = --SI->second->getFirstTerminator(); |
| 978 | R.valno->def = LiveIntervals::getDefIndex(instrIdx); |
| 979 | |
| 980 | DOUT << "Renaming failed: " << SI->first << " -> " |
| 981 | << I->first << "\n"; |
Owen Anderson | 883771f | 2008-08-06 22:08:58 +0000 | [diff] [blame] | 982 | } |
Owen Anderson | 883771f | 2008-08-06 22:08:58 +0000 | [diff] [blame] | 983 | } |
| 984 | |
Owen Anderson | 05472ee | 2008-09-30 23:58:47 +0000 | [diff] [blame] | 985 | LiveInterval& Int = LI.getOrCreateInterval(I->first); |
| 986 | const LiveRange* LR = |
| 987 | Int.getLiveRangeContaining(LI.getMBBEndIdx(SI->second)); |
Lang Hames | 857c4e0 | 2009-06-17 21:01:20 +0000 | [diff] [blame] | 988 | LR->valno->setHasPHIKill(true); |
Owen Anderson | 05472ee | 2008-09-30 23:58:47 +0000 | [diff] [blame] | 989 | |
Owen Anderson | 883771f | 2008-08-06 22:08:58 +0000 | [diff] [blame] | 990 | I->second.erase(SI->first); |
Owen Anderson | 0031671 | 2008-03-12 03:13:29 +0000 | [diff] [blame] | 991 | } |
Owen Anderson | 0c5714b | 2008-01-08 21:54:52 +0000 | [diff] [blame] | 992 | |
Owen Anderson | 0c5714b | 2008-01-08 21:54:52 +0000 | [diff] [blame] | 993 | // Remove PHIs |
Owen Anderson | 97ca75e | 2008-01-22 23:58:54 +0000 | [diff] [blame] | 994 | std::vector<MachineInstr*> phis; |
| 995 | for (MachineFunction::iterator I = Fn.begin(), E = Fn.end(); I != E; ++I) { |
Owen Anderson | 0c5714b | 2008-01-08 21:54:52 +0000 | [diff] [blame] | 996 | for (MachineBasicBlock::iterator BI = I->begin(), BE = I->end(); |
| 997 | BI != BE; ++BI) |
| 998 | if (BI->getOpcode() == TargetInstrInfo::PHI) |
Owen Anderson | 97ca75e | 2008-01-22 23:58:54 +0000 | [diff] [blame] | 999 | phis.push_back(BI); |
| 1000 | } |
| 1001 | |
| 1002 | for (std::vector<MachineInstr*>::iterator I = phis.begin(), E = phis.end(); |
Owen Anderson | c7c0036 | 2008-03-29 01:58:47 +0000 | [diff] [blame] | 1003 | I != E; ) { |
| 1004 | MachineInstr* PInstr = *(I++); |
| 1005 | |
Owen Anderson | 71ac0be | 2008-08-05 21:18:51 +0000 | [diff] [blame] | 1006 | // If this is a dead PHI node, then remove it from LiveIntervals. |
| 1007 | unsigned DestReg = PInstr->getOperand(0).getReg(); |
| 1008 | LiveInterval& PI = LI.getInterval(DestReg); |
| 1009 | if (PInstr->registerDefIsDead(DestReg)) { |
| 1010 | if (PI.containsOneValue()) { |
| 1011 | LI.removeInterval(DestReg); |
| 1012 | } else { |
| 1013 | unsigned idx = LI.getDefIndex(LI.getInstructionIndex(PInstr)); |
| 1014 | PI.removeRange(*PI.getLiveRangeContaining(idx), true); |
| 1015 | } |
| 1016 | } else { |
Owen Anderson | e7b8205 | 2008-08-05 20:51:26 +0000 | [diff] [blame] | 1017 | // Trim live intervals of input registers. They are no longer live into |
Owen Anderson | 9b49120 | 2008-08-06 18:36:17 +0000 | [diff] [blame] | 1018 | // this block if they died after the PHI. If they lived after it, don't |
| 1019 | // trim them because they might have other legitimate uses. |
Owen Anderson | e7b8205 | 2008-08-05 20:51:26 +0000 | [diff] [blame] | 1020 | for (unsigned i = 1; i < PInstr->getNumOperands(); i += 2) { |
| 1021 | unsigned reg = PInstr->getOperand(i).getReg(); |
Owen Anderson | 883771f | 2008-08-06 22:08:58 +0000 | [diff] [blame] | 1022 | |
Owen Anderson | e7b8205 | 2008-08-05 20:51:26 +0000 | [diff] [blame] | 1023 | MachineBasicBlock* MBB = PInstr->getOperand(i+1).getMBB(); |
| 1024 | LiveInterval& InputI = LI.getInterval(reg); |
| 1025 | if (MBB != PInstr->getParent() && |
Owen Anderson | 9b49120 | 2008-08-06 18:36:17 +0000 | [diff] [blame] | 1026 | InputI.liveAt(LI.getMBBStartIdx(PInstr->getParent())) && |
| 1027 | InputI.expiredAt(LI.getInstructionIndex(PInstr) + |
Lang Hames | f41538d | 2009-06-02 16:53:25 +0000 | [diff] [blame] | 1028 | LiveInterval::InstrSlots::NUM)) |
Owen Anderson | e7b8205 | 2008-08-05 20:51:26 +0000 | [diff] [blame] | 1029 | InputI.removeRange(LI.getMBBStartIdx(PInstr->getParent()), |
| 1030 | LI.getInstructionIndex(PInstr), |
| 1031 | true); |
Owen Anderson | d382f8a | 2008-03-26 03:03:23 +0000 | [diff] [blame] | 1032 | } |
Owen Anderson | e7b8205 | 2008-08-05 20:51:26 +0000 | [diff] [blame] | 1033 | |
Owen Anderson | 71ac0be | 2008-08-05 21:18:51 +0000 | [diff] [blame] | 1034 | // If the PHI is not dead, then the valno defined by the PHI |
| 1035 | // now has an unknown def. |
| 1036 | unsigned idx = LI.getDefIndex(LI.getInstructionIndex(PInstr)); |
| 1037 | const LiveRange* PLR = PI.getLiveRangeContaining(idx); |
Lang Hames | 857c4e0 | 2009-06-17 21:01:20 +0000 | [diff] [blame] | 1038 | PLR->valno->setIsPHIDef(true); |
Owen Anderson | 71ac0be | 2008-08-05 21:18:51 +0000 | [diff] [blame] | 1039 | LiveRange R (LI.getMBBStartIdx(PInstr->getParent()), |
| 1040 | PLR->start, PLR->valno); |
| 1041 | PI.addRange(R); |
Owen Anderson | d382f8a | 2008-03-26 03:03:23 +0000 | [diff] [blame] | 1042 | } |
Owen Anderson | 59df878 | 2008-04-02 02:12:45 +0000 | [diff] [blame] | 1043 | |
Owen Anderson | c7c0036 | 2008-03-29 01:58:47 +0000 | [diff] [blame] | 1044 | LI.RemoveMachineInstrFromMaps(PInstr); |
| 1045 | PInstr->eraseFromParent(); |
Owen Anderson | e46611e | 2008-03-24 04:11:27 +0000 | [diff] [blame] | 1046 | } |
Owen Anderson | cae8d8d | 2007-12-22 04:59:10 +0000 | [diff] [blame] | 1047 | |
Owen Anderson | 3947e4d | 2008-05-30 18:38:26 +0000 | [diff] [blame] | 1048 | LI.computeNumbering(); |
| 1049 | |
Owen Anderson | c7c0036 | 2008-03-29 01:58:47 +0000 | [diff] [blame] | 1050 | return true; |
Owen Anderson | a4ad2e7 | 2007-11-06 04:49:43 +0000 | [diff] [blame] | 1051 | } |