Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 1 | // Copyright 2014 the V8 project authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
| 5 | #include "src/compiler/js-builtin-reducer.h" |
| 6 | #include "src/compiler/js-graph.h" |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 7 | #include "src/compiler/node-properties.h" |
| 8 | #include "src/compiler/simplified-operator.h" |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 9 | #include "src/compiler/typer.h" |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 10 | #include "src/isolate-inl.h" |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 11 | #include "test/unittests/compiler/graph-unittest.h" |
| 12 | #include "test/unittests/compiler/node-test-utils.h" |
| 13 | #include "testing/gmock-support.h" |
| 14 | |
| 15 | using testing::BitEq; |
| 16 | using testing::Capture; |
| 17 | |
| 18 | namespace v8 { |
| 19 | namespace internal { |
| 20 | namespace compiler { |
| 21 | |
| 22 | class JSBuiltinReducerTest : public TypedGraphTest { |
| 23 | public: |
| 24 | JSBuiltinReducerTest() : javascript_(zone()) {} |
| 25 | |
| 26 | protected: |
| 27 | Reduction Reduce(Node* node, MachineOperatorBuilder::Flags flags = |
| 28 | MachineOperatorBuilder::Flag::kNoFlags) { |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 29 | MachineOperatorBuilder machine(zone(), MachineType::PointerRepresentation(), |
| 30 | flags); |
| 31 | SimplifiedOperatorBuilder simplified(zone()); |
| 32 | JSGraph jsgraph(isolate(), graph(), common(), javascript(), &simplified, |
| 33 | &machine); |
| 34 | // TODO(titzer): mock the GraphReducer here for better unit testing. |
| 35 | GraphReducer graph_reducer(zone(), graph()); |
| 36 | JSBuiltinReducer reducer(&graph_reducer, &jsgraph); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 37 | return reducer.Reduce(node); |
| 38 | } |
| 39 | |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 40 | Node* MathFunction(const char* name) { |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 41 | Handle<Object> m = |
| 42 | JSObject::GetProperty(isolate()->global_object(), |
| 43 | isolate()->factory()->NewStringFromAsciiChecked( |
| 44 | "Math")).ToHandleChecked(); |
| 45 | Handle<JSFunction> f = Handle<JSFunction>::cast( |
Ben Murdoch | da12d29 | 2016-06-02 14:46:10 +0100 | [diff] [blame] | 46 | Object::GetProperty( |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 47 | m, isolate()->factory()->NewStringFromAsciiChecked(name)) |
| 48 | .ToHandleChecked()); |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 49 | return HeapConstant(f); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 50 | } |
| 51 | |
| 52 | JSOperatorBuilder* javascript() { return &javascript_; } |
| 53 | |
| 54 | private: |
| 55 | JSOperatorBuilder javascript_; |
| 56 | }; |
| 57 | |
| 58 | |
| 59 | namespace { |
| 60 | |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 61 | Type* const kIntegral32Types[] = {Type::UnsignedSmall(), Type::Negative32(), |
| 62 | Type::Unsigned31(), Type::SignedSmall(), |
| 63 | Type::Signed32(), Type::Unsigned32(), |
| 64 | Type::Integral32()}; |
| 65 | |
| 66 | |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 67 | Type* const kNumberTypes[] = { |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 68 | Type::UnsignedSmall(), Type::Negative32(), Type::Unsigned31(), |
| 69 | Type::SignedSmall(), Type::Signed32(), Type::Unsigned32(), |
| 70 | Type::Integral32(), Type::MinusZero(), Type::NaN(), |
| 71 | Type::OrderedNumber(), Type::PlainNumber(), Type::Number()}; |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 72 | |
| 73 | } // namespace |
| 74 | |
| 75 | |
| 76 | // ----------------------------------------------------------------------------- |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 77 | // Math.max |
| 78 | |
| 79 | |
| 80 | TEST_F(JSBuiltinReducerTest, MathMax0) { |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 81 | Node* function = MathFunction("max"); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 82 | |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 83 | Node* effect = graph()->start(); |
| 84 | Node* control = graph()->start(); |
| 85 | Node* context = UndefinedConstant(); |
| 86 | Node* frame_state = graph()->start(); |
Ben Murdoch | 097c5b2 | 2016-05-18 11:27:45 +0100 | [diff] [blame] | 87 | Node* call = graph()->NewNode(javascript()->CallFunction(2), function, |
| 88 | UndefinedConstant(), context, frame_state, |
| 89 | frame_state, effect, control); |
| 90 | Reduction r = Reduce(call); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 91 | |
Ben Murdoch | 097c5b2 | 2016-05-18 11:27:45 +0100 | [diff] [blame] | 92 | ASSERT_TRUE(r.Changed()); |
| 93 | EXPECT_THAT(r.replacement(), IsNumberConstant(-V8_INFINITY)); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 94 | } |
| 95 | |
| 96 | |
| 97 | TEST_F(JSBuiltinReducerTest, MathMax1) { |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 98 | Node* function = MathFunction("max"); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 99 | |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 100 | Node* effect = graph()->start(); |
| 101 | Node* control = graph()->start(); |
| 102 | Node* context = UndefinedConstant(); |
| 103 | Node* frame_state = graph()->start(); |
Ben Murdoch | 097c5b2 | 2016-05-18 11:27:45 +0100 | [diff] [blame] | 104 | TRACED_FOREACH(Type*, t0, kNumberTypes) { |
| 105 | Node* p0 = Parameter(t0, 0); |
| 106 | Node* call = graph()->NewNode(javascript()->CallFunction(3), function, |
| 107 | UndefinedConstant(), p0, context, frame_state, |
| 108 | frame_state, effect, control); |
| 109 | Reduction r = Reduce(call); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 110 | |
Ben Murdoch | 097c5b2 | 2016-05-18 11:27:45 +0100 | [diff] [blame] | 111 | ASSERT_TRUE(r.Changed()); |
| 112 | EXPECT_THAT(r.replacement(), p0); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 113 | } |
| 114 | } |
| 115 | |
| 116 | |
| 117 | TEST_F(JSBuiltinReducerTest, MathMax2) { |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 118 | Node* function = MathFunction("max"); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 119 | |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 120 | Node* effect = graph()->start(); |
| 121 | Node* control = graph()->start(); |
| 122 | Node* context = UndefinedConstant(); |
| 123 | Node* frame_state = graph()->start(); |
Ben Murdoch | 097c5b2 | 2016-05-18 11:27:45 +0100 | [diff] [blame] | 124 | TRACED_FOREACH(Type*, t0, kIntegral32Types) { |
| 125 | TRACED_FOREACH(Type*, t1, kIntegral32Types) { |
| 126 | Node* p0 = Parameter(t0, 0); |
| 127 | Node* p1 = Parameter(t1, 1); |
| 128 | Node* call = graph()->NewNode(javascript()->CallFunction(4), function, |
| 129 | UndefinedConstant(), p0, p1, context, |
| 130 | frame_state, frame_state, effect, control); |
| 131 | Reduction r = Reduce(call); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 132 | |
Ben Murdoch | 097c5b2 | 2016-05-18 11:27:45 +0100 | [diff] [blame] | 133 | ASSERT_TRUE(r.Changed()); |
| 134 | EXPECT_THAT(r.replacement(), IsSelect(MachineRepresentation::kNone, |
| 135 | IsNumberLessThan(p1, p0), p0, p1)); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 136 | } |
| 137 | } |
| 138 | } |
| 139 | |
| 140 | |
| 141 | // ----------------------------------------------------------------------------- |
| 142 | // Math.imul |
| 143 | |
| 144 | |
| 145 | TEST_F(JSBuiltinReducerTest, MathImul) { |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 146 | Node* function = MathFunction("imul"); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 147 | |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 148 | Node* effect = graph()->start(); |
| 149 | Node* control = graph()->start(); |
| 150 | Node* context = UndefinedConstant(); |
| 151 | Node* frame_state = graph()->start(); |
Ben Murdoch | da12d29 | 2016-06-02 14:46:10 +0100 | [diff] [blame] | 152 | TRACED_FOREACH(Type*, t0, kNumberTypes) { |
| 153 | TRACED_FOREACH(Type*, t1, kNumberTypes) { |
Ben Murdoch | 097c5b2 | 2016-05-18 11:27:45 +0100 | [diff] [blame] | 154 | Node* p0 = Parameter(t0, 0); |
| 155 | Node* p1 = Parameter(t1, 1); |
| 156 | Node* call = graph()->NewNode(javascript()->CallFunction(4), function, |
| 157 | UndefinedConstant(), p0, p1, context, |
| 158 | frame_state, frame_state, effect, control); |
| 159 | Reduction r = Reduce(call); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 160 | |
Ben Murdoch | 097c5b2 | 2016-05-18 11:27:45 +0100 | [diff] [blame] | 161 | ASSERT_TRUE(r.Changed()); |
Ben Murdoch | da12d29 | 2016-06-02 14:46:10 +0100 | [diff] [blame] | 162 | EXPECT_THAT(r.replacement(), |
| 163 | IsNumberImul(IsNumberToUint32(p0), IsNumberToUint32(p1))); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 164 | } |
| 165 | } |
| 166 | } |
| 167 | |
| 168 | |
| 169 | // ----------------------------------------------------------------------------- |
| 170 | // Math.fround |
| 171 | |
| 172 | |
| 173 | TEST_F(JSBuiltinReducerTest, MathFround) { |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 174 | Node* function = MathFunction("fround"); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 175 | |
Ben Murdoch | 4a90d5f | 2016-03-22 12:00:34 +0000 | [diff] [blame] | 176 | Node* effect = graph()->start(); |
| 177 | Node* control = graph()->start(); |
| 178 | Node* context = UndefinedConstant(); |
| 179 | Node* frame_state = graph()->start(); |
Ben Murdoch | 097c5b2 | 2016-05-18 11:27:45 +0100 | [diff] [blame] | 180 | TRACED_FOREACH(Type*, t0, kNumberTypes) { |
| 181 | Node* p0 = Parameter(t0, 0); |
| 182 | Node* call = graph()->NewNode(javascript()->CallFunction(3), function, |
| 183 | UndefinedConstant(), p0, context, frame_state, |
| 184 | frame_state, effect, control); |
| 185 | Reduction r = Reduce(call); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 186 | |
Ben Murdoch | 097c5b2 | 2016-05-18 11:27:45 +0100 | [diff] [blame] | 187 | ASSERT_TRUE(r.Changed()); |
| 188 | EXPECT_THAT(r.replacement(), IsTruncateFloat64ToFloat32(p0)); |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 189 | } |
| 190 | } |
| 191 | |
Emily Bernier | d0a1eb7 | 2015-03-24 16:35:39 -0400 | [diff] [blame] | 192 | } // namespace compiler |
| 193 | } // namespace internal |
| 194 | } // namespace v8 |