commit fe8809471a40cac8acc984adfa51c39e13e83947
author Romain Guy <romainguy@google.com> Wed Jun 30 16:05:32 2010 -0700
committer Romain Guy <romainguy@google.com> Wed Jun 30 16:05:32 2010 -0700
tree 941d366f5445acc27f6774dcf1e0166e8b69ccb1
parent 364703c6fa4aa1a7d2ef5b0c048ea2a0d57a4c40

Remove unnecessary return and add bitmap generation ID tracking.

Change-Id: Icf5e0635e789f5ea53268c22fad51cf733b5b1a6

libs/hwui/Texture.h

diff --git a/libs/hwui/Texture.h b/libs/hwui/Texture.h
index b3b17ca..6802c59 100644
--- a/libs/hwui/Texture.h
+++ b/libs/hwui/Texture.h
@@ -31,6 +31,10 @@
      */
     GLuint id;
     /**
+     * Generation of the backing bitmap,
+     */
+    uint32_t generation;
+    /**
      * Indicates whether the texture requires blending.
      */
     bool blend;

libs/hwui/TextureCache.cpp

diff --git a/libs/hwui/TextureCache.cpp b/libs/hwui/TextureCache.cpp
index fd12a3c..c3b1463 100644
--- a/libs/hwui/TextureCache.cpp
+++ b/libs/hwui/TextureCache.cpp
@@ -43,6 +43,8 @@
         texture = new Texture;
         generateTexture(bitmap, texture);
         mCache.put(bitmap, texture);
+    } else if (bitmap->getGenerationID() != texture->generation) {
+        generateTexture(bitmap, texture, true);
     }
     return texture;
 }
@@ -55,11 +57,14 @@
     mCache.clear();
 }
 
-void TextureCache::generateTexture(SkBitmap* bitmap, Texture* texture) {
-    texture->width = bitmap->width();
-    texture->height = bitmap->height();
+void TextureCache::generateTexture(SkBitmap* bitmap, Texture* texture, bool regenerate) {
+    if (!regenerate) {
+        texture->width = bitmap->width();
+        texture->height = bitmap->height();
 
-    glGenTextures(1, &texture->id);
+        glGenTextures(1, &texture->id);
+    }
+
     glBindTexture(GL_TEXTURE_2D, texture->id);
 
     glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
@@ -80,7 +85,7 @@
         break;
     }
 
-    return texture;
+    glBindTexture(GL_TEXTURE_2D, 0);
 }
 
 }; // namespace uirenderer

libs/hwui/TextureCache.h

diff --git a/libs/hwui/TextureCache.h b/libs/hwui/TextureCache.h
index 7f95366..bf68061 100644
--- a/libs/hwui/TextureCache.h
+++ b/libs/hwui/TextureCache.h
@@ -37,7 +37,7 @@
     void clear();
 
 private:
-    void generateTexture(SkBitmap* bitmap, Texture* texture);
+    void generateTexture(SkBitmap* bitmap, Texture* texture, bool regenerate = false);
 
     GenerationCache<SkBitmap, Texture> mCache;
 }; // class TextureCache