UPD-20: Fix the creation of /storage/emulated/0/storage/emulated/0/updater
which happens due to the misuse of the method Environment.getExternalStoragePublicDirectory.
Change-Id: I81829b7f79e20810a3af91ca85751a28576c0676
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
diff --git a/app/src/main/java/com/fairphone/updater/UpdaterService.java b/app/src/main/java/com/fairphone/updater/UpdaterService.java
index eb65cd7..c59680f 100644
--- a/app/src/main/java/com/fairphone/updater/UpdaterService.java
+++ b/app/src/main/java/com/fairphone/updater/UpdaterService.java
@@ -380,7 +380,7 @@
try
{
request = new Request(Uri.parse(url));
- final File externalStoragePublicDirectory = Environment.getExternalStoragePublicDirectory(Environment.getExternalStorageDirectory() + resources.getString(R.string.updaterFolder));
+ final File externalStoragePublicDirectory = new File(Environment.getExternalStorageDirectory() + resources.getString(R.string.updaterFolder));
final boolean notMkDirs = !externalStoragePublicDirectory.mkdirs();
if(notMkDirs && !externalStoragePublicDirectory.exists()) {
throw new Exception("Couldn't create updater dir structures.");
diff --git a/app/src/main/java/com/fairphone/updater/fragments/VersionDetailFragment.java b/app/src/main/java/com/fairphone/updater/fragments/VersionDetailFragment.java
index 2761fe8..71a6f06 100644
--- a/app/src/main/java/com/fairphone/updater/fragments/VersionDetailFragment.java
+++ b/app/src/main/java/com/fairphone/updater/fragments/VersionDetailFragment.java
@@ -273,7 +273,7 @@
try
{
request = new Request(Uri.parse(url));
- final File externalStoragePublicDirectory = Environment.getExternalStoragePublicDirectory(Environment.getExternalStorageDirectory() + resources.getString(R.string.updaterFolder));
+ final File externalStoragePublicDirectory = new File(Environment.getExternalStorageDirectory() + resources.getString(R.string.updaterFolder));
final boolean notMkDirs = !externalStoragePublicDirectory.mkdirs();
if(notMkDirs && !externalStoragePublicDirectory.exists()) {
throw new Exception("Couldn't create updater dir structures.");