blob: 551bc74ed2b822fe0f211d90527397da2d86bb38 [file] [log] [blame]
Mike Marshall5db11c22015-07-17 10:38:12 -04001/*
2 * (C) 2001 Clemson University and The University of Chicago
3 *
4 * See COPYING in top-level directory.
5 */
6
7/*
8 * Linux VFS inode operations.
9 */
10
Christoph Hellwig2f8b5442016-11-01 07:40:13 -060011#include <linux/bvec.h>
Mike Marshall5db11c22015-07-17 10:38:12 -040012#include "protocol.h"
Mike Marshall575e9462015-12-04 12:56:14 -050013#include "orangefs-kernel.h"
14#include "orangefs-bufmap.h"
Mike Marshall5db11c22015-07-17 10:38:12 -040015
16static int read_one_page(struct page *page)
17{
Mike Marshall5db11c22015-07-17 10:38:12 -040018 int ret;
19 int max_block;
20 ssize_t bytes_read = 0;
21 struct inode *inode = page->mapping->host;
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +030022 const __u32 blocksize = PAGE_SIZE; /* inode->i_blksize */
23 const __u32 blockbits = PAGE_SHIFT; /* inode->i_blkbits */
Al Viro74f68fc2015-10-08 18:31:05 -040024 struct iov_iter to;
25 struct bio_vec bv = {.bv_page = page, .bv_len = PAGE_SIZE};
26
27 iov_iter_bvec(&to, ITER_BVEC | READ, &bv, 1, PAGE_SIZE);
Mike Marshall5db11c22015-07-17 10:38:12 -040028
29 gossip_debug(GOSSIP_INODE_DEBUG,
Yi Liu8bb8aef2015-11-24 15:12:14 -050030 "orangefs_readpage called with page %p\n",
Mike Marshall5db11c22015-07-17 10:38:12 -040031 page);
Mike Marshall5db11c22015-07-17 10:38:12 -040032
33 max_block = ((inode->i_size / blocksize) + 1);
34
35 if (page->index < max_block) {
36 loff_t blockptr_offset = (((loff_t) page->index) << blockbits);
37
Yi Liu8bb8aef2015-11-24 15:12:14 -050038 bytes_read = orangefs_inode_read(inode,
39 &to,
40 &blockptr_offset,
41 inode->i_size);
Mike Marshall5db11c22015-07-17 10:38:12 -040042 }
Al Viro74f68fc2015-10-08 18:31:05 -040043 /* this will only zero remaining unread portions of the page data */
44 iov_iter_zero(~0U, &to);
Mike Marshall5db11c22015-07-17 10:38:12 -040045 /* takes care of potential aliasing */
46 flush_dcache_page(page);
47 if (bytes_read < 0) {
48 ret = bytes_read;
49 SetPageError(page);
50 } else {
51 SetPageUptodate(page);
52 if (PageError(page))
53 ClearPageError(page);
54 ret = 0;
55 }
Mike Marshall5db11c22015-07-17 10:38:12 -040056 /* unlock the page after the ->readpage() routine completes */
57 unlock_page(page);
58 return ret;
59}
60
Yi Liu8bb8aef2015-11-24 15:12:14 -050061static int orangefs_readpage(struct file *file, struct page *page)
Mike Marshall5db11c22015-07-17 10:38:12 -040062{
63 return read_one_page(page);
64}
65
Yi Liu8bb8aef2015-11-24 15:12:14 -050066static int orangefs_readpages(struct file *file,
Mike Marshall5db11c22015-07-17 10:38:12 -040067 struct address_space *mapping,
68 struct list_head *pages,
69 unsigned nr_pages)
70{
71 int page_idx;
72 int ret;
73
Yi Liu8bb8aef2015-11-24 15:12:14 -050074 gossip_debug(GOSSIP_INODE_DEBUG, "orangefs_readpages called\n");
Mike Marshall5db11c22015-07-17 10:38:12 -040075
76 for (page_idx = 0; page_idx < nr_pages; page_idx++) {
77 struct page *page;
78
79 page = list_entry(pages->prev, struct page, lru);
80 list_del(&page->lru);
81 if (!add_to_page_cache(page,
82 mapping,
83 page->index,
Michal Hocko8a5c7432016-07-26 15:24:53 -070084 readahead_gfp_mask(mapping))) {
Mike Marshall5db11c22015-07-17 10:38:12 -040085 ret = read_one_page(page);
86 gossip_debug(GOSSIP_INODE_DEBUG,
87 "failure adding page to cache, read_one_page returned: %d\n",
88 ret);
89 } else {
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +030090 put_page(page);
Mike Marshall5db11c22015-07-17 10:38:12 -040091 }
92 }
93 BUG_ON(!list_empty(pages));
94 return 0;
95}
96
Yi Liu8bb8aef2015-11-24 15:12:14 -050097static void orangefs_invalidatepage(struct page *page,
Mike Marshall5db11c22015-07-17 10:38:12 -040098 unsigned int offset,
99 unsigned int length)
100{
101 gossip_debug(GOSSIP_INODE_DEBUG,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500102 "orangefs_invalidatepage called on page %p "
Mike Marshall5db11c22015-07-17 10:38:12 -0400103 "(offset is %u)\n",
104 page,
105 offset);
106
107 ClearPageUptodate(page);
108 ClearPageMappedToDisk(page);
109 return;
110
111}
112
Yi Liu8bb8aef2015-11-24 15:12:14 -0500113static int orangefs_releasepage(struct page *page, gfp_t foo)
Mike Marshall5db11c22015-07-17 10:38:12 -0400114{
115 gossip_debug(GOSSIP_INODE_DEBUG,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500116 "orangefs_releasepage called on page %p\n",
Mike Marshall5db11c22015-07-17 10:38:12 -0400117 page);
118 return 0;
119}
120
121/*
122 * Having a direct_IO entry point in the address_space_operations
123 * struct causes the kernel to allows us to use O_DIRECT on
124 * open. Nothing will ever call this thing, but in the future we
125 * will need to be able to use O_DIRECT on open in order to support
126 * AIO. Modeled after NFS, they do this too.
127 */
Mike Marshall3903f152016-06-09 15:38:03 -0400128
129static ssize_t orangefs_direct_IO(struct kiocb *iocb,
130 struct iov_iter *iter)
131{
132 gossip_debug(GOSSIP_INODE_DEBUG,
Al Virof66debf2016-08-07 12:20:01 -0400133 "orangefs_direct_IO: %pD\n",
134 iocb->ki_filp);
Mike Marshall3903f152016-06-09 15:38:03 -0400135
136 return -EINVAL;
137}
Mike Marshall5db11c22015-07-17 10:38:12 -0400138
Yi Liu8bb8aef2015-11-24 15:12:14 -0500139struct backing_dev_info orangefs_backing_dev_info = {
140 .name = "orangefs",
Mike Marshall5db11c22015-07-17 10:38:12 -0400141 .ra_pages = 0,
142 .capabilities = BDI_CAP_NO_ACCT_DIRTY | BDI_CAP_NO_WRITEBACK,
143};
144
Yi Liu8bb8aef2015-11-24 15:12:14 -0500145/** ORANGEFS2 implementation of address space operations */
146const struct address_space_operations orangefs_address_operations = {
147 .readpage = orangefs_readpage,
148 .readpages = orangefs_readpages,
149 .invalidatepage = orangefs_invalidatepage,
150 .releasepage = orangefs_releasepage,
Mike Marshall3903f152016-06-09 15:38:03 -0400151 .direct_IO = orangefs_direct_IO,
Mike Marshall5db11c22015-07-17 10:38:12 -0400152};
153
Yi Liu8bb8aef2015-11-24 15:12:14 -0500154static int orangefs_setattr_size(struct inode *inode, struct iattr *iattr)
Mike Marshall5db11c22015-07-17 10:38:12 -0400155{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500156 struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode);
157 struct orangefs_kernel_op_s *new_op;
Martin Brandenburgfecd86a2016-03-23 17:06:25 -0400158 loff_t orig_size;
Mike Marshall5db11c22015-07-17 10:38:12 -0400159 int ret = -EINVAL;
160
161 gossip_debug(GOSSIP_INODE_DEBUG,
162 "%s: %pU: Handle is %pU | fs_id %d | size is %llu\n",
163 __func__,
164 get_khandle_from_ino(inode),
Yi Liu8bb8aef2015-11-24 15:12:14 -0500165 &orangefs_inode->refn.khandle,
166 orangefs_inode->refn.fs_id,
Mike Marshall5db11c22015-07-17 10:38:12 -0400167 iattr->ia_size);
168
Martin Brandenburgfecd86a2016-03-23 17:06:25 -0400169 /* Ensure that we have a up to date size, so we know if it changed. */
170 ret = orangefs_inode_getattr(inode, 0, 1);
171 if (ret == -ESTALE)
172 ret = -EIO;
173 if (ret) {
174 gossip_err("%s: orangefs_inode_getattr failed, ret:%d:.\n",
175 __func__, ret);
176 return ret;
177 }
178 orig_size = i_size_read(inode);
179
Mike Marshall5db11c22015-07-17 10:38:12 -0400180 truncate_setsize(inode, iattr->ia_size);
181
Yi Liu8bb8aef2015-11-24 15:12:14 -0500182 new_op = op_alloc(ORANGEFS_VFS_OP_TRUNCATE);
Mike Marshall5db11c22015-07-17 10:38:12 -0400183 if (!new_op)
184 return -ENOMEM;
185
Yi Liu8bb8aef2015-11-24 15:12:14 -0500186 new_op->upcall.req.truncate.refn = orangefs_inode->refn;
Mike Marshall5db11c22015-07-17 10:38:12 -0400187 new_op->upcall.req.truncate.size = (__s64) iattr->ia_size;
188
189 ret = service_operation(new_op, __func__,
190 get_interruptible_flag(inode));
191
192 /*
193 * the truncate has no downcall members to retrieve, but
194 * the status value tells us if it went through ok or not
195 */
196 gossip_debug(GOSSIP_INODE_DEBUG,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500197 "orangefs: orangefs_truncate got return value of %d\n",
Mike Marshall5db11c22015-07-17 10:38:12 -0400198 ret);
199
200 op_release(new_op);
201
202 if (ret != 0)
203 return ret;
204
Martin Brandenburgf83140c2016-04-04 16:26:36 -0400205 if (orig_size != i_size_read(inode))
Mike Marshall5db11c22015-07-17 10:38:12 -0400206 iattr->ia_valid |= ATTR_CTIME | ATTR_MTIME;
Mike Marshall5db11c22015-07-17 10:38:12 -0400207
208 return ret;
209}
210
211/*
212 * Change attributes of an object referenced by dentry.
213 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500214int orangefs_setattr(struct dentry *dentry, struct iattr *iattr)
Mike Marshall5db11c22015-07-17 10:38:12 -0400215{
216 int ret = -EINVAL;
217 struct inode *inode = dentry->d_inode;
218
219 gossip_debug(GOSSIP_INODE_DEBUG,
Al Virof66debf2016-08-07 12:20:01 -0400220 "orangefs_setattr: called on %pd\n",
221 dentry);
Mike Marshall5db11c22015-07-17 10:38:12 -0400222
Jan Kara31051c82016-05-26 16:55:18 +0200223 ret = setattr_prepare(dentry, iattr);
Mike Marshall5db11c22015-07-17 10:38:12 -0400224 if (ret)
225 goto out;
226
227 if ((iattr->ia_valid & ATTR_SIZE) &&
228 iattr->ia_size != i_size_read(inode)) {
Yi Liu8bb8aef2015-11-24 15:12:14 -0500229 ret = orangefs_setattr_size(inode, iattr);
Mike Marshall5db11c22015-07-17 10:38:12 -0400230 if (ret)
231 goto out;
232 }
233
234 setattr_copy(inode, iattr);
235 mark_inode_dirty(inode);
236
Yi Liu8bb8aef2015-11-24 15:12:14 -0500237 ret = orangefs_inode_setattr(inode, iattr);
Mike Marshall5db11c22015-07-17 10:38:12 -0400238 gossip_debug(GOSSIP_INODE_DEBUG,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500239 "orangefs_setattr: inode_setattr returned %d\n",
Mike Marshall5db11c22015-07-17 10:38:12 -0400240 ret);
241
242 if (!ret && (iattr->ia_valid & ATTR_MODE))
243 /* change mod on a file that has ACLs */
244 ret = posix_acl_chmod(inode, inode->i_mode);
245
246out:
Yi Liu8bb8aef2015-11-24 15:12:14 -0500247 gossip_debug(GOSSIP_INODE_DEBUG, "orangefs_setattr: returning %d\n", ret);
Mike Marshall5db11c22015-07-17 10:38:12 -0400248 return ret;
249}
250
251/*
252 * Obtain attributes of an object given a dentry
253 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500254int orangefs_getattr(struct vfsmount *mnt,
Mike Marshall5db11c22015-07-17 10:38:12 -0400255 struct dentry *dentry,
256 struct kstat *kstat)
257{
258 int ret = -ENOENT;
259 struct inode *inode = dentry->d_inode;
Yi Liu8bb8aef2015-11-24 15:12:14 -0500260 struct orangefs_inode_s *orangefs_inode = NULL;
Mike Marshall5db11c22015-07-17 10:38:12 -0400261
262 gossip_debug(GOSSIP_INODE_DEBUG,
Al Virof66debf2016-08-07 12:20:01 -0400263 "orangefs_getattr: called on %pd\n",
264 dentry);
Mike Marshall5db11c22015-07-17 10:38:12 -0400265
Martin Brandenburg71680c12016-06-09 16:32:38 -0400266 ret = orangefs_inode_getattr(inode, 0, 0);
Mike Marshall5db11c22015-07-17 10:38:12 -0400267 if (ret == 0) {
268 generic_fillattr(inode, kstat);
Mike Marshalla7d3e782016-03-14 15:30:03 -0400269
Mike Marshall5db11c22015-07-17 10:38:12 -0400270 /* override block size reported to stat */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500271 orangefs_inode = ORANGEFS_I(inode);
272 kstat->blksize = orangefs_inode->blksize;
Mike Marshall5db11c22015-07-17 10:38:12 -0400273 }
274 return ret;
275}
276
Martin Brandenburg933287d2016-01-30 13:46:54 -0500277int orangefs_permission(struct inode *inode, int mask)
278{
279 int ret;
280
281 if (mask & MAY_NOT_BLOCK)
282 return -ECHILD;
283
284 gossip_debug(GOSSIP_INODE_DEBUG, "%s: refreshing\n", __func__);
285
286 /* Make sure the permission (and other common attrs) are up to date. */
Martin Brandenburg8f249282016-03-15 12:36:29 -0400287 ret = orangefs_inode_getattr(inode, 0, 0);
Martin Brandenburg933287d2016-01-30 13:46:54 -0500288 if (ret < 0)
289 return ret;
290
291 return generic_permission(inode, mask);
292}
293
Yi Liu8bb8aef2015-11-24 15:12:14 -0500294/* ORANGEDS2 implementation of VFS inode operations for files */
Al Viro6f3fc102016-05-14 18:46:32 -0400295const struct inode_operations orangefs_file_inode_operations = {
Yi Liu8bb8aef2015-11-24 15:12:14 -0500296 .get_acl = orangefs_get_acl,
297 .set_acl = orangefs_set_acl,
298 .setattr = orangefs_setattr,
299 .getattr = orangefs_getattr,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500300 .listxattr = orangefs_listxattr,
Martin Brandenburg933287d2016-01-30 13:46:54 -0500301 .permission = orangefs_permission,
Mike Marshall5db11c22015-07-17 10:38:12 -0400302};
303
Yi Liu8bb8aef2015-11-24 15:12:14 -0500304static int orangefs_init_iops(struct inode *inode)
Mike Marshall5db11c22015-07-17 10:38:12 -0400305{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500306 inode->i_mapping->a_ops = &orangefs_address_operations;
Mike Marshall5db11c22015-07-17 10:38:12 -0400307
308 switch (inode->i_mode & S_IFMT) {
309 case S_IFREG:
Yi Liu8bb8aef2015-11-24 15:12:14 -0500310 inode->i_op = &orangefs_file_inode_operations;
311 inode->i_fop = &orangefs_file_operations;
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +0300312 inode->i_blkbits = PAGE_SHIFT;
Mike Marshall5db11c22015-07-17 10:38:12 -0400313 break;
314 case S_IFLNK:
Yi Liu8bb8aef2015-11-24 15:12:14 -0500315 inode->i_op = &orangefs_symlink_inode_operations;
Mike Marshall5db11c22015-07-17 10:38:12 -0400316 break;
317 case S_IFDIR:
Yi Liu8bb8aef2015-11-24 15:12:14 -0500318 inode->i_op = &orangefs_dir_inode_operations;
319 inode->i_fop = &orangefs_dir_operations;
Mike Marshall5db11c22015-07-17 10:38:12 -0400320 break;
321 default:
322 gossip_debug(GOSSIP_INODE_DEBUG,
323 "%s: unsupported mode\n",
324 __func__);
325 return -EINVAL;
326 }
327
328 return 0;
329}
330
331/*
Yi Liu8bb8aef2015-11-24 15:12:14 -0500332 * Given a ORANGEFS object identifier (fsid, handle), convert it into a ino_t type
Mike Marshall5db11c22015-07-17 10:38:12 -0400333 * that will be used as a hash-index from where the handle will
334 * be searched for in the VFS hash table of inodes.
335 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500336static inline ino_t orangefs_handle_hash(struct orangefs_object_kref *ref)
Mike Marshall5db11c22015-07-17 10:38:12 -0400337{
338 if (!ref)
339 return 0;
Yi Liu8bb8aef2015-11-24 15:12:14 -0500340 return orangefs_khandle_to_ino(&(ref->khandle));
Mike Marshall5db11c22015-07-17 10:38:12 -0400341}
342
343/*
344 * Called to set up an inode from iget5_locked.
345 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500346static int orangefs_set_inode(struct inode *inode, void *data)
Mike Marshall5db11c22015-07-17 10:38:12 -0400347{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500348 struct orangefs_object_kref *ref = (struct orangefs_object_kref *) data;
Martin Brandenburga4c680a2016-03-16 14:35:21 -0400349 ORANGEFS_I(inode)->refn.fs_id = ref->fs_id;
350 ORANGEFS_I(inode)->refn.khandle = ref->khandle;
Mike Marshall5db11c22015-07-17 10:38:12 -0400351 return 0;
352}
353
354/*
355 * Called to determine if handles match.
356 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500357static int orangefs_test_inode(struct inode *inode, void *data)
Mike Marshall5db11c22015-07-17 10:38:12 -0400358{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500359 struct orangefs_object_kref *ref = (struct orangefs_object_kref *) data;
360 struct orangefs_inode_s *orangefs_inode = NULL;
Mike Marshall5db11c22015-07-17 10:38:12 -0400361
Yi Liu8bb8aef2015-11-24 15:12:14 -0500362 orangefs_inode = ORANGEFS_I(inode);
363 return (!ORANGEFS_khandle_cmp(&(orangefs_inode->refn.khandle), &(ref->khandle))
364 && orangefs_inode->refn.fs_id == ref->fs_id);
Mike Marshall5db11c22015-07-17 10:38:12 -0400365}
366
367/*
Yi Liu8bb8aef2015-11-24 15:12:14 -0500368 * Front-end to lookup the inode-cache maintained by the VFS using the ORANGEFS
Mike Marshall5db11c22015-07-17 10:38:12 -0400369 * file handle.
370 *
371 * @sb: the file system super block instance.
Yi Liu8bb8aef2015-11-24 15:12:14 -0500372 * @ref: The ORANGEFS object for which we are trying to locate an inode structure.
Mike Marshall5db11c22015-07-17 10:38:12 -0400373 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500374struct inode *orangefs_iget(struct super_block *sb, struct orangefs_object_kref *ref)
Mike Marshall5db11c22015-07-17 10:38:12 -0400375{
376 struct inode *inode = NULL;
377 unsigned long hash;
378 int error;
379
Yi Liu8bb8aef2015-11-24 15:12:14 -0500380 hash = orangefs_handle_hash(ref);
381 inode = iget5_locked(sb, hash, orangefs_test_inode, orangefs_set_inode, ref);
Mike Marshall5db11c22015-07-17 10:38:12 -0400382 if (!inode || !(inode->i_state & I_NEW))
383 return inode;
384
Martin Brandenburg71680c12016-06-09 16:32:38 -0400385 error = orangefs_inode_getattr(inode, 1, 1);
Mike Marshall5db11c22015-07-17 10:38:12 -0400386 if (error) {
387 iget_failed(inode);
388 return ERR_PTR(error);
389 }
390
391 inode->i_ino = hash; /* needed for stat etc */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500392 orangefs_init_iops(inode);
Mike Marshall5db11c22015-07-17 10:38:12 -0400393 unlock_new_inode(inode);
394
395 gossip_debug(GOSSIP_INODE_DEBUG,
396 "iget handle %pU, fsid %d hash %ld i_ino %lu\n",
397 &ref->khandle,
398 ref->fs_id,
399 hash,
400 inode->i_ino);
401
402 return inode;
403}
404
405/*
406 * Allocate an inode for a newly created file and insert it into the inode hash.
407 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500408struct inode *orangefs_new_inode(struct super_block *sb, struct inode *dir,
409 int mode, dev_t dev, struct orangefs_object_kref *ref)
Mike Marshall5db11c22015-07-17 10:38:12 -0400410{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500411 unsigned long hash = orangefs_handle_hash(ref);
Mike Marshall5db11c22015-07-17 10:38:12 -0400412 struct inode *inode;
413 int error;
414
415 gossip_debug(GOSSIP_INODE_DEBUG,
Mike Marshall52534872016-02-16 17:09:09 -0500416 "%s:(sb is %p | MAJOR(dev)=%u | MINOR(dev)=%u mode=%o)\n",
417 __func__,
Mike Marshall5db11c22015-07-17 10:38:12 -0400418 sb,
419 MAJOR(dev),
420 MINOR(dev),
421 mode);
422
423 inode = new_inode(sb);
424 if (!inode)
425 return NULL;
426
Yi Liu8bb8aef2015-11-24 15:12:14 -0500427 orangefs_set_inode(inode, ref);
Mike Marshall5db11c22015-07-17 10:38:12 -0400428 inode->i_ino = hash; /* needed for stat etc */
429
Martin Brandenburg71680c12016-06-09 16:32:38 -0400430 error = orangefs_inode_getattr(inode, 1, 1);
Mike Marshall5db11c22015-07-17 10:38:12 -0400431 if (error)
432 goto out_iput;
433
Yi Liu8bb8aef2015-11-24 15:12:14 -0500434 orangefs_init_iops(inode);
Mike Marshall5db11c22015-07-17 10:38:12 -0400435
436 inode->i_mode = mode;
437 inode->i_uid = current_fsuid();
438 inode->i_gid = current_fsgid();
Deepa Dinamani078cd822016-09-14 07:48:04 -0700439 inode->i_atime = inode->i_mtime = inode->i_ctime = current_time(inode);
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +0300440 inode->i_size = PAGE_SIZE;
Mike Marshall5db11c22015-07-17 10:38:12 -0400441 inode->i_rdev = dev;
442
Yi Liu8bb8aef2015-11-24 15:12:14 -0500443 error = insert_inode_locked4(inode, hash, orangefs_test_inode, ref);
Mike Marshall5db11c22015-07-17 10:38:12 -0400444 if (error < 0)
445 goto out_iput;
446
447 gossip_debug(GOSSIP_INODE_DEBUG,
448 "Initializing ACL's for inode %pU\n",
449 get_khandle_from_ino(inode));
Yi Liu8bb8aef2015-11-24 15:12:14 -0500450 orangefs_init_acl(inode, dir);
Mike Marshall5db11c22015-07-17 10:38:12 -0400451 return inode;
452
453out_iput:
454 iput(inode);
455 return ERR_PTR(error);
456}