blob: 9f6734ce1873c8143664d08a9342bd807fe1fd3a [file] [log] [blame]
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +00001/*
2 * Copyright (C) 2011 Google, Inc.
3 * Copyright (C) 2012 Intel, Inc.
4 * Copyright (C) 2013 Intel, Inc.
5 *
6 * This software is licensed under the terms of the GNU General Public
7 * License version 2, as published by the Free Software Foundation, and
8 * may be copied, distributed, and modified under those terms.
9 *
10 * This program is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
14 *
15 */
16
17/* This source file contains the implementation of a special device driver
18 * that intends to provide a *very* fast communication channel between the
19 * guest system and the QEMU emulator.
20 *
21 * Usage from the guest is simply the following (error handling simplified):
22 *
23 * int fd = open("/dev/qemu_pipe",O_RDWR);
24 * .... write() or read() through the pipe.
25 *
26 * This driver doesn't deal with the exact protocol used during the session.
27 * It is intended to be as simple as something like:
28 *
29 * // do this _just_ after opening the fd to connect to a specific
30 * // emulator service.
31 * const char* msg = "<pipename>";
32 * if (write(fd, msg, strlen(msg)+1) < 0) {
33 * ... could not connect to <pipename> service
34 * close(fd);
35 * }
36 *
37 * // after this, simply read() and write() to communicate with the
38 * // service. Exact protocol details left as an exercise to the reader.
39 *
40 * This driver is very fast because it doesn't copy any data through
41 * intermediate buffers, since the emulator is capable of translating
42 * guest user addresses into host ones.
43 *
44 * Note that we must however ensure that each user page involved in the
45 * exchange is properly mapped during a transfer.
46 */
47
48#include <linux/module.h>
49#include <linux/interrupt.h>
50#include <linux/kernel.h>
51#include <linux/spinlock.h>
52#include <linux/miscdevice.h>
53#include <linux/platform_device.h>
54#include <linux/poll.h>
55#include <linux/sched.h>
56#include <linux/bitops.h>
57#include <linux/slab.h>
58#include <linux/io.h>
Alana99698f2014-05-12 16:57:22 +010059#include <linux/goldfish.h>
Shraddha Barke1d427da2016-02-12 16:11:54 +053060#include <linux/dma-mapping.h>
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +000061
62/*
63 * IMPORTANT: The following constants must match the ones used and defined
64 * in external/qemu/hw/goldfish_pipe.c in the Android source tree.
65 */
66
67/* pipe device registers */
68#define PIPE_REG_COMMAND 0x00 /* write: value = command */
69#define PIPE_REG_STATUS 0x04 /* read */
70#define PIPE_REG_CHANNEL 0x08 /* read/write: channel id */
Jun Tian49a75c42014-05-12 16:54:46 +010071#define PIPE_REG_CHANNEL_HIGH 0x30 /* read/write: channel id */
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +000072#define PIPE_REG_SIZE 0x0c /* read/write: buffer size */
73#define PIPE_REG_ADDRESS 0x10 /* write: physical address */
Jun Tian49a75c42014-05-12 16:54:46 +010074#define PIPE_REG_ADDRESS_HIGH 0x34 /* write: physical address */
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +000075#define PIPE_REG_WAKES 0x14 /* read: wake flags */
76#define PIPE_REG_PARAMS_ADDR_LOW 0x18 /* read/write: batch data address */
77#define PIPE_REG_PARAMS_ADDR_HIGH 0x1c /* read/write: batch data address */
78#define PIPE_REG_ACCESS_PARAMS 0x20 /* write: batch access */
79
80/* list of commands for PIPE_REG_COMMAND */
81#define CMD_OPEN 1 /* open new channel */
82#define CMD_CLOSE 2 /* close channel (from guest) */
83#define CMD_POLL 3 /* poll read/write status */
84
85/* List of bitflags returned in status of CMD_POLL command */
86#define PIPE_POLL_IN (1 << 0)
87#define PIPE_POLL_OUT (1 << 1)
88#define PIPE_POLL_HUP (1 << 2)
89
90/* The following commands are related to write operations */
91#define CMD_WRITE_BUFFER 4 /* send a user buffer to the emulator */
92#define CMD_WAKE_ON_WRITE 5 /* tell the emulator to wake us when writing
93 is possible */
94
95/* The following commands are related to read operations, they must be
96 * listed in the same order than the corresponding write ones, since we
97 * will use (CMD_READ_BUFFER - CMD_WRITE_BUFFER) as a special offset
98 * in goldfish_pipe_read_write() below.
99 */
100#define CMD_READ_BUFFER 6 /* receive a user buffer from the emulator */
101#define CMD_WAKE_ON_READ 7 /* tell the emulator to wake us when reading
102 * is possible */
103
104/* Possible status values used to signal errors - see goldfish_pipe_error_convert */
105#define PIPE_ERROR_INVAL -1
106#define PIPE_ERROR_AGAIN -2
107#define PIPE_ERROR_NOMEM -3
108#define PIPE_ERROR_IO -4
109
110/* Bit-flags used to signal events from the emulator */
111#define PIPE_WAKE_CLOSED (1 << 0) /* emulator closed pipe */
112#define PIPE_WAKE_READ (1 << 1) /* pipe can now be read from */
113#define PIPE_WAKE_WRITE (1 << 2) /* pipe can now be written to */
114
115struct access_params {
Jun Tian49a75c42014-05-12 16:54:46 +0100116 unsigned long channel;
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000117 u32 size;
Jun Tian49a75c42014-05-12 16:54:46 +0100118 unsigned long address;
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000119 u32 cmd;
120 u32 result;
121 /* reserved for future extension */
122 u32 flags;
123};
124
125/* The global driver data. Holds a reference to the i/o page used to
126 * communicate with the emulator, and a wake queue for blocked tasks
127 * waiting to be awoken.
128 */
129struct goldfish_pipe_dev {
130 spinlock_t lock;
131 unsigned char __iomem *base;
132 struct access_params *aps;
133 int irq;
134};
135
136static struct goldfish_pipe_dev pipe_dev[1];
137
138/* This data type models a given pipe instance */
139struct goldfish_pipe {
140 struct goldfish_pipe_dev *dev;
141 struct mutex lock;
142 unsigned long flags;
143 wait_queue_head_t wake_queue;
144};
145
146
147/* Bit flags for the 'flags' field */
148enum {
149 BIT_CLOSED_ON_HOST = 0, /* pipe closed by host */
150 BIT_WAKE_ON_WRITE = 1, /* want to be woken on writes */
151 BIT_WAKE_ON_READ = 2, /* want to be woken on reads */
152};
153
154
155static u32 goldfish_cmd_status(struct goldfish_pipe *pipe, u32 cmd)
Alana99698f2014-05-12 16:57:22 +0100156{
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000157 unsigned long flags;
158 u32 status;
159 struct goldfish_pipe_dev *dev = pipe->dev;
160
161 spin_lock_irqsave(&dev->lock, flags);
Peter Senna Tschudin07d783f2015-05-19 11:44:46 +0200162 gf_write_ptr(pipe, dev->base + PIPE_REG_CHANNEL,
163 dev->base + PIPE_REG_CHANNEL_HIGH);
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000164 writel(cmd, dev->base + PIPE_REG_COMMAND);
165 status = readl(dev->base + PIPE_REG_STATUS);
166 spin_unlock_irqrestore(&dev->lock, flags);
167 return status;
168}
169
170static void goldfish_cmd(struct goldfish_pipe *pipe, u32 cmd)
Alana99698f2014-05-12 16:57:22 +0100171{
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000172 unsigned long flags;
173 struct goldfish_pipe_dev *dev = pipe->dev;
174
175 spin_lock_irqsave(&dev->lock, flags);
Peter Senna Tschudin07d783f2015-05-19 11:44:46 +0200176 gf_write_ptr(pipe, dev->base + PIPE_REG_CHANNEL,
177 dev->base + PIPE_REG_CHANNEL_HIGH);
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000178 writel(cmd, dev->base + PIPE_REG_COMMAND);
179 spin_unlock_irqrestore(&dev->lock, flags);
180}
181
182/* This function converts an error code returned by the emulator through
183 * the PIPE_REG_STATUS i/o register into a valid negative errno value.
184 */
185static int goldfish_pipe_error_convert(int status)
186{
187 switch (status) {
188 case PIPE_ERROR_AGAIN:
189 return -EAGAIN;
190 case PIPE_ERROR_NOMEM:
191 return -ENOMEM;
192 case PIPE_ERROR_IO:
193 return -EIO;
194 default:
195 return -EINVAL;
196 }
197}
198
199/*
200 * Notice: QEMU will return 0 for un-known register access, indicating
201 * param_acess is supported or not
202 */
203static int valid_batchbuffer_addr(struct goldfish_pipe_dev *dev,
204 struct access_params *aps)
205{
206 u32 aph, apl;
207 u64 paddr;
208 aph = readl(dev->base + PIPE_REG_PARAMS_ADDR_HIGH);
209 apl = readl(dev->base + PIPE_REG_PARAMS_ADDR_LOW);
210
211 paddr = ((u64)aph << 32) | apl;
212 if (paddr != (__pa(aps)))
213 return 0;
214 return 1;
215}
216
217/* 0 on success */
218static int setup_access_params_addr(struct platform_device *pdev,
219 struct goldfish_pipe_dev *dev)
220{
Shraddha Barke1d427da2016-02-12 16:11:54 +0530221 dma_addr_t dma_handle;
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000222 struct access_params *aps;
223
Shraddha Barke1d427da2016-02-12 16:11:54 +0530224 aps = dmam_alloc_coherent(&pdev->dev, sizeof(struct access_params),
225 &dma_handle, GFP_KERNEL);
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000226 if (!aps)
Shraddha Barke1d427da2016-02-12 16:11:54 +0530227 return -ENOMEM;
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000228
Shraddha Barke1d427da2016-02-12 16:11:54 +0530229 writel(upper_32_bits(dma_handle), dev->base + PIPE_REG_PARAMS_ADDR_HIGH);
230 writel(lower_32_bits(dma_handle), dev->base + PIPE_REG_PARAMS_ADDR_LOW);
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000231
232 if (valid_batchbuffer_addr(dev, aps)) {
233 dev->aps = aps;
234 return 0;
235 } else
236 return -1;
237}
238
239/* A value that will not be set by qemu emulator */
240#define INITIAL_BATCH_RESULT (0xdeadbeaf)
241static int access_with_param(struct goldfish_pipe_dev *dev, const int cmd,
242 unsigned long address, unsigned long avail,
243 struct goldfish_pipe *pipe, int *status)
244{
245 struct access_params *aps = dev->aps;
246
247 if (aps == NULL)
248 return -1;
249
250 aps->result = INITIAL_BATCH_RESULT;
251 aps->channel = (unsigned long)pipe;
252 aps->size = avail;
253 aps->address = address;
254 aps->cmd = cmd;
255 writel(cmd, dev->base + PIPE_REG_ACCESS_PARAMS);
256 /*
257 * If the aps->result has not changed, that means
258 * that the batch command failed
259 */
260 if (aps->result == INITIAL_BATCH_RESULT)
261 return -1;
262 *status = aps->result;
263 return 0;
264}
265
266/* This function is used for both reading from and writing to a given
267 * pipe.
268 */
269static ssize_t goldfish_pipe_read_write(struct file *filp, char __user *buffer,
270 size_t bufflen, int is_write)
271{
272 unsigned long irq_flags;
273 struct goldfish_pipe *pipe = filp->private_data;
274 struct goldfish_pipe_dev *dev = pipe->dev;
275 const int cmd_offset = is_write ? 0
276 : (CMD_READ_BUFFER - CMD_WRITE_BUFFER);
277 unsigned long address, address_end;
278 int ret = 0;
279
280 /* If the emulator already closed the pipe, no need to go further */
281 if (test_bit(BIT_CLOSED_ON_HOST, &pipe->flags))
282 return -EIO;
283
284 /* Null reads or writes succeeds */
Joe Perches3411d032015-04-10 16:47:35 -0700285 if (unlikely(bufflen == 0))
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000286 return 0;
287
288 /* Check the buffer range for access */
289 if (!access_ok(is_write ? VERIFY_WRITE : VERIFY_READ,
290 buffer, bufflen))
291 return -EFAULT;
292
293 /* Serialize access to the pipe */
294 if (mutex_lock_interruptible(&pipe->lock))
295 return -ERESTARTSYS;
296
297 address = (unsigned long)(void *)buffer;
298 address_end = address + bufflen;
299
300 while (address < address_end) {
301 unsigned long page_end = (address & PAGE_MASK) + PAGE_SIZE;
302 unsigned long next = page_end < address_end ? page_end
303 : address_end;
304 unsigned long avail = next - address;
305 int status, wakeBit;
306
307 /* Ensure that the corresponding page is properly mapped */
Alan Cox17c4c9d2013-01-23 14:13:18 +0000308 /* FIXME: this isn't safe or sufficient - use get_user_pages */
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000309 if (is_write) {
310 char c;
311 /* Ensure that the page is mapped and readable */
312 if (__get_user(c, (char __user *)address)) {
313 if (!ret)
314 ret = -EFAULT;
315 break;
316 }
317 } else {
318 /* Ensure that the page is mapped and writable */
319 if (__put_user(0, (char __user *)address)) {
320 if (!ret)
321 ret = -EFAULT;
322 break;
323 }
324 }
325
326 /* Now, try to transfer the bytes in the current page */
327 spin_lock_irqsave(&dev->lock, irq_flags);
328 if (access_with_param(dev, CMD_WRITE_BUFFER + cmd_offset,
329 address, avail, pipe, &status)) {
Peter Senna Tschudin07d783f2015-05-19 11:44:46 +0200330 gf_write_ptr(pipe, dev->base + PIPE_REG_CHANNEL,
331 dev->base + PIPE_REG_CHANNEL_HIGH);
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000332 writel(avail, dev->base + PIPE_REG_SIZE);
Peter Senna Tschudin07d783f2015-05-19 11:44:46 +0200333 gf_write_ptr((void *)address,
334 dev->base + PIPE_REG_ADDRESS,
335 dev->base + PIPE_REG_ADDRESS_HIGH);
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000336 writel(CMD_WRITE_BUFFER + cmd_offset,
337 dev->base + PIPE_REG_COMMAND);
338 status = readl(dev->base + PIPE_REG_STATUS);
339 }
340 spin_unlock_irqrestore(&dev->lock, irq_flags);
341
342 if (status > 0) { /* Correct transfer */
343 ret += status;
344 address += status;
345 continue;
346 }
347
348 if (status == 0) /* EOF */
349 break;
350
351 /* An error occured. If we already transfered stuff, just
352 * return with its count. We expect the next call to return
353 * an error code */
354 if (ret > 0)
355 break;
356
357 /* If the error is not PIPE_ERROR_AGAIN, or if we are not in
358 * non-blocking mode, just return the error code.
359 */
360 if (status != PIPE_ERROR_AGAIN ||
361 (filp->f_flags & O_NONBLOCK) != 0) {
362 ret = goldfish_pipe_error_convert(status);
363 break;
364 }
365
366 /* We will have to wait until more data/space is available.
367 * First, mark the pipe as waiting for a specific wake signal.
368 */
369 wakeBit = is_write ? BIT_WAKE_ON_WRITE : BIT_WAKE_ON_READ;
370 set_bit(wakeBit, &pipe->flags);
371
372 /* Tell the emulator we're going to wait for a wake event */
373 goldfish_cmd(pipe, CMD_WAKE_ON_WRITE + cmd_offset);
374
375 /* Unlock the pipe, then wait for the wake signal */
376 mutex_unlock(&pipe->lock);
377
378 while (test_bit(wakeBit, &pipe->flags)) {
379 if (wait_event_interruptible(
380 pipe->wake_queue,
381 !test_bit(wakeBit, &pipe->flags)))
382 return -ERESTARTSYS;
383
384 if (test_bit(BIT_CLOSED_ON_HOST, &pipe->flags))
385 return -EIO;
386 }
387
388 /* Try to re-acquire the lock */
389 if (mutex_lock_interruptible(&pipe->lock))
390 return -ERESTARTSYS;
391
392 /* Try the transfer again */
393 continue;
394 }
395 mutex_unlock(&pipe->lock);
396 return ret;
397}
398
399static ssize_t goldfish_pipe_read(struct file *filp, char __user *buffer,
400 size_t bufflen, loff_t *ppos)
401{
402 return goldfish_pipe_read_write(filp, buffer, bufflen, 0);
403}
404
405static ssize_t goldfish_pipe_write(struct file *filp,
406 const char __user *buffer, size_t bufflen,
407 loff_t *ppos)
408{
409 return goldfish_pipe_read_write(filp, (char __user *)buffer,
410 bufflen, 1);
411}
412
413
414static unsigned int goldfish_pipe_poll(struct file *filp, poll_table *wait)
415{
416 struct goldfish_pipe *pipe = filp->private_data;
417 unsigned int mask = 0;
418 int status;
419
420 mutex_lock(&pipe->lock);
421
422 poll_wait(filp, &pipe->wake_queue, wait);
423
424 status = goldfish_cmd_status(pipe, CMD_POLL);
425
426 mutex_unlock(&pipe->lock);
427
428 if (status & PIPE_POLL_IN)
429 mask |= POLLIN | POLLRDNORM;
430
431 if (status & PIPE_POLL_OUT)
432 mask |= POLLOUT | POLLWRNORM;
433
434 if (status & PIPE_POLL_HUP)
435 mask |= POLLHUP;
436
437 if (test_bit(BIT_CLOSED_ON_HOST, &pipe->flags))
438 mask |= POLLERR;
439
440 return mask;
441}
442
443static irqreturn_t goldfish_pipe_interrupt(int irq, void *dev_id)
444{
445 struct goldfish_pipe_dev *dev = dev_id;
446 unsigned long irq_flags;
447 int count = 0;
448
449 /* We're going to read from the emulator a list of (channel,flags)
450 * pairs corresponding to the wake events that occured on each
451 * blocked pipe (i.e. channel).
452 */
453 spin_lock_irqsave(&dev->lock, irq_flags);
454 for (;;) {
455 /* First read the channel, 0 means the end of the list */
456 struct goldfish_pipe *pipe;
457 unsigned long wakes;
Jun Tian49a75c42014-05-12 16:54:46 +0100458 unsigned long channel = 0;
459
460#ifdef CONFIG_64BIT
461 channel = (u64)readl(dev->base + PIPE_REG_CHANNEL_HIGH) << 32;
Jun Tian25c72c72014-05-12 16:54:57 +0100462
463 if (channel == 0)
464 break;
Jun Tian49a75c42014-05-12 16:54:46 +0100465#endif
466 channel |= readl(dev->base + PIPE_REG_CHANNEL);
David 'Digit' Turnerc89f2752013-01-21 23:48:21 +0000467
468 if (channel == 0)
469 break;
470
471 /* Convert channel to struct pipe pointer + read wake flags */
472 wakes = readl(dev->base + PIPE_REG_WAKES);
473 pipe = (struct goldfish_pipe *)(ptrdiff_t)channel;
474
475 /* Did the emulator just closed a pipe? */
476 if (wakes & PIPE_WAKE_CLOSED) {
477 set_bit(BIT_CLOSED_ON_HOST, &pipe->flags);
478 wakes |= PIPE_WAKE_READ | PIPE_WAKE_WRITE;
479 }
480 if (wakes & PIPE_WAKE_READ)
481 clear_bit(BIT_WAKE_ON_READ, &pipe->flags);
482 if (wakes & PIPE_WAKE_WRITE)
483 clear_bit(BIT_WAKE_ON_WRITE, &pipe->flags);
484
485 wake_up_interruptible(&pipe->wake_queue);
486 count++;
487 }
488 spin_unlock_irqrestore(&dev->lock, irq_flags);
489
490 return (count == 0) ? IRQ_NONE : IRQ_HANDLED;
491}
492
493/**
494 * goldfish_pipe_open - open a channel to the AVD
495 * @inode: inode of device
496 * @file: file struct of opener
497 *
498 * Create a new pipe link between the emulator and the use application.
499 * Each new request produces a new pipe.
500 *
501 * Note: we use the pipe ID as a mux. All goldfish emulations are 32bit
502 * right now so this is fine. A move to 64bit will need this addressing
503 */
504static int goldfish_pipe_open(struct inode *inode, struct file *file)
505{
506 struct goldfish_pipe *pipe;
507 struct goldfish_pipe_dev *dev = pipe_dev;
508 int32_t status;
509
510 /* Allocate new pipe kernel object */
511 pipe = kzalloc(sizeof(*pipe), GFP_KERNEL);
512 if (pipe == NULL)
513 return -ENOMEM;
514
515 pipe->dev = dev;
516 mutex_init(&pipe->lock);
517 init_waitqueue_head(&pipe->wake_queue);
518
519 /*
520 * Now, tell the emulator we're opening a new pipe. We use the
521 * pipe object's address as the channel identifier for simplicity.
522 */
523
524 status = goldfish_cmd_status(pipe, CMD_OPEN);
525 if (status < 0) {
526 kfree(pipe);
527 return status;
528 }
529
530 /* All is done, save the pipe into the file's private data field */
531 file->private_data = pipe;
532 return 0;
533}
534
535static int goldfish_pipe_release(struct inode *inode, struct file *filp)
536{
537 struct goldfish_pipe *pipe = filp->private_data;
538
539 /* The guest is closing the channel, so tell the emulator right now */
540 goldfish_cmd(pipe, CMD_CLOSE);
541 kfree(pipe);
542 filp->private_data = NULL;
543 return 0;
544}
545
546static const struct file_operations goldfish_pipe_fops = {
547 .owner = THIS_MODULE,
548 .read = goldfish_pipe_read,
549 .write = goldfish_pipe_write,
550 .poll = goldfish_pipe_poll,
551 .open = goldfish_pipe_open,
552 .release = goldfish_pipe_release,
553};
554
555static struct miscdevice goldfish_pipe_device = {
556 .minor = MISC_DYNAMIC_MINOR,
557 .name = "goldfish_pipe",
558 .fops = &goldfish_pipe_fops,
559};
560
561static int goldfish_pipe_probe(struct platform_device *pdev)
562{
563 int err;
564 struct resource *r;
565 struct goldfish_pipe_dev *dev = pipe_dev;
566
567 /* not thread safe, but this should not happen */
568 WARN_ON(dev->base != NULL);
569
570 spin_lock_init(&dev->lock);
571
572 r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
573 if (r == NULL || resource_size(r) < PAGE_SIZE) {
574 dev_err(&pdev->dev, "can't allocate i/o page\n");
575 return -EINVAL;
576 }
577 dev->base = devm_ioremap(&pdev->dev, r->start, PAGE_SIZE);
578 if (dev->base == NULL) {
579 dev_err(&pdev->dev, "ioremap failed\n");
580 return -EINVAL;
581 }
582
583 r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
584 if (r == NULL) {
585 err = -EINVAL;
586 goto error;
587 }
588 dev->irq = r->start;
589
590 err = devm_request_irq(&pdev->dev, dev->irq, goldfish_pipe_interrupt,
591 IRQF_SHARED, "goldfish_pipe", dev);
592 if (err) {
593 dev_err(&pdev->dev, "unable to allocate IRQ\n");
594 goto error;
595 }
596
597 err = misc_register(&goldfish_pipe_device);
598 if (err) {
599 dev_err(&pdev->dev, "unable to register device\n");
600 goto error;
601 }
602 setup_access_params_addr(pdev, dev);
603 return 0;
604
605error:
606 dev->base = NULL;
607 return err;
608}
609
610static int goldfish_pipe_remove(struct platform_device *pdev)
611{
612 struct goldfish_pipe_dev *dev = pipe_dev;
613 misc_deregister(&goldfish_pipe_device);
614 dev->base = NULL;
615 return 0;
616}
617
618static struct platform_driver goldfish_pipe = {
619 .probe = goldfish_pipe_probe,
620 .remove = goldfish_pipe_remove,
621 .driver = {
622 .name = "goldfish_pipe"
623 }
624};
625
626module_platform_driver(goldfish_pipe);
627MODULE_AUTHOR("David Turner <digit@google.com>");
628MODULE_LICENSE("GPL");