Greg Kroah-Hartman | b244131 | 2017-11-01 15:07:57 +0100 | [diff] [blame] | 1 | // SPDX-License-Identifier: GPL-2.0 |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 2 | /* |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 3 | * Memory subsystem support |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 4 | * |
| 5 | * Written by Matt Tolentino <matthew.e.tolentino@intel.com> |
| 6 | * Dave Hansen <haveblue@us.ibm.com> |
| 7 | * |
| 8 | * This file provides the necessary infrastructure to represent |
| 9 | * a SPARSEMEM-memory-model system's physical memory in /sysfs. |
| 10 | * All arch-independent code that assumes MEMORY_HOTPLUG requires |
| 11 | * SPARSEMEM should be contained here, or in mm/memory_hotplug.c. |
| 12 | */ |
| 13 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 14 | #include <linux/module.h> |
| 15 | #include <linux/init.h> |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 16 | #include <linux/topology.h> |
Randy.Dunlap | c59ede7 | 2006-01-11 12:17:46 -0800 | [diff] [blame] | 17 | #include <linux/capability.h> |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 18 | #include <linux/device.h> |
| 19 | #include <linux/memory.h> |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 20 | #include <linux/memory_hotplug.h> |
| 21 | #include <linux/mm.h> |
Daniel Walker | da19cbc | 2008-02-04 23:35:47 -0800 | [diff] [blame] | 22 | #include <linux/mutex.h> |
Shaohua Li | 9f1b16a | 2008-10-18 20:27:12 -0700 | [diff] [blame] | 23 | #include <linux/stat.h> |
Tejun Heo | 5a0e3ad | 2010-03-24 17:04:11 +0900 | [diff] [blame] | 24 | #include <linux/slab.h> |
Shaohua Li | 9f1b16a | 2008-10-18 20:27:12 -0700 | [diff] [blame] | 25 | |
Arun Sharma | 60063497 | 2011-07-26 16:09:06 -0700 | [diff] [blame] | 26 | #include <linux/atomic.h> |
Linus Torvalds | 7c0f6ba | 2016-12-24 11:46:01 -0800 | [diff] [blame] | 27 | #include <linux/uaccess.h> |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 28 | |
Nathan Fontenot | 2938ffb | 2010-10-19 12:45:24 -0500 | [diff] [blame] | 29 | static DEFINE_MUTEX(mem_sysfs_mutex); |
| 30 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 31 | #define MEMORY_CLASS_NAME "memory" |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 32 | |
Gu Zheng | 7315f0c | 2013-08-28 14:38:27 +0800 | [diff] [blame] | 33 | #define to_memory_block(dev) container_of(dev, struct memory_block, dev) |
| 34 | |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 35 | static int sections_per_block; |
| 36 | |
| 37 | static inline int base_memory_block_id(int section_nr) |
| 38 | { |
| 39 | return section_nr / sections_per_block; |
| 40 | } |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 41 | |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 42 | static int memory_subsys_online(struct device *dev); |
| 43 | static int memory_subsys_offline(struct device *dev); |
| 44 | |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 45 | static struct bus_type memory_subsys = { |
Kay Sievers | af5ca3f | 2007-12-20 02:09:39 +0100 | [diff] [blame] | 46 | .name = MEMORY_CLASS_NAME, |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 47 | .dev_name = MEMORY_CLASS_NAME, |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 48 | .online = memory_subsys_online, |
| 49 | .offline = memory_subsys_offline, |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 50 | }; |
| 51 | |
Alan Stern | e041c68 | 2006-03-27 01:16:30 -0800 | [diff] [blame] | 52 | static BLOCKING_NOTIFIER_HEAD(memory_chain); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 53 | |
Andy Whitcroft | 98a38eb | 2006-01-06 00:10:35 -0800 | [diff] [blame] | 54 | int register_memory_notifier(struct notifier_block *nb) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 55 | { |
Ioana Ciornei | 2aeebca | 2015-03-08 12:48:35 +0200 | [diff] [blame] | 56 | return blocking_notifier_chain_register(&memory_chain, nb); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 57 | } |
Hannes Hering | 3c82c30 | 2008-05-07 14:43:01 +0200 | [diff] [blame] | 58 | EXPORT_SYMBOL(register_memory_notifier); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 59 | |
Andy Whitcroft | 98a38eb | 2006-01-06 00:10:35 -0800 | [diff] [blame] | 60 | void unregister_memory_notifier(struct notifier_block *nb) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 61 | { |
Ioana Ciornei | 2aeebca | 2015-03-08 12:48:35 +0200 | [diff] [blame] | 62 | blocking_notifier_chain_unregister(&memory_chain, nb); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 63 | } |
Hannes Hering | 3c82c30 | 2008-05-07 14:43:01 +0200 | [diff] [blame] | 64 | EXPORT_SYMBOL(unregister_memory_notifier); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 65 | |
Robert Jennings | 925cc71 | 2009-12-17 14:44:38 +0000 | [diff] [blame] | 66 | static ATOMIC_NOTIFIER_HEAD(memory_isolate_chain); |
| 67 | |
| 68 | int register_memory_isolate_notifier(struct notifier_block *nb) |
| 69 | { |
| 70 | return atomic_notifier_chain_register(&memory_isolate_chain, nb); |
| 71 | } |
| 72 | EXPORT_SYMBOL(register_memory_isolate_notifier); |
| 73 | |
| 74 | void unregister_memory_isolate_notifier(struct notifier_block *nb) |
| 75 | { |
| 76 | atomic_notifier_chain_unregister(&memory_isolate_chain, nb); |
| 77 | } |
| 78 | EXPORT_SYMBOL(unregister_memory_isolate_notifier); |
| 79 | |
Yasuaki Ishimatsu | fa7194e | 2012-12-11 16:00:44 -0800 | [diff] [blame] | 80 | static void memory_block_release(struct device *dev) |
| 81 | { |
Gu Zheng | 7315f0c | 2013-08-28 14:38:27 +0800 | [diff] [blame] | 82 | struct memory_block *mem = to_memory_block(dev); |
Yasuaki Ishimatsu | fa7194e | 2012-12-11 16:00:44 -0800 | [diff] [blame] | 83 | |
| 84 | kfree(mem); |
| 85 | } |
| 86 | |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 87 | unsigned long __weak memory_block_size_bytes(void) |
| 88 | { |
| 89 | return MIN_MEMORY_BLOCK_SIZE; |
| 90 | } |
| 91 | |
| 92 | static unsigned long get_memory_block_size(void) |
| 93 | { |
| 94 | unsigned long block_sz; |
| 95 | |
| 96 | block_sz = memory_block_size_bytes(); |
| 97 | |
| 98 | /* Validate blk_sz is a power of 2 and not less than section size */ |
| 99 | if ((block_sz & (block_sz - 1)) || (block_sz < MIN_MEMORY_BLOCK_SIZE)) { |
| 100 | WARN_ON(1); |
| 101 | block_sz = MIN_MEMORY_BLOCK_SIZE; |
| 102 | } |
| 103 | |
| 104 | return block_sz; |
| 105 | } |
| 106 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 107 | /* |
| 108 | * use this as the physical section index that this memsection |
| 109 | * uses. |
| 110 | */ |
| 111 | |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 112 | static ssize_t show_mem_start_phys_index(struct device *dev, |
| 113 | struct device_attribute *attr, char *buf) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 114 | { |
Gu Zheng | 7315f0c | 2013-08-28 14:38:27 +0800 | [diff] [blame] | 115 | struct memory_block *mem = to_memory_block(dev); |
Nathan Fontenot | d336016 | 2011-01-20 10:44:29 -0600 | [diff] [blame] | 116 | unsigned long phys_index; |
| 117 | |
| 118 | phys_index = mem->start_section_nr / sections_per_block; |
| 119 | return sprintf(buf, "%08lx\n", phys_index); |
| 120 | } |
| 121 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 122 | /* |
Badari Pulavarty | 5c755e9 | 2008-07-23 21:28:19 -0700 | [diff] [blame] | 123 | * Show whether the section of memory is likely to be hot-removable |
| 124 | */ |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 125 | static ssize_t show_mem_removable(struct device *dev, |
| 126 | struct device_attribute *attr, char *buf) |
Badari Pulavarty | 5c755e9 | 2008-07-23 21:28:19 -0700 | [diff] [blame] | 127 | { |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 128 | unsigned long i, pfn; |
| 129 | int ret = 1; |
Gu Zheng | 7315f0c | 2013-08-28 14:38:27 +0800 | [diff] [blame] | 130 | struct memory_block *mem = to_memory_block(dev); |
Badari Pulavarty | 5c755e9 | 2008-07-23 21:28:19 -0700 | [diff] [blame] | 131 | |
Michal Hocko | 8b0662f | 2017-07-06 15:37:53 -0700 | [diff] [blame] | 132 | if (mem->state != MEM_ONLINE) |
| 133 | goto out; |
| 134 | |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 135 | for (i = 0; i < sections_per_block; i++) { |
Russ Anderson | 21ea9f5 | 2013-08-28 16:35:18 -0700 | [diff] [blame] | 136 | if (!present_section_nr(mem->start_section_nr + i)) |
| 137 | continue; |
Nathan Fontenot | d336016 | 2011-01-20 10:44:29 -0600 | [diff] [blame] | 138 | pfn = section_nr_to_pfn(mem->start_section_nr + i); |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 139 | ret &= is_mem_section_removable(pfn, PAGES_PER_SECTION); |
| 140 | } |
| 141 | |
Michal Hocko | 8b0662f | 2017-07-06 15:37:53 -0700 | [diff] [blame] | 142 | out: |
Badari Pulavarty | 5c755e9 | 2008-07-23 21:28:19 -0700 | [diff] [blame] | 143 | return sprintf(buf, "%d\n", ret); |
| 144 | } |
| 145 | |
| 146 | /* |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 147 | * online, offline, going offline, etc. |
| 148 | */ |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 149 | static ssize_t show_mem_state(struct device *dev, |
| 150 | struct device_attribute *attr, char *buf) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 151 | { |
Gu Zheng | 7315f0c | 2013-08-28 14:38:27 +0800 | [diff] [blame] | 152 | struct memory_block *mem = to_memory_block(dev); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 153 | ssize_t len = 0; |
| 154 | |
| 155 | /* |
| 156 | * We can probably put these states in a nice little array |
| 157 | * so that they're not open-coded |
| 158 | */ |
| 159 | switch (mem->state) { |
Ioana Ciornei | 3d3af6a | 2015-03-08 12:29:04 +0200 | [diff] [blame] | 160 | case MEM_ONLINE: |
| 161 | len = sprintf(buf, "online\n"); |
| 162 | break; |
| 163 | case MEM_OFFLINE: |
| 164 | len = sprintf(buf, "offline\n"); |
| 165 | break; |
| 166 | case MEM_GOING_OFFLINE: |
| 167 | len = sprintf(buf, "going-offline\n"); |
| 168 | break; |
| 169 | default: |
| 170 | len = sprintf(buf, "ERROR-UNKNOWN-%ld\n", |
| 171 | mem->state); |
| 172 | WARN_ON(1); |
| 173 | break; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 174 | } |
| 175 | |
| 176 | return len; |
| 177 | } |
| 178 | |
Yasunori Goto | 7b78d33 | 2007-10-21 16:41:36 -0700 | [diff] [blame] | 179 | int memory_notify(unsigned long val, void *v) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 180 | { |
Alan Stern | e041c68 | 2006-03-27 01:16:30 -0800 | [diff] [blame] | 181 | return blocking_notifier_call_chain(&memory_chain, val, v); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 182 | } |
| 183 | |
Robert Jennings | 925cc71 | 2009-12-17 14:44:38 +0000 | [diff] [blame] | 184 | int memory_isolate_notify(unsigned long val, void *v) |
| 185 | { |
| 186 | return atomic_notifier_call_chain(&memory_isolate_chain, val, v); |
| 187 | } |
| 188 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 189 | /* |
Pavel Tatashin | b77eab7 | 2018-04-05 16:22:52 -0700 | [diff] [blame] | 190 | * The probe routines leave the pages uninitialized, just as the bootmem code |
| 191 | * does. Make sure we do not access them, but instead use only information from |
| 192 | * within sections. |
Mel Gorman | 2bbcb878 | 2011-10-17 16:38:20 +0200 | [diff] [blame] | 193 | */ |
Pavel Tatashin | b77eab7 | 2018-04-05 16:22:52 -0700 | [diff] [blame] | 194 | static bool pages_correctly_probed(unsigned long start_pfn) |
Mel Gorman | 2bbcb878 | 2011-10-17 16:38:20 +0200 | [diff] [blame] | 195 | { |
Pavel Tatashin | b77eab7 | 2018-04-05 16:22:52 -0700 | [diff] [blame] | 196 | unsigned long section_nr = pfn_to_section_nr(start_pfn); |
| 197 | unsigned long section_nr_end = section_nr + sections_per_block; |
Mel Gorman | 2bbcb878 | 2011-10-17 16:38:20 +0200 | [diff] [blame] | 198 | unsigned long pfn = start_pfn; |
| 199 | |
| 200 | /* |
| 201 | * memmap between sections is not contiguous except with |
| 202 | * SPARSEMEM_VMEMMAP. We lookup the page once per section |
| 203 | * and assume memmap is contiguous within each section |
| 204 | */ |
Pavel Tatashin | b77eab7 | 2018-04-05 16:22:52 -0700 | [diff] [blame] | 205 | for (; section_nr < section_nr_end; section_nr++) { |
Mel Gorman | 2bbcb878 | 2011-10-17 16:38:20 +0200 | [diff] [blame] | 206 | if (WARN_ON_ONCE(!pfn_valid(pfn))) |
| 207 | return false; |
Mel Gorman | 2bbcb878 | 2011-10-17 16:38:20 +0200 | [diff] [blame] | 208 | |
Pavel Tatashin | b77eab7 | 2018-04-05 16:22:52 -0700 | [diff] [blame] | 209 | if (!present_section_nr(section_nr)) { |
| 210 | pr_warn("section %ld pfn[%lx, %lx) not present", |
| 211 | section_nr, pfn, pfn + PAGES_PER_SECTION); |
| 212 | return false; |
| 213 | } else if (!valid_section_nr(section_nr)) { |
| 214 | pr_warn("section %ld pfn[%lx, %lx) no valid memmap", |
| 215 | section_nr, pfn, pfn + PAGES_PER_SECTION); |
| 216 | return false; |
| 217 | } else if (online_section_nr(section_nr)) { |
| 218 | pr_warn("section %ld pfn[%lx, %lx) is already online", |
| 219 | section_nr, pfn, pfn + PAGES_PER_SECTION); |
Mel Gorman | 2bbcb878 | 2011-10-17 16:38:20 +0200 | [diff] [blame] | 220 | return false; |
| 221 | } |
Pavel Tatashin | b77eab7 | 2018-04-05 16:22:52 -0700 | [diff] [blame] | 222 | pfn += PAGES_PER_SECTION; |
Mel Gorman | 2bbcb878 | 2011-10-17 16:38:20 +0200 | [diff] [blame] | 223 | } |
| 224 | |
| 225 | return true; |
| 226 | } |
| 227 | |
| 228 | /* |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 229 | * MEMORY_HOTPLUG depends on SPARSEMEM in mm/Kconfig, so it is |
| 230 | * OK to have direct references to sparsemem variables in here. |
David Rientjes | 30467e0 | 2015-04-14 15:45:11 -0700 | [diff] [blame] | 231 | * Must already be protected by mem_hotplug_begin(). |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 232 | */ |
| 233 | static int |
Lai Jiangshan | 511c2ab | 2012-12-11 16:03:16 -0800 | [diff] [blame] | 234 | memory_block_action(unsigned long phys_index, unsigned long action, int online_type) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 235 | { |
Wen Congyang | a16cee1 | 2012-10-08 16:33:58 -0700 | [diff] [blame] | 236 | unsigned long start_pfn; |
Anton Blanchard | 5409d2c | 2011-05-11 17:25:14 +1000 | [diff] [blame] | 237 | unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 238 | int ret; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 239 | |
Sheng Yong | 19c07d5 | 2015-04-14 15:44:54 -0700 | [diff] [blame] | 240 | start_pfn = section_nr_to_pfn(phys_index); |
Greg Kroah-Hartman | de0ed36 | 2011-10-18 14:00:57 -0700 | [diff] [blame] | 241 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 242 | switch (action) { |
Ioana Ciornei | 3d3af6a | 2015-03-08 12:29:04 +0200 | [diff] [blame] | 243 | case MEM_ONLINE: |
Pavel Tatashin | b77eab7 | 2018-04-05 16:22:52 -0700 | [diff] [blame] | 244 | if (!pages_correctly_probed(start_pfn)) |
Ioana Ciornei | 3d3af6a | 2015-03-08 12:29:04 +0200 | [diff] [blame] | 245 | return -EBUSY; |
Mel Gorman | 2bbcb878 | 2011-10-17 16:38:20 +0200 | [diff] [blame] | 246 | |
Ioana Ciornei | 3d3af6a | 2015-03-08 12:29:04 +0200 | [diff] [blame] | 247 | ret = online_pages(start_pfn, nr_pages, online_type); |
| 248 | break; |
| 249 | case MEM_OFFLINE: |
| 250 | ret = offline_pages(start_pfn, nr_pages); |
| 251 | break; |
| 252 | default: |
| 253 | WARN(1, KERN_WARNING "%s(%ld, %ld) unknown action: " |
| 254 | "%ld\n", __func__, phys_index, action, action); |
| 255 | ret = -EINVAL; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 256 | } |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 257 | |
| 258 | return ret; |
| 259 | } |
| 260 | |
Nathan Fontenot | dc18d70 | 2017-02-24 15:00:02 -0800 | [diff] [blame] | 261 | static int memory_block_change_state(struct memory_block *mem, |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 262 | unsigned long to_state, unsigned long from_state_req) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 263 | { |
Greg Kroah-Hartman | de0ed36 | 2011-10-18 14:00:57 -0700 | [diff] [blame] | 264 | int ret = 0; |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 265 | |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 266 | if (mem->state != from_state_req) |
| 267 | return -EINVAL; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 268 | |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 269 | if (to_state == MEM_OFFLINE) |
| 270 | mem->state = MEM_GOING_OFFLINE; |
| 271 | |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 272 | ret = memory_block_action(mem->start_section_nr, to_state, |
| 273 | mem->online_type); |
| 274 | |
Rafael J. Wysocki | b2c064b | 2013-05-23 10:38:55 +0200 | [diff] [blame] | 275 | mem->state = ret ? from_state_req : to_state; |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 276 | |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 277 | return ret; |
| 278 | } |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 279 | |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 280 | /* The device lock serializes operations on memory_subsys_[online|offline] */ |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 281 | static int memory_subsys_online(struct device *dev) |
| 282 | { |
Gu Zheng | 7315f0c | 2013-08-28 14:38:27 +0800 | [diff] [blame] | 283 | struct memory_block *mem = to_memory_block(dev); |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 284 | int ret; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 285 | |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 286 | if (mem->state == MEM_ONLINE) |
| 287 | return 0; |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 288 | |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 289 | /* |
| 290 | * If we are called from store_mem_state(), online_type will be |
| 291 | * set >= 0 Otherwise we were called from the device online |
| 292 | * attribute and need to set the online_type. |
| 293 | */ |
| 294 | if (mem->online_type < 0) |
Tang Chen | 4f7c6b4 | 2014-08-06 16:05:13 -0700 | [diff] [blame] | 295 | mem->online_type = MMOP_ONLINE_KEEP; |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 296 | |
David Rientjes | 30467e0 | 2015-04-14 15:45:11 -0700 | [diff] [blame] | 297 | /* Already under protection of mem_hotplug_begin() */ |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 298 | ret = memory_block_change_state(mem, MEM_ONLINE, MEM_OFFLINE); |
| 299 | |
| 300 | /* clear online_type */ |
| 301 | mem->online_type = -1; |
| 302 | |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 303 | return ret; |
| 304 | } |
| 305 | |
| 306 | static int memory_subsys_offline(struct device *dev) |
| 307 | { |
Gu Zheng | 7315f0c | 2013-08-28 14:38:27 +0800 | [diff] [blame] | 308 | struct memory_block *mem = to_memory_block(dev); |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 309 | |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 310 | if (mem->state == MEM_OFFLINE) |
| 311 | return 0; |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 312 | |
Seth Jennings | 26bbe7e | 2015-12-11 13:40:57 -0800 | [diff] [blame] | 313 | /* Can't offline block with non-present sections */ |
| 314 | if (mem->section_count != sections_per_block) |
| 315 | return -EINVAL; |
| 316 | |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 317 | return memory_block_change_state(mem, MEM_OFFLINE, MEM_ONLINE); |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 318 | } |
| 319 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 320 | static ssize_t |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 321 | store_mem_state(struct device *dev, |
| 322 | struct device_attribute *attr, const char *buf, size_t count) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 323 | { |
Gu Zheng | 7315f0c | 2013-08-28 14:38:27 +0800 | [diff] [blame] | 324 | struct memory_block *mem = to_memory_block(dev); |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 325 | int ret, online_type; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 326 | |
Rafael J. Wysocki | 5e33bc4 | 2013-08-28 21:41:01 +0200 | [diff] [blame] | 327 | ret = lock_device_hotplug_sysfs(); |
| 328 | if (ret) |
| 329 | return ret; |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 330 | |
Tang Chen | 1f6a6cc | 2014-08-06 16:05:11 -0700 | [diff] [blame] | 331 | if (sysfs_streq(buf, "online_kernel")) |
Tang Chen | 4f7c6b4 | 2014-08-06 16:05:13 -0700 | [diff] [blame] | 332 | online_type = MMOP_ONLINE_KERNEL; |
Tang Chen | 1f6a6cc | 2014-08-06 16:05:11 -0700 | [diff] [blame] | 333 | else if (sysfs_streq(buf, "online_movable")) |
Tang Chen | 4f7c6b4 | 2014-08-06 16:05:13 -0700 | [diff] [blame] | 334 | online_type = MMOP_ONLINE_MOVABLE; |
Tang Chen | 1f6a6cc | 2014-08-06 16:05:11 -0700 | [diff] [blame] | 335 | else if (sysfs_streq(buf, "online")) |
Tang Chen | 4f7c6b4 | 2014-08-06 16:05:13 -0700 | [diff] [blame] | 336 | online_type = MMOP_ONLINE_KEEP; |
Tang Chen | 1f6a6cc | 2014-08-06 16:05:11 -0700 | [diff] [blame] | 337 | else if (sysfs_streq(buf, "offline")) |
Tang Chen | 4f7c6b4 | 2014-08-06 16:05:13 -0700 | [diff] [blame] | 338 | online_type = MMOP_OFFLINE; |
Yasuaki Ishimatsu | a37f863 | 2013-10-11 15:36:25 +0900 | [diff] [blame] | 339 | else { |
| 340 | ret = -EINVAL; |
| 341 | goto err; |
| 342 | } |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 343 | |
David Rientjes | 30467e0 | 2015-04-14 15:45:11 -0700 | [diff] [blame] | 344 | /* |
| 345 | * Memory hotplug needs to hold mem_hotplug_begin() for probe to find |
| 346 | * the correct memory block to online before doing device_online(dev), |
| 347 | * which will take dev->mutex. Take the lock early to prevent an |
| 348 | * inversion, memory_subsys_online() callbacks will be implemented by |
| 349 | * assuming it's already protected. |
| 350 | */ |
| 351 | mem_hotplug_begin(); |
| 352 | |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 353 | switch (online_type) { |
Tang Chen | 4f7c6b4 | 2014-08-06 16:05:13 -0700 | [diff] [blame] | 354 | case MMOP_ONLINE_KERNEL: |
| 355 | case MMOP_ONLINE_MOVABLE: |
| 356 | case MMOP_ONLINE_KEEP: |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 357 | mem->online_type = online_type; |
| 358 | ret = device_online(&mem->dev); |
| 359 | break; |
Tang Chen | 4f7c6b4 | 2014-08-06 16:05:13 -0700 | [diff] [blame] | 360 | case MMOP_OFFLINE: |
Seth Jennings | fa2be40 | 2013-08-20 16:05:05 -0500 | [diff] [blame] | 361 | ret = device_offline(&mem->dev); |
| 362 | break; |
| 363 | default: |
| 364 | ret = -EINVAL; /* should never happen */ |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 365 | } |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 366 | |
David Rientjes | 30467e0 | 2015-04-14 15:45:11 -0700 | [diff] [blame] | 367 | mem_hotplug_done(); |
Yasuaki Ishimatsu | a37f863 | 2013-10-11 15:36:25 +0900 | [diff] [blame] | 368 | err: |
Rafael J. Wysocki | 4960e05 | 2013-05-08 14:18:37 +0200 | [diff] [blame] | 369 | unlock_device_hotplug(); |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 370 | |
Reza Arbab | d66ba15 | 2016-10-07 17:00:15 -0700 | [diff] [blame] | 371 | if (ret < 0) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 372 | return ret; |
Reza Arbab | d66ba15 | 2016-10-07 17:00:15 -0700 | [diff] [blame] | 373 | if (ret) |
| 374 | return -EINVAL; |
| 375 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 376 | return count; |
| 377 | } |
| 378 | |
| 379 | /* |
| 380 | * phys_device is a bad name for this. What I really want |
| 381 | * is a way to differentiate between memory ranges that |
| 382 | * are part of physical devices that constitute |
| 383 | * a complete removable unit or fru. |
| 384 | * i.e. do these ranges belong to the same physical device, |
| 385 | * s.t. if I offline all of these sections I can then |
| 386 | * remove the physical device? |
| 387 | */ |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 388 | static ssize_t show_phys_device(struct device *dev, |
| 389 | struct device_attribute *attr, char *buf) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 390 | { |
Gu Zheng | 7315f0c | 2013-08-28 14:38:27 +0800 | [diff] [blame] | 391 | struct memory_block *mem = to_memory_block(dev); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 392 | return sprintf(buf, "%d\n", mem->phys_device); |
| 393 | } |
| 394 | |
Zhang Zhen | ed2f240 | 2014-10-09 15:26:31 -0700 | [diff] [blame] | 395 | #ifdef CONFIG_MEMORY_HOTREMOVE |
Michal Hocko | e5e6893 | 2017-09-06 16:19:37 -0700 | [diff] [blame] | 396 | static void print_allowed_zone(char *buf, int nid, unsigned long start_pfn, |
| 397 | unsigned long nr_pages, int online_type, |
| 398 | struct zone *default_zone) |
| 399 | { |
| 400 | struct zone *zone; |
| 401 | |
Michal Hocko | e5e6893 | 2017-09-06 16:19:37 -0700 | [diff] [blame] | 402 | zone = zone_for_pfn_range(online_type, nid, start_pfn, nr_pages); |
| 403 | if (zone != default_zone) { |
| 404 | strcat(buf, " "); |
| 405 | strcat(buf, zone->name); |
| 406 | } |
| 407 | } |
| 408 | |
Zhang Zhen | ed2f240 | 2014-10-09 15:26:31 -0700 | [diff] [blame] | 409 | static ssize_t show_valid_zones(struct device *dev, |
| 410 | struct device_attribute *attr, char *buf) |
| 411 | { |
| 412 | struct memory_block *mem = to_memory_block(dev); |
Michal Hocko | f1dd2cd | 2017-07-06 15:38:11 -0700 | [diff] [blame] | 413 | unsigned long start_pfn = section_nr_to_pfn(mem->start_section_nr); |
Zhang Zhen | ed2f240 | 2014-10-09 15:26:31 -0700 | [diff] [blame] | 414 | unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block; |
Michal Hocko | f1dd2cd | 2017-07-06 15:38:11 -0700 | [diff] [blame] | 415 | unsigned long valid_start_pfn, valid_end_pfn; |
Michal Hocko | e5e6893 | 2017-09-06 16:19:37 -0700 | [diff] [blame] | 416 | struct zone *default_zone; |
Michal Hocko | f1dd2cd | 2017-07-06 15:38:11 -0700 | [diff] [blame] | 417 | int nid; |
Zhang Zhen | ed2f240 | 2014-10-09 15:26:31 -0700 | [diff] [blame] | 418 | |
Michal Hocko | f1dd2cd | 2017-07-06 15:38:11 -0700 | [diff] [blame] | 419 | /* |
| 420 | * The block contains more than one zone can not be offlined. |
| 421 | * This can happen e.g. for ZONE_DMA and ZONE_DMA32 |
| 422 | */ |
| 423 | if (!test_pages_in_a_zone(start_pfn, start_pfn + nr_pages, &valid_start_pfn, &valid_end_pfn)) |
Zhang Zhen | ed2f240 | 2014-10-09 15:26:31 -0700 | [diff] [blame] | 424 | return sprintf(buf, "none\n"); |
| 425 | |
Michal Hocko | f1dd2cd | 2017-07-06 15:38:11 -0700 | [diff] [blame] | 426 | start_pfn = valid_start_pfn; |
| 427 | nr_pages = valid_end_pfn - start_pfn; |
Zhang Zhen | ed2f240 | 2014-10-09 15:26:31 -0700 | [diff] [blame] | 428 | |
Michal Hocko | f1dd2cd | 2017-07-06 15:38:11 -0700 | [diff] [blame] | 429 | /* |
| 430 | * Check the existing zone. Make sure that we do that only on the |
| 431 | * online nodes otherwise the page_zone is not reliable |
| 432 | */ |
| 433 | if (mem->state == MEM_ONLINE) { |
| 434 | strcat(buf, page_zone(pfn_to_page(start_pfn))->name); |
| 435 | goto out; |
Zhang Zhen | ed2f240 | 2014-10-09 15:26:31 -0700 | [diff] [blame] | 436 | } |
| 437 | |
Michal Hocko | f1dd2cd | 2017-07-06 15:38:11 -0700 | [diff] [blame] | 438 | nid = pfn_to_nid(start_pfn); |
Michal Hocko | e5e6893 | 2017-09-06 16:19:37 -0700 | [diff] [blame] | 439 | default_zone = zone_for_pfn_range(MMOP_ONLINE_KEEP, nid, start_pfn, nr_pages); |
| 440 | strcat(buf, default_zone->name); |
Zhang Zhen | ed2f240 | 2014-10-09 15:26:31 -0700 | [diff] [blame] | 441 | |
Michal Hocko | e5e6893 | 2017-09-06 16:19:37 -0700 | [diff] [blame] | 442 | print_allowed_zone(buf, nid, start_pfn, nr_pages, MMOP_ONLINE_KERNEL, |
| 443 | default_zone); |
| 444 | print_allowed_zone(buf, nid, start_pfn, nr_pages, MMOP_ONLINE_MOVABLE, |
| 445 | default_zone); |
Michal Hocko | f1dd2cd | 2017-07-06 15:38:11 -0700 | [diff] [blame] | 446 | out: |
Reza Arbab | a371d9f | 2016-07-26 15:22:27 -0700 | [diff] [blame] | 447 | strcat(buf, "\n"); |
| 448 | |
| 449 | return strlen(buf); |
Zhang Zhen | ed2f240 | 2014-10-09 15:26:31 -0700 | [diff] [blame] | 450 | } |
| 451 | static DEVICE_ATTR(valid_zones, 0444, show_valid_zones, NULL); |
| 452 | #endif |
| 453 | |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 454 | static DEVICE_ATTR(phys_index, 0444, show_mem_start_phys_index, NULL); |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 455 | static DEVICE_ATTR(state, 0644, show_mem_state, store_mem_state); |
| 456 | static DEVICE_ATTR(phys_device, 0444, show_phys_device, NULL); |
| 457 | static DEVICE_ATTR(removable, 0444, show_mem_removable, NULL); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 458 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 459 | /* |
| 460 | * Block size attribute stuff |
| 461 | */ |
| 462 | static ssize_t |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 463 | print_block_size(struct device *dev, struct device_attribute *attr, |
Andi Kleen | 8564a6c | 2010-01-05 12:48:06 +0100 | [diff] [blame] | 464 | char *buf) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 465 | { |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 466 | return sprintf(buf, "%lx\n", get_memory_block_size()); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 467 | } |
| 468 | |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 469 | static DEVICE_ATTR(block_size_bytes, 0444, print_block_size, NULL); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 470 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 471 | /* |
Vitaly Kuznetsov | 31bc385 | 2016-03-15 14:56:48 -0700 | [diff] [blame] | 472 | * Memory auto online policy. |
| 473 | */ |
| 474 | |
| 475 | static ssize_t |
| 476 | show_auto_online_blocks(struct device *dev, struct device_attribute *attr, |
| 477 | char *buf) |
| 478 | { |
| 479 | if (memhp_auto_online) |
| 480 | return sprintf(buf, "online\n"); |
| 481 | else |
| 482 | return sprintf(buf, "offline\n"); |
| 483 | } |
| 484 | |
| 485 | static ssize_t |
| 486 | store_auto_online_blocks(struct device *dev, struct device_attribute *attr, |
| 487 | const char *buf, size_t count) |
| 488 | { |
| 489 | if (sysfs_streq(buf, "online")) |
| 490 | memhp_auto_online = true; |
| 491 | else if (sysfs_streq(buf, "offline")) |
| 492 | memhp_auto_online = false; |
| 493 | else |
| 494 | return -EINVAL; |
| 495 | |
| 496 | return count; |
| 497 | } |
| 498 | |
| 499 | static DEVICE_ATTR(auto_online_blocks, 0644, show_auto_online_blocks, |
| 500 | store_auto_online_blocks); |
| 501 | |
| 502 | /* |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 503 | * Some architectures will have custom drivers to do this, and |
| 504 | * will not need to do it from userspace. The fake hot-add code |
| 505 | * as well as ppc64 will do all of their discovery in userspace |
| 506 | * and will require this interface. |
| 507 | */ |
| 508 | #ifdef CONFIG_ARCH_MEMORY_PROBE |
| 509 | static ssize_t |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 510 | memory_probe_store(struct device *dev, struct device_attribute *attr, |
Andi Kleen | 28812fe | 2010-01-05 12:48:07 +0100 | [diff] [blame] | 511 | const char *buf, size_t count) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 512 | { |
| 513 | u64 phys_addr; |
John Allen | cb5490a | 2016-01-14 15:22:16 -0800 | [diff] [blame] | 514 | int nid, ret; |
Anton Blanchard | 61b94fe | 2011-09-15 06:26:15 +1000 | [diff] [blame] | 515 | unsigned long pages_per_block = PAGES_PER_SECTION * sections_per_block; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 516 | |
Zhang Zhen | b69deb2 | 2014-08-06 16:06:06 -0700 | [diff] [blame] | 517 | ret = kstrtoull(buf, 0, &phys_addr); |
| 518 | if (ret) |
| 519 | return ret; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 520 | |
Anton Blanchard | 61b94fe | 2011-09-15 06:26:15 +1000 | [diff] [blame] | 521 | if (phys_addr & ((pages_per_block << PAGE_SHIFT) - 1)) |
| 522 | return -EINVAL; |
| 523 | |
John Allen | cb5490a | 2016-01-14 15:22:16 -0800 | [diff] [blame] | 524 | nid = memory_add_physaddr_to_nid(phys_addr); |
| 525 | ret = add_memory(nid, phys_addr, |
| 526 | MIN_MEMORY_BLOCK_SIZE * sections_per_block); |
Nathan Fontenot | 6add7cd | 2011-01-31 10:55:23 -0600 | [diff] [blame] | 527 | |
John Allen | cb5490a | 2016-01-14 15:22:16 -0800 | [diff] [blame] | 528 | if (ret) |
| 529 | goto out; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 530 | |
Nikanth Karthikesan | 9f0af69 | 2011-03-24 11:46:18 +0530 | [diff] [blame] | 531 | ret = count; |
| 532 | out: |
| 533 | return ret; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 534 | } |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 535 | |
Nathan Fontenot | 96b2c0f | 2013-06-04 14:42:28 -0500 | [diff] [blame] | 536 | static DEVICE_ATTR(probe, S_IWUSR, NULL, memory_probe_store); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 537 | #endif |
| 538 | |
Andi Kleen | facb601 | 2009-12-16 12:20:00 +0100 | [diff] [blame] | 539 | #ifdef CONFIG_MEMORY_FAILURE |
| 540 | /* |
| 541 | * Support for offlining pages of memory |
| 542 | */ |
| 543 | |
| 544 | /* Soft offline a page */ |
| 545 | static ssize_t |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 546 | store_soft_offline_page(struct device *dev, |
| 547 | struct device_attribute *attr, |
Andi Kleen | 28812fe | 2010-01-05 12:48:07 +0100 | [diff] [blame] | 548 | const char *buf, size_t count) |
Andi Kleen | facb601 | 2009-12-16 12:20:00 +0100 | [diff] [blame] | 549 | { |
| 550 | int ret; |
| 551 | u64 pfn; |
| 552 | if (!capable(CAP_SYS_ADMIN)) |
| 553 | return -EPERM; |
Jingoo Han | 34da5e6 | 2013-07-26 13:10:22 +0900 | [diff] [blame] | 554 | if (kstrtoull(buf, 0, &pfn) < 0) |
Andi Kleen | facb601 | 2009-12-16 12:20:00 +0100 | [diff] [blame] | 555 | return -EINVAL; |
| 556 | pfn >>= PAGE_SHIFT; |
| 557 | if (!pfn_valid(pfn)) |
| 558 | return -ENXIO; |
| 559 | ret = soft_offline_page(pfn_to_page(pfn), 0); |
| 560 | return ret == 0 ? count : ret; |
| 561 | } |
| 562 | |
| 563 | /* Forcibly offline a page, including killing processes. */ |
| 564 | static ssize_t |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 565 | store_hard_offline_page(struct device *dev, |
| 566 | struct device_attribute *attr, |
Andi Kleen | 28812fe | 2010-01-05 12:48:07 +0100 | [diff] [blame] | 567 | const char *buf, size_t count) |
Andi Kleen | facb601 | 2009-12-16 12:20:00 +0100 | [diff] [blame] | 568 | { |
| 569 | int ret; |
| 570 | u64 pfn; |
| 571 | if (!capable(CAP_SYS_ADMIN)) |
| 572 | return -EPERM; |
Jingoo Han | 34da5e6 | 2013-07-26 13:10:22 +0900 | [diff] [blame] | 573 | if (kstrtoull(buf, 0, &pfn) < 0) |
Andi Kleen | facb601 | 2009-12-16 12:20:00 +0100 | [diff] [blame] | 574 | return -EINVAL; |
| 575 | pfn >>= PAGE_SHIFT; |
Eric W. Biederman | 83b5753 | 2017-07-09 18:14:01 -0500 | [diff] [blame] | 576 | ret = memory_failure(pfn, 0); |
Andi Kleen | facb601 | 2009-12-16 12:20:00 +0100 | [diff] [blame] | 577 | return ret ? ret : count; |
| 578 | } |
| 579 | |
Felipe Balbi | 74fef7a | 2013-02-18 21:09:03 +0200 | [diff] [blame] | 580 | static DEVICE_ATTR(soft_offline_page, S_IWUSR, NULL, store_soft_offline_page); |
| 581 | static DEVICE_ATTR(hard_offline_page, S_IWUSR, NULL, store_hard_offline_page); |
Andi Kleen | facb601 | 2009-12-16 12:20:00 +0100 | [diff] [blame] | 582 | #endif |
| 583 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 584 | /* |
| 585 | * Note that phys_device is optional. It is here to allow for |
| 586 | * differentiation between which *physical* devices each |
| 587 | * section belongs to... |
| 588 | */ |
Heiko Carstens | bc32df0 | 2010-03-15 00:35:03 -0400 | [diff] [blame] | 589 | int __weak arch_get_memory_phys_device(unsigned long start_pfn) |
| 590 | { |
| 591 | return 0; |
| 592 | } |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 593 | |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 594 | /* |
| 595 | * A reference for the returned object is held and the reference for the |
| 596 | * hinted object is released. |
| 597 | */ |
Robin Holt | 9838303 | 2010-09-29 14:00:55 -0500 | [diff] [blame] | 598 | struct memory_block *find_memory_block_hinted(struct mem_section *section, |
| 599 | struct memory_block *hint) |
| 600 | { |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 601 | int block_id = base_memory_block_id(__section_nr(section)); |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 602 | struct device *hintdev = hint ? &hint->dev : NULL; |
| 603 | struct device *dev; |
Robin Holt | 9838303 | 2010-09-29 14:00:55 -0500 | [diff] [blame] | 604 | |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 605 | dev = subsys_find_device_by_id(&memory_subsys, block_id, hintdev); |
| 606 | if (hint) |
| 607 | put_device(&hint->dev); |
| 608 | if (!dev) |
Robin Holt | 9838303 | 2010-09-29 14:00:55 -0500 | [diff] [blame] | 609 | return NULL; |
Gu Zheng | 7315f0c | 2013-08-28 14:38:27 +0800 | [diff] [blame] | 610 | return to_memory_block(dev); |
Robin Holt | 9838303 | 2010-09-29 14:00:55 -0500 | [diff] [blame] | 611 | } |
| 612 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 613 | /* |
| 614 | * For now, we have a linear search to go find the appropriate |
| 615 | * memory_block corresponding to a particular phys_index. If |
| 616 | * this gets to be a real problem, we can always use a radix |
| 617 | * tree or something here. |
| 618 | * |
Kay Sievers | 10fbcf4 | 2011-12-21 14:48:43 -0800 | [diff] [blame] | 619 | * This could be made generic for all device subsystems. |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 620 | */ |
Gary Hade | c04fc58 | 2009-01-06 14:39:14 -0800 | [diff] [blame] | 621 | struct memory_block *find_memory_block(struct mem_section *section) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 622 | { |
Robin Holt | 9838303 | 2010-09-29 14:00:55 -0500 | [diff] [blame] | 623 | return find_memory_block_hinted(section, NULL); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 624 | } |
| 625 | |
Nathan Fontenot | 96b2c0f | 2013-06-04 14:42:28 -0500 | [diff] [blame] | 626 | static struct attribute *memory_memblk_attrs[] = { |
| 627 | &dev_attr_phys_index.attr, |
Nathan Fontenot | 96b2c0f | 2013-06-04 14:42:28 -0500 | [diff] [blame] | 628 | &dev_attr_state.attr, |
| 629 | &dev_attr_phys_device.attr, |
| 630 | &dev_attr_removable.attr, |
Zhang Zhen | ed2f240 | 2014-10-09 15:26:31 -0700 | [diff] [blame] | 631 | #ifdef CONFIG_MEMORY_HOTREMOVE |
| 632 | &dev_attr_valid_zones.attr, |
| 633 | #endif |
Nathan Fontenot | 96b2c0f | 2013-06-04 14:42:28 -0500 | [diff] [blame] | 634 | NULL |
| 635 | }; |
| 636 | |
| 637 | static struct attribute_group memory_memblk_attr_group = { |
| 638 | .attrs = memory_memblk_attrs, |
| 639 | }; |
| 640 | |
| 641 | static const struct attribute_group *memory_memblk_attr_groups[] = { |
| 642 | &memory_memblk_attr_group, |
| 643 | NULL, |
| 644 | }; |
| 645 | |
| 646 | /* |
| 647 | * register_memory - Setup a sysfs device for a memory block |
| 648 | */ |
| 649 | static |
| 650 | int register_memory(struct memory_block *memory) |
| 651 | { |
Arvind Yadav | 085aa2d | 2018-04-26 21:12:09 +0530 | [diff] [blame] | 652 | int ret; |
| 653 | |
Nathan Fontenot | 96b2c0f | 2013-06-04 14:42:28 -0500 | [diff] [blame] | 654 | memory->dev.bus = &memory_subsys; |
| 655 | memory->dev.id = memory->start_section_nr / sections_per_block; |
| 656 | memory->dev.release = memory_block_release; |
| 657 | memory->dev.groups = memory_memblk_attr_groups; |
Linus Torvalds | f991fae | 2013-07-03 14:35:40 -0700 | [diff] [blame] | 658 | memory->dev.offline = memory->state == MEM_OFFLINE; |
Nathan Fontenot | 96b2c0f | 2013-06-04 14:42:28 -0500 | [diff] [blame] | 659 | |
Arvind Yadav | 085aa2d | 2018-04-26 21:12:09 +0530 | [diff] [blame] | 660 | ret = device_register(&memory->dev); |
| 661 | if (ret) |
| 662 | put_device(&memory->dev); |
| 663 | |
| 664 | return ret; |
Nathan Fontenot | 96b2c0f | 2013-06-04 14:42:28 -0500 | [diff] [blame] | 665 | } |
| 666 | |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 667 | static int init_memory_block(struct memory_block **memory, |
| 668 | struct mem_section *section, unsigned long state) |
Nathan Fontenot | e4619c8 | 2010-10-19 12:44:20 -0500 | [diff] [blame] | 669 | { |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 670 | struct memory_block *mem; |
Nathan Fontenot | e4619c8 | 2010-10-19 12:44:20 -0500 | [diff] [blame] | 671 | unsigned long start_pfn; |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 672 | int scn_nr; |
Nathan Fontenot | e4619c8 | 2010-10-19 12:44:20 -0500 | [diff] [blame] | 673 | int ret = 0; |
| 674 | |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 675 | mem = kzalloc(sizeof(*mem), GFP_KERNEL); |
Nathan Fontenot | e4619c8 | 2010-10-19 12:44:20 -0500 | [diff] [blame] | 676 | if (!mem) |
| 677 | return -ENOMEM; |
| 678 | |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 679 | scn_nr = __section_nr(section); |
Nathan Fontenot | d336016 | 2011-01-20 10:44:29 -0600 | [diff] [blame] | 680 | mem->start_section_nr = |
| 681 | base_memory_block_id(scn_nr) * sections_per_block; |
| 682 | mem->end_section_nr = mem->start_section_nr + sections_per_block - 1; |
Nathan Fontenot | e4619c8 | 2010-10-19 12:44:20 -0500 | [diff] [blame] | 683 | mem->state = state; |
Nathan Fontenot | d336016 | 2011-01-20 10:44:29 -0600 | [diff] [blame] | 684 | start_pfn = section_nr_to_pfn(mem->start_section_nr); |
Nathan Fontenot | e4619c8 | 2010-10-19 12:44:20 -0500 | [diff] [blame] | 685 | mem->phys_device = arch_get_memory_phys_device(start_pfn); |
| 686 | |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 687 | ret = register_memory(mem); |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 688 | |
| 689 | *memory = mem; |
| 690 | return ret; |
| 691 | } |
| 692 | |
Seth Jennings | cb5e39b | 2013-08-20 12:13:03 -0500 | [diff] [blame] | 693 | static int add_memory_block(int base_section_nr) |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 694 | { |
Seth Jennings | cb5e39b | 2013-08-20 12:13:03 -0500 | [diff] [blame] | 695 | struct memory_block *mem; |
| 696 | int i, ret, section_count = 0, section_nr; |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 697 | |
Seth Jennings | cb5e39b | 2013-08-20 12:13:03 -0500 | [diff] [blame] | 698 | for (i = base_section_nr; |
| 699 | (i < base_section_nr + sections_per_block) && i < NR_MEM_SECTIONS; |
| 700 | i++) { |
| 701 | if (!present_section_nr(i)) |
| 702 | continue; |
| 703 | if (section_count == 0) |
| 704 | section_nr = i; |
| 705 | section_count++; |
Yinghai Lu | 321bf4e | 2012-01-30 13:57:12 -0800 | [diff] [blame] | 706 | } |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 707 | |
Seth Jennings | cb5e39b | 2013-08-20 12:13:03 -0500 | [diff] [blame] | 708 | if (section_count == 0) |
| 709 | return 0; |
| 710 | ret = init_memory_block(&mem, __nr_to_section(section_nr), MEM_ONLINE); |
| 711 | if (ret) |
| 712 | return ret; |
| 713 | mem->section_count = section_count; |
| 714 | return 0; |
Nathan Fontenot | e4619c8 | 2010-10-19 12:44:20 -0500 | [diff] [blame] | 715 | } |
| 716 | |
David Rientjes | 4edd7ce | 2013-04-29 15:08:22 -0700 | [diff] [blame] | 717 | /* |
| 718 | * need an interface for the VM to add new memory regions, |
| 719 | * but without onlining it. |
| 720 | */ |
Pavel Tatashin | fc44f7f | 2018-04-05 16:22:56 -0700 | [diff] [blame] | 721 | int hotplug_memory_register(int nid, struct mem_section *section) |
David Rientjes | 4edd7ce | 2013-04-29 15:08:22 -0700 | [diff] [blame] | 722 | { |
Seth Jennings | d7f8053 | 2013-08-20 12:13:00 -0500 | [diff] [blame] | 723 | int ret = 0; |
| 724 | struct memory_block *mem; |
Seth Jennings | b1eaef3 | 2013-08-20 12:12:57 -0500 | [diff] [blame] | 725 | |
| 726 | mutex_lock(&mem_sysfs_mutex); |
Seth Jennings | b1eaef3 | 2013-08-20 12:12:57 -0500 | [diff] [blame] | 727 | |
Seth Jennings | d7f8053 | 2013-08-20 12:13:00 -0500 | [diff] [blame] | 728 | mem = find_memory_block(section); |
| 729 | if (mem) { |
| 730 | mem->section_count++; |
| 731 | put_device(&mem->dev); |
| 732 | } else { |
| 733 | ret = init_memory_block(&mem, section, MEM_OFFLINE); |
| 734 | if (ret) |
| 735 | goto out; |
Seth Jennings | 56c6b5d | 2016-01-14 15:20:21 -0800 | [diff] [blame] | 736 | mem->section_count++; |
Seth Jennings | d7f8053 | 2013-08-20 12:13:00 -0500 | [diff] [blame] | 737 | } |
| 738 | |
| 739 | if (mem->section_count == sections_per_block) |
Pavel Tatashin | fc44f7f | 2018-04-05 16:22:56 -0700 | [diff] [blame] | 740 | ret = register_mem_sect_under_node(mem, nid, false); |
Seth Jennings | d7f8053 | 2013-08-20 12:13:00 -0500 | [diff] [blame] | 741 | out: |
| 742 | mutex_unlock(&mem_sysfs_mutex); |
Seth Jennings | b1eaef3 | 2013-08-20 12:12:57 -0500 | [diff] [blame] | 743 | return ret; |
David Rientjes | 4edd7ce | 2013-04-29 15:08:22 -0700 | [diff] [blame] | 744 | } |
| 745 | |
| 746 | #ifdef CONFIG_MEMORY_HOTREMOVE |
| 747 | static void |
| 748 | unregister_memory(struct memory_block *memory) |
| 749 | { |
| 750 | BUG_ON(memory->dev.bus != &memory_subsys); |
| 751 | |
| 752 | /* drop the ref. we got in remove_memory_block() */ |
Seth Jennings | df2b717 | 2013-08-20 12:12:59 -0500 | [diff] [blame] | 753 | put_device(&memory->dev); |
David Rientjes | 4edd7ce | 2013-04-29 15:08:22 -0700 | [diff] [blame] | 754 | device_unregister(&memory->dev); |
| 755 | } |
| 756 | |
Seth Jennings | cc292b0 | 2016-01-14 15:20:24 -0800 | [diff] [blame] | 757 | static int remove_memory_section(unsigned long node_id, |
David Rientjes | 4edd7ce | 2013-04-29 15:08:22 -0700 | [diff] [blame] | 758 | struct mem_section *section, int phys_device) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 759 | { |
| 760 | struct memory_block *mem; |
| 761 | |
Nathan Fontenot | 2938ffb | 2010-10-19 12:45:24 -0500 | [diff] [blame] | 762 | mutex_lock(&mem_sysfs_mutex); |
Michal Hocko | 1b862ae | 2017-07-06 15:37:45 -0700 | [diff] [blame] | 763 | |
| 764 | /* |
| 765 | * Some users of the memory hotplug do not want/need memblock to |
| 766 | * track all sections. Skip over those. |
| 767 | */ |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 768 | mem = find_memory_block(section); |
Michal Hocko | 1b862ae | 2017-07-06 15:37:45 -0700 | [diff] [blame] | 769 | if (!mem) |
| 770 | goto out_unlock; |
| 771 | |
Nathan Fontenot | d336016 | 2011-01-20 10:44:29 -0600 | [diff] [blame] | 772 | unregister_mem_sect_under_nodes(mem, __section_nr(section)); |
Nathan Fontenot | 0768121 | 2010-10-19 12:46:19 -0500 | [diff] [blame] | 773 | |
| 774 | mem->section_count--; |
Nathan Fontenot | 96b2c0f | 2013-06-04 14:42:28 -0500 | [diff] [blame] | 775 | if (mem->section_count == 0) |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 776 | unregister_memory(mem); |
Nathan Fontenot | 96b2c0f | 2013-06-04 14:42:28 -0500 | [diff] [blame] | 777 | else |
Seth Jennings | df2b717 | 2013-08-20 12:12:59 -0500 | [diff] [blame] | 778 | put_device(&mem->dev); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 779 | |
Michal Hocko | 1b862ae | 2017-07-06 15:37:45 -0700 | [diff] [blame] | 780 | out_unlock: |
Nathan Fontenot | 2938ffb | 2010-10-19 12:45:24 -0500 | [diff] [blame] | 781 | mutex_unlock(&mem_sysfs_mutex); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 782 | return 0; |
| 783 | } |
| 784 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 785 | int unregister_memory_section(struct mem_section *section) |
| 786 | { |
Andy Whitcroft | 540557b | 2007-10-16 01:24:11 -0700 | [diff] [blame] | 787 | if (!present_section(section)) |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 788 | return -EINVAL; |
| 789 | |
Seth Jennings | cc292b0 | 2016-01-14 15:20:24 -0800 | [diff] [blame] | 790 | return remove_memory_section(0, section, 0); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 791 | } |
David Rientjes | 4edd7ce | 2013-04-29 15:08:22 -0700 | [diff] [blame] | 792 | #endif /* CONFIG_MEMORY_HOTREMOVE */ |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 793 | |
Yasuaki Ishimatsu | 6677e3e | 2013-02-22 16:32:52 -0800 | [diff] [blame] | 794 | /* return true if the memory block is offlined, otherwise, return false */ |
| 795 | bool is_memblock_offlined(struct memory_block *mem) |
| 796 | { |
| 797 | return mem->state == MEM_OFFLINE; |
| 798 | } |
| 799 | |
Nathan Fontenot | 96b2c0f | 2013-06-04 14:42:28 -0500 | [diff] [blame] | 800 | static struct attribute *memory_root_attrs[] = { |
| 801 | #ifdef CONFIG_ARCH_MEMORY_PROBE |
| 802 | &dev_attr_probe.attr, |
| 803 | #endif |
| 804 | |
| 805 | #ifdef CONFIG_MEMORY_FAILURE |
| 806 | &dev_attr_soft_offline_page.attr, |
| 807 | &dev_attr_hard_offline_page.attr, |
| 808 | #endif |
| 809 | |
| 810 | &dev_attr_block_size_bytes.attr, |
Vitaly Kuznetsov | 31bc385 | 2016-03-15 14:56:48 -0700 | [diff] [blame] | 811 | &dev_attr_auto_online_blocks.attr, |
Nathan Fontenot | 96b2c0f | 2013-06-04 14:42:28 -0500 | [diff] [blame] | 812 | NULL |
| 813 | }; |
| 814 | |
| 815 | static struct attribute_group memory_root_attr_group = { |
| 816 | .attrs = memory_root_attrs, |
| 817 | }; |
| 818 | |
| 819 | static const struct attribute_group *memory_root_attr_groups[] = { |
| 820 | &memory_root_attr_group, |
| 821 | NULL, |
| 822 | }; |
| 823 | |
Wen Congyang | e90bdb7 | 2012-10-08 16:34:01 -0700 | [diff] [blame] | 824 | /* |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 825 | * Initialize the sysfs support for memory devices... |
| 826 | */ |
| 827 | int __init memory_dev_init(void) |
| 828 | { |
| 829 | unsigned int i; |
| 830 | int ret; |
Andrew Morton | 28ec24e | 2006-12-06 20:37:29 -0800 | [diff] [blame] | 831 | int err; |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 832 | unsigned long block_sz; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 833 | |
Nathan Fontenot | 96b2c0f | 2013-06-04 14:42:28 -0500 | [diff] [blame] | 834 | ret = subsys_system_register(&memory_subsys, memory_root_attr_groups); |
Andrew Morton | 28ec24e | 2006-12-06 20:37:29 -0800 | [diff] [blame] | 835 | if (ret) |
| 836 | goto out; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 837 | |
Nathan Fontenot | 0c2c99b | 2011-01-20 10:43:34 -0600 | [diff] [blame] | 838 | block_sz = get_memory_block_size(); |
| 839 | sections_per_block = block_sz / MIN_MEMORY_BLOCK_SIZE; |
| 840 | |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 841 | /* |
| 842 | * Create entries for memory sections that were found |
| 843 | * during boot and have been initialized |
| 844 | */ |
Seth Jennings | b1eaef3 | 2013-08-20 12:12:57 -0500 | [diff] [blame] | 845 | mutex_lock(&mem_sysfs_mutex); |
Wei Yang | bc8755b | 2018-04-10 16:29:23 -0700 | [diff] [blame] | 846 | for (i = 0; i <= __highest_present_section_nr; |
| 847 | i += sections_per_block) { |
Seth Jennings | cb5e39b | 2013-08-20 12:13:03 -0500 | [diff] [blame] | 848 | err = add_memory_block(i); |
Andrew Morton | 28ec24e | 2006-12-06 20:37:29 -0800 | [diff] [blame] | 849 | if (!ret) |
| 850 | ret = err; |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 851 | } |
Seth Jennings | b1eaef3 | 2013-08-20 12:12:57 -0500 | [diff] [blame] | 852 | mutex_unlock(&mem_sysfs_mutex); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 853 | |
Andrew Morton | 28ec24e | 2006-12-06 20:37:29 -0800 | [diff] [blame] | 854 | out: |
| 855 | if (ret) |
Harvey Harrison | 2b3a302 | 2008-03-04 16:41:05 -0800 | [diff] [blame] | 856 | printk(KERN_ERR "%s() failed: %d\n", __func__, ret); |
Dave Hansen | 3947be1 | 2005-10-29 18:16:54 -0700 | [diff] [blame] | 857 | return ret; |
| 858 | } |