blob: ad7173df72eb53b978eb9c919c194410f7f8e327 [file] [log] [blame]
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +09001#include <linux/idr.h>
2#include <linux/mutex.h>
3#include <linux/device.h>
4#include <linux/sysfs.h>
Masami Hiramatsu90b05b02017-08-02 13:47:42 +09005#include <linux/gpio.h>
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +09006#include <linux/gpio/consumer.h>
7#include <linux/gpio/driver.h>
8#include <linux/interrupt.h>
9#include <linux/kdev_t.h>
Johan Hovoldc43960f2015-05-04 17:10:37 +020010#include <linux/slab.h>
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090011
12#include "gpiolib.h"
13
Johan Hovoldcef17172015-05-04 17:10:48 +020014#define GPIO_IRQF_TRIGGER_FALLING BIT(0)
15#define GPIO_IRQF_TRIGGER_RISING BIT(1)
16#define GPIO_IRQF_TRIGGER_BOTH (GPIO_IRQF_TRIGGER_FALLING | \
17 GPIO_IRQF_TRIGGER_RISING)
18
Johan Hovoldc43960f2015-05-04 17:10:37 +020019struct gpiod_data {
20 struct gpio_desc *desc;
Johan Hovold6ffcb792015-05-04 17:10:44 +020021
22 struct mutex mutex;
Johan Hovolda08f5c22015-05-04 17:10:39 +020023 struct kernfs_node *value_kn;
Johan Hovold2ec74a92015-05-04 17:10:41 +020024 int irq;
Johan Hovoldcef17172015-05-04 17:10:48 +020025 unsigned char irq_flags;
Johan Hovold427fdee2015-05-04 17:10:47 +020026
27 bool direction_can_change;
Johan Hovoldc43960f2015-05-04 17:10:37 +020028};
29
Johan Hovold6ffcb792015-05-04 17:10:44 +020030/*
31 * Lock to serialise gpiod export and unexport, and prevent re-export of
32 * gpiod whose chip is being unregistered.
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090033 */
34static DEFINE_MUTEX(sysfs_lock);
35
36/*
37 * /sys/class/gpio/gpioN... only for GPIOs that are exported
38 * /direction
39 * * MAY BE OMITTED if kernel won't allow direction changes
40 * * is read/write as "in" or "out"
41 * * may also be written as "high" or "low", initializing
42 * output value as specified ("out" implies "low")
43 * /value
44 * * always readable, subject to hardware behavior
45 * * may be writable, as zero/nonzero
46 * /edge
47 * * configures behavior of poll(2) on /value
48 * * available only if pin can generate IRQs on input
49 * * is read/write as "none", "falling", "rising", or "both"
50 * /active_low
51 * * configures polarity of /value
52 * * is read/write as zero/nonzero
53 * * also affects existing and subsequent "falling" and "rising"
54 * /edge configuration
55 */
56
Johan Hovold6beac9d12015-05-04 17:10:34 +020057static ssize_t direction_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090058 struct device_attribute *attr, char *buf)
59{
Johan Hovoldc43960f2015-05-04 17:10:37 +020060 struct gpiod_data *data = dev_get_drvdata(dev);
61 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090062 ssize_t status;
63
Johan Hovold6ffcb792015-05-04 17:10:44 +020064 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090065
Johan Hovoldf0b78662015-05-04 17:10:36 +020066 gpiod_get_direction(desc);
67 status = sprintf(buf, "%s\n",
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090068 test_bit(FLAG_IS_OUT, &desc->flags)
69 ? "out" : "in");
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090070
Johan Hovold6ffcb792015-05-04 17:10:44 +020071 mutex_unlock(&data->mutex);
72
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090073 return status;
74}
75
Johan Hovold6beac9d12015-05-04 17:10:34 +020076static ssize_t direction_store(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090077 struct device_attribute *attr, const char *buf, size_t size)
78{
Johan Hovoldc43960f2015-05-04 17:10:37 +020079 struct gpiod_data *data = dev_get_drvdata(dev);
80 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090081 ssize_t status;
82
Johan Hovold6ffcb792015-05-04 17:10:44 +020083 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090084
Johan Hovoldf0b78662015-05-04 17:10:36 +020085 if (sysfs_streq(buf, "high"))
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090086 status = gpiod_direction_output_raw(desc, 1);
87 else if (sysfs_streq(buf, "out") || sysfs_streq(buf, "low"))
88 status = gpiod_direction_output_raw(desc, 0);
89 else if (sysfs_streq(buf, "in"))
90 status = gpiod_direction_input(desc);
91 else
92 status = -EINVAL;
93
Johan Hovold6ffcb792015-05-04 17:10:44 +020094 mutex_unlock(&data->mutex);
95
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090096 return status ? : size;
97}
Johan Hovold6beac9d12015-05-04 17:10:34 +020098static DEVICE_ATTR_RW(direction);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +090099
Johan Hovold6beac9d12015-05-04 17:10:34 +0200100static ssize_t value_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900101 struct device_attribute *attr, char *buf)
102{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200103 struct gpiod_data *data = dev_get_drvdata(dev);
104 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900105 ssize_t status;
106
Johan Hovold6ffcb792015-05-04 17:10:44 +0200107 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900108
Christophe Leroy9295c012017-12-18 11:08:31 +0100109 status = gpiod_get_value_cansleep(desc);
110 if (status < 0)
111 goto err;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900112
Christophe Leroy7a94b882017-12-18 11:08:33 +0100113 buf[0] = '0' + status;
114 buf[1] = '\n';
115 status = 2;
Christophe Leroy9295c012017-12-18 11:08:31 +0100116err:
Johan Hovold6ffcb792015-05-04 17:10:44 +0200117 mutex_unlock(&data->mutex);
118
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900119 return status;
120}
121
Johan Hovold6beac9d12015-05-04 17:10:34 +0200122static ssize_t value_store(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900123 struct device_attribute *attr, const char *buf, size_t size)
124{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200125 struct gpiod_data *data = dev_get_drvdata(dev);
126 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900127 ssize_t status;
128
Johan Hovold6ffcb792015-05-04 17:10:44 +0200129 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900130
Johan Hovoldf0b78662015-05-04 17:10:36 +0200131 if (!test_bit(FLAG_IS_OUT, &desc->flags)) {
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900132 status = -EPERM;
Johan Hovoldf0b78662015-05-04 17:10:36 +0200133 } else {
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900134 long value;
135
136 status = kstrtol(buf, 0, &value);
137 if (status == 0) {
138 gpiod_set_value_cansleep(desc, value);
139 status = size;
140 }
141 }
142
Johan Hovold6ffcb792015-05-04 17:10:44 +0200143 mutex_unlock(&data->mutex);
144
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900145 return status;
146}
Christophe Leroy7fda9102017-12-18 11:08:29 +0100147static DEVICE_ATTR_PREALLOC(value, S_IWUSR | S_IRUGO, value_show, value_store);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900148
149static irqreturn_t gpio_sysfs_irq(int irq, void *priv)
150{
Johan Hovolda08f5c22015-05-04 17:10:39 +0200151 struct gpiod_data *data = priv;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900152
Johan Hovolda08f5c22015-05-04 17:10:39 +0200153 sysfs_notify_dirent(data->value_kn);
154
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900155 return IRQ_HANDLED;
156}
157
Johan Hovold6ffcb792015-05-04 17:10:44 +0200158/* Caller holds gpiod-data mutex. */
Johan Hovoldcef17172015-05-04 17:10:48 +0200159static int gpio_sysfs_request_irq(struct device *dev, unsigned char flags)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900160{
Johan Hovold0f628502015-05-04 17:10:38 +0200161 struct gpiod_data *data = dev_get_drvdata(dev);
162 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900163 unsigned long irq_flags;
Johan Hovold2ec74a92015-05-04 17:10:41 +0200164 int ret;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900165
Johan Hovold2ec74a92015-05-04 17:10:41 +0200166 data->irq = gpiod_to_irq(desc);
167 if (data->irq < 0)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900168 return -EIO;
169
Johan Hovold2ec74a92015-05-04 17:10:41 +0200170 data->value_kn = sysfs_get_dirent(dev->kobj.sd, "value");
171 if (!data->value_kn)
172 return -ENODEV;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900173
174 irq_flags = IRQF_SHARED;
Johan Hovoldcef17172015-05-04 17:10:48 +0200175 if (flags & GPIO_IRQF_TRIGGER_FALLING)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900176 irq_flags |= test_bit(FLAG_ACTIVE_LOW, &desc->flags) ?
177 IRQF_TRIGGER_RISING : IRQF_TRIGGER_FALLING;
Johan Hovoldcef17172015-05-04 17:10:48 +0200178 if (flags & GPIO_IRQF_TRIGGER_RISING)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900179 irq_flags |= test_bit(FLAG_ACTIVE_LOW, &desc->flags) ?
180 IRQF_TRIGGER_FALLING : IRQF_TRIGGER_RISING;
181
Johan Hovold52176d02015-05-04 17:10:28 +0200182 /*
183 * FIXME: This should be done in the irq_request_resources callback
184 * when the irq is requested, but a few drivers currently fail
185 * to do so.
186 *
187 * Remove this redundant call (along with the corresponding
188 * unlock) when those drivers have been fixed.
189 */
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100190 ret = gpiochip_lock_as_irq(desc->gdev->chip, gpio_chip_hwgpio(desc));
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900191 if (ret < 0)
Johan Hovold2ec74a92015-05-04 17:10:41 +0200192 goto err_put_kn;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900193
Johan Hovold2ec74a92015-05-04 17:10:41 +0200194 ret = request_any_context_irq(data->irq, gpio_sysfs_irq, irq_flags,
Johan Hovolda08f5c22015-05-04 17:10:39 +0200195 "gpiolib", data);
Johan Hovold52176d02015-05-04 17:10:28 +0200196 if (ret < 0)
197 goto err_unlock;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900198
Johan Hovoldcef17172015-05-04 17:10:48 +0200199 data->irq_flags = flags;
Johan Hovold2ec74a92015-05-04 17:10:41 +0200200
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900201 return 0;
202
Johan Hovold52176d02015-05-04 17:10:28 +0200203err_unlock:
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100204 gpiochip_unlock_as_irq(desc->gdev->chip, gpio_chip_hwgpio(desc));
Johan Hovold2ec74a92015-05-04 17:10:41 +0200205err_put_kn:
206 sysfs_put(data->value_kn);
207
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900208 return ret;
209}
210
Johan Hovold6ffcb792015-05-04 17:10:44 +0200211/*
212 * Caller holds gpiod-data mutex (unless called after class-device
213 * deregistration).
214 */
Johan Hovold2ec74a92015-05-04 17:10:41 +0200215static void gpio_sysfs_free_irq(struct device *dev)
216{
217 struct gpiod_data *data = dev_get_drvdata(dev);
218 struct gpio_desc *desc = data->desc;
219
Johan Hovoldcef17172015-05-04 17:10:48 +0200220 data->irq_flags = 0;
Johan Hovold2ec74a92015-05-04 17:10:41 +0200221 free_irq(data->irq, data);
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100222 gpiochip_unlock_as_irq(desc->gdev->chip, gpio_chip_hwgpio(desc));
Johan Hovold2ec74a92015-05-04 17:10:41 +0200223 sysfs_put(data->value_kn);
224}
225
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900226static const struct {
227 const char *name;
Johan Hovoldcef17172015-05-04 17:10:48 +0200228 unsigned char flags;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900229} trigger_types[] = {
230 { "none", 0 },
Johan Hovoldcef17172015-05-04 17:10:48 +0200231 { "falling", GPIO_IRQF_TRIGGER_FALLING },
232 { "rising", GPIO_IRQF_TRIGGER_RISING },
233 { "both", GPIO_IRQF_TRIGGER_BOTH },
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900234};
235
Johan Hovold6beac9d12015-05-04 17:10:34 +0200236static ssize_t edge_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900237 struct device_attribute *attr, char *buf)
238{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200239 struct gpiod_data *data = dev_get_drvdata(dev);
Johan Hovoldf0b78662015-05-04 17:10:36 +0200240 ssize_t status = 0;
241 int i;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900242
Johan Hovold6ffcb792015-05-04 17:10:44 +0200243 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900244
Johan Hovoldf0b78662015-05-04 17:10:36 +0200245 for (i = 0; i < ARRAY_SIZE(trigger_types); i++) {
Johan Hovoldcef17172015-05-04 17:10:48 +0200246 if (data->irq_flags == trigger_types[i].flags) {
Johan Hovoldf0b78662015-05-04 17:10:36 +0200247 status = sprintf(buf, "%s\n", trigger_types[i].name);
248 break;
249 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900250 }
251
Johan Hovold6ffcb792015-05-04 17:10:44 +0200252 mutex_unlock(&data->mutex);
253
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900254 return status;
255}
256
Johan Hovold6beac9d12015-05-04 17:10:34 +0200257static ssize_t edge_store(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900258 struct device_attribute *attr, const char *buf, size_t size)
259{
Johan Hovoldb91e1802015-05-04 17:10:40 +0200260 struct gpiod_data *data = dev_get_drvdata(dev);
Johan Hovoldcef17172015-05-04 17:10:48 +0200261 unsigned char flags;
Johan Hovold2ec74a92015-05-04 17:10:41 +0200262 ssize_t status = size;
Johan Hovolde4339ce2015-05-04 17:10:42 +0200263 int i;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900264
Johan Hovolde4339ce2015-05-04 17:10:42 +0200265 for (i = 0; i < ARRAY_SIZE(trigger_types); i++) {
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900266 if (sysfs_streq(trigger_types[i].name, buf))
Johan Hovolde4339ce2015-05-04 17:10:42 +0200267 break;
268 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900269
Johan Hovolde4339ce2015-05-04 17:10:42 +0200270 if (i == ARRAY_SIZE(trigger_types))
271 return -EINVAL;
272
Johan Hovoldb91e1802015-05-04 17:10:40 +0200273 flags = trigger_types[i].flags;
274
Johan Hovold6ffcb792015-05-04 17:10:44 +0200275 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900276
Johan Hovoldcef17172015-05-04 17:10:48 +0200277 if (flags == data->irq_flags) {
Johan Hovoldb91e1802015-05-04 17:10:40 +0200278 status = size;
279 goto out_unlock;
280 }
281
Johan Hovoldcef17172015-05-04 17:10:48 +0200282 if (data->irq_flags)
Johan Hovold2ec74a92015-05-04 17:10:41 +0200283 gpio_sysfs_free_irq(dev);
284
285 if (flags) {
286 status = gpio_sysfs_request_irq(dev, flags);
287 if (!status)
288 status = size;
289 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900290
Johan Hovoldb91e1802015-05-04 17:10:40 +0200291out_unlock:
Johan Hovold6ffcb792015-05-04 17:10:44 +0200292 mutex_unlock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900293
294 return status;
295}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200296static DEVICE_ATTR_RW(edge);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900297
Johan Hovold6ffcb792015-05-04 17:10:44 +0200298/* Caller holds gpiod-data mutex. */
Johan Hovold2f323b82015-05-04 17:10:46 +0200299static int gpio_sysfs_set_active_low(struct device *dev, int value)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900300{
Johan Hovold0f628502015-05-04 17:10:38 +0200301 struct gpiod_data *data = dev_get_drvdata(dev);
302 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900303 int status = 0;
Johan Hovoldcef17172015-05-04 17:10:48 +0200304 unsigned int flags = data->irq_flags;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900305
306 if (!!test_bit(FLAG_ACTIVE_LOW, &desc->flags) == !!value)
307 return 0;
308
309 if (value)
310 set_bit(FLAG_ACTIVE_LOW, &desc->flags);
311 else
312 clear_bit(FLAG_ACTIVE_LOW, &desc->flags);
313
314 /* reconfigure poll(2) support if enabled on one edge only */
Johan Hovoldcef17172015-05-04 17:10:48 +0200315 if (flags == GPIO_IRQF_TRIGGER_FALLING ||
316 flags == GPIO_IRQF_TRIGGER_RISING) {
Johan Hovold2ec74a92015-05-04 17:10:41 +0200317 gpio_sysfs_free_irq(dev);
Johan Hovoldcef17172015-05-04 17:10:48 +0200318 status = gpio_sysfs_request_irq(dev, flags);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900319 }
320
321 return status;
322}
323
Johan Hovold6beac9d12015-05-04 17:10:34 +0200324static ssize_t active_low_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900325 struct device_attribute *attr, char *buf)
326{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200327 struct gpiod_data *data = dev_get_drvdata(dev);
328 struct gpio_desc *desc = data->desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900329 ssize_t status;
330
Johan Hovold6ffcb792015-05-04 17:10:44 +0200331 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900332
Johan Hovoldf0b78662015-05-04 17:10:36 +0200333 status = sprintf(buf, "%d\n",
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900334 !!test_bit(FLAG_ACTIVE_LOW, &desc->flags));
335
Johan Hovold6ffcb792015-05-04 17:10:44 +0200336 mutex_unlock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900337
338 return status;
339}
340
Johan Hovold6beac9d12015-05-04 17:10:34 +0200341static ssize_t active_low_store(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900342 struct device_attribute *attr, const char *buf, size_t size)
343{
Johan Hovold6ffcb792015-05-04 17:10:44 +0200344 struct gpiod_data *data = dev_get_drvdata(dev);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900345 ssize_t status;
Johan Hovoldf0b78662015-05-04 17:10:36 +0200346 long value;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900347
Johan Hovold6ffcb792015-05-04 17:10:44 +0200348 mutex_lock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900349
Johan Hovoldf0b78662015-05-04 17:10:36 +0200350 status = kstrtol(buf, 0, &value);
351 if (status == 0)
Johan Hovold2f323b82015-05-04 17:10:46 +0200352 status = gpio_sysfs_set_active_low(dev, value);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900353
Johan Hovold6ffcb792015-05-04 17:10:44 +0200354 mutex_unlock(&data->mutex);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900355
356 return status ? : size;
357}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200358static DEVICE_ATTR_RW(active_low);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900359
Johan Hovoldebbeba12015-01-13 13:00:06 +0100360static umode_t gpio_is_visible(struct kobject *kobj, struct attribute *attr,
361 int n)
362{
363 struct device *dev = container_of(kobj, struct device, kobj);
Johan Hovoldc43960f2015-05-04 17:10:37 +0200364 struct gpiod_data *data = dev_get_drvdata(dev);
365 struct gpio_desc *desc = data->desc;
Johan Hovoldebbeba12015-01-13 13:00:06 +0100366 umode_t mode = attr->mode;
Johan Hovold427fdee2015-05-04 17:10:47 +0200367 bool show_direction = data->direction_can_change;
Johan Hovoldebbeba12015-01-13 13:00:06 +0100368
369 if (attr == &dev_attr_direction.attr) {
370 if (!show_direction)
371 mode = 0;
372 } else if (attr == &dev_attr_edge.attr) {
373 if (gpiod_to_irq(desc) < 0)
374 mode = 0;
375 if (!show_direction && test_bit(FLAG_IS_OUT, &desc->flags))
376 mode = 0;
377 }
378
379 return mode;
380}
381
Johan Hovold0915e6f2015-01-13 13:00:05 +0100382static struct attribute *gpio_attrs[] = {
Johan Hovoldebbeba12015-01-13 13:00:06 +0100383 &dev_attr_direction.attr,
384 &dev_attr_edge.attr,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900385 &dev_attr_value.attr,
386 &dev_attr_active_low.attr,
387 NULL,
388};
Johan Hovoldebbeba12015-01-13 13:00:06 +0100389
390static const struct attribute_group gpio_group = {
391 .attrs = gpio_attrs,
392 .is_visible = gpio_is_visible,
393};
394
395static const struct attribute_group *gpio_groups[] = {
396 &gpio_group,
397 NULL
398};
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900399
400/*
401 * /sys/class/gpio/gpiochipN/
402 * /base ... matching gpio_chip.base (N)
403 * /label ... matching gpio_chip.label
404 * /ngpio ... matching gpio_chip.ngpio
405 */
406
Johan Hovold6beac9d12015-05-04 17:10:34 +0200407static ssize_t base_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900408 struct device_attribute *attr, char *buf)
409{
410 const struct gpio_chip *chip = dev_get_drvdata(dev);
411
412 return sprintf(buf, "%d\n", chip->base);
413}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200414static DEVICE_ATTR_RO(base);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900415
Johan Hovold6beac9d12015-05-04 17:10:34 +0200416static ssize_t label_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900417 struct device_attribute *attr, char *buf)
418{
419 const struct gpio_chip *chip = dev_get_drvdata(dev);
420
421 return sprintf(buf, "%s\n", chip->label ? : "");
422}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200423static DEVICE_ATTR_RO(label);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900424
Johan Hovold6beac9d12015-05-04 17:10:34 +0200425static ssize_t ngpio_show(struct device *dev,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900426 struct device_attribute *attr, char *buf)
427{
428 const struct gpio_chip *chip = dev_get_drvdata(dev);
429
430 return sprintf(buf, "%u\n", chip->ngpio);
431}
Johan Hovold6beac9d12015-05-04 17:10:34 +0200432static DEVICE_ATTR_RO(ngpio);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900433
Johan Hovold121b6a72015-01-13 13:00:04 +0100434static struct attribute *gpiochip_attrs[] = {
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900435 &dev_attr_base.attr,
436 &dev_attr_label.attr,
437 &dev_attr_ngpio.attr,
438 NULL,
439};
Johan Hovold121b6a72015-01-13 13:00:04 +0100440ATTRIBUTE_GROUPS(gpiochip);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900441
Masami Hiramatsu90b05b02017-08-02 13:47:42 +0900442static struct gpio_desc *gpio_to_valid_desc(int gpio)
443{
444 return gpio_is_valid(gpio) ? gpio_to_desc(gpio) : NULL;
445}
446
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900447/*
448 * /sys/class/gpio/export ... write-only
449 * integer N ... number of GPIO to export (full access)
450 * /sys/class/gpio/unexport ... write-only
451 * integer N ... number of GPIO to unexport
452 */
453static ssize_t export_store(struct class *class,
454 struct class_attribute *attr,
455 const char *buf, size_t len)
456{
457 long gpio;
458 struct gpio_desc *desc;
459 int status;
460
461 status = kstrtol(buf, 0, &gpio);
462 if (status < 0)
463 goto done;
464
Masami Hiramatsu90b05b02017-08-02 13:47:42 +0900465 desc = gpio_to_valid_desc(gpio);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900466 /* reject invalid GPIOs */
467 if (!desc) {
468 pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
469 return -EINVAL;
470 }
471
472 /* No extra locking here; FLAG_SYSFS just signifies that the
473 * request and export were done by on behalf of userspace, so
474 * they may be undone on its behalf too.
475 */
476
477 status = gpiod_request(desc, "sysfs");
478 if (status < 0) {
479 if (status == -EPROBE_DEFER)
480 status = -ENODEV;
481 goto done;
482 }
Andrew Jefferye10f72b2017-11-30 14:25:24 +1030483
484 status = gpiod_set_transitory(desc, false);
485 if (!status) {
486 status = gpiod_export(desc, true);
487 if (status < 0)
488 gpiod_free(desc);
489 else
490 set_bit(FLAG_SYSFS, &desc->flags);
491 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900492
493done:
494 if (status)
495 pr_debug("%s: status %d\n", __func__, status);
496 return status ? : len;
497}
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200498static CLASS_ATTR_WO(export);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900499
500static ssize_t unexport_store(struct class *class,
501 struct class_attribute *attr,
502 const char *buf, size_t len)
503{
504 long gpio;
505 struct gpio_desc *desc;
506 int status;
507
508 status = kstrtol(buf, 0, &gpio);
509 if (status < 0)
510 goto done;
511
Masami Hiramatsu90b05b02017-08-02 13:47:42 +0900512 desc = gpio_to_valid_desc(gpio);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900513 /* reject bogus commands (gpio_unexport ignores them) */
514 if (!desc) {
515 pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
516 return -EINVAL;
517 }
518
519 status = -EINVAL;
520
521 /* No extra locking here; FLAG_SYSFS just signifies that the
522 * request and export were done by on behalf of userspace, so
523 * they may be undone on its behalf too.
524 */
525 if (test_and_clear_bit(FLAG_SYSFS, &desc->flags)) {
526 status = 0;
527 gpiod_free(desc);
528 }
529done:
530 if (status)
531 pr_debug("%s: status %d\n", __func__, status);
532 return status ? : len;
533}
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200534static CLASS_ATTR_WO(unexport);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900535
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200536static struct attribute *gpio_class_attrs[] = {
537 &class_attr_export.attr,
538 &class_attr_unexport.attr,
539 NULL,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900540};
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200541ATTRIBUTE_GROUPS(gpio_class);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900542
543static struct class gpio_class = {
544 .name = "gpio",
545 .owner = THIS_MODULE,
546
Greg Kroah-Hartmand83bb152017-06-08 10:12:40 +0200547 .class_groups = gpio_class_groups,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900548};
549
550
551/**
552 * gpiod_export - export a GPIO through sysfs
Thierry Reding2d9d0512017-07-24 16:57:26 +0200553 * @desc: GPIO to make available, already requested
554 * @direction_may_change: true if userspace may change GPIO direction
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900555 * Context: arch_initcall or later
556 *
557 * When drivers want to make a GPIO accessible to userspace after they
558 * have requested it -- perhaps while debugging, or as part of their
559 * public interface -- they may use this routine. If the GPIO can
560 * change direction (some can't) and the caller allows it, userspace
561 * will see "direction" sysfs attribute which may be used to change
562 * the gpio's direction. A "value" attribute will always be provided.
563 *
564 * Returns zero on success, else an error.
565 */
566int gpiod_export(struct gpio_desc *desc, bool direction_may_change)
567{
Johan Hovold483d8212015-04-21 17:42:09 +0200568 struct gpio_chip *chip;
Linus Walleijff2b1352015-10-20 11:10:38 +0200569 struct gpio_device *gdev;
Johan Hovoldc43960f2015-05-04 17:10:37 +0200570 struct gpiod_data *data;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900571 unsigned long flags;
572 int status;
573 const char *ioname = NULL;
574 struct device *dev;
575 int offset;
576
577 /* can't export until sysfs is available ... */
578 if (!gpio_class.p) {
579 pr_debug("%s: called too early!\n", __func__);
580 return -ENOENT;
581 }
582
583 if (!desc) {
584 pr_debug("%s: invalid gpio descriptor\n", __func__);
585 return -EINVAL;
586 }
587
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100588 gdev = desc->gdev;
589 chip = gdev->chip;
Johan Hovold483d8212015-04-21 17:42:09 +0200590
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900591 mutex_lock(&sysfs_lock);
592
Johan Hovold483d8212015-04-21 17:42:09 +0200593 /* check if chip is being removed */
Linus Walleijafbc4f32016-02-09 13:21:06 +0100594 if (!chip || !gdev->mockdev) {
Johan Hovold483d8212015-04-21 17:42:09 +0200595 status = -ENODEV;
Johan Hovoldc43960f2015-05-04 17:10:37 +0200596 goto err_unlock;
Johan Hovold483d8212015-04-21 17:42:09 +0200597 }
598
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900599 spin_lock_irqsave(&gpio_lock, flags);
600 if (!test_bit(FLAG_REQUESTED, &desc->flags) ||
601 test_bit(FLAG_EXPORT, &desc->flags)) {
602 spin_unlock_irqrestore(&gpio_lock, flags);
603 gpiod_dbg(desc, "%s: unavailable (requested=%d, exported=%d)\n",
604 __func__,
605 test_bit(FLAG_REQUESTED, &desc->flags),
606 test_bit(FLAG_EXPORT, &desc->flags));
607 status = -EPERM;
Johan Hovoldc43960f2015-05-04 17:10:37 +0200608 goto err_unlock;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900609 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900610 spin_unlock_irqrestore(&gpio_lock, flags);
611
Johan Hovoldc43960f2015-05-04 17:10:37 +0200612 data = kzalloc(sizeof(*data), GFP_KERNEL);
613 if (!data) {
614 status = -ENOMEM;
615 goto err_unlock;
616 }
617
618 data->desc = desc;
Johan Hovold6ffcb792015-05-04 17:10:44 +0200619 mutex_init(&data->mutex);
Johan Hovold427fdee2015-05-04 17:10:47 +0200620 if (chip->direction_input && chip->direction_output)
621 data->direction_can_change = direction_may_change;
622 else
623 data->direction_can_change = false;
Johan Hovoldc43960f2015-05-04 17:10:37 +0200624
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900625 offset = gpio_chip_hwgpio(desc);
Johan Hovoldcecf58a2015-05-04 17:10:29 +0200626 if (chip->names && chip->names[offset])
627 ioname = chip->names[offset];
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900628
Linus Walleijff2b1352015-10-20 11:10:38 +0200629 dev = device_create_with_groups(&gpio_class, &gdev->dev,
Johan Hovoldc43960f2015-05-04 17:10:37 +0200630 MKDEV(0, 0), data, gpio_groups,
Johan Hovold0915e6f2015-01-13 13:00:05 +0100631 ioname ? ioname : "gpio%u",
632 desc_to_gpio(desc));
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900633 if (IS_ERR(dev)) {
634 status = PTR_ERR(dev);
Johan Hovoldc43960f2015-05-04 17:10:37 +0200635 goto err_free_data;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900636 }
637
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900638 set_bit(FLAG_EXPORT, &desc->flags);
639 mutex_unlock(&sysfs_lock);
640 return 0;
641
Johan Hovoldc43960f2015-05-04 17:10:37 +0200642err_free_data:
643 kfree(data);
644err_unlock:
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900645 mutex_unlock(&sysfs_lock);
646 gpiod_dbg(desc, "%s: status %d\n", __func__, status);
647 return status;
648}
649EXPORT_SYMBOL_GPL(gpiod_export);
650
Johan Hovoldc43960f2015-05-04 17:10:37 +0200651static int match_export(struct device *dev, const void *desc)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900652{
Johan Hovoldc43960f2015-05-04 17:10:37 +0200653 struct gpiod_data *data = dev_get_drvdata(dev);
654
655 return data->desc == desc;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900656}
657
658/**
659 * gpiod_export_link - create a sysfs link to an exported GPIO node
660 * @dev: device under which to create symlink
661 * @name: name of the symlink
Thierry Reding2d9d0512017-07-24 16:57:26 +0200662 * @desc: GPIO to create symlink to, already exported
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900663 *
664 * Set up a symlink from /sys/.../dev/name to /sys/class/gpio/gpioN
665 * node. Caller is responsible for unlinking.
666 *
667 * Returns zero on success, else an error.
668 */
669int gpiod_export_link(struct device *dev, const char *name,
670 struct gpio_desc *desc)
671{
Johan Hovold56d30ec2015-05-04 17:10:43 +0200672 struct device *cdev;
673 int ret;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900674
675 if (!desc) {
676 pr_warn("%s: invalid GPIO\n", __func__);
677 return -EINVAL;
678 }
679
Johan Hovold56d30ec2015-05-04 17:10:43 +0200680 cdev = class_find_device(&gpio_class, NULL, desc, match_export);
681 if (!cdev)
682 return -ENODEV;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900683
Johan Hovold56d30ec2015-05-04 17:10:43 +0200684 ret = sysfs_create_link(&dev->kobj, &cdev->kobj, name);
685 put_device(cdev);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900686
Johan Hovold56d30ec2015-05-04 17:10:43 +0200687 return ret;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900688}
689EXPORT_SYMBOL_GPL(gpiod_export_link);
690
691/**
Amitesh Singh31963eb2016-09-08 17:11:20 +0530692 * gpiod_unexport - reverse effect of gpiod_export()
Thierry Reding2d9d0512017-07-24 16:57:26 +0200693 * @desc: GPIO to make unavailable
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900694 *
Amitesh Singh31963eb2016-09-08 17:11:20 +0530695 * This is implicit on gpiod_free().
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900696 */
697void gpiod_unexport(struct gpio_desc *desc)
698{
Johan Hovold72eba6f2015-05-04 17:10:45 +0200699 struct gpiod_data *data;
700 struct device *dev;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900701
702 if (!desc) {
703 pr_warn("%s: invalid GPIO\n", __func__);
704 return;
705 }
706
707 mutex_lock(&sysfs_lock);
708
Johan Hovold72eba6f2015-05-04 17:10:45 +0200709 if (!test_bit(FLAG_EXPORT, &desc->flags))
710 goto err_unlock;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900711
Johan Hovold72eba6f2015-05-04 17:10:45 +0200712 dev = class_find_device(&gpio_class, NULL, desc, match_export);
713 if (!dev)
714 goto err_unlock;
715
716 data = dev_get_drvdata(dev);
717
Johan Hovold72eba6f2015-05-04 17:10:45 +0200718 clear_bit(FLAG_EXPORT, &desc->flags);
719
720 device_unregister(dev);
721
722 /*
723 * Release irq after deregistration to prevent race with edge_store.
724 */
Johan Hovoldcef17172015-05-04 17:10:48 +0200725 if (data->irq_flags)
Johan Hovold72eba6f2015-05-04 17:10:45 +0200726 gpio_sysfs_free_irq(dev);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900727
728 mutex_unlock(&sysfs_lock);
729
Johan Hovold72eba6f2015-05-04 17:10:45 +0200730 put_device(dev);
731 kfree(data);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900732
Johan Hovold72eba6f2015-05-04 17:10:45 +0200733 return;
734
735err_unlock:
736 mutex_unlock(&sysfs_lock);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900737}
738EXPORT_SYMBOL_GPL(gpiod_unexport);
739
Linus Walleijafbc4f32016-02-09 13:21:06 +0100740int gpiochip_sysfs_register(struct gpio_device *gdev)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900741{
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900742 struct device *dev;
Bamvor Jian Zhangd27c1722016-02-24 22:17:19 +0800743 struct device *parent;
Linus Walleijafbc4f32016-02-09 13:21:06 +0100744 struct gpio_chip *chip = gdev->chip;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900745
Johan Hovold426577b2015-05-04 17:10:32 +0200746 /*
747 * Many systems add gpio chips for SOC support very early,
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900748 * before driver model support is available. In those cases we
Johan Hovold426577b2015-05-04 17:10:32 +0200749 * register later, in gpiolib_sysfs_init() ... here we just
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900750 * verify that _some_ field of gpio_class got initialized.
751 */
752 if (!gpio_class.p)
753 return 0;
754
Bamvor Jian Zhangd27c1722016-02-24 22:17:19 +0800755 /*
756 * For sysfs backward compatibility we need to preserve this
757 * preferred parenting to the gpio_chip parent field, if set.
758 */
759 if (chip->parent)
760 parent = chip->parent;
761 else
762 parent = &gdev->dev;
763
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900764 /* use chip->base for the ID; it's already known to be unique */
Bamvor Jian Zhangd27c1722016-02-24 22:17:19 +0800765 dev = device_create_with_groups(&gpio_class, parent,
Linus Walleij58383c782015-11-04 09:56:26 +0100766 MKDEV(0, 0),
Johan Hovold121b6a72015-01-13 13:00:04 +0100767 chip, gpiochip_groups,
768 "gpiochip%d", chip->base);
769 if (IS_ERR(dev))
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200770 return PTR_ERR(dev);
Johan Hovold3ff74be2015-05-04 17:10:30 +0200771
772 mutex_lock(&sysfs_lock);
Linus Walleijafbc4f32016-02-09 13:21:06 +0100773 gdev->mockdev = dev;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900774 mutex_unlock(&sysfs_lock);
775
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200776 return 0;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900777}
778
Linus Walleijafbc4f32016-02-09 13:21:06 +0100779void gpiochip_sysfs_unregister(struct gpio_device *gdev)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900780{
Johan Hovold483d8212015-04-21 17:42:09 +0200781 struct gpio_desc *desc;
Linus Walleijafbc4f32016-02-09 13:21:06 +0100782 struct gpio_chip *chip = gdev->chip;
Johan Hovold483d8212015-04-21 17:42:09 +0200783 unsigned int i;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900784
Linus Walleijafbc4f32016-02-09 13:21:06 +0100785 if (!gdev->mockdev)
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200786 return;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900787
Linus Walleijafbc4f32016-02-09 13:21:06 +0100788 device_unregister(gdev->mockdev);
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200789
790 /* prevent further gpiod exports */
791 mutex_lock(&sysfs_lock);
Linus Walleijafbc4f32016-02-09 13:21:06 +0100792 gdev->mockdev = NULL;
Johan Hovold6a4b6b02015-05-04 17:10:31 +0200793 mutex_unlock(&sysfs_lock);
Johan Hovold483d8212015-04-21 17:42:09 +0200794
795 /* unregister gpiod class devices owned by sysfs */
796 for (i = 0; i < chip->ngpio; i++) {
Linus Walleijfdeb8e12016-02-10 10:57:36 +0100797 desc = &gdev->descs[i];
Johan Hovold483d8212015-04-21 17:42:09 +0200798 if (test_and_clear_bit(FLAG_SYSFS, &desc->flags))
799 gpiod_free(desc);
800 }
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900801}
802
803static int __init gpiolib_sysfs_init(void)
804{
805 int status;
806 unsigned long flags;
Linus Walleijff2b1352015-10-20 11:10:38 +0200807 struct gpio_device *gdev;
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900808
809 status = class_register(&gpio_class);
810 if (status < 0)
811 return status;
812
813 /* Scan and register the gpio_chips which registered very
814 * early (e.g. before the class_register above was called).
815 *
816 * We run before arch_initcall() so chip->dev nodes can have
817 * registered, and so arch_initcall() can always gpio_export().
818 */
819 spin_lock_irqsave(&gpio_lock, flags);
Linus Walleijff2b1352015-10-20 11:10:38 +0200820 list_for_each_entry(gdev, &gpio_devices, list) {
Linus Walleijafbc4f32016-02-09 13:21:06 +0100821 if (gdev->mockdev)
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900822 continue;
823
Alexandre Courbot14141a92014-07-22 16:17:40 +0900824 /*
Johan Hovold426577b2015-05-04 17:10:32 +0200825 * TODO we yield gpio_lock here because
826 * gpiochip_sysfs_register() acquires a mutex. This is unsafe
827 * and needs to be fixed.
Alexandre Courbot14141a92014-07-22 16:17:40 +0900828 *
829 * Also it would be nice to use gpiochip_find() here so we
830 * can keep gpio_chips local to gpiolib.c, but the yield of
831 * gpio_lock prevents us from doing this.
832 */
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900833 spin_unlock_irqrestore(&gpio_lock, flags);
Linus Walleijafbc4f32016-02-09 13:21:06 +0100834 status = gpiochip_sysfs_register(gdev);
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900835 spin_lock_irqsave(&gpio_lock, flags);
836 }
837 spin_unlock_irqrestore(&gpio_lock, flags);
838
Alexandre Courbot0eb4c6c2014-07-01 14:45:15 +0900839 return status;
840}
841postcore_initcall(gpiolib_sysfs_init);