blob: f46ad75dc96af187ea22990a09e63d051aa4bbca [file] [log] [blame]
Miklos Szeredibbb1e542016-12-16 11:02:56 +01001/*
2 * Copyright (C) 2011 Novell Inc.
3 * Copyright (C) 2016 Red Hat, Inc.
4 *
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published by
7 * the Free Software Foundation.
8 */
9
10#include <linux/fs.h>
11#include <linux/mount.h>
12#include <linux/slab.h>
Ingo Molnar5b825c32017-02-02 17:54:15 +010013#include <linux/cred.h>
Miklos Szeredibbb1e542016-12-16 11:02:56 +010014#include <linux/xattr.h>
Amir Goldstein02bcd152017-06-21 15:28:36 +030015#include <linux/exportfs.h>
16#include <linux/uuid.h>
Amir Goldsteincaf70cb2017-06-21 13:46:12 +030017#include <linux/namei.h>
18#include <linux/ratelimit.h>
Miklos Szeredibbb1e542016-12-16 11:02:56 +010019#include "overlayfs.h"
20#include "ovl_entry.h"
21
22int ovl_want_write(struct dentry *dentry)
23{
24 struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
25 return mnt_want_write(ofs->upper_mnt);
26}
27
28void ovl_drop_write(struct dentry *dentry)
29{
30 struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
31 mnt_drop_write(ofs->upper_mnt);
32}
33
34struct dentry *ovl_workdir(struct dentry *dentry)
35{
36 struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
37 return ofs->workdir;
38}
39
40const struct cred *ovl_override_creds(struct super_block *sb)
41{
42 struct ovl_fs *ofs = sb->s_fs_info;
43
44 return override_creds(ofs->creator_cred);
45}
46
Amir Goldstein7bcd74b2017-03-22 08:42:21 -040047struct super_block *ovl_same_sb(struct super_block *sb)
48{
49 struct ovl_fs *ofs = sb->s_fs_info;
50
51 return ofs->same_sb;
52}
53
Amir Goldstein02bcd152017-06-21 15:28:36 +030054bool ovl_can_decode_fh(struct super_block *sb)
55{
56 return (sb->s_export_op && sb->s_export_op->fh_to_dentry &&
57 !uuid_is_null(&sb->s_uuid));
58}
59
60struct dentry *ovl_indexdir(struct super_block *sb)
61{
62 struct ovl_fs *ofs = sb->s_fs_info;
63
64 return ofs->indexdir;
65}
66
Miklos Szeredibbb1e542016-12-16 11:02:56 +010067struct ovl_entry *ovl_alloc_entry(unsigned int numlower)
68{
69 size_t size = offsetof(struct ovl_entry, lowerstack[numlower]);
70 struct ovl_entry *oe = kzalloc(size, GFP_KERNEL);
71
72 if (oe)
73 oe->numlower = numlower;
74
75 return oe;
76}
77
78bool ovl_dentry_remote(struct dentry *dentry)
79{
80 return dentry->d_flags &
81 (DCACHE_OP_REVALIDATE | DCACHE_OP_WEAK_REVALIDATE |
82 DCACHE_OP_REAL);
83}
84
85bool ovl_dentry_weird(struct dentry *dentry)
86{
87 return dentry->d_flags & (DCACHE_NEED_AUTOMOUNT |
88 DCACHE_MANAGE_TRANSIT |
89 DCACHE_OP_HASH |
90 DCACHE_OP_COMPARE);
91}
92
93enum ovl_path_type ovl_path_type(struct dentry *dentry)
94{
95 struct ovl_entry *oe = dentry->d_fsdata;
96 enum ovl_path_type type = 0;
97
Miklos Szeredi09d8b582017-07-04 22:03:16 +020098 if (ovl_dentry_upper(dentry)) {
Miklos Szeredibbb1e542016-12-16 11:02:56 +010099 type = __OVL_PATH_UPPER;
100
101 /*
Amir Goldstein59548502017-04-23 23:12:34 +0300102 * Non-dir dentry can hold lower dentry of its copy up origin.
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100103 */
Amir Goldstein59548502017-04-23 23:12:34 +0300104 if (oe->numlower) {
105 type |= __OVL_PATH_ORIGIN;
106 if (d_is_dir(dentry))
107 type |= __OVL_PATH_MERGE;
108 }
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100109 } else {
110 if (oe->numlower > 1)
111 type |= __OVL_PATH_MERGE;
112 }
113 return type;
114}
115
116void ovl_path_upper(struct dentry *dentry, struct path *path)
117{
118 struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100119
120 path->mnt = ofs->upper_mnt;
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200121 path->dentry = ovl_dentry_upper(dentry);
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100122}
123
124void ovl_path_lower(struct dentry *dentry, struct path *path)
125{
126 struct ovl_entry *oe = dentry->d_fsdata;
127
Kees Cook33006cd2017-03-29 14:02:19 -0700128 *path = oe->numlower ? oe->lowerstack[0] : (struct path) { };
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100129}
130
131enum ovl_path_type ovl_path_real(struct dentry *dentry, struct path *path)
132{
133 enum ovl_path_type type = ovl_path_type(dentry);
134
135 if (!OVL_TYPE_UPPER(type))
136 ovl_path_lower(dentry, path);
137 else
138 ovl_path_upper(dentry, path);
139
140 return type;
141}
142
143struct dentry *ovl_dentry_upper(struct dentry *dentry)
144{
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200145 return ovl_upperdentry_dereference(OVL_I(d_inode(dentry)));
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100146}
147
148struct dentry *ovl_dentry_lower(struct dentry *dentry)
149{
150 struct ovl_entry *oe = dentry->d_fsdata;
151
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200152 return oe->numlower ? oe->lowerstack[0].dentry : NULL;
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100153}
154
155struct dentry *ovl_dentry_real(struct dentry *dentry)
156{
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200157 return ovl_dentry_upper(dentry) ?: ovl_dentry_lower(dentry);
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100158}
159
Miklos Szeredi1d88f182017-07-20 11:08:21 +0200160struct dentry *ovl_i_dentry_upper(struct inode *inode)
161{
162 return ovl_upperdentry_dereference(OVL_I(inode));
163}
164
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200165struct inode *ovl_inode_upper(struct inode *inode)
Miklos Szeredi25b77132017-07-04 22:03:16 +0200166{
Miklos Szeredi1d88f182017-07-20 11:08:21 +0200167 struct dentry *upperdentry = ovl_i_dentry_upper(inode);
Miklos Szeredi25b77132017-07-04 22:03:16 +0200168
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200169 return upperdentry ? d_inode(upperdentry) : NULL;
Miklos Szeredi25b77132017-07-04 22:03:16 +0200170}
171
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200172struct inode *ovl_inode_lower(struct inode *inode)
173{
174 return OVL_I(inode)->lower;
175}
176
177struct inode *ovl_inode_real(struct inode *inode)
178{
179 return ovl_inode_upper(inode) ?: ovl_inode_lower(inode);
180}
181
182
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100183struct ovl_dir_cache *ovl_dir_cache(struct dentry *dentry)
184{
Miklos Szeredi04a01ac2017-07-04 22:03:16 +0200185 return OVL_I(d_inode(dentry))->cache;
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100186}
187
188void ovl_set_dir_cache(struct dentry *dentry, struct ovl_dir_cache *cache)
189{
Miklos Szeredi04a01ac2017-07-04 22:03:16 +0200190 OVL_I(d_inode(dentry))->cache = cache;
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100191}
192
193bool ovl_dentry_is_opaque(struct dentry *dentry)
194{
195 struct ovl_entry *oe = dentry->d_fsdata;
196 return oe->opaque;
197}
198
199bool ovl_dentry_is_whiteout(struct dentry *dentry)
200{
201 return !dentry->d_inode && ovl_dentry_is_opaque(dentry);
202}
203
Miklos Szeredi5cf5b472016-12-16 11:02:57 +0100204void ovl_dentry_set_opaque(struct dentry *dentry)
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100205{
206 struct ovl_entry *oe = dentry->d_fsdata;
Miklos Szeredi5cf5b472016-12-16 11:02:57 +0100207
208 oe->opaque = true;
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100209}
210
Miklos Szeredi55acc662017-07-04 22:03:18 +0200211/*
212 * For hard links it's possible for ovl_dentry_upper() to return positive, while
213 * there's no actual upper alias for the inode. Copy up code needs to know
214 * about the existence of the upper alias, so it can't use ovl_dentry_upper().
215 */
216bool ovl_dentry_has_upper_alias(struct dentry *dentry)
217{
218 struct ovl_entry *oe = dentry->d_fsdata;
219
220 return oe->has_upper;
221}
222
223void ovl_dentry_set_upper_alias(struct dentry *dentry)
224{
225 struct ovl_entry *oe = dentry->d_fsdata;
226
227 oe->has_upper = true;
228}
229
Miklos Szeredia6c60652016-12-16 11:02:56 +0100230bool ovl_redirect_dir(struct super_block *sb)
231{
232 struct ovl_fs *ofs = sb->s_fs_info;
233
Amir Goldstein21a22872017-05-17 00:12:41 +0300234 return ofs->config.redirect_dir && !ofs->noxattr;
Miklos Szeredia6c60652016-12-16 11:02:56 +0100235}
236
237const char *ovl_dentry_get_redirect(struct dentry *dentry)
238{
Miklos Szeredicf31c462017-07-04 22:03:16 +0200239 return OVL_I(d_inode(dentry))->redirect;
Miklos Szeredia6c60652016-12-16 11:02:56 +0100240}
241
242void ovl_dentry_set_redirect(struct dentry *dentry, const char *redirect)
243{
Miklos Szeredicf31c462017-07-04 22:03:16 +0200244 struct ovl_inode *oi = OVL_I(d_inode(dentry));
Miklos Szeredia6c60652016-12-16 11:02:56 +0100245
Miklos Szeredicf31c462017-07-04 22:03:16 +0200246 kfree(oi->redirect);
247 oi->redirect = redirect;
Miklos Szeredia6c60652016-12-16 11:02:56 +0100248}
249
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200250void ovl_inode_init(struct inode *inode, struct dentry *upperdentry,
251 struct dentry *lowerdentry)
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100252{
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200253 if (upperdentry)
254 OVL_I(inode)->__upperdentry = upperdentry;
255 if (lowerdentry)
256 OVL_I(inode)->lower = d_inode(lowerdentry);
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100257
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200258 ovl_copyattr(d_inode(upperdentry ?: lowerdentry), inode);
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100259}
260
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200261void ovl_inode_update(struct inode *inode, struct dentry *upperdentry)
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100262{
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200263 struct inode *upperinode = d_inode(upperdentry);
Miklos Szeredie6d2ebd2017-07-04 22:03:16 +0200264
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200265 WARN_ON(OVL_I(inode)->__upperdentry);
266
Miklos Szeredi25b77132017-07-04 22:03:16 +0200267 /*
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200268 * Make sure upperdentry is consistent before making it visible
Miklos Szeredi25b77132017-07-04 22:03:16 +0200269 */
270 smp_wmb();
Miklos Szeredi09d8b582017-07-04 22:03:16 +0200271 OVL_I(inode)->__upperdentry = upperdentry;
Miklos Szeredib9ac5c272017-07-04 22:03:17 +0200272 if (!S_ISDIR(upperinode->i_mode) && inode_unhashed(inode)) {
Miklos Szeredi25b77132017-07-04 22:03:16 +0200273 inode->i_private = upperinode;
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100274 __insert_inode_hash(inode, (unsigned long) upperinode);
Miklos Szeredi25b77132017-07-04 22:03:16 +0200275 }
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100276}
277
278void ovl_dentry_version_inc(struct dentry *dentry)
279{
Miklos Szeredi04a01ac2017-07-04 22:03:16 +0200280 struct inode *inode = d_inode(dentry);
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100281
Miklos Szeredi04a01ac2017-07-04 22:03:16 +0200282 WARN_ON(!inode_is_locked(inode));
283 OVL_I(inode)->version++;
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100284}
285
286u64 ovl_dentry_version_get(struct dentry *dentry)
287{
Miklos Szeredi04a01ac2017-07-04 22:03:16 +0200288 struct inode *inode = d_inode(dentry);
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100289
Miklos Szeredi04a01ac2017-07-04 22:03:16 +0200290 WARN_ON(!inode_is_locked(inode));
291 return OVL_I(inode)->version;
Miklos Szeredibbb1e542016-12-16 11:02:56 +0100292}
293
294bool ovl_is_whiteout(struct dentry *dentry)
295{
296 struct inode *inode = dentry->d_inode;
297
298 return inode && IS_WHITEOUT(inode);
299}
300
301struct file *ovl_path_open(struct path *path, int flags)
302{
303 return dentry_open(path, flags | O_NOATIME, current_cred());
304}
Amir Goldstein39d3d602017-01-17 06:34:56 +0200305
306int ovl_copy_up_start(struct dentry *dentry)
307{
Amir Goldsteina015daf2017-06-21 15:28:51 +0300308 struct ovl_inode *oi = OVL_I(d_inode(dentry));
Amir Goldstein39d3d602017-01-17 06:34:56 +0200309 int err;
310
Amir Goldsteina015daf2017-06-21 15:28:51 +0300311 err = mutex_lock_interruptible(&oi->lock);
Amir Goldstein59be0972017-06-20 15:25:46 +0300312 if (!err && ovl_dentry_has_upper_alias(dentry)) {
Amir Goldsteina015daf2017-06-21 15:28:51 +0300313 err = 1; /* Already copied up */
314 mutex_unlock(&oi->lock);
Amir Goldstein39d3d602017-01-17 06:34:56 +0200315 }
Amir Goldstein39d3d602017-01-17 06:34:56 +0200316
317 return err;
318}
319
320void ovl_copy_up_end(struct dentry *dentry)
321{
Amir Goldsteina015daf2017-06-21 15:28:51 +0300322 mutex_unlock(&OVL_I(d_inode(dentry))->lock);
Amir Goldstein39d3d602017-01-17 06:34:56 +0200323}
Amir Goldstein82b749b2017-05-17 00:12:40 +0300324
Amir Goldsteinf3a15682017-05-24 15:29:33 +0300325bool ovl_check_dir_xattr(struct dentry *dentry, const char *name)
326{
327 int res;
328 char val;
329
330 if (!d_is_dir(dentry))
331 return false;
332
333 res = vfs_getxattr(dentry, name, &val, 1);
334 if (res == 1 && val == 'y')
335 return true;
336
337 return false;
338}
339
Amir Goldstein82b749b2017-05-17 00:12:40 +0300340int ovl_check_setxattr(struct dentry *dentry, struct dentry *upperdentry,
341 const char *name, const void *value, size_t size,
342 int xerr)
343{
344 int err;
345 struct ovl_fs *ofs = dentry->d_sb->s_fs_info;
346
347 if (ofs->noxattr)
348 return xerr;
349
350 err = ovl_do_setxattr(upperdentry, name, value, size, 0);
351
352 if (err == -EOPNOTSUPP) {
353 pr_warn("overlayfs: cannot set %s xattr on upper\n", name);
354 ofs->noxattr = true;
355 return xerr;
356 }
357
358 return err;
359}
Amir Goldsteinf3a15682017-05-24 15:29:33 +0300360
361int ovl_set_impure(struct dentry *dentry, struct dentry *upperdentry)
362{
363 int err;
Amir Goldsteinf3a15682017-05-24 15:29:33 +0300364
Miklos Szeredi13c72072017-07-04 22:03:16 +0200365 if (ovl_test_flag(OVL_IMPURE, d_inode(dentry)))
Amir Goldsteinf3a15682017-05-24 15:29:33 +0300366 return 0;
367
368 /*
369 * Do not fail when upper doesn't support xattrs.
370 * Upper inodes won't have origin nor redirect xattr anyway.
371 */
372 err = ovl_check_setxattr(dentry, upperdentry, OVL_XATTR_IMPURE,
373 "y", 1, 0);
374 if (!err)
Miklos Szeredi13c72072017-07-04 22:03:16 +0200375 ovl_set_flag(OVL_IMPURE, d_inode(dentry));
Amir Goldsteinf3a15682017-05-24 15:29:33 +0300376
377 return err;
378}
Miklos Szeredi13c72072017-07-04 22:03:16 +0200379
380void ovl_set_flag(unsigned long flag, struct inode *inode)
381{
382 set_bit(flag, &OVL_I(inode)->flags);
383}
384
385bool ovl_test_flag(unsigned long flag, struct inode *inode)
386{
387 return test_bit(flag, &OVL_I(inode)->flags);
388}
Amir Goldsteinad0af712017-06-21 15:28:32 +0300389
390/**
391 * Caller must hold a reference to inode to prevent it from being freed while
392 * it is marked inuse.
393 */
394bool ovl_inuse_trylock(struct dentry *dentry)
395{
396 struct inode *inode = d_inode(dentry);
397 bool locked = false;
398
399 spin_lock(&inode->i_lock);
400 if (!(inode->i_state & I_OVL_INUSE)) {
401 inode->i_state |= I_OVL_INUSE;
402 locked = true;
403 }
404 spin_unlock(&inode->i_lock);
405
406 return locked;
407}
408
409void ovl_inuse_unlock(struct dentry *dentry)
410{
411 if (dentry) {
412 struct inode *inode = d_inode(dentry);
413
414 spin_lock(&inode->i_lock);
415 WARN_ON(!(inode->i_state & I_OVL_INUSE));
416 inode->i_state &= ~I_OVL_INUSE;
417 spin_unlock(&inode->i_lock);
418 }
419}
Amir Goldstein5f8415d2017-06-20 15:35:14 +0300420
Amir Goldsteincaf70cb2017-06-21 13:46:12 +0300421/* Called must hold OVL_I(inode)->oi_lock */
422static void ovl_cleanup_index(struct dentry *dentry)
423{
424 struct inode *dir = ovl_indexdir(dentry->d_sb)->d_inode;
425 struct dentry *lowerdentry = ovl_dentry_lower(dentry);
426 struct dentry *upperdentry = ovl_dentry_upper(dentry);
427 struct dentry *index = NULL;
428 struct inode *inode;
429 struct qstr name;
430 int err;
431
432 err = ovl_get_index_name(lowerdentry, &name);
433 if (err)
434 goto fail;
435
436 inode = d_inode(upperdentry);
437 if (inode->i_nlink != 1) {
438 pr_warn_ratelimited("overlayfs: cleanup linked index (%pd2, ino=%lu, nlink=%u)\n",
439 upperdentry, inode->i_ino, inode->i_nlink);
440 /*
441 * We either have a bug with persistent union nlink or a lower
442 * hardlink was added while overlay is mounted. Adding a lower
443 * hardlink and then unlinking all overlay hardlinks would drop
444 * overlay nlink to zero before all upper inodes are unlinked.
445 * As a safety measure, when that situation is detected, set
446 * the overlay nlink to the index inode nlink minus one for the
447 * index entry itself.
448 */
449 set_nlink(d_inode(dentry), inode->i_nlink - 1);
450 ovl_set_nlink_upper(dentry);
451 goto out;
452 }
453
454 inode_lock_nested(dir, I_MUTEX_PARENT);
455 /* TODO: whiteout instead of cleanup to block future open by handle */
456 index = lookup_one_len(name.name, ovl_indexdir(dentry->d_sb), name.len);
457 err = PTR_ERR(index);
458 if (!IS_ERR(index))
459 err = ovl_cleanup(dir, index);
460 inode_unlock(dir);
461 if (err)
462 goto fail;
463
464out:
465 dput(index);
466 return;
467
468fail:
469 pr_err("overlayfs: cleanup index of '%pd2' failed (%i)\n", dentry, err);
470 goto out;
471}
472
Amir Goldstein5f8415d2017-06-20 15:35:14 +0300473/*
474 * Operations that change overlay inode and upper inode nlink need to be
475 * synchronized with copy up for persistent nlink accounting.
476 */
477int ovl_nlink_start(struct dentry *dentry, bool *locked)
478{
479 struct ovl_inode *oi = OVL_I(d_inode(dentry));
480 const struct cred *old_cred;
481 int err;
482
483 if (!d_inode(dentry) || d_is_dir(dentry))
484 return 0;
485
486 /*
487 * With inodes index is enabled, we store the union overlay nlink
488 * in an xattr on the index inode. When whiting out lower hardlinks
489 * we need to decrement the overlay persistent nlink, but before the
490 * first copy up, we have no upper index inode to store the xattr.
491 *
492 * As a workaround, before whiteout/rename over of a lower hardlink,
493 * copy up to create the upper index. Creating the upper index will
494 * initialize the overlay nlink, so it could be dropped if unlink
495 * or rename succeeds.
496 *
497 * TODO: implement metadata only index copy up when called with
498 * ovl_copy_up_flags(dentry, O_PATH).
499 */
500 if (ovl_indexdir(dentry->d_sb) && !ovl_dentry_has_upper_alias(dentry) &&
501 d_inode(ovl_dentry_lower(dentry))->i_nlink > 1) {
502 err = ovl_copy_up(dentry);
503 if (err)
504 return err;
505 }
506
507 err = mutex_lock_interruptible(&oi->lock);
508 if (err)
509 return err;
510
511 if (!ovl_test_flag(OVL_INDEX, d_inode(dentry)))
512 goto out;
513
514 old_cred = ovl_override_creds(dentry->d_sb);
515 /*
516 * The overlay inode nlink should be incremented/decremented IFF the
517 * upper operation succeeds, along with nlink change of upper inode.
518 * Therefore, before link/unlink/rename, we store the union nlink
519 * value relative to the upper inode nlink in an upper inode xattr.
520 */
521 err = ovl_set_nlink_upper(dentry);
522 revert_creds(old_cred);
523
524out:
525 if (err)
526 mutex_unlock(&oi->lock);
527 else
528 *locked = true;
529
530 return err;
531}
532
533void ovl_nlink_end(struct dentry *dentry, bool locked)
534{
Amir Goldsteincaf70cb2017-06-21 13:46:12 +0300535 if (locked) {
536 if (ovl_test_flag(OVL_INDEX, d_inode(dentry)) &&
537 d_inode(dentry)->i_nlink == 0) {
538 const struct cred *old_cred;
539
540 old_cred = ovl_override_creds(dentry->d_sb);
541 ovl_cleanup_index(dentry);
542 revert_creds(old_cred);
543 }
544
Amir Goldstein5f8415d2017-06-20 15:35:14 +0300545 mutex_unlock(&OVL_I(d_inode(dentry))->lock);
Amir Goldsteincaf70cb2017-06-21 13:46:12 +0300546 }
Amir Goldstein5f8415d2017-06-20 15:35:14 +0300547}