crypto: qce50: Fix unclocked access in unbind path
In unbind path crypto registers are accessed even if clocks are
disabled which results unclocked access to crypto register, this
patch fixes the same.
Change-Id: Ie56d4f2f0d4118e7d8efbd81b6aa128b1708e74b
Signed-off-by: AnilKumar Chimata <anilc@codeaurora.org>
diff --git a/drivers/crypto/msm/qce50.c b/drivers/crypto/msm/qce50.c
index 8643667..19f2289 100644
--- a/drivers/crypto/msm/qce50.c
+++ b/drivers/crypto/msm/qce50.c
@@ -1,7 +1,7 @@
/*
* QTI Crypto Engine driver.
*
- * Copyright (c) 2012-2017, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2012-2018, The Linux Foundation. All rights reserved.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 and
@@ -6118,13 +6118,15 @@
int qce_close(void *handle)
{
struct qce_device *pce_dev = (struct qce_device *) handle;
+ int ret = -1;
if (handle == NULL)
return -ENODEV;
mutex_lock(&qce_iomap_mutex);
- qce_enable_clk(pce_dev);
- qce_sps_exit(pce_dev);
+ ret = qce_enable_clk(pce_dev);
+ if (!ret)
+ qce_sps_exit(pce_dev);
if (pce_dev->iobase)
iounmap(pce_dev->iobase);
@@ -6137,7 +6139,8 @@
if (pce_dev->enable_s1_smmu)
qce_iommu_release_iomapping(pce_dev);
- qce_disable_clk(pce_dev);
+ if (!ret)
+ qce_disable_clk(pce_dev);
__qce_deinit_clk(pce_dev);
mutex_unlock(&qce_iomap_mutex);
kfree(handle);