blob: 25bbbb482bb6311642526300400c0ad8e92bd4ae [file] [log] [blame]
John Johansenc88d4c72010-07-29 14:48:00 -07001/*
2 * AppArmor security module
3 *
4 * This file contains AppArmor policy manipulation functions
5 *
6 * Copyright (C) 1998-2008 Novell/SUSE
7 * Copyright 2009-2010 Canonical Ltd.
8 *
9 * This program is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU General Public License as
11 * published by the Free Software Foundation, version 2 of the
12 * License.
13 *
14 *
15 * AppArmor policy is based around profiles, which contain the rules a
16 * task is confined by. Every task in the system has a profile attached
17 * to it determined either by matching "unconfined" tasks against the
18 * visible set of profiles or by following a profiles attachment rules.
19 *
20 * Each profile exists in a profile namespace which is a container of
21 * visible profiles. Each namespace contains a special "unconfined" profile,
22 * which doesn't enforce any confinement on a task beyond DAC.
23 *
24 * Namespace and profile names can be written together in either
25 * of two syntaxes.
26 * :namespace:profile - used by kernel interfaces for easy detection
27 * namespace://profile - used by policy
28 *
29 * Profile names can not start with : or @ or ^ and may not contain \0
30 *
31 * Reserved profile names
32 * unconfined - special automatically generated unconfined profile
33 * inherit - special name to indicate profile inheritance
34 * null-XXXX-YYYY - special automatically generated learning profiles
35 *
36 * Namespace names may not start with / or @ and may not contain \0 or :
37 * Reserved namespace names
38 * user-XXXX - user defined profiles
39 *
40 * a // in a profile or namespace name indicates a hierarchical name with the
41 * name before the // being the parent and the name after the child.
42 *
43 * Profile and namespace hierarchies serve two different but similar purposes.
44 * The namespace contains the set of visible profiles that are considered
45 * for attachment. The hierarchy of namespaces allows for virtualizing
46 * the namespace so that for example a chroot can have its own set of profiles
47 * which may define some local user namespaces.
48 * The profile hierarchy severs two distinct purposes,
49 * - it allows for sub profiles or hats, which allows an application to run
50 * subprograms under its own profile with different restriction than it
51 * self, and not have it use the system profile.
52 * eg. if a mail program starts an editor, the policy might make the
53 * restrictions tighter on the editor tighter than the mail program,
54 * and definitely different than general editor restrictions
55 * - it allows for binary hierarchy of profiles, so that execution history
56 * is preserved. This feature isn't exploited by AppArmor reference policy
57 * but is allowed. NOTE: this is currently suboptimal because profile
58 * aliasing is not currently implemented so that a profile for each
59 * level must be defined.
60 * eg. /bin/bash///bin/ls as a name would indicate /bin/ls was started
61 * from /bin/bash
62 *
63 * A profile or namespace name that can contain one or more // separators
64 * is referred to as an hname (hierarchical).
65 * eg. /bin/bash//bin/ls
66 *
67 * An fqname is a name that may contain both namespace and profile hnames.
68 * eg. :ns:/bin/bash//bin/ls
69 *
70 * NOTES:
71 * - locking of profile lists is currently fairly coarse. All profile
72 * lists within a namespace use the namespace lock.
73 * FIXME: move profile lists to using rcu_lists
74 */
75
76#include <linux/slab.h>
77#include <linux/spinlock.h>
78#include <linux/string.h>
79
80#include "include/apparmor.h"
81#include "include/capability.h"
82#include "include/context.h"
83#include "include/file.h"
84#include "include/ipc.h"
85#include "include/match.h"
86#include "include/path.h"
87#include "include/policy.h"
88#include "include/policy_unpack.h"
89#include "include/resource.h"
John Johansenc88d4c72010-07-29 14:48:00 -070090
91
92/* root profile namespace */
93struct aa_namespace *root_ns;
94
Jan Engelhardt2d4cee72012-03-14 13:30:36 +010095const char *const profile_mode_names[] = {
John Johansenc88d4c72010-07-29 14:48:00 -070096 "enforce",
97 "complain",
98 "kill",
99};
100
101/**
102 * hname_tail - find the last component of an hname
103 * @name: hname to find the base profile name component of (NOT NULL)
104 *
105 * Returns: the tail (base profile name) name component of an hname
106 */
107static const char *hname_tail(const char *hname)
108{
109 char *split;
110 hname = strim((char *)hname);
111 for (split = strstr(hname, "//"); split; split = strstr(hname, "//"))
112 hname = split + 2;
113
114 return hname;
115}
116
117/**
118 * policy_init - initialize a policy structure
119 * @policy: policy to initialize (NOT NULL)
120 * @prefix: prefix name if any is required. (MAYBE NULL)
121 * @name: name of the policy, init will make a copy of it (NOT NULL)
122 *
123 * Note: this fn creates a copy of strings passed in
124 *
125 * Returns: true if policy init successful
126 */
127static bool policy_init(struct aa_policy *policy, const char *prefix,
128 const char *name)
129{
130 /* freed by policy_free */
131 if (prefix) {
132 policy->hname = kmalloc(strlen(prefix) + strlen(name) + 3,
133 GFP_KERNEL);
134 if (policy->hname)
135 sprintf(policy->hname, "%s//%s", prefix, name);
136 } else
137 policy->hname = kstrdup(name, GFP_KERNEL);
138 if (!policy->hname)
139 return 0;
140 /* base.name is a substring of fqname */
141 policy->name = (char *)hname_tail(policy->hname);
142 INIT_LIST_HEAD(&policy->list);
143 INIT_LIST_HEAD(&policy->profiles);
144 kref_init(&policy->count);
145
146 return 1;
147}
148
149/**
150 * policy_destroy - free the elements referenced by @policy
151 * @policy: policy that is to have its elements freed (NOT NULL)
152 */
153static void policy_destroy(struct aa_policy *policy)
154{
155 /* still contains profiles -- invalid */
John Johansen01e2b672013-07-10 21:06:43 -0700156 if (on_list_rcu(&policy->profiles)) {
John Johansenc88d4c72010-07-29 14:48:00 -0700157 AA_ERROR("%s: internal error, "
158 "policy '%s' still contains profiles\n",
159 __func__, policy->name);
160 BUG();
161 }
John Johansen01e2b672013-07-10 21:06:43 -0700162 if (on_list_rcu(&policy->list)) {
John Johansenc88d4c72010-07-29 14:48:00 -0700163 AA_ERROR("%s: internal error, policy '%s' still on list\n",
164 __func__, policy->name);
165 BUG();
166 }
167
168 /* don't free name as its a subset of hname */
169 kzfree(policy->hname);
170}
171
172/**
173 * __policy_find - find a policy by @name on a policy list
174 * @head: list to search (NOT NULL)
175 * @name: name to search for (NOT NULL)
176 *
John Johansen01e2b672013-07-10 21:06:43 -0700177 * Requires: rcu_read_lock be held
John Johansenc88d4c72010-07-29 14:48:00 -0700178 *
179 * Returns: unrefcounted policy that match @name or NULL if not found
180 */
181static struct aa_policy *__policy_find(struct list_head *head, const char *name)
182{
183 struct aa_policy *policy;
184
John Johansen01e2b672013-07-10 21:06:43 -0700185 list_for_each_entry_rcu(policy, head, list) {
John Johansenc88d4c72010-07-29 14:48:00 -0700186 if (!strcmp(policy->name, name))
187 return policy;
188 }
189 return NULL;
190}
191
192/**
193 * __policy_strn_find - find a policy that's name matches @len chars of @str
194 * @head: list to search (NOT NULL)
195 * @str: string to search for (NOT NULL)
196 * @len: length of match required
197 *
John Johansen01e2b672013-07-10 21:06:43 -0700198 * Requires: rcu_read_lock be held
John Johansenc88d4c72010-07-29 14:48:00 -0700199 *
200 * Returns: unrefcounted policy that match @str or NULL if not found
201 *
202 * if @len == strlen(@strlen) then this is equiv to __policy_find
203 * other wise it allows searching for policy by a partial match of name
204 */
205static struct aa_policy *__policy_strn_find(struct list_head *head,
206 const char *str, int len)
207{
208 struct aa_policy *policy;
209
John Johansen01e2b672013-07-10 21:06:43 -0700210 list_for_each_entry_rcu(policy, head, list) {
John Johansenc88d4c72010-07-29 14:48:00 -0700211 if (aa_strneq(policy->name, str, len))
212 return policy;
213 }
214
215 return NULL;
216}
217
218/*
219 * Routines for AppArmor namespaces
220 */
221
222static const char *hidden_ns_name = "---";
223/**
224 * aa_ns_visible - test if @view is visible from @curr
225 * @curr: namespace to treat as the parent (NOT NULL)
226 * @view: namespace to test if visible from @curr (NOT NULL)
227 *
228 * Returns: true if @view is visible from @curr else false
229 */
230bool aa_ns_visible(struct aa_namespace *curr, struct aa_namespace *view)
231{
232 if (curr == view)
233 return true;
234
235 for ( ; view; view = view->parent) {
236 if (view->parent == curr)
237 return true;
238 }
239 return false;
240}
241
242/**
243 * aa_na_name - Find the ns name to display for @view from @curr
244 * @curr - current namespace (NOT NULL)
245 * @view - namespace attempting to view (NOT NULL)
246 *
247 * Returns: name of @view visible from @curr
248 */
249const char *aa_ns_name(struct aa_namespace *curr, struct aa_namespace *view)
250{
251 /* if view == curr then the namespace name isn't displayed */
252 if (curr == view)
253 return "";
254
255 if (aa_ns_visible(curr, view)) {
256 /* at this point if a ns is visible it is in a view ns
257 * thus the curr ns.hname is a prefix of its name.
258 * Only output the virtualized portion of the name
259 * Add + 2 to skip over // separating curr hname prefix
260 * from the visible tail of the views hname
261 */
262 return view->base.hname + strlen(curr->base.hname) + 2;
263 } else
264 return hidden_ns_name;
265}
266
267/**
268 * alloc_namespace - allocate, initialize and return a new namespace
269 * @prefix: parent namespace name (MAYBE NULL)
270 * @name: a preallocated name (NOT NULL)
271 *
272 * Returns: refcounted namespace or NULL on failure.
273 */
274static struct aa_namespace *alloc_namespace(const char *prefix,
275 const char *name)
276{
277 struct aa_namespace *ns;
278
279 ns = kzalloc(sizeof(*ns), GFP_KERNEL);
280 AA_DEBUG("%s(%p)\n", __func__, ns);
281 if (!ns)
282 return NULL;
283 if (!policy_init(&ns->base, prefix, name))
284 goto fail_ns;
285
286 INIT_LIST_HEAD(&ns->sub_ns);
John Johansen01e2b672013-07-10 21:06:43 -0700287 mutex_init(&ns->lock);
John Johansenc88d4c72010-07-29 14:48:00 -0700288
289 /* released by free_namespace */
290 ns->unconfined = aa_alloc_profile("unconfined");
291 if (!ns->unconfined)
292 goto fail_unconfined;
293
John Johansenc88d4c72010-07-29 14:48:00 -0700294 ns->unconfined->flags = PFLAG_UNCONFINED | PFLAG_IX_ON_NAME_ERROR |
295 PFLAG_IMMUTABLE;
296
297 /*
298 * released by free_namespace, however __remove_namespace breaks
299 * the cyclic references (ns->unconfined, and unconfined->ns) and
300 * replaces with refs to parent namespace unconfined
301 */
302 ns->unconfined->ns = aa_get_namespace(ns);
303
John Johansena4987852013-02-18 16:10:34 -0800304 atomic_set(&ns->uniq_null, 0);
305
John Johansenc88d4c72010-07-29 14:48:00 -0700306 return ns;
307
308fail_unconfined:
wzt.wzt@gmail.com246c3fb2010-11-10 11:31:55 +0800309 kzfree(ns->base.hname);
John Johansenc88d4c72010-07-29 14:48:00 -0700310fail_ns:
311 kzfree(ns);
312 return NULL;
313}
314
315/**
316 * free_namespace - free a profile namespace
317 * @ns: the namespace to free (MAYBE NULL)
318 *
319 * Requires: All references to the namespace must have been put, if the
320 * namespace was referenced by a profile confining a task,
321 */
322static void free_namespace(struct aa_namespace *ns)
323{
324 if (!ns)
325 return;
326
327 policy_destroy(&ns->base);
328 aa_put_namespace(ns->parent);
329
330 if (ns->unconfined && ns->unconfined->ns == ns)
331 ns->unconfined->ns = NULL;
332
333 aa_put_profile(ns->unconfined);
334 kzfree(ns);
335}
336
337/**
338 * aa_free_namespace_kref - free aa_namespace by kref (see aa_put_namespace)
339 * @kr: kref callback for freeing of a namespace (NOT NULL)
340 */
341void aa_free_namespace_kref(struct kref *kref)
342{
343 free_namespace(container_of(kref, struct aa_namespace, base.count));
344}
345
346/**
347 * __aa_find_namespace - find a namespace on a list by @name
348 * @head: list to search for namespace on (NOT NULL)
349 * @name: name of namespace to look for (NOT NULL)
350 *
351 * Returns: unrefcounted namespace
352 *
John Johansen01e2b672013-07-10 21:06:43 -0700353 * Requires: rcu_read_lock be held
John Johansenc88d4c72010-07-29 14:48:00 -0700354 */
355static struct aa_namespace *__aa_find_namespace(struct list_head *head,
356 const char *name)
357{
358 return (struct aa_namespace *)__policy_find(head, name);
359}
360
361/**
362 * aa_find_namespace - look up a profile namespace on the namespace list
363 * @root: namespace to search in (NOT NULL)
364 * @name: name of namespace to find (NOT NULL)
365 *
366 * Returns: a refcounted namespace on the list, or NULL if no namespace
367 * called @name exists.
368 *
369 * refcount released by caller
370 */
371struct aa_namespace *aa_find_namespace(struct aa_namespace *root,
372 const char *name)
373{
374 struct aa_namespace *ns = NULL;
375
John Johansen01e2b672013-07-10 21:06:43 -0700376 rcu_read_lock();
John Johansenc88d4c72010-07-29 14:48:00 -0700377 ns = aa_get_namespace(__aa_find_namespace(&root->sub_ns, name));
John Johansen01e2b672013-07-10 21:06:43 -0700378 rcu_read_unlock();
John Johansenc88d4c72010-07-29 14:48:00 -0700379
380 return ns;
381}
382
383/**
384 * aa_prepare_namespace - find an existing or create a new namespace of @name
385 * @name: the namespace to find or add (MAYBE NULL)
386 *
387 * Returns: refcounted namespace or NULL if failed to create one
388 */
389static struct aa_namespace *aa_prepare_namespace(const char *name)
390{
391 struct aa_namespace *ns, *root;
392
393 root = aa_current_profile()->ns;
394
John Johansen01e2b672013-07-10 21:06:43 -0700395 mutex_lock(&root->lock);
John Johansenc88d4c72010-07-29 14:48:00 -0700396
397 /* if name isn't specified the profile is loaded to the current ns */
398 if (!name) {
399 /* released by caller */
400 ns = aa_get_namespace(root);
401 goto out;
402 }
403
404 /* try and find the specified ns and if it doesn't exist create it */
405 /* released by caller */
406 ns = aa_get_namespace(__aa_find_namespace(&root->sub_ns, name));
407 if (!ns) {
John Johansen01e2b672013-07-10 21:06:43 -0700408 ns = alloc_namespace(root->base.hname, name);
409 if (!ns)
410 goto out;
411 /* add parent ref */
412 ns->parent = aa_get_namespace(root);
413 list_add_rcu(&ns->base.list, &root->sub_ns);
414 /* add list ref */
415 aa_get_namespace(ns);
John Johansenc88d4c72010-07-29 14:48:00 -0700416 }
417out:
John Johansen01e2b672013-07-10 21:06:43 -0700418 mutex_unlock(&root->lock);
John Johansenc88d4c72010-07-29 14:48:00 -0700419
420 /* return ref */
421 return ns;
422}
423
424/**
425 * __list_add_profile - add a profile to a list
426 * @list: list to add it to (NOT NULL)
427 * @profile: the profile to add (NOT NULL)
428 *
429 * refcount @profile, should be put by __list_remove_profile
430 *
431 * Requires: namespace lock be held, or list not be shared
432 */
433static void __list_add_profile(struct list_head *list,
434 struct aa_profile *profile)
435{
John Johansen01e2b672013-07-10 21:06:43 -0700436 list_add_rcu(&profile->base.list, list);
John Johansenc88d4c72010-07-29 14:48:00 -0700437 /* get list reference */
438 aa_get_profile(profile);
439}
440
441/**
442 * __list_remove_profile - remove a profile from the list it is on
443 * @profile: the profile to remove (NOT NULL)
444 *
445 * remove a profile from the list, warning generally removal should
446 * be done with __replace_profile as most profile removals are
447 * replacements to the unconfined profile.
448 *
449 * put @profile list refcount
450 *
451 * Requires: namespace lock be held, or list not have been live
452 */
453static void __list_remove_profile(struct aa_profile *profile)
454{
John Johansen01e2b672013-07-10 21:06:43 -0700455 list_del_rcu(&profile->base.list);
456 aa_put_profile(profile);
John Johansenc88d4c72010-07-29 14:48:00 -0700457}
458
John Johansenc88d4c72010-07-29 14:48:00 -0700459static void __profile_list_release(struct list_head *head);
460
461/**
462 * __remove_profile - remove old profile, and children
463 * @profile: profile to be replaced (NOT NULL)
464 *
465 * Requires: namespace list lock be held, or list not be shared
466 */
467static void __remove_profile(struct aa_profile *profile)
468{
469 /* release any children lists first */
470 __profile_list_release(&profile->base.profiles);
471 /* released by free_profile */
472 profile->replacedby = aa_get_profile(profile->ns->unconfined);
473 __list_remove_profile(profile);
474}
475
476/**
477 * __profile_list_release - remove all profiles on the list and put refs
478 * @head: list of profiles (NOT NULL)
479 *
480 * Requires: namespace lock be held
481 */
482static void __profile_list_release(struct list_head *head)
483{
484 struct aa_profile *profile, *tmp;
485 list_for_each_entry_safe(profile, tmp, head, base.list)
486 __remove_profile(profile);
487}
488
489static void __ns_list_release(struct list_head *head);
490
491/**
492 * destroy_namespace - remove everything contained by @ns
493 * @ns: namespace to have it contents removed (NOT NULL)
494 */
495static void destroy_namespace(struct aa_namespace *ns)
496{
John Johansen01e2b672013-07-10 21:06:43 -0700497 struct aa_profile *unconfined;
498
John Johansenc88d4c72010-07-29 14:48:00 -0700499 if (!ns)
500 return;
501
John Johansen01e2b672013-07-10 21:06:43 -0700502 mutex_lock(&ns->lock);
John Johansenc88d4c72010-07-29 14:48:00 -0700503 /* release all profiles in this namespace */
504 __profile_list_release(&ns->base.profiles);
505
506 /* release all sub namespaces */
507 __ns_list_release(&ns->sub_ns);
508
John Johansen01e2b672013-07-10 21:06:43 -0700509 unconfined = ns->unconfined;
510 /*
511 * break the ns, unconfined profile cyclic reference and forward
512 * all new unconfined profiles requests to the parent namespace
513 * This will result in all confined tasks that have a profile
514 * being removed, inheriting the parent->unconfined profile.
515 */
516 if (ns->parent)
517 ns->unconfined = aa_get_profile(ns->parent->unconfined);
518
519 /* release original ns->unconfined ref */
520 aa_put_profile(unconfined);
521
522 mutex_unlock(&ns->lock);
523}
524
525static void aa_put_ns_rcu(struct rcu_head *head)
526{
527 struct aa_namespace *ns = container_of(head, struct aa_namespace,
528 base.rcu);
529 /* release ns->base.list ref */
530 aa_put_namespace(ns);
John Johansenc88d4c72010-07-29 14:48:00 -0700531}
532
533/**
534 * __remove_namespace - remove a namespace and all its children
535 * @ns: namespace to be removed (NOT NULL)
536 *
537 * Requires: ns->parent->lock be held and ns removed from parent.
538 */
539static void __remove_namespace(struct aa_namespace *ns)
540{
John Johansenc88d4c72010-07-29 14:48:00 -0700541 /* remove ns from namespace list */
John Johansen01e2b672013-07-10 21:06:43 -0700542 list_del_rcu(&ns->base.list);
John Johansenc88d4c72010-07-29 14:48:00 -0700543
544 destroy_namespace(ns);
545
John Johansen01e2b672013-07-10 21:06:43 -0700546 call_rcu(&ns->base.rcu, aa_put_ns_rcu);
John Johansenc88d4c72010-07-29 14:48:00 -0700547}
548
549/**
550 * __ns_list_release - remove all profile namespaces on the list put refs
551 * @head: list of profile namespaces (NOT NULL)
552 *
553 * Requires: namespace lock be held
554 */
555static void __ns_list_release(struct list_head *head)
556{
557 struct aa_namespace *ns, *tmp;
558 list_for_each_entry_safe(ns, tmp, head, base.list)
559 __remove_namespace(ns);
560
561}
562
563/**
564 * aa_alloc_root_ns - allocate the root profile namespace
565 *
566 * Returns: %0 on success else error
567 *
568 */
569int __init aa_alloc_root_ns(void)
570{
571 /* released by aa_free_root_ns - used as list ref*/
572 root_ns = alloc_namespace(NULL, "root");
573 if (!root_ns)
574 return -ENOMEM;
575
576 return 0;
577}
578
579 /**
580 * aa_free_root_ns - free the root profile namespace
581 */
582void __init aa_free_root_ns(void)
583 {
584 struct aa_namespace *ns = root_ns;
585 root_ns = NULL;
586
587 destroy_namespace(ns);
588 aa_put_namespace(ns);
589}
590
591/**
John Johansenc88d4c72010-07-29 14:48:00 -0700592 * free_profile - free a profile
593 * @profile: the profile to free (MAYBE NULL)
594 *
595 * Free a profile, its hats and null_profile. All references to the profile,
596 * its hats and null_profile must have been put.
597 *
598 * If the profile was referenced from a task context, free_profile() will
599 * be called from an rcu callback routine, so we must not sleep here.
600 */
601static void free_profile(struct aa_profile *profile)
602{
John Johansen2e680dd2012-10-24 06:27:32 -0700603 struct aa_profile *p;
604
John Johansenc88d4c72010-07-29 14:48:00 -0700605 AA_DEBUG("%s(%p)\n", __func__, profile);
606
607 if (!profile)
608 return;
609
John Johansenc88d4c72010-07-29 14:48:00 -0700610 /* free children profiles */
611 policy_destroy(&profile->base);
John Johansen01e2b672013-07-10 21:06:43 -0700612 aa_put_profile(rcu_access_pointer(profile->parent));
John Johansenc88d4c72010-07-29 14:48:00 -0700613
614 aa_put_namespace(profile->ns);
615 kzfree(profile->rename);
616
617 aa_free_file_rules(&profile->file);
618 aa_free_cap_rules(&profile->caps);
619 aa_free_rlimit_rules(&profile->rlimits);
620
John Johansenc88d4c72010-07-29 14:48:00 -0700621 aa_put_dfa(profile->xmatch);
John Johansenad5ff3d2012-02-16 07:07:53 -0800622 aa_put_dfa(profile->policy.dfa);
John Johansenc88d4c72010-07-29 14:48:00 -0700623
John Johansen2e680dd2012-10-24 06:27:32 -0700624 /* put the profile reference for replacedby, but not via
625 * put_profile(kref_put).
626 * replacedby can form a long chain that can result in cascading
627 * frees that blows the stack because kref_put makes a nested fn
628 * call (it looks like recursion, with free_profile calling
629 * free_profile) for each profile in the chain lp#1056078.
630 */
631 for (p = profile->replacedby; p; ) {
632 if (atomic_dec_and_test(&p->base.count.refcount)) {
633 /* no more refs on p, grab its replacedby */
634 struct aa_profile *next = p->replacedby;
635 /* break the chain */
636 p->replacedby = NULL;
637 /* now free p, chain is broken */
638 free_profile(p);
639
640 /* follow up with next profile in the chain */
641 p = next;
642 } else
643 break;
644 }
John Johansenc88d4c72010-07-29 14:48:00 -0700645
646 kzfree(profile);
647}
648
649/**
John Johansen01e2b672013-07-10 21:06:43 -0700650 * aa_free_profile_rcu - free aa_profile by rcu (called by aa_free_profile_kref)
651 * @head: rcu_head callback for freeing of a profile (NOT NULL)
652 */
653static void aa_free_profile_rcu(struct rcu_head *head)
654{
655 struct aa_profile *p = container_of(head, struct aa_profile, base.rcu);
656 free_profile(p);
657}
658
659/**
John Johansenc88d4c72010-07-29 14:48:00 -0700660 * aa_free_profile_kref - free aa_profile by kref (called by aa_put_profile)
661 * @kr: kref callback for freeing of a profile (NOT NULL)
662 */
663void aa_free_profile_kref(struct kref *kref)
664{
665 struct aa_profile *p = container_of(kref, struct aa_profile,
666 base.count);
John Johansen01e2b672013-07-10 21:06:43 -0700667 call_rcu(&p->base.rcu, aa_free_profile_rcu);
John Johansenc88d4c72010-07-29 14:48:00 -0700668}
669
John Johansen4da05cc2013-02-18 16:11:34 -0800670/**
671 * aa_alloc_profile - allocate, initialize and return a new profile
672 * @hname: name of the profile (NOT NULL)
673 *
674 * Returns: refcount profile or NULL on failure
675 */
676struct aa_profile *aa_alloc_profile(const char *hname)
677{
678 struct aa_profile *profile;
679
680 /* freed by free_profile - usually through aa_put_profile */
681 profile = kzalloc(sizeof(*profile), GFP_KERNEL);
682 if (!profile)
683 return NULL;
684
685 if (!policy_init(&profile->base, NULL, hname)) {
686 kzfree(profile);
687 return NULL;
688 }
689
690 /* refcount released by caller */
691 return profile;
692}
693
694/**
695 * aa_new_null_profile - create a new null-X learning profile
696 * @parent: profile that caused this profile to be created (NOT NULL)
697 * @hat: true if the null- learning profile is a hat
698 *
699 * Create a null- complain mode profile used in learning mode. The name of
700 * the profile is unique and follows the format of parent//null-<uniq>.
701 *
702 * null profiles are added to the profile list but the list does not
703 * hold a count on them so that they are automatically released when
704 * not in use.
705 *
706 * Returns: new refcounted profile else NULL on failure
707 */
708struct aa_profile *aa_new_null_profile(struct aa_profile *parent, int hat)
709{
710 struct aa_profile *profile = NULL;
711 char *name;
712 int uniq = atomic_inc_return(&parent->ns->uniq_null);
713
714 /* freed below */
715 name = kmalloc(strlen(parent->base.hname) + 2 + 7 + 8, GFP_KERNEL);
716 if (!name)
717 goto fail;
718 sprintf(name, "%s//null-%x", parent->base.hname, uniq);
719
720 profile = aa_alloc_profile(name);
721 kfree(name);
722 if (!profile)
723 goto fail;
724
725 profile->mode = APPARMOR_COMPLAIN;
726 profile->flags = PFLAG_NULL;
727 if (hat)
728 profile->flags |= PFLAG_HAT;
729
730 /* released on free_profile */
John Johansen01e2b672013-07-10 21:06:43 -0700731 rcu_assign_pointer(profile->parent, aa_get_profile(parent));
John Johansen4da05cc2013-02-18 16:11:34 -0800732 profile->ns = aa_get_namespace(parent->ns);
733
John Johansen01e2b672013-07-10 21:06:43 -0700734 mutex_lock(&profile->ns->lock);
John Johansen4da05cc2013-02-18 16:11:34 -0800735 __list_add_profile(&parent->base.profiles, profile);
John Johansen01e2b672013-07-10 21:06:43 -0700736 mutex_unlock(&profile->ns->lock);
John Johansen4da05cc2013-02-18 16:11:34 -0800737
738 /* refcount released by caller */
739 return profile;
740
741fail:
742 return NULL;
743}
744
John Johansenc88d4c72010-07-29 14:48:00 -0700745/* TODO: profile accounting - setup in remove */
746
747/**
748 * __find_child - find a profile on @head list with a name matching @name
749 * @head: list to search (NOT NULL)
750 * @name: name of profile (NOT NULL)
751 *
John Johansen01e2b672013-07-10 21:06:43 -0700752 * Requires: rcu_read_lock be held
John Johansenc88d4c72010-07-29 14:48:00 -0700753 *
754 * Returns: unrefcounted profile ptr, or NULL if not found
755 */
756static struct aa_profile *__find_child(struct list_head *head, const char *name)
757{
758 return (struct aa_profile *)__policy_find(head, name);
759}
760
761/**
762 * __strn_find_child - find a profile on @head list using substring of @name
763 * @head: list to search (NOT NULL)
764 * @name: name of profile (NOT NULL)
765 * @len: length of @name substring to match
766 *
John Johansen01e2b672013-07-10 21:06:43 -0700767 * Requires: rcu_read_lock be held
John Johansenc88d4c72010-07-29 14:48:00 -0700768 *
769 * Returns: unrefcounted profile ptr, or NULL if not found
770 */
771static struct aa_profile *__strn_find_child(struct list_head *head,
772 const char *name, int len)
773{
774 return (struct aa_profile *)__policy_strn_find(head, name, len);
775}
776
777/**
778 * aa_find_child - find a profile by @name in @parent
779 * @parent: profile to search (NOT NULL)
780 * @name: profile name to search for (NOT NULL)
781 *
782 * Returns: a refcounted profile or NULL if not found
783 */
784struct aa_profile *aa_find_child(struct aa_profile *parent, const char *name)
785{
786 struct aa_profile *profile;
787
John Johansen01e2b672013-07-10 21:06:43 -0700788 rcu_read_lock();
John Johansenc88d4c72010-07-29 14:48:00 -0700789 profile = aa_get_profile(__find_child(&parent->base.profiles, name));
John Johansen01e2b672013-07-10 21:06:43 -0700790 rcu_read_unlock();
John Johansenc88d4c72010-07-29 14:48:00 -0700791
792 /* refcount released by caller */
793 return profile;
794}
795
796/**
797 * __lookup_parent - lookup the parent of a profile of name @hname
798 * @ns: namespace to lookup profile in (NOT NULL)
799 * @hname: hierarchical profile name to find parent of (NOT NULL)
800 *
801 * Lookups up the parent of a fully qualified profile name, the profile
802 * that matches hname does not need to exist, in general this
803 * is used to load a new profile.
804 *
John Johansen01e2b672013-07-10 21:06:43 -0700805 * Requires: rcu_read_lock be held
John Johansenc88d4c72010-07-29 14:48:00 -0700806 *
807 * Returns: unrefcounted policy or NULL if not found
808 */
809static struct aa_policy *__lookup_parent(struct aa_namespace *ns,
810 const char *hname)
811{
812 struct aa_policy *policy;
813 struct aa_profile *profile = NULL;
814 char *split;
815
816 policy = &ns->base;
817
818 for (split = strstr(hname, "//"); split;) {
819 profile = __strn_find_child(&policy->profiles, hname,
820 split - hname);
821 if (!profile)
822 return NULL;
823 policy = &profile->base;
824 hname = split + 2;
825 split = strstr(hname, "//");
826 }
827 if (!profile)
828 return &ns->base;
829 return &profile->base;
830}
831
832/**
833 * __lookup_profile - lookup the profile matching @hname
834 * @base: base list to start looking up profile name from (NOT NULL)
835 * @hname: hierarchical profile name (NOT NULL)
836 *
John Johansen01e2b672013-07-10 21:06:43 -0700837 * Requires: rcu_read_lock be held
John Johansenc88d4c72010-07-29 14:48:00 -0700838 *
839 * Returns: unrefcounted profile pointer or NULL if not found
840 *
841 * Do a relative name lookup, recursing through profile tree.
842 */
843static struct aa_profile *__lookup_profile(struct aa_policy *base,
844 const char *hname)
845{
846 struct aa_profile *profile = NULL;
847 char *split;
848
849 for (split = strstr(hname, "//"); split;) {
850 profile = __strn_find_child(&base->profiles, hname,
851 split - hname);
852 if (!profile)
853 return NULL;
854
855 base = &profile->base;
856 hname = split + 2;
857 split = strstr(hname, "//");
858 }
859
860 profile = __find_child(&base->profiles, hname);
861
862 return profile;
863}
864
865/**
866 * aa_lookup_profile - find a profile by its full or partial name
867 * @ns: the namespace to start from (NOT NULL)
868 * @hname: name to do lookup on. Does not contain namespace prefix (NOT NULL)
869 *
870 * Returns: refcounted profile or NULL if not found
871 */
872struct aa_profile *aa_lookup_profile(struct aa_namespace *ns, const char *hname)
873{
874 struct aa_profile *profile;
875
John Johansen01e2b672013-07-10 21:06:43 -0700876 rcu_read_lock();
877 do {
878 profile = __lookup_profile(&ns->base, hname);
879 } while (profile && !aa_get_profile_not0(profile));
880 rcu_read_unlock();
John Johansenc88d4c72010-07-29 14:48:00 -0700881
John Johansenbf832082012-05-16 11:00:05 -0700882 /* the unconfined profile is not in the regular profile list */
883 if (!profile && strcmp(hname, "unconfined") == 0)
884 profile = aa_get_profile(ns->unconfined);
885
John Johansenc88d4c72010-07-29 14:48:00 -0700886 /* refcount released by caller */
887 return profile;
888}
889
890/**
891 * replacement_allowed - test to see if replacement is allowed
892 * @profile: profile to test if it can be replaced (MAYBE NULL)
893 * @noreplace: true if replacement shouldn't be allowed but addition is okay
894 * @info: Returns - info about why replacement failed (NOT NULL)
895 *
896 * Returns: %0 if replacement allowed else error code
897 */
898static int replacement_allowed(struct aa_profile *profile, int noreplace,
899 const char **info)
900{
901 if (profile) {
902 if (profile->flags & PFLAG_IMMUTABLE) {
903 *info = "cannot replace immutible profile";
904 return -EPERM;
905 } else if (noreplace) {
906 *info = "profile already exists";
907 return -EEXIST;
908 }
909 }
910 return 0;
911}
912
913/**
John Johansenc88d4c72010-07-29 14:48:00 -0700914 * aa_audit_policy - Do auditing of policy changes
915 * @op: policy operation being performed
916 * @gfp: memory allocation flags
917 * @name: name of profile being manipulated (NOT NULL)
918 * @info: any extra information to be audited (MAYBE NULL)
919 * @error: error code
920 *
921 * Returns: the error to be returned after audit is done
922 */
923static int audit_policy(int op, gfp_t gfp, const char *name, const char *info,
924 int error)
925{
926 struct common_audit_data sa;
Eric Paris3b3b0e42012-04-03 09:37:02 -0700927 struct apparmor_audit_data aad = {0,};
Eric Paris50c205f2012-04-04 15:01:43 -0400928 sa.type = LSM_AUDIT_DATA_NONE;
Eric Paris3b3b0e42012-04-03 09:37:02 -0700929 sa.aad = &aad;
930 aad.op = op;
931 aad.name = name;
932 aad.info = info;
933 aad.error = error;
John Johansenc88d4c72010-07-29 14:48:00 -0700934
935 return aa_audit(AUDIT_APPARMOR_STATUS, __aa_current_profile(), gfp,
936 &sa, NULL);
937}
938
939/**
940 * aa_may_manage_policy - can the current task manage policy
941 * @op: the policy manipulation operation being done
942 *
943 * Returns: true if the task is allowed to manipulate policy
944 */
945bool aa_may_manage_policy(int op)
946{
947 /* check if loading policy is locked out */
948 if (aa_g_lock_policy) {
949 audit_policy(op, GFP_KERNEL, NULL, "policy_locked", -EACCES);
950 return 0;
951 }
952
953 if (!capable(CAP_MAC_ADMIN)) {
954 audit_policy(op, GFP_KERNEL, NULL, "not policy admin", -EACCES);
955 return 0;
956 }
957
958 return 1;
959}
960
John Johansendd51c8482013-07-10 21:05:43 -0700961static struct aa_profile *__list_lookup_parent(struct list_head *lh,
962 struct aa_profile *profile)
963{
964 const char *base = hname_tail(profile->base.hname);
965 long len = base - profile->base.hname;
966 struct aa_load_ent *ent;
967
968 /* parent won't have trailing // so remove from len */
969 if (len <= 2)
970 return NULL;
971 len -= 2;
972
973 list_for_each_entry(ent, lh, list) {
974 if (ent->new == profile)
975 continue;
976 if (strncmp(ent->new->base.hname, profile->base.hname, len) ==
977 0 && ent->new->base.hname[len] == 0)
978 return ent->new;
979 }
980
981 return NULL;
982}
983
984/**
985 * __replace_profile - replace @old with @new on a list
986 * @old: profile to be replaced (NOT NULL)
987 * @new: profile to replace @old with (NOT NULL)
988 *
989 * Will duplicate and refcount elements that @new inherits from @old
990 * and will inherit @old children.
991 *
992 * refcount @new for list, put @old list refcount
993 *
994 * Requires: namespace list lock be held, or list not be shared
995 */
996static void __replace_profile(struct aa_profile *old, struct aa_profile *new)
997{
998 struct aa_profile *child, *tmp;
999
1000 if (!list_empty(&old->base.profiles)) {
1001 LIST_HEAD(lh);
John Johansen01e2b672013-07-10 21:06:43 -07001002 list_splice_init_rcu(&old->base.profiles, &lh, synchronize_rcu);
John Johansendd51c8482013-07-10 21:05:43 -07001003
1004 list_for_each_entry_safe(child, tmp, &lh, base.list) {
1005 struct aa_profile *p;
1006
1007 list_del_init(&child->base.list);
1008 p = __find_child(&new->base.profiles, child->base.name);
1009 if (p) {
1010 /* @p replaces @child */
1011 __replace_profile(child, p);
1012 continue;
1013 }
1014
1015 /* inherit @child and its children */
1016 /* TODO: update hname of inherited children */
1017 /* list refcount transferred to @new */
John Johansen01e2b672013-07-10 21:06:43 -07001018 p = rcu_dereference_protected(child->parent,
1019 mutex_is_locked(&child->ns->lock));
1020 rcu_assign_pointer(child->parent, aa_get_profile(new));
1021 list_add_rcu(&child->base.list, &new->base.profiles);
1022 aa_put_profile(p);
John Johansendd51c8482013-07-10 21:05:43 -07001023 }
1024 }
1025
John Johansen01e2b672013-07-10 21:06:43 -07001026 if (!rcu_access_pointer(new->parent)) {
1027 struct aa_profile *parent = rcu_dereference(old->parent);
1028 rcu_assign_pointer(new->parent, aa_get_profile(parent));
1029 }
John Johansendd51c8482013-07-10 21:05:43 -07001030 /* released by free_profile */
1031 old->replacedby = aa_get_profile(new);
1032
1033 if (list_empty(&new->base.list)) {
1034 /* new is not on a list already */
John Johansen01e2b672013-07-10 21:06:43 -07001035 list_replace_rcu(&old->base.list, &new->base.list);
John Johansendd51c8482013-07-10 21:05:43 -07001036 aa_get_profile(new);
1037 aa_put_profile(old);
1038 } else
1039 __list_remove_profile(old);
1040}
1041
1042/**
1043 * __lookup_replace - lookup replacement information for a profile
1044 * @ns - namespace the lookup occurs in
1045 * @hname - name of profile to lookup
1046 * @noreplace - true if not replacing an existing profile
1047 * @p - Returns: profile to be replaced
1048 * @info - Returns: info string on why lookup failed
1049 *
1050 * Returns: profile to replace (no ref) on success else ptr error
1051 */
1052static int __lookup_replace(struct aa_namespace *ns, const char *hname,
1053 bool noreplace, struct aa_profile **p,
1054 const char **info)
1055{
1056 *p = aa_get_profile(__lookup_profile(&ns->base, hname));
1057 if (*p) {
1058 int error = replacement_allowed(*p, noreplace, info);
1059 if (error) {
1060 *info = "profile can not be replaced";
1061 return error;
1062 }
1063 }
1064
1065 return 0;
1066}
1067
John Johansenc88d4c72010-07-29 14:48:00 -07001068/**
1069 * aa_replace_profiles - replace profile(s) on the profile list
1070 * @udata: serialized data stream (NOT NULL)
1071 * @size: size of the serialized data stream
1072 * @noreplace: true if only doing addition, no replacement allowed
1073 *
1074 * unpack and replace a profile on the profile list and uses of that profile
1075 * by any aa_task_cxt. If the profile does not exist on the profile list
1076 * it is added.
1077 *
1078 * Returns: size of data consumed else error code on failure.
1079 */
1080ssize_t aa_replace_profiles(void *udata, size_t size, bool noreplace)
1081{
John Johansenc88d4c72010-07-29 14:48:00 -07001082 const char *ns_name, *name = NULL, *info = NULL;
John Johansendd51c8482013-07-10 21:05:43 -07001083 struct aa_namespace *ns = NULL;
1084 struct aa_load_ent *ent, *tmp;
John Johansenc88d4c72010-07-29 14:48:00 -07001085 int op = OP_PROF_REPL;
1086 ssize_t error;
John Johansendd51c8482013-07-10 21:05:43 -07001087 LIST_HEAD(lh);
John Johansenc88d4c72010-07-29 14:48:00 -07001088
1089 /* released below */
John Johansendd51c8482013-07-10 21:05:43 -07001090 error = aa_unpack(udata, size, &lh, &ns_name);
1091 if (error)
1092 goto out;
John Johansenc88d4c72010-07-29 14:48:00 -07001093
1094 /* released below */
1095 ns = aa_prepare_namespace(ns_name);
1096 if (!ns) {
1097 info = "failed to prepare namespace";
1098 error = -ENOMEM;
1099 name = ns_name;
1100 goto fail;
1101 }
1102
John Johansen01e2b672013-07-10 21:06:43 -07001103 mutex_lock(&ns->lock);
John Johansendd51c8482013-07-10 21:05:43 -07001104 /* setup parent and ns info */
1105 list_for_each_entry(ent, &lh, list) {
1106 struct aa_policy *policy;
John Johansenc88d4c72010-07-29 14:48:00 -07001107
John Johansendd51c8482013-07-10 21:05:43 -07001108 name = ent->new->base.hname;
1109 error = __lookup_replace(ns, ent->new->base.hname, noreplace,
1110 &ent->old, &info);
1111 if (error)
1112 goto fail_lock;
John Johansenc88d4c72010-07-29 14:48:00 -07001113
John Johansendd51c8482013-07-10 21:05:43 -07001114 if (ent->new->rename) {
1115 error = __lookup_replace(ns, ent->new->rename,
1116 noreplace, &ent->rename,
1117 &info);
1118 if (error)
1119 goto fail_lock;
John Johansenc88d4c72010-07-29 14:48:00 -07001120 }
John Johansendd51c8482013-07-10 21:05:43 -07001121
1122 /* released when @new is freed */
1123 ent->new->ns = aa_get_namespace(ns);
1124
1125 if (ent->old || ent->rename)
1126 continue;
1127
1128 /* no ref on policy only use inside lock */
1129 policy = __lookup_parent(ns, ent->new->base.hname);
1130 if (!policy) {
1131 struct aa_profile *p;
1132 p = __list_lookup_parent(&lh, ent->new);
1133 if (!p) {
1134 error = -ENOENT;
1135 info = "parent does not exist";
1136 name = ent->new->base.hname;
1137 goto fail_lock;
1138 }
John Johansen01e2b672013-07-10 21:06:43 -07001139 rcu_assign_pointer(ent->new->parent, aa_get_profile(p));
1140 } else if (policy != &ns->base) {
John Johansendd51c8482013-07-10 21:05:43 -07001141 /* released on profile replacement or free_profile */
John Johansen01e2b672013-07-10 21:06:43 -07001142 struct aa_profile *p = (struct aa_profile *) policy;
1143 rcu_assign_pointer(ent->new->parent, aa_get_profile(p));
1144 }
John Johansenc88d4c72010-07-29 14:48:00 -07001145 }
1146
John Johansendd51c8482013-07-10 21:05:43 -07001147 /* do actual replacement */
1148 list_for_each_entry_safe(ent, tmp, &lh, list) {
1149 list_del_init(&ent->list);
1150 op = (!ent->old && !ent->rename) ? OP_PROF_LOAD : OP_PROF_REPL;
John Johansenc88d4c72010-07-29 14:48:00 -07001151
John Johansendd51c8482013-07-10 21:05:43 -07001152 audit_policy(op, GFP_ATOMIC, ent->new->base.name, NULL, error);
John Johansenc88d4c72010-07-29 14:48:00 -07001153
John Johansendd51c8482013-07-10 21:05:43 -07001154 if (ent->old) {
1155 __replace_profile(ent->old, ent->new);
1156 if (ent->rename)
1157 __replace_profile(ent->rename, ent->new);
1158 } else if (ent->rename) {
1159 __replace_profile(ent->rename, ent->new);
1160 } else if (ent->new->parent) {
John Johansen01e2b672013-07-10 21:06:43 -07001161 struct aa_profile *parent, *newest;
1162 parent = rcu_dereference_protected(ent->new->parent,
1163 mutex_is_locked(&ns->lock));
1164 newest = aa_newest_version(parent);
1165
John Johansendd51c8482013-07-10 21:05:43 -07001166 /* parent replaced in this atomic set? */
John Johansen01e2b672013-07-10 21:06:43 -07001167 if (newest != parent) {
1168 aa_get_profile(newest);
1169 aa_put_profile(parent);
1170 rcu_assign_pointer(ent->new->parent, newest);
John Johansendd51c8482013-07-10 21:05:43 -07001171 }
1172 __list_add_profile(&parent->base.profiles, ent->new);
1173 } else
1174 __list_add_profile(&ns->base.profiles, ent->new);
John Johansenc88d4c72010-07-29 14:48:00 -07001175
John Johansendd51c8482013-07-10 21:05:43 -07001176 aa_load_ent_free(ent);
John Johansenc88d4c72010-07-29 14:48:00 -07001177 }
John Johansen01e2b672013-07-10 21:06:43 -07001178 mutex_unlock(&ns->lock);
John Johansenc88d4c72010-07-29 14:48:00 -07001179
1180out:
1181 aa_put_namespace(ns);
John Johansendd51c8482013-07-10 21:05:43 -07001182
John Johansenc88d4c72010-07-29 14:48:00 -07001183 if (error)
1184 return error;
1185 return size;
1186
John Johansendd51c8482013-07-10 21:05:43 -07001187fail_lock:
John Johansen01e2b672013-07-10 21:06:43 -07001188 mutex_unlock(&ns->lock);
John Johansenc88d4c72010-07-29 14:48:00 -07001189fail:
1190 error = audit_policy(op, GFP_KERNEL, name, info, error);
John Johansendd51c8482013-07-10 21:05:43 -07001191
1192 list_for_each_entry_safe(ent, tmp, &lh, list) {
1193 list_del_init(&ent->list);
1194 aa_load_ent_free(ent);
1195 }
1196
John Johansenc88d4c72010-07-29 14:48:00 -07001197 goto out;
1198}
1199
1200/**
1201 * aa_remove_profiles - remove profile(s) from the system
1202 * @fqname: name of the profile or namespace to remove (NOT NULL)
1203 * @size: size of the name
1204 *
1205 * Remove a profile or sub namespace from the current namespace, so that
1206 * they can not be found anymore and mark them as replaced by unconfined
1207 *
1208 * NOTE: removing confinement does not restore rlimits to preconfinemnet values
1209 *
1210 * Returns: size of data consume else error code if fails
1211 */
1212ssize_t aa_remove_profiles(char *fqname, size_t size)
1213{
1214 struct aa_namespace *root, *ns = NULL;
1215 struct aa_profile *profile = NULL;
1216 const char *name = fqname, *info = NULL;
1217 ssize_t error = 0;
1218
1219 if (*fqname == 0) {
1220 info = "no profile specified";
1221 error = -ENOENT;
1222 goto fail;
1223 }
1224
1225 root = aa_current_profile()->ns;
1226
1227 if (fqname[0] == ':') {
1228 char *ns_name;
1229 name = aa_split_fqname(fqname, &ns_name);
John Johansen41d1b3e2013-02-21 01:14:17 -08001230 /* released below */
1231 ns = aa_find_namespace(root, ns_name);
1232 if (!ns) {
1233 info = "namespace does not exist";
1234 error = -ENOENT;
1235 goto fail;
John Johansenc88d4c72010-07-29 14:48:00 -07001236 }
1237 } else
1238 /* released below */
1239 ns = aa_get_namespace(root);
1240
John Johansenc88d4c72010-07-29 14:48:00 -07001241 if (!name) {
1242 /* remove namespace - can only happen if fqname[0] == ':' */
John Johansen01e2b672013-07-10 21:06:43 -07001243 mutex_lock(&ns->parent->lock);
John Johansenc88d4c72010-07-29 14:48:00 -07001244 __remove_namespace(ns);
John Johansen01e2b672013-07-10 21:06:43 -07001245 mutex_unlock(&ns->parent->lock);
John Johansenc88d4c72010-07-29 14:48:00 -07001246 } else {
1247 /* remove profile */
John Johansen01e2b672013-07-10 21:06:43 -07001248 mutex_lock(&ns->lock);
John Johansenc88d4c72010-07-29 14:48:00 -07001249 profile = aa_get_profile(__lookup_profile(&ns->base, name));
1250 if (!profile) {
1251 error = -ENOENT;
1252 info = "profile does not exist";
1253 goto fail_ns_lock;
1254 }
1255 name = profile->base.hname;
1256 __remove_profile(profile);
John Johansen01e2b672013-07-10 21:06:43 -07001257 mutex_unlock(&ns->lock);
John Johansenc88d4c72010-07-29 14:48:00 -07001258 }
John Johansenc88d4c72010-07-29 14:48:00 -07001259
1260 /* don't fail removal if audit fails */
1261 (void) audit_policy(OP_PROF_RM, GFP_KERNEL, name, info, error);
1262 aa_put_namespace(ns);
1263 aa_put_profile(profile);
1264 return size;
1265
1266fail_ns_lock:
John Johansen01e2b672013-07-10 21:06:43 -07001267 mutex_unlock(&ns->lock);
John Johansenc88d4c72010-07-29 14:48:00 -07001268 aa_put_namespace(ns);
1269
1270fail:
1271 (void) audit_policy(OP_PROF_RM, GFP_KERNEL, name, info, error);
1272 return error;
1273}