blob: 05795f10e55a56e4360a4e33969f012436e8aa73 [file] [log] [blame]
Theodore Ts'obd2d0212010-10-27 21:30:10 -04001/*
2 * linux/fs/ext4/page-io.c
3 *
4 * This contains the new page_io functions for ext4
5 *
6 * Written by Theodore Ts'o, 2010.
7 */
8
Theodore Ts'obd2d0212010-10-27 21:30:10 -04009#include <linux/fs.h>
10#include <linux/time.h>
11#include <linux/jbd2.h>
12#include <linux/highuid.h>
13#include <linux/pagemap.h>
14#include <linux/quotaops.h>
15#include <linux/string.h>
16#include <linux/buffer_head.h>
17#include <linux/writeback.h>
18#include <linux/pagevec.h>
19#include <linux/mpage.h>
20#include <linux/namei.h>
21#include <linux/uio.h>
22#include <linux/bio.h>
23#include <linux/workqueue.h>
24#include <linux/kernel.h>
25#include <linux/slab.h>
Jan Kara1ae48a62013-01-28 09:32:54 -050026#include <linux/mm.h>
Theodore Ts'obd2d0212010-10-27 21:30:10 -040027
28#include "ext4_jbd2.h"
29#include "xattr.h"
30#include "acl.h"
Theodore Ts'obd2d0212010-10-27 21:30:10 -040031
32static struct kmem_cache *io_page_cachep, *io_end_cachep;
33
Theodore Ts'o5dabfc72010-10-27 21:30:14 -040034int __init ext4_init_pageio(void)
Theodore Ts'obd2d0212010-10-27 21:30:10 -040035{
36 io_page_cachep = KMEM_CACHE(ext4_io_page, SLAB_RECLAIM_ACCOUNT);
37 if (io_page_cachep == NULL)
38 return -ENOMEM;
39 io_end_cachep = KMEM_CACHE(ext4_io_end, SLAB_RECLAIM_ACCOUNT);
Dan Carpenter13195182011-01-10 12:10:44 -050040 if (io_end_cachep == NULL) {
Theodore Ts'obd2d0212010-10-27 21:30:10 -040041 kmem_cache_destroy(io_page_cachep);
42 return -ENOMEM;
43 }
Theodore Ts'obd2d0212010-10-27 21:30:10 -040044 return 0;
45}
46
Theodore Ts'o5dabfc72010-10-27 21:30:14 -040047void ext4_exit_pageio(void)
Theodore Ts'obd2d0212010-10-27 21:30:10 -040048{
49 kmem_cache_destroy(io_end_cachep);
50 kmem_cache_destroy(io_page_cachep);
51}
52
Theodore Ts'of7ad6d22010-11-08 13:43:33 -050053void ext4_ioend_wait(struct inode *inode)
54{
Eric Sandeene9e3bce2011-02-12 08:17:34 -050055 wait_queue_head_t *wq = ext4_ioend_wq(inode);
Theodore Ts'of7ad6d22010-11-08 13:43:33 -050056
57 wait_event(*wq, (atomic_read(&EXT4_I(inode)->i_ioend_count) == 0));
58}
59
Theodore Ts'o83668e72010-11-08 13:45:33 -050060static void put_io_page(struct ext4_io_page *io_page)
61{
62 if (atomic_dec_and_test(&io_page->p_count)) {
Linus Torvalds6268b322012-03-29 17:00:56 -070063 end_page_writeback(io_page->p_page);
Theodore Ts'o83668e72010-11-08 13:45:33 -050064 put_page(io_page->p_page);
65 kmem_cache_free(io_page_cachep, io_page);
66 }
67}
68
Theodore Ts'obd2d0212010-10-27 21:30:10 -040069void ext4_free_io_end(ext4_io_end_t *io)
70{
71 int i;
72
73 BUG_ON(!io);
Dmitry Monakhov28a535f2012-09-29 00:14:55 -040074 BUG_ON(!list_empty(&io->list));
Dmitry Monakhov82e54222012-09-28 23:36:25 -040075 BUG_ON(io->flag & EXT4_IO_END_UNWRITTEN);
76
Theodore Ts'o83668e72010-11-08 13:45:33 -050077 for (i = 0; i < io->num_io_pages; i++)
78 put_io_page(io->pages[i]);
Theodore Ts'obd2d0212010-10-27 21:30:10 -040079 io->num_io_pages = 0;
Theodore Ts'o4e298022011-10-30 18:41:19 -040080 if (atomic_dec_and_test(&EXT4_I(io->inode)->i_ioend_count))
81 wake_up_all(ext4_ioend_wq(io->inode));
Theodore Ts'obd2d0212010-10-27 21:30:10 -040082 kmem_cache_free(io_end_cachep, io);
83}
84
Dmitry Monakhov28a535f2012-09-29 00:14:55 -040085/* check a range of space and convert unwritten extents to written. */
86static int ext4_end_io(ext4_io_end_t *io)
Theodore Ts'obd2d0212010-10-27 21:30:10 -040087{
88 struct inode *inode = io->inode;
89 loff_t offset = io->offset;
90 ssize_t size = io->size;
91 int ret = 0;
92
93 ext4_debug("ext4_end_io_nolock: io 0x%p from inode %lu,list->next 0x%p,"
94 "list->prev 0x%p\n",
95 io, inode->i_ino, io->list.next, io->list.prev);
96
Theodore Ts'obd2d0212010-10-27 21:30:10 -040097 ret = ext4_convert_unwritten_extents(inode, offset, size);
98 if (ret < 0) {
Theodore Ts'ob82e3842011-10-31 10:56:32 -040099 ext4_msg(inode->i_sb, KERN_EMERG,
100 "failed to convert unwritten extents to written "
101 "extents -- potential data loss! "
102 "(inode %lu, offset %llu, size %zd, error %d)",
103 inode->i_ino, offset, size, ret);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400104 }
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400105 if (io->iocb)
106 aio_complete(io->iocb, io->result, 0);
Eric Sandeene9e3bce2011-02-12 08:17:34 -0500107
Jeff Moyer266991b2012-02-20 17:59:24 -0500108 if (io->flag & EXT4_IO_END_DIRECT)
109 inode_dio_done(inode);
Theodore Ts'ob82e3842011-10-31 10:56:32 -0400110 /* Wake up anyone waiting on unwritten extent conversion */
Dmitry Monakhove27f41e2012-09-28 23:24:52 -0400111 if (atomic_dec_and_test(&EXT4_I(inode)->i_unwritten))
Anatol Pomozov8d8c1822012-11-08 14:53:35 -0500112 wake_up_all(ext4_ioend_wq(inode));
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400113 return ret;
114}
115
Dmitry Monakhov28a535f2012-09-29 00:14:55 -0400116static void dump_completed_IO(struct inode *inode)
117{
118#ifdef EXT4FS_DEBUG
119 struct list_head *cur, *before, *after;
120 ext4_io_end_t *io, *io0, *io1;
121 unsigned long flags;
122
123 if (list_empty(&EXT4_I(inode)->i_completed_io_list)) {
124 ext4_debug("inode %lu completed_io list is empty\n",
125 inode->i_ino);
126 return;
127 }
128
129 ext4_debug("Dump inode %lu completed_io list\n", inode->i_ino);
130 list_for_each_entry(io, &EXT4_I(inode)->i_completed_io_list, list) {
131 cur = &io->list;
132 before = cur->prev;
133 io0 = container_of(before, ext4_io_end_t, list);
134 after = cur->next;
135 io1 = container_of(after, ext4_io_end_t, list);
136
137 ext4_debug("io 0x%p from inode %lu,prev 0x%p,next 0x%p\n",
138 io, inode->i_ino, io0, io1);
139 }
140#endif
141}
142
143/* Add the io_end to per-inode completed end_io list. */
144void ext4_add_complete_io(ext4_io_end_t *io_end)
145{
146 struct ext4_inode_info *ei = EXT4_I(io_end->inode);
147 struct workqueue_struct *wq;
148 unsigned long flags;
149
150 BUG_ON(!(io_end->flag & EXT4_IO_END_UNWRITTEN));
151 wq = EXT4_SB(io_end->inode->i_sb)->dio_unwritten_wq;
152
153 spin_lock_irqsave(&ei->i_completed_io_lock, flags);
154 if (list_empty(&ei->i_completed_io_list)) {
155 io_end->flag |= EXT4_IO_END_QUEUED;
156 queue_work(wq, &io_end->work);
157 }
158 list_add_tail(&io_end->list, &ei->i_completed_io_list);
159 spin_unlock_irqrestore(&ei->i_completed_io_lock, flags);
160}
161
162static int ext4_do_flush_completed_IO(struct inode *inode,
163 ext4_io_end_t *work_io)
164{
165 ext4_io_end_t *io;
166 struct list_head unwritten, complete, to_free;
167 unsigned long flags;
168 struct ext4_inode_info *ei = EXT4_I(inode);
169 int err, ret = 0;
170
171 INIT_LIST_HEAD(&complete);
172 INIT_LIST_HEAD(&to_free);
173
174 spin_lock_irqsave(&ei->i_completed_io_lock, flags);
175 dump_completed_IO(inode);
176 list_replace_init(&ei->i_completed_io_list, &unwritten);
177 spin_unlock_irqrestore(&ei->i_completed_io_lock, flags);
178
179 while (!list_empty(&unwritten)) {
180 io = list_entry(unwritten.next, ext4_io_end_t, list);
181 BUG_ON(!(io->flag & EXT4_IO_END_UNWRITTEN));
182 list_del_init(&io->list);
183
184 err = ext4_end_io(io);
185 if (unlikely(!ret && err))
186 ret = err;
187
188 list_add_tail(&io->list, &complete);
189 }
Dmitry Monakhov28a535f2012-09-29 00:14:55 -0400190 spin_lock_irqsave(&ei->i_completed_io_lock, flags);
191 while (!list_empty(&complete)) {
192 io = list_entry(complete.next, ext4_io_end_t, list);
193 io->flag &= ~EXT4_IO_END_UNWRITTEN;
194 /* end_io context can not be destroyed now because it still
195 * used by queued worker. Worker thread will destroy it later */
196 if (io->flag & EXT4_IO_END_QUEUED)
197 list_del_init(&io->list);
198 else
199 list_move(&io->list, &to_free);
200 }
201 /* If we are called from worker context, it is time to clear queued
202 * flag, and destroy it's end_io if it was converted already */
203 if (work_io) {
204 work_io->flag &= ~EXT4_IO_END_QUEUED;
205 if (!(work_io->flag & EXT4_IO_END_UNWRITTEN))
206 list_add_tail(&work_io->list, &to_free);
207 }
208 spin_unlock_irqrestore(&ei->i_completed_io_lock, flags);
209
210 while (!list_empty(&to_free)) {
211 io = list_entry(to_free.next, ext4_io_end_t, list);
212 list_del_init(&io->list);
213 ext4_free_io_end(io);
214 }
215 return ret;
216}
217
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400218/*
219 * work on completed aio dio IO, to convert unwritten extents to extents
220 */
221static void ext4_end_io_work(struct work_struct *work)
222{
Dmitry Monakhov28a535f2012-09-29 00:14:55 -0400223 ext4_io_end_t *io = container_of(work, ext4_io_end_t, work);
224 ext4_do_flush_completed_IO(io->inode, io);
225}
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400226
Dmitry Monakhovc2785312012-10-05 11:31:55 -0400227int ext4_flush_unwritten_io(struct inode *inode)
Dmitry Monakhov28a535f2012-09-29 00:14:55 -0400228{
Dmitry Monakhovc2785312012-10-05 11:31:55 -0400229 int ret;
230 WARN_ON_ONCE(!mutex_is_locked(&inode->i_mutex) &&
231 !(inode->i_state & I_FREEING));
232 ret = ext4_do_flush_completed_IO(inode, NULL);
233 ext4_unwritten_wait(inode);
234 return ret;
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400235}
236
237ext4_io_end_t *ext4_init_io_end(struct inode *inode, gfp_t flags)
238{
Jesper Juhlb17b35e2010-12-19 21:41:55 -0500239 ext4_io_end_t *io = kmem_cache_zalloc(io_end_cachep, flags);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400240 if (io) {
Theodore Ts'of7ad6d22010-11-08 13:43:33 -0500241 atomic_inc(&EXT4_I(inode)->i_ioend_count);
242 io->inode = inode;
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400243 INIT_WORK(&io->work, ext4_end_io_work);
244 INIT_LIST_HEAD(&io->list);
245 }
246 return io;
247}
248
249/*
250 * Print an buffer I/O error compatible with the fs/buffer.c. This
251 * provides compatibility with dmesg scrapers that look for a specific
252 * buffer I/O error message. We really need a unified error reporting
253 * structure to userspace ala Digital Unix's uerf system, but it's
254 * probably not going to happen in my lifetime, due to LKML politics...
255 */
256static void buffer_io_error(struct buffer_head *bh)
257{
258 char b[BDEVNAME_SIZE];
259 printk(KERN_ERR "Buffer I/O error on device %s, logical block %llu\n",
260 bdevname(bh->b_bdev, b),
261 (unsigned long long)bh->b_blocknr);
262}
263
264static void ext4_end_bio(struct bio *bio, int error)
265{
266 ext4_io_end_t *io_end = bio->bi_private;
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400267 struct inode *inode;
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400268 int i;
Curt Wohlgemuthd50bdd52011-02-07 12:46:14 -0500269 sector_t bi_sector = bio->bi_sector;
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400270
271 BUG_ON(!io_end);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400272 bio->bi_private = NULL;
273 bio->bi_end_io = NULL;
274 if (test_bit(BIO_UPTODATE, &bio->bi_flags))
275 error = 0;
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400276 bio_put(bio);
277
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400278 for (i = 0; i < io_end->num_io_pages; i++) {
279 struct page *page = io_end->pages[i]->p_page;
280 struct buffer_head *bh, *head;
Curt Wohlgemuth39db00f2011-04-30 13:26:26 -0400281 loff_t offset;
282 loff_t io_end_offset;
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400283
Curt Wohlgemuth39db00f2011-04-30 13:26:26 -0400284 if (error) {
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400285 SetPageError(page);
Curt Wohlgemuth39db00f2011-04-30 13:26:26 -0400286 set_bit(AS_EIO, &page->mapping->flags);
287 head = page_buffers(page);
288 BUG_ON(!head);
289
290 io_end_offset = io_end->offset + io_end->size;
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400291
292 offset = (sector_t) page->index << PAGE_CACHE_SHIFT;
293 bh = head;
294 do {
295 if ((offset >= io_end->offset) &&
Curt Wohlgemuth39db00f2011-04-30 13:26:26 -0400296 (offset+bh->b_size <= io_end_offset))
297 buffer_io_error(bh);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400298
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400299 offset += bh->b_size;
300 bh = bh->b_this_page;
301 } while (bh != head);
302 }
303
Linus Torvalds6268b322012-03-29 17:00:56 -0700304 put_io_page(io_end->pages[i]);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400305 }
Linus Torvalds6268b322012-03-29 17:00:56 -0700306 io_end->num_io_pages = 0;
Theodore Ts'of7ad6d22010-11-08 13:43:33 -0500307 inode = io_end->inode;
308
309 if (error) {
310 io_end->flag |= EXT4_IO_END_ERROR;
311 ext4_warning(inode->i_sb, "I/O error writing to inode %lu "
312 "(offset %llu size %ld starting block %llu)",
313 inode->i_ino,
314 (unsigned long long) io_end->offset,
315 (long) io_end->size,
316 (unsigned long long)
Curt Wohlgemuthd50bdd52011-02-07 12:46:14 -0500317 bi_sector >> (inode->i_blkbits - 9));
Theodore Ts'of7ad6d22010-11-08 13:43:33 -0500318 }
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400319
Theodore Ts'ob6168442011-02-28 13:12:38 -0500320 if (!(io_end->flag & EXT4_IO_END_UNWRITTEN)) {
321 ext4_free_io_end(io_end);
322 return;
323 }
324
Dmitry Monakhov28a535f2012-09-29 00:14:55 -0400325 ext4_add_complete_io(io_end);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400326}
327
328void ext4_io_submit(struct ext4_io_submit *io)
329{
330 struct bio *bio = io->io_bio;
331
332 if (bio) {
333 bio_get(io->io_bio);
334 submit_bio(io->io_op, io->io_bio);
335 BUG_ON(bio_flagged(io->io_bio, BIO_EOPNOTSUPP));
336 bio_put(io->io_bio);
337 }
Peter Huewe7dc57612011-02-21 21:01:42 -0500338 io->io_bio = NULL;
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400339 io->io_op = 0;
Peter Huewe7dc57612011-02-21 21:01:42 -0500340 io->io_end = NULL;
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400341}
342
343static int io_submit_init(struct ext4_io_submit *io,
344 struct inode *inode,
345 struct writeback_control *wbc,
346 struct buffer_head *bh)
347{
348 ext4_io_end_t *io_end;
349 struct page *page = bh->b_page;
350 int nvecs = bio_get_nr_vecs(bh->b_bdev);
351 struct bio *bio;
352
353 io_end = ext4_init_io_end(inode, GFP_NOFS);
354 if (!io_end)
355 return -ENOMEM;
Theodore Ts'o275d3ba2011-06-29 21:44:45 -0400356 bio = bio_alloc(GFP_NOIO, min(nvecs, BIO_MAX_PAGES));
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400357 bio->bi_sector = bh->b_blocknr * (bh->b_size >> 9);
358 bio->bi_bdev = bh->b_bdev;
359 bio->bi_private = io->io_end = io_end;
360 bio->bi_end_io = ext4_end_bio;
361
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400362 io_end->offset = (page->index << PAGE_CACHE_SHIFT) + bh_offset(bh);
363
364 io->io_bio = bio;
Jens Axboe721a9602011-03-09 11:56:30 +0100365 io->io_op = (wbc->sync_mode == WB_SYNC_ALL ? WRITE_SYNC : WRITE);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400366 io->io_next_block = bh->b_blocknr;
367 return 0;
368}
369
370static int io_submit_add_bh(struct ext4_io_submit *io,
371 struct ext4_io_page *io_page,
372 struct inode *inode,
373 struct writeback_control *wbc,
374 struct buffer_head *bh)
375{
376 ext4_io_end_t *io_end;
377 int ret;
378
379 if (buffer_new(bh)) {
380 clear_buffer_new(bh);
381 unmap_underlying_metadata(bh->b_bdev, bh->b_blocknr);
382 }
383
384 if (!buffer_mapped(bh) || buffer_delay(bh)) {
385 if (!buffer_mapped(bh))
386 clear_buffer_dirty(bh);
387 if (io->io_bio)
388 ext4_io_submit(io);
389 return 0;
390 }
391
392 if (io->io_bio && bh->b_blocknr != io->io_next_block) {
393submit_and_retry:
394 ext4_io_submit(io);
395 }
396 if (io->io_bio == NULL) {
397 ret = io_submit_init(io, inode, wbc, bh);
398 if (ret)
399 return ret;
400 }
401 io_end = io->io_end;
402 if ((io_end->num_io_pages >= MAX_IO_PAGES) &&
403 (io_end->pages[io_end->num_io_pages-1] != io_page))
404 goto submit_and_retry;
Tao Ma0edeb712011-10-31 17:30:44 -0400405 if (buffer_uninit(bh))
406 ext4_set_io_unwritten_flag(inode, io_end);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400407 io->io_end->size += bh->b_size;
408 io->io_next_block++;
409 ret = bio_add_page(io->io_bio, bh->b_page, bh->b_size, bh_offset(bh));
410 if (ret != bh->b_size)
411 goto submit_and_retry;
412 if ((io_end->num_io_pages == 0) ||
413 (io_end->pages[io_end->num_io_pages-1] != io_page)) {
414 io_end->pages[io_end->num_io_pages++] = io_page;
Theodore Ts'o83668e72010-11-08 13:45:33 -0500415 atomic_inc(&io_page->p_count);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400416 }
417 return 0;
418}
419
420int ext4_bio_write_page(struct ext4_io_submit *io,
421 struct page *page,
422 int len,
423 struct writeback_control *wbc)
424{
425 struct inode *inode = page->mapping->host;
426 unsigned block_start, block_end, blocksize;
427 struct ext4_io_page *io_page;
428 struct buffer_head *bh, *head;
429 int ret = 0;
430
431 blocksize = 1 << inode->i_blkbits;
432
Curt Wohlgemuthd50bdd52011-02-07 12:46:14 -0500433 BUG_ON(!PageLocked(page));
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400434 BUG_ON(PageWriteback(page));
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400435
436 io_page = kmem_cache_alloc(io_page_cachep, GFP_NOFS);
437 if (!io_page) {
Jan Kara1ae48a62013-01-28 09:32:54 -0500438 redirty_page_for_writepage(wbc, page);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400439 unlock_page(page);
440 return -ENOMEM;
441 }
442 io_page->p_page = page;
Theodore Ts'o83668e72010-11-08 13:45:33 -0500443 atomic_set(&io_page->p_count, 1);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400444 get_page(page);
Theodore Ts'oa54aa762011-02-27 16:43:24 -0500445 set_page_writeback(page);
446 ClearPageError(page);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400447
448 for (bh = head = page_buffers(page), block_start = 0;
449 bh != head || !block_start;
450 block_start = block_end, bh = bh->b_this_page) {
Curt Wohlgemuthd50bdd52011-02-07 12:46:14 -0500451
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400452 block_end = block_start + blocksize;
453 if (block_start >= len) {
Yongqiang Yang5a0dc732011-12-13 22:29:12 -0500454 /*
455 * Comments copied from block_write_full_page_endio:
456 *
457 * The page straddles i_size. It must be zeroed out on
458 * each and every writepage invocation because it may
459 * be mmapped. "A file is mapped in multiples of the
460 * page size. For a file that is not a multiple of
461 * the page size, the remaining memory is zeroed when
462 * mapped, and writes to that region are not written
463 * out to the file."
464 */
465 zero_user_segment(page, block_start, block_end);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400466 clear_buffer_dirty(bh);
467 set_buffer_uptodate(bh);
468 continue;
469 }
470 ret = io_submit_add_bh(io, io_page, inode, wbc, bh);
471 if (ret) {
472 /*
473 * We only get here on ENOMEM. Not much else
474 * we can do but mark the page as dirty, and
475 * better luck next time.
476 */
Jan Kara1ae48a62013-01-28 09:32:54 -0500477 redirty_page_for_writepage(wbc, page);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400478 break;
479 }
Jan Kara1ae48a62013-01-28 09:32:54 -0500480 clear_buffer_dirty(bh);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400481 }
482 unlock_page(page);
483 /*
484 * If the page was truncated before we could do the writeback,
485 * or we had a memory allocation error while trying to write
486 * the first buffer head, we won't have submitted any pages for
487 * I/O. In that case we need to make sure we've cleared the
488 * PageWriteback bit from the page to prevent the system from
489 * wedging later on.
490 */
Theodore Ts'o83668e72010-11-08 13:45:33 -0500491 put_io_page(io_page);
Theodore Ts'obd2d0212010-10-27 21:30:10 -0400492 return ret;
493}