blob: f419dd999581e976fb51a5987211de6bbe87f9e6 [file] [log] [blame]
Mike Marshall5db11c22015-07-17 10:38:12 -04001/*
2 * (C) 2001 Clemson University and The University of Chicago
3 *
4 * Changes by Acxiom Corporation to add protocol version to kernel
5 * communication, Copyright Acxiom Corporation, 2005.
6 *
7 * See COPYING in top-level directory.
8 */
9
10#include "protocol.h"
Mike Marshall575e9462015-12-04 12:56:14 -050011#include "orangefs-kernel.h"
12#include "orangefs-dev-proto.h"
13#include "orangefs-bufmap.h"
Martin Brandenburg44f46412016-08-15 11:38:36 -040014#include "orangefs-debugfs.h"
Mike Marshall5db11c22015-07-17 10:38:12 -040015
16#include <linux/debugfs.h>
17#include <linux/slab.h>
18
19/* this file implements the /dev/pvfs2-req device node */
20
Martin Brandenburg482664d2016-08-12 12:02:31 -040021uint32_t orangefs_userspace_version;
Martin Brandenburgf2ee3b72016-08-09 15:59:26 -040022
Mike Marshall5db11c22015-07-17 10:38:12 -040023static int open_access_count;
24
Martin Brandenburga0fe0512016-08-15 15:21:16 -040025static DEFINE_MUTEX(devreq_mutex);
26
Mike Marshall5db11c22015-07-17 10:38:12 -040027#define DUMP_DEVICE_ERROR() \
28do { \
29 gossip_err("*****************************************************\n");\
Yi Liu8bb8aef2015-11-24 15:12:14 -050030 gossip_err("ORANGEFS Device Error: You cannot open the device file "); \
Mike Marshall5db11c22015-07-17 10:38:12 -040031 gossip_err("\n/dev/%s more than once. Please make sure that\nthere " \
Yi Liu8bb8aef2015-11-24 15:12:14 -050032 "are no ", ORANGEFS_REQDEVICE_NAME); \
Mike Marshall5db11c22015-07-17 10:38:12 -040033 gossip_err("instances of a program using this device\ncurrently " \
34 "running. (You must verify this!)\n"); \
35 gossip_err("For example, you can use the lsof program as follows:\n");\
36 gossip_err("'lsof | grep %s' (run this as root)\n", \
Yi Liu8bb8aef2015-11-24 15:12:14 -050037 ORANGEFS_REQDEVICE_NAME); \
Mike Marshall5db11c22015-07-17 10:38:12 -040038 gossip_err(" open_access_count = %d\n", open_access_count); \
39 gossip_err("*****************************************************\n");\
40} while (0)
41
42static int hash_func(__u64 tag, int table_size)
43{
Mike Marshall2c590d52015-07-24 10:37:15 -040044 return do_div(tag, (unsigned int)table_size);
Mike Marshall5db11c22015-07-17 10:38:12 -040045}
46
Yi Liu8bb8aef2015-11-24 15:12:14 -050047static void orangefs_devreq_add_op(struct orangefs_kernel_op_s *op)
Mike Marshall5db11c22015-07-17 10:38:12 -040048{
49 int index = hash_func(op->tag, hash_table_size);
50
Martin Brandenburg1d503612016-08-16 11:38:14 -040051 list_add_tail(&op->list, &orangefs_htable_ops_in_progress[index]);
Mike Marshall5db11c22015-07-17 10:38:12 -040052}
53
Mike Marshallca9f5182016-02-26 10:21:12 -050054/*
55 * find the op with this tag and remove it from the in progress
56 * hash table.
57 */
Yi Liu8bb8aef2015-11-24 15:12:14 -050058static struct orangefs_kernel_op_s *orangefs_devreq_remove_op(__u64 tag)
Mike Marshall5db11c22015-07-17 10:38:12 -040059{
Yi Liu8bb8aef2015-11-24 15:12:14 -050060 struct orangefs_kernel_op_s *op, *next;
Mike Marshall5db11c22015-07-17 10:38:12 -040061 int index;
62
63 index = hash_func(tag, hash_table_size);
64
Martin Brandenburg1d503612016-08-16 11:38:14 -040065 spin_lock(&orangefs_htable_ops_in_progress_lock);
Mike Marshall5db11c22015-07-17 10:38:12 -040066 list_for_each_entry_safe(op,
67 next,
Martin Brandenburg1d503612016-08-16 11:38:14 -040068 &orangefs_htable_ops_in_progress[index],
Mike Marshall5db11c22015-07-17 10:38:12 -040069 list) {
Al Viro05a50a52016-02-18 18:59:44 -050070 if (op->tag == tag && !op_state_purged(op) &&
71 !op_state_given_up(op)) {
Al Viroed42fe02016-01-22 19:47:47 -050072 list_del_init(&op->list);
Martin Brandenburg1d503612016-08-16 11:38:14 -040073 spin_unlock(&orangefs_htable_ops_in_progress_lock);
Mike Marshall5db11c22015-07-17 10:38:12 -040074 return op;
75 }
76 }
77
Martin Brandenburg1d503612016-08-16 11:38:14 -040078 spin_unlock(&orangefs_htable_ops_in_progress_lock);
Mike Marshall5db11c22015-07-17 10:38:12 -040079 return NULL;
80}
81
Martin Brandenburgacfcbaf2016-03-05 13:17:39 -050082/* Returns whether any FS are still pending remounted */
83static int mark_all_pending_mounts(void)
84{
85 int unmounted = 1;
86 struct orangefs_sb_info_s *orangefs_sb = NULL;
87
88 spin_lock(&orangefs_superblocks_lock);
89 list_for_each_entry(orangefs_sb, &orangefs_superblocks, list) {
90 /* All of these file system require a remount */
91 orangefs_sb->mount_pending = 1;
92 unmounted = 0;
93 }
94 spin_unlock(&orangefs_superblocks_lock);
95 return unmounted;
96}
97
98/*
99 * Determine if a given file system needs to be remounted or not
100 * Returns -1 on error
101 * 0 if already mounted
102 * 1 if needs remount
103 */
104static int fs_mount_pending(__s32 fsid)
105{
106 int mount_pending = -1;
107 struct orangefs_sb_info_s *orangefs_sb = NULL;
108
109 spin_lock(&orangefs_superblocks_lock);
110 list_for_each_entry(orangefs_sb, &orangefs_superblocks, list) {
111 if (orangefs_sb->fs_id == fsid) {
112 mount_pending = orangefs_sb->mount_pending;
113 break;
114 }
115 }
116 spin_unlock(&orangefs_superblocks_lock);
117 return mount_pending;
118}
119
Yi Liu8bb8aef2015-11-24 15:12:14 -0500120static int orangefs_devreq_open(struct inode *inode, struct file *file)
Mike Marshall5db11c22015-07-17 10:38:12 -0400121{
122 int ret = -EINVAL;
123
Jann Horn78fee0b2016-06-25 01:51:52 +0200124 /* in order to ensure that the filesystem driver sees correct UIDs */
125 if (file->f_cred->user_ns != &init_user_ns) {
126 gossip_err("%s: device cannot be opened outside init_user_ns\n",
127 __func__);
128 goto out;
129 }
130
Mike Marshall5db11c22015-07-17 10:38:12 -0400131 if (!(file->f_flags & O_NONBLOCK)) {
Mike Marshall97f10022015-12-11 16:45:03 -0500132 gossip_err("%s: device cannot be opened in blocking mode\n",
133 __func__);
Mike Marshall5db11c22015-07-17 10:38:12 -0400134 goto out;
135 }
136 ret = -EACCES;
Mike Marshall97f10022015-12-11 16:45:03 -0500137 gossip_debug(GOSSIP_DEV_DEBUG, "client-core: opening device\n");
Mike Marshall5db11c22015-07-17 10:38:12 -0400138 mutex_lock(&devreq_mutex);
139
140 if (open_access_count == 0) {
Al Virofee25ce2016-01-22 19:46:08 -0500141 open_access_count = 1;
Al Virofb6d2522016-01-19 12:00:26 -0500142 ret = 0;
Mike Marshall5db11c22015-07-17 10:38:12 -0400143 } else {
144 DUMP_DEVICE_ERROR();
145 }
146 mutex_unlock(&devreq_mutex);
147
148out:
149
150 gossip_debug(GOSSIP_DEV_DEBUG,
151 "pvfs2-client-core: open device complete (ret = %d)\n",
152 ret);
153 return ret;
154}
155
Mike Marshall97f10022015-12-11 16:45:03 -0500156/* Function for read() callers into the device */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500157static ssize_t orangefs_devreq_read(struct file *file,
Mike Marshall5db11c22015-07-17 10:38:12 -0400158 char __user *buf,
159 size_t count, loff_t *offset)
160{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500161 struct orangefs_kernel_op_s *op, *temp;
162 __s32 proto_ver = ORANGEFS_KERNEL_PROTO_VERSION;
163 static __s32 magic = ORANGEFS_DEVREQ_MAGIC;
164 struct orangefs_kernel_op_s *cur_op = NULL;
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500165 unsigned long ret;
Mike Marshall5db11c22015-07-17 10:38:12 -0400166
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500167 /* We do not support blocking IO. */
Mike Marshall5db11c22015-07-17 10:38:12 -0400168 if (!(file->f_flags & O_NONBLOCK)) {
Mike Marshall97f10022015-12-11 16:45:03 -0500169 gossip_err("%s: blocking read from client-core.\n",
170 __func__);
Mike Marshall5db11c22015-07-17 10:38:12 -0400171 return -EINVAL;
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500172 }
173
174 /*
Martin Brandenburga762ae62015-12-15 14:22:06 -0500175 * The client will do an ioctl to find MAX_DEV_REQ_UPSIZE, then
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500176 * always read with that size buffer.
177 */
Martin Brandenburga762ae62015-12-15 14:22:06 -0500178 if (count != MAX_DEV_REQ_UPSIZE) {
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500179 gossip_err("orangefs: client-core tried to read wrong size\n");
180 return -EINVAL;
181 }
182
Al Viroed42fe02016-01-22 19:47:47 -0500183restart:
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500184 /* Get next op (if any) from top of list. */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500185 spin_lock(&orangefs_request_list_lock);
186 list_for_each_entry_safe(op, temp, &orangefs_request_list, list) {
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500187 __s32 fsid;
188 /* This lock is held past the end of the loop when we break. */
189 spin_lock(&op->lock);
Al Viro05a50a52016-02-18 18:59:44 -0500190 if (unlikely(op_state_purged(op) || op_state_given_up(op))) {
Al Viroed42fe02016-01-22 19:47:47 -0500191 spin_unlock(&op->lock);
192 continue;
193 }
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500194
195 fsid = fsid_of_op(op);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500196 if (fsid != ORANGEFS_FS_ID_NULL) {
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500197 int ret;
198 /* Skip ops whose filesystem needs to be mounted. */
199 ret = fs_mount_pending(fsid);
200 if (ret == 1) {
Mike Marshall5db11c22015-07-17 10:38:12 -0400201 gossip_debug(GOSSIP_DEV_DEBUG,
Mike Marshall5090c962016-02-04 13:29:27 -0500202 "%s: mount pending, skipping op tag "
203 "%llu %s\n",
204 __func__,
205 llu(op->tag),
206 get_opname_string(op));
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500207 spin_unlock(&op->lock);
Mike Marshall5db11c22015-07-17 10:38:12 -0400208 continue;
Mike Marshall97f10022015-12-11 16:45:03 -0500209 /*
210 * Skip ops whose filesystem we don't know about unless
211 * it is being mounted.
212 */
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500213 /* XXX: is there a better way to detect this? */
214 } else if (ret == -1 &&
Mike Marshall97f10022015-12-11 16:45:03 -0500215 !(op->upcall.type ==
216 ORANGEFS_VFS_OP_FS_MOUNT ||
217 op->upcall.type ==
218 ORANGEFS_VFS_OP_GETATTR)) {
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500219 gossip_debug(GOSSIP_DEV_DEBUG,
220 "orangefs: skipping op tag %llu %s\n",
221 llu(op->tag), get_opname_string(op));
222 gossip_err(
223 "orangefs: ERROR: fs_mount_pending %d\n",
224 fsid);
225 spin_unlock(&op->lock);
226 continue;
Mike Marshall5db11c22015-07-17 10:38:12 -0400227 }
228 }
Mike Marshall5db11c22015-07-17 10:38:12 -0400229 /*
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500230 * Either this op does not pertain to a filesystem, is mounting
231 * a filesystem, or pertains to a mounted filesystem. Let it
232 * through.
Mike Marshall5db11c22015-07-17 10:38:12 -0400233 */
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500234 cur_op = op;
235 break;
Mike Marshall5db11c22015-07-17 10:38:12 -0400236 }
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500237
238 /*
239 * At this point we either have a valid op and can continue or have not
240 * found an op and must ask the client to try again later.
241 */
242 if (!cur_op) {
Yi Liu8bb8aef2015-11-24 15:12:14 -0500243 spin_unlock(&orangefs_request_list_lock);
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500244 return -EAGAIN;
245 }
246
Mike Marshallca9f5182016-02-26 10:21:12 -0500247 gossip_debug(GOSSIP_DEV_DEBUG, "%s: reading op tag %llu %s\n",
248 __func__,
249 llu(cur_op->tag),
250 get_opname_string(cur_op));
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500251
252 /*
253 * Such an op should never be on the list in the first place. If so, we
254 * will abort.
255 */
256 if (op_state_in_progress(cur_op) || op_state_serviced(cur_op)) {
257 gossip_err("orangefs: ERROR: Current op already queued.\n");
Al Viro05a50a52016-02-18 18:59:44 -0500258 list_del_init(&cur_op->list);
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500259 spin_unlock(&cur_op->lock);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500260 spin_unlock(&orangefs_request_list_lock);
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500261 return -EAGAIN;
262 }
Mike Marshallca9f5182016-02-26 10:21:12 -0500263
Al Viroed42fe02016-01-22 19:47:47 -0500264 list_del_init(&cur_op->list);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500265 spin_unlock(&orangefs_request_list_lock);
Al Viroed42fe02016-01-22 19:47:47 -0500266
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500267 spin_unlock(&cur_op->lock);
268
269 /* Push the upcall out. */
270 ret = copy_to_user(buf, &proto_ver, sizeof(__s32));
271 if (ret != 0)
272 goto error;
273 ret = copy_to_user(buf+sizeof(__s32), &magic, sizeof(__s32));
274 if (ret != 0)
275 goto error;
276 ret = copy_to_user(buf+2 * sizeof(__s32), &cur_op->tag, sizeof(__u64));
277 if (ret != 0)
278 goto error;
279 ret = copy_to_user(buf+2*sizeof(__s32)+sizeof(__u64), &cur_op->upcall,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500280 sizeof(struct orangefs_upcall_s));
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500281 if (ret != 0)
282 goto error;
283
Martin Brandenburg1d503612016-08-16 11:38:14 -0400284 spin_lock(&orangefs_htable_ops_in_progress_lock);
Al Viroed42fe02016-01-22 19:47:47 -0500285 spin_lock(&cur_op->lock);
286 if (unlikely(op_state_given_up(cur_op))) {
287 spin_unlock(&cur_op->lock);
Martin Brandenburg1d503612016-08-16 11:38:14 -0400288 spin_unlock(&orangefs_htable_ops_in_progress_lock);
Al Viro05a50a52016-02-18 18:59:44 -0500289 complete(&cur_op->waitq);
Al Viroed42fe02016-01-22 19:47:47 -0500290 goto restart;
291 }
292
293 /*
294 * Set the operation to be in progress and move it between lists since
295 * it has been sent to the client.
296 */
297 set_op_state_inprogress(cur_op);
Mike Marshall9d9e7ba2016-03-03 13:46:48 -0500298 gossip_debug(GOSSIP_DEV_DEBUG,
299 "%s: 1 op:%s: op_state:%d: process:%s:\n",
300 __func__,
301 get_opname_string(cur_op),
302 cur_op->op_state,
303 current->comm);
Al Viroed42fe02016-01-22 19:47:47 -0500304 orangefs_devreq_add_op(cur_op);
305 spin_unlock(&cur_op->lock);
Martin Brandenburg1d503612016-08-16 11:38:14 -0400306 spin_unlock(&orangefs_htable_ops_in_progress_lock);
Al Viroed42fe02016-01-22 19:47:47 -0500307
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500308 /* The client only asks to read one size buffer. */
Martin Brandenburga762ae62015-12-15 14:22:06 -0500309 return MAX_DEV_REQ_UPSIZE;
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500310error:
311 /*
312 * We were unable to copy the op data to the client. Put the op back in
313 * list. If client has crashed, the op will be purged later when the
314 * device is released.
315 */
316 gossip_err("orangefs: Failed to copy data to user space\n");
Yi Liu8bb8aef2015-11-24 15:12:14 -0500317 spin_lock(&orangefs_request_list_lock);
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500318 spin_lock(&cur_op->lock);
Al Viroed42fe02016-01-22 19:47:47 -0500319 if (likely(!op_state_given_up(cur_op))) {
320 set_op_state_waiting(cur_op);
Mike Marshall9d9e7ba2016-03-03 13:46:48 -0500321 gossip_debug(GOSSIP_DEV_DEBUG,
322 "%s: 2 op:%s: op_state:%d: process:%s:\n",
323 __func__,
324 get_opname_string(cur_op),
325 cur_op->op_state,
326 current->comm);
Al Viroed42fe02016-01-22 19:47:47 -0500327 list_add(&cur_op->list, &orangefs_request_list);
Al Viro05a50a52016-02-18 18:59:44 -0500328 spin_unlock(&cur_op->lock);
329 } else {
330 spin_unlock(&cur_op->lock);
331 complete(&cur_op->waitq);
Al Viroed42fe02016-01-22 19:47:47 -0500332 }
Yi Liu8bb8aef2015-11-24 15:12:14 -0500333 spin_unlock(&orangefs_request_list_lock);
Martin Brandenburg24c8d082015-11-13 14:26:10 -0500334 return -EFAULT;
Mike Marshall5db11c22015-07-17 10:38:12 -0400335}
336
Mike Marshall97f10022015-12-11 16:45:03 -0500337/*
Mike Marshallb3ae4752016-01-13 11:18:12 -0500338 * Function for writev() callers into the device.
339 *
340 * Userspace should have written:
341 * - __u32 version
342 * - __u32 magic
343 * - __u64 tag
344 * - struct orangefs_downcall_s
345 * - trailer buffer (in the case of READDIR operations)
Mike Marshall97f10022015-12-11 16:45:03 -0500346 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500347static ssize_t orangefs_devreq_write_iter(struct kiocb *iocb,
Mike Marshall5db11c22015-07-17 10:38:12 -0400348 struct iov_iter *iter)
349{
Mike Marshallb3ae4752016-01-13 11:18:12 -0500350 ssize_t ret;
351 struct orangefs_kernel_op_s *op = NULL;
352 struct {
353 __u32 version;
354 __u32 magic;
355 __u64 tag;
356 } head;
357 int total = ret = iov_iter_count(iter);
358 int n;
359 int downcall_size = sizeof(struct orangefs_downcall_s);
360 int head_size = sizeof(head);
361
362 gossip_debug(GOSSIP_DEV_DEBUG, "%s: total:%d: ret:%zd:\n",
363 __func__,
364 total,
365 ret);
366
367 if (total < MAX_DEV_REQ_DOWNSIZE) {
Mike Marshallcf0c2772016-01-19 12:04:40 -0500368 gossip_err("%s: total:%d: must be at least:%u:\n",
Mike Marshallb3ae4752016-01-13 11:18:12 -0500369 __func__,
370 total,
Mike Marshallcf0c2772016-01-19 12:04:40 -0500371 (unsigned int) MAX_DEV_REQ_DOWNSIZE);
Al Viroed42fe02016-01-22 19:47:47 -0500372 return -EFAULT;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500373 }
374
375 n = copy_from_iter(&head, head_size, iter);
376 if (n < head_size) {
377 gossip_err("%s: failed to copy head.\n", __func__);
Al Viroed42fe02016-01-22 19:47:47 -0500378 return -EFAULT;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500379 }
380
381 if (head.version < ORANGEFS_MINIMUM_USERSPACE_VERSION) {
382 gossip_err("%s: userspace claims version"
383 "%d, minimum version required: %d.\n",
384 __func__,
385 head.version,
386 ORANGEFS_MINIMUM_USERSPACE_VERSION);
Al Viroed42fe02016-01-22 19:47:47 -0500387 return -EPROTO;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500388 }
389
390 if (head.magic != ORANGEFS_DEVREQ_MAGIC) {
391 gossip_err("Error: Device magic number does not match.\n");
Al Viroed42fe02016-01-22 19:47:47 -0500392 return -EPROTO;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500393 }
394
Martin Brandenburg482664d2016-08-12 12:02:31 -0400395 if (!orangefs_userspace_version) {
396 orangefs_userspace_version = head.version;
397 } else if (orangefs_userspace_version != head.version) {
Martin Brandenburgf2ee3b72016-08-09 15:59:26 -0400398 gossip_err("Error: userspace version changes\n");
399 return -EPROTO;
400 }
401
Mike Marshallca9f5182016-02-26 10:21:12 -0500402 /* remove the op from the in progress hash table */
Mike Marshallb3ae4752016-01-13 11:18:12 -0500403 op = orangefs_devreq_remove_op(head.tag);
404 if (!op) {
Mike Marshall1b992182017-02-09 14:38:50 -0500405 gossip_debug(GOSSIP_DEV_DEBUG,
406 "%s: No one's waiting for tag %llu\n",
407 __func__, llu(head.tag));
Al Viroed42fe02016-01-22 19:47:47 -0500408 return ret;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500409 }
410
Mike Marshallb3ae4752016-01-13 11:18:12 -0500411 n = copy_from_iter(&op->downcall, downcall_size, iter);
412 if (n != downcall_size) {
413 gossip_err("%s: failed to copy downcall.\n", __func__);
Al Viro5964c1b2016-02-18 18:53:41 -0500414 goto Efault;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500415 }
416
417 if (op->downcall.status)
418 goto wakeup;
419
420 /*
421 * We've successfully peeled off the head and the downcall.
422 * Something has gone awry if total doesn't equal the
423 * sum of head_size, downcall_size and trailer_size.
424 */
425 if ((head_size + downcall_size + op->downcall.trailer_size) != total) {
426 gossip_err("%s: funky write, head_size:%d"
427 ": downcall_size:%d: trailer_size:%lld"
428 ": total size:%d:\n",
429 __func__,
430 head_size,
431 downcall_size,
432 op->downcall.trailer_size,
433 total);
Al Viro5964c1b2016-02-18 18:53:41 -0500434 goto Efault;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500435 }
436
437 /* Only READDIR operations should have trailers. */
438 if ((op->downcall.type != ORANGEFS_VFS_OP_READDIR) &&
439 (op->downcall.trailer_size != 0)) {
440 gossip_err("%s: %x operation with trailer.",
441 __func__,
442 op->downcall.type);
Al Viro5964c1b2016-02-18 18:53:41 -0500443 goto Efault;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500444 }
445
446 /* READDIR operations should always have trailers. */
447 if ((op->downcall.type == ORANGEFS_VFS_OP_READDIR) &&
448 (op->downcall.trailer_size == 0)) {
449 gossip_err("%s: %x operation with no trailer.",
450 __func__,
451 op->downcall.type);
Al Viro5964c1b2016-02-18 18:53:41 -0500452 goto Efault;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500453 }
454
455 if (op->downcall.type != ORANGEFS_VFS_OP_READDIR)
456 goto wakeup;
457
458 op->downcall.trailer_buf =
459 vmalloc(op->downcall.trailer_size);
460 if (op->downcall.trailer_buf == NULL) {
461 gossip_err("%s: failed trailer vmalloc.\n",
462 __func__);
Al Viro5964c1b2016-02-18 18:53:41 -0500463 goto Enomem;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500464 }
465 memset(op->downcall.trailer_buf, 0, op->downcall.trailer_size);
466 n = copy_from_iter(op->downcall.trailer_buf,
467 op->downcall.trailer_size,
468 iter);
469 if (n != op->downcall.trailer_size) {
470 gossip_err("%s: failed to copy trailer.\n", __func__);
471 vfree(op->downcall.trailer_buf);
Al Viro5964c1b2016-02-18 18:53:41 -0500472 goto Efault;
Mike Marshallb3ae4752016-01-13 11:18:12 -0500473 }
474
475wakeup:
Al Viro2a9e5c22016-01-23 13:45:46 -0500476 /*
Mike Marshall9f08cfe92016-02-26 14:39:08 -0500477 * Return to vfs waitqueue, and back to service_operation
478 * through wait_for_matching_downcall.
Al Viro2a9e5c22016-01-23 13:45:46 -0500479 */
480 spin_lock(&op->lock);
Al Viro5964c1b2016-02-18 18:53:41 -0500481 if (unlikely(op_is_cancel(op))) {
Al Viro2a9e5c22016-01-23 13:45:46 -0500482 spin_unlock(&op->lock);
Al Viro78699e22016-02-11 23:07:19 -0500483 put_cancel(op);
Al Viro5964c1b2016-02-18 18:53:41 -0500484 } else if (unlikely(op_state_given_up(op))) {
485 spin_unlock(&op->lock);
Al Viro05a50a52016-02-18 18:59:44 -0500486 complete(&op->waitq);
Al Viro5964c1b2016-02-18 18:53:41 -0500487 } else {
488 set_op_state_serviced(op);
Mike Marshall9d9e7ba2016-03-03 13:46:48 -0500489 gossip_debug(GOSSIP_DEV_DEBUG,
490 "%s: op:%s: op_state:%d: process:%s:\n",
491 __func__,
492 get_opname_string(op),
493 op->op_state,
494 current->comm);
Al Viro5964c1b2016-02-18 18:53:41 -0500495 spin_unlock(&op->lock);
496 }
Mike Marshallb3ae4752016-01-13 11:18:12 -0500497 return ret;
Al Viroed42fe02016-01-22 19:47:47 -0500498
Al Viro5964c1b2016-02-18 18:53:41 -0500499Efault:
500 op->downcall.status = -(ORANGEFS_ERROR_BIT | 9);
501 ret = -EFAULT;
502 goto wakeup;
503
504Enomem:
505 op->downcall.status = -(ORANGEFS_ERROR_BIT | 8);
506 ret = -ENOMEM;
507 goto wakeup;
Mike Marshall5db11c22015-07-17 10:38:12 -0400508}
509
Mike Marshall5db11c22015-07-17 10:38:12 -0400510/*
511 * NOTE: gets called when the last reference to this device is dropped.
512 * Using the open_access_count variable, we enforce a reference count
513 * on this file so that it can be opened by only one process at a time.
514 * the devreq_mutex is used to make sure all i/o has completed
Yi Liu8bb8aef2015-11-24 15:12:14 -0500515 * before we call orangefs_bufmap_finalize, and similar such tricky
Mike Marshall5db11c22015-07-17 10:38:12 -0400516 * situations
517 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500518static int orangefs_devreq_release(struct inode *inode, struct file *file)
Mike Marshall5db11c22015-07-17 10:38:12 -0400519{
520 int unmounted = 0;
521
522 gossip_debug(GOSSIP_DEV_DEBUG,
523 "%s:pvfs2-client-core: exiting, closing device\n",
524 __func__);
525
526 mutex_lock(&devreq_mutex);
Al Viroea2c9c92016-02-13 21:01:21 -0500527 orangefs_bufmap_finalize();
Mike Marshall5db11c22015-07-17 10:38:12 -0400528
Al Virofee25ce2016-01-22 19:46:08 -0500529 open_access_count = -1;
Mike Marshall5db11c22015-07-17 10:38:12 -0400530
531 unmounted = mark_all_pending_mounts();
Yi Liu8bb8aef2015-11-24 15:12:14 -0500532 gossip_debug(GOSSIP_DEV_DEBUG, "ORANGEFS Device Close: Filesystem(s) %s\n",
Mike Marshall5db11c22015-07-17 10:38:12 -0400533 (unmounted ? "UNMOUNTED" : "MOUNTED"));
Mike Marshall5db11c22015-07-17 10:38:12 -0400534
Mike Marshall5db11c22015-07-17 10:38:12 -0400535 purge_waiting_ops();
Mike Marshall5db11c22015-07-17 10:38:12 -0400536 purge_inprogress_ops();
Al Viroea2c9c92016-02-13 21:01:21 -0500537
538 orangefs_bufmap_run_down();
539
Mike Marshall5db11c22015-07-17 10:38:12 -0400540 gossip_debug(GOSSIP_DEV_DEBUG,
541 "pvfs2-client-core: device close complete\n");
Al Virofee25ce2016-01-22 19:46:08 -0500542 open_access_count = 0;
Martin Brandenburg482664d2016-08-12 12:02:31 -0400543 orangefs_userspace_version = 0;
Al Virofee25ce2016-01-22 19:46:08 -0500544 mutex_unlock(&devreq_mutex);
Mike Marshall5db11c22015-07-17 10:38:12 -0400545 return 0;
546}
547
548int is_daemon_in_service(void)
549{
550 int in_service;
551
552 /*
553 * What this function does is checks if client-core is alive
554 * based on the access count we maintain on the device.
555 */
556 mutex_lock(&devreq_mutex);
557 in_service = open_access_count == 1 ? 0 : -EIO;
558 mutex_unlock(&devreq_mutex);
559 return in_service;
560}
561
Al Viro78699e22016-02-11 23:07:19 -0500562bool __is_daemon_in_service(void)
563{
564 return open_access_count == 1;
565}
566
Mike Marshall5db11c22015-07-17 10:38:12 -0400567static inline long check_ioctl_command(unsigned int command)
568{
569 /* Check for valid ioctl codes */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500570 if (_IOC_TYPE(command) != ORANGEFS_DEV_MAGIC) {
Mike Marshall5db11c22015-07-17 10:38:12 -0400571 gossip_err("device ioctl magic numbers don't match! Did you rebuild pvfs2-client-core/libpvfs2? [cmd %x, magic %x != %x]\n",
572 command,
573 _IOC_TYPE(command),
Yi Liu8bb8aef2015-11-24 15:12:14 -0500574 ORANGEFS_DEV_MAGIC);
Mike Marshall5db11c22015-07-17 10:38:12 -0400575 return -EINVAL;
576 }
577 /* and valid ioctl commands */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500578 if (_IOC_NR(command) >= ORANGEFS_DEV_MAXNR || _IOC_NR(command) <= 0) {
Mike Marshall5db11c22015-07-17 10:38:12 -0400579 gossip_err("Invalid ioctl command number [%d >= %d]\n",
Yi Liu8bb8aef2015-11-24 15:12:14 -0500580 _IOC_NR(command), ORANGEFS_DEV_MAXNR);
Mike Marshall5db11c22015-07-17 10:38:12 -0400581 return -ENOIOCTLCMD;
582 }
583 return 0;
584}
585
586static long dispatch_ioctl_command(unsigned int command, unsigned long arg)
587{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500588 static __s32 magic = ORANGEFS_DEVREQ_MAGIC;
Martin Brandenburga762ae62015-12-15 14:22:06 -0500589 static __s32 max_up_size = MAX_DEV_REQ_UPSIZE;
590 static __s32 max_down_size = MAX_DEV_REQ_DOWNSIZE;
Yi Liu8bb8aef2015-11-24 15:12:14 -0500591 struct ORANGEFS_dev_map_desc user_desc;
Mike Marshall5db11c22015-07-17 10:38:12 -0400592 int ret = 0;
Mike Marshall5db11c22015-07-17 10:38:12 -0400593 int upstream_kmod = 1;
Al Viro45996492016-03-25 19:56:34 -0400594 struct orangefs_sb_info_s *orangefs_sb;
Mike Marshall5db11c22015-07-17 10:38:12 -0400595
596 /* mtmoore: add locking here */
597
598 switch (command) {
Yi Liu8bb8aef2015-11-24 15:12:14 -0500599 case ORANGEFS_DEV_GET_MAGIC:
Mike Marshall5db11c22015-07-17 10:38:12 -0400600 return ((put_user(magic, (__s32 __user *) arg) == -EFAULT) ?
601 -EIO :
602 0);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500603 case ORANGEFS_DEV_GET_MAX_UPSIZE:
Mike Marshall5db11c22015-07-17 10:38:12 -0400604 return ((put_user(max_up_size,
605 (__s32 __user *) arg) == -EFAULT) ?
606 -EIO :
607 0);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500608 case ORANGEFS_DEV_GET_MAX_DOWNSIZE:
Mike Marshall5db11c22015-07-17 10:38:12 -0400609 return ((put_user(max_down_size,
610 (__s32 __user *) arg) == -EFAULT) ?
611 -EIO :
612 0);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500613 case ORANGEFS_DEV_MAP:
Mike Marshall5db11c22015-07-17 10:38:12 -0400614 ret = copy_from_user(&user_desc,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500615 (struct ORANGEFS_dev_map_desc __user *)
Mike Marshall5db11c22015-07-17 10:38:12 -0400616 arg,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500617 sizeof(struct ORANGEFS_dev_map_desc));
Al Viroea2c9c92016-02-13 21:01:21 -0500618 /* WTF -EIO and not -EFAULT? */
619 return ret ? -EIO : orangefs_bufmap_initialize(&user_desc);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500620 case ORANGEFS_DEV_REMOUNT_ALL:
Mike Marshall5db11c22015-07-17 10:38:12 -0400621 gossip_debug(GOSSIP_DEV_DEBUG,
Mike Marshall97f10022015-12-11 16:45:03 -0500622 "%s: got ORANGEFS_DEV_REMOUNT_ALL\n",
623 __func__);
Mike Marshall5db11c22015-07-17 10:38:12 -0400624
625 /*
Yi Liu8bb8aef2015-11-24 15:12:14 -0500626 * remount all mounted orangefs volumes to regain the lost
Mike Marshall5db11c22015-07-17 10:38:12 -0400627 * dynamic mount tables (if any) -- NOTE: this is done
628 * without keeping the superblock list locked due to the
Mike Marshalladcf34a2016-02-24 16:54:27 -0500629 * upcall/downcall waiting. also, the request mutex is
Mike Marshall5db11c22015-07-17 10:38:12 -0400630 * used to ensure that no operations will be serviced until
631 * all of the remounts are serviced (to avoid ops between
632 * mounts to fail)
633 */
Martin Brandenburg1d503612016-08-16 11:38:14 -0400634 ret = mutex_lock_interruptible(&orangefs_request_mutex);
Mike Marshall5db11c22015-07-17 10:38:12 -0400635 if (ret < 0)
636 return ret;
637 gossip_debug(GOSSIP_DEV_DEBUG,
Mike Marshall97f10022015-12-11 16:45:03 -0500638 "%s: priority remount in progress\n",
639 __func__);
Al Viro45996492016-03-25 19:56:34 -0400640 spin_lock(&orangefs_superblocks_lock);
641 list_for_each_entry(orangefs_sb, &orangefs_superblocks, list) {
642 /*
643 * We have to drop the spinlock, so entries can be
644 * removed. They can't be freed, though, so we just
645 * keep the forward pointers and zero the back ones -
646 * that way we can get to the rest of the list.
647 */
648 if (!orangefs_sb->list.prev)
649 continue;
650 gossip_debug(GOSSIP_DEV_DEBUG,
651 "%s: Remounting SB %p\n",
652 __func__,
653 orangefs_sb);
Mike Marshall5db11c22015-07-17 10:38:12 -0400654
Al Viro45996492016-03-25 19:56:34 -0400655 spin_unlock(&orangefs_superblocks_lock);
656 ret = orangefs_remount(orangefs_sb);
657 spin_lock(&orangefs_superblocks_lock);
658 if (ret) {
659 gossip_debug(GOSSIP_DEV_DEBUG,
660 "SB %p remount failed\n",
661 orangefs_sb);
662 break;
Mike Marshall5db11c22015-07-17 10:38:12 -0400663 }
664 }
Al Viro45996492016-03-25 19:56:34 -0400665 spin_unlock(&orangefs_superblocks_lock);
Mike Marshall5db11c22015-07-17 10:38:12 -0400666 gossip_debug(GOSSIP_DEV_DEBUG,
Mike Marshall97f10022015-12-11 16:45:03 -0500667 "%s: priority remount complete\n",
668 __func__);
Martin Brandenburg1d503612016-08-16 11:38:14 -0400669 mutex_unlock(&orangefs_request_mutex);
Mike Marshall5db11c22015-07-17 10:38:12 -0400670 return ret;
671
Yi Liu8bb8aef2015-11-24 15:12:14 -0500672 case ORANGEFS_DEV_UPSTREAM:
Mike Marshall5db11c22015-07-17 10:38:12 -0400673 ret = copy_to_user((void __user *)arg,
674 &upstream_kmod,
675 sizeof(upstream_kmod));
676
677 if (ret != 0)
678 return -EIO;
679 else
680 return ret;
681
Yi Liu8bb8aef2015-11-24 15:12:14 -0500682 case ORANGEFS_DEV_CLIENT_MASK:
Martin Brandenburg44f46412016-08-15 11:38:36 -0400683 return orangefs_debugfs_new_client_mask((void __user *)arg);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500684 case ORANGEFS_DEV_CLIENT_STRING:
Martin Brandenburg44f46412016-08-15 11:38:36 -0400685 return orangefs_debugfs_new_client_string((void __user *)arg);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500686 case ORANGEFS_DEV_DEBUG:
Martin Brandenburg44f46412016-08-15 11:38:36 -0400687 return orangefs_debugfs_new_debug((void __user *)arg);
Mike Marshall5db11c22015-07-17 10:38:12 -0400688 default:
689 return -ENOIOCTLCMD;
690 }
691 return -ENOIOCTLCMD;
692}
693
Yi Liu8bb8aef2015-11-24 15:12:14 -0500694static long orangefs_devreq_ioctl(struct file *file,
Mike Marshall5db11c22015-07-17 10:38:12 -0400695 unsigned int command, unsigned long arg)
696{
697 long ret;
698
699 /* Check for properly constructed commands */
700 ret = check_ioctl_command(command);
701 if (ret < 0)
702 return (int)ret;
703
704 return (int)dispatch_ioctl_command(command, arg);
705}
706
707#ifdef CONFIG_COMPAT /* CONFIG_COMPAT is in .config */
708
Yi Liu8bb8aef2015-11-24 15:12:14 -0500709/* Compat structure for the ORANGEFS_DEV_MAP ioctl */
710struct ORANGEFS_dev_map_desc32 {
Mike Marshall5db11c22015-07-17 10:38:12 -0400711 compat_uptr_t ptr;
712 __s32 total_size;
713 __s32 size;
714 __s32 count;
715};
716
717static unsigned long translate_dev_map26(unsigned long args, long *error)
718{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500719 struct ORANGEFS_dev_map_desc32 __user *p32 = (void __user *)args;
Mike Marshall5db11c22015-07-17 10:38:12 -0400720 /*
721 * Depending on the architecture, allocate some space on the
722 * user-call-stack based on our expected layout.
723 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500724 struct ORANGEFS_dev_map_desc __user *p =
Mike Marshall5db11c22015-07-17 10:38:12 -0400725 compat_alloc_user_space(sizeof(*p));
Mike Marshall84d02152015-07-28 13:27:51 -0400726 compat_uptr_t addr;
Mike Marshall5db11c22015-07-17 10:38:12 -0400727
728 *error = 0;
729 /* get the ptr from the 32 bit user-space */
730 if (get_user(addr, &p32->ptr))
731 goto err;
732 /* try to put that into a 64-bit layout */
733 if (put_user(compat_ptr(addr), &p->ptr))
734 goto err;
735 /* copy the remaining fields */
736 if (copy_in_user(&p->total_size, &p32->total_size, sizeof(__s32)))
737 goto err;
738 if (copy_in_user(&p->size, &p32->size, sizeof(__s32)))
739 goto err;
740 if (copy_in_user(&p->count, &p32->count, sizeof(__s32)))
741 goto err;
742 return (unsigned long)p;
743err:
744 *error = -EFAULT;
745 return 0;
746}
747
748/*
749 * 32 bit user-space apps' ioctl handlers when kernel modules
750 * is compiled as a 64 bit one
751 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500752static long orangefs_devreq_compat_ioctl(struct file *filp, unsigned int cmd,
Mike Marshall5db11c22015-07-17 10:38:12 -0400753 unsigned long args)
754{
755 long ret;
756 unsigned long arg = args;
757
758 /* Check for properly constructed commands */
759 ret = check_ioctl_command(cmd);
760 if (ret < 0)
761 return ret;
Yi Liu8bb8aef2015-11-24 15:12:14 -0500762 if (cmd == ORANGEFS_DEV_MAP) {
Mike Marshall5db11c22015-07-17 10:38:12 -0400763 /*
764 * convert the arguments to what we expect internally
765 * in kernel space
766 */
767 arg = translate_dev_map26(args, &ret);
768 if (ret < 0) {
769 gossip_err("Could not translate dev map\n");
770 return ret;
771 }
772 }
773 /* no other ioctl requires translation */
774 return dispatch_ioctl_command(cmd, arg);
775}
776
Mike Marshall2c590d52015-07-24 10:37:15 -0400777#endif /* CONFIG_COMPAT is in .config */
778
Mike Marshall5db11c22015-07-17 10:38:12 -0400779/* the assigned character device major number */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500780static int orangefs_dev_major;
Mike Marshall5db11c22015-07-17 10:38:12 -0400781
782/*
Yi Liu8bb8aef2015-11-24 15:12:14 -0500783 * Initialize orangefs device specific state:
Mike Marshall5db11c22015-07-17 10:38:12 -0400784 * Must be called at module load time only
785 */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500786int orangefs_dev_init(void)
Mike Marshall5db11c22015-07-17 10:38:12 -0400787{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500788 /* register orangefs-req device */
789 orangefs_dev_major = register_chrdev(0,
790 ORANGEFS_REQDEVICE_NAME,
791 &orangefs_devreq_file_operations);
792 if (orangefs_dev_major < 0) {
Mike Marshall5db11c22015-07-17 10:38:12 -0400793 gossip_debug(GOSSIP_DEV_DEBUG,
794 "Failed to register /dev/%s (error %d)\n",
Yi Liu8bb8aef2015-11-24 15:12:14 -0500795 ORANGEFS_REQDEVICE_NAME, orangefs_dev_major);
Yi Liu8bb8aef2015-11-24 15:12:14 -0500796 return orangefs_dev_major;
Mike Marshall5db11c22015-07-17 10:38:12 -0400797 }
798
799 gossip_debug(GOSSIP_DEV_DEBUG,
800 "*** /dev/%s character device registered ***\n",
Yi Liu8bb8aef2015-11-24 15:12:14 -0500801 ORANGEFS_REQDEVICE_NAME);
Mike Marshall5db11c22015-07-17 10:38:12 -0400802 gossip_debug(GOSSIP_DEV_DEBUG, "'mknod /dev/%s c %d 0'.\n",
Yi Liu8bb8aef2015-11-24 15:12:14 -0500803 ORANGEFS_REQDEVICE_NAME, orangefs_dev_major);
Mike Marshall5db11c22015-07-17 10:38:12 -0400804 return 0;
805}
806
Yi Liu8bb8aef2015-11-24 15:12:14 -0500807void orangefs_dev_cleanup(void)
Mike Marshall5db11c22015-07-17 10:38:12 -0400808{
Yi Liu8bb8aef2015-11-24 15:12:14 -0500809 unregister_chrdev(orangefs_dev_major, ORANGEFS_REQDEVICE_NAME);
Mike Marshall5db11c22015-07-17 10:38:12 -0400810 gossip_debug(GOSSIP_DEV_DEBUG,
811 "*** /dev/%s character device unregistered ***\n",
Yi Liu8bb8aef2015-11-24 15:12:14 -0500812 ORANGEFS_REQDEVICE_NAME);
Mike Marshall5db11c22015-07-17 10:38:12 -0400813}
814
Yi Liu8bb8aef2015-11-24 15:12:14 -0500815static unsigned int orangefs_devreq_poll(struct file *file,
Mike Marshall5db11c22015-07-17 10:38:12 -0400816 struct poll_table_struct *poll_table)
817{
818 int poll_revent_mask = 0;
819
Al Viro83595db2016-01-19 12:03:05 -0500820 poll_wait(file, &orangefs_request_list_waitq, poll_table);
Mike Marshall5db11c22015-07-17 10:38:12 -0400821
Al Viro83595db2016-01-19 12:03:05 -0500822 if (!list_empty(&orangefs_request_list))
823 poll_revent_mask |= POLL_IN;
Mike Marshall5db11c22015-07-17 10:38:12 -0400824 return poll_revent_mask;
825}
826
Yi Liu8bb8aef2015-11-24 15:12:14 -0500827const struct file_operations orangefs_devreq_file_operations = {
Mike Marshall5db11c22015-07-17 10:38:12 -0400828 .owner = THIS_MODULE,
Yi Liu8bb8aef2015-11-24 15:12:14 -0500829 .read = orangefs_devreq_read,
830 .write_iter = orangefs_devreq_write_iter,
831 .open = orangefs_devreq_open,
832 .release = orangefs_devreq_release,
833 .unlocked_ioctl = orangefs_devreq_ioctl,
Mike Marshall5db11c22015-07-17 10:38:12 -0400834
835#ifdef CONFIG_COMPAT /* CONFIG_COMPAT is in .config */
Yi Liu8bb8aef2015-11-24 15:12:14 -0500836 .compat_ioctl = orangefs_devreq_compat_ioctl,
Mike Marshall5db11c22015-07-17 10:38:12 -0400837#endif
Yi Liu8bb8aef2015-11-24 15:12:14 -0500838 .poll = orangefs_devreq_poll
Mike Marshall5db11c22015-07-17 10:38:12 -0400839};