Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 1 | /* |
| 2 | * Remote processor messaging transport (OMAP platform-specific bits) |
| 3 | * |
| 4 | * Copyright (C) 2011 Texas Instruments, Inc. |
| 5 | * Copyright (C) 2011 Google, Inc. |
| 6 | * |
| 7 | * Ohad Ben-Cohen <ohad@wizery.com> |
| 8 | * Brian Swetland <swetland@google.com> |
| 9 | * |
| 10 | * This software is licensed under the terms of the GNU General Public |
| 11 | * License version 2, as published by the Free Software Foundation, and |
| 12 | * may be copied, distributed, and modified under those terms. |
| 13 | * |
| 14 | * This program is distributed in the hope that it will be useful, |
| 15 | * but WITHOUT ANY WARRANTY; without even the implied warranty of |
| 16 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| 17 | * GNU General Public License for more details. |
| 18 | */ |
| 19 | |
| 20 | #include <linux/export.h> |
| 21 | #include <linux/remoteproc.h> |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 22 | #include <linux/virtio.h> |
| 23 | #include <linux/virtio_config.h> |
| 24 | #include <linux/virtio_ids.h> |
| 25 | #include <linux/virtio_ring.h> |
| 26 | #include <linux/err.h> |
| 27 | #include <linux/kref.h> |
| 28 | #include <linux/slab.h> |
| 29 | |
| 30 | #include "remoteproc_internal.h" |
| 31 | |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 32 | /* kick the remote processor, and let it know which virtqueue to poke at */ |
| 33 | static void rproc_virtio_notify(struct virtqueue *vq) |
| 34 | { |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 35 | struct rproc_vring *rvring = vq->priv; |
| 36 | struct rproc *rproc = rvring->rvdev->rproc; |
| 37 | int notifyid = rvring->notifyid; |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 38 | |
Ohad Ben-Cohen | b5ab5e2 | 2012-05-30 22:01:25 +0300 | [diff] [blame] | 39 | dev_dbg(&rproc->dev, "kicking vq index: %d\n", notifyid); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 40 | |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 41 | rproc->ops->kick(rproc, notifyid); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 42 | } |
| 43 | |
| 44 | /** |
| 45 | * rproc_vq_interrupt() - tell remoteproc that a virtqueue is interrupted |
| 46 | * @rproc: handle to the remote processor |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 47 | * @notifyid: index of the signalled virtqueue (unique per this @rproc) |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 48 | * |
| 49 | * This function should be called by the platform-specific rproc driver, |
| 50 | * when the remote processor signals that a specific virtqueue has pending |
| 51 | * messages available. |
| 52 | * |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 53 | * Returns IRQ_NONE if no message was found in the @notifyid virtqueue, |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 54 | * and otherwise returns IRQ_HANDLED. |
| 55 | */ |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 56 | irqreturn_t rproc_vq_interrupt(struct rproc *rproc, int notifyid) |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 57 | { |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 58 | struct rproc_vring *rvring; |
| 59 | |
Ohad Ben-Cohen | b5ab5e2 | 2012-05-30 22:01:25 +0300 | [diff] [blame] | 60 | dev_dbg(&rproc->dev, "vq index %d is interrupted\n", notifyid); |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 61 | |
| 62 | rvring = idr_find(&rproc->notifyids, notifyid); |
| 63 | if (!rvring || !rvring->vq) |
| 64 | return IRQ_NONE; |
| 65 | |
| 66 | return vring_interrupt(0, rvring->vq); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 67 | } |
| 68 | EXPORT_SYMBOL(rproc_vq_interrupt); |
| 69 | |
| 70 | static struct virtqueue *rp_find_vq(struct virtio_device *vdev, |
| 71 | unsigned id, |
| 72 | void (*callback)(struct virtqueue *vq), |
| 73 | const char *name) |
| 74 | { |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 75 | struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 76 | struct rproc *rproc = vdev_to_rproc(vdev); |
Ohad Ben-Cohen | b5ab5e2 | 2012-05-30 22:01:25 +0300 | [diff] [blame] | 77 | struct device *dev = &rproc->dev; |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 78 | struct rproc_vring *rvring; |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 79 | struct virtqueue *vq; |
| 80 | void *addr; |
Ohad Ben-Cohen | 6db20ea | 2012-05-17 14:23:59 +0300 | [diff] [blame] | 81 | int len, size, ret; |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 82 | |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 83 | /* we're temporarily limited to two virtqueues per rvdev */ |
| 84 | if (id >= ARRAY_SIZE(rvdev->vring)) |
| 85 | return ERR_PTR(-EINVAL); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 86 | |
Michael S. Tsirkin | 6457f12 | 2012-09-05 21:47:45 +0300 | [diff] [blame] | 87 | if (!name) |
| 88 | return NULL; |
| 89 | |
Ohad Ben-Cohen | 6db20ea | 2012-05-17 14:23:59 +0300 | [diff] [blame] | 90 | ret = rproc_alloc_vring(rvdev, id); |
| 91 | if (ret) |
| 92 | return ERR_PTR(ret); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 93 | |
Ohad Ben-Cohen | 6db20ea | 2012-05-17 14:23:59 +0300 | [diff] [blame] | 94 | rvring = &rvdev->vring[id]; |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 95 | addr = rvring->va; |
| 96 | len = rvring->len; |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 97 | |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 98 | /* zero vring */ |
| 99 | size = vring_size(len, rvring->align); |
| 100 | memset(addr, 0, size); |
| 101 | |
Ohad Ben-Cohen | b5ab5e2 | 2012-05-30 22:01:25 +0300 | [diff] [blame] | 102 | dev_dbg(dev, "vring%d: va %p qsz %d notifyid %d\n", |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 103 | id, addr, len, rvring->notifyid); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 104 | |
Ohad Ben-Cohen | dd6da1c | 2012-01-12 09:26:57 +0200 | [diff] [blame] | 105 | /* |
| 106 | * Create the new vq, and tell virtio we're not interested in |
| 107 | * the 'weak' smp barriers, since we're talking with a real device. |
| 108 | */ |
Jason Wang | 17bb6d4 | 2012-08-28 13:54:13 +0200 | [diff] [blame] | 109 | vq = vring_new_virtqueue(id, len, rvring->align, vdev, false, addr, |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 110 | rproc_virtio_notify, callback, name); |
| 111 | if (!vq) { |
Ohad Ben-Cohen | b5ab5e2 | 2012-05-30 22:01:25 +0300 | [diff] [blame] | 112 | dev_err(dev, "vring_new_virtqueue %s failed\n", name); |
Ohad Ben-Cohen | 6db20ea | 2012-05-17 14:23:59 +0300 | [diff] [blame] | 113 | rproc_free_vring(rvring); |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 114 | return ERR_PTR(-ENOMEM); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 115 | } |
| 116 | |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 117 | rvring->vq = vq; |
| 118 | vq->priv = rvring; |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 119 | |
| 120 | return vq; |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 121 | } |
| 122 | |
Ohad Ben-Cohen | dab55bb | 2012-11-12 11:13:51 +0200 | [diff] [blame] | 123 | static void __rproc_virtio_del_vqs(struct virtio_device *vdev) |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 124 | { |
| 125 | struct virtqueue *vq, *n; |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 126 | struct rproc_vring *rvring; |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 127 | |
| 128 | list_for_each_entry_safe(vq, n, &vdev->vqs, list) { |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 129 | rvring = vq->priv; |
| 130 | rvring->vq = NULL; |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 131 | vring_del_virtqueue(vq); |
Ohad Ben-Cohen | 6db20ea | 2012-05-17 14:23:59 +0300 | [diff] [blame] | 132 | rproc_free_vring(rvring); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 133 | } |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 134 | } |
| 135 | |
Ohad Ben-Cohen | dab55bb | 2012-11-12 11:13:51 +0200 | [diff] [blame] | 136 | static void rproc_virtio_del_vqs(struct virtio_device *vdev) |
| 137 | { |
| 138 | struct rproc *rproc = vdev_to_rproc(vdev); |
| 139 | |
| 140 | /* power down the remote processor before deleting vqs */ |
| 141 | rproc_shutdown(rproc); |
| 142 | |
| 143 | __rproc_virtio_del_vqs(vdev); |
| 144 | } |
| 145 | |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 146 | static int rproc_virtio_find_vqs(struct virtio_device *vdev, unsigned nvqs, |
| 147 | struct virtqueue *vqs[], |
| 148 | vq_callback_t *callbacks[], |
| 149 | const char *names[]) |
| 150 | { |
| 151 | struct rproc *rproc = vdev_to_rproc(vdev); |
| 152 | int i, ret; |
| 153 | |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 154 | for (i = 0; i < nvqs; ++i) { |
| 155 | vqs[i] = rp_find_vq(vdev, i, callbacks[i], names[i]); |
| 156 | if (IS_ERR(vqs[i])) { |
| 157 | ret = PTR_ERR(vqs[i]); |
| 158 | goto error; |
| 159 | } |
| 160 | } |
| 161 | |
Ohad Ben-Cohen | 41a6ee0 | 2012-02-13 09:38:23 +0200 | [diff] [blame] | 162 | /* now that the vqs are all set, boot the remote processor */ |
| 163 | ret = rproc_boot(rproc); |
| 164 | if (ret) { |
Ohad Ben-Cohen | b5ab5e2 | 2012-05-30 22:01:25 +0300 | [diff] [blame] | 165 | dev_err(&rproc->dev, "rproc_boot() failed %d\n", ret); |
Ohad Ben-Cohen | 41a6ee0 | 2012-02-13 09:38:23 +0200 | [diff] [blame] | 166 | goto error; |
| 167 | } |
| 168 | |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 169 | return 0; |
| 170 | |
| 171 | error: |
Ohad Ben-Cohen | dab55bb | 2012-11-12 11:13:51 +0200 | [diff] [blame] | 172 | __rproc_virtio_del_vqs(vdev); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 173 | return ret; |
| 174 | } |
| 175 | |
| 176 | /* |
| 177 | * We don't support yet real virtio status semantics. |
| 178 | * |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 179 | * The plan is to provide this via the VDEV resource entry |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 180 | * which is part of the firmware: this way the remote processor |
| 181 | * will be able to access the status values as set by us. |
| 182 | */ |
| 183 | static u8 rproc_virtio_get_status(struct virtio_device *vdev) |
| 184 | { |
| 185 | return 0; |
| 186 | } |
| 187 | |
| 188 | static void rproc_virtio_set_status(struct virtio_device *vdev, u8 status) |
| 189 | { |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 190 | dev_dbg(&vdev->dev, "status: %d\n", status); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 191 | } |
| 192 | |
| 193 | static void rproc_virtio_reset(struct virtio_device *vdev) |
| 194 | { |
| 195 | dev_dbg(&vdev->dev, "reset !\n"); |
| 196 | } |
| 197 | |
| 198 | /* provide the vdev features as retrieved from the firmware */ |
| 199 | static u32 rproc_virtio_get_features(struct virtio_device *vdev) |
| 200 | { |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 201 | struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 202 | |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 203 | return rvdev->dfeatures; |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 204 | } |
| 205 | |
| 206 | static void rproc_virtio_finalize_features(struct virtio_device *vdev) |
| 207 | { |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 208 | struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 209 | |
| 210 | /* Give virtio_ring a chance to accept features */ |
| 211 | vring_transport_features(vdev); |
| 212 | |
| 213 | /* |
| 214 | * Remember the finalized features of our vdev, and provide it |
| 215 | * to the remote processor once it is powered on. |
| 216 | * |
| 217 | * Similarly to the status field, we don't expose yet the negotiated |
| 218 | * features to the remote processors at this point. This will be |
| 219 | * fixed as part of a small resource table overhaul and then an |
| 220 | * extension of the virtio resource entries. |
| 221 | */ |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 222 | rvdev->gfeatures = vdev->features[0]; |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 223 | } |
| 224 | |
Stephen Hemminger | 9350393 | 2013-02-10 15:57:38 +1030 | [diff] [blame] | 225 | static const struct virtio_config_ops rproc_virtio_config_ops = { |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 226 | .get_features = rproc_virtio_get_features, |
| 227 | .finalize_features = rproc_virtio_finalize_features, |
| 228 | .find_vqs = rproc_virtio_find_vqs, |
| 229 | .del_vqs = rproc_virtio_del_vqs, |
| 230 | .reset = rproc_virtio_reset, |
| 231 | .set_status = rproc_virtio_set_status, |
| 232 | .get_status = rproc_virtio_get_status, |
| 233 | }; |
| 234 | |
| 235 | /* |
| 236 | * This function is called whenever vdev is released, and is responsible |
Ohad Ben-Cohen | 7183a2a | 2012-05-30 22:02:24 +0300 | [diff] [blame] | 237 | * to decrement the remote processor's refcount which was taken when vdev was |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 238 | * added. |
| 239 | * |
| 240 | * Never call this function directly; it will be called by the driver |
| 241 | * core when needed. |
| 242 | */ |
| 243 | static void rproc_vdev_release(struct device *dev) |
| 244 | { |
| 245 | struct virtio_device *vdev = dev_to_virtio(dev); |
Ohad Ben-Cohen | 6db20ea | 2012-05-17 14:23:59 +0300 | [diff] [blame] | 246 | struct rproc_vdev *rvdev = vdev_to_rvdev(vdev); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 247 | struct rproc *rproc = vdev_to_rproc(vdev); |
| 248 | |
Ohad Ben-Cohen | 6db20ea | 2012-05-17 14:23:59 +0300 | [diff] [blame] | 249 | list_del(&rvdev->node); |
| 250 | kfree(rvdev); |
| 251 | |
Ohad Ben-Cohen | 7183a2a | 2012-05-30 22:02:24 +0300 | [diff] [blame] | 252 | put_device(&rproc->dev); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 253 | } |
| 254 | |
| 255 | /** |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 256 | * rproc_add_virtio_dev() - register an rproc-induced virtio device |
| 257 | * @rvdev: the remote vdev |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 258 | * |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 259 | * This function registers a virtio device. This vdev's partent is |
| 260 | * the rproc device. |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 261 | * |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 262 | * Returns 0 on success or an appropriate error value otherwise. |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 263 | */ |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 264 | int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id) |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 265 | { |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 266 | struct rproc *rproc = rvdev->rproc; |
Ohad Ben-Cohen | b5ab5e2 | 2012-05-30 22:01:25 +0300 | [diff] [blame] | 267 | struct device *dev = &rproc->dev; |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 268 | struct virtio_device *vdev = &rvdev->vdev; |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 269 | int ret; |
| 270 | |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 271 | vdev->id.device = id, |
| 272 | vdev->config = &rproc_virtio_config_ops, |
| 273 | vdev->dev.parent = dev; |
| 274 | vdev->dev.release = rproc_vdev_release; |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 275 | |
| 276 | /* |
| 277 | * We're indirectly making a non-temporary copy of the rproc pointer |
| 278 | * here, because drivers probed with this vdev will indirectly |
| 279 | * access the wrapping rproc. |
| 280 | * |
| 281 | * Therefore we must increment the rproc refcount here, and decrement |
| 282 | * it _only_ when the vdev is released. |
| 283 | */ |
Ohad Ben-Cohen | 7183a2a | 2012-05-30 22:02:24 +0300 | [diff] [blame] | 284 | get_device(&rproc->dev); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 285 | |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 286 | ret = register_virtio_device(vdev); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 287 | if (ret) { |
Ohad Ben-Cohen | 7183a2a | 2012-05-30 22:02:24 +0300 | [diff] [blame] | 288 | put_device(&rproc->dev); |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 289 | dev_err(dev, "failed to register vdev: %d\n", ret); |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 290 | goto out; |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 291 | } |
| 292 | |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 293 | dev_info(dev, "registered %s (type %d)\n", dev_name(&vdev->dev), id); |
| 294 | |
| 295 | out: |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 296 | return ret; |
| 297 | } |
| 298 | |
| 299 | /** |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 300 | * rproc_remove_virtio_dev() - remove an rproc-induced virtio device |
| 301 | * @rvdev: the remote vdev |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 302 | * |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 303 | * This function unregisters an existing virtio device. |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 304 | */ |
Ohad Ben-Cohen | 7a18694 | 2012-02-13 22:30:39 +0100 | [diff] [blame] | 305 | void rproc_remove_virtio_dev(struct rproc_vdev *rvdev) |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 306 | { |
Ohad Ben-Cohen | ac8954a | 2011-10-20 18:15:13 +0200 | [diff] [blame] | 307 | unregister_virtio_device(&rvdev->vdev); |
| 308 | } |