blob: 784724aa4f349f8f3389e6895e39fea037159663 [file] [log] [blame]
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -08001HOWTO do Linux kernel development
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -03002=================================
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -08003
4This is the be-all, end-all document on this topic. It contains
5instructions on how to become a Linux kernel developer and how to learn
6to work with the Linux kernel development community. It tries to not
7contain anything related to the technical aspects of kernel programming,
8but will help point you in the right direction for that.
9
10If anything in this document becomes out of date, please send in patches
11to the maintainer of this file, who is listed at the bottom of the
12document.
13
14
15Introduction
16------------
17
18So, you want to learn how to become a Linux kernel developer? Or you
19have been told by your manager, "Go write a Linux driver for this
20device." This document's goal is to teach you everything you need to
21know to achieve this by describing the process you need to go through,
22and hints on how to work with the community. It will also try to
23explain some of the reasons why the community works like it does.
24
25The kernel is written mostly in C, with some architecture-dependent
26parts written in assembly. A good understanding of C is required for
27kernel development. Assembly (any architecture) is not required unless
28you plan to do low-level development for that architecture. Though they
29are not a good substitute for a solid C education and/or years of
30experience, the following books are good for, if anything, reference:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -030031
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080032 - "The C Programming Language" by Kernighan and Ritchie [Prentice Hall]
33 - "Practical C Programming" by Steve Oualline [O'Reilly]
Robert P. J. Day4de0ca82007-01-17 04:54:07 -050034 - "C: A Reference Manual" by Harbison and Steele [Prentice Hall]
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080035
36The kernel is written using GNU C and the GNU toolchain. While it
37adheres to the ISO C89 standard, it uses a number of extensions that are
38not featured in the standard. The kernel is a freestanding C
39environment, with no reliance on the standard C library, so some
40portions of the C standard are not supported. Arbitrary long long
41divisions and floating point are not allowed. It can sometimes be
42difficult to understand the assumptions the kernel has on the toolchain
43and the extensions that it uses, and unfortunately there is no
44definitive reference for them. Please check the gcc info pages (`info
45gcc`) for some information on them.
46
47Please remember that you are trying to learn how to work with the
48existing development community. It is a diverse group of people, with
49high standards for coding, style and procedure. These standards have
50been created over time based on what they have found to work best for
51such a large and geographically dispersed team. Try to learn as much as
52possible about these standards ahead of time, as they are well
53documented; do not expect people to adapt to you or your company's way
54of doing things.
55
56
57Legal Issues
58------------
59
60The Linux kernel source code is released under the GPL. Please see the
61file, COPYING, in the main directory of the source tree, for details on
62the license. If you have further questions about the license, please
63contact a lawyer, and do not ask on the Linux kernel mailing list. The
64people on the mailing lists are not lawyers, and you should not rely on
65their statements on legal matters.
66
67For common questions and answers about the GPL, please see:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -030068
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080069 http://www.gnu.org/licenses/gpl-faq.html
70
71
72Documentation
Philippe Loctauxce655082016-03-07 02:36:18 +010073-------------
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080074
75The Linux kernel source tree has a large range of documents that are
76invaluable for learning how to interact with the kernel community. When
77new features are added to the kernel, it is recommended that new
78documentation files are also added which explain how to use the feature.
79When a kernel change causes the interface that the kernel exposes to
80userspace to change, it is recommended that you send the information or
81a patch to the manual pages explaining the change to the manual pages
Michael Kerrisk09b05f52008-10-03 15:23:45 -070082maintainer at mtk.manpages@gmail.com, and CC the list
83linux-api@vger.kernel.org.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080084
85Here is a list of files that are in the kernel source tree that are
86required reading:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -030087
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080088 README
89 This file gives a short background on the Linux kernel and describes
90 what is necessary to do to configure and build the kernel. People
91 who are new to the kernel should start here.
92
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -030093 :ref:`Documentation/Changes <changes>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080094 This file gives a list of the minimum levels of various software
95 packages that are necessary to build and run the kernel
96 successfully.
97
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -030098 :ref:`Documentation/CodingStyle <codingstyle>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -080099 This describes the Linux kernel coding style, and some of the
100 rationale behind it. All new code is expected to follow the
101 guidelines in this document. Most maintainers will only accept
102 patches if these rules are followed, and many people will only
103 review code if it is in the proper style.
104
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300105 :ref:`Documentation/SubmittingPatches <submittingpatches>` and :ref:`Documentation/SubmittingDrivers <submittingdrivers>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800106 These files describe in explicit detail how to successfully create
107 and send a patch, including (but not limited to):
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300108
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800109 - Email contents
110 - Email format
111 - Who to send it to
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300112
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800113 Following these rules will not guarantee success (as all patches are
114 subject to scrutiny for content and style), but not following them
115 will almost always prevent it.
116
117 Other excellent descriptions of how to create patches properly are:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300118
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800119 "The Perfect Patch"
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300120
SeongJae Park937d9f52013-12-06 18:04:42 +0900121 http://www.ozlabs.org/~akpm/stuff/tpp.txt
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300122
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800123 "Linux kernel patch submission format"
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300124
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800125 http://linux.yyz.us/patch-format.html
126
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300127 :ref:`Documentation/stable_api_nonsense.txt <stable_api_nonsense>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800128 This file describes the rationale behind the conscious decision to
129 not have a stable API within the kernel, including things like:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300130
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800131 - Subsystem shim-layers (for compatibility?)
132 - Driver portability between Operating Systems.
133 - Mitigating rapid change within the kernel source tree (or
134 preventing rapid change)
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300135
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800136 This document is crucial for understanding the Linux development
137 philosophy and is very important for people moving to Linux from
138 development on other Operating Systems.
139
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300140 :ref:`Documentation/SecurityBugs <securitybugs>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800141 If you feel you have found a security problem in the Linux kernel,
142 please follow the steps in this document to help notify the kernel
143 developers, and help solve the issue.
144
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300145 :ref:`Documentation/ManagementStyle <managementstyle>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800146 This document describes how Linux kernel maintainers operate and the
147 shared ethos behind their methodologies. This is important reading
148 for anyone new to kernel development (or anyone simply curious about
149 it), as it resolves a lot of common misconceptions and confusion
150 about the unique behavior of kernel maintainers.
151
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300152 :ref:`Documentation/stable_kernel_rules.txt <stable_kernel_rules>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800153 This file describes the rules on how the stable kernel releases
154 happen, and what to do if you want to get a change into one of these
155 releases.
156
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300157 :ref:`Documentation/kernel-docs.txt <kernel_docs>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800158 A list of external documentation that pertains to kernel
159 development. Please consult this list if you do not find what you
160 are looking for within the in-kernel documentation.
161
Mauro Carvalho Chehab609d99a2016-09-19 08:07:56 -0300162 :ref:`Documentation/applying-patches.txt <applying_patches>`
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800163 A good introduction describing exactly what a patch is and how to
164 apply it to the different development branches of the kernel.
165
166The kernel also has a large number of documents that can be
Mauro Carvalho Chehab43fb67a2016-09-19 08:07:57 -0300167automatically generated from the source code itself or from
168ReStructuredText markups (ReST), like this one. This includes a
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800169full description of the in-kernel API, and rules on how to handle
Mauro Carvalho Chehab43fb67a2016-09-19 08:07:57 -0300170locking properly.
171
172All such documents can be generated as PDF or HTML by running:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300173
174::
175
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800176 make pdfdocs
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800177 make htmldocs
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300178
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800179respectively from the main kernel source directory.
180
Mauro Carvalho Chehab43fb67a2016-09-19 08:07:57 -0300181The documents that uses ReST markup will be generated at Documentation/output.
182They can also be generated on LaTeX and ePub formats with:
183
184::
185
186 make latexdocs
187 make epubdocs
188
189Currently, there are some documents written on DocBook that are in
190the process of conversion to ReST. Such documents will be created in the
191Documentation/DocBook/ directory and can be generated also as
192Postscript or man pages by running:
193
194::
195
196 make psdocs
197 make mandocs
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800198
199Becoming A Kernel Developer
200---------------------------
201
202If you do not know anything about Linux kernel development, you should
203look at the Linux KernelNewbies project:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300204
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800205 http://kernelnewbies.org
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300206
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800207It consists of a helpful mailing list where you can ask almost any type
208of basic kernel development question (make sure to search the archives
209first, before asking something that has already been answered in the
210past.) It also has an IRC channel that you can use to ask questions in
211real-time, and a lot of helpful documentation that is useful for
212learning about Linux kernel development.
213
214The website has basic information about code organization, subsystems,
215and current projects (both in-tree and out-of-tree). It also describes
216some basic logistical information, like how to compile a kernel and
217apply a patch.
218
219If you do not know where you want to start, but you want to look for
220some task to start doing to join into the kernel development community,
221go to the Linux Kernel Janitor's project:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300222
Peter Loeffler5645a712016-01-30 21:53:53 +0100223 http://kernelnewbies.org/KernelJanitors
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300224
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800225It is a great place to start. It describes a list of relatively simple
226problems that need to be cleaned up and fixed within the Linux kernel
227source tree. Working with the developers in charge of this project, you
228will learn the basics of getting your patch into the Linux kernel tree,
229and possibly be pointed in the direction of what to go work on next, if
230you do not already have an idea.
231
232If you already have a chunk of code that you want to put into the kernel
233tree, but need some help getting it in the proper form, the
234kernel-mentors project was created to help you out with this. It is a
235mailing list, and can be found at:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300236
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800237 http://selenic.com/mailman/listinfo/kernel-mentors
238
239Before making any actual modifications to the Linux kernel code, it is
240imperative to understand how the code in question works. For this
241purpose, nothing is better than reading through it directly (most tricky
242bits are commented well), perhaps even with the help of specialized
243tools. One such tool that is particularly recommended is the Linux
244Cross-Reference project, which is able to present source code in a
245self-referential, indexed webpage format. An excellent up-to-date
246repository of the kernel code may be found at:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300247
Doug Smythies1d125542015-11-22 15:42:48 -0800248 http://lxr.free-electrons.com/
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800249
250
251The development process
252-----------------------
253
254Linux kernel development process currently consists of a few different
255main kernel "branches" and lots of different subsystem-specific kernel
256branches. These different branches are:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300257
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500258 - main 4.x kernel tree
259 - 4.x.y -stable kernel tree
260 - 4.x -git kernel patches
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800261 - subsystem specific kernel trees and patches
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500262 - the 4.x -next kernel tree for integration tests
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800263
Mario Carrilloe4144fe2015-08-24 09:33:09 -05002644.x kernel tree
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800265-----------------
Mario Carrilloe4144fe2015-08-24 09:33:09 -05002664.x kernels are maintained by Linus Torvalds, and can be found on
267kernel.org in the pub/linux/kernel/v4.x/ directory. Its development
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800268process is as follows:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300269
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800270 - As soon as a new kernel is released a two weeks window is open,
271 during this period of time maintainers can submit big diffs to
272 Linus, usually the patches that have already been included in the
Stefan Richterc607cf02010-01-15 13:23:51 +0100273 -next kernel for a few weeks. The preferred way to submit big changes
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800274 is using git (the kernel's source management tool, more information
Randy Dunlape234ebf2010-04-06 16:16:59 -0700275 can be found at http://git-scm.com/) but plain patches are also just
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800276 fine.
277 - After two weeks a -rc1 kernel is released it is now possible to push
278 only patches that do not include new features that could affect the
279 stability of the whole kernel. Please note that a whole new driver
280 (or filesystem) might be accepted after -rc1 because there is no
281 risk of causing regressions with such a change as long as the change
282 is self-contained and does not affect areas outside of the code that
283 is being added. git can be used to send patches to Linus after -rc1
284 is released, but the patches need to also be sent to a public
285 mailing list for review.
286 - A new -rc is released whenever Linus deems the current git tree to
287 be in a reasonably sane state adequate for testing. The goal is to
288 release a new -rc kernel every week.
289 - Process continues until the kernel is considered "ready", the
290 process should last around 6 weeks.
291
292It is worth mentioning what Andrew Morton wrote on the linux-kernel
293mailing list about kernel releases:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300294
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300295 *"Nobody knows when a kernel will be released, because it's
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800296 released according to perceived bug status, not according to a
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300297 preconceived timeline."*
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800298
Mario Carrilloe4144fe2015-08-24 09:33:09 -05002994.x.y -stable kernel tree
Philippe Loctauxce655082016-03-07 02:36:18 +0100300-------------------------
Kees Cook591bfc62012-04-18 23:16:45 -0700301Kernels with 3-part versions are -stable kernels. They contain
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800302relatively small and critical fixes for security problems or significant
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500303regressions discovered in a given 4.x kernel.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800304
305This is the recommended branch for users who want the most recent stable
306kernel and are not interested in helping test development/experimental
307versions.
308
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500309If no 4.x.y kernel is available, then the highest numbered 4.x
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800310kernel is the current stable kernel.
311
Mario Carrilloe4144fe2015-08-24 09:33:09 -05003124.x.y are maintained by the "stable" team <stable@vger.kernel.org>, and
Joe Perches2eb7f202011-12-09 14:12:00 -0800313are released as needs dictate. The normal release period is approximately
Jonathan Corbet0fe8a3c2008-04-25 11:23:56 -0600314two weeks, but it can be longer if there are no pressing problems. A
315security-related problem, instead, can cause a release to happen almost
316instantly.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800317
318The file Documentation/stable_kernel_rules.txt in the kernel tree
319documents what kinds of changes are acceptable for the -stable tree, and
320how the release process works.
321
Mario Carrilloe4144fe2015-08-24 09:33:09 -05003224.x -git patches
Philippe Loctauxce655082016-03-07 02:36:18 +0100323----------------
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800324These are daily snapshots of Linus' kernel tree which are managed in a
325git repository (hence the name.) These patches are usually released
326daily and represent the current state of Linus' tree. They are more
327experimental than -rc kernels since they are generated automatically
328without even a cursory glance to see if they are sane.
329
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800330Subsystem Specific kernel trees and patches
331-------------------------------------------
Stefan Richterc607cf02010-01-15 13:23:51 +0100332The maintainers of the various kernel subsystems --- and also many
333kernel subsystem developers --- expose their current state of
334development in source repositories. That way, others can see what is
335happening in the different areas of the kernel. In areas where
336development is rapid, a developer may be asked to base his submissions
337onto such a subsystem kernel tree so that conflicts between the
338submission and other already ongoing work are avoided.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800339
Stefan Richterc607cf02010-01-15 13:23:51 +0100340Most of these repositories are git trees, but there are also other SCMs
341in use, or patch queues being published as quilt series. Addresses of
342these subsystem repositories are listed in the MAINTAINERS file. Many
343of them can be browsed at http://git.kernel.org/.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800344
Stefan Richterc607cf02010-01-15 13:23:51 +0100345Before a proposed patch is committed to such a subsystem tree, it is
346subject to review which primarily happens on mailing lists (see the
347respective section below). For several kernel subsystems, this review
348process is tracked with the tool patchwork. Patchwork offers a web
349interface which shows patch postings, any comments on a patch or
350revisions to it, and maintainers can mark patches as under review,
351accepted, or rejected. Most of these patchwork sites are listed at
Justin P. Mattock0ea6e612010-07-23 20:51:24 -0700352http://patchwork.kernel.org/.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800353
Mario Carrilloe4144fe2015-08-24 09:33:09 -05003544.x -next kernel tree for integration tests
Philippe Loctauxce655082016-03-07 02:36:18 +0100355-------------------------------------------
Mario Carrilloe4144fe2015-08-24 09:33:09 -0500356Before updates from subsystem trees are merged into the mainline 4.x
Stefan Richterc607cf02010-01-15 13:23:51 +0100357tree, they need to be integration-tested. For this purpose, a special
358testing repository exists into which virtually all subsystem trees are
359pulled on an almost daily basis:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300360
Kees Cook591bfc62012-04-18 23:16:45 -0700361 http://git.kernel.org/?p=linux/kernel/git/next/linux-next.git
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800362
Stefan Richterc607cf02010-01-15 13:23:51 +0100363This way, the -next kernel gives a summary outlook onto what will be
364expected to go into the mainline kernel at the next merge period.
365Adventurous testers are very welcome to runtime-test the -next kernel.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800366
Stefan Richter8a465c32007-06-27 14:10:01 -0700367
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800368Bug Reporting
369-------------
370
371bugzilla.kernel.org is where the Linux kernel developers track kernel
372bugs. Users are encouraged to report all bugs that they find in this
373tool. For details on how to use the kernel bugzilla, please see:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300374
Jiri Pirko0302c012008-07-13 12:13:59 -0700375 http://bugzilla.kernel.org/page.cgi?id=faq.html
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800376
377The file REPORTING-BUGS in the main kernel source directory has a good
378template for how to report a possible kernel bug, and details what kind
379of information is needed by the kernel developers to help track down the
380problem.
381
382
Diego Calleja3f271002006-09-30 23:27:49 -0700383Managing bug reports
384--------------------
385
386One of the best ways to put into practice your hacking skills is by fixing
387bugs reported by other people. Not only you will help to make the kernel
388more stable, you'll learn to fix real world problems and you will improve
389your skills, and other developers will be aware of your presence. Fixing
Qi Yong4db29c12007-06-12 13:06:49 +0800390bugs is one of the best ways to get merits among other developers, because
Diego Calleja3f271002006-09-30 23:27:49 -0700391not many people like wasting time fixing other people's bugs.
392
393To work in the already reported bug reports, go to http://bugzilla.kernel.org.
394If you want to be advised of the future bug reports, you can subscribe to the
395bugme-new mailing list (only new bug reports are mailed here) or to the
396bugme-janitor mailing list (every change in the bugzilla is mailed here)
397
Jonathan Corbet0fe8a3c2008-04-25 11:23:56 -0600398 http://lists.linux-foundation.org/mailman/listinfo/bugme-new
399 http://lists.linux-foundation.org/mailman/listinfo/bugme-janitors
Diego Calleja3f271002006-09-30 23:27:49 -0700400
401
402
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800403Mailing lists
404-------------
405
406As some of the above documents describe, the majority of the core kernel
407developers participate on the Linux Kernel Mailing list. Details on how
408to subscribe and unsubscribe from the list can be found at:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300409
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800410 http://vger.kernel.org/vger-lists.html#linux-kernel
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300411
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800412There are archives of the mailing list on the web in many different
413places. Use a search engine to find these archives. For example:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300414
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800415 http://dir.gmane.org/gmane.linux.kernel
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300416
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800417It is highly recommended that you search the archives about the topic
418you want to bring up, before you post it to the list. A lot of things
419already discussed in detail are only recorded at the mailing list
420archives.
421
422Most of the individual kernel subsystems also have their own separate
423mailing list where they do their development efforts. See the
424MAINTAINERS file for a list of what these lists are for the different
425groups.
426
427Many of the lists are hosted on kernel.org. Information on them can be
428found at:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300429
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800430 http://vger.kernel.org/vger-lists.html
431
432Please remember to follow good behavioral habits when using the lists.
433Though a bit cheesy, the following URL has some simple guidelines for
434interacting with the list (or any list):
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300435
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800436 http://www.albion.com/netiquette/
437
438If multiple people respond to your mail, the CC: list of recipients may
439get pretty large. Don't remove anybody from the CC: list without a good
440reason, or don't reply only to the list address. Get used to receiving the
441mail twice, one from the sender and the one from the list, and don't try
442to tune that by adding fancy mail-headers, people will not like it.
443
444Remember to keep the context and the attribution of your replies intact,
445keep the "John Kernelhacker wrote ...:" lines at the top of your reply, and
446add your statements between the individual quoted sections instead of
447writing at the top of the mail.
448
449If you add patches to your mail, make sure they are plain readable text
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300450as stated in Documentation/SubmittingPatches.
451Kernel developers don't want to deal with
452attachments or compressed patches; they may want to comment on
453individual lines of your patch, which works only that way. Make sure you
454use a mail program that does not mangle spaces and tab characters. A
455good first test is to send the mail to yourself and try to apply your
456own patch by yourself. If that doesn't work, get your mail program fixed
457or change it until it works.
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800458
459Above all, please remember to show respect to other subscribers.
460
461
462Working with the community
463--------------------------
464
465The goal of the kernel community is to provide the best possible kernel
466there is. When you submit a patch for acceptance, it will be reviewed
467on its technical merits and those alone. So, what should you be
468expecting?
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300469
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800470 - criticism
471 - comments
472 - requests for change
473 - requests for justification
474 - silence
475
476Remember, this is part of getting your patch into the kernel. You have
477to be able to take criticism and comments about your patches, evaluate
478them at a technical level and either rework your patches or provide
479clear and concise reasoning as to why those changes should not be made.
480If there are no responses to your posting, wait a few days and try
481again, sometimes things get lost in the huge volume.
482
483What should you not do?
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300484
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800485 - expect your patch to be accepted without question
486 - become defensive
487 - ignore comments
488 - resubmit the patch without making any of the requested changes
489
490In a community that is looking for the best technical solution possible,
491there will always be differing opinions on how beneficial a patch is.
492You have to be cooperative, and willing to adapt your idea to fit within
493the kernel. Or at least be willing to prove your idea is worth it.
494Remember, being wrong is acceptable as long as you are willing to work
495toward a solution that is right.
496
497It is normal that the answers to your first patch might simply be a list
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300498of a dozen things you should correct. This does **not** imply that your
499patch will not be accepted, and it is **not** meant against you
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800500personally. Simply correct all issues raised against your patch and
501resend it.
502
503
504Differences between the kernel community and corporate structures
505-----------------------------------------------------------------
506
507The kernel community works differently than most traditional corporate
508development environments. Here are a list of things that you can try to
Cristian Stoica106f9d92012-12-07 16:37:11 +0200509do to avoid problems:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300510
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800511 Good things to say regarding your proposed changes:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300512
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800513 - "This solves multiple problems."
514 - "This deletes 2000 lines of code."
515 - "Here is a patch that explains what I am trying to describe."
516 - "I tested it on 5 different architectures..."
517 - "Here is a series of small patches that..."
518 - "This increases performance on typical machines..."
519
520 Bad things you should avoid saying:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300521
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800522 - "We did it this way in AIX/ptx/Solaris, so therefore it must be
523 good..."
524 - "I've being doing this for 20 years, so..."
525 - "This is required for my company to make money"
526 - "This is for our Enterprise product line."
527 - "Here is my 1000 page design document that describes my idea"
528 - "I've been working on this for 6 months..."
529 - "Here's a 5000 line patch that..."
530 - "I rewrote all of the current mess, and here it is..."
531 - "I have a deadline, and this patch needs to be applied now."
532
533Another way the kernel community is different than most traditional
534software engineering work environments is the faceless nature of
535interaction. One benefit of using email and irc as the primary forms of
536communication is the lack of discrimination based on gender or race.
537The Linux kernel work environment is accepting of women and minorities
538because all you are is an email address. The international aspect also
539helps to level the playing field because you can't guess gender based on
540a person's name. A man may be named Andrea and a woman may be named Pat.
541Most women who have worked in the Linux kernel and have expressed an
542opinion have had positive experiences.
543
544The language barrier can cause problems for some people who are not
545comfortable with English. A good grasp of the language can be needed in
546order to get ideas across properly on mailing lists, so it is
547recommended that you check your emails to make sure they make sense in
548English before sending them.
549
550
551Break up your changes
552---------------------
553
554The Linux kernel community does not gladly accept large chunks of code
555dropped on it all at once. The changes need to be properly introduced,
556discussed, and broken up into tiny, individual portions. This is almost
557the exact opposite of what companies are used to doing. Your proposal
558should also be introduced very early in the development process, so that
559you can receive feedback on what you are doing. It also lets the
560community feel that you are working with them, and not simply using them
561as a dumping ground for your feature. However, don't send 50 emails at
562one time to a mailing list, your patch series should be smaller than
563that almost all of the time.
564
565The reasons for breaking things up are the following:
566
5671) Small patches increase the likelihood that your patches will be
568 applied, since they don't take much time or effort to verify for
569 correctness. A 5 line patch can be applied by a maintainer with
570 barely a second glance. However, a 500 line patch may take hours to
571 review for correctness (the time it takes is exponentially
572 proportional to the size of the patch, or something).
573
574 Small patches also make it very easy to debug when something goes
575 wrong. It's much easier to back out patches one by one than it is
576 to dissect a very large patch after it's been applied (and broken
577 something).
578
5792) It's important not only to send small patches, but also to rewrite
580 and simplify (or simply re-order) patches before submitting them.
581
582Here is an analogy from kernel developer Al Viro:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300583
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300584 *"Think of a teacher grading homework from a math student. The
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800585 teacher does not want to see the student's trials and errors
586 before they came up with the solution. They want to see the
587 cleanest, most elegant answer. A good student knows this, and
588 would never submit her intermediate work before the final
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300589 solution.*
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800590
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300591 *The same is true of kernel development. The maintainers and
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800592 reviewers do not want to see the thought process behind the
593 solution to the problem one is solving. They want to see a
Mauro Carvalho Chehab34fed7e2016-09-19 08:07:58 -0300594 simple and elegant solution."*
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800595
596It may be challenging to keep the balance between presenting an elegant
597solution and working together with the community and discussing your
598unfinished work. Therefore it is good to get early in the process to
599get feedback to improve your work, but also keep your changes in small
600chunks that they may get already accepted, even when your whole task is
601not ready for inclusion now.
602
603Also realize that it is not acceptable to send patches for inclusion
604that are unfinished and will be "fixed up later."
605
606
607Justify your change
608-------------------
609
610Along with breaking up your patches, it is very important for you to let
611the Linux community know why they should add this change. New features
612must be justified as being needed and useful.
613
614
615Document your change
616--------------------
617
618When sending in your patches, pay special attention to what you say in
619the text in your email. This information will become the ChangeLog
620information for the patch, and will be preserved for everyone to see for
621all time. It should describe the patch completely, containing:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300622
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800623 - why the change is necessary
624 - the overall design approach in the patch
625 - implementation details
626 - testing results
627
628For more details on what this should all look like, please see the
629ChangeLog section of the document:
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300630
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800631 "The Perfect Patch"
SeongJae Park937d9f52013-12-06 18:04:42 +0900632 http://www.ozlabs.org/~akpm/stuff/tpp.txt
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800633
634
635
636
637All of these things are sometimes very hard to do. It can take years to
638perfect these practices (if at all). It's a continuous process of
639improvement that requires a lot of patience and determination. But
640don't give up, it's possible. Many have done it before, and each had to
641start exactly where you are now.
642
643
644
645
646----------
Mauro Carvalho Chehab022e04d2016-09-19 08:07:39 -0300647
Paolo Ciarrocchi5bd982e2006-04-25 22:47:51 +0200648Thanks to Paolo Ciarrocchi who allowed the "Development Process"
Justin P. Mattock0ea6e612010-07-23 20:51:24 -0700649(http://lwn.net/Articles/94386/) section
Greg Kroah-Hartmand36cc9d2005-11-18 09:31:11 -0800650to be based on text he had written, and to Randy Dunlap and Gerrit
651Huizenga for some of the list of things you should and should not say.
652Also thanks to Pat Mochel, Hanna Linder, Randy Dunlap, Kay Sievers,
653Vojtech Pavlik, Jan Kara, Josh Boyer, Kees Cook, Andrew Morton, Andi
654Kleen, Vadim Lobanov, Jesper Juhl, Adrian Bunk, Keri Harris, Frans Pop,
655David A. Wheeler, Junio Hamano, Michael Kerrisk, and Alex Shepard for
656their review, comments, and contributions. Without their help, this
657document would not have been possible.
658
659
660
661Maintainer: Greg Kroah-Hartman <greg@kroah.com>