blob: b0b8ba9b800c6e41fb0f89c5916f2c58dbc7c7c3 [file] [log] [blame]
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001/*
2 * Copyright (C) 2015-2017 Josh Poimboeuf <jpoimboe@redhat.com>
3 *
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU General Public License
6 * as published by the Free Software Foundation; either version 2
7 * of the License, or (at your option) any later version.
8 *
9 * This program is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details.
13 *
14 * You should have received a copy of the GNU General Public License
15 * along with this program; if not, see <http://www.gnu.org/licenses/>.
16 */
17
18#include <string.h>
19#include <stdlib.h>
20
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +020021#include "builtin.h"
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -050022#include "check.h"
23#include "elf.h"
24#include "special.h"
25#include "arch.h"
26#include "warn.h"
27
28#include <linux/hashtable.h>
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +020029#include <linux/kernel.h>
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -050030
Josh Poimboeuf4ba76bf2019-05-13 12:01:31 -050031#define FAKE_JUMP_OFFSET -1
32
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -050033struct alternative {
34 struct list_head list;
35 struct instruction *insn;
36};
37
38const char *objname;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +020039struct cfi_state initial_func_cfi;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -050040
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +020041struct instruction *find_insn(struct objtool_file *file,
42 struct section *sec, unsigned long offset)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -050043{
44 struct instruction *insn;
45
46 hash_for_each_possible(file->insn_hash, insn, hash, offset)
47 if (insn->sec == sec && insn->offset == offset)
48 return insn;
49
50 return NULL;
51}
52
53static struct instruction *next_insn_same_sec(struct objtool_file *file,
54 struct instruction *insn)
55{
56 struct instruction *next = list_next_entry(insn, list);
57
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +020058 if (!next || &next->list == &file->insn_list || next->sec != insn->sec)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -050059 return NULL;
60
61 return next;
62}
63
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -050064static struct instruction *next_insn_same_func(struct objtool_file *file,
65 struct instruction *insn)
66{
67 struct instruction *next = list_next_entry(insn, list);
68 struct symbol *func = insn->func;
69
70 if (!func)
71 return NULL;
72
73 if (&next->list != &file->insn_list && next->func == func)
74 return next;
75
76 /* Check if we're already in the subfunction: */
77 if (func == func->cfunc)
78 return NULL;
79
80 /* Move to the subfunction: */
81 return find_insn(file, func->cfunc->sec, func->cfunc->offset);
82}
83
84#define func_for_each_insn_all(file, func, insn) \
85 for (insn = find_insn(file, func->sec, func->offset); \
86 insn; \
87 insn = next_insn_same_func(file, insn))
88
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -050089#define func_for_each_insn(file, func, insn) \
90 for (insn = find_insn(file, func->sec, func->offset); \
91 insn && &insn->list != &file->insn_list && \
92 insn->sec == func->sec && \
93 insn->offset < func->offset + func->len; \
94 insn = list_next_entry(insn, list))
95
96#define func_for_each_insn_continue_reverse(file, func, insn) \
97 for (insn = list_prev_entry(insn, list); \
98 &insn->list != &file->insn_list && \
99 insn->sec == func->sec && insn->offset >= func->offset; \
100 insn = list_prev_entry(insn, list))
101
102#define sec_for_each_insn_from(file, insn) \
103 for (; insn; insn = next_insn_same_sec(file, insn))
104
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200105#define sec_for_each_insn_continue(file, insn) \
106 for (insn = next_insn_same_sec(file, insn); insn; \
107 insn = next_insn_same_sec(file, insn))
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500108
109/*
110 * Check if the function has been manually whitelisted with the
111 * STACK_FRAME_NON_STANDARD macro, or if it should be automatically whitelisted
112 * due to its use of a context switching instruction.
113 */
114static bool ignore_func(struct objtool_file *file, struct symbol *func)
115{
116 struct rela *rela;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500117
118 /* check for STACK_FRAME_NON_STANDARD */
119 if (file->whitelist && file->whitelist->rela)
120 list_for_each_entry(rela, &file->whitelist->rela->rela_list, list) {
121 if (rela->sym->type == STT_SECTION &&
122 rela->sym->sec == func->sec &&
123 rela->addend == func->offset)
124 return true;
125 if (rela->sym->type == STT_FUNC && rela->sym == func)
126 return true;
127 }
128
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500129 return false;
130}
131
132/*
133 * This checks to see if the given function is a "noreturn" function.
134 *
135 * For global functions which are outside the scope of this object file, we
136 * have to keep a manual list of them.
137 *
138 * For local functions, we have to detect them manually by simply looking for
139 * the lack of a return instruction.
140 *
141 * Returns:
142 * -1: error
143 * 0: no dead end
144 * 1: dead end
145 */
146static int __dead_end_function(struct objtool_file *file, struct symbol *func,
147 int recursion)
148{
149 int i;
150 struct instruction *insn;
151 bool empty = true;
152
153 /*
154 * Unfortunately these have to be hard coded because the noreturn
155 * attribute isn't provided in ELF data.
156 */
157 static const char * const global_noreturns[] = {
158 "__stack_chk_fail",
159 "panic",
160 "do_exit",
161 "do_task_dead",
162 "__module_put_and_exit",
163 "complete_and_exit",
164 "kvm_spurious_fault",
165 "__reiserfs_panic",
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200166 "lbug_with_loc",
167 "fortify_panic",
Josh Poimboeuf495dace2018-06-19 10:47:50 -0500168 "machine_real_restart",
Josh Poimboeuf180019b2019-04-04 12:17:35 -0500169 "rewind_stack_do_exit",
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500170 };
171
172 if (func->bind == STB_WEAK)
173 return 0;
174
175 if (func->bind == STB_GLOBAL)
176 for (i = 0; i < ARRAY_SIZE(global_noreturns); i++)
177 if (!strcmp(func->name, global_noreturns[i]))
178 return 1;
179
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -0500180 if (!func->len)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500181 return 0;
182
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -0500183 insn = find_insn(file, func->sec, func->offset);
184 if (!insn->func)
185 return 0;
186
187 func_for_each_insn_all(file, func, insn) {
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500188 empty = false;
189
190 if (insn->type == INSN_RETURN)
191 return 0;
192 }
193
194 if (empty)
195 return 0;
196
197 /*
198 * A function can have a sibling call instead of a return. In that
199 * case, the function's dead-end status depends on whether the target
200 * of the sibling call returns.
201 */
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -0500202 func_for_each_insn_all(file, func, insn) {
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500203 if (insn->type == INSN_JUMP_UNCONDITIONAL) {
204 struct instruction *dest = insn->jump_dest;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500205
206 if (!dest)
207 /* sibling call to another file */
208 return 0;
209
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -0500210 if (dest->func && dest->func->pfunc != insn->func->pfunc) {
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500211
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -0500212 /* local sibling call */
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500213 if (recursion == 5) {
Josh Poimboeuf9aebb3d2018-05-09 22:39:14 -0500214 /*
215 * Infinite recursion: two functions
216 * have sibling calls to each other.
217 * This is a very rare case. It means
218 * they aren't dead ends.
219 */
220 return 0;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500221 }
222
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -0500223 return __dead_end_function(file, dest->func,
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500224 recursion + 1);
225 }
226 }
227
228 if (insn->type == INSN_JUMP_DYNAMIC && list_empty(&insn->alts))
229 /* sibling call */
230 return 0;
231 }
232
233 return 1;
234}
235
236static int dead_end_function(struct objtool_file *file, struct symbol *func)
237{
238 return __dead_end_function(file, func, 0);
239}
240
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200241static void clear_insn_state(struct insn_state *state)
242{
243 int i;
244
245 memset(state, 0, sizeof(*state));
246 state->cfa.base = CFI_UNDEFINED;
247 for (i = 0; i < CFI_NUM_REGS; i++) {
248 state->regs[i].base = CFI_UNDEFINED;
249 state->vals[i].base = CFI_UNDEFINED;
250 }
251 state->drap_reg = CFI_UNDEFINED;
252 state->drap_offset = -1;
253}
254
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500255/*
256 * Call the arch-specific instruction decoder for all the instructions and add
257 * them to the global instruction list.
258 */
259static int decode_instructions(struct objtool_file *file)
260{
261 struct section *sec;
262 struct symbol *func;
263 unsigned long offset;
264 struct instruction *insn;
265 int ret;
266
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200267 for_each_sec(file, sec) {
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500268
269 if (!(sec->sh.sh_flags & SHF_EXECINSTR))
270 continue;
271
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200272 if (strcmp(sec->name, ".altinstr_replacement") &&
273 strcmp(sec->name, ".altinstr_aux") &&
274 strncmp(sec->name, ".discard.", 9))
275 sec->text = true;
276
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500277 for (offset = 0; offset < sec->len; offset += insn->len) {
278 insn = malloc(sizeof(*insn));
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200279 if (!insn) {
280 WARN("malloc failed");
281 return -1;
282 }
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500283 memset(insn, 0, sizeof(*insn));
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500284 INIT_LIST_HEAD(&insn->alts);
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200285 clear_insn_state(&insn->state);
286
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500287 insn->sec = sec;
288 insn->offset = offset;
289
290 ret = arch_decode_instruction(file->elf, sec, offset,
291 sec->len - offset,
292 &insn->len, &insn->type,
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200293 &insn->immediate,
294 &insn->stack_op);
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500295 if (ret)
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200296 goto err;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500297
298 if (!insn->type || insn->type > INSN_LAST) {
299 WARN_FUNC("invalid instruction type %d",
300 insn->sec, insn->offset, insn->type);
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200301 ret = -1;
302 goto err;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500303 }
304
305 hash_add(file->insn_hash, &insn->hash, insn->offset);
306 list_add_tail(&insn->list, &file->insn_list);
307 }
308
309 list_for_each_entry(func, &sec->symbol_list, list) {
310 if (func->type != STT_FUNC)
311 continue;
312
313 if (!find_insn(file, sec, func->offset)) {
314 WARN("%s(): can't find starting instruction",
315 func->name);
316 return -1;
317 }
318
319 func_for_each_insn(file, func, insn)
320 if (!insn->func)
321 insn->func = func;
322 }
323 }
324
325 return 0;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200326
327err:
328 free(insn);
329 return ret;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500330}
331
332/*
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200333 * Mark "ud2" instructions and manually annotated dead ends.
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500334 */
335static int add_dead_ends(struct objtool_file *file)
336{
337 struct section *sec;
338 struct rela *rela;
339 struct instruction *insn;
340 bool found;
341
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200342 /*
343 * By default, "ud2" is a dead end unless otherwise annotated, because
344 * GCC 7 inserts it for certain divide-by-zero cases.
345 */
346 for_each_insn(file, insn)
347 if (insn->type == INSN_BUG)
348 insn->dead_end = true;
349
350 /*
351 * Check for manually annotated dead ends.
352 */
353 sec = find_section_by_name(file->elf, ".rela.discard.unreachable");
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500354 if (!sec)
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200355 goto reachable;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500356
357 list_for_each_entry(rela, &sec->rela_list, list) {
358 if (rela->sym->type != STT_SECTION) {
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200359 WARN("unexpected relocation symbol type in %s", sec->name);
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500360 return -1;
361 }
362 insn = find_insn(file, rela->sym->sec, rela->addend);
363 if (insn)
364 insn = list_prev_entry(insn, list);
365 else if (rela->addend == rela->sym->sec->len) {
366 found = false;
367 list_for_each_entry_reverse(insn, &file->insn_list, list) {
368 if (insn->sec == rela->sym->sec) {
369 found = true;
370 break;
371 }
372 }
373
374 if (!found) {
375 WARN("can't find unreachable insn at %s+0x%x",
376 rela->sym->sec->name, rela->addend);
377 return -1;
378 }
379 } else {
380 WARN("can't find unreachable insn at %s+0x%x",
381 rela->sym->sec->name, rela->addend);
382 return -1;
383 }
384
385 insn->dead_end = true;
386 }
387
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200388reachable:
389 /*
390 * These manually annotated reachable checks are needed for GCC 4.4,
391 * where the Linux unreachable() macro isn't supported. In that case
392 * GCC doesn't know the "ud2" is fatal, so it generates code as if it's
393 * not a dead end.
394 */
395 sec = find_section_by_name(file->elf, ".rela.discard.reachable");
396 if (!sec)
397 return 0;
398
399 list_for_each_entry(rela, &sec->rela_list, list) {
400 if (rela->sym->type != STT_SECTION) {
401 WARN("unexpected relocation symbol type in %s", sec->name);
402 return -1;
403 }
404 insn = find_insn(file, rela->sym->sec, rela->addend);
405 if (insn)
406 insn = list_prev_entry(insn, list);
407 else if (rela->addend == rela->sym->sec->len) {
408 found = false;
409 list_for_each_entry_reverse(insn, &file->insn_list, list) {
410 if (insn->sec == rela->sym->sec) {
411 found = true;
412 break;
413 }
414 }
415
416 if (!found) {
417 WARN("can't find reachable insn at %s+0x%x",
418 rela->sym->sec->name, rela->addend);
419 return -1;
420 }
421 } else {
422 WARN("can't find reachable insn at %s+0x%x",
423 rela->sym->sec->name, rela->addend);
424 return -1;
425 }
426
427 insn->dead_end = false;
428 }
429
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500430 return 0;
431}
432
433/*
434 * Warnings shouldn't be reported for ignored functions.
435 */
436static void add_ignores(struct objtool_file *file)
437{
438 struct instruction *insn;
439 struct section *sec;
440 struct symbol *func;
441
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200442 for_each_sec(file, sec) {
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500443 list_for_each_entry(func, &sec->symbol_list, list) {
444 if (func->type != STT_FUNC)
445 continue;
446
447 if (!ignore_func(file, func))
448 continue;
449
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -0500450 func_for_each_insn_all(file, func, insn)
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200451 insn->ignore = true;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500452 }
453 }
454}
455
456/*
457 * FIXME: For now, just ignore any alternatives which add retpolines. This is
458 * a temporary hack, as it doesn't allow ORC to unwind from inside a retpoline.
459 * But it at least allows objtool to understand the control flow *around* the
460 * retpoline.
461 */
462static int add_nospec_ignores(struct objtool_file *file)
463{
464 struct section *sec;
465 struct rela *rela;
466 struct instruction *insn;
467
468 sec = find_section_by_name(file->elf, ".rela.discard.nospec");
469 if (!sec)
470 return 0;
471
472 list_for_each_entry(rela, &sec->rela_list, list) {
473 if (rela->sym->type != STT_SECTION) {
474 WARN("unexpected relocation symbol type in %s", sec->name);
475 return -1;
476 }
477
478 insn = find_insn(file, rela->sym->sec, rela->addend);
479 if (!insn) {
480 WARN("bad .discard.nospec entry");
481 return -1;
482 }
483
484 insn->ignore_alts = true;
485 }
486
487 return 0;
488}
489
490/*
491 * Find the destination instructions for all jumps.
492 */
493static int add_jump_destinations(struct objtool_file *file)
494{
495 struct instruction *insn;
496 struct rela *rela;
497 struct section *dest_sec;
498 unsigned long dest_off;
499
500 for_each_insn(file, insn) {
501 if (insn->type != INSN_JUMP_CONDITIONAL &&
502 insn->type != INSN_JUMP_UNCONDITIONAL)
503 continue;
504
Josh Poimboeuf4ba76bf2019-05-13 12:01:31 -0500505 if (insn->ignore || insn->offset == FAKE_JUMP_OFFSET)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500506 continue;
507
508 rela = find_rela_by_dest_range(insn->sec, insn->offset,
509 insn->len);
510 if (!rela) {
511 dest_sec = insn->sec;
512 dest_off = insn->offset + insn->len + insn->immediate;
513 } else if (rela->sym->type == STT_SECTION) {
514 dest_sec = rela->sym->sec;
515 dest_off = rela->addend + 4;
516 } else if (rela->sym->sec->idx) {
517 dest_sec = rela->sym->sec;
518 dest_off = rela->sym->sym.st_value + rela->addend + 4;
519 } else if (strstr(rela->sym->name, "_indirect_thunk_")) {
520 /*
521 * Retpoline jumps are really dynamic jumps in
522 * disguise, so convert them accordingly.
523 */
524 insn->type = INSN_JUMP_DYNAMIC;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200525 insn->retpoline_safe = true;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500526 continue;
527 } else {
528 /* sibling call */
529 insn->jump_dest = 0;
530 continue;
531 }
532
533 insn->jump_dest = find_insn(file, dest_sec, dest_off);
534 if (!insn->jump_dest) {
535
536 /*
537 * This is a special case where an alt instruction
538 * jumps past the end of the section. These are
539 * handled later in handle_group_alt().
540 */
541 if (!strcmp(insn->sec->name, ".altinstr_replacement"))
542 continue;
543
544 WARN_FUNC("can't find jump dest instruction at %s+0x%lx",
545 insn->sec, insn->offset, dest_sec->name,
546 dest_off);
547 return -1;
548 }
549 }
550
551 return 0;
552}
553
554/*
555 * Find the destination instructions for all calls.
556 */
557static int add_call_destinations(struct objtool_file *file)
558{
559 struct instruction *insn;
560 unsigned long dest_off;
561 struct rela *rela;
562
563 for_each_insn(file, insn) {
564 if (insn->type != INSN_CALL)
565 continue;
566
567 rela = find_rela_by_dest_range(insn->sec, insn->offset,
568 insn->len);
569 if (!rela) {
570 dest_off = insn->offset + insn->len + insn->immediate;
571 insn->call_dest = find_symbol_by_offset(insn->sec,
572 dest_off);
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200573
574 if (!insn->call_dest && !insn->ignore) {
575 WARN_FUNC("unsupported intra-function call",
576 insn->sec, insn->offset);
577 if (retpoline)
578 WARN("If this is a retpoline, please patch it in with alternatives and annotate it with ANNOTATE_NOSPEC_ALTERNATIVE.");
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500579 return -1;
580 }
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200581
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500582 } else if (rela->sym->type == STT_SECTION) {
583 insn->call_dest = find_symbol_by_offset(rela->sym->sec,
584 rela->addend+4);
585 if (!insn->call_dest ||
586 insn->call_dest->type != STT_FUNC) {
587 WARN_FUNC("can't find call dest symbol at %s+0x%x",
588 insn->sec, insn->offset,
589 rela->sym->sec->name,
590 rela->addend + 4);
591 return -1;
592 }
593 } else
594 insn->call_dest = rela->sym;
595 }
596
597 return 0;
598}
599
600/*
601 * The .alternatives section requires some extra special care, over and above
602 * what other special sections require:
603 *
604 * 1. Because alternatives are patched in-place, we need to insert a fake jump
605 * instruction at the end so that validate_branch() skips all the original
606 * replaced instructions when validating the new instruction path.
607 *
608 * 2. An added wrinkle is that the new instruction length might be zero. In
609 * that case the old instructions are replaced with noops. We simulate that
610 * by creating a fake jump as the only new instruction.
611 *
612 * 3. In some cases, the alternative section includes an instruction which
613 * conditionally jumps to the _end_ of the entry. We have to modify these
614 * jumps' destinations to point back to .text rather than the end of the
615 * entry in .altinstr_replacement.
616 *
617 * 4. It has been requested that we don't validate the !POPCNT feature path
618 * which is a "very very small percentage of machines".
619 */
620static int handle_group_alt(struct objtool_file *file,
621 struct special_alt *special_alt,
622 struct instruction *orig_insn,
623 struct instruction **new_insn)
624{
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200625 struct instruction *last_orig_insn, *last_new_insn, *insn, *fake_jump = NULL;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500626 unsigned long dest_off;
627
628 last_orig_insn = NULL;
629 insn = orig_insn;
630 sec_for_each_insn_from(file, insn) {
631 if (insn->offset >= special_alt->orig_off + special_alt->orig_len)
632 break;
633
634 if (special_alt->skip_orig)
635 insn->type = INSN_NOP;
636
637 insn->alt_group = true;
638 last_orig_insn = insn;
639 }
640
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200641 if (next_insn_same_sec(file, last_orig_insn)) {
642 fake_jump = malloc(sizeof(*fake_jump));
643 if (!fake_jump) {
644 WARN("malloc failed");
645 return -1;
646 }
647 memset(fake_jump, 0, sizeof(*fake_jump));
648 INIT_LIST_HEAD(&fake_jump->alts);
649 clear_insn_state(&fake_jump->state);
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500650
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200651 fake_jump->sec = special_alt->new_sec;
Josh Poimboeuf4ba76bf2019-05-13 12:01:31 -0500652 fake_jump->offset = FAKE_JUMP_OFFSET;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200653 fake_jump->type = INSN_JUMP_UNCONDITIONAL;
654 fake_jump->jump_dest = list_next_entry(last_orig_insn, list);
Josh Poimboeuf4ba76bf2019-05-13 12:01:31 -0500655 fake_jump->func = orig_insn->func;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500656 }
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500657
658 if (!special_alt->new_len) {
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200659 if (!fake_jump) {
660 WARN("%s: empty alternative at end of section",
661 special_alt->orig_sec->name);
662 return -1;
663 }
664
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500665 *new_insn = fake_jump;
666 return 0;
667 }
668
669 last_new_insn = NULL;
670 insn = *new_insn;
671 sec_for_each_insn_from(file, insn) {
672 if (insn->offset >= special_alt->new_off + special_alt->new_len)
673 break;
674
675 last_new_insn = insn;
676
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200677 insn->ignore = orig_insn->ignore_alts;
678
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500679 if (insn->type != INSN_JUMP_CONDITIONAL &&
680 insn->type != INSN_JUMP_UNCONDITIONAL)
681 continue;
682
683 if (!insn->immediate)
684 continue;
685
686 dest_off = insn->offset + insn->len + insn->immediate;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200687 if (dest_off == special_alt->new_off + special_alt->new_len) {
688 if (!fake_jump) {
689 WARN("%s: alternative jump to end of section",
690 special_alt->orig_sec->name);
691 return -1;
692 }
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500693 insn->jump_dest = fake_jump;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200694 }
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500695
696 if (!insn->jump_dest) {
697 WARN_FUNC("can't find alternative jump destination",
698 insn->sec, insn->offset);
699 return -1;
700 }
701 }
702
703 if (!last_new_insn) {
704 WARN_FUNC("can't find last new alternative instruction",
705 special_alt->new_sec, special_alt->new_off);
706 return -1;
707 }
708
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200709 if (fake_jump)
710 list_add(&fake_jump->list, &last_new_insn->list);
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500711
712 return 0;
713}
714
715/*
716 * A jump table entry can either convert a nop to a jump or a jump to a nop.
717 * If the original instruction is a jump, make the alt entry an effective nop
718 * by just skipping the original instruction.
719 */
720static int handle_jump_alt(struct objtool_file *file,
721 struct special_alt *special_alt,
722 struct instruction *orig_insn,
723 struct instruction **new_insn)
724{
725 if (orig_insn->type == INSN_NOP)
726 return 0;
727
728 if (orig_insn->type != INSN_JUMP_UNCONDITIONAL) {
729 WARN_FUNC("unsupported instruction at jump label",
730 orig_insn->sec, orig_insn->offset);
731 return -1;
732 }
733
734 *new_insn = list_next_entry(orig_insn, list);
735 return 0;
736}
737
738/*
739 * Read all the special sections which have alternate instructions which can be
740 * patched in or redirected to at runtime. Each instruction having alternate
741 * instruction(s) has them added to its insn->alts list, which will be
742 * traversed in validate_branch().
743 */
744static int add_special_section_alts(struct objtool_file *file)
745{
746 struct list_head special_alts;
747 struct instruction *orig_insn, *new_insn;
748 struct special_alt *special_alt, *tmp;
749 struct alternative *alt;
750 int ret;
751
752 ret = special_get_alts(file->elf, &special_alts);
753 if (ret)
754 return ret;
755
756 list_for_each_entry_safe(special_alt, tmp, &special_alts, list) {
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200757
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500758 orig_insn = find_insn(file, special_alt->orig_sec,
759 special_alt->orig_off);
760 if (!orig_insn) {
761 WARN_FUNC("special: can't find orig instruction",
762 special_alt->orig_sec, special_alt->orig_off);
763 ret = -1;
764 goto out;
765 }
766
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500767 new_insn = NULL;
768 if (!special_alt->group || special_alt->new_len) {
769 new_insn = find_insn(file, special_alt->new_sec,
770 special_alt->new_off);
771 if (!new_insn) {
772 WARN_FUNC("special: can't find new instruction",
773 special_alt->new_sec,
774 special_alt->new_off);
775 ret = -1;
776 goto out;
777 }
778 }
779
780 if (special_alt->group) {
781 ret = handle_group_alt(file, special_alt, orig_insn,
782 &new_insn);
783 if (ret)
784 goto out;
785 } else if (special_alt->jump_or_nop) {
786 ret = handle_jump_alt(file, special_alt, orig_insn,
787 &new_insn);
788 if (ret)
789 goto out;
790 }
791
792 alt = malloc(sizeof(*alt));
793 if (!alt) {
794 WARN("malloc failed");
795 ret = -1;
796 goto out;
797 }
798
799 alt->insn = new_insn;
800 list_add_tail(&alt->list, &orig_insn->alts);
801
802 list_del(&special_alt->list);
803 free(special_alt);
804 }
805
806out:
807 return ret;
808}
809
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -0500810static int add_switch_table(struct objtool_file *file, struct instruction *insn,
811 struct rela *table, struct rela *next_table)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500812{
813 struct rela *rela = table;
814 struct instruction *alt_insn;
815 struct alternative *alt;
Josh Poimboeuf7cd91852018-05-10 17:48:49 -0500816 struct symbol *pfunc = insn->func->pfunc;
817 unsigned int prev_offset = 0;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500818
819 list_for_each_entry_from(rela, &file->rodata->rela->rela_list, list) {
820 if (rela == next_table)
821 break;
822
Josh Poimboeuf7cd91852018-05-10 17:48:49 -0500823 /* Make sure the switch table entries are consecutive: */
824 if (prev_offset && rela->offset != prev_offset + 8)
825 break;
826
827 /* Detect function pointers from contiguous objects: */
828 if (rela->sym->sec == pfunc->sec &&
829 rela->addend == pfunc->offset)
830 break;
831
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -0500832 alt_insn = find_insn(file, rela->sym->sec, rela->addend);
833 if (!alt_insn)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500834 break;
835
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -0500836 /* Make sure the jmp dest is in the function or subfunction: */
Josh Poimboeuf7cd91852018-05-10 17:48:49 -0500837 if (alt_insn->func->pfunc != pfunc)
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -0500838 break;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500839
840 alt = malloc(sizeof(*alt));
841 if (!alt) {
842 WARN("malloc failed");
843 return -1;
844 }
845
846 alt->insn = alt_insn;
847 list_add_tail(&alt->list, &insn->alts);
Josh Poimboeuf7cd91852018-05-10 17:48:49 -0500848 prev_offset = rela->offset;
849 }
850
851 if (!prev_offset) {
852 WARN_FUNC("can't find switch jump table",
853 insn->sec, insn->offset);
854 return -1;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500855 }
856
857 return 0;
858}
859
860/*
861 * find_switch_table() - Given a dynamic jump, find the switch jump table in
862 * .rodata associated with it.
863 *
864 * There are 3 basic patterns:
865 *
866 * 1. jmpq *[rodata addr](,%reg,8)
867 *
868 * This is the most common case by far. It jumps to an address in a simple
869 * jump table which is stored in .rodata.
870 *
871 * 2. jmpq *[rodata addr](%rip)
872 *
873 * This is caused by a rare GCC quirk, currently only seen in three driver
874 * functions in the kernel, only with certain obscure non-distro configs.
875 *
876 * As part of an optimization, GCC makes a copy of an existing switch jump
877 * table, modifies it, and then hard-codes the jump (albeit with an indirect
878 * jump) to use a single entry in the table. The rest of the jump table and
879 * some of its jump targets remain as dead code.
880 *
881 * In such a case we can just crudely ignore all unreachable instruction
882 * warnings for the entire object file. Ideally we would just ignore them
883 * for the function, but that would require redesigning the code quite a
884 * bit. And honestly that's just not worth doing: unreachable instruction
885 * warnings are of questionable value anyway, and this is such a rare issue.
886 *
887 * 3. mov [rodata addr],%reg1
888 * ... some instructions ...
889 * jmpq *(%reg1,%reg2,8)
890 *
891 * This is a fairly uncommon pattern which is new for GCC 6. As of this
892 * writing, there are 11 occurrences of it in the allmodconfig kernel.
893 *
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200894 * As of GCC 7 there are quite a few more of these and the 'in between' code
895 * is significant. Esp. with KASAN enabled some of the code between the mov
896 * and jmpq uses .rodata itself, which can confuse things.
897 *
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500898 * TODO: Once we have DWARF CFI and smarter instruction decoding logic,
899 * ensure the same register is used in the mov and jump instructions.
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200900 *
901 * NOTE: RETPOLINE made it harder still to decode dynamic jumps.
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500902 */
903static struct rela *find_switch_table(struct objtool_file *file,
904 struct symbol *func,
905 struct instruction *insn)
906{
907 struct rela *text_rela, *rodata_rela;
908 struct instruction *orig_insn = insn;
Josh Poimboeuf48dc5372018-05-14 08:53:24 -0500909 unsigned long table_offset;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500910
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200911 /*
912 * Backward search using the @first_jump_src links, these help avoid
913 * much of the 'in between' code. Which avoids us getting confused by
914 * it.
915 */
Josh Poimboeuf603a2cd2018-05-18 15:10:34 -0500916 for (;
Josh Poimboeuf76905852020-04-01 13:23:28 -0500917 &insn->list != &file->insn_list && insn->func && insn->func->pfunc == func;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200918 insn = insn->first_jump_src ?: list_prev_entry(insn, list)) {
919
Josh Poimboeuf603a2cd2018-05-18 15:10:34 -0500920 if (insn != orig_insn && insn->type == INSN_JUMP_DYNAMIC)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500921 break;
922
923 /* allow small jumps within the range */
924 if (insn->type == INSN_JUMP_UNCONDITIONAL &&
925 insn->jump_dest &&
926 (insn->jump_dest->offset <= insn->offset ||
927 insn->jump_dest->offset > orig_insn->offset))
928 break;
929
930 /* look for a relocation which references .rodata */
931 text_rela = find_rela_by_dest_range(insn->sec, insn->offset,
932 insn->len);
933 if (!text_rela || text_rela->sym != file->rodata->sym)
934 continue;
935
Josh Poimboeuf48dc5372018-05-14 08:53:24 -0500936 table_offset = text_rela->addend;
937 if (text_rela->type == R_X86_64_PC32)
938 table_offset += 4;
939
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500940 /*
941 * Make sure the .rodata address isn't associated with a
942 * symbol. gcc jump tables are anonymous data.
943 */
Josh Poimboeuf48dc5372018-05-14 08:53:24 -0500944 if (find_symbol_containing(file->rodata, table_offset))
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500945 continue;
946
Josh Poimboeuf48dc5372018-05-14 08:53:24 -0500947 rodata_rela = find_rela_by_dest(file->rodata, table_offset);
Josh Poimboeuf603a2cd2018-05-18 15:10:34 -0500948 if (rodata_rela) {
949 /*
950 * Use of RIP-relative switch jumps is quite rare, and
951 * indicates a rare GCC quirk/bug which can leave dead
952 * code behind.
953 */
954 if (text_rela->type == R_X86_64_PC32)
955 file->ignore_unreachables = true;
956
Josh Poimboeuf48dc5372018-05-14 08:53:24 -0500957 return rodata_rela;
Josh Poimboeuf603a2cd2018-05-18 15:10:34 -0500958 }
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500959 }
960
961 return NULL;
962}
963
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200964
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500965static int add_func_switch_tables(struct objtool_file *file,
966 struct symbol *func)
967{
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200968 struct instruction *insn, *last = NULL, *prev_jump = NULL;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500969 struct rela *rela, *prev_rela = NULL;
970 int ret;
971
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -0500972 func_for_each_insn_all(file, func, insn) {
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +0200973 if (!last)
974 last = insn;
975
976 /*
977 * Store back-pointers for unconditional forward jumps such
978 * that find_switch_table() can back-track using those and
979 * avoid some potentially confusing code.
980 */
981 if (insn->type == INSN_JUMP_UNCONDITIONAL && insn->jump_dest &&
982 insn->offset > last->offset &&
983 insn->jump_dest->offset > insn->offset &&
984 !insn->jump_dest->first_jump_src) {
985
986 insn->jump_dest->first_jump_src = insn;
987 last = insn->jump_dest;
988 }
989
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -0500990 if (insn->type != INSN_JUMP_DYNAMIC)
991 continue;
992
993 rela = find_switch_table(file, func, insn);
994 if (!rela)
995 continue;
996
997 /*
998 * We found a switch table, but we don't know yet how big it
999 * is. Don't add it until we reach the end of the function or
1000 * the beginning of another switch table in the same function.
1001 */
1002 if (prev_jump) {
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -05001003 ret = add_switch_table(file, prev_jump, prev_rela, rela);
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001004 if (ret)
1005 return ret;
1006 }
1007
1008 prev_jump = insn;
1009 prev_rela = rela;
1010 }
1011
1012 if (prev_jump) {
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -05001013 ret = add_switch_table(file, prev_jump, prev_rela, NULL);
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001014 if (ret)
1015 return ret;
1016 }
1017
1018 return 0;
1019}
1020
1021/*
1022 * For some switch statements, gcc generates a jump table in the .rodata
1023 * section which contains a list of addresses within the function to jump to.
1024 * This finds these jump tables and adds them to the insn->alts lists.
1025 */
1026static int add_switch_table_alts(struct objtool_file *file)
1027{
1028 struct section *sec;
1029 struct symbol *func;
1030 int ret;
1031
1032 if (!file->rodata || !file->rodata->rela)
1033 return 0;
1034
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001035 for_each_sec(file, sec) {
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001036 list_for_each_entry(func, &sec->symbol_list, list) {
1037 if (func->type != STT_FUNC)
1038 continue;
1039
1040 ret = add_func_switch_tables(file, func);
1041 if (ret)
1042 return ret;
1043 }
1044 }
1045
1046 return 0;
1047}
1048
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001049static int read_unwind_hints(struct objtool_file *file)
1050{
1051 struct section *sec, *relasec;
1052 struct rela *rela;
1053 struct unwind_hint *hint;
1054 struct instruction *insn;
1055 struct cfi_reg *cfa;
1056 int i;
1057
1058 sec = find_section_by_name(file->elf, ".discard.unwind_hints");
1059 if (!sec)
1060 return 0;
1061
1062 relasec = sec->rela;
1063 if (!relasec) {
1064 WARN("missing .rela.discard.unwind_hints section");
1065 return -1;
1066 }
1067
1068 if (sec->len % sizeof(struct unwind_hint)) {
1069 WARN("struct unwind_hint size mismatch");
1070 return -1;
1071 }
1072
1073 file->hints = true;
1074
1075 for (i = 0; i < sec->len / sizeof(struct unwind_hint); i++) {
1076 hint = (struct unwind_hint *)sec->data->d_buf + i;
1077
1078 rela = find_rela_by_dest(sec, i * sizeof(*hint));
1079 if (!rela) {
1080 WARN("can't find rela for unwind_hints[%d]", i);
1081 return -1;
1082 }
1083
1084 insn = find_insn(file, rela->sym->sec, rela->addend);
1085 if (!insn) {
1086 WARN("can't find insn for unwind_hints[%d]", i);
1087 return -1;
1088 }
1089
1090 cfa = &insn->state.cfa;
1091
1092 if (hint->type == UNWIND_HINT_TYPE_SAVE) {
1093 insn->save = true;
1094 continue;
1095
1096 } else if (hint->type == UNWIND_HINT_TYPE_RESTORE) {
1097 insn->restore = true;
1098 insn->hint = true;
1099 continue;
1100 }
1101
1102 insn->hint = true;
1103
1104 switch (hint->sp_reg) {
1105 case ORC_REG_UNDEFINED:
1106 cfa->base = CFI_UNDEFINED;
1107 break;
1108 case ORC_REG_SP:
1109 cfa->base = CFI_SP;
1110 break;
1111 case ORC_REG_BP:
1112 cfa->base = CFI_BP;
1113 break;
1114 case ORC_REG_SP_INDIRECT:
1115 cfa->base = CFI_SP_INDIRECT;
1116 break;
1117 case ORC_REG_R10:
1118 cfa->base = CFI_R10;
1119 break;
1120 case ORC_REG_R13:
1121 cfa->base = CFI_R13;
1122 break;
1123 case ORC_REG_DI:
1124 cfa->base = CFI_DI;
1125 break;
1126 case ORC_REG_DX:
1127 cfa->base = CFI_DX;
1128 break;
1129 default:
1130 WARN_FUNC("unsupported unwind_hint sp base reg %d",
1131 insn->sec, insn->offset, hint->sp_reg);
1132 return -1;
1133 }
1134
1135 cfa->offset = hint->sp_offset;
1136 insn->state.type = hint->type;
1137 }
1138
1139 return 0;
1140}
1141
1142static int read_retpoline_hints(struct objtool_file *file)
1143{
1144 struct section *sec;
1145 struct instruction *insn;
1146 struct rela *rela;
1147
1148 sec = find_section_by_name(file->elf, ".rela.discard.retpoline_safe");
1149 if (!sec)
1150 return 0;
1151
1152 list_for_each_entry(rela, &sec->rela_list, list) {
1153 if (rela->sym->type != STT_SECTION) {
1154 WARN("unexpected relocation symbol type in %s", sec->name);
1155 return -1;
1156 }
1157
1158 insn = find_insn(file, rela->sym->sec, rela->addend);
1159 if (!insn) {
1160 WARN("bad .discard.retpoline_safe entry");
1161 return -1;
1162 }
1163
1164 if (insn->type != INSN_JUMP_DYNAMIC &&
1165 insn->type != INSN_CALL_DYNAMIC) {
1166 WARN_FUNC("retpoline_safe hint not an indirect jump/call",
1167 insn->sec, insn->offset);
1168 return -1;
1169 }
1170
1171 insn->retpoline_safe = true;
1172 }
1173
1174 return 0;
1175}
1176
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001177static int decode_sections(struct objtool_file *file)
1178{
1179 int ret;
1180
1181 ret = decode_instructions(file);
1182 if (ret)
1183 return ret;
1184
1185 ret = add_dead_ends(file);
1186 if (ret)
1187 return ret;
1188
1189 add_ignores(file);
1190
1191 ret = add_nospec_ignores(file);
1192 if (ret)
1193 return ret;
1194
1195 ret = add_jump_destinations(file);
1196 if (ret)
1197 return ret;
1198
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001199 ret = add_special_section_alts(file);
1200 if (ret)
1201 return ret;
1202
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001203 ret = add_call_destinations(file);
1204 if (ret)
1205 return ret;
1206
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001207 ret = add_switch_table_alts(file);
1208 if (ret)
1209 return ret;
1210
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001211 ret = read_unwind_hints(file);
1212 if (ret)
1213 return ret;
1214
1215 ret = read_retpoline_hints(file);
1216 if (ret)
1217 return ret;
1218
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001219 return 0;
1220}
1221
1222static bool is_fentry_call(struct instruction *insn)
1223{
1224 if (insn->type == INSN_CALL &&
1225 insn->call_dest->type == STT_NOTYPE &&
1226 !strcmp(insn->call_dest->name, "__fentry__"))
1227 return true;
1228
1229 return false;
1230}
1231
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001232static bool has_modified_stack_frame(struct insn_state *state)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001233{
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001234 int i;
1235
1236 if (state->cfa.base != initial_func_cfi.cfa.base ||
1237 state->cfa.offset != initial_func_cfi.cfa.offset ||
1238 state->stack_size != initial_func_cfi.cfa.offset ||
1239 state->drap)
1240 return true;
1241
1242 for (i = 0; i < CFI_NUM_REGS; i++)
1243 if (state->regs[i].base != initial_func_cfi.regs[i].base ||
1244 state->regs[i].offset != initial_func_cfi.regs[i].offset)
1245 return true;
1246
1247 return false;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001248}
1249
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001250static bool has_valid_stack_frame(struct insn_state *state)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001251{
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001252 if (state->cfa.base == CFI_BP && state->regs[CFI_BP].base == CFI_CFA &&
1253 state->regs[CFI_BP].offset == -16)
1254 return true;
1255
1256 if (state->drap && state->regs[CFI_BP].base == CFI_BP)
1257 return true;
1258
1259 return false;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001260}
1261
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001262static int update_insn_state_regs(struct instruction *insn, struct insn_state *state)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001263{
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001264 struct cfi_reg *cfa = &state->cfa;
1265 struct stack_op *op = &insn->stack_op;
1266
Josh Poimboeuf7c2842f2020-04-25 05:03:00 -05001267 if (cfa->base != CFI_SP && cfa->base != CFI_SP_INDIRECT)
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001268 return 0;
1269
1270 /* push */
1271 if (op->dest.type == OP_DEST_PUSH)
1272 cfa->offset += 8;
1273
1274 /* pop */
1275 if (op->src.type == OP_SRC_POP)
1276 cfa->offset -= 8;
1277
1278 /* add immediate to sp */
1279 if (op->dest.type == OP_DEST_REG && op->src.type == OP_SRC_ADD &&
1280 op->dest.reg == CFI_SP && op->src.reg == CFI_SP)
1281 cfa->offset -= op->src.offset;
1282
1283 return 0;
1284}
1285
1286static void save_reg(struct insn_state *state, unsigned char reg, int base,
1287 int offset)
1288{
1289 if (arch_callee_saved_reg(reg) &&
1290 state->regs[reg].base == CFI_UNDEFINED) {
1291 state->regs[reg].base = base;
1292 state->regs[reg].offset = offset;
1293 }
1294}
1295
1296static void restore_reg(struct insn_state *state, unsigned char reg)
1297{
1298 state->regs[reg].base = CFI_UNDEFINED;
1299 state->regs[reg].offset = 0;
1300}
1301
1302/*
1303 * A note about DRAP stack alignment:
1304 *
1305 * GCC has the concept of a DRAP register, which is used to help keep track of
1306 * the stack pointer when aligning the stack. r10 or r13 is used as the DRAP
1307 * register. The typical DRAP pattern is:
1308 *
1309 * 4c 8d 54 24 08 lea 0x8(%rsp),%r10
1310 * 48 83 e4 c0 and $0xffffffffffffffc0,%rsp
1311 * 41 ff 72 f8 pushq -0x8(%r10)
1312 * 55 push %rbp
1313 * 48 89 e5 mov %rsp,%rbp
1314 * (more pushes)
1315 * 41 52 push %r10
1316 * ...
1317 * 41 5a pop %r10
1318 * (more pops)
1319 * 5d pop %rbp
1320 * 49 8d 62 f8 lea -0x8(%r10),%rsp
1321 * c3 retq
1322 *
1323 * There are some variations in the epilogues, like:
1324 *
1325 * 5b pop %rbx
1326 * 41 5a pop %r10
1327 * 41 5c pop %r12
1328 * 41 5d pop %r13
1329 * 41 5e pop %r14
1330 * c9 leaveq
1331 * 49 8d 62 f8 lea -0x8(%r10),%rsp
1332 * c3 retq
1333 *
1334 * and:
1335 *
1336 * 4c 8b 55 e8 mov -0x18(%rbp),%r10
1337 * 48 8b 5d e0 mov -0x20(%rbp),%rbx
1338 * 4c 8b 65 f0 mov -0x10(%rbp),%r12
1339 * 4c 8b 6d f8 mov -0x8(%rbp),%r13
1340 * c9 leaveq
1341 * 49 8d 62 f8 lea -0x8(%r10),%rsp
1342 * c3 retq
1343 *
1344 * Sometimes r13 is used as the DRAP register, in which case it's saved and
1345 * restored beforehand:
1346 *
1347 * 41 55 push %r13
1348 * 4c 8d 6c 24 10 lea 0x10(%rsp),%r13
1349 * 48 83 e4 f0 and $0xfffffffffffffff0,%rsp
1350 * ...
1351 * 49 8d 65 f0 lea -0x10(%r13),%rsp
1352 * 41 5d pop %r13
1353 * c3 retq
1354 */
1355static int update_insn_state(struct instruction *insn, struct insn_state *state)
1356{
1357 struct stack_op *op = &insn->stack_op;
1358 struct cfi_reg *cfa = &state->cfa;
1359 struct cfi_reg *regs = state->regs;
1360
1361 /* stack operations don't make sense with an undefined CFA */
1362 if (cfa->base == CFI_UNDEFINED) {
1363 if (insn->func) {
1364 WARN_FUNC("undefined stack state", insn->sec, insn->offset);
1365 return -1;
1366 }
1367 return 0;
1368 }
1369
1370 if (state->type == ORC_TYPE_REGS || state->type == ORC_TYPE_REGS_IRET)
1371 return update_insn_state_regs(insn, state);
1372
1373 switch (op->dest.type) {
1374
1375 case OP_DEST_REG:
1376 switch (op->src.type) {
1377
1378 case OP_SRC_REG:
1379 if (op->src.reg == CFI_SP && op->dest.reg == CFI_BP &&
1380 cfa->base == CFI_SP &&
1381 regs[CFI_BP].base == CFI_CFA &&
1382 regs[CFI_BP].offset == -cfa->offset) {
1383
1384 /* mov %rsp, %rbp */
1385 cfa->base = op->dest.reg;
1386 state->bp_scratch = false;
1387 }
1388
1389 else if (op->src.reg == CFI_SP &&
1390 op->dest.reg == CFI_BP && state->drap) {
1391
1392 /* drap: mov %rsp, %rbp */
1393 regs[CFI_BP].base = CFI_BP;
1394 regs[CFI_BP].offset = -state->stack_size;
1395 state->bp_scratch = false;
1396 }
1397
1398 else if (op->src.reg == CFI_SP && cfa->base == CFI_SP) {
1399
1400 /*
1401 * mov %rsp, %reg
1402 *
1403 * This is needed for the rare case where GCC
1404 * does:
1405 *
1406 * mov %rsp, %rax
1407 * ...
1408 * mov %rax, %rsp
1409 */
1410 state->vals[op->dest.reg].base = CFI_CFA;
1411 state->vals[op->dest.reg].offset = -state->stack_size;
1412 }
1413
1414 else if (op->src.reg == CFI_BP && op->dest.reg == CFI_SP &&
1415 cfa->base == CFI_BP) {
1416
1417 /*
1418 * mov %rbp, %rsp
1419 *
1420 * Restore the original stack pointer (Clang).
1421 */
1422 state->stack_size = -state->regs[CFI_BP].offset;
1423 }
1424
1425 else if (op->dest.reg == cfa->base) {
1426
1427 /* mov %reg, %rsp */
1428 if (cfa->base == CFI_SP &&
1429 state->vals[op->src.reg].base == CFI_CFA) {
1430
1431 /*
1432 * This is needed for the rare case
1433 * where GCC does something dumb like:
1434 *
1435 * lea 0x8(%rsp), %rcx
1436 * ...
1437 * mov %rcx, %rsp
1438 */
1439 cfa->offset = -state->vals[op->src.reg].offset;
1440 state->stack_size = cfa->offset;
1441
1442 } else {
1443 cfa->base = CFI_UNDEFINED;
1444 cfa->offset = 0;
1445 }
1446 }
1447
1448 break;
1449
1450 case OP_SRC_ADD:
1451 if (op->dest.reg == CFI_SP && op->src.reg == CFI_SP) {
1452
1453 /* add imm, %rsp */
1454 state->stack_size -= op->src.offset;
1455 if (cfa->base == CFI_SP)
1456 cfa->offset -= op->src.offset;
1457 break;
1458 }
1459
1460 if (op->dest.reg == CFI_SP && op->src.reg == CFI_BP) {
1461
1462 /* lea disp(%rbp), %rsp */
1463 state->stack_size = -(op->src.offset + regs[CFI_BP].offset);
1464 break;
1465 }
1466
1467 if (op->src.reg == CFI_SP && cfa->base == CFI_SP) {
1468
1469 /* drap: lea disp(%rsp), %drap */
1470 state->drap_reg = op->dest.reg;
1471
1472 /*
1473 * lea disp(%rsp), %reg
1474 *
1475 * This is needed for the rare case where GCC
1476 * does something dumb like:
1477 *
1478 * lea 0x8(%rsp), %rcx
1479 * ...
1480 * mov %rcx, %rsp
1481 */
1482 state->vals[op->dest.reg].base = CFI_CFA;
1483 state->vals[op->dest.reg].offset = \
1484 -state->stack_size + op->src.offset;
1485
1486 break;
1487 }
1488
1489 if (state->drap && op->dest.reg == CFI_SP &&
1490 op->src.reg == state->drap_reg) {
1491
1492 /* drap: lea disp(%drap), %rsp */
1493 cfa->base = CFI_SP;
1494 cfa->offset = state->stack_size = -op->src.offset;
1495 state->drap_reg = CFI_UNDEFINED;
1496 state->drap = false;
1497 break;
1498 }
1499
1500 if (op->dest.reg == state->cfa.base) {
1501 WARN_FUNC("unsupported stack register modification",
1502 insn->sec, insn->offset);
1503 return -1;
1504 }
1505
1506 break;
1507
1508 case OP_SRC_AND:
1509 if (op->dest.reg != CFI_SP ||
1510 (state->drap_reg != CFI_UNDEFINED && cfa->base != CFI_SP) ||
1511 (state->drap_reg == CFI_UNDEFINED && cfa->base != CFI_BP)) {
1512 WARN_FUNC("unsupported stack pointer realignment",
1513 insn->sec, insn->offset);
1514 return -1;
1515 }
1516
1517 if (state->drap_reg != CFI_UNDEFINED) {
1518 /* drap: and imm, %rsp */
1519 cfa->base = state->drap_reg;
1520 cfa->offset = state->stack_size = 0;
1521 state->drap = true;
1522 }
1523
1524 /*
1525 * Older versions of GCC (4.8ish) realign the stack
1526 * without DRAP, with a frame pointer.
1527 */
1528
1529 break;
1530
1531 case OP_SRC_POP:
1532 if (!state->drap && op->dest.type == OP_DEST_REG &&
1533 op->dest.reg == cfa->base) {
1534
1535 /* pop %rbp */
1536 cfa->base = CFI_SP;
1537 }
1538
1539 if (state->drap && cfa->base == CFI_BP_INDIRECT &&
1540 op->dest.type == OP_DEST_REG &&
1541 op->dest.reg == state->drap_reg &&
1542 state->drap_offset == -state->stack_size) {
1543
1544 /* drap: pop %drap */
1545 cfa->base = state->drap_reg;
1546 cfa->offset = 0;
1547 state->drap_offset = -1;
1548
1549 } else if (regs[op->dest.reg].offset == -state->stack_size) {
1550
1551 /* pop %reg */
1552 restore_reg(state, op->dest.reg);
1553 }
1554
1555 state->stack_size -= 8;
1556 if (cfa->base == CFI_SP)
1557 cfa->offset -= 8;
1558
1559 break;
1560
1561 case OP_SRC_REG_INDIRECT:
1562 if (state->drap && op->src.reg == CFI_BP &&
1563 op->src.offset == state->drap_offset) {
1564
1565 /* drap: mov disp(%rbp), %drap */
1566 cfa->base = state->drap_reg;
1567 cfa->offset = 0;
1568 state->drap_offset = -1;
1569 }
1570
1571 if (state->drap && op->src.reg == CFI_BP &&
1572 op->src.offset == regs[op->dest.reg].offset) {
1573
1574 /* drap: mov disp(%rbp), %reg */
1575 restore_reg(state, op->dest.reg);
1576
1577 } else if (op->src.reg == cfa->base &&
1578 op->src.offset == regs[op->dest.reg].offset + cfa->offset) {
1579
1580 /* mov disp(%rbp), %reg */
1581 /* mov disp(%rsp), %reg */
1582 restore_reg(state, op->dest.reg);
1583 }
1584
1585 break;
1586
1587 default:
1588 WARN_FUNC("unknown stack-related instruction",
1589 insn->sec, insn->offset);
1590 return -1;
1591 }
1592
1593 break;
1594
1595 case OP_DEST_PUSH:
1596 state->stack_size += 8;
1597 if (cfa->base == CFI_SP)
1598 cfa->offset += 8;
1599
1600 if (op->src.type != OP_SRC_REG)
1601 break;
1602
1603 if (state->drap) {
1604 if (op->src.reg == cfa->base && op->src.reg == state->drap_reg) {
1605
1606 /* drap: push %drap */
1607 cfa->base = CFI_BP_INDIRECT;
1608 cfa->offset = -state->stack_size;
1609
1610 /* save drap so we know when to restore it */
1611 state->drap_offset = -state->stack_size;
1612
1613 } else if (op->src.reg == CFI_BP && cfa->base == state->drap_reg) {
1614
1615 /* drap: push %rbp */
1616 state->stack_size = 0;
1617
1618 } else if (regs[op->src.reg].base == CFI_UNDEFINED) {
1619
1620 /* drap: push %reg */
1621 save_reg(state, op->src.reg, CFI_BP, -state->stack_size);
1622 }
1623
1624 } else {
1625
1626 /* push %reg */
1627 save_reg(state, op->src.reg, CFI_CFA, -state->stack_size);
1628 }
1629
1630 /* detect when asm code uses rbp as a scratch register */
1631 if (!no_fp && insn->func && op->src.reg == CFI_BP &&
1632 cfa->base != CFI_BP)
1633 state->bp_scratch = true;
1634 break;
1635
1636 case OP_DEST_REG_INDIRECT:
1637
1638 if (state->drap) {
1639 if (op->src.reg == cfa->base && op->src.reg == state->drap_reg) {
1640
1641 /* drap: mov %drap, disp(%rbp) */
1642 cfa->base = CFI_BP_INDIRECT;
1643 cfa->offset = op->dest.offset;
1644
1645 /* save drap offset so we know when to restore it */
1646 state->drap_offset = op->dest.offset;
1647 }
1648
1649 else if (regs[op->src.reg].base == CFI_UNDEFINED) {
1650
1651 /* drap: mov reg, disp(%rbp) */
1652 save_reg(state, op->src.reg, CFI_BP, op->dest.offset);
1653 }
1654
1655 } else if (op->dest.reg == cfa->base) {
1656
1657 /* mov reg, disp(%rbp) */
1658 /* mov reg, disp(%rsp) */
1659 save_reg(state, op->src.reg, CFI_CFA,
1660 op->dest.offset - state->cfa.offset);
1661 }
1662
1663 break;
1664
1665 case OP_DEST_LEAVE:
1666 if ((!state->drap && cfa->base != CFI_BP) ||
1667 (state->drap && cfa->base != state->drap_reg)) {
1668 WARN_FUNC("leave instruction with modified stack frame",
1669 insn->sec, insn->offset);
1670 return -1;
1671 }
1672
1673 /* leave (mov %rbp, %rsp; pop %rbp) */
1674
1675 state->stack_size = -state->regs[CFI_BP].offset - 8;
1676 restore_reg(state, CFI_BP);
1677
1678 if (!state->drap) {
1679 cfa->base = CFI_SP;
1680 cfa->offset -= 8;
1681 }
1682
1683 break;
1684
1685 case OP_DEST_MEM:
1686 if (op->src.type != OP_SRC_POP) {
1687 WARN_FUNC("unknown stack-related memory operation",
1688 insn->sec, insn->offset);
1689 return -1;
1690 }
1691
1692 /* pop mem */
1693 state->stack_size -= 8;
1694 if (cfa->base == CFI_SP)
1695 cfa->offset -= 8;
1696
1697 break;
1698
1699 default:
1700 WARN_FUNC("unknown stack-related instruction",
1701 insn->sec, insn->offset);
1702 return -1;
1703 }
1704
1705 return 0;
1706}
1707
1708static bool insn_state_match(struct instruction *insn, struct insn_state *state)
1709{
1710 struct insn_state *state1 = &insn->state, *state2 = state;
1711 int i;
1712
1713 if (memcmp(&state1->cfa, &state2->cfa, sizeof(state1->cfa))) {
1714 WARN_FUNC("stack state mismatch: cfa1=%d%+d cfa2=%d%+d",
1715 insn->sec, insn->offset,
1716 state1->cfa.base, state1->cfa.offset,
1717 state2->cfa.base, state2->cfa.offset);
1718
1719 } else if (memcmp(&state1->regs, &state2->regs, sizeof(state1->regs))) {
1720 for (i = 0; i < CFI_NUM_REGS; i++) {
1721 if (!memcmp(&state1->regs[i], &state2->regs[i],
1722 sizeof(struct cfi_reg)))
1723 continue;
1724
1725 WARN_FUNC("stack state mismatch: reg1[%d]=%d%+d reg2[%d]=%d%+d",
1726 insn->sec, insn->offset,
1727 i, state1->regs[i].base, state1->regs[i].offset,
1728 i, state2->regs[i].base, state2->regs[i].offset);
1729 break;
1730 }
1731
1732 } else if (state1->type != state2->type) {
1733 WARN_FUNC("stack state mismatch: type1=%d type2=%d",
1734 insn->sec, insn->offset, state1->type, state2->type);
1735
1736 } else if (state1->drap != state2->drap ||
1737 (state1->drap && state1->drap_reg != state2->drap_reg) ||
1738 (state1->drap && state1->drap_offset != state2->drap_offset)) {
1739 WARN_FUNC("stack state mismatch: drap1=%d(%d,%d) drap2=%d(%d,%d)",
1740 insn->sec, insn->offset,
1741 state1->drap, state1->drap_reg, state1->drap_offset,
1742 state2->drap, state2->drap_reg, state2->drap_offset);
1743
1744 } else
1745 return true;
1746
1747 return false;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001748}
1749
1750/*
1751 * Follow the branch starting at the given instruction, and recursively follow
1752 * any other branches (jumps). Meanwhile, track the frame pointer state at
1753 * each instruction and validate all the rules described in
1754 * tools/objtool/Documentation/stack-validation.txt.
1755 */
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001756static int validate_branch(struct objtool_file *file, struct instruction *first,
1757 struct insn_state state)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001758{
1759 struct alternative *alt;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001760 struct instruction *insn, *next_insn;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001761 struct section *sec;
1762 struct symbol *func = NULL;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001763 int ret;
1764
1765 insn = first;
1766 sec = insn->sec;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001767
1768 if (insn->alt_group && list_empty(&insn->alts)) {
1769 WARN_FUNC("don't know how to handle branch to middle of alternative instruction group",
1770 sec, insn->offset);
1771 return 1;
1772 }
1773
1774 while (1) {
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001775 next_insn = next_insn_same_sec(file, insn);
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001776
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -05001777 if (file->c_file && func && insn->func && func != insn->func->pfunc) {
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001778 WARN("%s() falls through to next function %s()",
1779 func->name, insn->func->name);
1780 return 1;
1781 }
1782
Josh Poimboeuf15e6da92019-05-13 12:01:32 -05001783 if (insn->func)
1784 func = insn->func->pfunc;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001785
1786 if (func && insn->ignore) {
1787 WARN_FUNC("BUG: why am I validating an ignored function?",
1788 sec, insn->offset);
1789 return 1;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001790 }
1791
1792 if (insn->visited) {
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001793 if (!insn->hint && !insn_state_match(insn, &state))
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001794 return 1;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001795
1796 return 0;
1797 }
1798
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001799 if (insn->hint) {
1800 if (insn->restore) {
1801 struct instruction *save_insn, *i;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001802
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001803 i = insn;
1804 save_insn = NULL;
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -05001805 func_for_each_insn_continue_reverse(file, insn->func, i) {
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001806 if (i->save) {
1807 save_insn = i;
1808 break;
1809 }
1810 }
1811
1812 if (!save_insn) {
1813 WARN_FUNC("no corresponding CFI save for CFI restore",
1814 sec, insn->offset);
1815 return 1;
1816 }
1817
1818 if (!save_insn->visited) {
1819 /*
1820 * Oops, no state to copy yet.
1821 * Hopefully we can reach this
1822 * instruction from another branch
1823 * after the save insn has been
1824 * visited.
1825 */
1826 if (insn == first)
1827 return 0;
1828
1829 WARN_FUNC("objtool isn't smart enough to handle this CFI save/restore combo",
1830 sec, insn->offset);
1831 return 1;
1832 }
1833
1834 insn->state = save_insn->state;
1835 }
1836
1837 state = insn->state;
1838
1839 } else
1840 insn->state = state;
1841
1842 insn->visited = true;
1843
1844 if (!insn->ignore_alts) {
1845 list_for_each_entry(alt, &insn->alts, list) {
1846 ret = validate_branch(file, alt->insn, state);
1847 if (ret)
1848 return 1;
1849 }
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001850 }
1851
1852 switch (insn->type) {
1853
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001854 case INSN_RETURN:
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001855 if (func && has_modified_stack_frame(&state)) {
1856 WARN_FUNC("return with modified stack frame",
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001857 sec, insn->offset);
1858 return 1;
1859 }
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001860
1861 if (state.bp_scratch) {
1862 WARN("%s uses BP as a scratch register",
1863 insn->func->name);
1864 return 1;
1865 }
1866
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001867 return 0;
1868
1869 case INSN_CALL:
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001870 if (is_fentry_call(insn))
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001871 break;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001872
1873 ret = dead_end_function(file, insn->call_dest);
1874 if (ret == 1)
1875 return 0;
1876 if (ret == -1)
1877 return 1;
1878
1879 /* fallthrough */
1880 case INSN_CALL_DYNAMIC:
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001881 if (!no_fp && func && !has_valid_stack_frame(&state)) {
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001882 WARN_FUNC("call without frame pointer save/setup",
1883 sec, insn->offset);
1884 return 1;
1885 }
1886 break;
1887
1888 case INSN_JUMP_CONDITIONAL:
1889 case INSN_JUMP_UNCONDITIONAL:
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001890 if (insn->jump_dest &&
1891 (!func || !insn->jump_dest->func ||
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -05001892 insn->jump_dest->func->pfunc == func)) {
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001893 ret = validate_branch(file, insn->jump_dest,
1894 state);
1895 if (ret)
1896 return 1;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001897
1898 } else if (func && has_modified_stack_frame(&state)) {
1899 WARN_FUNC("sibling call from callable instruction with modified stack frame",
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001900 sec, insn->offset);
1901 return 1;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001902 }
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001903
1904 if (insn->type == INSN_JUMP_UNCONDITIONAL)
1905 return 0;
1906
1907 break;
1908
1909 case INSN_JUMP_DYNAMIC:
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001910 if (func && list_empty(&insn->alts) &&
1911 has_modified_stack_frame(&state)) {
1912 WARN_FUNC("sibling call from callable instruction with modified stack frame",
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001913 sec, insn->offset);
1914 return 1;
1915 }
1916
1917 return 0;
1918
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001919 case INSN_CONTEXT_SWITCH:
1920 if (func && (!next_insn || !next_insn->hint)) {
1921 WARN_FUNC("unsupported instruction in callable function",
1922 sec, insn->offset);
1923 return 1;
1924 }
1925 return 0;
1926
1927 case INSN_STACK:
1928 if (update_insn_state(insn, &state))
1929 return 1;
1930
1931 break;
1932
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001933 default:
1934 break;
1935 }
1936
1937 if (insn->dead_end)
1938 return 0;
1939
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001940 if (!next_insn) {
1941 if (state.cfa.base == CFI_UNDEFINED)
1942 return 0;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001943 WARN("%s: unexpected end of section", sec->name);
1944 return 1;
1945 }
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001946
1947 insn = next_insn;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05001948 }
1949
1950 return 0;
1951}
1952
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02001953static int validate_unwind_hints(struct objtool_file *file)
1954{
1955 struct instruction *insn;
1956 int ret, warnings = 0;
1957 struct insn_state state;
1958
1959 if (!file->hints)
1960 return 0;
1961
1962 clear_insn_state(&state);
1963
1964 for_each_insn(file, insn) {
1965 if (insn->hint && !insn->visited) {
1966 ret = validate_branch(file, insn, state);
1967 warnings += ret;
1968 }
1969 }
1970
1971 return warnings;
1972}
1973
1974static int validate_retpoline(struct objtool_file *file)
1975{
1976 struct instruction *insn;
1977 int warnings = 0;
1978
1979 for_each_insn(file, insn) {
1980 if (insn->type != INSN_JUMP_DYNAMIC &&
1981 insn->type != INSN_CALL_DYNAMIC)
1982 continue;
1983
1984 if (insn->retpoline_safe)
1985 continue;
1986
1987 /*
1988 * .init.text code is ran before userspace and thus doesn't
1989 * strictly need retpolines, except for modules which are
1990 * loaded late, they very much do need retpoline in their
1991 * .init.text
1992 */
1993 if (!strcmp(insn->sec->name, ".init.text") && !module)
1994 continue;
1995
1996 WARN_FUNC("indirect %s found in RETPOLINE build",
1997 insn->sec, insn->offset,
1998 insn->type == INSN_JUMP_DYNAMIC ? "jump" : "call");
1999
2000 warnings++;
2001 }
2002
2003 return warnings;
2004}
2005
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002006static bool is_kasan_insn(struct instruction *insn)
2007{
2008 return (insn->type == INSN_CALL &&
2009 !strcmp(insn->call_dest->name, "__asan_handle_no_return"));
2010}
2011
2012static bool is_ubsan_insn(struct instruction *insn)
2013{
2014 return (insn->type == INSN_CALL &&
2015 !strcmp(insn->call_dest->name,
2016 "__ubsan_handle_builtin_unreachable"));
2017}
2018
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002019static bool ignore_unreachable_insn(struct instruction *insn)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002020{
2021 int i;
2022
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002023 if (insn->ignore || insn->type == INSN_NOP)
2024 return true;
2025
2026 /*
2027 * Ignore any unused exceptions. This can happen when a whitelisted
2028 * function has an exception table entry.
2029 *
2030 * Also ignore alternative replacement instructions. This can happen
2031 * when a whitelisted function uses one of the ALTERNATIVE macros.
2032 */
2033 if (!strcmp(insn->sec->name, ".fixup") ||
2034 !strcmp(insn->sec->name, ".altinstr_replacement") ||
2035 !strcmp(insn->sec->name, ".altinstr_aux"))
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002036 return true;
2037
Josh Poimboeufe1f81c92020-04-01 13:23:25 -05002038 if (!insn->func)
2039 return false;
2040
2041 /*
2042 * CONFIG_UBSAN_TRAP inserts a UD2 when it sees
2043 * __builtin_unreachable(). The BUG() macro has an unreachable() after
2044 * the UD2, which causes GCC's undefined trap logic to emit another UD2
2045 * (or occasionally a JMP to UD2).
2046 */
2047 if (list_prev_entry(insn, list)->dead_end &&
2048 (insn->type == INSN_BUG ||
2049 (insn->type == INSN_JUMP_UNCONDITIONAL &&
2050 insn->jump_dest && insn->jump_dest->type == INSN_BUG)))
2051 return true;
2052
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002053 /*
2054 * Check if this (or a subsequent) instruction is related to
2055 * CONFIG_UBSAN or CONFIG_KASAN.
2056 *
2057 * End the search at 5 instructions to avoid going into the weeds.
2058 */
2059 for (i = 0; i < 5; i++) {
2060
2061 if (is_kasan_insn(insn) || is_ubsan_insn(insn))
2062 return true;
2063
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002064 if (insn->type == INSN_JUMP_UNCONDITIONAL) {
2065 if (insn->jump_dest &&
2066 insn->jump_dest->func == insn->func) {
2067 insn = insn->jump_dest;
2068 continue;
2069 }
2070
2071 break;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002072 }
2073
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002074 if (insn->offset + insn->len >= insn->func->offset + insn->func->len)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002075 break;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002076
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002077 insn = list_next_entry(insn, list);
2078 }
2079
2080 return false;
2081}
2082
2083static int validate_functions(struct objtool_file *file)
2084{
2085 struct section *sec;
2086 struct symbol *func;
2087 struct instruction *insn;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002088 struct insn_state state;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002089 int ret, warnings = 0;
2090
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002091 clear_insn_state(&state);
2092
2093 state.cfa = initial_func_cfi.cfa;
2094 memcpy(&state.regs, &initial_func_cfi.regs,
2095 CFI_NUM_REGS * sizeof(struct cfi_reg));
2096 state.stack_size = initial_func_cfi.cfa.offset;
2097
2098 for_each_sec(file, sec) {
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002099 list_for_each_entry(func, &sec->symbol_list, list) {
Josh Poimboeuf1f7f88a2018-05-09 22:39:15 -05002100 if (func->type != STT_FUNC || func->pfunc != func)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002101 continue;
2102
2103 insn = find_insn(file, sec, func->offset);
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002104 if (!insn || insn->ignore)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002105 continue;
2106
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002107 ret = validate_branch(file, insn, state);
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002108 warnings += ret;
2109 }
2110 }
2111
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002112 return warnings;
2113}
2114
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002115static int validate_reachable_instructions(struct objtool_file *file)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002116{
2117 struct instruction *insn;
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002118
2119 if (file->ignore_unreachables)
2120 return 0;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002121
2122 for_each_insn(file, insn) {
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002123 if (insn->visited || ignore_unreachable_insn(insn))
2124 continue;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002125
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002126 WARN_FUNC("unreachable instruction", insn->sec, insn->offset);
2127 return 1;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002128 }
2129
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002130 return 0;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002131}
2132
2133static void cleanup(struct objtool_file *file)
2134{
2135 struct instruction *insn, *tmpinsn;
2136 struct alternative *alt, *tmpalt;
2137
2138 list_for_each_entry_safe(insn, tmpinsn, &file->insn_list, list) {
2139 list_for_each_entry_safe(alt, tmpalt, &insn->alts, list) {
2140 list_del(&alt->list);
2141 free(alt);
2142 }
2143 list_del(&insn->list);
2144 hash_del(&insn->hash);
2145 free(insn);
2146 }
2147 elf_close(file->elf);
2148}
2149
Josh Poimboeufc818b2f2019-03-18 19:09:38 -05002150static struct objtool_file file;
2151
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002152int check(const char *_objname, bool orc)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002153{
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002154 int ret, warnings = 0;
2155
2156 objname = _objname;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002157
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002158 file.elf = elf_open(objname, orc ? O_RDWR : O_RDONLY);
2159 if (!file.elf)
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002160 return 1;
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002161
2162 INIT_LIST_HEAD(&file.insn_list);
2163 hash_init(file.insn_hash);
2164 file.whitelist = find_section_by_name(file.elf, ".discard.func_stack_frame_non_standard");
2165 file.rodata = find_section_by_name(file.elf, ".rodata");
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002166 file.c_file = find_section_by_name(file.elf, ".comment");
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002167 file.ignore_unreachables = no_unreachable;
2168 file.hints = false;
2169
2170 arch_initial_func_cfi_state(&initial_func_cfi);
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002171
2172 ret = decode_sections(&file);
2173 if (ret < 0)
2174 goto out;
2175 warnings += ret;
2176
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002177 if (list_empty(&file.insn_list))
2178 goto out;
2179
2180 if (retpoline) {
2181 ret = validate_retpoline(&file);
2182 if (ret < 0)
2183 return ret;
2184 warnings += ret;
2185 }
2186
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002187 ret = validate_functions(&file);
2188 if (ret < 0)
2189 goto out;
2190 warnings += ret;
2191
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002192 ret = validate_unwind_hints(&file);
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002193 if (ret < 0)
2194 goto out;
2195 warnings += ret;
2196
Greg Kroah-Hartmanb790b4f2018-06-03 12:35:15 +02002197 if (!warnings) {
2198 ret = validate_reachable_instructions(&file);
2199 if (ret < 0)
2200 goto out;
2201 warnings += ret;
2202 }
2203
2204 if (orc) {
2205 ret = create_orc(&file);
2206 if (ret < 0)
2207 goto out;
2208
2209 ret = create_orc_sections(&file);
2210 if (ret < 0)
2211 goto out;
2212
2213 ret = elf_write(file.elf);
2214 if (ret < 0)
2215 goto out;
2216 }
2217
Josh Poimboeuf24ac7a42017-06-28 10:11:05 -05002218out:
2219 cleanup(&file);
2220
2221 /* ignore warnings for now until we get all the code cleaned up */
2222 if (ret || warnings)
2223 return 0;
2224 return 0;
2225}