blob: 5a9bd95884bef0ebd35f85518c3a6c4f63acef05 [file] [log] [blame]
Mitch Williamsb76cdba2005-11-09 10:36:41 -08001
2/*
3 * Copyright(c) 2004-2005 Intel Corporation. All rights reserved.
4 *
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License as published by the
7 * Free Software Foundation; either version 2 of the License, or
8 * (at your option) any later version.
9 *
10 * This program is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
12 * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
13 * for more details.
14 *
15 * You should have received a copy of the GNU General Public License along
16 * with this program; if not, write to the Free Software Foundation, Inc.,
17 * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
18 *
19 * The full GNU General Public License is included in this distribution in the
20 * file called LICENSE.
21 *
Mitch Williamsb76cdba2005-11-09 10:36:41 -080022 */
23#include <linux/config.h>
24#include <linux/kernel.h>
25#include <linux/module.h>
26#include <linux/sched.h>
27#include <linux/device.h>
28#include <linux/sysdev.h>
29#include <linux/fs.h>
30#include <linux/types.h>
31#include <linux/string.h>
32#include <linux/netdevice.h>
33#include <linux/inetdevice.h>
34#include <linux/in.h>
35#include <linux/sysfs.h>
36#include <linux/string.h>
37#include <linux/ctype.h>
38#include <linux/inet.h>
39#include <linux/rtnetlink.h>
40
41/* #define BONDING_DEBUG 1 */
42#include "bonding.h"
43#define to_class_dev(obj) container_of(obj,struct class_device,kobj)
44#define to_net_dev(class) container_of(class, struct net_device, class_dev)
45#define to_bond(cd) ((struct bonding *)(to_net_dev(cd)->priv))
46
47/*---------------------------- Declarations -------------------------------*/
48
49
50extern struct list_head bond_dev_list;
51extern struct bond_params bonding_defaults;
52extern struct bond_parm_tbl bond_mode_tbl[];
53extern struct bond_parm_tbl bond_lacp_tbl[];
54extern struct bond_parm_tbl xmit_hashtype_tbl[];
55
56static int expected_refcount = -1;
57static struct class *netdev_class;
58/*--------------------------- Data Structures -----------------------------*/
59
60/* Bonding sysfs lock. Why can't we just use the subsytem lock?
61 * Because kobject_register tries to acquire the subsystem lock. If
62 * we already hold the lock (which we would if the user was creating
63 * a new bond through the sysfs interface), we deadlock.
64 * This lock is only needed when deleting a bond - we need to make sure
65 * that we don't collide with an ongoing ioctl.
66 */
67
68struct rw_semaphore bonding_rwsem;
69
70
71
72
73/*------------------------------ Functions --------------------------------*/
74
75/*
76 * "show" function for the bond_masters attribute.
77 * The class parameter is ignored.
78 */
79static ssize_t bonding_show_bonds(struct class *cls, char *buffer)
80{
81 int res = 0;
82 struct bonding *bond;
83
84 down_read(&(bonding_rwsem));
85
86 list_for_each_entry(bond, &bond_dev_list, bond_list) {
87 if (res > (PAGE_SIZE - IFNAMSIZ)) {
88 /* not enough space for another interface name */
89 if ((PAGE_SIZE - res) > 10)
90 res = PAGE_SIZE - 10;
91 res += sprintf(buffer + res, "++more++");
92 break;
93 }
94 res += sprintf(buffer + res, "%s ",
95 bond->dev->name);
96 }
97 res += sprintf(buffer + res, "\n");
98 res++;
99 up_read(&(bonding_rwsem));
100 return res;
101}
102
103/*
104 * "store" function for the bond_masters attribute. This is what
105 * creates and deletes entire bonds.
106 *
107 * The class parameter is ignored.
108 *
109 */
110
111static ssize_t bonding_store_bonds(struct class *cls, const char *buffer, size_t count)
112{
113 char command[IFNAMSIZ + 1] = {0, };
114 char *ifname;
115 int res = count;
116 struct bonding *bond;
117 struct bonding *nxt;
118
119 down_write(&(bonding_rwsem));
120 sscanf(buffer, "%16s", command); /* IFNAMSIZ*/
121 ifname = command + 1;
122 if ((strlen(command) <= 1) ||
123 !dev_valid_name(ifname))
124 goto err_no_cmd;
125
126 if (command[0] == '+') {
127
128 /* Check to see if the bond already exists. */
129 list_for_each_entry_safe(bond, nxt, &bond_dev_list, bond_list)
130 if (strnicmp(bond->dev->name, ifname, IFNAMSIZ) == 0) {
131 printk(KERN_ERR DRV_NAME
132 ": cannot add bond %s; it already exists\n",
133 ifname);
134 res = -EPERM;
135 goto out;
136 }
137
138 printk(KERN_INFO DRV_NAME
139 ": %s is being created...\n", ifname);
140 if (bond_create(ifname, &bonding_defaults, &bond)) {
141 printk(KERN_INFO DRV_NAME
142 ": %s interface already exists. Bond creation failed.\n",
143 ifname);
144 res = -EPERM;
145 }
146 goto out;
147 }
148
149 if (command[0] == '-') {
150 list_for_each_entry_safe(bond, nxt, &bond_dev_list, bond_list)
151 if (strnicmp(bond->dev->name, ifname, IFNAMSIZ) == 0) {
152 rtnl_lock();
153 /* check the ref count on the bond's kobject.
154 * If it's > expected, then there's a file open,
155 * and we have to fail.
156 */
157 if (atomic_read(&bond->dev->class_dev.kobj.kref.refcount)
158 > expected_refcount){
159 rtnl_unlock();
160 printk(KERN_INFO DRV_NAME
161 ": Unable remove bond %s due to open references.\n",
162 ifname);
163 res = -EPERM;
164 goto out;
165 }
166 printk(KERN_INFO DRV_NAME
167 ": %s is being deleted...\n",
168 bond->dev->name);
169 unregister_netdevice(bond->dev);
170 bond_deinit(bond->dev);
171 bond_destroy_sysfs_entry(bond);
172 rtnl_unlock();
173 goto out;
174 }
175
176 printk(KERN_ERR DRV_NAME
177 ": unable to delete non-existent bond %s\n", ifname);
178 res = -ENODEV;
179 goto out;
180 }
181
182err_no_cmd:
183 printk(KERN_ERR DRV_NAME
184 ": no command found in bonding_masters. Use +ifname or -ifname.\n");
185 res = -EPERM;
186
187 /* Always return either count or an error. If you return 0, you'll
188 * get called forever, which is bad.
189 */
190out:
191 up_write(&(bonding_rwsem));
192 return res;
193}
194/* class attribute for bond_masters file. This ends up in /sys/class/net */
195static CLASS_ATTR(bonding_masters, S_IWUSR | S_IRUGO,
196 bonding_show_bonds, bonding_store_bonds);
197
198int bond_create_slave_symlinks(struct net_device *master, struct net_device *slave)
199{
200 char linkname[IFNAMSIZ+7];
201 int ret = 0;
202
203 /* first, create a link from the slave back to the master */
204 ret = sysfs_create_link(&(slave->class_dev.kobj), &(master->class_dev.kobj),
205 "master");
206 if (ret)
207 return ret;
208 /* next, create a link from the master to the slave */
209 sprintf(linkname,"slave_%s",slave->name);
210 ret = sysfs_create_link(&(master->class_dev.kobj), &(slave->class_dev.kobj),
211 linkname);
212 return ret;
213
214}
215
216void bond_destroy_slave_symlinks(struct net_device *master, struct net_device *slave)
217{
218 char linkname[IFNAMSIZ+7];
219
220 sysfs_remove_link(&(slave->class_dev.kobj), "master");
221 sprintf(linkname,"slave_%s",slave->name);
222 sysfs_remove_link(&(master->class_dev.kobj), linkname);
223}
224
225
226/*
227 * Show the slaves in the current bond.
228 */
229static ssize_t bonding_show_slaves(struct class_device *cd, char *buf)
230{
231 struct slave *slave;
232 int i, res = 0;
233 struct bonding *bond = to_bond(cd);
234
235 read_lock_bh(&bond->lock);
236 bond_for_each_slave(bond, slave, i) {
237 if (res > (PAGE_SIZE - IFNAMSIZ)) {
238 /* not enough space for another interface name */
239 if ((PAGE_SIZE - res) > 10)
240 res = PAGE_SIZE - 10;
241 res += sprintf(buf + res, "++more++");
242 break;
243 }
244 res += sprintf(buf + res, "%s ", slave->dev->name);
245 }
246 read_unlock_bh(&bond->lock);
247 res += sprintf(buf + res, "\n");
248 res++;
249 return res;
250}
251
252/*
253 * Set the slaves in the current bond. The bond interface must be
254 * up for this to succeed.
255 * This function is largely the same flow as bonding_update_bonds().
256 */
257static ssize_t bonding_store_slaves(struct class_device *cd, const char *buffer, size_t count)
258{
259 char command[IFNAMSIZ + 1] = { 0, };
260 char *ifname;
261 int i, res, found, ret = count;
262 struct slave *slave;
Luiz Fernando Capitulino3418db72006-02-01 00:54:34 -0800263 struct net_device *dev = NULL;
Mitch Williamsb76cdba2005-11-09 10:36:41 -0800264 struct bonding *bond = to_bond(cd);
265
266 /* Quick sanity check -- is the bond interface up? */
267 if (!(bond->dev->flags & IFF_UP)) {
268 printk(KERN_ERR DRV_NAME
269 ": %s: Unable to update slaves because interface is down.\n",
270 bond->dev->name);
271 ret = -EPERM;
272 goto out;
273 }
274
275 /* Note: We can't hold bond->lock here, as bond_create grabs it. */
276
277 sscanf(buffer, "%16s", command); /* IFNAMSIZ*/
278 ifname = command + 1;
279 if ((strlen(command) <= 1) ||
280 !dev_valid_name(ifname))
281 goto err_no_cmd;
282
283 if (command[0] == '+') {
284
285 /* Got a slave name in ifname. Is it already in the list? */
286 found = 0;
287 read_lock_bh(&bond->lock);
288 bond_for_each_slave(bond, slave, i)
289 if (strnicmp(slave->dev->name, ifname, IFNAMSIZ) == 0) {
290 printk(KERN_ERR DRV_NAME
291 ": %s: Interface %s is already enslaved!\n",
292 bond->dev->name, ifname);
293 ret = -EPERM;
294 read_unlock_bh(&bond->lock);
295 goto out;
296 }
297
298 read_unlock_bh(&bond->lock);
299 printk(KERN_INFO DRV_NAME ": %s: Adding slave %s.\n",
300 bond->dev->name, ifname);
301 dev = dev_get_by_name(ifname);
302 if (!dev) {
303 printk(KERN_INFO DRV_NAME
304 ": %s: Interface %s does not exist!\n",
305 bond->dev->name, ifname);
306 ret = -EPERM;
307 goto out;
308 }
309 else
310 dev_put(dev);
311
312 if (dev->flags & IFF_UP) {
313 printk(KERN_ERR DRV_NAME
314 ": %s: Error: Unable to enslave %s "
315 "because it is already up.\n",
316 bond->dev->name, dev->name);
317 ret = -EPERM;
318 goto out;
319 }
320 /* If this is the first slave, then we need to set
321 the master's hardware address to be the same as the
322 slave's. */
323 if (!(*((u32 *) & (bond->dev->dev_addr[0])))) {
324 memcpy(bond->dev->dev_addr, dev->dev_addr,
325 dev->addr_len);
326 }
327
328 /* Set the slave's MTU to match the bond */
329 if (dev->mtu != bond->dev->mtu) {
330 if (dev->change_mtu) {
331 res = dev->change_mtu(dev,
332 bond->dev->mtu);
333 if (res) {
334 ret = res;
335 goto out;
336 }
337 } else {
338 dev->mtu = bond->dev->mtu;
339 }
340 }
341 rtnl_lock();
342 res = bond_enslave(bond->dev, dev);
343 rtnl_unlock();
344 if (res) {
345 ret = res;
346 }
347 goto out;
348 }
349
350 if (command[0] == '-') {
351 dev = NULL;
352 bond_for_each_slave(bond, slave, i)
353 if (strnicmp(slave->dev->name, ifname, IFNAMSIZ) == 0) {
354 dev = slave->dev;
355 break;
356 }
357 if (dev) {
358 printk(KERN_INFO DRV_NAME ": %s: Removing slave %s\n",
359 bond->dev->name, dev->name);
360 rtnl_lock();
361 res = bond_release(bond->dev, dev);
362 rtnl_unlock();
363 if (res) {
364 ret = res;
365 goto out;
366 }
367 /* set the slave MTU to the default */
368 if (dev->change_mtu) {
369 dev->change_mtu(dev, 1500);
370 } else {
371 dev->mtu = 1500;
372 }
373 }
374 else {
375 printk(KERN_ERR DRV_NAME ": unable to remove non-existent slave %s for bond %s.\n",
376 ifname, bond->dev->name);
377 ret = -ENODEV;
378 }
379 goto out;
380 }
381
382err_no_cmd:
383 printk(KERN_ERR DRV_NAME ": no command found in slaves file for bond %s. Use +ifname or -ifname.\n", bond->dev->name);
384 ret = -EPERM;
385
386out:
387 return ret;
388}
389
390static CLASS_DEVICE_ATTR(slaves, S_IRUGO | S_IWUSR, bonding_show_slaves, bonding_store_slaves);
391
392/*
393 * Show and set the bonding mode. The bond interface must be down to
394 * change the mode.
395 */
396static ssize_t bonding_show_mode(struct class_device *cd, char *buf)
397{
398 struct bonding *bond = to_bond(cd);
399
400 return sprintf(buf, "%s %d\n",
401 bond_mode_tbl[bond->params.mode].modename,
402 bond->params.mode) + 1;
403}
404
405static ssize_t bonding_store_mode(struct class_device *cd, const char *buf, size_t count)
406{
407 int new_value, ret = count;
408 struct bonding *bond = to_bond(cd);
409
410 if (bond->dev->flags & IFF_UP) {
411 printk(KERN_ERR DRV_NAME
412 ": unable to update mode of %s because interface is up.\n",
413 bond->dev->name);
414 ret = -EPERM;
415 goto out;
416 }
417
418 new_value = bond_parse_parm((char *)buf, bond_mode_tbl);
419 if (new_value < 0) {
420 printk(KERN_ERR DRV_NAME
421 ": %s: Ignoring invalid mode value %.*s.\n",
422 bond->dev->name,
423 (int)strlen(buf) - 1, buf);
424 ret = -EINVAL;
425 goto out;
426 } else {
Jay Vosburgh8f903c72006-02-21 16:36:44 -0800427 if (bond->params.mode == BOND_MODE_8023AD)
428 bond_unset_master_3ad_flags(bond);
429
430 if (bond->params.mode == BOND_MODE_ALB)
431 bond_unset_master_alb_flags(bond);
432
Mitch Williamsb76cdba2005-11-09 10:36:41 -0800433 bond->params.mode = new_value;
434 bond_set_mode_ops(bond, bond->params.mode);
435 printk(KERN_INFO DRV_NAME ": %s: setting mode to %s (%d).\n",
436 bond->dev->name, bond_mode_tbl[new_value].modename, new_value);
437 }
438out:
439 return ret;
440}
441static CLASS_DEVICE_ATTR(mode, S_IRUGO | S_IWUSR, bonding_show_mode, bonding_store_mode);
442
443/*
444 * Show and set the bonding transmit hash method. The bond interface must be down to
445 * change the xmit hash policy.
446 */
447static ssize_t bonding_show_xmit_hash(struct class_device *cd, char *buf)
448{
449 int count;
450 struct bonding *bond = to_bond(cd);
451
452 if ((bond->params.mode != BOND_MODE_XOR) &&
453 (bond->params.mode != BOND_MODE_8023AD)) {
454 // Not Applicable
455 count = sprintf(buf, "NA\n") + 1;
456 } else {
457 count = sprintf(buf, "%s %d\n",
458 xmit_hashtype_tbl[bond->params.xmit_policy].modename,
459 bond->params.xmit_policy) + 1;
460 }
461
462 return count;
463}
464
465static ssize_t bonding_store_xmit_hash(struct class_device *cd, const char *buf, size_t count)
466{
467 int new_value, ret = count;
468 struct bonding *bond = to_bond(cd);
469
470 if (bond->dev->flags & IFF_UP) {
471 printk(KERN_ERR DRV_NAME
472 "%s: Interface is up. Unable to update xmit policy.\n",
473 bond->dev->name);
474 ret = -EPERM;
475 goto out;
476 }
477
478 if ((bond->params.mode != BOND_MODE_XOR) &&
479 (bond->params.mode != BOND_MODE_8023AD)) {
480 printk(KERN_ERR DRV_NAME
481 "%s: Transmit hash policy is irrelevant in this mode.\n",
482 bond->dev->name);
483 ret = -EPERM;
484 goto out;
485 }
486
487 new_value = bond_parse_parm((char *)buf, xmit_hashtype_tbl);
488 if (new_value < 0) {
489 printk(KERN_ERR DRV_NAME
490 ": %s: Ignoring invalid xmit hash policy value %.*s.\n",
491 bond->dev->name,
492 (int)strlen(buf) - 1, buf);
493 ret = -EINVAL;
494 goto out;
495 } else {
496 bond->params.xmit_policy = new_value;
497 bond_set_mode_ops(bond, bond->params.mode);
498 printk(KERN_INFO DRV_NAME ": %s: setting xmit hash policy to %s (%d).\n",
499 bond->dev->name, xmit_hashtype_tbl[new_value].modename, new_value);
500 }
501out:
502 return ret;
503}
504static CLASS_DEVICE_ATTR(xmit_hash_policy, S_IRUGO | S_IWUSR, bonding_show_xmit_hash, bonding_store_xmit_hash);
505
506/*
507 * Show and set the arp timer interval. There are two tricky bits
508 * here. First, if ARP monitoring is activated, then we must disable
509 * MII monitoring. Second, if the ARP timer isn't running, we must
510 * start it.
511 */
512static ssize_t bonding_show_arp_interval(struct class_device *cd, char *buf)
513{
514 struct bonding *bond = to_bond(cd);
515
516 return sprintf(buf, "%d\n", bond->params.arp_interval) + 1;
517}
518
519static ssize_t bonding_store_arp_interval(struct class_device *cd, const char *buf, size_t count)
520{
521 int new_value, ret = count;
522 struct bonding *bond = to_bond(cd);
523
524 if (sscanf(buf, "%d", &new_value) != 1) {
525 printk(KERN_ERR DRV_NAME
526 ": %s: no arp_interval value specified.\n",
527 bond->dev->name);
528 ret = -EINVAL;
529 goto out;
530 }
531 if (new_value < 0) {
532 printk(KERN_ERR DRV_NAME
533 ": %s: Invalid arp_interval value %d not in range 1-%d; rejected.\n",
534 bond->dev->name, new_value, INT_MAX);
535 ret = -EINVAL;
536 goto out;
537 }
538
539 printk(KERN_INFO DRV_NAME
540 ": %s: Setting ARP monitoring interval to %d.\n",
541 bond->dev->name, new_value);
542 bond->params.arp_interval = new_value;
543 if (bond->params.miimon) {
544 printk(KERN_INFO DRV_NAME
545 ": %s: ARP monitoring cannot be used with MII monitoring. "
546 "%s Disabling MII monitoring.\n",
547 bond->dev->name, bond->dev->name);
548 bond->params.miimon = 0;
549 /* Kill MII timer, else it brings bond's link down */
550 if (bond->arp_timer.function) {
551 printk(KERN_INFO DRV_NAME
552 ": %s: Kill MII timer, else it brings bond's link down...\n",
553 bond->dev->name);
554 del_timer_sync(&bond->mii_timer);
555 }
556 }
557 if (!bond->params.arp_targets[0]) {
558 printk(KERN_INFO DRV_NAME
559 ": %s: ARP monitoring has been set up, "
560 "but no ARP targets have been specified.\n",
561 bond->dev->name);
562 }
563 if (bond->dev->flags & IFF_UP) {
564 /* If the interface is up, we may need to fire off
565 * the ARP timer. If the interface is down, the
566 * timer will get fired off when the open function
567 * is called.
568 */
569 if (bond->arp_timer.function) {
570 /* The timer's already set up, so fire it off */
571 mod_timer(&bond->arp_timer, jiffies + 1);
572 } else {
573 /* Set up the timer. */
574 init_timer(&bond->arp_timer);
575 bond->arp_timer.expires = jiffies + 1;
576 bond->arp_timer.data =
577 (unsigned long) bond->dev;
578 if (bond->params.mode == BOND_MODE_ACTIVEBACKUP) {
579 bond->arp_timer.function =
580 (void *)
581 &bond_activebackup_arp_mon;
582 } else {
583 bond->arp_timer.function =
584 (void *)
585 &bond_loadbalance_arp_mon;
586 }
587 add_timer(&bond->arp_timer);
588 }
589 }
590
591out:
592 return ret;
593}
594static CLASS_DEVICE_ATTR(arp_interval, S_IRUGO | S_IWUSR , bonding_show_arp_interval, bonding_store_arp_interval);
595
596/*
597 * Show and set the arp targets.
598 */
599static ssize_t bonding_show_arp_targets(struct class_device *cd, char *buf)
600{
601 int i, res = 0;
602 struct bonding *bond = to_bond(cd);
603
604 for (i = 0; i < BOND_MAX_ARP_TARGETS; i++) {
605 if (bond->params.arp_targets[i])
606 res += sprintf(buf + res, "%u.%u.%u.%u ",
607 NIPQUAD(bond->params.arp_targets[i]));
608 }
609 if (res)
610 res--; /* eat the leftover space */
611 res += sprintf(buf + res, "\n");
612 res++;
613 return res;
614}
615
616static ssize_t bonding_store_arp_targets(struct class_device *cd, const char *buf, size_t count)
617{
618 u32 newtarget;
619 int i = 0, done = 0, ret = count;
620 struct bonding *bond = to_bond(cd);
621 u32 *targets;
622
623 targets = bond->params.arp_targets;
624 newtarget = in_aton(buf + 1);
625 /* look for adds */
626 if (buf[0] == '+') {
627 if ((newtarget == 0) || (newtarget == INADDR_BROADCAST)) {
628 printk(KERN_ERR DRV_NAME
629 ": %s: invalid ARP target %u.%u.%u.%u specified for addition\n",
630 bond->dev->name, NIPQUAD(newtarget));
631 ret = -EINVAL;
632 goto out;
633 }
634 /* look for an empty slot to put the target in, and check for dupes */
635 for (i = 0; (i < BOND_MAX_ARP_TARGETS); i++) {
636 if (targets[i] == newtarget) { /* duplicate */
637 printk(KERN_ERR DRV_NAME
638 ": %s: ARP target %u.%u.%u.%u is already present\n",
639 bond->dev->name, NIPQUAD(newtarget));
640 if (done)
641 targets[i] = 0;
642 ret = -EINVAL;
643 goto out;
644 }
645 if (targets[i] == 0 && !done) {
646 printk(KERN_INFO DRV_NAME
647 ": %s: adding ARP target %d.%d.%d.%d.\n",
648 bond->dev->name, NIPQUAD(newtarget));
649 done = 1;
650 targets[i] = newtarget;
651 }
652 }
653 if (!done) {
654 printk(KERN_ERR DRV_NAME
655 ": %s: ARP target table is full!\n",
656 bond->dev->name);
657 ret = -EINVAL;
658 goto out;
659 }
660
661 }
662 else if (buf[0] == '-') {
663 if ((newtarget == 0) || (newtarget == INADDR_BROADCAST)) {
664 printk(KERN_ERR DRV_NAME
665 ": %s: invalid ARP target %d.%d.%d.%d specified for removal\n",
666 bond->dev->name, NIPQUAD(newtarget));
667 ret = -EINVAL;
668 goto out;
669 }
670
671 for (i = 0; (i < BOND_MAX_ARP_TARGETS); i++) {
672 if (targets[i] == newtarget) {
673 printk(KERN_INFO DRV_NAME
674 ": %s: removing ARP target %d.%d.%d.%d.\n",
675 bond->dev->name, NIPQUAD(newtarget));
676 targets[i] = 0;
677 done = 1;
678 }
679 }
680 if (!done) {
681 printk(KERN_INFO DRV_NAME
682 ": %s: unable to remove nonexistent ARP target %d.%d.%d.%d.\n",
683 bond->dev->name, NIPQUAD(newtarget));
684 ret = -EINVAL;
685 goto out;
686 }
687 }
688 else {
689 printk(KERN_ERR DRV_NAME ": no command found in arp_ip_targets file for bond %s. Use +<addr> or -<addr>.\n",
690 bond->dev->name);
691 ret = -EPERM;
692 goto out;
693 }
694
695out:
696 return ret;
697}
698static CLASS_DEVICE_ATTR(arp_ip_target, S_IRUGO | S_IWUSR , bonding_show_arp_targets, bonding_store_arp_targets);
699
700/*
701 * Show and set the up and down delays. These must be multiples of the
702 * MII monitoring value, and are stored internally as the multiplier.
703 * Thus, we must translate to MS for the real world.
704 */
705static ssize_t bonding_show_downdelay(struct class_device *cd, char *buf)
706{
707 struct bonding *bond = to_bond(cd);
708
709 return sprintf(buf, "%d\n", bond->params.downdelay * bond->params.miimon) + 1;
710}
711
712static ssize_t bonding_store_downdelay(struct class_device *cd, const char *buf, size_t count)
713{
714 int new_value, ret = count;
715 struct bonding *bond = to_bond(cd);
716
717 if (!(bond->params.miimon)) {
718 printk(KERN_ERR DRV_NAME
719 ": %s: Unable to set down delay as MII monitoring is disabled\n",
720 bond->dev->name);
721 ret = -EPERM;
722 goto out;
723 }
724
725 if (sscanf(buf, "%d", &new_value) != 1) {
726 printk(KERN_ERR DRV_NAME
727 ": %s: no down delay value specified.\n",
728 bond->dev->name);
729 ret = -EINVAL;
730 goto out;
731 }
732 if (new_value < 0) {
733 printk(KERN_ERR DRV_NAME
734 ": %s: Invalid down delay value %d not in range %d-%d; rejected.\n",
735 bond->dev->name, new_value, 1, INT_MAX);
736 ret = -EINVAL;
737 goto out;
738 } else {
739 if ((new_value % bond->params.miimon) != 0) {
740 printk(KERN_WARNING DRV_NAME
741 ": %s: Warning: down delay (%d) is not a multiple "
742 "of miimon (%d), delay rounded to %d ms\n",
743 bond->dev->name, new_value, bond->params.miimon,
744 (new_value / bond->params.miimon) *
745 bond->params.miimon);
746 }
747 bond->params.downdelay = new_value / bond->params.miimon;
748 printk(KERN_INFO DRV_NAME ": %s: Setting down delay to %d.\n",
749 bond->dev->name, bond->params.downdelay * bond->params.miimon);
750
751 }
752
753out:
754 return ret;
755}
756static CLASS_DEVICE_ATTR(downdelay, S_IRUGO | S_IWUSR , bonding_show_downdelay, bonding_store_downdelay);
757
758static ssize_t bonding_show_updelay(struct class_device *cd, char *buf)
759{
760 struct bonding *bond = to_bond(cd);
761
762 return sprintf(buf, "%d\n", bond->params.updelay * bond->params.miimon) + 1;
763
764}
765
766static ssize_t bonding_store_updelay(struct class_device *cd, const char *buf, size_t count)
767{
768 int new_value, ret = count;
769 struct bonding *bond = to_bond(cd);
770
771 if (!(bond->params.miimon)) {
772 printk(KERN_ERR DRV_NAME
773 ": %s: Unable to set up delay as MII monitoring is disabled\n",
774 bond->dev->name);
775 ret = -EPERM;
776 goto out;
777 }
778
779 if (sscanf(buf, "%d", &new_value) != 1) {
780 printk(KERN_ERR DRV_NAME
781 ": %s: no up delay value specified.\n",
782 bond->dev->name);
783 ret = -EINVAL;
784 goto out;
785 }
786 if (new_value < 0) {
787 printk(KERN_ERR DRV_NAME
788 ": %s: Invalid down delay value %d not in range %d-%d; rejected.\n",
789 bond->dev->name, new_value, 1, INT_MAX);
790 ret = -EINVAL;
791 goto out;
792 } else {
793 if ((new_value % bond->params.miimon) != 0) {
794 printk(KERN_WARNING DRV_NAME
795 ": %s: Warning: up delay (%d) is not a multiple "
796 "of miimon (%d), updelay rounded to %d ms\n",
797 bond->dev->name, new_value, bond->params.miimon,
798 (new_value / bond->params.miimon) *
799 bond->params.miimon);
800 }
801 bond->params.updelay = new_value / bond->params.miimon;
802 printk(KERN_INFO DRV_NAME ": %s: Setting up delay to %d.\n",
803 bond->dev->name, bond->params.updelay * bond->params.miimon);
804
805 }
806
807out:
808 return ret;
809}
810static CLASS_DEVICE_ATTR(updelay, S_IRUGO | S_IWUSR , bonding_show_updelay, bonding_store_updelay);
811
812/*
813 * Show and set the LACP interval. Interface must be down, and the mode
814 * must be set to 802.3ad mode.
815 */
816static ssize_t bonding_show_lacp(struct class_device *cd, char *buf)
817{
818 struct bonding *bond = to_bond(cd);
819
820 return sprintf(buf, "%s %d\n",
821 bond_lacp_tbl[bond->params.lacp_fast].modename,
822 bond->params.lacp_fast) + 1;
823}
824
825static ssize_t bonding_store_lacp(struct class_device *cd, const char *buf, size_t count)
826{
827 int new_value, ret = count;
828 struct bonding *bond = to_bond(cd);
829
830 if (bond->dev->flags & IFF_UP) {
831 printk(KERN_ERR DRV_NAME
832 ": %s: Unable to update LACP rate because interface is up.\n",
833 bond->dev->name);
834 ret = -EPERM;
835 goto out;
836 }
837
838 if (bond->params.mode != BOND_MODE_8023AD) {
839 printk(KERN_ERR DRV_NAME
840 ": %s: Unable to update LACP rate because bond is not in 802.3ad mode.\n",
841 bond->dev->name);
842 ret = -EPERM;
843 goto out;
844 }
845
846 new_value = bond_parse_parm((char *)buf, bond_lacp_tbl);
847
848 if ((new_value == 1) || (new_value == 0)) {
849 bond->params.lacp_fast = new_value;
850 printk(KERN_INFO DRV_NAME
851 ": %s: Setting LACP rate to %s (%d).\n",
852 bond->dev->name, bond_lacp_tbl[new_value].modename, new_value);
853 } else {
854 printk(KERN_ERR DRV_NAME
855 ": %s: Ignoring invalid LACP rate value %.*s.\n",
856 bond->dev->name, (int)strlen(buf) - 1, buf);
857 ret = -EINVAL;
858 }
859out:
860 return ret;
861}
862static CLASS_DEVICE_ATTR(lacp_rate, S_IRUGO | S_IWUSR, bonding_show_lacp, bonding_store_lacp);
863
864/*
865 * Show and set the MII monitor interval. There are two tricky bits
866 * here. First, if MII monitoring is activated, then we must disable
867 * ARP monitoring. Second, if the timer isn't running, we must
868 * start it.
869 */
870static ssize_t bonding_show_miimon(struct class_device *cd, char *buf)
871{
872 struct bonding *bond = to_bond(cd);
873
874 return sprintf(buf, "%d\n", bond->params.miimon) + 1;
875}
876
877static ssize_t bonding_store_miimon(struct class_device *cd, const char *buf, size_t count)
878{
879 int new_value, ret = count;
880 struct bonding *bond = to_bond(cd);
881
882 if (sscanf(buf, "%d", &new_value) != 1) {
883 printk(KERN_ERR DRV_NAME
884 ": %s: no miimon value specified.\n",
885 bond->dev->name);
886 ret = -EINVAL;
887 goto out;
888 }
889 if (new_value < 0) {
890 printk(KERN_ERR DRV_NAME
891 ": %s: Invalid miimon value %d not in range %d-%d; rejected.\n",
892 bond->dev->name, new_value, 1, INT_MAX);
893 ret = -EINVAL;
894 goto out;
895 } else {
896 printk(KERN_INFO DRV_NAME
897 ": %s: Setting MII monitoring interval to %d.\n",
898 bond->dev->name, new_value);
899 bond->params.miimon = new_value;
900 if(bond->params.updelay)
901 printk(KERN_INFO DRV_NAME
902 ": %s: Note: Updating updelay (to %d) "
903 "since it is a multiple of the miimon value.\n",
904 bond->dev->name,
905 bond->params.updelay * bond->params.miimon);
906 if(bond->params.downdelay)
907 printk(KERN_INFO DRV_NAME
908 ": %s: Note: Updating downdelay (to %d) "
909 "since it is a multiple of the miimon value.\n",
910 bond->dev->name,
911 bond->params.downdelay * bond->params.miimon);
912 if (bond->params.arp_interval) {
913 printk(KERN_INFO DRV_NAME
914 ": %s: MII monitoring cannot be used with "
915 "ARP monitoring. Disabling ARP monitoring...\n",
916 bond->dev->name);
917 bond->params.arp_interval = 0;
918 /* Kill ARP timer, else it brings bond's link down */
919 if (bond->mii_timer.function) {
920 printk(KERN_INFO DRV_NAME
921 ": %s: Kill ARP timer, else it brings bond's link down...\n",
922 bond->dev->name);
923 del_timer_sync(&bond->arp_timer);
924 }
925 }
926
927 if (bond->dev->flags & IFF_UP) {
928 /* If the interface is up, we may need to fire off
929 * the MII timer. If the interface is down, the
930 * timer will get fired off when the open function
931 * is called.
932 */
933 if (bond->mii_timer.function) {
934 /* The timer's already set up, so fire it off */
935 mod_timer(&bond->mii_timer, jiffies + 1);
936 } else {
937 /* Set up the timer. */
938 init_timer(&bond->mii_timer);
939 bond->mii_timer.expires = jiffies + 1;
940 bond->mii_timer.data =
941 (unsigned long) bond->dev;
942 bond->mii_timer.function =
943 (void *) &bond_mii_monitor;
944 add_timer(&bond->mii_timer);
945 }
946 }
947 }
948out:
949 return ret;
950}
951static CLASS_DEVICE_ATTR(miimon, S_IRUGO | S_IWUSR, bonding_show_miimon, bonding_store_miimon);
952
953/*
954 * Show and set the primary slave. The store function is much
955 * simpler than bonding_store_slaves function because it only needs to
956 * handle one interface name.
957 * The bond must be a mode that supports a primary for this be
958 * set.
959 */
960static ssize_t bonding_show_primary(struct class_device *cd, char *buf)
961{
962 int count = 0;
963 struct bonding *bond = to_bond(cd);
964
965 if (bond->primary_slave)
966 count = sprintf(buf, "%s\n", bond->primary_slave->dev->name) + 1;
967 else
968 count = sprintf(buf, "\n") + 1;
969
970 return count;
971}
972
973static ssize_t bonding_store_primary(struct class_device *cd, const char *buf, size_t count)
974{
975 int i;
976 struct slave *slave;
977 struct bonding *bond = to_bond(cd);
978
979 write_lock_bh(&bond->lock);
980 if (!USES_PRIMARY(bond->params.mode)) {
981 printk(KERN_INFO DRV_NAME
982 ": %s: Unable to set primary slave; %s is in mode %d\n",
983 bond->dev->name, bond->dev->name, bond->params.mode);
984 } else {
985 bond_for_each_slave(bond, slave, i) {
986 if (strnicmp
987 (slave->dev->name, buf,
988 strlen(slave->dev->name)) == 0) {
989 printk(KERN_INFO DRV_NAME
990 ": %s: Setting %s as primary slave.\n",
991 bond->dev->name, slave->dev->name);
992 bond->primary_slave = slave;
993 bond_select_active_slave(bond);
994 goto out;
995 }
996 }
997
998 /* if we got here, then we didn't match the name of any slave */
999
1000 if (strlen(buf) == 0 || buf[0] == '\n') {
1001 printk(KERN_INFO DRV_NAME
1002 ": %s: Setting primary slave to None.\n",
1003 bond->dev->name);
Luiz Fernando Capitulino3418db72006-02-01 00:54:34 -08001004 bond->primary_slave = NULL;
Mitch Williamsb76cdba2005-11-09 10:36:41 -08001005 bond_select_active_slave(bond);
1006 } else {
1007 printk(KERN_INFO DRV_NAME
1008 ": %s: Unable to set %.*s as primary slave as it is not a slave.\n",
1009 bond->dev->name, (int)strlen(buf) - 1, buf);
1010 }
1011 }
1012out:
1013 write_unlock_bh(&bond->lock);
1014 return count;
1015}
1016static CLASS_DEVICE_ATTR(primary, S_IRUGO | S_IWUSR, bonding_show_primary, bonding_store_primary);
1017
1018/*
1019 * Show and set the use_carrier flag.
1020 */
1021static ssize_t bonding_show_carrier(struct class_device *cd, char *buf)
1022{
1023 struct bonding *bond = to_bond(cd);
1024
1025 return sprintf(buf, "%d\n", bond->params.use_carrier) + 1;
1026}
1027
1028static ssize_t bonding_store_carrier(struct class_device *cd, const char *buf, size_t count)
1029{
1030 int new_value, ret = count;
1031 struct bonding *bond = to_bond(cd);
1032
1033
1034 if (sscanf(buf, "%d", &new_value) != 1) {
1035 printk(KERN_ERR DRV_NAME
1036 ": %s: no use_carrier value specified.\n",
1037 bond->dev->name);
1038 ret = -EINVAL;
1039 goto out;
1040 }
1041 if ((new_value == 0) || (new_value == 1)) {
1042 bond->params.use_carrier = new_value;
1043 printk(KERN_INFO DRV_NAME ": %s: Setting use_carrier to %d.\n",
1044 bond->dev->name, new_value);
1045 } else {
1046 printk(KERN_INFO DRV_NAME
1047 ": %s: Ignoring invalid use_carrier value %d.\n",
1048 bond->dev->name, new_value);
1049 }
1050out:
1051 return count;
1052}
1053static CLASS_DEVICE_ATTR(use_carrier, S_IRUGO | S_IWUSR, bonding_show_carrier, bonding_store_carrier);
1054
1055
1056/*
1057 * Show and set currently active_slave.
1058 */
1059static ssize_t bonding_show_active_slave(struct class_device *cd, char *buf)
1060{
1061 struct slave *curr;
1062 struct bonding *bond = to_bond(cd);
1063 int count;
1064
1065
1066 read_lock(&bond->curr_slave_lock);
1067 curr = bond->curr_active_slave;
1068 read_unlock(&bond->curr_slave_lock);
1069
1070 if (USES_PRIMARY(bond->params.mode) && curr)
1071 count = sprintf(buf, "%s\n", curr->dev->name) + 1;
1072 else
1073 count = sprintf(buf, "\n") + 1;
1074 return count;
1075}
1076
1077static ssize_t bonding_store_active_slave(struct class_device *cd, const char *buf, size_t count)
1078{
1079 int i;
1080 struct slave *slave;
1081 struct slave *old_active = NULL;
1082 struct slave *new_active = NULL;
1083 struct bonding *bond = to_bond(cd);
1084
1085 write_lock_bh(&bond->lock);
1086 if (!USES_PRIMARY(bond->params.mode)) {
1087 printk(KERN_INFO DRV_NAME
1088 ": %s: Unable to change active slave; %s is in mode %d\n",
1089 bond->dev->name, bond->dev->name, bond->params.mode);
1090 } else {
1091 bond_for_each_slave(bond, slave, i) {
1092 if (strnicmp
1093 (slave->dev->name, buf,
1094 strlen(slave->dev->name)) == 0) {
1095 old_active = bond->curr_active_slave;
1096 new_active = slave;
1097 if (new_active && (new_active == old_active)) {
1098 /* do nothing */
1099 printk(KERN_INFO DRV_NAME
1100 ": %s: %s is already the current active slave.\n",
1101 bond->dev->name, slave->dev->name);
1102 goto out;
1103 }
1104 else {
1105 if ((new_active) &&
1106 (old_active) &&
1107 (new_active->link == BOND_LINK_UP) &&
1108 IS_UP(new_active->dev)) {
1109 printk(KERN_INFO DRV_NAME
1110 ": %s: Setting %s as active slave.\n",
1111 bond->dev->name, slave->dev->name);
1112 bond_change_active_slave(bond, new_active);
1113 }
1114 else {
1115 printk(KERN_INFO DRV_NAME
1116 ": %s: Could not set %s as active slave; "
1117 "either %s is down or the link is down.\n",
1118 bond->dev->name, slave->dev->name,
1119 slave->dev->name);
1120 }
1121 goto out;
1122 }
1123 }
1124 }
1125
1126 /* if we got here, then we didn't match the name of any slave */
1127
1128 if (strlen(buf) == 0 || buf[0] == '\n') {
1129 printk(KERN_INFO DRV_NAME
1130 ": %s: Setting active slave to None.\n",
1131 bond->dev->name);
Luiz Fernando Capitulino3418db72006-02-01 00:54:34 -08001132 bond->primary_slave = NULL;
Mitch Williamsb76cdba2005-11-09 10:36:41 -08001133 bond_select_active_slave(bond);
1134 } else {
1135 printk(KERN_INFO DRV_NAME
1136 ": %s: Unable to set %.*s as active slave as it is not a slave.\n",
1137 bond->dev->name, (int)strlen(buf) - 1, buf);
1138 }
1139 }
1140out:
1141 write_unlock_bh(&bond->lock);
1142 return count;
1143
1144}
1145static CLASS_DEVICE_ATTR(active_slave, S_IRUGO | S_IWUSR, bonding_show_active_slave, bonding_store_active_slave);
1146
1147
1148/*
1149 * Show link status of the bond interface.
1150 */
1151static ssize_t bonding_show_mii_status(struct class_device *cd, char *buf)
1152{
1153 struct slave *curr;
1154 struct bonding *bond = to_bond(cd);
1155
1156 read_lock(&bond->curr_slave_lock);
1157 curr = bond->curr_active_slave;
1158 read_unlock(&bond->curr_slave_lock);
1159
1160 return sprintf(buf, "%s\n", (curr) ? "up" : "down") + 1;
1161}
1162static CLASS_DEVICE_ATTR(mii_status, S_IRUGO, bonding_show_mii_status, NULL);
1163
1164
1165/*
1166 * Show current 802.3ad aggregator ID.
1167 */
1168static ssize_t bonding_show_ad_aggregator(struct class_device *cd, char *buf)
1169{
1170 int count = 0;
1171 struct bonding *bond = to_bond(cd);
1172
1173 if (bond->params.mode == BOND_MODE_8023AD) {
1174 struct ad_info ad_info;
1175 count = sprintf(buf, "%d\n", (bond_3ad_get_active_agg_info(bond, &ad_info)) ? 0 : ad_info.aggregator_id) + 1;
1176 }
1177 else
1178 count = sprintf(buf, "\n") + 1;
1179
1180 return count;
1181}
1182static CLASS_DEVICE_ATTR(ad_aggregator, S_IRUGO, bonding_show_ad_aggregator, NULL);
1183
1184
1185/*
1186 * Show number of active 802.3ad ports.
1187 */
1188static ssize_t bonding_show_ad_num_ports(struct class_device *cd, char *buf)
1189{
1190 int count = 0;
1191 struct bonding *bond = to_bond(cd);
1192
1193 if (bond->params.mode == BOND_MODE_8023AD) {
1194 struct ad_info ad_info;
1195 count = sprintf(buf, "%d\n", (bond_3ad_get_active_agg_info(bond, &ad_info)) ? 0: ad_info.ports) + 1;
1196 }
1197 else
1198 count = sprintf(buf, "\n") + 1;
1199
1200 return count;
1201}
1202static CLASS_DEVICE_ATTR(ad_num_ports, S_IRUGO, bonding_show_ad_num_ports, NULL);
1203
1204
1205/*
1206 * Show current 802.3ad actor key.
1207 */
1208static ssize_t bonding_show_ad_actor_key(struct class_device *cd, char *buf)
1209{
1210 int count = 0;
1211 struct bonding *bond = to_bond(cd);
1212
1213 if (bond->params.mode == BOND_MODE_8023AD) {
1214 struct ad_info ad_info;
1215 count = sprintf(buf, "%d\n", (bond_3ad_get_active_agg_info(bond, &ad_info)) ? 0 : ad_info.actor_key) + 1;
1216 }
1217 else
1218 count = sprintf(buf, "\n") + 1;
1219
1220 return count;
1221}
1222static CLASS_DEVICE_ATTR(ad_actor_key, S_IRUGO, bonding_show_ad_actor_key, NULL);
1223
1224
1225/*
1226 * Show current 802.3ad partner key.
1227 */
1228static ssize_t bonding_show_ad_partner_key(struct class_device *cd, char *buf)
1229{
1230 int count = 0;
1231 struct bonding *bond = to_bond(cd);
1232
1233 if (bond->params.mode == BOND_MODE_8023AD) {
1234 struct ad_info ad_info;
1235 count = sprintf(buf, "%d\n", (bond_3ad_get_active_agg_info(bond, &ad_info)) ? 0 : ad_info.partner_key) + 1;
1236 }
1237 else
1238 count = sprintf(buf, "\n") + 1;
1239
1240 return count;
1241}
1242static CLASS_DEVICE_ATTR(ad_partner_key, S_IRUGO, bonding_show_ad_partner_key, NULL);
1243
1244
1245/*
1246 * Show current 802.3ad partner mac.
1247 */
1248static ssize_t bonding_show_ad_partner_mac(struct class_device *cd, char *buf)
1249{
1250 int count = 0;
1251 struct bonding *bond = to_bond(cd);
1252
1253 if (bond->params.mode == BOND_MODE_8023AD) {
1254 struct ad_info ad_info;
1255 if (!bond_3ad_get_active_agg_info(bond, &ad_info)) {
1256 count = sprintf(buf,"%02x:%02x:%02x:%02x:%02x:%02x\n",
1257 ad_info.partner_system[0],
1258 ad_info.partner_system[1],
1259 ad_info.partner_system[2],
1260 ad_info.partner_system[3],
1261 ad_info.partner_system[4],
1262 ad_info.partner_system[5]) + 1;
1263 }
1264 }
1265 else
1266 count = sprintf(buf, "\n") + 1;
1267
1268 return count;
1269}
1270static CLASS_DEVICE_ATTR(ad_partner_mac, S_IRUGO, bonding_show_ad_partner_mac, NULL);
1271
1272
1273
1274static struct attribute *per_bond_attrs[] = {
1275 &class_device_attr_slaves.attr,
1276 &class_device_attr_mode.attr,
1277 &class_device_attr_arp_interval.attr,
1278 &class_device_attr_arp_ip_target.attr,
1279 &class_device_attr_downdelay.attr,
1280 &class_device_attr_updelay.attr,
1281 &class_device_attr_lacp_rate.attr,
1282 &class_device_attr_xmit_hash_policy.attr,
1283 &class_device_attr_miimon.attr,
1284 &class_device_attr_primary.attr,
1285 &class_device_attr_use_carrier.attr,
1286 &class_device_attr_active_slave.attr,
1287 &class_device_attr_mii_status.attr,
1288 &class_device_attr_ad_aggregator.attr,
1289 &class_device_attr_ad_num_ports.attr,
1290 &class_device_attr_ad_actor_key.attr,
1291 &class_device_attr_ad_partner_key.attr,
1292 &class_device_attr_ad_partner_mac.attr,
1293 NULL,
1294};
1295
1296static struct attribute_group bonding_group = {
1297 .name = "bonding",
1298 .attrs = per_bond_attrs,
1299};
1300
1301/*
1302 * Initialize sysfs. This sets up the bonding_masters file in
1303 * /sys/class/net.
1304 */
1305int bond_create_sysfs(void)
1306{
1307 int ret = 0;
1308 struct bonding *firstbond;
1309
1310 init_rwsem(&bonding_rwsem);
1311
1312 /* get the netdev class pointer */
1313 firstbond = container_of(bond_dev_list.next, struct bonding, bond_list);
1314 if (!firstbond)
1315 return -ENODEV;
1316
1317 netdev_class = firstbond->dev->class_dev.class;
1318 if (!netdev_class)
1319 return -ENODEV;
1320
1321 ret = class_create_file(netdev_class, &class_attr_bonding_masters);
1322
1323 return ret;
1324
1325}
1326
1327/*
1328 * Remove /sys/class/net/bonding_masters.
1329 */
1330void bond_destroy_sysfs(void)
1331{
1332 if (netdev_class)
1333 class_remove_file(netdev_class, &class_attr_bonding_masters);
1334}
1335
1336/*
1337 * Initialize sysfs for each bond. This sets up and registers
1338 * the 'bondctl' directory for each individual bond under /sys/class/net.
1339 */
1340int bond_create_sysfs_entry(struct bonding *bond)
1341{
1342 struct net_device *dev = bond->dev;
1343 int err;
1344
1345 err = sysfs_create_group(&(dev->class_dev.kobj), &bonding_group);
1346 if (err) {
1347 printk(KERN_EMERG "eek! didn't create group!\n");
1348 }
1349
1350 if (expected_refcount < 1)
1351 expected_refcount = atomic_read(&bond->dev->class_dev.kobj.kref.refcount);
1352
1353 return err;
1354}
1355/*
1356 * Remove sysfs entries for each bond.
1357 */
1358void bond_destroy_sysfs_entry(struct bonding *bond)
1359{
1360 struct net_device *dev = bond->dev;
1361
1362 sysfs_remove_group(&(dev->class_dev.kobj), &bonding_group);
1363}
1364