blob: b9048dc46b1a11c4939fdaf463d37c6114745641 [file] [log] [blame]
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -07001/*
Lai Jiangshan47c59802008-10-18 20:28:07 -07002 * device_cgroup.c - device cgroup subsystem
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -07003 *
4 * Copyright 2007 IBM Corp
5 */
6
7#include <linux/device_cgroup.h>
8#include <linux/cgroup.h>
9#include <linux/ctype.h>
10#include <linux/list.h>
11#include <linux/uaccess.h>
Serge E. Hallyn29486df2008-04-29 01:00:14 -070012#include <linux/seq_file.h>
Tejun Heo5a0e3ad2010-03-24 17:04:11 +090013#include <linux/slab.h>
Lai Jiangshan47c59802008-10-18 20:28:07 -070014#include <linux/rcupdate.h>
Li Zefanb4046f02009-04-02 16:57:32 -070015#include <linux/mutex.h>
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070016
17#define ACC_MKNOD 1
18#define ACC_READ 2
19#define ACC_WRITE 4
20#define ACC_MASK (ACC_MKNOD | ACC_READ | ACC_WRITE)
21
22#define DEV_BLOCK 1
23#define DEV_CHAR 2
24#define DEV_ALL 4 /* this represents all devices */
25
Li Zefanb4046f02009-04-02 16:57:32 -070026static DEFINE_MUTEX(devcgroup_mutex);
27
Aristeu Rozanskic39a2a32013-02-15 11:55:45 -050028enum devcg_behavior {
29 DEVCG_DEFAULT_NONE,
30 DEVCG_DEFAULT_ALLOW,
31 DEVCG_DEFAULT_DENY,
32};
33
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070034/*
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -070035 * exception list locking rules:
Li Zefanb4046f02009-04-02 16:57:32 -070036 * hold devcgroup_mutex for update/read.
Lai Jiangshan47c59802008-10-18 20:28:07 -070037 * hold rcu_read_lock() for read.
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070038 */
39
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -070040struct dev_exception_item {
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070041 u32 major, minor;
42 short type;
43 short access;
44 struct list_head list;
Pavel Emelyanov4efd1a12008-07-25 01:47:07 -070045 struct rcu_head rcu;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070046};
47
48struct dev_cgroup {
49 struct cgroup_subsys_state css;
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -070050 struct list_head exceptions;
Aristeu Rozanskic39a2a32013-02-15 11:55:45 -050051 enum devcg_behavior behavior;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070052};
53
Pavel Emelyanovb66862f2008-06-05 22:46:24 -070054static inline struct dev_cgroup *css_to_devcgroup(struct cgroup_subsys_state *s)
55{
Tejun Heoa7c6d552013-08-08 20:11:23 -040056 return s ? container_of(s, struct dev_cgroup, css) : NULL;
Pavel Emelyanovb66862f2008-06-05 22:46:24 -070057}
58
Paul Menagef92523e2008-07-25 01:47:03 -070059static inline struct dev_cgroup *task_devcgroup(struct task_struct *task)
60{
Tejun Heo073219e2014-02-08 10:36:58 -050061 return css_to_devcgroup(task_css(task, devices_cgrp_id));
Paul Menagef92523e2008-07-25 01:47:03 -070062}
63
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070064/*
Li Zefanb4046f02009-04-02 16:57:32 -070065 * called under devcgroup_mutex
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070066 */
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -070067static int dev_exceptions_copy(struct list_head *dest, struct list_head *orig)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070068{
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -070069 struct dev_exception_item *ex, *tmp, *new;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070070
Tejun Heo4b1c7842012-11-06 09:16:53 -080071 lockdep_assert_held(&devcgroup_mutex);
72
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -070073 list_for_each_entry(ex, orig, list) {
74 new = kmemdup(ex, sizeof(*ex), GFP_KERNEL);
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070075 if (!new)
76 goto free_and_exit;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070077 list_add_tail(&new->list, dest);
78 }
79
80 return 0;
81
82free_and_exit:
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -070083 list_for_each_entry_safe(ex, tmp, dest, list) {
84 list_del(&ex->list);
85 kfree(ex);
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070086 }
87 return -ENOMEM;
88}
89
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070090/*
Li Zefanb4046f02009-04-02 16:57:32 -070091 * called under devcgroup_mutex
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070092 */
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -070093static int dev_exception_add(struct dev_cgroup *dev_cgroup,
94 struct dev_exception_item *ex)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070095{
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -070096 struct dev_exception_item *excopy, *walk;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -070097
Tejun Heo4b1c7842012-11-06 09:16:53 -080098 lockdep_assert_held(&devcgroup_mutex);
99
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700100 excopy = kmemdup(ex, sizeof(*ex), GFP_KERNEL);
101 if (!excopy)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700102 return -ENOMEM;
103
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700104 list_for_each_entry(walk, &dev_cgroup->exceptions, list) {
105 if (walk->type != ex->type)
Pavel Emelyanovd1ee2972008-06-05 22:46:28 -0700106 continue;
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700107 if (walk->major != ex->major)
Pavel Emelyanovd1ee2972008-06-05 22:46:28 -0700108 continue;
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700109 if (walk->minor != ex->minor)
Pavel Emelyanovd1ee2972008-06-05 22:46:28 -0700110 continue;
111
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700112 walk->access |= ex->access;
113 kfree(excopy);
114 excopy = NULL;
Pavel Emelyanovd1ee2972008-06-05 22:46:28 -0700115 }
116
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700117 if (excopy != NULL)
118 list_add_tail_rcu(&excopy->list, &dev_cgroup->exceptions);
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700119 return 0;
120}
121
122/*
Li Zefanb4046f02009-04-02 16:57:32 -0700123 * called under devcgroup_mutex
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700124 */
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700125static void dev_exception_rm(struct dev_cgroup *dev_cgroup,
126 struct dev_exception_item *ex)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700127{
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700128 struct dev_exception_item *walk, *tmp;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700129
Tejun Heo4b1c7842012-11-06 09:16:53 -0800130 lockdep_assert_held(&devcgroup_mutex);
131
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700132 list_for_each_entry_safe(walk, tmp, &dev_cgroup->exceptions, list) {
133 if (walk->type != ex->type)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700134 continue;
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700135 if (walk->major != ex->major)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700136 continue;
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700137 if (walk->minor != ex->minor)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700138 continue;
139
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700140 walk->access &= ~ex->access;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700141 if (!walk->access) {
Pavel Emelyanov4efd1a12008-07-25 01:47:07 -0700142 list_del_rcu(&walk->list);
Lai Jiangshan6034f7e2011-03-15 18:07:57 +0800143 kfree_rcu(walk, rcu);
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700144 }
145 }
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700146}
147
Jerry Snitselaar53eb8c82013-02-21 16:41:31 -0800148static void __dev_exception_clean(struct dev_cgroup *dev_cgroup)
149{
150 struct dev_exception_item *ex, *tmp;
151
152 list_for_each_entry_safe(ex, tmp, &dev_cgroup->exceptions, list) {
153 list_del_rcu(&ex->list);
154 kfree_rcu(ex, rcu);
155 }
156}
157
Aristeu Rozanski868539a2012-10-04 17:15:15 -0700158/**
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700159 * dev_exception_clean - frees all entries of the exception list
160 * @dev_cgroup: dev_cgroup with the exception list to be cleaned
Aristeu Rozanski868539a2012-10-04 17:15:15 -0700161 *
162 * called under devcgroup_mutex
163 */
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700164static void dev_exception_clean(struct dev_cgroup *dev_cgroup)
Aristeu Rozanski868539a2012-10-04 17:15:15 -0700165{
Tejun Heo4b1c7842012-11-06 09:16:53 -0800166 lockdep_assert_held(&devcgroup_mutex);
167
Jerry Snitselaar53eb8c82013-02-21 16:41:31 -0800168 __dev_exception_clean(dev_cgroup);
Aristeu Rozanski868539a2012-10-04 17:15:15 -0700169}
170
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500171static inline bool is_devcg_online(const struct dev_cgroup *devcg)
172{
173 return (devcg->behavior != DEVCG_DEFAULT_NONE);
174}
175
Aristeu Rozanski1909554c2013-02-15 11:55:46 -0500176/**
177 * devcgroup_online - initializes devcgroup's behavior and exceptions based on
178 * parent's
Tejun Heoeb954192013-08-08 20:11:23 -0400179 * @css: css getting online
Aristeu Rozanski1909554c2013-02-15 11:55:46 -0500180 * returns 0 in case of success, error code otherwise
181 */
Tejun Heoeb954192013-08-08 20:11:23 -0400182static int devcgroup_online(struct cgroup_subsys_state *css)
Aristeu Rozanski1909554c2013-02-15 11:55:46 -0500183{
Tejun Heoeb954192013-08-08 20:11:23 -0400184 struct dev_cgroup *dev_cgroup = css_to_devcgroup(css);
185 struct dev_cgroup *parent_dev_cgroup = css_to_devcgroup(css_parent(css));
Aristeu Rozanski1909554c2013-02-15 11:55:46 -0500186 int ret = 0;
187
188 mutex_lock(&devcgroup_mutex);
Aristeu Rozanski1909554c2013-02-15 11:55:46 -0500189
190 if (parent_dev_cgroup == NULL)
191 dev_cgroup->behavior = DEVCG_DEFAULT_ALLOW;
192 else {
193 ret = dev_exceptions_copy(&dev_cgroup->exceptions,
194 &parent_dev_cgroup->exceptions);
195 if (!ret)
196 dev_cgroup->behavior = parent_dev_cgroup->behavior;
197 }
198 mutex_unlock(&devcgroup_mutex);
199
200 return ret;
201}
202
Tejun Heoeb954192013-08-08 20:11:23 -0400203static void devcgroup_offline(struct cgroup_subsys_state *css)
Aristeu Rozanski1909554c2013-02-15 11:55:46 -0500204{
Tejun Heoeb954192013-08-08 20:11:23 -0400205 struct dev_cgroup *dev_cgroup = css_to_devcgroup(css);
Aristeu Rozanski1909554c2013-02-15 11:55:46 -0500206
207 mutex_lock(&devcgroup_mutex);
208 dev_cgroup->behavior = DEVCG_DEFAULT_NONE;
209 mutex_unlock(&devcgroup_mutex);
210}
211
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700212/*
213 * called from kernel/cgroup.c with cgroup_lock() held.
214 */
Tejun Heoeb954192013-08-08 20:11:23 -0400215static struct cgroup_subsys_state *
216devcgroup_css_alloc(struct cgroup_subsys_state *parent_css)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700217{
Aristeu Rozanski1909554c2013-02-15 11:55:46 -0500218 struct dev_cgroup *dev_cgroup;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700219
220 dev_cgroup = kzalloc(sizeof(*dev_cgroup), GFP_KERNEL);
221 if (!dev_cgroup)
222 return ERR_PTR(-ENOMEM);
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700223 INIT_LIST_HEAD(&dev_cgroup->exceptions);
Aristeu Rozanski1909554c2013-02-15 11:55:46 -0500224 dev_cgroup->behavior = DEVCG_DEFAULT_NONE;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700225
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700226 return &dev_cgroup->css;
227}
228
Tejun Heoeb954192013-08-08 20:11:23 -0400229static void devcgroup_css_free(struct cgroup_subsys_state *css)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700230{
Tejun Heoeb954192013-08-08 20:11:23 -0400231 struct dev_cgroup *dev_cgroup = css_to_devcgroup(css);
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700232
Jerry Snitselaar53eb8c82013-02-21 16:41:31 -0800233 __dev_exception_clean(dev_cgroup);
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700234 kfree(dev_cgroup);
235}
236
237#define DEVCG_ALLOW 1
238#define DEVCG_DENY 2
Serge E. Hallyn29486df2008-04-29 01:00:14 -0700239#define DEVCG_LIST 3
240
Li Zefan17d213f2008-07-13 12:14:02 -0700241#define MAJMINLEN 13
Serge E. Hallyn29486df2008-04-29 01:00:14 -0700242#define ACCLEN 4
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700243
244static void set_access(char *acc, short access)
245{
246 int idx = 0;
Serge E. Hallyn29486df2008-04-29 01:00:14 -0700247 memset(acc, 0, ACCLEN);
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700248 if (access & ACC_READ)
249 acc[idx++] = 'r';
250 if (access & ACC_WRITE)
251 acc[idx++] = 'w';
252 if (access & ACC_MKNOD)
253 acc[idx++] = 'm';
254}
255
256static char type_to_char(short type)
257{
258 if (type == DEV_ALL)
259 return 'a';
260 if (type == DEV_CHAR)
261 return 'c';
262 if (type == DEV_BLOCK)
263 return 'b';
264 return 'X';
265}
266
Serge E. Hallyn29486df2008-04-29 01:00:14 -0700267static void set_majmin(char *str, unsigned m)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700268{
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700269 if (m == ~0)
Li Zefan7759fc92008-07-25 01:47:08 -0700270 strcpy(str, "*");
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700271 else
Li Zefan7759fc92008-07-25 01:47:08 -0700272 sprintf(str, "%u", m);
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700273}
274
Tejun Heo2da8ca82013-12-05 12:28:04 -0500275static int devcgroup_seq_show(struct seq_file *m, void *v)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700276{
Tejun Heo2da8ca82013-12-05 12:28:04 -0500277 struct dev_cgroup *devcgroup = css_to_devcgroup(seq_css(m));
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700278 struct dev_exception_item *ex;
Serge E. Hallyn29486df2008-04-29 01:00:14 -0700279 char maj[MAJMINLEN], min[MAJMINLEN], acc[ACCLEN];
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700280
Pavel Emelyanov4efd1a12008-07-25 01:47:07 -0700281 rcu_read_lock();
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700282 /*
283 * To preserve the compatibility:
284 * - Only show the "all devices" when the default policy is to allow
285 * - List the exceptions in case the default policy is to deny
286 * This way, the file remains as a "whitelist of devices"
287 */
Aristeu Rozanski5b7aa7d2012-10-25 13:37:38 -0700288 if (devcgroup->behavior == DEVCG_DEFAULT_ALLOW) {
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700289 set_access(acc, ACC_MASK);
290 set_majmin(maj, ~0);
291 set_majmin(min, ~0);
292 seq_printf(m, "%c %s:%s %s\n", type_to_char(DEV_ALL),
Serge E. Hallyn29486df2008-04-29 01:00:14 -0700293 maj, min, acc);
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700294 } else {
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700295 list_for_each_entry_rcu(ex, &devcgroup->exceptions, list) {
296 set_access(acc, ex->access);
297 set_majmin(maj, ex->major);
298 set_majmin(min, ex->minor);
299 seq_printf(m, "%c %s:%s %s\n", type_to_char(ex->type),
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700300 maj, min, acc);
301 }
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700302 }
Pavel Emelyanov4efd1a12008-07-25 01:47:07 -0700303 rcu_read_unlock();
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700304
Serge E. Hallyn29486df2008-04-29 01:00:14 -0700305 return 0;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700306}
307
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700308/**
Aristeu Rozanski79d71972014-04-21 12:13:03 -0400309 * match_exception - iterates the exception list trying to match a rule
310 * based on type, major, minor and access type. It is
311 * considered a match if an exception is found that
312 * will contain the entire range of provided parameters.
313 * @exceptions: list of exceptions
314 * @type: device type (DEV_BLOCK or DEV_CHAR)
315 * @major: device file major number, ~0 to match all
316 * @minor: device file minor number, ~0 to match all
317 * @access: permission mask (ACC_READ, ACC_WRITE, ACC_MKNOD)
318 *
319 * returns: true in case it matches an exception completely
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700320 */
Aristeu Rozanski79d71972014-04-21 12:13:03 -0400321static bool match_exception(struct list_head *exceptions, short type,
322 u32 major, u32 minor, short access)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700323{
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700324 struct dev_exception_item *ex;
Aristeu Rozanski79d71972014-04-21 12:13:03 -0400325
326 list_for_each_entry_rcu(ex, exceptions, list) {
327 if ((type & DEV_BLOCK) && !(ex->type & DEV_BLOCK))
328 continue;
329 if ((type & DEV_CHAR) && !(ex->type & DEV_CHAR))
330 continue;
331 if (ex->major != ~0 && ex->major != major)
332 continue;
333 if (ex->minor != ~0 && ex->minor != minor)
334 continue;
335 /* provided access cannot have more than the exception rule */
336 if (access & (~ex->access))
337 continue;
338 return true;
339 }
340 return false;
341}
342
343/**
344 * match_exception_partial - iterates the exception list trying to match a rule
345 * based on type, major, minor and access type. It is
346 * considered a match if an exception's range is
347 * found to contain *any* of the devices specified by
348 * provided parameters. This is used to make sure no
349 * extra access is being granted that is forbidden by
350 * any of the exception list.
351 * @exceptions: list of exceptions
352 * @type: device type (DEV_BLOCK or DEV_CHAR)
353 * @major: device file major number, ~0 to match all
354 * @minor: device file minor number, ~0 to match all
355 * @access: permission mask (ACC_READ, ACC_WRITE, ACC_MKNOD)
356 *
357 * returns: true in case the provided range mat matches an exception completely
358 */
359static bool match_exception_partial(struct list_head *exceptions, short type,
360 u32 major, u32 minor, short access)
361{
362 struct dev_exception_item *ex;
363
364 list_for_each_entry_rcu(ex, exceptions, list) {
365 if ((type & DEV_BLOCK) && !(ex->type & DEV_BLOCK))
366 continue;
367 if ((type & DEV_CHAR) && !(ex->type & DEV_CHAR))
368 continue;
369 /*
370 * We must be sure that both the exception and the provided
371 * range aren't masking all devices
372 */
373 if (ex->major != ~0 && major != ~0 && ex->major != major)
374 continue;
375 if (ex->minor != ~0 && minor != ~0 && ex->minor != minor)
376 continue;
377 /*
378 * In order to make sure the provided range isn't matching
379 * an exception, all its access bits shouldn't match the
380 * exception's access bits
381 */
382 if (!(access & ex->access))
383 continue;
384 return true;
385 }
386 return false;
387}
388
389/**
390 * verify_new_ex - verifies if a new exception is part of what is allowed
391 * by a dev cgroup based on the default policy +
392 * exceptions. This is used to make sure a child cgroup
393 * won't have more privileges than its parent
394 * @dev_cgroup: dev cgroup to be tested against
395 * @refex: new exception
396 * @behavior: behavior of the exception's dev_cgroup
397 */
398static bool verify_new_ex(struct dev_cgroup *dev_cgroup,
399 struct dev_exception_item *refex,
400 enum devcg_behavior behavior)
401{
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700402 bool match = false;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700403
Tejun Heo4b1c7842012-11-06 09:16:53 -0800404 rcu_lockdep_assert(rcu_read_lock_held() ||
405 lockdep_is_held(&devcgroup_mutex),
Aristeu Rozanski79d71972014-04-21 12:13:03 -0400406 "device_cgroup:verify_new_ex called without proper synchronization");
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700407
Aristeu Rozanskic39a2a32013-02-15 11:55:45 -0500408 if (dev_cgroup->behavior == DEVCG_DEFAULT_ALLOW) {
409 if (behavior == DEVCG_DEFAULT_ALLOW) {
Aristeu Rozanski79d71972014-04-21 12:13:03 -0400410 /*
411 * new exception in the child doesn't matter, only
412 * adding extra restrictions
413 */
Aristeu Rozanski26898fd2013-02-15 11:55:44 -0500414 return true;
Aristeu Rozanskic39a2a32013-02-15 11:55:45 -0500415 } else {
Aristeu Rozanski79d71972014-04-21 12:13:03 -0400416 /*
417 * new exception in the child will add more devices
418 * that can be acessed, so it can't match any of
419 * parent's exceptions, even slightly
420 */
421 match = match_exception_partial(&dev_cgroup->exceptions,
422 refex->type,
423 refex->major,
424 refex->minor,
425 refex->access);
426
Aristeu Rozanskic39a2a32013-02-15 11:55:45 -0500427 if (match)
Aristeu Rozanskic39a2a32013-02-15 11:55:45 -0500428 return false;
429 return true;
430 }
Aristeu Rozanski26898fd2013-02-15 11:55:44 -0500431 } else {
Aristeu Rozanski79d71972014-04-21 12:13:03 -0400432 /*
433 * Only behavior == DEVCG_DEFAULT_DENY allowed here, therefore
434 * the new exception will add access to more devices and must
435 * be contained completely in an parent's exception to be
436 * allowed
437 */
438 match = match_exception(&dev_cgroup->exceptions, refex->type,
439 refex->major, refex->minor,
440 refex->access);
441
Aristeu Rozanskic39a2a32013-02-15 11:55:45 -0500442 if (match)
443 /* parent has an exception that matches the proposed */
Aristeu Rozanski26898fd2013-02-15 11:55:44 -0500444 return true;
Aristeu Rozanskic39a2a32013-02-15 11:55:45 -0500445 else
446 return false;
Aristeu Rozanski26898fd2013-02-15 11:55:44 -0500447 }
448 return false;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700449}
450
451/*
452 * parent_has_perm:
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700453 * when adding a new allow rule to a device exception list, the rule
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700454 * must be allowed in the parent device
455 */
Paul Menagef92523e2008-07-25 01:47:03 -0700456static int parent_has_perm(struct dev_cgroup *childcg,
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700457 struct dev_exception_item *ex)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700458{
Tejun Heo63876982013-08-08 20:11:23 -0400459 struct dev_cgroup *parent = css_to_devcgroup(css_parent(&childcg->css));
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700460
Tejun Heo63876982013-08-08 20:11:23 -0400461 if (!parent)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700462 return 1;
Aristeu Rozanski79d71972014-04-21 12:13:03 -0400463 return verify_new_ex(parent, ex, childcg->behavior);
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700464}
465
Aristeu Rozanski4cef7292012-10-25 13:37:45 -0700466/**
467 * may_allow_all - checks if it's possible to change the behavior to
468 * allow based on parent's rules.
469 * @parent: device cgroup's parent
470 * returns: != 0 in case it's allowed, 0 otherwise
471 */
472static inline int may_allow_all(struct dev_cgroup *parent)
473{
Aristeu Rozanski64e10472012-11-06 07:25:04 -0800474 if (!parent)
475 return 1;
Aristeu Rozanski4cef7292012-10-25 13:37:45 -0700476 return parent->behavior == DEVCG_DEFAULT_ALLOW;
477}
478
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500479/**
480 * revalidate_active_exceptions - walks through the active exception list and
481 * revalidates the exceptions based on parent's
482 * behavior and exceptions. The exceptions that
483 * are no longer valid will be removed.
484 * Called with devcgroup_mutex held.
485 * @devcg: cgroup which exceptions will be checked
486 *
487 * This is one of the three key functions for hierarchy implementation.
488 * This function is responsible for re-evaluating all the cgroup's active
489 * exceptions due to a parent's exception change.
490 * Refer to Documentation/cgroups/devices.txt for more details.
491 */
492static void revalidate_active_exceptions(struct dev_cgroup *devcg)
493{
494 struct dev_exception_item *ex;
495 struct list_head *this, *tmp;
496
497 list_for_each_safe(this, tmp, &devcg->exceptions) {
498 ex = container_of(this, struct dev_exception_item, list);
499 if (!parent_has_perm(devcg, ex))
500 dev_exception_rm(devcg, ex);
501 }
502}
503
504/**
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500505 * propagate_exception - propagates a new exception to the children
506 * @devcg_root: device cgroup that added a new exception
507 * @ex: new exception to be propagated
508 *
509 * returns: 0 in case of success, != 0 in case of error
510 */
511static int propagate_exception(struct dev_cgroup *devcg_root,
512 struct dev_exception_item *ex)
513{
Tejun Heo492eb212013-08-08 20:11:25 -0400514 struct cgroup_subsys_state *pos;
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500515 int rc = 0;
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500516
Tejun Heod591fb52013-05-24 10:55:38 +0900517 rcu_read_lock();
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500518
Tejun Heo492eb212013-08-08 20:11:25 -0400519 css_for_each_descendant_pre(pos, &devcg_root->css) {
520 struct dev_cgroup *devcg = css_to_devcgroup(pos);
Tejun Heod591fb52013-05-24 10:55:38 +0900521
522 /*
523 * Because devcgroup_mutex is held, no devcg will become
524 * online or offline during the tree walk (see on/offline
525 * methods), and online ones are safe to access outside RCU
526 * read lock without bumping refcnt.
527 */
Tejun Heobd8815a2013-08-08 20:11:27 -0400528 if (pos == &devcg_root->css || !is_devcg_online(devcg))
Tejun Heod591fb52013-05-24 10:55:38 +0900529 continue;
530
531 rcu_read_unlock();
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500532
533 /*
534 * in case both root's behavior and devcg is allow, a new
535 * restriction means adding to the exception list
536 */
537 if (devcg_root->behavior == DEVCG_DEFAULT_ALLOW &&
538 devcg->behavior == DEVCG_DEFAULT_ALLOW) {
539 rc = dev_exception_add(devcg, ex);
540 if (rc)
541 break;
542 } else {
543 /*
544 * in the other possible cases:
545 * root's behavior: allow, devcg's: deny
546 * root's behavior: deny, devcg's: deny
547 * the exception will be removed
548 */
549 dev_exception_rm(devcg, ex);
550 }
551 revalidate_active_exceptions(devcg);
552
Tejun Heod591fb52013-05-24 10:55:38 +0900553 rcu_read_lock();
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500554 }
Tejun Heod591fb52013-05-24 10:55:38 +0900555
556 rcu_read_unlock();
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500557 return rc;
558}
559
560static inline bool has_children(struct dev_cgroup *devcgroup)
561{
562 struct cgroup *cgrp = devcgroup->css.cgroup;
563
564 return !list_empty(&cgrp->children);
565}
566
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700567/*
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700568 * Modify the exception list using allow/deny rules.
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700569 * CAP_SYS_ADMIN is needed for this. It's at least separate from CAP_MKNOD
570 * so we can give a container CAP_MKNOD to let it create devices but not
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700571 * modify the exception list.
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700572 * It seems likely we'll want to add a CAP_CONTAINER capability to allow
573 * us to also grant CAP_SYS_ADMIN to containers without giving away the
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700574 * device exception list controls, but for now we'll stick with CAP_SYS_ADMIN
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700575 *
576 * Taking rules away is always allowed (given CAP_SYS_ADMIN). Granting
577 * new access is only allowed if you're in the top-level cgroup, or your
578 * parent cgroup has the access you're asking for.
579 */
Paul Menagef92523e2008-07-25 01:47:03 -0700580static int devcgroup_update_access(struct dev_cgroup *devcgroup,
Tejun Heo4d3bb512014-03-19 10:23:54 -0400581 int filetype, char *buffer)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700582{
Paul Menagef92523e2008-07-25 01:47:03 -0700583 const char *b;
Aristeu Rozanski26fd8402012-10-25 13:37:41 -0700584 char temp[12]; /* 11 + 1 characters needed for a u32 */
Aristeu Rozanskic39a2a32013-02-15 11:55:45 -0500585 int count, rc = 0;
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700586 struct dev_exception_item ex;
Tejun Heo63876982013-08-08 20:11:23 -0400587 struct dev_cgroup *parent = css_to_devcgroup(css_parent(&devcgroup->css));
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700588
589 if (!capable(CAP_SYS_ADMIN))
590 return -EPERM;
591
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700592 memset(&ex, 0, sizeof(ex));
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700593 b = buffer;
594
595 switch (*b) {
596 case 'a':
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700597 switch (filetype) {
598 case DEVCG_ALLOW:
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500599 if (has_children(devcgroup))
600 return -EINVAL;
601
Aristeu Rozanski4cef7292012-10-25 13:37:45 -0700602 if (!may_allow_all(parent))
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700603 return -EPERM;
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700604 dev_exception_clean(devcgroup);
Aristeu Rozanski64e10472012-11-06 07:25:04 -0800605 devcgroup->behavior = DEVCG_DEFAULT_ALLOW;
606 if (!parent)
607 break;
608
Aristeu Rozanski4cef7292012-10-25 13:37:45 -0700609 rc = dev_exceptions_copy(&devcgroup->exceptions,
610 &parent->exceptions);
611 if (rc)
612 return rc;
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700613 break;
614 case DEVCG_DENY:
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500615 if (has_children(devcgroup))
616 return -EINVAL;
617
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700618 dev_exception_clean(devcgroup);
Aristeu Rozanski5b7aa7d2012-10-25 13:37:38 -0700619 devcgroup->behavior = DEVCG_DEFAULT_DENY;
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700620 break;
621 default:
622 return -EINVAL;
623 }
624 return 0;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700625 case 'b':
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700626 ex.type = DEV_BLOCK;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700627 break;
628 case 'c':
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700629 ex.type = DEV_CHAR;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700630 break;
631 default:
Paul Menagef92523e2008-07-25 01:47:03 -0700632 return -EINVAL;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700633 }
634 b++;
Paul Menagef92523e2008-07-25 01:47:03 -0700635 if (!isspace(*b))
636 return -EINVAL;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700637 b++;
638 if (*b == '*') {
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700639 ex.major = ~0;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700640 b++;
641 } else if (isdigit(*b)) {
Aristeu Rozanski26fd8402012-10-25 13:37:41 -0700642 memset(temp, 0, sizeof(temp));
643 for (count = 0; count < sizeof(temp) - 1; count++) {
644 temp[count] = *b;
645 b++;
646 if (!isdigit(*b))
647 break;
648 }
649 rc = kstrtou32(temp, 10, &ex.major);
650 if (rc)
651 return -EINVAL;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700652 } else {
Paul Menagef92523e2008-07-25 01:47:03 -0700653 return -EINVAL;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700654 }
Paul Menagef92523e2008-07-25 01:47:03 -0700655 if (*b != ':')
656 return -EINVAL;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700657 b++;
658
659 /* read minor */
660 if (*b == '*') {
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700661 ex.minor = ~0;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700662 b++;
663 } else if (isdigit(*b)) {
Aristeu Rozanski26fd8402012-10-25 13:37:41 -0700664 memset(temp, 0, sizeof(temp));
665 for (count = 0; count < sizeof(temp) - 1; count++) {
666 temp[count] = *b;
667 b++;
668 if (!isdigit(*b))
669 break;
670 }
671 rc = kstrtou32(temp, 10, &ex.minor);
672 if (rc)
673 return -EINVAL;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700674 } else {
Paul Menagef92523e2008-07-25 01:47:03 -0700675 return -EINVAL;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700676 }
Paul Menagef92523e2008-07-25 01:47:03 -0700677 if (!isspace(*b))
678 return -EINVAL;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700679 for (b++, count = 0; count < 3; count++, b++) {
680 switch (*b) {
681 case 'r':
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700682 ex.access |= ACC_READ;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700683 break;
684 case 'w':
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700685 ex.access |= ACC_WRITE;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700686 break;
687 case 'm':
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700688 ex.access |= ACC_MKNOD;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700689 break;
690 case '\n':
691 case '\0':
692 count = 3;
693 break;
694 default:
Paul Menagef92523e2008-07-25 01:47:03 -0700695 return -EINVAL;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700696 }
697 }
698
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700699 switch (filetype) {
700 case DEVCG_ALLOW:
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700701 if (!parent_has_perm(devcgroup, &ex))
Paul Menagef92523e2008-07-25 01:47:03 -0700702 return -EPERM;
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700703 /*
704 * If the default policy is to allow by default, try to remove
705 * an matching exception instead. And be silent about it: we
706 * don't want to break compatibility
707 */
Aristeu Rozanski5b7aa7d2012-10-25 13:37:38 -0700708 if (devcgroup->behavior == DEVCG_DEFAULT_ALLOW) {
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700709 dev_exception_rm(devcgroup, &ex);
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700710 return 0;
711 }
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500712 rc = dev_exception_add(devcgroup, &ex);
713 break;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700714 case DEVCG_DENY:
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700715 /*
716 * If the default policy is to deny by default, try to remove
717 * an matching exception instead. And be silent about it: we
718 * don't want to break compatibility
719 */
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500720 if (devcgroup->behavior == DEVCG_DEFAULT_DENY)
Aristeu Rozanskidb9aeca2012-10-04 17:15:20 -0700721 dev_exception_rm(devcgroup, &ex);
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500722 else
723 rc = dev_exception_add(devcgroup, &ex);
724
725 if (rc)
726 break;
727 /* we only propagate new restrictions */
728 rc = propagate_exception(devcgroup, &ex);
729 break;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700730 default:
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500731 rc = -EINVAL;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700732 }
Aristeu Rozanskibd2953e2013-02-15 11:55:47 -0500733 return rc;
Paul Menagef92523e2008-07-25 01:47:03 -0700734}
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700735
Tejun Heo182446d2013-08-08 20:11:24 -0400736static int devcgroup_access_write(struct cgroup_subsys_state *css,
Tejun Heo4d3bb512014-03-19 10:23:54 -0400737 struct cftype *cft, char *buffer)
Paul Menagef92523e2008-07-25 01:47:03 -0700738{
739 int retval;
Li Zefanb4046f02009-04-02 16:57:32 -0700740
741 mutex_lock(&devcgroup_mutex);
Tejun Heo182446d2013-08-08 20:11:24 -0400742 retval = devcgroup_update_access(css_to_devcgroup(css),
Paul Menagef92523e2008-07-25 01:47:03 -0700743 cft->private, buffer);
Li Zefanb4046f02009-04-02 16:57:32 -0700744 mutex_unlock(&devcgroup_mutex);
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700745 return retval;
746}
747
748static struct cftype dev_cgroup_files[] = {
749 {
750 .name = "allow",
Paul Menagef92523e2008-07-25 01:47:03 -0700751 .write_string = devcgroup_access_write,
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700752 .private = DEVCG_ALLOW,
753 },
754 {
755 .name = "deny",
Paul Menagef92523e2008-07-25 01:47:03 -0700756 .write_string = devcgroup_access_write,
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700757 .private = DEVCG_DENY,
758 },
Serge E. Hallyn29486df2008-04-29 01:00:14 -0700759 {
760 .name = "list",
Tejun Heo2da8ca82013-12-05 12:28:04 -0500761 .seq_show = devcgroup_seq_show,
Serge E. Hallyn29486df2008-04-29 01:00:14 -0700762 .private = DEVCG_LIST,
763 },
Tejun Heo4baf6e32012-04-01 12:09:55 -0700764 { } /* terminate */
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700765};
766
Tejun Heo073219e2014-02-08 10:36:58 -0500767struct cgroup_subsys devices_cgrp_subsys = {
Tejun Heo92fb9742012-11-19 08:13:38 -0800768 .css_alloc = devcgroup_css_alloc,
769 .css_free = devcgroup_css_free,
Aristeu Rozanski1909554c2013-02-15 11:55:46 -0500770 .css_online = devcgroup_online,
771 .css_offline = devcgroup_offline,
Tejun Heo4baf6e32012-04-01 12:09:55 -0700772 .base_cftypes = dev_cgroup_files,
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700773};
774
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700775/**
776 * __devcgroup_check_permission - checks if an inode operation is permitted
777 * @dev_cgroup: the dev cgroup to be tested against
778 * @type: device type
779 * @major: device major number
780 * @minor: device minor number
781 * @access: combination of ACC_WRITE, ACC_READ and ACC_MKNOD
782 *
783 * returns 0 on success, -EPERM case the operation is not permitted
784 */
Jiri Slaby8c9506d2012-10-25 13:37:34 -0700785static int __devcgroup_check_permission(short type, u32 major, u32 minor,
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700786 short access)
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700787{
Jiri Slaby8c9506d2012-10-25 13:37:34 -0700788 struct dev_cgroup *dev_cgroup;
Aristeu Rozanski79d71972014-04-21 12:13:03 -0400789 bool rc;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700790
Pavel Emelyanov4efd1a12008-07-25 01:47:07 -0700791 rcu_read_lock();
Jiri Slaby8c9506d2012-10-25 13:37:34 -0700792 dev_cgroup = task_devcgroup(current);
Aristeu Rozanski79d71972014-04-21 12:13:03 -0400793 if (dev_cgroup->behavior == DEVCG_DEFAULT_ALLOW)
794 /* Can't match any of the exceptions, even partially */
795 rc = !match_exception_partial(&dev_cgroup->exceptions,
796 type, major, minor, access);
797 else
798 /* Need to match completely one exception to be allowed */
799 rc = match_exception(&dev_cgroup->exceptions, type, major,
800 minor, access);
Pavel Emelyanov4efd1a12008-07-25 01:47:07 -0700801 rcu_read_unlock();
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700802
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700803 if (!rc)
804 return -EPERM;
805
806 return 0;
807}
808
809int __devcgroup_inode_permission(struct inode *inode, int mask)
810{
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700811 short type, access = 0;
812
813 if (S_ISBLK(inode->i_mode))
814 type = DEV_BLOCK;
815 if (S_ISCHR(inode->i_mode))
816 type = DEV_CHAR;
817 if (mask & MAY_WRITE)
818 access |= ACC_WRITE;
819 if (mask & MAY_READ)
820 access |= ACC_READ;
821
Jiri Slaby8c9506d2012-10-25 13:37:34 -0700822 return __devcgroup_check_permission(type, imajor(inode), iminor(inode),
823 access);
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700824}
825
826int devcgroup_inode_mknod(int mode, dev_t dev)
827{
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700828 short type;
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700829
Serge E. Hallyn0b82ac32009-01-07 18:07:46 -0800830 if (!S_ISBLK(mode) && !S_ISCHR(mode))
831 return 0;
832
Aristeu Rozanskiad676072012-10-04 17:15:17 -0700833 if (S_ISBLK(mode))
834 type = DEV_BLOCK;
835 else
836 type = DEV_CHAR;
Li Zefan36fd71d2008-09-02 14:35:52 -0700837
Jiri Slaby8c9506d2012-10-25 13:37:34 -0700838 return __devcgroup_check_permission(type, MAJOR(dev), MINOR(dev),
839 ACC_MKNOD);
Li Zefan36fd71d2008-09-02 14:35:52 -0700840
Serge E. Hallyn08ce5f12008-04-29 01:00:10 -0700841}