Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 1 | /* -*- mode: c; c-basic-offset: 8; -*- |
| 2 | * vim: noexpandtab sw=8 ts=8 sts=0: |
| 3 | * |
| 4 | * userdlm.c |
| 5 | * |
| 6 | * Code which implements the kernel side of a minimal userspace |
| 7 | * interface to our DLM. |
| 8 | * |
| 9 | * Many of the functions here are pared down versions of dlmglue.c |
| 10 | * functions. |
| 11 | * |
| 12 | * Copyright (C) 2003, 2004 Oracle. All rights reserved. |
| 13 | * |
| 14 | * This program is free software; you can redistribute it and/or |
| 15 | * modify it under the terms of the GNU General Public |
| 16 | * License as published by the Free Software Foundation; either |
| 17 | * version 2 of the License, or (at your option) any later version. |
| 18 | * |
| 19 | * This program is distributed in the hope that it will be useful, |
| 20 | * but WITHOUT ANY WARRANTY; without even the implied warranty of |
| 21 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU |
| 22 | * General Public License for more details. |
| 23 | * |
| 24 | * You should have received a copy of the GNU General Public |
| 25 | * License along with this program; if not, write to the |
| 26 | * Free Software Foundation, Inc., 59 Temple Place - Suite 330, |
| 27 | * Boston, MA 021110-1307, USA. |
| 28 | */ |
| 29 | |
Jeff Mahoney | aee93ac | 2006-01-09 12:36:40 -0500 | [diff] [blame] | 30 | #include <linux/signal.h> |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 31 | |
| 32 | #include <linux/module.h> |
| 33 | #include <linux/fs.h> |
| 34 | #include <linux/types.h> |
| 35 | #include <linux/crc32.h> |
| 36 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 37 | #include "ocfs2_lockingver.h" |
| 38 | #include "stackglue.h" |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 39 | #include "userdlm.h" |
| 40 | |
| 41 | #define MLOG_MASK_PREFIX ML_DLMFS |
| 42 | #include "cluster/masklog.h" |
| 43 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 44 | |
| 45 | static inline struct user_lock_res *user_lksb_to_lock_res(struct ocfs2_dlm_lksb *lksb) |
| 46 | { |
| 47 | return container_of(lksb, struct user_lock_res, l_lksb); |
| 48 | } |
| 49 | |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 50 | static inline int user_check_wait_flag(struct user_lock_res *lockres, |
| 51 | int flag) |
| 52 | { |
| 53 | int ret; |
| 54 | |
| 55 | spin_lock(&lockres->l_lock); |
| 56 | ret = lockres->l_flags & flag; |
| 57 | spin_unlock(&lockres->l_lock); |
| 58 | |
| 59 | return ret; |
| 60 | } |
| 61 | |
| 62 | static inline void user_wait_on_busy_lock(struct user_lock_res *lockres) |
| 63 | |
| 64 | { |
| 65 | wait_event(lockres->l_event, |
| 66 | !user_check_wait_flag(lockres, USER_LOCK_BUSY)); |
| 67 | } |
| 68 | |
| 69 | static inline void user_wait_on_blocked_lock(struct user_lock_res *lockres) |
| 70 | |
| 71 | { |
| 72 | wait_event(lockres->l_event, |
| 73 | !user_check_wait_flag(lockres, USER_LOCK_BLOCKED)); |
| 74 | } |
| 75 | |
| 76 | /* I heart container_of... */ |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 77 | static inline struct ocfs2_cluster_connection * |
| 78 | cluster_connection_from_user_lockres(struct user_lock_res *lockres) |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 79 | { |
| 80 | struct dlmfs_inode_private *ip; |
| 81 | |
| 82 | ip = container_of(lockres, |
| 83 | struct dlmfs_inode_private, |
| 84 | ip_lockres); |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 85 | return ip->ip_conn; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 86 | } |
| 87 | |
| 88 | static struct inode * |
| 89 | user_dlm_inode_from_user_lockres(struct user_lock_res *lockres) |
| 90 | { |
| 91 | struct dlmfs_inode_private *ip; |
| 92 | |
| 93 | ip = container_of(lockres, |
| 94 | struct dlmfs_inode_private, |
| 95 | ip_lockres); |
| 96 | return &ip->ip_vfs_inode; |
| 97 | } |
| 98 | |
| 99 | static inline void user_recover_from_dlm_error(struct user_lock_res *lockres) |
| 100 | { |
| 101 | spin_lock(&lockres->l_lock); |
| 102 | lockres->l_flags &= ~USER_LOCK_BUSY; |
| 103 | spin_unlock(&lockres->l_lock); |
| 104 | } |
| 105 | |
Mark Fasheh | ea5b3a1 | 2006-09-08 11:39:27 -0700 | [diff] [blame] | 106 | #define user_log_dlm_error(_func, _stat, _lockres) do { \ |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 107 | mlog(ML_ERROR, "Dlm error %d while calling %s on " \ |
| 108 | "resource %.*s\n", _stat, _func, \ |
| 109 | _lockres->l_namelen, _lockres->l_name); \ |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 110 | } while (0) |
| 111 | |
| 112 | /* WARNING: This function lives in a world where the only three lock |
| 113 | * levels are EX, PR, and NL. It *will* have to be adjusted when more |
| 114 | * lock types are added. */ |
| 115 | static inline int user_highest_compat_lock_level(int level) |
| 116 | { |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 117 | int new_level = DLM_LOCK_EX; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 118 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 119 | if (level == DLM_LOCK_EX) |
| 120 | new_level = DLM_LOCK_NL; |
| 121 | else if (level == DLM_LOCK_PR) |
| 122 | new_level = DLM_LOCK_PR; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 123 | return new_level; |
| 124 | } |
| 125 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 126 | static void user_ast(struct ocfs2_dlm_lksb *lksb) |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 127 | { |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 128 | struct user_lock_res *lockres = user_lksb_to_lock_res(lksb); |
| 129 | int status; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 130 | |
Sunil Mushran | 6fcef3f | 2010-02-26 19:42:45 -0800 | [diff] [blame] | 131 | mlog(ML_BASTS, "AST fired for lockres %.*s, level %d => %d\n", |
| 132 | lockres->l_namelen, lockres->l_name, lockres->l_level, |
| 133 | lockres->l_requested); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 134 | |
| 135 | spin_lock(&lockres->l_lock); |
| 136 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 137 | status = ocfs2_dlm_lock_status(&lockres->l_lksb); |
| 138 | if (status) { |
Mark Fasheh | ea5b3a1 | 2006-09-08 11:39:27 -0700 | [diff] [blame] | 139 | mlog(ML_ERROR, "lksb status value of %u on lockres %.*s\n", |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 140 | status, lockres->l_namelen, lockres->l_name); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 141 | spin_unlock(&lockres->l_lock); |
| 142 | return; |
| 143 | } |
| 144 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 145 | mlog_bug_on_msg(lockres->l_requested == DLM_LOCK_IV, |
Mark Fasheh | ea5b3a1 | 2006-09-08 11:39:27 -0700 | [diff] [blame] | 146 | "Lockres %.*s, requested ivmode. flags 0x%x\n", |
| 147 | lockres->l_namelen, lockres->l_name, lockres->l_flags); |
Mark Fasheh | cc6eb72 | 2006-03-29 10:34:21 -0800 | [diff] [blame] | 148 | |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 149 | /* we're downconverting. */ |
| 150 | if (lockres->l_requested < lockres->l_level) { |
| 151 | if (lockres->l_requested <= |
| 152 | user_highest_compat_lock_level(lockres->l_blocking)) { |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 153 | lockres->l_blocking = DLM_LOCK_NL; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 154 | lockres->l_flags &= ~USER_LOCK_BLOCKED; |
| 155 | } |
| 156 | } |
| 157 | |
| 158 | lockres->l_level = lockres->l_requested; |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 159 | lockres->l_requested = DLM_LOCK_IV; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 160 | lockres->l_flags |= USER_LOCK_ATTACHED; |
| 161 | lockres->l_flags &= ~USER_LOCK_BUSY; |
| 162 | |
| 163 | spin_unlock(&lockres->l_lock); |
| 164 | |
| 165 | wake_up(&lockres->l_event); |
| 166 | } |
| 167 | |
| 168 | static inline void user_dlm_grab_inode_ref(struct user_lock_res *lockres) |
| 169 | { |
| 170 | struct inode *inode; |
| 171 | inode = user_dlm_inode_from_user_lockres(lockres); |
| 172 | if (!igrab(inode)) |
| 173 | BUG(); |
| 174 | } |
| 175 | |
David Howells | c402895 | 2006-11-22 14:57:56 +0000 | [diff] [blame] | 176 | static void user_dlm_unblock_lock(struct work_struct *work); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 177 | |
| 178 | static void __user_dlm_queue_lockres(struct user_lock_res *lockres) |
| 179 | { |
| 180 | if (!(lockres->l_flags & USER_LOCK_QUEUED)) { |
| 181 | user_dlm_grab_inode_ref(lockres); |
| 182 | |
David Howells | c402895 | 2006-11-22 14:57:56 +0000 | [diff] [blame] | 183 | INIT_WORK(&lockres->l_work, user_dlm_unblock_lock); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 184 | |
| 185 | queue_work(user_dlm_worker, &lockres->l_work); |
| 186 | lockres->l_flags |= USER_LOCK_QUEUED; |
| 187 | } |
| 188 | } |
| 189 | |
| 190 | static void __user_dlm_cond_queue_lockres(struct user_lock_res *lockres) |
| 191 | { |
| 192 | int queue = 0; |
| 193 | |
| 194 | if (!(lockres->l_flags & USER_LOCK_BLOCKED)) |
| 195 | return; |
| 196 | |
| 197 | switch (lockres->l_blocking) { |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 198 | case DLM_LOCK_EX: |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 199 | if (!lockres->l_ex_holders && !lockres->l_ro_holders) |
| 200 | queue = 1; |
| 201 | break; |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 202 | case DLM_LOCK_PR: |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 203 | if (!lockres->l_ex_holders) |
| 204 | queue = 1; |
| 205 | break; |
| 206 | default: |
| 207 | BUG(); |
| 208 | } |
| 209 | |
| 210 | if (queue) |
| 211 | __user_dlm_queue_lockres(lockres); |
| 212 | } |
| 213 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 214 | static void user_bast(struct ocfs2_dlm_lksb *lksb, int level) |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 215 | { |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 216 | struct user_lock_res *lockres = user_lksb_to_lock_res(lksb); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 217 | |
Sunil Mushran | 6fcef3f | 2010-02-26 19:42:45 -0800 | [diff] [blame] | 218 | mlog(ML_BASTS, "BAST fired for lockres %.*s, blocking %d, level %d\n", |
| 219 | lockres->l_namelen, lockres->l_name, level, lockres->l_level); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 220 | |
| 221 | spin_lock(&lockres->l_lock); |
| 222 | lockres->l_flags |= USER_LOCK_BLOCKED; |
| 223 | if (level > lockres->l_blocking) |
| 224 | lockres->l_blocking = level; |
| 225 | |
| 226 | __user_dlm_queue_lockres(lockres); |
| 227 | spin_unlock(&lockres->l_lock); |
| 228 | |
| 229 | wake_up(&lockres->l_event); |
| 230 | } |
| 231 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 232 | static void user_unlock_ast(struct ocfs2_dlm_lksb *lksb, int status) |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 233 | { |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 234 | struct user_lock_res *lockres = user_lksb_to_lock_res(lksb); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 235 | |
Sunil Mushran | 6fcef3f | 2010-02-26 19:42:45 -0800 | [diff] [blame] | 236 | mlog(ML_BASTS, "UNLOCK AST fired for lockres %.*s, flags 0x%x\n", |
| 237 | lockres->l_namelen, lockres->l_name, lockres->l_flags); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 238 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 239 | if (status) |
| 240 | mlog(ML_ERROR, "dlm returns status %d\n", status); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 241 | |
| 242 | spin_lock(&lockres->l_lock); |
Mark Fasheh | 2cd9888 | 2006-03-29 16:49:13 -0800 | [diff] [blame] | 243 | /* The teardown flag gets set early during the unlock process, |
| 244 | * so test the cancel flag to make sure that this ast isn't |
| 245 | * for a concurrent cancel. */ |
| 246 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN |
| 247 | && !(lockres->l_flags & USER_LOCK_IN_CANCEL)) { |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 248 | lockres->l_level = DLM_LOCK_IV; |
Mark Fasheh | 2cd9888 | 2006-03-29 16:49:13 -0800 | [diff] [blame] | 249 | } else if (status == DLM_CANCELGRANT) { |
Mark Fasheh | f43e691 | 2006-03-29 18:24:12 -0800 | [diff] [blame] | 250 | /* We tried to cancel a convert request, but it was |
| 251 | * already granted. Don't clear the busy flag - the |
| 252 | * ast should've done this already. */ |
| 253 | BUG_ON(!(lockres->l_flags & USER_LOCK_IN_CANCEL)); |
| 254 | lockres->l_flags &= ~USER_LOCK_IN_CANCEL; |
| 255 | goto out_noclear; |
| 256 | } else { |
| 257 | BUG_ON(!(lockres->l_flags & USER_LOCK_IN_CANCEL)); |
| 258 | /* Cancel succeeded, we want to re-queue */ |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 259 | lockres->l_requested = DLM_LOCK_IV; /* cancel an |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 260 | * upconvert |
| 261 | * request. */ |
| 262 | lockres->l_flags &= ~USER_LOCK_IN_CANCEL; |
| 263 | /* we want the unblock thread to look at it again |
| 264 | * now. */ |
Mark Fasheh | f43e691 | 2006-03-29 18:24:12 -0800 | [diff] [blame] | 265 | if (lockres->l_flags & USER_LOCK_BLOCKED) |
| 266 | __user_dlm_queue_lockres(lockres); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 267 | } |
| 268 | |
| 269 | lockres->l_flags &= ~USER_LOCK_BUSY; |
Mark Fasheh | f43e691 | 2006-03-29 18:24:12 -0800 | [diff] [blame] | 270 | out_noclear: |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 271 | spin_unlock(&lockres->l_lock); |
| 272 | |
| 273 | wake_up(&lockres->l_event); |
| 274 | } |
| 275 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 276 | /* |
| 277 | * This is the userdlmfs locking protocol version. |
| 278 | * |
| 279 | * See fs/ocfs2/dlmglue.c for more details on locking versions. |
| 280 | */ |
| 281 | static struct ocfs2_locking_protocol user_dlm_lproto = { |
| 282 | .lp_max_version = { |
| 283 | .pv_major = OCFS2_LOCKING_PROTOCOL_MAJOR, |
| 284 | .pv_minor = OCFS2_LOCKING_PROTOCOL_MINOR, |
| 285 | }, |
| 286 | .lp_lock_ast = user_ast, |
| 287 | .lp_blocking_ast = user_bast, |
| 288 | .lp_unlock_ast = user_unlock_ast, |
| 289 | }; |
| 290 | |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 291 | static inline void user_dlm_drop_inode_ref(struct user_lock_res *lockres) |
| 292 | { |
| 293 | struct inode *inode; |
| 294 | inode = user_dlm_inode_from_user_lockres(lockres); |
| 295 | iput(inode); |
| 296 | } |
| 297 | |
David Howells | c402895 | 2006-11-22 14:57:56 +0000 | [diff] [blame] | 298 | static void user_dlm_unblock_lock(struct work_struct *work) |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 299 | { |
| 300 | int new_level, status; |
David Howells | c402895 | 2006-11-22 14:57:56 +0000 | [diff] [blame] | 301 | struct user_lock_res *lockres = |
| 302 | container_of(work, struct user_lock_res, l_work); |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 303 | struct ocfs2_cluster_connection *conn = |
| 304 | cluster_connection_from_user_lockres(lockres); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 305 | |
Sunil Mushran | 6fcef3f | 2010-02-26 19:42:45 -0800 | [diff] [blame] | 306 | mlog(0, "lockres %.*s\n", lockres->l_namelen, lockres->l_name); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 307 | |
| 308 | spin_lock(&lockres->l_lock); |
| 309 | |
Mark Fasheh | 1f7bc82 | 2006-03-29 10:33:35 -0800 | [diff] [blame] | 310 | mlog_bug_on_msg(!(lockres->l_flags & USER_LOCK_QUEUED), |
Mark Fasheh | ea5b3a1 | 2006-09-08 11:39:27 -0700 | [diff] [blame] | 311 | "Lockres %.*s, flags 0x%x\n", |
| 312 | lockres->l_namelen, lockres->l_name, lockres->l_flags); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 313 | |
Mark Fasheh | 1f7bc82 | 2006-03-29 10:33:35 -0800 | [diff] [blame] | 314 | /* notice that we don't clear USER_LOCK_BLOCKED here. If it's |
| 315 | * set, we want user_ast clear it. */ |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 316 | lockres->l_flags &= ~USER_LOCK_QUEUED; |
| 317 | |
Mark Fasheh | 1f7bc82 | 2006-03-29 10:33:35 -0800 | [diff] [blame] | 318 | /* It's valid to get here and no longer be blocked - if we get |
| 319 | * several basts in a row, we might be queued by the first |
| 320 | * one, the unblock thread might run and clear the queued |
| 321 | * flag, and finally we might get another bast which re-queues |
| 322 | * us before our ast for the downconvert is called. */ |
| 323 | if (!(lockres->l_flags & USER_LOCK_BLOCKED)) { |
Sunil Mushran | 6fcef3f | 2010-02-26 19:42:45 -0800 | [diff] [blame] | 324 | mlog(ML_BASTS, "lockres %.*s USER_LOCK_BLOCKED\n", |
| 325 | lockres->l_namelen, lockres->l_name); |
Mark Fasheh | 1f7bc82 | 2006-03-29 10:33:35 -0800 | [diff] [blame] | 326 | spin_unlock(&lockres->l_lock); |
| 327 | goto drop_ref; |
| 328 | } |
| 329 | |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 330 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN) { |
Sunil Mushran | 6fcef3f | 2010-02-26 19:42:45 -0800 | [diff] [blame] | 331 | mlog(ML_BASTS, "lockres %.*s USER_LOCK_IN_TEARDOWN\n", |
| 332 | lockres->l_namelen, lockres->l_name); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 333 | spin_unlock(&lockres->l_lock); |
| 334 | goto drop_ref; |
| 335 | } |
| 336 | |
| 337 | if (lockres->l_flags & USER_LOCK_BUSY) { |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 338 | if (lockres->l_flags & USER_LOCK_IN_CANCEL) { |
Sunil Mushran | 6fcef3f | 2010-02-26 19:42:45 -0800 | [diff] [blame] | 339 | mlog(ML_BASTS, "lockres %.*s USER_LOCK_IN_CANCEL\n", |
| 340 | lockres->l_namelen, lockres->l_name); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 341 | spin_unlock(&lockres->l_lock); |
| 342 | goto drop_ref; |
| 343 | } |
| 344 | |
| 345 | lockres->l_flags |= USER_LOCK_IN_CANCEL; |
| 346 | spin_unlock(&lockres->l_lock); |
| 347 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 348 | status = ocfs2_dlm_unlock(conn, &lockres->l_lksb, |
| 349 | DLM_LKF_CANCEL); |
| 350 | if (status) |
| 351 | user_log_dlm_error("ocfs2_dlm_unlock", status, lockres); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 352 | goto drop_ref; |
| 353 | } |
| 354 | |
| 355 | /* If there are still incompat holders, we can exit safely |
| 356 | * without worrying about re-queueing this lock as that will |
| 357 | * happen on the last call to user_cluster_unlock. */ |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 358 | if ((lockres->l_blocking == DLM_LOCK_EX) |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 359 | && (lockres->l_ex_holders || lockres->l_ro_holders)) { |
| 360 | spin_unlock(&lockres->l_lock); |
Sunil Mushran | 6fcef3f | 2010-02-26 19:42:45 -0800 | [diff] [blame] | 361 | mlog(ML_BASTS, "lockres %.*s, EX/PR Holders %u,%u\n", |
| 362 | lockres->l_namelen, lockres->l_name, |
| 363 | lockres->l_ex_holders, lockres->l_ro_holders); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 364 | goto drop_ref; |
| 365 | } |
| 366 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 367 | if ((lockres->l_blocking == DLM_LOCK_PR) |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 368 | && lockres->l_ex_holders) { |
| 369 | spin_unlock(&lockres->l_lock); |
Sunil Mushran | 6fcef3f | 2010-02-26 19:42:45 -0800 | [diff] [blame] | 370 | mlog(ML_BASTS, "lockres %.*s, EX Holders %u\n", |
| 371 | lockres->l_namelen, lockres->l_name, |
| 372 | lockres->l_ex_holders); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 373 | goto drop_ref; |
| 374 | } |
| 375 | |
| 376 | /* yay, we can downconvert now. */ |
| 377 | new_level = user_highest_compat_lock_level(lockres->l_blocking); |
| 378 | lockres->l_requested = new_level; |
| 379 | lockres->l_flags |= USER_LOCK_BUSY; |
Sunil Mushran | 6fcef3f | 2010-02-26 19:42:45 -0800 | [diff] [blame] | 380 | mlog(ML_BASTS, "lockres %.*s, downconvert %d => %d\n", |
| 381 | lockres->l_namelen, lockres->l_name, lockres->l_level, new_level); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 382 | spin_unlock(&lockres->l_lock); |
| 383 | |
| 384 | /* need lock downconvert request now... */ |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 385 | status = ocfs2_dlm_lock(conn, new_level, &lockres->l_lksb, |
| 386 | DLM_LKF_CONVERT|DLM_LKF_VALBLK, |
| 387 | lockres->l_name, |
| 388 | lockres->l_namelen); |
| 389 | if (status) { |
| 390 | user_log_dlm_error("ocfs2_dlm_lock", status, lockres); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 391 | user_recover_from_dlm_error(lockres); |
| 392 | } |
| 393 | |
| 394 | drop_ref: |
| 395 | user_dlm_drop_inode_ref(lockres); |
| 396 | } |
| 397 | |
| 398 | static inline void user_dlm_inc_holders(struct user_lock_res *lockres, |
| 399 | int level) |
| 400 | { |
| 401 | switch(level) { |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 402 | case DLM_LOCK_EX: |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 403 | lockres->l_ex_holders++; |
| 404 | break; |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 405 | case DLM_LOCK_PR: |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 406 | lockres->l_ro_holders++; |
| 407 | break; |
| 408 | default: |
| 409 | BUG(); |
| 410 | } |
| 411 | } |
| 412 | |
| 413 | /* predict what lock level we'll be dropping down to on behalf |
| 414 | * of another node, and return true if the currently wanted |
| 415 | * level will be compatible with it. */ |
| 416 | static inline int |
| 417 | user_may_continue_on_blocked_lock(struct user_lock_res *lockres, |
| 418 | int wanted) |
| 419 | { |
| 420 | BUG_ON(!(lockres->l_flags & USER_LOCK_BLOCKED)); |
| 421 | |
| 422 | return wanted <= user_highest_compat_lock_level(lockres->l_blocking); |
| 423 | } |
| 424 | |
| 425 | int user_dlm_cluster_lock(struct user_lock_res *lockres, |
| 426 | int level, |
| 427 | int lkm_flags) |
| 428 | { |
| 429 | int status, local_flags; |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 430 | struct ocfs2_cluster_connection *conn = |
| 431 | cluster_connection_from_user_lockres(lockres); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 432 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 433 | if (level != DLM_LOCK_EX && |
| 434 | level != DLM_LOCK_PR) { |
Mark Fasheh | ea5b3a1 | 2006-09-08 11:39:27 -0700 | [diff] [blame] | 435 | mlog(ML_ERROR, "lockres %.*s: invalid request!\n", |
| 436 | lockres->l_namelen, lockres->l_name); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 437 | status = -EINVAL; |
| 438 | goto bail; |
| 439 | } |
| 440 | |
Sunil Mushran | 6fcef3f | 2010-02-26 19:42:45 -0800 | [diff] [blame] | 441 | mlog(ML_BASTS, "lockres %.*s, level %d, flags = 0x%x\n", |
| 442 | lockres->l_namelen, lockres->l_name, level, lkm_flags); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 443 | |
| 444 | again: |
| 445 | if (signal_pending(current)) { |
| 446 | status = -ERESTARTSYS; |
| 447 | goto bail; |
| 448 | } |
| 449 | |
| 450 | spin_lock(&lockres->l_lock); |
| 451 | |
| 452 | /* We only compare against the currently granted level |
| 453 | * here. If the lock is blocked waiting on a downconvert, |
| 454 | * we'll get caught below. */ |
| 455 | if ((lockres->l_flags & USER_LOCK_BUSY) && |
| 456 | (level > lockres->l_level)) { |
| 457 | /* is someone sitting in dlm_lock? If so, wait on |
| 458 | * them. */ |
| 459 | spin_unlock(&lockres->l_lock); |
| 460 | |
| 461 | user_wait_on_busy_lock(lockres); |
| 462 | goto again; |
| 463 | } |
| 464 | |
| 465 | if ((lockres->l_flags & USER_LOCK_BLOCKED) && |
| 466 | (!user_may_continue_on_blocked_lock(lockres, level))) { |
| 467 | /* is the lock is currently blocked on behalf of |
| 468 | * another node */ |
| 469 | spin_unlock(&lockres->l_lock); |
| 470 | |
| 471 | user_wait_on_blocked_lock(lockres); |
| 472 | goto again; |
| 473 | } |
| 474 | |
| 475 | if (level > lockres->l_level) { |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 476 | local_flags = lkm_flags | DLM_LKF_VALBLK; |
| 477 | if (lockres->l_level != DLM_LOCK_IV) |
| 478 | local_flags |= DLM_LKF_CONVERT; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 479 | |
| 480 | lockres->l_requested = level; |
| 481 | lockres->l_flags |= USER_LOCK_BUSY; |
| 482 | spin_unlock(&lockres->l_lock); |
| 483 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 484 | BUG_ON(level == DLM_LOCK_IV); |
| 485 | BUG_ON(level == DLM_LOCK_NL); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 486 | |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 487 | /* call dlm_lock to upgrade lock now */ |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 488 | status = ocfs2_dlm_lock(conn, level, &lockres->l_lksb, |
| 489 | local_flags, lockres->l_name, |
| 490 | lockres->l_namelen); |
| 491 | if (status) { |
| 492 | if ((lkm_flags & DLM_LKF_NOQUEUE) && |
| 493 | (status != -EAGAIN)) |
| 494 | user_log_dlm_error("ocfs2_dlm_lock", |
| 495 | status, lockres); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 496 | user_recover_from_dlm_error(lockres); |
| 497 | goto bail; |
| 498 | } |
| 499 | |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 500 | user_wait_on_busy_lock(lockres); |
| 501 | goto again; |
| 502 | } |
| 503 | |
| 504 | user_dlm_inc_holders(lockres, level); |
| 505 | spin_unlock(&lockres->l_lock); |
| 506 | |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 507 | status = 0; |
| 508 | bail: |
| 509 | return status; |
| 510 | } |
| 511 | |
| 512 | static inline void user_dlm_dec_holders(struct user_lock_res *lockres, |
| 513 | int level) |
| 514 | { |
| 515 | switch(level) { |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 516 | case DLM_LOCK_EX: |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 517 | BUG_ON(!lockres->l_ex_holders); |
| 518 | lockres->l_ex_holders--; |
| 519 | break; |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 520 | case DLM_LOCK_PR: |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 521 | BUG_ON(!lockres->l_ro_holders); |
| 522 | lockres->l_ro_holders--; |
| 523 | break; |
| 524 | default: |
| 525 | BUG(); |
| 526 | } |
| 527 | } |
| 528 | |
| 529 | void user_dlm_cluster_unlock(struct user_lock_res *lockres, |
| 530 | int level) |
| 531 | { |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 532 | if (level != DLM_LOCK_EX && |
| 533 | level != DLM_LOCK_PR) { |
Mark Fasheh | ea5b3a1 | 2006-09-08 11:39:27 -0700 | [diff] [blame] | 534 | mlog(ML_ERROR, "lockres %.*s: invalid request!\n", |
| 535 | lockres->l_namelen, lockres->l_name); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 536 | return; |
| 537 | } |
| 538 | |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 539 | spin_lock(&lockres->l_lock); |
| 540 | user_dlm_dec_holders(lockres, level); |
| 541 | __user_dlm_cond_queue_lockres(lockres); |
| 542 | spin_unlock(&lockres->l_lock); |
| 543 | } |
| 544 | |
| 545 | void user_dlm_write_lvb(struct inode *inode, |
| 546 | const char *val, |
| 547 | unsigned int len) |
| 548 | { |
| 549 | struct user_lock_res *lockres = &DLMFS_I(inode)->ip_lockres; |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 550 | char *lvb; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 551 | |
| 552 | BUG_ON(len > DLM_LVB_LEN); |
| 553 | |
| 554 | spin_lock(&lockres->l_lock); |
| 555 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 556 | BUG_ON(lockres->l_level < DLM_LOCK_EX); |
| 557 | lvb = ocfs2_dlm_lvb(&lockres->l_lksb); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 558 | memcpy(lvb, val, len); |
| 559 | |
| 560 | spin_unlock(&lockres->l_lock); |
| 561 | } |
| 562 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 563 | ssize_t user_dlm_read_lvb(struct inode *inode, |
| 564 | char *val, |
| 565 | unsigned int len) |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 566 | { |
| 567 | struct user_lock_res *lockres = &DLMFS_I(inode)->ip_lockres; |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 568 | char *lvb; |
| 569 | ssize_t ret = len; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 570 | |
| 571 | BUG_ON(len > DLM_LVB_LEN); |
| 572 | |
| 573 | spin_lock(&lockres->l_lock); |
| 574 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 575 | BUG_ON(lockres->l_level < DLM_LOCK_PR); |
| 576 | if (ocfs2_dlm_lvb_valid(&lockres->l_lksb)) { |
| 577 | lvb = ocfs2_dlm_lvb(&lockres->l_lksb); |
| 578 | memcpy(val, lvb, len); |
| 579 | } else |
| 580 | ret = 0; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 581 | |
| 582 | spin_unlock(&lockres->l_lock); |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 583 | return ret; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 584 | } |
| 585 | |
| 586 | void user_dlm_lock_res_init(struct user_lock_res *lockres, |
| 587 | struct dentry *dentry) |
| 588 | { |
| 589 | memset(lockres, 0, sizeof(*lockres)); |
| 590 | |
| 591 | spin_lock_init(&lockres->l_lock); |
| 592 | init_waitqueue_head(&lockres->l_event); |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 593 | lockres->l_level = DLM_LOCK_IV; |
| 594 | lockres->l_requested = DLM_LOCK_IV; |
| 595 | lockres->l_blocking = DLM_LOCK_IV; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 596 | |
| 597 | /* should have been checked before getting here. */ |
| 598 | BUG_ON(dentry->d_name.len >= USER_DLM_LOCK_ID_MAX_LEN); |
| 599 | |
| 600 | memcpy(lockres->l_name, |
| 601 | dentry->d_name.name, |
| 602 | dentry->d_name.len); |
Mark Fasheh | ea5b3a1 | 2006-09-08 11:39:27 -0700 | [diff] [blame] | 603 | lockres->l_namelen = dentry->d_name.len; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 604 | } |
| 605 | |
| 606 | int user_dlm_destroy_lock(struct user_lock_res *lockres) |
| 607 | { |
| 608 | int status = -EBUSY; |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 609 | struct ocfs2_cluster_connection *conn = |
| 610 | cluster_connection_from_user_lockres(lockres); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 611 | |
Sunil Mushran | 6fcef3f | 2010-02-26 19:42:45 -0800 | [diff] [blame] | 612 | mlog(ML_BASTS, "lockres %.*s\n", lockres->l_namelen, lockres->l_name); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 613 | |
| 614 | spin_lock(&lockres->l_lock); |
Mark Fasheh | 2cd9888 | 2006-03-29 16:49:13 -0800 | [diff] [blame] | 615 | if (lockres->l_flags & USER_LOCK_IN_TEARDOWN) { |
Mark Fasheh | 2cd9888 | 2006-03-29 16:49:13 -0800 | [diff] [blame] | 616 | spin_unlock(&lockres->l_lock); |
| 617 | return 0; |
| 618 | } |
| 619 | |
| 620 | lockres->l_flags |= USER_LOCK_IN_TEARDOWN; |
| 621 | |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 622 | while (lockres->l_flags & USER_LOCK_BUSY) { |
| 623 | spin_unlock(&lockres->l_lock); |
| 624 | |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 625 | user_wait_on_busy_lock(lockres); |
| 626 | |
| 627 | spin_lock(&lockres->l_lock); |
| 628 | } |
| 629 | |
| 630 | if (lockres->l_ro_holders || lockres->l_ex_holders) { |
| 631 | spin_unlock(&lockres->l_lock); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 632 | goto bail; |
| 633 | } |
| 634 | |
| 635 | status = 0; |
| 636 | if (!(lockres->l_flags & USER_LOCK_ATTACHED)) { |
| 637 | spin_unlock(&lockres->l_lock); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 638 | goto bail; |
| 639 | } |
| 640 | |
| 641 | lockres->l_flags &= ~USER_LOCK_ATTACHED; |
| 642 | lockres->l_flags |= USER_LOCK_BUSY; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 643 | spin_unlock(&lockres->l_lock); |
| 644 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 645 | status = ocfs2_dlm_unlock(conn, &lockres->l_lksb, DLM_LKF_VALBLK); |
| 646 | if (status) { |
| 647 | user_log_dlm_error("ocfs2_dlm_unlock", status, lockres); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 648 | goto bail; |
| 649 | } |
| 650 | |
| 651 | user_wait_on_busy_lock(lockres); |
| 652 | |
| 653 | status = 0; |
| 654 | bail: |
| 655 | return status; |
| 656 | } |
| 657 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 658 | static void user_dlm_recovery_handler_noop(int node_num, |
| 659 | void *recovery_data) |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 660 | { |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 661 | /* We ignore recovery events */ |
| 662 | return; |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 663 | } |
| 664 | |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 665 | void user_dlm_set_locking_protocol(void) |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 666 | { |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 667 | ocfs2_stack_glue_set_max_proto_version(&user_dlm_lproto.lp_max_version); |
| 668 | } |
| 669 | |
| 670 | struct ocfs2_cluster_connection *user_dlm_register(struct qstr *name) |
| 671 | { |
| 672 | int rc; |
| 673 | struct ocfs2_cluster_connection *conn; |
| 674 | |
Joel Becker | cbe0e33 | 2010-01-30 06:02:10 -0800 | [diff] [blame] | 675 | rc = ocfs2_cluster_connect_agnostic(name->name, name->len, |
| 676 | &user_dlm_lproto, |
| 677 | user_dlm_recovery_handler_noop, |
| 678 | NULL, &conn); |
Joel Becker | 0016eed | 2010-01-30 04:33:50 -0800 | [diff] [blame] | 679 | if (rc) |
| 680 | mlog_errno(rc); |
| 681 | |
| 682 | return rc ? ERR_PTR(rc) : conn; |
| 683 | } |
| 684 | |
| 685 | void user_dlm_unregister(struct ocfs2_cluster_connection *conn) |
| 686 | { |
| 687 | ocfs2_cluster_disconnect(conn, 0); |
Mark Fasheh | 8df08c8 | 2005-12-15 14:31:23 -0800 | [diff] [blame] | 688 | } |