blob: df26ee9caa6859de033998c76784f6896101cdb7 [file] [log] [blame]
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -07001/******************************************************************************
2 * balloon.c
3 *
4 * Xen balloon driver - enables returning/claiming memory to/from Xen.
5 *
6 * Copyright (c) 2003, B Dragovic
7 * Copyright (c) 2003-2004, M Williamson, K Fraser
8 * Copyright (c) 2005 Dan M. Smith, IBM Corporation
9 *
10 * This program is free software; you can redistribute it and/or
11 * modify it under the terms of the GNU General Public License version 2
12 * as published by the Free Software Foundation; or, when distributed
13 * separately from the Linux kernel or incorporated into other
14 * software packages, subject to the following license:
15 *
16 * Permission is hereby granted, free of charge, to any person obtaining a copy
17 * of this source file (the "Software"), to deal in the Software without
18 * restriction, including without limitation the rights to use, copy, modify,
19 * merge, publish, distribute, sublicense, and/or sell copies of the Software,
20 * and to permit persons to whom the Software is furnished to do so, subject to
21 * the following conditions:
22 *
23 * The above copyright notice and this permission notice shall be included in
24 * all copies or substantial portions of the Software.
25 *
26 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
27 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
28 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
29 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
30 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
31 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
32 * IN THE SOFTWARE.
33 */
34
35#include <linux/kernel.h>
36#include <linux/module.h>
37#include <linux/sched.h>
38#include <linux/errno.h>
39#include <linux/mm.h>
40#include <linux/bootmem.h>
41#include <linux/pagemap.h>
42#include <linux/highmem.h>
43#include <linux/mutex.h>
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -070044#include <linux/list.h>
45#include <linux/sysdev.h>
Tejun Heo5a0e3ad2010-03-24 17:04:11 +090046#include <linux/gfp.h>
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -070047
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -070048#include <asm/page.h>
49#include <asm/pgalloc.h>
50#include <asm/pgtable.h>
51#include <asm/uaccess.h>
52#include <asm/tlb.h>
53
Jeremy Fitzhardingeecbf29c2008-12-16 12:37:07 -080054#include <asm/xen/hypervisor.h>
55#include <asm/xen/hypercall.h>
Jeremy Fitzhardinge1ccbf532009-10-06 15:11:14 -070056
57#include <xen/xen.h>
Jeremy Fitzhardingeecbf29c2008-12-16 12:37:07 -080058#include <xen/interface/xen.h>
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -070059#include <xen/interface/memory.h>
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -070060#include <xen/xenbus.h>
61#include <xen/features.h>
62#include <xen/page.h>
63
64#define PAGES2KB(_p) ((_p)<<(PAGE_SHIFT-10))
65
Jeremy Fitzhardinge167e6cf2008-07-24 16:27:52 -070066#define BALLOON_CLASS_NAME "xen_memory"
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -070067
68struct balloon_stats {
69 /* We aim for 'current allocation' == 'target allocation'. */
70 unsigned long current_pages;
71 unsigned long target_pages;
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -070072 /*
73 * Drivers may alter the memory reservation independently, but they
74 * must inform the balloon driver so we avoid hitting the hard limit.
75 */
76 unsigned long driver_pages;
77 /* Number of pages in high- and low-memory balloons. */
78 unsigned long balloon_low;
79 unsigned long balloon_high;
80};
81
82static DEFINE_MUTEX(balloon_mutex);
83
84static struct sys_device balloon_sysdev;
85
86static int register_balloon(struct sys_device *sysdev);
87
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -070088static struct balloon_stats balloon_stats;
89
90/* We increase/decrease in batches which fit in a page */
91static unsigned long frame_list[PAGE_SIZE / sizeof(unsigned long)];
92
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -070093#ifdef CONFIG_HIGHMEM
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -070094#define inc_totalhigh_pages() (totalhigh_pages++)
95#define dec_totalhigh_pages() (totalhigh_pages--)
96#else
97#define inc_totalhigh_pages() do {} while(0)
98#define dec_totalhigh_pages() do {} while(0)
99#endif
100
101/* List of ballooned pages, threaded through the mem_map array. */
102static LIST_HEAD(ballooned_pages);
103
104/* Main work function, always executed in process context. */
105static void balloon_process(struct work_struct *work);
106static DECLARE_WORK(balloon_worker, balloon_process);
107static struct timer_list balloon_timer;
108
109/* When ballooning out (allocating memory to return to Xen) we don't really
110 want the kernel to try too hard since that can trigger the oom killer. */
111#define GFP_BALLOON \
112 (GFP_HIGHUSER | __GFP_NOWARN | __GFP_NORETRY | __GFP_NOMEMALLOC)
113
114static void scrub_page(struct page *page)
115{
116#ifdef CONFIG_XEN_SCRUB_PAGES
Jeremy Fitzhardinge26a3e992008-11-17 09:35:00 -0800117 clear_highpage(page);
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700118#endif
119}
120
121/* balloon_append: add the given page to the balloon. */
Jeremy Fitzhardinge9be4d452010-08-31 15:01:16 -0700122static void __balloon_append(struct page *page)
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700123{
124 /* Lowmem is re-populated first, so highmem pages go at list tail. */
125 if (PageHighMem(page)) {
126 list_add_tail(&page->lru, &ballooned_pages);
127 balloon_stats.balloon_high++;
128 dec_totalhigh_pages();
129 } else {
130 list_add(&page->lru, &ballooned_pages);
131 balloon_stats.balloon_low++;
132 }
Jeremy Fitzhardinge9be4d452010-08-31 15:01:16 -0700133}
Gianluca Guida3d65c942009-07-30 22:54:36 +0100134
Jeremy Fitzhardinge9be4d452010-08-31 15:01:16 -0700135static void balloon_append(struct page *page)
136{
137 __balloon_append(page);
Gianluca Guida3d65c942009-07-30 22:54:36 +0100138 totalram_pages--;
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700139}
140
141/* balloon_retrieve: rescue a page from the balloon, if it is not empty. */
142static struct page *balloon_retrieve(void)
143{
144 struct page *page;
145
146 if (list_empty(&ballooned_pages))
147 return NULL;
148
149 page = list_entry(ballooned_pages.next, struct page, lru);
150 list_del(&page->lru);
151
152 if (PageHighMem(page)) {
153 balloon_stats.balloon_high--;
154 inc_totalhigh_pages();
155 }
156 else
157 balloon_stats.balloon_low--;
158
Gianluca Guida3d65c942009-07-30 22:54:36 +0100159 totalram_pages++;
160
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700161 return page;
162}
163
164static struct page *balloon_first_page(void)
165{
166 if (list_empty(&ballooned_pages))
167 return NULL;
168 return list_entry(ballooned_pages.next, struct page, lru);
169}
170
171static struct page *balloon_next_page(struct page *page)
172{
173 struct list_head *next = page->lru.next;
174 if (next == &ballooned_pages)
175 return NULL;
176 return list_entry(next, struct page, lru);
177}
178
179static void balloon_alarm(unsigned long unused)
180{
181 schedule_work(&balloon_worker);
182}
183
184static unsigned long current_target(void)
185{
Ian Campbellbc2c0302009-06-05 11:58:37 +0100186 unsigned long target = balloon_stats.target_pages;
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700187
188 target = min(target,
189 balloon_stats.current_pages +
190 balloon_stats.balloon_low +
191 balloon_stats.balloon_high);
192
193 return target;
194}
195
196static int increase_reservation(unsigned long nr_pages)
197{
198 unsigned long pfn, i, flags;
199 struct page *page;
200 long rc;
201 struct xen_memory_reservation reservation = {
202 .address_bits = 0,
203 .extent_order = 0,
204 .domid = DOMID_SELF
205 };
206
207 if (nr_pages > ARRAY_SIZE(frame_list))
208 nr_pages = ARRAY_SIZE(frame_list);
209
Alex Nixon19001c82009-02-09 12:05:46 -0800210 spin_lock_irqsave(&xen_reservation_lock, flags);
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700211
212 page = balloon_first_page();
213 for (i = 0; i < nr_pages; i++) {
214 BUG_ON(page == NULL);
Joe Perchesa419aef2009-08-18 11:18:35 -0700215 frame_list[i] = page_to_pfn(page);
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700216 page = balloon_next_page(page);
217 }
218
Isaku Yamahataa90971e2008-05-26 23:31:14 +0100219 set_xen_guest_handle(reservation.extent_start, frame_list);
Jeremy Fitzhardingefde28e82008-07-24 16:28:00 -0700220 reservation.nr_extents = nr_pages;
221 rc = HYPERVISOR_memory_op(XENMEM_populate_physmap, &reservation);
Ian Campbellbc2c0302009-06-05 11:58:37 +0100222 if (rc < 0)
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700223 goto out;
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700224
Ian Campbellbc2c0302009-06-05 11:58:37 +0100225 for (i = 0; i < rc; i++) {
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700226 page = balloon_retrieve();
227 BUG_ON(page == NULL);
228
229 pfn = page_to_pfn(page);
230 BUG_ON(!xen_feature(XENFEAT_auto_translated_physmap) &&
231 phys_to_machine_mapping_valid(pfn));
232
233 set_phys_to_machine(pfn, frame_list[i]);
234
235 /* Link back into the page tables if not highmem. */
236 if (pfn < max_low_pfn) {
237 int ret;
238 ret = HYPERVISOR_update_va_mapping(
239 (unsigned long)__va(pfn << PAGE_SHIFT),
240 mfn_pte(frame_list[i], PAGE_KERNEL),
241 0);
242 BUG_ON(ret);
243 }
244
245 /* Relinquish the page back to the allocator. */
246 ClearPageReserved(page);
247 init_page_count(page);
248 __free_page(page);
249 }
250
Ian Campbellbc2c0302009-06-05 11:58:37 +0100251 balloon_stats.current_pages += rc;
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700252
253 out:
Alex Nixon19001c82009-02-09 12:05:46 -0800254 spin_unlock_irqrestore(&xen_reservation_lock, flags);
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700255
Ian Campbellbc2c0302009-06-05 11:58:37 +0100256 return rc < 0 ? rc : rc != nr_pages;
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700257}
258
259static int decrease_reservation(unsigned long nr_pages)
260{
261 unsigned long pfn, i, flags;
262 struct page *page;
263 int need_sleep = 0;
264 int ret;
265 struct xen_memory_reservation reservation = {
266 .address_bits = 0,
267 .extent_order = 0,
268 .domid = DOMID_SELF
269 };
270
271 if (nr_pages > ARRAY_SIZE(frame_list))
272 nr_pages = ARRAY_SIZE(frame_list);
273
274 for (i = 0; i < nr_pages; i++) {
275 if ((page = alloc_page(GFP_BALLOON)) == NULL) {
276 nr_pages = i;
277 need_sleep = 1;
278 break;
279 }
280
281 pfn = page_to_pfn(page);
282 frame_list[i] = pfn_to_mfn(pfn);
283
284 scrub_page(page);
Dan Magenheimer1058a752009-01-22 14:36:08 -0800285
Ian Campbellff4ce8c2009-01-23 16:26:21 +0000286 if (!PageHighMem(page)) {
287 ret = HYPERVISOR_update_va_mapping(
288 (unsigned long)__va(pfn << PAGE_SHIFT),
289 __pte_ma(0), 0);
290 BUG_ON(ret);
291 }
292
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700293 }
294
295 /* Ensure that ballooned highmem pages don't have kmaps. */
296 kmap_flush_unused();
297 flush_tlb_all();
298
Alex Nixon19001c82009-02-09 12:05:46 -0800299 spin_lock_irqsave(&xen_reservation_lock, flags);
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700300
301 /* No more mappings: invalidate P2M and add to balloon. */
302 for (i = 0; i < nr_pages; i++) {
303 pfn = mfn_to_pfn(frame_list[i]);
304 set_phys_to_machine(pfn, INVALID_P2M_ENTRY);
305 balloon_append(pfn_to_page(pfn));
306 }
307
Isaku Yamahataa90971e2008-05-26 23:31:14 +0100308 set_xen_guest_handle(reservation.extent_start, frame_list);
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700309 reservation.nr_extents = nr_pages;
310 ret = HYPERVISOR_memory_op(XENMEM_decrease_reservation, &reservation);
311 BUG_ON(ret != nr_pages);
312
313 balloon_stats.current_pages -= nr_pages;
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700314
Alex Nixon19001c82009-02-09 12:05:46 -0800315 spin_unlock_irqrestore(&xen_reservation_lock, flags);
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700316
317 return need_sleep;
318}
319
320/*
321 * We avoid multiple worker processes conflicting via the balloon mutex.
322 * We may of course race updates of the target counts (which are protected
323 * by the balloon lock), or with changes to the Xen hard limit, but we will
324 * recover from these in time.
325 */
326static void balloon_process(struct work_struct *work)
327{
328 int need_sleep = 0;
329 long credit;
330
331 mutex_lock(&balloon_mutex);
332
333 do {
334 credit = current_target() - balloon_stats.current_pages;
335 if (credit > 0)
336 need_sleep = (increase_reservation(credit) != 0);
337 if (credit < 0)
338 need_sleep = (decrease_reservation(-credit) != 0);
339
340#ifndef CONFIG_PREEMPT
341 if (need_resched())
342 schedule();
343#endif
344 } while ((credit != 0) && !need_sleep);
345
346 /* Schedule more work if there is some still to be done. */
347 if (current_target() != balloon_stats.current_pages)
348 mod_timer(&balloon_timer, jiffies + HZ);
349
350 mutex_unlock(&balloon_mutex);
351}
352
353/* Resets the Xen limit, sets new target, and kicks off processing. */
Adrian Bunk955d6f12008-05-26 23:31:17 +0100354static void balloon_set_new_target(unsigned long target)
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700355{
356 /* No need for lock. Not read-modify-write updates. */
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700357 balloon_stats.target_pages = target;
358 schedule_work(&balloon_worker);
359}
360
361static struct xenbus_watch target_watch =
362{
363 .node = "memory/target"
364};
365
366/* React to a change in the target key */
367static void watch_target(struct xenbus_watch *watch,
368 const char **vec, unsigned int len)
369{
370 unsigned long long new_target;
371 int err;
372
373 err = xenbus_scanf(XBT_NIL, "memory", "target", "%llu", &new_target);
374 if (err != 1) {
375 /* This is ok (for domain0 at least) - so just return */
376 return;
377 }
378
379 /* The given memory/target value is in KiB, so it needs converting to
380 * pages. PAGE_SHIFT converts bytes to pages, hence PAGE_SHIFT - 10.
381 */
382 balloon_set_new_target(new_target >> (PAGE_SHIFT - 10));
383}
384
385static int balloon_init_watcher(struct notifier_block *notifier,
386 unsigned long event,
387 void *data)
388{
389 int err;
390
391 err = register_xenbus_watch(&target_watch);
392 if (err)
393 printk(KERN_ERR "Failed to set balloon watcher\n");
394
395 return NOTIFY_DONE;
396}
397
398static struct notifier_block xenstore_notifier;
399
400static int __init balloon_init(void)
401{
402 unsigned long pfn;
403 struct page *page;
404
Jeremy Fitzhardinge6e833582008-08-19 13:16:17 -0700405 if (!xen_pv_domain())
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700406 return -ENODEV;
407
408 pr_info("xen_balloon: Initialising balloon driver.\n");
409
410 balloon_stats.current_pages = min(xen_start_info->nr_pages, max_pfn);
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700411 balloon_stats.target_pages = balloon_stats.current_pages;
412 balloon_stats.balloon_low = 0;
413 balloon_stats.balloon_high = 0;
414 balloon_stats.driver_pages = 0UL;
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700415
416 init_timer(&balloon_timer);
417 balloon_timer.data = 0;
418 balloon_timer.function = balloon_alarm;
419
420 register_balloon(&balloon_sysdev);
421
422 /* Initialise the balloon with excess memory space. */
Jeremy Fitzhardinge9be4d452010-08-31 15:01:16 -0700423 for (pfn = PFN_UP(xen_extra_mem_start);
424 pfn < PFN_DOWN(xen_extra_mem_start + xen_extra_mem_size);
425 pfn++) {
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700426 page = pfn_to_page(pfn);
Jeremy Fitzhardinge9be4d452010-08-31 15:01:16 -0700427 /* totalram_pages doesn't include the boot-time
428 balloon extension, so don't subtract from it. */
429 __balloon_append(page);
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700430 }
431
432 target_watch.callback = watch_target;
433 xenstore_notifier.notifier_call = balloon_init_watcher;
434
435 register_xenstore_notifier(&xenstore_notifier);
436
437 return 0;
438}
439
440subsys_initcall(balloon_init);
441
442static void balloon_exit(void)
443{
444 /* XXX - release balloon here */
445 return;
446}
447
448module_exit(balloon_exit);
449
Jeremy Fitzhardinge167e6cf2008-07-24 16:27:52 -0700450#define BALLOON_SHOW(name, format, args...) \
451 static ssize_t show_##name(struct sys_device *dev, \
452 struct sysdev_attribute *attr, \
453 char *buf) \
454 { \
455 return sprintf(buf, format, ##args); \
456 } \
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700457 static SYSDEV_ATTR(name, S_IRUGO, show_##name, NULL)
458
459BALLOON_SHOW(current_kb, "%lu\n", PAGES2KB(balloon_stats.current_pages));
460BALLOON_SHOW(low_kb, "%lu\n", PAGES2KB(balloon_stats.balloon_low));
461BALLOON_SHOW(high_kb, "%lu\n", PAGES2KB(balloon_stats.balloon_high));
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700462BALLOON_SHOW(driver_kb, "%lu\n", PAGES2KB(balloon_stats.driver_pages));
463
Jeremy Fitzhardinge167e6cf2008-07-24 16:27:52 -0700464static ssize_t show_target_kb(struct sys_device *dev, struct sysdev_attribute *attr,
465 char *buf)
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700466{
467 return sprintf(buf, "%lu\n", PAGES2KB(balloon_stats.target_pages));
468}
469
470static ssize_t store_target_kb(struct sys_device *dev,
Andi Kleen4a0b2b42008-07-01 18:48:41 +0200471 struct sysdev_attribute *attr,
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700472 const char *buf,
473 size_t count)
474{
Jeremy Fitzhardinge167e6cf2008-07-24 16:27:52 -0700475 char *endchar;
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700476 unsigned long long target_bytes;
477
478 if (!capable(CAP_SYS_ADMIN))
479 return -EPERM;
480
Jeremy Fitzhardinge618b2c82009-01-28 16:50:20 -0800481 target_bytes = simple_strtoull(buf, &endchar, 0) * 1024;
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700482
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700483 balloon_set_new_target(target_bytes >> PAGE_SHIFT);
484
485 return count;
486}
487
488static SYSDEV_ATTR(target_kb, S_IRUGO | S_IWUSR,
489 show_target_kb, store_target_kb);
490
Jeremy Fitzhardinge618b2c82009-01-28 16:50:20 -0800491
492static ssize_t show_target(struct sys_device *dev, struct sysdev_attribute *attr,
493 char *buf)
494{
495 return sprintf(buf, "%llu\n",
Jan Beulich06926982009-05-05 13:57:52 +0100496 (unsigned long long)balloon_stats.target_pages
497 << PAGE_SHIFT);
Jeremy Fitzhardinge618b2c82009-01-28 16:50:20 -0800498}
499
500static ssize_t store_target(struct sys_device *dev,
501 struct sysdev_attribute *attr,
502 const char *buf,
503 size_t count)
504{
505 char *endchar;
506 unsigned long long target_bytes;
507
508 if (!capable(CAP_SYS_ADMIN))
509 return -EPERM;
510
511 target_bytes = memparse(buf, &endchar);
512
513 balloon_set_new_target(target_bytes >> PAGE_SHIFT);
514
515 return count;
516}
517
518static SYSDEV_ATTR(target, S_IRUGO | S_IWUSR,
519 show_target, store_target);
520
521
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700522static struct sysdev_attribute *balloon_attrs[] = {
523 &attr_target_kb,
Jeremy Fitzhardinge618b2c82009-01-28 16:50:20 -0800524 &attr_target,
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700525};
526
527static struct attribute *balloon_info_attrs[] = {
528 &attr_current_kb.attr,
529 &attr_low_kb.attr,
530 &attr_high_kb.attr,
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700531 &attr_driver_kb.attr,
532 NULL
533};
534
535static struct attribute_group balloon_info_group = {
536 .name = "info",
537 .attrs = balloon_info_attrs,
538};
539
540static struct sysdev_class balloon_sysdev_class = {
541 .name = BALLOON_CLASS_NAME,
542};
543
544static int register_balloon(struct sys_device *sysdev)
545{
546 int i, error;
547
548 error = sysdev_class_register(&balloon_sysdev_class);
549 if (error)
550 return error;
551
552 sysdev->id = 0;
553 sysdev->cls = &balloon_sysdev_class;
554
555 error = sysdev_register(sysdev);
556 if (error) {
557 sysdev_class_unregister(&balloon_sysdev_class);
558 return error;
559 }
560
561 for (i = 0; i < ARRAY_SIZE(balloon_attrs); i++) {
562 error = sysdev_create_file(sysdev, balloon_attrs[i]);
563 if (error)
564 goto fail;
565 }
566
567 error = sysfs_create_group(&sysdev->kobj, &balloon_info_group);
568 if (error)
569 goto fail;
570
571 return 0;
572
573 fail:
574 while (--i >= 0)
575 sysdev_remove_file(sysdev, balloon_attrs[i]);
576 sysdev_unregister(sysdev);
577 sysdev_class_unregister(&balloon_sysdev_class);
578 return error;
579}
580
Jeremy Fitzhardinge17758262008-04-02 10:54:13 -0700581MODULE_LICENSE("GPL");