blob: a26ba7a17c2be824797c728bc415cc2e3fd49bdb [file] [log] [blame]
Linus Torvalds1da177e2005-04-16 15:20:36 -07001/*
Guenter Roeck19f2c052012-01-14 13:26:08 -08002 * ds1621.c - Part of lm_sensors, Linux kernel modules for hardware
3 * monitoring
4 * Christian W. Zuckschwerdt <zany@triq.net> 2000-11-23
5 * based on lm75.c by Frodo Looijaard <frodol@dds.nl>
6 * Ported to Linux 2.6 by Aurelien Jarno <aurelien@aurel32.net> with
7 * the help of Jean Delvare <khali@linux-fr.org>
8 *
Robert Coulsoncd6c8a42013-05-08 22:45:53 -07009 * The DS1621 device is a digital temperature/thermometer with 9-bit
10 * resolution, a thermal alarm output (Tout), and user-defined minimum
11 * and maximum temperature thresholds (TH and TL).
12 *
Robert Coulson260f81f2013-06-10 18:46:02 -070013 * The DS1625, DS1631, DS1721, and DS1731 are pin compatible with the DS1621
14 * and similar in operation, with slight variations as noted in the device
Robert Coulsoncd6c8a42013-05-08 22:45:53 -070015 * datasheets (please refer to www.maximintegrated.com for specific
16 * device information).
17 *
18 * Since the DS1621 was the first chipset supported by this driver,
19 * most comments will refer to this chipset, but are actually general
20 * and concern all supported chipsets, unless mentioned otherwise.
21 *
Guenter Roeck19f2c052012-01-14 13:26:08 -080022 * This program is free software; you can redistribute it and/or modify
23 * it under the terms of the GNU General Public License as published by
24 * the Free Software Foundation; either version 2 of the License, or
25 * (at your option) any later version.
26 *
27 * This program is distributed in the hope that it will be useful,
28 * but WITHOUT ANY WARRANTY; without even the implied warranty of
29 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
30 * GNU General Public License for more details.
31 *
32 * You should have received a copy of the GNU General Public License
33 * along with this program; if not, write to the Free Software
34 * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
35 */
Linus Torvalds1da177e2005-04-16 15:20:36 -070036
37#include <linux/module.h>
38#include <linux/init.h>
39#include <linux/slab.h>
40#include <linux/jiffies.h>
41#include <linux/i2c.h>
Mark M. Hoffman943b0832005-07-15 21:39:18 -040042#include <linux/hwmon.h>
Jean Delvare46a2e712007-06-09 10:11:15 -040043#include <linux/hwmon-sysfs.h>
Mark M. Hoffman943b0832005-07-15 21:39:18 -040044#include <linux/err.h>
Ingo Molnar9a61bf62006-01-18 23:19:26 +010045#include <linux/mutex.h>
Jean Delvarea5ebe662006-09-24 21:24:46 +020046#include <linux/sysfs.h>
Robert Coulsoncd6c8a42013-05-08 22:45:53 -070047#include <linux/kernel.h>
Linus Torvalds1da177e2005-04-16 15:20:36 -070048
Robert Coulsoncd6c8a42013-05-08 22:45:53 -070049/* Supported devices */
Robert Coulson260f81f2013-06-10 18:46:02 -070050enum chips { ds1621, ds1625, ds1631, ds1721, ds1731 };
Robert Coulsoncd6c8a42013-05-08 22:45:53 -070051
Linus Torvalds1da177e2005-04-16 15:20:36 -070052/* Insmod parameters */
Linus Torvalds1da177e2005-04-16 15:20:36 -070053static int polarity = -1;
54module_param(polarity, int, 0);
55MODULE_PARM_DESC(polarity, "Output's polarity: 0 = active high, 1 = active low");
56
Robert Coulsoncd6c8a42013-05-08 22:45:53 -070057/*
58 * The Configuration/Status register
59 *
60 * - DS1621:
61 * 7 6 5 4 3 2 1 0
62 * |Done|THF |TLF |NVB | X | X |POL |1SHOT|
63 *
64 * - DS1625:
65 * 7 6 5 4 3 2 1 0
66 * |Done|THF |TLF |NVB | 1 | 0 |POL |1SHOT|
67 *
Robert Coulson260f81f2013-06-10 18:46:02 -070068 * - DS1631, DS1731:
Robert Coulson79c1cc12013-05-16 15:10:41 -070069 * 7 6 5 4 3 2 1 0
70 * |Done|THF |TLF |NVB | R1 | R0 |POL |1SHOT|
71 *
Robert Coulsoncd6c8a42013-05-08 22:45:53 -070072 * - DS1721:
73 * 7 6 5 4 3 2 1 0
74 * |Done| X | X | U | R1 | R0 |POL |1SHOT|
75 *
76 * Where:
77 * - 'X' is Reserved
78 * - 'U' is Undefined
79 */
Linus Torvalds1da177e2005-04-16 15:20:36 -070080#define DS1621_REG_CONFIG_NVB 0x10
Robert Coulsoncd6c8a42013-05-08 22:45:53 -070081#define DS1621_REG_CONFIG_RESOL 0x0C
Linus Torvalds1da177e2005-04-16 15:20:36 -070082#define DS1621_REG_CONFIG_POLARITY 0x02
83#define DS1621_REG_CONFIG_1SHOT 0x01
84#define DS1621_REG_CONFIG_DONE 0x80
85
Robert Coulsoncd6c8a42013-05-08 22:45:53 -070086#define DS1621_REG_CONFIG_RESOL_SHIFT 2
87
88/* ds1721 conversion rates: {C/LSB, time(ms), resolution bit setting} */
89static const unsigned short ds1721_convrates[] = {
90 94, /* 9-bits (0.5, 93.75, RES[0..1] = 0 */
91 188, /* 10-bits (0.25, 187.5, RES[0..1] = 1 */
92 375, /* 11-bits (0.125, 375, RES[0..1] = 2 */
93 750, /* 12-bits (0.0625, 750, RES[0..1] = 3 */
94};
95
96#define DS1621_CONVERSION_MAX 750
97#define DS1625_CONVERSION_MAX 500
98
99#define DS1621_TEMP_MAX 125000
100#define DS1621_TEMP_MIN (-55000)
101
102/* The DS1621 temperature registers */
Jean Delvare46a2e712007-06-09 10:11:15 -0400103static const u8 DS1621_REG_TEMP[3] = {
104 0xAA, /* input, word, RO */
105 0xA2, /* min, word, RW */
106 0xA1, /* max, word, RW */
107};
Linus Torvalds1da177e2005-04-16 15:20:36 -0700108#define DS1621_REG_CONF 0xAC /* byte, RW */
109#define DS1621_COM_START 0xEE /* no data */
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700110#define DS1721_COM_START 0x51 /* no data */
Linus Torvalds1da177e2005-04-16 15:20:36 -0700111#define DS1621_COM_STOP 0x22 /* no data */
112
113/* The DS1621 configuration register */
114#define DS1621_ALARM_TEMP_HIGH 0x40
115#define DS1621_ALARM_TEMP_LOW 0x20
116
Jean Delvare75819f02007-06-09 10:11:15 -0400117/* Conversions */
Linus Torvalds1da177e2005-04-16 15:20:36 -0700118#define ALARMS_FROM_REG(val) ((val) & \
Guenter Roeck19f2c052012-01-14 13:26:08 -0800119 (DS1621_ALARM_TEMP_HIGH | DS1621_ALARM_TEMP_LOW))
Linus Torvalds1da177e2005-04-16 15:20:36 -0700120
121/* Each client has this additional data */
122struct ds1621_data {
Tony Jones1beeffe2007-08-20 13:46:20 -0700123 struct device *hwmon_dev;
Ingo Molnar9a61bf62006-01-18 23:19:26 +0100124 struct mutex update_lock;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700125 char valid; /* !=0 if following fields are valid */
126 unsigned long last_updated; /* In jiffies */
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700127 enum chips kind; /* device type */
Linus Torvalds1da177e2005-04-16 15:20:36 -0700128
Jean Delvare46a2e712007-06-09 10:11:15 -0400129 u16 temp[3]; /* Register values, word */
Linus Torvalds1da177e2005-04-16 15:20:36 -0700130 u8 conf; /* Register encoding, combined */
Guenter Roecka50d9a42013-06-27 10:07:19 -0700131 u8 zbits; /* Resolution encoded as number of
132 * zero bits */
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700133 u16 update_interval; /* Conversion rate in milliseconds */
Linus Torvalds1da177e2005-04-16 15:20:36 -0700134};
135
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700136static inline int DS1621_TEMP_FROM_REG(u16 reg)
137{
138 return DIV_ROUND_CLOSEST(((s16)reg / 16) * 625, 10);
139}
140
141/*
142 * TEMP: 0.001C/bit (-55C to +125C)
143 * REG:
Guenter Roecka50d9a42013-06-27 10:07:19 -0700144 * - 1621, 1625: 0.5C/bit, 7 zero-bits
145 * - 1631, 1721, 1731: 0.0625C/bit, 4 zero-bits
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700146 */
Guenter Roecka50d9a42013-06-27 10:07:19 -0700147static inline u16 DS1621_TEMP_TO_REG(long temp, u8 zbits)
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700148{
Guenter Roecka50d9a42013-06-27 10:07:19 -0700149 temp = clamp_val(temp, DS1621_TEMP_MIN, DS1621_TEMP_MAX);
150 temp = DIV_ROUND_CLOSEST(temp * (1 << (8 - zbits)), 1000) << zbits;
151 return temp;
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700152}
153
Linus Torvalds1da177e2005-04-16 15:20:36 -0700154static void ds1621_init_client(struct i2c_client *client)
155{
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700156 u8 conf, new_conf, sreg, resol;
157 struct ds1621_data *data = i2c_get_clientdata(client);
Jean Delvaree4879e22009-03-30 21:46:40 +0200158
159 new_conf = conf = i2c_smbus_read_byte_data(client, DS1621_REG_CONF);
Steven Cole44bbe872005-05-03 18:21:25 -0600160 /* switch to continuous conversion mode */
Jean Delvaree4879e22009-03-30 21:46:40 +0200161 new_conf &= ~DS1621_REG_CONFIG_1SHOT;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700162
163 /* setup output polarity */
164 if (polarity == 0)
Jean Delvaree4879e22009-03-30 21:46:40 +0200165 new_conf &= ~DS1621_REG_CONFIG_POLARITY;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700166 else if (polarity == 1)
Jean Delvaree4879e22009-03-30 21:46:40 +0200167 new_conf |= DS1621_REG_CONFIG_POLARITY;
Guenter Roeck19f2c052012-01-14 13:26:08 -0800168
Jean Delvaree4879e22009-03-30 21:46:40 +0200169 if (conf != new_conf)
170 i2c_smbus_write_byte_data(client, DS1621_REG_CONF, new_conf);
Guenter Roeck19f2c052012-01-14 13:26:08 -0800171
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700172 switch (data->kind) {
173 case ds1625:
174 data->update_interval = DS1625_CONVERSION_MAX;
Guenter Roecka50d9a42013-06-27 10:07:19 -0700175 data->zbits = 7;
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700176 sreg = DS1621_COM_START;
177 break;
Robert Coulson79c1cc12013-05-16 15:10:41 -0700178 case ds1631:
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700179 case ds1721:
Robert Coulson260f81f2013-06-10 18:46:02 -0700180 case ds1731:
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700181 resol = (new_conf & DS1621_REG_CONFIG_RESOL) >>
182 DS1621_REG_CONFIG_RESOL_SHIFT;
183 data->update_interval = ds1721_convrates[resol];
Guenter Roecka50d9a42013-06-27 10:07:19 -0700184 data->zbits = 7 - resol;
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700185 sreg = DS1721_COM_START;
186 break;
187 default:
188 data->update_interval = DS1621_CONVERSION_MAX;
Guenter Roecka50d9a42013-06-27 10:07:19 -0700189 data->zbits = 7;
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700190 sreg = DS1621_COM_START;
191 break;
192 }
193
Linus Torvalds1da177e2005-04-16 15:20:36 -0700194 /* start conversion */
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700195 i2c_smbus_write_byte(client, sreg);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700196}
197
Jean Delvare9202add2009-03-30 21:46:40 +0200198static struct ds1621_data *ds1621_update_client(struct device *dev)
199{
200 struct i2c_client *client = to_i2c_client(dev);
201 struct ds1621_data *data = i2c_get_clientdata(client);
202 u8 new_conf;
203
204 mutex_lock(&data->update_lock);
205
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700206 if (time_after(jiffies, data->last_updated + data->update_interval) ||
207 !data->valid) {
Jean Delvare9202add2009-03-30 21:46:40 +0200208 int i;
209
210 dev_dbg(&client->dev, "Starting ds1621 update\n");
211
Jean Delvare594592d2009-03-30 21:46:40 +0200212 data->conf = i2c_smbus_read_byte_data(client, DS1621_REG_CONF);
Jean Delvare9202add2009-03-30 21:46:40 +0200213
214 for (i = 0; i < ARRAY_SIZE(data->temp); i++)
Jean Delvare90f41022011-11-04 12:00:47 +0100215 data->temp[i] = i2c_smbus_read_word_swapped(client,
Jean Delvare594592d2009-03-30 21:46:40 +0200216 DS1621_REG_TEMP[i]);
Jean Delvare9202add2009-03-30 21:46:40 +0200217
218 /* reset alarms if necessary */
219 new_conf = data->conf;
220 if (data->temp[0] > data->temp[1]) /* input > min */
221 new_conf &= ~DS1621_ALARM_TEMP_LOW;
222 if (data->temp[0] < data->temp[2]) /* input < max */
223 new_conf &= ~DS1621_ALARM_TEMP_HIGH;
224 if (data->conf != new_conf)
Jean Delvare594592d2009-03-30 21:46:40 +0200225 i2c_smbus_write_byte_data(client, DS1621_REG_CONF,
226 new_conf);
Jean Delvare9202add2009-03-30 21:46:40 +0200227
228 data->last_updated = jiffies;
229 data->valid = 1;
230 }
231
232 mutex_unlock(&data->update_lock);
233
234 return data;
235}
236
Jean Delvare46a2e712007-06-09 10:11:15 -0400237static ssize_t show_temp(struct device *dev, struct device_attribute *da,
238 char *buf)
239{
240 struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
241 struct ds1621_data *data = ds1621_update_client(dev);
242 return sprintf(buf, "%d\n",
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700243 DS1621_TEMP_FROM_REG(data->temp[attr->index]));
Linus Torvalds1da177e2005-04-16 15:20:36 -0700244}
245
Jean Delvare46a2e712007-06-09 10:11:15 -0400246static ssize_t set_temp(struct device *dev, struct device_attribute *da,
247 const char *buf, size_t count)
248{
249 struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
250 struct i2c_client *client = to_i2c_client(dev);
Jean Delvaree4879e22009-03-30 21:46:40 +0200251 struct ds1621_data *data = i2c_get_clientdata(client);
Guenter Roeck19f2c052012-01-14 13:26:08 -0800252 long val;
253 int err;
254
255 err = kstrtol(buf, 10, &val);
256 if (err)
257 return err;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700258
Jean Delvare46a2e712007-06-09 10:11:15 -0400259 mutex_lock(&data->update_lock);
Guenter Roecka50d9a42013-06-27 10:07:19 -0700260 data->temp[attr->index] = DS1621_TEMP_TO_REG(val, data->zbits);
Jean Delvare90f41022011-11-04 12:00:47 +0100261 i2c_smbus_write_word_swapped(client, DS1621_REG_TEMP[attr->index],
262 data->temp[attr->index]);
Jean Delvare46a2e712007-06-09 10:11:15 -0400263 mutex_unlock(&data->update_lock);
264 return count;
Linus Torvalds1da177e2005-04-16 15:20:36 -0700265}
266
Jean Delvare46a2e712007-06-09 10:11:15 -0400267static ssize_t show_alarms(struct device *dev, struct device_attribute *da,
268 char *buf)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700269{
270 struct ds1621_data *data = ds1621_update_client(dev);
271 return sprintf(buf, "%d\n", ALARMS_FROM_REG(data->conf));
272}
273
Jean Delvare87f0f312007-06-09 10:11:15 -0400274static ssize_t show_alarm(struct device *dev, struct device_attribute *da,
275 char *buf)
276{
277 struct sensor_device_attribute *attr = to_sensor_dev_attr(da);
278 struct ds1621_data *data = ds1621_update_client(dev);
279 return sprintf(buf, "%d\n", !!(data->conf & attr->index));
280}
281
Robert Coulson3a8fe332013-05-08 22:45:54 -0700282static ssize_t show_convrate(struct device *dev, struct device_attribute *da,
283 char *buf)
284{
285 struct i2c_client *client = to_i2c_client(dev);
286 struct ds1621_data *data = i2c_get_clientdata(client);
287 return scnprintf(buf, PAGE_SIZE, "%hu\n", data->update_interval);
288}
289
290static ssize_t set_convrate(struct device *dev, struct device_attribute *da,
291 const char *buf, size_t count)
292{
293 struct i2c_client *client = to_i2c_client(dev);
294 struct ds1621_data *data = i2c_get_clientdata(client);
295 unsigned long convrate;
296 s32 err;
297 int resol = 0;
298
299 err = kstrtoul(buf, 10, &convrate);
300 if (err)
301 return err;
302
303 /* Convert rate into resolution bits */
304 while (resol < (ARRAY_SIZE(ds1721_convrates) - 1) &&
305 convrate > ds1721_convrates[resol])
306 resol++;
307
308 mutex_lock(&data->update_lock);
309 data->conf = i2c_smbus_read_byte_data(client, DS1621_REG_CONF);
310 data->conf &= ~DS1621_REG_CONFIG_RESOL;
311 data->conf |= (resol << DS1621_REG_CONFIG_RESOL_SHIFT);
312 i2c_smbus_write_byte_data(client, DS1621_REG_CONF, data->conf);
313 data->update_interval = ds1721_convrates[resol];
314 mutex_unlock(&data->update_lock);
315
316 return count;
317}
318
Linus Torvalds1da177e2005-04-16 15:20:36 -0700319static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
Robert Coulson3a8fe332013-05-08 22:45:54 -0700320static DEVICE_ATTR(update_interval, S_IWUSR | S_IRUGO, show_convrate,
321 set_convrate);
322
Jean Delvare46a2e712007-06-09 10:11:15 -0400323static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL, 0);
324static SENSOR_DEVICE_ATTR(temp1_min, S_IWUSR | S_IRUGO, show_temp, set_temp, 1);
325static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, show_temp, set_temp, 2);
Jean Delvare87f0f312007-06-09 10:11:15 -0400326static SENSOR_DEVICE_ATTR(temp1_min_alarm, S_IRUGO, show_alarm, NULL,
327 DS1621_ALARM_TEMP_LOW);
328static SENSOR_DEVICE_ATTR(temp1_max_alarm, S_IRUGO, show_alarm, NULL,
329 DS1621_ALARM_TEMP_HIGH);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700330
Jean Delvarea5ebe662006-09-24 21:24:46 +0200331static struct attribute *ds1621_attributes[] = {
Jean Delvare46a2e712007-06-09 10:11:15 -0400332 &sensor_dev_attr_temp1_input.dev_attr.attr,
333 &sensor_dev_attr_temp1_min.dev_attr.attr,
334 &sensor_dev_attr_temp1_max.dev_attr.attr,
Jean Delvare87f0f312007-06-09 10:11:15 -0400335 &sensor_dev_attr_temp1_min_alarm.dev_attr.attr,
336 &sensor_dev_attr_temp1_max_alarm.dev_attr.attr,
Jean Delvarea5ebe662006-09-24 21:24:46 +0200337 &dev_attr_alarms.attr,
Robert Coulson3a8fe332013-05-08 22:45:54 -0700338 &dev_attr_update_interval.attr,
Jean Delvarea5ebe662006-09-24 21:24:46 +0200339 NULL
340};
341
Robert Coulson3a8fe332013-05-08 22:45:54 -0700342static umode_t ds1621_attribute_visible(struct kobject *kobj,
343 struct attribute *attr, int index)
344{
345 struct device *dev = container_of(kobj, struct device, kobj);
346 struct i2c_client *client = to_i2c_client(dev);
347 struct ds1621_data *data = i2c_get_clientdata(client);
348
349 if (attr == &dev_attr_update_interval.attr)
Robert Coulson79c1cc12013-05-16 15:10:41 -0700350 if (data->kind == ds1621 || data->kind == ds1625)
Robert Coulson3a8fe332013-05-08 22:45:54 -0700351 /* shhh, we're hiding update_interval */
352 return 0;
353 return attr->mode;
354}
355
Jean Delvarea5ebe662006-09-24 21:24:46 +0200356static const struct attribute_group ds1621_group = {
357 .attrs = ds1621_attributes,
Robert Coulson3a8fe332013-05-08 22:45:54 -0700358 .is_visible = ds1621_attribute_visible
Jean Delvarea5ebe662006-09-24 21:24:46 +0200359};
360
Jean Delvare70313ea2008-07-16 19:30:11 +0200361static int ds1621_probe(struct i2c_client *client,
362 const struct i2c_device_id *id)
363{
364 struct ds1621_data *data;
365 int err;
366
Guenter Roecke20b4b32012-06-02 09:58:03 -0700367 data = devm_kzalloc(&client->dev, sizeof(struct ds1621_data),
368 GFP_KERNEL);
369 if (!data)
370 return -ENOMEM;
Jean Delvare70313ea2008-07-16 19:30:11 +0200371
372 i2c_set_clientdata(client, data);
373 mutex_init(&data->update_lock);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700374
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700375 data->kind = id->driver_data;
376
Linus Torvalds1da177e2005-04-16 15:20:36 -0700377 /* Initialize the DS1621 chip */
Jean Delvare75819f02007-06-09 10:11:15 -0400378 ds1621_init_client(client);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700379
380 /* Register sysfs hooks */
Guenter Roeck19f2c052012-01-14 13:26:08 -0800381 err = sysfs_create_group(&client->dev.kobj, &ds1621_group);
382 if (err)
Guenter Roecke20b4b32012-06-02 09:58:03 -0700383 return err;
Jean Delvarea5ebe662006-09-24 21:24:46 +0200384
Tony Jones1beeffe2007-08-20 13:46:20 -0700385 data->hwmon_dev = hwmon_device_register(&client->dev);
386 if (IS_ERR(data->hwmon_dev)) {
387 err = PTR_ERR(data->hwmon_dev);
Jean Delvarea5ebe662006-09-24 21:24:46 +0200388 goto exit_remove_files;
Mark M. Hoffman943b0832005-07-15 21:39:18 -0400389 }
390
Linus Torvalds1da177e2005-04-16 15:20:36 -0700391 return 0;
392
Guenter Roeck19f2c052012-01-14 13:26:08 -0800393 exit_remove_files:
Jean Delvare75819f02007-06-09 10:11:15 -0400394 sysfs_remove_group(&client->dev.kobj, &ds1621_group);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700395 return err;
396}
397
Jean Delvare70313ea2008-07-16 19:30:11 +0200398static int ds1621_remove(struct i2c_client *client)
Linus Torvalds1da177e2005-04-16 15:20:36 -0700399{
Mark M. Hoffman943b0832005-07-15 21:39:18 -0400400 struct ds1621_data *data = i2c_get_clientdata(client);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700401
Tony Jones1beeffe2007-08-20 13:46:20 -0700402 hwmon_device_unregister(data->hwmon_dev);
Jean Delvarea5ebe662006-09-24 21:24:46 +0200403 sysfs_remove_group(&client->dev.kobj, &ds1621_group);
Mark M. Hoffman943b0832005-07-15 21:39:18 -0400404
Linus Torvalds1da177e2005-04-16 15:20:36 -0700405 return 0;
406}
407
Jean Delvare9202add2009-03-30 21:46:40 +0200408static const struct i2c_device_id ds1621_id[] = {
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700409 { "ds1621", ds1621 },
410 { "ds1625", ds1625 },
Robert Coulson79c1cc12013-05-16 15:10:41 -0700411 { "ds1631", ds1631 },
Robert Coulsoncd6c8a42013-05-08 22:45:53 -0700412 { "ds1721", ds1721 },
Robert Coulson260f81f2013-06-10 18:46:02 -0700413 { "ds1731", ds1731 },
Jean Delvare9202add2009-03-30 21:46:40 +0200414 { }
415};
416MODULE_DEVICE_TABLE(i2c, ds1621_id);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700417
Jean Delvare9202add2009-03-30 21:46:40 +0200418/* This is the driver that will be inserted */
419static struct i2c_driver ds1621_driver = {
420 .class = I2C_CLASS_HWMON,
421 .driver = {
422 .name = "ds1621",
423 },
424 .probe = ds1621_probe,
425 .remove = ds1621_remove,
426 .id_table = ds1621_id,
Jean Delvare9202add2009-03-30 21:46:40 +0200427};
Linus Torvalds1da177e2005-04-16 15:20:36 -0700428
Axel Linf0967ee2012-01-20 15:38:18 +0800429module_i2c_driver(ds1621_driver);
Linus Torvalds1da177e2005-04-16 15:20:36 -0700430
431MODULE_AUTHOR("Christian W. Zuckschwerdt <zany@triq.net>");
432MODULE_DESCRIPTION("DS1621 driver");
433MODULE_LICENSE("GPL");